)]}'
{"doc/source/devref/commit_message_tags.rst":[{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"3b147bf51595fcc2701e4e43e2226d2b2ac63038","unresolved":false,"context_lines":[{"line_number":4,"context_line":"When writing git commit messages for code submissions into Manila, it can be"},{"line_number":5,"context_line":"useful to provide tags in the message for both human consumption as well as"},{"line_number":6,"context_line":"linking to other external resources, such as Launchpad. The tags are placed"},{"line_number":7,"context_line":"on a line on their own and each subsequent tag must be on its own line The"},{"line_number":8,"context_line":"following tags are used in Manila."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- **APIImpact** - Use this tag when the code change modifies a public HTTP"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_23eaba0f","line":7,"updated":"2016-04-25 22:02:20.000000000","message":"its own line. The... forgot the period.","commit_id":"4a949c761afb1e05cb5ce949677a0aa351abf925"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e131c7b8797485fb6825d1e5676ea1f82c162a15","unresolved":false,"context_lines":[{"line_number":4,"context_line":"When writing git commit messages for code submissions into Manila, it can be"},{"line_number":5,"context_line":"useful to provide tags in the message for both human consumption as well as"},{"line_number":6,"context_line":"linking to other external resources, such as Launchpad. The tags are placed"},{"line_number":7,"context_line":"on a line on their own and each subsequent tag must be on its own line The"},{"line_number":8,"context_line":"following tags are used in Manila."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- **APIImpact** - Use this tag when the code change modifies a public HTTP"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_83c2ae83","line":7,"in_reply_to":"1a122d0e_23eaba0f","updated":"2016-04-25 22:05:29.000000000","message":"Whoops! I will add it in the next patch. Thanks, Telles!","commit_id":"4a949c761afb1e05cb5ce949677a0aa351abf925"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"f13deb850a93e5a7ce785d02c075056534c3b33a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"When writing git commit messages for code submissions into Manila, it can be"},{"line_number":5,"context_line":"useful to provide tags in the message for both human consumption as well as"},{"line_number":6,"context_line":"linking to other external resources, such as Launchpad. The tags are placed"},{"line_number":7,"context_line":"on a line on their own and each subsequent tag must be on its own line. The"},{"line_number":8,"context_line":"following tags are used in Manila."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- **APIImpact** - Use this tag when the code change modifies a public HTTP"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_927af222","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":22},"updated":"2016-04-26 07:24:49.000000000","message":"\"Each tag should be placed on a separate line\"?","commit_id":"c96816b8a531243d8a9884f3c86937b38d1580e1"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"7552fd283690eaf1474ce7dbd31635228cb7b569","unresolved":false,"context_lines":[{"line_number":4,"context_line":"When writing git commit messages for code submissions into Manila, it can be"},{"line_number":5,"context_line":"useful to provide tags in the message for both human consumption as well as"},{"line_number":6,"context_line":"linking to other external resources, such as Launchpad. The tags are placed"},{"line_number":7,"context_line":"on a line on their own and each subsequent tag must be on its own line. The"},{"line_number":8,"context_line":"following tags are used in Manila."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- **APIImpact** - Use this tag when the code change modifies a public HTTP"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_7e9c33c0","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":22},"in_reply_to":"1a122d0e_927af222","updated":"2016-04-26 15:28:33.000000000","message":"That wording is better, I\u0027ll change that in the next patch set. Thanks!","commit_id":"c96816b8a531243d8a9884f3c86937b38d1580e1"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"8589df762246454fc450ed22b95a7a5eb5714eb8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"- **Implements:** *blueprint \u003cname_of_blueprint\u003e* - Use this tag when a change"},{"line_number":25,"context_line":"  implements the given blueprint in Launchpad. This will automatically generate"},{"line_number":26,"context_line":"  a link to the blueprint in Gerrit for easy access for reviewers."},{"line_number":27,"context_line":"- **Partial-Fix:** *\u003c#launchpad_bug_id\u003e* - This tag is used when the change"},{"line_number":28,"context_line":"  partially fixes the issue referenced by the Launchpad bug ID given. Use this"},{"line_number":29,"context_line":"  tag when more work is needed to close the bug."},{"line_number":30,"context_line":"- **Related-Bug:** *\u003c#launchpad_bug_id\u003e* - This tag is used when a reference"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_06d98c57","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":15},"updated":"2016-04-25 23:54:03.000000000","message":"\u0027Partial-Fix\u0027 should be \u0027Partial-Bug\u0027  per https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"c96816b8a531243d8a9884f3c86937b38d1580e1"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"7552fd283690eaf1474ce7dbd31635228cb7b569","unresolved":false,"context_lines":[{"line_number":24,"context_line":"- **Implements:** *blueprint \u003cname_of_blueprint\u003e* - Use this tag when a change"},{"line_number":25,"context_line":"  implements the given blueprint in Launchpad. This will automatically generate"},{"line_number":26,"context_line":"  a link to the blueprint in Gerrit for easy access for reviewers."},{"line_number":27,"context_line":"- **Partial-Fix:** *\u003c#launchpad_bug_id\u003e* - This tag is used when the change"},{"line_number":28,"context_line":"  partially fixes the issue referenced by the Launchpad bug ID given. Use this"},{"line_number":29,"context_line":"  tag when more work is needed to close the bug."},{"line_number":30,"context_line":"- **Related-Bug:** *\u003c#launchpad_bug_id\u003e* - This tag is used when a reference"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_de94678c","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":15},"in_reply_to":"1a122d0e_06d98c57","updated":"2016-04-26 15:28:33.000000000","message":"They must have changed that underneath me when I was looking at these yesterday. I\u0027ll update this to reflect the change!","commit_id":"c96816b8a531243d8a9884f3c86937b38d1580e1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"e0eccb4d1f918deab44270adbd90233e98d00983","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  tag when more work is needed to close the bug."},{"line_number":30,"context_line":"- **Related-Bug:** *\u003c#launchpad_bug_id\u003e* - This tag is used when a reference"},{"line_number":31,"context_line":"  to another bug is needed but is not impacted by the current change."},{"line_number":32,"context_line":"- **Trivial-Fix:** - This tag is used when a change provides a simple for an"},{"line_number":33,"context_line":"  issue such that having a Launchpad bug does not need to be created."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Make sure that the **Closes-Bug**, **Partial-Fix**, **Related-Bug**,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_720c76ec","line":32,"range":{"start_line":32,"start_character":61,"end_line":32,"end_character":73},"updated":"2016-04-26 07:19:00.000000000","message":"I believe it should be \"a simple \u003csomething\u003e for\". Maybe \"solution\"?","commit_id":"c96816b8a531243d8a9884f3c86937b38d1580e1"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"7552fd283690eaf1474ce7dbd31635228cb7b569","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  tag when more work is needed to close the bug."},{"line_number":30,"context_line":"- **Related-Bug:** *\u003c#launchpad_bug_id\u003e* - This tag is used when a reference"},{"line_number":31,"context_line":"  to another bug is needed but is not impacted by the current change."},{"line_number":32,"context_line":"- **Trivial-Fix:** - This tag is used when a change provides a simple for an"},{"line_number":33,"context_line":"  issue such that having a Launchpad bug does not need to be created."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Make sure that the **Closes-Bug**, **Partial-Fix**, **Related-Bug**,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_7ed1d356","line":32,"range":{"start_line":32,"start_character":61,"end_line":32,"end_character":73},"in_reply_to":"1a122d0e_720c76ec","updated":"2016-04-26 15:28:33.000000000","message":"Yep, it looks like I forgot a word, I\u0027ll add \"solution\" in the next patch. Good catch!","commit_id":"c96816b8a531243d8a9884f3c86937b38d1580e1"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"8589df762246454fc450ed22b95a7a5eb5714eb8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  tag when more work is needed to close the bug."},{"line_number":30,"context_line":"- **Related-Bug:** *\u003c#launchpad_bug_id\u003e* - This tag is used when a reference"},{"line_number":31,"context_line":"  to another bug is needed but is not impacted by the current change."},{"line_number":32,"context_line":"- **Trivial-Fix:** - This tag is used when a change provides a simple for an"},{"line_number":33,"context_line":"  issue such that having a Launchpad bug does not need to be created."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Make sure that the **Closes-Bug**, **Partial-Fix**, **Related-Bug**,"},{"line_number":36,"context_line":"**blueprint**, and **Change-id** tags are at the very end of the commit"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_46ad449a","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":69},"updated":"2016-04-25 23:54:03.000000000","message":"\u0027Trivial-Fix\u0027 is not referenced in the OpenStack \u0027Commit Message\u0027 wiki - https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references.  So I think this line should be removed.","commit_id":"c96816b8a531243d8a9884f3c86937b38d1580e1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"e0eccb4d1f918deab44270adbd90233e98d00983","unresolved":false,"context_lines":[{"line_number":30,"context_line":"- **Related-Bug:** *\u003c#launchpad_bug_id\u003e* - This tag is used when a reference"},{"line_number":31,"context_line":"  to another bug is needed but is not impacted by the current change."},{"line_number":32,"context_line":"- **Trivial-Fix:** - This tag is used when a change provides a simple for an"},{"line_number":33,"context_line":"  issue such that having a Launchpad bug does not need to be created."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Make sure that the **Closes-Bug**, **Partial-Fix**, **Related-Bug**,"},{"line_number":36,"context_line":"**blueprint**, and **Change-id** tags are at the very end of the commit"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_9293125b","line":33,"range":{"start_line":33,"start_character":1,"end_line":33,"end_character":69},"updated":"2016-04-26 07:19:00.000000000","message":"I would have reworded this, it seems to be a bit hard to comprehend. Maybe \"for a trivial issue which does not require a separate bug in LP.\"? Also a simple example might be helpful here (\"such as typo, unclear message, etc.\").","commit_id":"c96816b8a531243d8a9884f3c86937b38d1580e1"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"e0eccb4d1f918deab44270adbd90233e98d00983","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  tag when more work is needed to close the bug."},{"line_number":30,"context_line":"- **Related-Bug:** *\u003c#launchpad_bug_id\u003e* - This tag is used when a reference"},{"line_number":31,"context_line":"  to another bug is needed but is not impacted by the current change."},{"line_number":32,"context_line":"- **Trivial-Fix:** - This tag is used when a change provides a simple for an"},{"line_number":33,"context_line":"  issue such that having a Launchpad bug does not need to be created."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Make sure that the **Closes-Bug**, **Partial-Fix**, **Related-Bug**,"},{"line_number":36,"context_line":"**blueprint**, and **Change-id** tags are at the very end of the commit"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_921e720a","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":69},"in_reply_to":"1a122d0e_46ad449a","updated":"2016-04-26 07:19:00.000000000","message":"It seems to be used around the project anyway, so probably it is a good idea to provide an official reference for correct usage. Also if we desire to follow the OpenStack Wiki verbatim then we definitely don\u0027t need this document, do we?","commit_id":"c96816b8a531243d8a9884f3c86937b38d1580e1"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"7348490af8530c9f9c04f8ef881b84074324d86d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"- **Related-Bug:** *\u003c#launchpad_bug_id\u003e* - This tag is used when a reference"},{"line_number":31,"context_line":"  to another bug is needed but is not impacted by the current change."},{"line_number":32,"context_line":"- **Trivial-Fix:** - This tag is used when a change provides a simple for an"},{"line_number":33,"context_line":"  issue such that having a Launchpad bug does not need to be created."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Make sure that the **Closes-Bug**, **Partial-Fix**, **Related-Bug**,"},{"line_number":36,"context_line":"**blueprint**, and **Change-id** tags are at the very end of the commit"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_3e475bbd","line":33,"range":{"start_line":33,"start_character":1,"end_line":33,"end_character":69},"in_reply_to":"1a122d0e_7ebb93e5","updated":"2016-04-26 15:33:31.000000000","message":"@Dustin ahh I see - thanks :)","commit_id":"c96816b8a531243d8a9884f3c86937b38d1580e1"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"7552fd283690eaf1474ce7dbd31635228cb7b569","unresolved":false,"context_lines":[{"line_number":30,"context_line":"- **Related-Bug:** *\u003c#launchpad_bug_id\u003e* - This tag is used when a reference"},{"line_number":31,"context_line":"  to another bug is needed but is not impacted by the current change."},{"line_number":32,"context_line":"- **Trivial-Fix:** - This tag is used when a change provides a simple for an"},{"line_number":33,"context_line":"  issue such that having a Launchpad bug does not need to be created."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Make sure that the **Closes-Bug**, **Partial-Fix**, **Related-Bug**,"},{"line_number":36,"context_line":"**blueprint**, and **Change-id** tags are at the very end of the commit"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_7ebb93e5","line":33,"range":{"start_line":33,"start_character":1,"end_line":33,"end_character":69},"in_reply_to":"1a122d0e_9293125b","updated":"2016-04-26 15:28:33.000000000","message":"@Stew, yeah, it\u0027s not referenced in the general OpenStack docs but seems to be used in Manila at the least. I wanted to have this here in Manila\u0027s documentation to provide an \"at-a-glance\" overview of the tags and how they\u0027re used in Manila. \n\n@Alexey, the same thought had occurred to me, but I\u0027d like to have a quick reference available especially for new Manila contributors that does reference the general documentation. I\u0027ll also make the change here to clarify the Trivial-Fix tag. I was hoping that someone would come by and help clarify it for me :)","commit_id":"c96816b8a531243d8a9884f3c86937b38d1580e1"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"7552fd283690eaf1474ce7dbd31635228cb7b569","unresolved":false,"context_lines":[{"line_number":32,"context_line":"- **Trivial-Fix:** - This tag is used when a change provides a simple for an"},{"line_number":33,"context_line":"  issue such that having a Launchpad bug does not need to be created."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Make sure that the **Closes-Bug**, **Partial-Fix**, **Related-Bug**,"},{"line_number":36,"context_line":"**blueprint**, and **Change-id** tags are at the very end of the commit"},{"line_number":37,"context_line":"message. The Gerrit hooks will automatically put the hash at the end of the"},{"line_number":38,"context_line":"commit message. For more information on tags and some examples of good commit"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_decc678b","line":35,"range":{"start_line":35,"start_character":45,"end_line":35,"end_character":48},"updated":"2016-04-26 15:28:33.000000000","message":"I\u0027ll have to change this to \"Partial-Bug\"","commit_id":"c96816b8a531243d8a9884f3c86937b38d1580e1"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"7348490af8530c9f9c04f8ef881b84074324d86d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"- **Trivial-Fix:** - This tag is used when a change provides a simple for an"},{"line_number":33,"context_line":"  issue such that having a Launchpad bug does not need to be created."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Make sure that the **Closes-Bug**, **Partial-Fix**, **Related-Bug**,"},{"line_number":36,"context_line":"**blueprint**, and **Change-id** tags are at the very end of the commit"},{"line_number":37,"context_line":"message. The Gerrit hooks will automatically put the hash at the end of the"},{"line_number":38,"context_line":"commit message. For more information on tags and some examples of good commit"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_def6278e","line":35,"range":{"start_line":35,"start_character":45,"end_line":35,"end_character":48},"in_reply_to":"1a122d0e_decc678b","updated":"2016-04-26 15:33:31.000000000","message":"oh great catch - I missed that :)","commit_id":"c96816b8a531243d8a9884f3c86937b38d1580e1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"93a619e152beeae867396dd0c4a3ea2fce56f837","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Using Commit Message Tags in Manila"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"When writing git commit messages for code submissions into Manila, it can be"},{"line_number":5,"context_line":"useful to provide tags in the message for both human consumption as well as"},{"line_number":6,"context_line":"linking to other external resources, such as Launchpad. Each tag should be"},{"line_number":7,"context_line":"placed on a separate line. The following tags are used in Manila."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_27cf4657","line":4,"range":{"start_line":4,"start_character":59,"end_line":4,"end_character":65},"updated":"2016-04-27 03:06:09.000000000","message":"s/Manila/manila\nhttp://docs.openstack.org/contributor-guide/writing-style/openstack-components.html","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"0200823095df382e98fdf5589d3700dec4e67d9d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Using Commit Message Tags in Manila"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"When writing git commit messages for code submissions into Manila, it can be"},{"line_number":5,"context_line":"useful to provide tags in the message for both human consumption as well as"},{"line_number":6,"context_line":"linking to other external resources, such as Launchpad. Each tag should be"},{"line_number":7,"context_line":"placed on a separate line. The following tags are used in Manila."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_3c0bc725","line":4,"range":{"start_line":4,"start_character":59,"end_line":4,"end_character":65},"in_reply_to":"1a122d0e_27cf4657","updated":"2016-04-27 15:17:03.000000000","message":"OpenStack is weird with proper nouns :) I\u0027ll change it!","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"93a619e152beeae867396dd0c4a3ea2fce56f837","unresolved":false,"context_lines":[{"line_number":4,"context_line":"When writing git commit messages for code submissions into Manila, it can be"},{"line_number":5,"context_line":"useful to provide tags in the message for both human consumption as well as"},{"line_number":6,"context_line":"linking to other external resources, such as Launchpad. Each tag should be"},{"line_number":7,"context_line":"placed on a separate line. The following tags are used in Manila."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- **APIImpact** - Use this tag when the code change modifies a public HTTP"},{"line_number":10,"context_line":"  API interface. This tag indicates that the patch creates, changes, or deletes"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_87d8da1f","line":7,"range":{"start_line":7,"start_character":58,"end_line":7,"end_character":64},"updated":"2016-04-27 03:06:09.000000000","message":"s/Manila/manila","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"0200823095df382e98fdf5589d3700dec4e67d9d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"When writing git commit messages for code submissions into Manila, it can be"},{"line_number":5,"context_line":"useful to provide tags in the message for both human consumption as well as"},{"line_number":6,"context_line":"linking to other external resources, such as Launchpad. Each tag should be"},{"line_number":7,"context_line":"placed on a separate line. The following tags are used in Manila."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- **APIImpact** - Use this tag when the code change modifies a public HTTP"},{"line_number":10,"context_line":"  API interface. This tag indicates that the patch creates, changes, or deletes"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_dc1a936e","line":7,"range":{"start_line":7,"start_character":58,"end_line":7,"end_character":64},"in_reply_to":"1a122d0e_87d8da1f","updated":"2016-04-27 15:17:03.000000000","message":"Same as above, thanks, Jun!","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3be48a92109ad553a9c54dff6553b941f51765e3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- **APIImpact** - Use this tag when the code change modifies a public HTTP"},{"line_number":10,"context_line":"  API interface. This tag indicates that the patch creates, changes, or deletes"},{"line_number":11,"context_line":"  a public API interface."},{"line_number":12,"context_line":"- **Change-id** - This tag is automatically generated by a Gerrit hook and is"},{"line_number":13,"context_line":"  a unique hash that describes the change. This hash should not be changed"},{"line_number":14,"context_line":"  when rebasing as it is used by Gerrit to keep track of the change."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_617f73ab","line":11,"range":{"start_line":11,"start_character":24,"end_line":11,"end_character":25},"updated":"2016-04-26 19:39:42.000000000","message":"APIImpact could be followed by a reason beginning in the next line. If you are touching Manila\u0027s API layer and you are unsure if your change has an impact on the API, use this tag anyway.","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"0200823095df382e98fdf5589d3700dec4e67d9d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- **APIImpact** - Use this tag when the code change modifies a public HTTP"},{"line_number":10,"context_line":"  API interface. This tag indicates that the patch creates, changes, or deletes"},{"line_number":11,"context_line":"  a public API interface."},{"line_number":12,"context_line":"- **Change-id** - This tag is automatically generated by a Gerrit hook and is"},{"line_number":13,"context_line":"  a unique hash that describes the change. This hash should not be changed"},{"line_number":14,"context_line":"  when rebasing as it is used by Gerrit to keep track of the change."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_3272e711","line":11,"range":{"start_line":11,"start_character":24,"end_line":11,"end_character":25},"in_reply_to":"1a122d0e_617f73ab","updated":"2016-04-27 15:17:03.000000000","message":"Good catch, I\u0027ll add the information here in the next patch set.","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3be48a92109ad553a9c54dff6553b941f51765e3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"- **Closes-Bug: | Partial-Bug: | Related-Bug:** *\u003c#launchpad_bug_id\u003e* - These"},{"line_number":16,"context_line":"  tags are used when the change closes, partially closes, or relates to the bug"},{"line_number":17,"context_line":"  referenced by the Launchpad bug ID respectively."},{"line_number":18,"context_line":"- **DocImpact** *\u003creason\u003e* - Use this tag when the code change requires changes or"},{"line_number":19,"context_line":"  additions to documentation in order to be understood. This tag can also be used"},{"line_number":20,"context_line":"  if the documentation is provided along with the patch itself. While not"},{"line_number":21,"context_line":"  required, it is recommended to provide a short description of the documentation"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_6156532b","line":18,"range":{"start_line":18,"start_character":16,"end_line":18,"end_character":26},"updated":"2016-04-26 19:39:42.000000000","message":"Please remove, make this part of your description.. DocImpact should be on a line by its own.","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"0200823095df382e98fdf5589d3700dec4e67d9d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"- **Closes-Bug: | Partial-Bug: | Related-Bug:** *\u003c#launchpad_bug_id\u003e* - These"},{"line_number":16,"context_line":"  tags are used when the change closes, partially closes, or relates to the bug"},{"line_number":17,"context_line":"  referenced by the Launchpad bug ID respectively."},{"line_number":18,"context_line":"- **DocImpact** *\u003creason\u003e* - Use this tag when the code change requires changes or"},{"line_number":19,"context_line":"  additions to documentation in order to be understood. This tag can also be used"},{"line_number":20,"context_line":"  if the documentation is provided along with the patch itself. While not"},{"line_number":21,"context_line":"  required, it is recommended to provide a short description of the documentation"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_324947b8","line":18,"range":{"start_line":18,"start_character":16,"end_line":18,"end_character":26},"in_reply_to":"1a122d0e_6156532b","updated":"2016-04-27 15:17:03.000000000","message":"Will do, I was following what was given in the general documentation. I didn\u0027t really like that either :)","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3be48a92109ad553a9c54dff6553b941f51765e3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  if the documentation is provided along with the patch itself. While not"},{"line_number":21,"context_line":"  required, it is recommended to provide a short description of the documentation"},{"line_number":22,"context_line":"  changes needed or provided for or with the patch. This will also generate a"},{"line_number":23,"context_line":"  bug in the openstack-manuals project for triaging and tracking."},{"line_number":24,"context_line":"- **Implements:** *blueprint \u003cname_of_blueprint\u003e* - Use this tag when a change"},{"line_number":25,"context_line":"  implements the given blueprint in Launchpad. This will automatically generate"},{"line_number":26,"context_line":"  a link to the blueprint in Gerrit for easy access for reviewers."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_a1198b8a","line":23,"range":{"start_line":23,"start_character":9,"end_line":23,"end_character":38},"updated":"2016-04-26 19:39:42.000000000","message":"manila... not openstack-manuals. It can be tagged with openstack-manuals later if we believe it should be fixed there..","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"0200823095df382e98fdf5589d3700dec4e67d9d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  if the documentation is provided along with the patch itself. While not"},{"line_number":21,"context_line":"  required, it is recommended to provide a short description of the documentation"},{"line_number":22,"context_line":"  changes needed or provided for or with the patch. This will also generate a"},{"line_number":23,"context_line":"  bug in the openstack-manuals project for triaging and tracking."},{"line_number":24,"context_line":"- **Implements:** *blueprint \u003cname_of_blueprint\u003e* - Use this tag when a change"},{"line_number":25,"context_line":"  implements the given blueprint in Launchpad. This will automatically generate"},{"line_number":26,"context_line":"  a link to the blueprint in Gerrit for easy access for reviewers."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_92ef7b86","line":23,"range":{"start_line":23,"start_character":9,"end_line":23,"end_character":38},"in_reply_to":"1a122d0e_a1198b8a","updated":"2016-04-27 15:17:03.000000000","message":"I actually didn\u0027t know that. I thought that all of the DocImpact tags generated bugs in openstack-manuals. I\u0027ll update this in the next patch. Thanks!","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"93a619e152beeae867396dd0c4a3ea2fce56f837","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  required, it is recommended to provide a short description of the documentation"},{"line_number":22,"context_line":"  changes needed or provided for or with the patch. This will also generate a"},{"line_number":23,"context_line":"  bug in the openstack-manuals project for triaging and tracking."},{"line_number":24,"context_line":"- **Implements:** *blueprint \u003cname_of_blueprint\u003e* - Use this tag when a change"},{"line_number":25,"context_line":"  implements the given blueprint in Launchpad. This will automatically generate"},{"line_number":26,"context_line":"  a link to the blueprint in Gerrit for easy access for reviewers."},{"line_number":27,"context_line":"- **Trivial-Fix:** - This tag is used for a trivial issue, such as a typo or an"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_47f9a27f","line":24,"range":{"start_line":24,"start_character":14,"end_line":24,"end_character":17},"updated":"2016-04-27 03:06:09.000000000","message":"How about add \"Partially implements:\". such as:\nhttps://review.openstack.org/#/c/240220/","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3be48a92109ad553a9c54dff6553b941f51765e3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"- **Implements:** *blueprint \u003cname_of_blueprint\u003e* - Use this tag when a change"},{"line_number":25,"context_line":"  implements the given blueprint in Launchpad. This will automatically generate"},{"line_number":26,"context_line":"  a link to the blueprint in Gerrit for easy access for reviewers."},{"line_number":27,"context_line":"- **Trivial-Fix:** - This tag is used for a trivial issue, such as a typo or an"},{"line_number":28,"context_line":"  unclear log message, that does not require the creation of a separate bug in"},{"line_number":29,"context_line":"  Launchpad."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_5432f3f2","line":27,"range":{"start_line":27,"start_character":15,"end_line":27,"end_character":16},"updated":"2016-04-26 19:39:42.000000000","message":"remove :","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"0200823095df382e98fdf5589d3700dec4e67d9d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"- **Implements:** *blueprint \u003cname_of_blueprint\u003e* - Use this tag when a change"},{"line_number":25,"context_line":"  implements the given blueprint in Launchpad. This will automatically generate"},{"line_number":26,"context_line":"  a link to the blueprint in Gerrit for easy access for reviewers."},{"line_number":27,"context_line":"- **Trivial-Fix:** - This tag is used for a trivial issue, such as a typo or an"},{"line_number":28,"context_line":"  unclear log message, that does not require the creation of a separate bug in"},{"line_number":29,"context_line":"  Launchpad."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_f2006f36","line":27,"range":{"start_line":27,"start_character":15,"end_line":27,"end_character":16},"in_reply_to":"1a122d0e_5432f3f2","updated":"2016-04-27 15:17:03.000000000","message":"Right, that doesn\u0027t need to be there. I\u0027ll remove.","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3be48a92109ad553a9c54dff6553b941f51765e3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  implements the given blueprint in Launchpad. This will automatically generate"},{"line_number":26,"context_line":"  a link to the blueprint in Gerrit for easy access for reviewers."},{"line_number":27,"context_line":"- **Trivial-Fix:** - This tag is used for a trivial issue, such as a typo or an"},{"line_number":28,"context_line":"  unclear log message, that does not require the creation of a separate bug in"},{"line_number":29,"context_line":"  Launchpad."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Make sure that the **Closes-Bug**, **Partial-Bug**, **Related-Bug**,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_5449535f","line":28,"range":{"start_line":28,"start_character":72,"end_line":28,"end_character":75},"updated":"2016-04-26 19:39:42.000000000","message":"bug or a blueprint","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3be48a92109ad553a9c54dff6553b941f51765e3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  implements the given blueprint in Launchpad. This will automatically generate"},{"line_number":26,"context_line":"  a link to the blueprint in Gerrit for easy access for reviewers."},{"line_number":27,"context_line":"- **Trivial-Fix:** - This tag is used for a trivial issue, such as a typo or an"},{"line_number":28,"context_line":"  unclear log message, that does not require the creation of a separate bug in"},{"line_number":29,"context_line":"  Launchpad."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Make sure that the **Closes-Bug**, **Partial-Bug**, **Related-Bug**,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_b459c737","line":28,"range":{"start_line":28,"start_character":21,"end_line":28,"end_character":22},"updated":"2016-04-26 19:39:42.000000000","message":"or a simple code refactor that doesn\u0027t change existing behavior","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"0200823095df382e98fdf5589d3700dec4e67d9d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  implements the given blueprint in Launchpad. This will automatically generate"},{"line_number":26,"context_line":"  a link to the blueprint in Gerrit for easy access for reviewers."},{"line_number":27,"context_line":"- **Trivial-Fix:** - This tag is used for a trivial issue, such as a typo or an"},{"line_number":28,"context_line":"  unclear log message, that does not require the creation of a separate bug in"},{"line_number":29,"context_line":"  Launchpad."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Make sure that the **Closes-Bug**, **Partial-Bug**, **Related-Bug**,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_32f7875a","line":28,"range":{"start_line":28,"start_character":72,"end_line":28,"end_character":75},"in_reply_to":"1a122d0e_5449535f","updated":"2016-04-27 15:17:03.000000000","message":"Good catch, I\u0027ll add that as well.","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"0200823095df382e98fdf5589d3700dec4e67d9d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  implements the given blueprint in Launchpad. This will automatically generate"},{"line_number":26,"context_line":"  a link to the blueprint in Gerrit for easy access for reviewers."},{"line_number":27,"context_line":"- **Trivial-Fix:** - This tag is used for a trivial issue, such as a typo or an"},{"line_number":28,"context_line":"  unclear log message, that does not require the creation of a separate bug in"},{"line_number":29,"context_line":"  Launchpad."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Make sure that the **Closes-Bug**, **Partial-Bug**, **Related-Bug**,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_729bbf18","line":28,"range":{"start_line":28,"start_character":21,"end_line":28,"end_character":22},"in_reply_to":"1a122d0e_b459c737","updated":"2016-04-27 15:17:03.000000000","message":"Good to know, I\u0027ll add that as well. Thanks!","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"93a619e152beeae867396dd0c4a3ea2fce56f837","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  Launchpad."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Make sure that the **Closes-Bug**, **Partial-Bug**, **Related-Bug**,"},{"line_number":32,"context_line":"**blueprint**, and **Change-id** tags are at the very end of the commit"},{"line_number":33,"context_line":"message. The Gerrit hooks will automatically put the hash at the end of the"},{"line_number":34,"context_line":"commit message. For more information on tags and some examples of good commit"},{"line_number":35,"context_line":"messages, refer to the GitCommitMessages_ documentation."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_e70d4e90","line":32,"range":{"start_line":32,"start_character":2,"end_line":32,"end_character":11},"updated":"2016-04-27 03:06:09.000000000","message":"The \"blueprint\" is not a tag. change to \"Implements\".","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"0200823095df382e98fdf5589d3700dec4e67d9d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  Launchpad."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Make sure that the **Closes-Bug**, **Partial-Bug**, **Related-Bug**,"},{"line_number":32,"context_line":"**blueprint**, and **Change-id** tags are at the very end of the commit"},{"line_number":33,"context_line":"message. The Gerrit hooks will automatically put the hash at the end of the"},{"line_number":34,"context_line":"commit message. For more information on tags and some examples of good commit"},{"line_number":35,"context_line":"messages, refer to the GitCommitMessages_ documentation."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_f91de173","line":32,"range":{"start_line":32,"start_character":2,"end_line":32,"end_character":11},"in_reply_to":"1a122d0e_e70d4e90","updated":"2016-04-27 15:17:03.000000000","message":"Will do, thanks, Jun! I think this is what the general documentation said so I kept it in line with that. I\u0027m starting to think that might need to be updated as well.","commit_id":"a0c9e5b1ea910f573502e403d6defee1dfbe51aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"034c5f6281037dd8baf442eaf415822879cefbaa","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- **Closes-Bug: | Partial-Bug: | Related-Bug:** *\u003c#launchpad_bug_id\u003e* - These"},{"line_number":18,"context_line":"  tags are used when the change closes, partially closes, or relates to the bug"},{"line_number":19,"context_line":"  referenced by the Launchpad bug ID respectively."},{"line_number":20,"context_line":"- **DocImpact**- Use this tag when the code change requires changes or"},{"line_number":21,"context_line":"  additions to documentation in order to be understood. This tag can also be used"},{"line_number":22,"context_line":"  if the documentation is provided along with the patch itself. This will also"},{"line_number":23,"context_line":"  generate a Launchpad bug in manila for triaging and tracking."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_cd693f8e","line":20,"range":{"start_line":20,"start_character":15,"end_line":20,"end_character":16},"updated":"2016-04-27 16:36:26.000000000","message":"this just triggers my OCD, space before  this please:\n\nhttp://docs-draft.openstack.org/09/310009/7/check/gate-manila-docs/56102d8//doc/build/html/devref/commit_message_tags.html","commit_id":"4447317637dba4ee5f780b5de9cd8eafb4c80e1f"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"96437bed018e885a23674cca2d5017d11ad236a0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- **Closes-Bug: | Partial-Bug: | Related-Bug:** *\u003c#launchpad_bug_id\u003e* - These"},{"line_number":18,"context_line":"  tags are used when the change closes, partially closes, or relates to the bug"},{"line_number":19,"context_line":"  referenced by the Launchpad bug ID respectively."},{"line_number":20,"context_line":"- **DocImpact**- Use this tag when the code change requires changes or"},{"line_number":21,"context_line":"  additions to documentation in order to be understood. This tag can also be used"},{"line_number":22,"context_line":"  if the documentation is provided along with the patch itself. This will also"},{"line_number":23,"context_line":"  generate a Launchpad bug in manila for triaging and tracking."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_adeb23db","line":20,"range":{"start_line":20,"start_character":15,"end_line":20,"end_character":16},"in_reply_to":"1a122d0e_cd693f8e","updated":"2016-04-27 16:40:07.000000000","message":"I offed one too many spaces, I\u0027ll add it back!","commit_id":"4447317637dba4ee5f780b5de9cd8eafb4c80e1f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"67be282da2046e45fcea456bf2bc792ab5a28b83","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  when rebasing as it is used by Gerrit to keep track of the change."},{"line_number":17,"context_line":"- **Closes-Bug: | Partial-Bug: | Related-Bug:** *\u003c#launchpad_bug_id\u003e* - These"},{"line_number":18,"context_line":"  tags are used when the change closes, partially closes, or relates to the bug"},{"line_number":19,"context_line":"  referenced by the Launchpad bug ID respectively."},{"line_number":20,"context_line":"- **DocImpact** - Use this tag when the code change requires changes or"},{"line_number":21,"context_line":"  additions to documentation in order to be understood. This tag can also be"},{"line_number":22,"context_line":"  used if the documentation is provided along with the patch itself. This will"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a122d0e_19b9597a","line":19,"range":{"start_line":19,"start_character":49,"end_line":19,"end_character":50},"updated":"2016-05-02 04:02:10.000000000","message":"As you said with \u0027Implements\u0027, you could say something like \u0027This will automatically generate a link to the bug report in Launchpad for easy access for reviewers.\"","commit_id":"97b72b148f81f42e65601c0c4aa72438c43fad43"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"9eb87206a381cab17a95d10f093fa2c385b87372","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  when rebasing as it is used by Gerrit to keep track of the change."},{"line_number":17,"context_line":"- **Closes-Bug: | Partial-Bug: | Related-Bug:** *\u003c#launchpad_bug_id\u003e* - These"},{"line_number":18,"context_line":"  tags are used when the change closes, partially closes, or relates to the bug"},{"line_number":19,"context_line":"  referenced by the Launchpad bug ID respectively."},{"line_number":20,"context_line":"- **DocImpact** - Use this tag when the code change requires changes or"},{"line_number":21,"context_line":"  additions to documentation in order to be understood. This tag can also be"},{"line_number":22,"context_line":"  used if the documentation is provided along with the patch itself. This will"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a122d0e_eca12b97","line":19,"range":{"start_line":19,"start_character":49,"end_line":19,"end_character":50},"in_reply_to":"1a122d0e_19b9597a","updated":"2016-05-02 20:56:34.000000000","message":"Good thinking, I\u0027ll be sure to add that in the next patch. Good catch!","commit_id":"97b72b148f81f42e65601c0c4aa72438c43fad43"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"67be282da2046e45fcea456bf2bc792ab5a28b83","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  this tag when a change implements or partially implements the given blueprint"},{"line_number":26,"context_line":"  in Launchpad. This will automatically generate a link to the blueprint in"},{"line_number":27,"context_line":"  Gerrit for easy access for reviewers."},{"line_number":28,"context_line":"- **Trivial-Fix** - This tag is used for a trivial issue, such as a typo, an"},{"line_number":29,"context_line":"  unclear log message, or a simple code refactor that does not change existing"},{"line_number":30,"context_line":"  behavior which does not require the creation of a separate bug or blueprint"},{"line_number":31,"context_line":"  in Launchpad."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a122d0e_b99145f4","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":15},"updated":"2016-05-02 04:02:10.000000000","message":"I see more occurrences in Gerrit of TrivialFix than Trivial-Fix.  Is this published somewhere else?","commit_id":"97b72b148f81f42e65601c0c4aa72438c43fad43"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45930823b4b44c9efe097e7d2a7bd689d7213491","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  this tag when a change implements or partially implements the given blueprint"},{"line_number":26,"context_line":"  in Launchpad. This will automatically generate a link to the blueprint in"},{"line_number":27,"context_line":"  Gerrit for easy access for reviewers."},{"line_number":28,"context_line":"- **Trivial-Fix** - This tag is used for a trivial issue, such as a typo, an"},{"line_number":29,"context_line":"  unclear log message, or a simple code refactor that does not change existing"},{"line_number":30,"context_line":"  behavior which does not require the creation of a separate bug or blueprint"},{"line_number":31,"context_line":"  in Launchpad."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a122d0e_d6183978","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":15},"in_reply_to":"1a122d0e_0319d522","updated":"2016-05-02 22:19:42.000000000","message":"+1","commit_id":"97b72b148f81f42e65601c0c4aa72438c43fad43"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f2cc25dd1fc1124153f808cb35b7297eaf755a2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  this tag when a change implements or partially implements the given blueprint"},{"line_number":26,"context_line":"  in Launchpad. This will automatically generate a link to the blueprint in"},{"line_number":27,"context_line":"  Gerrit for easy access for reviewers."},{"line_number":28,"context_line":"- **Trivial-Fix** - This tag is used for a trivial issue, such as a typo, an"},{"line_number":29,"context_line":"  unclear log message, or a simple code refactor that does not change existing"},{"line_number":30,"context_line":"  behavior which does not require the creation of a separate bug or blueprint"},{"line_number":31,"context_line":"  in Launchpad."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a122d0e_7de02bfb","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":15},"in_reply_to":"1a122d0e_3d6193a9","updated":"2016-05-02 17:21:46.000000000","message":"However, a lot of people seem to be using Trivial: in the commit message: https://review.openstack.org/#/q/topic:trivial\n\ntrivial-fix:\nhttps://review.openstack.org/#/q/topic:trivial-fix\n\ntrivialfix:\nhttps://review.openstack.org/#/q/topic:trivialfix\n\nTrivialFix:\nhttps://review.openstack.org/#/q/topic:TrivialFix","commit_id":"97b72b148f81f42e65601c0c4aa72438c43fad43"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"9eb87206a381cab17a95d10f093fa2c385b87372","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  this tag when a change implements or partially implements the given blueprint"},{"line_number":26,"context_line":"  in Launchpad. This will automatically generate a link to the blueprint in"},{"line_number":27,"context_line":"  Gerrit for easy access for reviewers."},{"line_number":28,"context_line":"- **Trivial-Fix** - This tag is used for a trivial issue, such as a typo, an"},{"line_number":29,"context_line":"  unclear log message, or a simple code refactor that does not change existing"},{"line_number":30,"context_line":"  behavior which does not require the creation of a separate bug or blueprint"},{"line_number":31,"context_line":"  in Launchpad."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a122d0e_ecd92bf6","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":15},"in_reply_to":"1a122d0e_7de02bfb","updated":"2016-05-02 20:56:34.000000000","message":"So it looks like there isn\u0027t a consensus on which tag should be used. How should we specify that we do it?","commit_id":"97b72b148f81f42e65601c0c4aa72438c43fad43"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ca540c53462176695f4cc2921c8f0c81bd3e14b6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  this tag when a change implements or partially implements the given blueprint"},{"line_number":26,"context_line":"  in Launchpad. This will automatically generate a link to the blueprint in"},{"line_number":27,"context_line":"  Gerrit for easy access for reviewers."},{"line_number":28,"context_line":"- **Trivial-Fix** - This tag is used for a trivial issue, such as a typo, an"},{"line_number":29,"context_line":"  unclear log message, or a simple code refactor that does not change existing"},{"line_number":30,"context_line":"  behavior which does not require the creation of a separate bug or blueprint"},{"line_number":31,"context_line":"  in Launchpad."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a122d0e_3d6193a9","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":15},"in_reply_to":"1a122d0e_b99145f4","updated":"2016-05-02 17:17:38.000000000","message":"This was the mail that started off this flag : http://lists.openstack.org/pipermail/openstack-dev/2014-June/037940.html\n\nHowever, you are right, the proposal was TrivialFix (much like DocImpact, APIImpact, UpgradeImpact etc)","commit_id":"97b72b148f81f42e65601c0c4aa72438c43fad43"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"c06efcac91c399d185804d748a1eff1afd27e5d4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  this tag when a change implements or partially implements the given blueprint"},{"line_number":26,"context_line":"  in Launchpad. This will automatically generate a link to the blueprint in"},{"line_number":27,"context_line":"  Gerrit for easy access for reviewers."},{"line_number":28,"context_line":"- **Trivial-Fix** - This tag is used for a trivial issue, such as a typo, an"},{"line_number":29,"context_line":"  unclear log message, or a simple code refactor that does not change existing"},{"line_number":30,"context_line":"  behavior which does not require the creation of a separate bug or blueprint"},{"line_number":31,"context_line":"  in Launchpad."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a122d0e_0319d522","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":15},"in_reply_to":"1a122d0e_ecd92bf6","updated":"2016-05-02 21:58:19.000000000","message":"I\u0027d go with the original email (TrivialFix).  It\u0027s really no big deal if we have to change it later, so no need to ruminate on it too much.","commit_id":"97b72b148f81f42e65601c0c4aa72438c43fad43"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4db522e180196fb7bede94746b1fedcc37fb1543","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  referenced by the Launchpad bug ID respectively. This will automatically"},{"line_number":20,"context_line":"  generate a link to the bug in Launchpad for easy access for reviewers."},{"line_number":21,"context_line":"- **DocImpact** - Use this tag when the code change requires changes or"},{"line_number":22,"context_line":"  additions to documentation in order to be understood. This tag can also be"},{"line_number":23,"context_line":"  used if the documentation is provided along with the patch itself. This will"},{"line_number":24,"context_line":"  also generate a Launchpad bug in manila for triaging and tracking."},{"line_number":25,"context_line":"- **Implements: | Partially Implements:** *blueprint \u003cname_of_blueprint\u003e* - Use"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_24179b55","line":22,"range":{"start_line":22,"start_character":2,"end_line":22,"end_character":11},"updated":"2016-05-03 18:04:49.000000000","message":"I would prefer using \"updates\".","commit_id":"cf2d5955843edad4e599f7b7e3a8f0cce62f7d2b"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"2ff1eefc10b5de22f1262268d6bb17256b7a3c94","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  referenced by the Launchpad bug ID respectively. This will automatically"},{"line_number":20,"context_line":"  generate a link to the bug in Launchpad for easy access for reviewers."},{"line_number":21,"context_line":"- **DocImpact** - Use this tag when the code change requires changes or"},{"line_number":22,"context_line":"  additions to documentation in order to be understood. This tag can also be"},{"line_number":23,"context_line":"  used if the documentation is provided along with the patch itself. This will"},{"line_number":24,"context_line":"  also generate a Launchpad bug in manila for triaging and tracking."},{"line_number":25,"context_line":"- **Implements: | Partially Implements:** *blueprint \u003cname_of_blueprint\u003e* - Use"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_27cf9db4","line":22,"range":{"start_line":22,"start_character":2,"end_line":22,"end_character":11},"in_reply_to":"1a122d0e_24179b55","updated":"2016-05-03 18:10:22.000000000","message":"Now that I see it, I think I like that version better too. I\u0027ll change it to \"updates\" in the next patch.","commit_id":"cf2d5955843edad4e599f7b7e3a8f0cce62f7d2b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4db522e180196fb7bede94746b1fedcc37fb1543","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  referenced by the Launchpad bug ID respectively. This will automatically"},{"line_number":20,"context_line":"  generate a link to the bug in Launchpad for easy access for reviewers."},{"line_number":21,"context_line":"- **DocImpact** - Use this tag when the code change requires changes or"},{"line_number":22,"context_line":"  additions to documentation in order to be understood. This tag can also be"},{"line_number":23,"context_line":"  used if the documentation is provided along with the patch itself. This will"},{"line_number":24,"context_line":"  also generate a Launchpad bug in manila for triaging and tracking."},{"line_number":25,"context_line":"- **Implements: | Partially Implements:** *blueprint \u003cname_of_blueprint\u003e* - Use"},{"line_number":26,"context_line":"  this tag when a change implements or partially implements the given blueprint"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_0701c104","line":23,"range":{"start_line":22,"start_character":56,"end_line":23,"end_character":68},"updated":"2016-05-03 18:04:49.000000000","message":"I am curious, if the doc is provided, why would we allow the system to automatically open a bug?","commit_id":"cf2d5955843edad4e599f7b7e3a8f0cce62f7d2b"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"2ff1eefc10b5de22f1262268d6bb17256b7a3c94","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  referenced by the Launchpad bug ID respectively. This will automatically"},{"line_number":20,"context_line":"  generate a link to the bug in Launchpad for easy access for reviewers."},{"line_number":21,"context_line":"- **DocImpact** - Use this tag when the code change requires changes or"},{"line_number":22,"context_line":"  additions to documentation in order to be understood. This tag can also be"},{"line_number":23,"context_line":"  used if the documentation is provided along with the patch itself. This will"},{"line_number":24,"context_line":"  also generate a Launchpad bug in manila for triaging and tracking."},{"line_number":25,"context_line":"- **Implements: | Partially Implements:** *blueprint \u003cname_of_blueprint\u003e* - Use"},{"line_number":26,"context_line":"  this tag when a change implements or partially implements the given blueprint"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_070701ca","line":23,"range":{"start_line":22,"start_character":56,"end_line":23,"end_character":68},"in_reply_to":"1a122d0e_0701c104","updated":"2016-05-03 18:10:22.000000000","message":"That\u0027s a good question, and one I don\u0027t have an answer to. I suppose that it\u0027d be added to the system only to be closed by the committer as they would be providing the doc changes required by the bug.","commit_id":"cf2d5955843edad4e599f7b7e3a8f0cce62f7d2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f133bd13509b9e7af6dc34d135177b13538862eb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  referenced by the Launchpad bug ID respectively. This will automatically"},{"line_number":20,"context_line":"  generate a link to the bug in Launchpad for easy access for reviewers."},{"line_number":21,"context_line":"- **DocImpact** - Use this tag when the code change requires changes or"},{"line_number":22,"context_line":"  additions to documentation in order to be understood. This tag can also be"},{"line_number":23,"context_line":"  used if the documentation is provided along with the patch itself. This will"},{"line_number":24,"context_line":"  also generate a Launchpad bug in manila for triaging and tracking."},{"line_number":25,"context_line":"- **Implements: | Partially Implements:** *blueprint \u003cname_of_blueprint\u003e* - Use"},{"line_number":26,"context_line":"  this tag when a change implements or partially implements the given blueprint"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_07d2615b","line":23,"range":{"start_line":22,"start_character":56,"end_line":23,"end_character":68},"in_reply_to":"1a122d0e_0701c104","updated":"2016-05-03 18:06:37.000000000","message":"The automation helps us with the tracking.. If all necessary documentation is added with the original patch, this flag isn\u0027t necessary.. but i would rather have the flag and then close the generated bug, rather than decide on my own whether all documentation has been added :)","commit_id":"cf2d5955843edad4e599f7b7e3a8f0cce62f7d2b"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"11c46a5dabc3e3b3765db5f6bef423c4572ef416","unresolved":false,"context_lines":[{"line_number":7,"context_line":"placed on a separate line. The following tags are used in manila."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- **APIImpact** - Use this tag when the code change modifies a public HTTP"},{"line_number":10,"context_line":"  API interface. This tag indicates that the patch creates, changes, or deletes"},{"line_number":11,"context_line":"  a public API interface. The tag could be followed by a reason beginning on"},{"line_number":12,"context_line":"  the next line. If you are touching manila\u0027s API layer and you are unsure if"},{"line_number":13,"context_line":"  your change has an impact on the API, use this tag anyway."},{"line_number":14,"context_line":"- **Change-id** - This tag is automatically generated by a Gerrit hook and is"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a122d0e_90aaf783","line":11,"range":{"start_line":10,"start_character":16,"end_line":11,"end_character":25},"updated":"2016-05-04 17:12:23.000000000","message":"This flag should be used when not only the interface changes, but also its behavior. Shouldn\u0027t this be included here?\n\n\nFrom the openstack doc: The APIImpact line contains the string APIImpact, and a comment about why the change impacts a public HTTP API. Put APIImpact on a line by itself. Use this flag to indicate that the patch creates, updates, or deletes a public HTTP API or causes the behavior of a public HTTP API to change.","commit_id":"0dad036b04da143e360af519a1bb0be51124e09e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86123fd9475132565407b4e17179439b3b0664e1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"placed on a separate line. The following tags are used in manila."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- **APIImpact** - Use this tag when the code change modifies a public HTTP"},{"line_number":10,"context_line":"  API interface. This tag indicates that the patch creates, changes, or deletes"},{"line_number":11,"context_line":"  a public API interface. The tag could be followed by a reason beginning on"},{"line_number":12,"context_line":"  the next line. If you are touching manila\u0027s API layer and you are unsure if"},{"line_number":13,"context_line":"  your change has an impact on the API, use this tag anyway."},{"line_number":14,"context_line":"- **Change-id** - This tag is automatically generated by a Gerrit hook and is"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a122d0e_30b843c7","line":11,"range":{"start_line":10,"start_character":16,"end_line":11,"end_character":25},"in_reply_to":"1a122d0e_90aaf783","updated":"2016-05-04 17:13:41.000000000","message":"+1 \n\nYou\u0027re right Tiago. Good catch!","commit_id":"0dad036b04da143e360af519a1bb0be51124e09e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"c8112963b5b6a1bf47795dd9b338da5cbb7eef4d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"placed on a separate line. The following tags are used in manila."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- **APIImpact** - Use this tag when the code change modifies a public HTTP"},{"line_number":10,"context_line":"  API interface. This tag indicates that the patch creates, changes, or deletes"},{"line_number":11,"context_line":"  a public API interface. The tag could be followed by a reason beginning on"},{"line_number":12,"context_line":"  the next line. If you are touching manila\u0027s API layer and you are unsure if"},{"line_number":13,"context_line":"  your change has an impact on the API, use this tag anyway."},{"line_number":14,"context_line":"- **Change-id** - This tag is automatically generated by a Gerrit hook and is"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a122d0e_d3959988","line":11,"range":{"start_line":10,"start_character":16,"end_line":11,"end_character":25},"in_reply_to":"1a122d0e_90aaf783","updated":"2016-05-04 17:24:38.000000000","message":"Good catch, Tiago! I\u0027ll be sure to add that in the next update to the patch to clarify that the tag would also apply to a behavior change to a public API interface. Thanks!","commit_id":"0dad036b04da143e360af519a1bb0be51124e09e"}]}
