)]}'
{"manila/share/drivers/huawei/v3/connection.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4413ba507209d0d05a4425234f034e3d9e75217e","unresolved":false,"context_lines":[{"line_number":649,"context_line":"            return"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":652,"context_line":"        # Huawei array use * to represent IP addresses of all clients"},{"line_number":653,"context_line":"        if (share_proto \u003d\u003d \u0027NFS\u0027 and access_type \u003d\u003d \u0027ip\u0027 and"},{"line_number":654,"context_line":"                access_to \u003d\u003d \u00270.0.0.0\u0027):"},{"line_number":655,"context_line":"            access_to \u003d \u0027*\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_24dffc0d","line":652,"range":{"start_line":652,"start_character":23,"end_line":652,"end_character":26},"updated":"2016-04-29 08:57:27.000000000","message":"uses","commit_id":"d33745dac1637661368d10361ed2ca9c9ab0a187"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"6ef2007714f953ce86d9343bb0cced43a2ce5d0f","unresolved":false,"context_lines":[{"line_number":649,"context_line":"            return"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":652,"context_line":"        # Huawei array use * to represent IP addresses of all clients"},{"line_number":653,"context_line":"        if (share_proto \u003d\u003d \u0027NFS\u0027 and access_type \u003d\u003d \u0027ip\u0027 and"},{"line_number":654,"context_line":"                access_to \u003d\u003d \u00270.0.0.0\u0027):"},{"line_number":655,"context_line":"            access_to \u003d \u0027*\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_1d191689","line":652,"range":{"start_line":652,"start_character":23,"end_line":652,"end_character":26},"in_reply_to":"1a122d0e_24dffc0d","updated":"2016-06-22 03:02:18.000000000","message":"Done","commit_id":"d33745dac1637661368d10361ed2ca9c9ab0a187"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4413ba507209d0d05a4425234f034e3d9e75217e","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":652,"context_line":"        # Huawei array use * to represent IP addresses of all clients"},{"line_number":653,"context_line":"        if (share_proto \u003d\u003d \u0027NFS\u0027 and access_type \u003d\u003d \u0027ip\u0027 and"},{"line_number":654,"context_line":"                access_to \u003d\u003d \u00270.0.0.0\u0027):"},{"line_number":655,"context_line":"            access_to \u003d \u0027*\u0027"},{"line_number":656,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_url_type)"},{"line_number":657,"context_line":"        if not share:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_84c7f043","line":654,"range":{"start_line":654,"start_character":30,"end_line":654,"end_character":37},"updated":"2016-04-29 08:57:27.000000000","message":"What if you get 0.0.0.0/0?","commit_id":"d33745dac1637661368d10361ed2ca9c9ab0a187"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"45666968929a326233d3fe1394f9337a4566967e","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":652,"context_line":"        # Huawei array use * to represent IP addresses of all clients"},{"line_number":653,"context_line":"        if (share_proto \u003d\u003d \u0027NFS\u0027 and access_type \u003d\u003d \u0027ip\u0027 and"},{"line_number":654,"context_line":"                access_to \u003d\u003d \u00270.0.0.0\u0027):"},{"line_number":655,"context_line":"            access_to \u003d \u0027*\u0027"},{"line_number":656,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_url_type)"},{"line_number":657,"context_line":"        if not share:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_7b434e42","line":654,"range":{"start_line":654,"start_character":30,"end_line":654,"end_character":37},"in_reply_to":"1a122d0e_84c7f043","updated":"2016-04-29 10:11:47.000000000","message":"It should get exactly range. All possible values:\n\n0.0.0.0/0\n0.0.0.0/0.0.0.0\n\nWhen \n0.0.0.0 is 0.0.0.0/255.255.255.255","commit_id":"d33745dac1637661368d10361ed2ca9c9ab0a187"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4413ba507209d0d05a4425234f034e3d9e75217e","unresolved":false,"context_lines":[{"line_number":694,"context_line":"                access_level \u003d constants.ACCESS_NFS_RW"},{"line_number":695,"context_line":"            else:"},{"line_number":696,"context_line":"                access_level \u003d constants.ACCESS_NFS_RO"},{"line_number":697,"context_line":"            # Huawei array use * to represent IP addresses of all clients"},{"line_number":698,"context_line":"            if access_to \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":699,"context_line":"                access_to \u003d \u0027*\u0027"},{"line_number":700,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_64e574da","line":697,"range":{"start_line":697,"start_character":27,"end_line":697,"end_character":30},"updated":"2016-04-29 08:57:27.000000000","message":"uses","commit_id":"d33745dac1637661368d10361ed2ca9c9ab0a187"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"6ef2007714f953ce86d9343bb0cced43a2ce5d0f","unresolved":false,"context_lines":[{"line_number":694,"context_line":"                access_level \u003d constants.ACCESS_NFS_RW"},{"line_number":695,"context_line":"            else:"},{"line_number":696,"context_line":"                access_level \u003d constants.ACCESS_NFS_RO"},{"line_number":697,"context_line":"            # Huawei array use * to represent IP addresses of all clients"},{"line_number":698,"context_line":"            if access_to \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":699,"context_line":"                access_to \u003d \u0027*\u0027"},{"line_number":700,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_5d139e66","line":697,"range":{"start_line":697,"start_character":27,"end_line":697,"end_character":30},"in_reply_to":"1a122d0e_64e574da","updated":"2016-06-22 03:02:18.000000000","message":"Done","commit_id":"d33745dac1637661368d10361ed2ca9c9ab0a187"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4413ba507209d0d05a4425234f034e3d9e75217e","unresolved":false,"context_lines":[{"line_number":695,"context_line":"            else:"},{"line_number":696,"context_line":"                access_level \u003d constants.ACCESS_NFS_RO"},{"line_number":697,"context_line":"            # Huawei array use * to represent IP addresses of all clients"},{"line_number":698,"context_line":"            if access_to \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":699,"context_line":"                access_to \u003d \u0027*\u0027"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        elif share_proto \u003d\u003d \u0027CIFS\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_a4d30c03","line":698,"range":{"start_line":698,"start_character":29,"end_line":698,"end_character":36},"updated":"2016-04-29 08:57:27.000000000","message":"what if you get the subnet?","commit_id":"d33745dac1637661368d10361ed2ca9c9ab0a187"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"6ef2007714f953ce86d9343bb0cced43a2ce5d0f","unresolved":false,"context_lines":[{"line_number":695,"context_line":"            else:"},{"line_number":696,"context_line":"                access_level \u003d constants.ACCESS_NFS_RO"},{"line_number":697,"context_line":"            # Huawei array use * to represent IP addresses of all clients"},{"line_number":698,"context_line":"            if access_to \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":699,"context_line":"                access_to \u003d \u0027*\u0027"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        elif share_proto \u003d\u003d \u0027CIFS\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_33808346","line":698,"range":{"start_line":698,"start_character":29,"end_line":698,"end_character":36},"in_reply_to":"1a122d0e_5bac92ec","updated":"2016-06-22 03:02:18.000000000","message":"This change is to provide a way to add access of all IPs.\nI just use \u00270.0.0.0\u0027 to represent all IPs.\nHow should I deal like \u00270.0.0.0/16\u0027 or \u00270.0.0.0/24\u0027?\nI dont\u0027t think it\u0027s a good idea to translate \u00270.0.0.0/16\u0027 to \u0027*\u0027.","commit_id":"d33745dac1637661368d10361ed2ca9c9ab0a187"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"45666968929a326233d3fe1394f9337a4566967e","unresolved":false,"context_lines":[{"line_number":695,"context_line":"            else:"},{"line_number":696,"context_line":"                access_level \u003d constants.ACCESS_NFS_RO"},{"line_number":697,"context_line":"            # Huawei array use * to represent IP addresses of all clients"},{"line_number":698,"context_line":"            if access_to \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":699,"context_line":"                access_to \u003d \u0027*\u0027"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        elif share_proto \u003d\u003d \u0027CIFS\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_5bac92ec","line":698,"range":{"start_line":698,"start_character":29,"end_line":698,"end_character":36},"in_reply_to":"1a122d0e_a4d30c03","updated":"2016-04-29 10:11:47.000000000","message":"Actually, driver should be able to handle subnets in general. Not only specific one.","commit_id":"d33745dac1637661368d10361ed2ca9c9ab0a187"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d6cd2a739dc88e4acf093eda0612f6239e4f6a5e","unresolved":false,"context_lines":[{"line_number":656,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":657,"context_line":"        # Huawei array uses * to represent IP addresses of all clients"},{"line_number":658,"context_line":"        if (share_proto \u003d\u003d \u0027NFS\u0027 and access_type \u003d\u003d \u0027ip\u0027 and"},{"line_number":659,"context_line":"                access_to \u003d\u003d \u00270.0.0.0\u0027):"},{"line_number":660,"context_line":"            access_to \u003d \u0027*\u0027"},{"line_number":661,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_url_type)"},{"line_number":662,"context_line":"        if not share:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_9522cdff","line":659,"range":{"start_line":659,"start_character":29,"end_line":659,"end_character":38},"updated":"2016-06-23 13:48:05.000000000","message":"0.0.0.0 is network address. You should cover case of CIDR - 0.0.0.0/0","commit_id":"0ce251557c166a2e37d6985a39f6b391d6092125"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3f97076ba19f27b8791798539136407d23102bd9","unresolved":false,"context_lines":[{"line_number":655,"context_line":""},{"line_number":656,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":657,"context_line":"        # Huawei array uses * to represent IP addresses of all clients"},{"line_number":658,"context_line":"        if (share_proto \u003d\u003d \u0027NFS\u0027 and access_type \u003d\u003d \u0027ip\u0027 and"},{"line_number":659,"context_line":"                access_to \u003d\u003d \u00270.0.0.0/0\u0027):"},{"line_number":660,"context_line":"            access_to \u003d \u0027*\u0027"},{"line_number":661,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_url_type)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_ebebaa10","line":658,"range":{"start_line":658,"start_character":12,"end_line":658,"end_character":56},"updated":"2016-06-28 13:38:06.000000000","message":"all string comparisons should be case insensitive..","commit_id":"b8a623d110edeae59e370d948a77d72e3348bc1a"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"b7e4220d66c8e083cb4a969828eaa795e8053390","unresolved":false,"context_lines":[{"line_number":655,"context_line":""},{"line_number":656,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":657,"context_line":"        # Huawei array uses * to represent IP addresses of all clients"},{"line_number":658,"context_line":"        if (share_proto \u003d\u003d \u0027NFS\u0027 and access_type \u003d\u003d \u0027ip\u0027 and"},{"line_number":659,"context_line":"                access_to \u003d\u003d \u00270.0.0.0/0\u0027):"},{"line_number":660,"context_line":"            access_to \u003d \u0027*\u0027"},{"line_number":661,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_url_type)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_afd4ba1f","line":658,"range":{"start_line":658,"start_character":12,"end_line":658,"end_character":56},"in_reply_to":"3aaa91ec_50ea33ad","updated":"2016-07-13 01:50:52.000000000","message":"Only lowercase of \u0027access_type\u0027 are allowed by API.","commit_id":"b8a623d110edeae59e370d948a77d72e3348bc1a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fec3cacafe0e2d7a00314733b8a8a24332904ee9","unresolved":false,"context_lines":[{"line_number":655,"context_line":""},{"line_number":656,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":657,"context_line":"        # Huawei array uses * to represent IP addresses of all clients"},{"line_number":658,"context_line":"        if (share_proto \u003d\u003d \u0027NFS\u0027 and access_type \u003d\u003d \u0027ip\u0027 and"},{"line_number":659,"context_line":"                access_to \u003d\u003d \u00270.0.0.0/0\u0027):"},{"line_number":660,"context_line":"            access_to \u003d \u0027*\u0027"},{"line_number":661,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_url_type)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_50ea33ad","line":658,"range":{"start_line":658,"start_character":12,"end_line":658,"end_character":56},"in_reply_to":"3aaa91ec_ebebaa10","updated":"2016-06-29 11:22:01.000000000","message":"\"share_proto\" is uppercase always, it is changed by API. But not sure about access type. So, better to implement case insensitive condition and cover different cases in unit tests.","commit_id":"b8a623d110edeae59e370d948a77d72e3348bc1a"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"b7e4220d66c8e083cb4a969828eaa795e8053390","unresolved":false,"context_lines":[{"line_number":655,"context_line":""},{"line_number":656,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":657,"context_line":"        # Huawei array uses * to represent IP addresses of all clients"},{"line_number":658,"context_line":"        if (share_proto \u003d\u003d \u0027NFS\u0027 and access_type \u003d\u003d \u0027ip\u0027 and"},{"line_number":659,"context_line":"                access_to \u003d\u003d \u00270.0.0.0/0\u0027):"},{"line_number":660,"context_line":"            access_to \u003d \u0027*\u0027"},{"line_number":661,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_url_type)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_ef06c21a","line":658,"range":{"start_line":658,"start_character":12,"end_line":658,"end_character":56},"in_reply_to":"3aaa91ec_ebebaa10","updated":"2016-07-13 01:50:52.000000000","message":"\u0027share_proto\u0027 and \u0027access_type\u0027 are case sensitive","commit_id":"b8a623d110edeae59e370d948a77d72e3348bc1a"}],"manila/tests/share/drivers/huawei/test_huawei_nas.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d6cd2a739dc88e4acf093eda0612f6239e4f6a5e","unresolved":false,"context_lines":[{"line_number":2371,"context_line":"    def test_access_nfs_all_ip(self):"},{"line_number":2372,"context_line":"        access_all \u003d {"},{"line_number":2373,"context_line":"            \u0027access_type\u0027: \u0027ip\u0027,"},{"line_number":2374,"context_line":"            \u0027access_to\u0027: \u00270.0.0.0\u0027,"},{"line_number":2375,"context_line":"            \u0027access_level\u0027: \u0027rw\u0027,"},{"line_number":2376,"context_line":"        }"},{"line_number":2377,"context_line":"        self.driver.plugin.helper.login()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_b5554951","line":2374,"range":{"start_line":2374,"start_character":25,"end_line":2374,"end_character":35},"updated":"2016-06-23 13:48:05.000000000","message":"Should test 0.0.0.0/0 case too.","commit_id":"0ce251557c166a2e37d6985a39f6b391d6092125"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"230f494e75aee2c859909b38d3d2555cdaad5b93","unresolved":false,"context_lines":[{"line_number":2378,"context_line":"        with mock.patch.object(self.driver.plugin.helper,"},{"line_number":2379,"context_line":"                               \u0027_get_access_from_share\u0027) as mock_call:"},{"line_number":2380,"context_line":"            mock_call.return_value \u003d None"},{"line_number":2381,"context_line":"            self.driver.allow_access(self._context,"},{"line_number":2382,"context_line":"                                     self.share_nfs,"},{"line_number":2383,"context_line":"                                     access_all,"},{"line_number":2384,"context_line":"                                     self.share_server)"},{"line_number":2385,"context_line":"            mock_call.assert_called_with(\u00271\u0027, \u0027*\u0027, \u0027NFS\u0027)"},{"line_number":2386,"context_line":"            self.driver.deny_access(self._context, self.share_nfs,"},{"line_number":2387,"context_line":"                                    access_all, self.share_server)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_1ba259fd","line":2384,"range":{"start_line":2381,"start_character":12,"end_line":2384,"end_character":55},"updated":"2016-06-24 10:51:28.000000000","message":"It is more readable when tested command is separated with empty lines below and above.","commit_id":"7a78cd4dec0c3e6bb0da565b1046bcd8bd119741"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"65f55b798d0e7f24c80d635867427d000b0bebb0","unresolved":false,"context_lines":[{"line_number":2378,"context_line":"        with mock.patch.object(self.driver.plugin.helper,"},{"line_number":2379,"context_line":"                               \u0027_get_access_from_share\u0027) as mock_call:"},{"line_number":2380,"context_line":"            mock_call.return_value \u003d None"},{"line_number":2381,"context_line":"            self.driver.allow_access(self._context,"},{"line_number":2382,"context_line":"                                     self.share_nfs,"},{"line_number":2383,"context_line":"                                     access_all,"},{"line_number":2384,"context_line":"                                     self.share_server)"},{"line_number":2385,"context_line":"            mock_call.assert_called_with(\u00271\u0027, \u0027*\u0027, \u0027NFS\u0027)"},{"line_number":2386,"context_line":"            self.driver.deny_access(self._context, self.share_nfs,"},{"line_number":2387,"context_line":"                                    access_all, self.share_server)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_d8c1bee5","line":2384,"range":{"start_line":2381,"start_character":12,"end_line":2384,"end_character":55},"in_reply_to":"3aaa91ec_1ba259fd","updated":"2016-06-27 01:46:54.000000000","message":"Done","commit_id":"7a78cd4dec0c3e6bb0da565b1046bcd8bd119741"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"230f494e75aee2c859909b38d3d2555cdaad5b93","unresolved":false,"context_lines":[{"line_number":2368,"context_line":"                          self.driver.update_access, self._context,"},{"line_number":2369,"context_line":"                          self.share_nfs, rules, None, None, self.share_server)"},{"line_number":2370,"context_line":""},{"line_number":2371,"context_line":"    def test_access_nfs_all_ip(self):"},{"line_number":2372,"context_line":"        access_all \u003d {"},{"line_number":2373,"context_line":"            \u0027access_type\u0027: \u0027ip\u0027,"},{"line_number":2374,"context_line":"            \u0027access_to\u0027: \u00270.0.0.0/0\u0027,"},{"line_number":2375,"context_line":"            \u0027access_level\u0027: \u0027rw\u0027,"},{"line_number":2376,"context_line":"        }"},{"line_number":2377,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":2378,"context_line":"        with mock.patch.object(self.driver.plugin.helper,"},{"line_number":2379,"context_line":"                               \u0027_get_access_from_share\u0027) as mock_call:"},{"line_number":2380,"context_line":"            mock_call.return_value \u003d None"},{"line_number":2381,"context_line":"            self.driver.allow_access(self._context,"},{"line_number":2382,"context_line":"                                     self.share_nfs,"},{"line_number":2383,"context_line":"                                     access_all,"},{"line_number":2384,"context_line":"                                     self.share_server)"},{"line_number":2385,"context_line":"            mock_call.assert_called_with(\u00271\u0027, \u0027*\u0027, \u0027NFS\u0027)"},{"line_number":2386,"context_line":"            self.driver.deny_access(self._context, self.share_nfs,"},{"line_number":2387,"context_line":"                                    access_all, self.share_server)"},{"line_number":2388,"context_line":"            mock_call.assert_called_with(\u00271\u0027, \u0027*\u0027, \u0027NFS\u0027)"},{"line_number":2389,"context_line":""},{"line_number":2390,"context_line":"    def test_get_share_client_type_fail(self):"},{"line_number":2391,"context_line":"        share_proto \u003d \u0027fake_proto\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_1b7b798d","line":2388,"range":{"start_line":2371,"start_character":4,"end_line":2388,"end_character":57},"updated":"2016-06-24 10:51:28.000000000","message":"You combined two cases in one test - \"allow\" and \"deny\" access. Please, separate them.","commit_id":"7a78cd4dec0c3e6bb0da565b1046bcd8bd119741"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"65f55b798d0e7f24c80d635867427d000b0bebb0","unresolved":false,"context_lines":[{"line_number":2368,"context_line":"                          self.driver.update_access, self._context,"},{"line_number":2369,"context_line":"                          self.share_nfs, rules, None, None, self.share_server)"},{"line_number":2370,"context_line":""},{"line_number":2371,"context_line":"    def test_access_nfs_all_ip(self):"},{"line_number":2372,"context_line":"        access_all \u003d {"},{"line_number":2373,"context_line":"            \u0027access_type\u0027: \u0027ip\u0027,"},{"line_number":2374,"context_line":"            \u0027access_to\u0027: \u00270.0.0.0/0\u0027,"},{"line_number":2375,"context_line":"            \u0027access_level\u0027: \u0027rw\u0027,"},{"line_number":2376,"context_line":"        }"},{"line_number":2377,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":2378,"context_line":"        with mock.patch.object(self.driver.plugin.helper,"},{"line_number":2379,"context_line":"                               \u0027_get_access_from_share\u0027) as mock_call:"},{"line_number":2380,"context_line":"            mock_call.return_value \u003d None"},{"line_number":2381,"context_line":"            self.driver.allow_access(self._context,"},{"line_number":2382,"context_line":"                                     self.share_nfs,"},{"line_number":2383,"context_line":"                                     access_all,"},{"line_number":2384,"context_line":"                                     self.share_server)"},{"line_number":2385,"context_line":"            mock_call.assert_called_with(\u00271\u0027, \u0027*\u0027, \u0027NFS\u0027)"},{"line_number":2386,"context_line":"            self.driver.deny_access(self._context, self.share_nfs,"},{"line_number":2387,"context_line":"                                    access_all, self.share_server)"},{"line_number":2388,"context_line":"            mock_call.assert_called_with(\u00271\u0027, \u0027*\u0027, \u0027NFS\u0027)"},{"line_number":2389,"context_line":""},{"line_number":2390,"context_line":"    def test_get_share_client_type_fail(self):"},{"line_number":2391,"context_line":"        share_proto \u003d \u0027fake_proto\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_78b36a98","line":2388,"range":{"start_line":2371,"start_character":4,"end_line":2388,"end_character":57},"in_reply_to":"3aaa91ec_1b7b798d","updated":"2016-06-27 01:46:54.000000000","message":"Done","commit_id":"7a78cd4dec0c3e6bb0da565b1046bcd8bd119741"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fec3cacafe0e2d7a00314733b8a8a24332904ee9","unresolved":false,"context_lines":[{"line_number":2368,"context_line":"                          self.driver.update_access, self._context,"},{"line_number":2369,"context_line":"                          self.share_nfs, rules, None, None, self.share_server)"},{"line_number":2370,"context_line":""},{"line_number":2371,"context_line":"    def test_allow_access_nfs_all_ip(self):"},{"line_number":2372,"context_line":"        access_all \u003d {"},{"line_number":2373,"context_line":"            \u0027access_type\u0027: \u0027ip\u0027,"},{"line_number":2374,"context_line":"            \u0027access_to\u0027: \u00270.0.0.0/0\u0027,"},{"line_number":2375,"context_line":"            \u0027access_level\u0027: \u0027rw\u0027,"},{"line_number":2376,"context_line":"        }"},{"line_number":2377,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":2378,"context_line":"        with mock.patch.object(self.driver.plugin.helper,"},{"line_number":2379,"context_line":"                               \u0027_get_access_from_share\u0027) as mock_call:"},{"line_number":2380,"context_line":"            mock_call.return_value \u003d None"},{"line_number":2381,"context_line":""},{"line_number":2382,"context_line":"            self.driver.allow_access(self._context, self.share_nfs,"},{"line_number":2383,"context_line":"                                     access_all, self.share_server)"},{"line_number":2384,"context_line":""},{"line_number":2385,"context_line":"            mock_call.assert_called_with(\u00271\u0027, \u0027*\u0027, \u0027NFS\u0027)"},{"line_number":2386,"context_line":""},{"line_number":2387,"context_line":"    def test_deny_access_nfs_all_ip(self):"},{"line_number":2388,"context_line":"        access_all \u003d {"},{"line_number":2389,"context_line":"            \u0027access_type\u0027: \u0027ip\u0027,"},{"line_number":2390,"context_line":"            \u0027access_to\u0027: \u00270.0.0.0/0\u0027,"},{"line_number":2391,"context_line":"            \u0027access_level\u0027: \u0027rw\u0027,"},{"line_number":2392,"context_line":"        }"},{"line_number":2393,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":2394,"context_line":"        with mock.patch.object(self.driver.plugin.helper,"},{"line_number":2395,"context_line":"                               \u0027_get_access_from_share\u0027) as mock_call:"},{"line_number":2396,"context_line":"            mock_call.return_value \u003d None"},{"line_number":2397,"context_line":""},{"line_number":2398,"context_line":"            self.driver.deny_access(self._context, self.share_nfs,"},{"line_number":2399,"context_line":"                                    access_all, self.share_server)"},{"line_number":2400,"context_line":""},{"line_number":2401,"context_line":"            mock_call.assert_called_with(\u00271\u0027, \u0027*\u0027, \u0027NFS\u0027)"},{"line_number":2402,"context_line":""},{"line_number":2403,"context_line":"    def test_get_share_client_type_fail(self):"},{"line_number":2404,"context_line":"        share_proto \u003d \u0027fake_proto\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_b57709d3","line":2401,"range":{"start_line":2371,"start_character":4,"end_line":2401,"end_character":57},"updated":"2016-06-29 11:22:01.000000000","message":"Two separate tests does not mean use \"copy-paste\". It could be written as following:\n\n\"\"\"\n\n@ddt.ddt\nclass FOO(object):\n\n    @ddt.data(\n        (True, \"ip\"), (True, \"iP\"), (True, \"Ip\"), (True, \"IP\"),\n        (False, \"ip\"), (False, \"Ip\"), (False, \"iP\"), (False, \"IP\"),\n    )\n    @ddt.unpack\n    def test_nfs_access_for_all_ip_addresses(self, is_allow, access_type):\n        mock_get_access \u003d self.mock_object(\n            self.driver.plugin.helper,\n            \"_get_access_from_share\",\n            mock.Mock(return_value\u003dNone))\n        self.driver.plugin.helper.login()\n        method \u003d (self.driver.allow_access if is_allow\n                  else self.driver.deny_access)\n        rule \u003d {\n            \u0027access_type\u0027: access_type,\n            \u0027access_to\u0027: \u00270.0.0.0/0\u0027,\n            \u0027access_level\u0027: \u0027rw\u0027,\n        }\n\n\n        method(self._context, self.share_nfs, rule, self.share_server)\n\n\n        mock_get_access.assert_called_with(\u00271\u0027, \u0027*\u0027, \u0027NFS\u0027)\n        # Also add here some check that proper command was called.\n        # Because, now, test does not verify whether you called \"allow\" or \"deny\" operation indeed.\n\n\"\"\"","commit_id":"b8a623d110edeae59e370d948a77d72e3348bc1a"}],"releasenotes/notes/huawei-support-access-all-ip-4994c10ff75ac683.yaml":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d6cd2a739dc88e4acf093eda0612f6239e4f6a5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - users can allow access of all IP addresses by using \u00270.0.0.0\u0027"},{"line_number":4,"context_line":"    in Huawei driver."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3aaa91ec_d5f8d54b","line":3,"range":{"start_line":3,"start_character":57,"end_line":3,"end_character":64},"updated":"2016-06-23 13:48:05.000000000","message":"Groups of IP addresses is described using CIDRs. In current case it is 0.0.0.0/0","commit_id":"0ce251557c166a2e37d6985a39f6b391d6092125"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"584dddfcafc1eabb315741d11de29f6305b21aab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - users can allow access of all IP addresses by using \u00270.0.0.0\u0027"},{"line_number":4,"context_line":"    in Huawei driver."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3aaa91ec_1a28a899","line":3,"range":{"start_line":3,"start_character":57,"end_line":3,"end_character":64},"in_reply_to":"3aaa91ec_ba47d475","updated":"2016-06-24 01:45:59.000000000","message":"yes","commit_id":"0ce251557c166a2e37d6985a39f6b391d6092125"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"8eb79484cbaea30c4bfefff83bd7cfeb0a8f5d54","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - users can allow access of all IP addresses by using \u00270.0.0.0\u0027"},{"line_number":4,"context_line":"    in Huawei driver."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3aaa91ec_ba47d475","line":3,"range":{"start_line":3,"start_character":57,"end_line":3,"end_character":64},"in_reply_to":"3aaa91ec_d5f8d54b","updated":"2016-06-24 01:45:24.000000000","message":"You mean users should use command \"manila access-allow ip 0.0.0.0/0\" to allow access of all IPs ?","commit_id":"0ce251557c166a2e37d6985a39f6b391d6092125"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"230f494e75aee2c859909b38d3d2555cdaad5b93","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - users can allow access of all IP addresses by using \u00270.0.0.0/0\u0027"},{"line_number":4,"context_line":"    in Huawei driver."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_3b84755c","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":21},"updated":"2016-06-24 10:51:28.000000000","message":"Huawei driver now properly handles access for all IP addresses (0.0.0.0/0).","commit_id":"7a78cd4dec0c3e6bb0da565b1046bcd8bd119741"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"65f55b798d0e7f24c80d635867427d000b0bebb0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - users can allow access of all IP addresses by using \u00270.0.0.0/0\u0027"},{"line_number":4,"context_line":"    in Huawei driver."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_38e722ad","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":21},"in_reply_to":"3aaa91ec_3b84755c","updated":"2016-06-27 01:46:54.000000000","message":"Done","commit_id":"7a78cd4dec0c3e6bb0da565b1046bcd8bd119741"}]}
