)]}'
{".gitignore":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"*.sqlite"},{"line_number":7,"context_line":"*.swp"},{"line_number":8,"context_line":".manila-venv"},{"line_number":9,"context_line":".cache/"},{"line_number":10,"context_line":".coverage"},{"line_number":11,"context_line":".testrepository"},{"line_number":12,"context_line":".tox"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"dab17558_31d31506","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":7},"updated":"2016-05-16 13:12:33.000000000","message":"Why this change is part of \"driver\" commit?","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d3a9372cc0a61bc511e8c8f8d5ce23f8e23fdd61","unresolved":false,"context_lines":[{"line_number":6,"context_line":"*.sqlite"},{"line_number":7,"context_line":"*.swp"},{"line_number":8,"context_line":".manila-venv"},{"line_number":9,"context_line":".cache/"},{"line_number":10,"context_line":".coverage"},{"line_number":11,"context_line":".testrepository"},{"line_number":12,"context_line":".tox"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"bab6814e_d6f2026f","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":7},"in_reply_to":"bab6814e_969fecb3","updated":"2016-05-18 10:56:07.000000000","message":"Do it in separate commit, what is the problem?","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"ef857537bd8c71aa28ed1008ff8b319dc7ed138f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"*.sqlite"},{"line_number":7,"context_line":"*.swp"},{"line_number":8,"context_line":".manila-venv"},{"line_number":9,"context_line":".cache/"},{"line_number":10,"context_line":".coverage"},{"line_number":11,"context_line":".testrepository"},{"line_number":12,"context_line":".tox"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"bab6814e_291210b5","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":7},"in_reply_to":"bab6814e_d6f2026f","updated":"2016-05-18 11:54:08.000000000","message":"The problem is too much process overhead.\nI am removing the change.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":6,"context_line":"*.sqlite"},{"line_number":7,"context_line":"*.swp"},{"line_number":8,"context_line":".manila-venv"},{"line_number":9,"context_line":".cache/"},{"line_number":10,"context_line":".coverage"},{"line_number":11,"context_line":".testrepository"},{"line_number":12,"context_line":".tox"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"bab6814e_969fecb3","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":7},"in_reply_to":"dab17558_31d31506","updated":"2016-05-18 08:19:01.000000000","message":"I want to improve the code when I saw it.\nJust to save others effort.\nBut I am OK to drop this change if a separate PR is required.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"}],"/COMMIT_MSG":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"198979b60102d629f8439e8344a74cc50bcf5c2c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"* extend_share: Extend the maximum size of a share."},{"line_number":23,"context_line":"* create_snapshot: Create a snapshot for the specified share."},{"line_number":24,"context_line":"* delete_snapshot: Delete the snapshot of the share."},{"line_number":25,"context_line":"* allow_access: Allow access of a user/host to a share."},{"line_number":26,"context_line":"* deny_access: Remove the access of a user/host to the share."},{"line_number":27,"context_line":"* ensure_share: No implementation."},{"line_number":28,"context_line":"* update_share_stats: Retrieve share related statistics from Unity."},{"line_number":29,"context_line":"* get_network_allocatins_number: Returns number of network allocations for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dab17558_f3800349","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":61},"updated":"2016-05-06 03:02:40.000000000","message":"Drivers need to implement the new update_access() method. please see link: https://etherpad.openstack.org/p/newton-manila-update-access","commit_id":"4f156d7e3eb1d5010771f3c3b5a79bc0e6dd4382"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"3539b22b3d142550f3ff74cbd239787b4aa10250","unresolved":false,"context_lines":[{"line_number":22,"context_line":"* extend_share: Extend the maximum size of a share."},{"line_number":23,"context_line":"* create_snapshot: Create a snapshot for the specified share."},{"line_number":24,"context_line":"* delete_snapshot: Delete the snapshot of the share."},{"line_number":25,"context_line":"* allow_access: Allow access of a user/host to a share."},{"line_number":26,"context_line":"* deny_access: Remove the access of a user/host to the share."},{"line_number":27,"context_line":"* ensure_share: No implementation."},{"line_number":28,"context_line":"* update_share_stats: Retrieve share related statistics from Unity."},{"line_number":29,"context_line":"* get_network_allocatins_number: Returns number of network allocations for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dab17558_bf163aa5","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":61},"in_reply_to":"dab17558_f3800349","updated":"2016-05-06 06:29:52.000000000","message":"Done.","commit_id":"4f156d7e3eb1d5010771f3c3b5a79bc0e6dd4382"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"58c979ed6d94b1456d821d8bb13d2a4b00587ea0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"* extend_share: Extend the maximum size of a share."},{"line_number":23,"context_line":"* create_snapshot: Create a snapshot for the specified share."},{"line_number":24,"context_line":"* delete_snapshot: Delete the snapshot of the share."},{"line_number":25,"context_line":"* allow_access: Allow access of a user/host to a share."},{"line_number":26,"context_line":"* deny_access: Remove the access of a user/host to the share."},{"line_number":27,"context_line":"* ensure_share: No implementation."},{"line_number":28,"context_line":"* update_share_stats: Retrieve share related statistics from Unity."},{"line_number":29,"context_line":"* get_network_allocatins_number: Returns number of network allocations for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dab17558_2ffe4a38","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":61},"updated":"2016-05-09 13:33:24.000000000","message":"change this to update_access","commit_id":"778ffba60efc2a70f226dcf180eb6f398f35e07c"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"ce294013c397d2c96fbe065ee86c684e5bc25db5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"* extend_share: Extend the maximum size of a share."},{"line_number":23,"context_line":"* create_snapshot: Create a snapshot for the specified share."},{"line_number":24,"context_line":"* delete_snapshot: Delete the snapshot of the share."},{"line_number":25,"context_line":"* allow_access: Allow access of a user/host to a share."},{"line_number":26,"context_line":"* deny_access: Remove the access of a user/host to the share."},{"line_number":27,"context_line":"* ensure_share: No implementation."},{"line_number":28,"context_line":"* update_share_stats: Retrieve share related statistics from Unity."},{"line_number":29,"context_line":"* get_network_allocatins_number: Returns number of network allocations for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dab17558_4b5ba22e","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":61},"in_reply_to":"dab17558_2ffe4a38","updated":"2016-05-10 03:15:14.000000000","message":"Thanks.  I forgot to update the commit message.  Updated.","commit_id":"778ffba60efc2a70f226dcf180eb6f398f35e07c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* setup_server: Set up and configures share server with given network"},{"line_number":32,"context_line":"* parameters."},{"line_number":33,"context_line":"* teardown_server: Tear down the share server."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Change-Id: Ic520539341fa19ec5c6c6b85c3c1dcecf70e5141"},{"line_number":36,"context_line":"Implements: blueprint emc-unity-manila-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"3aaa91ec_87c5a33d","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":0},"updated":"2016-06-23 03:19:45.000000000","message":"Please add a DocImpact flag","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* setup_server: Set up and configures share server with given network"},{"line_number":32,"context_line":"* parameters."},{"line_number":33,"context_line":"* teardown_server: Tear down the share server."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Change-Id: Ic520539341fa19ec5c6c6b85c3c1dcecf70e5141"},{"line_number":36,"context_line":"Implements: blueprint emc-unity-manila-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"3aaa91ec_c80dfb91","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":0},"in_reply_to":"3aaa91ec_87c5a33d","updated":"2016-06-23 05:45:48.000000000","message":"Done","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"efc5374a3504a921f6173dbaf89d610a53ff0e78","unresolved":false,"context_lines":[{"line_number":26,"context_line":"* deny_access: Remove the access of a user/host to the share."},{"line_number":27,"context_line":"* ensure_share: Check whether share exists or not."},{"line_number":28,"context_line":"* update_share_stats: Retrieve share related statistics from Unity."},{"line_number":29,"context_line":"* get_network_allocatins_number: Returns number of network allocations for"},{"line_number":30,"context_line":"* creating VIFs."},{"line_number":31,"context_line":"* setup_server: Set up and configures share server with given network"},{"line_number":32,"context_line":"* parameters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"1aa78d24_3bc9755b","line":29,"range":{"start_line":29,"start_character":71,"end_line":29,"end_character":74},"updated":"2016-07-15 04:22:37.000000000","message":"Please keep this within 72 characters","commit_id":"494e387a03b6cfc66614c0092ba1baa4b0fe9fda"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"f5fc8c7caa74d48f0148307eaac50984e752ce97","unresolved":false,"context_lines":[{"line_number":26,"context_line":"* deny_access: Remove the access of a user/host to the share."},{"line_number":27,"context_line":"* ensure_share: Check whether share exists or not."},{"line_number":28,"context_line":"* update_share_stats: Retrieve share related statistics from Unity."},{"line_number":29,"context_line":"* get_network_allocatins_number: Returns number of network allocations for"},{"line_number":30,"context_line":"* creating VIFs."},{"line_number":31,"context_line":"* setup_server: Set up and configures share server with given network"},{"line_number":32,"context_line":"* parameters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"1aa78d24_61e6ab17","line":29,"range":{"start_line":29,"start_character":71,"end_line":29,"end_character":74},"in_reply_to":"1aa78d24_3bc9755b","updated":"2016-07-15 08:31:56.000000000","message":"Done.  I also removed unnecessary `*` in this commit message.  Thanks.","commit_id":"494e387a03b6cfc66614c0092ba1baa4b0fe9fda"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c018c8eeeb66bd7acdf1c9f7aad1992ccbde43f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* setup_server: Set up and configures share server with given network"},{"line_number":32,"context_line":"  parameters."},{"line_number":33,"context_line":"* teardown_server: Tear down the share server."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"DocImpact"},{"line_number":36,"context_line":"Change-Id: Ic520539341fa19ec5c6c6b85c3c1dcecf70e5141"},{"line_number":37,"context_line":"Implements: blueprint emc-unity-manila-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"bacf61ea_e6b1fee2","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":0},"updated":"2016-07-29 06:10:12.000000000","message":"If the author is different from the committer and the committer has made significant changes to the author\u0027s patch, we use Co-Authored-By. I encourage you to add it...","commit_id":"ade6c414312a8f7665b4b4e4a53ede5538848b70"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"887ac4b70a7c1281b67f9b43cb24f378cb82325d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* setup_server: Set up and configures share server with given network"},{"line_number":32,"context_line":"  parameters."},{"line_number":33,"context_line":"* teardown_server: Tear down the share server."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"DocImpact"},{"line_number":36,"context_line":"Change-Id: Ic520539341fa19ec5c6c6b85c3c1dcecf70e5141"},{"line_number":37,"context_line":"Implements: blueprint emc-unity-manila-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"bacf61ea_0651b262","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":0},"in_reply_to":"bacf61ea_e6b1fee2","updated":"2016-07-29 06:16:12.000000000","message":"Done.  Thanks :)","commit_id":"ade6c414312a8f7665b4b4e4a53ede5538848b70"}],"doc/source/devref/emc_unity_driver.rst":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a03531c988683144bc2a6f7bf06b79be01a961b5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"- Unity OE 4.0.1 or higher."},{"line_number":37,"context_line":"- StorOps 0.2.17 or higher is installed on Manila node."},{"line_number":38,"context_line":"- Following licenses are activated on Unity:"},{"line_number":39,"context_line":"  * CIFS/SMB Support"},{"line_number":40,"context_line":"  * Network File System (NFS)"},{"line_number":41,"context_line":"  * Thin Provisioning"},{"line_number":42,"context_line":"  * Fiber Channel (FC)"},{"line_number":43,"context_line":"  * Internet Small Computer System Interface (iSCSI)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Supported Operations"}],"source_content_type":"text/x-rst","patch_set":34,"id":"bacf61ea_d87c7db7","line":43,"range":{"start_line":39,"start_character":0,"end_line":43,"end_character":52},"updated":"2016-07-29 15:35:40.000000000","message":"These sub-bullets aren\u0027t rendering correctly.  (Need a blank line.)","commit_id":"86383ff900ecb215d6569b8bcdf3ed6099a723eb"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"0b33f84d8736e1088bd0af9b818c16e469cd4799","unresolved":false,"context_lines":[{"line_number":36,"context_line":"- Unity OE 4.0.1 or higher."},{"line_number":37,"context_line":"- StorOps 0.2.17 or higher is installed on Manila node."},{"line_number":38,"context_line":"- Following licenses are activated on Unity:"},{"line_number":39,"context_line":"  * CIFS/SMB Support"},{"line_number":40,"context_line":"  * Network File System (NFS)"},{"line_number":41,"context_line":"  * Thin Provisioning"},{"line_number":42,"context_line":"  * Fiber Channel (FC)"},{"line_number":43,"context_line":"  * Internet Small Computer System Interface (iSCSI)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Supported Operations"}],"source_content_type":"text/x-rst","patch_set":34,"id":"bacf61ea_7fbc41dc","line":43,"range":{"start_line":39,"start_character":0,"end_line":43,"end_character":52},"in_reply_to":"bacf61ea_d87c7db7","updated":"2016-07-30 03:08:37.000000000","message":"Good catch.  I reviewed it with \"restview\" before commit and it seems I missed this one because there is no obvious error and they just mixed with the parent bullet.\nSince we already have two +2 and we will definitely have another review for the document, how about we fixed the issue in a separate commit?","commit_id":"86383ff900ecb215d6569b8bcdf3ed6099a723eb"}],"manila/exception.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":554,"context_line":"                \"shares present with the type.\")"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"class IpAddressInUse(InUse):"},{"line_number":558,"context_line":"    message \u003d _(\"IP address %(ip)s is already used.\")"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_c704cb7f","line":557,"range":{"start_line":557,"start_character":6,"end_line":557,"end_character":8},"updated":"2016-06-23 03:19:45.000000000","message":"IP","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":554,"context_line":"                \"shares present with the type.\")"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"class IpAddressInUse(InUse):"},{"line_number":558,"context_line":"    message \u003d _(\"IP address %(ip)s is already used.\")"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_6864c748","line":557,"range":{"start_line":557,"start_character":6,"end_line":557,"end_character":8},"in_reply_to":"3aaa91ec_c704cb7f","updated":"2016-06-23 05:45:48.000000000","message":"Done","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"543265e6ffe9ae0f77daed81142fa193c9a7d802","unresolved":false,"context_lines":[{"line_number":649,"context_line":"    message \u003d _(\"Invalid mover or vdm %(id)s.\")"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"class EMCUnityError(ManilaException):"},{"line_number":653,"context_line":"    message \u003d _(\"%(err)s\")"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1aa78d24_a4f79d57","line":652,"updated":"2016-07-06 21:15:48.000000000","message":"Better to inherit from ShareBackendException.","commit_id":"5fd01b68d5da84edb887b33ef46b02a5355a6ff7"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"cd7bc3d0178fa2cd55605ef9bb548152176aea4d","unresolved":false,"context_lines":[{"line_number":649,"context_line":"    message \u003d _(\"Invalid mover or vdm %(id)s.\")"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"class EMCUnityError(ManilaException):"},{"line_number":653,"context_line":"    message \u003d _(\"%(err)s\")"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1aa78d24_7c954031","line":652,"in_reply_to":"1aa78d24_a4f79d57","updated":"2016-07-07 04:37:38.000000000","message":"Done.  Thanks!","commit_id":"5fd01b68d5da84edb887b33ef46b02a5355a6ff7"}],"manila/share/drivers/emc/driver.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f67875d4f79a67a3eee5dc87b7bc360f0967ba22","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.StrOpt(\u0027emc_nas_server_container\u0027,"},{"line_number":49,"context_line":"               default\u003d\u0027server_2\u0027,"},{"line_number":50,"context_line":"               help\u003d\u0027Container of share servers.\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027emc_interface_port_list\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027Comma separated ports for interface creation.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027emc_nas_pool_names\u0027,"},{"line_number":54,"context_line":"               deprecated_name\u003d\u0027emc_nas_pool_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_7355bcc4","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":14},"updated":"2016-05-04 11:09:09.000000000","message":"shouldn\u0027t you use ListOpt here?","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.StrOpt(\u0027emc_nas_server_container\u0027,"},{"line_number":49,"context_line":"               default\u003d\u0027server_2\u0027,"},{"line_number":50,"context_line":"               help\u003d\u0027Container of share servers.\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027emc_interface_port_list\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027Comma separated ports for interface creation.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027emc_nas_pool_names\u0027,"},{"line_number":54,"context_line":"               deprecated_name\u003d\u0027emc_nas_pool_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_5ebfb7cf","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":14},"in_reply_to":"1a122d0e_6ebe7300","updated":"2016-05-05 11:18:30.000000000","message":"Done.  This is required for the plugin but not required for the driver.  So I will leave at as not required.\n\nActually when I added `required\u003dTrue`, all test cases failed.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.StrOpt(\u0027emc_nas_server_container\u0027,"},{"line_number":49,"context_line":"               default\u003d\u0027server_2\u0027,"},{"line_number":50,"context_line":"               help\u003d\u0027Container of share servers.\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027emc_interface_port_list\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027Comma separated ports for interface creation.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027emc_nas_pool_names\u0027,"},{"line_number":54,"context_line":"               deprecated_name\u003d\u0027emc_nas_pool_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_7eba73e2","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":14},"in_reply_to":"1a122d0e_7355bcc4","updated":"2016-05-05 11:18:30.000000000","message":"Done","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.StrOpt(\u0027emc_nas_server_container\u0027,"},{"line_number":49,"context_line":"               default\u003d\u0027server_2\u0027,"},{"line_number":50,"context_line":"               help\u003d\u0027Container of share servers.\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027emc_interface_port_list\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027Comma separated ports for interface creation.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027emc_nas_pool_names\u0027,"},{"line_number":54,"context_line":"               deprecated_name\u003d\u0027emc_nas_pool_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_6ebe7300","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":14},"in_reply_to":"1a122d0e_7355bcc4","updated":"2016-05-04 11:57:24.000000000","message":"Yes. It should be list. Also, it is not clear whether it is required or optional.\n\nYou can set attr \"required\u003dTrue\" to options that should be set.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d\u0027Container of share servers.\u0027),"},{"line_number":48,"context_line":"    cfg.ListOpt(\u0027emc_interface_ports\u0027,"},{"line_number":49,"context_line":"                help\u003d\u0027Comma separated ports for interface creation.\u0027),"},{"line_number":50,"context_line":"    cfg.ListOpt(\u0027emc_nas_pool_names\u0027,"},{"line_number":51,"context_line":"                deprecated_name\u003d\u0027emc_nas_pool_name\u0027,"},{"line_number":52,"context_line":"                help\u003d\u0027EMC pool names.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027emc_nas_root_dir\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_f157cd57","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":37},"updated":"2016-05-16 13:12:33.000000000","message":"Change of type for this opt looks like unrelated bugfix of existing functionality.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"ef857537bd8c71aa28ed1008ff8b319dc7ed138f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d\u0027Container of share servers.\u0027),"},{"line_number":48,"context_line":"    cfg.ListOpt(\u0027emc_interface_ports\u0027,"},{"line_number":49,"context_line":"                help\u003d\u0027Comma separated ports for interface creation.\u0027),"},{"line_number":50,"context_line":"    cfg.ListOpt(\u0027emc_nas_pool_names\u0027,"},{"line_number":51,"context_line":"                deprecated_name\u003d\u0027emc_nas_pool_name\u0027,"},{"line_number":52,"context_line":"                help\u003d\u0027EMC pool names.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027emc_nas_root_dir\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_89869cb7","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":37},"in_reply_to":"bab6814e_714b602c","updated":"2016-05-18 11:54:08.000000000","message":"I plan to keep it here because it affects other changes in the new driver.\nOtherwise I will have to maintain another dependency.\nThanks for the suggestion.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d3a9372cc0a61bc511e8c8f8d5ce23f8e23fdd61","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d\u0027Container of share servers.\u0027),"},{"line_number":48,"context_line":"    cfg.ListOpt(\u0027emc_interface_ports\u0027,"},{"line_number":49,"context_line":"                help\u003d\u0027Comma separated ports for interface creation.\u0027),"},{"line_number":50,"context_line":"    cfg.ListOpt(\u0027emc_nas_pool_names\u0027,"},{"line_number":51,"context_line":"                deprecated_name\u003d\u0027emc_nas_pool_name\u0027,"},{"line_number":52,"context_line":"                help\u003d\u0027EMC pool names.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027emc_nas_root_dir\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_714b602c","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":37},"in_reply_to":"bab6814e_f6c918ae","updated":"2016-05-18 10:56:07.000000000","message":"It is nice, but it is bugfix that better to move out to separate commit.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d\u0027Container of share servers.\u0027),"},{"line_number":48,"context_line":"    cfg.ListOpt(\u0027emc_interface_ports\u0027,"},{"line_number":49,"context_line":"                help\u003d\u0027Comma separated ports for interface creation.\u0027),"},{"line_number":50,"context_line":"    cfg.ListOpt(\u0027emc_nas_pool_names\u0027,"},{"line_number":51,"context_line":"                deprecated_name\u003d\u0027emc_nas_pool_name\u0027,"},{"line_number":52,"context_line":"                help\u003d\u0027EMC pool names.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027emc_nas_root_dir\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_f6c918ae","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":37},"in_reply_to":"dab17558_f157cd57","updated":"2016-05-18 08:19:01.000000000","message":"Yes.  The change is caused by a comment in previous diff.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"}],"manila/share/drivers/emc/plugins/unity/client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_log import log"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from manila.common import constants as const"},{"line_number":22,"context_line":"from manila import exception"},{"line_number":23,"context_line":"from manila.i18n import _"},{"line_number":24,"context_line":"import storops"},{"line_number":25,"context_line":"from storops import exception as storops_ex"},{"line_number":26,"context_line":"from storops.unity import enums"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_ce286736","line":23,"range":{"start_line":21,"start_character":0,"end_line":23,"end_character":25},"updated":"2016-05-04 11:57:24.000000000","message":"All manila imports should be at the end of imports. See: http://docs.openstack.org/developer/hacking/#imports","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_log import log"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from manila.common import constants as const"},{"line_number":22,"context_line":"from manila import exception"},{"line_number":23,"context_line":"from manila.i18n import _"},{"line_number":24,"context_line":"import storops"},{"line_number":25,"context_line":"from storops import exception as storops_ex"},{"line_number":26,"context_line":"from storops.unity import enums"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_69a11fa9","line":23,"range":{"start_line":21,"start_character":0,"end_line":23,"end_character":25},"in_reply_to":"1a122d0e_ce286736","updated":"2016-05-05 11:18:30.000000000","message":"Done","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        except storops_ex.UnityNfsShareNameExistedError:"},{"line_number":57,"context_line":"            return self.get_share(share_name, \u0027NFS\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def get_share(self, name, share_proto):"},{"line_number":60,"context_line":"        # Validate the share protocol"},{"line_number":61,"context_line":"        proto \u003d share_proto.upper()"},{"line_number":62,"context_line":"        if proto not in (\u0027NFS\u0027, \u0027CIFS\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_8ea30fb1","line":59,"range":{"start_line":59,"start_character":24,"end_line":59,"end_character":28},"updated":"2016-05-04 11:57:24.000000000","message":"Name is not required for validation. Therefore, if better to expect here \"share\" object and not several its parts.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        except storops_ex.UnityNfsShareNameExistedError:"},{"line_number":57,"context_line":"            return self.get_share(share_name, \u0027NFS\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def get_share(self, name, share_proto):"},{"line_number":60,"context_line":"        # Validate the share protocol"},{"line_number":61,"context_line":"        proto \u003d share_proto.upper()"},{"line_number":62,"context_line":"        if proto not in (\u0027NFS\u0027, \u0027CIFS\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_89e8fbb4","line":59,"range":{"start_line":59,"start_character":24,"end_line":59,"end_character":28},"in_reply_to":"1a122d0e_8ea30fb1","updated":"2016-05-05 11:18:30.000000000","message":"The consideration here is better decouple.\nIf I pass an object here, the `get_share` method will depend on an object with a `name` property.  But this method actually only requires a name input.\nWhat about we keep name for now and if we need more than one property from this resource, we change it to an object.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f67875d4f79a67a3eee5dc87b7bc360f0967ba22","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        proto \u003d share_proto.upper()"},{"line_number":62,"context_line":"        if proto not in (\u0027NFS\u0027, \u0027CIFS\u0027):"},{"line_number":63,"context_line":"            raise exception.InvalidShare("},{"line_number":64,"context_line":"                reason\u003d(_(\u0027Invalid NAS protocol supplied: %s.\u0027) % share_proto))"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":67,"context_line":"            return self.system.get_cifs_share(name\u003dname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_d3281036","line":64,"range":{"start_line":64,"start_character":23,"end_line":64,"end_character":79},"updated":"2016-05-04 11:09:09.000000000","message":"unecessary extra parenthesis here","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        proto \u003d share_proto.upper()"},{"line_number":62,"context_line":"        if proto not in (\u0027NFS\u0027, \u0027CIFS\u0027):"},{"line_number":63,"context_line":"            raise exception.InvalidShare("},{"line_number":64,"context_line":"                reason\u003d(_(\u0027Invalid NAS protocol supplied: %s.\u0027) % share_proto))"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":67,"context_line":"            return self.system.get_cifs_share(name\u003dname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_a9fa1775","line":64,"range":{"start_line":64,"start_character":23,"end_line":64,"end_character":79},"in_reply_to":"1a122d0e_d3281036","updated":"2016-05-05 11:18:30.000000000","message":"Good catch.  Fixed.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def get_share(self, name, share_proto):"},{"line_number":60,"context_line":"        # Validate the share protocol"},{"line_number":61,"context_line":"        proto \u003d share_proto.upper()"},{"line_number":62,"context_line":"        if proto not in (\u0027NFS\u0027, \u0027CIFS\u0027):"},{"line_number":63,"context_line":"            raise exception.InvalidShare("},{"line_number":64,"context_line":"                reason\u003d(_(\u0027Invalid NAS protocol supplied: %s.\u0027) % share_proto))"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":67,"context_line":"            return self.system.get_cifs_share(name\u003dname)"},{"line_number":68,"context_line":"        elif proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":69,"context_line":"            return self.system.get_nfs_share(name\u003dname)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def delete_share(self, share):"},{"line_number":72,"context_line":"        share.delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_eeb3a308","line":69,"range":{"start_line":62,"start_character":8,"end_line":69,"end_character":55},"updated":"2016-05-04 11:57:24.000000000","message":"if proto \u003d\u003d \u0027CIFS\u0027:\n    return self.system.get_cifs_share(name\u003dname)\nelif proto \u003d\u003d \u0027NFS\u0027:\n    return self.system.get_nfs_share(name\u003dname)\nelse:\n    raise %FOO%","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def get_share(self, name, share_proto):"},{"line_number":60,"context_line":"        # Validate the share protocol"},{"line_number":61,"context_line":"        proto \u003d share_proto.upper()"},{"line_number":62,"context_line":"        if proto not in (\u0027NFS\u0027, \u0027CIFS\u0027):"},{"line_number":63,"context_line":"            raise exception.InvalidShare("},{"line_number":64,"context_line":"                reason\u003d(_(\u0027Invalid NAS protocol supplied: %s.\u0027) % share_proto))"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":67,"context_line":"            return self.system.get_cifs_share(name\u003dname)"},{"line_number":68,"context_line":"        elif proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":69,"context_line":"            return self.system.get_nfs_share(name\u003dname)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def delete_share(self, share):"},{"line_number":72,"context_line":"        share.delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_89847bd3","line":69,"range":{"start_line":62,"start_character":8,"end_line":69,"end_character":55},"in_reply_to":"1a122d0e_eeb3a308","updated":"2016-05-05 11:18:30.000000000","message":"We already have an invalid protocol exception at line 62.  But you have the point.  I am moving the raise at line 63 here and remove the duplicated type check.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f67875d4f79a67a3eee5dc87b7bc360f0967ba22","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                                          size,"},{"line_number":79,"context_line":"                                          proto\u003dproto)"},{"line_number":80,"context_line":"        except storops_ex.UnityFileSystemNameAlreadyExisted:"},{"line_number":81,"context_line":"            LOG.debug(\u0027Filesystem %s already exists, and \u0027"},{"line_number":82,"context_line":"                      \u0027ignore filesystem creation.\u0027, share_name)"},{"line_number":83,"context_line":"            return self.system.get_filesystem(name\u003dshare_name)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def delete_filesystem(self, filesystem):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_33cea483","line":82,"range":{"start_line":81,"start_character":53,"end_line":82,"end_character":29},"updated":"2016-05-04 11:09:09.000000000","message":"instead of \"and ignore\" I think \"ignoring\" is better","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                                          size,"},{"line_number":79,"context_line":"                                          proto\u003dproto)"},{"line_number":80,"context_line":"        except storops_ex.UnityFileSystemNameAlreadyExisted:"},{"line_number":81,"context_line":"            LOG.debug(\u0027Filesystem %s already exists, and \u0027"},{"line_number":82,"context_line":"                      \u0027ignore filesystem creation.\u0027, share_name)"},{"line_number":83,"context_line":"            return self.system.get_filesystem(name\u003dshare_name)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def delete_filesystem(self, filesystem):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_49654343","line":82,"range":{"start_line":81,"start_character":53,"end_line":82,"end_character":29},"in_reply_to":"1a122d0e_33cea483","updated":"2016-05-05 11:18:30.000000000","message":"You are right.  Done.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f67875d4f79a67a3eee5dc87b7bc360f0967ba22","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        try:"},{"line_number":87,"context_line":"            filesystem.delete()"},{"line_number":88,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":89,"context_line":"            pass"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def create_nas_server(self, name, sp, pool):"},{"line_number":92,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_93a338b1","line":89,"range":{"start_line":89,"start_character":12,"end_line":89,"end_character":16},"updated":"2016-05-04 11:09:09.000000000","message":"nit: it could be a good idea to LOG.warning here","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        try:"},{"line_number":87,"context_line":"            filesystem.delete()"},{"line_number":88,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":89,"context_line":"            pass"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def create_nas_server(self, name, sp, pool):"},{"line_number":92,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_c9515364","line":89,"range":{"start_line":89,"start_character":12,"end_line":89,"end_character":16},"in_reply_to":"1a122d0e_93a338b1","updated":"2016-05-05 11:18:30.000000000","message":"Done.  The error here is usually caused by timeout retry.  It won\u0027t be a problem.  So I am adding an info log here.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f67875d4f79a67a3eee5dc87b7bc360f0967ba22","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        try:"},{"line_number":93,"context_line":"            return self.system.create_nas_server(name, sp, pool)"},{"line_number":94,"context_line":"        except storops_ex.UnityNasServerNameUsedError:"},{"line_number":95,"context_line":"            LOG.debug(\u0027Share server %s already exists, and ignore share \u0027"},{"line_number":96,"context_line":"                      \u0027server creation.\u0027, name)"},{"line_number":97,"context_line":"            return self.get_nas_server(name)"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_33950440","line":95,"range":{"start_line":95,"start_character":55,"end_line":95,"end_character":65},"updated":"2016-05-04 11:09:09.000000000","message":"same as above, I think \"ignoring\" is better here","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        try:"},{"line_number":93,"context_line":"            return self.system.create_nas_server(name, sp, pool)"},{"line_number":94,"context_line":"        except storops_ex.UnityNasServerNameUsedError:"},{"line_number":95,"context_line":"            LOG.debug(\u0027Share server %s already exists, and ignore share \u0027"},{"line_number":96,"context_line":"                      \u0027server creation.\u0027, name)"},{"line_number":97,"context_line":"            return self.get_nas_server(name)"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_a9e4d7a7","line":95,"range":{"start_line":95,"start_character":55,"end_line":95,"end_character":65},"in_reply_to":"1a122d0e_33950440","updated":"2016-05-05 11:18:30.000000000","message":"Updated.  Thanks.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f67875d4f79a67a3eee5dc87b7bc360f0967ba22","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            return self.system.get_nas_server(name\u003dname)"},{"line_number":102,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":103,"context_line":"            LOG.debug(\u0027NAS server %s not found.\u0027, name)"},{"line_number":104,"context_line":"            return"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def delete_nas_server(self, name, username\u003dNone, password\u003dNone):"},{"line_number":107,"context_line":"        nas_server \u003d self.get_nas_server(name\u003dname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_93dfb80b","line":104,"range":{"start_line":104,"start_character":12,"end_line":104,"end_character":18},"updated":"2016-05-04 11:09:09.000000000","message":"you are returning None here. Other methods are expecting an object to be returned, and then invoking {yourObject}.something... which would result in errors. Are you sure you want to return None here instead of throwing an exception?","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            return self.system.get_nas_server(name\u003dname)"},{"line_number":102,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":103,"context_line":"            LOG.debug(\u0027NAS server %s not found.\u0027, name)"},{"line_number":104,"context_line":"            return"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def delete_nas_server(self, name, username\u003dNone, password\u003dNone):"},{"line_number":107,"context_line":"        nas_server \u003d self.get_nas_server(name\u003dname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_297e07af","line":104,"range":{"start_line":104,"start_character":12,"end_line":104,"end_character":18},"in_reply_to":"1a122d0e_4e71f743","updated":"2016-05-05 11:18:30.000000000","message":"I am removing the extra return.  The error check is done in `connection.py`.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            return self.system.get_nas_server(name\u003dname)"},{"line_number":102,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":103,"context_line":"            LOG.debug(\u0027NAS server %s not found.\u0027, name)"},{"line_number":104,"context_line":"            return"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def delete_nas_server(self, name, username\u003dNone, password\u003dNone):"},{"line_number":107,"context_line":"        nas_server \u003d self.get_nas_server(name\u003dname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_4e71f743","line":104,"range":{"start_line":104,"start_character":12,"end_line":104,"end_character":18},"in_reply_to":"1a122d0e_93dfb80b","updated":"2016-05-04 11:57:24.000000000","message":"And it is redundant in general.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f67875d4f79a67a3eee5dc87b7bc360f0967ba22","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        try:"},{"line_number":109,"context_line":"            nas_server.delete(username\u003dusername, password\u003dpassword)"},{"line_number":110,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":111,"context_line":"            pass"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def create_dns_server(self, nas_server, domain, dns_ip):"},{"line_number":114,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b3875411","line":111,"range":{"start_line":111,"start_character":11,"end_line":111,"end_character":16},"updated":"2016-05-04 11:09:09.000000000","message":"nit: same as above, could be a LOG.warning","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        try:"},{"line_number":109,"context_line":"            nas_server.delete(username\u003dusername, password\u003dpassword)"},{"line_number":110,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":111,"context_line":"            pass"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def create_dns_server(self, nas_server, domain, dns_ip):"},{"line_number":114,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_ce9b4765","line":111,"range":{"start_line":111,"start_character":11,"end_line":111,"end_character":16},"in_reply_to":"1a122d0e_b3875411","updated":"2016-05-04 11:57:24.000000000","message":"At least \"debug\" - yes.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        try:"},{"line_number":109,"context_line":"            nas_server.delete(username\u003dusername, password\u003dpassword)"},{"line_number":110,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":111,"context_line":"            pass"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def create_dns_server(self, nas_server, domain, dns_ip):"},{"line_number":114,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_e95ecf43","line":111,"range":{"start_line":111,"start_character":11,"end_line":111,"end_character":16},"in_reply_to":"1a122d0e_ce9b4765","updated":"2016-05-05 11:18:30.000000000","message":"Adding an info log here.  Thanks.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f67875d4f79a67a3eee5dc87b7bc360f0967ba22","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            nas_server.create_dns_server(domain, dns_ip)"},{"line_number":116,"context_line":"        except storops_ex.UnityOneDnsPerNasServerError:"},{"line_number":117,"context_line":"            LOG.debug(\u0027DNS server %s already exists, and \u0027"},{"line_number":118,"context_line":"                      \u0027ignore DNS server creation.\u0027, domain)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def create_interface(self, nas_server, ip_addr, netmask, gateway, ports,"},{"line_number":121,"context_line":"                         vlan_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_d3e930b9","line":118,"range":{"start_line":117,"start_character":53,"end_line":118,"end_character":29},"updated":"2016-05-04 11:09:09.000000000","message":"same as above \"ignoring\"","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            nas_server.create_dns_server(domain, dns_ip)"},{"line_number":116,"context_line":"        except storops_ex.UnityOneDnsPerNasServerError:"},{"line_number":117,"context_line":"            LOG.debug(\u0027DNS server %s already exists, and \u0027"},{"line_number":118,"context_line":"                      \u0027ignore DNS server creation.\u0027, domain)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def create_interface(self, nas_server, ip_addr, netmask, gateway, ports,"},{"line_number":121,"context_line":"                         vlan_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_44040a14","line":118,"range":{"start_line":117,"start_character":53,"end_line":118,"end_character":29},"in_reply_to":"1a122d0e_d3e930b9","updated":"2016-05-05 11:18:30.000000000","message":"Done.  And changed the log level to \"Info\".","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def create_interface(self, nas_server, ip_addr, netmask, gateway, ports,"},{"line_number":121,"context_line":"                         vlan_id\u003dNone):"},{"line_number":122,"context_line":"        port_list \u003d list(ports)"},{"line_number":123,"context_line":"        random.shuffle(port_list)"},{"line_number":124,"context_line":"        try:"},{"line_number":125,"context_line":"            nas_server.create_file_interface(port_list[0],"},{"line_number":126,"context_line":"                                             ip_addr,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_4ee0d796","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":33},"updated":"2016-05-04 11:57:24.000000000","message":"Why do you need to shuffle ports?","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def create_interface(self, nas_server, ip_addr, netmask, gateway, ports,"},{"line_number":121,"context_line":"                         vlan_id\u003dNone):"},{"line_number":122,"context_line":"        port_list \u003d list(ports)"},{"line_number":123,"context_line":"        random.shuffle(port_list)"},{"line_number":124,"context_line":"        try:"},{"line_number":125,"context_line":"            nas_server.create_file_interface(port_list[0],"},{"line_number":126,"context_line":"                                             ip_addr,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_24310eee","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":33},"in_reply_to":"1a122d0e_4ee0d796","updated":"2016-05-05 11:18:30.000000000","message":"Because we want to distribute the connection to different ports.  It\u0027s not perfect way but the simplest we could come up to.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f67875d4f79a67a3eee5dc87b7bc360f0967ba22","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                                             gateway\u003dgateway,"},{"line_number":129,"context_line":"                                             vlan_id\u003dvlan_id)"},{"line_number":130,"context_line":"        except storops_ex.UnityIpAddressUsedError:"},{"line_number":131,"context_line":"            pass"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def enable_cifs_service(self, nas_server, domain, username, password):"},{"line_number":134,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_9314d89f","line":131,"range":{"start_line":131,"start_character":12,"end_line":131,"end_character":16},"updated":"2016-05-04 11:09:09.000000000","message":"if it is in-use it probably has not created the interface, are you sure you want to swallow the exception here?","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                                             gateway\u003dgateway,"},{"line_number":129,"context_line":"                                             vlan_id\u003dvlan_id)"},{"line_number":130,"context_line":"        except storops_ex.UnityIpAddressUsedError:"},{"line_number":131,"context_line":"            pass"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def enable_cifs_service(self, nas_server, domain, username, password):"},{"line_number":134,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_04b3324e","line":131,"range":{"start_line":131,"start_character":12,"end_line":131,"end_character":16},"in_reply_to":"1a122d0e_9314d89f","updated":"2016-05-05 11:18:30.000000000","message":"You have the point.  The original consideration here is to remove the impact of retried call.  But I don\u0027t think it\u0027s an operation that could trigger retry here.  I will log an error and re-raise the exception here.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            pass"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def enable_cifs_service(self, nas_server, domain, username, password):"},{"line_number":134,"context_line":"        try:"},{"line_number":135,"context_line":"            nas_server.enable_cifs_service("},{"line_number":136,"context_line":"                nas_server.file_interface,"},{"line_number":137,"context_line":"                domain\u003ddomain,"},{"line_number":138,"context_line":"                domain_username\u003dusername,"},{"line_number":139,"context_line":"                domain_password\u003dpassword)"},{"line_number":140,"context_line":"        except storops_ex.UnitySmbNameInUseError:"},{"line_number":141,"context_line":"            LOG.debug(\u0027CIFS service on NAS server %s is \u0027"},{"line_number":142,"context_line":"                      \u0027already enabled.\u0027, nas_server.name)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def enable_nfs_service(self, nas_server):"},{"line_number":145,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_ce8507d0","line":142,"range":{"start_line":134,"start_character":8,"end_line":142,"end_character":58},"updated":"2016-05-04 11:57:24.000000000","message":"You return \"None\" in both cases - with \"success\" and \"error\" results. It is incorrect behavior. Same for all other such places.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            pass"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def enable_cifs_service(self, nas_server, domain, username, password):"},{"line_number":134,"context_line":"        try:"},{"line_number":135,"context_line":"            nas_server.enable_cifs_service("},{"line_number":136,"context_line":"                nas_server.file_interface,"},{"line_number":137,"context_line":"                domain\u003ddomain,"},{"line_number":138,"context_line":"                domain_username\u003dusername,"},{"line_number":139,"context_line":"                domain_password\u003dpassword)"},{"line_number":140,"context_line":"        except storops_ex.UnitySmbNameInUseError:"},{"line_number":141,"context_line":"            LOG.debug(\u0027CIFS service on NAS server %s is \u0027"},{"line_number":142,"context_line":"                      \u0027already enabled.\u0027, nas_server.name)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def enable_nfs_service(self, nas_server):"},{"line_number":145,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_84cbc2a3","line":142,"range":{"start_line":134,"start_character":8,"end_line":142,"end_character":58},"in_reply_to":"1a122d0e_ce8507d0","updated":"2016-05-05 11:18:30.000000000","message":"Ah, yes.  This is a modify method.  If anything went wrong, we could receive an exception.  If things goes well, we don\u0027t need any extra information.  So I will keep the behavior here.\nSame thing applies to `enable_nfs_service`, etc.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"f69290fbd76d514bef4c9359153596df5a9deafe","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def create_snapshot(self, filesystem, name):"},{"line_number":152,"context_line":"        try:"},{"line_number":153,"context_line":"            access_type \u003d enums.FilesystemSnapAccessTypeEnum.CHECKPOINT"},{"line_number":154,"context_line":"            return filesystem.create_snap(name, fs_access_type\u003daccess_type)"},{"line_number":155,"context_line":"        except storops_ex.UnitySnapNameInUseError:"},{"line_number":156,"context_line":"            LOG.debug(\u0027Snapshot %(snap)s on Filesystem %(fs)s already \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b7ad779d","line":153,"updated":"2016-05-04 15:19:39.000000000","message":"You could move this line out of the try block to keep the scope of the try as small as possible.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def create_snapshot(self, filesystem, name):"},{"line_number":152,"context_line":"        try:"},{"line_number":153,"context_line":"            access_type \u003d enums.FilesystemSnapAccessTypeEnum.CHECKPOINT"},{"line_number":154,"context_line":"            return filesystem.create_snap(name, fs_access_type\u003daccess_type)"},{"line_number":155,"context_line":"        except storops_ex.UnitySnapNameInUseError:"},{"line_number":156,"context_line":"            LOG.debug(\u0027Snapshot %(snap)s on Filesystem %(fs)s already \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_04b85210","line":153,"in_reply_to":"1a122d0e_b7ad779d","updated":"2016-05-05 11:18:30.000000000","message":"Good point.  Done.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"f69290fbd76d514bef4c9359153596df5a9deafe","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def create_snap_of_snap(self, src_snap, dst_snap_name, snap_type):"},{"line_number":160,"context_line":"        try:"},{"line_number":161,"context_line":"            access_type \u003d enums.FilesystemSnapAccessTypeEnum.PROTOCOL"},{"line_number":162,"context_line":"            if snap_type \u003d\u003d \u0027checkpoint\u0027:"},{"line_number":163,"context_line":"                access_type \u003d enums.FilesystemSnapAccessTypeEnum.CHECKPOINT"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"            if isinstance(src_snap, six.string_types):"},{"line_number":166,"context_line":"                snap \u003d self.get_snapshot(name\u003dsrc_snap)"},{"line_number":167,"context_line":"            else:"},{"line_number":168,"context_line":"                snap \u003d src_snap"},{"line_number":169,"context_line":"            return snap.create_snap(dst_snap_name, fs_access_type\u003daccess_type)"},{"line_number":170,"context_line":"        except storops_ex.UnitySnapNameInUseError:"},{"line_number":171,"context_line":"            return self.get_snapshot(dst_snap_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b7e9f7b9","line":168,"range":{"start_line":161,"start_character":12,"end_line":168,"end_character":31},"updated":"2016-05-04 15:19:39.000000000","message":"Same as above, this code could be moved out of the try block.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def create_snap_of_snap(self, src_snap, dst_snap_name, snap_type):"},{"line_number":160,"context_line":"        try:"},{"line_number":161,"context_line":"            access_type \u003d enums.FilesystemSnapAccessTypeEnum.PROTOCOL"},{"line_number":162,"context_line":"            if snap_type \u003d\u003d \u0027checkpoint\u0027:"},{"line_number":163,"context_line":"                access_type \u003d enums.FilesystemSnapAccessTypeEnum.CHECKPOINT"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"            if isinstance(src_snap, six.string_types):"},{"line_number":166,"context_line":"                snap \u003d self.get_snapshot(name\u003dsrc_snap)"},{"line_number":167,"context_line":"            else:"},{"line_number":168,"context_line":"                snap \u003d src_snap"},{"line_number":169,"context_line":"            return snap.create_snap(dst_snap_name, fs_access_type\u003daccess_type)"},{"line_number":170,"context_line":"        except storops_ex.UnitySnapNameInUseError:"},{"line_number":171,"context_line":"            return self.get_snapshot(dst_snap_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_c4f5ba83","line":168,"range":{"start_line":161,"start_character":12,"end_line":168,"end_character":31},"in_reply_to":"1a122d0e_b7e9f7b9","updated":"2016-05-05 11:18:30.000000000","message":"Done.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f67875d4f79a67a3eee5dc87b7bc360f0967ba22","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        try:"},{"line_number":178,"context_line":"            snap.delete()"},{"line_number":179,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":180,"context_line":"            pass"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def get_pool(self, name\u003dNone):"},{"line_number":183,"context_line":"        return self.system.get_pool(name\u003dname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_53724012","line":180,"range":{"start_line":180,"start_character":12,"end_line":180,"end_character":16},"updated":"2016-05-04 11:09:09.000000000","message":"nit: same as above, could be a LOG.warning.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        try:"},{"line_number":178,"context_line":"            snap.delete()"},{"line_number":179,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":180,"context_line":"            pass"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def get_pool(self, name\u003dNone):"},{"line_number":183,"context_line":"        return self.system.get_pool(name\u003dname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_a4087e81","line":180,"range":{"start_line":180,"start_character":12,"end_line":180,"end_character":16},"in_reply_to":"1a122d0e_53724012","updated":"2016-05-05 11:18:30.000000000","message":"`Warning` may cause unnecessary worries.  This exception could be caused by an timeout retry and do not affect the application.  I will log an info here.  Thanks.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f67875d4f79a67a3eee5dc87b7bc360f0967ba22","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        try:"},{"line_number":215,"context_line":"            share.delete_access(host_ip)"},{"line_number":216,"context_line":"        except storops_ex.UnityHostNotFoundException:"},{"line_number":217,"context_line":"            pass"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def get_ip_ports(self, sp\u003dNone):"},{"line_number":220,"context_line":"        ports \u003d self.system.get_ip_port()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f3826cc7","line":217,"range":{"start_line":217,"start_character":12,"end_line":217,"end_character":16},"updated":"2016-05-04 11:09:09.000000000","message":"nit: same as above, could be a LOG.warning","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        try:"},{"line_number":215,"context_line":"            share.delete_access(host_ip)"},{"line_number":216,"context_line":"        except storops_ex.UnityHostNotFoundException:"},{"line_number":217,"context_line":"            pass"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def get_ip_ports(self, sp\u003dNone):"},{"line_number":220,"context_line":"        ports \u003d self.system.get_ip_port()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_449a4a15","line":217,"range":{"start_line":217,"start_character":12,"end_line":217,"end_character":16},"in_reply_to":"1a122d0e_f3826cc7","updated":"2016-05-05 11:18:30.000000000","message":"Done.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"a5d671903d429e02839c45c74335eb9fc14fafbd","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                         \u0027server creation.\u0027), name)"},{"line_number":98,"context_line":"            return self.get_nas_server(name)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def get_nas_server(self, name):"},{"line_number":101,"context_line":"        try:"},{"line_number":102,"context_line":"            return self.system.get_nas_server(name\u003dname)"},{"line_number":103,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":104,"context_line":"            LOG.info(_LI(\u0027NAS server %s not found.\u0027), name)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def delete_nas_server(self, name, username\u003dNone, password\u003dNone):"},{"line_number":107,"context_line":"        nas_server \u003d self.get_nas_server(name\u003dname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_07a16af7","line":104,"range":{"start_line":100,"start_character":3,"end_line":104,"end_character":59},"updated":"2016-05-05 19:15:57.000000000","message":"you are still swallowing the exception here. If you look below, it is used in create_dns_server and several other functions. So, when invoked, this method may return None, and then create_dns_server will fail with AttributeError. Are you sure you don\u0027t want to treat this scenario more elegantly?","commit_id":"c785b5f5bc1267b8220da7b2ef36a70955226482"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"3724f049b65eee5b2ff6f47bf377619fc91724e4","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                         \u0027server creation.\u0027), name)"},{"line_number":98,"context_line":"            return self.get_nas_server(name)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def get_nas_server(self, name):"},{"line_number":101,"context_line":"        try:"},{"line_number":102,"context_line":"            return self.system.get_nas_server(name\u003dname)"},{"line_number":103,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":104,"context_line":"            LOG.info(_LI(\u0027NAS server %s not found.\u0027), name)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def delete_nas_server(self, name, username\u003dNone, password\u003dNone):"},{"line_number":107,"context_line":"        nas_server \u003d self.get_nas_server(name\u003dname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_8eefcaaf","line":104,"range":{"start_line":100,"start_character":3,"end_line":104,"end_character":59},"in_reply_to":"1a122d0e_07a16af7","updated":"2016-05-06 03:58:16.000000000","message":"Updated.\n\nThe function will now re-throw the exception.\n\nFor the caller, we have tow kinds of behavior when this exception is received.\n\n  * delete_nas_server will log an info and swallow the exception.\n  * other functions will raise a UnityExcerption(ManilaException) if NAS server is missing.","commit_id":"c785b5f5bc1267b8220da7b2ef36a70955226482"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"a5d671903d429e02839c45c74335eb9fc14fafbd","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        except storops_ex.UnityIpAddressUsedError:"},{"line_number":131,"context_line":"            msg \u003d \u0027IP address %s is already used.\u0027 % ip_addr"},{"line_number":132,"context_line":"            LOG.error(_LE(msg))"},{"line_number":133,"context_line":"            raise ValueError(msg)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def enable_cifs_service(self, nas_server, domain, username, password):"},{"line_number":136,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_631db372","line":133,"range":{"start_line":133,"start_character":12,"end_line":133,"end_character":33},"updated":"2016-05-05 19:15:57.000000000","message":"I highly recommend using an exception that inherits ManilaException.","commit_id":"c785b5f5bc1267b8220da7b2ef36a70955226482"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"3724f049b65eee5b2ff6f47bf377619fc91724e4","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        except storops_ex.UnityIpAddressUsedError:"},{"line_number":131,"context_line":"            msg \u003d \u0027IP address %s is already used.\u0027 % ip_addr"},{"line_number":132,"context_line":"            LOG.error(_LE(msg))"},{"line_number":133,"context_line":"            raise ValueError(msg)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def enable_cifs_service(self, nas_server, domain, username, password):"},{"line_number":136,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_0e875a10","line":133,"range":{"start_line":133,"start_character":12,"end_line":133,"end_character":33},"in_reply_to":"1a122d0e_631db372","updated":"2016-05-06 03:58:16.000000000","message":"I am adding new exception \"IpAddressInUse \u003c- InUse \u003c- ManilaException\".","commit_id":"c785b5f5bc1267b8220da7b2ef36a70955226482"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"58c979ed6d94b1456d821d8bb13d2a4b00587ea0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        \"\"\""},{"line_number":45,"context_line":"        try:"},{"line_number":46,"context_line":"            return resource.create_cifs_share(share_name)"},{"line_number":47,"context_line":"        except storops_ex.UnitySmbShareNameExistedError:"},{"line_number":48,"context_line":"            return self.get_share(share_name, \u0027CIFS\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def create_nfs_share(self, resource, share_name):"},{"line_number":51,"context_line":"        \"\"\"Create NFS share from the resource."}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_8f07761b","line":48,"range":{"start_line":47,"start_character":8,"end_line":48,"end_character":53},"updated":"2016-05-09 13:33:24.000000000","message":"I hadn\u0027t looked this in more detail before, but now I find this workflow a little unusual because this function is being invoked from the connection.py file within the create_share/create_share_from_snapshot. This workflow intends to create a new share, if you find that it is already there, you are not in fact creating a new share and I am not sure the parameters of the new share intended to be created match the ones already that, you may be comparing just the share IDs or name. Is this really what you want?","commit_id":"778ffba60efc2a70f226dcf180eb6f398f35e07c"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"ce294013c397d2c96fbe065ee86c684e5bc25db5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        \"\"\""},{"line_number":45,"context_line":"        try:"},{"line_number":46,"context_line":"            return resource.create_cifs_share(share_name)"},{"line_number":47,"context_line":"        except storops_ex.UnitySmbShareNameExistedError:"},{"line_number":48,"context_line":"            return self.get_share(share_name, \u0027CIFS\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def create_nfs_share(self, resource, share_name):"},{"line_number":51,"context_line":"        \"\"\"Create NFS share from the resource."}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_f0ab671b","line":48,"range":{"start_line":47,"start_character":8,"end_line":48,"end_character":53},"in_reply_to":"dab17558_8f07761b","updated":"2016-05-10 03:15:14.000000000","message":"Yes, I know it\u0027s confusing.  The reason here is that the operation may timeout.  And when timeout happens, the same operation will be retried.  If we return the exception for the retried operation, nova will think it\u0027s failed while in fact the operation completed successfully.\nSo we take it for granted that the share_name used by openstack should be unique (something includes a UUID).  And if it\u0027s used that probably means we are in a retry call and it\u0027s safe to ignore this error.\nThe same thing applies to almost all API implemented in this driver.  We will ignore the error if it could be caused by a retry operation.","commit_id":"778ffba60efc2a70f226dcf180eb6f398f35e07c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"b46e5dcb592691c3774eb9d86c56f940fafb00bf","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        \"\"\""},{"line_number":45,"context_line":"        try:"},{"line_number":46,"context_line":"            return resource.create_cifs_share(share_name)"},{"line_number":47,"context_line":"        except storops_ex.UnitySmbShareNameExistedError:"},{"line_number":48,"context_line":"            return self.get_share(share_name, \u0027CIFS\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def create_nfs_share(self, resource, share_name):"},{"line_number":51,"context_line":"        \"\"\"Create NFS share from the resource."}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_7838e7ef","line":48,"range":{"start_line":47,"start_character":8,"end_line":48,"end_character":53},"in_reply_to":"dab17558_f0ab671b","updated":"2016-05-10 10:56:40.000000000","message":"Thanks, I understand it now.","commit_id":"778ffba60efc2a70f226dcf180eb6f398f35e07c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"58c979ed6d94b1456d821d8bb13d2a4b00587ea0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":"        try:"},{"line_number":58,"context_line":"            return resource.create_nfs_share(share_name)"},{"line_number":59,"context_line":"        except storops_ex.UnityNfsShareNameExistedError:"},{"line_number":60,"context_line":"            return self.get_share(share_name, \u0027NFS\u0027)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def get_share(self, name, share_proto):"},{"line_number":63,"context_line":"        # Validate the share protocol"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_caffacff","line":60,"range":{"start_line":59,"start_character":8,"end_line":60,"end_character":52},"updated":"2016-05-09 13:33:24.000000000","message":"same as above","commit_id":"778ffba60efc2a70f226dcf180eb6f398f35e07c"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"ce294013c397d2c96fbe065ee86c684e5bc25db5","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":"        try:"},{"line_number":58,"context_line":"            return resource.create_nfs_share(share_name)"},{"line_number":59,"context_line":"        except storops_ex.UnityNfsShareNameExistedError:"},{"line_number":60,"context_line":"            return self.get_share(share_name, \u0027NFS\u0027)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def get_share(self, name, share_proto):"},{"line_number":63,"context_line":"        # Validate the share protocol"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_d0a62352","line":60,"range":{"start_line":59,"start_character":8,"end_line":60,"end_character":52},"in_reply_to":"dab17558_caffacff","updated":"2016-05-10 03:15:14.000000000","message":"See the comment above.","commit_id":"778ffba60efc2a70f226dcf180eb6f398f35e07c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                          share_name,"},{"line_number":81,"context_line":"                                          size,"},{"line_number":82,"context_line":"                                          proto\u003dproto)"},{"line_number":83,"context_line":"        except storops_ex.UnityFileSystemNameAlreadyExisted:"},{"line_number":84,"context_line":"            LOG.debug(\u0027Filesystem %s already exists, \u0027"},{"line_number":85,"context_line":"                      \u0027ignoring filesystem creation.\u0027, share_name)"},{"line_number":86,"context_line":"            return self.system.get_filesystem(name\u003dshare_name)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def delete_filesystem(self, filesystem):"},{"line_number":89,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_6c74a035","line":86,"range":{"start_line":83,"start_character":8,"end_line":86,"end_character":62},"updated":"2016-05-16 13:12:33.000000000","message":"Why do you return \"existing\" filesystem in \"create\" method?","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"ef857537bd8c71aa28ed1008ff8b319dc7ed138f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                          share_name,"},{"line_number":81,"context_line":"                                          size,"},{"line_number":82,"context_line":"                                          proto\u003dproto)"},{"line_number":83,"context_line":"        except storops_ex.UnityFileSystemNameAlreadyExisted:"},{"line_number":84,"context_line":"            LOG.debug(\u0027Filesystem %s already exists, \u0027"},{"line_number":85,"context_line":"                      \u0027ignoring filesystem creation.\u0027, share_name)"},{"line_number":86,"context_line":"            return self.system.get_filesystem(name\u003dshare_name)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def delete_filesystem(self, filesystem):"},{"line_number":89,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_0c8d9a31","line":86,"range":{"start_line":83,"start_character":8,"end_line":86,"end_character":62},"in_reply_to":"bab6814e_31dd5843","updated":"2016-05-18 11:54:08.000000000","message":"Sometimes the array operation took too long to return.  Manila treated it as a timeout operation and will retry.\n\nThe problem is why it retries the operation.\nAs long as the retry mechanism exists, I will have to deal with it in this ugly way.  Because if I returned \"filesystem already existed\" error, Manila will thought the operation failed while it actually succeeded.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d3a9372cc0a61bc511e8c8f8d5ce23f8e23fdd61","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                          share_name,"},{"line_number":81,"context_line":"                                          size,"},{"line_number":82,"context_line":"                                          proto\u003dproto)"},{"line_number":83,"context_line":"        except storops_ex.UnityFileSystemNameAlreadyExisted:"},{"line_number":84,"context_line":"            LOG.debug(\u0027Filesystem %s already exists, \u0027"},{"line_number":85,"context_line":"                      \u0027ignoring filesystem creation.\u0027, share_name)"},{"line_number":86,"context_line":"            return self.system.get_filesystem(name\u003dshare_name)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def delete_filesystem(self, filesystem):"},{"line_number":89,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_31dd5843","line":86,"range":{"start_line":83,"start_character":8,"end_line":86,"end_character":62},"in_reply_to":"bab6814e_760368b9","updated":"2016-05-18 10:56:07.000000000","message":"Why do you expect \"timeout\"? It should not be expected case. Even if it exists, something may be broken or be of unexpected state.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                          share_name,"},{"line_number":81,"context_line":"                                          size,"},{"line_number":82,"context_line":"                                          proto\u003dproto)"},{"line_number":83,"context_line":"        except storops_ex.UnityFileSystemNameAlreadyExisted:"},{"line_number":84,"context_line":"            LOG.debug(\u0027Filesystem %s already exists, \u0027"},{"line_number":85,"context_line":"                      \u0027ignoring filesystem creation.\u0027, share_name)"},{"line_number":86,"context_line":"            return self.system.get_filesystem(name\u003dshare_name)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def delete_filesystem(self, filesystem):"},{"line_number":89,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_760368b9","line":86,"range":{"start_line":83,"start_character":8,"end_line":86,"end_character":62},"in_reply_to":"dab17558_6c74a035","updated":"2016-05-18 08:19:01.000000000","message":"The behavior here is to address timeout.\nIf an operation timeout happens, driver will receive the same request.  If we fail the second request, the operation will fail even if we have already created the filesystem in the first request.\nAnd it\u0027s not likely that someone else will create a filesystem with a name used by the manila driver so it\u0027s safe to skip the already existed error.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        try:"},{"line_number":90,"context_line":"            filesystem.delete()"},{"line_number":91,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":92,"context_line":"            LOG.info(_LI(\u0027File system is already removed.\u0027))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def create_nas_server(self, name, sp, pool):"},{"line_number":95,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_2ca578a1","line":92,"range":{"start_line":92,"start_character":26,"end_line":92,"end_character":57},"updated":"2016-05-16 13:12:33.000000000","message":"Which filesystem. Requires identifier.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        try:"},{"line_number":90,"context_line":"            filesystem.delete()"},{"line_number":91,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":92,"context_line":"            LOG.info(_LI(\u0027File system is already removed.\u0027))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def create_nas_server(self, name, sp, pool):"},{"line_number":95,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_36ce0084","line":92,"range":{"start_line":92,"start_character":26,"end_line":92,"end_character":57},"in_reply_to":"dab17558_2ca578a1","updated":"2016-05-18 08:19:01.000000000","message":"Added.  Thanks.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":92,"context_line":"            LOG.info(_LI(\u0027File system is already removed.\u0027))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def create_nas_server(self, name, sp, pool):"},{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            return self.system.create_nas_server(name, sp, pool)"},{"line_number":97,"context_line":"        except storops_ex.UnityNasServerNameUsedError:"},{"line_number":98,"context_line":"            LOG.info(_LI(\u0027Share server %s already exists, ignoring share \u0027"},{"line_number":99,"context_line":"                         \u0027server creation.\u0027), name)"},{"line_number":100,"context_line":"            return self.get_nas_server(name)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def get_nas_server(self, name):"},{"line_number":103,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_4ca8bc77","line":100,"range":{"start_line":94,"start_character":4,"end_line":100,"end_character":44},"updated":"2016-05-16 13:12:33.000000000","message":"Same here.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":92,"context_line":"            LOG.info(_LI(\u0027File system is already removed.\u0027))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def create_nas_server(self, name, sp, pool):"},{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            return self.system.create_nas_server(name, sp, pool)"},{"line_number":97,"context_line":"        except storops_ex.UnityNasServerNameUsedError:"},{"line_number":98,"context_line":"            LOG.info(_LI(\u0027Share server %s already exists, ignoring share \u0027"},{"line_number":99,"context_line":"                         \u0027server creation.\u0027), name)"},{"line_number":100,"context_line":"            return self.get_nas_server(name)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def get_nas_server(self, name):"},{"line_number":103,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_161dbc0f","line":100,"range":{"start_line":94,"start_character":4,"end_line":100,"end_character":44},"in_reply_to":"dab17558_4ca8bc77","updated":"2016-05-18 08:19:01.000000000","message":"Same reason as create filesystem.  The logic here is used to address the timeout retry.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        try:"},{"line_number":182,"context_line":"            snap.delete()"},{"line_number":183,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":184,"context_line":"            LOG.info(_LI(\u0027The snapshot is already removed.\u0027))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def get_pool(self, name\u003dNone):"},{"line_number":187,"context_line":"        return self.system.get_pool(name\u003dname)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_8c31045d","line":184,"range":{"start_line":184,"start_character":12,"end_line":184,"end_character":61},"updated":"2016-05-16 13:12:33.000000000","message":"Which snapshot?","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        try:"},{"line_number":182,"context_line":"            snap.delete()"},{"line_number":183,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":184,"context_line":"            LOG.info(_LI(\u0027The snapshot is already removed.\u0027))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def get_pool(self, name\u003dNone):"},{"line_number":187,"context_line":"        return self.system.get_pool(name\u003dname)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_b68e7025","line":184,"range":{"start_line":184,"start_character":12,"end_line":184,"end_character":61},"in_reply_to":"dab17558_8c31045d","updated":"2016-05-18 08:19:01.000000000","message":"Fixed.  Thanks.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":184,"context_line":"            LOG.info(_LI(\u0027The snapshot is already removed.\u0027))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def get_pool(self, name\u003dNone):"},{"line_number":187,"context_line":"        return self.system.get_pool(name\u003dname)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def get_storage_processor(self, sp_id):"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_6c4780bc","line":186,"range":{"start_line":186,"start_character":27,"end_line":186,"end_character":33},"updated":"2016-05-16 13:12:33.000000000","message":"Is case with None is valid? If not, then default None value should be absent.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":184,"context_line":"            LOG.info(_LI(\u0027The snapshot is already removed.\u0027))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def get_pool(self, name\u003dNone):"},{"line_number":187,"context_line":"        return self.system.get_pool(name\u003dname)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def get_storage_processor(self, sp_id):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_16a01c90","line":186,"range":{"start_line":186,"start_character":27,"end_line":186,"end_character":33},"in_reply_to":"dab17558_6c4780bc","updated":"2016-05-18 08:19:01.000000000","message":"Yes, it\u0027s valid.  If no name is supplied, it will return all pools available.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3aac3feb9c1eecfd9107881ab4d4876a8861d948","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        elif proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":69,"context_line":"            return self.system.get_nfs_share(name\u003dname)"},{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            raise exception.InvalidShare("},{"line_number":72,"context_line":"                reason\u003d_(\u0027Invalid NAS protocol supplied: %s.\u0027) % share_proto)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def delete_share(self, share):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_458b17c3","line":71,"range":{"start_line":71,"start_character":28,"end_line":71,"end_character":40},"updated":"2016-06-15 03:50:03.000000000","message":"s/ InvalidShare / InvalidShareAccess","commit_id":"9091e29be889dc55b2767fbcbb3b29ed0aefa51c"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"79be08394fa57f558c23b5aa76501a433f02b142","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        elif proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":69,"context_line":"            return self.system.get_nfs_share(name\u003dname)"},{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            raise exception.InvalidShare("},{"line_number":72,"context_line":"                reason\u003d_(\u0027Invalid NAS protocol supplied: %s.\u0027) % share_proto)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def delete_share(self, share):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_f53c38c1","line":71,"range":{"start_line":71,"start_character":28,"end_line":71,"end_character":40},"in_reply_to":"7aa08908_458b17c3","updated":"2016-06-16 05:34:52.000000000","message":"Done","commit_id":"9091e29be889dc55b2767fbcbb3b29ed0aefa51c"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d2240824e0de32b2cfd29eec30402a93f2a20e2b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        elif proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":69,"context_line":"            return self.system.get_nfs_share(name\u003dname)"},{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            raise exception.InvalidShareAccess("},{"line_number":72,"context_line":"                reason\u003d_(\u0027Invalid NAS protocol supplied: %s.\u0027) % share_proto)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def delete_share(self, share):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_bf5ef1e6","line":71,"range":{"start_line":71,"start_character":28,"end_line":71,"end_character":46},"updated":"2016-06-22 21:56:48.000000000","message":"InvalidShareAccess is about access rules, so this doesn\u0027t seem the best exception choice.  EMCUnityError or InvalidInput would be fine choices here.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        elif proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":69,"context_line":"            return self.system.get_nfs_share(name\u003dname)"},{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            raise exception.InvalidShareAccess("},{"line_number":72,"context_line":"                reason\u003d_(\u0027Invalid NAS protocol supplied: %s.\u0027) % share_proto)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def delete_share(self, share):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_6702370d","line":71,"range":{"start_line":71,"start_character":28,"end_line":71,"end_character":46},"in_reply_to":"3aaa91ec_bf5ef1e6","updated":"2016-06-23 05:45:48.000000000","message":"Thanks.  I think InvalidInput is more friendly to the user.  Switch to InvalidInput.\n\nBased on another comment, I am updating it to `BadConfigurationException`.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"cb83cf5e94fe1006797f322c4f42a0c6d7db8559","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_log import log"},{"line_number":20,"context_line":"from oslo_utils import importutils"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"storops \u003d importutils.try_import(\u0027storops\u0027)"},{"line_number":23,"context_line":"if storops:"},{"line_number":24,"context_line":"    from storops import exception as storops_ex"},{"line_number":25,"context_line":"    from storops.unity import enums"}],"source_content_type":"text/x-python","patch_set":30,"id":"dada55a8_7c9aca6f","line":22,"updated":"2016-07-25 13:20:27.000000000","message":"Why is the try_import needed? Isn\u0027t the client anyway directly throwing an exception if an instance is created and storops is not available?\nI wonder if we want to have storops in the global-requirements?\nAnd if not I would at least log a warning that storops must be installed.","commit_id":"141cf4bd97cf06347391ae294ab17130419c7e6e"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"1f9acbd92e03a10bef93b05b325e418894fe4452","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_log import log"},{"line_number":20,"context_line":"from oslo_utils import importutils"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"storops \u003d importutils.try_import(\u0027storops\u0027)"},{"line_number":23,"context_line":"if storops:"},{"line_number":24,"context_line":"    from storops import exception as storops_ex"},{"line_number":25,"context_line":"    from storops.unity import enums"}],"source_content_type":"text/x-python","patch_set":30,"id":"dada55a8_bf97ef8e","line":22,"in_reply_to":"dada55a8_7c9aca6f","updated":"2016-07-26 03:00:45.000000000","message":"Thanks.  StorOps is required and as discussed, we cannot add it to the manila requirement because it\u0027s needed by the third party driver only.\nI added an error log if storops is not installed.","commit_id":"141cf4bd97cf06347391ae294ab17130419c7e6e"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"cb83cf5e94fe1006797f322c4f42a0c6d7db8559","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def __init__(self, host, username, password):"},{"line_number":36,"context_line":"        self.system \u003d storops.UnitySystem(host, username, password)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def create_cifs_share(self, resource, share_name):"},{"line_number":39,"context_line":"        \"\"\"Create CIFS share from the resource."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        :param resource: either UnityFilesystem or UnitySnap object"}],"source_content_type":"text/x-python","patch_set":30,"id":"dada55a8_5cd1c6fa","line":38,"updated":"2016-07-25 13:20:27.000000000","message":"nit: get_or_create_cifs_share() would be a better method name imo","commit_id":"141cf4bd97cf06347391ae294ab17130419c7e6e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"aafade5c65cef2bf7484b1a8534dbc8f09ce2671","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def __init__(self, host, username, password):"},{"line_number":36,"context_line":"        self.system \u003d storops.UnitySystem(host, username, password)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def create_cifs_share(self, resource, share_name):"},{"line_number":39,"context_line":"        \"\"\"Create CIFS share from the resource."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        :param resource: either UnityFilesystem or UnitySnap object"}],"source_content_type":"text/x-python","patch_set":30,"id":"dada55a8_1c18c9d2","line":38,"in_reply_to":"dada55a8_5cd1c6fa","updated":"2016-07-26 02:42:35.000000000","message":"It is normal to return a share object during the share creation. SO I would suggest to leave the function name as it is.","commit_id":"141cf4bd97cf06347391ae294ab17130419c7e6e"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"cb83cf5e94fe1006797f322c4f42a0c6d7db8559","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        except storops_ex.UnitySmbShareNameExistedError:"},{"line_number":48,"context_line":"            return self.get_share(share_name, \u0027CIFS\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def create_nfs_share(self, resource, share_name):"},{"line_number":51,"context_line":"        \"\"\"Create NFS share from the resource."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        :param resource: either UnityFilesystem or UnitySnap object"}],"source_content_type":"text/x-python","patch_set":30,"id":"dada55a8_bc060283","line":50,"updated":"2016-07-25 13:20:27.000000000","message":"same here","commit_id":"141cf4bd97cf06347391ae294ab17130419c7e6e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"aafade5c65cef2bf7484b1a8534dbc8f09ce2671","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        except storops_ex.UnitySmbShareNameExistedError:"},{"line_number":48,"context_line":"            return self.get_share(share_name, \u0027CIFS\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def create_nfs_share(self, resource, share_name):"},{"line_number":51,"context_line":"        \"\"\"Create NFS share from the resource."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        :param resource: either UnityFilesystem or UnitySnap object"}],"source_content_type":"text/x-python","patch_set":30,"id":"dada55a8_5c0ec18c","line":50,"in_reply_to":"dada55a8_bc060283","updated":"2016-07-26 02:42:35.000000000","message":"see my reply above.","commit_id":"141cf4bd97cf06347391ae294ab17130419c7e6e"}],"manila/share/drivers/emc/plugins/unity/connection.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.nas_server_pool \u003d None"},{"line_number":55,"context_line":"        self.storage_processor \u003d None"},{"line_number":56,"context_line":"        self.reserved_percentage \u003d None"},{"line_number":57,"context_line":"        self.driver_handles_share_servers \u003d True"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def connect(self, emc_share_driver, context):"},{"line_number":60,"context_line":"        \"\"\"Connect to Unity storage.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b973b3b3","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":48},"updated":"2016-05-04 11:57:24.000000000","message":"This could be class attr too as well as IP_ALLOCATIONS. Why do you init them differently?","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.nas_server_pool \u003d None"},{"line_number":55,"context_line":"        self.storage_processor \u003d None"},{"line_number":56,"context_line":"        self.reserved_percentage \u003d None"},{"line_number":57,"context_line":"        self.driver_handles_share_servers \u003d True"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def connect(self, emc_share_driver, context):"},{"line_number":60,"context_line":"        \"\"\"Connect to Unity storage.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_04521235","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":48},"in_reply_to":"1a122d0e_b973b3b3","updated":"2016-05-05 11:18:30.000000000","message":"It\u0027s a property of the super class `StorageConnection`.  I could move it to a class member but I think it would cause unnecessary confusion.  I will add comment here to state it\u0027s an value assignment rather than a property initialization.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f67875d4f79a67a3eee5dc87b7bc360f0967ba22","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.storage_processor \u003d self.client.get_storage_processor("},{"line_number":77,"context_line":"            sp_name.lower())"},{"line_number":78,"context_line":"        if self.storage_processor is None:"},{"line_number":79,"context_line":"            message \u003d (_LW(\"The storage processor %s does not exist or \""},{"line_number":80,"context_line":"                           \"is unavailable. Please reconfigure it in \""},{"line_number":81,"context_line":"                           \"cinder.conf.\"), sp_name)"},{"line_number":82,"context_line":"            LOG.error(message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_5349a0b6","line":79,"range":{"start_line":79,"start_character":24,"end_line":79,"end_character":26},"updated":"2016-05-04 11:09:09.000000000","message":"you are using _LW here, but then LOG.error. One of them is wrong.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.storage_processor \u003d self.client.get_storage_processor("},{"line_number":77,"context_line":"            sp_name.lower())"},{"line_number":78,"context_line":"        if self.storage_processor is None:"},{"line_number":79,"context_line":"            message \u003d (_LW(\"The storage processor %s does not exist or \""},{"line_number":80,"context_line":"                           \"is unavailable. Please reconfigure it in \""},{"line_number":81,"context_line":"                           \"cinder.conf.\"), sp_name)"},{"line_number":82,"context_line":"            LOG.error(message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_af05f710","line":79,"range":{"start_line":79,"start_character":24,"end_line":79,"end_character":26},"in_reply_to":"1a122d0e_5349a0b6","updated":"2016-05-05 11:18:30.000000000","message":"Good catch.  Updated.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f67875d4f79a67a3eee5dc87b7bc360f0967ba22","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            self.nas_server_pool \u003d self.client.get_pool("},{"line_number":92,"context_line":"                emc_share_driver.configuration.emc_nas_server_pool)"},{"line_number":93,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":94,"context_line":"            message \u003d (_LW(\"The storage pools %s to store nas server \""},{"line_number":95,"context_line":"                           \"configuration do not exist.\"),"},{"line_number":96,"context_line":"                       self.nas_server_pool.name)"},{"line_number":97,"context_line":"            LOG.error(message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b3c63414","line":94,"range":{"start_line":94,"start_character":23,"end_line":94,"end_character":27},"updated":"2016-05-04 11:09:09.000000000","message":"same as above","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            self.nas_server_pool \u003d self.client.get_pool("},{"line_number":92,"context_line":"                emc_share_driver.configuration.emc_nas_server_pool)"},{"line_number":93,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":94,"context_line":"            message \u003d (_LW(\"The storage pools %s to store nas server \""},{"line_number":95,"context_line":"                           \"configuration do not exist.\"),"},{"line_number":96,"context_line":"                       self.nas_server_pool.name)"},{"line_number":97,"context_line":"            LOG.error(message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_af221752","line":94,"range":{"start_line":94,"start_character":23,"end_line":94,"end_character":27},"in_reply_to":"1a122d0e_b3c63414","updated":"2016-05-05 11:18:30.000000000","message":"Done","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f67875d4f79a67a3eee5dc87b7bc360f0967ba22","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        pool \u003d self.client.get_pool(pool_name)"},{"line_number":119,"context_line":"        nas_server \u003d self.client.get_nas_server(server_name)"},{"line_number":120,"context_line":"        if nas_server is None:"},{"line_number":121,"context_line":"            message \u003d (_(\"Failed to get NAS server %(server)s when \""},{"line_number":122,"context_line":"                         \"creating the share %(share)s.\") %"},{"line_number":123,"context_line":"                       {\u0027server\u0027: server_name, \u0027share\u0027: share_name})"},{"line_number":124,"context_line":"            LOG.error(message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_3302243f","line":121,"range":{"start_line":121,"start_character":23,"end_line":121,"end_character":26},"updated":"2016-05-04 11:09:09.000000000","message":"_LE","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        pool \u003d self.client.get_pool(pool_name)"},{"line_number":119,"context_line":"        nas_server \u003d self.client.get_nas_server(server_name)"},{"line_number":120,"context_line":"        if nas_server is None:"},{"line_number":121,"context_line":"            message \u003d (_(\"Failed to get NAS server %(server)s when \""},{"line_number":122,"context_line":"                         \"creating the share %(share)s.\") %"},{"line_number":123,"context_line":"                       {\u0027server\u0027: server_name, \u0027share\u0027: share_name})"},{"line_number":124,"context_line":"            LOG.error(message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_ef208f4b","line":121,"range":{"start_line":121,"start_character":23,"end_line":121,"end_character":26},"in_reply_to":"1a122d0e_3302243f","updated":"2016-05-05 11:18:30.000000000","message":"Done","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            LOG.error(message)"},{"line_number":125,"context_line":"            raise exception.EMCUnityError(err\u003dmessage)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        filesystem \u003d self.client.create_filesystem("},{"line_number":128,"context_line":"            pool, nas_server, share_name, size, proto\u003dproto_enum)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        location \u003d None"},{"line_number":131,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b9cf33b2","line":128,"range":{"start_line":127,"start_character":8,"end_line":128,"end_character":65},"updated":"2016-05-04 11:57:24.000000000","message":"You should not create file system if incorrect share protocol was provided.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            LOG.error(message)"},{"line_number":125,"context_line":"            raise exception.EMCUnityError(err\u003dmessage)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        filesystem \u003d self.client.create_filesystem("},{"line_number":128,"context_line":"            pool, nas_server, share_name, size, proto\u003dproto_enum)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        location \u003d None"},{"line_number":131,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_4fd8a353","line":128,"range":{"start_line":127,"start_character":8,"end_line":128,"end_character":65},"in_reply_to":"1a122d0e_b9cf33b2","updated":"2016-05-05 11:18:30.000000000","message":"We will not reach here if incorrect share protocol was provided.\nThe type check is done at line 111.  An exception will be thrown if share type not recognized.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"            cifs_share.enable_ace()"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"            location \u003d [\u0027\\\\%(interface)s\\%(share_name)s\u0027 %"},{"line_number":137,"context_line":"                        {\u0027interface\u0027: interface.ip_address,"},{"line_number":138,"context_line":"                         \u0027share_name\u0027: share_name}"},{"line_number":139,"context_line":"                        for interface in nas_server.file_interface]"},{"line_number":140,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":141,"context_line":"            self.client.create_nfs_share(filesystem, share_name)"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f9824bc7","line":139,"range":{"start_line":136,"start_character":12,"end_line":139,"end_character":67},"updated":"2016-05-04 11:57:24.000000000","message":"It is incorrect format to return. It should be list of dicts starting with API v2.9\n\nExample: https://github.com/openstack/manila/blob/bf24cdba/manila/share/drivers/zfsonlinux/utils.py#L205\n\nSame below.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"f26c66c29973c906fa59a8f139c7e69a5ea837c9","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"            cifs_share.enable_ace()"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"            location \u003d [\u0027\\\\%(interface)s\\%(share_name)s\u0027 %"},{"line_number":137,"context_line":"                        {\u0027interface\u0027: interface.ip_address,"},{"line_number":138,"context_line":"                         \u0027share_name\u0027: share_name}"},{"line_number":139,"context_line":"                        for interface in nas_server.file_interface]"},{"line_number":140,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":141,"context_line":"            self.client.create_nfs_share(filesystem, share_name)"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_4e096231","line":139,"range":{"start_line":136,"start_character":12,"end_line":139,"end_character":67},"in_reply_to":"1a122d0e_f9824bc7","updated":"2016-05-06 06:27:35.000000000","message":"Updated to dict.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f67875d4f79a67a3eee5dc87b7bc360f0967ba22","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        nas_server \u003d self.client.get_nas_server(server_name)"},{"line_number":164,"context_line":"        if nas_server is None:"},{"line_number":165,"context_line":"            message \u003d (_(\"Failed to get NAS server %(server)s when \""},{"line_number":166,"context_line":"                         \"creating the share %(share)s.\") %"},{"line_number":167,"context_line":"                       {\u0027server\u0027: server_name, \u0027share\u0027: share_name})"},{"line_number":168,"context_line":"            LOG.error(message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_93333813","line":165,"range":{"start_line":165,"start_character":23,"end_line":165,"end_character":24},"updated":"2016-05-04 11:09:09.000000000","message":"_LE","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        nas_server \u003d self.client.get_nas_server(server_name)"},{"line_number":164,"context_line":"        if nas_server is None:"},{"line_number":165,"context_line":"            message \u003d (_(\"Failed to get NAS server %(server)s when \""},{"line_number":166,"context_line":"                         \"creating the share %(share)s.\") %"},{"line_number":167,"context_line":"                       {\u0027server\u0027: server_name, \u0027share\u0027: share_name})"},{"line_number":168,"context_line":"            LOG.error(message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_2f90c7ec","line":165,"range":{"start_line":165,"start_character":23,"end_line":165,"end_character":24},"in_reply_to":"1a122d0e_93333813","updated":"2016-05-05 11:18:30.000000000","message":"Done.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f67875d4f79a67a3eee5dc87b7bc360f0967ba22","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":222,"context_line":"        if new_size \u003c share[\u0027size\u0027]:"},{"line_number":223,"context_line":"            message \u003d (_(\"Failed to extend file system %(name)s because new \""},{"line_number":224,"context_line":"                         \"size %(new_size)d is smaller than old size \""},{"line_number":225,"context_line":"                         \"%(size)d.\") %"},{"line_number":226,"context_line":"                       {\u0027name\u0027: share[\u0027id\u0027], \u0027new_size\u0027: new_size,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_33b0648b","line":223,"range":{"start_line":223,"start_character":23,"end_line":223,"end_character":25},"updated":"2016-05-04 11:09:09.000000000","message":"_LE","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":222,"context_line":"        if new_size \u003c share[\u0027size\u0027]:"},{"line_number":223,"context_line":"            message \u003d (_(\"Failed to extend file system %(name)s because new \""},{"line_number":224,"context_line":"                         \"size %(new_size)d is smaller than old size \""},{"line_number":225,"context_line":"                         \"%(size)d.\") %"},{"line_number":226,"context_line":"                       {\u0027name\u0027: share[\u0027id\u0027], \u0027new_size\u0027: new_size,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_ea3a3dcc","line":223,"range":{"start_line":223,"start_character":23,"end_line":223,"end_character":25},"in_reply_to":"1a122d0e_33b0648b","updated":"2016-05-05 11:18:30.000000000","message":"Done","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        snap \u003d self.client.get_snapshot(snapshot[\u0027id\u0027])"},{"line_number":260,"context_line":"        self.client.delete_snapshot(snap)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":263,"context_line":"        \"\"\"Allow access to a share.\"\"\""},{"line_number":264,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":265,"context_line":"        if access_level not in const.ACCESS_LEVELS:"},{"line_number":266,"context_line":"            raise exception.InvalidShareAccessLevel(level\u003daccess_level)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].upper()"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        self._validate_share_protocol(share_proto)"},{"line_number":271,"context_line":"        self._validate_share_access_type(share, access)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":274,"context_line":"            self._cifs_allow_access(share, access)"},{"line_number":275,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":276,"context_line":"            self._nfs_allow_access(share, access)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def deny_access(self, context, share, access, share_server):"},{"line_number":279,"context_line":"        \"\"\"Deny access to a share.\"\"\""},{"line_number":280,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].upper()"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        self._validate_share_protocol(share_proto)"},{"line_number":283,"context_line":"        self._validate_share_access_type(share, access)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":286,"context_line":"            self._cifs_deny_access(share, access)"},{"line_number":287,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":288,"context_line":"            self._nfs_deny_access(share, access)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def ensure_share(self, context, share, share_server):"},{"line_number":291,"context_line":"        \"\"\"Ensure that the share is exported.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b90453c6","line":288,"range":{"start_line":262,"start_character":4,"end_line":288,"end_character":48},"updated":"2016-05-04 11:57:24.000000000","message":"It should be replaced with \"update_access\" interface.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"f26c66c29973c906fa59a8f139c7e69a5ea837c9","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        snap \u003d self.client.get_snapshot(snapshot[\u0027id\u0027])"},{"line_number":260,"context_line":"        self.client.delete_snapshot(snap)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":263,"context_line":"        \"\"\"Allow access to a share.\"\"\""},{"line_number":264,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":265,"context_line":"        if access_level not in const.ACCESS_LEVELS:"},{"line_number":266,"context_line":"            raise exception.InvalidShareAccessLevel(level\u003daccess_level)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].upper()"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        self._validate_share_protocol(share_proto)"},{"line_number":271,"context_line":"        self._validate_share_access_type(share, access)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":274,"context_line":"            self._cifs_allow_access(share, access)"},{"line_number":275,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":276,"context_line":"            self._nfs_allow_access(share, access)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def deny_access(self, context, share, access, share_server):"},{"line_number":279,"context_line":"        \"\"\"Deny access to a share.\"\"\""},{"line_number":280,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].upper()"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        self._validate_share_protocol(share_proto)"},{"line_number":283,"context_line":"        self._validate_share_access_type(share, access)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":286,"context_line":"            self._cifs_deny_access(share, access)"},{"line_number":287,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":288,"context_line":"            self._nfs_deny_access(share, access)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def ensure_share(self, context, share, share_server):"},{"line_number":291,"context_line":"        \"\"\"Ensure that the share is exported.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_09b594cc","line":288,"range":{"start_line":262,"start_character":4,"end_line":288,"end_character":48},"in_reply_to":"1a122d0e_b90453c6","updated":"2016-05-06 06:27:35.000000000","message":"Updated.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                total_size \u003d float(pool.size_total)"},{"line_number":301,"context_line":"                used_size \u003d float(pool.size_used)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"                pool_stat \u003d dict("},{"line_number":304,"context_line":"                    pool_name\u003dpool.name,"},{"line_number":305,"context_line":"                    total_capacity_gb\u003dtotal_size,"},{"line_number":306,"context_line":"                    free_capacity_gb\u003dtotal_size - used_size,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_791abb18","line":303,"range":{"start_line":303,"start_character":28,"end_line":303,"end_character":33},"updated":"2016-05-04 11:57:24.000000000","message":"Please, do not use \"dict\" classes. Use dict comprehensions - {}. It works faster from interpreter point of view.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                total_size \u003d float(pool.size_total)"},{"line_number":301,"context_line":"                used_size \u003d float(pool.size_used)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"                pool_stat \u003d dict("},{"line_number":304,"context_line":"                    pool_name\u003dpool.name,"},{"line_number":305,"context_line":"                    total_capacity_gb\u003dtotal_size,"},{"line_number":306,"context_line":"                    free_capacity_gb\u003dtotal_size - used_size,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_4a87f160","line":303,"range":{"start_line":303,"start_character":28,"end_line":303,"end_character":33},"in_reply_to":"1a122d0e_791abb18","updated":"2016-05-05 11:18:30.000000000","message":"I am changing it to `{}`.  But I think the dict class has its advantage.  We could avoid all the unnecessary quotes.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                )"},{"line_number":310,"context_line":"                stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        if \u0027pools\u0027 not in stats_dict or not stats_dict[\u0027pools\u0027]:"},{"line_number":313,"context_line":"            message \u003d _(\"Failed to update storage pool.\")"},{"line_number":314,"context_line":"            LOG.error(message)"},{"line_number":315,"context_line":"            raise exception.EMCUnityError(err\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f9dc0b48","line":312,"range":{"start_line":312,"start_character":8,"end_line":312,"end_character":63},"updated":"2016-05-04 11:57:24.000000000","message":"if not stats_dict.get(\"pools\"):","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                )"},{"line_number":310,"context_line":"                stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        if \u0027pools\u0027 not in stats_dict or not stats_dict[\u0027pools\u0027]:"},{"line_number":313,"context_line":"            message \u003d _(\"Failed to update storage pool.\")"},{"line_number":314,"context_line":"            LOG.error(message)"},{"line_number":315,"context_line":"            raise exception.EMCUnityError(err\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_ea96bd92","line":312,"range":{"start_line":312,"start_character":8,"end_line":312,"end_character":63},"in_reply_to":"1a122d0e_f9dc0b48","updated":"2016-05-05 11:18:30.000000000","message":"Good point.  Updated.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            for network in network_info[\u0027network_allocations\u0027]:"},{"line_number":339,"context_line":"                ip_addr \u003d network[\u0027ip_address\u0027]"},{"line_number":340,"context_line":"                netmask \u003d utils.cidr_to_netmask(network[\u0027cidr\u0027])"},{"line_number":341,"context_line":"                # TODO(jay.xu): Workaround to get gateway information"},{"line_number":342,"context_line":"                # gateway \u003d network[\u0027gateway\u0027]"},{"line_number":343,"context_line":"                ll \u003d ip_addr.split(\u0027.\u0027)"},{"line_number":344,"context_line":"                ll[-1] \u003d \u00271\u0027"},{"line_number":345,"context_line":"                gateway \u003d \u0027.\u0027.join(ll)"},{"line_number":346,"context_line":"                vlan_id \u003d network[\u0027segmentation_id\u0027]"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"                # Create the interfaces on NAS server"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_99a357b1","line":345,"range":{"start_line":341,"start_character":16,"end_line":345,"end_character":38},"updated":"2016-05-04 11:57:24.000000000","message":"Such workaround should not exist. Just make this commit be dependent on change that adds \"gateway\" to network_allocations model.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"061cd75b1f95f216a2f7e72d53a9712f6a6c702a","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            for network in network_info[\u0027network_allocations\u0027]:"},{"line_number":339,"context_line":"                ip_addr \u003d network[\u0027ip_address\u0027]"},{"line_number":340,"context_line":"                netmask \u003d utils.cidr_to_netmask(network[\u0027cidr\u0027])"},{"line_number":341,"context_line":"                # TODO(jay.xu): Workaround to get gateway information"},{"line_number":342,"context_line":"                # gateway \u003d network[\u0027gateway\u0027]"},{"line_number":343,"context_line":"                ll \u003d ip_addr.split(\u0027.\u0027)"},{"line_number":344,"context_line":"                ll[-1] \u003d \u00271\u0027"},{"line_number":345,"context_line":"                gateway \u003d \u0027.\u0027.join(ll)"},{"line_number":346,"context_line":"                vlan_id \u003d network[\u0027segmentation_id\u0027]"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"                # Create the interfaces on NAS server"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_f8d1cefc","line":345,"range":{"start_line":341,"start_character":16,"end_line":345,"end_character":38},"in_reply_to":"1a122d0e_99a357b1","updated":"2016-05-07 04:15:22.000000000","message":"Done","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                        # Enable NFS service with kerberos"},{"line_number":377,"context_line":"                        kerberos_enabled \u003d True"},{"line_number":378,"context_line":"                        # TODO(jay.xu): enable nfs service with kerberos"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"            if not kerberos_enabled:"},{"line_number":381,"context_line":"                # Enable NFS service without kerberos"},{"line_number":382,"context_line":"                self.client.enable_nfs_service(nas_server)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b9873311","line":379,"updated":"2016-05-04 11:57:24.000000000","message":"Case of \"ldap\" is silent \"ok\". It should be handled properly.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        server_name \u003d server_details.get(\u0027share_server_name\u0027)"},{"line_number":403,"context_line":"        if not server_name:"},{"line_number":404,"context_line":"            LOG.debug(\u0027No share server found in server details.\u0027)"},{"line_number":405,"context_line":"            return"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        username \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_99919749","line":404,"range":{"start_line":404,"start_character":12,"end_line":404,"end_character":65},"updated":"2016-05-04 11:57:24.000000000","message":"Better to add ID of share server.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        server_name \u003d server_details.get(\u0027share_server_name\u0027)"},{"line_number":403,"context_line":"        if not server_name:"},{"line_number":404,"context_line":"            LOG.debug(\u0027No share server found in server details.\u0027)"},{"line_number":405,"context_line":"            return"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        username \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_4abb71c4","line":404,"range":{"start_line":404,"start_character":12,"end_line":404,"end_character":65},"in_reply_to":"1a122d0e_99919749","updated":"2016-05-05 11:18:30.000000000","message":"Done.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"f69290fbd76d514bef4c9359153596df5a9deafe","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        # Get the real pools from the backend storage"},{"line_number":419,"context_line":"        real_pools \u003d set([pool.name for pool in self.client.get_pool()])"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        if pool_conf:"},{"line_number":422,"context_line":"            matched_pools \u003d set()"},{"line_number":423,"context_line":"            conf_pools \u003d set([item.strip() for item in pool_conf.split(\",\")])"},{"line_number":424,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_9784b60b","line":421,"range":{"start_line":421,"start_character":8,"end_line":421,"end_character":21},"updated":"2016-05-04 15:19:39.000000000","message":"I think it would be better to write\n\n  if not pool_conf:\n      LOG.debug(\"No storage pool is specified, ...\")\n      return real_pools\n\n  matched_pools \u003d set()\n  conf_pools \u003d set([item.strip() for item in pool_conf.split(\",\")])\n  ... continue with code ...\n\nThis would decrease the indent level for most of this method and therefore make it slightly easier to read.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        # Get the real pools from the backend storage"},{"line_number":419,"context_line":"        real_pools \u003d set([pool.name for pool in self.client.get_pool()])"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        if pool_conf:"},{"line_number":422,"context_line":"            matched_pools \u003d set()"},{"line_number":423,"context_line":"            conf_pools \u003d set([item.strip() for item in pool_conf.split(\",\")])"},{"line_number":424,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_ea3fdd22","line":421,"range":{"start_line":421,"start_character":8,"end_line":421,"end_character":21},"in_reply_to":"1a122d0e_9784b60b","updated":"2016-05-05 11:18:30.000000000","message":"Good point.  Done.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"f69290fbd76d514bef4c9359153596df5a9deafe","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"            for pool in real_pools:"},{"line_number":426,"context_line":"                for matcher in conf_pools:"},{"line_number":427,"context_line":"                    if fnmatch.fnmatchcase(pool, matcher):"},{"line_number":428,"context_line":"                        matched_pools.add(pool)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"            unmanaged_pools \u003d real_pools.difference(matched_pools)"},{"line_number":431,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_57f05e66","line":428,"range":{"start_line":427,"start_character":20,"end_line":428,"end_character":47},"updated":"2016-05-04 15:19:39.000000000","message":"Instead of adding pools to matched_pools and later compute the difference to get the unmanaged_pools, i think it would be more efficient to add an else clause here:\n\n  if fnmatch.fnmatchcase(pool, matcher):\n      matched_pools.add(pool)\n  else:\n      unmanaged_pools.add(pool)","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"            for pool in real_pools:"},{"line_number":426,"context_line":"                for matcher in conf_pools:"},{"line_number":427,"context_line":"                    if fnmatch.fnmatchcase(pool, matcher):"},{"line_number":428,"context_line":"                        matched_pools.add(pool)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"            unmanaged_pools \u003d real_pools.difference(matched_pools)"},{"line_number":431,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_6a18ed84","line":428,"range":{"start_line":427,"start_character":20,"end_line":428,"end_character":47},"in_reply_to":"1a122d0e_57f05e66","updated":"2016-05-05 11:18:30.000000000","message":"Done","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"f69290fbd76d514bef4c9359153596df5a9deafe","unresolved":false,"context_lines":[{"line_number":454,"context_line":"                  \"system will be managed.\")"},{"line_number":455,"context_line":"        return real_pools"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def _get_managed_ports(self, port_conf, sp):"},{"line_number":458,"context_line":"        # Get the real ports from the backend storage"},{"line_number":459,"context_line":"        real_ports \u003d set([port.id for port in self.client.get_ip_ports(sp)])"},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_5ad2435c","line":457,"updated":"2016-05-04 15:19:39.000000000","message":"It seems to me like _get_managed_pools and _get_managed_ports look nearly identical. Maybe it is possible to create a private method which contains the shared code to prevent code duplication.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":454,"context_line":"                  \"system will be managed.\")"},{"line_number":455,"context_line":"        return real_pools"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def _get_managed_ports(self, port_conf, sp):"},{"line_number":458,"context_line":"        # Get the real ports from the backend storage"},{"line_number":459,"context_line":"        real_ports \u003d set([port.id for port in self.client.get_ip_ports(sp)])"},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_14787bc3","line":457,"in_reply_to":"1a122d0e_5ad2435c","updated":"2016-05-05 11:18:30.000000000","message":"Done","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"f69290fbd76d514bef4c9359153596df5a9deafe","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        # Get the real ports from the backend storage"},{"line_number":459,"context_line":"        real_ports \u003d set([port.id for port in self.client.get_ip_ports(sp)])"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        if port_conf:"},{"line_number":462,"context_line":"            matched_ports \u003d set()"},{"line_number":463,"context_line":"            conf_ports \u003d set([item.strip() for item in port_conf.split(\",\")])"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_973dd6df","line":461,"range":{"start_line":461,"start_character":8,"end_line":461,"end_character":21},"updated":"2016-05-04 15:19:39.000000000","message":"Same as above with pool_conf: I think it would be better to write\n\n  if not port_conf:\n      LOG.debug(\"No ports is specified, ...\")\n      return real_ports\n\n  matched_ports \u003d set()\n  conf_ports \u003d set([item.strip() for item in port_conf.split(\",\")])\n  ... continue with code ...","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        # Get the real ports from the backend storage"},{"line_number":459,"context_line":"        real_ports \u003d set([port.id for port in self.client.get_ip_ports(sp)])"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        if port_conf:"},{"line_number":462,"context_line":"            matched_ports \u003d set()"},{"line_number":463,"context_line":"            conf_ports \u003d set([item.strip() for item in port_conf.split(\",\")])"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_9eff8a00","line":461,"range":{"start_line":461,"start_character":8,"end_line":461,"end_character":21},"in_reply_to":"1a122d0e_973dd6df","updated":"2016-05-05 11:18:30.000000000","message":"Done","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"f69290fbd76d514bef4c9359153596df5a9deafe","unresolved":false,"context_lines":[{"line_number":464,"context_line":""},{"line_number":465,"context_line":"            for port in real_ports:"},{"line_number":466,"context_line":"                for matcher in conf_ports:"},{"line_number":467,"context_line":"                    if fnmatch.fnmatchcase(port, matcher):"},{"line_number":468,"context_line":"                        matched_ports.add(port)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"            unmanaged_ports \u003d real_ports.difference(matched_ports)"},{"line_number":471,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_da3bf3c6","line":468,"range":{"start_line":467,"start_character":20,"end_line":468,"end_character":47},"updated":"2016-05-04 15:19:39.000000000","message":"Same as above: instead of adding ports to matched_ports and later compute the difference to get the unmanaged_ports, i think it would be more efficient to add an else clause here:\n\n  if fnmatch.fnmatchcase(port, matcher):\n      matched_ports.add(port)\n  else:\n      unmanaged_ports.add(port)","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":464,"context_line":""},{"line_number":465,"context_line":"            for port in real_ports:"},{"line_number":466,"context_line":"                for matcher in conf_ports:"},{"line_number":467,"context_line":"                    if fnmatch.fnmatchcase(port, matcher):"},{"line_number":468,"context_line":"                        matched_ports.add(port)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"            unmanaged_ports \u003d real_ports.difference(matched_ports)"},{"line_number":471,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f4adff31","line":468,"range":{"start_line":467,"start_character":20,"end_line":468,"end_character":47},"in_reply_to":"1a122d0e_da3bf3c6","updated":"2016-05-05 11:18:30.000000000","message":"Done","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"f69290fbd76d514bef4c9359153596df5a9deafe","unresolved":false,"context_lines":[{"line_number":565,"context_line":"    @staticmethod"},{"line_number":566,"context_line":"    def _is_isolated_filesystem(filesystem):"},{"line_number":567,"context_line":"        filesystem.update()"},{"line_number":568,"context_line":"        if (filesystem.snap_count \u003d\u003d 0 and not filesystem.cifs_share and"},{"line_number":569,"context_line":"                not filesystem.nfs_share):"},{"line_number":570,"context_line":"            return True"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        return False"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"    @staticmethod"},{"line_number":575,"context_line":"    def _is_share_from_snapshot(share):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_5ad52319","line":572,"range":{"start_line":568,"start_character":8,"end_line":572,"end_character":20},"updated":"2016-05-04 15:19:39.000000000","message":"You could shorten these lines to\n\n  return filesystem.snap_count \u003d\u003d 0 and not filesystem.cifs_share and not filesystem.nfs_share","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":565,"context_line":"    @staticmethod"},{"line_number":566,"context_line":"    def _is_isolated_filesystem(filesystem):"},{"line_number":567,"context_line":"        filesystem.update()"},{"line_number":568,"context_line":"        if (filesystem.snap_count \u003d\u003d 0 and not filesystem.cifs_share and"},{"line_number":569,"context_line":"                not filesystem.nfs_share):"},{"line_number":570,"context_line":"            return True"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        return False"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"    @staticmethod"},{"line_number":575,"context_line":"    def _is_share_from_snapshot(share):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f4221fb8","line":572,"range":{"start_line":568,"start_character":8,"end_line":572,"end_character":20},"in_reply_to":"1a122d0e_5ad52319","updated":"2016-05-05 11:18:30.000000000","message":"Done","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        return False"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"    @staticmethod"},{"line_number":575,"context_line":"    def _is_share_from_snapshot(share):"},{"line_number":576,"context_line":"        return True if share.snap else False"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    @staticmethod"},{"line_number":579,"context_line":"    def _validate_share_access_type(share, access):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b92a93e5","line":576,"range":{"start_line":574,"start_character":4,"end_line":576,"end_character":44},"updated":"2016-05-04 11:57:24.000000000","message":"Those two cases where you use it, boolean is not really required. Therefore, you could just use \"share.snap\" there directly and remove this method.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        return False"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"    @staticmethod"},{"line_number":575,"context_line":"    def _is_share_from_snapshot(share):"},{"line_number":576,"context_line":"        return True if share.snap else False"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    @staticmethod"},{"line_number":579,"context_line":"    def _validate_share_access_type(share, access):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_d76a85b4","line":576,"range":{"start_line":574,"start_character":4,"end_line":576,"end_character":44},"in_reply_to":"1a122d0e_b92a93e5","updated":"2016-05-05 11:18:30.000000000","message":"I think this function name works as a comment.  If I change it to `share.snap`, I probably still need to add some comment to explain that we are actually check the type of this share. So I will keep it.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"4e9b76f4e628efb0bf38cc564216e2d3c1634ab2","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        # Check share\u0027s protocol."},{"line_number":118,"context_line":"        # Throw an exception immediately if it is an invalid protocol."},{"line_number":119,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].upper()"},{"line_number":120,"context_line":"        proto_enum \u003d self._get_proto_enum(share_proto)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        # Get pool name from share host field"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_6926aebb","line":119,"range":{"start_line":119,"start_character":22,"end_line":119,"end_character":50},"updated":"2016-05-07 10:50:47.000000000","message":"You call upper() here on share_proto.\nLater in _get_proto_enum(self, share_proto) you call it again in line 544.\nI think you can remove line 119 and just call\n\n  self._get_proto_enum(share[\u0027share_proto\u0027])","commit_id":"778ffba60efc2a70f226dcf180eb6f398f35e07c"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"ce294013c397d2c96fbe065ee86c684e5bc25db5","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        # Check share\u0027s protocol."},{"line_number":118,"context_line":"        # Throw an exception immediately if it is an invalid protocol."},{"line_number":119,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].upper()"},{"line_number":120,"context_line":"        proto_enum \u003d self._get_proto_enum(share_proto)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        # Get pool name from share host field"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_d002a30a","line":119,"range":{"start_line":119,"start_character":22,"end_line":119,"end_character":50},"in_reply_to":"dab17558_6926aebb","updated":"2016-05-10 03:15:14.000000000","message":"Thanks!  I have removed the call in the function because we will compare protocol at line 142 and 152 so I cannot remove the upper call at line 119.","commit_id":"778ffba60efc2a70f226dcf180eb6f398f35e07c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"58c979ed6d94b1456d821d8bb13d2a4b00587ea0","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                self.client.delete_filesystem(filesystem)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":236,"context_line":"        if new_size \u003c share[\u0027size\u0027]:"},{"line_number":237,"context_line":"            message \u003d (_LE(\"Failed to extend file system %(name)s because new \""},{"line_number":238,"context_line":"                           \"size %(new_size)d is smaller than old size \""},{"line_number":239,"context_line":"                           \"%(size)d.\") %"},{"line_number":240,"context_line":"                       {\u0027name\u0027: share[\u0027id\u0027], \u0027new_size\u0027: new_size,"},{"line_number":241,"context_line":"                        \u0027size\u0027: share[\u0027size\u0027]})"},{"line_number":242,"context_line":"            LOG.error(message)"},{"line_number":243,"context_line":"            raise exception.InvalidInput(reason\u003dmessage)"},{"line_number":244,"context_line":"        elif new_size \u003d\u003d share[\u0027size\u0027]:"},{"line_number":245,"context_line":"            return"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_c5d03f56","line":243,"range":{"start_line":236,"start_character":8,"end_line":243,"end_character":56},"updated":"2016-05-09 13:33:24.000000000","message":"the API handles this scenario, you do not need to handle it here.","commit_id":"778ffba60efc2a70f226dcf180eb6f398f35e07c"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"ce294013c397d2c96fbe065ee86c684e5bc25db5","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                self.client.delete_filesystem(filesystem)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":236,"context_line":"        if new_size \u003c share[\u0027size\u0027]:"},{"line_number":237,"context_line":"            message \u003d (_LE(\"Failed to extend file system %(name)s because new \""},{"line_number":238,"context_line":"                           \"size %(new_size)d is smaller than old size \""},{"line_number":239,"context_line":"                           \"%(size)d.\") %"},{"line_number":240,"context_line":"                       {\u0027name\u0027: share[\u0027id\u0027], \u0027new_size\u0027: new_size,"},{"line_number":241,"context_line":"                        \u0027size\u0027: share[\u0027size\u0027]})"},{"line_number":242,"context_line":"            LOG.error(message)"},{"line_number":243,"context_line":"            raise exception.InvalidInput(reason\u003dmessage)"},{"line_number":244,"context_line":"        elif new_size \u003d\u003d share[\u0027size\u0027]:"},{"line_number":245,"context_line":"            return"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_0b035a0e","line":243,"range":{"start_line":236,"start_character":8,"end_line":243,"end_character":56},"in_reply_to":"dab17558_c5d03f56","updated":"2016-05-10 03:15:14.000000000","message":"Thanks! Removed.","commit_id":"778ffba60efc2a70f226dcf180eb6f398f35e07c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"58c979ed6d94b1456d821d8bb13d2a4b00587ea0","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                        \u0027size\u0027: share[\u0027size\u0027]})"},{"line_number":242,"context_line":"            LOG.error(message)"},{"line_number":243,"context_line":"            raise exception.InvalidInput(reason\u003dmessage)"},{"line_number":244,"context_line":"        elif new_size \u003d\u003d share[\u0027size\u0027]:"},{"line_number":245,"context_line":"            return"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        backend_share \u003d self.client.get_share(share[\u0027id\u0027],"},{"line_number":248,"context_line":"                                              share[\u0027share_proto\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_05cb67a6","line":245,"range":{"start_line":244,"start_character":7,"end_line":245,"end_character":18},"updated":"2016-05-09 13:33:24.000000000","message":"same as above","commit_id":"778ffba60efc2a70f226dcf180eb6f398f35e07c"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"ce294013c397d2c96fbe065ee86c684e5bc25db5","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                        \u0027size\u0027: share[\u0027size\u0027]})"},{"line_number":242,"context_line":"            LOG.error(message)"},{"line_number":243,"context_line":"            raise exception.InvalidInput(reason\u003dmessage)"},{"line_number":244,"context_line":"        elif new_size \u003d\u003d share[\u0027size\u0027]:"},{"line_number":245,"context_line":"            return"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        backend_share \u003d self.client.get_share(share[\u0027id\u0027],"},{"line_number":248,"context_line":"                                              share[\u0027share_proto\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_ab14ce43","line":245,"range":{"start_line":244,"start_character":7,"end_line":245,"end_character":18},"in_reply_to":"dab17558_05cb67a6","updated":"2016-05-10 03:15:14.000000000","message":"Removed.","commit_id":"778ffba60efc2a70f226dcf180eb6f398f35e07c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \u0027emc_nas_pool_names\u0027)"},{"line_number":73,"context_line":"        self.pool_set \u003d self._get_managed_pools(pool_conf)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        self.reserved_percentage \u003d emc_share_driver.configuration.safe_get("},{"line_number":76,"context_line":"            \u0027reserved_share_percentage\u0027)"},{"line_number":77,"context_line":"        if self.reserved_percentage is None:"},{"line_number":78,"context_line":"            self.reserved_percentage \u003d 0"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self._config_sp(sp_name)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_2cdd78e0","line":78,"range":{"start_line":75,"start_character":8,"end_line":78,"end_character":40},"updated":"2016-05-16 13:12:33.000000000","message":"Why it is not in \"__init__\" method?","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d3a9372cc0a61bc511e8c8f8d5ce23f8e23fdd61","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \u0027emc_nas_pool_names\u0027)"},{"line_number":73,"context_line":"        self.pool_set \u003d self._get_managed_pools(pool_conf)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        self.reserved_percentage \u003d emc_share_driver.configuration.safe_get("},{"line_number":76,"context_line":"            \u0027reserved_share_percentage\u0027)"},{"line_number":77,"context_line":"        if self.reserved_percentage is None:"},{"line_number":78,"context_line":"            self.reserved_percentage \u003d 0"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self._config_sp(sp_name)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_5123bc05","line":78,"range":{"start_line":75,"start_character":8,"end_line":78,"end_character":40},"in_reply_to":"bab6814e_163c9c2e","updated":"2016-05-18 10:56:07.000000000","message":"Then it has bad design. \"configuration\" attr of a driver could be assigned to plugin on init step.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"ef857537bd8c71aa28ed1008ff8b319dc7ed138f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \u0027emc_nas_pool_names\u0027)"},{"line_number":73,"context_line":"        self.pool_set \u003d self._get_managed_pools(pool_conf)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        self.reserved_percentage \u003d emc_share_driver.configuration.safe_get("},{"line_number":76,"context_line":"            \u0027reserved_share_percentage\u0027)"},{"line_number":77,"context_line":"        if self.reserved_percentage is None:"},{"line_number":78,"context_line":"            self.reserved_percentage \u003d 0"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self._config_sp(sp_name)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_3f5cfe24","line":78,"range":{"start_line":75,"start_character":8,"end_line":78,"end_character":40},"in_reply_to":"bab6814e_5123bc05","updated":"2016-05-18 11:54:08.000000000","message":"I agree, but it\u0027s beyond my reach.  This connection class extends from driver.StorageConnection.  And the parent class is shared by other products.\nWe can discuss this with other product owners and file another bug to fix this.  It\u0027s really beyond the implementation of this driver.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \u0027emc_nas_pool_names\u0027)"},{"line_number":73,"context_line":"        self.pool_set \u003d self._get_managed_pools(pool_conf)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        self.reserved_percentage \u003d emc_share_driver.configuration.safe_get("},{"line_number":76,"context_line":"            \u0027reserved_share_percentage\u0027)"},{"line_number":77,"context_line":"        if self.reserved_percentage is None:"},{"line_number":78,"context_line":"            self.reserved_percentage \u003d 0"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self._config_sp(sp_name)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_163c9c2e","line":78,"range":{"start_line":75,"start_character":8,"end_line":78,"end_character":40},"in_reply_to":"dab17558_2cdd78e0","updated":"2016-05-18 08:19:01.000000000","message":"Because in \"__init__\" we don\u0027t have the reference to \"emc_share_driver\".","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if self.reserved_percentage is None:"},{"line_number":78,"context_line":"            self.reserved_percentage \u003d 0"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self._config_sp(sp_name)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        port_conf \u003d emc_share_driver.configuration.safe_get("},{"line_number":83,"context_line":"            \u0027emc_interface_ports\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_ac64c821","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":32},"updated":"2016-05-16 13:12:33.000000000","message":"It should be \"def check_for_setup_error(self):\"","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"ef857537bd8c71aa28ed1008ff8b319dc7ed138f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if self.reserved_percentage is None:"},{"line_number":78,"context_line":"            self.reserved_percentage \u003d 0"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self._config_sp(sp_name)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        port_conf \u003d emc_share_driver.configuration.safe_get("},{"line_number":83,"context_line":"            \u0027emc_interface_ports\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_1f9bfaca","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":32},"in_reply_to":"bab6814e_1149348c","updated":"2016-05-18 11:54:08.000000000","message":"As above, I don\u0027t have the capability to modify the driver interface that affects other plugins.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d3a9372cc0a61bc511e8c8f8d5ce23f8e23fdd61","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if self.reserved_percentage is None:"},{"line_number":78,"context_line":"            self.reserved_percentage \u003d 0"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self._config_sp(sp_name)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        port_conf \u003d emc_share_driver.configuration.safe_get("},{"line_number":83,"context_line":"            \u0027emc_interface_ports\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_1149348c","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":32},"in_reply_to":"bab6814e_f6d0f8cb","updated":"2016-05-18 10:56:07.000000000","message":"As above, just set \"configuration\" attr for plugin on init step.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if self.reserved_percentage is None:"},{"line_number":78,"context_line":"            self.reserved_percentage \u003d 0"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self._config_sp(sp_name)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        port_conf \u003d emc_share_driver.configuration.safe_get("},{"line_number":83,"context_line":"            \u0027emc_interface_ports\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_f6d0f8cb","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":32},"in_reply_to":"dab17558_ac64c821","updated":"2016-05-18 08:19:01.000000000","message":"The problem is check_for_setup_error do not have reference to \u0027emc_share_driver\u0027 and \u0027context\u0027.  Do you have any suggestion?","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        if not self._is_share_from_snapshot(backend_share):"},{"line_number":240,"context_line":"            backend_share.filesystem.extend(new_size * units.Gi)"},{"line_number":241,"context_line":"        else:"},{"line_number":242,"context_line":"            LOG.warning(_LW(\"Driver does not support extend share %s which is \""},{"line_number":243,"context_line":"                            \"created from snapshot.\"), share[\u0027id\u0027])"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":246,"context_line":"        \"\"\"Create snapshot from share.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_872c3f9a","line":243,"range":{"start_line":242,"start_character":12,"end_line":243,"end_character":67},"updated":"2016-05-16 13:12:33.000000000","message":"After it exception should be raised. For the moment driver reports \"ok\" and Manila will think everything went smoothly.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        if not self._is_share_from_snapshot(backend_share):"},{"line_number":240,"context_line":"            backend_share.filesystem.extend(new_size * units.Gi)"},{"line_number":241,"context_line":"        else:"},{"line_number":242,"context_line":"            LOG.warning(_LW(\"Driver does not support extend share %s which is \""},{"line_number":243,"context_line":"                            \"created from snapshot.\"), share[\u0027id\u0027])"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":246,"context_line":"        \"\"\"Create snapshot from share.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_5948175c","line":243,"range":{"start_line":242,"start_character":12,"end_line":243,"end_character":67},"in_reply_to":"dab17558_872c3f9a","updated":"2016-05-18 08:19:01.000000000","message":"Fixed.  Raise a ShareExtendingError instead.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            self._nfs_deny_access(share, access)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def ensure_share(self, context, share, share_server):"},{"line_number":316,"context_line":"        \"\"\"Ensure that the share is exported.\"\"\""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def update_share_stats(self, stats_dict):"},{"line_number":319,"context_line":"        \"\"\"Communicate with EMCNASClient to get the stats.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_0767afe9","line":316,"updated":"2016-05-16 13:12:33.000000000","message":"This method should verify that filesystem, at least, exists.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            self._nfs_deny_access(share, access)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def ensure_share(self, context, share, share_server):"},{"line_number":316,"context_line":"        \"\"\"Ensure that the share is exported.\"\"\""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def update_share_stats(self, stats_dict):"},{"line_number":319,"context_line":"        \"\"\"Communicate with EMCNASClient to get the stats.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_f9f2ab05","line":316,"in_reply_to":"dab17558_0767afe9","updated":"2016-05-18 08:19:01.000000000","message":"Add logic to check the existence of a share and raise ShareNotFound if share does not exist on the storage system.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":395,"context_line":"                    elif security_service[\u0027type\u0027] \u003d\u003d \u0027kerberos\u0027:"},{"line_number":396,"context_line":"                        # Enable NFS service with kerberos"},{"line_number":397,"context_line":"                        kerberos_enabled \u003d True"},{"line_number":398,"context_line":"                        # TODO(jay.xu): enable nfs service with kerberos"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"            if not kerberos_enabled:"},{"line_number":401,"context_line":"                # Enable NFS service without kerberos"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_67183b1f","line":398,"updated":"2016-05-16 13:12:33.000000000","message":"Better to log some messages saying that \"LDAP\" was ignored and \"Kerberos\" is not yet implemented.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":395,"context_line":"                    elif security_service[\u0027type\u0027] \u003d\u003d \u0027kerberos\u0027:"},{"line_number":396,"context_line":"                        # Enable NFS service with kerberos"},{"line_number":397,"context_line":"                        kerberos_enabled \u003d True"},{"line_number":398,"context_line":"                        # TODO(jay.xu): enable nfs service with kerberos"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"            if not kerberos_enabled:"},{"line_number":401,"context_line":"                # Enable NFS service without kerberos"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_99627fac","line":398,"in_reply_to":"dab17558_67183b1f","updated":"2016-05-18 08:19:01.000000000","message":"Added.  Thanks.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":416,"context_line":"    def teardown_server(self, server_details, security_services\u003dNone):"},{"line_number":417,"context_line":"        \"\"\"Teardown share server.\"\"\""},{"line_number":418,"context_line":"        if not server_details:"},{"line_number":419,"context_line":"            LOG.debug(\u0027Server details are empty.\u0027)"},{"line_number":420,"context_line":"            return"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        server_name \u003d server_details.get(\u0027share_server_name\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_07716f76","line":419,"range":{"start_line":419,"start_character":12,"end_line":419,"end_character":50},"updated":"2016-05-16 13:12:33.000000000","message":"Which server?","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d3a9372cc0a61bc511e8c8f8d5ce23f8e23fdd61","unresolved":false,"context_lines":[{"line_number":416,"context_line":"    def teardown_server(self, server_details, security_services\u003dNone):"},{"line_number":417,"context_line":"        \"\"\"Teardown share server.\"\"\""},{"line_number":418,"context_line":"        if not server_details:"},{"line_number":419,"context_line":"            LOG.debug(\u0027Server details are empty.\u0027)"},{"line_number":420,"context_line":"            return"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        server_name \u003d server_details.get(\u0027share_server_name\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_9ceedbea","line":419,"range":{"start_line":419,"start_character":12,"end_line":419,"end_character":50},"in_reply_to":"bab6814e_043bc6ec","updated":"2016-05-18 10:56:07.000000000","message":"Because whole \"share_server\" object with \"id\", \"status\", \"created_at\", etc values should have been provided.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"ef857537bd8c71aa28ed1008ff8b319dc7ed138f","unresolved":false,"context_lines":[{"line_number":416,"context_line":"    def teardown_server(self, server_details, security_services\u003dNone):"},{"line_number":417,"context_line":"        \"\"\"Teardown share server.\"\"\""},{"line_number":418,"context_line":"        if not server_details:"},{"line_number":419,"context_line":"            LOG.debug(\u0027Server details are empty.\u0027)"},{"line_number":420,"context_line":"            return"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        server_name \u003d server_details.get(\u0027share_server_name\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_cc55521e","line":419,"range":{"start_line":419,"start_character":12,"end_line":419,"end_character":50},"in_reply_to":"bab6814e_9ceedbea","updated":"2016-05-18 11:54:08.000000000","message":"I agree, but this change beyond my reach.  It\u0027s a method in driver.StorageConnection.  Modify of the parent class should not be in this commit.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":416,"context_line":"    def teardown_server(self, server_details, security_services\u003dNone):"},{"line_number":417,"context_line":"        \"\"\"Teardown share server.\"\"\""},{"line_number":418,"context_line":"        if not server_details:"},{"line_number":419,"context_line":"            LOG.debug(\u0027Server details are empty.\u0027)"},{"line_number":420,"context_line":"            return"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        server_name \u003d server_details.get(\u0027share_server_name\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_043bc6ec","line":419,"range":{"start_line":419,"start_character":12,"end_line":419,"end_character":50},"in_reply_to":"dab17558_07716f76","updated":"2016-05-18 08:19:01.000000000","message":"Details is empty so we don\u0027t know which server it is.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":539,"context_line":"            msg \u003d _(\u0027Share server not provided.\u0027)"},{"line_number":540,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        backend_details \u003d share_server.get(\u0027backend_details\u0027)"},{"line_number":543,"context_line":"        server_name \u003d backend_details.get("},{"line_number":544,"context_line":"            \u0027share_server_name\u0027) if backend_details else None"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"        if server_name is None:"},{"line_number":547,"context_line":"            msg \u003d _(\"No share server found.\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_87e39fd8","line":544,"range":{"start_line":542,"start_character":8,"end_line":544,"end_character":61},"updated":"2016-05-16 13:12:33.000000000","message":"server_name \u003d share_server.get(\u0027backend_details\u0027, {}).get(\u0027share_server_name\u0027)","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":539,"context_line":"            msg \u003d _(\u0027Share server not provided.\u0027)"},{"line_number":540,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        backend_details \u003d share_server.get(\u0027backend_details\u0027)"},{"line_number":543,"context_line":"        server_name \u003d backend_details.get("},{"line_number":544,"context_line":"            \u0027share_server_name\u0027) if backend_details else None"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"        if server_name is None:"},{"line_number":547,"context_line":"            msg \u003d _(\"No share server found.\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_c417fe52","line":544,"range":{"start_line":542,"start_character":8,"end_line":544,"end_character":61},"in_reply_to":"dab17558_87e39fd8","updated":"2016-05-18 08:19:01.000000000","message":"Fixed. Thanks.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            \u0027share_server_name\u0027) if backend_details else None"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"        if server_name is None:"},{"line_number":547,"context_line":"            msg \u003d _(\"No share server found.\")"},{"line_number":548,"context_line":"            LOG.error(msg)"},{"line_number":549,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":550,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_27d3d305","line":547,"range":{"start_line":547,"start_character":18,"end_line":547,"end_character":45},"updated":"2016-05-16 13:12:33.000000000","message":"Which share server?","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d3a9372cc0a61bc511e8c8f8d5ce23f8e23fdd61","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            \u0027share_server_name\u0027) if backend_details else None"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"        if server_name is None:"},{"line_number":547,"context_line":"            msg \u003d _(\"No share server found.\")"},{"line_number":548,"context_line":"            LOG.error(msg)"},{"line_number":549,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":550,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_bc9f5f5e","line":547,"range":{"start_line":547,"start_character":18,"end_line":547,"end_character":45},"in_reply_to":"bab6814e_0412a662","updated":"2016-05-18 10:56:07.000000000","message":"Same above. For such kind of error message use \"share_server_id\".","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"ef857537bd8c71aa28ed1008ff8b319dc7ed138f","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            \u0027share_server_name\u0027) if backend_details else None"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"        if server_name is None:"},{"line_number":547,"context_line":"            msg \u003d _(\"No share server found.\")"},{"line_number":548,"context_line":"            LOG.error(msg)"},{"line_number":549,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":550,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_4cede28a","line":547,"range":{"start_line":547,"start_character":18,"end_line":547,"end_character":45},"in_reply_to":"bab6814e_bc9f5f5e","updated":"2016-05-18 11:54:08.000000000","message":"Updated.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            \u0027share_server_name\u0027) if backend_details else None"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"        if server_name is None:"},{"line_number":547,"context_line":"            msg \u003d _(\"No share server found.\")"},{"line_number":548,"context_line":"            LOG.error(msg)"},{"line_number":549,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":550,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_0412a662","line":547,"range":{"start_line":547,"start_character":18,"end_line":547,"end_character":45},"in_reply_to":"dab17558_27d3d305","updated":"2016-05-18 08:19:01.000000000","message":"Failed to get name from share server.  So we don\u0027t know which server it is.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"68811aa09c10e51900c0ae59ca8af7cf6aa34ed0","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            share_id \u003d share[\u0027id\u0027]"},{"line_number":254,"context_line":"            reason \u003d (\"Driver does not support extend share %s which is \""},{"line_number":255,"context_line":"                      \"created from snapshot.\") % share_id"},{"line_number":256,"context_line":"            LOG.warning(_LW(reason))"},{"line_number":257,"context_line":"            raise exception.ShareExtendingError(share_id\u003dshare_id,"},{"line_number":258,"context_line":"                                                reason\u003dreason)"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_bc4bdf58","line":256,"range":{"start_line":256,"start_character":12,"end_line":256,"end_character":36},"updated":"2016-05-18 10:55:42.000000000","message":"LOG.warning(_LW(reason), share_id)\n\nBecause \"data\" should not be a part of not yet translated string. It should be added only after translation.","commit_id":"fe6bd87c4e77ef52359cec1f630e4a70d478e05f"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"72e3a7431cd007959dfab3f3fa8eadb9f60e4467","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            share_id \u003d share[\u0027id\u0027]"},{"line_number":254,"context_line":"            reason \u003d (\"Driver does not support extend share %s which is \""},{"line_number":255,"context_line":"                      \"created from snapshot.\") % share_id"},{"line_number":256,"context_line":"            LOG.warning(_LW(reason))"},{"line_number":257,"context_line":"            raise exception.ShareExtendingError(share_id\u003dshare_id,"},{"line_number":258,"context_line":"                                                reason\u003dreason)"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_e9be48fe","line":256,"range":{"start_line":256,"start_character":12,"end_line":256,"end_character":36},"in_reply_to":"bab6814e_bc4bdf58","updated":"2016-05-18 11:54:18.000000000","message":"Updated.  Thanks.","commit_id":"fe6bd87c4e77ef52359cec1f630e4a70d478e05f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"68811aa09c10e51900c0ae59ca8af7cf6aa34ed0","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                      \"created from snapshot.\") % share_id"},{"line_number":256,"context_line":"            LOG.warning(_LW(reason))"},{"line_number":257,"context_line":"            raise exception.ShareExtendingError(share_id\u003dshare_id,"},{"line_number":258,"context_line":"                                                reason\u003dreason)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":261,"context_line":"        \"\"\"Create snapshot from share.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_fc4c4778","line":258,"range":{"start_line":258,"start_character":55,"end_line":258,"end_character":61},"updated":"2016-05-18 10:55:42.000000000","message":"raise exception.ShareExtendingError(\n    share_id\u003dshare_id, reason\u003d_(reason) % share_id)","commit_id":"fe6bd87c4e77ef52359cec1f630e4a70d478e05f"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"72e3a7431cd007959dfab3f3fa8eadb9f60e4467","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                      \"created from snapshot.\") % share_id"},{"line_number":256,"context_line":"            LOG.warning(_LW(reason))"},{"line_number":257,"context_line":"            raise exception.ShareExtendingError(share_id\u003dshare_id,"},{"line_number":258,"context_line":"                                                reason\u003dreason)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":261,"context_line":"        \"\"\"Create snapshot from share.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_e96c889e","line":258,"range":{"start_line":258,"start_character":55,"end_line":258,"end_character":61},"in_reply_to":"bab6814e_fc4c4778","updated":"2016-05-18 11:54:18.000000000","message":"I updated it like this:\n\nreason \u003d _LW(\"Driver does not support extend share %s which is \"\n             \"created from snapshot.\") % share_id","commit_id":"fe6bd87c4e77ef52359cec1f630e4a70d478e05f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"68811aa09c10e51900c0ae59ca8af7cf6aa34ed0","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027]"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        backend_share \u003d self.client.get_share(share_name, share_proto)"},{"line_number":336,"context_line":"        if not backend_share.existed:"},{"line_number":337,"context_line":"            raise exception.ShareNotFound(share_id\u003dshare_name)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def update_share_stats(self, stats_dict):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_bc6c7f9d","line":336,"range":{"start_line":336,"start_character":29,"end_line":336,"end_character":36},"updated":"2016-05-18 10:55:42.000000000","message":"Why it is in past tense? When you verify that it exists \"now\"?","commit_id":"fe6bd87c4e77ef52359cec1f630e4a70d478e05f"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"72e3a7431cd007959dfab3f3fa8eadb9f60e4467","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027]"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        backend_share \u003d self.client.get_share(share_name, share_proto)"},{"line_number":336,"context_line":"        if not backend_share.existed:"},{"line_number":337,"context_line":"            raise exception.ShareNotFound(share_id\u003dshare_name)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def update_share_stats(self, stats_dict):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_09310ca3","line":336,"range":{"start_line":336,"start_character":29,"end_line":336,"end_character":36},"in_reply_to":"bab6814e_bc6c7f9d","updated":"2016-05-18 11:54:18.000000000","message":"It\u0027s the property on a third party instance.\nYou have the point.  But I cannot modify the name of the property in manila driver.","commit_id":"fe6bd87c4e77ef52359cec1f630e4a70d478e05f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"68811aa09c10e51900c0ae59ca8af7cf6aa34ed0","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                        # Enable NFS service with kerberos"},{"line_number":418,"context_line":"                        kerberos_enabled \u003d True"},{"line_number":419,"context_line":"                        # TODO(jay.xu): enable nfs service with kerberos"},{"line_number":420,"context_line":"                        LOG.warning(_LW(\u0027Kerberos is not supported in this \u0027"},{"line_number":421,"context_line":"                                        \u0027version.\u0027))"},{"line_number":422,"context_line":"                    elif security_service[\u0027type\u0027] \u003d\u003d \u0027ldap\u0027:"},{"line_number":423,"context_line":"                        LOG.warning(_LW(\u0027LDAP is not supported in this \u0027"},{"line_number":424,"context_line":"                                        \u0027version.\u0027))"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_dc3063a1","line":421,"range":{"start_line":420,"start_character":70,"end_line":421,"end_character":48},"updated":"2016-05-18 10:55:42.000000000","message":"Which this version? Version of what?","commit_id":"fe6bd87c4e77ef52359cec1f630e4a70d478e05f"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"72e3a7431cd007959dfab3f3fa8eadb9f60e4467","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                        # Enable NFS service with kerberos"},{"line_number":418,"context_line":"                        kerberos_enabled \u003d True"},{"line_number":419,"context_line":"                        # TODO(jay.xu): enable nfs service with kerberos"},{"line_number":420,"context_line":"                        LOG.warning(_LW(\u0027Kerberos is not supported in this \u0027"},{"line_number":421,"context_line":"                                        \u0027version.\u0027))"},{"line_number":422,"context_line":"                    elif security_service[\u0027type\u0027] \u003d\u003d \u0027ldap\u0027:"},{"line_number":423,"context_line":"                        LOG.warning(_LW(\u0027LDAP is not supported in this \u0027"},{"line_number":424,"context_line":"                                        \u0027version.\u0027))"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_098d8c31","line":421,"range":{"start_line":420,"start_character":70,"end_line":421,"end_character":48},"in_reply_to":"bab6814e_dc3063a1","updated":"2016-05-18 11:54:18.000000000","message":"Updated to:\n\"Kerberos is not supported by EMC Unity manila driver plugin.\"","commit_id":"fe6bd87c4e77ef52359cec1f630e4a70d478e05f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"81f97fa5724c277fa95b0563a493681da9db7ef3","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                         \"created from snapshot.\") % share_id"},{"line_number":256,"context_line":"            LOG.warning(reason)"},{"line_number":257,"context_line":"            raise exception.ShareExtendingError(share_id\u003dshare_id,"},{"line_number":258,"context_line":"                                                reason\u003dreason)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":261,"context_line":"        \"\"\"Create snapshot from share.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_d61dcdbe","line":258,"range":{"start_line":258,"start_character":54,"end_line":258,"end_character":61},"updated":"2016-05-18 15:18:48.000000000","message":"Not sure what will be in result, but better to use common \"_\" translation func when you provide it to exception.","commit_id":"fe776d3b19da9d2e4af17304e8d78540d9678c05"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"efe266bc3762aaebd80e185070ad88d0524b8493","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                         \"created from snapshot.\") % share_id"},{"line_number":256,"context_line":"            LOG.warning(reason)"},{"line_number":257,"context_line":"            raise exception.ShareExtendingError(share_id\u003dshare_id,"},{"line_number":258,"context_line":"                                                reason\u003dreason)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":261,"context_line":"        \"\"\"Create snapshot from share.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_7cb02944","line":258,"range":{"start_line":258,"start_character":54,"end_line":258,"end_character":61},"in_reply_to":"bab6814e_d61dcdbe","updated":"2016-05-19 03:28:54.000000000","message":"Thanks, updated.  After a second check, I think we could remove the log warning since we are raising an exception here.\nAnd I will wrap the message in _LE.","commit_id":"fe776d3b19da9d2e4af17304e8d78540d9678c05"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c60461bf9af017e8719d939ec3a02b119a069b45","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @staticmethod"},{"line_number":197,"context_line":"    def _get_cifs_location(file_interfaces, share_name):"},{"line_number":198,"context_line":"        return [{\u0027path\u0027: r\u0027\\\\%(interface)s\\%(share_name)s\u0027 %"},{"line_number":199,"context_line":"                         {\u0027interface\u0027: interface.ip_address,"},{"line_number":200,"context_line":"                          \u0027share_name\u0027: share_name}}"},{"line_number":201,"context_line":"                for interface in file_interfaces]"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @staticmethod"},{"line_number":204,"context_line":"    def _get_nfs_location(file_interfaces, share_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_b3e12c01","line":201,"range":{"start_line":198,"start_character":8,"end_line":201,"end_character":49},"updated":"2016-05-24 16:29:26.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists\n\nSame below.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"c20fd511373603c61a7bf191ec05b365eff506bb","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @staticmethod"},{"line_number":197,"context_line":"    def _get_cifs_location(file_interfaces, share_name):"},{"line_number":198,"context_line":"        return [{\u0027path\u0027: r\u0027\\\\%(interface)s\\%(share_name)s\u0027 %"},{"line_number":199,"context_line":"                         {\u0027interface\u0027: interface.ip_address,"},{"line_number":200,"context_line":"                          \u0027share_name\u0027: share_name}}"},{"line_number":201,"context_line":"                for interface in file_interfaces]"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @staticmethod"},{"line_number":204,"context_line":"    def _get_nfs_location(file_interfaces, share_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_fe2ec640","line":201,"range":{"start_line":198,"start_character":8,"end_line":201,"end_character":49},"in_reply_to":"bab6814e_b3e12c01","updated":"2016-05-25 04:13:32.000000000","message":"Updated.  Thanks.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c60461bf9af017e8719d939ec3a02b119a069b45","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                self.client.delete_filesystem(filesystem)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":236,"context_line":"        if new_size \u003c share[\u0027size\u0027]:"},{"line_number":237,"context_line":"            message \u003d (_LE(\"Failed to extend file system %(name)s because new \""},{"line_number":238,"context_line":"                           \"size %(new_size)d is smaller than old size \""},{"line_number":239,"context_line":"                           \"%(size)d.\") %"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_7330649f","line":236,"range":{"start_line":236,"start_character":20,"end_line":236,"end_character":21},"updated":"2016-05-24 16:29:26.000000000","message":"What about \"equal\" case?","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"c20fd511373603c61a7bf191ec05b365eff506bb","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                self.client.delete_filesystem(filesystem)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":236,"context_line":"        if new_size \u003c share[\u0027size\u0027]:"},{"line_number":237,"context_line":"            message \u003d (_LE(\"Failed to extend file system %(name)s because new \""},{"line_number":238,"context_line":"                           \"size %(new_size)d is smaller than old size \""},{"line_number":239,"context_line":"                           \"%(size)d.\") %"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_1ed3ca39","line":236,"range":{"start_line":236,"start_character":20,"end_line":236,"end_character":21},"in_reply_to":"bab6814e_7330649f","updated":"2016-05-25 04:13:32.000000000","message":"See line 244.  We do nothing for equal case.  The intention is to keep the share in a non-error state as much as possible.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c60461bf9af017e8719d939ec3a02b119a069b45","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        \"\"\"Returns number of network allocations for creating VIFs.\"\"\""},{"line_number":372,"context_line":"        return self.IP_ALLOCATIONS"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def setup_server(self, network_info, metadata\u003dNone):"},{"line_number":375,"context_line":"        \"\"\"Set up and configures share server with given network parameters.\"\"\""},{"line_number":376,"context_line":"        server_name \u003d network_info[\u0027server_id\u0027]"},{"line_number":377,"context_line":"        nas_server \u003d self.client.create_nas_server(server_name,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_b35bec2d","line":374,"range":{"start_line":374,"start_character":8,"end_line":374,"end_character":20},"updated":"2016-05-24 16:29:26.000000000","message":"Are you aware about admin network allocations availability?\n\nSee [1]. You may want to set some specific network for manila needs for all service actions and separate network for users.\n\n[1] https://github.com/openstack/manila/commit/e8e8adc2beee8874c1c6b996a99e2c9413e1b7c1","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"c20fd511373603c61a7bf191ec05b365eff506bb","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        \"\"\"Returns number of network allocations for creating VIFs.\"\"\""},{"line_number":372,"context_line":"        return self.IP_ALLOCATIONS"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def setup_server(self, network_info, metadata\u003dNone):"},{"line_number":375,"context_line":"        \"\"\"Set up and configures share server with given network parameters.\"\"\""},{"line_number":376,"context_line":"        server_name \u003d network_info[\u0027server_id\u0027]"},{"line_number":377,"context_line":"        nas_server \u003d self.client.create_nas_server(server_name,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_d962fcd7","line":374,"range":{"start_line":374,"start_character":8,"end_line":374,"end_character":20},"in_reply_to":"bab6814e_b35bec2d","updated":"2016-05-25 04:13:32.000000000","message":"No.  We do not support admin network allocations.  And we do not support share migration for now.  The support for admin network allocation will be added when we implement share migration.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"da4aac99f17df13ef97b305ba3a8204fd6117532","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        \"\"\"Returns number of network allocations for creating VIFs.\"\"\""},{"line_number":372,"context_line":"        return self.IP_ALLOCATIONS"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def setup_server(self, network_info, metadata\u003dNone):"},{"line_number":375,"context_line":"        \"\"\"Set up and configures share server with given network parameters.\"\"\""},{"line_number":376,"context_line":"        server_name \u003d network_info[\u0027server_id\u0027]"},{"line_number":377,"context_line":"        nas_server \u003d self.client.create_nas_server(server_name,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_0c8e1678","line":374,"range":{"start_line":374,"start_character":8,"end_line":374,"end_character":20},"in_reply_to":"bab6814e_d962fcd7","updated":"2016-06-06 16:01:36.000000000","message":"It is not related to share migration. It is other network interface(s) that are used only by manila/service needs. It allows you to have service traffic in different net pipeline than user\u0027s.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c60461bf9af017e8719d939ec3a02b119a069b45","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        real_ports \u003d set([port.id for port in self.client.get_ip_ports(sp)])"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        if not port_conf:"},{"line_number":519,"context_line":"            LOG.debug(\"No ports is specified, so all ports in storage \""},{"line_number":520,"context_line":"                      \"system will be managed.\")"},{"line_number":521,"context_line":"            return real_ports"},{"line_number":522,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_78c043e1","line":519,"range":{"start_line":519,"start_character":32,"end_line":519,"end_character":34},"updated":"2016-05-24 16:29:26.000000000","message":"s/is/are/","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"c20fd511373603c61a7bf191ec05b365eff506bb","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        real_ports \u003d set([port.id for port in self.client.get_ip_ports(sp)])"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        if not port_conf:"},{"line_number":519,"context_line":"            LOG.debug(\"No ports is specified, so all ports in storage \""},{"line_number":520,"context_line":"                      \"system will be managed.\")"},{"line_number":521,"context_line":"            return real_ports"},{"line_number":522,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_d9b95c30","line":519,"range":{"start_line":519,"start_character":32,"end_line":519,"end_character":34},"in_reply_to":"bab6814e_78c043e1","updated":"2016-05-25 04:13:32.000000000","message":"Done","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c60461bf9af017e8719d939ec3a02b119a069b45","unresolved":false,"context_lines":[{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def _cifs_deny_access(self, share, access):"},{"line_number":601,"context_line":"        \"\"\"Deny access to CIFS share.\"\"\""},{"line_number":602,"context_line":"        share_name \u003d share[\u0027id\u0027]"},{"line_number":603,"context_line":"        user_name \u003d access[\u0027access_to\u0027]"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"        self.client.cifs_deny_access(share_name, user_name)"},{"line_number":606,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_7864c348","line":603,"range":{"start_line":602,"start_character":8,"end_line":603,"end_character":39},"updated":"2016-05-24 16:29:26.000000000","message":"Such things looks redundant. Same for all such places here.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"c20fd511373603c61a7bf191ec05b365eff506bb","unresolved":false,"context_lines":[{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def _cifs_deny_access(self, share, access):"},{"line_number":601,"context_line":"        \"\"\"Deny access to CIFS share.\"\"\""},{"line_number":602,"context_line":"        share_name \u003d share[\u0027id\u0027]"},{"line_number":603,"context_line":"        user_name \u003d access[\u0027access_to\u0027]"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"        self.client.cifs_deny_access(share_name, user_name)"},{"line_number":606,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_f9d2605a","line":603,"range":{"start_line":602,"start_character":8,"end_line":603,"end_character":39},"in_reply_to":"bab6814e_7864c348","updated":"2016-05-25 04:13:32.000000000","message":"All updated.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c60461bf9af017e8719d939ec3a02b119a069b45","unresolved":false,"context_lines":[{"line_number":614,"context_line":"    @staticmethod"},{"line_number":615,"context_line":"    def _is_isolated_filesystem(filesystem):"},{"line_number":616,"context_line":"        filesystem.update()"},{"line_number":617,"context_line":"        return (filesystem.snap_count \u003d\u003d 0 and not filesystem.cifs_share and"},{"line_number":618,"context_line":"                not filesystem.nfs_share)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    @staticmethod"},{"line_number":621,"context_line":"    def _is_share_from_snapshot(share):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_78ba03c2","line":618,"range":{"start_line":617,"start_character":8,"end_line":618,"end_character":41},"updated":"2016-05-24 16:29:26.000000000","message":"return (\n    filesystem.snap_count \u003d\u003d 0 and\n    not (filesystem.cifs_share or filesystem.nfs_share)\n)","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"c20fd511373603c61a7bf191ec05b365eff506bb","unresolved":false,"context_lines":[{"line_number":614,"context_line":"    @staticmethod"},{"line_number":615,"context_line":"    def _is_isolated_filesystem(filesystem):"},{"line_number":616,"context_line":"        filesystem.update()"},{"line_number":617,"context_line":"        return (filesystem.snap_count \u003d\u003d 0 and not filesystem.cifs_share and"},{"line_number":618,"context_line":"                not filesystem.nfs_share)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    @staticmethod"},{"line_number":621,"context_line":"    def _is_share_from_snapshot(share):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_796dd098","line":618,"range":{"start_line":617,"start_character":8,"end_line":618,"end_character":41},"in_reply_to":"bab6814e_78ba03c2","updated":"2016-05-25 04:13:32.000000000","message":"Updated.  Thanks.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"45d3eeaf383dc696fdaf4011364dcf3ed5bcda44","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                        }"},{"line_number":205,"context_line":"            }"},{"line_number":206,"context_line":"            for interface in file_interfaces"},{"line_number":207,"context_line":"            ]"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @staticmethod"},{"line_number":210,"context_line":"    def _get_nfs_location(file_interfaces, share_name):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_11a8f11e","line":207,"range":{"start_line":207,"start_character":8,"end_line":207,"end_character":13},"updated":"2016-06-06 16:04:34.000000000","message":"return [\n    {\u0027path\u0027: r\u0027\\\\%(interface)s\\%(share_name)s\u0027 % {\n        \u0027interface\u0027: interface.ip_address,\n        \u0027share_name\u0027: share_name}\n    }\n    for interface in file_interfaces\n]","commit_id":"8d0e9ce81c308afe846f3590a2226adbce2ef704"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"04fd0102e594a0ca312da2b0f03931669ca4558a","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                        }"},{"line_number":205,"context_line":"            }"},{"line_number":206,"context_line":"            for interface in file_interfaces"},{"line_number":207,"context_line":"            ]"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @staticmethod"},{"line_number":210,"context_line":"    def _get_nfs_location(file_interfaces, share_name):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_456c1035","line":207,"range":{"start_line":207,"start_character":8,"end_line":207,"end_character":13},"in_reply_to":"7aa08908_11a8f11e","updated":"2016-06-08 03:12:53.000000000","message":"Thanks a lot.  Updated.","commit_id":"8d0e9ce81c308afe846f3590a2226adbce2ef704"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3aac3feb9c1eecfd9107881ab4d4876a8861d948","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                    \"pool_name\": pool.name,"},{"line_number":356,"context_line":"                    \"total_capacity_gb\": total_size,"},{"line_number":357,"context_line":"                    \"free_capacity_gb\": total_size - used_size,"},{"line_number":358,"context_line":"                    \"QoS_support\": False,"},{"line_number":359,"context_line":"                    \"reserved_percentage\": self.reserved_percentage}"},{"line_number":360,"context_line":"                stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":361,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_283ce22d","line":358,"range":{"start_line":358,"start_character":20,"end_line":358,"end_character":33},"updated":"2016-06-15 03:50:03.000000000","message":"This should be changed to qos.","commit_id":"9091e29be889dc55b2767fbcbb3b29ed0aefa51c"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"79be08394fa57f558c23b5aa76501a433f02b142","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                    \"pool_name\": pool.name,"},{"line_number":356,"context_line":"                    \"total_capacity_gb\": total_size,"},{"line_number":357,"context_line":"                    \"free_capacity_gb\": total_size - used_size,"},{"line_number":358,"context_line":"                    \"QoS_support\": False,"},{"line_number":359,"context_line":"                    \"reserved_percentage\": self.reserved_percentage}"},{"line_number":360,"context_line":"                stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":361,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_959974d3","line":358,"range":{"start_line":358,"start_character":20,"end_line":358,"end_character":33},"in_reply_to":"7aa08908_283ce22d","updated":"2016-06-16 05:34:52.000000000","message":"Done","commit_id":"9091e29be889dc55b2767fbcbb3b29ed0aefa51c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3aac3feb9c1eecfd9107881ab4d4876a8861d948","unresolved":false,"context_lines":[{"line_number":351,"context_line":"                total_size \u003d float(pool.size_total)"},{"line_number":352,"context_line":"                used_size \u003d float(pool.size_used)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"                pool_stat \u003d {"},{"line_number":355,"context_line":"                    \"pool_name\": pool.name,"},{"line_number":356,"context_line":"                    \"total_capacity_gb\": total_size,"},{"line_number":357,"context_line":"                    \"free_capacity_gb\": total_size - used_size,"},{"line_number":358,"context_line":"                    \"QoS_support\": False,"},{"line_number":359,"context_line":"                    \"reserved_percentage\": self.reserved_percentage}"},{"line_number":360,"context_line":"                stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if not stats_dict.get(\u0027pools\u0027):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_488b2ec3","line":359,"range":{"start_line":354,"start_character":16,"end_line":359,"end_character":68},"updated":"2016-06-15 03:50:03.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"9091e29be889dc55b2767fbcbb3b29ed0aefa51c"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"79be08394fa57f558c23b5aa76501a433f02b142","unresolved":false,"context_lines":[{"line_number":351,"context_line":"                total_size \u003d float(pool.size_total)"},{"line_number":352,"context_line":"                used_size \u003d float(pool.size_used)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"                pool_stat \u003d {"},{"line_number":355,"context_line":"                    \"pool_name\": pool.name,"},{"line_number":356,"context_line":"                    \"total_capacity_gb\": total_size,"},{"line_number":357,"context_line":"                    \"free_capacity_gb\": total_size - used_size,"},{"line_number":358,"context_line":"                    \"QoS_support\": False,"},{"line_number":359,"context_line":"                    \"reserved_percentage\": self.reserved_percentage}"},{"line_number":360,"context_line":"                stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if not stats_dict.get(\u0027pools\u0027):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_f56398db","line":359,"range":{"start_line":354,"start_character":16,"end_line":359,"end_character":68},"in_reply_to":"7aa08908_488b2ec3","updated":"2016-06-16 05:34:52.000000000","message":"Done","commit_id":"9091e29be889dc55b2767fbcbb3b29ed0aefa51c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3aac3feb9c1eecfd9107881ab4d4876a8861d948","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                    \"free_capacity_gb\": total_size - used_size,"},{"line_number":358,"context_line":"                    \"QoS_support\": False,"},{"line_number":359,"context_line":"                    \"reserved_percentage\": self.reserved_percentage}"},{"line_number":360,"context_line":"                stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if not stats_dict.get(\u0027pools\u0027):"},{"line_number":363,"context_line":"            message \u003d _(\"Failed to update storage pool.\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_c8643e23","line":360,"range":{"start_line":360,"start_character":43,"end_line":360,"end_character":52},"updated":"2016-06-15 03:50:03.000000000","message":"Does you need to set thin_provisioning, allocated_capacity_gb or provisioned_capacity_gb in this driver?","commit_id":"9091e29be889dc55b2767fbcbb3b29ed0aefa51c"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"79be08394fa57f558c23b5aa76501a433f02b142","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                    \"free_capacity_gb\": total_size - used_size,"},{"line_number":358,"context_line":"                    \"QoS_support\": False,"},{"line_number":359,"context_line":"                    \"reserved_percentage\": self.reserved_percentage}"},{"line_number":360,"context_line":"                stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if not stats_dict.get(\u0027pools\u0027):"},{"line_number":363,"context_line":"            message \u003d _(\"Failed to update storage pool.\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_b544701b","line":360,"range":{"start_line":360,"start_character":43,"end_line":360,"end_character":52},"in_reply_to":"7aa08908_c8643e23","updated":"2016-06-16 05:34:52.000000000","message":"Good call.  All of them are added.  Thanks.","commit_id":"9091e29be889dc55b2767fbcbb3b29ed0aefa51c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_utils import importutils"},{"line_number":22,"context_line":"from oslo_utils import units"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"storops \u003d importutils.try_import(\u0027storops\u0027)"},{"line_number":25,"context_line":"if storops:"},{"line_number":26,"context_line":"    from storops import exception as storops_ex"},{"line_number":27,"context_line":"    from storops.unity import enums"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_a7ca5f18","line":24,"range":{"start_line":24,"start_character":10,"end_line":24,"end_character":43},"updated":"2016-06-23 03:19:45.000000000","message":"Library needs to be documented in your the configref; please add a \"DocImpact\" flag to the commit message","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_utils import importutils"},{"line_number":22,"context_line":"from oslo_utils import units"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"storops \u003d importutils.try_import(\u0027storops\u0027)"},{"line_number":25,"context_line":"if storops:"},{"line_number":26,"context_line":"    from storops import exception as storops_ex"},{"line_number":27,"context_line":"    from storops.unity import enums"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_68f20771","line":24,"range":{"start_line":24,"start_character":10,"end_line":24,"end_character":43},"in_reply_to":"3aaa91ec_a7ca5f18","updated":"2016-06-23 05:45:48.000000000","message":"Done.  Thanks!","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d2240824e0de32b2cfd29eec30402a93f2a20e2b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"@vnx_utils.decorate_all_methods(vnx_utils.log_enter_exit,"},{"line_number":44,"context_line":"                                debug_only\u003dTrue)"},{"line_number":45,"context_line":"class UnityStorageConnection(driver.StorageConnection):"},{"line_number":46,"context_line":"    \"\"\"Implements Unity specific functionality for EMC Manila driver.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_ff0cf995","line":43,"range":{"start_line":43,"start_character":1,"end_line":43,"end_character":4},"updated":"2016-06-22 21:56:48.000000000","message":"Since you\u0027re reusing this here in a different plug-in, you should consider renaming this to emc_utils.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"@vnx_utils.decorate_all_methods(vnx_utils.log_enter_exit,"},{"line_number":44,"context_line":"                                debug_only\u003dTrue)"},{"line_number":45,"context_line":"class UnityStorageConnection(driver.StorageConnection):"},{"line_number":46,"context_line":"    \"\"\"Implements Unity specific functionality for EMC Manila driver.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_c24dd973","line":43,"range":{"start_line":43,"start_character":1,"end_line":43,"end_character":4},"in_reply_to":"3aaa91ec_ff0cf995","updated":"2016-06-23 05:45:48.000000000","message":"Good point.  Done.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d2240824e0de32b2cfd29eec30402a93f2a20e2b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        try:"},{"line_number":92,"context_line":"            self.nas_server_pool \u003d self.client.get_pool(pool_name)"},{"line_number":93,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":94,"context_line":"            message \u003d (_LE(\"The storage pools %s to store nas server \""},{"line_number":95,"context_line":"                           \"configuration do not exist.\") % pool_name)"},{"line_number":96,"context_line":"            LOG.error(message)"},{"line_number":97,"context_line":"            raise exception.InvalidParameterValue(err\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_bfeef188","line":94,"range":{"start_line":94,"start_character":58,"end_line":94,"end_character":61},"updated":"2016-06-22 21:56:48.000000000","message":"s/nas/NAS/\n\n(You used \u0027NAS\u0027 in the client module.)","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        try:"},{"line_number":92,"context_line":"            self.nas_server_pool \u003d self.client.get_pool(pool_name)"},{"line_number":93,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":94,"context_line":"            message \u003d (_LE(\"The storage pools %s to store nas server \""},{"line_number":95,"context_line":"                           \"configuration do not exist.\") % pool_name)"},{"line_number":96,"context_line":"            LOG.error(message)"},{"line_number":97,"context_line":"            raise exception.InvalidParameterValue(err\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_e271f5a9","line":94,"range":{"start_line":94,"start_character":58,"end_line":94,"end_character":61},"in_reply_to":"3aaa91ec_bfeef188","updated":"2016-06-23 05:45:48.000000000","message":"Updated.  Thanks.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            message \u003d (_LE(\"The storage pools %s to store nas server \""},{"line_number":95,"context_line":"                           \"configuration do not exist.\") % pool_name)"},{"line_number":96,"context_line":"            LOG.error(message)"},{"line_number":97,"context_line":"            raise exception.InvalidParameterValue(err\u003dmessage)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _config_sp(self, sp_name):"},{"line_number":100,"context_line":"        self.storage_processor \u003d self.client.get_storage_processor("}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_a7f1bf6c","line":97,"range":{"start_line":97,"start_character":28,"end_line":97,"end_character":49},"updated":"2016-06-23 03:19:45.000000000","message":"BadConfigurationException..","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            message \u003d (_LE(\"The storage pools %s to store nas server \""},{"line_number":95,"context_line":"                           \"configuration do not exist.\") % pool_name)"},{"line_number":96,"context_line":"            LOG.error(message)"},{"line_number":97,"context_line":"            raise exception.InvalidParameterValue(err\u003dmessage)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _config_sp(self, sp_name):"},{"line_number":100,"context_line":"        self.storage_processor \u003d self.client.get_storage_processor("}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_6899671f","line":97,"range":{"start_line":97,"start_character":28,"end_line":97,"end_character":49},"in_reply_to":"3aaa91ec_a7f1bf6c","updated":"2016-06-23 05:45:48.000000000","message":"Done.  Thanks.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                           \"is unavailable. Please reconfigure it in \""},{"line_number":105,"context_line":"                           \"manila.conf.\") % sp_name)"},{"line_number":106,"context_line":"            LOG.error(message)"},{"line_number":107,"context_line":"            raise exception.InvalidParameterValue(err\u003dmessage)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def check_for_setup_error(self):"},{"line_number":110,"context_line":"        \"\"\"Check for setup error.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_27fe6f38","line":107,"range":{"start_line":107,"start_character":28,"end_line":107,"end_character":49},"updated":"2016-06-23 03:19:45.000000000","message":"BadConfigurationException","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                           \"is unavailable. Please reconfigure it in \""},{"line_number":105,"context_line":"                           \"manila.conf.\") % sp_name)"},{"line_number":106,"context_line":"            LOG.error(message)"},{"line_number":107,"context_line":"            raise exception.InvalidParameterValue(err\u003dmessage)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def check_for_setup_error(self):"},{"line_number":110,"context_line":"        \"\"\"Check for setup error.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_c8a05b46","line":107,"range":{"start_line":107,"start_character":28,"end_line":107,"end_character":49},"in_reply_to":"3aaa91ec_27fe6f38","updated":"2016-06-23 05:45:48.000000000","message":"Done.  Thanks.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        filesystem \u003d self.client.create_filesystem("},{"line_number":138,"context_line":"            pool, nas_server, share_name, size, proto\u003dproto_enum)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        location \u003d None"},{"line_number":141,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":142,"context_line":"            cifs_share \u003d self.client.create_cifs_share(filesystem, share_name)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_c7632b19","line":140,"range":{"start_line":140,"start_character":8,"end_line":140,"end_character":16},"updated":"2016-06-23 03:19:45.000000000","message":"nit: locations","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        filesystem \u003d self.client.create_filesystem("},{"line_number":138,"context_line":"            pool, nas_server, share_name, size, proto\u003dproto_enum)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        location \u003d None"},{"line_number":141,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":142,"context_line":"            cifs_share \u003d self.client.create_cifs_share(filesystem, share_name)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_a8a34f4e","line":140,"range":{"start_line":140,"start_character":8,"end_line":140,"end_character":16},"in_reply_to":"3aaa91ec_c7632b19","updated":"2016-06-23 05:45:48.000000000","message":"Done.  Thanks.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                                                       share_name,"},{"line_number":180,"context_line":"                                                       snap_type\u003d\u0027snapshot\u0027)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        location \u003d None"},{"line_number":183,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":184,"context_line":"            self.client.create_cifs_share(backend_snap, share_name)"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_8782c392","line":182,"range":{"start_line":182,"start_character":8,"end_line":182,"end_character":16},"updated":"2016-06-23 03:19:45.000000000","message":"nit: locations","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                                                       share_name,"},{"line_number":180,"context_line":"                                                       snap_type\u003d\u0027snapshot\u0027)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        location \u003d None"},{"line_number":183,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":184,"context_line":"            self.client.create_cifs_share(backend_snap, share_name)"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_088b83c4","line":182,"range":{"start_line":182,"start_character":8,"end_line":182,"end_character":16},"in_reply_to":"3aaa91ec_8782c392","updated":"2016-06-23 05:45:48.000000000","message":"Done.  Thanks.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d2240824e0de32b2cfd29eec30402a93f2a20e2b","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            filesystem \u003d backend_share.filesystem"},{"line_number":236,"context_line":"            self.client.delete_share(backend_share)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"            if self._is_isolated_filesystem(filesystem):"},{"line_number":239,"context_line":"                self.client.delete_filesystem(filesystem)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":242,"context_line":"        if new_size \u003c share[\u0027size\u0027]:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_9f1b3580","line":239,"range":{"start_line":238,"start_character":12,"end_line":239,"end_character":57},"updated":"2016-06-22 21:56:48.000000000","message":"These two lines are common between the if and the else blocks.  Seems like you could dedupe them.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            filesystem \u003d backend_share.filesystem"},{"line_number":236,"context_line":"            self.client.delete_share(backend_share)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"            if self._is_isolated_filesystem(filesystem):"},{"line_number":239,"context_line":"                self.client.delete_filesystem(filesystem)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":242,"context_line":"        if new_size \u003c share[\u0027size\u0027]:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_e27f3564","line":239,"range":{"start_line":238,"start_character":12,"end_line":239,"end_character":57},"in_reply_to":"3aaa91ec_9f1b3580","updated":"2016-06-23 05:45:48.000000000","message":"Good catch.  Updated.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d2240824e0de32b2cfd29eec30402a93f2a20e2b","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                self.client.delete_filesystem(filesystem)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":242,"context_line":"        if new_size \u003c share[\u0027size\u0027]:"},{"line_number":243,"context_line":"            message \u003d (_LE(\"Failed to extend file system %(name)s because \""},{"line_number":244,"context_line":"                           \"new size %(new_size)d is smaller than old size\""},{"line_number":245,"context_line":"                           \" %(size)d.\") %"},{"line_number":246,"context_line":"                       {\u0027name\u0027: share[\u0027id\u0027], \u0027new_size\u0027: new_size,"},{"line_number":247,"context_line":"                        \u0027size\u0027: share[\u0027size\u0027]})"},{"line_number":248,"context_line":"            LOG.error(message)"},{"line_number":249,"context_line":"            raise exception.InvalidInput(reason\u003dmessage)"},{"line_number":250,"context_line":"        elif new_size \u003d\u003d share[\u0027size\u0027]:"},{"line_number":251,"context_line":"            return"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        backend_share \u003d self.client.get_share(share[\u0027id\u0027],"},{"line_number":254,"context_line":"                                              share[\u0027share_proto\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_6a1e8964","line":251,"range":{"start_line":242,"start_character":8,"end_line":251,"end_character":18},"updated":"2016-06-22 21:56:48.000000000","message":"The share API layer already performs this check.  You don\u0027t need it here.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                self.client.delete_filesystem(filesystem)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":242,"context_line":"        if new_size \u003c share[\u0027size\u0027]:"},{"line_number":243,"context_line":"            message \u003d (_LE(\"Failed to extend file system %(name)s because \""},{"line_number":244,"context_line":"                           \"new size %(new_size)d is smaller than old size\""},{"line_number":245,"context_line":"                           \" %(size)d.\") %"},{"line_number":246,"context_line":"                       {\u0027name\u0027: share[\u0027id\u0027], \u0027new_size\u0027: new_size,"},{"line_number":247,"context_line":"                        \u0027size\u0027: share[\u0027size\u0027]})"},{"line_number":248,"context_line":"            LOG.error(message)"},{"line_number":249,"context_line":"            raise exception.InvalidInput(reason\u003dmessage)"},{"line_number":250,"context_line":"        elif new_size \u003d\u003d share[\u0027size\u0027]:"},{"line_number":251,"context_line":"            return"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        backend_share \u003d self.client.get_share(share[\u0027id\u0027],"},{"line_number":254,"context_line":"                                              share[\u0027share_proto\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_c2d03956","line":251,"range":{"start_line":242,"start_character":8,"end_line":251,"end_character":18},"in_reply_to":"3aaa91ec_6a1e8964","updated":"2016-06-23 05:45:48.000000000","message":"Thanks for the info.  I am removing this along with the UT.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d2240824e0de32b2cfd29eec30402a93f2a20e2b","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        # recovery mode"},{"line_number":295,"context_line":"        if not add_rules and not delete_rules:"},{"line_number":296,"context_line":"            self.clear_access(share)"},{"line_number":297,"context_line":"            self.allow_access(context, share, access, share_server)"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    def clear_access(self, share):"},{"line_number":300,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].upper()"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_ca5a1d2a","line":297,"range":{"start_line":296,"start_character":12,"end_line":297,"end_character":67},"updated":"2016-06-22 21:56:48.000000000","message":"This looks like it will introduce a transient loss of access.  Is it possible to avoid that with your storage system?","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        # recovery mode"},{"line_number":295,"context_line":"        if not add_rules and not delete_rules:"},{"line_number":296,"context_line":"            self.clear_access(share)"},{"line_number":297,"context_line":"            self.allow_access(context, share, access, share_server)"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    def clear_access(self, share):"},{"line_number":300,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].upper()"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_029a4163","line":297,"range":{"start_line":296,"start_character":12,"end_line":297,"end_character":67},"in_reply_to":"3aaa91ec_ca5a1d2a","updated":"2016-06-23 05:45:48.000000000","message":"Yes, it\u0027s doable.  I guess we need a call of update access from array\u0027s API.\nI will see what I can do.\n\nAfter some investigation I think the effort is too large to be covered in this review.\n\nAfter this review is merged, we will start another bugfix to address this issue.  Thanks.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d2240824e0de32b2cfd29eec30402a93f2a20e2b","unresolved":false,"context_lines":[{"line_number":359,"context_line":"                    \u0027allocated_capacity_gb\u0027: used_size,"},{"line_number":360,"context_line":"                    \u0027provisioned_capacity_gb\u0027: float(pool.size_subscribed),"},{"line_number":361,"context_line":"                    \u0027qos\u0027: False,"},{"line_number":362,"context_line":"                    \u0027reserved_percentage\u0027: self.reserved_percentage"},{"line_number":363,"context_line":"                }"},{"line_number":364,"context_line":"                stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_caa85dde","line":362,"range":{"start_line":362,"start_character":57,"end_line":362,"end_character":67},"updated":"2016-06-22 21:56:48.000000000","message":"Add a trailing comma, please.\n\nhttp://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":359,"context_line":"                    \u0027allocated_capacity_gb\u0027: used_size,"},{"line_number":360,"context_line":"                    \u0027provisioned_capacity_gb\u0027: float(pool.size_subscribed),"},{"line_number":361,"context_line":"                    \u0027qos\u0027: False,"},{"line_number":362,"context_line":"                    \u0027reserved_percentage\u0027: self.reserved_percentage"},{"line_number":363,"context_line":"                }"},{"line_number":364,"context_line":"                stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_229f7d51","line":362,"range":{"start_line":362,"start_character":57,"end_line":362,"end_character":67},"in_reply_to":"3aaa91ec_caa85dde","updated":"2016-06-23 05:45:48.000000000","message":"Thanks.  Done.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d2240824e0de32b2cfd29eec30402a93f2a20e2b","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                                             netmask,"},{"line_number":400,"context_line":"                                             gateway,"},{"line_number":401,"context_line":"                                             ports\u003dself.port_set,"},{"line_number":402,"context_line":"                                             vlan_id\u003dvlan_id)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"            kerberos_enabled \u003d False"},{"line_number":405,"context_line":"            if \u0027security_services\u0027 in network_info:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_aad07154","line":402,"range":{"start_line":402,"start_character":45,"end_line":402,"end_character":61},"updated":"2016-06-22 21:56:48.000000000","message":"This could be vlan, vxlan, etc.  You might want to validate the segmentation type here.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                                             netmask,"},{"line_number":400,"context_line":"                                             gateway,"},{"line_number":401,"context_line":"                                             ports\u003dself.port_set,"},{"line_number":402,"context_line":"                                             vlan_id\u003dvlan_id)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"            kerberos_enabled \u003d False"},{"line_number":405,"context_line":"            if \u0027security_services\u0027 in network_info:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_4203a942","line":402,"range":{"start_line":402,"start_character":45,"end_line":402,"end_character":61},"in_reply_to":"3aaa91ec_aad07154","updated":"2016-06-23 05:45:48.000000000","message":"I am adding a check to rule out `vxlan`.  We do not support vxlan.  An `InvalidInput` exception will be raised when the network type is vxlan.\nAdd UT to verify the fix.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d2240824e0de32b2cfd29eec30402a93f2a20e2b","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                # Enable NFS service without kerberos"},{"line_number":439,"context_line":"                self.client.enable_nfs_service(nas_server)"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"            return {"},{"line_number":442,"context_line":"                \u0027share_server_name\u0027: server_name,"},{"line_number":443,"context_line":"            }"},{"line_number":444,"context_line":"        except Exception as ex:"},{"line_number":445,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":446,"context_line":"                LOG.error(_LE(\u0027Could not setup server. Reason: %s.\u0027), ex)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_8a6135ab","line":443,"range":{"start_line":441,"start_character":12,"end_line":443,"end_character":13},"updated":"2016-06-22 21:56:48.000000000","message":"Unwrap.  (It all fits on one line.)\n\nhttp://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                # Enable NFS service without kerberos"},{"line_number":439,"context_line":"                self.client.enable_nfs_service(nas_server)"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"            return {"},{"line_number":442,"context_line":"                \u0027share_server_name\u0027: server_name,"},{"line_number":443,"context_line":"            }"},{"line_number":444,"context_line":"        except Exception as ex:"},{"line_number":445,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":446,"context_line":"                LOG.error(_LE(\u0027Could not setup server. Reason: %s.\u0027), ex)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_08c6e399","line":443,"range":{"start_line":441,"start_character":12,"end_line":443,"end_character":13},"in_reply_to":"3aaa91ec_8a6135ab","updated":"2016-06-23 05:45:48.000000000","message":"Thanks.  Updated.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d2240824e0de32b2cfd29eec30402a93f2a20e2b","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        except Exception as ex:"},{"line_number":445,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":446,"context_line":"                LOG.error(_LE(\u0027Could not setup server. Reason: %s.\u0027), ex)"},{"line_number":447,"context_line":"                server_details \u003d {"},{"line_number":448,"context_line":"                    \u0027share_server_name\u0027: server_name,"},{"line_number":449,"context_line":"                }"},{"line_number":450,"context_line":"                self.teardown_server("},{"line_number":451,"context_line":"                    server_details, network_info[\u0027security_services\u0027])"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_0a6ee595","line":449,"range":{"start_line":447,"start_character":16,"end_line":449,"end_character":17},"updated":"2016-06-22 21:56:48.000000000","message":"Unwrap.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        except Exception as ex:"},{"line_number":445,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":446,"context_line":"                LOG.error(_LE(\u0027Could not setup server. Reason: %s.\u0027), ex)"},{"line_number":447,"context_line":"                server_details \u003d {"},{"line_number":448,"context_line":"                    \u0027share_server_name\u0027: server_name,"},{"line_number":449,"context_line":"                }"},{"line_number":450,"context_line":"                self.teardown_server("},{"line_number":451,"context_line":"                    server_details, network_info[\u0027security_services\u0027])"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_48c0eb7b","line":449,"range":{"start_line":447,"start_character":16,"end_line":449,"end_character":17},"in_reply_to":"3aaa91ec_0a6ee595","updated":"2016-06-23 05:45:48.000000000","message":"Thanks.  Updated.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                     \"emc_nas_pool_names in manila.conf. \""},{"line_number":505,"context_line":"                     \"The available pools in the backend are %s\") %"},{"line_number":506,"context_line":"                   \",\".join(real_pools))"},{"line_number":507,"context_line":"            raise exception.InvalidParameterValue(err\u003dmsg)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        if unmanaged_pools:"},{"line_number":510,"context_line":"            LOG.warning(_LW(\"The following specified storage pools \""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_424c4942","line":507,"range":{"start_line":507,"start_character":28,"end_line":507,"end_character":49},"updated":"2016-06-23 03:19:45.000000000","message":"BadConfigurationException","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                     \"emc_nas_pool_names in manila.conf. \""},{"line_number":505,"context_line":"                     \"The available pools in the backend are %s\") %"},{"line_number":506,"context_line":"                   \",\".join(real_pools))"},{"line_number":507,"context_line":"            raise exception.InvalidParameterValue(err\u003dmsg)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        if unmanaged_pools:"},{"line_number":510,"context_line":"            LOG.warning(_LW(\"The following specified storage pools \""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_e88557ad","line":507,"range":{"start_line":507,"start_character":28,"end_line":507,"end_character":49},"in_reply_to":"3aaa91ec_424c4942","updated":"2016-06-23 05:45:48.000000000","message":"Done.  Thanks.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":536,"context_line":"                     \"emc_interface_ports in manila.conf. \""},{"line_number":537,"context_line":"                     \"The available ports in the backend are %s\") %"},{"line_number":538,"context_line":"                   \",\".join(real_ports))"},{"line_number":539,"context_line":"            raise exception.InvalidParameterValue(err\u003dmsg)"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        if unmanaged_ports:"},{"line_number":542,"context_line":"            LOG.warning(_LW(\"The following specified ports \""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_c25e79e8","line":539,"range":{"start_line":539,"start_character":28,"end_line":539,"end_character":49},"updated":"2016-06-23 03:19:45.000000000","message":"BadConfigurationException","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":536,"context_line":"                     \"emc_interface_ports in manila.conf. \""},{"line_number":537,"context_line":"                     \"The available ports in the backend are %s\") %"},{"line_number":538,"context_line":"                   \",\".join(real_ports))"},{"line_number":539,"context_line":"            raise exception.InvalidParameterValue(err\u003dmsg)"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        if unmanaged_ports:"},{"line_number":542,"context_line":"            LOG.warning(_LW(\"The following specified ports \""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_88bdb36a","line":539,"range":{"start_line":539,"start_character":28,"end_line":539,"end_character":49},"in_reply_to":"3aaa91ec_c25e79e8","updated":"2016-06-23 05:45:48.000000000","message":"Done.  Thanks.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d2240824e0de32b2cfd29eec30402a93f2a20e2b","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        if server_name is None:"},{"line_number":584,"context_line":"            msg \u003d _LE(\"Name of the share server %s not found.\")"},{"line_number":585,"context_line":"            LOG.error(msg, share_server[\u0027id\u0027])"},{"line_number":586,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"        return server_name"},{"line_number":589,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_90bde2d9","line":586,"range":{"start_line":586,"start_character":41,"end_line":586,"end_character":51},"updated":"2016-06-22 21:56:48.000000000","message":"This won\u0027t have the share server ID in it.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        if server_name is None:"},{"line_number":584,"context_line":"            msg \u003d _LE(\"Name of the share server %s not found.\")"},{"line_number":585,"context_line":"            LOG.error(msg, share_server[\u0027id\u0027])"},{"line_number":586,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"        return server_name"},{"line_number":589,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_c8b7bb84","line":586,"range":{"start_line":586,"start_character":41,"end_line":586,"end_character":51},"in_reply_to":"3aaa91ec_62686588","updated":"2016-06-23 05:45:48.000000000","message":"Done.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        if server_name is None:"},{"line_number":584,"context_line":"            msg \u003d _LE(\"Name of the share server %s not found.\")"},{"line_number":585,"context_line":"            LOG.error(msg, share_server[\u0027id\u0027])"},{"line_number":586,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"        return server_name"},{"line_number":589,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_62686588","line":586,"range":{"start_line":586,"start_character":41,"end_line":586,"end_character":51},"in_reply_to":"3aaa91ec_90bde2d9","updated":"2016-06-23 03:19:45.000000000","message":"+1","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        if server_name is None:"},{"line_number":584,"context_line":"            msg \u003d _LE(\"Name of the share server %s not found.\")"},{"line_number":585,"context_line":"            LOG.error(msg, share_server[\u0027id\u0027])"},{"line_number":586,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"        return server_name"},{"line_number":589,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_e86ef794","line":586,"range":{"start_line":586,"start_character":41,"end_line":586,"end_character":51},"in_reply_to":"3aaa91ec_90bde2d9","updated":"2016-06-23 05:45:48.000000000","message":"Updated.  The formatted message will be assigned to `msg`.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].upper()"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027 and access[\u0027access_type\u0027] !\u003d \u0027user\u0027:"},{"line_number":626,"context_line":"            reason \u003d _(\u0027Only user access type allowed for CIFS share\u0027)"},{"line_number":627,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027 and access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":628,"context_line":"            reason \u003d _(\u0027Only ip access type allowed for NFS share.\u0027)"},{"line_number":629,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_02108100","line":626,"range":{"start_line":626,"start_character":68,"end_line":626,"end_character":70},"updated":"2016-06-23 03:19:45.000000000","message":"nit: add period for consistency","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].upper()"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027 and access[\u0027access_type\u0027] !\u003d \u0027user\u0027:"},{"line_number":626,"context_line":"            reason \u003d _(\u0027Only user access type allowed for CIFS share\u0027)"},{"line_number":627,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027 and access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":628,"context_line":"            reason \u003d _(\u0027Only ip access type allowed for NFS share.\u0027)"},{"line_number":629,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_a8ba2f6c","line":626,"range":{"start_line":626,"start_character":68,"end_line":626,"end_character":70},"in_reply_to":"3aaa91ec_02108100","updated":"2016-06-23 05:45:48.000000000","message":"Good catch.  Done.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027 and access[\u0027access_type\u0027] !\u003d \u0027user\u0027:"},{"line_number":626,"context_line":"            reason \u003d _(\u0027Only user access type allowed for CIFS share\u0027)"},{"line_number":627,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027 and access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":628,"context_line":"            reason \u003d _(\u0027Only ip access type allowed for NFS share.\u0027)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        if reason:"},{"line_number":631,"context_line":"            raise exception.InvalidShareAccess(reason\u003dreason)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_e2129508","line":628,"range":{"start_line":628,"start_character":29,"end_line":628,"end_character":31},"updated":"2016-06-23 03:19:45.000000000","message":"IP","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027 and access[\u0027access_type\u0027] !\u003d \u0027user\u0027:"},{"line_number":626,"context_line":"            reason \u003d _(\u0027Only user access type allowed for CIFS share\u0027)"},{"line_number":627,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027 and access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":628,"context_line":"            reason \u003d _(\u0027Only ip access type allowed for NFS share.\u0027)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        if reason:"},{"line_number":631,"context_line":"            raise exception.InvalidShareAccess(reason\u003dreason)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_e8ac3737","line":628,"range":{"start_line":628,"start_character":29,"end_line":628,"end_character":31},"in_reply_to":"3aaa91ec_e2129508","updated":"2016-06-23 05:45:48.000000000","message":"Done","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"b56d63a2ae93e5ea4dc563ba2c86819d60f12efa","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"@emc_utils.decorate_all_methods(emc_utils.log_enter_exit,"},{"line_number":44,"context_line":"                                debug_only\u003dTrue)"},{"line_number":45,"context_line":"class UnityStorageConnection(driver.StorageConnection):"},{"line_number":46,"context_line":"    \"\"\"Implements Unity specific functionality for EMC Manila driver.\"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    IP_ALLOCATIONS \u003d 2"}],"source_content_type":"text/x-python","patch_set":17,"id":"3aaa91ec_af106e02","line":45,"range":{"start_line":45,"start_character":36,"end_line":45,"end_character":53},"updated":"2016-06-23 08:24:39.000000000","message":"Why do we have here an abstract driver class that is EMC specific? Looking at this class I would say it should be in manila/driver.py instead. And why isn\u0027t there any inheritance from driver.ShareDriver?","commit_id":"1bf98b814d509fd5efaa8e8568c14654d8a13d51"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b391c29d69746a0d6bc82dcb2da35129bf4d84db","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"@emc_utils.decorate_all_methods(emc_utils.log_enter_exit,"},{"line_number":44,"context_line":"                                debug_only\u003dTrue)"},{"line_number":45,"context_line":"class UnityStorageConnection(driver.StorageConnection):"},{"line_number":46,"context_line":"    \"\"\"Implements Unity specific functionality for EMC Manila driver.\"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    IP_ALLOCATIONS \u003d 2"}],"source_content_type":"text/x-python","patch_set":17,"id":"3aaa91ec_923f95d5","line":45,"range":{"start_line":45,"start_character":36,"end_line":45,"end_character":53},"in_reply_to":"3aaa91ec_af106e02","updated":"2016-06-23 08:51:07.000000000","message":"Hi Marc,\n\nI raise the same question to Jay this morning.  My concern is that it looks like an over engineering and increase the dependency between EMC drivers.  And here is the answer I got.\n\nThe main reason is that we want to have a single driver class for all EMC storage.\nIn the configuration file, user only needs to specify the same driver class for Unity, Isilon or VNX.  I think this one makes sense.\n\nOther considerations maybe that we could add some EMC specific common utility/logic in it.  And an extra layer between interface and plugins could give some extra flexibility.\n\nRegarding why not use inheritance, I think its a technical choice.  Just like they are using ABC but not inheritance in StorageConnection.  I think they have their reason but it\u0027s beyond the topic of this commit.\n\nPlease let me know if this comment resolves your concern.\n\nThanks.","commit_id":"1bf98b814d509fd5efaa8e8568c14654d8a13d51"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"b57ee2d749f6a46fd3c2142d2a54809a1fbc8889","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                \u0027share_name\u0027: share_name}"},{"line_number":202,"context_line":"             }"},{"line_number":203,"context_line":"            for interface in file_interfaces"},{"line_number":204,"context_line":"            ]"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    @staticmethod"},{"line_number":207,"context_line":"    def _get_nfs_location(file_interfaces, share_name):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3aaa91ec_37daef17","line":204,"range":{"start_line":204,"start_character":8,"end_line":204,"end_character":12},"updated":"2016-06-23 18:58:43.000000000","message":"Why did you add this extra tab?  I think the alignment of the closing square bracket was correct.  Same below.","commit_id":"1bf98b814d509fd5efaa8e8568c14654d8a13d51"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"15498089ae8ba185f14a2e47c1edc1dbcda708d3","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                \u0027share_name\u0027: share_name}"},{"line_number":202,"context_line":"             }"},{"line_number":203,"context_line":"            for interface in file_interfaces"},{"line_number":204,"context_line":"            ]"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    @staticmethod"},{"line_number":207,"context_line":"    def _get_nfs_location(file_interfaces, share_name):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3aaa91ec_727a9725","line":204,"range":{"start_line":204,"start_character":8,"end_line":204,"end_character":12},"in_reply_to":"3aaa91ec_37daef17","updated":"2016-06-30 11:53:10.000000000","message":"Done","commit_id":"1bf98b814d509fd5efaa8e8568c14654d8a13d51"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"b57ee2d749f6a46fd3c2142d2a54809a1fbc8889","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                gateway \u003d network[\u0027gateway\u0027]"},{"line_number":380,"context_line":"                vlan_id \u003d network[\u0027segmentation_id\u0027]"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"                if network[\u0027network_type\u0027] \u003d\u003d \u0027vxlan\u0027:"},{"line_number":383,"context_line":"                    raise exception.InvalidInput("},{"line_number":384,"context_line":"                        \u0027vxlan is not supported by Unity.\u0027)"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"3aaa91ec_97a2c349","line":382,"range":{"start_line":382,"start_character":16,"end_line":382,"end_character":54},"updated":"2016-06-23 18:58:43.000000000","message":"There could be other types like GRE, so I think it would be better to have a positive check rather than a negative check.  Here\u0027s an example:\n\nhttps://github.com/openstack/manila/blob/master/manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py#L37\nhttps://github.com/openstack/manila/blob/master/manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py#L134","commit_id":"1bf98b814d509fd5efaa8e8568c14654d8a13d51"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"15498089ae8ba185f14a2e47c1edc1dbcda708d3","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                gateway \u003d network[\u0027gateway\u0027]"},{"line_number":380,"context_line":"                vlan_id \u003d network[\u0027segmentation_id\u0027]"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"                if network[\u0027network_type\u0027] \u003d\u003d \u0027vxlan\u0027:"},{"line_number":383,"context_line":"                    raise exception.InvalidInput("},{"line_number":384,"context_line":"                        \u0027vxlan is not supported by Unity.\u0027)"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"3aaa91ec_d2f9cb4f","line":382,"range":{"start_line":382,"start_character":16,"end_line":382,"end_character":54},"in_reply_to":"3aaa91ec_97a2c349","updated":"2016-06-30 11:53:10.000000000","message":"Thanks for the comment and the example.  Updated.","commit_id":"1bf98b814d509fd5efaa8e8568c14654d8a13d51"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"12a26b9f380f547500192f21d9e982c03cfdba8d","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"                if network[\u0027network_type\u0027] \u003d\u003d \u0027vxlan\u0027:"},{"line_number":383,"context_line":"                    raise exception.InvalidInput("},{"line_number":384,"context_line":"                        \u0027vxlan is not supported by Unity.\u0027)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"                # Create the interfaces on NAS server"},{"line_number":387,"context_line":"                self.client.create_interface(nas_server,"}],"source_content_type":"text/x-python","patch_set":17,"id":"3aaa91ec_e65254dd","line":384,"updated":"2016-06-30 09:31:39.000000000","message":"+1 on Clinton\u0027s comment. And also suggest to update the info like:\n\u0027Invalid network type supplied: %s.\u0027 % network[\u0027network_type\u0027]","commit_id":"1bf98b814d509fd5efaa8e8568c14654d8a13d51"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"15498089ae8ba185f14a2e47c1edc1dbcda708d3","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"                if network[\u0027network_type\u0027] \u003d\u003d \u0027vxlan\u0027:"},{"line_number":383,"context_line":"                    raise exception.InvalidInput("},{"line_number":384,"context_line":"                        \u0027vxlan is not supported by Unity.\u0027)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"                # Create the interfaces on NAS server"},{"line_number":387,"context_line":"                self.client.create_interface(nas_server,"}],"source_content_type":"text/x-python","patch_set":17,"id":"3aaa91ec_d2a70b4e","line":384,"in_reply_to":"3aaa91ec_e65254dd","updated":"2016-06-30 11:53:10.000000000","message":"Updated.","commit_id":"1bf98b814d509fd5efaa8e8568c14654d8a13d51"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c5b1291492d269dbbb99c7548c79466f9555cef1","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                    \u0027allocated_capacity_gb\u0027: used_size,"},{"line_number":347,"context_line":"                    \u0027provisioned_capacity_gb\u0027: float(pool.size_subscribed),"},{"line_number":348,"context_line":"                    \u0027qos\u0027: False,"},{"line_number":349,"context_line":"                    \u0027reserved_percentage\u0027: self.reserved_percentage,"},{"line_number":350,"context_line":"                }"},{"line_number":351,"context_line":"                stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1aa78d24_bf1e84b8","line":349,"updated":"2016-07-06 21:40:13.000000000","message":"Can  you report max_over_subscription_ratio too?","commit_id":"5fd01b68d5da84edb887b33ef46b02a5355a6ff7"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"cd7bc3d0178fa2cd55605ef9bb548152176aea4d","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                    \u0027allocated_capacity_gb\u0027: used_size,"},{"line_number":347,"context_line":"                    \u0027provisioned_capacity_gb\u0027: float(pool.size_subscribed),"},{"line_number":348,"context_line":"                    \u0027qos\u0027: False,"},{"line_number":349,"context_line":"                    \u0027reserved_percentage\u0027: self.reserved_percentage,"},{"line_number":350,"context_line":"                }"},{"line_number":351,"context_line":"                stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1aa78d24_1f7b4ec2","line":349,"in_reply_to":"1aa78d24_bf1e84b8","updated":"2016-07-07 04:37:38.000000000","message":"Added.  Thanks.","commit_id":"5fd01b68d5da84edb887b33ef46b02a5355a6ff7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"efc5374a3504a921f6173dbaf89d610a53ff0e78","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        # recovery mode"},{"line_number":242,"context_line":"        if not add_rules and not delete_rules:"},{"line_number":243,"context_line":"            self.clear_access(share)"},{"line_number":244,"context_line":"            self.allow_access(context, share, access, share_server)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def clear_access(self, share):"},{"line_number":247,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].upper()"}],"source_content_type":"text/x-python","patch_set":24,"id":"1aa78d24_db42f10e","line":244,"range":{"start_line":243,"start_character":12,"end_line":244,"end_character":67},"updated":"2016-07-15 04:22:37.000000000","message":"question: will clear and allow evict anyone (cause disruption) for even a short period?","commit_id":"494e387a03b6cfc66614c0092ba1baa4b0fe9fda"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"96dc0f30e9faa730e2ea4bc3b78109f6a0c9b3ec","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        # recovery mode"},{"line_number":242,"context_line":"        if not add_rules and not delete_rules:"},{"line_number":243,"context_line":"            self.clear_access(share)"},{"line_number":244,"context_line":"            self.allow_access(context, share, access, share_server)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def clear_access(self, share):"},{"line_number":247,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].upper()"}],"source_content_type":"text/x-python","patch_set":24,"id":"1aa78d24_34e17ffd","line":244,"range":{"start_line":243,"start_character":12,"end_line":244,"end_character":67},"in_reply_to":"1aa78d24_db42f10e","updated":"2016-07-15 08:45:32.000000000","message":"I check the array interface and it seems there is no need to do `clear_access`.  `allow_access` will update the old access configurations if it already exists.","commit_id":"494e387a03b6cfc66614c0092ba1baa4b0fe9fda"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"f5fc8c7caa74d48f0148307eaac50984e752ce97","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        # recovery mode"},{"line_number":242,"context_line":"        if not add_rules and not delete_rules:"},{"line_number":243,"context_line":"            self.clear_access(share)"},{"line_number":244,"context_line":"            self.allow_access(context, share, access, share_server)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def clear_access(self, share):"},{"line_number":247,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].upper()"}],"source_content_type":"text/x-python","patch_set":24,"id":"1aa78d24_21aae385","line":244,"range":{"start_line":243,"start_character":12,"end_line":244,"end_character":67},"in_reply_to":"1aa78d24_db42f10e","updated":"2016-07-15 08:31:56.000000000","message":"That\u0027s true.  Updated to remove access for those not exists in the current access list.  Thanks.","commit_id":"494e387a03b6cfc66614c0092ba1baa4b0fe9fda"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9b850e2157536fb59852b73ff1bd66dc6dec8e65","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                # the unit of following numbers are GB"},{"line_number":299,"context_line":"                total_size \u003d float(pool.size_total)"},{"line_number":300,"context_line":"                used_size \u003d float(pool.size_used)"},{"line_number":301,"context_line":"                max_pool_size \u003d 688 * 1024"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"                pool_stat \u003d {"},{"line_number":304,"context_line":"                    \u0027pool_name\u0027: pool.name,"}],"source_content_type":"text/x-python","patch_set":24,"id":"1aa78d24_b66f2afb","line":301,"updated":"2016-07-15 12:57:30.000000000","message":"Use units.Ki for 1024.\n\nhttps://github.com/openstack/oslo.utils/blob/master/oslo_utils/units.py#L21\n\nWhat is 688 * 1024?  Is this the max subscribed size or the max real physical size for a pool?  Please define a constant for it.\n\nIf it is the subscribed (virtual) size, then max_pool_size/total_size is the max over subscription ratio you can specify.  If it is the max real physical size you can have on a pool, then \"max_pool_size/total_size\" cannot be used to calculate max_over_subscription_ratio.","commit_id":"494e387a03b6cfc66614c0092ba1baa4b0fe9fda"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"efc5374a3504a921f6173dbaf89d610a53ff0e78","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                    \u0027reserved_percentage\u0027: self.reserved_percentage,"},{"line_number":312,"context_line":"                    # Max subscription ratio depends on the max size of pool."},{"line_number":313,"context_line":"                    # There is no hard limit on pool about this ratio."},{"line_number":314,"context_line":"                    \u0027max_over_subscription_ratio\u0027:"},{"line_number":315,"context_line":"                        max(1.0, max_pool_size / total_size),"},{"line_number":316,"context_line":"                }"},{"line_number":317,"context_line":"                stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"1aa78d24_7b6bfd85","line":315,"range":{"start_line":314,"start_character":20,"end_line":315,"end_character":60},"updated":"2016-07-15 04:22:37.000000000","message":"Interesting. So, you just ignore the max_over_subscription_ratio set by the administrator?\n\n\nThis needs to be documented, please.","commit_id":"494e387a03b6cfc66614c0092ba1baa4b0fe9fda"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"07d45989649fd833026c8b3d44a8be77e2faeb9d","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                    \u0027reserved_percentage\u0027: self.reserved_percentage,"},{"line_number":312,"context_line":"                    # Max subscription ratio depends on the max size of pool."},{"line_number":313,"context_line":"                    # There is no hard limit on pool about this ratio."},{"line_number":314,"context_line":"                    \u0027max_over_subscription_ratio\u0027:"},{"line_number":315,"context_line":"                        max(1.0, max_pool_size / total_size),"},{"line_number":316,"context_line":"                }"},{"line_number":317,"context_line":"                stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"1aa78d24_bcf549ee","line":315,"range":{"start_line":314,"start_character":20,"end_line":315,"end_character":60},"in_reply_to":"1aa78d24_56fc063e","updated":"2016-07-15 12:59:48.000000000","message":"Sorry.  I mean manila.conf:).","commit_id":"494e387a03b6cfc66614c0092ba1baa4b0fe9fda"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"f5fc8c7caa74d48f0148307eaac50984e752ce97","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                    \u0027reserved_percentage\u0027: self.reserved_percentage,"},{"line_number":312,"context_line":"                    # Max subscription ratio depends on the max size of pool."},{"line_number":313,"context_line":"                    # There is no hard limit on pool about this ratio."},{"line_number":314,"context_line":"                    \u0027max_over_subscription_ratio\u0027:"},{"line_number":315,"context_line":"                        max(1.0, max_pool_size / total_size),"},{"line_number":316,"context_line":"                }"},{"line_number":317,"context_line":"                stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"1aa78d24_e18d7b2b","line":315,"range":{"start_line":314,"start_character":20,"end_line":315,"end_character":60},"in_reply_to":"1aa78d24_7b6bfd85","updated":"2016-07-15 08:31:56.000000000","message":"OK.  I don\u0027t know there is a administrator set `max_over_subscription_ratio`.  Definitely not want to reset it.  I used to think of this value as a metric of the pool reported to the user.\nDo you know how to get the user set value?  I think I should only set the value when user input of this value is not present.","commit_id":"494e387a03b6cfc66614c0092ba1baa4b0fe9fda"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"7fc1506009f5bc838d44645f0c97afcd975ea518","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                    \u0027reserved_percentage\u0027: self.reserved_percentage,"},{"line_number":312,"context_line":"                    # Max subscription ratio depends on the max size of pool."},{"line_number":313,"context_line":"                    # There is no hard limit on pool about this ratio."},{"line_number":314,"context_line":"                    \u0027max_over_subscription_ratio\u0027:"},{"line_number":315,"context_line":"                        max(1.0, max_pool_size / total_size),"},{"line_number":316,"context_line":"                }"},{"line_number":317,"context_line":"                stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_123b0ded","line":315,"range":{"start_line":314,"start_character":20,"end_line":315,"end_character":60},"in_reply_to":"1aa78d24_bcf549ee","updated":"2016-07-18 03:23:45.000000000","message":"Hi Xing, Goutham,\n\nThanks for the discussion.  I think we could respect user\u0027s configuration here.  The max over subscription ratio set here is calculated with the maximum size of the pool.  Because we don\u0027t have this kind of hard threshold in array side.\nI think it makes sense to overwrite it if the user set value is larger than the value supported by array.  But if not, we should follow the configuration set by user.\nAnd consider it\u0027s really rare that the subscript space is larger than the maximum physical pool size, I think we could remove the reset logic here to make the code cleaner and more maintainable.\nSo basically I will follow hp 3par driver\u0027s logic to deal with this option.\nXing, please let me know if you have other concerns.\n\nThanks,\nCedric","commit_id":"494e387a03b6cfc66614c0092ba1baa4b0fe9fda"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9b850e2157536fb59852b73ff1bd66dc6dec8e65","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                    \u0027reserved_percentage\u0027: self.reserved_percentage,"},{"line_number":312,"context_line":"                    # Max subscription ratio depends on the max size of pool."},{"line_number":313,"context_line":"                    # There is no hard limit on pool about this ratio."},{"line_number":314,"context_line":"                    \u0027max_over_subscription_ratio\u0027:"},{"line_number":315,"context_line":"                        max(1.0, max_pool_size / total_size),"},{"line_number":316,"context_line":"                }"},{"line_number":317,"context_line":"                stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"1aa78d24_56fc063e","line":315,"range":{"start_line":314,"start_character":20,"end_line":315,"end_character":60},"in_reply_to":"1aa78d24_e18d7b2b","updated":"2016-07-15 12:57:30.000000000","message":"Cedric,\n\nmax_over_subscription_ratio is in cinder.conf.  By default, it is 20.  It means you can virtually provision (or subscribe) 20 times of the total capacity.\n\nhttps://github.com/openstack/manila/blob/master/manila/share/driver.py#L63","commit_id":"494e387a03b6cfc66614c0092ba1baa4b0fe9fda"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"17189de2a60d460fe9b4f3d0bc40e0518bdc6752","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                # the unit of following numbers are GB"},{"line_number":296,"context_line":"                total_size \u003d float(pool.size_total)"},{"line_number":297,"context_line":"                used_size \u003d float(pool.size_used)"},{"line_number":298,"context_line":"                max_pool_size \u003d 688 * 1024"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"                pool_stat \u003d {"},{"line_number":301,"context_line":"                    \u0027pool_name\u0027: pool.name,"}],"source_content_type":"text/x-python","patch_set":26,"id":"1aa78d24_dc6db5cd","line":298,"updated":"2016-07-15 12:58:10.000000000","message":"See my comments in patch set 24.","commit_id":"c60718d33e2354ea7ba2f00c6d7aa244e1a8ebee"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"dac69828f3934d71f8e47c66481369c0bcca7666","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_utils import importutils"},{"line_number":20,"context_line":"from oslo_utils import units"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"storops \u003d importutils.try_import(\u0027storops\u0027)"},{"line_number":23,"context_line":"if storops:"},{"line_number":24,"context_line":"    from storops import exception as storops_ex"},{"line_number":25,"context_line":"    from storops.unity import enums"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from manila.common import constants as const"},{"line_number":28,"context_line":"from manila import exception"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_12d297d2","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":35},"updated":"2016-07-19 14:49:06.000000000","message":"Does this mean that there is a big chance not to find storops on a system using this driver?","commit_id":"f00e1e1f2f9c4f2792835f2bd025311edc14d547"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9503d10788784e005b7596d53330e855cf5e0fef","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_utils import importutils"},{"line_number":20,"context_line":"from oslo_utils import units"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"storops \u003d importutils.try_import(\u0027storops\u0027)"},{"line_number":23,"context_line":"if storops:"},{"line_number":24,"context_line":"    from storops import exception as storops_ex"},{"line_number":25,"context_line":"    from storops.unity import enums"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from manila.common import constants as const"},{"line_number":28,"context_line":"from manila import exception"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_f31b6919","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":35},"in_reply_to":"dada55a8_12d297d2","updated":"2016-07-20 03:28:16.000000000","message":"No.  StorOps is required for this plugin to function normally.  It\u0027s a \"try\" import just because we cannot add thirdparty dependencies into the requirements of manila.\nSo before using this plugin, user must install this package by their own.  It will be addressed in the document.","commit_id":"f00e1e1f2f9c4f2792835f2bd025311edc14d547"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"6f3dc6e52a96cd24e0b5b41d24b7415ac5b953eb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_utils import importutils"},{"line_number":20,"context_line":"from oslo_utils import units"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"storops \u003d importutils.try_import(\u0027storops\u0027)"},{"line_number":23,"context_line":"if storops:"},{"line_number":24,"context_line":"    from storops import exception as storops_ex"},{"line_number":25,"context_line":"    from storops.unity import enums"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from manila.common import constants as const"},{"line_number":28,"context_line":"from manila import exception"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_02198022","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":35},"in_reply_to":"dada55a8_f31b6919","updated":"2016-07-20 07:19:53.000000000","message":"Thank you, this makes perfect sense in the context of not breaking other people\u0027s tests.","commit_id":"f00e1e1f2f9c4f2792835f2bd025311edc14d547"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"dac69828f3934d71f8e47c66481369c0bcca7666","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        pool \u003d self.client.get_pool(pool_name)"},{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            nas_server \u003d self.client.get_nas_server(server_name)"},{"line_number":116,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":117,"context_line":"            message \u003d (_LE(\"Failed to get NAS server %(server)s when \""},{"line_number":118,"context_line":"                           \"creating the share %(share)s.\") %"},{"line_number":119,"context_line":"                       {\u0027server\u0027: server_name, \u0027share\u0027: share_name})"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_7245d3b1","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":52},"updated":"2016-07-19 14:49:06.000000000","message":"Line 22 suggests that storops can be absent, and here you are expecting to catch an exception defined in storops. What will happen if there is no such thing as storops in a system and an exception happens while executing line 115?","commit_id":"f00e1e1f2f9c4f2792835f2bd025311edc14d547"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9503d10788784e005b7596d53330e855cf5e0fef","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        pool \u003d self.client.get_pool(pool_name)"},{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            nas_server \u003d self.client.get_nas_server(server_name)"},{"line_number":116,"context_line":"        except storops_ex.UnityResourceNotFoundError:"},{"line_number":117,"context_line":"            message \u003d (_LE(\"Failed to get NAS server %(server)s when \""},{"line_number":118,"context_line":"                           \"creating the share %(share)s.\") %"},{"line_number":119,"context_line":"                       {\u0027server\u0027: server_name, \u0027share\u0027: share_name})"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_73de5940","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":52},"in_reply_to":"dada55a8_7245d3b1","updated":"2016-07-20 03:28:16.000000000","message":"See previous comment, storops is required.","commit_id":"f00e1e1f2f9c4f2792835f2bd025311edc14d547"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"dac69828f3934d71f8e47c66481369c0bcca7666","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        # recovery mode"},{"line_number":245,"context_line":"        if not add_rules and not delete_rules:"},{"line_number":246,"context_line":"            self.allow_access(context, share, access, share_server)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def clear_access(self, share):"},{"line_number":249,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].upper()"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_8d75c599","line":246,"updated":"2016-07-19 14:49:06.000000000","message":"Probably it is better to make sure first that no stray access rules are left from times before recovery and grant access after that.","commit_id":"f00e1e1f2f9c4f2792835f2bd025311edc14d547"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9503d10788784e005b7596d53330e855cf5e0fef","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        # recovery mode"},{"line_number":245,"context_line":"        if not add_rules and not delete_rules:"},{"line_number":246,"context_line":"            self.allow_access(context, share, access, share_server)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def clear_access(self, share):"},{"line_number":249,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].upper()"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_d39bc570","line":246,"in_reply_to":"dada55a8_8d75c599","updated":"2016-07-20 03:28:16.000000000","message":"Thanks for the comment.  I think I just found a bug here.  I treated rules list as a single rule here which won\u0027t work.\n\nFor the clear access issue, I used to clear all access before adding rules.  But it seems it will results in a small amount of time in which user don\u0027t have access.\n\nI check other drivers and it seems they either clear all access (ganesha, huawei v3) as I did before or do not clear stray access as I did here (ceph).  So I kind like to keep the behavior here for now.  Because I think it\u0027s called recovery so there shouldn\u0027t be too much stray rules out there.","commit_id":"f00e1e1f2f9c4f2792835f2bd025311edc14d547"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"6f3dc6e52a96cd24e0b5b41d24b7415ac5b953eb","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        # recovery mode"},{"line_number":245,"context_line":"        if not add_rules and not delete_rules:"},{"line_number":246,"context_line":"            self.allow_access(context, share, access, share_server)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def clear_access(self, share):"},{"line_number":249,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].upper()"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_e2e0ac98","line":246,"in_reply_to":"dada55a8_d39bc570","updated":"2016-07-20 07:19:53.000000000","message":"Well, I believe that this is a valid way to handle recovery, yet I\u0027d like to point out a possibility of first accidentally granting access to everyone and then accidentally bringing service down. I am not sure how probable such scenario is, but it will definitely require some cleanup.","commit_id":"f00e1e1f2f9c4f2792835f2bd025311edc14d547"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"7be236ebfd24437c468fd23a5295f3d3faf28188","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        # recovery mode"},{"line_number":245,"context_line":"        if not add_rules and not delete_rules:"},{"line_number":246,"context_line":"            self.allow_access(context, share, access, share_server)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def clear_access(self, share):"},{"line_number":249,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].upper()"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_9358248c","line":246,"in_reply_to":"dada55a8_e2e0ac98","updated":"2016-07-21 10:17:20.000000000","message":"Yes, Alexey.  That\u0027s possible.  I think it\u0027s valid.  I am adding a clear all with white list method to deal with it. \n\nCheck the latest code review, now I am saving the targets in access_rules as the white list.  And after update the access rules, I clear access on the share except the items in the white list.","commit_id":"f00e1e1f2f9c4f2792835f2bd025311edc14d547"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"dac69828f3934d71f8e47c66481369c0bcca7666","unresolved":false,"context_lines":[{"line_number":338,"context_line":"                                                   self.storage_processor,"},{"line_number":339,"context_line":"                                                   self.nas_server_pool)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        try:"},{"line_number":342,"context_line":"            for network in network_info[\u0027network_allocations\u0027]:"},{"line_number":343,"context_line":"                ip_addr \u003d network[\u0027ip_address\u0027]"},{"line_number":344,"context_line":"                netmask \u003d utils.cidr_to_netmask(network[\u0027cidr\u0027])"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_4d50ed5d","line":341,"updated":"2016-07-19 14:49:06.000000000","message":"This try block is huge! I suggest to cut it in smaller pieces, it will be much easier to understand it.","commit_id":"f00e1e1f2f9c4f2792835f2bd025311edc14d547"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9503d10788784e005b7596d53330e855cf5e0fef","unresolved":false,"context_lines":[{"line_number":338,"context_line":"                                                   self.storage_processor,"},{"line_number":339,"context_line":"                                                   self.nas_server_pool)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        try:"},{"line_number":342,"context_line":"            for network in network_info[\u0027network_allocations\u0027]:"},{"line_number":343,"context_line":"                ip_addr \u003d network[\u0027ip_address\u0027]"},{"line_number":344,"context_line":"                netmask \u003d utils.cidr_to_netmask(network[\u0027cidr\u0027])"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_f321a9fc","line":341,"in_reply_to":"dada55a8_4d50ed5d","updated":"2016-07-20 03:28:16.000000000","message":"Restructured.  Thanks.","commit_id":"f00e1e1f2f9c4f2792835f2bd025311edc14d547"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"dac69828f3934d71f8e47c66481369c0bcca7666","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        UnityStorageConnection._validate_share_protocol(share_proto)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":560,"context_line":"            return enums.FSSupportedProtocolEnum.CIFS"},{"line_number":561,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":562,"context_line":"            return enums.FSSupportedProtocolEnum.NFS"},{"line_number":563,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_ad29aa8b","line":560,"range":{"start_line":560,"start_character":18,"end_line":560,"end_character":24},"updated":"2016-07-19 14:49:06.000000000","message":"Line 24 suggests that enums are defined in storops. Line 22 suggests that one can\u0027t rely on storops presence. It looks like this will fail when there is no storops in a system. Maybe it is better to fail earlier than when trying to create a share?","commit_id":"f00e1e1f2f9c4f2792835f2bd025311edc14d547"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9503d10788784e005b7596d53330e855cf5e0fef","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        UnityStorageConnection._validate_share_protocol(share_proto)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":560,"context_line":"            return enums.FSSupportedProtocolEnum.CIFS"},{"line_number":561,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":562,"context_line":"            return enums.FSSupportedProtocolEnum.NFS"},{"line_number":563,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_33906143","line":560,"range":{"start_line":560,"start_character":18,"end_line":560,"end_character":24},"in_reply_to":"dada55a8_ad29aa8b","updated":"2016-07-20 03:28:16.000000000","message":"See previous comment.  Storops is required.","commit_id":"f00e1e1f2f9c4f2792835f2bd025311edc14d547"},{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"0963764357eb54841be2c3388af9203dc494c83b","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":261,"context_line":"            self.client.nfs_clear_access(share_name, white_list)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":264,"context_line":"        \"\"\"Allow access to a share.\"\"\""},{"line_number":265,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":266,"context_line":"        if access_level not in const.ACCESS_LEVELS:"}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_aa7d2bb3","line":263,"range":{"start_line":263,"start_character":8,"end_line":263,"end_character":20},"updated":"2016-07-28 17:02:32.000000000","message":"Does allow_access \u0026 deny_access need to be implemented if update_access is implemented? I\u0027m working on a new manila driver for Dell, and I was told that allow_access \u0026 deny_access are replaced with update_access.  This review - \u0027https://review.openstack.org/#/c/339795/3/manila/share/drivers/hpe/hpe_3par_mediator.py\u0027 shows another driver that removed allow_access \u0026 update_access and replaced them with update_access.  This review prompted me to ask on the IRC channel about which methods should be implemented.\n\nNote: I realize making this change would affect the EMC\u0027s vnx \u0026 isilon drivers too. But I just wanted to pass along the info I found through my research.","commit_id":"034cd8cce712912f0ead9ace53ff140c89a013ee"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"0df55c64291cebc953eff19dece1e1ad625f9531","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":261,"context_line":"            self.client.nfs_clear_access(share_name, white_list)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":264,"context_line":"        \"\"\"Allow access to a share.\"\"\""},{"line_number":265,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":266,"context_line":"        if access_level not in const.ACCESS_LEVELS:"}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_325fd40f","line":263,"range":{"start_line":263,"start_character":8,"end_line":263,"end_character":20},"in_reply_to":"bacf61ea_aa7d2bb3","updated":"2016-07-29 03:29:22.000000000","message":"Hi Jeff,\nYou are right.  The update_access interface replace the other two.  I left them here for the reason you mentioned.  Another reason is that the code is reused in update_access.  Thanks for the info!","commit_id":"034cd8cce712912f0ead9ace53ff140c89a013ee"}],"manila/tests/share/drivers/emc/plugins/unity/mocked_manila.yaml":[{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"f69290fbd76d514bef4c9359153596df5a9deafe","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  _properties:"},{"line_number":74,"context_line":"    \u003c\u003c: *network_info__vlan_prop"},{"line_number":75,"context_line":"    security_services: [*active_directory_prop]"},{"line_number":76,"context_line":"    "},{"line_number":77,"context_line":"network_info__kerberos:"},{"line_number":78,"context_line":"  _type: \u0027network_info\u0027"},{"line_number":79,"context_line":"  _properties:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_1aa8cb76","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":4},"updated":"2016-05-04 15:19:39.000000000","message":"trailing whitespaces","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  _properties:"},{"line_number":74,"context_line":"    \u003c\u003c: *network_info__vlan_prop"},{"line_number":75,"context_line":"    security_services: [*active_directory_prop]"},{"line_number":76,"context_line":"    "},{"line_number":77,"context_line":"network_info__kerberos:"},{"line_number":78,"context_line":"  _type: \u0027network_info\u0027"},{"line_number":79,"context_line":"  _properties:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_17b07d42","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":4},"in_reply_to":"1a122d0e_1aa8cb76","updated":"2016-05-05 11:18:30.000000000","message":"Done","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"0963764357eb54841be2c3388af9203dc494c83b","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    access_to: \u0027administrator\u0027"},{"line_number":207,"context_line":"    access_type: \u0027user\u0027"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"nfs_rw_access:"},{"line_number":210,"context_line":"  _type: \u0027access\u0027"},{"line_number":211,"context_line":"  _properties:"},{"line_number":212,"context_line":"    access_level: \u0027rw\u0027"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"bacf61ea_77e31706","line":209,"range":{"start_line":209,"start_character":0,"end_line":209,"end_character":13},"updated":"2016-07-28 17:02:32.000000000","message":"Would it make sense to add some test IP address(es) that test CIDR notation).  I.E., 192.168.1.0/24 ?","commit_id":"034cd8cce712912f0ead9ace53ff140c89a013ee"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"0df55c64291cebc953eff19dece1e1ad625f9531","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    access_to: \u0027administrator\u0027"},{"line_number":207,"context_line":"    access_type: \u0027user\u0027"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"nfs_rw_access:"},{"line_number":210,"context_line":"  _type: \u0027access\u0027"},{"line_number":211,"context_line":"  _properties:"},{"line_number":212,"context_line":"    access_level: \u0027rw\u0027"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"bacf61ea_728cac35","line":209,"range":{"start_line":209,"start_character":0,"end_line":209,"end_character":13},"in_reply_to":"bacf61ea_77e31706","updated":"2016-07-29 03:29:22.000000000","message":"Hi Jeff,\n\nThe logic to process CIDR notation is actually written in StorOps which is another library.  So it doesn\u0027t matter in manila\u0027s code whether we are sending in a normal IP or a CIDR style IP.  But I am adding a new case for CIDR just to make sure they are treated the same as other IPs and prepare for future changes.","commit_id":"034cd8cce712912f0ead9ace53ff140c89a013ee"}],"manila/tests/share/drivers/emc/plugins/unity/mocked_unity.yaml":[{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"f69290fbd76d514bef4c9359153596df5a9deafe","unresolved":false,"context_lines":[{"line_number":722,"context_line":"  unity:"},{"line_number":723,"context_line":"    _methods:"},{"line_number":724,"context_line":"      get_cifs_share: *cifs_share__test_create_cifs_share__existed_expt"},{"line_number":725,"context_line":"      "},{"line_number":726,"context_line":"test_create_nfs_share__existed_expt:"},{"line_number":727,"context_line":"  filesystem:"},{"line_number":728,"context_line":"    _methods:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_dac49342","line":725,"range":{"start_line":725,"start_character":0,"end_line":725,"end_character":6},"updated":"2016-05-04 15:19:39.000000000","message":"trailing whitespaces","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"f69290fbd76d514bef4c9359153596df5a9deafe","unresolved":false,"context_lines":[{"line_number":803,"context_line":"  unity:"},{"line_number":804,"context_line":"    _methods:"},{"line_number":805,"context_line":"      get_nas_server: *nas_server__test_delete_nas_server__nonexistent_expt"},{"line_number":806,"context_line":"      "},{"line_number":807,"context_line":"test_create_dns_server__existed_expt:"},{"line_number":808,"context_line":"  nas_server:"},{"line_number":809,"context_line":"    _methods:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_7adc5f18","line":806,"range":{"start_line":806,"start_character":0,"end_line":806,"end_character":6},"updated":"2016-05-04 15:19:39.000000000","message":"trailing whitespaces","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"b85088816671ee094d0c2968064815285ad6ac5f","unresolved":false,"context_lines":[{"line_number":803,"context_line":"  unity:"},{"line_number":804,"context_line":"    _methods:"},{"line_number":805,"context_line":"      get_nas_server: *nas_server__test_delete_nas_server__nonexistent_expt"},{"line_number":806,"context_line":"      "},{"line_number":807,"context_line":"test_create_dns_server__existed_expt:"},{"line_number":808,"context_line":"  nas_server:"},{"line_number":809,"context_line":"    _methods:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_77873161","line":806,"range":{"start_line":806,"start_character":0,"end_line":806,"end_character":6},"in_reply_to":"1a122d0e_7adc5f18","updated":"2016-05-05 11:18:30.000000000","message":"Done","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"}],"manila/tests/share/drivers/emc/plugins/unity/res_mock.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"198979b60102d629f8439e8344a74cc50bcf5c2c","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def __init__(self, yaml_file):"},{"line_number":111,"context_line":"        yaml_dict \u003d utils.load_yaml(yaml_file)"},{"line_number":112,"context_line":"        if isinstance(yaml_dict, dict):"},{"line_number":113,"context_line":"            for name, body in yaml_dict.iteritems():"},{"line_number":114,"context_line":"                if isinstance(body, dict):"},{"line_number":115,"context_line":"                    props \u003d body[SYMBOL_PROPERTIES]"},{"line_number":116,"context_line":"                    if isinstance(props, dict):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_930377b8","line":113,"range":{"start_line":113,"start_character":40,"end_line":113,"end_character":49},"updated":"2016-05-06 03:02:40.000000000","message":"yaml_dict.items()","commit_id":"4f156d7e3eb1d5010771f3c3b5a79bc0e6dd4382"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"465f475d5740ff8348f2f00d12d5d3b6d3448f20","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def __init__(self, yaml_file):"},{"line_number":111,"context_line":"        yaml_dict \u003d utils.load_yaml(yaml_file)"},{"line_number":112,"context_line":"        if isinstance(yaml_dict, dict):"},{"line_number":113,"context_line":"            for name, body in yaml_dict.iteritems():"},{"line_number":114,"context_line":"                if isinstance(body, dict):"},{"line_number":115,"context_line":"                    props \u003d body[SYMBOL_PROPERTIES]"},{"line_number":116,"context_line":"                    if isinstance(props, dict):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_33f56b83","line":113,"range":{"start_line":113,"start_character":40,"end_line":113,"end_character":49},"in_reply_to":"dab17558_930377b8","updated":"2016-05-06 03:06:26.000000000","message":"I realize that.  Updating.  Thanks.","commit_id":"4f156d7e3eb1d5010771f3c3b5a79bc0e6dd4382"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"198979b60102d629f8439e8344a74cc50bcf5c2c","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    def __init__(self, yaml_file):"},{"line_number":230,"context_line":"        yaml_dict \u003d utils.load_yaml(yaml_file)"},{"line_number":231,"context_line":"        if isinstance(yaml_dict, dict):"},{"line_number":232,"context_line":"            for section, sec_body in yaml_dict.iteritems():"},{"line_number":233,"context_line":"                self[section] \u003d {}"},{"line_number":234,"context_line":"                if isinstance(sec_body, dict):"},{"line_number":235,"context_line":"                    for obj_name, obj_body in sec_body.iteritems():"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_f3b803e8","line":232,"range":{"start_line":232,"start_character":37,"end_line":232,"end_character":56},"updated":"2016-05-06 03:02:40.000000000","message":"yaml_dict.items()","commit_id":"4f156d7e3eb1d5010771f3c3b5a79bc0e6dd4382"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"465f475d5740ff8348f2f00d12d5d3b6d3448f20","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    def __init__(self, yaml_file):"},{"line_number":230,"context_line":"        yaml_dict \u003d utils.load_yaml(yaml_file)"},{"line_number":231,"context_line":"        if isinstance(yaml_dict, dict):"},{"line_number":232,"context_line":"            for section, sec_body in yaml_dict.iteritems():"},{"line_number":233,"context_line":"                self[section] \u003d {}"},{"line_number":234,"context_line":"                if isinstance(sec_body, dict):"},{"line_number":235,"context_line":"                    for obj_name, obj_body in sec_body.iteritems():"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_73eff3b0","line":232,"range":{"start_line":232,"start_character":37,"end_line":232,"end_character":56},"in_reply_to":"dab17558_f3b803e8","updated":"2016-05-06 03:06:26.000000000","message":"Done","commit_id":"4f156d7e3eb1d5010771f3c3b5a79bc0e6dd4382"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"198979b60102d629f8439e8344a74cc50bcf5c2c","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    if _is_mock_object(yaml_dict):"},{"line_number":246,"context_line":"        return StorageObjectMock(yaml_dict)"},{"line_number":247,"context_line":"    elif isinstance(yaml_dict, dict):"},{"line_number":248,"context_line":"        return {k: _build_mock_object(v) for k, v in yaml_dict.iteritems()}"},{"line_number":249,"context_line":"    elif isinstance(yaml_dict, list):"},{"line_number":250,"context_line":"        return [_build_mock_object(each) for each in yaml_dict]"},{"line_number":251,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_53ce2f84","line":248,"range":{"start_line":248,"start_character":53,"end_line":248,"end_character":72},"updated":"2016-05-06 03:02:40.000000000","message":"yaml_dict.items()","commit_id":"4f156d7e3eb1d5010771f3c3b5a79bc0e6dd4382"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"465f475d5740ff8348f2f00d12d5d3b6d3448f20","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    if _is_mock_object(yaml_dict):"},{"line_number":246,"context_line":"        return StorageObjectMock(yaml_dict)"},{"line_number":247,"context_line":"    elif isinstance(yaml_dict, dict):"},{"line_number":248,"context_line":"        return {k: _build_mock_object(v) for k, v in yaml_dict.iteritems()}"},{"line_number":249,"context_line":"    elif isinstance(yaml_dict, list):"},{"line_number":250,"context_line":"        return [_build_mock_object(each) for each in yaml_dict]"},{"line_number":251,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_d32a1fe7","line":248,"range":{"start_line":248,"start_character":53,"end_line":248,"end_character":72},"in_reply_to":"dab17558_53ce2f84","updated":"2016-05-06 03:06:26.000000000","message":"Done","commit_id":"4f156d7e3eb1d5010771f3c3b5a79bc0e6dd4382"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"def fake_share_server(**kwargs):"},{"line_number":48,"context_line":"    share_server \u003d {"},{"line_number":49,"context_line":"        \u0027instance_id\u0027: \u0027fake_instance_id\u0027,"},{"line_number":50,"context_line":"        \u0027backend_details\u0027: {}"},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    share_server.update(kwargs)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_0227e164","line":50,"range":{"start_line":50,"start_character":27,"end_line":50,"end_character":29},"updated":"2016-06-23 03:19:45.000000000","message":"trailing comma, please..","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"def fake_share_server(**kwargs):"},{"line_number":48,"context_line":"    share_server \u003d {"},{"line_number":49,"context_line":"        \u0027instance_id\u0027: \u0027fake_instance_id\u0027,"},{"line_number":50,"context_line":"        \u0027backend_details\u0027: {}"},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    share_server.update(kwargs)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_a8718fe2","line":50,"range":{"start_line":50,"start_character":27,"end_line":50,"end_character":29},"in_reply_to":"3aaa91ec_0227e164","updated":"2016-06-23 05:45:48.000000000","message":"Done","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    network_info \u003d {"},{"line_number":60,"context_line":"        \u0027id\u0027: \u0027fake_net_id\u0027,"},{"line_number":61,"context_line":"        \u0027name\u0027: \u0027net_name\u0027,"},{"line_number":62,"context_line":"        \u0027subnet\u0027: []"},{"line_number":63,"context_line":"    }"},{"line_number":64,"context_line":"    network_info.update(kwargs)"},{"line_number":65,"context_line":"    return network_info"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_e229f538","line":62,"range":{"start_line":62,"start_character":18,"end_line":62,"end_character":20},"updated":"2016-06-23 03:19:45.000000000","message":"same","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    network_info \u003d {"},{"line_number":60,"context_line":"        \u0027id\u0027: \u0027fake_net_id\u0027,"},{"line_number":61,"context_line":"        \u0027name\u0027: \u0027net_name\u0027,"},{"line_number":62,"context_line":"        \u0027subnet\u0027: []"},{"line_number":63,"context_line":"    }"},{"line_number":64,"context_line":"    network_info.update(kwargs)"},{"line_number":65,"context_line":"    return network_info"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_4883cb98","line":62,"range":{"start_line":62,"start_character":18,"end_line":62,"end_character":20},"in_reply_to":"3aaa91ec_e229f538","updated":"2016-06-23 05:45:48.000000000","message":"Done","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"STATS \u003d dict("},{"line_number":99,"context_line":"    share_backend_name\u003d\u0027VNX\u0027,"},{"line_number":100,"context_line":"    vendor_name\u003d\u0027EMC\u0027,"},{"line_number":101,"context_line":"    storage_protocol\u003d\u0027NFS_CIFS\u0027,"},{"line_number":102,"context_line":"    driver_version\u003d\u00272.0.0,\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_221c9d12","line":99,"range":{"start_line":99,"start_character":24,"end_line":99,"end_character":27},"updated":"2016-06-23 03:19:45.000000000","message":"unity?","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"STATS \u003d dict("},{"line_number":99,"context_line":"    share_backend_name\u003d\u0027VNX\u0027,"},{"line_number":100,"context_line":"    vendor_name\u003d\u0027EMC\u0027,"},{"line_number":101,"context_line":"    storage_protocol\u003d\u0027NFS_CIFS\u0027,"},{"line_number":102,"context_line":"    driver_version\u003d\u00272.0.0,\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_884bf386","line":99,"range":{"start_line":99,"start_character":24,"end_line":99,"end_character":27},"in_reply_to":"3aaa91ec_221c9d12","updated":"2016-06-23 05:45:48.000000000","message":"Done","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":255,"context_line":"manila_res \u003d ManilaResourceMock(\u0027mocked_manila.yaml\u0027)"},{"line_number":256,"context_line":"unity_res \u003d StorageResourceMock(\u0027mocked_unity.yaml\u0027)"},{"line_number":257,"context_line":"STORAGE_RES_MAPPING \u003d {"},{"line_number":258,"context_line":"    # \u0027TestResMock\u0027: StorageResourceMock(\u0027test_res_mock.yaml\u0027),"},{"line_number":259,"context_line":"    \u0027TestClient\u0027: unity_res,"},{"line_number":260,"context_line":"    \u0027TestConnection\u0027: unity_res,"},{"line_number":261,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_22e3fd06","line":258,"range":{"start_line":258,"start_character":4,"end_line":258,"end_character":63},"updated":"2016-06-23 03:19:45.000000000","message":"?","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":255,"context_line":"manila_res \u003d ManilaResourceMock(\u0027mocked_manila.yaml\u0027)"},{"line_number":256,"context_line":"unity_res \u003d StorageResourceMock(\u0027mocked_unity.yaml\u0027)"},{"line_number":257,"context_line":"STORAGE_RES_MAPPING \u003d {"},{"line_number":258,"context_line":"    # \u0027TestResMock\u0027: StorageResourceMock(\u0027test_res_mock.yaml\u0027),"},{"line_number":259,"context_line":"    \u0027TestClient\u0027: unity_res,"},{"line_number":260,"context_line":"    \u0027TestConnection\u0027: unity_res,"},{"line_number":261,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_c845fb70","line":258,"range":{"start_line":258,"start_character":4,"end_line":258,"end_character":63},"in_reply_to":"3aaa91ec_22e3fd06","updated":"2016-06-23 05:45:48.000000000","message":"Good catch.  Removed.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"}],"manila/tests/share/drivers/emc/plugins/unity/test_client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c60461bf9af017e8719d939ec3a02b119a069b45","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TestClient(test.TestCase):"},{"line_number":22,"context_line":"    def setUp(self):"},{"line_number":23,"context_line":"        super(TestClient, self).setUp()"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def tearDown(self):"},{"line_number":26,"context_line":"        super(TestClient, self).tearDown()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @res_mock.mock_client_input"},{"line_number":29,"context_line":"    @res_mock.patch_client"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_334b7cb2","line":26,"range":{"start_line":22,"start_character":3,"end_line":26,"end_character":42},"updated":"2016-05-24 16:29:26.000000000","message":"These are redundant now.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"c20fd511373603c61a7bf191ec05b365eff506bb","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TestClient(test.TestCase):"},{"line_number":22,"context_line":"    def setUp(self):"},{"line_number":23,"context_line":"        super(TestClient, self).setUp()"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def tearDown(self):"},{"line_number":26,"context_line":"        super(TestClient, self).tearDown()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @res_mock.mock_client_input"},{"line_number":29,"context_line":"    @res_mock.patch_client"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_59828c01","line":26,"range":{"start_line":22,"start_character":3,"end_line":26,"end_character":42},"in_reply_to":"bab6814e_334b7cb2","updated":"2016-05-25 04:13:32.000000000","message":"Removed.  Thanks.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c60461bf9af017e8719d939ec3a02b119a069b45","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def tearDown(self):"},{"line_number":26,"context_line":"        super(TestClient, self).tearDown()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @res_mock.mock_client_input"},{"line_number":29,"context_line":"    @res_mock.patch_client"},{"line_number":30,"context_line":"    def test_create_cifs_share__existed_expt(self, client, mocked_input):"},{"line_number":31,"context_line":"        resource \u003d mocked_input[\u0027filesystem\u0027]"},{"line_number":32,"context_line":"        share \u003d mocked_input[\u0027cifs_share\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_337edcae","line":29,"range":{"start_line":28,"start_character":4,"end_line":29,"end_character":26},"updated":"2016-05-24 16:29:26.000000000","message":"It is useful to make call assertions on mocked objects. How do you know that it was called as expected and was called at all?","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"c20fd511373603c61a7bf191ec05b365eff506bb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def tearDown(self):"},{"line_number":26,"context_line":"        super(TestClient, self).tearDown()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @res_mock.mock_client_input"},{"line_number":29,"context_line":"    @res_mock.patch_client"},{"line_number":30,"context_line":"    def test_create_cifs_share__existed_expt(self, client, mocked_input):"},{"line_number":31,"context_line":"        resource \u003d mocked_input[\u0027filesystem\u0027]"},{"line_number":32,"context_line":"        share \u003d mocked_input[\u0027cifs_share\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_99ca344e","line":29,"range":{"start_line":28,"start_character":4,"end_line":29,"end_character":26},"in_reply_to":"bab6814e_337edcae","updated":"2016-05-25 04:13:32.000000000","message":"In the mock data file, we gave different output for different case.  When the driver/client methods called in the case returned the expected data, we know that the expected method is called with expected parameter.  \nOtherwise it will not return the expected data.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d2240824e0de32b2cfd29eec30402a93f2a20e2b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    def test_create_cifs_share__existed_expt(self, client, mocked_input):"},{"line_number":25,"context_line":"        resource \u003d mocked_input[\u0027filesystem\u0027]"},{"line_number":26,"context_line":"        share \u003d mocked_input[\u0027cifs_share\u0027]"},{"line_number":27,"context_line":"        new_share \u003d client.create_cifs_share(resource, share.name)"},{"line_number":28,"context_line":"        self.assertEqual(share.name, new_share.name)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @res_mock.mock_client_input"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_50a9ba7a","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":66},"updated":"2016-06-22 21:56:48.000000000","message":"Please use whitespace to separate all unit tests into 3 sections (mocks, call, asserts) or 2 sections (mocks, asserts).  This greatly enhances readability!","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    def test_create_cifs_share__existed_expt(self, client, mocked_input):"},{"line_number":25,"context_line":"        resource \u003d mocked_input[\u0027filesystem\u0027]"},{"line_number":26,"context_line":"        share \u003d mocked_input[\u0027cifs_share\u0027]"},{"line_number":27,"context_line":"        new_share \u003d client.create_cifs_share(resource, share.name)"},{"line_number":28,"context_line":"        self.assertEqual(share.name, new_share.name)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @res_mock.mock_client_input"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_c8acdba2","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":66},"in_reply_to":"3aaa91ec_50a9ba7a","updated":"2016-06-23 05:45:48.000000000","message":"Done","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d2240824e0de32b2cfd29eec30402a93f2a20e2b","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @res_mock.mock_client_input"},{"line_number":61,"context_line":"    @res_mock.patch_client"},{"line_number":62,"context_line":"    def test_delete_filesystem__nonexistent_expt(self, client, mocked_input):"},{"line_number":63,"context_line":"        filesystem \u003d mocked_input[\u0027filesystem\u0027]"},{"line_number":64,"context_line":"        client.delete_filesystem(filesystem)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @res_mock.mock_client_input"},{"line_number":67,"context_line":"    @res_mock.patch_client"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_103bb239","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":44},"updated":"2016-06-22 21:56:48.000000000","message":"Why are there no assertions here?  I see various tests with no asserts.  How can you prove the code is working as designed without asserts?","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @res_mock.mock_client_input"},{"line_number":61,"context_line":"    @res_mock.patch_client"},{"line_number":62,"context_line":"    def test_delete_filesystem__nonexistent_expt(self, client, mocked_input):"},{"line_number":63,"context_line":"        filesystem \u003d mocked_input[\u0027filesystem\u0027]"},{"line_number":64,"context_line":"        client.delete_filesystem(filesystem)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @res_mock.mock_client_input"},{"line_number":67,"context_line":"    @res_mock.patch_client"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_6b9fa1b4","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":44},"in_reply_to":"3aaa91ec_103bb239","updated":"2016-06-23 05:45:48.000000000","message":"The assertion is done by the mocks framework.\n\nTo avoid polluting the test cases with numerous mocks, we assemble all mocks to the yaml files.  (check `mocked_manila.yaml` and `mocked_unity.yaml`)\nThe mocked data in these files are separated by test cases.\n\nAnd when the production code access a property or method that was not supplied in the mock data of that test case, we knew something went wrong.  And the mock framework will raise an error.\n\nIn another senario, when the function didn\u0027t return the correct data, following function call may result in another code path that was not described in the mock file which would result in the failure of the test case.\n\nThat means, most of the work of assembly mock data and assert mock function call is done by the mock framework.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"}],"manila/tests/share/drivers/emc/plugins/unity/test_connection.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c60461bf9af017e8719d939ec3a02b119a069b45","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def setUpClass(cls):"},{"line_number":33,"context_line":"        cls.emc_share_driver \u003d res_mock.FakeEMCShareDriver()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        super(TestConnection, self).setUp()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def tearDown(self):"},{"line_number":39,"context_line":"        super(TestConnection, self).tearDown()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @res_mock.patch_connection_init"},{"line_number":42,"context_line":"    def test_connect(self, connection):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_93306809","line":39,"range":{"start_line":35,"start_character":4,"end_line":39,"end_character":46},"updated":"2016-05-24 16:29:26.000000000","message":"Same here. Redundant.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"c20fd511373603c61a7bf191ec05b365eff506bb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def setUpClass(cls):"},{"line_number":33,"context_line":"        cls.emc_share_driver \u003d res_mock.FakeEMCShareDriver()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        super(TestConnection, self).setUp()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def tearDown(self):"},{"line_number":39,"context_line":"        super(TestConnection, self).tearDown()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @res_mock.patch_connection_init"},{"line_number":42,"context_line":"    def test_connect(self, connection):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_59d1eccc","line":39,"range":{"start_line":35,"start_character":4,"end_line":39,"end_character":46},"in_reply_to":"bab6814e_93306809","updated":"2016-05-25 04:13:32.000000000","message":"Removed.  Thanks.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c60461bf9af017e8719d939ec3a02b119a069b45","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def tearDown(self):"},{"line_number":39,"context_line":"        super(TestConnection, self).tearDown()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @res_mock.patch_connection_init"},{"line_number":42,"context_line":"    def test_connect(self, connection):"},{"line_number":43,"context_line":"        connection.connect(res_mock.FakeEMCShareDriver(), None)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_731ce477","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":35},"updated":"2016-05-24 16:29:26.000000000","message":"And here. Where are assertions on mocked stuff?","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"c20fd511373603c61a7bf191ec05b365eff506bb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def tearDown(self):"},{"line_number":39,"context_line":"        super(TestConnection, self).tearDown()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @res_mock.patch_connection_init"},{"line_number":42,"context_line":"    def test_connect(self, connection):"},{"line_number":43,"context_line":"        connection.connect(res_mock.FakeEMCShareDriver(), None)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_595a8c84","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":35},"in_reply_to":"bab6814e_731ce477","updated":"2016-05-25 04:13:32.000000000","message":"The check for mocked stuff are verified by checking the behavior of the caller.  If the behavior of the caller is correct that means the expected mocked call are executed.\nThe mocking data are specified in the yaml files per case.\nAnd error will be raised if unexpected mock method is called.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"deff0b4aeee62ed15b439281b6851d2f3316ccae","unresolved":false,"context_lines":[{"line_number":581,"context_line":"    @res_mock.patch_connection"},{"line_number":582,"context_line":"    def test_get_proto_enum(self, connection):"},{"line_number":583,"context_line":"        self.assertIn(\u0027FSSupportedProtocolEnum.CIFS\u0027,"},{"line_number":584,"context_line":"                      str(connection._get_proto_enum(\u0027CIFS\u0027)))"},{"line_number":585,"context_line":"        self.assertIn(\u0027FSSupportedProtocolEnum.NFS\u0027,"},{"line_number":586,"context_line":"                      str(connection._get_proto_enum(\u0027nfs\u0027)))"},{"line_number":587,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1aa78d24_1d97e8ec","line":584,"updated":"2016-07-06 19:38:28.000000000","message":"str() -\u003e six.text_type()","commit_id":"5fd01b68d5da84edb887b33ef46b02a5355a6ff7"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"cd7bc3d0178fa2cd55605ef9bb548152176aea4d","unresolved":false,"context_lines":[{"line_number":581,"context_line":"    @res_mock.patch_connection"},{"line_number":582,"context_line":"    def test_get_proto_enum(self, connection):"},{"line_number":583,"context_line":"        self.assertIn(\u0027FSSupportedProtocolEnum.CIFS\u0027,"},{"line_number":584,"context_line":"                      str(connection._get_proto_enum(\u0027CIFS\u0027)))"},{"line_number":585,"context_line":"        self.assertIn(\u0027FSSupportedProtocolEnum.NFS\u0027,"},{"line_number":586,"context_line":"                      str(connection._get_proto_enum(\u0027nfs\u0027)))"},{"line_number":587,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1aa78d24_3ca8d876","line":584,"in_reply_to":"1aa78d24_1d97e8ec","updated":"2016-07-07 04:37:38.000000000","message":"Good catch.  Updated.  Thanks.","commit_id":"5fd01b68d5da84edb887b33ef46b02a5355a6ff7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"deff0b4aeee62ed15b439281b6851d2f3316ccae","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        self.assertIn(\u0027FSSupportedProtocolEnum.CIFS\u0027,"},{"line_number":584,"context_line":"                      str(connection._get_proto_enum(\u0027CIFS\u0027)))"},{"line_number":585,"context_line":"        self.assertIn(\u0027FSSupportedProtocolEnum.NFS\u0027,"},{"line_number":586,"context_line":"                      str(connection._get_proto_enum(\u0027nfs\u0027)))"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"    @res_mock.mock_manila_input"},{"line_number":589,"context_line":"    @res_mock.patch_connection"}],"source_content_type":"text/x-python","patch_set":20,"id":"1aa78d24_9db2b892","line":586,"updated":"2016-07-06 19:38:28.000000000","message":"str() -\u003e six.text_type()","commit_id":"5fd01b68d5da84edb887b33ef46b02a5355a6ff7"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"cd7bc3d0178fa2cd55605ef9bb548152176aea4d","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        self.assertIn(\u0027FSSupportedProtocolEnum.CIFS\u0027,"},{"line_number":584,"context_line":"                      str(connection._get_proto_enum(\u0027CIFS\u0027)))"},{"line_number":585,"context_line":"        self.assertIn(\u0027FSSupportedProtocolEnum.NFS\u0027,"},{"line_number":586,"context_line":"                      str(connection._get_proto_enum(\u0027nfs\u0027)))"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"    @res_mock.mock_manila_input"},{"line_number":589,"context_line":"    @res_mock.patch_connection"}],"source_content_type":"text/x-python","patch_set":20,"id":"1aa78d24_9cb90ccf","line":586,"in_reply_to":"1aa78d24_9db2b892","updated":"2016-07-07 04:37:38.000000000","message":"Updated.  Thanks.","commit_id":"5fd01b68d5da84edb887b33ef46b02a5355a6ff7"}],"manila/tests/share/drivers/emc/plugins/unity/utils.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"198979b60102d629f8439e8344a74cc50bcf5c2c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import yaml"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from oslo_log import log"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"patch_system \u003d mock.patch(\u0027storops.UnitySystem\u0027)"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_73e4133b","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":29},"updated":"2016-05-06 03:02:40.000000000","message":"This is not be used, please remove it.","commit_id":"4f156d7e3eb1d5010771f3c3b5a79bc0e6dd4382"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"465f475d5740ff8348f2f00d12d5d3b6d3448f20","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import yaml"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from oslo_log import log"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"patch_system \u003d mock.patch(\u0027storops.UnitySystem\u0027)"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_7346d3c0","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":29},"in_reply_to":"dab17558_73e4133b","updated":"2016-05-06 03:06:26.000000000","message":"Removed.","commit_id":"4f156d7e3eb1d5010771f3c3b5a79bc0e6dd4382"}],"manila/tests/share/drivers/emc/test_driver.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    def teardown_server(self, server_details, security_services\u003dNone):"},{"line_number":76,"context_line":"        \"\"\"Teardown share server.\"\"\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"FAKE_BACKEND \u003d \u0027fake_backend\u0027"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_b1642522","line":78,"updated":"2016-05-16 13:12:33.000000000","message":"Commit is big even without such kind of changes.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    def teardown_server(self, server_details, security_services\u003dNone):"},{"line_number":76,"context_line":"        \"\"\"Teardown share server.\"\"\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"FAKE_BACKEND \u003d \u0027fake_backend\u0027"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_30f6fdd7","line":78,"in_reply_to":"dab17558_b1642522","updated":"2016-05-18 08:19:01.000000000","message":"Correct.  It\u0027s a new driver submit.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c60461bf9af017e8719d939ec3a02b119a069b45","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def teardown_server(self, server_details, security_services\u003dNone):"},{"line_number":76,"context_line":"        \"\"\"Teardown share server.\"\"\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"FAKE_BACKEND \u003d \u0027fake_backend\u0027"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_ad870fd6","line":77,"updated":"2016-05-24 16:29:26.000000000","message":"These change are redundant, especially in such big change.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"fbc50e637086c464088c7b5136ca67d594acdbf3","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def teardown_server(self, server_details, security_services\u003dNone):"},{"line_number":76,"context_line":"        \"\"\"Teardown share server.\"\"\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"FAKE_BACKEND \u003d \u0027fake_backend\u0027"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_25cf442a","line":77,"in_reply_to":"7aa08908_2ca0329f","updated":"2016-06-08 03:12:41.000000000","message":"I checked PS14 but did not find the diff.  There is no diff for this file PS14.  Could you be more specific?  Thanks!","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b9ed3fb3ac92e438ba1d58e51c15b848a223b575","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def teardown_server(self, server_details, security_services\u003dNone):"},{"line_number":76,"context_line":"        \"\"\"Teardown share server.\"\"\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"FAKE_BACKEND \u003d \u0027fake_backend\u0027"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_2ca0329f","line":77,"in_reply_to":"bab6814e_9902343d","updated":"2016-06-06 16:04:24.000000000","message":"This one rolled back, but other added in PS14 \u003e\u003c","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"c20fd511373603c61a7bf191ec05b365eff506bb","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def teardown_server(self, server_details, security_services\u003dNone):"},{"line_number":76,"context_line":"        \"\"\"Teardown share server.\"\"\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"FAKE_BACKEND \u003d \u0027fake_backend\u0027"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_9902343d","line":77,"in_reply_to":"bab6814e_ad870fd6","updated":"2016-05-25 04:13:32.000000000","message":"Change of this file has been rollback.  Thanks.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"}],"releasenotes/notes/emc-unity-manila-support-d4f5a410501cfdae.yaml":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---\r"},{"line_number":2,"context_line":"prelude: \u003e\r"},{"line_number":3,"context_line":"    Add a new Unity plugin in manila which allows user to create NFS/CIFS\r"},{"line_number":4,"context_line":"    share with a Unity backend.\r"},{"line_number":5,"context_line":"features:\r"},{"line_number":6,"context_line":"  - |\r"},{"line_number":7,"context_line":"    Add a new Unity plugin in manila which allows user to create NFS/CIFS\r"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dab17558_f1386df0","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":31},"updated":"2016-05-16 13:12:33.000000000","message":"Better to mention \"EMC\" here. It is very ambiguous to say \"Unity plugin\".","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---\r"},{"line_number":2,"context_line":"prelude: \u003e\r"},{"line_number":3,"context_line":"    Add a new Unity plugin in manila which allows user to create NFS/CIFS\r"},{"line_number":4,"context_line":"    share with a Unity backend.\r"},{"line_number":5,"context_line":"features:\r"},{"line_number":6,"context_line":"  - |\r"},{"line_number":7,"context_line":"    Add a new Unity plugin in manila which allows user to create NFS/CIFS\r"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bab6814e_7017e5ed","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":31},"in_reply_to":"dab17558_f1386df0","updated":"2016-05-18 08:19:01.000000000","message":"Done","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2a6962338d10406f603579db4924570c34aae9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    * Create/delete a NFS share.\r"},{"line_number":14,"context_line":"    * Create/delete a CIFS share.\r"},{"line_number":15,"context_line":"    * Extend the size of a share.\r"},{"line_number":16,"context_line":"    * Modify the user/host access privilege of a NFS share.\r"},{"line_number":17,"context_line":"    * Modify the user/host access privilege of a CIFS share.\r"},{"line_number":18,"context_line":"    * Take/Delete snapshot of a share.\r"},{"line_number":19,"context_line":"    * Create a new share from snapshot.\r"},{"line_number":20,"context_line":"\r"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dab17558_ac832855","line":17,"range":{"start_line":16,"start_character":4,"end_line":17,"end_character":60},"updated":"2016-05-16 13:12:33.000000000","message":"What access type is allowed? Access level?","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"2f4b0730c16088560b5aee53cfa44cb1f363e695","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    * Create/delete a NFS share.\r"},{"line_number":14,"context_line":"    * Create/delete a CIFS share.\r"},{"line_number":15,"context_line":"    * Extend the size of a share.\r"},{"line_number":16,"context_line":"    * Modify the user/host access privilege of a NFS share.\r"},{"line_number":17,"context_line":"    * Modify the user/host access privilege of a CIFS share.\r"},{"line_number":18,"context_line":"    * Take/Delete snapshot of a share.\r"},{"line_number":19,"context_line":"    * Create a new share from snapshot.\r"},{"line_number":20,"context_line":"\r"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bab6814e_90f1a9d0","line":17,"range":{"start_line":16,"start_character":4,"end_line":17,"end_character":60},"in_reply_to":"dab17558_ac832855","updated":"2016-05-18 08:19:01.000000000","message":"Fixed.  Add read only or read write.","commit_id":"be19d47e244d71b83b49188568fa9ca53790c612"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"68811aa09c10e51900c0ae59ca8af7cf6aa34ed0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    * create_snapshot: Create a snapshot for the specified share.\r"},{"line_number":32,"context_line":"    * delete_snapshot: Delete the snapshot of the share.\r"},{"line_number":33,"context_line":"    * update_access: recover, add or delete user/host access to a share.\r"},{"line_number":34,"context_line":"    * allow_access: Allow access (read write/read only) of a user/host to a\r"},{"line_number":35,"context_line":"      share.\r"},{"line_number":36,"context_line":"    * deny_access: Remove the access (read write/read only) of a user/host\r"},{"line_number":37,"context_line":"      to the share.\r"},{"line_number":38,"context_line":"    * ensure_share: Check whether share exists or not.\r"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bab6814e_9c46dbbd","line":35,"range":{"start_line":34,"start_character":20,"end_line":35,"end_character":12},"updated":"2016-05-18 10:55:42.000000000","message":"It would be correct statement only if both are supported by all share_protocols. But it is not. Same below.","commit_id":"fe6bd87c4e77ef52359cec1f630e4a70d478e05f"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"72e3a7431cd007959dfab3f3fa8eadb9f60e4467","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    * create_snapshot: Create a snapshot for the specified share.\r"},{"line_number":32,"context_line":"    * delete_snapshot: Delete the snapshot of the share.\r"},{"line_number":33,"context_line":"    * update_access: recover, add or delete user/host access to a share.\r"},{"line_number":34,"context_line":"    * allow_access: Allow access (read write/read only) of a user/host to a\r"},{"line_number":35,"context_line":"      share.\r"},{"line_number":36,"context_line":"    * deny_access: Remove the access (read write/read only) of a user/host\r"},{"line_number":37,"context_line":"      to the share.\r"},{"line_number":38,"context_line":"    * ensure_share: Check whether share exists or not.\r"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bab6814e_693b78ec","line":35,"range":{"start_line":34,"start_character":20,"end_line":35,"end_character":12},"in_reply_to":"bab6814e_9c46dbbd","updated":"2016-05-18 11:54:18.000000000","message":"Updated.  Use separate sentences for different kinds of shares.  Thanks.","commit_id":"fe6bd87c4e77ef52359cec1f630e4a70d478e05f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c60461bf9af017e8719d939ec3a02b119a069b45","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    share with a Unity backend.\r"},{"line_number":9,"context_line":"\r"},{"line_number":10,"context_line":"    In detail, users are allowed to do following operation with EMC Unity\r"},{"line_number":11,"context_line":"    Storage Systems.\r"},{"line_number":12,"context_line":"\r"},{"line_number":13,"context_line":"    * Create/delete a NFS share.\r"},{"line_number":14,"context_line":"    * Create/delete a CIFS share.\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bab6814e_6d16c7a8","line":11,"updated":"2016-05-24 16:29:26.000000000","message":"Potential users may want to know its possibility to handle networks and what kind of them - flat, vlan, etc...","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"c20fd511373603c61a7bf191ec05b365eff506bb","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    share with a Unity backend.\r"},{"line_number":9,"context_line":"\r"},{"line_number":10,"context_line":"    In detail, users are allowed to do following operation with EMC Unity\r"},{"line_number":11,"context_line":"    Storage Systems.\r"},{"line_number":12,"context_line":"\r"},{"line_number":13,"context_line":"    * Create/delete a NFS share.\r"},{"line_number":14,"context_line":"    * Create/delete a CIFS share.\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bab6814e_593baceb","line":11,"in_reply_to":"bab6814e_6d16c7a8","updated":"2016-05-25 04:13:32.000000000","message":"There is no special restrictions for the network.  I am adding flat and vlan in the feature description for now.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c60461bf9af017e8719d939ec3a02b119a069b45","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    * Create/delete a NFS share.\r"},{"line_number":14,"context_line":"    * Create/delete a CIFS share.\r"},{"line_number":15,"context_line":"    * Extend the size of a share.\r"},{"line_number":16,"context_line":"    * Modify the user/host access privilege of a NFS share.\r"},{"line_number":17,"context_line":"    * Modify the user/host access privilege of a CIFS share.\r"},{"line_number":18,"context_line":"    * Take/Delete snapshot of a share.\r"},{"line_number":19,"context_line":"    * Create a new share from snapshot.\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bab6814e_adb8afe6","line":16,"range":{"start_line":16,"start_character":17,"end_line":16,"end_character":26},"updated":"2016-05-24 16:29:26.000000000","message":"only host","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"c20fd511373603c61a7bf191ec05b365eff506bb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    * Create/delete a NFS share.\r"},{"line_number":14,"context_line":"    * Create/delete a CIFS share.\r"},{"line_number":15,"context_line":"    * Extend the size of a share.\r"},{"line_number":16,"context_line":"    * Modify the user/host access privilege of a NFS share.\r"},{"line_number":17,"context_line":"    * Modify the user/host access privilege of a CIFS share.\r"},{"line_number":18,"context_line":"    * Take/Delete snapshot of a share.\r"},{"line_number":19,"context_line":"    * Create a new share from snapshot.\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bab6814e_63124164","line":16,"range":{"start_line":16,"start_character":17,"end_line":16,"end_character":26},"in_reply_to":"bab6814e_adb8afe6","updated":"2016-05-25 04:13:32.000000000","message":"Done.  Thanks.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c60461bf9af017e8719d939ec3a02b119a069b45","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    * Create/delete a CIFS share.\r"},{"line_number":15,"context_line":"    * Extend the size of a share.\r"},{"line_number":16,"context_line":"    * Modify the user/host access privilege of a NFS share.\r"},{"line_number":17,"context_line":"    * Modify the user/host access privilege of a CIFS share.\r"},{"line_number":18,"context_line":"    * Take/Delete snapshot of a share.\r"},{"line_number":19,"context_line":"    * Create a new share from snapshot.\r"},{"line_number":20,"context_line":"\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bab6814e_2dc5df5a","line":17,"range":{"start_line":17,"start_character":17,"end_line":17,"end_character":26},"updated":"2016-05-24 16:29:26.000000000","message":"only user","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"c20fd511373603c61a7bf191ec05b365eff506bb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    * Create/delete a CIFS share.\r"},{"line_number":15,"context_line":"    * Extend the size of a share.\r"},{"line_number":16,"context_line":"    * Modify the user/host access privilege of a NFS share.\r"},{"line_number":17,"context_line":"    * Modify the user/host access privilege of a CIFS share.\r"},{"line_number":18,"context_line":"    * Take/Delete snapshot of a share.\r"},{"line_number":19,"context_line":"    * Create a new share from snapshot.\r"},{"line_number":20,"context_line":"\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bab6814e_a30c2943","line":17,"range":{"start_line":17,"start_character":17,"end_line":17,"end_character":26},"in_reply_to":"bab6814e_2dc5df5a","updated":"2016-05-25 04:13:32.000000000","message":"Done.  Thanks.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c60461bf9af017e8719d939ec3a02b119a069b45","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\r"},{"line_number":22,"context_line":"    Following driver interfaces are implemented in the plugin.\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"    * connect: Connect to the Unity Storage.\r"},{"line_number":25,"context_line":"    * create_share: Create a share and export it based on the protocol used\r"},{"line_number":26,"context_line":"      (NFS or CIFS).\r"},{"line_number":27,"context_line":"    * create_share_from_snapshot: Create a share from a snapshot - clone a\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bab6814e_8d032b76","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":44},"updated":"2016-05-24 16:29:26.000000000","message":"It is not driver interface.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"c20fd511373603c61a7bf191ec05b365eff506bb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\r"},{"line_number":22,"context_line":"    Following driver interfaces are implemented in the plugin.\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"    * connect: Connect to the Unity Storage.\r"},{"line_number":25,"context_line":"    * create_share: Create a share and export it based on the protocol used\r"},{"line_number":26,"context_line":"      (NFS or CIFS).\r"},{"line_number":27,"context_line":"    * create_share_from_snapshot: Create a share from a snapshot - clone a\r"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bab6814e_be18be76","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":44},"in_reply_to":"bab6814e_8d032b76","updated":"2016-05-25 04:13:32.000000000","message":"Thanks.  Removed.","commit_id":"baf4980811f3b50b0f957d99013e26a0c5ad5d50"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d2240824e0de32b2cfd29eec30402a93f2a20e2b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    Add a new Unity plugin in manila which allows user to create NFS/CIFS\r"},{"line_number":8,"context_line":"    share with a Unity backend.\r"},{"line_number":9,"context_line":"\r"},{"line_number":10,"context_line":"    Network topology supported: flat, Virtual LAN.\r"},{"line_number":11,"context_line":"\r"},{"line_number":12,"context_line":"    In detail, users are allowed to do following operation with EMC Unity\r"},{"line_number":13,"context_line":"    Storage Systems.\r"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3aaa91ec_b060de36","line":10,"range":{"start_line":10,"start_character":38,"end_line":10,"end_character":49},"updated":"2016-06-22 21:56:48.000000000","message":"I think \u0027VLAN\u0027 would be clearer here.","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    Add a new Unity plugin in manila which allows user to create NFS/CIFS\r"},{"line_number":8,"context_line":"    share with a Unity backend.\r"},{"line_number":9,"context_line":"\r"},{"line_number":10,"context_line":"    Network topology supported: flat, Virtual LAN.\r"},{"line_number":11,"context_line":"\r"},{"line_number":12,"context_line":"    In detail, users are allowed to do following operation with EMC Unity\r"},{"line_number":13,"context_line":"    Storage Systems.\r"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3aaa91ec_28559f1c","line":10,"range":{"start_line":10,"start_character":38,"end_line":10,"end_character":49},"in_reply_to":"3aaa91ec_b060de36","updated":"2016-06-23 05:45:48.000000000","message":"Done","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    * Create a new share from snapshot.\r"},{"line_number":22,"context_line":"\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"    Following driver interfaces are implemented in the plugin.\r"},{"line_number":25,"context_line":"\r"},{"line_number":26,"context_line":"    * create_share: Create a share and export it based on the protocol used\r"},{"line_number":27,"context_line":"      (NFS or CIFS).\r"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3aaa91ec_22781d2b","line":24,"range":{"start_line":24,"start_character":14,"end_line":24,"end_character":31},"updated":"2016-06-23 03:19:45.000000000","message":"features","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    * Create a new share from snapshot.\r"},{"line_number":22,"context_line":"\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"    Following driver interfaces are implemented in the plugin.\r"},{"line_number":25,"context_line":"\r"},{"line_number":26,"context_line":"    * create_share: Create a share and export it based on the protocol used\r"},{"line_number":27,"context_line":"      (NFS or CIFS).\r"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3aaa91ec_8832d30e","line":24,"range":{"start_line":24,"start_character":14,"end_line":24,"end_character":31},"in_reply_to":"3aaa91ec_22781d2b","updated":"2016-06-23 05:45:48.000000000","message":"Done","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c0e7ac8ae69589e903e7c3ba3205cad8301c11e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      NFS share.\r"},{"line_number":41,"context_line":"    * ensure_share: Check whether share exists or not.\r"},{"line_number":42,"context_line":"    * update_share_stats: Retrieve share related statistics from Unity.\r"},{"line_number":43,"context_line":"    * get_network_allocatins_number: Returns number of network allocations for\r"},{"line_number":44,"context_line":"      creating VIFs.\r"},{"line_number":45,"context_line":"    * setup_server: Set up and configures share server with given network\r"},{"line_number":46,"context_line":"      parameters.\r"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3aaa91ec_c28f9921","line":43,"range":{"start_line":43,"start_character":6,"end_line":43,"end_character":35},"updated":"2016-06-23 03:19:45.000000000","message":"get_network_allocations_number","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"9ae3ac3158eb69d8719386205e372a27f862d3a2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      NFS share.\r"},{"line_number":41,"context_line":"    * ensure_share: Check whether share exists or not.\r"},{"line_number":42,"context_line":"    * update_share_stats: Retrieve share related statistics from Unity.\r"},{"line_number":43,"context_line":"    * get_network_allocatins_number: Returns number of network allocations for\r"},{"line_number":44,"context_line":"      creating VIFs.\r"},{"line_number":45,"context_line":"    * setup_server: Set up and configures share server with given network\r"},{"line_number":46,"context_line":"      parameters.\r"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3aaa91ec_a83fcfd4","line":43,"range":{"start_line":43,"start_character":6,"end_line":43,"end_character":35},"in_reply_to":"3aaa91ec_c28f9921","updated":"2016-06-23 05:45:48.000000000","message":"Done","commit_id":"6d17762463a7aa39b73fa10868e8885794b96618"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"efc5374a3504a921f6173dbaf89d610a53ff0e78","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      creating VIFs.\r"},{"line_number":45,"context_line":"    * setup_server: Set up and configures share server with given network\r"},{"line_number":46,"context_line":"      parameters.\r"},{"line_number":47,"context_line":"    * teardown_server: Tear down the share server.\r"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1aa78d24_9ba229ac","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":50},"updated":"2016-07-15 04:22:37.000000000","message":"Could you name the new config options that you\u0027ve introduced for the benefit of deployers..","commit_id":"494e387a03b6cfc66614c0092ba1baa4b0fe9fda"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"f5fc8c7caa74d48f0148307eaac50984e752ce97","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      creating VIFs.\r"},{"line_number":45,"context_line":"    * setup_server: Set up and configures share server with given network\r"},{"line_number":46,"context_line":"      parameters.\r"},{"line_number":47,"context_line":"    * teardown_server: Tear down the share server.\r"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1aa78d24_c1ef9f84","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":50},"in_reply_to":"1aa78d24_9ba229ac","updated":"2016-07-15 08:31:56.000000000","message":"Thanks for bring this up.  I am adding a new section to introduce the new configurations.  Thanks.","commit_id":"494e387a03b6cfc66614c0092ba1baa4b0fe9fda"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"cb83cf5e94fe1006797f322c4f42a0c6d7db8559","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      NAS servers.  Wild card character is supported.\r"},{"line_number":56,"context_line":"      Examples: pool_1, pool_*, *\r"},{"line_number":57,"context_line":"issues:\r"},{"line_number":58,"context_line":"  - Multitenancy is not supported because we do not support same\r"},{"line_number":59,"context_line":"    IP in different VLANs.\r"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"dada55a8_5cdb86ed","line":58,"updated":"2016-07-25 13:20:27.000000000","message":"Can you replace \"we\" with \"EMC\". Otherwise people may think that Manila does not support it.","commit_id":"141cf4bd97cf06347391ae294ab17130419c7e6e"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"1f9acbd92e03a10bef93b05b325e418894fe4452","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      NAS servers.  Wild card character is supported.\r"},{"line_number":56,"context_line":"      Examples: pool_1, pool_*, *\r"},{"line_number":57,"context_line":"issues:\r"},{"line_number":58,"context_line":"  - Multitenancy is not supported because we do not support same\r"},{"line_number":59,"context_line":"    IP in different VLANs.\r"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"dada55a8_7c57455a","line":58,"in_reply_to":"dada55a8_5cdb86ed","updated":"2016-07-26 03:00:45.000000000","message":"Done.  Replaced with EMC Unity.","commit_id":"141cf4bd97cf06347391ae294ab17130419c7e6e"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"40eabe0c99b8ac47fe5cf5bc27e6d70a2de52170","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e\r"},{"line_number":3,"context_line":"    Add a new EMC Unity plugin in manila which allows user to create NFS/CIFS\r"},{"line_number":4,"context_line":"    share with a EMC Unity backend.\r"},{"line_number":5,"context_line":"features:\r"},{"line_number":6,"context_line":"  - |\r"},{"line_number":7,"context_line":"    Add a new Unity plugin in manila which allows user to create NFS/CIFS\r"},{"line_number":8,"context_line":"    share with a Unity backend.\r"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"dada55a8_8131c9ef","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":8},"updated":"2016-07-26 16:16:19.000000000","message":"This is a lot of content for a release note.  Shouldn\u0027t most of this go into a new file doc/source/devref/emc_unity_driver.rst ?","commit_id":"4b80c17072ebcd6db9056b903a3efacff8801b54"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"f71d359f92097d061d83e2b9cde0238d1b8a51e3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e\r"},{"line_number":3,"context_line":"    Add a new EMC Unity plugin in manila which allows user to create NFS/CIFS\r"},{"line_number":4,"context_line":"    share with a EMC Unity backend.\r"},{"line_number":5,"context_line":"features:\r"},{"line_number":6,"context_line":"  - |\r"},{"line_number":7,"context_line":"    Add a new Unity plugin in manila which allows user to create NFS/CIFS\r"},{"line_number":8,"context_line":"    share with a Unity backend.\r"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"dada55a8_a117ada1","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":8},"in_reply_to":"dada55a8_8131c9ef","updated":"2016-07-26 16:26:13.000000000","message":"Hi Clinton,\nI think we will use another commit to track the documentation work.  And the document should have more detail about the feature than this one.  \nThis release notes puts very much detail about the API implementation, should I remove these API details to make it shorter?","commit_id":"4b80c17072ebcd6db9056b903a3efacff8801b54"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f7b9420eee71905a8ed9312936789e2a80b3d80d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e\r"},{"line_number":3,"context_line":"    Add a new EMC Unity plugin in manila which allows user to create NFS/CIFS\r"},{"line_number":4,"context_line":"    share with a EMC Unity backend.\r"},{"line_number":5,"context_line":"features:\r"},{"line_number":6,"context_line":"  - |\r"},{"line_number":7,"context_line":"    Add a new Unity plugin in manila which allows user to create NFS/CIFS\r"},{"line_number":8,"context_line":"    share with a Unity backend.\r"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"dada55a8_81b6e93b","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":8},"in_reply_to":"dada55a8_8131c9ef","updated":"2016-07-26 16:21:24.000000000","message":"Yes, should.","commit_id":"4b80c17072ebcd6db9056b903a3efacff8801b54"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"13e69c25e06759e939000d3713cf01ef84a03e44","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e\r"},{"line_number":3,"context_line":"    Add a new EMC Unity plugin in manila which allows user to create NFS/CIFS\r"},{"line_number":4,"context_line":"    share with a EMC Unity backend.\r"},{"line_number":5,"context_line":"features:\r"},{"line_number":6,"context_line":"  - |\r"},{"line_number":7,"context_line":"    Add a new Unity plugin in manila which allows user to create NFS/CIFS\r"},{"line_number":8,"context_line":"    share with a Unity backend.\r"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"bacf61ea_735d0ee9","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":8},"in_reply_to":"dada55a8_94946937","updated":"2016-07-28 05:49:56.000000000","message":"Done.  Thanks.","commit_id":"4b80c17072ebcd6db9056b903a3efacff8801b54"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"13fbc8a087c815502f0b7f255f35d1819acbb05e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e\r"},{"line_number":3,"context_line":"    Add a new EMC Unity plugin in manila which allows user to create NFS/CIFS\r"},{"line_number":4,"context_line":"    share with a EMC Unity backend.\r"},{"line_number":5,"context_line":"features:\r"},{"line_number":6,"context_line":"  - |\r"},{"line_number":7,"context_line":"    Add a new Unity plugin in manila which allows user to create NFS/CIFS\r"},{"line_number":8,"context_line":"    share with a Unity backend.\r"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"dada55a8_94946937","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":8},"in_reply_to":"dada55a8_a117ada1","updated":"2016-07-26 16:38:20.000000000","message":"Hi, Cedric.  From the file doc/source/devref/adding_release_notes.rst:  \"Release notes need to be succinct. Short and unambiguous descriptions are preferred.\"\n\nSo yes, this reno should be a single sentence in a \u0027features\u0027 section.  And since you already have the remaining content in RST format, I suggest you spend a few minutes to move it to a new devref file.  You can always enhance that in a subsequent patch.","commit_id":"4b80c17072ebcd6db9056b903a3efacff8801b54"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d52f5e9be9356fb0d969c78f446f43b855576731","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    share with a EMC Unity backend.  This plugin performs the operations on\r"},{"line_number":9,"context_line":"    Unity by REST API.\r"},{"line_number":10,"context_line":"issues:\r"},{"line_number":11,"context_line":"  - Multitenancy is not supported because EMC Unity do not support same\r"},{"line_number":12,"context_line":"    IP in different VLANs.\r"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"bacf61ea_913a2535","line":12,"range":{"start_line":11,"start_character":4,"end_line":12,"end_character":26},"updated":"2016-07-28 13:28:29.000000000","message":"The construction of this sentence leads me to believe that we dropped multi-tenancy support in manila because EMC unity doesn\u0027t support it. \n\nCan you reword this?\n\n\"The EMC Unity driver does not support multi tenancy because it cannot accept the same IP in different VLANs.\"\n\nor something to that effect?","commit_id":"034cd8cce712912f0ead9ace53ff140c89a013ee"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"0df55c64291cebc953eff19dece1e1ad625f9531","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    share with a EMC Unity backend.  This plugin performs the operations on\r"},{"line_number":9,"context_line":"    Unity by REST API.\r"},{"line_number":10,"context_line":"issues:\r"},{"line_number":11,"context_line":"  - Multitenancy is not supported because EMC Unity do not support same\r"},{"line_number":12,"context_line":"    IP in different VLANs.\r"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"bacf61ea_ef5a794f","line":12,"range":{"start_line":11,"start_character":4,"end_line":12,"end_character":26},"in_reply_to":"bacf61ea_3724ffad","updated":"2016-07-29 03:29:22.000000000","message":"Thanks for the great suggestion!","commit_id":"034cd8cce712912f0ead9ace53ff140c89a013ee"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"455438953ea46c6c82d5a6dd570614ecc36bc84e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    share with a EMC Unity backend.  This plugin performs the operations on\r"},{"line_number":9,"context_line":"    Unity by REST API.\r"},{"line_number":10,"context_line":"issues:\r"},{"line_number":11,"context_line":"  - Multitenancy is not supported because EMC Unity do not support same\r"},{"line_number":12,"context_line":"    IP in different VLANs.\r"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"bacf61ea_3724ffad","line":12,"range":{"start_line":11,"start_character":4,"end_line":12,"end_character":26},"in_reply_to":"bacf61ea_913a2535","updated":"2016-07-28 16:14:28.000000000","message":"Since multi tenancy support implies driver handles share server in Manila, it is odd to say this driver does not support multi tenancy but supports DHSS\u003dTrue.  I think it is better to leave \"multi tenancy\" out.  Just say \"EMC Unity does not support the same IP in different VLANs\".  People will know what that means.","commit_id":"034cd8cce712912f0ead9ace53ff140c89a013ee"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"29edc9796aefeca4d6daabcc539cedbe29cbafc0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    share with a EMC Unity backend.  This plugin performs the operations on\r"},{"line_number":9,"context_line":"    Unity by REST API.\r"},{"line_number":10,"context_line":"issues:\r"},{"line_number":11,"context_line":"  - Multitenancy is not supported because EMC Unity do not support same\r"},{"line_number":12,"context_line":"    IP in different VLANs.\r"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"bacf61ea_119115f1","line":12,"range":{"start_line":11,"start_character":4,"end_line":12,"end_character":26},"in_reply_to":"bacf61ea_913a2535","updated":"2016-07-28 13:32:01.000000000","message":"the release notes are combined to form the release notes of the project at the end of a milestone... The combined release notes can be seen here: http://docs.openstack.org/releasenotes/manila/unreleased.html\n\nYou will realize why we need to repeat information in each bullet point when you glance over the combined release notes.","commit_id":"034cd8cce712912f0ead9ace53ff140c89a013ee"}],"requirements.txt":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe4965cb9aab6d8e4cb7677da508303cf2a4b0c5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"six\u003e\u003d1.9.0 # MIT"},{"line_number":38,"context_line":"SQLAlchemy\u003c1.1.0,\u003e\u003d1.0.10 # MIT"},{"line_number":39,"context_line":"stevedore\u003e\u003d1.9.0 # Apache-2.0"},{"line_number":40,"context_line":"storops\u003e\u003d0.2.6,\u003c0.3.0 # Apache-2.0"},{"line_number":41,"context_line":"python-cinderclient\u003e\u003d1.6.0 # Apache-2.0"},{"line_number":42,"context_line":"python-novaclient!\u003d2.33.0,\u003e\u003d2.29.0 # Apache-2.0"},{"line_number":43,"context_line":"WebOb\u003e\u003d1.2.3 # MIT"}],"source_content_type":"text/plain","patch_set":1,"id":"1a122d0e_2e0c7b41","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":34},"updated":"2016-05-04 11:57:24.000000000","message":"It should not be requirement for whole manila. You should have done same approach as for HPE 3par: https://github.com/openstack/manila/blob/392680f1/manila/share/drivers/hpe/hpe_3par_mediator.py#L30","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"7b029f7dcd4cc2d76425297024a812f38af8038b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"six\u003e\u003d1.9.0 # MIT"},{"line_number":38,"context_line":"SQLAlchemy\u003c1.1.0,\u003e\u003d1.0.10 # MIT"},{"line_number":39,"context_line":"stevedore\u003e\u003d1.9.0 # Apache-2.0"},{"line_number":40,"context_line":"storops\u003e\u003d0.2.6,\u003c0.3.0 # Apache-2.0"},{"line_number":41,"context_line":"python-cinderclient\u003e\u003d1.6.0 # Apache-2.0"},{"line_number":42,"context_line":"python-novaclient!\u003d2.33.0,\u003e\u003d2.29.0 # Apache-2.0"},{"line_number":43,"context_line":"WebOb\u003e\u003d1.2.3 # MIT"}],"source_content_type":"text/plain","patch_set":1,"id":"1a122d0e_16740dfc","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":34},"in_reply_to":"1a122d0e_067eace3","updated":"2016-05-05 03:18:49.000000000","message":"Thanks, working on this now.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9399c8a2c9c5e450c2a1bc7d38a9aa82d68311d2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"six\u003e\u003d1.9.0 # MIT"},{"line_number":38,"context_line":"SQLAlchemy\u003c1.1.0,\u003e\u003d1.0.10 # MIT"},{"line_number":39,"context_line":"stevedore\u003e\u003d1.9.0 # Apache-2.0"},{"line_number":40,"context_line":"storops\u003e\u003d0.2.6,\u003c0.3.0 # Apache-2.0"},{"line_number":41,"context_line":"python-cinderclient\u003e\u003d1.6.0 # Apache-2.0"},{"line_number":42,"context_line":"python-novaclient!\u003d2.33.0,\u003e\u003d2.29.0 # Apache-2.0"},{"line_number":43,"context_line":"WebOb\u003e\u003d1.2.3 # MIT"}],"source_content_type":"text/plain","patch_set":1,"id":"1a122d0e_067eace3","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":34},"in_reply_to":"1a122d0e_2e0c7b41","updated":"2016-05-04 19:42:18.000000000","message":"+1.\n\nAlso your unit tests should not be dependent on this lib which is only used by the VNX driver because we cannot require everyone to install it.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"7b029f7dcd4cc2d76425297024a812f38af8038b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"six\u003e\u003d1.9.0 # MIT"},{"line_number":38,"context_line":"SQLAlchemy\u003c1.1.0,\u003e\u003d1.0.10 # MIT"},{"line_number":39,"context_line":"stevedore\u003e\u003d1.9.0 # Apache-2.0"},{"line_number":40,"context_line":"storops\u003e\u003d0.2.6,\u003c0.3.0 # Apache-2.0"},{"line_number":41,"context_line":"python-cinderclient\u003e\u003d1.6.0 # Apache-2.0"},{"line_number":42,"context_line":"python-novaclient!\u003d2.33.0,\u003e\u003d2.29.0 # Apache-2.0"},{"line_number":43,"context_line":"WebOb\u003e\u003d1.2.3 # MIT"}],"source_content_type":"text/plain","patch_set":1,"id":"1a122d0e_56604535","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":34},"in_reply_to":"1a122d0e_2e0c7b41","updated":"2016-05-05 03:18:49.000000000","message":"Thanks, I am working on it.","commit_id":"ab8a8032c4e5a203fa14faf34bfb114fd667c383"}]}
