)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"78b331963b0e38d7f3dd1801facea62f4ab9b2af","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add tempest tests for user messages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds basic tests for the list/show/delete"},{"line_number":10,"context_line":"APIs for Cinder\u0027s new user messages."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8d8d008571352e7311f2a16dfe2a1c2c53943696"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_f9eb7476","line":10,"updated":"2016-05-09 12:00:10.000000000","message":"s/Cinder\u0027s/manila\u0027s/","commit_id":"92c332bde96c932601997f9f522aec1820d36945"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"dcd31338cc8652102b851f4f6d83559b67cd609c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds basic tests for the list/show/delete"},{"line_number":10,"context_line":"APIs for Manila\u0027s new user messages."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8d8d008571352e7311f2a16dfe2a1c2c53943696"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dab17558_75620eaf","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"updated":"2016-05-13 07:21:57.000000000","message":"This is part of user message blueprint, How about add  \"Partially Implements: Blueprint user-messages\". If you make another patch","commit_id":"9ec6e9fc33d67f90b71c4990034c935e1e703b63"}],"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"78b331963b0e38d7f3dd1801facea62f4ab9b2af","unresolved":false,"context_lines":[{"line_number":1214,"context_line":""},{"line_number":1215,"context_line":"###############"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"    def show_message(self, message_id, version\u003dLATEST_MICROVERSION):"},{"line_number":1218,"context_line":"        \"\"\"Show details for a single message.\"\"\""},{"line_number":1219,"context_line":"        url \u003d \u0027messages/%s\u0027 % str(message_id)"},{"line_number":1220,"context_line":"        resp, body \u003d self.get(url, version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_d93790ae","line":1217,"updated":"2016-05-09 12:00:10.000000000","message":"With the exception of show_quota above we seem to call methods that do a get like this \u0027get_\u003csomething\u003e\u0027.\n\nJust an observation.","commit_id":"92c332bde96c932601997f9f522aec1820d36945"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"154e3f6ecc5f88a6d750314a3973e2f9b6624c26","unresolved":false,"context_lines":[{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"    def get_message(self, message_id, version\u003dLATEST_MICROVERSION):"},{"line_number":1218,"context_line":"        \"\"\"Show details for a single message.\"\"\""},{"line_number":1219,"context_line":"        url \u003d \u0027messages/%s\u0027 % str(message_id)"},{"line_number":1220,"context_line":"        resp, body \u003d self.get(url, version\u003dversion)"},{"line_number":1221,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":1222,"context_line":"        return self._parse_resp(body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_e76b8bef","line":1219,"range":{"start_line":1219,"start_character":30,"end_line":1219,"end_character":33},"updated":"2016-05-10 13:56:59.000000000","message":"This is not needed, please remove. Also str() should be avoided.","commit_id":"7face990cec789000a9999c1e565941ac663b4f6"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"846ad6f7a07875d1df703f9b2fd32213af885f7b","unresolved":false,"context_lines":[{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"    def get_message(self, message_id, version\u003dLATEST_MICROVERSION):"},{"line_number":1218,"context_line":"        \"\"\"Show details for a single message.\"\"\""},{"line_number":1219,"context_line":"        url \u003d \u0027messages/%s\u0027 % str(message_id)"},{"line_number":1220,"context_line":"        resp, body \u003d self.get(url, version\u003dversion)"},{"line_number":1221,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":1222,"context_line":"        return self._parse_resp(body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_745d1048","line":1219,"range":{"start_line":1219,"start_character":30,"end_line":1219,"end_character":33},"in_reply_to":"dab17558_e76b8bef","updated":"2016-05-12 13:40:10.000000000","message":"true story, not sure why i had that","commit_id":"7face990cec789000a9999c1e565941ac663b4f6"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"154e3f6ecc5f88a6d750314a3973e2f9b6624c26","unresolved":false,"context_lines":[{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"    def delete_message(self, message_id, version\u003dLATEST_MICROVERSION):"},{"line_number":1232,"context_line":"        \"\"\"Delete a single message.\"\"\""},{"line_number":1233,"context_line":"        url \u003d \u0027messages/%s\u0027 % str(message_id)"},{"line_number":1234,"context_line":"        resp, body \u003d self.delete(url, version\u003dversion)"},{"line_number":1235,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":1236,"context_line":"        return self._parse_resp(body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_0777afd3","line":1233,"range":{"start_line":1233,"start_character":30,"end_line":1233,"end_character":33},"updated":"2016-05-10 13:56:59.000000000","message":"Same","commit_id":"7face990cec789000a9999c1e565941ac663b4f6"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"846ad6f7a07875d1df703f9b2fd32213af885f7b","unresolved":false,"context_lines":[{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"    def delete_message(self, message_id, version\u003dLATEST_MICROVERSION):"},{"line_number":1232,"context_line":"        \"\"\"Delete a single message.\"\"\""},{"line_number":1233,"context_line":"        url \u003d \u0027messages/%s\u0027 % str(message_id)"},{"line_number":1234,"context_line":"        resp, body \u003d self.delete(url, version\u003dversion)"},{"line_number":1235,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":1236,"context_line":"        return self._parse_resp(body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_d44ddc9a","line":1233,"range":{"start_line":1233,"start_character":30,"end_line":1233,"end_character":33},"in_reply_to":"dab17558_0777afd3","updated":"2016-05-12 13:40:10.000000000","message":"Done","commit_id":"7face990cec789000a9999c1e565941ac663b4f6"}],"manila_tempest_tests/tests/api/admin/test_user_messages.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"94340f9c2f6ec8919c66aae4bc11826fc8bd9991","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        return message_id"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_list_messages(self):"},{"line_number":65,"context_line":"        self.skip_if_microversion_not_supported(MICROVERSION)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        message_id \u003d self._create_user_message()"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_3f48335b","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":61},"updated":"2016-05-09 15:29:11.000000000","message":"This can be a class decorator... \n\n@base.skip_if_microversion_lt(MICROVERSION)","commit_id":"f2074d8e5894f9da922ea727df2b7e6dbe15dc43"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"154e3f6ecc5f88a6d750314a3973e2f9b6624c26","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        return message_id"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_list_messages(self):"},{"line_number":65,"context_line":"        self.skip_if_microversion_not_supported(MICROVERSION)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        message_id \u003d self._create_user_message()"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_02dddd6e","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":61},"updated":"2016-05-10 13:56:59.000000000","message":"I think there\u0027s a class decorator for that. It would avoid repeating it in all tests.","commit_id":"7face990cec789000a9999c1e565941ac663b4f6"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"846ad6f7a07875d1df703f9b2fd32213af885f7b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        return message_id"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_list_messages(self):"},{"line_number":65,"context_line":"        self.skip_if_microversion_not_supported(MICROVERSION)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        message_id \u003d self._create_user_message()"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_b405b815","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":61},"in_reply_to":"dab17558_02dddd6e","updated":"2016-05-12 13:40:10.000000000","message":"Done","commit_id":"7face990cec789000a9999c1e565941ac663b4f6"},{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"f43cbb8b787f398cf2d21979d384039987341e3c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def _create_user_message(self):"},{"line_number":35,"context_line":"        \"\"\"Trigger a \u0027no valid host\u0027 situation to generate a message.\"\"\""},{"line_number":36,"context_line":"        extra_specs \u003d {"},{"line_number":37,"context_line":"            \u0027vendor_name\u0027: \u0027bar\u0027,"},{"line_number":38,"context_line":"            \u0027driver_handles_share_servers\u0027: CONF.share.multitenancy_enabled,"},{"line_number":39,"context_line":"        }"},{"line_number":40,"context_line":"        share_type_name \u003d data_utils.rand_name(\"share-type\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_b653ed6b","line":37,"range":{"start_line":37,"start_character":28,"end_line":37,"end_character":31},"updated":"2016-05-12 19:18:15.000000000","message":"I know why this is bar, but without the protocol\u003dfoo part it doesn\u0027t make as much sense.  I would recommend making this \u0027foobar\u0027 or \u0027bogus\u0027","commit_id":"bd08f2fdfc28294e831035652cde8f8d4269b240"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"99d185bc1afc9bb8b7647a309b61a1c588c9b67c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def _create_user_message(self):"},{"line_number":35,"context_line":"        \"\"\"Trigger a \u0027no valid host\u0027 situation to generate a message.\"\"\""},{"line_number":36,"context_line":"        extra_specs \u003d {"},{"line_number":37,"context_line":"            \u0027vendor_name\u0027: \u0027bar\u0027,"},{"line_number":38,"context_line":"            \u0027driver_handles_share_servers\u0027: CONF.share.multitenancy_enabled,"},{"line_number":39,"context_line":"        }"},{"line_number":40,"context_line":"        share_type_name \u003d data_utils.rand_name(\"share-type\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_8fb5dfd1","line":37,"range":{"start_line":37,"start_character":28,"end_line":37,"end_character":31},"in_reply_to":"dab17558_b653ed6b","updated":"2016-05-13 00:35:40.000000000","message":"yeah makes sense","commit_id":"bd08f2fdfc28294e831035652cde8f8d4269b240"},{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"f43cbb8b787f398cf2d21979d384039987341e3c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        return message_id"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_list_messages(self):"},{"line_number":66,"context_line":"        message_id \u003d self._create_user_message()"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        body \u003d self.shares_v2_client.list_messages()"},{"line_number":69,"context_line":"        self.assertIsInstance(body, list)"},{"line_number":70,"context_line":"        self.assertTrue(message_id, [x[\u0027id\u0027] for x in body])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_show_message(self):"},{"line_number":73,"context_line":"        message_id \u003d self._create_user_message()"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_f6fbb545","line":70,"range":{"start_line":66,"start_character":8,"end_line":70,"end_character":60},"updated":"2016-05-12 19:18:15.000000000","message":"Much of this test is redundant with what already happens in the _create_user_message method.  The original version simply verified that a list returned, without creating a message first.  If you want to verify that a properly populated list is returned, simply calling the _create_user_message method verifies that, albeit less explicitly.","commit_id":"bd08f2fdfc28294e831035652cde8f8d4269b240"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"99d185bc1afc9bb8b7647a309b61a1c588c9b67c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        return message_id"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_list_messages(self):"},{"line_number":66,"context_line":"        message_id \u003d self._create_user_message()"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        body \u003d self.shares_v2_client.list_messages()"},{"line_number":69,"context_line":"        self.assertIsInstance(body, list)"},{"line_number":70,"context_line":"        self.assertTrue(message_id, [x[\u0027id\u0027] for x in body])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_show_message(self):"},{"line_number":73,"context_line":"        message_id \u003d self._create_user_message()"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_4fadb787","line":70,"range":{"start_line":66,"start_character":8,"end_line":70,"end_character":60},"in_reply_to":"dab17558_f6fbb545","updated":"2016-05-13 00:35:40.000000000","message":"I ran into it just being an empty list and figured this is the most legit way to confirm the correct thing came back.","commit_id":"bd08f2fdfc28294e831035652cde8f8d4269b240"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"398d14ea8f7a0555bdff24b7a8ae8559247a8417","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"MICROVERSION \u003d \u00272.17\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@base.skip_if_microversion_lt(MICROVERSION)"},{"line_number":28,"context_line":"class UserMessagesTest(base.BaseSharesAdminTest):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_225ea5e9","line":25,"updated":"2016-05-18 12:18:26.000000000","message":"Need to cover \"negative\" cases too.","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"7feb40f87f8d4b4383fd58d95d67638aa0c8d434","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"MICROVERSION \u003d \u00272.17\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@base.skip_if_microversion_lt(MICROVERSION)"},{"line_number":28,"context_line":"class UserMessagesTest(base.BaseSharesAdminTest):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_f8f55383","line":25,"in_reply_to":"bab6814e_225ea5e9","updated":"2016-05-18 19:12:25.000000000","message":"I will try to think of a few and add those.","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e8c17c1cf1a60b828e06fad64bdef58dd823dca9","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@base.skip_if_microversion_lt(MICROVERSION)"},{"line_number":28,"context_line":"class UserMessagesTest(base.BaseSharesAdminTest):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def _delete_share(self, share_id):"},{"line_number":31,"context_line":"        self.shares_v2_client.delete_share(share_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_e2aadd18","line":28,"range":{"start_line":28,"start_character":23,"end_line":28,"end_character":47},"updated":"2016-05-18 12:24:17.000000000","message":"Policy in [1] allows non-admin to perform these APIs. Why do you set admin creds then?","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"7feb40f87f8d4b4383fd58d95d67638aa0c8d434","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@base.skip_if_microversion_lt(MICROVERSION)"},{"line_number":28,"context_line":"class UserMessagesTest(base.BaseSharesAdminTest):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def _delete_share(self, share_id):"},{"line_number":31,"context_line":"        self.shares_v2_client.delete_share(share_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_38c23b34","line":28,"range":{"start_line":28,"start_character":23,"end_line":28,"end_character":47},"in_reply_to":"bab6814e_e2aadd18","updated":"2016-05-18 19:12:25.000000000","message":"Need to create a share type that will fail","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"398d14ea8f7a0555bdff24b7a8ae8559247a8417","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            \u0027driver_handles_share_servers\u0027: CONF.share.multitenancy_enabled,"},{"line_number":39,"context_line":"        }"},{"line_number":40,"context_line":"        share_type_name \u003d data_utils.rand_name(\"share-type\")"},{"line_number":41,"context_line":"        bogus_type \u003d self.shares_v2_client.create_share_type("},{"line_number":42,"context_line":"            name\u003dshare_type_name,"},{"line_number":43,"context_line":"            extra_specs\u003dextra_specs)[\u0027share_type\u0027]"},{"line_number":44,"context_line":"        self.addCleanup(self.shares_v2_client.delete_share_type,"},{"line_number":45,"context_line":"                        bogus_type[\u0027id\u0027])"},{"line_number":46,"context_line":"        params \u003d {\u0027share_type_id\u0027: bogus_type[\u0027id\u0027],"},{"line_number":47,"context_line":"                  \u0027share_network_id\u0027: self.shares_v2_client.share_network_id}"},{"line_number":48,"context_line":"        share \u003d self.shares_v2_client.create_share(**params)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_2274e59a","line":45,"range":{"start_line":41,"start_character":8,"end_line":45,"end_character":41},"updated":"2016-05-18 12:18:26.000000000","message":"We have base methods for such kind of needs. Same for all other such occurrences in this module.","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"7609beaee2401af2873cf5b7ffd6905bf2ea3694","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            \u0027driver_handles_share_servers\u0027: CONF.share.multitenancy_enabled,"},{"line_number":39,"context_line":"        }"},{"line_number":40,"context_line":"        share_type_name \u003d data_utils.rand_name(\"share-type\")"},{"line_number":41,"context_line":"        bogus_type \u003d self.shares_v2_client.create_share_type("},{"line_number":42,"context_line":"            name\u003dshare_type_name,"},{"line_number":43,"context_line":"            extra_specs\u003dextra_specs)[\u0027share_type\u0027]"},{"line_number":44,"context_line":"        self.addCleanup(self.shares_v2_client.delete_share_type,"},{"line_number":45,"context_line":"                        bogus_type[\u0027id\u0027])"},{"line_number":46,"context_line":"        params \u003d {\u0027share_type_id\u0027: bogus_type[\u0027id\u0027],"},{"line_number":47,"context_line":"                  \u0027share_network_id\u0027: self.shares_v2_client.share_network_id}"},{"line_number":48,"context_line":"        share \u003d self.shares_v2_client.create_share(**params)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_33e1272e","line":45,"range":{"start_line":41,"start_character":8,"end_line":45,"end_character":41},"in_reply_to":"bab6814e_2274e59a","updated":"2016-05-22 20:32:49.000000000","message":"Done","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"398d14ea8f7a0555bdff24b7a8ae8559247a8417","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        share \u003d self.shares_v2_client.create_share(**params)"},{"line_number":49,"context_line":"        self.addCleanup(self.shares_v2_client.delete_share, share[\u0027id\u0027])"},{"line_number":50,"context_line":"        try:"},{"line_number":51,"context_line":"            self.shares_v2_client.wait_for_share_status(share[\u0027id\u0027], \"error\")"},{"line_number":52,"context_line":"        except share_exceptions.ShareBuildErrorException:"},{"line_number":53,"context_line":"            # Error state is expected and desired"},{"line_number":54,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_df2fb29f","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":77},"updated":"2016-05-18 12:18:26.000000000","message":"It does not raise exception if \"error\" status is expected. So, try-block is redundant.","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"7609beaee2401af2873cf5b7ffd6905bf2ea3694","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        share \u003d self.shares_v2_client.create_share(**params)"},{"line_number":49,"context_line":"        self.addCleanup(self.shares_v2_client.delete_share, share[\u0027id\u0027])"},{"line_number":50,"context_line":"        try:"},{"line_number":51,"context_line":"            self.shares_v2_client.wait_for_share_status(share[\u0027id\u0027], \"error\")"},{"line_number":52,"context_line":"        except share_exceptions.ShareBuildErrorException:"},{"line_number":53,"context_line":"            # Error state is expected and desired"},{"line_number":54,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_584e8ac1","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":77},"in_reply_to":"bab6814e_df2fb29f","updated":"2016-05-22 20:32:49.000000000","message":"Done","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"398d14ea8f7a0555bdff24b7a8ae8559247a8417","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        return message_id"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_list_messages(self):"},{"line_number":66,"context_line":"        message_id \u003d self._create_user_message()"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        body \u003d self.shares_v2_client.list_messages()"},{"line_number":69,"context_line":"        self.assertIsInstance(body, list)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_a2961592","line":66,"range":{"start_line":66,"start_character":21,"end_line":66,"end_character":48},"updated":"2016-05-18 12:18:26.000000000","message":"You do it in each test, it means that it should have been done in \"setUp\" method.","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"7609beaee2401af2873cf5b7ffd6905bf2ea3694","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        return message_id"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_list_messages(self):"},{"line_number":66,"context_line":"        message_id \u003d self._create_user_message()"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        body \u003d self.shares_v2_client.list_messages()"},{"line_number":69,"context_line":"        self.assertIsInstance(body, list)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_f8d93ef4","line":66,"range":{"start_line":66,"start_character":21,"end_line":66,"end_character":48},"in_reply_to":"bab6814e_a2961592","updated":"2016-05-22 20:32:49.000000000","message":"Done","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b1a001079ca37fb353de437b493c9d403f89d903","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        body \u003d self.shares_v2_client.list_messages()"},{"line_number":69,"context_line":"        self.assertIsInstance(body, list)"},{"line_number":70,"context_line":"        self.assertTrue(message_id, [x[\u0027id\u0027] for x in body])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_show_message(self):"},{"line_number":73,"context_line":"        message_id \u003d self._create_user_message()"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_82ce7158","line":70,"updated":"2016-05-18 12:19:02.000000000","message":"No assertion on expected keys for list of messages.","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"7609beaee2401af2873cf5b7ffd6905bf2ea3694","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        body \u003d self.shares_v2_client.list_messages()"},{"line_number":69,"context_line":"        self.assertIsInstance(body, list)"},{"line_number":70,"context_line":"        self.assertTrue(message_id, [x[\u0027id\u0027] for x in body])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_show_message(self):"},{"line_number":73,"context_line":"        message_id \u003d self._create_user_message()"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_f33affe5","line":70,"in_reply_to":"bab6814e_82ce7158","updated":"2016-05-22 20:32:49.000000000","message":"Done","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"398d14ea8f7a0555bdff24b7a8ae8559247a8417","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_show_message(self):"},{"line_number":73,"context_line":"        message_id \u003d self._create_user_message()"},{"line_number":74,"context_line":"        self.addCleanup(self.shares_v2_client.delete_message, message_id)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        message \u003d self.shares_v2_client.get_message(message_id)"},{"line_number":77,"context_line":"        expected_keys \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_22d3453a","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":73},"updated":"2016-05-18 12:18:26.000000000","message":"Shouldn\u0027t it be deleted with a share if not deleted explicitly before share?","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"7609beaee2401af2873cf5b7ffd6905bf2ea3694","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_show_message(self):"},{"line_number":73,"context_line":"        message_id \u003d self._create_user_message()"},{"line_number":74,"context_line":"        self.addCleanup(self.shares_v2_client.delete_message, message_id)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        message \u003d self.shares_v2_client.get_message(message_id)"},{"line_number":77,"context_line":"        expected_keys \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_d859da8f","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":73},"in_reply_to":"bab6814e_22d3453a","updated":"2016-05-22 20:32:49.000000000","message":"No they should live independently of the resource that triggered them. There may be some reason the user wants to have the message even if they delete the share, like saying \u0027hey look I got this error 5 times this week\u0027 to their support but having deleted the shares to make room in quota. \n\nAlso, that would mean we should have similar behavior for other resources like snapshots, groups, etc. Let me know what you think.","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"398d14ea8f7a0555bdff24b7a8ae8559247a8417","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.addCleanup(self.shares_v2_client.delete_message, message_id)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        message \u003d self.shares_v2_client.get_message(message_id)"},{"line_number":77,"context_line":"        expected_keys \u003d ["},{"line_number":78,"context_line":"            \u0027created_at\u0027,"},{"line_number":79,"context_line":"            \u0027event_id\u0027,"},{"line_number":80,"context_line":"            \u0027guaranteed_until\u0027,"},{"line_number":81,"context_line":"            \u0027id\u0027,"},{"line_number":82,"context_line":"            \u0027message_level\u0027,"},{"line_number":83,"context_line":"            \u0027request_id\u0027,"},{"line_number":84,"context_line":"            \u0027resource_type\u0027,"},{"line_number":85,"context_line":"            \u0027resource_uuid\u0027,"},{"line_number":86,"context_line":"            \u0027user_message\u0027]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        for key in expected_keys:"},{"line_number":89,"context_line":"            self.assertIn(key, message.keys(), \u0027Missing expected key %s\u0027 % key)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_22b6a5dc","line":86,"range":{"start_line":77,"start_character":8,"end_line":86,"end_character":27},"updated":"2016-05-18 12:18:26.000000000","message":"Please, use tuples for data container that are going to be used only for iteration.","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"7609beaee2401af2873cf5b7ffd6905bf2ea3694","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.addCleanup(self.shares_v2_client.delete_message, message_id)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        message \u003d self.shares_v2_client.get_message(message_id)"},{"line_number":77,"context_line":"        expected_keys \u003d ["},{"line_number":78,"context_line":"            \u0027created_at\u0027,"},{"line_number":79,"context_line":"            \u0027event_id\u0027,"},{"line_number":80,"context_line":"            \u0027guaranteed_until\u0027,"},{"line_number":81,"context_line":"            \u0027id\u0027,"},{"line_number":82,"context_line":"            \u0027message_level\u0027,"},{"line_number":83,"context_line":"            \u0027request_id\u0027,"},{"line_number":84,"context_line":"            \u0027resource_type\u0027,"},{"line_number":85,"context_line":"            \u0027resource_uuid\u0027,"},{"line_number":86,"context_line":"            \u0027user_message\u0027]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        for key in expected_keys:"},{"line_number":89,"context_line":"            self.assertIn(key, message.keys(), \u0027Missing expected key %s\u0027 % key)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_5877aa01","line":86,"range":{"start_line":77,"start_character":8,"end_line":86,"end_character":27},"in_reply_to":"bab6814e_22b6a5dc","updated":"2016-05-22 20:32:49.000000000","message":"Done","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"398d14ea8f7a0555bdff24b7a8ae8559247a8417","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            \u0027resource_uuid\u0027,"},{"line_number":86,"context_line":"            \u0027user_message\u0027]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        for key in expected_keys:"},{"line_number":89,"context_line":"            self.assertIn(key, message.keys(), \u0027Missing expected key %s\u0027 % key)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_delete_message(self):"},{"line_number":92,"context_line":"        message_id \u003d self._create_user_message()"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_028d6131","line":89,"range":{"start_line":88,"start_character":8,"end_line":89,"end_character":79},"updated":"2016-05-18 12:18:26.000000000","message":"Insufficient testing. We also should check presence of values and their types.","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"7feb40f87f8d4b4383fd58d95d67638aa0c8d434","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            \u0027resource_uuid\u0027,"},{"line_number":86,"context_line":"            \u0027user_message\u0027]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        for key in expected_keys:"},{"line_number":89,"context_line":"            self.assertIn(key, message.keys(), \u0027Missing expected key %s\u0027 % key)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_delete_message(self):"},{"line_number":92,"context_line":"        message_id \u003d self._create_user_message()"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_9804077f","line":89,"range":{"start_line":88,"start_character":8,"end_line":89,"end_character":79},"in_reply_to":"bab6814e_028d6131","updated":"2016-05-18 19:12:25.000000000","message":"Sure we can improve this, this was a close port of the cinder tests.","commit_id":"6a6c211eb06456aaeece533c33012e6160359868"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b014447a78c6c66139b814dc95b711d7fcd9aced","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.assertTrue(self.message_id, [x[\u0027id\u0027] for x in body])"},{"line_number":82,"context_line":"        message \u003d body[0]"},{"line_number":83,"context_line":"        for key in MESSAGE_KEYS:"},{"line_number":84,"context_line":"            self.assertIn(key, message.keys(), \u0027Missing expected key %s\u0027 % key)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_show_message(self):"},{"line_number":87,"context_line":"        self.addCleanup(self.shares_v2_client.delete_message, self.message_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_c8881774","line":84,"range":{"start_line":84,"start_character":31,"end_line":84,"end_character":45},"updated":"2016-06-08 03:35:22.000000000","message":"Use py3 compatible approach, wrap it with \"list\".  set(message.keys())","commit_id":"8c93f9fc9faca2203ee52bc983c7420260b92ddb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b014447a78c6c66139b814dc95b711d7fcd9aced","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        message \u003d self.shares_v2_client.get_message(self.message_id)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        for key in MESSAGE_KEYS:"},{"line_number":92,"context_line":"            self.assertIn(key, message.keys(), \u0027Missing expected key %s\u0027 % key)"},{"line_number":93,"context_line":"        self.assertTrue(uuidutils.is_uuid_like(message[\u0027id\u0027]))"},{"line_number":94,"context_line":"        self.assertEqual(\u0027SHARE_000002\u0027, message[\u0027event_id\u0027])"},{"line_number":95,"context_line":"        self.assertEqual(\u0027SHARE\u0027, message[\u0027resource_type\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_087fbf66","line":92,"range":{"start_line":92,"start_character":30,"end_line":92,"end_character":45},"updated":"2016-06-08 03:35:22.000000000","message":"Use py3 compatible approach, wrap it with \"list\".  set(message.keys())","commit_id":"8c93f9fc9faca2203ee52bc983c7420260b92ddb"}],"manila_tempest_tests/tests/api/admin/test_user_messages_negative.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b014447a78c6c66139b814dc95b711d7fcd9aced","unresolved":false,"context_lines":[{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"MICROVERSION \u003d \u00272.17\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class UserMessagesTest(base.BaseSharesAdminTest):"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_48e6e715","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":0},"updated":"2016-06-08 03:35:22.000000000","message":"The \u0027list_messages\u0027 negative tests is absent.","commit_id":"8c93f9fc9faca2203ee52bc983c7420260b92ddb"}]}
