)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"d4670c8cbe9b4e03fbf85dacb43a1910ae556e17","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The sqlalchemy API has decorators to require"},{"line_number":10,"context_line":"a context or admin context argument to its DB"},{"line_number":11,"context_line":"methods.  This commit ensures that these decorators"},{"line_number":12,"context_line":"are applied conistently across the methods, and in"},{"line_number":13,"context_line":"accord with the following principles:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  1. private methods begin with underscore and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_761f185b","line":12,"range":{"start_line":12,"start_character":12,"end_line":12,"end_character":23},"updated":"2016-05-11 12:40:35.000000000","message":"consistently","commit_id":"77e4fd64156e52c7507f40d33e94c02c1aad497e"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"4703c5f6d67644578dec6db4cada848ee4f6c774","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The sqlalchemy API has decorators to require"},{"line_number":10,"context_line":"a context or admin context argument to its DB"},{"line_number":11,"context_line":"methods.  This commit ensures that these decorators"},{"line_number":12,"context_line":"are applied conistently across the methods, and in"},{"line_number":13,"context_line":"accord with the following principles:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  1. private methods begin with underscore and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_96755ccc","line":12,"range":{"start_line":12,"start_character":12,"end_line":12,"end_character":23},"in_reply_to":"dab17558_761f185b","updated":"2016-05-11 12:55:45.000000000","message":"Thanks, I\u0027ll fix.","commit_id":"77e4fd64156e52c7507f40d33e94c02c1aad497e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5eb7cc5c6ab7ab10e90febe6c785c31bf9f86905","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Unit test methods that inappropriately called these"},{"line_number":24,"context_line":"methods without context have been corrected as well."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Ic448d40ef83a02837dd9bc2c6465080387305ca1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dab17558_bef6695a","line":25,"updated":"2016-05-11 16:19:23.000000000","message":"What about to file a bug and mention it here?\n\nIt does not really fit \"TrivialFix\" case.","commit_id":"adfc56e242d60f5a75b00f1a39510771f4919759"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7b626cf1437c1a248388410179883d2a3373f70a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tom Barron \u003ctpb@dyncloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-11 16:43:41 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cleanup context decorator usage in DB API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The sqlalchemy API has decorators to require"},{"line_number":10,"context_line":"a context or admin context argument to its DB"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_09459416","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":41},"updated":"2016-05-12 10:50:12.000000000","message":"It is not really cleanup, it is \"fix\" or \"correction\".","commit_id":"e382e2b033e83fe7c6e77549e633f194695da9fa"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f2ccb5d5478c05bd04d9cafdd51cfc1ca86e723f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tom Barron \u003ctpb@dyncloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-11 16:43:41 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cleanup context decorator usage in DB API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The sqlalchemy API has decorators to require"},{"line_number":10,"context_line":"a context or admin context argument to its DB"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_e89e45b7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":41},"in_reply_to":"dab17558_09459416","updated":"2016-05-12 12:23:16.000000000","message":"Done","commit_id":"e382e2b033e83fe7c6e77549e633f194695da9fa"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7b626cf1437c1a248388410179883d2a3373f70a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The sqlalchemy API has decorators to require"},{"line_number":10,"context_line":"a context or admin context argument to its DB"},{"line_number":11,"context_line":"methods.  This commit ensures that these decorators"},{"line_number":12,"context_line":"are applied consistently across the methods, and in"},{"line_number":13,"context_line":"accord with the following principles:"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_29c978ad","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":34},"updated":"2016-05-12 10:50:12.000000000","message":"Please, do not use such wording. Just use imperative mood:\n\n\"Add context-check decorators where context argument is required. And make it required in all public methods.\"","commit_id":"e382e2b033e83fe7c6e77549e633f194695da9fa"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f2ccb5d5478c05bd04d9cafdd51cfc1ca86e723f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The sqlalchemy API has decorators to require"},{"line_number":10,"context_line":"a context or admin context argument to its DB"},{"line_number":11,"context_line":"methods.  This commit ensures that these decorators"},{"line_number":12,"context_line":"are applied consistently across the methods, and in"},{"line_number":13,"context_line":"accord with the following principles:"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_88ae99e5","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":34},"in_reply_to":"dab17558_29c978ad","updated":"2016-05-12 12:23:16.000000000","message":"Done","commit_id":"e382e2b033e83fe7c6e77549e633f194695da9fa"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7b626cf1437c1a248388410179883d2a3373f70a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"are applied consistently across the methods, and in"},{"line_number":13,"context_line":"accord with the following principles:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  1. private methods begin with underscore and"},{"line_number":16,"context_line":"     public methods do not"},{"line_number":17,"context_line":"  2. all public methods have appropriate context"},{"line_number":18,"context_line":"     requirement decorators"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_c9d6ec26","line":15,"range":{"start_line":15,"start_character":5,"end_line":15,"end_character":6},"updated":"2016-05-12 10:50:12.000000000","message":"Would be nice to make first letter in uppercase.","commit_id":"e382e2b033e83fe7c6e77549e633f194695da9fa"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f2ccb5d5478c05bd04d9cafdd51cfc1ca86e723f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"are applied consistently across the methods, and in"},{"line_number":13,"context_line":"accord with the following principles:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  1. private methods begin with underscore and"},{"line_number":16,"context_line":"     public methods do not"},{"line_number":17,"context_line":"  2. all public methods have appropriate context"},{"line_number":18,"context_line":"     requirement decorators"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_c8b8a12d","line":15,"range":{"start_line":15,"start_character":5,"end_line":15,"end_character":6},"in_reply_to":"dab17558_c9d6ec26","updated":"2016-05-12 12:23:16.000000000","message":"Done","commit_id":"e382e2b033e83fe7c6e77549e633f194695da9fa"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7b626cf1437c1a248388410179883d2a3373f70a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"     principle #2 is enforced."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Unit test methods that inappropriately called these"},{"line_number":24,"context_line":"methods without context havebeen corrected as well."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Closes-Bug:#1580690"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_e94bf05d","line":24,"range":{"start_line":24,"start_character":24,"end_line":24,"end_character":32},"updated":"2016-05-12 10:50:12.000000000","message":"havebeen","commit_id":"e382e2b033e83fe7c6e77549e633f194695da9fa"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"08bf161daf1a92617970f2d0466e246c76adb922","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix context decorator usage in DB API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The sqlalchemy API has decorators to require"},{"line_number":10,"context_line":"a context or admin context argument to its DB"},{"line_number":11,"context_line":"methods."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dab17558_0862a916","line":9,"updated":"2016-05-12 12:31:45.000000000","message":"\"The sqlalchemy API\" is imo missleading. Maybe better: \"Manila\u0027s sqlalchemy API...\"","commit_id":"0cecddb59d138ea11aba9c66c285ed4d9c8e5bea"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"b624cf8dc086dfc23cd18a3c514c4534d3ec3372","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix context decorator usage in DB API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The sqlalchemy API has decorators to require"},{"line_number":10,"context_line":"a context or admin context argument to its DB"},{"line_number":11,"context_line":"methods."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dab17558_f3ce3ab6","line":9,"in_reply_to":"dab17558_0862a916","updated":"2016-05-12 12:35:53.000000000","message":"Agree.","commit_id":"0cecddb59d138ea11aba9c66c285ed4d9c8e5bea"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"d4670c8cbe9b4e03fbf85dacb43a1910ae556e17","unresolved":false,"context_lines":[{"line_number":3647,"context_line":"        count()"},{"line_number":3648,"context_line":""},{"line_number":3649,"context_line":""},{"line_number":3650,"context_line":"@require_context"},{"line_number":3651,"context_line":"def _cgsnapshot_get(context, cgsnapshot_id, session\u003dNone):"},{"line_number":3652,"context_line":"    session \u003d session or get_session()"},{"line_number":3653,"context_line":"    result \u003d model_query(context, models.CGSnapshot, session\u003dsession,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_1b37d5ff","line":3650,"range":{"start_line":3650,"start_character":0,"end_line":3650,"end_character":16},"updated":"2016-05-11 12:40:35.000000000","message":"Missed this one?","commit_id":"77e4fd64156e52c7507f40d33e94c02c1aad497e"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"4703c5f6d67644578dec6db4cada848ee4f6c774","unresolved":false,"context_lines":[{"line_number":3647,"context_line":"        count()"},{"line_number":3648,"context_line":""},{"line_number":3649,"context_line":""},{"line_number":3650,"context_line":"@require_context"},{"line_number":3651,"context_line":"def _cgsnapshot_get(context, cgsnapshot_id, session\u003dNone):"},{"line_number":3652,"context_line":"    session \u003d session or get_session()"},{"line_number":3653,"context_line":"    result \u003d model_query(context, models.CGSnapshot, session\u003dsession,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_b68ce0da","line":3650,"range":{"start_line":3650,"start_character":0,"end_line":3650,"end_character":16},"in_reply_to":"dab17558_1b37d5ff","updated":"2016-05-11 12:55:45.000000000","message":"Yes, thanks!  I\u0027ll fix.","commit_id":"77e4fd64156e52c7507f40d33e94c02c1aad497e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7b626cf1437c1a248388410179883d2a3373f70a","unresolved":false,"context_lines":[{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"################"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"def extract_instance_values(values_to_extract, fields):"},{"line_number":1114,"context_line":"    values \u003d copy.deepcopy(values_to_extract)"},{"line_number":1115,"context_line":"    instance_values \u003d {}"},{"line_number":1116,"context_line":"    for field in fields:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_49695c25","line":1113,"range":{"start_line":1113,"start_character":0,"end_line":1113,"end_character":55},"updated":"2016-05-12 10:50:12.000000000","message":"Shouldn\u0027t it be a private method?","commit_id":"e382e2b033e83fe7c6e77549e633f194695da9fa"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f2ccb5d5478c05bd04d9cafdd51cfc1ca86e723f","unresolved":false,"context_lines":[{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"################"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"def extract_instance_values(values_to_extract, fields):"},{"line_number":1114,"context_line":"    values \u003d copy.deepcopy(values_to_extract)"},{"line_number":1115,"context_line":"    instance_values \u003d {}"},{"line_number":1116,"context_line":"    for field in fields:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_a819dd7b","line":1113,"range":{"start_line":1113,"start_character":0,"end_line":1113,"end_character":55},"in_reply_to":"dab17558_49695c25","updated":"2016-05-12 12:23:16.000000000","message":"Yes, thanks for the catch.","commit_id":"e382e2b033e83fe7c6e77549e633f194695da9fa"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7b626cf1437c1a248388410179883d2a3373f70a","unresolved":false,"context_lines":[{"line_number":1121,"context_line":"    return instance_values, values"},{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"def extract_share_instance_values(values):"},{"line_number":1125,"context_line":"    share_instance_model_fields \u003d ["},{"line_number":1126,"context_line":"        \u0027status\u0027, \u0027host\u0027, \u0027scheduled_at\u0027, \u0027launched_at\u0027, \u0027terminated_at\u0027,"},{"line_number":1127,"context_line":"        \u0027share_server_id\u0027, \u0027share_network_id\u0027, \u0027availability_zone\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_891ce4c2","line":1124,"range":{"start_line":1124,"start_character":0,"end_line":1124,"end_character":42},"updated":"2016-05-12 10:50:12.000000000","message":"Shouldn\u0027t it be a private method?","commit_id":"e382e2b033e83fe7c6e77549e633f194695da9fa"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f2ccb5d5478c05bd04d9cafdd51cfc1ca86e723f","unresolved":false,"context_lines":[{"line_number":1121,"context_line":"    return instance_values, values"},{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"def extract_share_instance_values(values):"},{"line_number":1125,"context_line":"    share_instance_model_fields \u003d ["},{"line_number":1126,"context_line":"        \u0027status\u0027, \u0027host\u0027, \u0027scheduled_at\u0027, \u0027launched_at\u0027, \u0027terminated_at\u0027,"},{"line_number":1127,"context_line":"        \u0027share_server_id\u0027, \u0027share_network_id\u0027, \u0027availability_zone\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_481f915b","line":1124,"range":{"start_line":1124,"start_character":0,"end_line":1124,"end_character":42},"in_reply_to":"dab17558_891ce4c2","updated":"2016-05-12 12:23:16.000000000","message":"ditto","commit_id":"e382e2b033e83fe7c6e77549e633f194695da9fa"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7b626cf1437c1a248388410179883d2a3373f70a","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"    return share_instance_values, share_values"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":""},{"line_number":1136,"context_line":"def extract_snapshot_instance_values(values):"},{"line_number":1137,"context_line":"    fields \u003d [\u0027status\u0027, \u0027progress\u0027, \u0027provider_location\u0027]"},{"line_number":1138,"context_line":"    snapshot_instance_values, snapshot_values \u003d ("},{"line_number":1139,"context_line":"        extract_instance_values(values, fields)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_290b387f","line":1136,"range":{"start_line":1136,"start_character":0,"end_line":1136,"end_character":45},"updated":"2016-05-12 10:50:12.000000000","message":"Shouldn\u0027t it be a private method?","commit_id":"e382e2b033e83fe7c6e77549e633f194695da9fa"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f2ccb5d5478c05bd04d9cafdd51cfc1ca86e723f","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"    return share_instance_values, share_values"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":""},{"line_number":1136,"context_line":"def extract_snapshot_instance_values(values):"},{"line_number":1137,"context_line":"    fields \u003d [\u0027status\u0027, \u0027progress\u0027, \u0027provider_location\u0027]"},{"line_number":1138,"context_line":"    snapshot_instance_values, snapshot_values \u003d ("},{"line_number":1139,"context_line":"        extract_instance_values(values, fields)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_285b2d30","line":1136,"range":{"start_line":1136,"start_character":0,"end_line":1136,"end_character":45},"in_reply_to":"dab17558_290b387f","updated":"2016-05-12 12:23:16.000000000","message":"ditto","commit_id":"e382e2b033e83fe7c6e77549e633f194695da9fa"}]}
