)]}'
{"manila/context.py":[{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"0b3668352a23fb5dfe7f56b02fcfbf926fefb2d7","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            \u0027timestamp\u0027: self.timestamp.isoformat() if hasattr("},{"line_number":116,"context_line":"                self, \u0027timestamp\u0027) else None,"},{"line_number":117,"context_line":"            \u0027quota_class\u0027: getattr(self, \u0027quota_class\u0027, None),"},{"line_number":118,"context_line":"            \u0027service_catalog\u0027: getattr(self, \u0027service_catalog\u0027, None)})"},{"line_number":119,"context_line":"        return values"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_bee400e0","line":118,"range":{"start_line":118,"start_character":68,"end_line":118,"end_character":71},"updated":"2016-05-16 09:03:13.000000000","message":"Is _read_deleted the only non-initialized attribute? Maybe, we can replace:\n\nself.read_deleted \u003d read_deleted   \n\nin line 78 with \n\nself._read_deleted \u003d read_deleted","commit_id":"f52d032be3760aa432b1bf57faedf52c44c18be6"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ff278ab0698dfb3c08c00c3e74e0981d957aa109","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            \u0027timestamp\u0027: self.timestamp.isoformat() if hasattr("},{"line_number":116,"context_line":"                self, \u0027timestamp\u0027) else None,"},{"line_number":117,"context_line":"            \u0027quota_class\u0027: getattr(self, \u0027quota_class\u0027, None),"},{"line_number":118,"context_line":"            \u0027service_catalog\u0027: getattr(self, \u0027service_catalog\u0027, None)})"},{"line_number":119,"context_line":"        return values"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_a3a18048","line":118,"range":{"start_line":118,"start_character":68,"end_line":118,"end_character":71},"in_reply_to":"dab17558_bee400e0","updated":"2016-05-16 10:42:41.000000000","message":"Which variables are uninitialized depends on code order.\n\nAll of the attributes in the update are added to the context by manila and therefore may not be present early in the context setup depending on when to_dict() gets triggered.  When it is triggered is not entirely under our control since oslo code may invoke it.  That\u0027s why my initial fix moving lines around to avoid this issue is too fragile and it\u0027s better just to handle all of these attributes that manila sets after the pure oslo context creation.\n\nI agree that the code you point to is over-complicated.  You could address that as a separate patch :)","commit_id":"f52d032be3760aa432b1bf57faedf52c44c18be6"}]}