)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"4de4351ed62cb5ee454a96b031fc3c28603c9dbb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Driver private storage admin API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds an admin API to retrieve"},{"line_number":10,"context_line":"driver private storage data."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If9e5ab3ef411a193158afc0a43d597c98ef27397"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_408818c7","line":9,"updated":"2016-05-12 08:57:40.000000000","message":"Can you explain *why* you want to do that? It\u0027s not in the commit msg and also not in the blueprint. Is it for debugging?","commit_id":"de34d7224313558a5aaa59c8d39296ed3f06669b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f2d6199af5df3e72f4c732be5acc06bc269c9ef9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Driver private storage admin API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds an admin API to retrieve"},{"line_number":10,"context_line":"driver private storage data."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If9e5ab3ef411a193158afc0a43d597c98ef27397"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_10113d5e","line":9,"in_reply_to":"dab17558_408818c7","updated":"2016-05-12 10:09:25.000000000","message":"Add completely new APIs only for debugging? Nice. For this sake better to use \"manila-manage\" approach. It also does not require auth in identity service and will serve \"debug\" needs without any problems.","commit_id":"de34d7224313558a5aaa59c8d39296ed3f06669b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"efbcb96d7a109c35db4fa84c896503ae9caaee56","unresolved":false,"context_lines":[{"line_number":14,"context_line":"this API to check what is in driver private storage before"},{"line_number":15,"context_line":"performing an operation on a resource."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"APIImpact"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Co-Authored-By: Accela Zhao \u003caccelazh@gmail.com\u003e"},{"line_number":20,"context_line":"Depends-On: Ifd0b290b2992f6b0792250b86466d9329dfd08a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bacf61ea_4a0d8f8f","line":17,"range":{"start_line":17,"start_character":9,"end_line":17,"end_character":9},"updated":"2016-07-28 16:10:22.000000000","message":"DocImpact","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8659bbde21b9597a72e31e649122aabfb6e53a62","unresolved":false,"context_lines":[{"line_number":17,"context_line":"storage\". This patch also replaces them to \"driver private data\""},{"line_number":18,"context_line":"to avoid confusion."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"APIImpact"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Co-Authored-By: Accela Zhao \u003caccelazh@gmail.com\u003e"},{"line_number":23,"context_line":"Depends-On: Ifd0b290b2992f6b0792250b86466d9329dfd08a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"3ac371cc_50d1f9fa","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":9},"updated":"2016-08-15 03:22:38.000000000","message":"DocImpact\n\nYou will need to add this API to the in-tree API reference..","commit_id":"15ee00cd29fe38ca40a7bce76387016294fed0c7"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"7e90a0a4e80225e879765ce17a36498e7eb7178a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"storage\". This patch also replaces them to \"driver private data\""},{"line_number":18,"context_line":"to avoid confusion."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"APIImpact"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Co-Authored-By: Accela Zhao \u003caccelazh@gmail.com\u003e"},{"line_number":23,"context_line":"Depends-On: Ifd0b290b2992f6b0792250b86466d9329dfd08a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"3ac371cc_d7ddca71","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":9},"in_reply_to":"3ac371cc_50d1f9fa","updated":"2016-08-15 14:27:28.000000000","message":"Added DocImpact. I\u0027ve searched the in-tree doc, but the api-reference section looks entirely empty: https://github.com/openstack/manila/blob/master/doc/source/devref/index.rst#api-reference. Would you please show me some hints about where should I add API doc for driver private data? Thanks a lot!","commit_id":"15ee00cd29fe38ca40a7bce76387016294fed0c7"}],"etc/manila/policy.json":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"2855fa3983771cf8e61881040bc28981d1a86bd4","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    \"share_replica:resync\": \"rule:admin_api\","},{"line_number":127,"context_line":"    \"share_replica:reset_status\": \"rule:admin_api\","},{"line_number":128,"context_line":"    \"share_replica:force_delete\": \"rule:admin_api\","},{"line_number":129,"context_line":"    \"share_replica:reset_replica_state\": \"rule:admin_api\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    \"driver_private_data:index\": \"rule:admin_api\""},{"line_number":132,"context_line":"}"}],"source_content_type":"application/json","patch_set":1,"id":"dab17558_1a5a0151","line":129,"range":{"start_line":129,"start_character":55,"end_line":129,"end_character":57},"updated":"2016-05-12 08:39:42.000000000","message":"add comma","commit_id":"de34d7224313558a5aaa59c8d39296ed3f06669b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f2d6199af5df3e72f4c732be5acc06bc269c9ef9","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    \"share_replica:resync\": \"rule:admin_api\","},{"line_number":127,"context_line":"    \"share_replica:reset_status\": \"rule:admin_api\","},{"line_number":128,"context_line":"    \"share_replica:force_delete\": \"rule:admin_api\","},{"line_number":129,"context_line":"    \"share_replica:reset_replica_state\": \"rule:admin_api\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    \"driver_private_data:index\": \"rule:admin_api\""},{"line_number":132,"context_line":"}"}],"source_content_type":"application/json","patch_set":1,"id":"dab17558_d3fdff09","line":129,"range":{"start_line":129,"start_character":55,"end_line":129,"end_character":57},"in_reply_to":"dab17558_1a5a0151","updated":"2016-05-12 10:09:25.000000000","message":"+1, it is a must.","commit_id":"de34d7224313558a5aaa59c8d39296ed3f06669b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"2855fa3983771cf8e61881040bc28981d1a86bd4","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    \"share_replica:reset_status\": \"rule:admin_api\","},{"line_number":128,"context_line":"    \"share_replica:force_delete\": \"rule:admin_api\","},{"line_number":129,"context_line":"    \"share_replica:reset_replica_state\": \"rule:admin_api\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    \"driver_private_data:index\": \"rule:admin_api\""},{"line_number":132,"context_line":"}"}],"source_content_type":"application/json","patch_set":1,"id":"dab17558_9a4d519c","line":130,"updated":"2016-05-12 08:39:42.000000000","message":"remove blank line","commit_id":"de34d7224313558a5aaa59c8d39296ed3f06669b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f2d6199af5df3e72f4c732be5acc06bc269c9ef9","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    \"share_replica:reset_status\": \"rule:admin_api\","},{"line_number":128,"context_line":"    \"share_replica:force_delete\": \"rule:admin_api\","},{"line_number":129,"context_line":"    \"share_replica:reset_replica_state\": \"rule:admin_api\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    \"driver_private_data:index\": \"rule:admin_api\""},{"line_number":132,"context_line":"}"}],"source_content_type":"application/json","patch_set":1,"id":"dab17558_13082728","line":130,"in_reply_to":"dab17558_9a4d519c","updated":"2016-05-12 10:09:25.000000000","message":"+1, nice to have.","commit_id":"de34d7224313558a5aaa59c8d39296ed3f06669b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b0a3561abd13e3613fe7b6cf6cc5ec67391ac047","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    \"share_replica:reset_status\": \"rule:admin_api\","},{"line_number":128,"context_line":"    \"share_replica:force_delete\": \"rule:admin_api\","},{"line_number":129,"context_line":"    \"share_replica:reset_replica_state\": \"rule:admin_api\","},{"line_number":130,"context_line":"    \"driver_private_data:index\": \"rule:admin_api\""},{"line_number":131,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"1aa78d24_e002a3b3","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":49},"updated":"2016-07-15 02:22:01.000000000","message":"please put this in its own section. i.e, add an empty line above","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"52ee72da3752296635802c93ad17e160cbd9353e","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    \"share_replica:reset_status\": \"rule:admin_api\","},{"line_number":128,"context_line":"    \"share_replica:force_delete\": \"rule:admin_api\","},{"line_number":129,"context_line":"    \"share_replica:reset_replica_state\": \"rule:admin_api\","},{"line_number":130,"context_line":"    \"driver_private_data:index\": \"rule:admin_api\""},{"line_number":131,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"fad55976_3e68a1ba","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":49},"in_reply_to":"1aa78d24_e002a3b3","updated":"2016-07-15 21:02:39.000000000","message":"Done.","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f6a6953a7455f887f21fa425fcedab986f6de32","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    \"share_replica:force_delete\": \"rule:admin_api\","},{"line_number":134,"context_line":"    \"share_replica:reset_replica_state\": \"rule:admin_api\","},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    \"driver_private_data:index\": \"rule:admin_api\""},{"line_number":137,"context_line":"}"}],"source_content_type":"application/json","patch_set":15,"id":"3ac371cc_700075ab","line":136,"range":{"start_line":136,"start_character":25,"end_line":136,"end_character":30},"updated":"2016-08-15 03:23:05.000000000","message":"get_all_for_entity","commit_id":"ef76cad61c083142d70fd5492bdd78cfd10d20e6"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"4aac70e5041c5492456286427c8ba532a0272e0e","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    \"share_replica:force_delete\": \"rule:admin_api\","},{"line_number":134,"context_line":"    \"share_replica:reset_replica_state\": \"rule:admin_api\","},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    \"driver_private_data:index\": \"rule:admin_api\""},{"line_number":137,"context_line":"}"}],"source_content_type":"application/json","patch_set":15,"id":"3ac371cc_3d04ff13","line":136,"range":{"start_line":136,"start_character":25,"end_line":136,"end_character":30},"in_reply_to":"3ac371cc_700075ab","updated":"2016-08-15 14:27:08.000000000","message":"See comment for https://review.openstack.org/#/c/315346/15/manila/api/v2/driver_private_data.py","commit_id":"ef76cad61c083142d70fd5492bdd78cfd10d20e6"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ede0a31fbf506b164bda5c8fa0a0982bac48ea41","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"class APIVersionRequest(utils.ComparableMixin):"},{"line_number":93,"context_line":"    \"\"\"This class represents an API Version Request."},{"line_number":94,"context_line":"    This class includes convenience methods for manipulation"},{"line_number":95,"context_line":"    and comparison of version numbers as needed to implement"},{"line_number":96,"context_line":"    API microversions."},{"line_number":97,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_5cf265d3","line":94,"updated":"2016-07-11 10:05:16.000000000","message":"You removed a blank line here and it causes [H405] error:\nhttp://docs.openstack.org/developer/hacking/","commit_id":"b4c6567c8ea6e9e224e4328ae88a7bc10ac031f7"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"f1b9aa90f812d454add5edd22c7f8e92b0b7dbaa","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"class APIVersionRequest(utils.ComparableMixin):"},{"line_number":93,"context_line":"    \"\"\"This class represents an API Version Request."},{"line_number":94,"context_line":"    This class includes convenience methods for manipulation"},{"line_number":95,"context_line":"    and comparison of version numbers as needed to implement"},{"line_number":96,"context_line":"    API microversions."},{"line_number":97,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_3b4511b3","line":94,"in_reply_to":"1aa78d24_5cf265d3","updated":"2016-07-14 15:33:11.000000000","message":"Thanks, Tom! It\u0027s weird that I happened to have deleted those lines. Thank you for locating them!","commit_id":"b4c6567c8ea6e9e224e4328ae88a7bc10ac031f7"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ede0a31fbf506b164bda5c8fa0a0982bac48ea41","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def matches(self, min_version, max_version, experimental\u003dFalse):"},{"line_number":150,"context_line":"        \"\"\"Compares this version to the specified min/max range."},{"line_number":151,"context_line":"        Returns whether the version object represents a version"},{"line_number":152,"context_line":"        greater than or equal to the minimum version and less than"},{"line_number":153,"context_line":"        or equal to the maximum version."},{"line_number":154,"context_line":"        If min_version is null then there is no minimum limit."}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_bcaee995","line":151,"updated":"2016-07-11 10:05:16.000000000","message":"You removed a blank line here and it causes [H405] error:\nhttp://docs.openstack.org/developer/hacking/","commit_id":"b4c6567c8ea6e9e224e4328ae88a7bc10ac031f7"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"f1b9aa90f812d454add5edd22c7f8e92b0b7dbaa","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def matches(self, min_version, max_version, experimental\u003dFalse):"},{"line_number":150,"context_line":"        \"\"\"Compares this version to the specified min/max range."},{"line_number":151,"context_line":"        Returns whether the version object represents a version"},{"line_number":152,"context_line":"        greater than or equal to the minimum version and less than"},{"line_number":153,"context_line":"        or equal to the maximum version."},{"line_number":154,"context_line":"        If min_version is null then there is no minimum limit."}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_bb0f4187","line":151,"in_reply_to":"1aa78d24_bcaee995","updated":"2016-07-14 15:33:11.000000000","message":"Ditto.","commit_id":"b4c6567c8ea6e9e224e4328ae88a7bc10ac031f7"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ede0a31fbf506b164bda5c8fa0a0982bac48ea41","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        Returns whether the version object represents a version"},{"line_number":152,"context_line":"        greater than or equal to the minimum version and less than"},{"line_number":153,"context_line":"        or equal to the maximum version."},{"line_number":154,"context_line":"        If min_version is null then there is no minimum limit."},{"line_number":155,"context_line":"        If max_version is null then there is no maximum limit."},{"line_number":156,"context_line":"        If self is null then raise ValueError."},{"line_number":157,"context_line":"        :param min_version: Minimum acceptable version."}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_9c8fad22","line":154,"updated":"2016-07-11 10:05:16.000000000","message":"You removed a blank line - shouldn\u0027t make unneeded whitespace changes.","commit_id":"b4c6567c8ea6e9e224e4328ae88a7bc10ac031f7"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"f1b9aa90f812d454add5edd22c7f8e92b0b7dbaa","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        Returns whether the version object represents a version"},{"line_number":152,"context_line":"        greater than or equal to the minimum version and less than"},{"line_number":153,"context_line":"        or equal to the maximum version."},{"line_number":154,"context_line":"        If min_version is null then there is no minimum limit."},{"line_number":155,"context_line":"        If max_version is null then there is no maximum limit."},{"line_number":156,"context_line":"        If self is null then raise ValueError."},{"line_number":157,"context_line":"        :param min_version: Minimum acceptable version."}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_3b1cf1c0","line":154,"in_reply_to":"1aa78d24_9c8fad22","updated":"2016-07-14 15:33:11.000000000","message":"Ditto.","commit_id":"b4c6567c8ea6e9e224e4328ae88a7bc10ac031f7"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ede0a31fbf506b164bda5c8fa0a0982bac48ea41","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        If min_version is null then there is no minimum limit."},{"line_number":155,"context_line":"        If max_version is null then there is no maximum limit."},{"line_number":156,"context_line":"        If self is null then raise ValueError."},{"line_number":157,"context_line":"        :param min_version: Minimum acceptable version."},{"line_number":158,"context_line":"        :param max_version: Maximum acceptable version."},{"line_number":159,"context_line":"        :param experimental: Whether to match experimental APIs."},{"line_number":160,"context_line":"        :returns: boolean"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_bcb389e8","line":157,"updated":"2016-07-11 10:05:16.000000000","message":"You removed a blank line - shouldn\u0027t make unneeded whitespace changes.","commit_id":"b4c6567c8ea6e9e224e4328ae88a7bc10ac031f7"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"f1b9aa90f812d454add5edd22c7f8e92b0b7dbaa","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        If min_version is null then there is no minimum limit."},{"line_number":155,"context_line":"        If max_version is null then there is no maximum limit."},{"line_number":156,"context_line":"        If self is null then raise ValueError."},{"line_number":157,"context_line":"        :param min_version: Minimum acceptable version."},{"line_number":158,"context_line":"        :param max_version: Maximum acceptable version."},{"line_number":159,"context_line":"        :param experimental: Whether to match experimental APIs."},{"line_number":160,"context_line":"        :returns: boolean"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_7b7cb9eb","line":157,"in_reply_to":"1aa78d24_bcb389e8","updated":"2016-07-14 15:33:11.000000000","message":"Ditto.","commit_id":"b4c6567c8ea6e9e224e4328ae88a7bc10ac031f7"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ede0a31fbf506b164bda5c8fa0a0982bac48ea41","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def get_string(self):"},{"line_number":180,"context_line":"        \"\"\"Returns a string representation of this object."},{"line_number":181,"context_line":"        If this method is used to create an APIVersionRequest,"},{"line_number":182,"context_line":"        the resulting object will be an equivalent request."},{"line_number":183,"context_line":"        \"\"\""},{"line_number":184,"context_line":"        if self.is_null():"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_1cd29d00","line":181,"updated":"2016-07-11 10:05:16.000000000","message":"You removed a blank line here and it causes [H405] error:\nhttp://docs.openstack.org/developer/hacking/","commit_id":"b4c6567c8ea6e9e224e4328ae88a7bc10ac031f7"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"f1b9aa90f812d454add5edd22c7f8e92b0b7dbaa","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def get_string(self):"},{"line_number":180,"context_line":"        \"\"\"Returns a string representation of this object."},{"line_number":181,"context_line":"        If this method is used to create an APIVersionRequest,"},{"line_number":182,"context_line":"        the resulting object will be an equivalent request."},{"line_number":183,"context_line":"        \"\"\""},{"line_number":184,"context_line":"        if self.is_null():"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_db816dc5","line":181,"in_reply_to":"1aa78d24_1cd29d00","updated":"2016-07-14 15:33:11.000000000","message":"Ditto.","commit_id":"b4c6567c8ea6e9e224e4328ae88a7bc10ac031f7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"619294513533e604af00b7b217d7b5fb7f873fe2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    * 2.18 - Add gateway to the JSON response of share network show API."},{"line_number":72,"context_line":"    * 2.19 - Share snapshot instances admin APIs"},{"line_number":73,"context_line":"            (list/show/detail/reset-status)."},{"line_number":74,"context_line":"    * 2.20 - Add admin API to show driver private data."},{"line_number":75,"context_line":"\"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_51667fbb","line":74,"range":{"start_line":74,"start_character":35,"end_line":74,"end_character":55},"updated":"2016-08-05 06:47:14.000000000","message":"Please, be consistent, here you say \"private data\" but in history file \"private storage\".","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"29dcb50ac6f726009923ff049185ff6f6e069b7b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    * 2.18 - Add gateway to the JSON response of share network show API."},{"line_number":72,"context_line":"    * 2.19 - Share snapshot instances admin APIs"},{"line_number":73,"context_line":"            (list/show/detail/reset-status)."},{"line_number":74,"context_line":"    * 2.20 - Add admin API to show driver private data."},{"line_number":75,"context_line":"\"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_4c480688","line":74,"range":{"start_line":74,"start_character":35,"end_line":74,"end_character":55},"in_reply_to":"bacf61ea_51667fbb","updated":"2016-08-09 15:17:45.000000000","message":"Done.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"f026b4da93141605646a9e77e9447c9b005ce805","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    * 2.18 - Add gateway to the JSON response of share network show API."},{"line_number":72,"context_line":"    * 2.19 - Share snapshot instances admin APIs"},{"line_number":73,"context_line":"            (list/show/detail/reset-status)."},{"line_number":74,"context_line":"    * 2.20 - Add admin API to show driver private data."},{"line_number":75,"context_line":"\"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_ff4c3178","line":74,"range":{"start_line":74,"start_character":6,"end_line":74,"end_character":10},"updated":"2016-08-15 06:49:55.000000000","message":"should be 2.21 now","commit_id":"15ee00cd29fe38ca40a7bce76387016294fed0c7"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"7e90a0a4e80225e879765ce17a36498e7eb7178a","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    * 2.18 - Add gateway to the JSON response of share network show API."},{"line_number":72,"context_line":"    * 2.19 - Share snapshot instances admin APIs"},{"line_number":73,"context_line":"            (list/show/detail/reset-status)."},{"line_number":74,"context_line":"    * 2.20 - Add admin API to show driver private data."},{"line_number":75,"context_line":"\"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_5d373bb0","line":74,"range":{"start_line":74,"start_character":6,"end_line":74,"end_character":10},"in_reply_to":"3ac371cc_ff4c3178","updated":"2016-08-15 14:27:28.000000000","message":"Done.","commit_id":"15ee00cd29fe38ca40a7bce76387016294fed0c7"}],"manila/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"f026b4da93141605646a9e77e9447c9b005ce805","unresolved":false,"context_lines":[{"line_number":123,"context_line":"----"},{"line_number":124,"context_line":"  Add admin APIs(list/show/detail/reset-status) of snapshot instances."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"2.20"},{"line_number":127,"context_line":"----"},{"line_number":128,"context_line":"  Add admin API to show driver private data."}],"source_content_type":"text/x-rst","patch_set":16,"id":"3ac371cc_df517510","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":4},"updated":"2016-08-15 06:49:55.000000000","message":"2.21","commit_id":"15ee00cd29fe38ca40a7bce76387016294fed0c7"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"7e90a0a4e80225e879765ce17a36498e7eb7178a","unresolved":false,"context_lines":[{"line_number":123,"context_line":"----"},{"line_number":124,"context_line":"  Add admin APIs(list/show/detail/reset-status) of snapshot instances."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"2.20"},{"line_number":127,"context_line":"----"},{"line_number":128,"context_line":"  Add admin API to show driver private data."}],"source_content_type":"text/x-rst","patch_set":16,"id":"3ac371cc_7d467724","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":4},"in_reply_to":"3ac371cc_df517510","updated":"2016-08-15 14:27:28.000000000","message":"Done.","commit_id":"15ee00cd29fe38ca40a7bce76387016294fed0c7"}],"manila/api/v2/driver_private_data.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"2855fa3983771cf8e61881040bc28981d1a86bd4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import webob.exc"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from manila.api.openstack import wsgi"},{"line_number":19,"context_line":"from manila.api.views import driver_private_data as private_views"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_05e622e8","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":16},"updated":"2016-05-12 08:39:42.000000000","message":"You aren\u0027t using this import.","commit_id":"de34d7224313558a5aaa59c8d39296ed3f06669b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b0a3561abd13e3613fe7b6cf6cc5ec67391ac047","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @wsgi.Controller.api_version(\u00272.19\u0027)"},{"line_number":32,"context_line":"    @wsgi.Controller.authorize(\"index\")"},{"line_number":33,"context_line":"    def private_index(self, req, entity_id):"},{"line_number":34,"context_line":"        \"\"\"Returns driver private data.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_20d2eb34","line":33,"range":{"start_line":33,"start_character":33,"end_line":33,"end_character":42},"updated":"2016-07-15 02:22:01.000000000","message":"How do you know the entity_id? It\u0027s something that the driver knows to make up, as per the use case. Wouldn\u0027t it be better to implement an index call for the entire driver\u0027s private data?\n\nSuch an index call should support pagination.","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b0a3561abd13e3613fe7b6cf6cc5ec67391ac047","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @wsgi.Controller.api_version(\u00272.19\u0027)"},{"line_number":32,"context_line":"    @wsgi.Controller.authorize(\"index\")"},{"line_number":33,"context_line":"    def private_index(self, req, entity_id):"},{"line_number":34,"context_line":"        \"\"\"Returns driver private data.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_6025135b","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":21},"updated":"2016-07-15 02:22:01.000000000","message":"why the special name? Why not just \u0027index\u0027","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"52ee72da3752296635802c93ad17e160cbd9353e","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @wsgi.Controller.api_version(\u00272.19\u0027)"},{"line_number":32,"context_line":"    @wsgi.Controller.authorize(\"index\")"},{"line_number":33,"context_line":"    def private_index(self, req, entity_id):"},{"line_number":34,"context_line":"        \"\"\"Returns driver private data.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"fad55976_bea011a7","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":21},"in_reply_to":"1aa78d24_6025135b","updated":"2016-07-15 21:02:39.000000000","message":"Good questions. Let me check with peers. Reply you later.","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3035537c01d529b6518a85c20e5eb5798c1610ca","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @wsgi.Controller.api_version(\u00272.19\u0027)"},{"line_number":32,"context_line":"    @wsgi.Controller.authorize(\"index\")"},{"line_number":33,"context_line":"    def private_index(self, req, entity_id):"},{"line_number":34,"context_line":"        \"\"\"Returns driver private data.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_653b8b39","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":21},"in_reply_to":"dada55a8_6591cb52","updated":"2016-07-22 16:11:50.000000000","message":"Nice, good stuff. Will review the latest patch... Thanks!","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"99970a54485323902ca527d73d6339b017f291e2","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @wsgi.Controller.api_version(\u00272.19\u0027)"},{"line_number":32,"context_line":"    @wsgi.Controller.authorize(\"index\")"},{"line_number":33,"context_line":"    def private_index(self, req, entity_id):"},{"line_number":34,"context_line":"        \"\"\"Returns driver private data.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_6591cb52","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":21},"in_reply_to":"fad55976_3964c620","updated":"2016-07-22 16:09:36.000000000","message":"Goutham,\n\nI chatted with Ben and Clinton here about this.  Both of them think we don\u0027t need to get all private data.  We\u0027ll retrieve driver private data right after a volume or snapshot is created.  We know the uuid.  So it makes more sense just to get driver private data based on one uuid.  Thanks.","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f5ccbb77217d04ed18abb14f0d8628025552ab1b","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @wsgi.Controller.api_version(\u00272.19\u0027)"},{"line_number":32,"context_line":"    @wsgi.Controller.authorize(\"index\")"},{"line_number":33,"context_line":"    def private_index(self, req, entity_id):"},{"line_number":34,"context_line":"        \"\"\"Returns driver private data.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"fad55976_b9555651","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":21},"in_reply_to":"fad55976_59109aa8","updated":"2016-07-17 05:48:51.000000000","message":"No, i\u0027m okay with calling it entity_id; but I want to know if that will be consistent with all of the driver actions? Is it always expected to be a ID associated with a manila resource? I was suggesting that it\u0027s better to implement an API to get all private data belonging to a driver, and allow filters and sorting (standard pagination), so that the clients can request with entity_id as a filter if they really know it.. \n\nEither that, i\u0027m grossly misunderstanding the intent of this API :)","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c7414cd0b50705acececad832e2ab4792ffeddcd","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @wsgi.Controller.api_version(\u00272.19\u0027)"},{"line_number":32,"context_line":"    @wsgi.Controller.authorize(\"index\")"},{"line_number":33,"context_line":"    def private_index(self, req, entity_id):"},{"line_number":34,"context_line":"        \"\"\"Returns driver private data.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"fad55976_3964c620","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":21},"in_reply_to":"fad55976_b9555651","updated":"2016-07-17 06:38:41.000000000","message":"Any Manila resource (volume, snapshot, etc) should have an ID.  Also entity ID is required to add a private data entry in the DB.\n\nhttps://github.com/openstack/manila/blob/master/manila/db/sqlalchemy/models.py#L878\n\nWe can look into the idea of getting all private data, but this could be a lot of data, including all volumes, snapshots, etc on the backend.  I thought the purpose of having this API is to examine the private data for one particular resource.","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b7f05cc76c42ff685b9b34c9d26d640f685b3600","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @wsgi.Controller.api_version(\u00272.19\u0027)"},{"line_number":32,"context_line":"    @wsgi.Controller.authorize(\"index\")"},{"line_number":33,"context_line":"    def private_index(self, req, entity_id):"},{"line_number":34,"context_line":"        \"\"\"Returns driver private data.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"fad55976_59109aa8","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":21},"in_reply_to":"fad55976_bea011a7","updated":"2016-07-17 05:43:28.000000000","message":"This is because it is called entity_id in DB APIs.  An entity id could be a volume uuid or snapshot uuid, etc.  Maybe resource id is more clear, but it\u0027s better to be consistent with the parameter names in the DB APIs.\n\nhttps://github.com/openstack/manila/blob/master/manila/db/sqlalchemy/api.py#L2860","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bac0e426f686729af41d4afa969ab91f73ed052b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \"\"\"Returns driver private data.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":37,"context_line":"        private_storage \u003d db.driver_private_data_get("},{"line_number":38,"context_line":"            context, entity_id)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        return self._view_builder.show(private_storage)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_46432c13","line":38,"range":{"start_line":37,"start_character":8,"end_line":38,"end_character":31},"updated":"2016-07-21 16:23:53.000000000","message":"It is broken. There is 3 required arguments. See https://github.com/openstack/manila/blob/aeea2b3b/manila/db/sqlalchemy/api.py#L2860","commit_id":"ddda0cd3a43a7ec8d7ca4c5febf625c9006d1589"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"33df9dc4cbae7eb3d01a29dc0e8f087ee916d1b0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \"\"\"Returns driver private data.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":37,"context_line":"        private_storage \u003d db.driver_private_data_get("},{"line_number":38,"context_line":"            context, entity_id)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        return self._view_builder.show(private_storage)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_b87540cc","line":38,"range":{"start_line":37,"start_character":8,"end_line":38,"end_character":31},"in_reply_to":"dada55a8_46432c13","updated":"2016-07-26 07:52:55.000000000","message":"This patch depends on #339592. I will add a \"Depends-On\" in commit message of the next patch.","commit_id":"ddda0cd3a43a7ec8d7ca4c5febf625c9006d1589"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"efbcb96d7a109c35db4fa84c896503ae9caaee56","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @wsgi.Controller.api_version(\u00272.19\u0027)"},{"line_number":32,"context_line":"    @wsgi.Controller.authorize(\"index\")"},{"line_number":33,"context_line":"    def private_index(self, req, entity_id):"},{"line_number":34,"context_line":"        \"\"\"Returns driver private data.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_c535f0da","line":33,"range":{"start_line":33,"start_character":33,"end_line":33,"end_character":42},"updated":"2016-07-28 16:10:22.000000000","message":"How about verify entity_id?  If entity id is not exist, it will return exc.HTTPNotFound?","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffddb7a7e3c0ada1a706f62cb19a5c847daa83d4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \"\"\"Returns driver private data.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":37,"context_line":"        private_storage \u003d db.driver_private_data_get("},{"line_number":38,"context_line":"            context, entity_id)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        return self._view_builder.show(private_storage)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_91947737","line":38,"range":{"start_line":37,"start_character":8,"end_line":38,"end_character":31},"updated":"2016-08-05 06:50:21.000000000","message":"API should return NotFound error in case entity_id is not found. It would be proper user experience, he will get know that it is not set instead of improper understanding that it exists and just empty.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"29dcb50ac6f726009923ff049185ff6f6e069b7b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \"\"\"Returns driver private data.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":37,"context_line":"        private_storage \u003d db.driver_private_data_get("},{"line_number":38,"context_line":"            context, entity_id)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        return self._view_builder.show(private_storage)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_cc68768a","line":38,"range":{"start_line":37,"start_character":8,"end_line":38,"end_character":31},"in_reply_to":"bacf61ea_91947737","updated":"2016-08-09 15:17:45.000000000","message":"Done.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f6a6953a7455f887f21fa425fcedab986f6de32","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @wsgi.Controller.api_version(\u00272.20\u0027)"},{"line_number":35,"context_line":"    @wsgi.Controller.authorize(\"index\")"},{"line_number":36,"context_line":"    def private_index(self, req, entity_id):"},{"line_number":37,"context_line":"        \"\"\"Returns driver private data.\"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_10266168","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":21},"updated":"2016-08-15 03:23:05.000000000","message":"get_all_for_entity","commit_id":"ef76cad61c083142d70fd5492bdd78cfd10d20e6"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"4aac70e5041c5492456286427c8ba532a0272e0e","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @wsgi.Controller.api_version(\u00272.20\u0027)"},{"line_number":35,"context_line":"    @wsgi.Controller.authorize(\"index\")"},{"line_number":36,"context_line":"    def private_index(self, req, entity_id):"},{"line_number":37,"context_line":"        \"\"\"Returns driver private data.\"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_82179250","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":21},"in_reply_to":"3ac371cc_10266168","updated":"2016-08-15 14:27:08.000000000","message":"It\u0027s a good catch. But previously we had a discussion about why use special name \"private_index\": https://review.openstack.org/#/c/315346/7/manila/api/v2/driver_private_data.py.","commit_id":"ef76cad61c083142d70fd5492bdd78cfd10d20e6"}],"manila/api/v2/router.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b0a3561abd13e3613fe7b6cf6cc5ec67391ac047","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        self.resources[\"driver_private_data\"] \u003d ("},{"line_number":276,"context_line":"            driver_private_data.create_resource())"},{"line_number":277,"context_line":"        mapper.connect(\"driver_private_data\","},{"line_number":278,"context_line":"                       \"/{project_id}/driver_private_data/{entity_id}\","},{"line_number":279,"context_line":"                       controller\u003dself.resources[\"driver_private_data\"],"},{"line_number":280,"context_line":"                       action\u003d\"private_index\","},{"line_number":281,"context_line":"                       conditions\u003d{\"method\": [\"GET\"]})"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_60b3530b","line":278,"range":{"start_line":278,"start_character":38,"end_line":278,"end_character":57},"updated":"2016-07-15 02:22:01.000000000","message":"we use \u0027-\u0027 over underscores in the URI","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"52ee72da3752296635802c93ad17e160cbd9353e","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        self.resources[\"driver_private_data\"] \u003d ("},{"line_number":276,"context_line":"            driver_private_data.create_resource())"},{"line_number":277,"context_line":"        mapper.connect(\"driver_private_data\","},{"line_number":278,"context_line":"                       \"/{project_id}/driver_private_data/{entity_id}\","},{"line_number":279,"context_line":"                       controller\u003dself.resources[\"driver_private_data\"],"},{"line_number":280,"context_line":"                       action\u003d\"private_index\","},{"line_number":281,"context_line":"                       conditions\u003d{\"method\": [\"GET\"]})"}],"source_content_type":"text/x-python","patch_set":7,"id":"fad55976_5ee2b5a0","line":278,"range":{"start_line":278,"start_character":38,"end_line":278,"end_character":57},"in_reply_to":"1aa78d24_60b3530b","updated":"2016-07-15 21:02:39.000000000","message":"Done.","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b0a3561abd13e3613fe7b6cf6cc5ec67391ac047","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            driver_private_data.create_resource())"},{"line_number":277,"context_line":"        mapper.connect(\"driver_private_data\","},{"line_number":278,"context_line":"                       \"/{project_id}/driver_private_data/{entity_id}\","},{"line_number":279,"context_line":"                       controller\u003dself.resources[\"driver_private_data\"],"},{"line_number":280,"context_line":"                       action\u003d\"private_index\","},{"line_number":281,"context_line":"                       conditions\u003d{\"method\": [\"GET\"]})"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        self.resources[\"consistency-groups\"] \u003d ("},{"line_number":284,"context_line":"            consistency_groups.create_resource())"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_40ad779a","line":281,"range":{"start_line":279,"start_character":23,"end_line":281,"end_character":54},"updated":"2016-07-15 02:22:01.000000000","message":"self.resources[\u0027driver-private-data\u0027] \u003d driver_private_data.create_resource()\nmapper.resource(\"driver-private-data\", \"driver_private_data\",\n                controller\u003dself.resources[\u0027driver-private-data\u0027],\n                collection\u003d{\u0027detail\u0027: \u0027GET\u0027})","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"52ee72da3752296635802c93ad17e160cbd9353e","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            driver_private_data.create_resource())"},{"line_number":277,"context_line":"        mapper.connect(\"driver_private_data\","},{"line_number":278,"context_line":"                       \"/{project_id}/driver_private_data/{entity_id}\","},{"line_number":279,"context_line":"                       controller\u003dself.resources[\"driver_private_data\"],"},{"line_number":280,"context_line":"                       action\u003d\"private_index\","},{"line_number":281,"context_line":"                       conditions\u003d{\"method\": [\"GET\"]})"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        self.resources[\"consistency-groups\"] \u003d ("},{"line_number":284,"context_line":"            consistency_groups.create_resource())"}],"source_content_type":"text/x-python","patch_set":7,"id":"fad55976_be177153","line":281,"range":{"start_line":279,"start_character":23,"end_line":281,"end_character":54},"in_reply_to":"1aa78d24_40ad779a","updated":"2016-07-15 21:02:39.000000000","message":"Thanks for providing code! I will fix it after the \"private_index\".","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"}],"manila/api/views/driver_private_data.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8bfe9a8192a59e90dd3e6281b8af671e27f2b345","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    def show(self, private_storage):"},{"line_number":24,"context_line":"        \"\"\"Show private storage.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        return private_storage"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_aa5f870d","line":26,"range":{"start_line":26,"start_character":15,"end_line":26,"end_character":30},"updated":"2016-07-26 16:06:03.000000000","message":"Two concerns:\n1) All views should set parent key for whole data that is returned like following:\n\"\"\"\nreturn {\"shares\": [%share1%, %share2%]}\n\"\"\"\n\n2) All keys that are returned should be explicitly set here. Change of DB schema should not influence API response.","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"921ee3904e44532d7e6092e88101a750599fcdb0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    def show(self, private_storage):"},{"line_number":24,"context_line":"        \"\"\"Show private storage.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        return private_storage"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_5fe38f05","line":26,"range":{"start_line":26,"start_character":15,"end_line":26,"end_character":30},"in_reply_to":"dada55a8_aa5f870d","updated":"2016-07-28 17:19:45.000000000","message":"Done.","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"9c7e382fbc77671c590ef27ffc948a45eca5582e","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class ViewBuilder(common.ViewBuilder):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    _collection_name \u003d \u0027driver_private_storage\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def show(self, private_storage):"},{"line_number":24,"context_line":"        \"\"\"Show private storage.\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_977a60b8","line":21,"updated":"2016-08-08 02:17:39.000000000","message":"suggest altering all these \"private storage\" description to \"private data\"","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"29dcb50ac6f726009923ff049185ff6f6e069b7b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class ViewBuilder(common.ViewBuilder):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    _collection_name \u003d \u0027driver_private_storage\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def show(self, private_storage):"},{"line_number":24,"context_line":"        \"\"\"Show private storage.\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_87d93986","line":21,"in_reply_to":"bacf61ea_977a60b8","updated":"2016-08-09 15:17:45.000000000","message":"Done.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"9c7e382fbc77671c590ef27ffc948a45eca5582e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    _collection_name \u003d \u0027driver_private_storage\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def show(self, private_storage):"},{"line_number":24,"context_line":"        \"\"\"Show private storage.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        # private_storage is a dict of key-value pairs of what"},{"line_number":27,"context_line":"        # driver private storage has in db, for example {"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_a232c4ef","line":24,"updated":"2016-08-08 02:17:39.000000000","message":"ditto","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"29dcb50ac6f726009923ff049185ff6f6e069b7b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    _collection_name \u003d \u0027driver_private_storage\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def show(self, private_storage):"},{"line_number":24,"context_line":"        \"\"\"Show private storage.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        # private_storage is a dict of key-value pairs of what"},{"line_number":27,"context_line":"        # driver private storage has in db, for example {"}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_a7971d8f","line":24,"in_reply_to":"bacf61ea_a232c4ef","updated":"2016-08-09 15:17:45.000000000","message":"Done.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"9c7e382fbc77671c590ef27ffc948a45eca5582e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        # private_storage is a dict of key-value pairs of what"},{"line_number":27,"context_line":"        # driver private storage has in db, for example {"},{"line_number":28,"context_line":"        # \u0027k1\u0027: \u0027v1\u0027, \u0027k2\u0027: \u0027v2\u0027}"},{"line_number":29,"context_line":"        return {\u0027driver_private_data\u0027: private_storage}"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_822d0091","line":29,"range":{"start_line":29,"start_character":39,"end_line":29,"end_character":54},"updated":"2016-08-08 02:17:39.000000000","message":"ditto","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"29dcb50ac6f726009923ff049185ff6f6e069b7b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        # private_storage is a dict of key-value pairs of what"},{"line_number":27,"context_line":"        # driver private storage has in db, for example {"},{"line_number":28,"context_line":"        # \u0027k1\u0027: \u0027v1\u0027, \u0027k2\u0027: \u0027v2\u0027}"},{"line_number":29,"context_line":"        return {\u0027driver_private_data\u0027: private_storage}"}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_e791159b","line":29,"range":{"start_line":29,"start_character":39,"end_line":29,"end_character":54},"in_reply_to":"bacf61ea_822d0091","updated":"2016-08-09 15:17:45.000000000","message":"Done.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f6a6953a7455f887f21fa425fcedab986f6de32","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        # private_data is a dict of key-value pairs of what"},{"line_number":27,"context_line":"        # driver private data has in db, for example {"},{"line_number":28,"context_line":"        # \u0027k1\u0027: \u0027v1\u0027, \u0027k2\u0027: \u0027v2\u0027}"},{"line_number":29,"context_line":"        return {\u0027driver_private_data\u0027: private_data}"}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_50e73912","line":29,"range":{"start_line":29,"start_character":16,"end_line":29,"end_character":37},"updated":"2016-08-15 03:23:05.000000000","message":"_collection_name","commit_id":"ef76cad61c083142d70fd5492bdd78cfd10d20e6"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"4aac70e5041c5492456286427c8ba532a0272e0e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        # private_data is a dict of key-value pairs of what"},{"line_number":27,"context_line":"        # driver private data has in db, for example {"},{"line_number":28,"context_line":"        # \u0027k1\u0027: \u0027v1\u0027, \u0027k2\u0027: \u0027v2\u0027}"},{"line_number":29,"context_line":"        return {\u0027driver_private_data\u0027: private_data}"}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_1dbf83fc","line":29,"range":{"start_line":29,"start_character":16,"end_line":29,"end_character":37},"in_reply_to":"3ac371cc_50e73912","updated":"2016-08-15 14:27:08.000000000","message":"I return {\u0027driver_private_data\u0027: ...} because \"All views should set parent key for whole data that is returned\".\n\nWe had previously commented it: https://review.openstack.org/#/c/315346/11/manila/api/views/driver_private_data.py.","commit_id":"ef76cad61c083142d70fd5492bdd78cfd10d20e6"}],"manila/share/drivers_private_data.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"008c17c682856f55bb7a5654db5ef97a60186832","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"private_data_opts \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt("},{"line_number":33,"context_line":"        \u0027drivers_private_data_class\u0027,"},{"line_number":34,"context_line":"        default\u003d\u0027manila.share.drivers_private_data.SqlStorageDriver\u0027,"},{"line_number":35,"context_line":"        help\u003d\u0027The full class name of the Private Data Driver class to use.\u0027),"},{"line_number":36,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad45d7e_343e50da","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":37},"updated":"2016-08-11 06:59:48.000000000","message":"All config option renames should follow \"deprecation\" approach only. It should never be just renamed if was released already.","commit_id":"15ee00cd29fe38ca40a7bce76387016294fed0c7"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"7e90a0a4e80225e879765ce17a36498e7eb7178a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"private_data_opts \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt("},{"line_number":33,"context_line":"        \u0027drivers_private_data_class\u0027,"},{"line_number":34,"context_line":"        default\u003d\u0027manila.share.drivers_private_data.SqlStorageDriver\u0027,"},{"line_number":35,"context_line":"        help\u003d\u0027The full class name of the Private Data Driver class to use.\u0027),"},{"line_number":36,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_bc091534","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":37},"in_reply_to":"3ac371cc_9f5ffd0d","updated":"2016-08-15 14:27:28.000000000","message":"Agreed with the renaming process. I renamed it to unify all the \"driver private data\" vs \"driver private storage\". But since it is already released, I will keep it as the original now. Later I can raise a dedicated renaming patch following the right process.","commit_id":"15ee00cd29fe38ca40a7bce76387016294fed0c7"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"f026b4da93141605646a9e77e9447c9b005ce805","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"private_data_opts \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt("},{"line_number":33,"context_line":"        \u0027drivers_private_data_class\u0027,"},{"line_number":34,"context_line":"        default\u003d\u0027manila.share.drivers_private_data.SqlStorageDriver\u0027,"},{"line_number":35,"context_line":"        help\u003d\u0027The full class name of the Private Data Driver class to use.\u0027),"},{"line_number":36,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_9f5ffd0d","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":37},"in_reply_to":"9ad45d7e_3415b048","updated":"2016-08-15 06:49:55.000000000","message":"@Valeriy, Xing stated the answer in the commit message. \"storage_class\" can be misinterpreted. \n\n+1 for that but we need to keep it as deprecated opt.","commit_id":"15ee00cd29fe38ca40a7bce76387016294fed0c7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b1c1c22b267effbd6e8316709ebb428013e6eae4","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"private_data_opts \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt("},{"line_number":33,"context_line":"        \u0027drivers_private_data_class\u0027,"},{"line_number":34,"context_line":"        default\u003d\u0027manila.share.drivers_private_data.SqlStorageDriver\u0027,"},{"line_number":35,"context_line":"        help\u003d\u0027The full class name of the Private Data Driver class to use.\u0027),"},{"line_number":36,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad45d7e_3415b048","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":37},"in_reply_to":"9ad45d7e_343e50da","updated":"2016-08-11 07:00:15.000000000","message":"Also, why it was renamed at all?","commit_id":"15ee00cd29fe38ca40a7bce76387016294fed0c7"}],"manila/tests/api/v2/test_driver_private_data.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"747d4be2934d1c51552273cbb6f70e24ea6a50ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Alex Meade"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_1fd3fc39","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":27},"updated":"2016-07-04 03:23:42.000000000","message":"?  Copyright 2016 EMC Corporation. ?","commit_id":"124e99e86a9ae0e7cf023198ae390312197b9616"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"88e7dcb346fd5cb9fae03e0be9e1bfb62f4211f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Alex Meade"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_f003bf0b","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":27},"in_reply_to":"1aa78d24_1fd3fc39","updated":"2016-07-04 05:42:58.000000000","message":"Good catch! Thanks!","commit_id":"124e99e86a9ae0e7cf023198ae390312197b9616"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b0a3561abd13e3613fe7b6cf6cc5ec67391ac047","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.flags(rpc_backend\u003d\u0027manila.openstack.common.rpc.impl_fake\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def _get_fake_dpd(self, **values):"},{"line_number":51,"context_line":"        dpd \u003d {"},{"line_number":52,"context_line":"            \u0027entity_id\u0027: \u0027fake\u0027,"},{"line_number":53,"context_line":"            \u0027details\u0027: {"},{"line_number":54,"context_line":"                \u0027fake_key1\u0027: \u0027fake_value1\u0027,"},{"line_number":55,"context_line":"                \u0027fake_key2\u0027: \u0027fake_value2\u0027,"},{"line_number":56,"context_line":"            }"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"        dpd.update(**values)"},{"line_number":59,"context_line":"        expected_dpd \u003d copy.deepcopy(dpd)"},{"line_number":60,"context_line":"        return dpd, expected_dpd"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_7167a351","line":57,"range":{"start_line":51,"start_character":14,"end_line":57,"end_character":9},"updated":"2016-07-15 02:22:01.000000000","message":"This isn\u0027t the response you get from the DB API.. It\u0027s just one key\u003dvalue pair when you specify an entity UUID.","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"52ee72da3752296635802c93ad17e160cbd9353e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.flags(rpc_backend\u003d\u0027manila.openstack.common.rpc.impl_fake\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def _get_fake_dpd(self, **values):"},{"line_number":51,"context_line":"        dpd \u003d {"},{"line_number":52,"context_line":"            \u0027entity_id\u0027: \u0027fake\u0027,"},{"line_number":53,"context_line":"            \u0027details\u0027: {"},{"line_number":54,"context_line":"                \u0027fake_key1\u0027: \u0027fake_value1\u0027,"},{"line_number":55,"context_line":"                \u0027fake_key2\u0027: \u0027fake_value2\u0027,"},{"line_number":56,"context_line":"            }"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"        dpd.update(**values)"},{"line_number":59,"context_line":"        expected_dpd \u003d copy.deepcopy(dpd)"},{"line_number":60,"context_line":"        return dpd, expected_dpd"}],"source_content_type":"text/x-python","patch_set":7,"id":"fad55976_67ee05ee","line":57,"range":{"start_line":51,"start_character":14,"end_line":57,"end_character":9},"in_reply_to":"1aa78d24_7167a351","updated":"2016-07-15 21:02:39.000000000","message":"Done.","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b0a3561abd13e3613fe7b6cf6cc5ec67391ac047","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        self.assertEqual(expected_dpd, res_dict)"},{"line_number":77,"context_line":"        self.mock_policy_check.assert_called_once_with("},{"line_number":78,"context_line":"            req_context, self.resource_name, \u0027index\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_91532f6c","line":78,"range":{"start_line":78,"start_character":51,"end_line":78,"end_character":53},"updated":"2016-07-15 02:22:01.000000000","message":"Negative test cases please?\n\n - Wrong entity ID\n - Incorrect access level\n - Incompatible API version","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"52ee72da3752296635802c93ad17e160cbd9353e","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        self.assertEqual(expected_dpd, res_dict)"},{"line_number":77,"context_line":"        self.mock_policy_check.assert_called_once_with("},{"line_number":78,"context_line":"            req_context, self.resource_name, \u0027index\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fad55976_c7d25134","line":78,"range":{"start_line":78,"start_character":51,"end_line":78,"end_character":53},"in_reply_to":"1aa78d24_91532f6c","updated":"2016-07-15 21:02:39.000000000","message":"Done.","commit_id":"1198b0c2e57d6cfb5eb433c94a09f9acb29a84d9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8bfe9a8192a59e90dd3e6281b8af671e27f2b345","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        }"},{"line_number":43,"context_line":"        self.mock_policy_check \u003d self.mock_object("},{"line_number":44,"context_line":"            policy, \u0027check_policy\u0027, mock.Mock(return_value\u003dTrue))"},{"line_number":45,"context_line":"        self.flags(rpc_backend\u003d\u0027manila.openstack.common.rpc.impl_fake\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @ddt.data({\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.19\u0027, \u0027entity_id\u0027: \u0027fake\u0027},"},{"line_number":48,"context_line":"              {\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.19\u0027, \u0027entity_id\u0027: \u0027wrong\u0027},"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_ca3c7b95","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":71},"updated":"2016-07-26 16:06:03.000000000","message":"Why do you need it?","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"921ee3904e44532d7e6092e88101a750599fcdb0","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        }"},{"line_number":43,"context_line":"        self.mock_policy_check \u003d self.mock_object("},{"line_number":44,"context_line":"            policy, \u0027check_policy\u0027, mock.Mock(return_value\u003dTrue))"},{"line_number":45,"context_line":"        self.flags(rpc_backend\u003d\u0027manila.openstack.common.rpc.impl_fake\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @ddt.data({\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.19\u0027, \u0027entity_id\u0027: \u0027fake\u0027},"},{"line_number":48,"context_line":"              {\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.19\u0027, \u0027entity_id\u0027: \u0027wrong\u0027},"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_dfbdbfd8","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":71},"in_reply_to":"dada55a8_ca3c7b95","updated":"2016-07-28 17:19:45.000000000","message":"Removed.","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"619294513533e604af00b7b217d7b5fb7f873fe2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"@ddt.ddt"},{"line_number":32,"context_line":"class DriverPrivateDataApiTest(test.TestCase):"},{"line_number":33,"context_line":"    \"\"\"Driver Private Data API Test suite.\"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        super(self.__class__, self).setUp()"},{"line_number":37,"context_line":"        self.controller \u003d dpd.DriverPrivateDataController()"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_de843ed4","line":34,"updated":"2016-08-05 06:47:14.000000000","message":"No test for Notfound case.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"29dcb50ac6f726009923ff049185ff6f6e069b7b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"@ddt.ddt"},{"line_number":32,"context_line":"class DriverPrivateDataApiTest(test.TestCase):"},{"line_number":33,"context_line":"    \"\"\"Driver Private Data API Test suite.\"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        super(self.__class__, self).setUp()"},{"line_number":37,"context_line":"        self.controller \u003d dpd.DriverPrivateDataController()"}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_e7f2b5d1","line":34,"in_reply_to":"bacf61ea_de843ed4","updated":"2016-08-09 15:17:45.000000000","message":"Done.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"619294513533e604af00b7b217d7b5fb7f873fe2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            policy, \u0027check_policy\u0027, mock.Mock(return_value\u003dTrue))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @ddt.data({\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.20\u0027, \u0027entity_id\u0027: \u0027correct\u0027},"},{"line_number":47,"context_line":"              {\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.20\u0027, \u0027entity_id\u0027: \u0027wrong\u0027},"},{"line_number":48,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.20\u0027, \u0027entity_id\u0027: \u0027correct\u0027},"},{"line_number":49,"context_line":"              {\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.19\u0027, \u0027entity_id\u0027: \u0027correct\u0027})"},{"line_number":50,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_9e092698","line":47,"range":{"start_line":47,"start_character":14,"end_line":47,"end_character":73},"updated":"2016-08-05 06:47:14.000000000","message":"It is confusing. Better to name it \"existing\" and \"nonexistent\". In that case it becomes much obvious than now.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"29dcb50ac6f726009923ff049185ff6f6e069b7b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            policy, \u0027check_policy\u0027, mock.Mock(return_value\u003dTrue))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @ddt.data({\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.20\u0027, \u0027entity_id\u0027: \u0027correct\u0027},"},{"line_number":47,"context_line":"              {\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.20\u0027, \u0027entity_id\u0027: \u0027wrong\u0027},"},{"line_number":48,"context_line":"              {\u0027role\u0027: \u0027user\u0027, \u0027version\u0027: \u00272.20\u0027, \u0027entity_id\u0027: \u0027correct\u0027},"},{"line_number":49,"context_line":"              {\u0027role\u0027: \u0027admin\u0027, \u0027version\u0027: \u00272.19\u0027, \u0027entity_id\u0027: \u0027correct\u0027})"},{"line_number":50,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_27bb2de7","line":47,"range":{"start_line":47,"start_character":14,"end_line":47,"end_character":73},"in_reply_to":"bacf61ea_9e092698","updated":"2016-08-09 15:17:45.000000000","message":"Done.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"619294513533e604af00b7b217d7b5fb7f873fe2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            \u0027/driver-private-data/%(entity_id)s\u0027 % {"},{"line_number":60,"context_line":"                \u0027entity_id\u0027: using_entity_id},"},{"line_number":61,"context_line":"            version\u003dversion)"},{"line_number":62,"context_line":"        if role \u003d\u003d \u0027admin\u0027:"},{"line_number":63,"context_line":"            req.environ[\u0027manila.context\u0027] \u003d self.ctxt[\u0027admin\u0027]"},{"line_number":64,"context_line":"        else:"},{"line_number":65,"context_line":"            req.environ[\u0027manila.context\u0027] \u003d self.ctxt[\u0027user\u0027]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if float(version) \u003e\u003d 2.20:"},{"line_number":68,"context_line":"            res_dict \u003d self.controller.private_index("}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_feb2e294","line":65,"range":{"start_line":62,"start_character":8,"end_line":65,"end_character":61},"updated":"2016-08-05 06:47:14.000000000","message":"req.environ[\u0027manila.context\u0027] \u003d self.ctxt[role]","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"29dcb50ac6f726009923ff049185ff6f6e069b7b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            \u0027/driver-private-data/%(entity_id)s\u0027 % {"},{"line_number":60,"context_line":"                \u0027entity_id\u0027: using_entity_id},"},{"line_number":61,"context_line":"            version\u003dversion)"},{"line_number":62,"context_line":"        if role \u003d\u003d \u0027admin\u0027:"},{"line_number":63,"context_line":"            req.environ[\u0027manila.context\u0027] \u003d self.ctxt[\u0027admin\u0027]"},{"line_number":64,"context_line":"        else:"},{"line_number":65,"context_line":"            req.environ[\u0027manila.context\u0027] \u003d self.ctxt[\u0027user\u0027]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if float(version) \u003e\u003d 2.20:"},{"line_number":68,"context_line":"            res_dict \u003d self.controller.private_index("}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_a796fd49","line":65,"range":{"start_line":62,"start_character":8,"end_line":65,"end_character":61},"in_reply_to":"bacf61ea_feb2e294","updated":"2016-08-09 15:17:45.000000000","message":"Done.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"619294513533e604af00b7b217d7b5fb7f873fe2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        else:"},{"line_number":65,"context_line":"            req.environ[\u0027manila.context\u0027] \u003d self.ctxt[\u0027user\u0027]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if float(version) \u003e\u003d 2.20:"},{"line_number":68,"context_line":"            res_dict \u003d self.controller.private_index("},{"line_number":69,"context_line":"                req,"},{"line_number":70,"context_line":"                using_entity_id"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_be2b4aea","line":67,"range":{"start_line":67,"start_character":11,"end_line":67,"end_character":34},"updated":"2016-08-05 06:47:14.000000000","message":"It works only while versions have same length.\n\nfloat(2.3) is bigger than float(2.20)\n\nSo, better to use proper version comparison as in other tests. So, you could add checks for any version.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"29dcb50ac6f726009923ff049185ff6f6e069b7b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        else:"},{"line_number":65,"context_line":"            req.environ[\u0027manila.context\u0027] \u003d self.ctxt[\u0027user\u0027]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if float(version) \u003e\u003d 2.20:"},{"line_number":68,"context_line":"            res_dict \u003d self.controller.private_index("},{"line_number":69,"context_line":"                req,"},{"line_number":70,"context_line":"                using_entity_id"}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_a269cbc0","line":67,"range":{"start_line":67,"start_character":11,"end_line":67,"end_character":34},"in_reply_to":"bacf61ea_be2b4aea","updated":"2016-08-09 15:17:45.000000000","message":"Done.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"619294513533e604af00b7b217d7b5fb7f873fe2","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                using_entity_id"},{"line_number":71,"context_line":"            )"},{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            self.assertRaises("},{"line_number":74,"context_line":"                exception.VersionNotFoundForAPIMethod,"},{"line_number":75,"context_line":"                self.controller.private_index,"},{"line_number":76,"context_line":"                req,"},{"line_number":77,"context_line":"                using_entity_id"},{"line_number":78,"context_line":"            )"},{"line_number":79,"context_line":"            return"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if entity_id \u003d\u003d \u0027correct\u0027:"},{"line_number":82,"context_line":"            expected_dpd \u003d {\u0027driver_private_data\u0027: fake_dpd[\u0027details\u0027]}"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_b1fffbff","line":79,"range":{"start_line":73,"start_character":12,"end_line":79,"end_character":18},"updated":"2016-08-05 06:47:14.000000000","message":"In this case policy call not verified, it mans you should remove \"return\" here and current lines 81-85 set in previous part of condition block.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"29dcb50ac6f726009923ff049185ff6f6e069b7b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                using_entity_id"},{"line_number":71,"context_line":"            )"},{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            self.assertRaises("},{"line_number":74,"context_line":"                exception.VersionNotFoundForAPIMethod,"},{"line_number":75,"context_line":"                self.controller.private_index,"},{"line_number":76,"context_line":"                req,"},{"line_number":77,"context_line":"                using_entity_id"},{"line_number":78,"context_line":"            )"},{"line_number":79,"context_line":"            return"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if entity_id \u003d\u003d \u0027correct\u0027:"},{"line_number":82,"context_line":"            expected_dpd \u003d {\u0027driver_private_data\u0027: fake_dpd[\u0027details\u0027]}"}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_422a8f2d","line":79,"range":{"start_line":73,"start_character":12,"end_line":79,"end_character":18},"in_reply_to":"bacf61ea_b1fffbff","updated":"2016-08-09 15:17:45.000000000","message":"Done.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"619294513533e604af00b7b217d7b5fb7f873fe2","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        if entity_id \u003d\u003d \u0027correct\u0027:"},{"line_number":82,"context_line":"            expected_dpd \u003d {\u0027driver_private_data\u0027: fake_dpd[\u0027details\u0027]}"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            expected_dpd \u003d {\u0027driver_private_data\u0027: {}}"},{"line_number":85,"context_line":"        self.assertEqual(expected_dpd, res_dict)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        self.mock_policy_check.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_3e263ace","line":84,"range":{"start_line":84,"start_character":11,"end_line":84,"end_character":54},"updated":"2016-08-05 06:47:14.000000000","message":"Such non-existent case should have raised NotFound error.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"29dcb50ac6f726009923ff049185ff6f6e069b7b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        if entity_id \u003d\u003d \u0027correct\u0027:"},{"line_number":82,"context_line":"            expected_dpd \u003d {\u0027driver_private_data\u0027: fake_dpd[\u0027details\u0027]}"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            expected_dpd \u003d {\u0027driver_private_data\u0027: {}}"},{"line_number":85,"context_line":"        self.assertEqual(expected_dpd, res_dict)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        self.mock_policy_check.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_a221cb4f","line":84,"range":{"start_line":84,"start_character":11,"end_line":84,"end_character":54},"in_reply_to":"bacf61ea_3e263ace","updated":"2016-08-09 15:17:45.000000000","message":"Done.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"}],"manila/tests/db_utils.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8bfe9a8192a59e90dd3e6281b8af671e27f2b345","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"def create_driver_private_data(**kwargs):"},{"line_number":213,"context_line":"    dpd \u003d {"},{"line_number":214,"context_line":"        \u0027entity_id\u0027: \u0027fake\u0027,"},{"line_number":215,"context_line":"        \u0027details\u0027: {"},{"line_number":216,"context_line":"            \u0027fake_key1\u0027: \u0027fake_value1\u0027,"},{"line_number":217,"context_line":"            \u0027fake_key2\u0027: \u0027fake_value2\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_4a1ecb0c","line":214,"range":{"start_line":214,"start_character":21,"end_line":214,"end_character":28},"updated":"2016-07-26 16:06:03.000000000","message":"Better to make this ID unique for each call. Because it uses real DB and if we run more than one test that calls this func we will get errors because of race conditions.","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"921ee3904e44532d7e6092e88101a750599fcdb0","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"def create_driver_private_data(**kwargs):"},{"line_number":213,"context_line":"    dpd \u003d {"},{"line_number":214,"context_line":"        \u0027entity_id\u0027: \u0027fake\u0027,"},{"line_number":215,"context_line":"        \u0027details\u0027: {"},{"line_number":216,"context_line":"            \u0027fake_key1\u0027: \u0027fake_value1\u0027,"},{"line_number":217,"context_line":"            \u0027fake_key2\u0027: \u0027fake_value2\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_07c27733","line":214,"range":{"start_line":214,"start_character":21,"end_line":214,"end_character":28},"in_reply_to":"dada55a8_4a1ecb0c","updated":"2016-07-28 17:19:45.000000000","message":"Done. Also updated the test case to use unique ID.","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"}],"manila_tempest_tests/config.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd79e3a3b7f8f537e6720fe240d5b15947930e8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                help\u003d\"This option used to determine backend driver type, \""},{"line_number":57,"context_line":"                     \"multitenant driver uses share-networks, but \""},{"line_number":58,"context_line":"                     \"single-tenant doesn\u0027t.\"),"},{"line_number":59,"context_line":"    cfg.BoolOpt(\"create_networks_when_multitenancy_enabled\","},{"line_number":60,"context_line":"                default\u003dTrue,"},{"line_number":61,"context_line":"                help\u003d\"This option is used only when other \""},{"line_number":62,"context_line":"                     \"\u0027multitenancy_enabled\u0027 option is set to \u0027True\u0027. \""},{"line_number":63,"context_line":"                     \"If this one is set to True, then tempest will create \""},{"line_number":64,"context_line":"                     \"neutron networks for each new manila share-network \""},{"line_number":65,"context_line":"                     \"it creates. Else it will use manila share-networks with \""},{"line_number":66,"context_line":"                     \"empty values (case of StandAloneNetworkPlugin and \""},{"line_number":67,"context_line":"                     \"NeutronSingleNetworkPlugin).\"),"},{"line_number":68,"context_line":"    cfg.ListOpt(\"enable_protocols\","},{"line_number":69,"context_line":"                default\u003d[\"nfs\", \"cifs\"],"},{"line_number":70,"context_line":"                help\u003d\"First value of list is protocol by default, \""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_869f62b3","side":"PARENT","line":67,"range":{"start_line":59,"start_character":4,"end_line":67,"end_character":53},"updated":"2016-07-29 05:55:03.000000000","message":"?","commit_id":"20adb836c3d7377b2c368f79fcc0717060363874"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"ddbf142367c55f4eb608d49873f355e0aa6d140c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                help\u003d\"This option used to determine backend driver type, \""},{"line_number":57,"context_line":"                     \"multitenant driver uses share-networks, but \""},{"line_number":58,"context_line":"                     \"single-tenant doesn\u0027t.\"),"},{"line_number":59,"context_line":"    cfg.BoolOpt(\"create_networks_when_multitenancy_enabled\","},{"line_number":60,"context_line":"                default\u003dTrue,"},{"line_number":61,"context_line":"                help\u003d\"This option is used only when other \""},{"line_number":62,"context_line":"                     \"\u0027multitenancy_enabled\u0027 option is set to \u0027True\u0027. \""},{"line_number":63,"context_line":"                     \"If this one is set to True, then tempest will create \""},{"line_number":64,"context_line":"                     \"neutron networks for each new manila share-network \""},{"line_number":65,"context_line":"                     \"it creates. Else it will use manila share-networks with \""},{"line_number":66,"context_line":"                     \"empty values (case of StandAloneNetworkPlugin and \""},{"line_number":67,"context_line":"                     \"NeutronSingleNetworkPlugin).\"),"},{"line_number":68,"context_line":"    cfg.ListOpt(\"enable_protocols\","},{"line_number":69,"context_line":"                default\u003d[\"nfs\", \"cifs\"],"},{"line_number":70,"context_line":"                help\u003d\"First value of list is protocol by default, \""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_626213af","side":"PARENT","line":67,"range":{"start_line":59,"start_character":4,"end_line":67,"end_character":53},"in_reply_to":"bacf61ea_869f62b3","updated":"2016-08-09 15:18:44.000000000","message":"Good catch! It looks like I didn\u0027t rebase right ... Thanks!","commit_id":"20adb836c3d7377b2c368f79fcc0717060363874"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"9c7e382fbc77671c590ef27ffc948a45eca5582e","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                     \"careful enabling this opt.\"),"},{"line_number":184,"context_line":"    cfg.BoolOpt(\"run_driver_private_data_tests\","},{"line_number":185,"context_line":"                default\u003dFalse,"},{"line_number":186,"context_line":"                help\u003d\"Defines whether to run driver private data tests\"),"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    cfg.StrOpt(\"image_with_share_tools\","},{"line_number":189,"context_line":"               default\u003d\"manila-service-image\","}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_f7191c89","line":186,"range":{"start_line":186,"start_character":70,"end_line":186,"end_character":71},"updated":"2016-08-08 02:17:39.000000000","message":"please add tail period.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"29dcb50ac6f726009923ff049185ff6f6e069b7b","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                     \"careful enabling this opt.\"),"},{"line_number":184,"context_line":"    cfg.BoolOpt(\"run_driver_private_data_tests\","},{"line_number":185,"context_line":"                default\u003dFalse,"},{"line_number":186,"context_line":"                help\u003d\"Defines whether to run driver private data tests\"),"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    cfg.StrOpt(\"image_with_share_tools\","},{"line_number":189,"context_line":"               default\u003d\"manila-service-image\","}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_3d721aae","line":186,"range":{"start_line":186,"start_character":70,"end_line":186,"end_character":71},"in_reply_to":"bacf61ea_f7191c89","updated":"2016-08-09 15:17:45.000000000","message":"Done.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f4b10ee588d9d7d8ee1c448da5e48c15304571e9","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                     \"or not. These tests may leave orphaned resources, so be \""},{"line_number":183,"context_line":"                     \"careful enabling this opt.\"),"},{"line_number":184,"context_line":"    cfg.BoolOpt(\"run_driver_private_data_tests\","},{"line_number":185,"context_line":"                default\u003dFalse,"},{"line_number":186,"context_line":"                help\u003d\"Defines whether to run driver private data tests.\"),"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    cfg.StrOpt(\"image_with_share_tools\","}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad45d7e_f38504cf","line":185,"range":{"start_line":185,"start_character":24,"end_line":185,"end_character":29},"updated":"2016-08-10 19:26:07.000000000","message":"Why can\u0027t this default to true?  These tests should always work.","commit_id":"ef76cad61c083142d70fd5492bdd78cfd10d20e6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"24b8d7294ae6c47a650ce33f8b47c937deb9a7ff","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                     \"or not. These tests may leave orphaned resources, so be \""},{"line_number":183,"context_line":"                     \"careful enabling this opt.\"),"},{"line_number":184,"context_line":"    cfg.BoolOpt(\"run_driver_private_data_tests\","},{"line_number":185,"context_line":"                default\u003dFalse,"},{"line_number":186,"context_line":"                help\u003d\"Defines whether to run driver private data tests.\"),"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    cfg.StrOpt(\"image_with_share_tools\","}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad45d7e_df60add1","line":185,"range":{"start_line":185,"start_character":24,"end_line":185,"end_character":29},"in_reply_to":"9ad45d7e_395da979","updated":"2016-08-11 07:05:23.000000000","message":"If Clinton asks such questions, then I am already afraid to leave project for whole 2 weeks... Sorry.","commit_id":"ef76cad61c083142d70fd5492bdd78cfd10d20e6"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f96e59956bd15eca4c48bde93ab9f99da17e412c","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                     \"or not. These tests may leave orphaned resources, so be \""},{"line_number":183,"context_line":"                     \"careful enabling this opt.\"),"},{"line_number":184,"context_line":"    cfg.BoolOpt(\"run_driver_private_data_tests\","},{"line_number":185,"context_line":"                default\u003dFalse,"},{"line_number":186,"context_line":"                help\u003d\"Defines whether to run driver private data tests.\"),"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    cfg.StrOpt(\"image_with_share_tools\","}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad45d7e_89437e12","line":185,"range":{"start_line":185,"start_character":24,"end_line":185,"end_character":29},"in_reply_to":"9ad45d7e_ae6c8808","updated":"2016-08-11 17:34:27.000000000","message":"But if the tests can only succeed if a driver *must* write private data for an object (i.e. a new share), then these tests and this feature would have very limited application.  To me it makes more sense that this feature would be lightly validated in the upstream gate and more heavily used in downstream testing where driver vendors can make assumptions about how their drivers should behave.  That was the rationale for my initial comment.","commit_id":"ef76cad61c083142d70fd5492bdd78cfd10d20e6"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2a6e87a09b0bbd1ba9177b007387c89099267a63","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                     \"or not. These tests may leave orphaned resources, so be \""},{"line_number":183,"context_line":"                     \"careful enabling this opt.\"),"},{"line_number":184,"context_line":"    cfg.BoolOpt(\"run_driver_private_data_tests\","},{"line_number":185,"context_line":"                default\u003dFalse,"},{"line_number":186,"context_line":"                help\u003d\"Defines whether to run driver private data tests.\"),"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    cfg.StrOpt(\"image_with_share_tools\","}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad45d7e_ae6c8808","line":185,"range":{"start_line":185,"start_character":24,"end_line":185,"end_character":29},"in_reply_to":"9ad45d7e_df60add1","updated":"2016-08-11 17:26:55.000000000","message":"Valeriy, you should always be afraid to leave.\n\nIf the tempest test can validate that the API works as expected (valid data or 404), regardless of whether the driver actually stored something for a given UUID, then I don\u0027t see why this can\u0027t be enabled always.","commit_id":"ef76cad61c083142d70fd5492bdd78cfd10d20e6"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"c851eb85032b86da003f5b0cda6c7152e270ed8c","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                     \"or not. These tests may leave orphaned resources, so be \""},{"line_number":183,"context_line":"                     \"careful enabling this opt.\"),"},{"line_number":184,"context_line":"    cfg.BoolOpt(\"run_driver_private_data_tests\","},{"line_number":185,"context_line":"                default\u003dFalse,"},{"line_number":186,"context_line":"                help\u003d\"Defines whether to run driver private data tests.\"),"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    cfg.StrOpt(\"image_with_share_tools\","}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad45d7e_395da979","line":185,"range":{"start_line":185,"start_character":24,"end_line":185,"end_character":29},"in_reply_to":"9ad45d7e_f38504cf","updated":"2016-08-11 06:24:55.000000000","message":"I agree with you. I will change it in the next patch. \n\nPreviously I set it to False because all the other options also default to False. I wonder is there a general rule that about that? Thanks!","commit_id":"ef76cad61c083142d70fd5492bdd78cfd10d20e6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0b8b5d6fefe4b84a0d4ba3786409f72cb290bff7","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                     \"or not. These tests may leave orphaned resources, so be \""},{"line_number":183,"context_line":"                     \"careful enabling this opt.\"),"},{"line_number":184,"context_line":"    cfg.BoolOpt(\"run_driver_private_data_tests\","},{"line_number":185,"context_line":"                default\u003dTrue,"},{"line_number":186,"context_line":"                help\u003d\"Defines whether to run driver private data tests.\"),"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    cfg.StrOpt(\"image_with_share_tools\","}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad45d7e_9479fcca","line":185,"range":{"start_line":185,"start_character":24,"end_line":185,"end_character":28},"updated":"2016-08-11 06:58:04.000000000","message":"It should be only False by default as it is optional feature and will fail on lots of backends. Also, need to add new config option described in other file [1].\n\n[1] manila_tempest_tests/tests/api/admin/test_driver_private_data.py","commit_id":"15ee00cd29fe38ca40a7bce76387016294fed0c7"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"7e90a0a4e80225e879765ce17a36498e7eb7178a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                     \"or not. These tests may leave orphaned resources, so be \""},{"line_number":183,"context_line":"                     \"careful enabling this opt.\"),"},{"line_number":184,"context_line":"    cfg.BoolOpt(\"run_driver_private_data_tests\","},{"line_number":185,"context_line":"                default\u003dTrue,"},{"line_number":186,"context_line":"                help\u003d\"Defines whether to run driver private data tests.\"),"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    cfg.StrOpt(\"image_with_share_tools\","}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_fc90adee","line":185,"range":{"start_line":185,"start_character":24,"end_line":185,"end_character":28},"in_reply_to":"3ac371cc_b0082d93","updated":"2016-08-15 14:27:28.000000000","message":"Agree with you. Done.","commit_id":"15ee00cd29fe38ca40a7bce76387016294fed0c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8659bbde21b9597a72e31e649122aabfb6e53a62","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                     \"or not. These tests may leave orphaned resources, so be \""},{"line_number":183,"context_line":"                     \"careful enabling this opt.\"),"},{"line_number":184,"context_line":"    cfg.BoolOpt(\"run_driver_private_data_tests\","},{"line_number":185,"context_line":"                default\u003dTrue,"},{"line_number":186,"context_line":"                help\u003d\"Defines whether to run driver private data tests.\"),"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    cfg.StrOpt(\"image_with_share_tools\","}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_b0082d93","line":185,"range":{"start_line":185,"start_character":24,"end_line":185,"end_character":28},"in_reply_to":"9ad45d7e_9479fcca","updated":"2016-08-15 03:22:38.000000000","message":"+1","commit_id":"15ee00cd29fe38ca40a7bce76387016294fed0c7"}],"manila_tempest_tests/tests/api/admin/test_driver_private_data.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8bfe9a8192a59e90dd3e6281b8af671e27f2b345","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from manila_tempest_tests.tests.api import base"},{"line_number":19,"context_line":"from manila.tests import db_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_cabbdbc2","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":33},"updated":"2016-07-26 16:06:03.000000000","message":"Manila code base should not be imported in tempest plugin code base and vice versa. Never.","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"efbcb96d7a109c35db4fa84c896503ae9caaee56","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from manila.tests import db_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class DriverPrivateDataAdminTest(base.BaseSharesAdminTest):"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_65fec439","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":0},"updated":"2016-07-28 16:10:22.000000000","message":"Test cases \"request all of these APIs with member user\" are absent.","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8bfe9a8192a59e90dd3e6281b8af671e27f2b345","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class DriverPrivateDataAdminTest(base.BaseSharesAdminTest):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @classmethod"},{"line_number":27,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_4a3d2b2a","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":59},"updated":"2016-07-26 16:06:03.000000000","message":"So, since your both tests depend on manila DB code, then we can say this module should be rewritten a little bit more than completely.\n\nHere what should be done:\n\n1) Goutham properly said below, you should add new config option that enables/disables DPD tests.\n2) This test class should run only when option (1) is enabled and required microversion is supported.\n3) Running these tests we assume DPD is used by share backend. So, in tests, we should verify following things:\n\n3a) API returns some data. These data satisfy expectations such as \"length\" of keys and values, they are all strings...\n3b) After share deletion we should verify that API returns 404 for DPD.\n4) We already have \"driver\" for such things - dummy driver, it already writes some DPD [1]. So, you enable such tests for dummy driver in \"contrib/ci/post_test_hook.sh\" file.\n\n[1] https://github.com/openstack/manila/blob/7145891e/manila/tests/share/drivers/dummy.py#L91","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"921ee3904e44532d7e6092e88101a750599fcdb0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class DriverPrivateDataAdminTest(base.BaseSharesAdminTest):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @classmethod"},{"line_number":27,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_50ded93f","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":59},"in_reply_to":"dada55a8_4a3d2b2a","updated":"2016-07-28 17:19:45.000000000","message":"Mostly done ... I try to use generic.py driver, because it does private_storage.update(...) when create_share. Hope everything works fine.","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8bfe9a8192a59e90dd3e6281b8af671e27f2b345","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class DriverPrivateDataAdminTest(base.BaseSharesAdminTest):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @classmethod"},{"line_number":27,"context_line":"    def resource_setup(cls):"},{"line_number":28,"context_line":"        super(DriverPrivateDataAdminTest, cls).resource_setup()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_show(self):"},{"line_number":31,"context_line":"        fake_dpd \u003d db_utils.create_driver_private_data("}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_8aeba3db","line":28,"range":{"start_line":26,"start_character":4,"end_line":28,"end_character":63},"updated":"2016-07-26 16:06:03.000000000","message":"Redundant.","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"921ee3904e44532d7e6092e88101a750599fcdb0","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class DriverPrivateDataAdminTest(base.BaseSharesAdminTest):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @classmethod"},{"line_number":27,"context_line":"    def resource_setup(cls):"},{"line_number":28,"context_line":"        super(DriverPrivateDataAdminTest, cls).resource_setup()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_show(self):"},{"line_number":31,"context_line":"        fake_dpd \u003d db_utils.create_driver_private_data("}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_ba47364a","line":28,"range":{"start_line":26,"start_character":4,"end_line":28,"end_character":63},"in_reply_to":"dada55a8_8aeba3db","updated":"2016-07-28 17:19:45.000000000","message":"Done.","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8bfe9a8192a59e90dd3e6281b8af671e27f2b345","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def resource_setup(cls):"},{"line_number":28,"context_line":"        super(DriverPrivateDataAdminTest, cls).resource_setup()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_show(self):"},{"line_number":31,"context_line":"        fake_dpd \u003d db_utils.create_driver_private_data("},{"line_number":32,"context_line":"            entity_id\u003d\u0027fake\u0027)"},{"line_number":33,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(\u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_9ed5a844","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":24},"updated":"2016-07-26 16:06:03.000000000","message":"Each test should have tags see other existing tests.","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"921ee3904e44532d7e6092e88101a750599fcdb0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def resource_setup(cls):"},{"line_number":28,"context_line":"        super(DriverPrivateDataAdminTest, cls).resource_setup()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_show(self):"},{"line_number":31,"context_line":"        fake_dpd \u003d db_utils.create_driver_private_data("},{"line_number":32,"context_line":"            entity_id\u003d\u0027fake\u0027)"},{"line_number":33,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(\u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_fa77ee9c","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":24},"in_reply_to":"dada55a8_9ed5a844","updated":"2016-07-28 17:19:45.000000000","message":"Done.","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"821859dfb0d59a713d1dfb9801b9f2533f3120dd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        super(DriverPrivateDataAdminTest, cls).resource_setup()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_show(self):"},{"line_number":31,"context_line":"        fake_dpd \u003d db_utils.create_driver_private_data("},{"line_number":32,"context_line":"            entity_id\u003d\u0027fake\u0027)"},{"line_number":33,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(\u0027fake\u0027)"},{"line_number":34,"context_line":"        self.assertEqual(fake_dpd[\u0027details\u0027], dpd_resp)"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_76ef5087","line":31,"updated":"2016-07-26 11:17:33.000000000","message":"I know this looks to be wrong way to populate test data. The api to create/delete driver_private_data records only exist at db api layer. So what is the proper way to populate test data in tempest tests? Thanks!","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"dbcde0af9d5644a82364dd06149511b2a8431049","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        super(DriverPrivateDataAdminTest, cls).resource_setup()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_show(self):"},{"line_number":31,"context_line":"        fake_dpd \u003d db_utils.create_driver_private_data("},{"line_number":32,"context_line":"            entity_id\u003d\u0027fake\u0027)"},{"line_number":33,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(\u0027fake\u0027)"},{"line_number":34,"context_line":"        self.assertEqual(fake_dpd[\u0027details\u0027], dpd_resp)"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_985f850e","line":31,"in_reply_to":"dada55a8_76ef5087","updated":"2016-07-26 14:06:45.000000000","message":"Accela,\n\nWhen you create a share or snapshot using the generic driver, the uuid of the cinder resource (volume or volume snapshot) will be added to the driver private storage data by the driver.  So you can verify that.  Don\u0027t write to DB directly in the tempest test.\n\nHowever, since every driver uses private storage data differently, you\u0027ll only be able to verify it for the generic driver.","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a06340e193f73c2ee20f721738a6396a24f0a76a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        super(DriverPrivateDataAdminTest, cls).resource_setup()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_show(self):"},{"line_number":31,"context_line":"        fake_dpd \u003d db_utils.create_driver_private_data("},{"line_number":32,"context_line":"            entity_id\u003d\u0027fake\u0027)"},{"line_number":33,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(\u0027fake\u0027)"},{"line_number":34,"context_line":"        self.assertEqual(fake_dpd[\u0027details\u0027], dpd_resp)"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_9869458f","line":31,"in_reply_to":"dada55a8_985f850e","updated":"2016-07-26 14:09:23.000000000","message":"I suggest adding a flag to enable/disable these tests.. Verify the schema of the response.. the top level key, for example.. \n\nDo not verify the content.. Adding the clients and performing these basic tests would help expand this in the future if ever all drivers implementing a feature will use driver private data consistently.","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"921ee3904e44532d7e6092e88101a750599fcdb0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        super(DriverPrivateDataAdminTest, cls).resource_setup()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_show(self):"},{"line_number":31,"context_line":"        fake_dpd \u003d db_utils.create_driver_private_data("},{"line_number":32,"context_line":"            entity_id\u003d\u0027fake\u0027)"},{"line_number":33,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(\u0027fake\u0027)"},{"line_number":34,"context_line":"        self.assertEqual(fake_dpd[\u0027details\u0027], dpd_resp)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_506ed901","line":31,"in_reply_to":"dada55a8_9869458f","updated":"2016-07-28 17:19:45.000000000","message":"Mostly done. Hope it\u0027s working fine.","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8bfe9a8192a59e90dd3e6281b8af671e27f2b345","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(\u0027fake\u0027)"},{"line_number":34,"context_line":"        self.assertEqual(fake_dpd[\u0027details\u0027], dpd_resp)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_show_non_exist(self):"},{"line_number":37,"context_line":"        db_utils.create_driver_private_data(entity_id\u003d\u0027fake\u0027)"},{"line_number":38,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(\u0027wrong\u0027)"},{"line_number":39,"context_line":"        self.assertEqual({}, dpd_resp)"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_1ec25885","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":34},"updated":"2016-07-26 16:06:03.000000000","message":"same here.","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"921ee3904e44532d7e6092e88101a750599fcdb0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(\u0027fake\u0027)"},{"line_number":34,"context_line":"        self.assertEqual(fake_dpd[\u0027details\u0027], dpd_resp)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_show_non_exist(self):"},{"line_number":37,"context_line":"        db_utils.create_driver_private_data(entity_id\u003d\u0027fake\u0027)"},{"line_number":38,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(\u0027wrong\u0027)"},{"line_number":39,"context_line":"        self.assertEqual({}, dpd_resp)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_ba5e1610","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":34},"in_reply_to":"dada55a8_1ec25885","updated":"2016-07-28 17:19:45.000000000","message":"Done.","commit_id":"d8df8e63fb9eb327346d1bac765508c3e80492ab"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e38c16d9a5e64703715b0cee84c75c883b1b8a58","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(share[\u0027id\u0027])"},{"line_number":35,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":36,"context_line":"        self.assertGreaterEqual(len(dpd_resp[\u0027driver_private_data\u0027]), 1)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":39,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\u0027id\u0027])"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_6ca2f34c","line":37,"updated":"2016-08-01 09:54:43.000000000","message":"Need to add check for length of key/value and their type that should be string.","commit_id":"f09e345a37e2471857a01ef9c2cb984db2ee56a4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"2083d09043f81599450c847b83d3a3b97b4c4195","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(share[\u0027id\u0027])"},{"line_number":35,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":36,"context_line":"        self.assertGreaterEqual(len(dpd_resp[\u0027driver_private_data\u0027]), 1)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":39,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\u0027id\u0027])"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_286ba7ba","line":37,"in_reply_to":"bacf61ea_6ca2f34c","updated":"2016-08-05 02:42:34.000000000","message":"Done.","commit_id":"f09e345a37e2471857a01ef9c2cb984db2ee56a4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e38c16d9a5e64703715b0cee84c75c883b1b8a58","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":39,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\u0027id\u0027])"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(share[\u0027id\u0027])"},{"line_number":42,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":43,"context_line":"        self.assertEqual({\u0027driver_private_data\u0027: {}}, dpd_resp)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":46,"context_line":"    def test_show_non_exist(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_4cf0cf67","line":43,"range":{"start_line":41,"start_character":8,"end_line":43,"end_character":63},"updated":"2016-08-01 09:54:43.000000000","message":"It should raise NotFound error because share was removed.","commit_id":"f09e345a37e2471857a01ef9c2cb984db2ee56a4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"2083d09043f81599450c847b83d3a3b97b4c4195","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":39,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\u0027id\u0027])"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(share[\u0027id\u0027])"},{"line_number":42,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":43,"context_line":"        self.assertEqual({\u0027driver_private_data\u0027: {}}, dpd_resp)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":46,"context_line":"    def test_show_non_exist(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_e8d06f55","line":43,"range":{"start_line":41,"start_character":8,"end_line":43,"end_character":63},"in_reply_to":"bacf61ea_4cf0cf67","updated":"2016-08-05 02:42:34.000000000","message":"Current driver private data API behavior is to return {} when there is no key associated to that entity. So there is no exception here.\n\nSince a entity can be associated with a flex number of keys, returning {} makes it behaves \"smoothly\" for different number of keys.\n\nDo you think we need an overhaul to change that and return 404 instead? Thanks!","commit_id":"f09e345a37e2471857a01ef9c2cb984db2ee56a4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4cac39e23bb25471df3a0bc97a297fb547343b2c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":39,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\u0027id\u0027])"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(share[\u0027id\u0027])"},{"line_number":42,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":43,"context_line":"        self.assertEqual({\u0027driver_private_data\u0027: {}}, dpd_resp)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":46,"context_line":"    def test_show_non_exist(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_1e709671","line":43,"range":{"start_line":41,"start_character":8,"end_line":43,"end_character":63},"in_reply_to":"bacf61ea_e8d06f55","updated":"2016-08-05 06:16:53.000000000","message":"By this comment I am saing exactly that API design is wrong and tests verify wrong approach. Exactly this commit implements API you are refering to.","commit_id":"f09e345a37e2471857a01ef9c2cb984db2ee56a4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e38c16d9a5e64703715b0cee84c75c883b1b8a58","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":46,"context_line":"    def test_show_non_exist(self):"},{"line_number":47,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(\u0027wrong\u0027)"},{"line_number":48,"context_line":"        self.assertEqual({\u0027driver_private_data\u0027: {}}, dpd_resp)"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_6cb95379","line":48,"range":{"start_line":47,"start_character":8,"end_line":48,"end_character":63},"updated":"2016-08-01 09:54:43.000000000","message":"Same here.","commit_id":"f09e345a37e2471857a01ef9c2cb984db2ee56a4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"619294513533e604af00b7b217d7b5fb7f873fe2","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(share[\u0027id\u0027])"},{"line_number":35,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":36,"context_line":"        self.assertEqual(1, len(dpd_resp[\u0027driver_private_data\u0027]))"},{"line_number":37,"context_line":"        for k, v in dpd_resp[\u0027driver_private_data\u0027]:"},{"line_number":38,"context_line":"            self.assertIsInstance(k, str)"},{"line_number":39,"context_line":"            self.assertIsInstance(v, str)"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_9ebf66cf","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":65},"updated":"2016-08-05 06:47:14.000000000","message":"Such assert will cause lots of errors, and they will be correct errors. Why do you assert that it has only one pair in dict? Moreover, \"dpd_resp[\u0027driver_private_data\u0027]\" will return KeyError exception. Parent key \u0027driver_private_data\u0027 will be filtered out on client side. The fact that we do not see such error means you do not run these tests in CI at all.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"29dcb50ac6f726009923ff049185ff6f6e069b7b","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(share[\u0027id\u0027])"},{"line_number":35,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":36,"context_line":"        self.assertEqual(1, len(dpd_resp[\u0027driver_private_data\u0027]))"},{"line_number":37,"context_line":"        for k, v in dpd_resp[\u0027driver_private_data\u0027]:"},{"line_number":38,"context_line":"            self.assertIsInstance(k, str)"},{"line_number":39,"context_line":"            self.assertIsInstance(v, str)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_9d4066a7","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":65},"in_reply_to":"9ad45d7e_fbdc5748","updated":"2016-08-09 15:17:45.000000000","message":"Done.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"6287e6bc8206cdccc78e5dac95522503e7798bb4","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(share[\u0027id\u0027])"},{"line_number":35,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":36,"context_line":"        self.assertEqual(1, len(dpd_resp[\u0027driver_private_data\u0027]))"},{"line_number":37,"context_line":"        for k, v in dpd_resp[\u0027driver_private_data\u0027]:"},{"line_number":38,"context_line":"            self.assertIsInstance(k, str)"},{"line_number":39,"context_line":"            self.assertIsInstance(v, str)"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_c351ba0f","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":65},"in_reply_to":"bacf61ea_9ebf66cf","updated":"2016-08-08 05:16:04.000000000","message":"In patch 13 you commented \"Need to add check for length of key/value\". So I wrote assertEqual(1, ..) It\u0027s must be misunderstanding. Would you mind clarify what do you mean by that \"check for length\"? Thanks!\n\nMore importantly, I need a way to run my added tempest test case locally. https://wiki.openstack.org/wiki/Manila/docs/HOWTO_use_tempest_with_manila#How_to_run_tests doesn\u0027t work. I digged jenkins CI log, but my local \u0027tox -eall-plugin\u0027 says unknown \u0027all-plugins\u0027. Would you please give me some hint? That would be very helpful. Thanks!","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95555c79312edd4602d467ae10fbb257acb67184","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(share[\u0027id\u0027])"},{"line_number":35,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":36,"context_line":"        self.assertEqual(1, len(dpd_resp[\u0027driver_private_data\u0027]))"},{"line_number":37,"context_line":"        for k, v in dpd_resp[\u0027driver_private_data\u0027]:"},{"line_number":38,"context_line":"            self.assertIsInstance(k, str)"},{"line_number":39,"context_line":"            self.assertIsInstance(v, str)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_fbdc5748","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":65},"in_reply_to":"bacf61ea_c351ba0f","updated":"2016-08-08 10:05:23.000000000","message":"\"Need to add check for length of key/value\" means verify length of each key and length of each value:\n\n\"\"\"\nfor k, v in dpd_resp.items():\n    self.assertTrue(0 \u003c len(k) \u003c 256) # [1]\n    self.assertTrue(0 \u003c len(v) \u003c 1024) # [2]\n\n\"\"\"\n\n[1] https://github.com/openstack/manila/blob/cd078020/manila/db/sqlalchemy/models.py#L878\n[2] https://github.com/openstack/manila/blob/cd078020/manila/db/sqlalchemy/models.py#L879","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"619294513533e604af00b7b217d7b5fb7f873fe2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":36,"context_line":"        self.assertEqual(1, len(dpd_resp[\u0027driver_private_data\u0027]))"},{"line_number":37,"context_line":"        for k, v in dpd_resp[\u0027driver_private_data\u0027]:"},{"line_number":38,"context_line":"            self.assertIsInstance(k, str)"},{"line_number":39,"context_line":"            self.assertIsInstance(v, str)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_5ec20e54","line":38,"updated":"2016-08-05 06:47:14.000000000","message":"ALso, check for length of k an v is lost.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"29dcb50ac6f726009923ff049185ff6f6e069b7b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":36,"context_line":"        self.assertEqual(1, len(dpd_resp[\u0027driver_private_data\u0027]))"},{"line_number":37,"context_line":"        for k, v in dpd_resp[\u0027driver_private_data\u0027]:"},{"line_number":38,"context_line":"            self.assertIsInstance(k, str)"},{"line_number":39,"context_line":"            self.assertIsInstance(v, str)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_dd4adec4","line":38,"in_reply_to":"bacf61ea_5ec20e54","updated":"2016-08-09 15:17:45.000000000","message":"Done.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"619294513533e604af00b7b217d7b5fb7f873fe2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":36,"context_line":"        self.assertEqual(1, len(dpd_resp[\u0027driver_private_data\u0027]))"},{"line_number":37,"context_line":"        for k, v in dpd_resp[\u0027driver_private_data\u0027]:"},{"line_number":38,"context_line":"            self.assertIsInstance(k, str)"},{"line_number":39,"context_line":"            self.assertIsInstance(v, str)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":42,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_1ecc1688","line":39,"range":{"start_line":38,"start_character":12,"end_line":39,"end_character":41},"updated":"2016-08-05 06:47:14.000000000","message":"Please, use py2/3 compatible check.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"29dcb50ac6f726009923ff049185ff6f6e069b7b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":36,"context_line":"        self.assertEqual(1, len(dpd_resp[\u0027driver_private_data\u0027]))"},{"line_number":37,"context_line":"        for k, v in dpd_resp[\u0027driver_private_data\u0027]:"},{"line_number":38,"context_line":"            self.assertIsInstance(k, str)"},{"line_number":39,"context_line":"            self.assertIsInstance(v, str)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":42,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_216e7896","line":39,"range":{"start_line":38,"start_character":12,"end_line":39,"end_character":41},"in_reply_to":"bacf61ea_1ecc1688","updated":"2016-08-09 15:17:45.000000000","message":"Done.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"619294513533e604af00b7b217d7b5fb7f873fe2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":42,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\u0027id\u0027])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(share[\u0027id\u0027])"},{"line_number":45,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":46,"context_line":"        self.assertEqual({\u0027driver_private_data\u0027: {}}, dpd_resp)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":49,"context_line":"    def test_show_non_exist(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_fe7e6219","line":46,"range":{"start_line":44,"start_character":8,"end_line":46,"end_character":63},"updated":"2016-08-05 06:47:14.000000000","message":"Should return 404.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"29dcb50ac6f726009923ff049185ff6f6e069b7b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":42,"context_line":"        self.shares_v2_client.wait_for_resource_deletion(share_id\u003dshare[\u0027id\u0027])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(share[\u0027id\u0027])"},{"line_number":45,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":46,"context_line":"        self.assertEqual({\u0027driver_private_data\u0027: {}}, dpd_resp)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":49,"context_line":"    def test_show_non_exist(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_a161c8aa","line":46,"range":{"start_line":44,"start_character":8,"end_line":46,"end_character":63},"in_reply_to":"bacf61ea_fe7e6219","updated":"2016-08-09 15:17:45.000000000","message":"Done.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"619294513533e604af00b7b217d7b5fb7f873fe2","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":49,"context_line":"    def test_show_non_exist(self):"},{"line_number":50,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(\u0027wrong\u0027)"},{"line_number":51,"context_line":"        self.assertEqual({\u0027driver_private_data\u0027: {}}, dpd_resp)"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_9e8da633","line":51,"range":{"start_line":50,"start_character":8,"end_line":51,"end_character":63},"updated":"2016-08-05 06:47:14.000000000","message":"Should return 404.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"29dcb50ac6f726009923ff049185ff6f6e069b7b","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":49,"context_line":"    def test_show_non_exist(self):"},{"line_number":50,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(\u0027wrong\u0027)"},{"line_number":51,"context_line":"        self.assertEqual({\u0027driver_private_data\u0027: {}}, dpd_resp)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_0159b4fe","line":51,"range":{"start_line":50,"start_character":8,"end_line":51,"end_character":63},"in_reply_to":"bacf61ea_9e8da633","updated":"2016-08-09 15:17:45.000000000","message":"Done.","commit_id":"04404a2a2e68ff5ede3510469f990591c6c8cff4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0b8b5d6fefe4b84a0d4ba3786409f72cb290bff7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def test_show(self):"},{"line_number":34,"context_line":"        share \u003d self.create_share()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(share[\u0027id\u0027])"},{"line_number":37,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":38,"context_line":"        self.assertGreaterEqual(len(dpd_resp), 1)"},{"line_number":39,"context_line":"        for k, v in dpd_resp.items():"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad45d7e_948bbcc2","line":36,"range":{"start_line":36,"start_character":66,"end_line":36,"end_character":77},"updated":"2016-08-11 06:58:04.000000000","message":"I guess we should have separate config option that will allow us to chose type of entity that has such data. For example, dummy driver writes data based on share_instance_id, not share_id. Same about ZFSonLinux driver. But, ZFSonLinux driver writes data for snapshots based on snapshot_id, not snapshot_instance_id. So, these functional tests should be reworked.","commit_id":"15ee00cd29fe38ca40a7bce76387016294fed0c7"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"7e90a0a4e80225e879765ce17a36498e7eb7178a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def test_show(self):"},{"line_number":34,"context_line":"        share \u003d self.create_share()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(share[\u0027id\u0027])"},{"line_number":37,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":38,"context_line":"        self.assertGreaterEqual(len(dpd_resp), 1)"},{"line_number":39,"context_line":"        for k, v in dpd_resp.items():"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_cfb6d23c","line":36,"range":{"start_line":36,"start_character":66,"end_line":36,"end_character":77},"in_reply_to":"3ac371cc_7046b5c0","updated":"2016-08-15 14:27:28.000000000","message":"I try to follow Valeriy\u0027s suggestions. However, as I opened dummy.py, it seems dummy driver is also writing share[\u0027id\u0027] when create_share: https://github.com/openstack/manila/blob/master/manila/tests/share/drivers/dummy.py#L90.\n\nZFSonLinux driver looks the same, also writing to share[\u0027id\u0027]: https://github.com/openstack/manila/blob/master/manila/share/drivers/zfsonlinux/driver.py#L432.\n\nI\u0027m confused here. What is the share_instance_id here and how should I obtain it in the test case? Thanks a lot!","commit_id":"15ee00cd29fe38ca40a7bce76387016294fed0c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fa599b9f99585a7e8416124e5cffac7f90ba02a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def test_show(self):"},{"line_number":34,"context_line":"        share \u003d self.create_share()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        dpd_resp \u003d self.shares_v2_client.show_driver_private_data(share[\u0027id\u0027])"},{"line_number":37,"context_line":"        self.assertIn(\u0027driver_private_data\u0027, dpd_resp)"},{"line_number":38,"context_line":"        self.assertGreaterEqual(len(dpd_resp), 1)"},{"line_number":39,"context_line":"        for k, v in dpd_resp.items():"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_7046b5c0","line":36,"range":{"start_line":36,"start_character":66,"end_line":36,"end_character":77},"in_reply_to":"9ad45d7e_948bbcc2","updated":"2016-08-15 03:25:41.000000000","message":"This is exactly why I asked how the administrator or anyone for that matter has knowledge of the entity ID.. I *still* think this API does not make sense as it is... I think we need to have a way to query the current storage based on the driver and probably filter by the entity ID..","commit_id":"15ee00cd29fe38ca40a7bce76387016294fed0c7"}]}
