)]}'
{"manila/context.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"cdd28a31ba7e0a74e7126bf869fb0b9d657e0a6a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if kwargs:"},{"line_number":76,"context_line":"            LOG.warning(_LW(\u0027Arguments dropped when creating context: %s.\u0027),"},{"line_number":77,"context_line":"                        str(kwargs))"},{"line_number":78,"context_line":"        self.user_id \u003d user_id"},{"line_number":79,"context_line":"        self.project_id \u003d project_id"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if self.is_admin is None:"},{"line_number":82,"context_line":"            self.is_admin \u003d policy.check_is_admin(self.roles)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_a06952c0","line":79,"range":{"start_line":78,"start_character":8,"end_line":79,"end_character":36},"updated":"2016-05-16 20:50:47.000000000","message":"Could you explain why these lines change?","commit_id":"d6c4e3d3426883fa64c2b8c732e04e22dcb1b8a6"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"69e417606dd547a68b3677c64b8624f802350d37","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if kwargs:"},{"line_number":76,"context_line":"            LOG.warning(_LW(\u0027Arguments dropped when creating context: %s.\u0027),"},{"line_number":77,"context_line":"                        str(kwargs))"},{"line_number":78,"context_line":"        self.user_id \u003d user_id"},{"line_number":79,"context_line":"        self.project_id \u003d project_id"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if self.is_admin is None:"},{"line_number":82,"context_line":"            self.is_admin \u003d policy.check_is_admin(self.roles)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_e8921356","line":79,"range":{"start_line":78,"start_character":8,"end_line":79,"end_character":36},"in_reply_to":"dab17558_08d4c01d","updated":"2016-05-17 05:44:31.000000000","message":"According to line 61:\nuser\u003duser_id or user,\n\nwhich means that in the previous version where\nself.user_id \u003d self.user\n\nself.user_id could be theoretically equal to user not user_id (I guess both user and user_id are equal but in this case your cleanup is partial). \n\nI suggest either drop this change and then apply another patch with cleanup or complete this cleanup here.","commit_id":"d6c4e3d3426883fa64c2b8c732e04e22dcb1b8a6"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"13fcc99253749fe8ba698325f9e88d22ca079bd5","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if kwargs:"},{"line_number":76,"context_line":"            LOG.warning(_LW(\u0027Arguments dropped when creating context: %s.\u0027),"},{"line_number":77,"context_line":"                        str(kwargs))"},{"line_number":78,"context_line":"        self.user_id \u003d user_id"},{"line_number":79,"context_line":"        self.project_id \u003d project_id"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if self.is_admin is None:"},{"line_number":82,"context_line":"            self.is_admin \u003d policy.check_is_admin(self.roles)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_08d4c01d","line":79,"range":{"start_line":78,"start_character":8,"end_line":79,"end_character":36},"in_reply_to":"dab17558_a06952c0","updated":"2016-05-16 23:18:56.000000000","message":"I followed dimms change in nova referenced above.\n\nI think it makes sense to do it this way as we are assured of uniqueness and it\u0027s much more transparent than feeding user_id and project_id into the superclass __init__, setting values in self there, and then copying them back out into the subclass object values.","commit_id":"d6c4e3d3426883fa64c2b8c732e04e22dcb1b8a6"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"add9ddaac5536aec9f0ca6c556fd4fdf0e35b1bf","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if kwargs:"},{"line_number":76,"context_line":"            LOG.warning(_LW(\u0027Arguments dropped when creating context: %s.\u0027),"},{"line_number":77,"context_line":"                        str(kwargs))"},{"line_number":78,"context_line":"        self.user_id \u003d user_id"},{"line_number":79,"context_line":"        self.project_id \u003d project_id"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if self.is_admin is None:"},{"line_number":82,"context_line":"            self.is_admin \u003d policy.check_is_admin(self.roles)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_a748302e","line":79,"range":{"start_line":78,"start_character":8,"end_line":79,"end_character":36},"in_reply_to":"dab17558_e8921356","updated":"2016-05-17 09:42:36.000000000","message":"You are right, they are not really the same as I have done it :-)","commit_id":"d6c4e3d3426883fa64c2b8c732e04e22dcb1b8a6"}]}