)]}'
{"HACKING.rst":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"c5fd12a602cd05dd66123039d5fe10ec30f47266","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Manila Specific Commandments"},{"line_number":10,"context_line":"----------------------------"},{"line_number":11,"context_line":"- [M313] Use assertTrue(...) rather than aasertEqual(True, ...)."},{"line_number":12,"context_line":"- [M319] Validate that debug level logs are not translated."},{"line_number":13,"context_line":"- [M323] Ensure that the _() function is explicitly imported to ensure proper translations."},{"line_number":14,"context_line":"- [M325] str() cannot be used on an exception.  Remove use or use six.text_type()"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bab6814e_9ae6ea42","line":11,"range":{"start_line":11,"start_character":41,"end_line":11,"end_character":44},"updated":"2016-05-23 22:55:27.000000000","message":"\u0027aas\u0027 is reserved for as-a-service, so I guess you\u0027ll have to use \u0027ass\u0027 here.","commit_id":"80c6584af853ad9c98dba349e33b6103af5f8409"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ac786b8b932596c3752ff9b0a9513f76dcd13ba3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Manila Specific Commandments"},{"line_number":10,"context_line":"----------------------------"},{"line_number":11,"context_line":"- [M313] Use assertTrue(...) rather than aasertEqual(True, ...)."},{"line_number":12,"context_line":"- [M319] Validate that debug level logs are not translated."},{"line_number":13,"context_line":"- [M323] Ensure that the _() function is explicitly imported to ensure proper translations."},{"line_number":14,"context_line":"- [M325] str() cannot be used on an exception.  Remove use or use six.text_type()"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bab6814e_9a48aace","line":11,"range":{"start_line":11,"start_character":41,"end_line":11,"end_character":44},"in_reply_to":"bab6814e_9ae6ea42","updated":"2016-05-23 23:06:51.000000000","message":":)\n\nThanks, Mark.","commit_id":"80c6584af853ad9c98dba349e33b6103af5f8409"}],"manila/hacking/checks.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"00771000bc0c1666e733bce7a241017858f18f1d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"oslo_namespace_imports \u003d re.compile(r\"from[\\s]*oslo[.](.*)\")"},{"line_number":57,"context_line":"dict_constructor_with_list_copy_re \u003d re.compile(r\".*\\bdict\\((\\[)?(\\(|\\[)\")"},{"line_number":58,"context_line":"assert_no_xrange_re \u003d re.compile(r\"\\s*xrange\\s*\\(\")"},{"line_number":59,"context_line":"assert_True \u003d re.compile("},{"line_number":60,"context_line":"    r\".*assertEqual\\(True, .*\\)\")"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_6688cfc7","line":59,"range":{"start_line":59,"start_character":7,"end_line":59,"end_character":8},"updated":"2016-05-24 02:50:26.000000000","message":"should be okay to use lower case...","commit_id":"b85248bce686309395e92f8b7e31f8a4e8fe7fd4"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"eed29f82bae7c1f60f0cf5494082b5619e000c94","unresolved":false,"context_lines":[{"line_number":56,"context_line":"oslo_namespace_imports \u003d re.compile(r\"from[\\s]*oslo[.](.*)\")"},{"line_number":57,"context_line":"dict_constructor_with_list_copy_re \u003d re.compile(r\".*\\bdict\\((\\[)?(\\(|\\[)\")"},{"line_number":58,"context_line":"assert_no_xrange_re \u003d re.compile(r\"\\s*xrange\\s*\\(\")"},{"line_number":59,"context_line":"assert_True \u003d re.compile("},{"line_number":60,"context_line":"    r\".*assertEqual\\(True, .*\\)\")"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_e15ca9f2","line":59,"range":{"start_line":59,"start_character":7,"end_line":59,"end_character":8},"in_reply_to":"bab6814e_6688cfc7","updated":"2016-05-24 03:01:31.000000000","message":"ok, but why?  True is the python value that is in question, no?\n\nAlso, unless there is a compelling reason otherwise, this is what other projects are doing.  I\u0027d eventually like to see these cross-project checks work their way back up into the central hacking checks so we can remove them in the specific projects.  Other things being equal, the more they are consistent with one another the easier it will be to see that they can be replaced by a central cross-project check.","commit_id":"b85248bce686309395e92f8b7e31f8a4e8fe7fd4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bf06052c77f9a7564aaf18b7bb7bbd205965f44d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"oslo_namespace_imports \u003d re.compile(r\"from[\\s]*oslo[.](.*)\")"},{"line_number":57,"context_line":"dict_constructor_with_list_copy_re \u003d re.compile(r\".*\\bdict\\((\\[)?(\\(|\\[)\")"},{"line_number":58,"context_line":"assert_no_xrange_re \u003d re.compile(r\"\\s*xrange\\s*\\(\")"},{"line_number":59,"context_line":"assert_True \u003d re.compile("},{"line_number":60,"context_line":"    r\".*assertEqual\\(True, .*\\)\")"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_a1ac618d","line":59,"range":{"start_line":59,"start_character":7,"end_line":59,"end_character":8},"in_reply_to":"bab6814e_e15ca9f2","updated":"2016-05-24 03:07:54.000000000","message":"I agree it would be easier to inherit, but i don\u0027t understand why they would choose to go against pep8.. it\u0027s not readable, imho:\n\nhttps://www.python.org/dev/peps/pep-0008/#descriptive-naming-styles","commit_id":"b85248bce686309395e92f8b7e31f8a4e8fe7fd4"}]}