)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"113acd43db5db4f235cab793011a2d5f9993d833","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Huawei: Fix exception in update_access not found"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When share is deleted in the backend, user is unable to delete"},{"line_number":10,"context_line":"share because of error thrown in update_access(). This"},{"line_number":11,"context_line":"method throws a ShareResourceNotFound exception to be handled"},{"line_number":12,"context_line":"by manager, thus allowing share to be deleted in this case,"},{"line_number":13,"context_line":"without having to use force-delete."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9756ff882e6960b07f5f0abac94057c687830ad0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_7f64c6e4","line":12,"range":{"start_line":10,"start_character":50,"end_line":12,"end_character":10},"updated":"2016-05-24 09:07:56.000000000","message":"You make it throw it, but it doesn\u0027t, in master.\n\nBetter to reword it:\n\n\"\"\"\nMake backend raise ShareResourceNotFound exception in case share not found during \"update_access\" operation, because share manager expects it for proper handling of share deletion.\n\"\"\"","commit_id":"815697c3d3f109de1108e3921ee9b547ba98233b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9bfcede0aba9c228f6c229ecc1c8cfdbb6558acc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Huawei: Fix exception in update_access not found"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When share is deleted in the backend, user is unable to delete"},{"line_number":10,"context_line":"share because of error thrown in update_access(). This"},{"line_number":11,"context_line":"method throws a ShareResourceNotFound exception to be handled"},{"line_number":12,"context_line":"by manager, thus allowing share to be deleted in this case,"},{"line_number":13,"context_line":"without having to use force-delete."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9756ff882e6960b07f5f0abac94057c687830ad0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_bfee2eb2","line":12,"range":{"start_line":10,"start_character":50,"end_line":12,"end_character":10},"in_reply_to":"bab6814e_7f64c6e4","updated":"2016-05-24 09:15:07.000000000","message":"Done","commit_id":"815697c3d3f109de1108e3921ee9b547ba98233b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"248ee541ff6373f556c2fc45b76d796b93adc6df","unresolved":false,"context_lines":[{"line_number":10,"context_line":"share because of error thrown in update_access(). Make backend raise"},{"line_number":11,"context_line":"ShareResourceNotFound exception in case share not found during"},{"line_number":12,"context_line":"\"update_access\" operation, because share manager expects it for"},{"line_number":13,"context_line":"proper handling of share deletion., thus allowing share to be"},{"line_number":14,"context_line":"deleted in this case, without having to use force-delete."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I9756ff882e6960b07f5f0abac94057c687830ad0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_706793b7","line":13,"range":{"start_line":13,"start_character":33,"end_line":13,"end_character":34},"updated":"2016-05-25 10:15:19.000000000","message":"nit: remove \u0027.\u0027","commit_id":"0857b3b0cea0ad937cf125fee978f30baabc1705"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a15c1201c3786eaee316f3bfc830dc189bcaa2db","unresolved":false,"context_lines":[{"line_number":10,"context_line":"share because of error thrown in update_access(). Make backend raise"},{"line_number":11,"context_line":"ShareResourceNotFound exception in case share not found during"},{"line_number":12,"context_line":"\"update_access\" operation, because share manager expects it for"},{"line_number":13,"context_line":"proper handling of share deletion., thus allowing share to be"},{"line_number":14,"context_line":"deleted in this case, without having to use force-delete."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I9756ff882e6960b07f5f0abac94057c687830ad0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_403d338e","line":13,"range":{"start_line":13,"start_character":33,"end_line":13,"end_character":34},"in_reply_to":"bab6814e_706793b7","updated":"2016-05-26 01:21:00.000000000","message":"Done","commit_id":"0857b3b0cea0ad937cf125fee978f30baabc1705"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f97ebf9780a549a3ba4e413781153c2369f41833","unresolved":false,"context_lines":[{"line_number":14,"context_line":"deleted in this case, without having to use force-delete."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"After add ShareResourceNotFound exception, it will need a parameter"},{"line_number":17,"context_line":"named share id(share[\u0027id\u0027]), so add share id to share info in"},{"line_number":18,"context_line":"create_share_from_snapshot function."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I9756ff882e6960b07f5f0abac94057c687830ad0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bab6814e_11f522ec","line":17,"range":{"start_line":17,"start_character":12,"end_line":17,"end_character":14},"updated":"2016-05-26 13:23:37.000000000","message":"ID","commit_id":"548975ee2d372f8374697e3d838e0b62cf2c6310"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f97ebf9780a549a3ba4e413781153c2369f41833","unresolved":false,"context_lines":[{"line_number":14,"context_line":"deleted in this case, without having to use force-delete."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"After add ShareResourceNotFound exception, it will need a parameter"},{"line_number":17,"context_line":"named share id(share[\u0027id\u0027]), so add share id to share info in"},{"line_number":18,"context_line":"create_share_from_snapshot function."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I9756ff882e6960b07f5f0abac94057c687830ad0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bab6814e_71de2e6e","line":17,"range":{"start_line":17,"start_character":42,"end_line":17,"end_character":44},"updated":"2016-05-26 13:23:37.000000000","message":"ID","commit_id":"548975ee2d372f8374697e3d838e0b62cf2c6310"}],"manila/share/drivers/huawei/v3/connection.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"52498aae8e56febde5b36454e6c7e8e2eab830d9","unresolved":false,"context_lines":[{"line_number":388,"context_line":"            \"mount_path\": new_share_path.replace(\"\\\\\", \"/\"),"},{"line_number":389,"context_line":"            \"mount_src\":"},{"line_number":390,"context_line":"                tempfile.mkdtemp(prefix\u003dconstants.TMP_PATH_DST_PREFIX),"},{"line_number":391,"context_line":"            \"id\": snapshot[\u0027share_id\u0027],"},{"line_number":392,"context_line":"        }"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        old_share_path \u003d self._get_location_path(old_share_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_995b662e","line":391,"range":{"start_line":391,"start_character":12,"end_line":391,"end_character":39},"updated":"2016-05-24 17:48:35.000000000","message":"this looks to be unrelated to the goal of this commit","commit_id":"c44c45955a9b36104cf5ea650174ab68fcf9eb71"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"24a80c4c151f33c21f0fdb02cd922dd819d05da1","unresolved":false,"context_lines":[{"line_number":388,"context_line":"            \"mount_path\": new_share_path.replace(\"\\\\\", \"/\"),"},{"line_number":389,"context_line":"            \"mount_src\":"},{"line_number":390,"context_line":"                tempfile.mkdtemp(prefix\u003dconstants.TMP_PATH_DST_PREFIX),"},{"line_number":391,"context_line":"            \"id\": snapshot[\u0027share_id\u0027],"},{"line_number":392,"context_line":"        }"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        old_share_path \u003d self._get_location_path(old_share_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_855e4d43","line":391,"range":{"start_line":391,"start_character":12,"end_line":391,"end_character":39},"in_reply_to":"bab6814e_995b662e","updated":"2016-05-25 01:44:41.000000000","message":"Hi Rodrigo Barbieri, when I add \"ShareResourceNotFound(share_id\u003dshare[\u0027id\u0027])\" in allow_access function, It will need a parameter named share id(share[\u0027id\u0027]), this share info assembled by myself, so It will add id in this, otherwise, it will thrown KeyError: \u0027id\u0027.","commit_id":"c44c45955a9b36104cf5ea650174ab68fcf9eb71"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"52498aae8e56febde5b36454e6c7e8e2eab830d9","unresolved":false,"context_lines":[{"line_number":400,"context_line":"            \"mount_src\":"},{"line_number":401,"context_line":"                tempfile.mkdtemp(prefix\u003dconstants.TMP_PATH_SRC_PREFIX),"},{"line_number":402,"context_line":"            \"snapshot_name\": (\"share_snapshot_\" +"},{"line_number":403,"context_line":"                              snapshot[\u0027id\u0027].replace(\"-\", \"_\")),"},{"line_number":404,"context_line":"            \"id\": snapshot[\u0027share_id\u0027],"},{"line_number":405,"context_line":"        }"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_f940b237","line":404,"range":{"start_line":403,"start_character":12,"end_line":404,"end_character":39},"updated":"2016-05-24 17:48:35.000000000","message":"same as above","commit_id":"c44c45955a9b36104cf5ea650174ab68fcf9eb71"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"24a80c4c151f33c21f0fdb02cd922dd819d05da1","unresolved":false,"context_lines":[{"line_number":400,"context_line":"            \"mount_src\":"},{"line_number":401,"context_line":"                tempfile.mkdtemp(prefix\u003dconstants.TMP_PATH_SRC_PREFIX),"},{"line_number":402,"context_line":"            \"snapshot_name\": (\"share_snapshot_\" +"},{"line_number":403,"context_line":"                              snapshot[\u0027id\u0027].replace(\"-\", \"_\")),"},{"line_number":404,"context_line":"            \"id\": snapshot[\u0027share_id\u0027],"},{"line_number":405,"context_line":"        }"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_6559a95b","line":404,"range":{"start_line":403,"start_character":12,"end_line":404,"end_character":39},"in_reply_to":"bab6814e_f940b237","updated":"2016-05-25 01:44:41.000000000","message":"Hi Rodrigo Barbieri, when I add \"ShareResourceNotFound(share_id\u003dshare[\u0027id\u0027])\" in allow_access function, It will need a parameter named share id(share[\u0027id\u0027]), this share info assembled by myself, so It will add id in this, otherwise, it will thrown KeyError: \u0027id\u0027.","commit_id":"c44c45955a9b36104cf5ea650174ab68fcf9eb71"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"248ee541ff6373f556c2fc45b76d796b93adc6df","unresolved":false,"context_lines":[{"line_number":401,"context_line":"                tempfile.mkdtemp(prefix\u003dconstants.TMP_PATH_SRC_PREFIX),"},{"line_number":402,"context_line":"            \"snapshot_name\": (\"share_snapshot_\" +"},{"line_number":403,"context_line":"                              snapshot[\u0027id\u0027].replace(\"-\", \"_\")),"},{"line_number":404,"context_line":"            \"id\": snapshot[\u0027share_id\u0027],"},{"line_number":405,"context_line":"        }"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_6b468850","line":404,"range":{"start_line":404,"start_character":12,"end_line":404,"end_character":38},"updated":"2016-05-25 10:15:19.000000000","message":"I see why you need it: https://github.com/openstack/manila/blob/02a9a2c/manila/share/drivers/huawei/v3/connection.py#L428\n\nbut you could clarify this in your commit message so that it\u0027s obvious why changing the update_access behavior needs a change in the create_share_from_snapshot method...","commit_id":"0857b3b0cea0ad937cf125fee978f30baabc1705"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a15c1201c3786eaee316f3bfc830dc189bcaa2db","unresolved":false,"context_lines":[{"line_number":401,"context_line":"                tempfile.mkdtemp(prefix\u003dconstants.TMP_PATH_SRC_PREFIX),"},{"line_number":402,"context_line":"            \"snapshot_name\": (\"share_snapshot_\" +"},{"line_number":403,"context_line":"                              snapshot[\u0027id\u0027].replace(\"-\", \"_\")),"},{"line_number":404,"context_line":"            \"id\": snapshot[\u0027share_id\u0027],"},{"line_number":405,"context_line":"        }"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_e04c2744","line":404,"range":{"start_line":404,"start_character":12,"end_line":404,"end_character":38},"in_reply_to":"bab6814e_6b468850","updated":"2016-05-26 01:21:00.000000000","message":"Done","commit_id":"0857b3b0cea0ad937cf125fee978f30baabc1705"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"248ee541ff6373f556c2fc45b76d796b93adc6df","unresolved":false,"context_lines":[{"line_number":706,"context_line":"        share_stor \u003d self.helper._get_share_by_name(share_name,"},{"line_number":707,"context_line":"                                                    share_url_type)"},{"line_number":708,"context_line":"        if not share_stor:"},{"line_number":709,"context_line":"            err_msg \u003d (_(\"Can not get share ID by share %s.\")"},{"line_number":710,"context_line":"                       % share_name)"},{"line_number":711,"context_line":"            LOG.error(err_msg)"},{"line_number":712,"context_line":"            raise exception.ShareResourceNotFound(share_id\u003dshare[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_d05f5f73","line":709,"range":{"start_line":709,"start_character":26,"end_line":709,"end_character":55},"updated":"2016-05-25 10:15:19.000000000","message":"\"Share %s does not exist on the backend\"?","commit_id":"0857b3b0cea0ad937cf125fee978f30baabc1705"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a15c1201c3786eaee316f3bfc830dc189bcaa2db","unresolved":false,"context_lines":[{"line_number":706,"context_line":"        share_stor \u003d self.helper._get_share_by_name(share_name,"},{"line_number":707,"context_line":"                                                    share_url_type)"},{"line_number":708,"context_line":"        if not share_stor:"},{"line_number":709,"context_line":"            err_msg \u003d (_(\"Can not get share ID by share %s.\")"},{"line_number":710,"context_line":"                       % share_name)"},{"line_number":711,"context_line":"            LOG.error(err_msg)"},{"line_number":712,"context_line":"            raise exception.ShareResourceNotFound(share_id\u003dshare[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_c0492333","line":709,"range":{"start_line":709,"start_character":26,"end_line":709,"end_character":55},"in_reply_to":"bab6814e_d05f5f73","updated":"2016-05-26 01:21:00.000000000","message":"Done","commit_id":"0857b3b0cea0ad937cf125fee978f30baabc1705"}],"releasenotes/notes/fix-huawei-exception-a09b73234ksd94kd.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"248ee541ff6373f556c2fc45b76d796b93adc6df","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fix exception in update_access not found in Huawei driver."},{"line_number":4,"context_line":"  - Make backend raise ShareResourceNotFound exception in case"},{"line_number":5,"context_line":"    share not found during \"update_access\" operation, because share"},{"line_number":6,"context_line":"    manager expects it for proper handling of share deletion., thus"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_50ca4f50","line":3,"range":{"start_line":3,"start_character":61,"end_line":3,"end_character":62},"updated":"2016-05-25 10:15:19.000000000","message":"This description seems sufficient..","commit_id":"0857b3b0cea0ad937cf125fee978f30baabc1705"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a15c1201c3786eaee316f3bfc830dc189bcaa2db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fix exception in update_access not found in Huawei driver."},{"line_number":4,"context_line":"  - Make backend raise ShareResourceNotFound exception in case"},{"line_number":5,"context_line":"    share not found during \"update_access\" operation, because share"},{"line_number":6,"context_line":"    manager expects it for proper handling of share deletion., thus"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_406413b8","line":3,"range":{"start_line":3,"start_character":61,"end_line":3,"end_character":62},"in_reply_to":"bab6814e_50ca4f50","updated":"2016-05-26 01:21:00.000000000","message":"Done","commit_id":"0857b3b0cea0ad937cf125fee978f30baabc1705"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"248ee541ff6373f556c2fc45b76d796b93adc6df","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fix exception in update_access not found in Huawei driver."},{"line_number":4,"context_line":"  - Make backend raise ShareResourceNotFound exception in case"},{"line_number":5,"context_line":"    share not found during \"update_access\" operation, because share"},{"line_number":6,"context_line":"    manager expects it for proper handling of share deletion., thus"},{"line_number":7,"context_line":"    allowing share to be deleted in this case, without having to use"},{"line_number":8,"context_line":"    force-delete."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_909f975e","line":5,"range":{"start_line":5,"start_character":9,"end_line":5,"end_character":10},"updated":"2016-05-25 10:15:19.000000000","message":"was","commit_id":"0857b3b0cea0ad937cf125fee978f30baabc1705"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"248ee541ff6373f556c2fc45b76d796b93adc6df","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fix exception in update_access not found in Huawei driver."},{"line_number":4,"context_line":"  - Make backend raise ShareResourceNotFound exception in case"},{"line_number":5,"context_line":"    share not found during \"update_access\" operation, because share"},{"line_number":6,"context_line":"    manager expects it for proper handling of share deletion., thus"},{"line_number":7,"context_line":"    allowing share to be deleted in this case, without having to use"},{"line_number":8,"context_line":"    force-delete."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_f0b263e4","line":8,"range":{"start_line":4,"start_character":4,"end_line":8,"end_character":17},"updated":"2016-05-25 10:15:19.000000000","message":"This is too much implementation detail for a user/deployer...","commit_id":"0857b3b0cea0ad937cf125fee978f30baabc1705"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a15c1201c3786eaee316f3bfc830dc189bcaa2db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fix exception in update_access not found in Huawei driver."},{"line_number":4,"context_line":"  - Make backend raise ShareResourceNotFound exception in case"},{"line_number":5,"context_line":"    share not found during \"update_access\" operation, because share"},{"line_number":6,"context_line":"    manager expects it for proper handling of share deletion., thus"},{"line_number":7,"context_line":"    allowing share to be deleted in this case, without having to use"},{"line_number":8,"context_line":"    force-delete."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_a055ffc2","line":8,"range":{"start_line":4,"start_character":4,"end_line":8,"end_character":17},"in_reply_to":"bab6814e_f0b263e4","updated":"2016-05-26 01:21:00.000000000","message":"Done","commit_id":"0857b3b0cea0ad937cf125fee978f30baabc1705"}]}