)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"815ab3ca62cf2605c03bd174ddbc4fefede6587e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update hacking underscore import"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update regex to the cinder version which is stricter."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Icb64f686cefac758240116b757669acc5e3118f7"},{"line_number":12,"context_line":"Closes-Bug: #1541780"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_1f301a07","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":53},"updated":"2016-05-24 09:19:37.000000000","message":"Please, describe what you do. Also, if you refer to some specific change, then add link to it here by change-id.","commit_id":"98404b572d3274b21e990f75c93ac3974a8a35b6"}],"manila/hacking/checks.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"86292c241e425ee819f90430efef67b708df6bfe","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    r\"(.)*LOG\\.(audit|error|info|warn|warning|critical|exception)\""},{"line_number":50,"context_line":"    \"\\(\\s*_\\(\\s*(\u0027|\\\")\")"},{"line_number":51,"context_line":"string_translation \u003d re.compile(r\"[^_]*_\\(\\s*(\u0027|\\\")\")"},{"line_number":52,"context_line":"underscore_import_check \u003d re.compile(r\"(.)*import _$\")"},{"line_number":53,"context_line":"underscore_import_check_multi \u003d re.compile(r\"(.)*i18n\\s+import(.)* _, (.)*\")"},{"line_number":54,"context_line":"# We need this for cases where they have created their own _ function."},{"line_number":55,"context_line":"custom_underscore_check \u003d re.compile(r\"(.)*_\\s*\u003d\\s*(.)*\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_7f696625","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":54},"updated":"2016-05-24 09:16:17.000000000","message":"Why this one is not updated?","commit_id":"98404b572d3274b21e990f75c93ac3974a8a35b6"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f6300f9e68c4e78b79a1d76a58592f622417a49a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    r\"(.)*LOG\\.(audit|error|info|warn|warning|critical|exception)\""},{"line_number":50,"context_line":"    \"\\(\\s*_\\(\\s*(\u0027|\\\")\")"},{"line_number":51,"context_line":"string_translation \u003d re.compile(r\"[^_]*_\\(\\s*(\u0027|\\\")\")"},{"line_number":52,"context_line":"underscore_import_check \u003d re.compile(r\"(.)*i18n\\s+import _$\")"},{"line_number":53,"context_line":"underscore_import_check_multi \u003d re.compile(r\"(.)*i18n\\s+import(.)* _, (.)*\")"},{"line_number":54,"context_line":"# We need this for cases where they have created their own _ function."},{"line_number":55,"context_line":"custom_underscore_check \u003d re.compile(r\"(.)*_\\s*\u003d\\s*(.)*\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_49af8294","line":52,"updated":"2016-05-24 13:26:19.000000000","message":"This change isn\u0027t getting tested.  If you remove it, your tests still pass.","commit_id":"16d330710b511f2f385088f2a77f2c5daa5710ac"}],"manila/tests/test_hacking.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f6300f9e68c4e78b79a1d76a58592f622417a49a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            \"msg \u003d _(\u0027My message\u0027)\","},{"line_number":118,"context_line":"            \"manila.tests.unit/other_files6.py\"))))"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.assertEqual(0, len(list(checks.check_explicit_underscore_import("},{"line_number":121,"context_line":"            \"from anotherimport import _LW, _\","},{"line_number":122,"context_line":"            \"manila.tests.unit/other_files7.py\"))))"},{"line_number":123,"context_line":"        self.assertEqual(1, len(list(checks.check_explicit_underscore_import("},{"line_number":124,"context_line":"            \"msg \u003d _(\u0027My message\u0027)\","},{"line_number":125,"context_line":"            \"manila.tests.unit/other_files7.py\"))))"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # We are patching pep8 so that only the check under test is actually"},{"line_number":128,"context_line":"    # installed."}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_893b2a38","line":125,"range":{"start_line":120,"start_character":8,"end_line":125,"end_character":51},"updated":"2016-05-24 13:26:19.000000000","message":"These tests (for files7) don\u0027t seem to be doing what is intended.  If you revert your functional code changes and remove the files6 tests, then these still pass.  So the files7 tests don\u0027t seem to test your changes.","commit_id":"16d330710b511f2f385088f2a77f2c5daa5710ac"}]}