)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"79df8e0e8a585a7ed1bc4a25af928739163bd59f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HPE3PAR driver doesn\u0027t decrease fstore capacity"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.This patch reduces the fsquota when a share is deleted"},{"line_number":10,"context_line":"for shared fstores."},{"line_number":11,"context_line":"2.Added new test_mediator_delete_share_with_fstore_per_share_false()"},{"line_number":12,"context_line":"to cover case:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9abb7d3a_97b54d7f","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":2},"updated":"2016-06-01 18:01:26.000000000","message":"#1 is good. But you don\u0027t need the number if you get rid of the 2,3,4.  I suggest you remove #2,3,4 -- because test coverage and release notes are expected things and listings of files touched are provided by git/gerrit. That info is not needed in the commit message.","commit_id":"3de76ac998dbf9d0f3391afd64ae32290ecc325c"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"79df8e0e8a585a7ed1bc4a25af928739163bd59f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"test_mediator_delete_nfs_share_only_readonly(),"},{"line_number":18,"context_line":"test_mediator_delete_share_not_found()"},{"line_number":19,"context_line":"test_mediator_delete_nfs_share() functions:"},{"line_number":20,"context_line":"*to handle arguments of delete_share  function of hpe_3par_mediator.py"},{"line_number":21,"context_line":"4.Added a release note."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ib20646696e6ee6c7c216530697c35a54eabede43"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9abb7d3a_7700a966","line":20,"range":{"start_line":20,"start_character":36,"end_line":20,"end_character":37},"updated":"2016-06-01 18:01:26.000000000","message":"extra space","commit_id":"3de76ac998dbf9d0f3391afd64ae32290ecc325c"}],"manila/share/drivers/hpe/hpe_3par_driver.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"79df8e0e8a585a7ed1bc4a25af928739163bd59f","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    \"\"\""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    VERSION \u003d \"2.0.3\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":132,"context_line":"        super(HPE3ParShareDriver, self).__init__((True, False),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_99fc5fb9","line":129,"range":{"start_line":129,"start_character":15,"end_line":129,"end_character":20},"updated":"2016-06-01 18:01:26.000000000","message":"please bump up the version and add a line in the history above.","commit_id":"3de76ac998dbf9d0f3391afd64ae32290ecc325c"}],"manila/share/drivers/hpe/hpe_3par_mediator.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c1681e907b156176a39e1d57c2780b61f3a7c6dc","unresolved":false,"context_lines":[{"line_number":634,"context_line":"            LOG.exception(msg)"},{"line_number":635,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    def delete_share(self, project_id, share_id, share_size, share_proto, fpg, vfs):"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        protocol \u003d self.ensure_supported_protocol(share_proto)"},{"line_number":640,"context_line":"        share_name \u003d self.ensure_prefix(share_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_372cdcaa","line":637,"range":{"start_line":637,"start_character":4,"end_line":637,"end_character":84},"updated":"2016-05-30 16:43:10.000000000","message":"pep8 fails because this line too long.","commit_id":"2d0d59f686d6f0941cc483fd57cefd76d3d5778e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"79df8e0e8a585a7ed1bc4a25af928739163bd59f","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    \"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    VERSION \u003d \"2.0.4\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def __init__(self, **kwargs):"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_b96683b8","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":21},"updated":"2016-06-01 18:01:26.000000000","message":"Please bump up the version and add a line in this history comment above.","commit_id":"3de76ac998dbf9d0f3391afd64ae32290ecc325c"}],"manila/tests/share/drivers/hpe/test_hpe_3par_mediator.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"79df8e0e8a585a7ed1bc4a25af928739163bd59f","unresolved":false,"context_lines":[{"line_number":658,"context_line":"        self.mediator._delete_share_directory.assert_called_with("},{"line_number":659,"context_line":"            expected_mount_path)"},{"line_number":660,"context_line":"        self.mediator._unmount_super_share.assert_called_with("},{"line_number":661,"context_line":"            expected_mount_path)"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"    def test_mediator_delete_share_not_found(self):"},{"line_number":664,"context_line":"        self.init_mediator()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_19922f4c","line":661,"updated":"2016-06-01 18:01:26.000000000","message":"You added a mock for _update_capacity_quotas.  Please add an assert here to verify that the mocked method was used as expected.","commit_id":"3de76ac998dbf9d0f3391afd64ae32290ecc325c"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"79df8e0e8a585a7ed1bc4a25af928739163bd59f","unresolved":false,"context_lines":[{"line_number":843,"context_line":"        self.mediator._delete_share_directory.assert_called_with("},{"line_number":844,"context_line":"            expected_mount_path)"},{"line_number":845,"context_line":"        self.mediator._unmount_super_share.assert_called_with("},{"line_number":846,"context_line":"            expected_mount_path)"},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"    def test_mediator_delete_cifs_share(self):"},{"line_number":849,"context_line":"        self.init_mediator()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_79cffb55","line":846,"updated":"2016-06-01 18:01:26.000000000","message":"same here. When you mock a method, use an assert to verify that it was used as expected.","commit_id":"3de76ac998dbf9d0f3391afd64ae32290ecc325c"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"79df8e0e8a585a7ed1bc4a25af928739163bd59f","unresolved":false,"context_lines":[{"line_number":914,"context_line":"        self.mediator._delete_share_directory.assert_called_with("},{"line_number":915,"context_line":"            expected_mount_path)"},{"line_number":916,"context_line":"        self.mediator._unmount_super_share.assert_called_with("},{"line_number":917,"context_line":"            expected_mount_path)"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"    def test_mediator_delete_share_with_fstore_per_share_false(self):"},{"line_number":920,"context_line":"        self.init_mediator()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_f9092b96","line":917,"updated":"2016-06-01 18:01:26.000000000","message":"same here","commit_id":"3de76ac998dbf9d0f3391afd64ae32290ecc325c"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"79df8e0e8a585a7ed1bc4a25af928739163bd59f","unresolved":false,"context_lines":[{"line_number":923,"context_line":"        fstore_init_size \u003d int("},{"line_number":924,"context_line":"            constants.GET_FSQUOTA[\u0027members\u0027][0][\u0027hardBlock\u0027])"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        if not self.mediator.hpe3par_fstore_per_share:"},{"line_number":927,"context_line":"            expected_capacity \u003d (0-share_size) * units.Ki + fstore_init_size"},{"line_number":928,"context_line":"        self.mock_object(self.mediator,"},{"line_number":929,"context_line":"                         \u0027_find_fstore\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_f97e4be2","line":926,"range":{"start_line":926,"start_character":7,"end_line":926,"end_character":54},"updated":"2016-06-01 18:01:26.000000000","message":"This is set to False a few lines above, so the if is not needed.","commit_id":"3de76ac998dbf9d0f3391afd64ae32290ecc325c"}],"releasenotes/notes/bug_1582931-1437eae20fa544d1.yaml":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"744fcdfb09db96524c158c5f229f617568288ff4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"    reduces the fsquota when a share is deleted"},{"line_number":4,"context_line":"    for shared fstores."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9abb7d3a_7f7a9f78","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":23},"updated":"2016-05-31 09:19:51.000000000","message":"It should mention share driver. Because it is completely confusing what backend was fixed in general.","commit_id":"427986a10319f5eea117e53b82e1cdedccee863d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"79df8e0e8a585a7ed1bc4a25af928739163bd59f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"    HPE3PAR Driver fix to reduce the fsquota when a share is deleted"},{"line_number":4,"context_line":"    for shared fstores."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9abb7d3a_9c3d6dc6","line":4,"updated":"2016-06-01 18:01:26.000000000","message":"See the releasenotes job output.  It is all messed up, but I believe that was introduced before this patch.","commit_id":"3de76ac998dbf9d0f3391afd64ae32290ecc325c"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"24dc8530d495fa2bac3e10bfba02532f2580f00b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"    HPE3PAR Driver fix to reduce the fsquota when a share is deleted"},{"line_number":4,"context_line":"    for shared fstores."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9abb7d3a_5c9e6507","line":4,"in_reply_to":"9abb7d3a_9c3d6dc6","updated":"2016-06-01 18:14:03.000000000","message":"See patchset 324047. Hopefully that fixes the problem and then you\u0027ll want to follow its example -- and check the build output.","commit_id":"3de76ac998dbf9d0f3391afd64ae32290ecc325c"}]}
