)]}'
{"manila/tests/db/migrations/alembic/migrations_data_checks.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7dcdb2bad521eeb1d0bfac762d7ae3e9416ecd0e","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        for el in engine.execute(el_table.select()):"},{"line_number":215,"context_line":"            self.test_case.assertTrue(hasattr(el, \u0027is_admin_only\u0027))"},{"line_number":216,"context_line":"            self.test_case.assertTrue(hasattr(el, \u0027uuid\u0027))"},{"line_number":217,"context_line":"            self.test_case.assertFalse(el.is_admin_only)"},{"line_number":218,"context_line":"            self.test_case.assertTrue(uuidutils.is_uuid_like(el.uuid))"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        # Write export location metadata"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_5decdaf2","line":217,"updated":"2016-05-31 20:42:22.000000000","message":"assertFalse(is_admin_only) is more dangerous than assertEqual(False, is_admin_only) because it is True in the case that is_admin_only is None.  So if is_admin_only doesn\u0027t get set properly it will still pass the assert - i.e. if the code says el._is_admin_only \u003d somefunction() and somefunction (perhaps b/c of a bug) returns None instead of True or False, this assert will pass whereas the original one would not.\n\nNote that assertTrue() does not have this issue where it is vulnerable to a setting function returning None by accident.  It will still fail in that case.","commit_id":"e302a02d3d3ff1062235e7546b1fb6f117be0b8b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4496322e5c45033c5d1e726b86cd4d221ebb8034","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        for el in engine.execute(el_table.select()):"},{"line_number":215,"context_line":"            self.test_case.assertTrue(hasattr(el, \u0027is_admin_only\u0027))"},{"line_number":216,"context_line":"            self.test_case.assertTrue(hasattr(el, \u0027uuid\u0027))"},{"line_number":217,"context_line":"            self.test_case.assertFalse(el.is_admin_only)"},{"line_number":218,"context_line":"            self.test_case.assertTrue(uuidutils.is_uuid_like(el.uuid))"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        # Write export location metadata"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_a03dc8de","line":217,"in_reply_to":"9abb7d3a_5decdaf2","updated":"2016-06-01 10:10:21.000000000","message":"Tom is right.","commit_id":"e302a02d3d3ff1062235e7546b1fb6f117be0b8b"}]}
