)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"6e21f8bce01d945cd015622d91a973bb8a815db9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liuke2 \u003cliuke2@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-02 11:35:07 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei: Support pool reported disk type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding support for pool report disk type in huawei"},{"line_number":10,"context_line":"manila driver. When creating share need appointing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_0e9e5006","line":7,"range":{"start_line":7,"start_character":16,"end_line":7,"end_character":39},"updated":"2016-06-02 03:52:06.000000000","message":"reporting disk type of pool","commit_id":"8c797b7a1a8746e6b03862c89e4fe20e1d9ade87"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"4c131d1c7f94264e357d11734958b71279f99fbf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liuke2 \u003cliuke2@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-02 11:35:07 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei: Support pool reported disk type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding support for pool report disk type in huawei"},{"line_number":10,"context_line":"manila driver. When creating share need appointing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_b1520511","line":7,"range":{"start_line":7,"start_character":16,"end_line":7,"end_character":39},"in_reply_to":"9abb7d3a_0e9e5006","updated":"2016-06-02 04:06:54.000000000","message":"Done","commit_id":"8c797b7a1a8746e6b03862c89e4fe20e1d9ade87"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"6e21f8bce01d945cd015622d91a973bb8a815db9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei: Support pool reported disk type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding support for pool report disk type in huawei"},{"line_number":10,"context_line":"manila driver. When creating share need appointing"},{"line_number":11,"context_line":"that pool has a disk type (ssd/sas/nl_sas and mix),"},{"line_number":12,"context_line":"manila driver should report that pool disk type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_8e9240f4","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":40},"updated":"2016-06-02 03:52:06.000000000","message":"reporting disk type of pool","commit_id":"8c797b7a1a8746e6b03862c89e4fe20e1d9ade87"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"4c131d1c7f94264e357d11734958b71279f99fbf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei: Support pool reported disk type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding support for pool report disk type in huawei"},{"line_number":10,"context_line":"manila driver. When creating share need appointing"},{"line_number":11,"context_line":"that pool has a disk type (ssd/sas/nl_sas and mix),"},{"line_number":12,"context_line":"manila driver should report that pool disk type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_f1de4d3c","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":40},"in_reply_to":"9abb7d3a_8e9240f4","updated":"2016-06-02 04:06:54.000000000","message":"Done","commit_id":"8c797b7a1a8746e6b03862c89e4fe20e1d9ade87"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"6e21f8bce01d945cd015622d91a973bb8a815db9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Huawei: Support pool reported disk type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding support for pool report disk type in huawei"},{"line_number":10,"context_line":"manila driver. When creating share need appointing"},{"line_number":11,"context_line":"that pool has a disk type (ssd/sas/nl_sas and mix),"},{"line_number":12,"context_line":"manila driver should report that pool disk type."},{"line_number":13,"context_line":"This BP provide this ability."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_ce33a812","line":11,"range":{"start_line":10,"start_character":35,"end_line":11,"end_character":25},"updated":"2016-06-02 03:52:06.000000000","message":"we can specify the disk type of the pool we want to use","commit_id":"8c797b7a1a8746e6b03862c89e4fe20e1d9ade87"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"4c131d1c7f94264e357d11734958b71279f99fbf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Huawei: Support pool reported disk type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding support for pool report disk type in huawei"},{"line_number":10,"context_line":"manila driver. When creating share need appointing"},{"line_number":11,"context_line":"that pool has a disk type (ssd/sas/nl_sas and mix),"},{"line_number":12,"context_line":"manila driver should report that pool disk type."},{"line_number":13,"context_line":"This BP provide this ability."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_31e57508","line":11,"range":{"start_line":10,"start_character":35,"end_line":11,"end_character":25},"in_reply_to":"9abb7d3a_ce33a812","updated":"2016-06-02 04:06:54.000000000","message":"Done","commit_id":"8c797b7a1a8746e6b03862c89e4fe20e1d9ade87"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"6e21f8bce01d945cd015622d91a973bb8a815db9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adding support for pool report disk type in huawei"},{"line_number":10,"context_line":"manila driver. When creating share need appointing"},{"line_number":11,"context_line":"that pool has a disk type (ssd/sas/nl_sas and mix),"},{"line_number":12,"context_line":"manila driver should report that pool disk type."},{"line_number":13,"context_line":"This BP provide this ability."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1f694e8c93f79851f838d226830d9ab5344cf35a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_0e11305d","line":12,"range":{"start_line":12,"start_character":14,"end_line":12,"end_character":47},"updated":"2016-06-02 03:52:06.000000000","message":"will report disk type of the pools.","commit_id":"8c797b7a1a8746e6b03862c89e4fe20e1d9ade87"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"4c131d1c7f94264e357d11734958b71279f99fbf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adding support for pool report disk type in huawei"},{"line_number":10,"context_line":"manila driver. When creating share need appointing"},{"line_number":11,"context_line":"that pool has a disk type (ssd/sas/nl_sas and mix),"},{"line_number":12,"context_line":"manila driver should report that pool disk type."},{"line_number":13,"context_line":"This BP provide this ability."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1f694e8c93f79851f838d226830d9ab5344cf35a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_71eb7ddc","line":12,"range":{"start_line":12,"start_character":14,"end_line":12,"end_character":47},"in_reply_to":"9abb7d3a_0e11305d","updated":"2016-06-02 04:06:54.000000000","message":"Done","commit_id":"8c797b7a1a8746e6b03862c89e4fe20e1d9ade87"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"6e21f8bce01d945cd015622d91a973bb8a815db9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"manila driver. When creating share need appointing"},{"line_number":11,"context_line":"that pool has a disk type (ssd/sas/nl_sas and mix),"},{"line_number":12,"context_line":"manila driver should report that pool disk type."},{"line_number":13,"context_line":"This BP provide this ability."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1f694e8c93f79851f838d226830d9ab5344cf35a"},{"line_number":16,"context_line":"Implements: blueprint huawei-pool-disktype-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_0eb5b07c","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":15},"updated":"2016-06-02 03:52:06.000000000","message":"provides","commit_id":"8c797b7a1a8746e6b03862c89e4fe20e1d9ade87"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"4c131d1c7f94264e357d11734958b71279f99fbf","unresolved":false,"context_lines":[{"line_number":10,"context_line":"manila driver. When creating share need appointing"},{"line_number":11,"context_line":"that pool has a disk type (ssd/sas/nl_sas and mix),"},{"line_number":12,"context_line":"manila driver should report that pool disk type."},{"line_number":13,"context_line":"This BP provide this ability."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1f694e8c93f79851f838d226830d9ab5344cf35a"},{"line_number":16,"context_line":"Implements: blueprint huawei-pool-disktype-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_d1bce9dd","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":15},"in_reply_to":"9abb7d3a_0eb5b07c","updated":"2016-06-02 04:06:54.000000000","message":"Done","commit_id":"8c797b7a1a8746e6b03862c89e4fe20e1d9ade87"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe5bf79ae655196bead6312bc4cf28016f17e88e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adding support for reporting disk type of pool in huawei manila"},{"line_number":10,"context_line":"driver. When creating share we can specify the disk type of the"},{"line_number":11,"context_line":"pool we want to use ssd/sas/nl_sas/mix, manila driver will report"},{"line_number":12,"context_line":"the disk type of the pools. This BP provides this ability."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint huawei-pool-disktype-support"},{"line_number":15,"context_line":"Change-Id: I1f694e8c93f79851f838d226830d9ab5344cf35a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1aa78d24_468785d7","line":12,"range":{"start_line":12,"start_character":28,"end_line":12,"end_character":58},"updated":"2016-07-08 10:17:22.000000000","message":"Better to remove it.","commit_id":"08a07055c2d96fc12dd80afdcc63d8bc61eeb690"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"cb9a91ca0eaaae50d82e04b17bf2919333bfdfc4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adding support for reporting disk type of pool in huawei manila"},{"line_number":10,"context_line":"driver. When creating share we can specify the disk type of the"},{"line_number":11,"context_line":"pool we want to use ssd/sas/nl_sas/mix, manila driver will report"},{"line_number":12,"context_line":"the disk type of the pools. This BP provides this ability."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint huawei-pool-disktype-support"},{"line_number":15,"context_line":"Change-Id: I1f694e8c93f79851f838d226830d9ab5344cf35a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"dada55a8_5213c55c","line":12,"range":{"start_line":12,"start_character":28,"end_line":12,"end_character":58},"in_reply_to":"1aa78d24_468785d7","updated":"2016-07-18 01:44:00.000000000","message":"Done","commit_id":"08a07055c2d96fc12dd80afdcc63d8bc61eeb690"}],"doc/source/devref/huawei_nas_driver.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8c47ea04a49398e8d1847870fae77bc0557e586","unresolved":false,"context_lines":[{"line_number":152,"context_line":"For the Huawei driver, this must be set to False."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Manila requires that the share type includes the `huawei_disk_type` extra-spec."},{"line_number":155,"context_line":"This ensures that the share will be created on a backend that supports the "},{"line_number":156,"context_line":"requested disk_type capability. the share will be created on a backend with a "},{"line_number":157,"context_line":"matching disk_type."},{"line_number":158,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3aaa91ec_068f8475","line":155,"range":{"start_line":155,"start_character":74,"end_line":155,"end_character":75},"updated":"2016-06-30 17:11:26.000000000","message":"Please fix trailing white space, here and below.","commit_id":"fa7d1c13abddef2a34216708771fff1dadd522ba"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"5ef7c332488af5b2588e5a21e300122508f3af91","unresolved":false,"context_lines":[{"line_number":152,"context_line":"For the Huawei driver, this must be set to False."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Manila requires that the share type includes the `huawei_disk_type` extra-spec."},{"line_number":155,"context_line":"This ensures that the share will be created on a backend that supports the "},{"line_number":156,"context_line":"requested disk_type capability. the share will be created on a backend with a "},{"line_number":157,"context_line":"matching disk_type."},{"line_number":158,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3aaa91ec_de49b161","line":155,"range":{"start_line":155,"start_character":74,"end_line":155,"end_character":75},"in_reply_to":"3aaa91ec_068f8475","updated":"2016-07-01 01:20:49.000000000","message":"Done\nThank you for your opinion","commit_id":"fa7d1c13abddef2a34216708771fff1dadd522ba"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"25779ff6253a49d173a3404690c2d1a9198aca89","unresolved":false,"context_lines":[{"line_number":151,"context_line":"supports the requested driver_handles_share_servers (share networks) capability."},{"line_number":152,"context_line":"For the Huawei driver, this must be set to False."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Manila requires that the share type includes the `huawei_disk_type` extra-spec."},{"line_number":155,"context_line":"This ensures that the share will be created on a backend that supports the"},{"line_number":156,"context_line":"requested disk_type capability. The share will be created on a backend with a"},{"line_number":157,"context_line":"matching disk_type."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1aa78d24_fa3b4ccf","line":154,"range":{"start_line":154,"start_character":7,"end_line":154,"end_character":15},"updated":"2016-07-05 16:00:40.000000000","message":"It is not required. It is optional.","commit_id":"23854f98a4b8e3d3a9dcc618790250549e143373"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"401a00be218b430f2dc54117db3c858e5d4aafd6","unresolved":false,"context_lines":[{"line_number":151,"context_line":"supports the requested driver_handles_share_servers (share networks) capability."},{"line_number":152,"context_line":"For the Huawei driver, this must be set to False."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Manila requires that the share type includes the `huawei_disk_type` extra-spec."},{"line_number":155,"context_line":"This ensures that the share will be created on a backend that supports the"},{"line_number":156,"context_line":"requested disk_type capability. The share will be created on a backend with a"},{"line_number":157,"context_line":"matching disk_type."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1aa78d24_99f02c00","line":154,"range":{"start_line":154,"start_character":7,"end_line":154,"end_character":15},"in_reply_to":"1aa78d24_d0e9fae7","updated":"2016-07-06 10:32:38.000000000","message":"Done\nThank you for your opinion.","commit_id":"23854f98a4b8e3d3a9dcc618790250549e143373"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"54c7479aedc273df0e6be7c312f5d02f0bb2d970","unresolved":false,"context_lines":[{"line_number":151,"context_line":"supports the requested driver_handles_share_servers (share networks) capability."},{"line_number":152,"context_line":"For the Huawei driver, this must be set to False."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Manila requires that the share type includes the `huawei_disk_type` extra-spec."},{"line_number":155,"context_line":"This ensures that the share will be created on a backend that supports the"},{"line_number":156,"context_line":"requested disk_type capability. The share will be created on a backend with a"},{"line_number":157,"context_line":"matching disk_type."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1aa78d24_d0e9fae7","line":154,"range":{"start_line":154,"start_character":7,"end_line":154,"end_character":15},"in_reply_to":"1aa78d24_fa3b4ccf","updated":"2016-07-06 02:42:57.000000000","message":"+1","commit_id":"23854f98a4b8e3d3a9dcc618790250549e143373"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"54c7479aedc273df0e6be7c312f5d02f0bb2d970","unresolved":false,"context_lines":[{"line_number":206,"context_line":"  * qos:maxbandwidth\u003d100"},{"line_number":207,"context_line":"  * qos:minbandwidth\u003d10"},{"line_number":208,"context_line":"  * qos:latency\u003d10"},{"line_number":209,"context_line":"  * qos:iotype\u003d0"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"`thin_provisioning` will be reported as [True, False] for Huawei backends."},{"line_number":212,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1aa78d24_90ae527f","line":209,"range":{"start_line":209,"start_character":16,"end_line":209,"end_character":16},"updated":"2016-07-06 02:42:57.000000000","message":"We need to add the description about how to choose the pool by disk type and which value is effective in disk type. \nsuch as: \n\"- huawei_disk_type\u003d\u0027ssd\u0027  \u0027sas\u0027 \u0027nl_sas\u0027 or \u0027mix\u0027\"\n`huawei_disk_type` will be reported as \"ssd\", \"sas\" \"nl_sas\" or \"mix\" for Huawei backends.","commit_id":"23854f98a4b8e3d3a9dcc618790250549e143373"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"401a00be218b430f2dc54117db3c858e5d4aafd6","unresolved":false,"context_lines":[{"line_number":206,"context_line":"  * qos:maxbandwidth\u003d100"},{"line_number":207,"context_line":"  * qos:minbandwidth\u003d10"},{"line_number":208,"context_line":"  * qos:latency\u003d10"},{"line_number":209,"context_line":"  * qos:iotype\u003d0"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"`thin_provisioning` will be reported as [True, False] for Huawei backends."},{"line_number":212,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1aa78d24_f9c850aa","line":209,"range":{"start_line":209,"start_character":16,"end_line":209,"end_character":16},"in_reply_to":"1aa78d24_90ae527f","updated":"2016-07-06 10:32:38.000000000","message":"Done.\nThank you for your opinion.","commit_id":"23854f98a4b8e3d3a9dcc618790250549e143373"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e6f97ce0a4a10b35758c4a540b89e37e17c9e4b5","unresolved":false,"context_lines":[{"line_number":207,"context_line":"  * qos:minbandwidth\u003d10"},{"line_number":208,"context_line":"  * qos:latency\u003d10"},{"line_number":209,"context_line":"  * qos:iotype\u003d0"},{"line_number":210,"context_line":" "},{"line_number":211,"context_line":" - huawei_disk_type\u003d\u0027ssd\u0027 or \u0027sas\u0027 or \u0027nl_sas\u0027 or \u0027mix\u0027"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"`thin_provisioning` will be reported as [True, False] for Huawei backends."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1aa78d24_22a55846","line":210,"range":{"start_line":210,"start_character":0,"end_line":210,"end_character":1},"updated":"2016-07-07 01:19:27.000000000","message":"remove space","commit_id":"30ab9369b4521af59b889715b86ae451cf784aae"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"ebb0a15ccddd9e2a1c651f8bb460dade775f716e","unresolved":false,"context_lines":[{"line_number":207,"context_line":"  * qos:minbandwidth\u003d10"},{"line_number":208,"context_line":"  * qos:latency\u003d10"},{"line_number":209,"context_line":"  * qos:iotype\u003d0"},{"line_number":210,"context_line":" "},{"line_number":211,"context_line":" - huawei_disk_type\u003d\u0027ssd\u0027 or \u0027sas\u0027 or \u0027nl_sas\u0027 or \u0027mix\u0027"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"`thin_provisioning` will be reported as [True, False] for Huawei backends."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1aa78d24_cddc8548","line":210,"range":{"start_line":210,"start_character":0,"end_line":210,"end_character":1},"in_reply_to":"1aa78d24_22a55846","updated":"2016-07-07 01:35:04.000000000","message":"Done","commit_id":"30ab9369b4521af59b889715b86ae451cf784aae"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"99955ffae4bdd1f302f1f1772490dc0c255063c8","unresolved":false,"context_lines":[{"line_number":151,"context_line":"supports the requested driver_handles_share_servers (share networks) capability."},{"line_number":152,"context_line":"For the Huawei driver, this must be set to False."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"When the manila need to support disk type of pool. Manila requires that the"},{"line_number":155,"context_line":"share type includes the `huawei_disk_type` extra-spec. This ensures that the"},{"line_number":156,"context_line":"share will be created on a backend that supports the requested disk_type"},{"line_number":157,"context_line":"capability. The share will be created on a backend with a matching disk_type."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Another common manila extra-spec used to determine where a share is created"},{"line_number":160,"context_line":"is `share_backend_name`. When this extra-spec is defined in the share type,"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_4806c320","line":157,"range":{"start_line":154,"start_character":0,"end_line":157,"end_character":77},"updated":"2016-07-07 02:25:05.000000000","message":"This is kinda confusing. I suggest rewording this:\n\n\n  To create a share on a backend with a specific type of disks, include\n  the ``huawei_disk_type`` extra-spec in the share type. Valid values\n  for this extra-spec are \u0027ssd\u0027, \u0027sas\u0027, \u0027nl_sas\u0027 or \u0027mix\u0027.","commit_id":"f722e6b64458042f013416d446c3ea74a139d698"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"dbd81dc61e4ea66cb23d09ea39166c858db331b1","unresolved":false,"context_lines":[{"line_number":151,"context_line":"supports the requested driver_handles_share_servers (share networks) capability."},{"line_number":152,"context_line":"For the Huawei driver, this must be set to False."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"When the manila need to support disk type of pool. Manila requires that the"},{"line_number":155,"context_line":"share type includes the `huawei_disk_type` extra-spec. This ensures that the"},{"line_number":156,"context_line":"share will be created on a backend that supports the requested disk_type"},{"line_number":157,"context_line":"capability. The share will be created on a backend with a matching disk_type."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Another common manila extra-spec used to determine where a share is created"},{"line_number":160,"context_line":"is `share_backend_name`. When this extra-spec is defined in the share type,"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_d257fdc7","line":157,"range":{"start_line":154,"start_character":0,"end_line":157,"end_character":77},"in_reply_to":"1aa78d24_4806c320","updated":"2016-07-07 03:43:32.000000000","message":"Done","commit_id":"f722e6b64458042f013416d446c3ea74a139d698"}],"manila/share/drivers/huawei/v3/connection.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6cc5fc9bf3423546a79e49eba446a451d5a647ec","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        for pool_name in pool_name_list:"},{"line_number":281,"context_line":"            pool_name \u003d pool_name.strip().strip(\u0027\\n\u0027)"},{"line_number":282,"context_line":"            capacity \u003d self._get_capacity(pool_name, all_pool_info)"},{"line_number":283,"context_line":"            disk_type \u003d self._get_disk_type(pool_name, all_pool_info)"},{"line_number":284,"context_line":"            if capacity:"},{"line_number":285,"context_line":"                pool \u003d dict("},{"line_number":286,"context_line":"                    pool_name\u003dpool_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_4aa4a907","line":283,"range":{"start_line":283,"start_character":12,"end_line":283,"end_character":69},"updated":"2016-06-02 13:11:11.000000000","message":"since you don\u0027t use this unless capacity is set, you could move to inside the if condition below","commit_id":"9f2ed3855e0640f695b652256ed68921b334a2e9"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"7e1cb69a7639f38b70661916accff2738ad60d58","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        for pool_name in pool_name_list:"},{"line_number":281,"context_line":"            pool_name \u003d pool_name.strip().strip(\u0027\\n\u0027)"},{"line_number":282,"context_line":"            capacity \u003d self._get_capacity(pool_name, all_pool_info)"},{"line_number":283,"context_line":"            disk_type \u003d self._get_disk_type(pool_name, all_pool_info)"},{"line_number":284,"context_line":"            if capacity:"},{"line_number":285,"context_line":"                pool \u003d dict("},{"line_number":286,"context_line":"                    pool_name\u003dpool_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_bcd0daca","line":283,"range":{"start_line":283,"start_character":12,"end_line":283,"end_character":69},"in_reply_to":"9abb7d3a_4aa4a907","updated":"2016-06-03 02:13:10.000000000","message":"Thank you for your opinions.\nThe disk_type is dynamic report,  if this disk_type return None, the disk_type will not be reported . So, the disk_type is separated treatment.\nI am Liuke, not Liucheng.","commit_id":"9f2ed3855e0640f695b652256ed68921b334a2e9"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"7d81ccd1affd38e4f601266ae409d58ec53cf4b0","unresolved":false,"context_lines":[{"line_number":612,"context_line":"            return None"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        pool_disk \u003d []"},{"line_number":615,"context_line":"        if pool_info[\u0027TIER0CAPACITY\u0027] !\u003d \u00270\u0027:"},{"line_number":616,"context_line":"            pool_disk.append(\u0027ssd\u0027)"},{"line_number":617,"context_line":"        if pool_info[\u0027TIER1CAPACITY\u0027] !\u003d \u00270\u0027:"},{"line_number":618,"context_line":"            pool_disk.append(\u0027sas\u0027)"},{"line_number":619,"context_line":"        if pool_info[\u0027TIER2CAPACITY\u0027] !\u003d \u00270\u0027:"},{"line_number":620,"context_line":"            pool_disk.append(\u0027nl_sas\u0027)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        if len(pool_disk) \u003e 1:"},{"line_number":623,"context_line":"            pool_disk \u003d [\u0027mix\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_7df18c94","line":620,"range":{"start_line":615,"start_character":8,"end_line":620,"end_character":38},"updated":"2016-06-02 06:42:32.000000000","message":"I think this could be rewritten as\n\n  for i, x in enumerate([\u0027ssd\u0027, \u0027sas\u0027, \u0027nl_sas\u0027]):\n      if pool_info[\u0027TIER%dCAPACITY\u0027] % i !\u003d \u00270\u0027:\n          pool_disk.append(x)","commit_id":"9f2ed3855e0640f695b652256ed68921b334a2e9"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"7e1cb69a7639f38b70661916accff2738ad60d58","unresolved":false,"context_lines":[{"line_number":612,"context_line":"            return None"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        pool_disk \u003d []"},{"line_number":615,"context_line":"        if pool_info[\u0027TIER0CAPACITY\u0027] !\u003d \u00270\u0027:"},{"line_number":616,"context_line":"            pool_disk.append(\u0027ssd\u0027)"},{"line_number":617,"context_line":"        if pool_info[\u0027TIER1CAPACITY\u0027] !\u003d \u00270\u0027:"},{"line_number":618,"context_line":"            pool_disk.append(\u0027sas\u0027)"},{"line_number":619,"context_line":"        if pool_info[\u0027TIER2CAPACITY\u0027] !\u003d \u00270\u0027:"},{"line_number":620,"context_line":"            pool_disk.append(\u0027nl_sas\u0027)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        if len(pool_disk) \u003e 1:"},{"line_number":623,"context_line":"            pool_disk \u003d [\u0027mix\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_b3016507","line":620,"range":{"start_line":615,"start_character":8,"end_line":620,"end_character":38},"in_reply_to":"9abb7d3a_7df18c94","updated":"2016-06-03 02:13:10.000000000","message":"Done\nThank you for your opinion","commit_id":"9f2ed3855e0640f695b652256ed68921b334a2e9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"832e705f4b453026b22e87f8a2f8a08bbe3edafe","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                    huawei_smartpartition\u003d[True, False],"},{"line_number":304,"context_line":"                )"},{"line_number":305,"context_line":"                if disk_type:"},{"line_number":306,"context_line":"                    pool[\u0027disk_type\u0027] \u003d disk_type"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"                stats_dict[\"pools\"].append(pool)"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_225321e3","line":306,"range":{"start_line":306,"start_character":26,"end_line":306,"end_character":35},"updated":"2016-06-22 13:23:28.000000000","message":"this should be \"huawei_disk_type\"...","commit_id":"5b668f8b2a0cf265f5a1c3e1a8f2040773933698"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"c2f9c81501db844c92218dadcd7b18129e1d2c16","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                    huawei_smartpartition\u003d[True, False],"},{"line_number":304,"context_line":"                )"},{"line_number":305,"context_line":"                if disk_type:"},{"line_number":306,"context_line":"                    pool[\u0027disk_type\u0027] \u003d disk_type"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"                stats_dict[\"pools\"].append(pool)"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_7654ab20","line":306,"range":{"start_line":306,"start_character":26,"end_line":306,"end_character":35},"in_reply_to":"3aaa91ec_225321e3","updated":"2016-06-23 01:08:35.000000000","message":"Thank you for your opinion.\nThis disk_type is generic reporting of pool, it is not to be used alone for Huawei.","commit_id":"5b668f8b2a0cf265f5a1c3e1a8f2040773933698"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"e7cf304485c2fc36af91cd8c3b83d77a1b6b1fd1","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                    huawei_smartpartition\u003d[True, False],"},{"line_number":304,"context_line":"                )"},{"line_number":305,"context_line":"                if disk_type:"},{"line_number":306,"context_line":"                    pool[\u0027disk_type\u0027] \u003d disk_type"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"                stats_dict[\"pools\"].append(pool)"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_604e8c70","line":306,"range":{"start_line":306,"start_character":26,"end_line":306,"end_character":35},"in_reply_to":"3aaa91ec_5169b9bd","updated":"2016-06-30 05:04:37.000000000","message":"Done","commit_id":"5b668f8b2a0cf265f5a1c3e1a8f2040773933698"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4cd3c0bad3fbdbe0fe218aeb632e0840787e5bec","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                    huawei_smartpartition\u003d[True, False],"},{"line_number":304,"context_line":"                )"},{"line_number":305,"context_line":"                if disk_type:"},{"line_number":306,"context_line":"                    pool[\u0027disk_type\u0027] \u003d disk_type"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"                stats_dict[\"pools\"].append(pool)"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_5169b9bd","line":306,"range":{"start_line":306,"start_character":26,"end_line":306,"end_character":35},"in_reply_to":"3aaa91ec_7654ab20","updated":"2016-06-23 01:11:36.000000000","message":"It\u0027s not a common capability as far as i\u0027m aware:\n\nhttp://docs.openstack.org/developer/manila/devref/capabilities_and_extra_specs.html#common-capabilities\n\nfwiw, the netapp driver supports disk_types too, we report this capability as \"netapp_disk_type\"","commit_id":"5b668f8b2a0cf265f5a1c3e1a8f2040773933698"}],"manila/tests/share/drivers/huawei/test_huawei_nas.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"42b823f452437b7f6b8e4c100c69b05725485d19","unresolved":false,"context_lines":[{"line_number":2174,"context_line":"        self.driver._update_share_stats()"},{"line_number":2175,"context_line":""},{"line_number":2176,"context_line":"        self.assertEqual(\u0027ssd\u0027, self.driver._stats[\u0027pools\u0027][0][\u0027disk_type\u0027])"},{"line_number":2177,"context_line":""},{"line_number":2178,"context_line":"    def test_get_share_stats_disk_type_sas(self):"},{"line_number":2179,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":2180,"context_line":"        storage_pool_info \u003d {\"error\": {\"code\": 0},"},{"line_number":2181,"context_line":"                             \"data\": [{\"USERFREECAPACITY\": \"2097152\","},{"line_number":2182,"context_line":"                                       \"ID\": \"1\","},{"line_number":2183,"context_line":"                                       \"NAME\": \"OpenStack_Pool\","},{"line_number":2184,"context_line":"                                       \"USERTOTALCAPACITY\": \"4194304\","},{"line_number":2185,"context_line":"                                       \"USAGETYPE\": \"2\","},{"line_number":2186,"context_line":"                                       \"USERCONSUMEDCAPACITY\": \"2097152\","},{"line_number":2187,"context_line":"                                       \"TIER0CAPACITY\": \"0\","},{"line_number":2188,"context_line":"                                       \"TIER1CAPACITY\": \"100\","},{"line_number":2189,"context_line":"                                       \"TIER2CAPACITY\": \"0\"}]}"},{"line_number":2190,"context_line":"        self.mock_object(self.driver.plugin.helper, \u0027_find_all_pool_info\u0027,"},{"line_number":2191,"context_line":"                         mock.Mock(return_value\u003dstorage_pool_info))"},{"line_number":2192,"context_line":"        self.driver._update_share_stats()"},{"line_number":2193,"context_line":""},{"line_number":2194,"context_line":"        self.assertEqual(\u0027sas\u0027, self.driver._stats[\u0027pools\u0027][0][\u0027disk_type\u0027])"},{"line_number":2195,"context_line":""},{"line_number":2196,"context_line":"    def test_get_share_stats_disk_type_nl_sas(self):"},{"line_number":2197,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":2198,"context_line":"        storage_pool_info \u003d {\"error\": {\"code\": 0},"},{"line_number":2199,"context_line":"                             \"data\": [{\"USERFREECAPACITY\": \"2097152\","},{"line_number":2200,"context_line":"                                       \"ID\": \"1\","},{"line_number":2201,"context_line":"                                       \"NAME\": \"OpenStack_Pool\","},{"line_number":2202,"context_line":"                                       \"USERTOTALCAPACITY\": \"4194304\","},{"line_number":2203,"context_line":"                                       \"USAGETYPE\": \"2\","},{"line_number":2204,"context_line":"                                       \"USERCONSUMEDCAPACITY\": \"2097152\","},{"line_number":2205,"context_line":"                                       \"TIER0CAPACITY\": \"0\","},{"line_number":2206,"context_line":"                                       \"TIER1CAPACITY\": \"0\","},{"line_number":2207,"context_line":"                                       \"TIER2CAPACITY\": \"100\"}]}"},{"line_number":2208,"context_line":"        self.mock_object(self.driver.plugin.helper, \u0027_find_all_pool_info\u0027,"},{"line_number":2209,"context_line":"                         mock.Mock(return_value\u003dstorage_pool_info))"},{"line_number":2210,"context_line":"        self.driver._update_share_stats()"},{"line_number":2211,"context_line":""},{"line_number":2212,"context_line":"        self.assertEqual(\u0027nl_sas\u0027, self.driver._stats[\u0027pools\u0027][0][\u0027disk_type\u0027])"},{"line_number":2213,"context_line":""},{"line_number":2214,"context_line":"    def test_get_share_stats_disk_type_mix(self):"},{"line_number":2215,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":2216,"context_line":"        storage_pool_info \u003d {\"error\": {\"code\": 0},"},{"line_number":2217,"context_line":"                             \"data\": [{\"USERFREECAPACITY\": \"2097152\","},{"line_number":2218,"context_line":"                                       \"ID\": \"1\","},{"line_number":2219,"context_line":"                                       \"NAME\": \"OpenStack_Pool\","},{"line_number":2220,"context_line":"                                       \"USERTOTALCAPACITY\": \"4194304\","},{"line_number":2221,"context_line":"                                       \"USAGETYPE\": \"2\","},{"line_number":2222,"context_line":"                                       \"USERCONSUMEDCAPACITY\": \"2097152\","},{"line_number":2223,"context_line":"                                       \"TIER0CAPACITY\": \"100\","},{"line_number":2224,"context_line":"                                       \"TIER1CAPACITY\": \"100\","},{"line_number":2225,"context_line":"                                       \"TIER2CAPACITY\": \"100\"}]}"},{"line_number":2226,"context_line":"        self.mock_object(self.driver.plugin.helper, \u0027_find_all_pool_info\u0027,"},{"line_number":2227,"context_line":"                         mock.Mock(return_value\u003dstorage_pool_info))"},{"line_number":2228,"context_line":"        self.driver._update_share_stats()"},{"line_number":2229,"context_line":""},{"line_number":2230,"context_line":"        self.assertEqual(\u0027mix\u0027, self.driver._stats[\u0027pools\u0027][0][\u0027disk_type\u0027])"},{"line_number":2231,"context_line":""},{"line_number":2232,"context_line":"    def test_get_share_stats_disk_type_none(self):"},{"line_number":2233,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":2234,"context_line":"        storage_pool_info \u003d {\"error\": {\"code\": 0},"},{"line_number":2235,"context_line":"                             \"data\": [{\"USERFREECAPACITY\": \"2097152\","},{"line_number":2236,"context_line":"                                       \"ID\": \"1\","},{"line_number":2237,"context_line":"                                       \"NAME\": \"OpenStack_Pool\","},{"line_number":2238,"context_line":"                                       \"USERTOTALCAPACITY\": \"4194304\","},{"line_number":2239,"context_line":"                                       \"USAGETYPE\": \"2\","},{"line_number":2240,"context_line":"                                       \"USERCONSUMEDCAPACITY\": \"2097152\","},{"line_number":2241,"context_line":"                                       \"TIER0CAPACITY\": \"0\","},{"line_number":2242,"context_line":"                                       \"TIER1CAPACITY\": \"0\","},{"line_number":2243,"context_line":"                                       \"TIER2CAPACITY\": \"0\"}]}"},{"line_number":2244,"context_line":"        self.mock_object(self.driver.plugin.helper, \u0027_find_all_pool_info\u0027,"},{"line_number":2245,"context_line":"                         mock.Mock(return_value\u003dstorage_pool_info))"},{"line_number":2246,"context_line":"        self.driver._update_share_stats()"},{"line_number":2247,"context_line":""},{"line_number":2248,"context_line":"        self.assertIsNone(self.driver._stats[\u0027pools\u0027][0].get(\u0027disk_type\u0027))"},{"line_number":2249,"context_line":""},{"line_number":2250,"context_line":"    def test_allow_access_proto_fail(self):"},{"line_number":2251,"context_line":"        self.driver.plugin.helper.login()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_bddf740b","line":2248,"range":{"start_line":2177,"start_character":0,"end_line":2248,"end_character":74},"updated":"2016-06-02 06:47:18.000000000","message":"I\u0027d like to see you use DDT in these tests.","commit_id":"9f2ed3855e0640f695b652256ed68921b334a2e9"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"7e1cb69a7639f38b70661916accff2738ad60d58","unresolved":false,"context_lines":[{"line_number":2174,"context_line":"        self.driver._update_share_stats()"},{"line_number":2175,"context_line":""},{"line_number":2176,"context_line":"        self.assertEqual(\u0027ssd\u0027, self.driver._stats[\u0027pools\u0027][0][\u0027disk_type\u0027])"},{"line_number":2177,"context_line":""},{"line_number":2178,"context_line":"    def test_get_share_stats_disk_type_sas(self):"},{"line_number":2179,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":2180,"context_line":"        storage_pool_info \u003d {\"error\": {\"code\": 0},"},{"line_number":2181,"context_line":"                             \"data\": [{\"USERFREECAPACITY\": \"2097152\","},{"line_number":2182,"context_line":"                                       \"ID\": \"1\","},{"line_number":2183,"context_line":"                                       \"NAME\": \"OpenStack_Pool\","},{"line_number":2184,"context_line":"                                       \"USERTOTALCAPACITY\": \"4194304\","},{"line_number":2185,"context_line":"                                       \"USAGETYPE\": \"2\","},{"line_number":2186,"context_line":"                                       \"USERCONSUMEDCAPACITY\": \"2097152\","},{"line_number":2187,"context_line":"                                       \"TIER0CAPACITY\": \"0\","},{"line_number":2188,"context_line":"                                       \"TIER1CAPACITY\": \"100\","},{"line_number":2189,"context_line":"                                       \"TIER2CAPACITY\": \"0\"}]}"},{"line_number":2190,"context_line":"        self.mock_object(self.driver.plugin.helper, \u0027_find_all_pool_info\u0027,"},{"line_number":2191,"context_line":"                         mock.Mock(return_value\u003dstorage_pool_info))"},{"line_number":2192,"context_line":"        self.driver._update_share_stats()"},{"line_number":2193,"context_line":""},{"line_number":2194,"context_line":"        self.assertEqual(\u0027sas\u0027, self.driver._stats[\u0027pools\u0027][0][\u0027disk_type\u0027])"},{"line_number":2195,"context_line":""},{"line_number":2196,"context_line":"    def test_get_share_stats_disk_type_nl_sas(self):"},{"line_number":2197,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":2198,"context_line":"        storage_pool_info \u003d {\"error\": {\"code\": 0},"},{"line_number":2199,"context_line":"                             \"data\": [{\"USERFREECAPACITY\": \"2097152\","},{"line_number":2200,"context_line":"                                       \"ID\": \"1\","},{"line_number":2201,"context_line":"                                       \"NAME\": \"OpenStack_Pool\","},{"line_number":2202,"context_line":"                                       \"USERTOTALCAPACITY\": \"4194304\","},{"line_number":2203,"context_line":"                                       \"USAGETYPE\": \"2\","},{"line_number":2204,"context_line":"                                       \"USERCONSUMEDCAPACITY\": \"2097152\","},{"line_number":2205,"context_line":"                                       \"TIER0CAPACITY\": \"0\","},{"line_number":2206,"context_line":"                                       \"TIER1CAPACITY\": \"0\","},{"line_number":2207,"context_line":"                                       \"TIER2CAPACITY\": \"100\"}]}"},{"line_number":2208,"context_line":"        self.mock_object(self.driver.plugin.helper, \u0027_find_all_pool_info\u0027,"},{"line_number":2209,"context_line":"                         mock.Mock(return_value\u003dstorage_pool_info))"},{"line_number":2210,"context_line":"        self.driver._update_share_stats()"},{"line_number":2211,"context_line":""},{"line_number":2212,"context_line":"        self.assertEqual(\u0027nl_sas\u0027, self.driver._stats[\u0027pools\u0027][0][\u0027disk_type\u0027])"},{"line_number":2213,"context_line":""},{"line_number":2214,"context_line":"    def test_get_share_stats_disk_type_mix(self):"},{"line_number":2215,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":2216,"context_line":"        storage_pool_info \u003d {\"error\": {\"code\": 0},"},{"line_number":2217,"context_line":"                             \"data\": [{\"USERFREECAPACITY\": \"2097152\","},{"line_number":2218,"context_line":"                                       \"ID\": \"1\","},{"line_number":2219,"context_line":"                                       \"NAME\": \"OpenStack_Pool\","},{"line_number":2220,"context_line":"                                       \"USERTOTALCAPACITY\": \"4194304\","},{"line_number":2221,"context_line":"                                       \"USAGETYPE\": \"2\","},{"line_number":2222,"context_line":"                                       \"USERCONSUMEDCAPACITY\": \"2097152\","},{"line_number":2223,"context_line":"                                       \"TIER0CAPACITY\": \"100\","},{"line_number":2224,"context_line":"                                       \"TIER1CAPACITY\": \"100\","},{"line_number":2225,"context_line":"                                       \"TIER2CAPACITY\": \"100\"}]}"},{"line_number":2226,"context_line":"        self.mock_object(self.driver.plugin.helper, \u0027_find_all_pool_info\u0027,"},{"line_number":2227,"context_line":"                         mock.Mock(return_value\u003dstorage_pool_info))"},{"line_number":2228,"context_line":"        self.driver._update_share_stats()"},{"line_number":2229,"context_line":""},{"line_number":2230,"context_line":"        self.assertEqual(\u0027mix\u0027, self.driver._stats[\u0027pools\u0027][0][\u0027disk_type\u0027])"},{"line_number":2231,"context_line":""},{"line_number":2232,"context_line":"    def test_get_share_stats_disk_type_none(self):"},{"line_number":2233,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":2234,"context_line":"        storage_pool_info \u003d {\"error\": {\"code\": 0},"},{"line_number":2235,"context_line":"                             \"data\": [{\"USERFREECAPACITY\": \"2097152\","},{"line_number":2236,"context_line":"                                       \"ID\": \"1\","},{"line_number":2237,"context_line":"                                       \"NAME\": \"OpenStack_Pool\","},{"line_number":2238,"context_line":"                                       \"USERTOTALCAPACITY\": \"4194304\","},{"line_number":2239,"context_line":"                                       \"USAGETYPE\": \"2\","},{"line_number":2240,"context_line":"                                       \"USERCONSUMEDCAPACITY\": \"2097152\","},{"line_number":2241,"context_line":"                                       \"TIER0CAPACITY\": \"0\","},{"line_number":2242,"context_line":"                                       \"TIER1CAPACITY\": \"0\","},{"line_number":2243,"context_line":"                                       \"TIER2CAPACITY\": \"0\"}]}"},{"line_number":2244,"context_line":"        self.mock_object(self.driver.plugin.helper, \u0027_find_all_pool_info\u0027,"},{"line_number":2245,"context_line":"                         mock.Mock(return_value\u003dstorage_pool_info))"},{"line_number":2246,"context_line":"        self.driver._update_share_stats()"},{"line_number":2247,"context_line":""},{"line_number":2248,"context_line":"        self.assertIsNone(self.driver._stats[\u0027pools\u0027][0].get(\u0027disk_type\u0027))"},{"line_number":2249,"context_line":""},{"line_number":2250,"context_line":"    def test_allow_access_proto_fail(self):"},{"line_number":2251,"context_line":"        self.driver.plugin.helper.login()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_dcfe7e37","line":2248,"range":{"start_line":2177,"start_character":0,"end_line":2248,"end_character":74},"in_reply_to":"9abb7d3a_bddf740b","updated":"2016-06-03 02:13:10.000000000","message":"Done\nThank you for your opinion","commit_id":"9f2ed3855e0640f695b652256ed68921b334a2e9"}],"releasenotes/notes/huawei-pool-disktype-support-0a52ba5d44da55f9.yaml":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3e883aadd2c64a1adde4fb8fc09b5ed7075d2699","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---\r"},{"line_number":2,"context_line":"features:\r"},{"line_number":3,"context_line":"  - Add support for reporting pool disk type in Huawei driver.\r"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"dada55a8_6f46177c","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":62},"updated":"2016-07-21 11:39:55.000000000","message":"Please, add info about extra spec name and maybe values.","commit_id":"e25eb4b15d53d38483847af332b0984a22ab4ef8"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"b32f576d0011bc5ec2532df0e4689b1ba281288b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---\r"},{"line_number":2,"context_line":"features:\r"},{"line_number":3,"context_line":"  - Add support for reporting pool disk type in Huawei driver.\r"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"dada55a8_92aa9483","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":62},"in_reply_to":"dada55a8_6f46177c","updated":"2016-07-22 01:33:48.000000000","message":"Done","commit_id":"e25eb4b15d53d38483847af332b0984a22ab4ef8"}]}
