)]}'
{"manila/api/common.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"8e458f7a528f7bbea8d3ab2110d452c6502af2e3","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            method \u003d getattr(self, method_name)"},{"line_number":275,"context_line":"            if request.api_version_request.matches_versioned_method(method):"},{"line_number":276,"context_line":"                request_context \u003d request.environ[\u0027manila.context\u0027]"},{"line_number":277,"context_line":"                method.func(self, request_context, resource_dict, resource)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    @classmethod"},{"line_number":280,"context_line":"    def versioned_method(cls, min_ver, max_ver\u003dNone, experimental\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_5fcfad28","line":277,"range":{"start_line":277,"start_character":16,"end_line":277,"end_character":27},"updated":"2016-06-08 09:04:49.000000000","message":"Just thinking: Wouldn\u0027t it be better to add a property (like self.context) to ViewBuilder and simply set the property before calling the function? With that we don\u0027t need to change all function signatures.","commit_id":"2051579c2cc3138c31d92ca703a01bc81968e3c0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8dcded17cc37056caa385ca59b46ede7b9aaa3e9","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            method \u003d getattr(self, method_name)"},{"line_number":275,"context_line":"            if request.api_version_request.matches_versioned_method(method):"},{"line_number":276,"context_line":"                request_context \u003d request.environ[\u0027manila.context\u0027]"},{"line_number":277,"context_line":"                method.func(self, request_context, resource_dict, resource)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    @classmethod"},{"line_number":280,"context_line":"    def versioned_method(cls, min_ver, max_ver\u003dNone, experimental\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_8b85455b","line":277,"range":{"start_line":277,"start_character":16,"end_line":277,"end_character":27},"in_reply_to":"7aa08908_5fcfad28","updated":"2016-06-08 13:11:22.000000000","message":"That\u0027s one way too.. but we\u0027d have to rely on adding it to the class every time we need to make a decision based off context..","commit_id":"2051579c2cc3138c31d92ca703a01bc81968e3c0"}],"manila/tests/api/test_common.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1dd55d596b434aeff934c11d470fb5ec5d0eab53","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            \u0027xyzzy\u0027: \u0027qwerty\u0027,"},{"line_number":260,"context_line":"        }"},{"line_number":261,"context_line":"        self.fake_resource \u003d db_fakes.FakeModel(self.expected_resource_dict)"},{"line_number":262,"context_line":"        self.view_builder \u003d fakes.FakeResourceViewBuilder()"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @ddt.data(\u00271.0\u0027, \u00271.40\u0027)"},{"line_number":265,"context_line":"    def test_versioned_method_no_updates(self, version):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_97d62aef","line":262,"range":{"start_line":262,"start_character":59,"end_line":262,"end_character":59},"updated":"2016-06-08 06:55:14.000000000","message":"The tests (version between 1.41 and 1.6) is absent.","commit_id":"2051579c2cc3138c31d92ca703a01bc81968e3c0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8dcded17cc37056caa385ca59b46ede7b9aaa3e9","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            \u0027xyzzy\u0027: \u0027qwerty\u0027,"},{"line_number":260,"context_line":"        }"},{"line_number":261,"context_line":"        self.fake_resource \u003d db_fakes.FakeModel(self.expected_resource_dict)"},{"line_number":262,"context_line":"        self.view_builder \u003d fakes.FakeResourceViewBuilder()"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @ddt.data(\u00271.0\u0027, \u00271.40\u0027)"},{"line_number":265,"context_line":"    def test_versioned_method_no_updates(self, version):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_0b3e75c0","line":262,"range":{"start_line":262,"start_character":59,"end_line":262,"end_character":59},"in_reply_to":"7aa08908_97d62aef","updated":"2016-06-08 13:11:22.000000000","message":"I wanted to test: a) no match, b) match, but add fields for admin c) all micro versions..","commit_id":"2051579c2cc3138c31d92ca703a01bc81968e3c0"}]}