)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"049ab8849431d34eddadbac57a82cba555e5a2e7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If manage fails there shouldn\u0027t be any issue to simply remove it."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Trivial-Fix"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If3c85b39efb132413caf3c8e84f38fc4c1d75c4a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_3ebae7c0","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":11},"updated":"2016-06-07 12:09:48.000000000","message":"Why trivial fix? It is change of API behavior. Also, would be great to cover it with negative tempest test.","commit_id":"39bc0def796f0b336e88ad9e1176505a36f0a255"}],"manila/share/api.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cedf7e1c50d09d22e7551346cc7fd10455b1359f","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        share_id \u003d share[\u0027id\u0027]"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        statuses \u003d (constants.STATUS_AVAILABLE, constants.STATUS_ERROR,"},{"line_number":684,"context_line":"                    constants.STATUS_INACTIVE, constants.STATUS_MANAGE_ERROR)"},{"line_number":685,"context_line":"        if not (force or share[\u0027status\u0027] in statuses):"},{"line_number":686,"context_line":"            msg \u003d _(\"Share status must be one of %(statuses)s\") % {"},{"line_number":687,"context_line":"                \"statuses\": statuses}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_9adfd5d5","line":684,"range":{"start_line":684,"start_character":45,"end_line":684,"end_character":76},"updated":"2016-06-16 10:07:27.000000000","message":"It can and should be covered in unit tests updating one single line in [1].\n\n[1] https://github.com/openstack/manila/blob/348fde02/manila/tests/share/test_api.py#L1378","commit_id":"3bda6a7906d46a49ed232733ff659740c3051243"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"509528fc9f39ad8333fc5c4d8762bcc4f340a33e","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        share_id \u003d share[\u0027id\u0027]"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        statuses \u003d (constants.STATUS_AVAILABLE, constants.STATUS_ERROR,"},{"line_number":684,"context_line":"                    constants.STATUS_INACTIVE, constants.STATUS_MANAGE_ERROR)"},{"line_number":685,"context_line":"        if not (force or share[\u0027status\u0027] in statuses):"},{"line_number":686,"context_line":"            msg \u003d _(\"Share status must be one of %(statuses)s\") % {"},{"line_number":687,"context_line":"                \"statuses\": statuses}"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_8a300709","line":684,"range":{"start_line":684,"start_character":47,"end_line":684,"end_character":76},"updated":"2016-06-16 17:35:12.000000000","message":"A share can only get in MANAGE_ERROR state due to an admin action, so why would we allow a user to unroll that?  I\u0027m not convinced this is a good idea.","commit_id":"0a82a9f9b2fb4e25b6602290f25006dc42541706"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2e324e8b679d12f03faea54b6afbf09fd7440fe1","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        share_id \u003d share[\u0027id\u0027]"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        statuses \u003d (constants.STATUS_AVAILABLE, constants.STATUS_ERROR,"},{"line_number":684,"context_line":"                    constants.STATUS_INACTIVE, constants.STATUS_MANAGE_ERROR)"},{"line_number":685,"context_line":"        if not (force or share[\u0027status\u0027] in statuses):"},{"line_number":686,"context_line":"            msg \u003d _(\"Share status must be one of %(statuses)s\") % {"},{"line_number":687,"context_line":"                \"statuses\": statuses}"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_6af03b67","line":684,"range":{"start_line":684,"start_character":20,"end_line":684,"end_character":45},"updated":"2016-06-16 17:33:11.000000000","message":"How can this state be reached? If a share is inactive, this seems like a bug..","commit_id":"0a82a9f9b2fb4e25b6602290f25006dc42541706"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ea4ec176e84e881e2c12e9e4d8dc742d7d36b6f1","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        share_id \u003d share[\u0027id\u0027]"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        statuses \u003d (constants.STATUS_AVAILABLE, constants.STATUS_ERROR,"},{"line_number":684,"context_line":"                    constants.STATUS_INACTIVE, constants.STATUS_MANAGE_ERROR)"},{"line_number":685,"context_line":"        if not (force or share[\u0027status\u0027] in statuses):"},{"line_number":686,"context_line":"            msg \u003d _(\"Share status must be one of %(statuses)s\") % {"},{"line_number":687,"context_line":"                \"statuses\": statuses}"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_5e309307","line":684,"range":{"start_line":684,"start_character":47,"end_line":684,"end_character":76},"in_reply_to":"7aa08908_8a300709","updated":"2016-06-17 02:06:56.000000000","message":"+1.  If admin fails to manage an existing share, it does not mean a tenant should just delete the share from the backend.\n\nWe already have a \"force_delete\" that the admin can use to delete a share in manage_error status.","commit_id":"0a82a9f9b2fb4e25b6602290f25006dc42541706"}],"releasenotes/notes/bug_1591889_delete_manage_error-e543a26aa1507f11.yaml":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f55787b3bb30915a0f82cb3c6fca6adf755e1947","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - share is state \"manage_error\" can be removed directly"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7aa08908_49a55445","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":57},"updated":"2016-06-13 12:56:13.000000000","message":"It could be removed with \"force-delete\". So, it is incorrect statement. It should mention exactly \"delete\" command.","commit_id":"32bbf2477a3d169ace9b60725cf2f367954e1822"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"82a6288e7809fe52ce126e98e2030632847655cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - share is state \"manage_error\" can be removed directly"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7aa08908_b6bd376a","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":5},"updated":"2016-06-13 12:52:19.000000000","message":"Uppercase","commit_id":"32bbf2477a3d169ace9b60725cf2f367954e1822"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"82a6288e7809fe52ce126e98e2030632847655cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - share is state \"manage_error\" can be removed directly"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7aa08908_6975b0f8","line":3,"range":{"start_line":3,"start_character":56,"end_line":3,"end_character":57},"updated":"2016-06-13 12:52:19.000000000","message":"period","commit_id":"32bbf2477a3d169ace9b60725cf2f367954e1822"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"82a6288e7809fe52ce126e98e2030632847655cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - share is state \"manage_error\" can be removed directly"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7aa08908_d6b8c377","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":12},"updated":"2016-06-13 12:52:19.000000000","message":"s/is/in","commit_id":"32bbf2477a3d169ace9b60725cf2f367954e1822"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"90e9cd3005aa25f5a8474653a4bd4c5f1e3c071b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Share in state \"manage_error\" can be removed directly with \"delete\"."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7aa08908_f04ef56c","line":3,"range":{"start_line":3,"start_character":34,"end_line":3,"end_character":40},"updated":"2016-06-16 11:31:11.000000000","message":"since this entry is in the section \"fixes\", it becomes ambiguous to me if you fixed the behavior you are stating, or if you are stating the new behavior. I would s/\"can be\"/\"can now be\" just to be safe","commit_id":"514f71ef68d593986466616ea7a58b692f6de6ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"49d2e2f58e869efedd8cdf3ef8b8713650001b6f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Share in state \"manage_error\" can now be removed directly with \"delete\"."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7aa08908_8a3647b2","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":76},"updated":"2016-06-16 17:29:37.000000000","message":"Users should not be able to delete shares in manage_error. \n\nImagine this case:\n\n   -\u003e call to manage issued to share driver\n\n   -\u003e driver stores the share_id and backend ID in driver private storage.. (some drivers do this)\n\n   -\u003e something goes wrong here... probably something weird at the driver layer \n\n   -\u003e The share-manager sets the share to manage_error\n\n   -\u003e administrator/user comes along and deletes this share\n\n   -\u003e the call goes to the driver and, the share is deleted from the backend?\n\n\nIs this expected behavior?","commit_id":"0a82a9f9b2fb4e25b6602290f25006dc42541706"}]}
