)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6dc66f2ba79de5de9ebd9595ff0971950255c9fb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In module netaddr valid_ipv4/valid_ipv6 raise exception"},{"line_number":10,"context_line":"AddrFormatError if address is specified as empty string."},{"line_number":11,"context_line":"Methods is_valid_ipv4/is_valid_ipv6 catch the exception"},{"line_number":12,"context_line":"and return boolean value. So we\u0027d better use them form"},{"line_number":13,"context_line":"oslo.utils."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If58889bb322686c252b4fe89a4ddf9469121028c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_06915547","line":12,"range":{"start_line":12,"start_character":50,"end_line":12,"end_character":54},"updated":"2016-06-08 11:05:33.000000000","message":"/form/from/","commit_id":"3f27b9efaeb1cce9c927d0dfad25193a02e6546d"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"355a704043935fa3bcd2d1f6d0a14fb45bb2aef9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In module netaddr valid_ipv4/valid_ipv6 raise exception"},{"line_number":10,"context_line":"AddrFormatError if address is specified as empty string."},{"line_number":11,"context_line":"Methods is_valid_ipv4/is_valid_ipv6 catch the exception"},{"line_number":12,"context_line":"and return boolean value. So we\u0027d better use them form"},{"line_number":13,"context_line":"oslo.utils."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If58889bb322686c252b4fe89a4ddf9469121028c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_91c26c51","line":12,"range":{"start_line":12,"start_character":50,"end_line":12,"end_character":54},"in_reply_to":"7aa08908_06915547","updated":"2016-06-09 04:37:56.000000000","message":"Done","commit_id":"3f27b9efaeb1cce9c927d0dfad25193a02e6546d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"056be793484d92be1dfec9c0d53a82ecb6aee4a1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use is_valid_ipv4 and is_valid_ipv6 from oslo.utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In module netaddr valid_ipv4/valid_ipv6 raise exception"},{"line_number":10,"context_line":"AddrFormatError if address is specified as empty string."},{"line_number":11,"context_line":"Methods is_valid_ipv4/is_valid_ipv6 catch the exception"},{"line_number":12,"context_line":"and return boolean value. So we\u0027d better use them from"},{"line_number":13,"context_line":"oslo.utils."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_1d22ff01","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":56},"updated":"2016-06-09 11:27:32.000000000","message":"I cannot reproduce it. It returns boolean for me. Also, we have appropriate unit tests that prove absence of an exception. See https://github.com/openstack/manila/blob/5dfbef4f/manila/tests/test_utils.py#L664","commit_id":"48c80a6138c4e833770b7f4067f1f611812d84fa"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"80545e6dfd7e5f3e723955c92938fdba7f75df83","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use is_valid_ipv4 and is_valid_ipv6 from oslo.utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In module netaddr valid_ipv4/valid_ipv6 raise exception"},{"line_number":10,"context_line":"AddrFormatError if address is specified as empty string."},{"line_number":11,"context_line":"Methods is_valid_ipv4/is_valid_ipv6 catch the exception"},{"line_number":12,"context_line":"and return boolean value. So we\u0027d better use them from"},{"line_number":13,"context_line":"oslo.utils."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_a8d3a75e","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":56},"in_reply_to":"7aa08908_1d22ff01","updated":"2016-06-09 11:37:58.000000000","message":"I can reproduce this locally.\n\nHere is the case for netaddr:\n\u003e\u003e\u003e import netaddr\n\u003e\u003e\u003e netaddr.valid_ipv4(\u0027\u0027)\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  File \"/usr/local/lib/python2.7/site-packages/netaddr/strategy/ipv4.py\", line 92, in valid_str\n    raise AddrFormatError(\u0027Empty strings are not supported!\u0027)\nnetaddr.core.AddrFormatError: Empty strings are not supported!\n\nHere is the case for oslo.utils:\n\u003e\u003e\u003e from oslo_utils import netutils\n\u003e\u003e\u003e netutils.is_valid_ipv4(\u0027\u0027)\nFalse\n\nAlso, the unit test does not check for empty strings, so it does not apply to the problem fixed in this patch.","commit_id":"48c80a6138c4e833770b7f4067f1f611812d84fa"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"60afcdbb829462c20c94d47196d9dcb62f73ae51","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use is_valid_ipv4 and is_valid_ipv6 from oslo.utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In module netaddr valid_ipv4/valid_ipv6 raise exception"},{"line_number":10,"context_line":"AddrFormatError if address is specified as empty string."},{"line_number":11,"context_line":"Methods is_valid_ipv4/is_valid_ipv6 catch the exception"},{"line_number":12,"context_line":"and return boolean value. So we\u0027d better use them from"},{"line_number":13,"context_line":"oslo.utils."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_e8b76ff3","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":56},"in_reply_to":"7aa08908_a8d3a75e","updated":"2016-06-09 11:41:20.000000000","message":"Hm, right, exactly empty string does cause exception and such case is absent in unit tests. So, it should be added for changed code.","commit_id":"48c80a6138c4e833770b7f4067f1f611812d84fa"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"41303a1079fec505c1c58141f2b5bab87160c94a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use is_valid_ipv4 and is_valid_ipv6 from oslo.utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In module netaddr valid_ipv4/valid_ipv6 raise exception"},{"line_number":10,"context_line":"AddrFormatError if address is specified as empty string."},{"line_number":11,"context_line":"Methods is_valid_ipv4/is_valid_ipv6 catch the exception"},{"line_number":12,"context_line":"and return boolean value. So we\u0027d better use them from"},{"line_number":13,"context_line":"oslo.utils."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_28c69749","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":56},"in_reply_to":"7aa08908_e8b76ff3","updated":"2016-06-09 11:45:02.000000000","message":"Thats a good point, would be great to cover this case in unit tests.","commit_id":"48c80a6138c4e833770b7f4067f1f611812d84fa"}]}