)]}'
{"manila/share/drivers/zfssa/zfssarest.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8e20cf3eeb2258fc7a1165afb02708fc7cb31c68","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                                \u0027ret.status\u0027: ret.status,"},{"line_number":410,"context_line":"                                \u0027ret.data\u0027: ret.data})"},{"line_number":411,"context_line":"            LOG.error(exception_msg)"},{"line_number":412,"context_line":"            raise exception.ShareBackendAPIException(msg\u003dexception_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_02aea584","line":412,"range":{"start_line":412,"start_character":28,"end_line":412,"end_character":52},"updated":"2016-06-12 02:53:01.000000000","message":"The ShareBackendAPIException is not exist in Manila. please add it or change it to another.","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f1b31b525ebc53a36eb6d2cabc9bd442ebac3e59","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                                \u0027ret.status\u0027: ret.status,"},{"line_number":410,"context_line":"                                \u0027ret.data\u0027: ret.data})"},{"line_number":411,"context_line":"            LOG.error(exception_msg)"},{"line_number":412,"context_line":"            raise exception.ShareBackendAPIException(msg\u003dexception_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_678e777a","line":412,"range":{"start_line":412,"start_character":28,"end_line":412,"end_character":52},"in_reply_to":"7aa08908_02aea584","updated":"2016-06-13 14:19:23.000000000","message":"+1","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"60ca74dbe97c04ab34eba71fd6e77581d42e5873","unresolved":false,"context_lines":[{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    def create_schema(self, schema):"},{"line_number":391,"context_line":"        \"\"\"Create a custom ZFSSA schema.\"\"\""},{"line_number":392,"context_line":"        base \u003d \u0027/api/storage/v1/schema\u0027"},{"line_number":393,"context_line":"        svc \u003d \"%(base)s/%(prop)s\" % {\u0027base\u0027: base, \u0027prop\u0027: schema[\u0027property\u0027]}"},{"line_number":394,"context_line":"        ret \u003d self.rclient.get(svc)"},{"line_number":395,"context_line":"        if ret.status \u003d\u003d restclient.Status.OK:"},{"line_number":396,"context_line":"            LOG.warning(_LW(\u0027Property %s already exists.\u0027), schema[\u0027property\u0027])"},{"line_number":397,"context_line":"            return"},{"line_number":398,"context_line":"        ret \u003d self.rclient.post(base, schema)"},{"line_number":399,"context_line":"        if ret.status !\u003d restclient.Status.CREATED:"},{"line_number":400,"context_line":"            exception_msg \u003d (_(\u0027Error Creating \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_3f7de11c","line":397,"range":{"start_line":392,"start_character":0,"end_line":397,"end_character":18},"updated":"2016-06-22 20:33:04.000000000","message":"Not covered with unit test:\n\nhttp://logs.openstack.org/97/327897/5/check/manila-coverage-db/7cc7310/cover/manila_share_drivers_zfssa_zfssarest_py.html#n392","commit_id":"5cff1a7db68cd1b97643e39bd207d2688c11404b"}],"manila/share/drivers/zfssa/zfssashare.py":[{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"220140b695eb6419ee0f0660981d52b282ab29d7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_0ad25700","side":"PARENT","line":4,"updated":"2016-06-10 18:47:00.000000000","message":"j","commit_id":"3dfc4dcb2fc6bc708abe7e25ebc0feee8f72804d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f1b31b525ebc53a36eb6d2cabc9bd442ebac3e59","unresolved":false,"context_lines":[{"line_number":60,"context_line":"               help\u003d\u0027REST connection timeout (in seconds).\u0027),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027zfssa_manage_policy\u0027, default\u003d\u0027loose\u0027,"},{"line_number":62,"context_line":"               choices\u003d[\u0027loose\u0027, \u0027strict\u0027],"},{"line_number":63,"context_line":"               help\u003d\u0027Driver policy for share manage.\u0027)"},{"line_number":64,"context_line":"]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"cfg.CONF.register_opts(ZFSSA_OPTS)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_27df4f6a","line":63,"range":{"start_line":63,"start_character":21,"end_line":63,"end_character":52},"updated":"2016-06-13 14:19:23.000000000","message":"Can you please add more details about variants.","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"2c47f11bb978f7e2a9f179c70ce6918a045430e0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"               help\u003d\u0027REST connection timeout (in seconds).\u0027),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027zfssa_manage_policy\u0027, default\u003d\u0027loose\u0027,"},{"line_number":62,"context_line":"               choices\u003d[\u0027loose\u0027, \u0027strict\u0027],"},{"line_number":63,"context_line":"               help\u003d\u0027Driver policy for share manage.\u0027)"},{"line_number":64,"context_line":"]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"cfg.CONF.register_opts(ZFSSA_OPTS)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_e6cca28c","line":63,"range":{"start_line":63,"start_character":21,"end_line":63,"end_character":52},"in_reply_to":"7aa08908_27df4f6a","updated":"2016-06-20 17:32:29.000000000","message":"Done","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f1b31b525ebc53a36eb6d2cabc9bd442ebac3e59","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                LOG.error(exception_msg)"},{"line_number":109,"context_line":"                raise exception.InvalidParameterValue(exception_msg)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        if lcfg.zfssa_manage_policy not in (\"loose\", \"strict\"):"},{"line_number":112,"context_line":"            err_msg \u003d (_(\"zfssa_manage_policy property needs to be set to \""},{"line_number":113,"context_line":"                         \"\u0027strict\u0027 or \u0027loose\u0027. Current value is: %s.\")"},{"line_number":114,"context_line":"                       % lcfg.zfssa_manage_policy)"},{"line_number":115,"context_line":"            LOG.error(err_msg)"},{"line_number":116,"context_line":"            raise exception.InvalidInput(reason\u003derr_msg)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        self.default_args \u003d {"},{"line_number":119,"context_line":"            \u0027compression\u0027: lcfg.zfssa_nas_compression,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_e73ee789","line":116,"range":{"start_line":111,"start_character":8,"end_line":116,"end_character":56},"updated":"2016-06-13 14:19:23.000000000","message":"Line 62 covers this check.","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"2c47f11bb978f7e2a9f179c70ce6918a045430e0","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                LOG.error(exception_msg)"},{"line_number":109,"context_line":"                raise exception.InvalidParameterValue(exception_msg)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        if lcfg.zfssa_manage_policy not in (\"loose\", \"strict\"):"},{"line_number":112,"context_line":"            err_msg \u003d (_(\"zfssa_manage_policy property needs to be set to \""},{"line_number":113,"context_line":"                         \"\u0027strict\u0027 or \u0027loose\u0027. Current value is: %s.\")"},{"line_number":114,"context_line":"                       % lcfg.zfssa_manage_policy)"},{"line_number":115,"context_line":"            LOG.error(err_msg)"},{"line_number":116,"context_line":"            raise exception.InvalidInput(reason\u003derr_msg)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        self.default_args \u003d {"},{"line_number":119,"context_line":"            \u0027compression\u0027: lcfg.zfssa_nas_compression,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_c6c9a67b","line":116,"range":{"start_line":111,"start_character":8,"end_line":116,"end_character":56},"in_reply_to":"7aa08908_e73ee789","updated":"2016-06-20 17:32:29.000000000","message":"Done","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":17742,"name":"liucheng","email":"liucheng20@huawei.com","username":"liucheng"},"change_message_id":"e10eb1671f341017e1c4b517161f772539bb31e7","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        and returns the correct share size and export location."},{"line_number":299,"context_line":"        \"\"\""},{"line_number":300,"context_line":"        if \u0027zfssa_name\u0027 not in driver_options:"},{"line_number":301,"context_line":"            msg \u003d _(\u0027Name of the share in ZFSSA share has to be \u0027"},{"line_number":302,"context_line":"                    \u0027specified in option zfssa_name\u0027)"},{"line_number":303,"context_line":"            LOG.error(msg)"},{"line_number":304,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":305,"context_line":"        name \u003d driver_options[\u0027zfssa_name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_b5f9cdca","line":302,"range":{"start_line":301,"start_character":0,"end_line":302,"end_character":53},"updated":"2016-06-12 03:23:39.000000000","message":"Please add punctuation marks.","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"2c47f11bb978f7e2a9f179c70ce6918a045430e0","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        and returns the correct share size and export location."},{"line_number":299,"context_line":"        \"\"\""},{"line_number":300,"context_line":"        if \u0027zfssa_name\u0027 not in driver_options:"},{"line_number":301,"context_line":"            msg \u003d _(\u0027Name of the share in ZFSSA share has to be \u0027"},{"line_number":302,"context_line":"                    \u0027specified in option zfssa_name\u0027)"},{"line_number":303,"context_line":"            LOG.error(msg)"},{"line_number":304,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":305,"context_line":"        name \u003d driver_options[\u0027zfssa_name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_86ae7e96","line":302,"range":{"start_line":301,"start_character":0,"end_line":302,"end_character":53},"in_reply_to":"7aa08908_b5f9cdca","updated":"2016-06-20 17:32:29.000000000","message":"Done","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"220140b695eb6419ee0f0660981d52b282ab29d7","unresolved":false,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        # Get and verify share size:"},{"line_number":319,"context_line":"        size_byte \u003d details[\u0027quota\u0027]"},{"line_number":320,"context_line":"        size_gb \u003d int(size_byte / units.Gi)"},{"line_number":321,"context_line":"        if size_byte % units.Gi !\u003d 0:"},{"line_number":322,"context_line":"            # Round up the size:"},{"line_number":323,"context_line":"            new_size_gb \u003d size_gb + 1"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_eacc2b63","line":320,"updated":"2016-06-10 18:47:00.000000000","message":"this could go as int(math.ceil(size_byte / float(units.Gi))). This will round up the size without the need for the module check.","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"2c47f11bb978f7e2a9f179c70ce6918a045430e0","unresolved":false,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        # Get and verify share size:"},{"line_number":319,"context_line":"        size_byte \u003d details[\u0027quota\u0027]"},{"line_number":320,"context_line":"        size_gb \u003d int(size_byte / units.Gi)"},{"line_number":321,"context_line":"        if size_byte % units.Gi !\u003d 0:"},{"line_number":322,"context_line":"            # Round up the size:"},{"line_number":323,"context_line":"            new_size_gb \u003d size_gb + 1"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_46077681","line":320,"in_reply_to":"7aa08908_eacc2b63","updated":"2016-06-20 17:32:29.000000000","message":"Done","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8e20cf3eeb2258fc7a1165afb02708fc7cb31c68","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        # Get and verify share size:"},{"line_number":319,"context_line":"        size_byte \u003d details[\u0027quota\u0027]"},{"line_number":320,"context_line":"        size_gb \u003d int(size_byte / units.Gi)"},{"line_number":321,"context_line":"        if size_byte % units.Gi !\u003d 0:"},{"line_number":322,"context_line":"            # Round up the size:"},{"line_number":323,"context_line":"            new_size_gb \u003d size_gb + 1"},{"line_number":324,"context_line":"            new_size_byte \u003d new_size_gb * units.Gi"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_a284f1b0","line":321,"range":{"start_line":321,"start_character":8,"end_line":321,"end_character":37},"updated":"2016-06-12 02:53:01.000000000","message":"Why use \u0027%\u0027, and not use \u0027/\u0027? If size_byte is equal to  4Gi, we not need to check whether the space is enough in the backend?","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"2c47f11bb978f7e2a9f179c70ce6918a045430e0","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        # Get and verify share size:"},{"line_number":319,"context_line":"        size_byte \u003d details[\u0027quota\u0027]"},{"line_number":320,"context_line":"        size_gb \u003d int(size_byte / units.Gi)"},{"line_number":321,"context_line":"        if size_byte % units.Gi !\u003d 0:"},{"line_number":322,"context_line":"            # Round up the size:"},{"line_number":323,"context_line":"            new_size_gb \u003d size_gb + 1"},{"line_number":324,"context_line":"            new_size_byte \u003d new_size_gb * units.Gi"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_e624a20f","line":321,"range":{"start_line":321,"start_character":8,"end_line":321,"end_character":37},"in_reply_to":"7aa08908_a284f1b0","updated":"2016-06-20 17:32:29.000000000","message":"If size_byte is already equals to a whole GB, there is no need to check whether space is enough in the backend, as there is no rounding up happening. So I\u0027m using % instead of /.","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ea5f8009dda45a71f642482ccd7d0d62188d2129","unresolved":false,"context_lines":[{"line_number":330,"context_line":"            if diff_space \u003e free_space:"},{"line_number":331,"context_line":"                msg \u003d (_(\u0027Quota and reservation of share %(name)s need to be \u0027"},{"line_number":332,"context_line":"                         \u0027rounded up to %(size)d. But there is not enough \u0027"},{"line_number":333,"context_line":"                         \u0027space in the backend. \u0027) % {\u0027name\u0027: name,"},{"line_number":334,"context_line":"                                                      \u0027size\u0027: new_size_gb})"},{"line_number":335,"context_line":"                LOG.error(msg)"},{"line_number":336,"context_line":"                raise exception.ManageInvalidShare(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_d1944238","line":333,"range":{"start_line":333,"start_character":47,"end_line":333,"end_character":48},"updated":"2016-06-13 16:33:34.000000000","message":"extra space","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"2c47f11bb978f7e2a9f179c70ce6918a045430e0","unresolved":false,"context_lines":[{"line_number":330,"context_line":"            if diff_space \u003e free_space:"},{"line_number":331,"context_line":"                msg \u003d (_(\u0027Quota and reservation of share %(name)s need to be \u0027"},{"line_number":332,"context_line":"                         \u0027rounded up to %(size)d. But there is not enough \u0027"},{"line_number":333,"context_line":"                         \u0027space in the backend. \u0027) % {\u0027name\u0027: name,"},{"line_number":334,"context_line":"                                                      \u0027size\u0027: new_size_gb})"},{"line_number":335,"context_line":"                LOG.error(msg)"},{"line_number":336,"context_line":"                raise exception.ManageInvalidShare(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_061c4ec0","line":333,"range":{"start_line":333,"start_character":47,"end_line":333,"end_character":48},"in_reply_to":"7aa08908_d1944238","updated":"2016-06-20 17:32:29.000000000","message":"Done","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ea5f8009dda45a71f642482ccd7d0d62188d2129","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        self.zfssa.modify_share(lcfg.zfssa_pool, lcfg.zfssa_project,"},{"line_number":367,"context_line":"                                name, manage_args)"},{"line_number":368,"context_line":"        return {\u0027size\u0027: int(size_gb),"},{"line_number":369,"context_line":"                \u0027export_locations\u0027: export_loc}"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def _verify_share_to_manage(self, name, details):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_91ec7abc","line":368,"range":{"start_line":368,"start_character":24,"end_line":368,"end_character":36},"updated":"2016-06-13 16:33:34.000000000","message":"int() again?","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"2c47f11bb978f7e2a9f179c70ce6918a045430e0","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        self.zfssa.modify_share(lcfg.zfssa_pool, lcfg.zfssa_project,"},{"line_number":367,"context_line":"                                name, manage_args)"},{"line_number":368,"context_line":"        return {\u0027size\u0027: int(size_gb),"},{"line_number":369,"context_line":"                \u0027export_locations\u0027: export_loc}"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def _verify_share_to_manage(self, name, details):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_2676aa06","line":368,"range":{"start_line":368,"start_character":24,"end_line":368,"end_character":36},"in_reply_to":"7aa08908_91ec7abc","updated":"2016-06-20 17:32:29.000000000","message":"Done","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ea5f8009dda45a71f642482ccd7d0d62188d2129","unresolved":false,"context_lines":[{"line_number":393,"context_line":"    def unmanage(self, share):"},{"line_number":394,"context_line":"        \"\"\"Removes the specified share from Manila management."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        This task involves only changing the custom:manila_managed"},{"line_number":397,"context_line":"        property to False. Current accesses to the share will be removed in"},{"line_number":398,"context_line":"        ZFSSA, as they are removed in Manila."},{"line_number":399,"context_line":"        \"\"\""},{"line_number":400,"context_line":"        name \u003d share[\u0027id\u0027]"},{"line_number":401,"context_line":"        lcfg \u003d self.configuration"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_91291a9e","line":398,"range":{"start_line":396,"start_character":8,"end_line":398,"end_character":45},"updated":"2016-06-13 16:33:34.000000000","message":"share must still exist in backend and be accessible, this is not supposed to do the same as \"delete\".","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"2c47f11bb978f7e2a9f179c70ce6918a045430e0","unresolved":false,"context_lines":[{"line_number":393,"context_line":"    def unmanage(self, share):"},{"line_number":394,"context_line":"        \"\"\"Removes the specified share from Manila management."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        This task involves only changing the custom:manila_managed"},{"line_number":397,"context_line":"        property to False. Current accesses to the share will be removed in"},{"line_number":398,"context_line":"        ZFSSA, as they are removed in Manila."},{"line_number":399,"context_line":"        \"\"\""},{"line_number":400,"context_line":"        name \u003d share[\u0027id\u0027]"},{"line_number":401,"context_line":"        lcfg \u003d self.configuration"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_06e1ee9a","line":398,"range":{"start_line":396,"start_character":8,"end_line":398,"end_character":45},"in_reply_to":"7aa08908_91291a9e","updated":"2016-06-20 17:32:29.000000000","message":"I think the wording is misleading, I meant that only the share accesses are deleted, not the share itself. I\u0027ve fixed it in the new patchset.","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ea5f8009dda45a71f642482ccd7d0d62188d2129","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        details \u003d self._get_share_details(name)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        if (managed not in details) or (details[managed] is not True):"},{"line_number":406,"context_line":"            msg \u003d (_(\"Share %s cannot is not being managed by the current \""},{"line_number":407,"context_line":"                     \"Manila instance.\") % name)"},{"line_number":408,"context_line":"            LOG.error(msg)"},{"line_number":409,"context_line":"            raise exception.UnmanageInvalidShare(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_dc2bb980","line":406,"range":{"start_line":406,"start_character":31,"end_line":406,"end_character":44},"updated":"2016-06-13 16:33:34.000000000","message":"wrong wording, use either \"cannot be managed\" or \"is not being managed\"","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"2c47f11bb978f7e2a9f179c70ce6918a045430e0","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        details \u003d self._get_share_details(name)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        if (managed not in details) or (details[managed] is not True):"},{"line_number":406,"context_line":"            msg \u003d (_(\"Share %s cannot is not being managed by the current \""},{"line_number":407,"context_line":"                     \"Manila instance.\") % name)"},{"line_number":408,"context_line":"            LOG.error(msg)"},{"line_number":409,"context_line":"            raise exception.UnmanageInvalidShare(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_e68782b4","line":406,"range":{"start_line":406,"start_character":31,"end_line":406,"end_character":44},"in_reply_to":"7aa08908_dc2bb980","updated":"2016-06-20 17:32:29.000000000","message":"Done","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8e20cf3eeb2258fc7a1165afb02708fc7cb31c68","unresolved":false,"context_lines":[{"line_number":409,"context_line":"            raise exception.UnmanageInvalidShare(reason\u003dmsg)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        arg \u003d {\u0027custom:manila_managed\u0027: False}"},{"line_number":412,"context_line":"        if share[\u0027share_proto\u0027] \u003d\u003d \u0027NFS\u0027:"},{"line_number":413,"context_line":"            arg.update({\u0027sharenfs\u0027: \u0027off\u0027})"},{"line_number":414,"context_line":"        elif share[\u0027share_proto\u0027] \u003d\u003d \u0027CIFS\u0027:"},{"line_number":415,"context_line":"            arg.update({\u0027sharesmb\u0027: \u0027off\u0027})"},{"line_number":416,"context_line":"        self.zfssa.modify_share(lcfg.zfssa_pool, lcfg.zfssa_project, name, arg)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    def _get_share_details(self, name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_e201d907","line":415,"range":{"start_line":412,"start_character":8,"end_line":415,"end_character":43},"updated":"2016-06-12 02:53:01.000000000","message":"How about else?","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"2c47f11bb978f7e2a9f179c70ce6918a045430e0","unresolved":false,"context_lines":[{"line_number":409,"context_line":"            raise exception.UnmanageInvalidShare(reason\u003dmsg)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        arg \u003d {\u0027custom:manila_managed\u0027: False}"},{"line_number":412,"context_line":"        if share[\u0027share_proto\u0027] \u003d\u003d \u0027NFS\u0027:"},{"line_number":413,"context_line":"            arg.update({\u0027sharenfs\u0027: \u0027off\u0027})"},{"line_number":414,"context_line":"        elif share[\u0027share_proto\u0027] \u003d\u003d \u0027CIFS\u0027:"},{"line_number":415,"context_line":"            arg.update({\u0027sharesmb\u0027: \u0027off\u0027})"},{"line_number":416,"context_line":"        self.zfssa.modify_share(lcfg.zfssa_pool, lcfg.zfssa_project, name, arg)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    def _get_share_details(self, name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_06028e0b","line":415,"range":{"start_line":412,"start_character":8,"end_line":415,"end_character":43},"in_reply_to":"7aa08908_1d6f062c","updated":"2016-06-20 17:32:29.000000000","message":"Done","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f1b31b525ebc53a36eb6d2cabc9bd442ebac3e59","unresolved":false,"context_lines":[{"line_number":409,"context_line":"            raise exception.UnmanageInvalidShare(reason\u003dmsg)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        arg \u003d {\u0027custom:manila_managed\u0027: False}"},{"line_number":412,"context_line":"        if share[\u0027share_proto\u0027] \u003d\u003d \u0027NFS\u0027:"},{"line_number":413,"context_line":"            arg.update({\u0027sharenfs\u0027: \u0027off\u0027})"},{"line_number":414,"context_line":"        elif share[\u0027share_proto\u0027] \u003d\u003d \u0027CIFS\u0027:"},{"line_number":415,"context_line":"            arg.update({\u0027sharesmb\u0027: \u0027off\u0027})"},{"line_number":416,"context_line":"        self.zfssa.modify_share(lcfg.zfssa_pool, lcfg.zfssa_project, name, arg)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    def _get_share_details(self, name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_1d6f062c","line":415,"range":{"start_line":412,"start_character":8,"end_line":415,"end_character":43},"in_reply_to":"7aa08908_e201d907","updated":"2016-06-13 14:19:23.000000000","message":"Right, better to log something here, if not raise exception.","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ea5f8009dda45a71f642482ccd7d0d62188d2129","unresolved":false,"context_lines":[{"line_number":421,"context_line":"                                       lcfg.zfssa_project,"},{"line_number":422,"context_line":"                                       name)"},{"line_number":423,"context_line":"        if not details:"},{"line_number":424,"context_line":"            msg \u003d (_(\"Share %s doesn\u0027t exists.\") % name)"},{"line_number":425,"context_line":"            raise exception.ManilaException(msg)"},{"line_number":426,"context_line":"        return details"},{"line_number":427,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_710d8e3d","line":424,"range":{"start_line":424,"start_character":39,"end_line":424,"end_character":45},"updated":"2016-06-13 16:33:34.000000000","message":"s/exists/exist","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"2c47f11bb978f7e2a9f179c70ce6918a045430e0","unresolved":false,"context_lines":[{"line_number":421,"context_line":"                                       lcfg.zfssa_project,"},{"line_number":422,"context_line":"                                       name)"},{"line_number":423,"context_line":"        if not details:"},{"line_number":424,"context_line":"            msg \u003d (_(\"Share %s doesn\u0027t exists.\") % name)"},{"line_number":425,"context_line":"            raise exception.ManilaException(msg)"},{"line_number":426,"context_line":"        return details"},{"line_number":427,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_c13cf0c1","line":424,"range":{"start_line":424,"start_character":39,"end_line":424,"end_character":45},"in_reply_to":"7aa08908_710d8e3d","updated":"2016-06-20 17:32:29.000000000","message":"Done","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8e20cf3eeb2258fc7a1165afb02708fc7cb31c68","unresolved":false,"context_lines":[{"line_number":422,"context_line":"                                       name)"},{"line_number":423,"context_line":"        if not details:"},{"line_number":424,"context_line":"            msg \u003d (_(\"Share %s doesn\u0027t exists.\") % name)"},{"line_number":425,"context_line":"            raise exception.ManilaException(msg)"},{"line_number":426,"context_line":"        return details"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_35267dba","line":425,"range":{"start_line":425,"start_character":28,"end_line":425,"end_character":43},"updated":"2016-06-12 02:53:01.000000000","message":"s / ManilaException / ShareResourceNotFound","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f1b31b525ebc53a36eb6d2cabc9bd442ebac3e59","unresolved":false,"context_lines":[{"line_number":422,"context_line":"                                       name)"},{"line_number":423,"context_line":"        if not details:"},{"line_number":424,"context_line":"            msg \u003d (_(\"Share %s doesn\u0027t exists.\") % name)"},{"line_number":425,"context_line":"            raise exception.ManilaException(msg)"},{"line_number":426,"context_line":"        return details"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_5d47cebb","line":425,"range":{"start_line":425,"start_character":28,"end_line":425,"end_character":43},"in_reply_to":"7aa08908_35267dba","updated":"2016-06-13 14:19:23.000000000","message":"+1","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"2c47f11bb978f7e2a9f179c70ce6918a045430e0","unresolved":false,"context_lines":[{"line_number":422,"context_line":"                                       name)"},{"line_number":423,"context_line":"        if not details:"},{"line_number":424,"context_line":"            msg \u003d (_(\"Share %s doesn\u0027t exists.\") % name)"},{"line_number":425,"context_line":"            raise exception.ManilaException(msg)"},{"line_number":426,"context_line":"        return details"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_214a1456","line":425,"range":{"start_line":425,"start_character":28,"end_line":425,"end_character":43},"in_reply_to":"7aa08908_35267dba","updated":"2016-06-20 17:32:29.000000000","message":"Done","commit_id":"7f058496a26b22deeb80a50147d0157ae2d7bc71"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"891ab9b5fab00d417cf6f08b7877cc39f93f80da","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    API version history:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        1.0 - Initial version."},{"line_number":85,"context_line":"        1.0.1 - Add share shrink/extend feature."},{"line_number":86,"context_line":"    \"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    VERSION \u003d \u00271.0.1\u0027"},{"line_number":89,"context_line":"    PROTOCOL \u003d \u0027NFS_CIFS\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_2be815b4","line":86,"range":{"start_line":85,"start_character":47,"end_line":86,"end_character":4},"updated":"2016-06-21 07:00:53.000000000","message":"Did you need to add the description about \"Add share manage/unmanage feature.\"?","commit_id":"24623cecf19f1cb55143419dc489f270a0fbe3fd"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"b00b5cdb9dac593120e801ec14639bff8fc2117e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    API version history:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        1.0 - Initial version."},{"line_number":85,"context_line":"        1.0.1 - Add share shrink/extend feature."},{"line_number":86,"context_line":"    \"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    VERSION \u003d \u00271.0.1\u0027"},{"line_number":89,"context_line":"    PROTOCOL \u003d \u0027NFS_CIFS\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_ede9051c","line":86,"range":{"start_line":85,"start_character":47,"end_line":86,"end_character":4},"in_reply_to":"5a9d85d2_2be815b4","updated":"2016-06-22 15:22:19.000000000","message":"Done","commit_id":"24623cecf19f1cb55143419dc489f270a0fbe3fd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bb7008c6bcd63473447339ee403c89611c1cae85","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    def unmanage(self, share):"},{"line_number":388,"context_line":"        \"\"\"Removes the specified share from Manila management."},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        This task involves only changing the custom:manila_managed"},{"line_number":391,"context_line":"        property to False. Current accesses to the share will be removed in"},{"line_number":392,"context_line":"        ZFSSA, as these accesses are removed in Manila."},{"line_number":393,"context_line":"        \"\"\""},{"line_number":394,"context_line":"        name \u003d share[\u0027id\u0027]"},{"line_number":395,"context_line":"        lcfg \u003d self.configuration"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_9c0ece30","line":392,"range":{"start_line":390,"start_character":8,"end_line":392,"end_character":55},"updated":"2016-06-15 19:42:48.000000000","message":"Same remark as my previous comment. If a share has users accessing them, unmanaging the share should not disrupt these users, you should just remove control of manila over the share.","commit_id":"24623cecf19f1cb55143419dc489f270a0fbe3fd"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"a5784bca0503b210c548fd15f6ef2c44f52aa882","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    def unmanage(self, share):"},{"line_number":388,"context_line":"        \"\"\"Removes the specified share from Manila management."},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        This task involves only changing the custom:manila_managed"},{"line_number":391,"context_line":"        property to False. Current accesses to the share will be removed in"},{"line_number":392,"context_line":"        ZFSSA, as these accesses are removed in Manila."},{"line_number":393,"context_line":"        \"\"\""},{"line_number":394,"context_line":"        name \u003d share[\u0027id\u0027]"},{"line_number":395,"context_line":"        lcfg \u003d self.configuration"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_6213025d","line":392,"range":{"start_line":390,"start_character":8,"end_line":392,"end_character":55},"in_reply_to":"7aa08908_9c0ece30","updated":"2016-06-17 21:39:41.000000000","message":"When a ZFSSA share is managed by Manila, it\u0027s Manila\u0027s exclusive, so every access to the share comes from Manila. When Manila un-manages a share, all Manila accesses should be removed, because Manila does not manage these accesses anymore.\n\nI think there will be a security hole if Manila un-manages a share but does not remove existing accesses.","commit_id":"24623cecf19f1cb55143419dc489f270a0fbe3fd"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"891ab9b5fab00d417cf6f08b7877cc39f93f80da","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            msg \u003d (_(\"ZFSSA does not support %s protocol.\") %"},{"line_number":412,"context_line":"                   share[\u0027share_proto\u0027])"},{"line_number":413,"context_line":"            LOG.error(msg)"},{"line_number":414,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":415,"context_line":"        self.zfssa.modify_share(lcfg.zfssa_pool, lcfg.zfssa_project, name, arg)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def _get_share_details(self, name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_cefd1a3c","line":414,"range":{"start_line":414,"start_character":28,"end_line":414,"end_character":46},"updated":"2016-06-21 07:00:53.000000000","message":"s/ ManageInvalidShare/ UnmanageInvalidShare","commit_id":"24623cecf19f1cb55143419dc489f270a0fbe3fd"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"b00b5cdb9dac593120e801ec14639bff8fc2117e","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            msg \u003d (_(\"ZFSSA does not support %s protocol.\") %"},{"line_number":412,"context_line":"                   share[\u0027share_proto\u0027])"},{"line_number":413,"context_line":"            LOG.error(msg)"},{"line_number":414,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":415,"context_line":"        self.zfssa.modify_share(lcfg.zfssa_pool, lcfg.zfssa_project, name, arg)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def _get_share_details(self, name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_2d42ed10","line":414,"range":{"start_line":414,"start_character":28,"end_line":414,"end_character":46},"in_reply_to":"5a9d85d2_cefd1a3c","updated":"2016-06-22 15:22:19.000000000","message":"Done","commit_id":"24623cecf19f1cb55143419dc489f270a0fbe3fd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e520c22291dcc641d8d1029b89bad2876a1a56e8","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            raise exception.ShareResourceNotFound(share_id\u003dname)"},{"line_number":426,"context_line":"        return details"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":429,"context_line":"        self._get_share_details(share[\u0027id\u0027])"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_4ffe746c","line":428,"range":{"start_line":428,"start_character":8,"end_line":428,"end_character":20},"updated":"2016-06-22 03:01:57.000000000","message":"Please add this to your commit message..","commit_id":"24623cecf19f1cb55143419dc489f270a0fbe3fd"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"b00b5cdb9dac593120e801ec14639bff8fc2117e","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            raise exception.ShareResourceNotFound(share_id\u003dname)"},{"line_number":426,"context_line":"        return details"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":429,"context_line":"        self._get_share_details(share[\u0027id\u0027])"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_6dcfd57f","line":428,"range":{"start_line":428,"start_character":8,"end_line":428,"end_character":20},"in_reply_to":"3aaa91ec_4ffe746c","updated":"2016-06-22 15:22:19.000000000","message":"I am not sure what you mean. ensure_share has the same input args, I just re-factor my code to avoid duplication here.","commit_id":"24623cecf19f1cb55143419dc489f270a0fbe3fd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9618f303983d500bfe8a417bda7887bc9f188560","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            raise exception.ShareResourceNotFound(share_id\u003dname)"},{"line_number":426,"context_line":"        return details"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":429,"context_line":"        self._get_share_details(share[\u0027id\u0027])"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_ab9b6271","line":428,"range":{"start_line":428,"start_character":8,"end_line":428,"end_character":20},"in_reply_to":"3aaa91ec_6dcfd57f","updated":"2016-06-22 16:54:41.000000000","message":"NVM, you\u0027re refactoring. I thought ensure_share is a new method. Thanks!","commit_id":"24623cecf19f1cb55143419dc489f270a0fbe3fd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"60ca74dbe97c04ab34eba71fd6e77581d42e5873","unresolved":false,"context_lines":[{"line_number":366,"context_line":"    def _verify_share_to_manage(self, name, details):"},{"line_number":367,"context_line":"        lcfg \u003d self.configuration"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        if lcfg.zfssa_manage_policy \u003d\u003d \u0027loose\u0027:"},{"line_number":370,"context_line":"            return"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        if \u0027custom:manila_managed\u0027 not in details:"},{"line_number":373,"context_line":"            msg \u003d (_(\"Unknown if the share: %s to be managed is \""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_dfb3fde7","line":370,"range":{"start_line":369,"start_character":0,"end_line":370,"end_character":18},"updated":"2016-06-22 20:33:04.000000000","message":"Not covered with unit test:\n\nhttp://logs.openstack.org/97/327897/5/check/manila-coverage-db/7cc7310/cover/manila_share_drivers_zfssa_zfssashare_py.html#n370","commit_id":"5cff1a7db68cd1b97643e39bd207d2688c11404b"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"6e02f8ce4d46fce0c2c1e7dc640b04f79a5d0c6e","unresolved":false,"context_lines":[{"line_number":366,"context_line":"    def _verify_share_to_manage(self, name, details):"},{"line_number":367,"context_line":"        lcfg \u003d self.configuration"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        if lcfg.zfssa_manage_policy \u003d\u003d \u0027loose\u0027:"},{"line_number":370,"context_line":"            return"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        if \u0027custom:manila_managed\u0027 not in details:"},{"line_number":373,"context_line":"            msg \u003d (_(\"Unknown if the share: %s to be managed is \""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_1b62440a","line":370,"range":{"start_line":369,"start_character":0,"end_line":370,"end_character":18},"in_reply_to":"3aaa91ec_dfb3fde7","updated":"2016-06-24 19:56:01.000000000","message":"Done","commit_id":"5cff1a7db68cd1b97643e39bd207d2688c11404b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"60ca74dbe97c04ab34eba71fd6e77581d42e5873","unresolved":false,"context_lines":[{"line_number":380,"context_line":"            LOG.error(msg)"},{"line_number":381,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        if details[\u0027custom:manila_managed\u0027] is True:"},{"line_number":384,"context_line":"            msg \u003d (_(\"Share %s is already being managed by Manila.\") % name)"},{"line_number":385,"context_line":"            LOG.error(msg)"},{"line_number":386,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def unmanage(self, share):"},{"line_number":389,"context_line":"        \"\"\"Removes the specified share from Manila management."}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_bfb6f1d9","line":386,"range":{"start_line":383,"start_character":0,"end_line":386,"end_character":58},"updated":"2016-06-22 20:33:04.000000000","message":"not covered with unit tests:\n\nhttp://logs.openstack.org/97/327897/5/check/manila-coverage-db/7cc7310/cover/manila_share_drivers_zfssa_zfssashare_py.html","commit_id":"5cff1a7db68cd1b97643e39bd207d2688c11404b"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"6e02f8ce4d46fce0c2c1e7dc640b04f79a5d0c6e","unresolved":false,"context_lines":[{"line_number":380,"context_line":"            LOG.error(msg)"},{"line_number":381,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        if details[\u0027custom:manila_managed\u0027] is True:"},{"line_number":384,"context_line":"            msg \u003d (_(\"Share %s is already being managed by Manila.\") % name)"},{"line_number":385,"context_line":"            LOG.error(msg)"},{"line_number":386,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def unmanage(self, share):"},{"line_number":389,"context_line":"        \"\"\"Removes the specified share from Manila management."}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_bb469078","line":386,"range":{"start_line":383,"start_character":0,"end_line":386,"end_character":58},"in_reply_to":"3aaa91ec_bfb6f1d9","updated":"2016-06-24 19:56:01.000000000","message":"Done","commit_id":"5cff1a7db68cd1b97643e39bd207d2688c11404b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5a685792c31f43378ade66cc7f9550d674858678","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        details \u003d self._get_share_details(name)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        if (managed not in details) or (details[managed] is not True):"},{"line_number":401,"context_line":"            msg \u003d (_(\"Share %s is not being managed by the current Manila \""},{"line_number":402,"context_line":"                     \"instance.\") % name)"},{"line_number":403,"context_line":"            LOG.error(msg)"},{"line_number":404,"context_line":"            raise exception.UnmanageInvalidShare(reason\u003dmsg)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        arg \u003d {\u0027custom:manila_managed\u0027: False}"},{"line_number":407,"context_line":"        if share[\u0027share_proto\u0027] \u003d\u003d \u0027NFS\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_436c0c35","line":404,"range":{"start_line":401,"start_character":12,"end_line":404,"end_character":60},"updated":"2016-06-24 03:08:32.000000000","message":"If the share is not being managed by the current manila instance, we could raise ShareResourceNotFound or some other exception,  and then the unmanage operation will not return fail, the share status will not be \u0027unmanage_error\u0027. If your raise other exception value, the share will be unmanaged. Is this your expect?","commit_id":"5cff1a7db68cd1b97643e39bd207d2688c11404b"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"6e02f8ce4d46fce0c2c1e7dc640b04f79a5d0c6e","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        details \u003d self._get_share_details(name)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        if (managed not in details) or (details[managed] is not True):"},{"line_number":401,"context_line":"            msg \u003d (_(\"Share %s is not being managed by the current Manila \""},{"line_number":402,"context_line":"                     \"instance.\") % name)"},{"line_number":403,"context_line":"            LOG.error(msg)"},{"line_number":404,"context_line":"            raise exception.UnmanageInvalidShare(reason\u003dmsg)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        arg \u003d {\u0027custom:manila_managed\u0027: False}"},{"line_number":407,"context_line":"        if share[\u0027share_proto\u0027] \u003d\u003d \u0027NFS\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_4e4ecfc1","line":404,"range":{"start_line":401,"start_character":12,"end_line":404,"end_character":60},"in_reply_to":"3aaa91ec_436c0c35","updated":"2016-06-24 19:56:01.000000000","message":"This share is supposed to be managed by Manila. If the code path goes here, it means that there is actually something wrong happening in the backend. So I need to raise the exception and bring the share to error state.","commit_id":"5cff1a7db68cd1b97643e39bd207d2688c11404b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a8e721153d52e69d56465578028954e2b5197f32","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        1.0.2 - Add share manage/unmanage feature."},{"line_number":87,"context_line":"    \"\"\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    VERSION \u003d \u00271.0.1\u0027"},{"line_number":90,"context_line":"    PROTOCOL \u003d \u0027NFS_CIFS\u0027"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_0ce8ea0f","line":89,"range":{"start_line":89,"start_character":4,"end_line":89,"end_character":21},"updated":"2016-07-04 11:17:29.000000000","message":"In code line 86.\n\ns/ 1.0.1 / 1.0.2 ?","commit_id":"d41976d1000946788372b4abc39ba1ce93352314"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"31b4e0efe01817cb1f0f3680037ffda353ad5952","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        1.0.2 - Add share manage/unmanage feature."},{"line_number":87,"context_line":"    \"\"\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    VERSION \u003d \u00271.0.1\u0027"},{"line_number":90,"context_line":"    PROTOCOL \u003d \u0027NFS_CIFS\u0027"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_c214a145","line":89,"range":{"start_line":89,"start_character":4,"end_line":89,"end_character":21},"in_reply_to":"1aa78d24_0ce8ea0f","updated":"2016-07-05 19:35:37.000000000","message":"Done","commit_id":"d41976d1000946788372b4abc39ba1ce93352314"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"25af28ed16e1676fdb19f93851fdbbb28b17bcdd","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        try:"},{"line_number":304,"context_line":"            details \u003d self._get_share_details(name)"},{"line_number":305,"context_line":"        except Exception as e:"},{"line_number":306,"context_line":"            LOG.error(_LE(\u0027Cannot manage share %s\u0027), name)"},{"line_number":307,"context_line":"            raise e"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        lcfg \u003d self.configuration"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_a6540154","line":306,"range":{"start_line":306,"start_character":16,"end_line":306,"end_character":21},"updated":"2016-07-05 16:10:00.000000000","message":"Better to use \"LOG.exception\" instead of \"LOG.error\" when you have stacktrace. The former will log it too.","commit_id":"d41976d1000946788372b4abc39ba1ce93352314"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"31b4e0efe01817cb1f0f3680037ffda353ad5952","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        try:"},{"line_number":304,"context_line":"            details \u003d self._get_share_details(name)"},{"line_number":305,"context_line":"        except Exception as e:"},{"line_number":306,"context_line":"            LOG.error(_LE(\u0027Cannot manage share %s\u0027), name)"},{"line_number":307,"context_line":"            raise e"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        lcfg \u003d self.configuration"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_2203e50e","line":306,"range":{"start_line":306,"start_character":16,"end_line":306,"end_character":21},"in_reply_to":"3aaa91ec_a6540154","updated":"2016-07-05 19:35:37.000000000","message":"I think it\u0027s better to keep using LOG.error for the reasons below:\n- I don\u0027t see any documentation on LOG.exception: http://docs.openstack.org/developer/oslo.log/usage.html\n- An exception is raised right after logging the error, it already contains a stacktrace.\n- LOG.error has been used throughout the driver code, it should be kept consistent.\n\nThanks.","commit_id":"d41976d1000946788372b4abc39ba1ce93352314"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"25af28ed16e1676fdb19f93851fdbbb28b17bcdd","unresolved":false,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        self.zfssa.modify_share(lcfg.zfssa_pool, lcfg.zfssa_project,"},{"line_number":362,"context_line":"                                name, manage_args)"},{"line_number":363,"context_line":"        return {\u0027size\u0027: size_gb,"},{"line_number":364,"context_line":"                \u0027export_locations\u0027: export_loc}"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def _verify_share_to_manage(self, name, details):"},{"line_number":367,"context_line":"        lcfg \u003d self.configuration"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_26ee518b","line":364,"range":{"start_line":363,"start_character":8,"end_line":364,"end_character":47},"updated":"2016-07-05 16:10:00.000000000","message":"Could be on one line.","commit_id":"d41976d1000946788372b4abc39ba1ce93352314"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"31b4e0efe01817cb1f0f3680037ffda353ad5952","unresolved":false,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        self.zfssa.modify_share(lcfg.zfssa_pool, lcfg.zfssa_project,"},{"line_number":362,"context_line":"                                name, manage_args)"},{"line_number":363,"context_line":"        return {\u0027size\u0027: size_gb,"},{"line_number":364,"context_line":"                \u0027export_locations\u0027: export_loc}"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def _verify_share_to_manage(self, name, details):"},{"line_number":367,"context_line":"        lcfg \u003d self.configuration"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_25edaf25","line":364,"range":{"start_line":363,"start_character":8,"end_line":364,"end_character":47},"in_reply_to":"3aaa91ec_26ee518b","updated":"2016-07-05 19:35:37.000000000","message":"Done","commit_id":"d41976d1000946788372b4abc39ba1ce93352314"}],"manila/tests/share/drivers/zfssa/test_zfssarest.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"25af28ed16e1676fdb19f93851fdbbb28b17bcdd","unresolved":false,"context_lines":[{"line_number":425,"context_line":"        self._zfssa.rclient.post.return_value \u003d self._create_response("},{"line_number":426,"context_line":"            restclient.Status.CREATED)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        self._zfssa.create_schema(self.schema)"},{"line_number":429,"context_line":"        self.assertEqual(1, self._zfssa.rclient.get.call_count)"},{"line_number":430,"context_line":"        self.assertEqual(1, self._zfssa.rclient.post.call_count)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_d53d83bc","line":428,"updated":"2016-07-05 16:10:00.000000000","message":"Here you do not have empty line after execution of tested method, but do have in previous test. Not consistent.","commit_id":"d41976d1000946788372b4abc39ba1ce93352314"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"31b4e0efe01817cb1f0f3680037ffda353ad5952","unresolved":false,"context_lines":[{"line_number":425,"context_line":"        self._zfssa.rclient.post.return_value \u003d self._create_response("},{"line_number":426,"context_line":"            restclient.Status.CREATED)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        self._zfssa.create_schema(self.schema)"},{"line_number":429,"context_line":"        self.assertEqual(1, self._zfssa.rclient.get.call_count)"},{"line_number":430,"context_line":"        self.assertEqual(1, self._zfssa.rclient.post.call_count)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_e219dd7a","line":428,"in_reply_to":"1aa78d24_d53d83bc","updated":"2016-07-05 19:35:37.000000000","message":"Done","commit_id":"d41976d1000946788372b4abc39ba1ce93352314"}],"manila/tests/share/drivers/zfssa/test_zfssashare.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"891ab9b5fab00d417cf6f08b7877cc39f93f80da","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self.configuration.admin_network_config_group \u003d ("},{"line_number":117,"context_line":"            \u0027fake_admin_network_config_group\u0027)"},{"line_number":118,"context_line":"        self.configuration.driver_handles_share_servers \u003d False"},{"line_number":119,"context_line":"        self.configuration.zfssa_manage_policy \u003d \u0027strict\u0027"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def test_create_share(self):"},{"line_number":122,"context_line":"        self.mock_object(self._driver.zfssa, \u0027create_share\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_ae2b6e93","line":119,"range":{"start_line":119,"start_character":49,"end_line":119,"end_character":57},"updated":"2016-06-21 07:00:53.000000000","message":"How about test for \u0027loose\u0027?","commit_id":"24623cecf19f1cb55143419dc489f270a0fbe3fd"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"b00b5cdb9dac593120e801ec14639bff8fc2117e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self.configuration.admin_network_config_group \u003d ("},{"line_number":117,"context_line":"            \u0027fake_admin_network_config_group\u0027)"},{"line_number":118,"context_line":"        self.configuration.driver_handles_share_servers \u003d False"},{"line_number":119,"context_line":"        self.configuration.zfssa_manage_policy \u003d \u0027strict\u0027"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def test_create_share(self):"},{"line_number":122,"context_line":"        self.mock_object(self._driver.zfssa, \u0027create_share\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_0d39f141","line":119,"range":{"start_line":119,"start_character":49,"end_line":119,"end_character":57},"in_reply_to":"5a9d85d2_ae2b6e93","updated":"2016-06-22 15:22:19.000000000","message":"\u0027loose\u0027 is already covered, because \u0027strict\u0027 includes code paths for \u0027loose\u0027, with additional checks. Please see function _verify_share_to_manage in zfssashare.py.","commit_id":"24623cecf19f1cb55143419dc489f270a0fbe3fd"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5a685792c31f43378ade66cc7f9550d674858678","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.fake_proto_share \u003d {"},{"line_number":82,"context_line":"            \u0027id\u0027: self.share[\u0027id\u0027],"},{"line_number":83,"context_line":"            \u0027share_proto\u0027: \u0027fake_proto\u0027,"},{"line_number":84,"context_line":"            \u0027export_locations\u0027: [{\u0027path\u0027: self.share[\u0027export_location\u0027]}]"},{"line_number":85,"context_line":"        }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        self.test_share \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_43dc0c73","line":84,"range":{"start_line":84,"start_character":72,"end_line":84,"end_character":73},"updated":"2016-06-24 03:08:32.000000000","message":"Add tailing comma.","commit_id":"5cff1a7db68cd1b97643e39bd207d2688c11404b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5a685792c31f43378ade66cc7f9550d674858678","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.test_share \u003d {"},{"line_number":88,"context_line":"            \u0027id\u0027: self.share[\u0027id\u0027],"},{"line_number":89,"context_line":"            \u0027share_proto\u0027: \u0027NFS\u0027,"},{"line_number":90,"context_line":"            \u0027export_locations\u0027: [{\u0027path\u0027: self.share[\u0027export_location\u0027]}]"},{"line_number":91,"context_line":"        }"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        self.driver_options \u003d {\u0027zfssa_name\u0027: self.share[\u0027name\u0027]}"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_a3e5f038","line":90,"range":{"start_line":90,"start_character":72,"end_line":90,"end_character":73},"updated":"2016-06-24 03:08:32.000000000","message":"Add tailing comma.","commit_id":"5cff1a7db68cd1b97643e39bd207d2688c11404b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"25af28ed16e1676fdb19f93851fdbbb28b17bcdd","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def test_manage_no_share_details(self):"},{"line_number":318,"context_line":"        self.mock_object(self._driver, \u0027_get_share_details\u0027)"},{"line_number":319,"context_line":"        self._driver._get_share_details.side_effect \u003d\\"},{"line_number":320,"context_line":"            exception.ShareResourceNotFound(share_id\u003dself.share[\u0027name\u0027])"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        self.assertRaises(exception.ShareResourceNotFound,"},{"line_number":323,"context_line":"                          self._driver.manage_existing,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_7a191c88","line":320,"range":{"start_line":319,"start_character":8,"end_line":320,"end_character":72},"updated":"2016-07-05 16:10:00.000000000","message":"http://docs.openstack.org/developer/hacking/#general\n\n\"\"\"\nIt is preferred to wrap long lines in parentheses and not a backslash for line continuation.\n\"\"\"","commit_id":"d41976d1000946788372b4abc39ba1ce93352314"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"31b4e0efe01817cb1f0f3680037ffda353ad5952","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def test_manage_no_share_details(self):"},{"line_number":318,"context_line":"        self.mock_object(self._driver, \u0027_get_share_details\u0027)"},{"line_number":319,"context_line":"        self._driver._get_share_details.side_effect \u003d\\"},{"line_number":320,"context_line":"            exception.ShareResourceNotFound(share_id\u003dself.share[\u0027name\u0027])"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        self.assertRaises(exception.ShareResourceNotFound,"},{"line_number":323,"context_line":"                          self._driver.manage_existing,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_6224cdae","line":320,"range":{"start_line":319,"start_character":8,"end_line":320,"end_character":72},"in_reply_to":"1aa78d24_7a191c88","updated":"2016-07-05 19:35:37.000000000","message":"Done","commit_id":"d41976d1000946788372b4abc39ba1ce93352314"}],"releasenotes/notes/zfssa-driver-release-notes-97982f798f5f4761.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e01b9214c824060a238a13caa1998fe9dfff2e3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The Oracle ZFS Storage Appliance Manila driver,"},{"line_number":4,"context_line":"    version 1.0.2, enables the Oracle ZFS Storage"},{"line_number":5,"context_line":"    Appliance (ZFSSA) to be used seamlessly as a shared"},{"line_number":6,"context_line":"    storage resource for the OpenStack (R) file system"},{"line_number":7,"context_line":"    service Manila. The driver provides the ability to"},{"line_number":8,"context_line":"    create and manage Manila NFS and CIFS shares on the"},{"line_number":9,"context_line":"    appliance, allowing virtual machines to access the"},{"line_number":10,"context_line":"features:"},{"line_number":11,"context_line":"    1.0 - Initial version."},{"line_number":12,"context_line":"    1.0.1 - Add share shrink/extend feature."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3aaa91ec_5fba6d0b","line":9,"range":{"start_line":3,"start_character":4,"end_line":9,"end_character":54},"updated":"2016-06-22 20:29:52.000000000","message":"Not necessary, please remove section..","commit_id":"5cff1a7db68cd1b97643e39bd207d2688c11404b"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"6e02f8ce4d46fce0c2c1e7dc640b04f79a5d0c6e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The Oracle ZFS Storage Appliance Manila driver,"},{"line_number":4,"context_line":"    version 1.0.2, enables the Oracle ZFS Storage"},{"line_number":5,"context_line":"    Appliance (ZFSSA) to be used seamlessly as a shared"},{"line_number":6,"context_line":"    storage resource for the OpenStack (R) file system"},{"line_number":7,"context_line":"    service Manila. The driver provides the ability to"},{"line_number":8,"context_line":"    create and manage Manila NFS and CIFS shares on the"},{"line_number":9,"context_line":"    appliance, allowing virtual machines to access the"},{"line_number":10,"context_line":"features:"},{"line_number":11,"context_line":"    1.0 - Initial version."},{"line_number":12,"context_line":"    1.0.1 - Add share shrink/extend feature."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3aaa91ec_4efc0f3e","line":9,"range":{"start_line":3,"start_character":4,"end_line":9,"end_character":54},"in_reply_to":"3aaa91ec_5fba6d0b","updated":"2016-06-24 19:56:01.000000000","message":"Done","commit_id":"5cff1a7db68cd1b97643e39bd207d2688c11404b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e01b9214c824060a238a13caa1998fe9dfff2e3","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    create and manage Manila NFS and CIFS shares on the"},{"line_number":9,"context_line":"    appliance, allowing virtual machines to access the"},{"line_number":10,"context_line":"features:"},{"line_number":11,"context_line":"    1.0 - Initial version."},{"line_number":12,"context_line":"    1.0.1 - Add share shrink/extend feature."},{"line_number":13,"context_line":"    1.0.2 - Add share manage/unmanage feature."},{"line_number":14,"context_line":"issues:"},{"line_number":15,"context_line":"upgrade:"},{"line_number":16,"context_line":"deprecations:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3aaa91ec_bf0551c3","line":13,"range":{"start_line":11,"start_character":4,"end_line":13,"end_character":46},"updated":"2016-06-22 20:29:52.000000000","message":"This should pertain to what this changeset is adding to the codebase:\n\n\nfeatures:\n    - Oracle ZFS Storage Appliance driver supports bringing shares under manila\u0027s management and removing shares from manila\u0027s management.\n\n\nor something to that effect...","commit_id":"5cff1a7db68cd1b97643e39bd207d2688c11404b"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"6e02f8ce4d46fce0c2c1e7dc640b04f79a5d0c6e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    create and manage Manila NFS and CIFS shares on the"},{"line_number":9,"context_line":"    appliance, allowing virtual machines to access the"},{"line_number":10,"context_line":"features:"},{"line_number":11,"context_line":"    1.0 - Initial version."},{"line_number":12,"context_line":"    1.0.1 - Add share shrink/extend feature."},{"line_number":13,"context_line":"    1.0.2 - Add share manage/unmanage feature."},{"line_number":14,"context_line":"issues:"},{"line_number":15,"context_line":"upgrade:"},{"line_number":16,"context_line":"deprecations:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3aaa91ec_2ef7035a","line":13,"range":{"start_line":11,"start_character":4,"end_line":13,"end_character":46},"in_reply_to":"3aaa91ec_a3b7b038","updated":"2016-06-24 19:56:01.000000000","message":"Done","commit_id":"5cff1a7db68cd1b97643e39bd207d2688c11404b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5a685792c31f43378ade66cc7f9550d674858678","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    create and manage Manila NFS and CIFS shares on the"},{"line_number":9,"context_line":"    appliance, allowing virtual machines to access the"},{"line_number":10,"context_line":"features:"},{"line_number":11,"context_line":"    1.0 - Initial version."},{"line_number":12,"context_line":"    1.0.1 - Add share shrink/extend feature."},{"line_number":13,"context_line":"    1.0.2 - Add share manage/unmanage feature."},{"line_number":14,"context_line":"issues:"},{"line_number":15,"context_line":"upgrade:"},{"line_number":16,"context_line":"deprecations:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3aaa91ec_a3b7b038","line":13,"range":{"start_line":11,"start_character":4,"end_line":13,"end_character":46},"in_reply_to":"3aaa91ec_bf0551c3","updated":"2016-06-24 03:08:32.000000000","message":"+1 Only need to add the description about change part.","commit_id":"5cff1a7db68cd1b97643e39bd207d2688c11404b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e01b9214c824060a238a13caa1998fe9dfff2e3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    1.0 - Initial version."},{"line_number":12,"context_line":"    1.0.1 - Add share shrink/extend feature."},{"line_number":13,"context_line":"    1.0.2 - Add share manage/unmanage feature."},{"line_number":14,"context_line":"issues:"},{"line_number":15,"context_line":"upgrade:"},{"line_number":16,"context_line":"deprecations:"},{"line_number":17,"context_line":"critical:"},{"line_number":18,"context_line":"security:"},{"line_number":19,"context_line":"fixes:"},{"line_number":20,"context_line":"other:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3aaa91ec_9fd3355f","line":20,"range":{"start_line":14,"start_character":0,"end_line":20,"end_character":6},"updated":"2016-06-22 20:29:52.000000000","message":"Please remove.","commit_id":"5cff1a7db68cd1b97643e39bd207d2688c11404b"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"6e02f8ce4d46fce0c2c1e7dc640b04f79a5d0c6e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    1.0 - Initial version."},{"line_number":12,"context_line":"    1.0.1 - Add share shrink/extend feature."},{"line_number":13,"context_line":"    1.0.2 - Add share manage/unmanage feature."},{"line_number":14,"context_line":"issues:"},{"line_number":15,"context_line":"upgrade:"},{"line_number":16,"context_line":"deprecations:"},{"line_number":17,"context_line":"critical:"},{"line_number":18,"context_line":"security:"},{"line_number":19,"context_line":"fixes:"},{"line_number":20,"context_line":"other:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3aaa91ec_8e98b71d","line":20,"range":{"start_line":14,"start_character":0,"end_line":20,"end_character":6},"in_reply_to":"3aaa91ec_9fd3355f","updated":"2016-06-24 19:56:01.000000000","message":"Done","commit_id":"5cff1a7db68cd1b97643e39bd207d2688c11404b"}]}
