)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"c270939fdcc6af0b5c4d348644a00b1d6852bc4f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Handle API NotFound exceptions at WSGI level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In many places, the API code catches various resource"},{"line_number":10,"context_line":"NotFound exceptions and converts them to webob.exc.HTTPFound"},{"line_number":11,"context_line":"exceptions."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Remove this local exception conversion and instead bubble"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_ab143e9f","line":10,"range":{"start_line":10,"start_character":51,"end_line":10,"end_character":60},"updated":"2016-06-15 11:12:01.000000000","message":"Probably HTTPNotFound?","commit_id":"25fe320711276a7b4541a58b20971a94dac64fdc"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"127dfcd58472ae7783b8f6210c5ed670e842a31e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Handle API NotFound exceptions at WSGI level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In many places, the API code catches various resource"},{"line_number":10,"context_line":"NotFound exceptions and converts them to webob.exc.HTTPFound"},{"line_number":11,"context_line":"exceptions."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Remove this local exception conversion and instead bubble"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_8a5c7c7e","line":10,"range":{"start_line":10,"start_character":51,"end_line":10,"end_character":60},"in_reply_to":"7aa08908_7fc91725","updated":"2016-06-16 21:41:09.000000000","message":"Yeah, will fix this in any case.","commit_id":"25fe320711276a7b4541a58b20971a94dac64fdc"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"7943dcb583bb7d36f2f6d4514c56b7322439814d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Handle API NotFound exceptions at WSGI level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In many places, the API code catches various resource"},{"line_number":10,"context_line":"NotFound exceptions and converts them to webob.exc.HTTPFound"},{"line_number":11,"context_line":"exceptions."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Remove this local exception conversion and instead bubble"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_7fc91725","line":10,"range":{"start_line":10,"start_character":51,"end_line":10,"end_character":60},"in_reply_to":"7aa08908_9a007504","updated":"2016-06-16 21:30:06.000000000","message":":-)\n\nPlease fix if you do another patch!","commit_id":"25fe320711276a7b4541a58b20971a94dac64fdc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"eda60eacf6c47979519b0dff35a9021c7fd5b561","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Handle API NotFound exceptions at WSGI level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In many places, the API code catches various resource"},{"line_number":10,"context_line":"NotFound exceptions and converts them to webob.exc.HTTPFound"},{"line_number":11,"context_line":"exceptions."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Remove this local exception conversion and instead bubble"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_9a007504","line":10,"range":{"start_line":10,"start_character":51,"end_line":10,"end_character":60},"in_reply_to":"7aa08908_ab143e9f","updated":"2016-06-16 10:17:38.000000000","message":"Alarm, API was found! Need to crash system immediately!","commit_id":"25fe320711276a7b4541a58b20971a94dac64fdc"}],"manila/api/v1/share_manage.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"7943dcb583bb7d36f2f6d4514c56b7322439814d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            # Not found exception will be handled at the wsgi level."},{"line_number":89,"context_line":"            utils.validate_service_host("},{"line_number":90,"context_line":"                context, share_utils.extract_host(data[\u0027service_host\u0027]))"},{"line_number":91,"context_line":"        except exception.PolicyNotAuthorized as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_6a031077","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":68},"updated":"2016-06-16 21:30:06.000000000","message":"Tom, I like the simplicity offered by this patch, but I cringe at seeing this comment repeated everywhere (and others won\u0027t remember to add it for new APIs).  Do we really need it?","commit_id":"25fe320711276a7b4541a58b20971a94dac64fdc"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"127dfcd58472ae7783b8f6210c5ed670e842a31e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            # Not found exception will be handled at the wsgi level."},{"line_number":89,"context_line":"            utils.validate_service_host("},{"line_number":90,"context_line":"                context, share_utils.extract_host(data[\u0027service_host\u0027]))"},{"line_number":91,"context_line":"        except exception.PolicyNotAuthorized as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_2a58e855","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":68},"in_reply_to":"7aa08908_6a031077","updated":"2016-06-16 21:41:09.000000000","message":"I tend to agree and unless I hear good reasons from other reviewers for keeping it I\u0027ll submit another patch without the comments.\n\nWe\u0027ll need somehow to instill in reviewers going forward that the extra checking locally should be avoided.","commit_id":"25fe320711276a7b4541a58b20971a94dac64fdc"}]}