)]}'
{"contrib/ci/common.sh":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"77a93e9f0aac340265ad8531bcbc7afb38f1c531","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    cp $src_dirname/tempest.log $src_dirname/tempest.txt"},{"line_number":106,"context_line":"    echo \u0027\u0027 \u003e $src_dirname/tempest.log"},{"line_number":107,"context_line":"    archive_file $src_dirname/tempest.txt"},{"line_number":108,"context_line":"    sudo mv $src_dirname/tempest.txt.gz $dst_dirname/tempest.txt.gz"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # 4. Save tempest testr results"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"3aaa91ec_452bfb30","line":108,"range":{"start_line":108,"start_character":33,"end_line":108,"end_character":39},"updated":"2016-06-22 00:12:30.000000000","message":".*?","commit_id":"79b76af08e2c7152b4b9b1c16f7f440206125a2b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"eba232400cc2d2227826e1ba4c00cd197585906f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    cp $src_dirname/tempest.log $src_dirname/tempest.txt"},{"line_number":106,"context_line":"    echo \u0027\u0027 \u003e $src_dirname/tempest.log"},{"line_number":107,"context_line":"    archive_file $src_dirname/tempest.txt"},{"line_number":108,"context_line":"    sudo mv $src_dirname/tempest.txt.gz $dst_dirname/tempest.txt.gz"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # 4. Save tempest testr results"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"3aaa91ec_4cdca612","line":108,"range":{"start_line":108,"start_character":33,"end_line":108,"end_character":39},"in_reply_to":"3aaa91ec_452bfb30","updated":"2016-06-22 12:55:41.000000000","message":"Goutham, what did you want to say?","commit_id":"79b76af08e2c7152b4b9b1c16f7f440206125a2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"00114f03fd659c285285ba430ea814eb041a6ac1","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    cp $src_dirname/tempest.log $src_dirname/tempest.txt"},{"line_number":106,"context_line":"    echo \u0027\u0027 \u003e $src_dirname/tempest.log"},{"line_number":107,"context_line":"    archive_file $src_dirname/tempest.txt"},{"line_number":108,"context_line":"    sudo mv $src_dirname/tempest.txt.gz $dst_dirname/tempest.txt.gz"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # 4. Save tempest testr results"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"3aaa91ec_9feceec8","line":108,"range":{"start_line":108,"start_character":33,"end_line":108,"end_character":39},"in_reply_to":"3aaa91ec_4cdca612","updated":"2016-06-22 13:12:36.000000000","message":"please ignore.. I was thinking we could get away from hardcoding the files expected to be there \"tempest.subunit\", \"tempest.txt\".. We can archive everything with cp tempest.*; but this works.","commit_id":"79b76af08e2c7152b4b9b1c16f7f440206125a2b"}],"manila/tests/share/drivers/dummy.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cac51248c8af934a9f64ea05d58bf009f5ddeb22","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        LOG.debug("},{"line_number":283,"context_line":"            \"Migration of dummy share with ID \u0027%s\u0027 has been started.\" %"},{"line_number":284,"context_line":"            share_ref[\"id\"])"},{"line_number":285,"context_line":"        return True, {}"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def migration_complete("},{"line_number":288,"context_line":"            self, context, share_ref, dest_host, dest_driver_migration_info,"}],"source_content_type":"text/x-python","patch_set":29,"id":"1aa78d24_f007281b","line":285,"range":{"start_line":285,"start_character":7,"end_line":285,"end_character":23},"updated":"2016-07-14 17:04:16.000000000","message":"if complete \u003d\u003d True, you need to return the export location update, exactly what you are doing in migration_complete. The test \u0027test_migration_empty_v2_5\u0027 never works if you do not do this if complete \u003d\u003d True.","commit_id":"d9ab453ae7e48a6acbf2fde5e9bae08ff8359077"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8430d03657f2949037ac710556c039bca21662c0","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        LOG.debug("},{"line_number":283,"context_line":"            \"Migration of dummy share with ID \u0027%s\u0027 has been started.\" %"},{"line_number":284,"context_line":"            share_ref[\"id\"])"},{"line_number":285,"context_line":"        return True, {}"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def migration_complete("},{"line_number":288,"context_line":"            self, context, share_ref, dest_host, dest_driver_migration_info,"}],"source_content_type":"text/x-python","patch_set":29,"id":"fad55976_701a4819","line":285,"range":{"start_line":285,"start_character":7,"end_line":285,"end_character":23},"in_reply_to":"1aa78d24_f007281b","updated":"2016-07-15 14:53:08.000000000","message":"Removed migration support from this driver. keeping in mind its addition in separate commit. To unblock merge of dummy driver. We should not forget that generic driver does not run all tests, only backend-related.","commit_id":"d9ab453ae7e48a6acbf2fde5e9bae08ff8359077"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cac51248c8af934a9f64ea05d58bf009f5ddeb22","unresolved":false,"context_lines":[{"line_number":316,"context_line":"            migrating_share_ref, notify, access_rules, share_server\u003dNone,"},{"line_number":317,"context_line":"            dest_share_server\u003dNone):"},{"line_number":318,"context_line":"        # Simulate migration progress."},{"line_number":319,"context_line":"        if share_ref[\"id\"] not in self.migration_progress:"},{"line_number":320,"context_line":"            self.migration_progress[share_ref[\"id\"]] \u003d total_progress \u003d 25"},{"line_number":321,"context_line":"        elif self.migration_progress[share_ref[\"id\"]] \u003d\u003d 100:"},{"line_number":322,"context_line":"            total_progress \u003d self.migration_progress.pop(share_ref[\"id\"])"},{"line_number":323,"context_line":"        else:"},{"line_number":324,"context_line":"            self.migration_progress[share_ref[\"id\"]] +\u003d 25"},{"line_number":325,"context_line":"            total_progress \u003d self.migration_progress[share_ref[\"id\"]]"},{"line_number":326,"context_line":"        LOG.debug("},{"line_number":327,"context_line":"            (\"Progress of current dummy share migration \""},{"line_number":328,"context_line":"             \"with ID \u0027%(id)s\u0027 is %(progress).\") % {"}],"source_content_type":"text/x-python","patch_set":29,"id":"1aa78d24_704df898","line":325,"range":{"start_line":319,"start_character":8,"end_line":325,"end_character":69},"updated":"2016-07-14 17:04:16.000000000","message":"this will not work because migration_start returns immediately, so task_state gets changed to \"migration_driver_phase1_done\"","commit_id":"d9ab453ae7e48a6acbf2fde5e9bae08ff8359077"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"180b5a9d7c0939d23535bcd5974baaee8625cd18","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        for rule in add_rules:"},{"line_number":140,"context_line":"            share_proto \u003d share[\"share_proto\"].lower()"},{"line_number":141,"context_line":"            access_type \u003d rule[\"access_type\"].lower()"},{"line_number":142,"context_line":"            if not ("},{"line_number":143,"context_line":"                    (share_proto \u003d\u003d \"nfs\" and access_type \u003d\u003d \"ip\") or"},{"line_number":144,"context_line":"                    (share_proto \u003d\u003d \"cifs\" and access_type \u003d\u003d \"user\")):"},{"line_number":145,"context_line":"                msg \u003d _(\"Unsupported \u0027%(access_type)s\u0027 access type provided \""},{"line_number":146,"context_line":"                        \"for \u0027%(share_proto)s\u0027 share protocol.\") % {"},{"line_number":147,"context_line":"                    \"access_type\": access_type, \"share_proto\": share_proto}"},{"line_number":148,"context_line":"                raise exception.InvalidShareAccess(reason\u003dmsg)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def do_setup(self, context):"},{"line_number":151,"context_line":"        \"\"\"Any initialization the share driver does while starting.\"\"\""}],"source_content_type":"text/x-python","patch_set":30,"id":"dada55a8_a0c3b989","line":148,"range":{"start_line":142,"start_character":11,"end_line":148,"end_character":62},"updated":"2016-07-22 14:15:49.000000000","message":"if a not supported rule is present in \"access_rule\", such error will not be thrown. If 2 rules are added very fast and 2nd one is incompatible it will reach this code: https://github.com/openstack/manila/blob/4d4104c11f227e28b5845525db515ccbf672906c/manila/share/access.py#L111 and your driver may end up passing.","commit_id":"60ecba0634ae29c7eb79699a937706d98d23ef40"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9400dc028de8ea17d260b6d57560b25dbf47ab72","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        for rule in add_rules:"},{"line_number":140,"context_line":"            share_proto \u003d share[\"share_proto\"].lower()"},{"line_number":141,"context_line":"            access_type \u003d rule[\"access_type\"].lower()"},{"line_number":142,"context_line":"            if not ("},{"line_number":143,"context_line":"                    (share_proto \u003d\u003d \"nfs\" and access_type \u003d\u003d \"ip\") or"},{"line_number":144,"context_line":"                    (share_proto \u003d\u003d \"cifs\" and access_type \u003d\u003d \"user\")):"},{"line_number":145,"context_line":"                msg \u003d _(\"Unsupported \u0027%(access_type)s\u0027 access type provided \""},{"line_number":146,"context_line":"                        \"for \u0027%(share_proto)s\u0027 share protocol.\") % {"},{"line_number":147,"context_line":"                    \"access_type\": access_type, \"share_proto\": share_proto}"},{"line_number":148,"context_line":"                raise exception.InvalidShareAccess(reason\u003dmsg)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def do_setup(self, context):"},{"line_number":151,"context_line":"        \"\"\"Any initialization the share driver does while starting.\"\"\""}],"source_content_type":"text/x-python","patch_set":30,"id":"dada55a8_16c64f16","line":148,"range":{"start_line":142,"start_character":11,"end_line":148,"end_character":62},"in_reply_to":"dada55a8_40459d15","updated":"2016-07-22 14:59:45.000000000","message":"Done","commit_id":"60ecba0634ae29c7eb79699a937706d98d23ef40"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"01baf1ba14afce5bf8b57bd147f06bc72e6f2af7","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        for rule in add_rules:"},{"line_number":140,"context_line":"            share_proto \u003d share[\"share_proto\"].lower()"},{"line_number":141,"context_line":"            access_type \u003d rule[\"access_type\"].lower()"},{"line_number":142,"context_line":"            if not ("},{"line_number":143,"context_line":"                    (share_proto \u003d\u003d \"nfs\" and access_type \u003d\u003d \"ip\") or"},{"line_number":144,"context_line":"                    (share_proto \u003d\u003d \"cifs\" and access_type \u003d\u003d \"user\")):"},{"line_number":145,"context_line":"                msg \u003d _(\"Unsupported \u0027%(access_type)s\u0027 access type provided \""},{"line_number":146,"context_line":"                        \"for \u0027%(share_proto)s\u0027 share protocol.\") % {"},{"line_number":147,"context_line":"                    \"access_type\": access_type, \"share_proto\": share_proto}"},{"line_number":148,"context_line":"                raise exception.InvalidShareAccess(reason\u003dmsg)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def do_setup(self, context):"},{"line_number":151,"context_line":"        \"\"\"Any initialization the share driver does while starting.\"\"\""}],"source_content_type":"text/x-python","patch_set":30,"id":"dada55a8_40459d15","line":148,"range":{"start_line":142,"start_character":11,"end_line":148,"end_character":62},"in_reply_to":"dada55a8_a0c3b989","updated":"2016-07-22 14:16:27.000000000","message":"\"access_rules\" list","commit_id":"60ecba0634ae29c7eb79699a937706d98d23ef40"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1b984e4d1788733c94eb4a7d2c11635a8c66dce7","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            \"consistency_group_support\": \"pool\","},{"line_number":220,"context_line":"            \"snapshot_support\": True,"},{"line_number":221,"context_line":"            \"driver_name\": \"Dummy\","},{"line_number":222,"context_line":"            \"pools\": self._get_pools_info(),"},{"line_number":223,"context_line":"        }"},{"line_number":224,"context_line":"        if self.configuration.replication_domain:"},{"line_number":225,"context_line":"            data[\"replication_type\"] \u003d \"readable\""}],"source_content_type":"text/x-python","patch_set":31,"id":"dada55a8_6f631c1b","line":222,"range":{"start_line":222,"start_character":41,"end_line":222,"end_character":44},"updated":"2016-07-25 17:35:09.000000000","message":"I\u0027d hope we can expand this to throw in capacity information and test our thin provisioning/max oversubscription/goodness filter logic..","commit_id":"7145891ef89bb4179335f1cbd435e3a7c841a3df"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"27a41c516bb44d78cd29e81b0b9f712efd01475a","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            \"consistency_group_support\": \"pool\","},{"line_number":220,"context_line":"            \"snapshot_support\": True,"},{"line_number":221,"context_line":"            \"driver_name\": \"Dummy\","},{"line_number":222,"context_line":"            \"pools\": self._get_pools_info(),"},{"line_number":223,"context_line":"        }"},{"line_number":224,"context_line":"        if self.configuration.replication_domain:"},{"line_number":225,"context_line":"            data[\"replication_type\"] \u003d \"readable\""}],"source_content_type":"text/x-python","patch_set":31,"id":"dada55a8_e53c4dc1","line":222,"range":{"start_line":222,"start_character":41,"end_line":222,"end_character":44},"in_reply_to":"dada55a8_6f631c1b","updated":"2016-07-25 17:49:32.000000000","message":"Good suggestion.  Maybe as a follow up patch.","commit_id":"7145891ef89bb4179335f1cbd435e3a7c841a3df"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"b5858ab1bc7862ec02011078bc43f1b237f80aab","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                                   share_replica, replica_snapshots,"},{"line_number":327,"context_line":"                                   replica_snapshot, share_server\u003dNone):"},{"line_number":328,"context_line":"        \"\"\"Update the status of a snapshot instance that lives on a replica.\"\"\""},{"line_number":329,"context_line":"        return {"},{"line_number":330,"context_line":"            \"id\": replica_snapshot[\"id\"], \"status\": constants.STATUS_AVAILABLE}"}],"source_content_type":"text/x-python","patch_set":31,"id":"dada55a8_c509492e","line":330,"range":{"start_line":329,"start_character":15,"end_line":330,"end_character":79},"updated":"2016-07-25 17:49:19.000000000","message":"This could be wrapped better if you push another patch.","commit_id":"7145891ef89bb4179335f1cbd435e3a7c841a3df"}],"manila_tempest_tests/tests/api/test_shares.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"180b5a9d7c0939d23535bcd5974baaee8625cd18","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        # The \u0027status\u0027 of the share returned by the create API must be"},{"line_number":149,"context_line":"        # set and have value either \u0027creating\u0027 or"},{"line_number":150,"context_line":"        # \u0027available\u0027 (if share creation takes really fast as in"},{"line_number":151,"context_line":"        # case of Dummy driver)."},{"line_number":152,"context_line":"        self.assertIn(s2[\u0027status\u0027], (\u0027creating\u0027, \u0027available\u0027))"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"dada55a8_b105d215","line":150,"range":{"start_line":150,"start_character":41,"end_line":150,"end_character":46},"updated":"2016-07-22 14:15:49.000000000","message":"s/takes/is","commit_id":"60ecba0634ae29c7eb79699a937706d98d23ef40"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9400dc028de8ea17d260b6d57560b25dbf47ab72","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        # The \u0027status\u0027 of the share returned by the create API must be"},{"line_number":149,"context_line":"        # set and have value either \u0027creating\u0027 or"},{"line_number":150,"context_line":"        # \u0027available\u0027 (if share creation takes really fast as in"},{"line_number":151,"context_line":"        # case of Dummy driver)."},{"line_number":152,"context_line":"        self.assertIn(s2[\u0027status\u0027], (\u0027creating\u0027, \u0027available\u0027))"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"dada55a8_16edaf8e","line":150,"range":{"start_line":150,"start_character":41,"end_line":150,"end_character":46},"in_reply_to":"dada55a8_b105d215","updated":"2016-07-22 14:59:45.000000000","message":"Done","commit_id":"60ecba0634ae29c7eb79699a937706d98d23ef40"}]}
