)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-06-14 09:23:24 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HPE 3PAR driver pool support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"3PAR driver so far did not support multiple pools per backend."},{"line_number":10,"context_line":"This patch aims to allow support for multiple pools per backend."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_eb844a5e","line":8,"updated":"2016-06-28 16:11:46.000000000","message":"nit-picky commit msg edits below...","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"3PAR driver so far did not support multiple pools per backend."},{"line_number":10,"context_line":"This patch aims to allow support for multiple pools per backend."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The configuration now accepts multiple pool entry per backend."},{"line_number":13,"context_line":"In manila.conf, hpe3par_fpg was used to represent one pool(FPG in"},{"line_number":14,"context_line":"terms of 3PAR) under a backend. Now, hpe3par_fpg can be used multiple"},{"line_number":15,"context_line":"time within a backend, each entry will represent a pool (FPG name)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_ad71e046","line":12,"range":{"start_line":12,"start_character":44,"end_line":12,"end_character":49},"updated":"2016-06-28 16:11:46.000000000","message":"s/entry/entries/","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"3PAR driver so far did not support multiple pools per backend."},{"line_number":10,"context_line":"This patch aims to allow support for multiple pools per backend."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The configuration now accepts multiple pool entry per backend."},{"line_number":13,"context_line":"In manila.conf, hpe3par_fpg was used to represent one pool(FPG in"},{"line_number":14,"context_line":"terms of 3PAR) under a backend. Now, hpe3par_fpg can be used multiple"},{"line_number":15,"context_line":"time within a backend, each entry will represent a pool (FPG name)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_8c34e74a","line":12,"range":{"start_line":12,"start_character":44,"end_line":12,"end_character":49},"in_reply_to":"7aa08908_ad71e046","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"This patch aims to allow support for multiple pools per backend."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The configuration now accepts multiple pool entry per backend."},{"line_number":13,"context_line":"In manila.conf, hpe3par_fpg was used to represent one pool(FPG in"},{"line_number":14,"context_line":"terms of 3PAR) under a backend. Now, hpe3par_fpg can be used multiple"},{"line_number":15,"context_line":"time within a backend, each entry will represent a pool (FPG name)."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_8b41463c","line":13,"range":{"start_line":13,"start_character":54,"end_line":13,"end_character":58},"updated":"2016-06-28 16:11:46.000000000","message":"space between pool and (","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"This patch aims to allow support for multiple pools per backend."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The configuration now accepts multiple pool entry per backend."},{"line_number":13,"context_line":"In manila.conf, hpe3par_fpg was used to represent one pool(FPG in"},{"line_number":14,"context_line":"terms of 3PAR) under a backend. Now, hpe3par_fpg can be used multiple"},{"line_number":15,"context_line":"time within a backend, each entry will represent a pool (FPG name)."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_cc3edf28","line":13,"range":{"start_line":13,"start_character":54,"end_line":13,"end_character":58},"in_reply_to":"3aaa91ec_8b41463c","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"The configuration now accepts multiple pool entry per backend."},{"line_number":13,"context_line":"In manila.conf, hpe3par_fpg was used to represent one pool(FPG in"},{"line_number":14,"context_line":"terms of 3PAR) under a backend. Now, hpe3par_fpg can be used multiple"},{"line_number":15,"context_line":"time within a backend, each entry will represent a pool (FPG name)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Sample configuration to supply pools \u0027testfpg\u0027 and \u0027sharenetfpg\u0027:"},{"line_number":18,"context_line":"hpe3par_fpg \u003d sharenetfpg, 10.50.158.8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_2d9cd05c","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":4},"updated":"2016-06-28 16:11:46.000000000","message":"s/time/times/","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"The configuration now accepts multiple pool entry per backend."},{"line_number":13,"context_line":"In manila.conf, hpe3par_fpg was used to represent one pool(FPG in"},{"line_number":14,"context_line":"terms of 3PAR) under a backend. Now, hpe3par_fpg can be used multiple"},{"line_number":15,"context_line":"time within a backend, each entry will represent a pool (FPG name)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Sample configuration to supply pools \u0027testfpg\u0027 and \u0027sharenetfpg\u0027:"},{"line_number":18,"context_line":"hpe3par_fpg \u003d sharenetfpg, 10.50.158.8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_0c4917d1","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":4},"in_reply_to":"7aa08908_2d9cd05c","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"hpe3par_fpg \u003d testfpg, 10.50.158.7"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Note that the configuration now also accepts IP address of share"},{"line_number":22,"context_line":"server. 3PAR supports upto 4 IP address per share server. So the"},{"line_number":23,"context_line":"format to supply multiple share server IP address per pool:"},{"line_number":24,"context_line":"hpe3par_fpg \u003d fpgname, IPaddress1, IPaddress2, IPaddress3, IPaddress4"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_2db330eb","line":22,"range":{"start_line":22,"start_character":32,"end_line":22,"end_character":39},"updated":"2016-06-28 16:11:46.000000000","message":"s/address/addresses/","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"hpe3par_fpg \u003d testfpg, 10.50.158.7"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Note that the configuration now also accepts IP address of share"},{"line_number":22,"context_line":"server. 3PAR supports upto 4 IP address per share server. So the"},{"line_number":23,"context_line":"format to supply multiple share server IP address per pool:"},{"line_number":24,"context_line":"hpe3par_fpg \u003d fpgname, IPaddress1, IPaddress2, IPaddress3, IPaddress4"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_0c73cf16","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":26},"updated":"2016-06-28 16:11:46.000000000","message":"s/upto/up to/","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"hpe3par_fpg \u003d testfpg, 10.50.158.7"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Note that the configuration now also accepts IP address of share"},{"line_number":22,"context_line":"server. 3PAR supports upto 4 IP address per share server. So the"},{"line_number":23,"context_line":"format to supply multiple share server IP address per pool:"},{"line_number":24,"context_line":"hpe3par_fpg \u003d fpgname, IPaddress1, IPaddress2, IPaddress3, IPaddress4"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_4c114faf","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":26},"in_reply_to":"7aa08908_0c73cf16","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"hpe3par_fpg \u003d testfpg, 10.50.158.7"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Note that the configuration now also accepts IP address of share"},{"line_number":22,"context_line":"server. 3PAR supports upto 4 IP address per share server. So the"},{"line_number":23,"context_line":"format to supply multiple share server IP address per pool:"},{"line_number":24,"context_line":"hpe3par_fpg \u003d fpgname, IPaddress1, IPaddress2, IPaddress3, IPaddress4"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_ec45a3b3","line":22,"range":{"start_line":22,"start_character":32,"end_line":22,"end_character":39},"in_reply_to":"7aa08908_2db330eb","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Note that the configuration now also accepts IP address of share"},{"line_number":22,"context_line":"server. 3PAR supports upto 4 IP address per share server. So the"},{"line_number":23,"context_line":"format to supply multiple share server IP address per pool:"},{"line_number":24,"context_line":"hpe3par_fpg \u003d fpgname, IPaddress1, IPaddress2, IPaddress3, IPaddress4"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"If the share server is already setup and configured with IP address,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_eddf680a","line":23,"range":{"start_line":23,"start_character":42,"end_line":23,"end_character":49},"updated":"2016-06-28 16:11:46.000000000","message":"s/address/addresses/","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Note that the configuration now also accepts IP address of share"},{"line_number":22,"context_line":"server. 3PAR supports upto 4 IP address per share server. So the"},{"line_number":23,"context_line":"format to supply multiple share server IP address per pool:"},{"line_number":24,"context_line":"hpe3par_fpg \u003d fpgname, IPaddress1, IPaddress2, IPaddress3, IPaddress4"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"If the share server is already setup and configured with IP address,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_8c0b477d","line":23,"range":{"start_line":23,"start_character":42,"end_line":23,"end_character":49},"in_reply_to":"7aa08908_eddf680a","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"}],"manila/share/driver.py":[{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"f95d5c840b4bb621d9a31c2a7062f67971e1fa50","unresolved":false,"context_lines":[{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def setup_server(self, *args, **kwargs):"},{"line_number":632,"context_line":"        # delayed import to avoid cyclic import errors"},{"line_number":633,"context_line":"        from manila.share.drivers.hpe import hpe_3par_driver"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        if self.driver_handles_share_servers:"},{"line_number":636,"context_line":"            if isinstance(self, hpe_3par_driver.HPE3ParShareDriver):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_01b7c1d8","line":633,"updated":"2016-08-26 20:05:53.000000000","message":"This change is in the wrong class. You can\u0027t add vendor-specific stuff to the main driver class.","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"cfb1725b51928fcd590095b4f98ce80097b0f4a4","unresolved":false,"context_lines":[{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def setup_server(self, *args, **kwargs):"},{"line_number":632,"context_line":"        # delayed import to avoid cyclic import errors"},{"line_number":633,"context_line":"        from manila.share.drivers.hpe import hpe_3par_driver"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        if self.driver_handles_share_servers:"},{"line_number":636,"context_line":"            if isinstance(self, hpe_3par_driver.HPE3ParShareDriver):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_faa1a6aa","line":633,"in_reply_to":"fa7ab95a_01b7c1d8","updated":"2016-08-26 20:59:26.000000000","message":"Ben, I am using it just to check if the call is for HPE driver or for some other driver. All this is done because manager.py is passing additional keyword argument which is not required for other driver.\nOther approach is to update formal argument list of _setup_server() for all the drivers and of course unit tests. \nPlease suggest approach to take.","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d5c326067fa500b3064968fcc2f6bdcdb2ef6d3b","unresolved":false,"context_lines":[{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def setup_server(self, *args, **kwargs):"},{"line_number":632,"context_line":"        # delayed import to avoid cyclic import errors"},{"line_number":633,"context_line":"        from manila.share.drivers.hpe import hpe_3par_driver"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        if self.driver_handles_share_servers:"},{"line_number":636,"context_line":"            if isinstance(self, hpe_3par_driver.HPE3ParShareDriver):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_c2ef30e7","line":633,"in_reply_to":"fa7ab95a_c6dc0715","updated":"2016-08-29 23:21:54.000000000","message":"Done","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d35c1af66453cd8ce514cb6dfee1cf71e0cdd486","unresolved":false,"context_lines":[{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def setup_server(self, *args, **kwargs):"},{"line_number":632,"context_line":"        # delayed import to avoid cyclic import errors"},{"line_number":633,"context_line":"        from manila.share.drivers.hpe import hpe_3par_driver"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        if self.driver_handles_share_servers:"},{"line_number":636,"context_line":"            if isinstance(self, hpe_3par_driver.HPE3ParShareDriver):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_c6dc0715","line":633,"in_reply_to":"fa7ab95a_faa1a6aa","updated":"2016-08-26 22:24:18.000000000","message":"Not necessary, as discussed on irc.. However, please update the docstring for the _setup_server method calling out that the \u0027metadata\u0027 param is a dictionary, for now containing a key \u0027request_host\u0027","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"ce506afb18b3a946959289bedb3f7c7a021a2fb1","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        Redefine it within share driver when it is going to handle share"},{"line_number":732,"context_line":"        servers."},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"        :param metadata: a ditionary, for now containing a key \u0027request_host\u0027"},{"line_number":735,"context_line":"        \"\"\""},{"line_number":736,"context_line":"        raise NotImplementedError()"},{"line_number":737,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_fd92c04a","line":734,"range":{"start_line":734,"start_character":27,"end_line":734,"end_character":36},"updated":"2016-08-31 06:19:40.000000000","message":"s/ditionary/dictionary/","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"9e4bb1b6287f6493da862e87926f3f9a87b29f89","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        Redefine it within share driver when it is going to handle share"},{"line_number":732,"context_line":"        servers."},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"        :param metadata: a ditionary, for now containing a key \u0027request_host\u0027"},{"line_number":735,"context_line":"        \"\"\""},{"line_number":736,"context_line":"        raise NotImplementedError()"},{"line_number":737,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_c7ec1792","line":734,"range":{"start_line":734,"start_character":27,"end_line":734,"end_character":36},"in_reply_to":"fa7ab95a_fd92c04a","updated":"2016-08-31 17:53:15.000000000","message":"Done","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"}],"manila/share/drivers/hpe/hpe_3par_driver.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    MAX_SUPPORTED_IP_PER_VFS \u003d 4"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def __init__(self, min\u003d0, max\u003dMAX_SUPPORTED_IP_PER_VFS,"},{"line_number":63,"context_line":"                 type_name\u003d\u0027FPG\u0027):"},{"line_number":64,"context_line":"        types.String.__init__(self, type_name\u003dtype_name)"},{"line_number":65,"context_line":"        types.IPAddress.__init__(self, type_name\u003dtype_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_6b77ba3b","line":62,"range":{"start_line":62,"start_character":23,"end_line":62,"end_character":33},"updated":"2016-06-28 16:11:46.000000000","message":"min and max are builtins in python.  Use different names.","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    MAX_SUPPORTED_IP_PER_VFS \u003d 4"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def __init__(self, min\u003d0, max\u003dMAX_SUPPORTED_IP_PER_VFS,"},{"line_number":63,"context_line":"                 type_name\u003d\u0027FPG\u0027):"},{"line_number":64,"context_line":"        types.String.__init__(self, type_name\u003dtype_name)"},{"line_number":65,"context_line":"        types.IPAddress.__init__(self, type_name\u003dtype_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_ec73e313","line":62,"range":{"start_line":62,"start_character":23,"end_line":62,"end_character":33},"in_reply_to":"3aaa91ec_6b77ba3b","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        types.String.__init__(self, type_name\u003dtype_name)"},{"line_number":65,"context_line":"        types.IPAddress.__init__(self, type_name\u003dtype_name)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if max \u003c min:"},{"line_number":68,"context_line":"            msg \u003d _(\u0027Pools max acceptable IP cannot be less than min\u0027)"},{"line_number":69,"context_line":"            raise exception.HPE3ParInvalid(msg)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_8b02e63c","line":67,"range":{"start_line":67,"start_character":2,"end_line":67,"end_character":21},"updated":"2016-06-28 16:11:46.000000000","message":"are these set anywhere?  If this is just a test for 0\u003c4 then remove the unused code.","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        types.String.__init__(self, type_name\u003dtype_name)"},{"line_number":65,"context_line":"        types.IPAddress.__init__(self, type_name\u003dtype_name)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if max \u003c min:"},{"line_number":68,"context_line":"            msg \u003d _(\u0027Pools max acceptable IP cannot be less than min\u0027)"},{"line_number":69,"context_line":"            raise exception.HPE3ParInvalid(msg)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_ec548322","line":67,"range":{"start_line":67,"start_character":2,"end_line":67,"end_character":21},"in_reply_to":"3aaa91ec_8b02e63c","updated":"2016-08-12 18:57:59.000000000","message":"This can be set at cfg.MultiOpt(\u0027hpe3par_fpg\u0027, just in case if the min is req to be 1 or max ip per VFS is revised in 3PAR","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"49fa1a0cf569097e45f3b14a89879d1fefae6c3a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        types.String.__init__(self, type_name\u003dtype_name)"},{"line_number":65,"context_line":"        types.IPAddress.__init__(self, type_name\u003dtype_name)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if max \u003c min:"},{"line_number":68,"context_line":"            msg \u003d _(\u0027Pools max acceptable IP cannot be less than min\u0027)"},{"line_number":69,"context_line":"            raise exception.HPE3ParInvalid(msg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if max \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"},{"line_number":72,"context_line":"            msg \u003d _(\u0027Pool max acceptable IP cannot be greater than supported\u0027)"},{"line_number":73,"context_line":"            raise exception.HPE3ParInvalid(msg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        self.min \u003d min"},{"line_number":76,"context_line":"        self.max \u003d max"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_7101b2af","line":73,"range":{"start_line":67,"start_character":8,"end_line":73,"end_character":47},"updated":"2016-06-15 07:43:25.000000000","message":"You could also check here that min \u003e\u003d 0, to ensure that min is not negative.","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        types.String.__init__(self, type_name\u003dtype_name)"},{"line_number":65,"context_line":"        types.IPAddress.__init__(self, type_name\u003dtype_name)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if max \u003c min:"},{"line_number":68,"context_line":"            msg \u003d _(\u0027Pools max acceptable IP cannot be less than min\u0027)"},{"line_number":69,"context_line":"            raise exception.HPE3ParInvalid(msg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if max \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"},{"line_number":72,"context_line":"            msg \u003d _(\u0027Pool max acceptable IP cannot be greater than supported\u0027)"},{"line_number":73,"context_line":"            raise exception.HPE3ParInvalid(msg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        self.min \u003d min"},{"line_number":76,"context_line":"        self.max \u003d max"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_cc241fc8","line":73,"range":{"start_line":67,"start_character":8,"end_line":73,"end_character":47},"in_reply_to":"7aa08908_7101b2af","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        if value is None:"},{"line_number":81,"context_line":"            message \u003d _(\"Invalid configuration. \""},{"line_number":82,"context_line":"                        \"hpe3par_fpgs must be set\")"},{"line_number":83,"context_line":"            LOG.error(message)"},{"line_number":84,"context_line":"            raise exception.HPE3ParInvalid(message)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_c4769b3d","line":82,"range":{"start_line":82,"start_character":36,"end_line":82,"end_character":37},"updated":"2016-06-28 16:11:46.000000000","message":"s/hpe3par_fpgs/hpe3par_fpg/","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        if value is None:"},{"line_number":81,"context_line":"            message \u003d _(\"Invalid configuration. \""},{"line_number":82,"context_line":"                        \"hpe3par_fpgs must be set\")"},{"line_number":83,"context_line":"            LOG.error(message)"},{"line_number":84,"context_line":"            raise exception.HPE3ParInvalid(message)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_ec2be392","line":82,"range":{"start_line":82,"start_character":36,"end_line":82,"end_character":37},"in_reply_to":"3aaa91ec_c4769b3d","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                deprecated_name\u003d\u0027hp3par_san_ssh_port\u0027),"},{"line_number":133,"context_line":"    cfg.MultiOpt(\u0027hpe3par_fpg\u0027,"},{"line_number":134,"context_line":"                 item_type\u003dFPG(),"},{"line_number":135,"context_line":"                 help\u003d\"The File Provisioning Group (FPG) to use\"),"},{"line_number":136,"context_line":"    cfg.BoolOpt(\u0027hpe3par_fstore_per_share\u0027,"},{"line_number":137,"context_line":"                default\u003dFalse,"},{"line_number":138,"context_line":"                help\u003d\"Use one filestore per share\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_6b469a22","line":135,"updated":"2016-06-28 16:11:46.000000000","message":"need to keep support for deprecated hp3par_fpg","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                deprecated_name\u003d\u0027hp3par_san_ssh_port\u0027),"},{"line_number":133,"context_line":"    cfg.MultiOpt(\u0027hpe3par_fpg\u0027,"},{"line_number":134,"context_line":"                 item_type\u003dFPG(),"},{"line_number":135,"context_line":"                 help\u003d\"The File Provisioning Group (FPG) to use\"),"},{"line_number":136,"context_line":"    cfg.BoolOpt(\u0027hpe3par_fstore_per_share\u0027,"},{"line_number":137,"context_line":"                default\u003dFalse,"},{"line_number":138,"context_line":"                help\u003d\"Use one filestore per share\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_97a4f008","line":135,"in_reply_to":"3aaa91ec_6b469a22","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        mediator.do_setup()"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        def validate_pool_ips(addresses, conf_pool_ips):"},{"line_number":238,"context_line":"            # Pool configured IP addresses should be subset of IP addresses"},{"line_number":239,"context_line":"            # retured from vfs"},{"line_number":240,"context_line":"            if isinstance(addresses, six.string_types):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_a4a54f48","line":237,"range":{"start_line":237,"start_character":12,"end_line":237,"end_character":29},"updated":"2016-06-28 16:11:46.000000000","message":"start with _ if only local","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        mediator.do_setup()"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        def validate_pool_ips(addresses, conf_pool_ips):"},{"line_number":238,"context_line":"            # Pool configured IP addresses should be subset of IP addresses"},{"line_number":239,"context_line":"            # retured from vfs"},{"line_number":240,"context_line":"            if isinstance(addresses, six.string_types):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_d7ae68e6","line":237,"range":{"start_line":237,"start_character":12,"end_line":237,"end_character":29},"in_reply_to":"3aaa91ec_a4a54f48","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                      \"Configuration pool IP address did not match with \""},{"line_number":246,"context_line":"                      \"IP addresses at 3par array\"))"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        def construct_fpg():"},{"line_number":249,"context_line":"            # FPG must be configured and must exist."},{"line_number":250,"context_line":"            # self.configuration.safe_get(\u0027hpe3par_fpg\u0027) will have value in"},{"line_number":251,"context_line":"            # following format:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_9595db41","line":248,"range":{"start_line":248,"start_character":12,"end_line":248,"end_character":25},"updated":"2016-06-28 16:11:46.000000000","message":"start with _ if only local","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                      \"Configuration pool IP address did not match with \""},{"line_number":246,"context_line":"                      \"IP addresses at 3par array\"))"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        def construct_fpg():"},{"line_number":249,"context_line":"            # FPG must be configured and must exist."},{"line_number":250,"context_line":"            # self.configuration.safe_get(\u0027hpe3par_fpg\u0027) will have value in"},{"line_number":251,"context_line":"            # following format:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_b7abf4d5","line":248,"range":{"start_line":248,"start_character":12,"end_line":248,"end_character":25},"in_reply_to":"3aaa91ec_9595db41","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                       share[\u0027host\u0027])"},{"line_number":296,"context_line":"            raise exception.InvalidHost(reason\u003dmessage)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        vfs \u003d self.fpgs[pool_name].items()[0][0]"},{"line_number":299,"context_line":"        ips \u003d self.fpgs[pool_name].items()[0][1]"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        return (pool_name, vfs, ips)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_70d83d80","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":48},"updated":"2016-06-28 16:11:46.000000000","message":"Needs to deal with existing shares which have pool name as backend name. Those should be updated. Here there would be a key error. This should better handle KeyError.","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                       share[\u0027host\u0027])"},{"line_number":296,"context_line":"            raise exception.InvalidHost(reason\u003dmessage)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        vfs \u003d self.fpgs[pool_name].items()[0][0]"},{"line_number":299,"context_line":"        ips \u003d self.fpgs[pool_name].items()[0][1]"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        return (pool_name, vfs, ips)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_b747741c","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":48},"in_reply_to":"3aaa91ec_70d83d80","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        vfs \u003d server_details.get(\u0027vfs\u0027)"},{"line_number":362,"context_line":"        ip \u003d server_details.get(\u0027ip\u0027)"},{"line_number":363,"context_line":"        self._hpe3par.remove_fsip(ip, fpg, vfs)"},{"line_number":364,"context_line":"        self.fpgs[fpg][vfs].remove(ip)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    @staticmethod"},{"line_number":367,"context_line":"    def _build_export_locations(protocol, ips, path):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_30299538","line":364,"range":{"start_line":364,"start_character":8,"end_line":364,"end_character":17},"updated":"2016-06-28 16:11:46.000000000","message":"is it right to modify this? it was built from conf during init","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        vfs \u003d server_details.get(\u0027vfs\u0027)"},{"line_number":362,"context_line":"        ip \u003d server_details.get(\u0027ip\u0027)"},{"line_number":363,"context_line":"        self._hpe3par.remove_fsip(ip, fpg, vfs)"},{"line_number":364,"context_line":"        self.fpgs[fpg][vfs].remove(ip)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    @staticmethod"},{"line_number":367,"context_line":"    def _build_export_locations(protocol, ips, path):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_171ac017","line":364,"range":{"start_line":364,"start_character":8,"end_line":364,"end_character":17},"in_reply_to":"3aaa91ec_30299538","updated":"2016-08-12 18:57:59.000000000","message":"Yes. For DHSS, the self.fpgs will ignore any configured VFS IP. when a share server is created we are populating self.fpgs and when we destruct share server from 3PAR, we are safe to remove them from self.fpgs","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        locations \u003d []"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        def build_locations(path_prefix):"},{"line_number":380,"context_line":"            for ip in ips:"},{"line_number":381,"context_line":"                locations.append(path_prefix % (ip, path))"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_d09f715d","line":379,"range":{"start_line":379,"start_character":33,"end_line":379,"end_character":39},"updated":"2016-06-28 16:11:46.000000000","message":"s/path_prefix/path_format/  ?","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        locations \u003d []"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        def build_locations(path_prefix):"},{"line_number":380,"context_line":"            for ip in ips:"},{"line_number":381,"context_line":"                locations.append(path_prefix % (ip, path))"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_37642448","line":379,"range":{"start_line":379,"start_character":33,"end_line":379,"end_character":39},"in_reply_to":"3aaa91ec_d09f715d","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"49fa1a0cf569097e45f3b14a89879d1fefae6c3a","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            message \u003d _(\u0027Failed to build export location due to missing path.\u0027)"},{"line_number":375,"context_line":"            raise exception.InvalidInput(message)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        locations \u003d []"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        def build_locations(path_prefix):"},{"line_number":380,"context_line":"            for ip in ips:"},{"line_number":381,"context_line":"                locations.append(path_prefix % (ip, path))"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        if protocol \u003d\u003d \u0027NFS\u0027:"},{"line_number":384,"context_line":"            build_locations(\u0027%s:%s\u0027)"},{"line_number":385,"context_line":"        elif protocol \u003d\u003d \u0027CIFS\u0027:"},{"line_number":386,"context_line":"            build_locations(\u0027\\\\\\\\%s\\%s\u0027)"},{"line_number":387,"context_line":"        else:"},{"line_number":388,"context_line":"            message \u003d _(\u0027Invalid protocol. Expected NFS or CIFS. \u0027"},{"line_number":389,"context_line":"                        \u0027Got %s.\u0027) % protocol"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_b192fafa","line":386,"range":{"start_line":377,"start_character":8,"end_line":386,"end_character":40},"updated":"2016-06-15 07:43:25.000000000","message":"I think this could be written a little bit shorter with a list comprehension and a direct return in the if statement\n\n  def build_locations(path_prefix):\n      return [ path_prefix % (ip, path) for ip in ips ]\n  \n  if protocol \u003d\u003d \u0027NFS\u0027:\n      return build_locations(\u0027%s:%s\u0027)\n  elif protocol \u003d\u003d \u0027CIFS\u0027:\n      return build_locations(\u0027\\\\\\\\%s\\%s\u0027)","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            message \u003d _(\u0027Failed to build export location due to missing path.\u0027)"},{"line_number":375,"context_line":"            raise exception.InvalidInput(message)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        locations \u003d []"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        def build_locations(path_prefix):"},{"line_number":380,"context_line":"            for ip in ips:"},{"line_number":381,"context_line":"                locations.append(path_prefix % (ip, path))"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        if protocol \u003d\u003d \u0027NFS\u0027:"},{"line_number":384,"context_line":"            build_locations(\u0027%s:%s\u0027)"},{"line_number":385,"context_line":"        elif protocol \u003d\u003d \u0027CIFS\u0027:"},{"line_number":386,"context_line":"            build_locations(\u0027\\\\\\\\%s\\%s\u0027)"},{"line_number":387,"context_line":"        else:"},{"line_number":388,"context_line":"            message \u003d _(\u0027Invalid protocol. Expected NFS or CIFS. \u0027"},{"line_number":389,"context_line":"                        \u0027Got %s.\u0027) % protocol"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_775e9c77","line":386,"range":{"start_line":377,"start_character":8,"end_line":386,"end_character":40},"in_reply_to":"3aaa91ec_3086b5db","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            message \u003d _(\u0027Failed to build export location due to missing path.\u0027)"},{"line_number":375,"context_line":"            raise exception.InvalidInput(message)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        locations \u003d []"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        def build_locations(path_prefix):"},{"line_number":380,"context_line":"            for ip in ips:"},{"line_number":381,"context_line":"                locations.append(path_prefix % (ip, path))"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        if protocol \u003d\u003d \u0027NFS\u0027:"},{"line_number":384,"context_line":"            build_locations(\u0027%s:%s\u0027)"},{"line_number":385,"context_line":"        elif protocol \u003d\u003d \u0027CIFS\u0027:"},{"line_number":386,"context_line":"            build_locations(\u0027\\\\\\\\%s\\%s\u0027)"},{"line_number":387,"context_line":"        else:"},{"line_number":388,"context_line":"            message \u003d _(\u0027Invalid protocol. Expected NFS or CIFS. \u0027"},{"line_number":389,"context_line":"                        \u0027Got %s.\u0027) % protocol"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_3086b5db","line":386,"range":{"start_line":377,"start_character":8,"end_line":386,"end_character":40},"in_reply_to":"7aa08908_b192fafa","updated":"2016-06-28 16:11:46.000000000","message":"+1 and then probably no need for method, just set the path_format for NFS else CIFS and return that one-liner","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            message \u003d _(\u0027Failed to build export location due to missing path.\u0027)"},{"line_number":375,"context_line":"            raise exception.InvalidInput(message)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        locations \u003d []"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        def build_locations(path_prefix):"},{"line_number":380,"context_line":"            for ip in ips:"},{"line_number":381,"context_line":"                locations.append(path_prefix % (ip, path))"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        if protocol \u003d\u003d \u0027NFS\u0027:"},{"line_number":384,"context_line":"            build_locations(\u0027%s:%s\u0027)"},{"line_number":385,"context_line":"        elif protocol \u003d\u003d \u0027CIFS\u0027:"},{"line_number":386,"context_line":"            build_locations(\u0027\\\\\\\\%s\\%s\u0027)"},{"line_number":387,"context_line":"        else:"},{"line_number":388,"context_line":"            message \u003d _(\u0027Invalid protocol. Expected NFS or CIFS. \u0027"},{"line_number":389,"context_line":"                        \u0027Got %s.\u0027) % protocol"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_97599091","line":386,"range":{"start_line":377,"start_character":8,"end_line":386,"end_character":40},"in_reply_to":"7aa08908_b192fafa","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"                subnet \u003d utils.cidr_to_netmask(network_info[\u0027cidr\u0027])"},{"line_number":426,"context_line":"                vlantag \u003d network_info[\u0027segmentation_id\u0027]"},{"line_number":427,"context_line":"                self._hpe3par.create_fsip(ip, subnet, vlantag, pool_name, vfs)"},{"line_number":428,"context_line":"                # Update in global saved config, self.fpgs[pool_name]"},{"line_number":429,"context_line":"                ips.append(ip)"},{"line_number":430,"context_line":"                # When DHSS, we only support one IP for export location"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_19464521","line":427,"range":{"start_line":427,"start_character":16,"end_line":427,"end_character":78},"updated":"2016-06-28 16:11:46.000000000","message":"need error handling around this","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"                subnet \u003d utils.cidr_to_netmask(network_info[\u0027cidr\u0027])"},{"line_number":426,"context_line":"                vlantag \u003d network_info[\u0027segmentation_id\u0027]"},{"line_number":427,"context_line":"                self._hpe3par.create_fsip(ip, subnet, vlantag, pool_name, vfs)"},{"line_number":428,"context_line":"                # Update in global saved config, self.fpgs[pool_name]"},{"line_number":429,"context_line":"                ips.append(ip)"},{"line_number":430,"context_line":"                # When DHSS, we only support one IP for export location"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_f21c5ac3","line":427,"range":{"start_line":427,"start_character":16,"end_line":427,"end_character":78},"in_reply_to":"3aaa91ec_19464521","updated":"2016-08-12 18:57:59.000000000","message":"If create_fsip throws exception, manager will handle that exception with message: \"Creation of share instance %s failed: failed to get share server.\"","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":426,"context_line":"                vlantag \u003d network_info[\u0027segmentation_id\u0027]"},{"line_number":427,"context_line":"                self._hpe3par.create_fsip(ip, subnet, vlantag, pool_name, vfs)"},{"line_number":428,"context_line":"                # Update in global saved config, self.fpgs[pool_name]"},{"line_number":429,"context_line":"                ips.append(ip)"},{"line_number":430,"context_line":"                # When DHSS, we only support one IP for export location"},{"line_number":431,"context_line":"                ips \u003d [ip]"},{"line_number":432,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_79f2e99b","line":429,"range":{"start_line":429,"start_character":15,"end_line":429,"end_character":30},"updated":"2016-06-28 16:11:46.000000000","message":"this does nothing it is overwritten on next line","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":426,"context_line":"                vlantag \u003d network_info[\u0027segmentation_id\u0027]"},{"line_number":427,"context_line":"                self._hpe3par.create_fsip(ip, subnet, vlantag, pool_name, vfs)"},{"line_number":428,"context_line":"                # Update in global saved config, self.fpgs[pool_name]"},{"line_number":429,"context_line":"                ips.append(ip)"},{"line_number":430,"context_line":"                # When DHSS, we only support one IP for export location"},{"line_number":431,"context_line":"                ips \u003d [ip]"},{"line_number":432,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_d2715679","line":429,"range":{"start_line":429,"start_character":15,"end_line":429,"end_character":30},"in_reply_to":"3aaa91ec_79f2e99b","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"},{"line_number":436,"context_line":"        \"\"\"Is called to create share.\"\"\""},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        fpg, vfs, ips \u003d self._create_share_server(share, share_server)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        protocol \u003d share[\u0027share_proto\u0027]"},{"line_number":441,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_d984bd0c","line":438,"range":{"start_line":438,"start_character":29,"end_line":438,"end_character":49},"updated":"2016-06-28 16:11:46.000000000","message":"this _create_share_server does not look like it is designed to be called for every share","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"},{"line_number":436,"context_line":"        \"\"\"Is called to create share.\"\"\""},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        fpg, vfs, ips \u003d self._create_share_server(share, share_server)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        protocol \u003d share[\u0027share_proto\u0027]"},{"line_number":441,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_7287cad7","line":438,"range":{"start_line":438,"start_character":29,"end_line":438,"end_character":49},"in_reply_to":"3aaa91ec_d984bd0c","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":456,"context_line":"                                   share_server\u003dNone):"},{"line_number":457,"context_line":"        \"\"\"Is called to create share from snapshot.\"\"\""},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        fpg, vfs, ips \u003d self._create_share_server(share, share_server)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        protocol \u003d share[\u0027share_proto\u0027]"},{"line_number":462,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_79db091c","line":459,"range":{"start_line":459,"start_character":29,"end_line":459,"end_character":49},"updated":"2016-06-28 16:11:46.000000000","message":"same here","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":456,"context_line":"                                   share_server\u003dNone):"},{"line_number":457,"context_line":"        \"\"\"Is called to create share from snapshot.\"\"\""},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        fpg, vfs, ips \u003d self._create_share_server(share, share_server)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        protocol \u003d share[\u0027share_proto\u0027]"},{"line_number":462,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_b2694228","line":459,"range":{"start_line":459,"start_character":29,"end_line":459,"end_character":49},"in_reply_to":"3aaa91ec_79db091c","updated":"2016-08-12 18:57:59.000000000","message":"Done","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":478,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":479,"context_line":"        \"\"\"Deletes share and its fstore.\"\"\""},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        fpg, vfs, ips \u003d self._get_pool_location(share)"},{"line_number":482,"context_line":"        self._hpe3par.delete_share(share[\u0027project_id\u0027],"},{"line_number":483,"context_line":"                                   share[\u0027id\u0027],"},{"line_number":484,"context_line":"                                   share[\u0027size\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_79e5c9a6","line":481,"range":{"start_line":481,"start_character":29,"end_line":481,"end_character":46},"updated":"2016-06-28 16:11:46.000000000","message":"if this throws and exception we\u0027ll have a share that can never be deleted.","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":478,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":479,"context_line":"        \"\"\"Deletes share and its fstore.\"\"\""},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        fpg, vfs, ips \u003d self._get_pool_location(share)"},{"line_number":482,"context_line":"        self._hpe3par.delete_share(share[\u0027project_id\u0027],"},{"line_number":483,"context_line":"                                   share[\u0027id\u0027],"},{"line_number":484,"context_line":"                                   share[\u0027size\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_92b51e80","line":481,"range":{"start_line":481,"start_character":29,"end_line":481,"end_character":46},"in_reply_to":"3aaa91ec_79e5c9a6","updated":"2016-08-12 18:57:59.000000000","message":"I am still not sure if driver will get any such pool name for which it cannot find location in self.fpgs and throw exception.","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":501,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":502,"context_line":"        \"\"\"Deletes a snapshot of a share.\"\"\""},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        fpg, vfs, ips \u003d self._get_pool_location(snapshot[\u0027share\u0027])"},{"line_number":505,"context_line":"        self._hpe3par.delete_snapshot(snapshot[\u0027share\u0027][\u0027project_id\u0027],"},{"line_number":506,"context_line":"                                      snapshot[\u0027share\u0027][\u0027id\u0027],"},{"line_number":507,"context_line":"                                      snapshot[\u0027share\u0027][\u0027share_proto\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_991a357b","line":504,"range":{"start_line":504,"start_character":29,"end_line":504,"end_character":47},"updated":"2016-06-28 16:11:46.000000000","message":"same here. make sure delete can work somehow","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":501,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":502,"context_line":"        \"\"\"Deletes a snapshot of a share.\"\"\""},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        fpg, vfs, ips \u003d self._get_pool_location(snapshot[\u0027share\u0027])"},{"line_number":505,"context_line":"        self._hpe3par.delete_snapshot(snapshot[\u0027share\u0027][\u0027project_id\u0027],"},{"line_number":506,"context_line":"                                      snapshot[\u0027share\u0027][\u0027id\u0027],"},{"line_number":507,"context_line":"                                      snapshot[\u0027share\u0027][\u0027share_proto\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_32671227","line":504,"range":{"start_line":504,"start_character":29,"end_line":504,"end_character":47},"in_reply_to":"3aaa91ec_991a357b","updated":"2016-08-12 18:57:59.000000000","message":"same as above.","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":603,"context_line":"        else:"},{"line_number":604,"context_line":"            for fpg in self.fpgs.keys():"},{"line_number":605,"context_line":"                fpg_status \u003d self._hpe3par.get_fpg_status(fpg)"},{"line_number":606,"context_line":"                fpg_status[\u0027reserved_percentage\u0027] \u003d reserved_share_percentage"},{"line_number":607,"context_line":"                stats.setdefault(\u0027pools\u0027, []).append(fpg_status)"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        super(HPE3ParShareDriver, self)._update_share_stats(stats)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_1caab3d2","line":606,"range":{"start_line":606,"start_character":52,"end_line":606,"end_character":77},"updated":"2016-06-28 16:11:46.000000000","message":"doesn\u0027t max_over_subscription_ratio behave the same?","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"39c1b8d73a118cdb6c7af0beafa06079b8ccf0d7","unresolved":false,"context_lines":[{"line_number":603,"context_line":"        else:"},{"line_number":604,"context_line":"            for fpg in self.fpgs.keys():"},{"line_number":605,"context_line":"                fpg_status \u003d self._hpe3par.get_fpg_status(fpg)"},{"line_number":606,"context_line":"                fpg_status[\u0027reserved_percentage\u0027] \u003d reserved_share_percentage"},{"line_number":607,"context_line":"                stats.setdefault(\u0027pools\u0027, []).append(fpg_status)"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        super(HPE3ParShareDriver, self)._update_share_stats(stats)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_1d62dfd8","line":606,"range":{"start_line":606,"start_character":52,"end_line":606,"end_character":77},"in_reply_to":"3aaa91ec_1caab3d2","updated":"2016-08-12 18:57:59.000000000","message":"No, this is what I got from 3PAR best practice guide:\n\nreserved_share_percentage - The percentage of backend capacity to be reserved. Default is 0.\n\nmax_over_subscription_ratio - Float representation of the over subscription ratio when thin provisioning is involved. Default ratio is 20.0, meaning provisioned share capacity can be 20 times the total physical capacity. Introduced in Liberty.","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1249f81742b509ea2fec1ff47d73a121277361f9","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if max_ip \u003c min_ip:"},{"line_number":68,"context_line":"            msg \u003d _(\u0027Pools max acceptable IP cannot be less than min\u0027)"},{"line_number":69,"context_line":"            raise exception.HPE3ParInvalid(msg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if min_ip \u003c 0:"},{"line_number":72,"context_line":"            msg \u003d _(\u0027Pools can be configured with zero or more IPs\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_ce027472","line":69,"range":{"start_line":69,"start_character":18,"end_line":69,"end_character":47},"updated":"2016-08-18 19:43:02.000000000","message":"exception.HPE3ParInvalid(err\u003dmsg)","commit_id":"3adc0bb02c05283da2a6cf5684d6eceefcb5517e"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"74eb1cf92dee30544109ebf51149d92c3177db60","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if max_ip \u003c min_ip:"},{"line_number":68,"context_line":"            msg \u003d _(\u0027Pools max acceptable IP cannot be less than min\u0027)"},{"line_number":69,"context_line":"            raise exception.HPE3ParInvalid(msg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if min_ip \u003c 0:"},{"line_number":72,"context_line":"            msg \u003d _(\u0027Pools can be configured with zero or more IPs\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_55a28b9b","line":69,"range":{"start_line":69,"start_character":18,"end_line":69,"end_character":47},"in_reply_to":"3ac371cc_ce027472","updated":"2016-08-18 21:39:08.000000000","message":"Done","commit_id":"3adc0bb02c05283da2a6cf5684d6eceefcb5517e"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1249f81742b509ea2fec1ff47d73a121277361f9","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if min_ip \u003c 0:"},{"line_number":72,"context_line":"            msg \u003d _(\u0027Pools can be configured with zero or more IPs\u0027)"},{"line_number":73,"context_line":"            raise exception.HPE3ParInvalid(msg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if max_ip \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"},{"line_number":76,"context_line":"            msg \u003d _(\u0027Pool max acceptable IP cannot be greater than supported\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_0efdac6e","line":73,"updated":"2016-08-18 19:43:02.000000000","message":"Same","commit_id":"3adc0bb02c05283da2a6cf5684d6eceefcb5517e"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"74eb1cf92dee30544109ebf51149d92c3177db60","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if min_ip \u003c 0:"},{"line_number":72,"context_line":"            msg \u003d _(\u0027Pools can be configured with zero or more IPs\u0027)"},{"line_number":73,"context_line":"            raise exception.HPE3ParInvalid(msg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if max_ip \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"},{"line_number":76,"context_line":"            msg \u003d _(\u0027Pool max acceptable IP cannot be greater than supported\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_359f0f52","line":73,"in_reply_to":"3ac371cc_0efdac6e","updated":"2016-08-18 21:39:08.000000000","message":"Done","commit_id":"3adc0bb02c05283da2a6cf5684d6eceefcb5517e"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1249f81742b509ea2fec1ff47d73a121277361f9","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if max_ip \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"},{"line_number":76,"context_line":"            msg \u003d _(\u0027Pool max acceptable IP cannot be greater than supported\u0027)"},{"line_number":77,"context_line":"            raise exception.HPE3ParInvalid(msg)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.min_ip \u003d min_ip"},{"line_number":80,"context_line":"        self.max_ip \u003d max_ip"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_8ef19c98","line":77,"updated":"2016-08-18 19:43:02.000000000","message":"Same\n\nPlease check other places where this is used.","commit_id":"3adc0bb02c05283da2a6cf5684d6eceefcb5517e"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"74eb1cf92dee30544109ebf51149d92c3177db60","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if max_ip \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"},{"line_number":76,"context_line":"            msg \u003d _(\u0027Pool max acceptable IP cannot be greater than supported\u0027)"},{"line_number":77,"context_line":"            raise exception.HPE3ParInvalid(msg)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.min_ip \u003d min_ip"},{"line_number":80,"context_line":"        self.max_ip \u003d max_ip"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_95ac038e","line":77,"in_reply_to":"3ac371cc_8ef19c98","updated":"2016-08-18 21:39:08.000000000","message":"Done","commit_id":"3adc0bb02c05283da2a6cf5684d6eceefcb5517e"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1249f81742b509ea2fec1ff47d73a121277361f9","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        return \u0027FPG\u0027"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _formatter(self, value):"},{"line_number":112,"context_line":"        return str(value)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"HPE3PAR_OPTS \u003d ["},{"line_number":115,"context_line":"    cfg.StrOpt(\u0027hpe3par_api_url\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_6e1c20c2","line":112,"updated":"2016-08-18 19:43:02.000000000","message":"str() -\u003e six.text_type()","commit_id":"3adc0bb02c05283da2a6cf5684d6eceefcb5517e"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"74eb1cf92dee30544109ebf51149d92c3177db60","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        return \u0027FPG\u0027"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _formatter(self, value):"},{"line_number":112,"context_line":"        return str(value)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"HPE3PAR_OPTS \u003d ["},{"line_number":115,"context_line":"    cfg.StrOpt(\u0027hpe3par_api_url\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_f5d457be","line":112,"in_reply_to":"3ac371cc_6e1c20c2","updated":"2016-08-18 21:39:08.000000000","message":"Done","commit_id":"3adc0bb02c05283da2a6cf5684d6eceefcb5517e"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1249f81742b509ea2fec1ff47d73a121277361f9","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        # self.fpgs \u003d {"},{"line_number":305,"context_line":"        #            \u0027pool_name1\u0027 : {\u0027vfs_name\u0027: [ip addr1, ..., ip addr4]},"},{"line_number":306,"context_line":"        #            ..."},{"line_number":307,"context_line":"        # }"},{"line_number":308,"context_line":"        _construct_fpg()"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        # Don\u0027t set _hpe3par until it is ready. Otherwise _update_stats fails."}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_8e4d1cc7","line":307,"updated":"2016-08-18 19:43:02.000000000","message":"Remove commented out code.","commit_id":"3adc0bb02c05283da2a6cf5684d6eceefcb5517e"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"74eb1cf92dee30544109ebf51149d92c3177db60","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        # self.fpgs \u003d {"},{"line_number":305,"context_line":"        #            \u0027pool_name1\u0027 : {\u0027vfs_name\u0027: [ip addr1, ..., ip addr4]},"},{"line_number":306,"context_line":"        #            ..."},{"line_number":307,"context_line":"        # }"},{"line_number":308,"context_line":"        _construct_fpg()"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        # Don\u0027t set _hpe3par until it is ready. Otherwise _update_stats fails."}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_759b4773","line":307,"in_reply_to":"3ac371cc_8e4d1cc7","updated":"2016-08-18 21:39:08.000000000","message":"This is not code. Just a comment of how the variable self.fpgs would have value (format) look like.","commit_id":"3adc0bb02c05283da2a6cf5684d6eceefcb5517e"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1249f81742b509ea2fec1ff47d73a121277361f9","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                message \u003d (_(\"Pool %s has exceeded 3PAR\u0027s \""},{"line_number":388,"context_line":"                             \"max supported VFS IP address\") % pool_name)"},{"line_number":389,"context_line":"                LOG.error(message)"},{"line_number":390,"context_line":"                raise exception.Invalid(reason\u003dmessage)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"            subnet \u003d utils.cidr_to_netmask(network_info[\u0027cidr\u0027])"},{"line_number":393,"context_line":"            vlantag \u003d network_info[\u0027segmentation_id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_0eb5ac7d","line":390,"updated":"2016-08-18 19:43:02.000000000","message":"exception.Invalid does not have a \"reason\" parameter in the message.","commit_id":"3adc0bb02c05283da2a6cf5684d6eceefcb5517e"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"74eb1cf92dee30544109ebf51149d92c3177db60","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                message \u003d (_(\"Pool %s has exceeded 3PAR\u0027s \""},{"line_number":388,"context_line":"                             \"max supported VFS IP address\") % pool_name)"},{"line_number":389,"context_line":"                LOG.error(message)"},{"line_number":390,"context_line":"                raise exception.Invalid(reason\u003dmessage)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"            subnet \u003d utils.cidr_to_netmask(network_info[\u0027cidr\u0027])"},{"line_number":393,"context_line":"            vlantag \u003d network_info[\u0027segmentation_id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_1598136a","line":390,"in_reply_to":"3ac371cc_0eb5ac7d","updated":"2016-08-18 21:39:08.000000000","message":"Done","commit_id":"3adc0bb02c05283da2a6cf5684d6eceefcb5517e"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b99121888c2d04ee2471998cde434182b822c3f0","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \"\"\"FPG type"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    Used to represent multiple pool per backend values."},{"line_number":45,"context_line":"    Converts configuration value to an FPGs value."},{"line_number":46,"context_line":"    FPGs value format:"},{"line_number":47,"context_line":"        FPG name, IP address 1, IP address 2, ..., IP address 4"},{"line_number":48,"context_line":"    where FPG name is a string value,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_c59b13c8","line":45,"range":{"start_line":45,"start_character":39,"end_line":45,"end_character":43},"updated":"2016-08-27 09:57:54.000000000","message":"FPG","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d5c326067fa500b3064968fcc2f6bdcdb2ef6d3b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \"\"\"FPG type"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    Used to represent multiple pool per backend values."},{"line_number":45,"context_line":"    Converts configuration value to an FPGs value."},{"line_number":46,"context_line":"    FPGs value format:"},{"line_number":47,"context_line":"        FPG name, IP address 1, IP address 2, ..., IP address 4"},{"line_number":48,"context_line":"    where FPG name is a string value,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_42a9608f","line":45,"range":{"start_line":45,"start_character":39,"end_line":45,"end_character":43},"in_reply_to":"fa7ab95a_c59b13c8","updated":"2016-08-29 23:21:54.000000000","message":"FPG is multi opt value. Hence kept it FPGs","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b99121888c2d04ee2471998cde434182b822c3f0","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    Used to represent multiple pool per backend values."},{"line_number":45,"context_line":"    Converts configuration value to an FPGs value."},{"line_number":46,"context_line":"    FPGs value format:"},{"line_number":47,"context_line":"        FPG name, IP address 1, IP address 2, ..., IP address 4"},{"line_number":48,"context_line":"    where FPG name is a string value,"},{"line_number":49,"context_line":"    IP address is of type types.IPAddress"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_05a6db0f","line":46,"range":{"start_line":46,"start_character":4,"end_line":46,"end_character":8},"updated":"2016-08-27 09:57:54.000000000","message":"FPG","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d5c326067fa500b3064968fcc2f6bdcdb2ef6d3b","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    Used to represent multiple pool per backend values."},{"line_number":45,"context_line":"    Converts configuration value to an FPGs value."},{"line_number":46,"context_line":"    FPGs value format:"},{"line_number":47,"context_line":"        FPG name, IP address 1, IP address 2, ..., IP address 4"},{"line_number":48,"context_line":"    where FPG name is a string value,"},{"line_number":49,"context_line":"    IP address is of type types.IPAddress"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_8297e846","line":46,"range":{"start_line":46,"start_character":4,"end_line":46,"end_character":8},"in_reply_to":"fa7ab95a_05a6db0f","updated":"2016-08-29 23:21:54.000000000","message":"FPG is multi opt value. Hence kept it FPGs","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b99121888c2d04ee2471998cde434182b822c3f0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        types.IPAddress.__init__(self, type_name\u003dtype_name)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if max_ip \u003c min_ip:"},{"line_number":68,"context_line":"            msg \u003d _(\u0027Pools max acceptable IP cannot be less than min\u0027)"},{"line_number":69,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if min_ip \u003c 0:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_e5857759","line":68,"range":{"start_line":68,"start_character":21,"end_line":68,"end_character":26},"updated":"2016-08-27 09:57:54.000000000","message":"Pool\u0027s","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d5c326067fa500b3064968fcc2f6bdcdb2ef6d3b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        types.IPAddress.__init__(self, type_name\u003dtype_name)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if max_ip \u003c min_ip:"},{"line_number":68,"context_line":"            msg \u003d _(\u0027Pools max acceptable IP cannot be less than min\u0027)"},{"line_number":69,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if min_ip \u003c 0:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_c29d7067","line":68,"range":{"start_line":68,"start_character":21,"end_line":68,"end_character":26},"in_reply_to":"fa7ab95a_e5857759","updated":"2016-08-29 23:21:54.000000000","message":"Done","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b99121888c2d04ee2471998cde434182b822c3f0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if min_ip \u003c 0:"},{"line_number":72,"context_line":"            msg \u003d _(\u0027Pools can be configured with zero or more IPs\u0027)"},{"line_number":73,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if max_ip \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_e5ec972b","line":72,"range":{"start_line":72,"start_character":21,"end_line":72,"end_character":30},"updated":"2016-08-27 09:57:54.000000000","message":"Pool must","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d5c326067fa500b3064968fcc2f6bdcdb2ef6d3b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if min_ip \u003c 0:"},{"line_number":72,"context_line":"            msg \u003d _(\u0027Pools can be configured with zero or more IPs\u0027)"},{"line_number":73,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if max_ip \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_e29a746d","line":72,"range":{"start_line":72,"start_character":21,"end_line":72,"end_character":30},"in_reply_to":"fa7ab95a_e5ec972b","updated":"2016-08-29 23:21:54.000000000","message":"Done","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b99121888c2d04ee2471998cde434182b822c3f0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            msg \u003d _(\u0027Pools can be configured with zero or more IPs\u0027)"},{"line_number":73,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if max_ip \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"},{"line_number":76,"context_line":"            msg \u003d _(\u0027Pool max acceptable IP cannot be greater than supported\u0027)"},{"line_number":77,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_45de236e","line":75,"range":{"start_line":75,"start_character":20,"end_line":75,"end_character":23},"updated":"2016-08-27 09:57:54.000000000","message":"could use self.","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d5c326067fa500b3064968fcc2f6bdcdb2ef6d3b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            msg \u003d _(\u0027Pools can be configured with zero or more IPs\u0027)"},{"line_number":73,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if max_ip \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"},{"line_number":76,"context_line":"            msg \u003d _(\u0027Pool max acceptable IP cannot be greater than supported\u0027)"},{"line_number":77,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_827e0817","line":75,"range":{"start_line":75,"start_character":20,"end_line":75,"end_character":23},"in_reply_to":"fa7ab95a_45de236e","updated":"2016-08-29 23:21:54.000000000","message":"Left it as it is.","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b99121888c2d04ee2471998cde434182b822c3f0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if max_ip \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"},{"line_number":76,"context_line":"            msg \u003d _(\u0027Pool max acceptable IP cannot be greater than supported\u0027)"},{"line_number":77,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.min_ip \u003d min_ip"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_e5d3b75d","line":76,"range":{"start_line":76,"start_character":21,"end_line":76,"end_character":25},"updated":"2016-08-27 09:57:54.000000000","message":"Pool\u0027s","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b99121888c2d04ee2471998cde434182b822c3f0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if max_ip \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"},{"line_number":76,"context_line":"            msg \u003d _(\u0027Pool max acceptable IP cannot be greater than supported\u0027)"},{"line_number":77,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.min_ip \u003d min_ip"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_85bf4bfa","line":76,"range":{"start_line":76,"start_character":67,"end_line":76,"end_character":76},"updated":"2016-08-27 09:57:54.000000000","message":"print out the number of MAX_SUPPORTED_IP_PER_VFS","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d5c326067fa500b3064968fcc2f6bdcdb2ef6d3b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if max_ip \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"},{"line_number":76,"context_line":"            msg \u003d _(\u0027Pool max acceptable IP cannot be greater than supported\u0027)"},{"line_number":77,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.min_ip \u003d min_ip"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_028af81a","line":76,"range":{"start_line":76,"start_character":67,"end_line":76,"end_character":76},"in_reply_to":"fa7ab95a_85bf4bfa","updated":"2016-08-29 23:21:54.000000000","message":"Done","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d5c326067fa500b3064968fcc2f6bdcdb2ef6d3b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if max_ip \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"},{"line_number":76,"context_line":"            msg \u003d _(\u0027Pool max acceptable IP cannot be greater than supported\u0027)"},{"line_number":77,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.min_ip \u003d min_ip"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_228ffc2a","line":76,"range":{"start_line":76,"start_character":21,"end_line":76,"end_character":25},"in_reply_to":"fa7ab95a_e5d3b75d","updated":"2016-08-29 23:21:54.000000000","message":"Done","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b99121888c2d04ee2471998cde434182b822c3f0","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def __call__(self, value):"},{"line_number":83,"context_line":"        if value is None:"},{"line_number":84,"context_line":"            message \u003d _(\"Invalid configuration. \""},{"line_number":85,"context_line":"                        \"hpe3par_fpg must be set\")"},{"line_number":86,"context_line":"            LOG.error(message)"},{"line_number":87,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmessage)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_e53ad797","line":85,"range":{"start_line":85,"start_character":48,"end_line":85,"end_character":49},"updated":"2016-08-27 09:57:54.000000000","message":"tail period.","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d5c326067fa500b3064968fcc2f6bdcdb2ef6d3b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def __call__(self, value):"},{"line_number":83,"context_line":"        if value is None:"},{"line_number":84,"context_line":"            message \u003d _(\"Invalid configuration. \""},{"line_number":85,"context_line":"                        \"hpe3par_fpg must be set\")"},{"line_number":86,"context_line":"            LOG.error(message)"},{"line_number":87,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmessage)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_a27b0c27","line":85,"range":{"start_line":85,"start_character":48,"end_line":85,"end_character":49},"in_reply_to":"fa7ab95a_e53ad797","updated":"2016-08-29 23:21:54.000000000","message":"Done","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b99121888c2d04ee2471998cde434182b822c3f0","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        ips \u003d []"},{"line_number":90,"context_line":"        values \u003d value.split(\",\")"},{"line_number":91,"context_line":"        # Extract pool name"},{"line_number":92,"context_line":"        pool_name \u003d values.pop(0).strip()"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        # values will now be [\u0027ip1\u0027, ...]"},{"line_number":95,"context_line":"        if len(values) \u003e self.max_ip:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_05ac1b9f","line":92,"updated":"2016-08-27 09:57:54.000000000","message":"Need to check if the pool_name is a non-empty string and not an IP, in case user misconfigure.","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d5c326067fa500b3064968fcc2f6bdcdb2ef6d3b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        ips \u003d []"},{"line_number":90,"context_line":"        values \u003d value.split(\",\")"},{"line_number":91,"context_line":"        # Extract pool name"},{"line_number":92,"context_line":"        pool_name \u003d values.pop(0).strip()"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        # values will now be [\u0027ip1\u0027, ...]"},{"line_number":95,"context_line":"        if len(values) \u003e self.max_ip:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_2219bcd7","line":92,"in_reply_to":"fa7ab95a_05ac1b9f","updated":"2016-08-29 23:21:54.000000000","message":"if value is None is already checked. IPs are optional.","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b99121888c2d04ee2471998cde434182b822c3f0","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        # values will now be [\u0027ip1\u0027, ...]"},{"line_number":95,"context_line":"        if len(values) \u003e self.max_ip:"},{"line_number":96,"context_line":"            msg \u003d _(\u0027Cannot configure IPs more than max supported per pool\u0027)"},{"line_number":97,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        for ip_addr in values:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_45738380","line":96,"range":{"start_line":96,"start_character":52,"end_line":96,"end_character":65},"updated":"2016-08-27 09:57:54.000000000","message":"print out the value of self.max_ip","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d5c326067fa500b3064968fcc2f6bdcdb2ef6d3b","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        # values will now be [\u0027ip1\u0027, ...]"},{"line_number":95,"context_line":"        if len(values) \u003e self.max_ip:"},{"line_number":96,"context_line":"            msg \u003d _(\u0027Cannot configure IPs more than max supported per pool\u0027)"},{"line_number":97,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        for ip_addr in values:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_82d36803","line":96,"range":{"start_line":96,"start_character":52,"end_line":96,"end_character":65},"in_reply_to":"fa7ab95a_45738380","updated":"2016-08-29 23:21:54.000000000","message":"Done","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b99121888c2d04ee2471998cde434182b822c3f0","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        for ip_addr in values:"},{"line_number":100,"context_line":"            ip_addr \u003d types.String.__call__(self, ip_addr.strip())"},{"line_number":101,"context_line":"            try:"},{"line_number":102,"context_line":"                ips.append(types.IPAddress.__call__(self, ip_addr))"},{"line_number":103,"context_line":"            except ValueError as verror:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_c52cf34c","line":100,"updated":"2016-08-27 09:57:54.000000000","message":"Is this converting necessary?","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d5c326067fa500b3064968fcc2f6bdcdb2ef6d3b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        for ip_addr in values:"},{"line_number":100,"context_line":"            ip_addr \u003d types.String.__call__(self, ip_addr.strip())"},{"line_number":101,"context_line":"            try:"},{"line_number":102,"context_line":"                ips.append(types.IPAddress.__call__(self, ip_addr))"},{"line_number":103,"context_line":"            except ValueError as verror:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_a2f78c89","line":100,"in_reply_to":"fa7ab95a_c52cf34c","updated":"2016-08-29 23:21:54.000000000","message":"Accepting IPs to be in str format and checks performed by types.String can be used.","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b99121888c2d04ee2471998cde434182b822c3f0","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        2.0.3 - Remove file tree on delete when using nested shares #1538800"},{"line_number":198,"context_line":"        2.0.4 - Reduce the fsquota by share size"},{"line_number":199,"context_line":"                when a share is deleted #1582931"},{"line_number":200,"context_line":"        2.0.5 - Pool support per backend"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    \"\"\""},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_e58bb71c","line":200,"range":{"start_line":200,"start_character":16,"end_line":200,"end_character":20},"updated":"2016-08-27 09:57:54.000000000","message":"multi pools","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d5c326067fa500b3064968fcc2f6bdcdb2ef6d3b","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        2.0.3 - Remove file tree on delete when using nested shares #1538800"},{"line_number":198,"context_line":"        2.0.4 - Reduce the fsquota by share size"},{"line_number":199,"context_line":"                when a share is deleted #1582931"},{"line_number":200,"context_line":"        2.0.5 - Pool support per backend"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    \"\"\""},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_c2f01094","line":200,"range":{"start_line":200,"start_character":16,"end_line":200,"end_character":20},"in_reply_to":"fa7ab95a_e58bb71c","updated":"2016-08-29 23:21:54.000000000","message":"Done","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b99121888c2d04ee2471998cde434182b822c3f0","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            # self.configuration.safe_get(\u0027hpe3par_fpg\u0027) will have value in"},{"line_number":265,"context_line":"            # following format:"},{"line_number":266,"context_line":"            # [ {\u0027pool_name\u0027:[\u0027ip_addr\u0027, \u0027ip_addr\u0027, ...]}, ... ]"},{"line_number":267,"context_line":"            for fpg in self.configuration.safe_get(\u0027hpe3par_fpg\u0027):"},{"line_number":268,"context_line":"                pool_name \u003d list(fpg)[0]"},{"line_number":269,"context_line":"                conf_pool_ips \u003d fpg[pool_name]"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_65cde75c","line":267,"range":{"start_line":267,"start_character":23,"end_line":267,"end_character":66},"updated":"2016-08-27 09:57:54.000000000","message":"better check the safe_get result if None","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d5c326067fa500b3064968fcc2f6bdcdb2ef6d3b","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            # self.configuration.safe_get(\u0027hpe3par_fpg\u0027) will have value in"},{"line_number":265,"context_line":"            # following format:"},{"line_number":266,"context_line":"            # [ {\u0027pool_name\u0027:[\u0027ip_addr\u0027, \u0027ip_addr\u0027, ...]}, ... ]"},{"line_number":267,"context_line":"            for fpg in self.configuration.safe_get(\u0027hpe3par_fpg\u0027):"},{"line_number":268,"context_line":"                pool_name \u003d list(fpg)[0]"},{"line_number":269,"context_line":"                conf_pool_ips \u003d fpg[pool_name]"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_22329c5f","line":267,"range":{"start_line":267,"start_character":23,"end_line":267,"end_character":66},"in_reply_to":"fa7ab95a_65cde75c","updated":"2016-08-29 23:21:54.000000000","message":"FPG class would construct proper values which will be obtained here. None should never be returned here.","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b99121888c2d04ee2471998cde434182b822c3f0","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                       share_instance_host)"},{"line_number":319,"context_line":"            raise exception.InvalidHost(reason\u003dmessage)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        if pool_name not in self.fpgs.keys():"},{"line_number":322,"context_line":"            message \u003d (_(\"Pool location lookup failed. \""},{"line_number":323,"context_line":"                         \"Could not find pool %s\") %"},{"line_number":324,"context_line":"                       pool_name)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_a51c4fc2","line":321,"range":{"start_line":321,"start_character":28,"end_line":321,"end_character":44},"updated":"2016-08-27 09:57:54.000000000","message":"self.fpgs is enough.","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d5c326067fa500b3064968fcc2f6bdcdb2ef6d3b","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                       share_instance_host)"},{"line_number":319,"context_line":"            raise exception.InvalidHost(reason\u003dmessage)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        if pool_name not in self.fpgs.keys():"},{"line_number":322,"context_line":"            message \u003d (_(\"Pool location lookup failed. \""},{"line_number":323,"context_line":"                         \"Could not find pool %s\") %"},{"line_number":324,"context_line":"                       pool_name)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_c21e50ba","line":321,"range":{"start_line":321,"start_character":28,"end_line":321,"end_character":44},"in_reply_to":"fa7ab95a_a51c4fc2","updated":"2016-08-29 23:21:54.000000000","message":"Done","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b99121888c2d04ee2471998cde434182b822c3f0","unresolved":false,"context_lines":[{"line_number":613,"context_line":"                _LI(\"Skipping capacity and capabilities update. Setup has not \""},{"line_number":614,"context_line":"                    \"completed.\"))"},{"line_number":615,"context_line":"        else:"},{"line_number":616,"context_line":"            for fpg in self.fpgs.keys():"},{"line_number":617,"context_line":"                fpg_status \u003d self._hpe3par.get_fpg_status(fpg)"},{"line_number":618,"context_line":"                fpg_status[\u0027reserved_percentage\u0027] \u003d reserved_share_percentage"},{"line_number":619,"context_line":"                stats.setdefault(\u0027pools\u0027, []).append(fpg_status)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_c5607338","line":616,"range":{"start_line":616,"start_character":23,"end_line":616,"end_character":39},"updated":"2016-08-27 09:57:54.000000000","message":"self.fpgs is enough","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d5c326067fa500b3064968fcc2f6bdcdb2ef6d3b","unresolved":false,"context_lines":[{"line_number":613,"context_line":"                _LI(\"Skipping capacity and capabilities update. Setup has not \""},{"line_number":614,"context_line":"                    \"completed.\"))"},{"line_number":615,"context_line":"        else:"},{"line_number":616,"context_line":"            for fpg in self.fpgs.keys():"},{"line_number":617,"context_line":"                fpg_status \u003d self._hpe3par.get_fpg_status(fpg)"},{"line_number":618,"context_line":"                fpg_status[\u0027reserved_percentage\u0027] \u003d reserved_share_percentage"},{"line_number":619,"context_line":"                stats.setdefault(\u0027pools\u0027, []).append(fpg_status)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_2280dcbf","line":616,"range":{"start_line":616,"start_character":23,"end_line":616,"end_character":39},"in_reply_to":"fa7ab95a_c5607338","updated":"2016-08-29 23:21:54.000000000","message":"Done","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1790d8f691e3b2fbb38683099e70be63641b3e93","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        types.IPAddress.__init__(self, type_name\u003dtype_name)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if max_ip \u003c min_ip:"},{"line_number":68,"context_line":"            msg \u003d _(\"Pool\u0027s max acceptable IP cannot be less than min\")"},{"line_number":69,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if min_ip \u003c 0:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_7c39a4d6","line":68,"range":{"start_line":68,"start_character":69,"end_line":68,"end_character":70},"updated":"2016-08-30 07:11:53.000000000","message":"period","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d41b4c608b937109f6d9ed9d71dab26f8dbf6691","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        types.IPAddress.__init__(self, type_name\u003dtype_name)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if max_ip \u003c min_ip:"},{"line_number":68,"context_line":"            msg \u003d _(\"Pool\u0027s max acceptable IP cannot be less than min\")"},{"line_number":69,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if min_ip \u003c 0:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_bc713a0e","line":68,"range":{"start_line":68,"start_character":69,"end_line":68,"end_character":70},"in_reply_to":"fa7ab95a_7c39a4d6","updated":"2016-08-30 18:29:21.000000000","message":"Done","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1790d8f691e3b2fbb38683099e70be63641b3e93","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if min_ip \u003c 0:"},{"line_number":72,"context_line":"            msg \u003d _(\"Pools must be configured with zero or more IPs\")"},{"line_number":73,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if max_ip \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_7c40c434","line":72,"range":{"start_line":72,"start_character":67,"end_line":72,"end_character":68},"updated":"2016-08-30 07:11:53.000000000","message":"period","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d41b4c608b937109f6d9ed9d71dab26f8dbf6691","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if min_ip \u003c 0:"},{"line_number":72,"context_line":"            msg \u003d _(\"Pools must be configured with zero or more IPs\")"},{"line_number":73,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if max_ip \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_dc627e3d","line":72,"range":{"start_line":72,"start_character":67,"end_line":72,"end_character":68},"in_reply_to":"fa7ab95a_7c40c434","updated":"2016-08-30 18:29:21.000000000","message":"Done","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1790d8f691e3b2fbb38683099e70be63641b3e93","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if max_ip \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"},{"line_number":76,"context_line":"            msg \u003d (_(\"Pool\u0027s max acceptable IP cannot be greater than \""},{"line_number":77,"context_line":"                     \"supported value\u003d%s\") % FPG.MAX_SUPPORTED_IP_PER_VFS)"},{"line_number":78,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self.min_ip \u003d min_ip"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_9c490863","line":77,"range":{"start_line":77,"start_character":40,"end_line":77,"end_character":41},"updated":"2016-08-30 07:11:53.000000000","message":"period","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d41b4c608b937109f6d9ed9d71dab26f8dbf6691","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if max_ip \u003e FPG.MAX_SUPPORTED_IP_PER_VFS:"},{"line_number":76,"context_line":"            msg \u003d (_(\"Pool\u0027s max acceptable IP cannot be greater than \""},{"line_number":77,"context_line":"                     \"supported value\u003d%s\") % FPG.MAX_SUPPORTED_IP_PER_VFS)"},{"line_number":78,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self.min_ip \u003d min_ip"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_1c59468e","line":77,"range":{"start_line":77,"start_character":40,"end_line":77,"end_character":41},"in_reply_to":"fa7ab95a_9c490863","updated":"2016-08-30 18:29:21.000000000","message":"Done","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"5b7e73d7bdbee9445938cdc29b50e72ba36927fd","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                     \"supported value\u003d%s\") % FPG.MAX_SUPPORTED_IP_PER_VFS)"},{"line_number":78,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self.min_ip \u003d min_ip"},{"line_number":81,"context_line":"        self.max_ip \u003d max_ip"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def __call__(self, value):"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_7e3d118e","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":19},"updated":"2016-08-30 08:24:00.000000000","message":"I didn\u0027t see where this attribute is referred, if it\u0027s not used, can we remove the min_ip parameter?","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d41b4c608b937109f6d9ed9d71dab26f8dbf6691","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                     \"supported value\u003d%s\") % FPG.MAX_SUPPORTED_IP_PER_VFS)"},{"line_number":78,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmsg)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self.min_ip \u003d min_ip"},{"line_number":81,"context_line":"        self.max_ip \u003d max_ip"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def __call__(self, value):"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_77118b51","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":19},"in_reply_to":"fa7ab95a_7e3d118e","updated":"2016-08-30 18:29:21.000000000","message":"Added those checks and unit test case too.","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1790d8f691e3b2fbb38683099e70be63641b3e93","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def __call__(self, value):"},{"line_number":84,"context_line":"        if value is None:"},{"line_number":85,"context_line":"            message \u003d _(\"Invalid configuration. \""},{"line_number":86,"context_line":"                        \"hpe3par_fpg must be set.\")"},{"line_number":87,"context_line":"            LOG.error(message)"},{"line_number":88,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmessage)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_1c6c18cf","line":86,"range":{"start_line":85,"start_character":12,"end_line":86,"end_character":51},"updated":"2016-08-30 07:11:53.000000000","message":"It could be one line.","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d41b4c608b937109f6d9ed9d71dab26f8dbf6691","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def __call__(self, value):"},{"line_number":84,"context_line":"        if value is None:"},{"line_number":85,"context_line":"            message \u003d _(\"Invalid configuration. \""},{"line_number":86,"context_line":"                        \"hpe3par_fpg must be set.\")"},{"line_number":87,"context_line":"            LOG.error(message)"},{"line_number":88,"context_line":"            raise exception.HPE3ParInvalid(err\u003dmessage)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_37a7030c","line":86,"range":{"start_line":85,"start_character":12,"end_line":86,"end_character":51},"in_reply_to":"fa7ab95a_1c6c18cf","updated":"2016-08-30 18:29:21.000000000","message":"Done","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1790d8f691e3b2fbb38683099e70be63641b3e93","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        def _validate_pool_ips(addresses, conf_pool_ips):"},{"line_number":255,"context_line":"            # Pool configured IP addresses should be subset of IP addresses"},{"line_number":256,"context_line":"            # retured from vfs"},{"line_number":257,"context_line":"            if isinstance(addresses, six.string_types):"},{"line_number":258,"context_line":"                addresses \u003d [addresses]"},{"line_number":259,"context_line":"            if not set(conf_pool_ips) \u003c\u003d set(addresses):"},{"line_number":260,"context_line":"                msg \u003d _(\"Incorrect configuration. \""},{"line_number":261,"context_line":"                        \"Configuration pool IP address did not match with \""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_bcb96c17","line":258,"range":{"start_line":257,"start_character":12,"end_line":258,"end_character":39},"updated":"2016-08-30 07:11:53.000000000","message":"How about else?","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d41b4c608b937109f6d9ed9d71dab26f8dbf6691","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        def _validate_pool_ips(addresses, conf_pool_ips):"},{"line_number":255,"context_line":"            # Pool configured IP addresses should be subset of IP addresses"},{"line_number":256,"context_line":"            # retured from vfs"},{"line_number":257,"context_line":"            if isinstance(addresses, six.string_types):"},{"line_number":258,"context_line":"                addresses \u003d [addresses]"},{"line_number":259,"context_line":"            if not set(conf_pool_ips) \u003c\u003d set(addresses):"},{"line_number":260,"context_line":"                msg \u003d _(\"Incorrect configuration. \""},{"line_number":261,"context_line":"                        \"Configuration pool IP address did not match with \""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_17575fca","line":258,"range":{"start_line":257,"start_character":12,"end_line":258,"end_character":39},"in_reply_to":"fa7ab95a_bcb96c17","updated":"2016-08-30 18:29:21.000000000","message":"else: It would be of list type and so no processing required.","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d35a1791b00800b41b3202fda557f52ae83fabac","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                # This also validates the client, connection, firmware, WSAPI,"},{"line_number":276,"context_line":"                # FPG..."},{"line_number":277,"context_line":"                vfs_info \u003d mediator.get_vfs(pool_name)"},{"line_number":278,"context_line":"                if self.driver_handles_share_servers or conf_pool_ips \u003d\u003d []:"},{"line_number":279,"context_line":"                    # IPs not configured in manila.conf."},{"line_number":280,"context_line":"                    if not vfs_info[\u0027vfsip\u0027][\u0027address\u0027]:"},{"line_number":281,"context_line":"                        msg \u003d _(\"Unsupported configuration. \""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_77bd0801","line":278,"range":{"start_line":278,"start_character":20,"end_line":278,"end_character":52},"updated":"2016-08-30 18:10:45.000000000","message":"Is this supposed to be !dhss?  The msg below says dhss is False.","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"a73179f443cfe3b59a51ce34d5986b08aa8cc10a","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                # This also validates the client, connection, firmware, WSAPI,"},{"line_number":276,"context_line":"                # FPG..."},{"line_number":277,"context_line":"                vfs_info \u003d mediator.get_vfs(pool_name)"},{"line_number":278,"context_line":"                if self.driver_handles_share_servers or conf_pool_ips \u003d\u003d []:"},{"line_number":279,"context_line":"                    # IPs not configured in manila.conf."},{"line_number":280,"context_line":"                    if not vfs_info[\u0027vfsip\u0027][\u0027address\u0027]:"},{"line_number":281,"context_line":"                        msg \u003d _(\"Unsupported configuration. \""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_fd6c99d1","line":278,"range":{"start_line":278,"start_character":20,"end_line":278,"end_character":52},"in_reply_to":"fa7ab95a_77bd0801","updated":"2016-08-30 23:36:42.000000000","message":"Revised the comment message.","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1790d8f691e3b2fbb38683099e70be63641b3e93","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":390,"context_line":"        for share_server in share_servers:"},{"line_number":391,"context_line":"            if share_server[\u0027backend_details\u0027].get(\u0027fpg\u0027, None) \u003d\u003d pool_name:"},{"line_number":392,"context_line":"                return share_server"},{"line_number":393,"context_line":"        return None"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_6ad9cf56","line":391,"range":{"start_line":391,"start_character":47,"end_line":391,"end_character":63},"updated":"2016-08-30 07:11:53.000000000","message":"s/ get(\u0027fpg\u0027, None) / get(\u0027fpg\u0027)\n \u0027None\u0027 would be the default return value.","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d41b4c608b937109f6d9ed9d71dab26f8dbf6691","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":390,"context_line":"        for share_server in share_servers:"},{"line_number":391,"context_line":"            if share_server[\u0027backend_details\u0027].get(\u0027fpg\u0027, None) \u003d\u003d pool_name:"},{"line_number":392,"context_line":"                return share_server"},{"line_number":393,"context_line":"        return None"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_97028fb2","line":391,"range":{"start_line":391,"start_character":47,"end_line":391,"end_character":63},"in_reply_to":"fa7ab95a_6ad9cf56","updated":"2016-08-30 18:29:21.000000000","message":"Yes. This would be a safe way to check if there is no value for key \u0027fpg\u0027, instead of py failure","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d35a1791b00800b41b3202fda557f52ae83fabac","unresolved":false,"context_lines":[{"line_number":422,"context_line":"            # Update in global saved config, self.fpgs[pool_name]"},{"line_number":423,"context_line":"            ips.append(ip)"},{"line_number":424,"context_line":"            # When DHSS, should we support only one IP for export location"},{"line_number":425,"context_line":"            # To decide: ips \u003d [ip] ??"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        return {\u0027share_server_name\u0027: network_info[\u0027server_id\u0027],"},{"line_number":428,"context_line":"                \u0027share_server_id\u0027: network_info[\u0027server_id\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_37238057","line":425,"range":{"start_line":425,"start_character":14,"end_line":425,"end_character":38},"updated":"2016-08-30 18:10:45.000000000","message":"Todo","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"a73179f443cfe3b59a51ce34d5986b08aa8cc10a","unresolved":false,"context_lines":[{"line_number":422,"context_line":"            # Update in global saved config, self.fpgs[pool_name]"},{"line_number":423,"context_line":"            ips.append(ip)"},{"line_number":424,"context_line":"            # When DHSS, should we support only one IP for export location"},{"line_number":425,"context_line":"            # To decide: ips \u003d [ip] ??"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        return {\u0027share_server_name\u0027: network_info[\u0027server_id\u0027],"},{"line_number":428,"context_line":"                \u0027share_server_id\u0027: network_info[\u0027server_id\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_9db38d4c","line":425,"range":{"start_line":425,"start_character":14,"end_line":425,"end_character":38},"in_reply_to":"fa7ab95a_37238057","updated":"2016-08-30 23:36:42.000000000","message":"Removing comment. We do support multiple export locations with DHSS","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d35a1791b00800b41b3202fda557f52ae83fabac","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                                   share[\u0027share_proto\u0027],"},{"line_number":523,"context_line":"                                   fpg,"},{"line_number":524,"context_line":"                                   vfs,"},{"line_number":525,"context_line":"                                   ips[0])"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":528,"context_line":"        \"\"\"Creates a snapshot of a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_f78118c4","line":525,"range":{"start_line":525,"start_character":31,"end_line":525,"end_character":42},"updated":"2016-08-30 18:10:45.000000000","message":"For DHSS this might not be accessible. Need to keep and admin IP address until all access is moved to m-dat.","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"a73179f443cfe3b59a51ce34d5986b08aa8cc10a","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                                   share[\u0027share_proto\u0027],"},{"line_number":523,"context_line":"                                   fpg,"},{"line_number":524,"context_line":"                                   vfs,"},{"line_number":525,"context_line":"                                   ips[0])"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":528,"context_line":"        \"\"\"Creates a snapshot of a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_e2cf8627","line":525,"range":{"start_line":525,"start_character":31,"end_line":525,"end_character":42},"in_reply_to":"fa7ab95a_f78118c4","updated":"2016-08-30 23:36:42.000000000","message":"As discussed and now using share_server, this will work. Thanks.","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1790d8f691e3b2fbb38683099e70be63641b3e93","unresolved":false,"context_lines":[{"line_number":619,"context_line":"            \u0027qos\u0027: False,"},{"line_number":620,"context_line":"            \u0027thin_provisioning\u0027: True,  # 3PAR default is thin"},{"line_number":621,"context_line":"            \u0027snapshot_support\u0027: True,"},{"line_number":622,"context_line":"            \u0027replication_domain\u0027: None,"},{"line_number":623,"context_line":"        }"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        if not self._hpe3par:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_8d08ed29","line":622,"range":{"start_line":622,"start_character":11,"end_line":622,"end_character":39},"updated":"2016-08-30 07:11:53.000000000","message":"You don\u0027t need to add this in hpe3par-pool-support code.","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d41b4c608b937109f6d9ed9d71dab26f8dbf6691","unresolved":false,"context_lines":[{"line_number":619,"context_line":"            \u0027qos\u0027: False,"},{"line_number":620,"context_line":"            \u0027thin_provisioning\u0027: True,  # 3PAR default is thin"},{"line_number":621,"context_line":"            \u0027snapshot_support\u0027: True,"},{"line_number":622,"context_line":"            \u0027replication_domain\u0027: None,"},{"line_number":623,"context_line":"        }"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        if not self._hpe3par:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_d72ed741","line":622,"range":{"start_line":622,"start_character":11,"end_line":622,"end_character":39},"in_reply_to":"fa7ab95a_8d08ed29","updated":"2016-08-30 18:29:21.000000000","message":"Done","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f8a56dd24c743e0bfcc8749144fce7301f73d0f9","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class FPG(types.String, types.IPAddress):"},{"line_number":42,"context_line":"    \"\"\"FPG type"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    Used to represent multiple pool per backend values."},{"line_number":45,"context_line":"    Converts configuration value to an FPGs value."}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_89e41aad","line":42,"updated":"2016-08-31 04:04:28.000000000","message":"nit: missing period at the end.","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"9e4bb1b6287f6493da862e87926f3f9a87b29f89","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class FPG(types.String, types.IPAddress):"},{"line_number":42,"context_line":"    \"\"\"FPG type"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    Used to represent multiple pool per backend values."},{"line_number":45,"context_line":"    Converts configuration value to an FPGs value."}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_7625c3ac","line":42,"in_reply_to":"fa7ab95a_89e41aad","updated":"2016-08-31 17:53:15.000000000","message":"Done","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f8a56dd24c743e0bfcc8749144fce7301f73d0f9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"class FPG(types.String, types.IPAddress):"},{"line_number":42,"context_line":"    \"\"\"FPG type"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    Used to represent multiple pool per backend values."},{"line_number":45,"context_line":"    Converts configuration value to an FPGs value."},{"line_number":46,"context_line":"    FPGs value format:"},{"line_number":47,"context_line":"        FPG name, IP address 1, IP address 2, ..., IP address 4"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_a9e1de9c","line":44,"updated":"2016-08-31 04:04:28.000000000","message":"nit: pools","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"9e4bb1b6287f6493da862e87926f3f9a87b29f89","unresolved":false,"context_lines":[{"line_number":41,"context_line":"class FPG(types.String, types.IPAddress):"},{"line_number":42,"context_line":"    \"\"\"FPG type"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    Used to represent multiple pool per backend values."},{"line_number":45,"context_line":"    Converts configuration value to an FPGs value."},{"line_number":46,"context_line":"    FPGs value format:"},{"line_number":47,"context_line":"        FPG name, IP address 1, IP address 2, ..., IP address 4"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_962a477d","line":44,"in_reply_to":"fa7ab95a_a9e1de9c","updated":"2016-08-31 17:53:15.000000000","message":"Done","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"ce506afb18b3a946959289bedb3f7c7a021a2fb1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    IP address is of type types.IPAddress"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    Optionally doing range checking."},{"line_number":52,"context_line":"    If value is whitespace or empty string will return None/ raise error"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    :param min_ip: Optional check that number of min IP address of VFS."},{"line_number":55,"context_line":"    :param max_ip: Optional check that number of max IP address of VFS."}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_fd07207f","line":52,"range":{"start_line":52,"start_character":59,"end_line":52,"end_character":60},"updated":"2016-08-31 06:19:40.000000000","message":"nit. the slash looks strange. s/\\// and/\n  and end sentence with period.","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"9e4bb1b6287f6493da862e87926f3f9a87b29f89","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    IP address is of type types.IPAddress"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    Optionally doing range checking."},{"line_number":52,"context_line":"    If value is whitespace or empty string will return None/ raise error"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    :param min_ip: Optional check that number of min IP address of VFS."},{"line_number":55,"context_line":"    :param max_ip: Optional check that number of max IP address of VFS."}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_76d22336","line":52,"range":{"start_line":52,"start_character":59,"end_line":52,"end_character":60},"in_reply_to":"fa7ab95a_fd07207f","updated":"2016-08-31 17:53:15.000000000","message":"Corrected: Raises error.","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"ce506afb18b3a946959289bedb3f7c7a021a2fb1","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                # This also validates the client, connection, firmware, WSAPI,"},{"line_number":286,"context_line":"                # FPG..."},{"line_number":287,"context_line":"                vfs_info \u003d mediator.get_vfs(pool_name)"},{"line_number":288,"context_line":"                if self.driver_handles_share_servers or conf_pool_ips \u003d\u003d []:"},{"line_number":289,"context_line":"                    # IPs not configured in manila.conf."},{"line_number":290,"context_line":"                    if not vfs_info[\u0027vfsip\u0027][\u0027address\u0027]:"},{"line_number":291,"context_line":"                        msg \u003d _(\"Unsupported configuration. \""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_5d53ac6c","line":288,"range":{"start_line":288,"start_character":19,"end_line":288,"end_character":52},"updated":"2016-08-31 06:19:40.000000000","message":"This should be !dhss.  dhss\u003dTrue doesn\u0027t need the array IPs.","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"9e4bb1b6287f6493da862e87926f3f9a87b29f89","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                # This also validates the client, connection, firmware, WSAPI,"},{"line_number":286,"context_line":"                # FPG..."},{"line_number":287,"context_line":"                vfs_info \u003d mediator.get_vfs(pool_name)"},{"line_number":288,"context_line":"                if self.driver_handles_share_servers or conf_pool_ips \u003d\u003d []:"},{"line_number":289,"context_line":"                    # IPs not configured in manila.conf."},{"line_number":290,"context_line":"                    if not vfs_info[\u0027vfsip\u0027][\u0027address\u0027]:"},{"line_number":291,"context_line":"                        msg \u003d _(\"Unsupported configuration. \""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_e7959b88","line":288,"range":{"start_line":288,"start_character":19,"end_line":288,"end_character":52},"in_reply_to":"fa7ab95a_5d53ac6c","updated":"2016-08-31 17:53:15.000000000","message":"Correct. DHSS does not req conf ips. Redone with more condition checks","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f8a56dd24c743e0bfcc8749144fce7301f73d0f9","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        # self.fpgs \u003d {"},{"line_number":310,"context_line":"        #            \u0027pool_name1\u0027 : {\u0027vfs_name\u0027: [ip addr1, ..., ip addr4]},"},{"line_number":311,"context_line":"        #            ..."},{"line_number":312,"context_line":"        # }"},{"line_number":313,"context_line":"        _construct_fpg()"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        # Don\u0027t set _hpe3par until it is ready. Otherwise _update_stats fails."}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_c92f02a6","line":312,"updated":"2016-08-31 04:04:28.000000000","message":"Remove commented out code.","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"9e4bb1b6287f6493da862e87926f3f9a87b29f89","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        # self.fpgs \u003d {"},{"line_number":310,"context_line":"        #            \u0027pool_name1\u0027 : {\u0027vfs_name\u0027: [ip addr1, ..., ip addr4]},"},{"line_number":311,"context_line":"        #            ..."},{"line_number":312,"context_line":"        # }"},{"line_number":313,"context_line":"        _construct_fpg()"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        # Don\u0027t set _hpe3par until it is ready. Otherwise _update_stats fails."}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_f6cd5387","line":312,"in_reply_to":"fa7ab95a_c92f02a6","updated":"2016-08-31 17:53:15.000000000","message":"Done","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"ce506afb18b3a946959289bedb3f7c7a021a2fb1","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        # self.fpgs \u003d {"},{"line_number":310,"context_line":"        #            \u0027pool_name1\u0027 : {\u0027vfs_name\u0027: [ip addr1, ..., ip addr4]},"},{"line_number":311,"context_line":"        #            ..."},{"line_number":312,"context_line":"        # }"},{"line_number":313,"context_line":"        _construct_fpg()"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        # Don\u0027t set _hpe3par until it is ready. Otherwise _update_stats fails."}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_fdf1e06b","line":312,"in_reply_to":"fa7ab95a_c92f02a6","updated":"2016-08-31 06:19:40.000000000","message":"agree. If you mean to document what the return dict looks like, do it at the top. This here looks like leftover junk.","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"9e4bb1b6287f6493da862e87926f3f9a87b29f89","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        # self.fpgs \u003d {"},{"line_number":310,"context_line":"        #            \u0027pool_name1\u0027 : {\u0027vfs_name\u0027: [ip addr1, ..., ip addr4]},"},{"line_number":311,"context_line":"        #            ..."},{"line_number":312,"context_line":"        # }"},{"line_number":313,"context_line":"        _construct_fpg()"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        # Don\u0027t set _hpe3par until it is ready. Otherwise _update_stats fails."}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_36c89b74","line":312,"in_reply_to":"fa7ab95a_fdf1e06b","updated":"2016-08-31 17:53:15.000000000","message":"Removed.","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"ce506afb18b3a946959289bedb3f7c7a021a2fb1","unresolved":false,"context_lines":[{"line_number":623,"context_line":"            \u0027vendor_name\u0027: \u0027HPE\u0027,"},{"line_number":624,"context_line":"            \u0027driver_version\u0027: self.VERSION,"},{"line_number":625,"context_line":"            \u0027storage_protocol\u0027: \u0027NFS_CIFS\u0027,"},{"line_number":626,"context_line":"            \u0027driver_handles_share_servers\u0027: self.driver_handles_share_servers,"},{"line_number":627,"context_line":"            \u0027total_capacity_gb\u0027: 0,"},{"line_number":628,"context_line":"            \u0027free_capacity_gb\u0027: 0,"},{"line_number":629,"context_line":"            \u0027provisioned_capacity_gb\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_9d2e14a4","line":626,"updated":"2016-08-31 06:19:40.000000000","message":"this seems like an unnecessary change, too","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"9e4bb1b6287f6493da862e87926f3f9a87b29f89","unresolved":false,"context_lines":[{"line_number":623,"context_line":"            \u0027vendor_name\u0027: \u0027HPE\u0027,"},{"line_number":624,"context_line":"            \u0027driver_version\u0027: self.VERSION,"},{"line_number":625,"context_line":"            \u0027storage_protocol\u0027: \u0027NFS_CIFS\u0027,"},{"line_number":626,"context_line":"            \u0027driver_handles_share_servers\u0027: self.driver_handles_share_servers,"},{"line_number":627,"context_line":"            \u0027total_capacity_gb\u0027: 0,"},{"line_number":628,"context_line":"            \u0027free_capacity_gb\u0027: 0,"},{"line_number":629,"context_line":"            \u0027provisioned_capacity_gb\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_27f2239b","line":626,"in_reply_to":"fa7ab95a_9d2e14a4","updated":"2016-08-31 17:53:15.000000000","message":"Done","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f8a56dd24c743e0bfcc8749144fce7301f73d0f9","unresolved":false,"context_lines":[{"line_number":631,"context_line":"            \u0027max_over_subscription_ratio\u0027: max_over_subscription_ratio,"},{"line_number":632,"context_line":"            \u0027qos\u0027: False,"},{"line_number":633,"context_line":"            \u0027thin_provisioning\u0027: True,  # 3PAR default is thin"},{"line_number":634,"context_line":"            \u0027snapshot_support\u0027: True,"},{"line_number":635,"context_line":"        }"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"        if not self._hpe3par:"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_6c0fe42e","line":634,"updated":"2016-08-31 04:04:28.000000000","message":"This is not related to the pool support patch.  Please add it in a separate patch.","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"9e4bb1b6287f6493da862e87926f3f9a87b29f89","unresolved":false,"context_lines":[{"line_number":631,"context_line":"            \u0027max_over_subscription_ratio\u0027: max_over_subscription_ratio,"},{"line_number":632,"context_line":"            \u0027qos\u0027: False,"},{"line_number":633,"context_line":"            \u0027thin_provisioning\u0027: True,  # 3PAR default is thin"},{"line_number":634,"context_line":"            \u0027snapshot_support\u0027: True,"},{"line_number":635,"context_line":"        }"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"        if not self._hpe3par:"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_47ef27b0","line":634,"in_reply_to":"fa7ab95a_6c0fe42e","updated":"2016-08-31 17:53:15.000000000","message":"Done","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"ce506afb18b3a946959289bedb3f7c7a021a2fb1","unresolved":false,"context_lines":[{"line_number":631,"context_line":"            \u0027max_over_subscription_ratio\u0027: max_over_subscription_ratio,"},{"line_number":632,"context_line":"            \u0027qos\u0027: False,"},{"line_number":633,"context_line":"            \u0027thin_provisioning\u0027: True,  # 3PAR default is thin"},{"line_number":634,"context_line":"            \u0027snapshot_support\u0027: True,"},{"line_number":635,"context_line":"        }"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"        if not self._hpe3par:"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_7d5a3052","line":634,"in_reply_to":"fa7ab95a_6c0fe42e","updated":"2016-08-31 06:19:40.000000000","message":"agree","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"9e4bb1b6287f6493da862e87926f3f9a87b29f89","unresolved":false,"context_lines":[{"line_number":631,"context_line":"            \u0027max_over_subscription_ratio\u0027: max_over_subscription_ratio,"},{"line_number":632,"context_line":"            \u0027qos\u0027: False,"},{"line_number":633,"context_line":"            \u0027thin_provisioning\u0027: True,  # 3PAR default is thin"},{"line_number":634,"context_line":"            \u0027snapshot_support\u0027: True,"},{"line_number":635,"context_line":"        }"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"        if not self._hpe3par:"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_672a6be9","line":634,"in_reply_to":"fa7ab95a_7d5a3052","updated":"2016-08-31 17:53:15.000000000","message":"Done","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"ce506afb18b3a946959289bedb3f7c7a021a2fb1","unresolved":false,"context_lines":[{"line_number":642,"context_line":"            for fpg in self.fpgs:"},{"line_number":643,"context_line":"                fpg_status \u003d self._hpe3par.get_fpg_status(fpg)"},{"line_number":644,"context_line":"                fpg_status[\u0027reserved_percentage\u0027] \u003d reserved_share_percentage"},{"line_number":645,"context_line":"                stats.setdefault(\u0027pools\u0027, []).append(fpg_status)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        super(HPE3ParShareDriver, self)._update_share_stats(stats)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_380d1638","line":645,"updated":"2016-08-31 06:19:40.000000000","message":"why did you remove the LOG.debug?","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"9e4bb1b6287f6493da862e87926f3f9a87b29f89","unresolved":false,"context_lines":[{"line_number":642,"context_line":"            for fpg in self.fpgs:"},{"line_number":643,"context_line":"                fpg_status \u003d self._hpe3par.get_fpg_status(fpg)"},{"line_number":644,"context_line":"                fpg_status[\u0027reserved_percentage\u0027] \u003d reserved_share_percentage"},{"line_number":645,"context_line":"                stats.setdefault(\u0027pools\u0027, []).append(fpg_status)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        super(HPE3ParShareDriver, self)._update_share_stats(stats)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_27778303","line":645,"in_reply_to":"fa7ab95a_380d1638","updated":"2016-08-31 17:53:15.000000000","message":"Done","commit_id":"5dfd0d9d7194a535a0531eec2c737f7791c98fb2"}],"manila/share/drivers/hpe/hpe_3par_mediator.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d2bdc943c9a7efadbde04bf91023d45d9e610d7a","unresolved":false,"context_lines":[{"line_number":668,"context_line":"            # not treat this as an error_deleting issue. We will allow the"},{"line_number":669,"context_line":"            # delete to continue as requested."},{"line_number":670,"context_line":"            self._delete_file_tree(share_name, protocol, fpg, vfs, fstore,"},{"line_number":671,"context_line":"                                   share_ip)"},{"line_number":672,"context_line":"            if fstore:"},{"line_number":673,"context_line":"                # reduce the fsquota by share size when a share is deleted."},{"line_number":674,"context_line":"                self._update_capacity_quotas(fstore, 0, share_size, fpg, vfs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_bc871f11","line":671,"range":{"start_line":671,"start_character":31,"end_line":671,"end_character":44},"updated":"2016-06-28 16:11:46.000000000","message":"We need to use and admin IP for this.","commit_id":"fe00b87de18ac6e13a04f43f508c52d7e295a694"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1790d8f691e3b2fbb38683099e70be63641b3e93","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            message \u003d (_(\u0027Invalid protocol. Expected nfs or smb. Got %s.\u0027) %"},{"line_number":310,"context_line":"                       protocol)"},{"line_number":311,"context_line":"            LOG.error(message)"},{"line_number":312,"context_line":"            raise exception.InvalidInput(reason\u003dmessage)"},{"line_number":313,"context_line":"        return protocol"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_6d31e959","line":312,"range":{"start_line":312,"start_character":28,"end_line":312,"end_character":40},"updated":"2016-08-30 07:11:53.000000000","message":"InvalidShareAccess(reason\u003dmessage)","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d41b4c608b937109f6d9ed9d71dab26f8dbf6691","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            message \u003d (_(\u0027Invalid protocol. Expected nfs or smb. Got %s.\u0027) %"},{"line_number":310,"context_line":"                       protocol)"},{"line_number":311,"context_line":"            LOG.error(message)"},{"line_number":312,"context_line":"            raise exception.InvalidInput(reason\u003dmessage)"},{"line_number":313,"context_line":"        return protocol"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_127bed7b","line":312,"range":{"start_line":312,"start_character":28,"end_line":312,"end_character":40},"in_reply_to":"fa7ab95a_6d31e959","updated":"2016-08-30 18:29:21.000000000","message":"Done","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d35a1791b00800b41b3202fda557f52ae83fabac","unresolved":false,"context_lines":[{"line_number":709,"context_line":"                    self._grant_admin_smb_access("},{"line_number":710,"context_line":"                        protocol, fpg, vfs, fstore, temp, share\u003dro_share_name)"},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"                source_locations \u003d self.build_export_locations("},{"line_number":713,"context_line":"                    protocol, ips, source_path)"},{"line_number":714,"context_line":"                dest_locations \u003d self.build_export_locations("},{"line_number":715,"context_line":"                    protocol, ips, dest_path)"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"                self._copy_share_data("},{"line_number":718,"context_line":"                    share_id, source_locations[0], dest_locations[0], protocol)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_d7e254d4","line":715,"range":{"start_line":712,"start_character":0,"end_line":715,"end_character":45},"updated":"2016-08-30 18:10:45.000000000","message":"For DHSS, these won\u0027t be accessible. I think we need to keep hpe3par_share_ip_address to have an admin access IP until all share access moves to m-dat.","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"a73179f443cfe3b59a51ce34d5986b08aa8cc10a","unresolved":false,"context_lines":[{"line_number":709,"context_line":"                    self._grant_admin_smb_access("},{"line_number":710,"context_line":"                        protocol, fpg, vfs, fstore, temp, share\u003dro_share_name)"},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"                source_locations \u003d self.build_export_locations("},{"line_number":713,"context_line":"                    protocol, ips, source_path)"},{"line_number":714,"context_line":"                dest_locations \u003d self.build_export_locations("},{"line_number":715,"context_line":"                    protocol, ips, dest_path)"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"                self._copy_share_data("},{"line_number":718,"context_line":"                    share_id, source_locations[0], dest_locations[0], protocol)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_82e15a9d","line":715,"range":{"start_line":712,"start_character":0,"end_line":715,"end_character":45},"in_reply_to":"fa7ab95a_d7e254d4","updated":"2016-08-30 23:36:42.000000000","message":"As discussed and addressed using share_server, it will work now.","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"}],"manila/share/manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d35c1af66453cd8ce514cb6dfee1cf71e0cdd486","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                # Create share server on backend with data from db."},{"line_number":465,"context_line":"                compatible_share_server \u003d self._setup_server("},{"line_number":466,"context_line":"                    context, compatible_share_server,"},{"line_number":467,"context_line":"                    share_instance_host\u003dshare_instance[\u0027host\u0027])"},{"line_number":468,"context_line":"                LOG.info(_LI(\"Share server created successfully.\"))"},{"line_number":469,"context_line":"            else:"},{"line_number":470,"context_line":"                LOG.info(_LI(\"Used preexisting share server \""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_26ba13c1","line":467,"range":{"start_line":467,"start_character":20,"end_line":467,"end_character":62},"updated":"2016-08-26 22:24:18.000000000","message":"this can be moved to the metadata dict that the method on L#2343 is already expecting. However, please call the key \u0027request_host\u0027","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d5c326067fa500b3064968fcc2f6bdcdb2ef6d3b","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                # Create share server on backend with data from db."},{"line_number":465,"context_line":"                compatible_share_server \u003d self._setup_server("},{"line_number":466,"context_line":"                    context, compatible_share_server,"},{"line_number":467,"context_line":"                    share_instance_host\u003dshare_instance[\u0027host\u0027])"},{"line_number":468,"context_line":"                LOG.info(_LI(\"Share server created successfully.\"))"},{"line_number":469,"context_line":"            else:"},{"line_number":470,"context_line":"                LOG.info(_LI(\"Used preexisting share server \""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_a2014c3a","line":467,"range":{"start_line":467,"start_character":20,"end_line":467,"end_character":62},"in_reply_to":"fa7ab95a_26ba13c1","updated":"2016-08-29 23:21:54.000000000","message":"Done","commit_id":"9c8e221dacaf9a96661af32ed739f3d511fece80"}],"manila/tests/share/drivers/hpe/test_hpe_3par_constants.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1790d8f691e3b2fbb38683099e70be63641b3e93","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    \u0027share_proto\u0027: NFS,"},{"line_number":159,"context_line":"    \u0027export_location\u0027: EXPECTED_LOCATION,"},{"line_number":160,"context_line":"    \u0027size\u0027: 1234,"},{"line_number":161,"context_line":"    \u0027host\u0027: EXPECTED_HOST"},{"line_number":162,"context_line":"}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"ACCESS_INFO \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_ed525966","line":161,"range":{"start_line":161,"start_character":24,"end_line":161,"end_character":25},"updated":"2016-08-30 07:11:53.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d41b4c608b937109f6d9ed9d71dab26f8dbf6691","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    \u0027share_proto\u0027: NFS,"},{"line_number":159,"context_line":"    \u0027export_location\u0027: EXPECTED_LOCATION,"},{"line_number":160,"context_line":"    \u0027size\u0027: 1234,"},{"line_number":161,"context_line":"    \u0027host\u0027: EXPECTED_HOST"},{"line_number":162,"context_line":"}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"ACCESS_INFO \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_b28a4162","line":161,"range":{"start_line":161,"start_character":24,"end_line":161,"end_character":25},"in_reply_to":"fa7ab95a_ed525966","updated":"2016-08-30 18:29:21.000000000","message":"Done","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1790d8f691e3b2fbb38683099e70be63641b3e93","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        \u0027id\u0027: EXPECTED_SHARE_ID,"},{"line_number":176,"context_line":"        \u0027share_proto\u0027: NFS,"},{"line_number":177,"context_line":"        \u0027export_location\u0027: EXPECTED_LOCATION,"},{"line_number":178,"context_line":"        \u0027host\u0027: EXPECTED_HOST"},{"line_number":179,"context_line":"    },"},{"line_number":180,"context_line":"}"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_0d4e9dc0","line":178,"range":{"start_line":178,"start_character":28,"end_line":178,"end_character":29},"updated":"2016-08-30 07:11:53.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d41b4c608b937109f6d9ed9d71dab26f8dbf6691","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        \u0027id\u0027: EXPECTED_SHARE_ID,"},{"line_number":176,"context_line":"        \u0027share_proto\u0027: NFS,"},{"line_number":177,"context_line":"        \u0027export_location\u0027: EXPECTED_LOCATION,"},{"line_number":178,"context_line":"        \u0027host\u0027: EXPECTED_HOST"},{"line_number":179,"context_line":"    },"},{"line_number":180,"context_line":"}"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_f2ee8920","line":178,"range":{"start_line":178,"start_character":28,"end_line":178,"end_character":29},"in_reply_to":"fa7ab95a_0d4e9dc0","updated":"2016-08-30 18:29:21.000000000","message":"Done","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"}],"manila/tests/share/drivers/hpe/test_hpe_3par_driver.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"5b7e73d7bdbee9445938cdc29b50e72ba36927fd","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @ddt.data(\u0027sharenetfpg, 10.256.0.1\u0027,"},{"line_number":45,"context_line":"              None,"},{"line_number":46,"context_line":"              \u0027samplefpg, 10.0.0.1, 10.0.0.2, 10.0.0.3, 10.0.0.4, 10.0.0.5\u0027)"},{"line_number":47,"context_line":"    def test_FPG_type_failures(self, value):"},{"line_number":48,"context_line":"        fpg_type_obj \u003d hpe3pardriver.FPG()"},{"line_number":49,"context_line":"        self.assertRaises(exception.HPE3ParInvalid, fpg_type_obj, value)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_7ecd1130","line":46,"updated":"2016-08-30 08:24:00.000000000","message":"how about an empty string as value.","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d41b4c608b937109f6d9ed9d71dab26f8dbf6691","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @ddt.data(\u0027sharenetfpg, 10.256.0.1\u0027,"},{"line_number":45,"context_line":"              None,"},{"line_number":46,"context_line":"              \u0027samplefpg, 10.0.0.1, 10.0.0.2, 10.0.0.3, 10.0.0.4, 10.0.0.5\u0027)"},{"line_number":47,"context_line":"    def test_FPG_type_failures(self, value):"},{"line_number":48,"context_line":"        fpg_type_obj \u003d hpe3pardriver.FPG()"},{"line_number":49,"context_line":"        self.assertRaises(exception.HPE3ParInvalid, fpg_type_obj, value)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_f2d5a942","line":46,"in_reply_to":"fa7ab95a_7ecd1130","updated":"2016-08-30 18:29:21.000000000","message":"Done","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"5b7e73d7bdbee9445938cdc29b50e72ba36927fd","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @ddt.data((\u0027samplefpg, 10.0.0.1\u0027, {\u0027samplefpg\u0027: [\u002710.0.0.1\u0027]}),"},{"line_number":52,"context_line":"              (\u0027samplefpg, 10.0.0.1, 10.0.0.2\u0027,"},{"line_number":53,"context_line":"               {\u0027samplefpg\u0027: [\u002710.0.0.1\u0027, \u002710.0.0.2\u0027]}))"},{"line_number":54,"context_line":"    @ddt.unpack"},{"line_number":55,"context_line":"    def test_FPG_type_success(self, value, expected_fpg):"},{"line_number":56,"context_line":"        fpg_type_obj \u003d hpe3pardriver.FPG()"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_5e34cdfa","line":53,"updated":"2016-08-30 08:24:00.000000000","message":"please test the case that no IPs configured.","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"d41b4c608b937109f6d9ed9d71dab26f8dbf6691","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @ddt.data((\u0027samplefpg, 10.0.0.1\u0027, {\u0027samplefpg\u0027: [\u002710.0.0.1\u0027]}),"},{"line_number":52,"context_line":"              (\u0027samplefpg, 10.0.0.1, 10.0.0.2\u0027,"},{"line_number":53,"context_line":"               {\u0027samplefpg\u0027: [\u002710.0.0.1\u0027, \u002710.0.0.2\u0027]}))"},{"line_number":54,"context_line":"    @ddt.unpack"},{"line_number":55,"context_line":"    def test_FPG_type_success(self, value, expected_fpg):"},{"line_number":56,"context_line":"        fpg_type_obj \u003d hpe3pardriver.FPG()"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_f263e9ae","line":53,"in_reply_to":"fa7ab95a_5e34cdfa","updated":"2016-08-30 18:29:21.000000000","message":"Done","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"5b7e73d7bdbee9445938cdc29b50e72ba36927fd","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        self.assertEqual(constants.EXPECTED_FPG_MAP, self.driver.fpgs)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_driver_setup_success_no_dhss_no_conf_ss_ip(self):"},{"line_number":160,"context_line":"        \"\"\"test_driver_setup_success_no_dhss_no_conf_ss_ip"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        Driver do_setup with dhss\u003dFalse, share server ip not set in config file"},{"line_number":163,"context_line":"        but discoverable at 3par array"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_5902270b","line":160,"range":{"start_line":160,"start_character":11,"end_line":160,"end_character":58},"updated":"2016-08-30 08:24:00.000000000","message":"not necessary repeat method name.","commit_id":"ace7d7784a2d7e56a4246aac22c8015220f543ef"}]}
