)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"a9c608efcec16ef22cb8a478df3ce8b5b71f388c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ensure_share is not a required feature for manila drivers, but when a"},{"line_number":10,"context_line":"NotImplementedError exception is thrown by the driver, it is currently being"},{"line_number":11,"context_line":"logged as an error. This patch fixex that by skipping this log if the exception"},{"line_number":12,"context_line":"is a NotImplementedError."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I754071ccf4084095bfeec2e4c60cb984ae2f6d4a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a9d85d2_ff925d56","line":11,"range":{"start_line":11,"start_character":31,"end_line":11,"end_character":36},"updated":"2016-06-20 17:51:57.000000000","message":"s/fixex/fixes","commit_id":"225eed4004a789f531d895d50440dceb0984becd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"a9c608efcec16ef22cb8a478df3ce8b5b71f388c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix logging error on ensure_share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ensure_share is not a required feature for manila drivers, but when a"},{"line_number":10,"context_line":"NotImplementedError exception is thrown by the driver, it is currently being"},{"line_number":11,"context_line":"logged as an error. This patch fixex that by skipping this log if the exception"},{"line_number":12,"context_line":"is a NotImplementedError."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I754071ccf4084095bfeec2e4c60cb984ae2f6d4a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a9d85d2_df820100","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":79},"updated":"2016-06-20 17:51:57.000000000","message":"you should not go beyond 79 characters.","commit_id":"225eed4004a789f531d895d50440dceb0984becd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f2feb8a1d59ac4fde4be7c7624ea9af3655e996d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix logging error on ensure_share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ensure_share is not a required feature for manila drivers, but when a"},{"line_number":10,"context_line":"NotImplementedError exception is thrown by the driver, it is currently being"},{"line_number":11,"context_line":"logged as an error. This patch fixes that by skipping this log if the"},{"line_number":12,"context_line":"exception is a NotImplementedError."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3aaa91ec_05045313","line":10,"range":{"start_line":10,"start_character":71,"end_line":10,"end_character":76},"updated":"2016-06-21 23:52:18.000000000","message":"limit line length \u003c 79 characters","commit_id":"e8ac8776859f495f596841b46cb38fdf9c3ed69d"}],"manila/share/manager.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"a9c608efcec16ef22cb8a478df3ce8b5b71f388c","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                export_locations \u003d self.driver.ensure_share("},{"line_number":306,"context_line":"                    ctxt, share_instance, share_server\u003dshare_server)"},{"line_number":307,"context_line":"            except Exception as e:"},{"line_number":308,"context_line":"                if not isinstance(e, NotImplementedError):"},{"line_number":309,"context_line":"                    LOG.error("},{"line_number":310,"context_line":"                        _LE(\"Caught exception trying ensure share \u0027%(s_id)s\u0027. \""},{"line_number":311,"context_line":"                            \"Exception: \\n%(e)s.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_5ff3b19e","line":308,"range":{"start_line":308,"start_character":15,"end_line":308,"end_character":58},"updated":"2016-06-20 17:51:57.000000000","message":"I would add an \"else\" clause with a LOG.debug to log that ensure was invoked but was not implemented. This is good to debug what is happening in init_host.","commit_id":"225eed4004a789f531d895d50440dceb0984becd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f2feb8a1d59ac4fde4be7c7624ea9af3655e996d","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                        {\u0027s_id\u0027: share_instance[\u0027id\u0027], \u0027e\u0027: six.text_type(e)},"},{"line_number":313,"context_line":"                    )"},{"line_number":314,"context_line":"                else:"},{"line_number":315,"context_line":"                    LOG.debug(\"Ensure share not implemented. Skipping it.\")"},{"line_number":316,"context_line":"                continue"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"            if export_locations:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_65ca77a3","line":315,"range":{"start_line":315,"start_character":20,"end_line":315,"end_character":75},"updated":"2016-06-21 23:52:18.000000000","message":"We log this for every share? That seems unnecessary imho.","commit_id":"e8ac8776859f495f596841b46cb38fdf9c3ed69d"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"4009a919aff71dbd0b499e7d54a9351016a24705","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                        {\u0027s_id\u0027: share_instance[\u0027id\u0027], \u0027e\u0027: six.text_type(e)},"},{"line_number":313,"context_line":"                    )"},{"line_number":314,"context_line":"                else:"},{"line_number":315,"context_line":"                    LOG.debug(\"Ensure share not implemented. Skipping it.\")"},{"line_number":316,"context_line":"                continue"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"            if export_locations:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_cd48a25e","line":315,"range":{"start_line":315,"start_character":20,"end_line":315,"end_character":75},"in_reply_to":"3aaa91ec_65ca77a3","updated":"2016-06-22 08:43:35.000000000","message":"+1","commit_id":"e8ac8776859f495f596841b46cb38fdf9c3ed69d"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"bb48bca3685eb79f91ab4601aa2cb7693e7b12e6","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                        {\u0027s_id\u0027: share_instance[\u0027id\u0027], \u0027e\u0027: six.text_type(e)},"},{"line_number":313,"context_line":"                    )"},{"line_number":314,"context_line":"                else:"},{"line_number":315,"context_line":"                    LOG.debug(\"Ensure share not implemented. Skipping it.\")"},{"line_number":316,"context_line":"                continue"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"            if export_locations:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_17d2a800","line":315,"range":{"start_line":315,"start_character":20,"end_line":315,"end_character":75},"in_reply_to":"3aaa91ec_cd48a25e","updated":"2016-06-22 12:25:28.000000000","message":"Rodrigo suggested that... I can remove it.","commit_id":"e8ac8776859f495f596841b46cb38fdf9c3ed69d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2111bbe6d90f91975e346a959123c213116b6b6d","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                export_locations \u003d self.driver.ensure_share("},{"line_number":306,"context_line":"                    ctxt, share_instance, share_server\u003dshare_server)"},{"line_number":307,"context_line":"            except Exception as e:"},{"line_number":308,"context_line":"                if not isinstance(e, NotImplementedError):"},{"line_number":309,"context_line":"                    LOG.error("},{"line_number":310,"context_line":"                        _LE(\"Caught exception trying ensure share \u0027%(s_id)s\u0027. \""},{"line_number":311,"context_line":"                            \"Exception: \\n%(e)s.\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_89820051","line":308,"range":{"start_line":308,"start_character":15,"end_line":308,"end_character":58},"updated":"2016-06-22 12:34:14.000000000","message":"It was a Debug level log, I really suggest adding back. Not a deal breaker for me, but I think it is useful.","commit_id":"bb99a8814f4413fe9ff377aa13678c3925671aab"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"984d4983013ce09bdd59f100e92181fb55039475","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                export_locations \u003d self.driver.ensure_share("},{"line_number":306,"context_line":"                    ctxt, share_instance, share_server\u003dshare_server)"},{"line_number":307,"context_line":"            except Exception as e:"},{"line_number":308,"context_line":"                if not isinstance(e, NotImplementedError):"},{"line_number":309,"context_line":"                    LOG.error("},{"line_number":310,"context_line":"                        _LE(\"Caught exception trying ensure share \u0027%(s_id)s\u0027. \""},{"line_number":311,"context_line":"                            \"Exception: \\n%(e)s.\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_df74b6d0","line":308,"range":{"start_line":308,"start_character":15,"end_line":308,"end_character":58},"in_reply_to":"3aaa91ec_89820051","updated":"2016-06-22 13:15:51.000000000","message":"Rodrigo: Isn\u0027t ensure_share an optional driver method? So, if a driver doesn\u0027t implement it, it would be weird seeing debug logs... I mean, what can the administrators do about it? With the various implementations that i have seen for ensure_share, i\u0027m not sure what the expectations are for that method...","commit_id":"bb99a8814f4413fe9ff377aa13678c3925671aab"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5b28e7af36ce1f9a878168517293e2197ef2717b","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                export_locations \u003d self.driver.ensure_share("},{"line_number":306,"context_line":"                    ctxt, share_instance, share_server\u003dshare_server)"},{"line_number":307,"context_line":"            except Exception as e:"},{"line_number":308,"context_line":"                if not isinstance(e, NotImplementedError):"},{"line_number":309,"context_line":"                    LOG.error("},{"line_number":310,"context_line":"                        _LE(\"Caught exception trying ensure share \u0027%(s_id)s\u0027. \""},{"line_number":311,"context_line":"                            \"Exception: \\n%(e)s.\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_b62bbeea","line":308,"range":{"start_line":308,"start_character":15,"end_line":308,"end_character":58},"in_reply_to":"3aaa91ec_95b15b92","updated":"2016-06-22 19:26:08.000000000","message":"okay, we can do that..","commit_id":"bb99a8814f4413fe9ff377aa13678c3925671aab"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2f5e39f91dd5ee1954ec974ea066009cec234b6a","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                export_locations \u003d self.driver.ensure_share("},{"line_number":306,"context_line":"                    ctxt, share_instance, share_server\u003dshare_server)"},{"line_number":307,"context_line":"            except Exception as e:"},{"line_number":308,"context_line":"                if not isinstance(e, NotImplementedError):"},{"line_number":309,"context_line":"                    LOG.error("},{"line_number":310,"context_line":"                        _LE(\"Caught exception trying ensure share \u0027%(s_id)s\u0027. \""},{"line_number":311,"context_line":"                            \"Exception: \\n%(e)s.\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_95b15b92","line":308,"range":{"start_line":308,"start_character":15,"end_line":308,"end_character":58},"in_reply_to":"3aaa91ec_df74b6d0","updated":"2016-06-22 18:54:50.000000000","message":"My suggestion is only regarding a message for debug purposes. Since it is run during initializaiton, if something is going wrong during initialization and the cloud operator enables debug to see what is going on, I think seeing a \"Driver does not implement ensure share, skipping\" would be a good way to indicate that the code passed through there successfully. This method loops through several shares so knowing which one is breaking and which one is not might be useful.","commit_id":"bb99a8814f4413fe9ff377aa13678c3925671aab"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2f5e39f91dd5ee1954ec974ea066009cec234b6a","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                            \"Exception: \\n%(e)s.\"),"},{"line_number":312,"context_line":"                        {\u0027s_id\u0027: share_instance[\u0027id\u0027], \u0027e\u0027: six.text_type(e)},"},{"line_number":313,"context_line":"                    )"},{"line_number":314,"context_line":"                continue"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"            if export_locations:"},{"line_number":317,"context_line":"                self.db.share_export_locations_update("}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_305b5530","line":314,"range":{"start_line":314,"start_character":16,"end_line":314,"end_character":24},"updated":"2016-06-22 18:54:50.000000000","message":"I just spotted this. So this is inside an except block that is reached when a driver fails to ensure by throwing an exception, and it is outside of the condition that checks if it is in fact a real exception or just NotImplemented, but this statement is telling the loop to skip the below code. Updating export_locations does not make sense if this failed, but update_access may make sense, even if driver does not implement ensure_share, which is unrelated to this. Git blame shows u_glide introduced this so I don\u0027t know if this is correct or not. I know this is unrelated to commit goal, just pointing out one more possible thing to fix.","commit_id":"bb99a8814f4413fe9ff377aa13678c3925671aab"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5b28e7af36ce1f9a878168517293e2197ef2717b","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                            \"Exception: \\n%(e)s.\"),"},{"line_number":312,"context_line":"                        {\u0027s_id\u0027: share_instance[\u0027id\u0027], \u0027e\u0027: six.text_type(e)},"},{"line_number":313,"context_line":"                    )"},{"line_number":314,"context_line":"                continue"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"            if export_locations:"},{"line_number":317,"context_line":"                self.db.share_export_locations_update("}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_762156fb","line":314,"range":{"start_line":314,"start_character":16,"end_line":314,"end_character":24},"in_reply_to":"3aaa91ec_305b5530","updated":"2016-06-22 19:26:08.000000000","message":"+1","commit_id":"bb99a8814f4413fe9ff377aa13678c3925671aab"}]}
