)]}'
{"manila/db/migrations/alembic/versions/162a3e673105_manila_init.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3f1954a0181bdfab4006ee2b9df60911fe1d7a91","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        Column(\u0027deleted\u0027, String(length\u003d36), default\u003d\u0027False\u0027),"},{"line_number":284,"context_line":"        Column(\u0027id\u0027, String(length\u003d36), primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":285,"context_line":"        Column(\u0027project_id\u0027, String(length\u003d36), nullable\u003dFalse),"},{"line_number":286,"context_line":"        Column(\u0027user_id\u0027, String(length\u003d255)),"},{"line_number":287,"context_line":"        Column(\u0027neutron_net_id\u0027, String(length\u003d36), nullable\u003dTrue),"},{"line_number":288,"context_line":"        Column(\u0027neutron_subnet_id\u0027, String(length\u003d36), nullable\u003dTrue),"},{"line_number":289,"context_line":"        Column(\u0027network_type\u0027, String(length\u003d32), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_d8830503","line":286,"range":{"start_line":286,"start_character":38,"end_line":286,"end_character":46},"updated":"2016-06-21 15:14:16.000000000","message":"This file should not be changed.","commit_id":"dc839d10ea75ffb32a92da4add8939dd3a1828b6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"05226ffb9fb9b568c7eb542cd71ddde26d5bf2e3","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        Column(\u0027deleted\u0027, String(length\u003d36), default\u003d\u0027False\u0027),"},{"line_number":284,"context_line":"        Column(\u0027id\u0027, String(length\u003d36), primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":285,"context_line":"        Column(\u0027project_id\u0027, String(length\u003d36), nullable\u003dFalse),"},{"line_number":286,"context_line":"        Column(\u0027user_id\u0027, String(length\u003d255)),"},{"line_number":287,"context_line":"        Column(\u0027neutron_net_id\u0027, String(length\u003d36), nullable\u003dTrue),"},{"line_number":288,"context_line":"        Column(\u0027neutron_subnet_id\u0027, String(length\u003d36), nullable\u003dTrue),"},{"line_number":289,"context_line":"        Column(\u0027network_type\u0027, String(length\u003d32), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_32e7c5b1","line":286,"range":{"start_line":286,"start_character":38,"end_line":286,"end_character":46},"in_reply_to":"5a9d85d2_d8830503","updated":"2016-06-21 23:29:41.000000000","message":"+1","commit_id":"dc839d10ea75ffb32a92da4add8939dd3a1828b6"}],"manila/db/migrations/alembic/versions/221a83cfd85b_change_user_id_length.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3f1954a0181bdfab4006ee2b9df60911fe1d7a91","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def upgrade():"},{"line_number":38,"context_line":"    LOG.info(_LI(\"Changing user_id length for share_networks\"))"},{"line_number":39,"context_line":"    op.alter_column(\"share_networks\", \"user_id\","},{"line_number":40,"context_line":"                    type_\u003dsa.String(length\u003d255))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def downgrade():"},{"line_number":44,"context_line":"    LOG.info(_LI(\"Changing user_id length for share_networks\"))"},{"line_number":45,"context_line":"    op.alter_column(\"share_networks\", \"user_id\","},{"line_number":46,"context_line":"                    type_\u003dsa.String(length\u003d36))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_5879d5f5","line":46,"range":{"start_line":36,"start_character":0,"end_line":46,"end_character":47},"updated":"2016-06-21 15:14:16.000000000","message":"Also, need to cover it with unit tests. See example:\n\nhttps://github.com/openstack/manila/blob/master/manila/tests/db/migrations/alembic/migrations_data_checks.py","commit_id":"dc839d10ea75ffb32a92da4add8939dd3a1828b6"}],"manila/tests/db/migrations/alembic/migrations_data_checks.py":[{"author":{"_account_id":15371,"name":"Tom Patzig","email":"tom.patzig@sap.com","username":"tpatzig"},"change_message_id":"3da89efdc4d106b44ca1be4092e1e131c2fad0c2","unresolved":false,"context_lines":[{"line_number":613,"context_line":"class ShareNetwoksFieldLengthChecks("},{"line_number":614,"context_line":"        BaseMigrationChecks):"},{"line_number":615,"context_line":"    def setup_upgrade_data(self, engine):"},{"line_number":616,"context_line":"        user_id \u003d \u0027123456789123456789\u0027"},{"line_number":617,"context_line":"        project_id \u003d \u0027project_id\u0027"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"        # Create share network data"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_7044e173","line":616,"updated":"2016-06-22 09:13:57.000000000","message":"Should we maybe also check with a user_id \u003e 36 ?","commit_id":"2d98b42af74757f64776c56a7c31a809eb6a8aee"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"d7b4614904cf2d964c8a13f62eb0bab8c541879e","unresolved":false,"context_lines":[{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    def check_upgrade(self, engine, data):"},{"line_number":638,"context_line":"        # check share_networks"},{"line_number":639,"context_line":"        ss_table \u003d utils.load_table(\u0027share_networks\u0027, engine)"},{"line_number":640,"context_line":"        db_result \u003d engine.execute(ss_table.select())"},{"line_number":641,"context_line":"        self.test_case.assertTrue(db_result.rowcount \u003e 0)"},{"line_number":642,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_10d8fd52","line":639,"updated":"2016-06-22 09:05:31.000000000","message":"the same comment as the one in check_downgrade().","commit_id":"2d98b42af74757f64776c56a7c31a809eb6a8aee"},{"author":{"_account_id":15371,"name":"Tom Patzig","email":"tom.patzig@sap.com","username":"tpatzig"},"change_message_id":"ab0b0600e3f316d0d3f9c86c4db3d3ed3753ad02","unresolved":false,"context_lines":[{"line_number":649,"context_line":"            ss_table.columns.get(\u0027project_id\u0027).type.length, 255)"},{"line_number":650,"context_line":"        self.test_case.assertIsInstance("},{"line_number":651,"context_line":"            ss_table.columns.get(\u0027project_id\u0027).type, sa.VARCHAR)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        # check security_services"},{"line_number":654,"context_line":"        ss_table \u003d utils.load_table(\u0027security_services\u0027, engine)"},{"line_number":655,"context_line":"        db_result \u003d engine.execute(ss_table.select())"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_6d5a4e85","line":652,"updated":"2016-06-22 08:55:07.000000000","message":"missing rowcount check for project_id","commit_id":"2d98b42af74757f64776c56a7c31a809eb6a8aee"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"d227ada5d3c98caed696574bb772fea2aac8004b","unresolved":false,"context_lines":[{"line_number":649,"context_line":"            ss_table.columns.get(\u0027project_id\u0027).type.length, 255)"},{"line_number":650,"context_line":"        self.test_case.assertIsInstance("},{"line_number":651,"context_line":"            ss_table.columns.get(\u0027project_id\u0027).type, sa.VARCHAR)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        # check security_services"},{"line_number":654,"context_line":"        ss_table \u003d utils.load_table(\u0027security_services\u0027, engine)"},{"line_number":655,"context_line":"        db_result \u003d engine.execute(ss_table.select())"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_7057c102","line":652,"in_reply_to":"3aaa91ec_6d5a4e85","updated":"2016-06-22 09:02:34.000000000","message":"rowcount check that the query selects some rows. project_id is a column","commit_id":"2d98b42af74757f64776c56a7c31a809eb6a8aee"},{"author":{"_account_id":15371,"name":"Tom Patzig","email":"tom.patzig@sap.com","username":"tpatzig"},"change_message_id":"ab0b0600e3f316d0d3f9c86c4db3d3ed3753ad02","unresolved":false,"context_lines":[{"line_number":659,"context_line":"            ss_table.columns.get(\u0027project_id\u0027).type.length, 255)"},{"line_number":660,"context_line":"        self.test_case.assertIsInstance("},{"line_number":661,"context_line":"            ss_table.columns.get(\u0027project_id\u0027).type, sa.VARCHAR)"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"    def check_downgrade(self, engine):"},{"line_number":664,"context_line":"        # check share_networks"},{"line_number":665,"context_line":"        ss_table \u003d utils.load_table(\u0027share_networks\u0027, engine)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_8dd85af1","line":662,"updated":"2016-06-22 08:55:07.000000000","message":"the above two checks should be for column security_services, not project_id","commit_id":"2d98b42af74757f64776c56a7c31a809eb6a8aee"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"d227ada5d3c98caed696574bb772fea2aac8004b","unresolved":false,"context_lines":[{"line_number":659,"context_line":"            ss_table.columns.get(\u0027project_id\u0027).type.length, 255)"},{"line_number":660,"context_line":"        self.test_case.assertIsInstance("},{"line_number":661,"context_line":"            ss_table.columns.get(\u0027project_id\u0027).type, sa.VARCHAR)"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"    def check_downgrade(self, engine):"},{"line_number":664,"context_line":"        # check share_networks"},{"line_number":665,"context_line":"        ss_table \u003d utils.load_table(\u0027share_networks\u0027, engine)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_70f3410b","line":662,"in_reply_to":"3aaa91ec_8dd85af1","updated":"2016-06-22 09:02:34.000000000","message":"no, security_services is a table ;)","commit_id":"2d98b42af74757f64776c56a7c31a809eb6a8aee"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"d7b4614904cf2d964c8a13f62eb0bab8c541879e","unresolved":false,"context_lines":[{"line_number":662,"context_line":""},{"line_number":663,"context_line":"    def check_downgrade(self, engine):"},{"line_number":664,"context_line":"        # check share_networks"},{"line_number":665,"context_line":"        ss_table \u003d utils.load_table(\u0027share_networks\u0027, engine)"},{"line_number":666,"context_line":"        db_result \u003d engine.execute(ss_table.select())"},{"line_number":667,"context_line":"        self.test_case.assertTrue(db_result.rowcount \u003e 0)"},{"line_number":668,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_f0be11fe","line":665,"updated":"2016-06-22 09:05:31.000000000","message":"for table_name, attrs in ((\u0027share_networks\u0027,(\u0027user_id\u0027, \u0027project_id\u0027), (security_services\u0027, (\u0027project_id\u0027,)):\n    table \u003d utils.load_table(table_name)\n    db_result \u003d engine.execute(table.select())\n    self.test_case.assertTrue(db_result.rowcount \u003e 0)\n    for attr in attrs:\n      self.test_case.assertEqual(table.columns.get(attr).type.length, 36)","commit_id":"2d98b42af74757f64776c56a7c31a809eb6a8aee"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"d7b4614904cf2d964c8a13f62eb0bab8c541879e","unresolved":false,"context_lines":[{"line_number":668,"context_line":""},{"line_number":669,"context_line":"        self.test_case.assertEqual(ss_table.columns.get(\u0027user_id\u0027).type.length,"},{"line_number":670,"context_line":"                                   36)"},{"line_number":671,"context_line":"        self.test_case.assertIsInstance(ss_table.columns.get(\u0027user_id\u0027).type,"},{"line_number":672,"context_line":"                                        sa.VARCHAR)"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"        self.test_case.assertEqual("}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_cdf9c24f","line":671,"updated":"2016-06-22 09:05:31.000000000","message":"No need to check the type because it is not changed.","commit_id":"2d98b42af74757f64776c56a7c31a809eb6a8aee"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"d7b4614904cf2d964c8a13f62eb0bab8c541879e","unresolved":false,"context_lines":[{"line_number":673,"context_line":""},{"line_number":674,"context_line":"        self.test_case.assertEqual("},{"line_number":675,"context_line":"            ss_table.columns.get(\u0027project_id\u0027).type.length, 36)"},{"line_number":676,"context_line":"        self.test_case.assertIsInstance("},{"line_number":677,"context_line":"            ss_table.columns.get(\u0027project_id\u0027).type, sa.VARCHAR)"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        # check security_services"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_addb96ec","line":676,"updated":"2016-06-22 09:05:31.000000000","message":"ditto","commit_id":"2d98b42af74757f64776c56a7c31a809eb6a8aee"},{"author":{"_account_id":15371,"name":"Tom Patzig","email":"tom.patzig@sap.com","username":"tpatzig"},"change_message_id":"ab0b0600e3f316d0d3f9c86c4db3d3ed3753ad02","unresolved":false,"context_lines":[{"line_number":675,"context_line":"            ss_table.columns.get(\u0027project_id\u0027).type.length, 36)"},{"line_number":676,"context_line":"        self.test_case.assertIsInstance("},{"line_number":677,"context_line":"            ss_table.columns.get(\u0027project_id\u0027).type, sa.VARCHAR)"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        # check security_services"},{"line_number":680,"context_line":"        ss_table \u003d utils.load_table(\u0027security_services\u0027, engine)"},{"line_number":681,"context_line":"        db_result \u003d engine.execute(ss_table.select())"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_2d95e6e3","line":678,"updated":"2016-06-22 08:55:07.000000000","message":"rowcount missing, same as in check_upgrade","commit_id":"2d98b42af74757f64776c56a7c31a809eb6a8aee"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"d7b4614904cf2d964c8a13f62eb0bab8c541879e","unresolved":false,"context_lines":[{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        self.test_case.assertEqual("},{"line_number":685,"context_line":"            ss_table.columns.get(\u0027project_id\u0027).type.length, 36)"},{"line_number":686,"context_line":"        self.test_case.assertIsInstance("},{"line_number":687,"context_line":"            ss_table.columns.get(\u0027project_id\u0027).type, sa.VARCHAR)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_0df3ca74","line":686,"updated":"2016-06-22 09:05:31.000000000","message":"ditto","commit_id":"2d98b42af74757f64776c56a7c31a809eb6a8aee"},{"author":{"_account_id":15371,"name":"Tom Patzig","email":"tom.patzig@sap.com","username":"tpatzig"},"change_message_id":"ab0b0600e3f316d0d3f9c86c4db3d3ed3753ad02","unresolved":false,"context_lines":[{"line_number":684,"context_line":"        self.test_case.assertEqual("},{"line_number":685,"context_line":"            ss_table.columns.get(\u0027project_id\u0027).type.length, 36)"},{"line_number":686,"context_line":"        self.test_case.assertIsInstance("},{"line_number":687,"context_line":"            ss_table.columns.get(\u0027project_id\u0027).type, sa.VARCHAR)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_4da4b256","line":687,"updated":"2016-06-22 08:55:07.000000000","message":"wrong column, same as in check_upgrade","commit_id":"2d98b42af74757f64776c56a7c31a809eb6a8aee"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8e0016026e8db59b1aa175b84aeda0cd4a78aa4d","unresolved":false,"context_lines":[{"line_number":609,"context_line":""},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"@map_to_migration(\u0027221a83cfd85b\u0027)"},{"line_number":612,"context_line":"class ShareNetwoksFieldLengthChecks("},{"line_number":613,"context_line":"        BaseMigrationChecks):"},{"line_number":614,"context_line":"    def setup_upgrade_data(self, engine):"},{"line_number":615,"context_line":"        user_id \u003d \u0027123456789123456789\u0027"},{"line_number":616,"context_line":"        project_id \u003d \u0027project_id\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_0238b0d2","line":613,"range":{"start_line":612,"start_character":36,"end_line":613,"end_character":29},"updated":"2016-06-22 10:28:20.000000000","message":"Could be on one line.","commit_id":"926854c6b71b3fd1ba1f573c1fa21d72bb9eb325"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8e0016026e8db59b1aa175b84aeda0cd4a78aa4d","unresolved":false,"context_lines":[{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        # Create share network data"},{"line_number":619,"context_line":"        share_network_data \u003d {"},{"line_number":620,"context_line":"            \u0027id\u0027: \u0027foo_share_network_id\u0027,"},{"line_number":621,"context_line":"            \u0027user_id\u0027: user_id,"},{"line_number":622,"context_line":"            \u0027project_id\u0027: project_id,"},{"line_number":623,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_22f96c81","line":620,"range":{"start_line":620,"start_character":12,"end_line":620,"end_character":41},"updated":"2016-06-22 10:28:20.000000000","message":"You will get duplication error in DB because this ID is already used in other migration. See line 487.","commit_id":"926854c6b71b3fd1ba1f573c1fa21d72bb9eb325"}]}
