)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"eb07a218d44a558a010a4cda0a63120d41debd6b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"APIImpact"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Closes-bug: #1594922"},{"line_number":30,"context_line":"Closes-bug: #1566815"},{"line_number":31,"context_line":"Change-Id: If4bfaf7e9d963b83c13a6fea241c2eda14f7f409"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"bacf61ea_1e6db998","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":20},"updated":"2016-07-28 06:17:17.000000000","message":"It is not fixed. \n\nhttp://logs.openstack.org/67/332267/34/check/gate-manila-tempest-dsvm-postgres-zfsonlinux/64df590/logs/testr_results.html.gz","commit_id":"6931f6190f1648f09c5c6e5b57358bbffe04cf40"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"49d49e3b5155741bf1cd2b31a932e986dc7a2c1d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"APIImpact"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Closes-bug: #1594922"},{"line_number":30,"context_line":"Closes-bug: #1566815"},{"line_number":31,"context_line":"Change-Id: If4bfaf7e9d963b83c13a6fea241c2eda14f7f409"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"bacf61ea_f63b7ee9","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":20},"in_reply_to":"bacf61ea_1e6db998","updated":"2016-07-28 20:30:24.000000000","message":"Let\u0027s see if new patchset fixes it","commit_id":"6931f6190f1648f09c5c6e5b57358bbffe04cf40"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"37a439045d9b8f4be4e35b8881eb0d409749a2c5","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"APIImpact"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Closes-bug: #1594922"},{"line_number":30,"context_line":"Closes-bug: #1566815"},{"line_number":31,"context_line":"Change-Id: If4bfaf7e9d963b83c13a6fea241c2eda14f7f409"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"bacf61ea_43592e8e","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":20},"updated":"2016-08-02 16:34:29.000000000","message":"There is no real need to combine fixes for these bugs into one commit. Please, separate them.","commit_id":"1f5998d19a3eff854b68078759548afabcc7bfe0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"85bdcaf9c62131fa1ea11f86bc7f10a82595b560","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"APIImpact"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Closes-bug: #1594922"},{"line_number":30,"context_line":"Closes-bug: #1566815"},{"line_number":31,"context_line":"Change-Id: If4bfaf7e9d963b83c13a6fea241c2eda14f7f409"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"bacf61ea_8a3aae32","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":20},"in_reply_to":"bacf61ea_43592e8e","updated":"2016-08-04 12:37:57.000000000","message":"Done","commit_id":"1f5998d19a3eff854b68078759548afabcc7bfe0"}],"manila/data/utils.py":[{"author":{"_account_id":19683,"name":"Jose Falavinha","email":"jose.falavinha@fit-tecnologia.org.br","username":"jose.falavinha"},"change_message_id":"42a96dbb17ce03ac313e7580b383695624656026","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        if not self.initialized:"},{"line_number":43,"context_line":"            return {\u0027total_progress\u0027: 0}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # Empty share or empty contents"},{"line_number":46,"context_line":"        if self.completed and self.total_size \u003d\u003d 0:"},{"line_number":47,"context_line":"            return {\u0027total_progress\u0027: 100}"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_a3368d00","line":45,"range":{"start_line":45,"start_character":10,"end_line":45,"end_character":39},"updated":"2016-07-26 18:52:39.000000000","message":"This comment causes some confusion since you are doing an \"and\" operation and commented \"or\".","commit_id":"be9527b7a789a1dbdfe4ce9512229c7d21ee9ca5"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"caeea7760f12789718364eb67c971bcf9092dc1a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        if not self.initialized:"},{"line_number":43,"context_line":"            return {\u0027total_progress\u0027: 0}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # Empty share or empty contents"},{"line_number":46,"context_line":"        if self.completed and self.total_size \u003d\u003d 0:"},{"line_number":47,"context_line":"            return {\u0027total_progress\u0027: 100}"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_06668650","line":45,"range":{"start_line":45,"start_character":10,"end_line":45,"end_character":39},"in_reply_to":"dada55a8_a3368d00","updated":"2016-07-26 19:12:17.000000000","message":"indeed it causes some confusion. Although the comment is not describing the condition, the comment describes the scenarios addressed by the condition.","commit_id":"be9527b7a789a1dbdfe4ce9512229c7d21ee9ca5"},{"author":{"_account_id":19683,"name":"Jose Falavinha","email":"jose.falavinha@fit-tecnologia.org.br","username":"jose.falavinha"},"change_message_id":"42a96dbb17ce03ac313e7580b383695624656026","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            return progress"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            return {\u0027total_progress\u0027: 0}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def cancel(self):"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_636bf4b9","line":77,"range":{"start_line":77,"start_character":12,"end_line":77,"end_character":40},"updated":"2016-07-26 18:52:39.000000000","message":"Code organization, should not these returns be together at the beginning since they are the same?","commit_id":"be9527b7a789a1dbdfe4ce9512229c7d21ee9ca5"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"caeea7760f12789718364eb67c971bcf9092dc1a","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            return progress"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            return {\u0027total_progress\u0027: 0}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def cancel(self):"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_46a19e45","line":77,"range":{"start_line":77,"start_character":12,"end_line":77,"end_character":40},"in_reply_to":"dada55a8_636bf4b9","updated":"2016-07-26 19:12:17.000000000","message":"I will look into merging them.","commit_id":"be9527b7a789a1dbdfe4ce9512229c7d21ee9ca5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.completed \u003d False"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_progress(self):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        # Empty share or empty contents"},{"line_number":43,"context_line":"        if self.completed and self.total_size \u003d\u003d 0:"},{"line_number":44,"context_line":"            return {\u0027total_progress\u0027: 100}"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_5fb0ec8b","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":0},"updated":"2016-08-15 02:45:17.000000000","message":"These fixes concern generic migration.. please make a note in the commit message if/why they are necessary with the driver assisted migration fixes..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.completed \u003d False"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_progress(self):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        # Empty share or empty contents"},{"line_number":43,"context_line":"        if self.completed and self.total_size \u003d\u003d 0:"},{"line_number":44,"context_line":"            return {\u0027total_progress\u0027: 100}"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_b9b8c7e6","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":0},"in_reply_to":"3ac371cc_5fb0ec8b","updated":"2016-08-17 12:40:36.000000000","message":"moved to a separate patch","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        # Empty share or empty contents"},{"line_number":43,"context_line":"        if self.completed and self.total_size \u003d\u003d 0:"},{"line_number":44,"context_line":"            return {\u0027total_progress\u0027: 100}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if not self.initialized or self.current_copy is None:"},{"line_number":47,"context_line":"            return {\u0027total_progress\u0027: 0}"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_3fad3032","line":44,"range":{"start_line":44,"start_character":19,"end_line":44,"end_character":42},"updated":"2016-08-15 02:45:17.000000000","message":"same comment as below..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        # Empty share or empty contents"},{"line_number":43,"context_line":"        if self.completed and self.total_size \u003d\u003d 0:"},{"line_number":44,"context_line":"            return {\u0027total_progress\u0027: 100}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if not self.initialized or self.current_copy is None:"},{"line_number":47,"context_line":"            return {\u0027total_progress\u0027: 0}"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_99a22bad","line":44,"range":{"start_line":44,"start_character":19,"end_line":44,"end_character":42},"in_reply_to":"3ac371cc_3fad3032","updated":"2016-08-17 12:40:36.000000000","message":"will address in newton improvements patch","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            return {\u0027total_progress\u0027: 100}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if not self.initialized or self.current_copy is None:"},{"line_number":47,"context_line":"            return {\u0027total_progress\u0027: 0}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # If share is not empty, there will be files"},{"line_number":50,"context_line":"        if self.current_copy is not None:"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_9faa6418","line":47,"range":{"start_line":47,"start_character":19,"end_line":47,"end_character":40},"updated":"2016-08-15 02:45:17.000000000","message":"same comment as below..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            return {\u0027total_progress\u0027: 100}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if not self.initialized or self.current_copy is None:"},{"line_number":47,"context_line":"            return {\u0027total_progress\u0027: 0}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # If share is not empty, there will be files"},{"line_number":50,"context_line":"        if self.current_copy is not None:"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_59a1d3a2","line":47,"range":{"start_line":47,"start_character":19,"end_line":47,"end_character":40},"in_reply_to":"3ac371cc_9faa6418","updated":"2016-08-17 12:40:36.000000000","message":"same as above","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                total_progress \u003d int((self.current_size + size) *"},{"line_number":70,"context_line":"                                     100 / self.total_size)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"            progress \u003d {"},{"line_number":73,"context_line":"                \u0027total_progress\u0027: total_progress,"},{"line_number":74,"context_line":"                \u0027current_file_path\u0027: current_file_path,"},{"line_number":75,"context_line":"                \u0027current_file_progress\u0027: current_file_progress"},{"line_number":76,"context_line":"            }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"            return progress"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def cancel(self):"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_1fb6748a","line":78,"range":{"start_line":72,"start_character":11,"end_line":78,"end_character":27},"updated":"2016-08-15 02:45:17.000000000","message":"This should be funneled through a view builder in the API..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                total_progress \u003d int((self.current_size + size) *"},{"line_number":70,"context_line":"                                     100 / self.total_size)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"            progress \u003d {"},{"line_number":73,"context_line":"                \u0027total_progress\u0027: total_progress,"},{"line_number":74,"context_line":"                \u0027current_file_path\u0027: current_file_path,"},{"line_number":75,"context_line":"                \u0027current_file_progress\u0027: current_file_progress"},{"line_number":76,"context_line":"            }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"            return progress"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def cancel(self):"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_798c8f35","line":78,"range":{"start_line":72,"start_character":11,"end_line":78,"end_character":27},"in_reply_to":"3ac371cc_1fb6748a","updated":"2016-08-17 12:40:36.000000000","message":"will address in newton improvements patch","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"78ab645b789f5725b4b02f107ac40a3814dececc","unresolved":false,"context_lines":[{"line_number":1767,"context_line":"        models.ShareInstanceAccessMapping,"},{"line_number":1768,"context_line":"        models.ShareInstanceAccessMapping.access_id \u003d\u003d"},{"line_number":1769,"context_line":"        models.ShareAccessMapping.id).filter(and_("},{"line_number":1770,"context_line":"            models.ShareInstanceAccessMapping.share_instance_id \u003d\u003d"},{"line_number":1771,"context_line":"            instance_id, models.ShareInstanceAccessMapping.deleted \u003d\u003d"},{"line_number":1772,"context_line":"            \"False\")).all()"},{"line_number":1773,"context_line":""},{"line_number":1774,"context_line":""},{"line_number":1775,"context_line":"@require_context"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_9b96a9ed","line":1772,"range":{"start_line":1770,"start_character":0,"end_line":1772,"end_character":27},"updated":"2016-07-15 04:28:27.000000000","message":"This was my downstream bug fix for https://bugs.launchpad.net/manila/+bug/1566815 that never saw the light of the day. Could you please add this bug ID to your commit message?","commit_id":"43ef7761b9a541de60f30e0c098dced1cd5d1ca8"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cc4a6af02795155009e7cfdd2850b33c2606eec3","unresolved":false,"context_lines":[{"line_number":1767,"context_line":"        models.ShareInstanceAccessMapping,"},{"line_number":1768,"context_line":"        models.ShareInstanceAccessMapping.access_id \u003d\u003d"},{"line_number":1769,"context_line":"        models.ShareAccessMapping.id).filter(and_("},{"line_number":1770,"context_line":"            models.ShareInstanceAccessMapping.share_instance_id \u003d\u003d"},{"line_number":1771,"context_line":"            instance_id, models.ShareInstanceAccessMapping.deleted \u003d\u003d"},{"line_number":1772,"context_line":"            \"False\")).all()"},{"line_number":1773,"context_line":""},{"line_number":1774,"context_line":""},{"line_number":1775,"context_line":"@require_context"}],"source_content_type":"text/x-python","patch_set":17,"id":"dada55a8_f81f3d59","line":1772,"range":{"start_line":1770,"start_character":0,"end_line":1772,"end_character":27},"in_reply_to":"1aa78d24_9b96a9ed","updated":"2016-07-17 19:10:05.000000000","message":"Done","commit_id":"43ef7761b9a541de60f30e0c098dced1cd5d1ca8"}],"manila/exception.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"class ShareServerNotReady(ManilaException):"},{"line_number":267,"context_line":"    message \u003d _(\"Share server %(share_server_id)s failed to become ready.\")"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"class ServiceNotFound(NotFound):"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_ff71d8e1","line":267,"range":{"start_line":267,"start_character":50,"end_line":267,"end_character":72},"updated":"2016-08-15 02:45:17.000000000","message":"failed to reach `available` state within `xyz` time..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"}],"manila/scheduler/manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                                                       request_spec,"},{"line_number":160,"context_line":"                                                       filter_properties)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        except exception.NoValidHost as ex:"},{"line_number":163,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":164,"context_line":"                _migrate_share_set_error(self, context, ex, request_spec)"},{"line_number":165,"context_line":"        except Exception as ex:"},{"line_number":166,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":167,"context_line":"                _migrate_share_set_error(self, context, ex, request_spec)"},{"line_number":168,"context_line":"        else:"},{"line_number":169,"context_line":"            share_ref \u003d db.share_get(context, share_id)"},{"line_number":170,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_7f55e81b","line":167,"range":{"start_line":162,"start_character":0,"end_line":167,"end_character":73},"updated":"2016-08-15 02:45:17.000000000","message":"Both exception paths are the same.. since this is an RPC call and not a cast, you can collapse the two into one except..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                                                       request_spec,"},{"line_number":160,"context_line":"                                                       filter_properties)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        except exception.NoValidHost as ex:"},{"line_number":163,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":164,"context_line":"                _migrate_share_set_error(self, context, ex, request_spec)"},{"line_number":165,"context_line":"        except Exception as ex:"},{"line_number":166,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":167,"context_line":"                _migrate_share_set_error(self, context, ex, request_spec)"},{"line_number":168,"context_line":"        else:"},{"line_number":169,"context_line":"            share_ref \u003d db.share_get(context, share_id)"},{"line_number":170,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_565fcee4","line":167,"range":{"start_line":162,"start_character":0,"end_line":167,"end_character":73},"in_reply_to":"3ac371cc_7f55e81b","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"}],"manila/share/api.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"58c029650dc497adce8c9b0f04734fce6f0630de","unresolved":false,"context_lines":[{"line_number":960,"context_line":"        share_instance_ref \u003d self.db.share_instance_get("},{"line_number":961,"context_line":"            context, share_instance_id, with_share_data\u003dTrue)"},{"line_number":962,"context_line":""},{"line_number":963,"context_line":"        share_rpc \u003d share_rpcapi.ShareAPI()"},{"line_number":964,"context_line":"        share_rpc.migration_complete(context, share_instance_ref,"},{"line_number":965,"context_line":"                                     new_share_instance_id)"},{"line_number":966,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_bb9c110f","line":963,"range":{"start_line":963,"start_character":8,"end_line":963,"end_character":43},"updated":"2016-07-26 11:22:34.000000000","message":"\"self.share_rpcapi\" defined in \"__init__\".","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3f0d174f280e53b18a4344bc0988f00e680d70fc","unresolved":false,"context_lines":[{"line_number":960,"context_line":"        share_instance_ref \u003d self.db.share_instance_get("},{"line_number":961,"context_line":"            context, share_instance_id, with_share_data\u003dTrue)"},{"line_number":962,"context_line":""},{"line_number":963,"context_line":"        share_rpc \u003d share_rpcapi.ShareAPI()"},{"line_number":964,"context_line":"        share_rpc.migration_complete(context, share_instance_ref,"},{"line_number":965,"context_line":"                                     new_share_instance_id)"},{"line_number":966,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_d37e0969","line":963,"range":{"start_line":963,"start_character":8,"end_line":963,"end_character":43},"in_reply_to":"dada55a8_bb9c110f","updated":"2016-07-26 16:02:40.000000000","message":"Done","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"58c029650dc497adce8c9b0f04734fce6f0630de","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"            share_instance_ref \u003d self.db.share_instance_get("},{"line_number":1026,"context_line":"                context, share_instance_id, with_share_data\u003dTrue)"},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"            share_rpc \u003d share_rpcapi.ShareAPI()"},{"line_number":1029,"context_line":"            share_rpc.migration_cancel("},{"line_number":1030,"context_line":"                context, share_instance_ref, migrating_instance_id)"},{"line_number":1031,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_1bf71d5a","line":1028,"range":{"start_line":1028,"start_character":12,"end_line":1028,"end_character":47},"updated":"2016-07-26 11:22:34.000000000","message":"\"self.share_rpcapi\" defined in \"__init__\".","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3f0d174f280e53b18a4344bc0988f00e680d70fc","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"            share_instance_ref \u003d self.db.share_instance_get("},{"line_number":1026,"context_line":"                context, share_instance_id, with_share_data\u003dTrue)"},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"            share_rpc \u003d share_rpcapi.ShareAPI()"},{"line_number":1029,"context_line":"            share_rpc.migration_cancel("},{"line_number":1030,"context_line":"                context, share_instance_ref, migrating_instance_id)"},{"line_number":1031,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_738e3d7a","line":1028,"range":{"start_line":1028,"start_character":12,"end_line":1028,"end_character":47},"in_reply_to":"dada55a8_1bf71d5a","updated":"2016-07-26 16:02:40.000000000","message":"Done","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a998ce1f57225d79984fdbe6750f46cfe1ff4336","unresolved":false,"context_lines":[{"line_number":1210,"context_line":"        if share[\u0027status\u0027] not in (constants.STATUS_AVAILABLE,"},{"line_number":1211,"context_line":"                                   constants.STATUS_MIGRATING,"},{"line_number":1212,"context_line":"                                   constants.STATUS_MIGRATING_TO):"},{"line_number":1213,"context_line":"            msg \u003d _(\"Share status must be %s\") % constants.STATUS_AVAILABLE"},{"line_number":1214,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":1215,"context_line":"        values \u003d {"},{"line_number":1216,"context_line":"            \u0027share_id\u0027: share[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_fb8b4d66","line":1213,"updated":"2016-07-25 19:17:01.000000000","message":"You added two statuses above.  This message should include those newly added statuses.  Should we allow access while the share is being migrated though?","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3f0d174f280e53b18a4344bc0988f00e680d70fc","unresolved":false,"context_lines":[{"line_number":1210,"context_line":"        if share[\u0027status\u0027] not in (constants.STATUS_AVAILABLE,"},{"line_number":1211,"context_line":"                                   constants.STATUS_MIGRATING,"},{"line_number":1212,"context_line":"                                   constants.STATUS_MIGRATING_TO):"},{"line_number":1213,"context_line":"            msg \u003d _(\"Share status must be %s\") % constants.STATUS_AVAILABLE"},{"line_number":1214,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":1215,"context_line":"        values \u003d {"},{"line_number":1216,"context_line":"            \u0027share_id\u0027: share[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_535059d4","line":1213,"in_reply_to":"dada55a8_aab83d76","updated":"2016-07-26 16:02:40.000000000","message":"Yes, the user should be able to see the contents of his files before issuing the \u0027migration-complete\u0027 command. I updated the driver interface to receive the list of rules so they can be kept in sync. But thinking about it, I think it is best if restricted to certain conditions, to prevent any users meddling with the data while it is being migrated. Thanks for your feedback.","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"58c029650dc497adce8c9b0f04734fce6f0630de","unresolved":false,"context_lines":[{"line_number":1210,"context_line":"        if share[\u0027status\u0027] not in (constants.STATUS_AVAILABLE,"},{"line_number":1211,"context_line":"                                   constants.STATUS_MIGRATING,"},{"line_number":1212,"context_line":"                                   constants.STATUS_MIGRATING_TO):"},{"line_number":1213,"context_line":"            msg \u003d _(\"Share status must be %s\") % constants.STATUS_AVAILABLE"},{"line_number":1214,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":1215,"context_line":"        values \u003d {"},{"line_number":1216,"context_line":"            \u0027share_id\u0027: share[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_aab83d76","line":1213,"in_reply_to":"dada55a8_fb8b4d66","updated":"2016-07-26 11:22:34.000000000","message":"Right, it should be changed too.","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"adc3bb3d0b202f79041be8a6eff9c2646eb42cc1","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"        \"\"\"Allow access to share.\"\"\""},{"line_number":1206,"context_line":"        policy.check_policy(ctx, \u0027share\u0027, \u0027allow_access\u0027)"},{"line_number":1207,"context_line":"        share \u003d self.db.share_get(ctx, share[\u0027id\u0027])"},{"line_number":1208,"context_line":"        if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE and not ("},{"line_number":1209,"context_line":"                (share[\u0027status\u0027] in (constants.STATUS_MIGRATING,"},{"line_number":1210,"context_line":"                                     constants.STATUS_MIGRATING_TO) and"},{"line_number":1211,"context_line":"                    share[\u0027task_state\u0027] in ("},{"line_number":1212,"context_line":"                        constants.TASK_STATE_DATA_COPYING_ERROR,"},{"line_number":1213,"context_line":"                        constants.TASK_STATE_MIGRATION_ERROR,"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_611ad5c7","line":1210,"range":{"start_line":1208,"start_character":11,"end_line":1210,"end_character":67},"updated":"2016-07-26 16:27:16.000000000","message":"Why separating?","commit_id":"d4c2ce9698dbcb2bd19b20727e817e6fc985c9ee"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1e48c089efbee28d553691864e1a83ec67418cb6","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"        \"\"\"Allow access to share.\"\"\""},{"line_number":1206,"context_line":"        policy.check_policy(ctx, \u0027share\u0027, \u0027allow_access\u0027)"},{"line_number":1207,"context_line":"        share \u003d self.db.share_get(ctx, share[\u0027id\u0027])"},{"line_number":1208,"context_line":"        if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE and not ("},{"line_number":1209,"context_line":"                (share[\u0027status\u0027] in (constants.STATUS_MIGRATING,"},{"line_number":1210,"context_line":"                                     constants.STATUS_MIGRATING_TO) and"},{"line_number":1211,"context_line":"                    share[\u0027task_state\u0027] in ("},{"line_number":1212,"context_line":"                        constants.TASK_STATE_DATA_COPYING_ERROR,"},{"line_number":1213,"context_line":"                        constants.TASK_STATE_MIGRATION_ERROR,"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_94f3c972","line":1210,"range":{"start_line":1208,"start_character":11,"end_line":1210,"end_character":67},"in_reply_to":"dada55a8_611ad5c7","updated":"2016-07-26 17:07:47.000000000","message":"I find it easier to read:\n\n\"if status is not available and share is not migrating while under certain task_states, raise exception\"","commit_id":"d4c2ce9698dbcb2bd19b20727e817e6fc985c9ee"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"adc3bb3d0b202f79041be8a6eff9c2646eb42cc1","unresolved":false,"context_lines":[{"line_number":1213,"context_line":"                        constants.TASK_STATE_MIGRATION_ERROR,"},{"line_number":1214,"context_line":"                        constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE,"},{"line_number":1215,"context_line":"                        constants.TASK_STATE_DATA_COPYING_COMPLETED))):"},{"line_number":1216,"context_line":"            msg \u003d _(\"Share status must be %s\") % constants.STATUS_AVAILABLE"},{"line_number":1217,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":1218,"context_line":"        values \u003d {"},{"line_number":1219,"context_line":"            \u0027share_id\u0027: share[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_a1cccd35","line":1216,"range":{"start_line":1216,"start_character":12,"end_line":1216,"end_character":75},"updated":"2016-07-26 16:27:16.000000000","message":"Message still not changed accordingly.","commit_id":"d4c2ce9698dbcb2bd19b20727e817e6fc985c9ee"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1e48c089efbee28d553691864e1a83ec67418cb6","unresolved":false,"context_lines":[{"line_number":1213,"context_line":"                        constants.TASK_STATE_MIGRATION_ERROR,"},{"line_number":1214,"context_line":"                        constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE,"},{"line_number":1215,"context_line":"                        constants.TASK_STATE_DATA_COPYING_COMPLETED))):"},{"line_number":1216,"context_line":"            msg \u003d _(\"Share status must be %s\") % constants.STATUS_AVAILABLE"},{"line_number":1217,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":1218,"context_line":"        values \u003d {"},{"line_number":1219,"context_line":"            \u0027share_id\u0027: share[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_b7888f23","line":1216,"range":{"start_line":1216,"start_character":12,"end_line":1216,"end_character":75},"in_reply_to":"dada55a8_a1cccd35","updated":"2016-07-26 17:07:47.000000000","message":"Done","commit_id":"d4c2ce9698dbcb2bd19b20727e817e6fc985c9ee"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":941,"context_line":"            {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_STARTING})"},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"        try:"},{"line_number":944,"context_line":"            self.scheduler_rpcapi.migrate_share_to_host("},{"line_number":945,"context_line":"                context, share[\u0027id\u0027], dest_host, force_host_copy, notify,"},{"line_number":946,"context_line":"                request_spec)"},{"line_number":947,"context_line":"        except Exception:"},{"line_number":948,"context_line":"            msg \u003d _(\u0027Destination host %(dest_host)s did not pass validation \u0027"},{"line_number":949,"context_line":"                    \u0027for migration of share %(share)s.\u0027) % {"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_ba780e91","line":946,"range":{"start_line":944,"start_character":0,"end_line":946,"end_character":29},"updated":"2016-08-15 02:45:17.000000000","message":"Why is the implementation of this RPC a call and not a cast?","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":941,"context_line":"            {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_STARTING})"},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"        try:"},{"line_number":944,"context_line":"            self.scheduler_rpcapi.migrate_share_to_host("},{"line_number":945,"context_line":"                context, share[\u0027id\u0027], dest_host, force_host_copy, notify,"},{"line_number":946,"context_line":"                request_spec)"},{"line_number":947,"context_line":"        except Exception:"},{"line_number":948,"context_line":"            msg \u003d _(\u0027Destination host %(dest_host)s did not pass validation \u0027"},{"line_number":949,"context_line":"                    \u0027for migration of share %(share)s.\u0027) % {"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_a45ffee3","line":946,"range":{"start_line":944,"start_character":0,"end_line":946,"end_character":29},"in_reply_to":"3ac371cc_ba780e91","updated":"2016-08-17 12:40:36.000000000","message":"this was a mistake in mitaka. It is addressed in newton improvements patch.","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":1212,"context_line":"        \"\"\"Allow access to share.\"\"\""},{"line_number":1213,"context_line":"        policy.check_policy(ctx, \u0027share\u0027, \u0027allow_access\u0027)"},{"line_number":1214,"context_line":"        share \u003d self.db.share_get(ctx, share[\u0027id\u0027])"},{"line_number":1215,"context_line":"        if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE and not ("},{"line_number":1216,"context_line":"                (share[\u0027status\u0027] in (constants.STATUS_MIGRATING,"},{"line_number":1217,"context_line":"                                     constants.STATUS_MIGRATING_TO) and"},{"line_number":1218,"context_line":"                    share[\u0027task_state\u0027] in ("},{"line_number":1219,"context_line":"                        constants.TASK_STATE_DATA_COPYING_ERROR,"},{"line_number":1220,"context_line":"                        constants.TASK_STATE_MIGRATION_ERROR,"},{"line_number":1221,"context_line":"                        constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE,"},{"line_number":1222,"context_line":"                        constants.TASK_STATE_DATA_COPYING_COMPLETED))):"},{"line_number":1223,"context_line":"            msg \u003d _(\"Share status must be %(available)s, or %(migrating)s \""},{"line_number":1224,"context_line":"                    \"while first phase of migration is completed.\") % {"},{"line_number":1225,"context_line":"                \u0027available\u0027: constants.STATUS_AVAILABLE,"},{"line_number":1226,"context_line":"                \u0027migrating\u0027: constants.STATUS_MIGRATING"},{"line_number":1227,"context_line":"            }"},{"line_number":1228,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":1229,"context_line":"        values \u003d {"},{"line_number":1230,"context_line":"            \u0027share_id\u0027: share[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_9a6272d7","line":1227,"range":{"start_line":1215,"start_character":0,"end_line":1227,"end_character":13},"updated":"2016-08-15 02:45:17.000000000","message":"This changes the error message for shares that aren\u0027t migrating.. Since allow-access is a tenant level API, i would advise against mixing the two messages.. in most cases, when the share is migrating, users may not be meddling with the share, so\n\nMaybe check for the migration related statuses first and respond with an appropriate error and elif for the \u0027available\u0027 status check as before..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":1212,"context_line":"        \"\"\"Allow access to share.\"\"\""},{"line_number":1213,"context_line":"        policy.check_policy(ctx, \u0027share\u0027, \u0027allow_access\u0027)"},{"line_number":1214,"context_line":"        share \u003d self.db.share_get(ctx, share[\u0027id\u0027])"},{"line_number":1215,"context_line":"        if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE and not ("},{"line_number":1216,"context_line":"                (share[\u0027status\u0027] in (constants.STATUS_MIGRATING,"},{"line_number":1217,"context_line":"                                     constants.STATUS_MIGRATING_TO) and"},{"line_number":1218,"context_line":"                    share[\u0027task_state\u0027] in ("},{"line_number":1219,"context_line":"                        constants.TASK_STATE_DATA_COPYING_ERROR,"},{"line_number":1220,"context_line":"                        constants.TASK_STATE_MIGRATION_ERROR,"},{"line_number":1221,"context_line":"                        constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE,"},{"line_number":1222,"context_line":"                        constants.TASK_STATE_DATA_COPYING_COMPLETED))):"},{"line_number":1223,"context_line":"            msg \u003d _(\"Share status must be %(available)s, or %(migrating)s \""},{"line_number":1224,"context_line":"                    \"while first phase of migration is completed.\") % {"},{"line_number":1225,"context_line":"                \u0027available\u0027: constants.STATUS_AVAILABLE,"},{"line_number":1226,"context_line":"                \u0027migrating\u0027: constants.STATUS_MIGRATING"},{"line_number":1227,"context_line":"            }"},{"line_number":1228,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":1229,"context_line":"        values \u003d {"},{"line_number":1230,"context_line":"            \u0027share_id\u0027: share[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_d673be7e","line":1227,"range":{"start_line":1215,"start_character":0,"end_line":1227,"end_character":13},"in_reply_to":"3ac371cc_9a6272d7","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":1302,"context_line":"        if not (share.instances and share.instance[\u0027host\u0027]):"},{"line_number":1303,"context_line":"            msg \u003d _(\"Share doesn\u0027t have any instances\")"},{"line_number":1304,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":1305,"context_line":"        if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE and not ("},{"line_number":1306,"context_line":"                (share[\u0027status\u0027] in (constants.STATUS_MIGRATING,"},{"line_number":1307,"context_line":"                                     constants.STATUS_MIGRATING_TO) and"},{"line_number":1308,"context_line":"                    share[\u0027task_state\u0027] in ("},{"line_number":1309,"context_line":"                        constants.TASK_STATE_DATA_COPYING_ERROR,"},{"line_number":1310,"context_line":"                        constants.TASK_STATE_MIGRATION_ERROR,"},{"line_number":1311,"context_line":"                        constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE,"},{"line_number":1312,"context_line":"                        constants.TASK_STATE_DATA_COPYING_COMPLETED))):"},{"line_number":1313,"context_line":"            msg \u003d _(\"Share status must be %(available)s, or %(migrating)s \""},{"line_number":1314,"context_line":"                    \"while first phase of migration is completed.\") % {"},{"line_number":1315,"context_line":"                \u0027available\u0027: constants.STATUS_AVAILABLE,"},{"line_number":1316,"context_line":"                \u0027migrating\u0027: constants.STATUS_MIGRATING"},{"line_number":1317,"context_line":"            }"},{"line_number":1318,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":1319,"context_line":""},{"line_number":1320,"context_line":"        for share_instance in share.instances:"},{"line_number":1321,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_7a5fb60e","line":1318,"range":{"start_line":1305,"start_character":8,"end_line":1318,"end_character":45},"updated":"2016-08-15 02:45:17.000000000","message":"same","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":1302,"context_line":"        if not (share.instances and share.instance[\u0027host\u0027]):"},{"line_number":1303,"context_line":"            msg \u003d _(\"Share doesn\u0027t have any instances\")"},{"line_number":1304,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":1305,"context_line":"        if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE and not ("},{"line_number":1306,"context_line":"                (share[\u0027status\u0027] in (constants.STATUS_MIGRATING,"},{"line_number":1307,"context_line":"                                     constants.STATUS_MIGRATING_TO) and"},{"line_number":1308,"context_line":"                    share[\u0027task_state\u0027] in ("},{"line_number":1309,"context_line":"                        constants.TASK_STATE_DATA_COPYING_ERROR,"},{"line_number":1310,"context_line":"                        constants.TASK_STATE_MIGRATION_ERROR,"},{"line_number":1311,"context_line":"                        constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE,"},{"line_number":1312,"context_line":"                        constants.TASK_STATE_DATA_COPYING_COMPLETED))):"},{"line_number":1313,"context_line":"            msg \u003d _(\"Share status must be %(available)s, or %(migrating)s \""},{"line_number":1314,"context_line":"                    \"while first phase of migration is completed.\") % {"},{"line_number":1315,"context_line":"                \u0027available\u0027: constants.STATUS_AVAILABLE,"},{"line_number":1316,"context_line":"                \u0027migrating\u0027: constants.STATUS_MIGRATING"},{"line_number":1317,"context_line":"            }"},{"line_number":1318,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":1319,"context_line":""},{"line_number":1320,"context_line":"        for share_instance in share.instances:"},{"line_number":1321,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_b66e0294","line":1318,"range":{"start_line":1305,"start_character":8,"end_line":1318,"end_character":45},"in_reply_to":"3ac371cc_7a5fb60e","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ef4f97551e6eb7dcc3cef71cc04f26b835f1ccc0","unresolved":false,"context_lines":[{"line_number":1006,"context_line":"            share_instance_ref \u003d self.db.share_instance_get("},{"line_number":1007,"context_line":"                context, share_instance_id, with_share_data\u003dTrue)"},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"            share_rpc \u003d share_rpcapi.ShareAPI()"},{"line_number":1010,"context_line":"            result \u003d share_rpc.migration_get_progress("},{"line_number":1011,"context_line":"                context, share_instance_ref, migrating_instance_id)"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"        elif share[\u0027task_state\u0027] \u003d\u003d ("},{"line_number":1014,"context_line":"                constants.TASK_STATE_DATA_COPYING_IN_PROGRESS):"}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_477812f9","line":1011,"range":{"start_line":1009,"start_character":0,"end_line":1011,"end_character":67},"updated":"2016-08-24 21:13:37.000000000","message":"check if the service is up and enabled..","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f30fdf868444c7a9f3033a23f8bcc1a54e39cd87","unresolved":false,"context_lines":[{"line_number":1006,"context_line":"            share_instance_ref \u003d self.db.share_instance_get("},{"line_number":1007,"context_line":"                context, share_instance_id, with_share_data\u003dTrue)"},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"            share_rpc \u003d share_rpcapi.ShareAPI()"},{"line_number":1010,"context_line":"            result \u003d share_rpc.migration_get_progress("},{"line_number":1011,"context_line":"                context, share_instance_ref, migrating_instance_id)"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"        elif share[\u0027task_state\u0027] \u003d\u003d ("},{"line_number":1014,"context_line":"                constants.TASK_STATE_DATA_COPYING_IN_PROGRESS):"}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_c46cf338","line":1011,"range":{"start_line":1009,"start_character":0,"end_line":1011,"end_character":67},"in_reply_to":"1ac06dbe_477812f9","updated":"2016-08-25 01:05:40.000000000","message":"Done","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66bafaa96bbac04568652ab90ff2d09fab0200ea","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"            service \u003d self.db.service_get_by_args("},{"line_number":1010,"context_line":"                context, share_instance_ref[\u0027host\u0027], \u0027manila-share\u0027)"},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"            if service[\u0027status\u0027] \u003d\u003d \u0027enabled\u0027 and service[\u0027state\u0027] \u003d\u003d \u0027up\u0027:"},{"line_number":1013,"context_line":"                try:"},{"line_number":1014,"context_line":"                    result \u003d self.share_rpcapi.migration_get_progress("},{"line_number":1015,"context_line":"                        context, share_instance_ref, migrating_instance_id)"}],"source_content_type":"text/x-python","patch_set":61,"id":"1ac06dbe_5c1d7365","line":1012,"range":{"start_line":1012,"start_character":36,"end_line":1012,"end_character":45},"updated":"2016-08-25 01:18:45.000000000","message":"constants, please..","commit_id":"70988588580594ebe6f1af24fd9d03bd4b91a853"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66bafaa96bbac04568652ab90ff2d09fab0200ea","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"            service \u003d self.db.service_get_by_args("},{"line_number":1010,"context_line":"                context, share_instance_ref[\u0027host\u0027], \u0027manila-share\u0027)"},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"            if service[\u0027status\u0027] \u003d\u003d \u0027enabled\u0027 and service[\u0027state\u0027] \u003d\u003d \u0027up\u0027:"},{"line_number":1013,"context_line":"                try:"},{"line_number":1014,"context_line":"                    result \u003d self.share_rpcapi.migration_get_progress("},{"line_number":1015,"context_line":"                        context, share_instance_ref, migrating_instance_id)"}],"source_content_type":"text/x-python","patch_set":61,"id":"1ac06dbe_bc2467af","line":1012,"range":{"start_line":1012,"start_character":71,"end_line":1012,"end_character":73},"updated":"2016-08-25 01:18:45.000000000","message":"same.","commit_id":"70988588580594ebe6f1af24fd9d03bd4b91a853"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"83bcc6d59cad02ebf3529d63a1f88b0caf1532c5","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"            service \u003d self.db.service_get_by_args("},{"line_number":1010,"context_line":"                context, share_instance_ref[\u0027host\u0027], \u0027manila-share\u0027)"},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"            if service[\u0027status\u0027] \u003d\u003d \u0027enabled\u0027 and service[\u0027state\u0027] \u003d\u003d \u0027up\u0027:"},{"line_number":1013,"context_line":"                try:"},{"line_number":1014,"context_line":"                    result \u003d self.share_rpcapi.migration_get_progress("},{"line_number":1015,"context_line":"                        context, share_instance_ref, migrating_instance_id)"}],"source_content_type":"text/x-python","patch_set":61,"id":"1ac06dbe_ac4c1577","line":1012,"range":{"start_line":1012,"start_character":71,"end_line":1012,"end_character":73},"in_reply_to":"1ac06dbe_bc2467af","updated":"2016-08-25 12:46:53.000000000","message":"Done","commit_id":"70988588580594ebe6f1af24fd9d03bd4b91a853"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66bafaa96bbac04568652ab90ff2d09fab0200ea","unresolved":false,"context_lines":[{"line_number":1027,"context_line":"            LOG.info(_LI(\"Sending request to get share migration information\""},{"line_number":1028,"context_line":"                     \" of share %s.\") % share[\u0027id\u0027])"},{"line_number":1029,"context_line":"            try:"},{"line_number":1030,"context_line":"                result \u003d data_rpc.data_copy_get_progress(context, share[\u0027id\u0027])"},{"line_number":1031,"context_line":"            except Exception:"},{"line_number":1032,"context_line":"                msg \u003d _(\"Failed to obtain migration progress of share \""},{"line_number":1033,"context_line":"                        \"%s.\") % share[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":61,"id":"1ac06dbe_dc8163fd","line":1030,"range":{"start_line":1030,"start_character":15,"end_line":1030,"end_character":78},"updated":"2016-08-25 01:18:45.000000000","message":"this is an RPC call too..","commit_id":"70988588580594ebe6f1af24fd9d03bd4b91a853"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"83bcc6d59cad02ebf3529d63a1f88b0caf1532c5","unresolved":false,"context_lines":[{"line_number":1027,"context_line":"            LOG.info(_LI(\"Sending request to get share migration information\""},{"line_number":1028,"context_line":"                     \" of share %s.\") % share[\u0027id\u0027])"},{"line_number":1029,"context_line":"            try:"},{"line_number":1030,"context_line":"                result \u003d data_rpc.data_copy_get_progress(context, share[\u0027id\u0027])"},{"line_number":1031,"context_line":"            except Exception:"},{"line_number":1032,"context_line":"                msg \u003d _(\"Failed to obtain migration progress of share \""},{"line_number":1033,"context_line":"                        \"%s.\") % share[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":61,"id":"1ac06dbe_cc599137","line":1030,"range":{"start_line":1030,"start_character":15,"end_line":1030,"end_character":78},"in_reply_to":"1ac06dbe_dc8163fd","updated":"2016-08-25 12:46:53.000000000","message":"Done","commit_id":"70988588580594ebe6f1af24fd9d03bd4b91a853"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66bafaa96bbac04568652ab90ff2d09fab0200ea","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"            service \u003d self.db.service_get_by_args("},{"line_number":1079,"context_line":"                context, share_instance_ref[\u0027host\u0027], \u0027manila-share\u0027)"},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"            if service[\u0027status\u0027] \u003d\u003d \u0027enabled\u0027 and service[\u0027state\u0027] \u003d\u003d \u0027up\u0027:"},{"line_number":1082,"context_line":""},{"line_number":1083,"context_line":"                try:"},{"line_number":1084,"context_line":"                    self.share_rpcapi.migration_cancel("}],"source_content_type":"text/x-python","patch_set":61,"id":"1ac06dbe_dc568305","line":1081,"range":{"start_line":1081,"start_character":36,"end_line":1081,"end_character":74},"updated":"2016-08-25 01:18:45.000000000","message":"same","commit_id":"70988588580594ebe6f1af24fd9d03bd4b91a853"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"83bcc6d59cad02ebf3529d63a1f88b0caf1532c5","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"            service \u003d self.db.service_get_by_args("},{"line_number":1079,"context_line":"                context, share_instance_ref[\u0027host\u0027], \u0027manila-share\u0027)"},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"            if service[\u0027status\u0027] \u003d\u003d \u0027enabled\u0027 and service[\u0027state\u0027] \u003d\u003d \u0027up\u0027:"},{"line_number":1082,"context_line":""},{"line_number":1083,"context_line":"                try:"},{"line_number":1084,"context_line":"                    self.share_rpcapi.migration_cancel("}],"source_content_type":"text/x-python","patch_set":61,"id":"1ac06dbe_2c41453a","line":1081,"range":{"start_line":1081,"start_character":36,"end_line":1081,"end_character":74},"in_reply_to":"1ac06dbe_dc568305","updated":"2016-08-25 12:46:53.000000000","message":"Done","commit_id":"70988588580594ebe6f1af24fd9d03bd4b91a853"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66bafaa96bbac04568652ab90ff2d09fab0200ea","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"            if service[\u0027status\u0027] \u003d\u003d \u0027enabled\u0027 and service[\u0027state\u0027] \u003d\u003d \u0027up\u0027:"},{"line_number":1082,"context_line":""},{"line_number":1083,"context_line":"                try:"},{"line_number":1084,"context_line":"                    self.share_rpcapi.migration_cancel("},{"line_number":1085,"context_line":"                        context, share_instance_ref, migrating_instance_id)"},{"line_number":1086,"context_line":"                except Exception:"},{"line_number":1087,"context_line":"                    msg \u003d _("}],"source_content_type":"text/x-python","patch_set":61,"id":"1ac06dbe_dcafa37b","line":1084,"range":{"start_line":1084,"start_character":20,"end_line":1084,"end_character":54},"updated":"2016-08-25 01:18:45.000000000","message":"this is an RPC call too..","commit_id":"70988588580594ebe6f1af24fd9d03bd4b91a853"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"83bcc6d59cad02ebf3529d63a1f88b0caf1532c5","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"            if service[\u0027status\u0027] \u003d\u003d \u0027enabled\u0027 and service[\u0027state\u0027] \u003d\u003d \u0027up\u0027:"},{"line_number":1082,"context_line":""},{"line_number":1083,"context_line":"                try:"},{"line_number":1084,"context_line":"                    self.share_rpcapi.migration_cancel("},{"line_number":1085,"context_line":"                        context, share_instance_ref, migrating_instance_id)"},{"line_number":1086,"context_line":"                except Exception:"},{"line_number":1087,"context_line":"                    msg \u003d _("}],"source_content_type":"text/x-python","patch_set":61,"id":"1ac06dbe_0c3c49be","line":1084,"range":{"start_line":1084,"start_character":20,"end_line":1084,"end_character":54},"in_reply_to":"1ac06dbe_dcafa37b","updated":"2016-08-25 12:46:53.000000000","message":"Done","commit_id":"70988588580594ebe6f1af24fd9d03bd4b91a853"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66bafaa96bbac04568652ab90ff2d09fab0200ea","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"                    self.share_rpcapi.migration_cancel("},{"line_number":1085,"context_line":"                        context, share_instance_ref, migrating_instance_id)"},{"line_number":1086,"context_line":"                except Exception:"},{"line_number":1087,"context_line":"                    msg \u003d _("},{"line_number":1088,"context_line":"                        \"Failed to cancel migration of share \""},{"line_number":1089,"context_line":"                        \"%s.\") % share[\u0027id\u0027]"},{"line_number":1090,"context_line":"                    LOG.exception(msg)"},{"line_number":1091,"context_line":"                    raise exception.ShareMigrationError(reason\u003dmsg)"},{"line_number":1092,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":61,"id":"1ac06dbe_5c6293d9","line":1089,"range":{"start_line":1087,"start_character":26,"end_line":1089,"end_character":44},"updated":"2016-08-25 01:18:45.000000000","message":"wrapping","commit_id":"70988588580594ebe6f1af24fd9d03bd4b91a853"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"83bcc6d59cad02ebf3529d63a1f88b0caf1532c5","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"                    self.share_rpcapi.migration_cancel("},{"line_number":1085,"context_line":"                        context, share_instance_ref, migrating_instance_id)"},{"line_number":1086,"context_line":"                except Exception:"},{"line_number":1087,"context_line":"                    msg \u003d _("},{"line_number":1088,"context_line":"                        \"Failed to cancel migration of share \""},{"line_number":1089,"context_line":"                        \"%s.\") % share[\u0027id\u0027]"},{"line_number":1090,"context_line":"                    LOG.exception(msg)"},{"line_number":1091,"context_line":"                    raise exception.ShareMigrationError(reason\u003dmsg)"},{"line_number":1092,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":61,"id":"1ac06dbe_ac7375b3","line":1089,"range":{"start_line":1087,"start_character":26,"end_line":1089,"end_character":44},"in_reply_to":"1ac06dbe_5c6293d9","updated":"2016-08-25 12:46:53.000000000","message":"Done","commit_id":"70988588580594ebe6f1af24fd9d03bd4b91a853"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66bafaa96bbac04568652ab90ff2d09fab0200ea","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"            data_rpc \u003d data_rpcapi.DataAPI()"},{"line_number":1099,"context_line":"            LOG.info(_LI(\"Sending request to cancel migration of \""},{"line_number":1100,"context_line":"                         \"share %s.\") % share[\u0027id\u0027])"},{"line_number":1101,"context_line":"            try:"},{"line_number":1102,"context_line":"                data_rpc.data_copy_cancel(context, share[\u0027id\u0027])"},{"line_number":1103,"context_line":"            except Exception:"},{"line_number":1104,"context_line":"                msg \u003d _("},{"line_number":1105,"context_line":"                    \"Failed to cancel migration of share \""}],"source_content_type":"text/x-python","patch_set":61,"id":"1ac06dbe_5c76133f","line":1102,"range":{"start_line":1101,"start_character":16,"end_line":1102,"end_character":62},"updated":"2016-08-25 01:18:45.000000000","message":"this is an RPC call too..","commit_id":"70988588580594ebe6f1af24fd9d03bd4b91a853"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"83bcc6d59cad02ebf3529d63a1f88b0caf1532c5","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"            data_rpc \u003d data_rpcapi.DataAPI()"},{"line_number":1099,"context_line":"            LOG.info(_LI(\"Sending request to cancel migration of \""},{"line_number":1100,"context_line":"                         \"share %s.\") % share[\u0027id\u0027])"},{"line_number":1101,"context_line":"            try:"},{"line_number":1102,"context_line":"                data_rpc.data_copy_cancel(context, share[\u0027id\u0027])"},{"line_number":1103,"context_line":"            except Exception:"},{"line_number":1104,"context_line":"                msg \u003d _("},{"line_number":1105,"context_line":"                    \"Failed to cancel migration of share \""}],"source_content_type":"text/x-python","patch_set":61,"id":"1ac06dbe_cc7071a7","line":1102,"range":{"start_line":1101,"start_character":16,"end_line":1102,"end_character":62},"in_reply_to":"1ac06dbe_5c76133f","updated":"2016-08-25 12:46:53.000000000","message":"Done","commit_id":"70988588580594ebe6f1af24fd9d03bd4b91a853"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66bafaa96bbac04568652ab90ff2d09fab0200ea","unresolved":false,"context_lines":[{"line_number":1101,"context_line":"            try:"},{"line_number":1102,"context_line":"                data_rpc.data_copy_cancel(context, share[\u0027id\u0027])"},{"line_number":1103,"context_line":"            except Exception:"},{"line_number":1104,"context_line":"                msg \u003d _("},{"line_number":1105,"context_line":"                    \"Failed to cancel migration of share \""},{"line_number":1106,"context_line":"                    \"%s.\") % share[\u0027id\u0027]"},{"line_number":1107,"context_line":"                LOG.exception(msg)"},{"line_number":1108,"context_line":"                raise exception.ShareMigrationError(reason\u003dmsg)"},{"line_number":1109,"context_line":"        else:"},{"line_number":1110,"context_line":"            migrating \u003d False"}],"source_content_type":"text/x-python","patch_set":61,"id":"1ac06dbe_9c9a4bc4","line":1107,"range":{"start_line":1104,"start_character":16,"end_line":1107,"end_character":34},"updated":"2016-08-25 01:18:45.000000000","message":"wrapping","commit_id":"70988588580594ebe6f1af24fd9d03bd4b91a853"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"83bcc6d59cad02ebf3529d63a1f88b0caf1532c5","unresolved":false,"context_lines":[{"line_number":1101,"context_line":"            try:"},{"line_number":1102,"context_line":"                data_rpc.data_copy_cancel(context, share[\u0027id\u0027])"},{"line_number":1103,"context_line":"            except Exception:"},{"line_number":1104,"context_line":"                msg \u003d _("},{"line_number":1105,"context_line":"                    \"Failed to cancel migration of share \""},{"line_number":1106,"context_line":"                    \"%s.\") % share[\u0027id\u0027]"},{"line_number":1107,"context_line":"                LOG.exception(msg)"},{"line_number":1108,"context_line":"                raise exception.ShareMigrationError(reason\u003dmsg)"},{"line_number":1109,"context_line":"        else:"},{"line_number":1110,"context_line":"            migrating \u003d False"}],"source_content_type":"text/x-python","patch_set":61,"id":"1ac06dbe_2c6825ba","line":1107,"range":{"start_line":1104,"start_character":16,"end_line":1107,"end_character":34},"in_reply_to":"1ac06dbe_9c9a4bc4","updated":"2016-08-25 12:46:53.000000000","message":"Done","commit_id":"70988588580594ebe6f1af24fd9d03bd4b91a853"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2801a3f544a4afdf63de5aca2fbfd2c8ede0c7aa","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"                context, share_instance_id, with_share_data\u003dTrue)"},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"            service \u003d self.db.service_get_by_args("},{"line_number":1010,"context_line":"                context, share_instance_ref[\u0027host\u0027], \u0027manila-share\u0027)"},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"            if (service[\u0027status\u0027] \u003d\u003d constants.SERVICE_STATUS_ENABLED and"},{"line_number":1013,"context_line":"                    service[\u0027state\u0027] \u003d\u003d constants.SERVICE_STATE_UP):"}],"source_content_type":"text/x-python","patch_set":63,"id":"1ac06dbe_906203d7","line":1010,"range":{"start_line":1010,"start_character":25,"end_line":1010,"end_character":51},"updated":"2016-08-25 14:34:48.000000000","message":"need to extract the host","commit_id":"4c72cc4272a685a66976df4dca4e2fcf3e0a2b9d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"33a2d0e7ab2d71ceab7aae5079a50d65355c2375","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"                context, share_instance_id, with_share_data\u003dTrue)"},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"            service \u003d self.db.service_get_by_args("},{"line_number":1010,"context_line":"                context, share_instance_ref[\u0027host\u0027], \u0027manila-share\u0027)"},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"            if (service[\u0027status\u0027] \u003d\u003d constants.SERVICE_STATUS_ENABLED and"},{"line_number":1013,"context_line":"                    service[\u0027state\u0027] \u003d\u003d constants.SERVICE_STATE_UP):"}],"source_content_type":"text/x-python","patch_set":63,"id":"1ac06dbe_0e470a4c","line":1010,"range":{"start_line":1010,"start_character":25,"end_line":1010,"end_character":51},"in_reply_to":"1ac06dbe_906203d7","updated":"2016-08-25 18:48:34.000000000","message":"Done","commit_id":"4c72cc4272a685a66976df4dca4e2fcf3e0a2b9d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2801a3f544a4afdf63de5aca2fbfd2c8ede0c7aa","unresolved":false,"context_lines":[{"line_number":1086,"context_line":"                context, share_instance_id, with_share_data\u003dTrue)"},{"line_number":1087,"context_line":""},{"line_number":1088,"context_line":"            service \u003d self.db.service_get_by_args("},{"line_number":1089,"context_line":"                context, share_instance_ref[\u0027host\u0027], \u0027manila-share\u0027)"},{"line_number":1090,"context_line":""},{"line_number":1091,"context_line":"            if (service[\u0027status\u0027] \u003d\u003d constants.SERVICE_STATUS_ENABLED and"},{"line_number":1092,"context_line":"                    service[\u0027state\u0027] \u003d\u003d constants.SERVICE_STATE_UP):"}],"source_content_type":"text/x-python","patch_set":63,"id":"1ac06dbe_30918f9b","line":1089,"range":{"start_line":1089,"start_character":25,"end_line":1089,"end_character":51},"updated":"2016-08-25 14:34:48.000000000","message":"need to extract host","commit_id":"4c72cc4272a685a66976df4dca4e2fcf3e0a2b9d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"33a2d0e7ab2d71ceab7aae5079a50d65355c2375","unresolved":false,"context_lines":[{"line_number":1086,"context_line":"                context, share_instance_id, with_share_data\u003dTrue)"},{"line_number":1087,"context_line":""},{"line_number":1088,"context_line":"            service \u003d self.db.service_get_by_args("},{"line_number":1089,"context_line":"                context, share_instance_ref[\u0027host\u0027], \u0027manila-share\u0027)"},{"line_number":1090,"context_line":""},{"line_number":1091,"context_line":"            if (service[\u0027status\u0027] \u003d\u003d constants.SERVICE_STATUS_ENABLED and"},{"line_number":1092,"context_line":"                    service[\u0027state\u0027] \u003d\u003d constants.SERVICE_STATE_UP):"}],"source_content_type":"text/x-python","patch_set":63,"id":"1ac06dbe_8e713aab","line":1089,"range":{"start_line":1089,"start_character":25,"end_line":1089,"end_character":51},"in_reply_to":"1ac06dbe_30918f9b","updated":"2016-08-25 18:48:34.000000000","message":"Done","commit_id":"4c72cc4272a685a66976df4dca4e2fcf3e0a2b9d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86aef3d727244295960fe78598575deee0284a16","unresolved":false,"context_lines":[{"line_number":1068,"context_line":"        elif task_state \u003d\u003d constants.TASK_STATE_MIGRATION_CANCELLED:"},{"line_number":1069,"context_line":"            msg \u003d _(\"Migration of share %s was already \""},{"line_number":1070,"context_line":"                    \"cancelled.\") % share[\u0027id\u0027]"},{"line_number":1071,"context_line":"        elif task_state in (constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE,"},{"line_number":1072,"context_line":"                            constants.TASK_STATE_DATA_COPYING_COMPLETED):"},{"line_number":1073,"context_line":"            msg \u003d _(\"Migration of share %s has already completed first \""},{"line_number":1074,"context_line":"                    \"phase.\") % share[\u0027id\u0027]"},{"line_number":1075,"context_line":"        else:"},{"line_number":1076,"context_line":"            return None"},{"line_number":1077,"context_line":"        return msg"}],"source_content_type":"text/x-python","patch_set":71,"id":"fa7ab95a_184196a9","line":1074,"range":{"start_line":1071,"start_character":0,"end_line":1074,"end_character":43},"updated":"2016-08-29 20:04:12.000000000","message":"I still think we should funnel this through the View builder and say that the progress is 100%. We can discuss further in newton improvements; since you don\u0027t have a view builder in this patch..","commit_id":"998db0f5c003ace6d0b9aa6461276554c87667a3"}],"manila/share/driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"85703504d34aa07a59e8999f952e4e535eef33cf","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        :returns: Dictionary containing a model update with relevant data to"},{"line_number":350,"context_line":"        be updated after migration, such as export locations."},{"line_number":351,"context_line":"        \"\"\""},{"line_number":352,"context_line":"        # NOTE(ganso): Driver should return a model update with \u0027host\u0027 field"},{"line_number":353,"context_line":"        # updated if had not done so in migration_start. This value can be"},{"line_number":354,"context_line":"        # obtained from private_storage if it was previously saved there in"},{"line_number":355,"context_line":"        # migration_start."},{"line_number":356,"context_line":"        return None"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"    def migration_cancel(self, context, share_ref, share_server,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_422609cf","line":355,"range":{"start_line":352,"start_character":23,"end_line":355,"end_character":26},"updated":"2016-06-23 03:35:15.000000000","message":"The share manager has the host name.. maybe the driver can be expected to provide the pool name?","commit_id":"46ea9f32c92f0f4de952efa6d1bfe43a0dfedb27"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"552dddfe218e11e66b029dc855c815d8a11d55ea","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        :returns: Dictionary containing a model update with relevant data to"},{"line_number":350,"context_line":"        be updated after migration, such as export locations."},{"line_number":351,"context_line":"        \"\"\""},{"line_number":352,"context_line":"        # NOTE(ganso): Driver should return a model update with \u0027host\u0027 field"},{"line_number":353,"context_line":"        # updated if had not done so in migration_start. This value can be"},{"line_number":354,"context_line":"        # obtained from private_storage if it was previously saved there in"},{"line_number":355,"context_line":"        # migration_start."},{"line_number":356,"context_line":"        return None"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"    def migration_cancel(self, context, share_ref, share_server,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_57106da8","line":355,"range":{"start_line":352,"start_character":23,"end_line":355,"end_character":26},"in_reply_to":"3aaa91ec_422609cf","updated":"2016-06-23 14:53:51.000000000","message":"the share manager does not have the destination host name at this point, just the source\u0027s. I am experimenting with a different approach to address this.","commit_id":"46ea9f32c92f0f4de952efa6d1bfe43a0dfedb27"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4499ef1d023223a708ee51fc061bd2304f32d72f","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        information about the destination backend. At the moment, this can be"},{"line_number":430,"context_line":"        done through the configuration file. Driver should provide a dictionary"},{"line_number":431,"context_line":"        with all parameters (and their values) related to destination backend"},{"line_number":432,"context_line":"        configuration group."},{"line_number":433,"context_line":"        :param context: The \u0027context.RequestContext\u0027 object for the request."},{"line_number":434,"context_line":"        :param share: Reference to the share being migrated."},{"line_number":435,"context_line":"        :param dest_host: Destination host and its capabilities."}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_4b284ae2","line":432,"updated":"2016-07-13 17:01:38.000000000","message":"Example?","commit_id":"2b2694c99d9762f2ba0f047049e911a4e95451f1"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"b97c1996770aecc64b48cd53316cf38e6c045827","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        information about the destination backend. At the moment, this can be"},{"line_number":430,"context_line":"        done through the configuration file. Driver should provide a dictionary"},{"line_number":431,"context_line":"        with all parameters (and their values) related to destination backend"},{"line_number":432,"context_line":"        configuration group."},{"line_number":433,"context_line":"        :param context: The \u0027context.RequestContext\u0027 object for the request."},{"line_number":434,"context_line":"        :param share: Reference to the share being migrated."},{"line_number":435,"context_line":"        :param dest_host: Destination host and its capabilities."}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_6a298489","line":432,"in_reply_to":"1aa78d24_4b284ae2","updated":"2016-07-14 17:49:02.000000000","message":"Done","commit_id":"2b2694c99d9762f2ba0f047049e911a4e95451f1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"91d38dd48f38181bb5cbd0dff19a7d186f4480a0","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        :param access_rules: All access rules the migrating share should have."},{"line_number":359,"context_line":"        :param share_server: Share server model or None."},{"line_number":360,"context_line":"        :param dest_share_server: Destination Share server model or None."},{"line_number":361,"context_line":"        :return: Boolean value indicating if driver migration succeeded."},{"line_number":362,"context_line":"        :return: List of export locations to update the share with."},{"line_number":363,"context_line":"        \"\"\""},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"bacf61ea_d1ecd691","line":361,"range":{"start_line":361,"start_character":62,"end_line":361,"end_character":71},"updated":"2016-07-27 14:49:51.000000000","message":"Succeeded or complited?","commit_id":"09549c244269aa74590d4cfeb368993278dd900a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c2553d33dfa45246ec14d17c18989db6a20accdb","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        :param access_rules: All access rules the migrating share should have."},{"line_number":359,"context_line":"        :param share_server: Share server model or None."},{"line_number":360,"context_line":"        :param dest_share_server: Destination Share server model or None."},{"line_number":361,"context_line":"        :return: Boolean value indicating if driver migration succeeded."},{"line_number":362,"context_line":"        :return: List of export locations to update the share with."},{"line_number":363,"context_line":"        \"\"\""},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"bacf61ea_221d2210","line":361,"range":{"start_line":361,"start_character":62,"end_line":361,"end_character":71},"in_reply_to":"bacf61ea_d1ecd691","updated":"2016-07-27 15:30:36.000000000","message":"succeeded. This is related to this step, so if migration-start has been invoked with notify\u003dFalse, then returning true will indicate that this part has succeeded. It will then be completed when migration-complete is invoked.","commit_id":"09549c244269aa74590d4cfeb368993278dd900a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a1770158f009c71d48f189620f87e2db5eb24494","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        raise NotImplementedError()"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def migration_start("},{"line_number":338,"context_line":"            self, context, share_ref, dest_host, dest_driver_migration_info,"},{"line_number":339,"context_line":"            migrating_share_ref, access_rules, share_server\u003dNone,"},{"line_number":340,"context_line":"            dest_share_server\u003dNone):"},{"line_number":341,"context_line":"        \"\"\"Is called to perform 1st phase of driver migration of a given share."}],"source_content_type":"text/x-python","patch_set":40,"id":"bacf61ea_faa663bf","line":338,"range":{"start_line":338,"start_character":27,"end_line":338,"end_character":36},"updated":"2016-08-05 10:23:07.000000000","message":"src_share_instance","commit_id":"65dddf29adc3f5b64379674a4ecadc049bd27f72"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9411114de524859d89eb5362b7ee4f1b9f33ec03","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        raise NotImplementedError()"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def migration_start("},{"line_number":338,"context_line":"            self, context, share_ref, dest_host, dest_driver_migration_info,"},{"line_number":339,"context_line":"            migrating_share_ref, access_rules, share_server\u003dNone,"},{"line_number":340,"context_line":"            dest_share_server\u003dNone):"},{"line_number":341,"context_line":"        \"\"\"Is called to perform 1st phase of driver migration of a given share."}],"source_content_type":"text/x-python","patch_set":40,"id":"9ad45d7e_1b1dc273","line":338,"range":{"start_line":338,"start_character":27,"end_line":338,"end_character":36},"in_reply_to":"bacf61ea_faa663bf","updated":"2016-08-09 00:37:48.000000000","message":"Done","commit_id":"65dddf29adc3f5b64379674a4ecadc049bd27f72"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a1770158f009c71d48f189620f87e2db5eb24494","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def migration_start("},{"line_number":338,"context_line":"            self, context, share_ref, dest_host, dest_driver_migration_info,"},{"line_number":339,"context_line":"            migrating_share_ref, access_rules, share_server\u003dNone,"},{"line_number":340,"context_line":"            dest_share_server\u003dNone):"},{"line_number":341,"context_line":"        \"\"\"Is called to perform 1st phase of driver migration of a given share."},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"bacf61ea_3ab63bf9","line":339,"range":{"start_line":339,"start_character":12,"end_line":339,"end_character":31},"updated":"2016-08-05 10:23:07.000000000","message":"Please name it in consistent way with other arguments here replacing \"migrating\" to \"dst\":\n\n\"dst_share_instance\"","commit_id":"65dddf29adc3f5b64379674a4ecadc049bd27f72"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9411114de524859d89eb5362b7ee4f1b9f33ec03","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def migration_start("},{"line_number":338,"context_line":"            self, context, share_ref, dest_host, dest_driver_migration_info,"},{"line_number":339,"context_line":"            migrating_share_ref, access_rules, share_server\u003dNone,"},{"line_number":340,"context_line":"            dest_share_server\u003dNone):"},{"line_number":341,"context_line":"        \"\"\"Is called to perform 1st phase of driver migration of a given share."},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"9ad45d7e_7b12fe63","line":339,"range":{"start_line":339,"start_character":12,"end_line":339,"end_character":31},"in_reply_to":"bacf61ea_3ab63bf9","updated":"2016-08-09 00:37:48.000000000","message":"Done","commit_id":"65dddf29adc3f5b64379674a4ecadc049bd27f72"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8dda9e0e8510850190e39ee1ed145152c0d836a3","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            self, context, share_ref, dest_host, dest_driver_migration_info,"},{"line_number":339,"context_line":"            migrating_share_ref, access_rules, share_server\u003dNone,"},{"line_number":340,"context_line":"            dest_share_server\u003dNone):"},{"line_number":341,"context_line":"        \"\"\"Is called to perform 1st phase of driver migration of a given share."},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        Driver should implement this method if willing to perform migration"},{"line_number":344,"context_line":"        in an optimized way, useful for when driver understands destination"},{"line_number":345,"context_line":"        backend."},{"line_number":346,"context_line":"        :param context: The \u0027context.RequestContext\u0027 object for the request."},{"line_number":347,"context_line":"        :param share_ref: Reference to the original share model."},{"line_number":348,"context_line":"        :param dest_host: Destination host and its capabilities."}],"source_content_type":"text/x-python","patch_set":40,"id":"bacf61ea_f7b671da","line":345,"range":{"start_line":341,"start_character":11,"end_line":345,"end_character":16},"updated":"2016-08-05 13:20:52.000000000","message":"I needed to debug to get it know for sure where it is called - either on src or dst.\n\nFor example, replica create is called on destination host, not source as here.","commit_id":"65dddf29adc3f5b64379674a4ecadc049bd27f72"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9411114de524859d89eb5362b7ee4f1b9f33ec03","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            self, context, share_ref, dest_host, dest_driver_migration_info,"},{"line_number":339,"context_line":"            migrating_share_ref, access_rules, share_server\u003dNone,"},{"line_number":340,"context_line":"            dest_share_server\u003dNone):"},{"line_number":341,"context_line":"        \"\"\"Is called to perform 1st phase of driver migration of a given share."},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        Driver should implement this method if willing to perform migration"},{"line_number":344,"context_line":"        in an optimized way, useful for when driver understands destination"},{"line_number":345,"context_line":"        backend."},{"line_number":346,"context_line":"        :param context: The \u0027context.RequestContext\u0027 object for the request."},{"line_number":347,"context_line":"        :param share_ref: Reference to the original share model."},{"line_number":348,"context_line":"        :param dest_host: Destination host and its capabilities."}],"source_content_type":"text/x-python","patch_set":40,"id":"9ad45d7e_5b173a51","line":345,"range":{"start_line":341,"start_character":11,"end_line":345,"end_character":16},"in_reply_to":"bacf61ea_f7b671da","updated":"2016-08-09 00:37:48.000000000","message":"Done","commit_id":"65dddf29adc3f5b64379674a4ecadc049bd27f72"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"13e381e28935c9e0192f835a700f1c9e899bbb15","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        :return: List of export locations to update the share with."},{"line_number":358,"context_line":"        \"\"\""},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        return None, None"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def migration_complete("},{"line_number":363,"context_line":"            self, context, share_ref, dest_host, dest_driver_migration_info,"}],"source_content_type":"text/x-python","patch_set":40,"id":"bacf61ea_27501432","line":360,"range":{"start_line":360,"start_character":19,"end_line":360,"end_character":25},"updated":"2016-08-04 14:20:26.000000000","message":"Why we return export locations, when after removal of \"notify\" argument itis enough to get them in \"migration_complete\"?","commit_id":"65dddf29adc3f5b64379674a4ecadc049bd27f72"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9411114de524859d89eb5362b7ee4f1b9f33ec03","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        :return: List of export locations to update the share with."},{"line_number":358,"context_line":"        \"\"\""},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        return None, None"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def migration_complete("},{"line_number":363,"context_line":"            self, context, share_ref, dest_host, dest_driver_migration_info,"}],"source_content_type":"text/x-python","patch_set":40,"id":"9ad45d7e_bb0c7643","line":360,"range":{"start_line":360,"start_character":19,"end_line":360,"end_character":25},"in_reply_to":"bacf61ea_27501432","updated":"2016-08-09 00:37:48.000000000","message":"Done","commit_id":"65dddf29adc3f5b64379674a4ecadc049bd27f72"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6df5060653f2e29e1ccd24be589e543113c0ae54","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                 \u0027allowed\u0027: driver_handles_share_servers})"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def migration_check_compatibility("},{"line_number":320,"context_line":"            self, context, share_ref, dest_host, dest_driver_migration_info,"},{"line_number":321,"context_line":"            share_server\u003dNone):"},{"line_number":322,"context_line":"        \"\"\"Is called to test compatibility with destination backend."},{"line_number":323,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"9ad45d7e_55021970","line":320,"range":{"start_line":320,"start_character":27,"end_line":320,"end_character":36},"updated":"2016-08-10 10:34:39.000000000","message":"It is incompatible with other migration namings.","commit_id":"a381dd6a074820d5b2b9ff9e8d250dcbb7c14a1b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6df5060653f2e29e1ccd24be589e543113c0ae54","unresolved":false,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def migration_continue("},{"line_number":362,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":363,"context_line":"            dest_driver_migration_info, dest_share_instance, access_rules,"},{"line_number":364,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":365,"context_line":"        \"\"\"Is called in source share\u0027s backend to continue migration."},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"9ad45d7e_803f2c86","line":363,"range":{"start_line":363,"start_character":40,"end_line":363,"end_character":59},"updated":"2016-08-10 10:34:39.000000000","message":"Writing ZFSonLinux driver implementation for share migration I found out that \"dest_share_instance\" on step where this method is called not bind to \"share\" and it has no values for \"share_proto\", \"share_type_id\" and all other proxified attributes.","commit_id":"a381dd6a074820d5b2b9ff9e8d250dcbb7c14a1b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f602f4c0e8498b1e44e103c7736ea3bf2b43818a","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                 \u0027allowed\u0027: driver_handles_share_servers})"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def migration_check_compatibility("},{"line_number":320,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":321,"context_line":"            dest_driver_migration_info, share_server\u003dNone):"},{"line_number":322,"context_line":"        \"\"\"Is called to test compatibility with destination backend."},{"line_number":323,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"1ac06dbe_ccf52884","line":320,"range":{"start_line":320,"start_character":27,"end_line":320,"end_character":45},"updated":"2016-08-20 23:47:06.000000000","message":"why call this out as a share instance? why not just src_share","commit_id":"658c51c7bd2558363b756eff405df3a23134fb36"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c1a05ba31664c21ac2ef0c87129a232dcdb27715","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                 \u0027allowed\u0027: driver_handles_share_servers})"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def migration_check_compatibility("},{"line_number":320,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":321,"context_line":"            dest_driver_migration_info, share_server\u003dNone):"},{"line_number":322,"context_line":"        \"\"\"Is called to test compatibility with destination backend."},{"line_number":323,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"1ac06dbe_945fad40","line":320,"range":{"start_line":320,"start_character":27,"end_line":320,"end_character":45},"in_reply_to":"1ac06dbe_ccf52884","updated":"2016-08-22 18:15:50.000000000","message":"this change was requested by Valeriy. See some previous commits.","commit_id":"658c51c7bd2558363b756eff405df3a23134fb36"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44f9239977c3c4c1a235e3522e860b22b60bae03","unresolved":false,"context_lines":[{"line_number":463,"context_line":"            migrated share."},{"line_number":464,"context_line":"        :param share_server: Share server model or None."},{"line_number":465,"context_line":"        :param dest_share_server: Destination Share server model or None."},{"line_number":466,"context_line":"        :return: A dictionary with at least \u0027total_progress\u0027 field containing"},{"line_number":467,"context_line":"            the percentage value."},{"line_number":468,"context_line":"        \"\"\""},{"line_number":469,"context_line":"        raise NotImplementedError()"},{"line_number":470,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"1ac06dbe_db516064","line":467,"range":{"start_line":466,"start_character":0,"end_line":467,"end_character":33},"updated":"2016-08-20 15:23:49.000000000","message":"So, different backends may have different levels of information they can give you. In the generic case, you have \u0027total_progress\u0027, \u0027current_file_in_progress\u0027 and \u0027current_file_progress\u0027.. \n\nFrom NetApp I can get, for different types of migration a different level of information; how can we provide a consistent user experience?\n\nI would like to know when the migration is expected to be completed... or the \"health\" of the migration activity.. thoughts?","commit_id":"658c51c7bd2558363b756eff405df3a23134fb36"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d637059c3c763596a8cc0b9b4914304188d89553","unresolved":false,"context_lines":[{"line_number":463,"context_line":"            migrated share."},{"line_number":464,"context_line":"        :param share_server: Share server model or None."},{"line_number":465,"context_line":"        :param dest_share_server: Destination Share server model or None."},{"line_number":466,"context_line":"        :return: A dictionary with at least \u0027total_progress\u0027 field containing"},{"line_number":467,"context_line":"            the percentage value."},{"line_number":468,"context_line":"        \"\"\""},{"line_number":469,"context_line":"        raise NotImplementedError()"},{"line_number":470,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"1ac06dbe_6e14e743","line":467,"range":{"start_line":466,"start_character":0,"end_line":467,"end_character":33},"in_reply_to":"1ac06dbe_db516064","updated":"2016-08-20 22:25:37.000000000","message":"This is a tough one. I chose to have at least \u0027total_progress\u0027 a backend supports it or not. In case progress cannot be retrieved, the API will always say something like \u0027Progress cannot be retrieved at this moment.\". Whether a backend can report progress, I think the baseline can always be total_progress, so it is consistent with all backends that can report it. Fallback approach supports current_file_in_progress and current_file_progress, it is there in the view because it is the only right now that can do it, but we can remove it from the view and have only \u0027total_progress\u0027 for it as well. I believe we could start with that, filtering the baseline in the view, and having drivers return all they can return, so in future releases we can extend the baseline.","commit_id":"658c51c7bd2558363b756eff405df3a23134fb36"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f602f4c0e8498b1e44e103c7736ea3bf2b43818a","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        configuration group."},{"line_number":480,"context_line":"        :param context: The \u0027context.RequestContext\u0027 object for the request."},{"line_number":481,"context_line":"        :param share: Reference to the share being migrated."},{"line_number":482,"context_line":"        :param dest_host: Destination host."},{"line_number":483,"context_line":"        :param share_server: Share server model or None."},{"line_number":484,"context_line":"        :return: A dictionary with migration information."},{"line_number":485,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"1ac06dbe_ec3f4423","line":482,"range":{"start_line":482,"start_character":8,"end_line":482,"end_character":43},"updated":"2016-08-20 23:47:06.000000000","message":"Clarify that this is a string containing a fully qualified manila share host name, ex: \"openstack@backend1#poolA\"","commit_id":"658c51c7bd2558363b756eff405df3a23134fb36"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c1a05ba31664c21ac2ef0c87129a232dcdb27715","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        configuration group."},{"line_number":480,"context_line":"        :param context: The \u0027context.RequestContext\u0027 object for the request."},{"line_number":481,"context_line":"        :param share: Reference to the share being migrated."},{"line_number":482,"context_line":"        :param dest_host: Destination host."},{"line_number":483,"context_line":"        :param share_server: Share server model or None."},{"line_number":484,"context_line":"        :return: A dictionary with migration information."},{"line_number":485,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"1ac06dbe_745af151","line":482,"range":{"start_line":482,"start_character":8,"end_line":482,"end_character":43},"in_reply_to":"1ac06dbe_ec3f4423","updated":"2016-08-22 18:15:50.000000000","message":"Done","commit_id":"658c51c7bd2558363b756eff405df3a23134fb36"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a116f3181675e171f2660f2f10c25eaac31d417d","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                 \u0027allowed\u0027: driver_handles_share_servers})"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def migration_check_compatibility("},{"line_number":320,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":321,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":322,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":323,"context_line":"        \"\"\"Is called to test compatibility with destination backend."}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_936cac36","line":320,"range":{"start_line":320,"start_character":47,"end_line":320,"end_character":55},"updated":"2016-08-22 17:54:02.000000000","message":"destination_host","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a116f3181675e171f2660f2f10c25eaac31d417d","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                 \u0027allowed\u0027: driver_handles_share_servers})"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def migration_check_compatibility("},{"line_number":320,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":321,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":322,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":323,"context_line":"        \"\"\"Is called to test compatibility with destination backend."}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_738130c3","line":320,"range":{"start_line":320,"start_character":27,"end_line":320,"end_character":45},"updated":"2016-08-22 17:54:02.000000000","message":"source_share or just share","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"66fd0c27729edbc5f76960c6e7ebd7da86cf6ed5","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                 \u0027allowed\u0027: driver_handles_share_servers})"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def migration_check_compatibility("},{"line_number":320,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":321,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":322,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":323,"context_line":"        \"\"\"Is called to test compatibility with destination backend."}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_766bdef1","line":320,"range":{"start_line":320,"start_character":27,"end_line":320,"end_character":45},"in_reply_to":"1ac06dbe_738130c3","updated":"2016-08-22 18:15:31.000000000","message":"Done","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"66fd0c27729edbc5f76960c6e7ebd7da86cf6ed5","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                 \u0027allowed\u0027: driver_handles_share_servers})"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def migration_check_compatibility("},{"line_number":320,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":321,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":322,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":323,"context_line":"        \"\"\"Is called to test compatibility with destination backend."}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_567062dc","line":320,"range":{"start_line":320,"start_character":47,"end_line":320,"end_character":55},"in_reply_to":"1ac06dbe_936cac36","updated":"2016-08-22 18:15:31.000000000","message":"Done","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a116f3181675e171f2660f2f10c25eaac31d417d","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def migration_check_compatibility("},{"line_number":320,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":321,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":322,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":323,"context_line":"        \"\"\"Is called to test compatibility with destination backend."},{"line_number":324,"context_line":""}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_13671c4e","line":321,"range":{"start_line":321,"start_character":40,"end_line":321,"end_character":59},"updated":"2016-08-22 17:54:02.000000000","message":"destination_share","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"66fd0c27729edbc5f76960c6e7ebd7da86cf6ed5","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def migration_check_compatibility("},{"line_number":320,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":321,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":322,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":323,"context_line":"        \"\"\"Is called to test compatibility with destination backend."},{"line_number":324,"context_line":""}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_96765ad5","line":321,"range":{"start_line":321,"start_character":40,"end_line":321,"end_character":59},"in_reply_to":"1ac06dbe_13671c4e","updated":"2016-08-22 18:15:31.000000000","message":"Done","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a116f3181675e171f2660f2f10c25eaac31d417d","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        raise NotImplementedError()"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def migration_check_writable("},{"line_number":343,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":344,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":345,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":346,"context_line":"        \"\"\"Is called to determine if source share can remain writable."},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        Driver should validate, according to the parameters supplied, if share"}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_f34c00ca","line":345,"range":{"start_line":343,"start_character":12,"end_line":345,"end_character":55},"updated":"2016-08-22 17:54:02.000000000","message":"same","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"66fd0c27729edbc5f76960c6e7ebd7da86cf6ed5","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        raise NotImplementedError()"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def migration_check_writable("},{"line_number":343,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":344,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":345,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":346,"context_line":"        \"\"\"Is called to determine if source share can remain writable."},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        Driver should validate, according to the parameters supplied, if share"}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_d67c52b7","line":345,"range":{"start_line":343,"start_character":12,"end_line":345,"end_character":55},"in_reply_to":"1ac06dbe_f34c00ca","updated":"2016-08-22 18:15:31.000000000","message":"Done","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a116f3181675e171f2660f2f10c25eaac31d417d","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        return False"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    def migration_start("},{"line_number":368,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":369,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":370,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":371,"context_line":"        \"\"\"Is called in source share\u0027s backend to start migration."},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        Driver should implement this method if willing to perform migration"}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_d34904b9","line":370,"range":{"start_line":368,"start_character":11,"end_line":370,"end_character":55},"updated":"2016-08-22 17:54:02.000000000","message":"same","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"66fd0c27729edbc5f76960c6e7ebd7da86cf6ed5","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        return False"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    def migration_start("},{"line_number":368,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":369,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":370,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":371,"context_line":"        \"\"\"Is called in source share\u0027s backend to start migration."},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        Driver should implement this method if willing to perform migration"}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_364cc69d","line":370,"range":{"start_line":368,"start_character":11,"end_line":370,"end_character":55},"in_reply_to":"1ac06dbe_d34904b9","updated":"2016-08-22 18:15:31.000000000","message":"Done","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a116f3181675e171f2660f2f10c25eaac31d417d","unresolved":false,"context_lines":[{"line_number":389,"context_line":"        raise NotImplementedError()"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def migration_continue("},{"line_number":392,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":393,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":394,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":395,"context_line":"        \"\"\"Is called in source share\u0027s backend to continue migration."},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        Driver should implement this method to continue monitor the migration"}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_13cefc2d","line":394,"range":{"start_line":392,"start_character":12,"end_line":394,"end_character":55},"updated":"2016-08-22 17:54:02.000000000","message":"same","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"66fd0c27729edbc5f76960c6e7ebd7da86cf6ed5","unresolved":false,"context_lines":[{"line_number":389,"context_line":"        raise NotImplementedError()"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def migration_continue("},{"line_number":392,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":393,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":394,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":395,"context_line":"        \"\"\"Is called in source share\u0027s backend to continue migration."},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        Driver should implement this method to continue monitor the migration"}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_7642be69","line":394,"range":{"start_line":392,"start_character":12,"end_line":394,"end_character":55},"in_reply_to":"1ac06dbe_13cefc2d","updated":"2016-08-22 18:15:31.000000000","message":"Done","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a116f3181675e171f2660f2f10c25eaac31d417d","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        raise NotImplementedError()"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    def migration_complete("},{"line_number":415,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":416,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":417,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":418,"context_line":"        \"\"\"Is called in source share\u0027s backend to complete migration."},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        If driver is implementing 2-phase migration, this method should"}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_73cf7029","line":417,"range":{"start_line":415,"start_character":12,"end_line":417,"end_character":55},"updated":"2016-08-22 17:54:02.000000000","message":"same","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"66fd0c27729edbc5f76960c6e7ebd7da86cf6ed5","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        raise NotImplementedError()"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    def migration_complete("},{"line_number":415,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":416,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":417,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":418,"context_line":"        \"\"\"Is called in source share\u0027s backend to complete migration."},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        If driver is implementing 2-phase migration, this method should"}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_5647c276","line":417,"range":{"start_line":415,"start_character":12,"end_line":417,"end_character":55},"in_reply_to":"1ac06dbe_73cf7029","updated":"2016-08-22 18:15:31.000000000","message":"Done","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a116f3181675e171f2660f2f10c25eaac31d417d","unresolved":false,"context_lines":[{"line_number":436,"context_line":"        return None"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    def migration_cancel("},{"line_number":439,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":440,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":441,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":442,"context_line":"        \"\"\"Is called in source share\u0027s backend to cancel migration."},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        If possible, driver can implement a way to cancel an in-progress"}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_f3e360a2","line":441,"range":{"start_line":439,"start_character":11,"end_line":441,"end_character":55},"updated":"2016-08-22 17:54:02.000000000","message":"same","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"66fd0c27729edbc5f76960c6e7ebd7da86cf6ed5","unresolved":false,"context_lines":[{"line_number":436,"context_line":"        return None"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    def migration_cancel("},{"line_number":439,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":440,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":441,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":442,"context_line":"        \"\"\"Is called in source share\u0027s backend to cancel migration."},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        If possible, driver can implement a way to cancel an in-progress"}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_b660b602","line":441,"range":{"start_line":439,"start_character":11,"end_line":441,"end_character":55},"in_reply_to":"1ac06dbe_f3e360a2","updated":"2016-08-22 18:15:31.000000000","message":"Done","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a116f3181675e171f2660f2f10c25eaac31d417d","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        raise NotImplementedError()"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    def migration_get_progress("},{"line_number":460,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":461,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":462,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":463,"context_line":"        \"\"\"Is called in source share\u0027s backend to obtain migration progress."},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        If possible, driver can implement a way to return migration progress"}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_13f55c56","line":462,"range":{"start_line":460,"start_character":11,"end_line":462,"end_character":55},"updated":"2016-08-22 17:54:02.000000000","message":"same","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"66fd0c27729edbc5f76960c6e7ebd7da86cf6ed5","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        raise NotImplementedError()"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    def migration_get_progress("},{"line_number":460,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":461,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":462,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":463,"context_line":"        \"\"\"Is called in source share\u0027s backend to obtain migration progress."},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        If possible, driver can implement a way to return migration progress"}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_965dba49","line":462,"range":{"start_line":460,"start_character":11,"end_line":462,"end_character":55},"in_reply_to":"1ac06dbe_13f55c56","updated":"2016-08-22 18:15:31.000000000","message":"Done","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a116f3181675e171f2660f2f10c25eaac31d417d","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        \"\"\""},{"line_number":480,"context_line":"        raise NotImplementedError()"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"    def migration_get_driver_info(self, context, share, dest_host,"},{"line_number":483,"context_line":"                                  share_server\u003dNone):"},{"line_number":484,"context_line":"        \"\"\"Is called to provide necessary driver migration logic."},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"        Drivers that implement optimized migration may need to obtain"}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_b304484a","line":483,"range":{"start_line":482,"start_character":33,"end_line":483,"end_character":53},"updated":"2016-08-22 17:54:02.000000000","message":"same","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"66fd0c27729edbc5f76960c6e7ebd7da86cf6ed5","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        \"\"\""},{"line_number":480,"context_line":"        raise NotImplementedError()"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"    def migration_get_driver_info(self, context, share, dest_host,"},{"line_number":483,"context_line":"                                  share_server\u003dNone):"},{"line_number":484,"context_line":"        \"\"\"Is called to provide necessary driver migration logic."},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"        Drivers that implement optimized migration may need to obtain"}],"source_content_type":"text/x-python","patch_set":53,"id":"1ac06dbe_1638aaee","line":483,"range":{"start_line":482,"start_character":33,"end_line":483,"end_character":53},"in_reply_to":"1ac06dbe_b304484a","updated":"2016-08-22 18:15:31.000000000","message":"Done","commit_id":"ca05e101e35b41a677e624acf8ba1c5799bdaeef"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"fb65600b80ee60b7d9176b6a79ff33315aa95e67","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        :return: A boolean indicating if it is compatible."},{"line_number":340,"context_line":"        \"\"\""},{"line_number":341,"context_line":"        raise NotImplementedError()"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    def migration_check_writable("},{"line_number":344,"context_line":"            self, context, source_share, destination_host,"},{"line_number":345,"context_line":"            destination_driver_migration_info, destination_share,"}],"source_content_type":"text/x-python","patch_set":56,"id":"1ac06dbe_f124e160","line":342,"updated":"2016-08-23 04:20:26.000000000","message":"I kind of think these two ^ v methods could be combined... What matters is whether the driver can do what the user asked or not. We know all the information up front, including the source, the destination, and whether the user wants, writable-only, nondisruptive-only, or non-metadata-lossy-only.","commit_id":"1c46d78049c89eb0cde9f577ae6e1c918e973205"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8e8dad4bb281515e339a6d7d6a75168f458b86f9","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        :return: A boolean indicating if it is compatible."},{"line_number":340,"context_line":"        \"\"\""},{"line_number":341,"context_line":"        raise NotImplementedError()"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    def migration_check_writable("},{"line_number":344,"context_line":"            self, context, source_share, destination_host,"},{"line_number":345,"context_line":"            destination_driver_migration_info, destination_share,"}],"source_content_type":"text/x-python","patch_set":56,"id":"1ac06dbe_9d3aae97","line":342,"in_reply_to":"1ac06dbe_f124e160","updated":"2016-08-23 16:59:00.000000000","message":"Done. More parameters will be added in newton-migration-improvements patch.","commit_id":"1c46d78049c89eb0cde9f577ae6e1c918e973205"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ef4f97551e6eb7dcc3cef71cc04f26b835f1ccc0","unresolved":false,"context_lines":[{"line_number":320,"context_line":"            self, context, source_share, destination_host,"},{"line_number":321,"context_line":"            destination_driver_migration_info, destination_share,"},{"line_number":322,"context_line":"            share_server\u003dNone, destination_share_server\u003dNone):"},{"line_number":323,"context_line":"        \"\"\"Is called to test compatibility with destination backend."},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        Based on destination_driver_migration_info, driver should check if it"},{"line_number":326,"context_line":"        is compatible with destination backend so optimized migration can"}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_ca7b6728","line":323,"range":{"start_line":323,"start_character":11,"end_line":323,"end_character":67},"updated":"2016-08-24 21:13:37.000000000","message":"this","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f30fdf868444c7a9f3033a23f8bcc1a54e39cd87","unresolved":false,"context_lines":[{"line_number":320,"context_line":"            self, context, source_share, destination_host,"},{"line_number":321,"context_line":"            destination_driver_migration_info, destination_share,"},{"line_number":322,"context_line":"            share_server\u003dNone, destination_share_server\u003dNone):"},{"line_number":323,"context_line":"        \"\"\"Is called to test compatibility with destination backend."},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        Based on destination_driver_migration_info, driver should check if it"},{"line_number":326,"context_line":"        is compatible with destination backend so optimized migration can"}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_3fd22e35","line":323,"range":{"start_line":323,"start_character":11,"end_line":323,"end_character":67},"in_reply_to":"1ac06dbe_ca7b6728","updated":"2016-08-25 01:05:40.000000000","message":"Done","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ef4f97551e6eb7dcc3cef71cc04f26b835f1ccc0","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            self, context, source_share, destination_host,"},{"line_number":357,"context_line":"            destination_driver_migration_info, destination_share,"},{"line_number":358,"context_line":"            share_server\u003dNone, destination_share_server\u003dNone):"},{"line_number":359,"context_line":"        \"\"\"Is called in source share\u0027s backend to start migration."},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        Driver should implement this method if willing to perform migration"},{"line_number":362,"context_line":"        in an optimized way, useful for when source share\u0027s backend driver"}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_aa78ab2c","line":359,"range":{"start_line":359,"start_character":11,"end_line":359,"end_character":66},"updated":"2016-08-24 21:13:37.000000000","message":"this","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f30fdf868444c7a9f3033a23f8bcc1a54e39cd87","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            self, context, source_share, destination_host,"},{"line_number":357,"context_line":"            destination_driver_migration_info, destination_share,"},{"line_number":358,"context_line":"            share_server\u003dNone, destination_share_server\u003dNone):"},{"line_number":359,"context_line":"        \"\"\"Is called in source share\u0027s backend to start migration."},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        Driver should implement this method if willing to perform migration"},{"line_number":362,"context_line":"        in an optimized way, useful for when source share\u0027s backend driver"}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_1fd77224","line":359,"range":{"start_line":359,"start_character":11,"end_line":359,"end_character":66},"in_reply_to":"1ac06dbe_aa78ab2c","updated":"2016-08-25 01:05:40.000000000","message":"Done","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ef4f97551e6eb7dcc3cef71cc04f26b835f1ccc0","unresolved":false,"context_lines":[{"line_number":381,"context_line":"            self, context, source_share, destination_host,"},{"line_number":382,"context_line":"            destination_driver_migration_info, destination_share,"},{"line_number":383,"context_line":"            share_server\u003dNone, destination_share_server\u003dNone):"},{"line_number":384,"context_line":"        \"\"\"Is called in source share\u0027s backend to continue migration."},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        Driver should implement this method to continue monitor the migration"},{"line_number":387,"context_line":"        progress in storage and perform following steps until 1st phase is"}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_ea72a348","line":384,"range":{"start_line":384,"start_character":11,"end_line":384,"end_character":69},"updated":"2016-08-24 21:13:37.000000000","message":"this","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f30fdf868444c7a9f3033a23f8bcc1a54e39cd87","unresolved":false,"context_lines":[{"line_number":381,"context_line":"            self, context, source_share, destination_host,"},{"line_number":382,"context_line":"            destination_driver_migration_info, destination_share,"},{"line_number":383,"context_line":"            share_server\u003dNone, destination_share_server\u003dNone):"},{"line_number":384,"context_line":"        \"\"\"Is called in source share\u0027s backend to continue migration."},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        Driver should implement this method to continue monitor the migration"},{"line_number":387,"context_line":"        progress in storage and perform following steps until 1st phase is"}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_7fdca646","line":384,"range":{"start_line":384,"start_character":11,"end_line":384,"end_character":69},"in_reply_to":"1ac06dbe_ea72a348","updated":"2016-08-25 01:05:40.000000000","message":"Done","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ef4f97551e6eb7dcc3cef71cc04f26b835f1ccc0","unresolved":false,"context_lines":[{"line_number":405,"context_line":"            self, context, source_share, destination_host,"},{"line_number":406,"context_line":"            destination_driver_migration_info, destination_share,"},{"line_number":407,"context_line":"            share_server\u003dNone, destination_share_server\u003dNone):"},{"line_number":408,"context_line":"        \"\"\"Is called in source share\u0027s backend to complete migration."},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        If driver is implementing 2-phase migration, this method should"},{"line_number":411,"context_line":"        perform the disruptive tasks related to the 2nd phase of migration,"}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_6a87d3d7","line":408,"range":{"start_line":408,"start_character":11,"end_line":408,"end_character":69},"updated":"2016-08-24 21:13:37.000000000","message":"this","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f30fdf868444c7a9f3033a23f8bcc1a54e39cd87","unresolved":false,"context_lines":[{"line_number":405,"context_line":"            self, context, source_share, destination_host,"},{"line_number":406,"context_line":"            destination_driver_migration_info, destination_share,"},{"line_number":407,"context_line":"            share_server\u003dNone, destination_share_server\u003dNone):"},{"line_number":408,"context_line":"        \"\"\"Is called in source share\u0027s backend to complete migration."},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        If driver is implementing 2-phase migration, this method should"},{"line_number":411,"context_line":"        perform the disruptive tasks related to the 2nd phase of migration,"}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_5fe1eafd","line":408,"range":{"start_line":408,"start_character":11,"end_line":408,"end_character":69},"in_reply_to":"1ac06dbe_6a87d3d7","updated":"2016-08-25 01:05:40.000000000","message":"Done","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ef4f97551e6eb7dcc3cef71cc04f26b835f1ccc0","unresolved":false,"context_lines":[{"line_number":430,"context_line":"            self, context, source_share, destination_host,"},{"line_number":431,"context_line":"            destination_driver_migration_info, destination_share,"},{"line_number":432,"context_line":"            share_server\u003dNone, destination_share_server\u003dNone):"},{"line_number":433,"context_line":"        \"\"\"Is called in source share\u0027s backend to cancel migration."},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"        If possible, driver can implement a way to cancel an in-progress"},{"line_number":436,"context_line":"        migration."}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_aa69cb27","line":433,"range":{"start_line":433,"start_character":11,"end_line":433,"end_character":67},"updated":"2016-08-24 21:13:37.000000000","message":"this","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f30fdf868444c7a9f3033a23f8bcc1a54e39cd87","unresolved":false,"context_lines":[{"line_number":430,"context_line":"            self, context, source_share, destination_host,"},{"line_number":431,"context_line":"            destination_driver_migration_info, destination_share,"},{"line_number":432,"context_line":"            share_server\u003dNone, destination_share_server\u003dNone):"},{"line_number":433,"context_line":"        \"\"\"Is called in source share\u0027s backend to cancel migration."},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"        If possible, driver can implement a way to cancel an in-progress"},{"line_number":436,"context_line":"        migration."}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_bfe61e14","line":433,"range":{"start_line":433,"start_character":11,"end_line":433,"end_character":67},"in_reply_to":"1ac06dbe_aa69cb27","updated":"2016-08-25 01:05:40.000000000","message":"Done","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ef4f97551e6eb7dcc3cef71cc04f26b835f1ccc0","unresolved":false,"context_lines":[{"line_number":452,"context_line":"            self, context, source_share, destination_host,"},{"line_number":453,"context_line":"            destination_driver_migration_info, destination_share,"},{"line_number":454,"context_line":"            share_server\u003dNone, destination_share_server\u003dNone):"},{"line_number":455,"context_line":"        \"\"\"Is called in source share\u0027s backend to obtain migration progress."},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        If possible, driver can implement a way to return migration progress"},{"line_number":458,"context_line":"        information."}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_4a9497e7","line":455,"range":{"start_line":455,"start_character":11,"end_line":455,"end_character":75},"updated":"2016-08-24 21:13:37.000000000","message":"this\n\nIn the replication interfaces, i made these stand out by using the ..note:: annotation.. It\u0027s really essential information that needs more highlighting","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f30fdf868444c7a9f3033a23f8bcc1a54e39cd87","unresolved":false,"context_lines":[{"line_number":452,"context_line":"            self, context, source_share, destination_host,"},{"line_number":453,"context_line":"            destination_driver_migration_info, destination_share,"},{"line_number":454,"context_line":"            share_server\u003dNone, destination_share_server\u003dNone):"},{"line_number":455,"context_line":"        \"\"\"Is called in source share\u0027s backend to obtain migration progress."},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        If possible, driver can implement a way to return migration progress"},{"line_number":458,"context_line":"        information."}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_9fe36205","line":455,"range":{"start_line":455,"start_character":11,"end_line":455,"end_character":75},"in_reply_to":"1ac06dbe_4a9497e7","updated":"2016-08-25 01:05:40.000000000","message":"Done","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ef4f97551e6eb7dcc3cef71cc04f26b835f1ccc0","unresolved":false,"context_lines":[{"line_number":472,"context_line":"        \"\"\""},{"line_number":473,"context_line":"        raise NotImplementedError()"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    def migration_get_driver_info(self, context, share, destination_host,"},{"line_number":476,"context_line":"                                  share_server\u003dNone):"},{"line_number":477,"context_line":"        \"\"\"Is called to provide necessary driver migration logic."},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        Drivers that implement optimized migration may need to obtain"},{"line_number":480,"context_line":"        information about the destination backend. At the moment, this can be"},{"line_number":481,"context_line":"        done through the configuration file. Driver should provide a dictionary"},{"line_number":482,"context_line":"        with all parameters (and their values) related to destination backend"},{"line_number":483,"context_line":"        configuration group."},{"line_number":484,"context_line":"        :param context: The \u0027context.RequestContext\u0027 object for the request."},{"line_number":485,"context_line":"        :param share: Reference to the share being migrated."},{"line_number":486,"context_line":"        :param destination_host: Destination host string in"},{"line_number":487,"context_line":"            hostname@backend#pool format."},{"line_number":488,"context_line":"        :param share_server: Share server model or None."},{"line_number":489,"context_line":"        :return: A dictionary with migration information."},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        Example::"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"            {"},{"line_number":494,"context_line":"                \u0027vendor_storage_mgmt_ip\u0027: \u0027172.24.47.155\u0027,"},{"line_number":495,"context_line":"                \u0027vendor_storage_mgmt_user\u0027: \u0027admin\u0027,"},{"line_number":496,"context_line":"                \u0027vendor_storage_mgmt_pass\u0027: \u0027secretpass\u0027,"},{"line_number":497,"context_line":"                \u0027vendor_storage_server_pool_name\u0027: \u0027some_pool\u0027,"},{"line_number":498,"context_line":"                \u0027vendor_storage_server_data_ip\u0027: \u0027192.168.100.5\u0027,"},{"line_number":499,"context_line":"                \u0027vendor_storage_server_id\u0027: 4,"},{"line_number":500,"context_line":"                \u0027vendor_storage_enable_cg_support\u0027: True,"},{"line_number":501,"context_line":"                \u0027vendor_storage_driver_helper\u0027: \u0027manila.path.to.helper.Class\u0027,"},{"line_number":502,"context_line":"                \u0027vendor_storage_create_share_timeout\u0027: 600,"},{"line_number":503,"context_line":"                \u0027vendor_storage_cluster_data_port\u0027: 12225,"},{"line_number":504,"context_line":"                \u0027vendor_storage_cluster_adm_ip\u0027: \u0027172.14.22.67\u0027,"},{"line_number":505,"context_line":"            }"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        \"\"\""},{"line_number":508,"context_line":"        return {}"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    def migration_get_info(self, context, share, share_server\u003dNone):"},{"line_number":511,"context_line":"        \"\"\"Is called to provide necessary generic migration logic."}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_f0d732eb","line":508,"range":{"start_line":475,"start_character":4,"end_line":508,"end_character":17},"updated":"2016-08-24 21:13:37.000000000","message":"If a driver has this information at hand, it wouldn\u0027t be a problem reading this information when it needs it.. We shouldn\u0027t ask for this information to be passed via the share manager. Thank you for explaining to me that this was part of an earlier design to work with RPCing to the destination from the share manager to read its configuration. However, since that design has changed, this interface is:\n\ni. redundant - because the driver always has access to this information and it doesn\u0027t need to get it from the share manager\nii. bad in terms of security if passwords and IPs are being sent to the share manager. \n\nSo, i suggest dropping this interface altogether.","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f30fdf868444c7a9f3033a23f8bcc1a54e39cd87","unresolved":false,"context_lines":[{"line_number":472,"context_line":"        \"\"\""},{"line_number":473,"context_line":"        raise NotImplementedError()"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    def migration_get_driver_info(self, context, share, destination_host,"},{"line_number":476,"context_line":"                                  share_server\u003dNone):"},{"line_number":477,"context_line":"        \"\"\"Is called to provide necessary driver migration logic."},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        Drivers that implement optimized migration may need to obtain"},{"line_number":480,"context_line":"        information about the destination backend. At the moment, this can be"},{"line_number":481,"context_line":"        done through the configuration file. Driver should provide a dictionary"},{"line_number":482,"context_line":"        with all parameters (and their values) related to destination backend"},{"line_number":483,"context_line":"        configuration group."},{"line_number":484,"context_line":"        :param context: The \u0027context.RequestContext\u0027 object for the request."},{"line_number":485,"context_line":"        :param share: Reference to the share being migrated."},{"line_number":486,"context_line":"        :param destination_host: Destination host string in"},{"line_number":487,"context_line":"            hostname@backend#pool format."},{"line_number":488,"context_line":"        :param share_server: Share server model or None."},{"line_number":489,"context_line":"        :return: A dictionary with migration information."},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        Example::"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"            {"},{"line_number":494,"context_line":"                \u0027vendor_storage_mgmt_ip\u0027: \u0027172.24.47.155\u0027,"},{"line_number":495,"context_line":"                \u0027vendor_storage_mgmt_user\u0027: \u0027admin\u0027,"},{"line_number":496,"context_line":"                \u0027vendor_storage_mgmt_pass\u0027: \u0027secretpass\u0027,"},{"line_number":497,"context_line":"                \u0027vendor_storage_server_pool_name\u0027: \u0027some_pool\u0027,"},{"line_number":498,"context_line":"                \u0027vendor_storage_server_data_ip\u0027: \u0027192.168.100.5\u0027,"},{"line_number":499,"context_line":"                \u0027vendor_storage_server_id\u0027: 4,"},{"line_number":500,"context_line":"                \u0027vendor_storage_enable_cg_support\u0027: True,"},{"line_number":501,"context_line":"                \u0027vendor_storage_driver_helper\u0027: \u0027manila.path.to.helper.Class\u0027,"},{"line_number":502,"context_line":"                \u0027vendor_storage_create_share_timeout\u0027: 600,"},{"line_number":503,"context_line":"                \u0027vendor_storage_cluster_data_port\u0027: 12225,"},{"line_number":504,"context_line":"                \u0027vendor_storage_cluster_adm_ip\u0027: \u0027172.14.22.67\u0027,"},{"line_number":505,"context_line":"            }"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        \"\"\""},{"line_number":508,"context_line":"        return {}"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    def migration_get_info(self, context, share, share_server\u003dNone):"},{"line_number":511,"context_line":"        \"\"\"Is called to provide necessary generic migration logic."}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_9f1c0215","line":508,"range":{"start_line":475,"start_character":4,"end_line":508,"end_character":17},"in_reply_to":"1ac06dbe_f0d732eb","updated":"2016-08-25 01:05:40.000000000","message":"Done","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"}],"manila/share/drivers/lvm.py":[{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"fb65600b80ee60b7d9176b6a79ff33315aa95e67","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        total_size \u003d re.findall(\"VSize\\s[0-9.]+g\", out)[0][6:-1]"},{"line_number":200,"context_line":"        free_size \u003d re.findall(\"VFree\\s[0-9.]+g\", out)[0][6:-1]"},{"line_number":201,"context_line":"        return [{"},{"line_number":202,"context_line":"            \u0027pool_name\u0027: \u0027-\u0027.join((\u0027lvm-single-pool\u0027, self.backend_name)),"},{"line_number":203,"context_line":"            \u0027total_capacity_gb\u0027: float(total_size),"},{"line_number":204,"context_line":"            \u0027free_capacity_gb\u0027: float(free_size),"},{"line_number":205,"context_line":"            \u0027reserved_percentage\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":56,"id":"1ac06dbe_eeaec5e4","line":202,"updated":"2016-08-23 04:20:26.000000000","message":"I don\u0027t think this is needed. Pools on different backends are allowed to have the same pool names because they\u0027re disambiguated by the backend name.","commit_id":"1c46d78049c89eb0cde9f577ae6e1c918e973205"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8e8dad4bb281515e339a6d7d6a75168f458b86f9","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        total_size \u003d re.findall(\"VSize\\s[0-9.]+g\", out)[0][6:-1]"},{"line_number":200,"context_line":"        free_size \u003d re.findall(\"VFree\\s[0-9.]+g\", out)[0][6:-1]"},{"line_number":201,"context_line":"        return [{"},{"line_number":202,"context_line":"            \u0027pool_name\u0027: \u0027-\u0027.join((\u0027lvm-single-pool\u0027, self.backend_name)),"},{"line_number":203,"context_line":"            \u0027total_capacity_gb\u0027: float(total_size),"},{"line_number":204,"context_line":"            \u0027free_capacity_gb\u0027: float(free_size),"},{"line_number":205,"context_line":"            \u0027reserved_percentage\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":56,"id":"1ac06dbe_fd0bf9d3","line":202,"in_reply_to":"1ac06dbe_eeaec5e4","updated":"2016-08-23 16:59:00.000000000","message":"I believe I fixed the problem in tempest in a different way but forgot to remove this. I\u0027ll double check","commit_id":"1c46d78049c89eb0cde9f577ae6e1c918e973205"}],"manila/share/manager.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c23ea65c2cb8bcb14f6e734f6b82d14ea2e42464","unresolved":false,"context_lines":[{"line_number":772,"context_line":"            try:"},{"line_number":773,"context_line":"                model_update \u003d self.driver.migration_complete("},{"line_number":774,"context_line":"                    context, share_instance, share_server)"},{"line_number":775,"context_line":"                if model_update:"},{"line_number":776,"context_line":"                    self.db.share_instance_update("},{"line_number":777,"context_line":"                        context, share_instance[\u0027id\u0027], model_update)"},{"line_number":778,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_f447da48","line":775,"range":{"start_line":775,"start_character":16,"end_line":775,"end_character":32},"updated":"2016-06-23 12:25:41.000000000","message":"It will fail if we return new export locations. And we should d return it. Also, such case is not covered with unit tests.","commit_id":"46ea9f32c92f0f4de952efa6d1bfe43a0dfedb27"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"552dddfe218e11e66b029dc855c815d8a11d55ea","unresolved":false,"context_lines":[{"line_number":772,"context_line":"            try:"},{"line_number":773,"context_line":"                model_update \u003d self.driver.migration_complete("},{"line_number":774,"context_line":"                    context, share_instance, share_server)"},{"line_number":775,"context_line":"                if model_update:"},{"line_number":776,"context_line":"                    self.db.share_instance_update("},{"line_number":777,"context_line":"                        context, share_instance[\u0027id\u0027], model_update)"},{"line_number":778,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_3761613a","line":775,"range":{"start_line":775,"start_character":16,"end_line":775,"end_character":32},"in_reply_to":"3aaa91ec_f447da48","updated":"2016-06-23 14:53:51.000000000","message":"Coming in new patch. Unit tests will be improved later when everything is working.","commit_id":"46ea9f32c92f0f4de952efa6d1bfe43a0dfedb27"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4499ef1d023223a708ee51fc061bd2304f32d72f","unresolved":false,"context_lines":[{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        return _provide_share_server_for_share()"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"    def create_share_server_in_backend("},{"line_number":472,"context_line":"            self, context, share_server, share_instance):"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        if share_server[\u0027status\u0027] \u003d\u003d constants.STATUS_CREATING:"},{"line_number":475,"context_line":"            # Create share server on backend with data from db."},{"line_number":476,"context_line":"            share_server \u003d self._setup_server(context, share_server)"},{"line_number":477,"context_line":"            LOG.info(_LI(\"Share server created successfully.\"))"},{"line_number":478,"context_line":"        else:"},{"line_number":479,"context_line":"            LOG.info(_LI(\"Used preexisting share server \""},{"line_number":480,"context_line":"                         \"\u0027%(share_server_id)s\u0027\"),"},{"line_number":481,"context_line":"                     {\u0027share_server_id\u0027: share_server[\u0027id\u0027]})"},{"line_number":482,"context_line":"        return share_server, share_instance"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    def create_remote_share_server("},{"line_number":485,"context_line":"            self, context, share_instance_id, share_server_id):"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"        share_instance \u003d self.db.share_instance_get("},{"line_number":488,"context_line":"            context, share_instance_id, with_share_data\u003dTrue)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        share_server \u003d self.db.share_server_get(context, share_server_id)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        self.create_share_server_in_backend("},{"line_number":493,"context_line":"            context, share_server, share_instance)"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    def provide_remote_share_server(self, context, share_instance_id,"},{"line_number":496,"context_line":"                                    share_network_id, snapshot_id):"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        share_instance \u003d self.db.share_instance_get(context, share_instance_id,"},{"line_number":499,"context_line":"                                                    with_share_data\u003dTrue)"},{"line_number":500,"context_line":"        snapshot_ref \u003d None"},{"line_number":501,"context_line":"        if snapshot_id:"},{"line_number":502,"context_line":"            snapshot_ref \u003d self.db.share_snapshot_get(context, snapshot_id)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        consistency_group_ref \u003d None"},{"line_number":505,"context_line":"        if share_instance.get(\u0027consistency_group_id\u0027):"},{"line_number":506,"context_line":"            consistency_group_ref \u003d self.db.consistency_group_get("},{"line_number":507,"context_line":"                context, share_instance[\u0027consistency_group_id\u0027])"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        share_server, share_instance \u003d self._provide_share_server_for_share("},{"line_number":510,"context_line":"            context, share_network_id, share_instance, snapshot_ref,"},{"line_number":511,"context_line":"            consistency_group_ref, create_in_backend\u003dFalse)"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"        return share_server[\u0027id\u0027]"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    def _provide_share_server_for_cg(self, context, share_network_id,"},{"line_number":516,"context_line":"                                     cg_ref, cgsnapshot\u003dNone):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_bc2c9202","line":513,"range":{"start_line":471,"start_character":4,"end_line":513,"end_character":33},"updated":"2016-07-13 17:01:38.000000000","message":"Please, add docstrings with details about \"when\" and \"who\" uses it? Also, you sure these should have \"public\"-like names.","commit_id":"2b2694c99d9762f2ba0f047049e911a4e95451f1"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"b97c1996770aecc64b48cd53316cf38e6c045827","unresolved":false,"context_lines":[{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        return _provide_share_server_for_share()"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"    def create_share_server_in_backend("},{"line_number":472,"context_line":"            self, context, share_server, share_instance):"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        if share_server[\u0027status\u0027] \u003d\u003d constants.STATUS_CREATING:"},{"line_number":475,"context_line":"            # Create share server on backend with data from db."},{"line_number":476,"context_line":"            share_server \u003d self._setup_server(context, share_server)"},{"line_number":477,"context_line":"            LOG.info(_LI(\"Share server created successfully.\"))"},{"line_number":478,"context_line":"        else:"},{"line_number":479,"context_line":"            LOG.info(_LI(\"Used preexisting share server \""},{"line_number":480,"context_line":"                         \"\u0027%(share_server_id)s\u0027\"),"},{"line_number":481,"context_line":"                     {\u0027share_server_id\u0027: share_server[\u0027id\u0027]})"},{"line_number":482,"context_line":"        return share_server, share_instance"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    def create_remote_share_server("},{"line_number":485,"context_line":"            self, context, share_instance_id, share_server_id):"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"        share_instance \u003d self.db.share_instance_get("},{"line_number":488,"context_line":"            context, share_instance_id, with_share_data\u003dTrue)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        share_server \u003d self.db.share_server_get(context, share_server_id)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        self.create_share_server_in_backend("},{"line_number":493,"context_line":"            context, share_server, share_instance)"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    def provide_remote_share_server(self, context, share_instance_id,"},{"line_number":496,"context_line":"                                    share_network_id, snapshot_id):"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        share_instance \u003d self.db.share_instance_get(context, share_instance_id,"},{"line_number":499,"context_line":"                                                    with_share_data\u003dTrue)"},{"line_number":500,"context_line":"        snapshot_ref \u003d None"},{"line_number":501,"context_line":"        if snapshot_id:"},{"line_number":502,"context_line":"            snapshot_ref \u003d self.db.share_snapshot_get(context, snapshot_id)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        consistency_group_ref \u003d None"},{"line_number":505,"context_line":"        if share_instance.get(\u0027consistency_group_id\u0027):"},{"line_number":506,"context_line":"            consistency_group_ref \u003d self.db.consistency_group_get("},{"line_number":507,"context_line":"                context, share_instance[\u0027consistency_group_id\u0027])"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        share_server, share_instance \u003d self._provide_share_server_for_share("},{"line_number":510,"context_line":"            context, share_network_id, share_instance, snapshot_ref,"},{"line_number":511,"context_line":"            consistency_group_ref, create_in_backend\u003dFalse)"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"        return share_server[\u0027id\u0027]"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    def _provide_share_server_for_cg(self, context, share_network_id,"},{"line_number":516,"context_line":"                                     cg_ref, cgsnapshot\u003dNone):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_4a6676ef","line":513,"range":{"start_line":471,"start_character":4,"end_line":513,"end_character":33},"in_reply_to":"1aa78d24_bc2c9202","updated":"2016-07-14 17:49:02.000000000","message":"Done. They are invoked by RPCs","commit_id":"2b2694c99d9762f2ba0f047049e911a4e95451f1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"58c029650dc497adce8c9b0f04734fce6f0630de","unresolved":false,"context_lines":[{"line_number":99,"context_line":"               help\u003d\u0027This value, specified in seconds, determines how often \u0027"},{"line_number":100,"context_line":"                    \u0027the share manager will poll for the health \u0027"},{"line_number":101,"context_line":"                    \u0027(replica_state) of each replica instance.\u0027),"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_d66b9c1c","line":102,"updated":"2016-07-26 11:22:34.000000000","message":"?","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3f0d174f280e53b18a4344bc0988f00e680d70fc","unresolved":false,"context_lines":[{"line_number":99,"context_line":"               help\u003d\u0027This value, specified in seconds, determines how often \u0027"},{"line_number":100,"context_line":"                    \u0027the share manager will poll for the health \u0027"},{"line_number":101,"context_line":"                    \u0027(replica_state) of each replica instance.\u0027),"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_24d3d905","line":102,"in_reply_to":"dada55a8_d66b9c1c","updated":"2016-07-26 16:02:40.000000000","message":"Done","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"58c029650dc497adce8c9b0f04734fce6f0630de","unresolved":false,"context_lines":[{"line_number":341,"context_line":"    def _provide_share_server_for_share(self, context, share_network_id,"},{"line_number":342,"context_line":"                                        share_instance, snapshot\u003dNone,"},{"line_number":343,"context_line":"                                        consistency_group\u003dNone,"},{"line_number":344,"context_line":"                                        create_in_backend\u003dTrue):"},{"line_number":345,"context_line":"        \"\"\"Gets or creates share_server and updates share with its id."},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        Active share_server can be deleted if there are no dependent shares"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_56d96c56","line":344,"range":{"start_line":344,"start_character":40,"end_line":344,"end_character":62},"updated":"2016-07-26 11:22:34.000000000","message":"If you add new argument, then need to add its description to docstring too. No matter that previous one didn\u0027t follow that approach.","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3f0d174f280e53b18a4344bc0988f00e680d70fc","unresolved":false,"context_lines":[{"line_number":341,"context_line":"    def _provide_share_server_for_share(self, context, share_network_id,"},{"line_number":342,"context_line":"                                        share_instance, snapshot\u003dNone,"},{"line_number":343,"context_line":"                                        consistency_group\u003dNone,"},{"line_number":344,"context_line":"                                        create_in_backend\u003dTrue):"},{"line_number":345,"context_line":"        \"\"\"Gets or creates share_server and updates share with its id."},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        Active share_server can be deleted if there are no dependent shares"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_bf7074a5","line":344,"range":{"start_line":344,"start_character":40,"end_line":344,"end_character":62},"in_reply_to":"dada55a8_56d96c56","updated":"2016-07-26 16:02:40.000000000","message":"Done","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"58c029650dc497adce8c9b0f04734fce6f0630de","unresolved":false,"context_lines":[{"line_number":480,"context_line":"                     {\u0027share_server_id\u0027: share_server[\u0027id\u0027]})"},{"line_number":481,"context_line":"        return share_server"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def create_remote_share_server(self, context, share_server_id):"},{"line_number":484,"context_line":"        \"\"\"Invoked remotely to create a share server in this backend."},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"        This method is invoked by another backend when trying to provide a"},{"line_number":487,"context_line":"        share server where shares will be moved to or created in by the"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_967e4468","line":484,"range":{"start_line":483,"start_character":4,"end_line":484,"end_character":69},"updated":"2016-07-26 11:22:34.000000000","message":"Very confusing combination.\n\nIf you need to be able to create share server on host, you define method \"create_share_server\". And then just call it from wherever you need. Such words as \"remote\" or \"in this backend\" just confusing.","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3f0d174f280e53b18a4344bc0988f00e680d70fc","unresolved":false,"context_lines":[{"line_number":480,"context_line":"                     {\u0027share_server_id\u0027: share_server[\u0027id\u0027]})"},{"line_number":481,"context_line":"        return share_server"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def create_remote_share_server(self, context, share_server_id):"},{"line_number":484,"context_line":"        \"\"\"Invoked remotely to create a share server in this backend."},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"        This method is invoked by another backend when trying to provide a"},{"line_number":487,"context_line":"        share server where shares will be moved to or created in by the"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_ff94ac8b","line":484,"range":{"start_line":483,"start_character":4,"end_line":484,"end_character":69},"in_reply_to":"dada55a8_967e4468","updated":"2016-07-26 16:02:40.000000000","message":"Done","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"58c029650dc497adce8c9b0f04734fce6f0630de","unresolved":false,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        self._create_share_server_in_backend(context, share_server)"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    def provide_remote_share_server(self, context, share_instance_id,"},{"line_number":498,"context_line":"                                    share_network_id, snapshot_id):"},{"line_number":499,"context_line":"        \"\"\"Invoked remotely to provide a compatible share server."},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        This method is invoked by another backend when trying to provide a"},{"line_number":502,"context_line":"        share server where shares will be moved to or created in by the"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_b6c70897","line":499,"range":{"start_line":497,"start_character":4,"end_line":499,"end_character":65},"updated":"2016-07-26 11:22:34.000000000","message":"Same here.","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3f0d174f280e53b18a4344bc0988f00e680d70fc","unresolved":false,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        self._create_share_server_in_backend(context, share_server)"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    def provide_remote_share_server(self, context, share_instance_id,"},{"line_number":498,"context_line":"                                    share_network_id, snapshot_id):"},{"line_number":499,"context_line":"        \"\"\"Invoked remotely to provide a compatible share server."},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        This method is invoked by another backend when trying to provide a"},{"line_number":502,"context_line":"        share server where shares will be moved to or created in by the"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_5fbcd805","line":499,"range":{"start_line":497,"start_character":4,"end_line":499,"end_character":65},"in_reply_to":"dada55a8_b6c70897","updated":"2016-07-26 16:02:40.000000000","message":"Done","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e3ddc221b0f82fbede352458d6bd440ecb362337","unresolved":false,"context_lines":[{"line_number":980,"context_line":"            self.db.share_export_locations_update("},{"line_number":981,"context_line":"                context, dest_share_instance[\u0027id\u0027], export_locations)"},{"line_number":982,"context_line":""},{"line_number":983,"context_line":"        self.access_helper.update_access_rules("},{"line_number":984,"context_line":"            context, dest_share_instance[\u0027id\u0027],"},{"line_number":985,"context_line":"            share_server\u003ddest_share_server)"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"        self.db.share_instance_update("},{"line_number":988,"context_line":"            context, dest_share_instance[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":47,"id":"9ad45d7e_d8cd5e32","line":985,"range":{"start_line":983,"start_character":8,"end_line":985,"end_character":43},"updated":"2016-08-11 09:47:14.000000000","message":"Is it correct that you call update of access for destination share instance on source host?\nIf yes, then in case of multinode setup you will get NotFound errors, in case of single-node setup you get lucky success.","commit_id":"10f5a61b03ca695766d5983fc53002cdb2776062"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1b227e53b894709ce4e3d494c41c48ae53597347","unresolved":false,"context_lines":[{"line_number":980,"context_line":"            self.db.share_export_locations_update("},{"line_number":981,"context_line":"                context, dest_share_instance[\u0027id\u0027], export_locations)"},{"line_number":982,"context_line":""},{"line_number":983,"context_line":"        self.access_helper.update_access_rules("},{"line_number":984,"context_line":"            context, dest_share_instance[\u0027id\u0027],"},{"line_number":985,"context_line":"            share_server\u003ddest_share_server)"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"        self.db.share_instance_update("},{"line_number":988,"context_line":"            context, dest_share_instance[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":47,"id":"9ad45d7e_2e2a6f90","line":985,"range":{"start_line":983,"start_character":8,"end_line":985,"end_character":43},"in_reply_to":"9ad45d7e_d8cd5e32","updated":"2016-08-11 11:53:40.000000000","message":"For the moment, implemented workaround in ZFSonLinux driver. So, it will be ok.","commit_id":"10f5a61b03ca695766d5983fc53002cdb2776062"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            if (share_ref[\u0027task_state\u0027] \u003d\u003d ("},{"line_number":289,"context_line":"                    constants.TASK_STATE_MIGRATION_DRIVER_IN_PROGRESS) and"},{"line_number":290,"context_line":"                    share_instance[\u0027status\u0027] \u003d\u003d constants.STATUS_MIGRATING and"},{"line_number":291,"context_line":"                    self.host in share_instance[\u0027host\u0027]):"},{"line_number":292,"context_line":"                rpcapi \u003d share_rpcapi.ShareAPI()"},{"line_number":293,"context_line":"                rpcapi.migration_driver_recovery(ctxt, share_ref, self.host)"},{"line_number":294,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_3aac1eed","line":291,"range":{"start_line":291,"start_character":20,"end_line":291,"end_character":55},"updated":"2016-08-15 02:45:17.000000000","message":"this condition is always true, see line 282..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            if (share_ref[\u0027task_state\u0027] \u003d\u003d ("},{"line_number":289,"context_line":"                    constants.TASK_STATE_MIGRATION_DRIVER_IN_PROGRESS) and"},{"line_number":290,"context_line":"                    share_instance[\u0027status\u0027] \u003d\u003d constants.STATUS_MIGRATING and"},{"line_number":291,"context_line":"                    self.host in share_instance[\u0027host\u0027]):"},{"line_number":292,"context_line":"                rpcapi \u003d share_rpcapi.ShareAPI()"},{"line_number":293,"context_line":"                rpcapi.migration_driver_recovery(ctxt, share_ref, self.host)"},{"line_number":294,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_d6cf3e7d","line":291,"range":{"start_line":291,"start_character":20,"end_line":291,"end_character":55},"in_reply_to":"3ac371cc_3aac1eed","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    def _provide_share_server_for_share(self, context, share_network_id,"},{"line_number":354,"context_line":"                                        share_instance, snapshot\u003dNone,"},{"line_number":355,"context_line":"                                        consistency_group\u003dNone,"},{"line_number":356,"context_line":"                                        create_in_backend\u003dTrue):"},{"line_number":357,"context_line":"        \"\"\"Gets or creates share_server and updates share with its id."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        Active share_server can be deleted if there are no dependent shares"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_9ab9d231","line":356,"range":{"start_line":356,"start_character":47,"end_line":356,"end_character":49},"updated":"2016-08-15 02:45:17.000000000","message":"nit: on","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    def _provide_share_server_for_share(self, context, share_network_id,"},{"line_number":354,"context_line":"                                        share_instance, snapshot\u003dNone,"},{"line_number":355,"context_line":"                                        consistency_group\u003dNone,"},{"line_number":356,"context_line":"                                        create_in_backend\u003dTrue):"},{"line_number":357,"context_line":"        \"\"\"Gets or creates share_server and updates share with its id."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        Active share_server can be deleted if there are no dependent shares"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_16ca766d","line":356,"range":{"start_line":356,"start_character":47,"end_line":356,"end_character":49},"in_reply_to":"3ac371cc_9ab9d231","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                                 share_network_id from provided snapshot."},{"line_number":373,"context_line":"        :param share_instance: Share Instance model"},{"line_number":374,"context_line":"        :param snapshot: Optional -- Snapshot model"},{"line_number":375,"context_line":"        :param create_in_backend: If no existing share server is found, sets"},{"line_number":376,"context_line":"                                  whether it should create just the model or"},{"line_number":377,"context_line":"                                  also create it in backend immediately."},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        :returns: dict, dict -- first value is share_server, that"},{"line_number":380,"context_line":"                  has been chosen for share schedule. Second value is"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_ba864e63","line":377,"range":{"start_line":375,"start_character":34,"end_line":377,"end_character":72},"updated":"2016-08-15 02:45:17.000000000","message":"nit: Boolean, If True, driver will be asked to create the share server if no share server is available.","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                                 share_network_id from provided snapshot."},{"line_number":373,"context_line":"        :param share_instance: Share Instance model"},{"line_number":374,"context_line":"        :param snapshot: Optional -- Snapshot model"},{"line_number":375,"context_line":"        :param create_in_backend: If no existing share server is found, sets"},{"line_number":376,"context_line":"                                  whether it should create just the model or"},{"line_number":377,"context_line":"                                  also create it in backend immediately."},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        :returns: dict, dict -- first value is share_server, that"},{"line_number":380,"context_line":"                  has been chosen for share schedule. Second value is"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_36a5f2b4","line":377,"range":{"start_line":375,"start_character":34,"end_line":377,"end_character":72},"in_reply_to":"3ac371cc_ba864e63","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":474,"context_line":"                {\u0027share_server_id\u0027: compatible_share_server[\u0027id\u0027]},"},{"line_number":475,"context_line":"                with_share_data\u003dTrue"},{"line_number":476,"context_line":"            )"},{"line_number":477,"context_line":"            if create_in_backend:"},{"line_number":478,"context_line":"                compatible_share_server \u003d ("},{"line_number":479,"context_line":"                    self._create_share_server_in_backend("},{"line_number":480,"context_line":"                        context, compatible_share_server))"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_3aa09e90","line":477,"range":{"start_line":477,"start_character":22,"end_line":477,"end_character":24},"updated":"2016-08-15 02:45:17.000000000","message":"on","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":474,"context_line":"                {\u0027share_server_id\u0027: compatible_share_server[\u0027id\u0027]},"},{"line_number":475,"context_line":"                with_share_data\u003dTrue"},{"line_number":476,"context_line":"            )"},{"line_number":477,"context_line":"            if create_in_backend:"},{"line_number":478,"context_line":"                compatible_share_server \u003d ("},{"line_number":479,"context_line":"                    self._create_share_server_in_backend("},{"line_number":480,"context_line":"                        context, compatible_share_server))"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_71f774f5","line":477,"range":{"start_line":477,"start_character":22,"end_line":477,"end_character":24},"in_reply_to":"3ac371cc_3aa09e90","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":476,"context_line":"            )"},{"line_number":477,"context_line":"            if create_in_backend:"},{"line_number":478,"context_line":"                compatible_share_server \u003d ("},{"line_number":479,"context_line":"                    self._create_share_server_in_backend("},{"line_number":480,"context_line":"                        context, compatible_share_server))"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"            return compatible_share_server, share_instance_ref"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_5aa3da9e","line":479,"range":{"start_line":479,"start_character":46,"end_line":479,"end_character":48},"updated":"2016-08-15 02:45:17.000000000","message":"on","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":476,"context_line":"            )"},{"line_number":477,"context_line":"            if create_in_backend:"},{"line_number":478,"context_line":"                compatible_share_server \u003d ("},{"line_number":479,"context_line":"                    self._create_share_server_in_backend("},{"line_number":480,"context_line":"                        context, compatible_share_server))"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"            return compatible_share_server, share_instance_ref"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_b1d9ec85","line":479,"range":{"start_line":479,"start_character":46,"end_line":479,"end_character":48},"in_reply_to":"3ac371cc_5aa3da9e","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        return _provide_share_server_for_share()"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    def _create_share_server_in_backend(self, context, share_server):"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"        if share_server[\u0027status\u0027] \u003d\u003d constants.STATUS_CREATING:"},{"line_number":489,"context_line":"            # Create share server on backend with data from db."}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_9aad528b","line":486,"range":{"start_line":486,"start_character":29,"end_line":486,"end_character":31},"updated":"2016-08-15 02:45:17.000000000","message":"on","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        return _provide_share_server_for_share()"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    def _create_share_server_in_backend(self, context, share_server):"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"        if share_server[\u0027status\u0027] \u003d\u003d constants.STATUS_CREATING:"},{"line_number":489,"context_line":"            # Create share server on backend with data from db."}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_11e9e014","line":486,"range":{"start_line":486,"start_character":29,"end_line":486,"end_character":31},"in_reply_to":"3ac371cc_9aad528b","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":490,"context_line":"            share_server \u003d self._setup_server(context, share_server)"},{"line_number":491,"context_line":"            LOG.info(_LI(\"Share server created successfully.\"))"},{"line_number":492,"context_line":"        else:"},{"line_number":493,"context_line":"            LOG.info(_LI(\"Used preexisting share server \""},{"line_number":494,"context_line":"                         \"\u0027%(share_server_id)s\u0027\"),"},{"line_number":495,"context_line":"                     {\u0027share_server_id\u0027: share_server[\u0027id\u0027]})"},{"line_number":496,"context_line":"        return share_server"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_7aaa1672","line":493,"range":{"start_line":493,"start_character":26,"end_line":493,"end_character":30},"updated":"2016-08-15 02:45:17.000000000","message":"Using","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":490,"context_line":"            share_server \u003d self._setup_server(context, share_server)"},{"line_number":491,"context_line":"            LOG.info(_LI(\"Share server created successfully.\"))"},{"line_number":492,"context_line":"        else:"},{"line_number":493,"context_line":"            LOG.info(_LI(\"Used preexisting share server \""},{"line_number":494,"context_line":"                         \"\u0027%(share_server_id)s\u0027\"),"},{"line_number":495,"context_line":"                     {\u0027share_server_id\u0027: share_server[\u0027id\u0027]})"},{"line_number":496,"context_line":"        return share_server"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_dab50ad1","line":493,"range":{"start_line":493,"start_character":49,"end_line":493,"end_character":55},"updated":"2016-08-15 02:45:17.000000000","message":"server:","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":490,"context_line":"            share_server \u003d self._setup_server(context, share_server)"},{"line_number":491,"context_line":"            LOG.info(_LI(\"Share server created successfully.\"))"},{"line_number":492,"context_line":"        else:"},{"line_number":493,"context_line":"            LOG.info(_LI(\"Used preexisting share server \""},{"line_number":494,"context_line":"                         \"\u0027%(share_server_id)s\u0027\"),"},{"line_number":495,"context_line":"                     {\u0027share_server_id\u0027: share_server[\u0027id\u0027]})"},{"line_number":496,"context_line":"        return share_server"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_71ce54b5","line":493,"range":{"start_line":493,"start_character":26,"end_line":493,"end_character":30},"in_reply_to":"3ac371cc_7aaa1672","updated":"2016-08-17 12:40:36.000000000","message":"This was copied from other section. But anyway, good opportunity to fix.","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":490,"context_line":"            share_server \u003d self._setup_server(context, share_server)"},{"line_number":491,"context_line":"            LOG.info(_LI(\"Share server created successfully.\"))"},{"line_number":492,"context_line":"        else:"},{"line_number":493,"context_line":"            LOG.info(_LI(\"Used preexisting share server \""},{"line_number":494,"context_line":"                         \"\u0027%(share_server_id)s\u0027\"),"},{"line_number":495,"context_line":"                     {\u0027share_server_id\u0027: share_server[\u0027id\u0027]})"},{"line_number":496,"context_line":"        return share_server"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_d173c87e","line":493,"range":{"start_line":493,"start_character":49,"end_line":493,"end_character":55},"in_reply_to":"3ac371cc_dab50ad1","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        self._create_share_server_in_backend(context, share_server)"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def provide_share_server(self, context, share_instance_id,"},{"line_number":512,"context_line":"                             share_network_id, snapshot_id):"},{"line_number":513,"context_line":"        \"\"\"Invoked to provide a compatible share server."},{"line_number":514,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_ba93ee4e","line":511,"range":{"start_line":511,"start_character":8,"end_line":511,"end_character":28},"updated":"2016-08-15 02:45:17.000000000","message":"please suffix _for_migration so it\u0027s clear why this method exists..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        self._create_share_server_in_backend(context, share_server)"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def provide_share_server(self, context, share_instance_id,"},{"line_number":512,"context_line":"                             share_network_id, snapshot_id):"},{"line_number":513,"context_line":"        \"\"\"Invoked to provide a compatible share server."},{"line_number":514,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_9cffa766","line":511,"range":{"start_line":511,"start_character":8,"end_line":511,"end_character":28},"in_reply_to":"3ac371cc_ba93ee4e","updated":"2016-08-17 12:40:36.000000000","message":"I don\u0027t really like the idea about suffixing stuff that is for migration since other features could end up using it. I had \"migration_get_info\" and renamed it to \"connection_get_info\" because backup and Data Service Helper/API will use it.\n\nThe docstring is supposed to be clear about how this method is used.","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":527,"context_line":"        \"\"\""},{"line_number":528,"context_line":"        share_instance \u003d self.db.share_instance_get(context, share_instance_id,"},{"line_number":529,"context_line":"                                                    with_share_data\u003dTrue)"},{"line_number":530,"context_line":"        snapshot_ref \u003d None"},{"line_number":531,"context_line":"        if snapshot_id:"},{"line_number":532,"context_line":"            snapshot_ref \u003d self.db.share_snapshot_get(context, snapshot_id)"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        consistency_group_ref \u003d None"},{"line_number":535,"context_line":"        if share_instance.get(\u0027consistency_group_id\u0027):"},{"line_number":536,"context_line":"            consistency_group_ref \u003d self.db.consistency_group_get("},{"line_number":537,"context_line":"                context, share_instance[\u0027consistency_group_id\u0027])"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        share_server, share_instance \u003d self._provide_share_server_for_share("},{"line_number":540,"context_line":"            context, share_network_id, share_instance, snapshot_ref,"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_7a73364e","line":537,"range":{"start_line":530,"start_character":0,"end_line":537,"end_character":64},"updated":"2016-08-15 02:45:17.000000000","message":"Why?","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":527,"context_line":"        \"\"\""},{"line_number":528,"context_line":"        share_instance \u003d self.db.share_instance_get(context, share_instance_id,"},{"line_number":529,"context_line":"                                                    with_share_data\u003dTrue)"},{"line_number":530,"context_line":"        snapshot_ref \u003d None"},{"line_number":531,"context_line":"        if snapshot_id:"},{"line_number":532,"context_line":"            snapshot_ref \u003d self.db.share_snapshot_get(context, snapshot_id)"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        consistency_group_ref \u003d None"},{"line_number":535,"context_line":"        if share_instance.get(\u0027consistency_group_id\u0027):"},{"line_number":536,"context_line":"            consistency_group_ref \u003d self.db.consistency_group_get("},{"line_number":537,"context_line":"                context, share_instance[\u0027consistency_group_id\u0027])"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        share_server, share_instance \u003d self._provide_share_server_for_share("},{"line_number":540,"context_line":"            context, share_network_id, share_instance, snapshot_ref,"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_bc8543ae","line":537,"range":{"start_line":530,"start_character":0,"end_line":537,"end_character":64},"in_reply_to":"3ac371cc_7a73364e","updated":"2016-08-17 12:40:36.000000000","message":"For compatibility with _provide_share_server_for_share. Although I don\u0027t care if we all agree that whoever requires this later should add it.","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        share_server, share_instance \u003d self._provide_share_server_for_share("},{"line_number":540,"context_line":"            context, share_network_id, share_instance, snapshot_ref,"},{"line_number":541,"context_line":"            consistency_group_ref, create_in_backend\u003dFalse)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        return share_server[\u0027id\u0027]"},{"line_number":544,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_bae12ed3","line":541,"range":{"start_line":541,"start_character":35,"end_line":541,"end_character":58},"updated":"2016-08-15 02:45:17.000000000","message":"Why not create the server right away?","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        share_server, share_instance \u003d self._provide_share_server_for_share("},{"line_number":540,"context_line":"            context, share_network_id, share_instance, snapshot_ref,"},{"line_number":541,"context_line":"            consistency_group_ref, create_in_backend\u003dFalse)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        return share_server[\u0027id\u0027]"},{"line_number":544,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_3c7dd3e7","line":541,"range":{"start_line":541,"start_character":35,"end_line":541,"end_character":58},"in_reply_to":"3ac371cc_bae12ed3","updated":"2016-08-17 12:40:36.000000000","message":"Because the caller needs the ID to wait while checking if it is complete, and the RPC needs to be async. This is an alternative to using thread modules. A second alternative approach would be to send a RPC to itself, so the method can return the ID to the caller and create the share in another thread, but this approach seems to be more \"spaghetty\". A third approach would be to create the share server in DB in the source host, similar to the dest_share_instance. Although I personally don\u0027t like this approach.","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        share_api \u003d api.API()"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        request_spec, dest_share_instance \u003d ("},{"line_number":684,"context_line":"            share_api._create_share_instance_and_get_request_spec("},{"line_number":685,"context_line":"                context, share_ref, new_az_id, None, dest_host,"},{"line_number":686,"context_line":"                share_ref[\u0027share_network_id\u0027]))"},{"line_number":687,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_1aab228b","line":684,"range":{"start_line":684,"start_character":22,"end_line":684,"end_character":23},"updated":"2016-08-15 02:45:17.000000000","message":"time to make this a public method..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        share_api \u003d api.API()"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        request_spec, dest_share_instance \u003d ("},{"line_number":684,"context_line":"            share_api._create_share_instance_and_get_request_spec("},{"line_number":685,"context_line":"                context, share_ref, new_az_id, None, dest_host,"},{"line_number":686,"context_line":"                share_ref[\u0027share_network_id\u0027]))"},{"line_number":687,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_49ea9010","line":684,"range":{"start_line":684,"start_character":22,"end_line":684,"end_character":23},"in_reply_to":"3ac371cc_1aab228b","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        self.db.share_instance_update("},{"line_number":689,"context_line":"            context, dest_share_instance[\u0027id\u0027],"},{"line_number":690,"context_line":"            {\u0027status\u0027: constants.STATUS_MIGRATING_TO})"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"        # refresh and obtain proxified properties"},{"line_number":693,"context_line":"        dest_share_instance \u003d self.db.share_instance_get("}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_3a925e58","line":690,"range":{"start_line":690,"start_character":33,"end_line":690,"end_character":52},"updated":"2016-08-15 02:45:17.000000000","message":"if this is \u0027migrating_to\u0027, shouldn\u0027t the status of the source be \u0027migrating_from\u0027 instead of \u0027migrating\u0027.. asking for a friend :D","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        self.db.share_instance_update("},{"line_number":689,"context_line":"            context, dest_share_instance[\u0027id\u0027],"},{"line_number":690,"context_line":"            {\u0027status\u0027: constants.STATUS_MIGRATING_TO})"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"        # refresh and obtain proxified properties"},{"line_number":693,"context_line":"        dest_share_instance \u003d self.db.share_instance_get("}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_fc7dfbb1","line":690,"range":{"start_line":690,"start_character":33,"end_line":690,"end_character":52},"in_reply_to":"3ac371cc_3a925e58","updated":"2016-08-17 12:40:36.000000000","message":"the status \"migrating\" is visible to users, not only admins. Users cannot see instances, so it is much less confusing to users if they see \"migrating\" instead of \"migrating_from\" because they would wonder what \"from\" really means and where the \"migration_to\" that they cannot see is.","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":698,"context_line":"        try:"},{"line_number":699,"context_line":"            if dest_share_instance[\u0027share_network_id\u0027]:"},{"line_number":700,"context_line":"                rpcapi \u003d share_rpcapi.ShareAPI()"},{"line_number":701,"context_line":"                dest_share_server_id \u003d rpcapi.provide_share_server("},{"line_number":702,"context_line":"                    context, dest_share_instance,"},{"line_number":703,"context_line":"                    dest_share_instance[\u0027share_network_id\u0027], None)"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"                rpcapi.create_share_server("},{"line_number":706,"context_line":"                    context, dest_share_instance, dest_share_server_id)"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"                dest_share_server \u003d helper.wait_for_share_server("},{"line_number":709,"context_line":"                    dest_share_server_id)"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_dadcea1a","line":706,"range":{"start_line":701,"start_character":0,"end_line":706,"end_character":71},"updated":"2016-08-15 02:45:17.000000000","message":"Could use a #NOTE to explain the reasoning behind the two step process\n\nAlso, you could avoid the RPC cast and the wait below if you checked for the status of the server here..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":698,"context_line":"        try:"},{"line_number":699,"context_line":"            if dest_share_instance[\u0027share_network_id\u0027]:"},{"line_number":700,"context_line":"                rpcapi \u003d share_rpcapi.ShareAPI()"},{"line_number":701,"context_line":"                dest_share_server_id \u003d rpcapi.provide_share_server("},{"line_number":702,"context_line":"                    context, dest_share_instance,"},{"line_number":703,"context_line":"                    dest_share_instance[\u0027share_network_id\u0027], None)"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"                rpcapi.create_share_server("},{"line_number":706,"context_line":"                    context, dest_share_instance, dest_share_server_id)"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"                dest_share_server \u003d helper.wait_for_share_server("},{"line_number":709,"context_line":"                    dest_share_server_id)"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_09e9b814","line":706,"range":{"start_line":701,"start_character":0,"end_line":706,"end_character":71},"in_reply_to":"3ac371cc_dadcea1a","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":710,"context_line":"            else:"},{"line_number":711,"context_line":"                dest_share_server \u003d None"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"            LOG.debug(\"Calling driver migration for share %s.\","},{"line_number":714,"context_line":"                      share_ref[\u0027id\u0027])"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"            driver_writable \u003d self.driver.migration_check_writable("}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_9adb921b","line":713,"range":{"start_line":713,"start_character":23,"end_line":713,"end_character":30},"updated":"2016-08-15 02:45:17.000000000","message":"Initiating","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":710,"context_line":"            else:"},{"line_number":711,"context_line":"                dest_share_server \u003d None"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"            LOG.debug(\"Calling driver migration for share %s.\","},{"line_number":714,"context_line":"                      share_ref[\u0027id\u0027])"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"            driver_writable \u003d self.driver.migration_check_writable("}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_09c0987a","line":713,"range":{"start_line":713,"start_character":23,"end_line":713,"end_character":30},"in_reply_to":"3ac371cc_9adb921b","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":735,"context_line":"                dest_driver_migration_info, dest_share_instance,"},{"line_number":736,"context_line":"                share_server, dest_share_server)"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"            # prevent invoking _migration_driver_continue immediately"},{"line_number":739,"context_line":"            time.sleep(5)"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"            self._migration_driver_continue("},{"line_number":742,"context_line":"                context, share_ref, src_share_instance, dest_host,"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_35654fe1","line":739,"range":{"start_line":738,"start_character":12,"end_line":739,"end_character":25},"updated":"2016-08-15 02:45:17.000000000","message":"suggest moving this inside the method..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":735,"context_line":"                dest_driver_migration_info, dest_share_instance,"},{"line_number":736,"context_line":"                share_server, dest_share_server)"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"            # prevent invoking _migration_driver_continue immediately"},{"line_number":739,"context_line":"            time.sleep(5)"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"            self._migration_driver_continue("},{"line_number":742,"context_line":"                context, share_ref, src_share_instance, dest_host,"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_c996804b","line":739,"range":{"start_line":738,"start_character":12,"end_line":739,"end_character":25},"in_reply_to":"3ac371cc_35654fe1","updated":"2016-08-17 12:40:36.000000000","message":"but then there is no reason to sleep when it is invoked by migration_driver_recoveroy","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":769,"context_line":"                context, src_share_instance, dest_host,"},{"line_number":770,"context_line":"                dest_driver_migration_info, dest_share_instance,"},{"line_number":771,"context_line":"                src_share_server, dest_share_server)"},{"line_number":772,"context_line":"            time.sleep(5)"},{"line_number":773,"context_line":"            share_ref \u003d self.db.share_get(context, share_ref[\u0027id\u0027])"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        if finished:"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_d504bbc7","line":772,"range":{"start_line":772,"start_character":12,"end_line":772,"end_character":25},"updated":"2016-08-15 02:45:17.000000000","message":"Why sleep?\n\nWhy not implement polling instead?\n\nIf this method fails during the poll, you can initiate the fallback migration..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":769,"context_line":"                context, src_share_instance, dest_host,"},{"line_number":770,"context_line":"                dest_driver_migration_info, dest_share_instance,"},{"line_number":771,"context_line":"                src_share_server, dest_share_server)"},{"line_number":772,"context_line":"            time.sleep(5)"},{"line_number":773,"context_line":"            share_ref \u003d self.db.share_get(context, share_ref[\u0027id\u0027])"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        if finished:"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_fc95d486","line":772,"range":{"start_line":772,"start_character":12,"end_line":772,"end_character":25},"in_reply_to":"3ac371cc_d504bbc7","updated":"2016-08-17 12:40:36.000000000","message":"As we discussed on IRC, I will make this change in newton improvements patch.","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":791,"context_line":"        else:"},{"line_number":792,"context_line":"            if (share_ref[\u0027task_state\u0027] \u003d\u003d"},{"line_number":793,"context_line":"                    constants.TASK_STATE_MIGRATION_CANCELLED):"},{"line_number":794,"context_line":"                LOG.warning(_LW(\"Share Migration for share %s was cancelled.\"),"},{"line_number":795,"context_line":"                            share_ref[\u0027id\u0027])"},{"line_number":796,"context_line":"            else:"},{"line_number":797,"context_line":"                msg \u003d (_(\"Share Migration for share %s did not complete \""},{"line_number":798,"context_line":"                         \"first phase successfully.\"), share_ref[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_d52b1b32","line":795,"range":{"start_line":794,"start_character":16,"end_line":795,"end_character":44},"updated":"2016-08-15 02:45:17.000000000","message":"finished \u003d True?","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":791,"context_line":"        else:"},{"line_number":792,"context_line":"            if (share_ref[\u0027task_state\u0027] \u003d\u003d"},{"line_number":793,"context_line":"                    constants.TASK_STATE_MIGRATION_CANCELLED):"},{"line_number":794,"context_line":"                LOG.warning(_LW(\"Share Migration for share %s was cancelled.\"),"},{"line_number":795,"context_line":"                            share_ref[\u0027id\u0027])"},{"line_number":796,"context_line":"            else:"},{"line_number":797,"context_line":"                msg \u003d (_(\"Share Migration for share %s did not complete \""},{"line_number":798,"context_line":"                         \"first phase successfully.\"), share_ref[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_e99b7c70","line":795,"range":{"start_line":794,"start_character":16,"end_line":795,"end_character":44},"in_reply_to":"3ac371cc_d52b1b32","updated":"2016-08-17 12:40:36.000000000","message":"not finished successfully","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":799,"context_line":"                raise exception.ShareMigrationFailed(reason\u003dmsg)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    @utils.require_driver_initialized"},{"line_number":802,"context_line":"    def migration_driver_recovery(self, context, share_id):"},{"line_number":803,"context_line":"        \"\"\"Resumes a migration after a service restart.\"\"\""},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        share \u003d self.db.share_get(context, share_id)"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_d5879b10","line":802,"range":{"start_line":802,"start_character":0,"end_line":802,"end_character":59},"updated":"2016-08-15 02:45:17.000000000","message":"If you implement polling, you won\u0027t need another method..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":799,"context_line":"                raise exception.ShareMigrationFailed(reason\u003dmsg)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    @utils.require_driver_initialized"},{"line_number":802,"context_line":"    def migration_driver_recovery(self, context, share_id):"},{"line_number":803,"context_line":"        \"\"\"Resumes a migration after a service restart.\"\"\""},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        share \u003d self.db.share_get(context, share_id)"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_7c3e048d","line":802,"range":{"start_line":802,"start_character":0,"end_line":802,"end_character":59},"in_reply_to":"3ac371cc_d5879b10","updated":"2016-08-17 12:40:36.000000000","message":"This and _migration_driver_continue will probably merge into a single method that is under polling.","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        share_api \u003d api.API()"},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"        src_share_instance_id, dest_share_instance_id \u003d ("},{"line_number":810,"context_line":"            share_api._get_migrating_instances(share))"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"        src_share_instance \u003d self.db.share_instance_get("},{"line_number":813,"context_line":"            context, src_share_instance_id, with_share_data\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_b5a5bfb6","line":810,"range":{"start_line":810,"start_character":22,"end_line":810,"end_character":23},"updated":"2016-08-15 02:45:17.000000000","message":"make public","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        share_api \u003d api.API()"},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"        src_share_instance_id, dest_share_instance_id \u003d ("},{"line_number":810,"context_line":"            share_api._get_migrating_instances(share))"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"        src_share_instance \u003d self.db.share_instance_get("},{"line_number":813,"context_line":"            context, src_share_instance_id, with_share_data\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_0908982b","line":810,"range":{"start_line":810,"start_character":22,"end_line":810,"end_character":23},"in_reply_to":"3ac371cc_b5a5bfb6","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":836,"context_line":"            self.db.share_instance_update("},{"line_number":837,"context_line":"                context, dest_share_instance[\u0027id\u0027],"},{"line_number":838,"context_line":"                {\u0027status\u0027: constants.STATUS_ERROR})"},{"line_number":839,"context_line":"            self.db.share_instance_update("},{"line_number":840,"context_line":"                context, src_share_instance[\u0027id\u0027],"},{"line_number":841,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":842,"context_line":"            self.db.share_update("},{"line_number":843,"context_line":"                context, share[\u0027id\u0027],"},{"line_number":844,"context_line":"                {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_ERROR})"},{"line_number":845,"context_line":"            msg \u003d _(\"Driver optimized migration failed.\")"},{"line_number":846,"context_line":"            LOG.exception(msg)"},{"line_number":847,"context_line":"            raise exception.ShareMigrationFailed(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_55956b3e","line":844,"range":{"start_line":839,"start_character":0,"end_line":844,"end_character":69},"updated":"2016-08-15 02:45:17.000000000","message":"might cause races.. we should condense these into one call if possible..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":836,"context_line":"            self.db.share_instance_update("},{"line_number":837,"context_line":"                context, dest_share_instance[\u0027id\u0027],"},{"line_number":838,"context_line":"                {\u0027status\u0027: constants.STATUS_ERROR})"},{"line_number":839,"context_line":"            self.db.share_instance_update("},{"line_number":840,"context_line":"                context, src_share_instance[\u0027id\u0027],"},{"line_number":841,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":842,"context_line":"            self.db.share_update("},{"line_number":843,"context_line":"                context, share[\u0027id\u0027],"},{"line_number":844,"context_line":"                {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_ERROR})"},{"line_number":845,"context_line":"            msg \u003d _(\"Driver optimized migration failed.\")"},{"line_number":846,"context_line":"            LOG.exception(msg)"},{"line_number":847,"context_line":"            raise exception.ShareMigrationFailed(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_cc696ec0","line":844,"range":{"start_line":839,"start_character":0,"end_line":844,"end_character":69},"in_reply_to":"3ac371cc_55956b3e","updated":"2016-08-17 12:40:36.000000000","message":"I really don\u0027t like updating the status of an instance through the share model. I haven\u0027t dig much into this but I suspect unpredictable things like setting the status to the wrong instance.","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":860,"context_line":"        share_instance \u003d self._get_share_instance(context, share_ref)"},{"line_number":861,"context_line":"        success \u003d False"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"        host \u003d share_utils.extract_host(dest_host)"},{"line_number":864,"context_line":"        service \u003d self.db.service_get_by_args("},{"line_number":865,"context_line":"            context, host, \u0027manila-share\u0027)"},{"line_number":866,"context_line":"        new_az_id \u003d service[\u0027availability_zone_id\u0027]"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_5a7c7a20","line":863,"range":{"start_line":863,"start_character":8,"end_line":863,"end_character":12},"updated":"2016-08-15 02:45:17.000000000","message":"dest_host.. to avoid confusing with self.host","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":860,"context_line":"        share_instance \u003d self._get_share_instance(context, share_ref)"},{"line_number":861,"context_line":"        success \u003d False"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"        host \u003d share_utils.extract_host(dest_host)"},{"line_number":864,"context_line":"        service \u003d self.db.service_get_by_args("},{"line_number":865,"context_line":"            context, host, \u0027manila-share\u0027)"},{"line_number":866,"context_line":"        new_az_id \u003d service[\u0027availability_zone_id\u0027]"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_6ca95adf","line":863,"range":{"start_line":863,"start_character":8,"end_line":863,"end_character":12},"in_reply_to":"3ac371cc_5a7c7a20","updated":"2016-08-17 12:40:36.000000000","message":"this is not dest_host. I am changing to \"host_value\".","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":876,"context_line":"                    new_az_id)"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"            except Exception as e:"},{"line_number":879,"context_line":"                msg \u003d six.text_type(e)"},{"line_number":880,"context_line":"                LOG.exception(msg)"},{"line_number":881,"context_line":"                LOG.warning(_LW(\"Driver could not migrate share %s. Proceeding\""},{"line_number":882,"context_line":"                                \" with generic migration approach.\")"},{"line_number":883,"context_line":"                            % share_id)"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_babe4ed2","line":880,"range":{"start_line":879,"start_character":16,"end_line":880,"end_character":34},"updated":"2016-08-15 02:45:17.000000000","message":"LOG.exception(_LE(\"The driver could not migrate the share %(shr)s\"), {\u0027shr\u0027: share_id})\n\nThe traceback is automatically logged with LOG.exception..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":876,"context_line":"                    new_az_id)"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"            except Exception as e:"},{"line_number":879,"context_line":"                msg \u003d six.text_type(e)"},{"line_number":880,"context_line":"                LOG.exception(msg)"},{"line_number":881,"context_line":"                LOG.warning(_LW(\"Driver could not migrate share %s. Proceeding\""},{"line_number":882,"context_line":"                                \" with generic migration approach.\")"},{"line_number":883,"context_line":"                            % share_id)"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_3cc48c5d","line":880,"range":{"start_line":879,"start_character":16,"end_line":880,"end_character":34},"in_reply_to":"3ac371cc_babe4ed2","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":878,"context_line":"            except Exception as e:"},{"line_number":879,"context_line":"                msg \u003d six.text_type(e)"},{"line_number":880,"context_line":"                LOG.exception(msg)"},{"line_number":881,"context_line":"                LOG.warning(_LW(\"Driver could not migrate share %s. Proceeding\""},{"line_number":882,"context_line":"                                \" with generic migration approach.\")"},{"line_number":883,"context_line":"                            % share_id)"},{"line_number":884,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_b5865f63","line":881,"range":{"start_line":881,"start_character":20,"end_line":881,"end_character":27},"updated":"2016-08-15 02:45:17.000000000","message":"You could remove this warning log.. and convert the debug to info on line 886..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":878,"context_line":"            except Exception as e:"},{"line_number":879,"context_line":"                msg \u003d six.text_type(e)"},{"line_number":880,"context_line":"                LOG.exception(msg)"},{"line_number":881,"context_line":"                LOG.warning(_LW(\"Driver could not migrate share %s. Proceeding\""},{"line_number":882,"context_line":"                                \" with generic migration approach.\")"},{"line_number":883,"context_line":"                            % share_id)"},{"line_number":884,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_dca9f891","line":881,"range":{"start_line":881,"start_character":20,"end_line":881,"end_character":27},"in_reply_to":"3ac371cc_b5865f63","updated":"2016-08-17 12:40:36.000000000","message":"Changed to not print errors in case of driver does not implement migration_start.","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":883,"context_line":"                            % share_id)"},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"        if not success:"},{"line_number":886,"context_line":"            LOG.debug(\"Starting generic migration for share %s.\", share_id)"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":"            self.db.share_update("},{"line_number":889,"context_line":"                context, share_id,"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_1ab4c2f0","line":886,"range":{"start_line":886,"start_character":16,"end_line":886,"end_character":21},"updated":"2016-08-15 02:45:17.000000000","message":"info","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":883,"context_line":"                            % share_id)"},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"        if not success:"},{"line_number":886,"context_line":"            LOG.debug(\"Starting generic migration for share %s.\", share_id)"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":"            self.db.share_update("},{"line_number":889,"context_line":"                context, share_id,"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_bcb7dcf3","line":886,"range":{"start_line":886,"start_character":16,"end_line":886,"end_character":21},"in_reply_to":"3ac371cc_1ab4c2f0","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":936,"context_line":"                                        self.driver)"},{"line_number":937,"context_line":"            raise exception.ShareMigrationFailed(reason\u003dmsg)"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"        ignore_list \u003d self.driver.configuration.safe_get("},{"line_number":940,"context_line":"            \u0027migration_ignore_files\u0027)"},{"line_number":941,"context_line":""},{"line_number":942,"context_line":"        data_rpc \u003d data_rpcapi.DataAPI()"},{"line_number":943,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_daa06aa8","line":940,"range":{"start_line":939,"start_character":0,"end_line":940,"end_character":37},"updated":"2016-08-15 02:45:17.000000000","message":"Isn\u0027t this required for driver optimized migration; or should individual drivers read this information?","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":936,"context_line":"                                        self.driver)"},{"line_number":937,"context_line":"            raise exception.ShareMigrationFailed(reason\u003dmsg)"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"        ignore_list \u003d self.driver.configuration.safe_get("},{"line_number":940,"context_line":"            \u0027migration_ignore_files\u0027)"},{"line_number":941,"context_line":""},{"line_number":942,"context_line":"        data_rpc \u003d data_rpcapi.DataAPI()"},{"line_number":943,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_1c29d0e6","line":940,"range":{"start_line":939,"start_character":0,"end_line":940,"end_character":37},"in_reply_to":"3ac371cc_daa06aa8","updated":"2016-08-17 12:40:36.000000000","message":"Yes and no. For driver that use replication-like mechanisms, this is not needed. For drivers that implement something similar to fallback, then this would be needed. I assume they can read this value within their code.","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":1057,"context_line":"                        {\u0027status\u0027: constants.STATUS_ERROR})"},{"line_number":1058,"context_line":"                    self.db.share_update("},{"line_number":1059,"context_line":"                        context, share_ref[\u0027id\u0027],"},{"line_number":1060,"context_line":"                        {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_ERROR})"},{"line_number":1061,"context_line":"                    raise exception.ShareMigrationFailed(reason\u003dmsg)"},{"line_number":1062,"context_line":""},{"line_number":1063,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_b52f7ff5","line":1060,"range":{"start_line":1060,"start_character":0,"end_line":1060,"end_character":77},"updated":"2016-08-15 02:45:17.000000000","message":"same comment as before..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":1057,"context_line":"                        {\u0027status\u0027: constants.STATUS_ERROR})"},{"line_number":1058,"context_line":"                    self.db.share_update("},{"line_number":1059,"context_line":"                        context, share_ref[\u0027id\u0027],"},{"line_number":1060,"context_line":"                        {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_ERROR})"},{"line_number":1061,"context_line":"                    raise exception.ShareMigrationFailed(reason\u003dmsg)"},{"line_number":1062,"context_line":""},{"line_number":1063,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_bc86bcd8","line":1060,"range":{"start_line":1060,"start_character":0,"end_line":1060,"end_character":77},"in_reply_to":"3ac371cc_b52f7ff5","updated":"2016-08-17 12:40:36.000000000","message":"Same reply as above","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"        # Confirm that it is driver migration scenario"},{"line_number":1163,"context_line":"        if share_ref[\u0027task_state\u0027] !\u003d ("},{"line_number":1164,"context_line":"                constants.TASK_STATE_MIGRATION_DRIVER_IN_PROGRESS):"},{"line_number":1165,"context_line":"            msg \u003d _(\"Driver is not performing migration for\""},{"line_number":1166,"context_line":"                    \" share %s\") % share_ref[\u0027id\u0027]"},{"line_number":1167,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_35ad4f32","line":1164,"range":{"start_line":1164,"start_character":16,"end_line":1164,"end_character":67},"updated":"2016-08-15 02:45:17.000000000","message":"Maybe don\u0027t raise the exception if the task\u0027s been completed by the time the RPC got here..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"        # Confirm that it is driver migration scenario"},{"line_number":1163,"context_line":"        if share_ref[\u0027task_state\u0027] !\u003d ("},{"line_number":1164,"context_line":"                constants.TASK_STATE_MIGRATION_DRIVER_IN_PROGRESS):"},{"line_number":1165,"context_line":"            msg \u003d _(\"Driver is not performing migration for\""},{"line_number":1166,"context_line":"                    \" share %s\") % share_ref[\u0027id\u0027]"},{"line_number":1167,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_dc58d88c","line":1164,"range":{"start_line":1164,"start_character":16,"end_line":1164,"end_character":67},"in_reply_to":"3ac371cc_35ad4f32","updated":"2016-08-17 12:40:36.000000000","message":"Changed message accordingly.","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":1229,"context_line":"        dest_driver_migration_info \u003d self.driver.migration_get_driver_info("},{"line_number":1230,"context_line":"            context, src_share_instance, dest_share_instance[\u0027host\u0027])"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"        return self.driver.migration_get_progress("},{"line_number":1233,"context_line":"            context, src_share_instance, dest_share_instance[\u0027host\u0027],"},{"line_number":1234,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":1235,"context_line":"            share_server, dest_share_server)"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"    def _get_share_instance(self, context, share):"},{"line_number":1238,"context_line":"        if isinstance(share, six.string_types):"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_b54e5f94","line":1235,"range":{"start_line":1232,"start_character":15,"end_line":1235,"end_character":44},"updated":"2016-08-15 02:45:17.000000000","message":"This has to be funneled through a View Builder..","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":1229,"context_line":"        dest_driver_migration_info \u003d self.driver.migration_get_driver_info("},{"line_number":1230,"context_line":"            context, src_share_instance, dest_share_instance[\u0027host\u0027])"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"        return self.driver.migration_get_progress("},{"line_number":1233,"context_line":"            context, src_share_instance, dest_share_instance[\u0027host\u0027],"},{"line_number":1234,"context_line":"            dest_driver_migration_info, dest_share_instance,"},{"line_number":1235,"context_line":"            share_server, dest_share_server)"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"    def _get_share_instance(self, context, share):"},{"line_number":1238,"context_line":"        if isinstance(share, six.string_types):"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_17440948","line":1235,"range":{"start_line":1232,"start_character":15,"end_line":1235,"end_character":44},"in_reply_to":"3ac371cc_b54e5f94","updated":"2016-08-17 12:40:36.000000000","message":"This will be implemented in newton-improvements patch, as discussed in IRC.","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":2172,"context_line":"        LOG.info(_LI(\"Share instance %s: deleted successfully.\"),"},{"line_number":2173,"context_line":"                 share_instance_id)"},{"line_number":2174,"context_line":""},{"line_number":2175,"context_line":"        self._check_delete_share_server(context, share_instance)"},{"line_number":2176,"context_line":""},{"line_number":2177,"context_line":"    def _check_delete_share_server(self, context, share_instance):"},{"line_number":2178,"context_line":""},{"line_number":2179,"context_line":"        if CONF.delete_share_server_with_last_share:"},{"line_number":2180,"context_line":"            share_server \u003d self._get_share_server(context, share_instance)"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_55256bc0","line":2177,"range":{"start_line":2175,"start_character":0,"end_line":2177,"end_character":66},"updated":"2016-08-15 02:45:17.000000000","message":"why is this necessary in this patch?","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":2172,"context_line":"        LOG.info(_LI(\"Share instance %s: deleted successfully.\"),"},{"line_number":2173,"context_line":"                 share_instance_id)"},{"line_number":2174,"context_line":""},{"line_number":2175,"context_line":"        self._check_delete_share_server(context, share_instance)"},{"line_number":2176,"context_line":""},{"line_number":2177,"context_line":"    def _check_delete_share_server(self, context, share_instance):"},{"line_number":2178,"context_line":""},{"line_number":2179,"context_line":"        if CONF.delete_share_server_with_last_share:"},{"line_number":2180,"context_line":"            share_server \u003d self._get_share_server(context, share_instance)"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_1716c94b","line":2177,"range":{"start_line":2175,"start_character":0,"end_line":2177,"end_character":66},"in_reply_to":"3ac371cc_55256bc0","updated":"2016-08-17 12:40:36.000000000","message":"So the share server is deleted once the source instance is deleted.","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f602f4c0e8498b1e44e103c7736ea3bf2b43818a","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        share_server \u003d self._get_share_server(context, src_share_instance)"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"        compatible \u003d False"},{"line_number":670,"context_line":"        try:"},{"line_number":671,"context_line":"            compatible \u003d self.driver.migration_check_compatibility("},{"line_number":672,"context_line":"                context, src_share_instance, dest_host,"},{"line_number":673,"context_line":"                dest_driver_migration_info, share_server)"},{"line_number":674,"context_line":"        except NotImplementedError:"},{"line_number":675,"context_line":"            pass"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"        if not compatible:"},{"line_number":678,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":52,"id":"1ac06dbe_4ed76bbf","line":675,"range":{"start_line":670,"start_character":0,"end_line":675,"end_character":16},"updated":"2016-08-20 23:47:06.000000000","message":"Need the destination share server for a compatibility check..","commit_id":"658c51c7bd2558363b756eff405df3a23134fb36"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c1a05ba31664c21ac2ef0c87129a232dcdb27715","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        share_server \u003d self._get_share_server(context, src_share_instance)"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"        compatible \u003d False"},{"line_number":670,"context_line":"        try:"},{"line_number":671,"context_line":"            compatible \u003d self.driver.migration_check_compatibility("},{"line_number":672,"context_line":"                context, src_share_instance, dest_host,"},{"line_number":673,"context_line":"                dest_driver_migration_info, share_server)"},{"line_number":674,"context_line":"        except NotImplementedError:"},{"line_number":675,"context_line":"            pass"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"        if not compatible:"},{"line_number":678,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":52,"id":"1ac06dbe_d459255c","line":675,"range":{"start_line":670,"start_character":0,"end_line":675,"end_character":16},"in_reply_to":"1ac06dbe_4ed76bbf","updated":"2016-08-22 18:15:50.000000000","message":"Done","commit_id":"658c51c7bd2558363b756eff405df3a23134fb36"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ef4f97551e6eb7dcc3cef71cc04f26b835f1ccc0","unresolved":false,"context_lines":[{"line_number":661,"context_line":"    def _migration_start_driver(self, context, share_ref, src_share_instance,"},{"line_number":662,"context_line":"                                dest_host, notify, new_az_id):"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        dest_driver_migration_info \u003d self.driver.migration_get_driver_info("},{"line_number":665,"context_line":"            context, src_share_instance, dest_host)"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"        share_server \u003d self._get_share_server(context, src_share_instance)"},{"line_number":668,"context_line":""}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_7087c2d7","line":665,"range":{"start_line":664,"start_character":0,"end_line":665,"end_character":51},"updated":"2016-08-24 21:13:37.000000000","message":"see comment in share/driver.py","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f30fdf868444c7a9f3033a23f8bcc1a54e39cd87","unresolved":false,"context_lines":[{"line_number":661,"context_line":"    def _migration_start_driver(self, context, share_ref, src_share_instance,"},{"line_number":662,"context_line":"                                dest_host, notify, new_az_id):"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        dest_driver_migration_info \u003d self.driver.migration_get_driver_info("},{"line_number":665,"context_line":"            context, src_share_instance, dest_host)"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"        share_server \u003d self._get_share_server(context, src_share_instance)"},{"line_number":668,"context_line":""}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_84595b91","line":665,"range":{"start_line":664,"start_character":0,"end_line":665,"end_character":51},"in_reply_to":"1ac06dbe_7087c2d7","updated":"2016-08-25 01:05:40.000000000","message":"Done","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"d17352b669ff2bab61de90f0a44c223b764621b7","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        self._create_share_server_in_backend(context, share_server)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def provide_share_server(self, context, share_instance_id,"},{"line_number":513,"context_line":"                             share_network_id, snapshot_id):"},{"line_number":514,"context_line":"        \"\"\"Invoked to provide a compatible share server."},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        This method is invoked to find a compatible share server among the"}],"source_content_type":"text/x-python","patch_set":64,"id":"fa7ab95a_b2e1f79c","line":513,"range":{"start_line":513,"start_character":47,"end_line":513,"end_character":58},"updated":"2016-08-27 08:20:52.000000000","message":"if snapshot_id is a optional argument, why not set it a default None?","commit_id":"546e72613d79a291a57066444f0e4ddc3ec4dc18"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"47d1ae867bdf140941bf7795e753ea4325e286e8","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        self._create_share_server_in_backend(context, share_server)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def provide_share_server(self, context, share_instance_id,"},{"line_number":513,"context_line":"                             share_network_id, snapshot_id):"},{"line_number":514,"context_line":"        \"\"\"Invoked to provide a compatible share server."},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        This method is invoked to find a compatible share server among the"}],"source_content_type":"text/x-python","patch_set":64,"id":"fa7ab95a_3cf3f5d7","line":513,"range":{"start_line":513,"start_character":47,"end_line":513,"end_character":58},"in_reply_to":"fa7ab95a_b2e1f79c","updated":"2016-08-27 22:26:46.000000000","message":"Done","commit_id":"546e72613d79a291a57066444f0e4ddc3ec4dc18"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cc621b0b0ab506c878099dd968006d77d89c231a","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            if (share_ref[\u0027task_state\u0027] \u003d\u003d ("},{"line_number":291,"context_line":"                    constants.TASK_STATE_MIGRATION_DRIVER_IN_PROGRESS) and"},{"line_number":292,"context_line":"                    share_instance[\u0027status\u0027] \u003d\u003d constants.STATUS_MIGRATING):"},{"line_number":293,"context_line":"                rpcapi \u003d share_rpcapi.ShareAPI()"},{"line_number":294,"context_line":"                rpcapi.migration_driver_recovery(ctxt, share_ref, self.host)"},{"line_number":295,"context_line":"                continue"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"            if share_ref.is_busy:"}],"source_content_type":"text/x-python","patch_set":70,"id":"fa7ab95a_ccea1aac","line":294,"range":{"start_line":293,"start_character":0,"end_line":294,"end_character":76},"updated":"2016-08-29 17:14:47.000000000","message":"does this need to be changed? Why do you need it to go through RPC and come back to share.host?","commit_id":"fcd26fb95f007ff83ae662d26d56e4d4ceb72fcc"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"1d0e4cf7b8212acc29eb70da5512dcda6816b1a6","unresolved":false,"context_lines":[{"line_number":739,"context_line":"                context, share_ref, src_share_instance, dest_share_instance,"},{"line_number":740,"context_line":"                share_server, dest_share_server, notify)"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"        except Exception:"},{"line_number":743,"context_line":"            # NOTE(ganso): Cleaning up error\u0027ed destination share instance from"},{"line_number":744,"context_line":"            # database. It is assumed that driver cleans up leftovers in"},{"line_number":745,"context_line":"            # backend when migration fails."}],"source_content_type":"text/x-python","patch_set":73,"id":"fa7ab95a_4d98a8c0","line":742,"range":{"start_line":742,"start_character":7,"end_line":742,"end_character":25},"updated":"2016-08-30 06:13:23.000000000","message":"Just in general: usually a good idea to log the the Exception for debug/troubleshooting","commit_id":"bf7db46655b409b241011ab27a3c27b9123c47dc"}],"manila/share/migration.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4499ef1d023223a708ee51fc061bd2304f32d72f","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                self.context, self.db, new_share_instance,"},{"line_number":202,"context_line":"                self.migration_wait_access_rules_timeout)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def wait_for_share_server(self, share_server_id):"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        # Wait for share_server to become ready"},{"line_number":207,"context_line":"        starttime \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_7c918af0","line":204,"updated":"2016-07-13 17:01:38.000000000","message":"Why \"retry\" [1] func not used?\n\n[1] https://github.com/openstack/manila/blob/cd698f26/manila/utils.py#L549","commit_id":"2b2694c99d9762f2ba0f047049e911a4e95451f1"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"b97c1996770aecc64b48cd53316cf38e6c045827","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                self.context, self.db, new_share_instance,"},{"line_number":202,"context_line":"                self.migration_wait_access_rules_timeout)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def wait_for_share_server(self, share_server_id):"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        # Wait for share_server to become ready"},{"line_number":207,"context_line":"        starttime \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_ca1eb85e","line":204,"in_reply_to":"1aa78d24_7c918af0","updated":"2016-07-14 17:49:02.000000000","message":"Done","commit_id":"2b2694c99d9762f2ba0f047049e911a4e95451f1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a998ce1f57225d79984fdbe6750f46cfe1ff4336","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                self.context, self.db, new_share_instance,"},{"line_number":201,"context_line":"                self.migration_wait_access_rules_timeout)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @utils.retry(exception.ShareServerNotReady, retries\u003d8)"},{"line_number":204,"context_line":"    def wait_for_share_server(self, share_server_id):"},{"line_number":205,"context_line":"        share_server \u003d self.db.share_server_get(self.context, share_server_id)"},{"line_number":206,"context_line":"        if share_server[\u0027status\u0027] \u003d\u003d constants.STATUS_ERROR:"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_dbf8097f","line":203,"updated":"2016-07-25 19:17:01.000000000","message":"Why retry so many times?","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3f0d174f280e53b18a4344bc0988f00e680d70fc","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                self.context, self.db, new_share_instance,"},{"line_number":201,"context_line":"                self.migration_wait_access_rules_timeout)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @utils.retry(exception.ShareServerNotReady, retries\u003d8)"},{"line_number":204,"context_line":"    def wait_for_share_server(self, share_server_id):"},{"line_number":205,"context_line":"        share_server \u003d self.db.share_server_get(self.context, share_server_id)"},{"line_number":206,"context_line":"        if share_server[\u0027status\u0027] \u003d\u003d constants.STATUS_ERROR:"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_5de084fa","line":203,"in_reply_to":"dada55a8_dbf8097f","updated":"2016-07-26 16:02:40.000000000","message":"Those are DB polling retries. With the default values these retries should sum to a maximum of 512 seconds wait time and then time out.","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"}],"manila/share/rpcapi.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a998ce1f57225d79984fdbe6750f46cfe1ff4336","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    def migration_get_progress(self, context, share_instance,"},{"line_number":312,"context_line":"                               migrating_instance_id):"},{"line_number":313,"context_line":"        new_host \u003d utils.extract_host(share_instance[\u0027host\u0027])"},{"line_number":314,"context_line":"        call_context \u003d self.client.prepare(server\u003dnew_host, version\u003d\u00271.10\u0027)"},{"line_number":315,"context_line":"        return call_context.call(context,"},{"line_number":316,"context_line":"                                 \u0027migration_get_progress\u0027,"},{"line_number":317,"context_line":"                                 share_instance_id\u003dshare_instance[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_5e2c074a","line":314,"updated":"2016-07-25 19:17:01.000000000","message":"These 3 RPC APIs have different signatures now.  I think the version should be changed as well.","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"58c029650dc497adce8c9b0f04734fce6f0630de","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    def migration_get_progress(self, context, share_instance,"},{"line_number":312,"context_line":"                               migrating_instance_id):"},{"line_number":313,"context_line":"        new_host \u003d utils.extract_host(share_instance[\u0027host\u0027])"},{"line_number":314,"context_line":"        call_context \u003d self.client.prepare(server\u003dnew_host, version\u003d\u00271.10\u0027)"},{"line_number":315,"context_line":"        return call_context.call(context,"},{"line_number":316,"context_line":"                                 \u0027migration_get_progress\u0027,"},{"line_number":317,"context_line":"                                 share_instance_id\u003dshare_instance[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_8d83d355","line":314,"in_reply_to":"dada55a8_5e2c074a","updated":"2016-07-26 11:22:34.000000000","message":"Completely correct statement. Interface was changed.","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3f0d174f280e53b18a4344bc0988f00e680d70fc","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    def migration_get_progress(self, context, share_instance,"},{"line_number":312,"context_line":"                               migrating_instance_id):"},{"line_number":313,"context_line":"        new_host \u003d utils.extract_host(share_instance[\u0027host\u0027])"},{"line_number":314,"context_line":"        call_context \u003d self.client.prepare(server\u003dnew_host, version\u003d\u00271.10\u0027)"},{"line_number":315,"context_line":"        return call_context.call(context,"},{"line_number":316,"context_line":"                                 \u0027migration_get_progress\u0027,"},{"line_number":317,"context_line":"                                 share_instance_id\u003dshare_instance[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_8a29e39d","line":314,"in_reply_to":"dada55a8_8d83d355","updated":"2016-07-26 16:02:40.000000000","message":"Done","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            migration_get_driver_info()"},{"line_number":60,"context_line":"        1.11 - Add create_replicated_snapshot() and"},{"line_number":61,"context_line":"            delete_replicated_snapshot() methods"},{"line_number":62,"context_line":"        1.12 - Add provide_remote_share_server() and"},{"line_number":63,"context_line":"            create_remote_share_server(), removed migration_get_driver_info(),"},{"line_number":64,"context_line":"            changed migration_cancel(), migration_complete() and"},{"line_number":65,"context_line":"            migration_get_progress method signature"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_b51c9f78","line":62,"range":{"start_line":62,"start_character":27,"end_line":62,"end_character":34},"updated":"2016-08-15 02:45:17.000000000","message":"remove","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            migration_get_driver_info()"},{"line_number":60,"context_line":"        1.11 - Add create_replicated_snapshot() and"},{"line_number":61,"context_line":"            delete_replicated_snapshot() methods"},{"line_number":62,"context_line":"        1.12 - Add provide_remote_share_server() and"},{"line_number":63,"context_line":"            create_remote_share_server(), removed migration_get_driver_info(),"},{"line_number":64,"context_line":"            changed migration_cancel(), migration_complete() and"},{"line_number":65,"context_line":"            migration_get_progress method signature"}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_360972de","line":62,"range":{"start_line":62,"start_character":27,"end_line":62,"end_character":34},"in_reply_to":"3ac371cc_b51c9f78","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38cf4fb4d515f66595f9ea07bcaf37f6aee4bac","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        1.11 - Add create_replicated_snapshot() and"},{"line_number":61,"context_line":"            delete_replicated_snapshot() methods"},{"line_number":62,"context_line":"        1.12 - Add provide_remote_share_server() and"},{"line_number":63,"context_line":"            create_remote_share_server(), removed migration_get_driver_info(),"},{"line_number":64,"context_line":"            changed migration_cancel(), migration_complete() and"},{"line_number":65,"context_line":"            migration_get_progress method signature"},{"line_number":66,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_f5161754","line":63,"range":{"start_line":63,"start_character":19,"end_line":63,"end_character":26},"updated":"2016-08-15 02:45:17.000000000","message":"remove","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"482e73b9cc84e35c8760a4b6c65f3d31b60c35ff","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        1.11 - Add create_replicated_snapshot() and"},{"line_number":61,"context_line":"            delete_replicated_snapshot() methods"},{"line_number":62,"context_line":"        1.12 - Add provide_remote_share_server() and"},{"line_number":63,"context_line":"            create_remote_share_server(), removed migration_get_driver_info(),"},{"line_number":64,"context_line":"            changed migration_cancel(), migration_complete() and"},{"line_number":65,"context_line":"            migration_get_progress method signature"},{"line_number":66,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":50,"id":"3ac371cc_96102603","line":63,"range":{"start_line":63,"start_character":19,"end_line":63,"end_character":26},"in_reply_to":"3ac371cc_f5161754","updated":"2016-08-17 12:40:36.000000000","message":"Done","commit_id":"6de9fde30c5b76df6affeca33a948e7ba3b471ad"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"d17352b669ff2bab61de90f0a44c223b764621b7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            migration_get_driver_info()"},{"line_number":60,"context_line":"        1.11 - Add create_replicated_snapshot() and"},{"line_number":61,"context_line":"            delete_replicated_snapshot() methods"},{"line_number":62,"context_line":"        1.12 - Add provide_share_server() and"},{"line_number":63,"context_line":"            create_share_server(), removed migration_get_driver_info(),"},{"line_number":64,"context_line":"            changed migration_cancel(), migration_complete() and"},{"line_number":65,"context_line":"            migration_get_progress method signature"}],"source_content_type":"text/x-python","patch_set":64,"id":"fa7ab95a_ea874910","line":62,"range":{"start_line":62,"start_character":42,"end_line":62,"end_character":45},"updated":"2016-08-27 08:20:52.000000000","message":"and migration_driver_recovery","commit_id":"546e72613d79a291a57066444f0e4ddc3ec4dc18"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"47d1ae867bdf140941bf7795e753ea4325e286e8","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            migration_get_driver_info()"},{"line_number":60,"context_line":"        1.11 - Add create_replicated_snapshot() and"},{"line_number":61,"context_line":"            delete_replicated_snapshot() methods"},{"line_number":62,"context_line":"        1.12 - Add provide_share_server() and"},{"line_number":63,"context_line":"            create_share_server(), removed migration_get_driver_info(),"},{"line_number":64,"context_line":"            changed migration_cancel(), migration_complete() and"},{"line_number":65,"context_line":"            migration_get_progress method signature"}],"source_content_type":"text/x-python","patch_set":64,"id":"fa7ab95a_7cbbbde5","line":62,"range":{"start_line":62,"start_character":42,"end_line":62,"end_character":45},"in_reply_to":"fa7ab95a_ea874910","updated":"2016-08-27 22:26:46.000000000","message":"Done","commit_id":"546e72613d79a291a57066444f0e4ddc3ec4dc18"}],"manila/tests/data/test_helper.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ef4f97551e6eb7dcc3cef71cc04f26b835f1ccc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":60,"id":"1ac06dbe_1bdb0f1d","updated":"2016-08-24 21:13:37.000000000","message":"Why is this part of this patch?","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"}],"manila/tests/share/test_driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ef4f97551e6eb7dcc3cef71cc04f26b835f1ccc0","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                          share_driver.migration_get_progress,"},{"line_number":503,"context_line":"                          None, None, None, None, None, None, None)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def test_migration_get_driver_info_default(self):"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        driver.CONF.set_default(\u0027driver_handles_share_servers\u0027, False)"},{"line_number":508,"context_line":"        share_driver \u003d driver.ShareDriver(False)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        self.assertEqual("},{"line_number":511,"context_line":"            {}, share_driver.migration_get_driver_info(None, None, None), None)"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    @ddt.data(True, False)"},{"line_number":514,"context_line":"    def test_migration_get_info(self, admin):"}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_db53376b","line":511,"range":{"start_line":505,"start_character":0,"end_line":511,"end_character":79},"updated":"2016-08-24 21:13:37.000000000","message":"could be removed","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f30fdf868444c7a9f3033a23f8bcc1a54e39cd87","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                          share_driver.migration_get_progress,"},{"line_number":503,"context_line":"                          None, None, None, None, None, None, None)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def test_migration_get_driver_info_default(self):"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        driver.CONF.set_default(\u0027driver_handles_share_servers\u0027, False)"},{"line_number":508,"context_line":"        share_driver \u003d driver.ShareDriver(False)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        self.assertEqual("},{"line_number":511,"context_line":"            {}, share_driver.migration_get_driver_info(None, None, None), None)"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    @ddt.data(True, False)"},{"line_number":514,"context_line":"    def test_migration_get_info(self, admin):"}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_44c64317","line":511,"range":{"start_line":505,"start_character":0,"end_line":511,"end_character":79},"in_reply_to":"1ac06dbe_db53376b","updated":"2016-08-25 01:05:40.000000000","message":"Done","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"}],"manila/tests/share/test_manager.py":[{"author":{"_account_id":19683,"name":"Jose Falavinha","email":"jose.falavinha@fit-tecnologia.org.br","username":"jose.falavinha"},"change_message_id":"1db7386141670cbf67021dd4690397c4429671b5","unresolved":false,"context_lines":[{"line_number":3943,"context_line":"            fake_driver_info, migrating_instance, fake_rules, src_server,"},{"line_number":3944,"context_line":"            dest_server, True)"},{"line_number":3945,"context_line":""},{"line_number":3946,"context_line":"    @ddt.data({\u0027finished\u0027: True, \u0027notify\u0027: True},"},{"line_number":3947,"context_line":"              {\u0027finished\u0027: True, \u0027notify\u0027: False},"},{"line_number":3948,"context_line":"              {\u0027finished\u0027: False, \u0027notify\u0027: True})"},{"line_number":3949,"context_line":"    @ddt.unpack"},{"line_number":3950,"context_line":"    def test__migration_driver_continue(self, finished, notify):"},{"line_number":3951,"context_line":""},{"line_number":3952,"context_line":"        share \u003d db_utils.create_share("}],"source_content_type":"text/x-python","patch_set":43,"id":"9ad45d7e_d807941a","line":3949,"range":{"start_line":3946,"start_character":4,"end_line":3949,"end_character":15},"updated":"2016-08-09 12:35:55.000000000","message":"{\u0027finished\u0027: False, \u0027notify\u0027: False} is not an option?","commit_id":"6b3f3ec96575d283d08aacf49104bf4c190d7183"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"40cdf96a8cf01b91c72384f65aa9f3fb6f1f7999","unresolved":false,"context_lines":[{"line_number":3943,"context_line":"            fake_driver_info, migrating_instance, fake_rules, src_server,"},{"line_number":3944,"context_line":"            dest_server, True)"},{"line_number":3945,"context_line":""},{"line_number":3946,"context_line":"    @ddt.data({\u0027finished\u0027: True, \u0027notify\u0027: True},"},{"line_number":3947,"context_line":"              {\u0027finished\u0027: True, \u0027notify\u0027: False},"},{"line_number":3948,"context_line":"              {\u0027finished\u0027: False, \u0027notify\u0027: True})"},{"line_number":3949,"context_line":"    @ddt.unpack"},{"line_number":3950,"context_line":"    def test__migration_driver_continue(self, finished, notify):"},{"line_number":3951,"context_line":""},{"line_number":3952,"context_line":"        share \u003d db_utils.create_share("}],"source_content_type":"text/x-python","patch_set":43,"id":"9ad45d7e_475bc12e","line":3949,"range":{"start_line":3946,"start_character":4,"end_line":3949,"end_character":15},"in_reply_to":"9ad45d7e_d807941a","updated":"2016-08-09 13:34:56.000000000","message":"If \u0027finished\u0027 is False, it does not use \u0027notify\u0027 at all","commit_id":"6b3f3ec96575d283d08aacf49104bf4c190d7183"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ef4f97551e6eb7dcc3cef71cc04f26b835f1ccc0","unresolved":false,"context_lines":[{"line_number":4302,"context_line":"                         \u0027apply_new_access_rules\u0027)"},{"line_number":4303,"context_line":""},{"line_number":4304,"context_line":"        # run"},{"line_number":4305,"context_line":"        self.share_manager._migration_complete_driver("},{"line_number":4306,"context_line":"            self.context, share, src_instance, dest_instance)"},{"line_number":4307,"context_line":""},{"line_number":4308,"context_line":"        # asserts"},{"line_number":4309,"context_line":"        self.share_manager.db.share_server_get.assert_has_calls(["}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_36ba62c1","line":4306,"range":{"start_line":4305,"start_character":0,"end_line":4306,"end_character":61},"updated":"2016-08-24 21:13:37.000000000","message":"test case where this blows up?","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ef4f97551e6eb7dcc3cef71cc04f26b835f1ccc0","unresolved":false,"context_lines":[{"line_number":4418,"context_line":"        (self.share_manager.driver.migration_get_driver_info."},{"line_number":4419,"context_line":"            assert_called_once_with(self.context, instance_1, dest_host))"},{"line_number":4420,"context_line":""},{"line_number":4421,"context_line":"        self.share_manager.driver.migration_cancel.assert_called_once_with("},{"line_number":4422,"context_line":"            self.context, instance_1, dest_host, driver_info, instance_2,"},{"line_number":4423,"context_line":"            server_1, server_2)"},{"line_number":4424,"context_line":""},{"line_number":4425,"context_line":"        self.share_manager.db.share_get.assert_called_once_with("},{"line_number":4426,"context_line":"            self.context, share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_769dfa58","line":4423,"range":{"start_line":4421,"start_character":0,"end_line":4423,"end_character":31},"updated":"2016-08-24 21:13:37.000000000","message":"test case where this blows up?","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"}],"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c23ea65c2cb8bcb14f6e734f6b82d14ea2e42464","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"            time.sleep(self.build_interval)"},{"line_number":1023,"context_line":"            share \u003d self.get_share(share_id, version\u003dversion)"},{"line_number":1024,"context_line":"            if share[\u0027task_state\u0027] \u003d\u003d status:"},{"line_number":1025,"context_line":"                return share"},{"line_number":1026,"context_line":"            elif share[\u0027task_state\u0027] \u003d\u003d \u0027migration_error\u0027:"},{"line_number":1027,"context_line":"                raise share_exceptions.ShareMigrationException("},{"line_number":1028,"context_line":"                    share_id\u003dshare[\u0027id\u0027], src\u003dshare[\u0027host\u0027], dest\u003ddest_host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_0979b3f6","side":"PARENT","line":1025,"range":{"start_line":1025,"start_character":16,"end_line":1025,"end_character":28},"updated":"2016-06-23 12:25:41.000000000","message":"It should be just \"break\".","commit_id":"62e01f076a5ad7bde7c99404a51c28b00e1e3bad"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c23ea65c2cb8bcb14f6e734f6b82d14ea2e42464","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"        while share[\u0027task_state\u0027] not in status_list:"},{"line_number":1023,"context_line":"            time.sleep(self.build_interval)"},{"line_number":1024,"context_line":"            share \u003d self.get_share(share_id, version\u003dversion)"},{"line_number":1025,"context_line":"            if share[\u0027task_state\u0027] \u003d\u003d \u0027migration_error\u0027:"},{"line_number":1026,"context_line":"                raise share_exceptions.ShareMigrationException("},{"line_number":1027,"context_line":"                    share_id\u003dshare[\u0027id\u0027], src\u003dshare[\u0027host\u0027], dest\u003ddest_host)"},{"line_number":1028,"context_line":"            elif int(time.time()) - start \u003e\u003d migration_timeout:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_89d2c3d0","line":1025,"range":{"start_line":1025,"start_character":12,"end_line":1025,"end_character":56},"updated":"2016-06-23 12:25:41.000000000","message":"You will get unexpected error if you expect this status. Revert it back.\n\nLine 1040 - correct change. Also old 1025 line should just become \"break\" or stay unchanged. That\u0027s all.","commit_id":"46ea9f32c92f0f4de952efa6d1bfe43a0dfedb27"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"552dddfe218e11e66b029dc855c815d8a11d55ea","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"        while share[\u0027task_state\u0027] not in status_list:"},{"line_number":1023,"context_line":"            time.sleep(self.build_interval)"},{"line_number":1024,"context_line":"            share \u003d self.get_share(share_id, version\u003dversion)"},{"line_number":1025,"context_line":"            if share[\u0027task_state\u0027] \u003d\u003d \u0027migration_error\u0027:"},{"line_number":1026,"context_line":"                raise share_exceptions.ShareMigrationException("},{"line_number":1027,"context_line":"                    share_id\u003dshare[\u0027id\u0027], src\u003dshare[\u0027host\u0027], dest\u003ddest_host)"},{"line_number":1028,"context_line":"            elif int(time.time()) - start \u003e\u003d migration_timeout:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_bafa58bb","line":1025,"range":{"start_line":1025,"start_character":12,"end_line":1025,"end_character":56},"in_reply_to":"3aaa91ec_89d2c3d0","updated":"2016-06-23 14:53:51.000000000","message":"Done","commit_id":"46ea9f32c92f0f4de952efa6d1bfe43a0dfedb27"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"11983ec0da2854b0e0a2aff443506d46dddc280d","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"                                  version\u003dLATEST_MICROVERSION):"},{"line_number":1018,"context_line":"        \"\"\"Waits for a share to migrate to a certain host.\"\"\""},{"line_number":1019,"context_line":"        statuses \u003d ((status_to_wait,)"},{"line_number":1020,"context_line":"                    if not isinstance(status_to_wait, tuple)"},{"line_number":1021,"context_line":"                    else status_to_wait)"},{"line_number":1022,"context_line":"        share \u003d self.get_share(share_id, version\u003dversion)"},{"line_number":1023,"context_line":"        migration_timeout \u003d CONF.share.migration_timeout"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_02197e22","line":1020,"range":{"start_line":1020,"start_character":54,"end_line":1020,"end_character":59},"updated":"2016-06-23 14:59:37.000000000","message":"No need to tie on some specific data container. Use following:\n\nif not isinstance(status_to_wait, (tuple, list, set))","commit_id":"11961926b199cd21d97c3a17885a8779f8b33054"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"722c2c55e6dd4b365e2d4ad619c635fe2ec3884a","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"                                  version\u003dLATEST_MICROVERSION):"},{"line_number":1018,"context_line":"        \"\"\"Waits for a share to migrate to a certain host.\"\"\""},{"line_number":1019,"context_line":"        statuses \u003d ((status_to_wait,)"},{"line_number":1020,"context_line":"                    if not isinstance(status_to_wait, tuple)"},{"line_number":1021,"context_line":"                    else status_to_wait)"},{"line_number":1022,"context_line":"        share \u003d self.get_share(share_id, version\u003dversion)"},{"line_number":1023,"context_line":"        migration_timeout \u003d CONF.share.migration_timeout"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_f7a507a2","line":1020,"range":{"start_line":1020,"start_character":54,"end_line":1020,"end_character":59},"in_reply_to":"3aaa91ec_02197e22","updated":"2016-06-24 17:18:57.000000000","message":"#TIL","commit_id":"11961926b199cd21d97c3a17885a8779f8b33054"}],"manila_tempest_tests/tests/api/admin/test_migration.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c23ea65c2cb8bcb14f6e734f6b82d14ea2e42464","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        share \u003d self.migrate_share("},{"line_number":66,"context_line":"            share[\u0027id\u0027], dest_pool, version\u003d\u00272.15\u0027, notify\u003dFalse,"},{"line_number":67,"context_line":"            wait_for_status\u003d[\u0027data_copying_completed\u0027,"},{"line_number":68,"context_line":"                             \u0027migration_driver_phase1_done\u0027])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self._validate_migration_successful(dest_pool, share, \u00272.15\u0027,"},{"line_number":71,"context_line":"                                            notify\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_49645b21","line":68,"range":{"start_line":67,"start_character":28,"end_line":68,"end_character":60},"updated":"2016-06-23 12:25:41.000000000","message":"Please, use tuple.","commit_id":"46ea9f32c92f0f4de952efa6d1bfe43a0dfedb27"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"552dddfe218e11e66b029dc855c815d8a11d55ea","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        share \u003d self.migrate_share("},{"line_number":66,"context_line":"            share[\u0027id\u0027], dest_pool, version\u003d\u00272.15\u0027, notify\u003dFalse,"},{"line_number":67,"context_line":"            wait_for_status\u003d[\u0027data_copying_completed\u0027,"},{"line_number":68,"context_line":"                             \u0027migration_driver_phase1_done\u0027])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self._validate_migration_successful(dest_pool, share, \u00272.15\u0027,"},{"line_number":71,"context_line":"                                            notify\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_5a71b4df","line":68,"range":{"start_line":67,"start_character":28,"end_line":68,"end_character":60},"in_reply_to":"3aaa91ec_49645b21","updated":"2016-06-23 14:53:51.000000000","message":"Done","commit_id":"46ea9f32c92f0f4de952efa6d1bfe43a0dfedb27"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c23ea65c2cb8bcb14f6e734f6b82d14ea2e42464","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        else:"},{"line_number":130,"context_line":"            self.assertNotEqual(dest_pool, share[\u0027host\u0027])"},{"line_number":131,"context_line":"            self.assertIn(share[\u0027task_state\u0027],"},{"line_number":132,"context_line":"                          [\u0027data_copying_completed\u0027,"},{"line_number":133,"context_line":"                           \u0027migration_driver_phase1_done\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_697157e0","line":133,"range":{"start_line":132,"start_character":26,"end_line":133,"end_character":58},"updated":"2016-06-23 12:25:41.000000000","message":"ditto","commit_id":"46ea9f32c92f0f4de952efa6d1bfe43a0dfedb27"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"552dddfe218e11e66b029dc855c815d8a11d55ea","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        else:"},{"line_number":130,"context_line":"            self.assertNotEqual(dest_pool, share[\u0027host\u0027])"},{"line_number":131,"context_line":"            self.assertIn(share[\u0027task_state\u0027],"},{"line_number":132,"context_line":"                          [\u0027data_copying_completed\u0027,"},{"line_number":133,"context_line":"                           \u0027migration_driver_phase1_done\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_fa822093","line":133,"range":{"start_line":132,"start_character":26,"end_line":133,"end_character":58},"in_reply_to":"3aaa91ec_697157e0","updated":"2016-06-23 14:53:51.000000000","message":"Done","commit_id":"46ea9f32c92f0f4de952efa6d1bfe43a0dfedb27"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ef4f97551e6eb7dcc3cef71cc04f26b835f1ccc0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            raise cls.skipException(message)"},{"line_number":39,"context_line":"        if not CONF.share.run_migration_tests:"},{"line_number":40,"context_line":"            raise cls.skipException(\"Migration tests disabled.\")"},{"line_number":41,"context_line":"        if len(CONF.share.backend_names) \u003c 2:"},{"line_number":42,"context_line":"            raise cls.skipException(\"For running migration tests it is \""},{"line_number":43,"context_line":"                                    \"required two backend names in config.\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_BACKEND])"},{"line_number":46,"context_line":"    @base.skip_if_microversion_lt(\"2.5\")"}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_3699c220","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":76},"updated":"2016-08-24 21:13:37.000000000","message":"As we discussed on the IRC - this test needs to change to allow migrating between pools; not every migration has to be between backends.. sometimes drivers may not be able to migrate between backends in an optimized way.. So, maybe its worth adding two kinds of tests; one for pools and the other between backends.. \n\nfor now, i would strongly suggest reading the list of pools using list_pools(detail\u003dTrue) and skipping if you can\u0027t find another \"pool\" to migrate your share to..","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f30fdf868444c7a9f3033a23f8bcc1a54e39cd87","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            raise cls.skipException(message)"},{"line_number":39,"context_line":"        if not CONF.share.run_migration_tests:"},{"line_number":40,"context_line":"            raise cls.skipException(\"Migration tests disabled.\")"},{"line_number":41,"context_line":"        if len(CONF.share.backend_names) \u003c 2:"},{"line_number":42,"context_line":"            raise cls.skipException(\"For running migration tests it is \""},{"line_number":43,"context_line":"                                    \"required two backend names in config.\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_BACKEND])"},{"line_number":46,"context_line":"    @base.skip_if_microversion_lt(\"2.5\")"}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_64ec1f90","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":76},"in_reply_to":"1ac06dbe_3699c220","updated":"2016-08-25 01:05:40.000000000","message":"Done","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86aef3d727244295960fe78598575deee0284a16","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        share \u003d self.migrate_share("},{"line_number":56,"context_line":"            share[\u0027id\u0027], dest_pool, version\u003d\u00272.15\u0027, notify\u003dFalse,"},{"line_number":57,"context_line":"            wait_for_status\u003d(\u0027data_copying_completed\u0027,"},{"line_number":58,"context_line":"                             \u0027migration_driver_phase1_done\u0027))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        self._validate_migration_successful("},{"line_number":61,"context_line":"            dest_pool, share, (\u0027data_copying_completed\u0027,"}],"source_content_type":"text/x-python","patch_set":71,"id":"fa7ab95a_f8add29b","line":58,"range":{"start_line":57,"start_character":29,"end_line":58,"end_character":59},"updated":"2016-08-29 20:04:12.000000000","message":"must be from constants","commit_id":"998db0f5c003ace6d0b9aa6461276554c87667a3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86aef3d727244295960fe78598575deee0284a16","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                             \u0027migration_driver_phase1_done\u0027))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        self._validate_migration_successful("},{"line_number":61,"context_line":"            dest_pool, share, (\u0027data_copying_completed\u0027,"},{"line_number":62,"context_line":"                               \u0027migration_driver_phase1_done\u0027),"},{"line_number":63,"context_line":"            \u00272.15\u0027, notify\u003dFalse)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        share \u003d self.migration_cancel(share[\u0027id\u0027], dest_pool)"}],"source_content_type":"text/x-python","patch_set":71,"id":"fa7ab95a_38949a41","line":62,"range":{"start_line":61,"start_character":31,"end_line":62,"end_character":60},"updated":"2016-08-29 20:04:12.000000000","message":"must be from constants","commit_id":"998db0f5c003ace6d0b9aa6461276554c87667a3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86aef3d727244295960fe78598575deee0284a16","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        share \u003d self.migration_cancel(share[\u0027id\u0027], dest_pool)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        self._validate_migration_successful("},{"line_number":68,"context_line":"            dest_pool, share, \u0027migration_cancelled\u0027, \u00272.15\u0027, notify\u003dFalse)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_BACKEND])"},{"line_number":71,"context_line":"    @base.skip_if_microversion_lt(\"2.5\")"}],"source_content_type":"text/x-python","patch_set":71,"id":"fa7ab95a_789aa26f","line":68,"range":{"start_line":68,"start_character":31,"end_line":68,"end_character":51},"updated":"2016-08-29 20:04:12.000000000","message":"same","commit_id":"998db0f5c003ace6d0b9aa6461276554c87667a3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86aef3d727244295960fe78598575deee0284a16","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        share \u003d self.migrate_share(share[\u0027id\u0027], dest_pool, version\u003d\u00272.5\u0027)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        self._validate_migration_successful("},{"line_number":79,"context_line":"            dest_pool, share, \u0027migration_success\u0027, version\u003d\u00272.5\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_BACKEND])"},{"line_number":82,"context_line":"    @base.skip_if_microversion_lt(\"2.15\")"}],"source_content_type":"text/x-python","patch_set":71,"id":"fa7ab95a_f884f20b","line":79,"range":{"start_line":79,"start_character":30,"end_line":79,"end_character":49},"updated":"2016-08-29 20:04:12.000000000","message":"same","commit_id":"998db0f5c003ace6d0b9aa6461276554c87667a3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86aef3d727244295960fe78598575deee0284a16","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                             \u0027migration_driver_phase1_done\u0027))"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        self._validate_migration_successful("},{"line_number":100,"context_line":"            dest_pool, share, (\u0027data_copying_completed\u0027,"},{"line_number":101,"context_line":"                               \u0027migration_driver_phase1_done\u0027),"},{"line_number":102,"context_line":"            \u00272.15\u0027, notify\u003dFalse)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        share \u003d self.migration_complete(share[\u0027id\u0027], dest_pool, version\u003d\u00272.15\u0027)"}],"source_content_type":"text/x-python","patch_set":71,"id":"fa7ab95a_387bba29","line":101,"range":{"start_line":100,"start_character":32,"end_line":101,"end_character":61},"updated":"2016-08-29 20:04:12.000000000","message":"same","commit_id":"998db0f5c003ace6d0b9aa6461276554c87667a3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86aef3d727244295960fe78598575deee0284a16","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        share \u003d self.migration_complete(share[\u0027id\u0027], dest_pool, version\u003d\u00272.15\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        self._validate_migration_successful("},{"line_number":107,"context_line":"            dest_pool, share, \u0027migration_success\u0027, version\u003d\u00272.15\u0027)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _setup_migration(self):"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":71,"id":"fa7ab95a_98904645","line":107,"range":{"start_line":107,"start_character":30,"end_line":107,"end_character":49},"updated":"2016-08-29 20:04:12.000000000","message":"same","commit_id":"998db0f5c003ace6d0b9aa6461276554c87667a3"}],"manila_tempest_tests/tests/api/admin/test_migration_negative.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"58c029650dc497adce8c9b0f04734fce6f0630de","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        if len(CONF.share.backend_names) \u003c 2:"},{"line_number":40,"context_line":"            raise cls.skipException(\"For running migration tests it is \""},{"line_number":41,"context_line":"                                    \"required two names in config. Skipping.\")"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        cls.share \u003d cls.create_share(cls.protocol)"},{"line_number":44,"context_line":"        cls.share \u003d cls.shares_client.get_share(cls.share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_d06a84ec","line":41,"range":{"start_line":41,"start_character":37,"end_line":41,"end_character":65},"updated":"2016-07-26 11:22:34.000000000","message":"Two names? Names of my cat and dog would be enough? Please, rewrite it to something more explicit.","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3f0d174f280e53b18a4344bc0988f00e680d70fc","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        if len(CONF.share.backend_names) \u003c 2:"},{"line_number":40,"context_line":"            raise cls.skipException(\"For running migration tests it is \""},{"line_number":41,"context_line":"                                    \"required two names in config. Skipping.\")"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        cls.share \u003d cls.create_share(cls.protocol)"},{"line_number":44,"context_line":"        cls.share \u003d cls.shares_client.get_share(cls.share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_3f1be4cb","line":41,"range":{"start_line":41,"start_character":37,"end_line":41,"end_character":65},"in_reply_to":"dada55a8_d06a84ec","updated":"2016-07-26 16:02:40.000000000","message":"if your cat and dog are named after backend names, that would work","commit_id":"0182f7bfcb01c52062eefd923fa8e61bdeb97ff0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"adc3bb3d0b202f79041be8a6eff9c2646eb42cc1","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            None)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        if not dest_pool or dest_pool.get(\u0027name\u0027) is None:"},{"line_number":60,"context_line":"            raise AssertionError(\"No valid pool entries to run migration \""},{"line_number":61,"context_line":"                                 \"tests.\")"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        cls.dest_pool \u003d dest_pool[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_a194cd36","line":60,"range":{"start_line":60,"start_character":18,"end_line":60,"end_character":32},"updated":"2016-07-26 16:27:16.000000000","message":"1) Why you change skipping to raising error?\n2) Only tempest exceptions are allowed.","commit_id":"d4c2ce9698dbcb2bd19b20727e817e6fc985c9ee"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1e48c089efbee28d553691864e1a83ec67418cb6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            None)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        if not dest_pool or dest_pool.get(\u0027name\u0027) is None:"},{"line_number":60,"context_line":"            raise AssertionError(\"No valid pool entries to run migration \""},{"line_number":61,"context_line":"                                 \"tests.\")"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        cls.dest_pool \u003d dest_pool[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_d7e8a3b5","line":60,"range":{"start_line":60,"start_character":18,"end_line":60,"end_character":32},"in_reply_to":"dada55a8_a194cd36","updated":"2016-07-26 17:07:47.000000000","message":"if migration tests are enabled, it should be error if destination host is not found because there is some misconfiguration","commit_id":"d4c2ce9698dbcb2bd19b20727e817e6fc985c9ee"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ef4f97551e6eb7dcc3cef71cc04f26b835f1ccc0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        if not CONF.share.run_migration_tests:"},{"line_number":39,"context_line":"            raise cls.skipException(\"Migration tests disabled.\")"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        if len(CONF.share.backend_names) \u003c 2:"},{"line_number":42,"context_line":"            raise cls.skipException(\"For running migration tests it is \""},{"line_number":43,"context_line":"                                    \"required two backend names in config.\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        pools \u003d cls.shares_client.list_pools()[\u0027pools\u0027]"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_f68f2aca","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":76},"updated":"2016-08-24 21:13:37.000000000","message":"same","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f30fdf868444c7a9f3033a23f8bcc1a54e39cd87","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        if not CONF.share.run_migration_tests:"},{"line_number":39,"context_line":"            raise cls.skipException(\"Migration tests disabled.\")"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        if len(CONF.share.backend_names) \u003c 2:"},{"line_number":42,"context_line":"            raise cls.skipException(\"For running migration tests it is \""},{"line_number":43,"context_line":"                                    \"required two backend names in config.\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        pools \u003d cls.shares_client.list_pools()[\u0027pools\u0027]"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_04fc4b3d","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":76},"in_reply_to":"1ac06dbe_f68f2aca","updated":"2016-08-25 01:05:40.000000000","message":"Done","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c23ea65c2cb8bcb14f6e734f6b82d14ea2e42464","unresolved":false,"context_lines":[{"line_number":383,"context_line":"    @classmethod"},{"line_number":384,"context_line":"    def migrate_share(cls, share_id, dest_host, client\u003dNone, notify\u003dTrue,"},{"line_number":385,"context_line":"                      wait_for_status\u003d\u0027migration_success\u0027, **kwargs):"},{"line_number":386,"context_line":"        status_list \u003d ([wait_for_status]"},{"line_number":387,"context_line":"                       if not isinstance(wait_for_status, list)"},{"line_number":388,"context_line":"                       else wait_for_status)"},{"line_number":389,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":390,"context_line":"        client.migrate_share(share_id, dest_host, notify, **kwargs)"},{"line_number":391,"context_line":"        share \u003d client.wait_for_migration_status("}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_69483788","line":388,"range":{"start_line":386,"start_character":22,"end_line":388,"end_character":44},"updated":"2016-06-23 12:25:41.000000000","message":"Should be logic of that waiter. Lots of callers should not do that trick.","commit_id":"46ea9f32c92f0f4de952efa6d1bfe43a0dfedb27"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"552dddfe218e11e66b029dc855c815d8a11d55ea","unresolved":false,"context_lines":[{"line_number":383,"context_line":"    @classmethod"},{"line_number":384,"context_line":"    def migrate_share(cls, share_id, dest_host, client\u003dNone, notify\u003dTrue,"},{"line_number":385,"context_line":"                      wait_for_status\u003d\u0027migration_success\u0027, **kwargs):"},{"line_number":386,"context_line":"        status_list \u003d ([wait_for_status]"},{"line_number":387,"context_line":"                       if not isinstance(wait_for_status, list)"},{"line_number":388,"context_line":"                       else wait_for_status)"},{"line_number":389,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":390,"context_line":"        client.migrate_share(share_id, dest_host, notify, **kwargs)"},{"line_number":391,"context_line":"        share \u003d client.wait_for_migration_status("}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_daa9247d","line":388,"range":{"start_line":386,"start_character":22,"end_line":388,"end_character":44},"in_reply_to":"3aaa91ec_69483788","updated":"2016-06-23 14:53:51.000000000","message":"Done","commit_id":"46ea9f32c92f0f4de952efa6d1bfe43a0dfedb27"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86aef3d727244295960fe78598575deee0284a16","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":425,"context_line":"        client.migration_cancel(share_id, **kwargs)"},{"line_number":426,"context_line":"        share \u003d client.wait_for_migration_status("},{"line_number":427,"context_line":"            share_id, dest_host, \u0027migration_cancelled\u0027, **kwargs)"},{"line_number":428,"context_line":"        return share"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":71,"id":"fa7ab95a_d8b1ee02","line":427,"range":{"start_line":427,"start_character":33,"end_line":427,"end_character":54},"updated":"2016-08-29 20:04:12.000000000","message":"needs to be in the constants file","commit_id":"998db0f5c003ace6d0b9aa6461276554c87667a3"}],"manila_tempest_tests/tests/scenario/test_share_basic_ops.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ef4f97551e6eb7dcc3cef71cc04f26b835f1ccc0","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_BACKEND])"},{"line_number":248,"context_line":"    @testtools.skipUnless(CONF.share.run_migration_tests,"},{"line_number":249,"context_line":"                          \"Migration tests disabled.\")"},{"line_number":250,"context_line":"    @testtools.skipUnless(len(CONF.share.backend_names) \u003e 1,"},{"line_number":251,"context_line":"                          \"For running migration tests it is \""},{"line_number":252,"context_line":"                          \"required two backend names in config.\")"},{"line_number":253,"context_line":"    def test_migration_files(self):"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        if self.protocol \u003d\u003d \"CIFS\":"},{"line_number":256,"context_line":"            raise self.skipException(\"Test for CIFS protocol not supported \""}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_76717ae0","line":253,"range":{"start_line":250,"start_character":0,"end_line":253,"end_character":35},"updated":"2016-08-24 21:13:37.000000000","message":"same","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f30fdf868444c7a9f3033a23f8bcc1a54e39cd87","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_BACKEND])"},{"line_number":248,"context_line":"    @testtools.skipUnless(CONF.share.run_migration_tests,"},{"line_number":249,"context_line":"                          \"Migration tests disabled.\")"},{"line_number":250,"context_line":"    @testtools.skipUnless(len(CONF.share.backend_names) \u003e 1,"},{"line_number":251,"context_line":"                          \"For running migration tests it is \""},{"line_number":252,"context_line":"                          \"required two backend names in config.\")"},{"line_number":253,"context_line":"    def test_migration_files(self):"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        if self.protocol \u003d\u003d \"CIFS\":"},{"line_number":256,"context_line":"            raise self.skipException(\"Test for CIFS protocol not supported \""}],"source_content_type":"text/x-python","patch_set":60,"id":"1ac06dbe_c48873c9","line":253,"range":{"start_line":250,"start_character":0,"end_line":253,"end_character":35},"in_reply_to":"1ac06dbe_76717ae0","updated":"2016-08-25 01:05:40.000000000","message":"Done","commit_id":"1fd980572992b8608edaa022e51b8a0acfed0033"}]}
