)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5b66634f5d7000c270563eda83f3eac990b1ddc5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhongjun \u003cjun.zhongjun@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-23 03:28:55 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix quota usage can exceed limit in manage share API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we directly use db method to change quota usage,"},{"line_number":10,"context_line":"the quota usage limit can not work. So change to use"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_5086b313","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":52},"updated":"2016-06-23 14:01:30.000000000","message":"Update quota usages correctly in manage share operation","commit_id":"a5a249a087ea79ea4b81598f8edda8a5b609f6c5"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3f649ef434de6494696b11bb68961f9260a2711f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhongjun \u003cjun.zhongjun@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-23 03:28:55 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix quota usage can exceed limit in manage share API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we directly use db method to change quota usage,"},{"line_number":10,"context_line":"the quota usage limit can not work. So change to use"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_5f3ebfda","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":52},"in_reply_to":"3aaa91ec_5086b313","updated":"2016-06-23 14:55:40.000000000","message":"Done","commit_id":"a5a249a087ea79ea4b81598f8edda8a5b609f6c5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5b66634f5d7000c270563eda83f3eac990b1ddc5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix quota usage can exceed limit in manage share API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we directly use db method to change quota usage,"},{"line_number":10,"context_line":"the quota usage limit can not work. So change to use"},{"line_number":11,"context_line":"quota reserve method to modify the share usage value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I9175dae538480bde4704330a79453dfc89cc32b9"},{"line_number":14,"context_line":"Closes-Bug: #1595430"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_1008ab90","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":53},"updated":"2016-06-23 14:01:30.000000000","message":"I understood problem only after reading code change.\nbetter to rewrite it to something following:\n\n\"\"\"\nMake share manager\u0027s method \"manage_existing\" use \"quota\" interface for updating quota usages instead of direct DB update. It will allow us to fail correctly if quota exceeds limit.\n\"\"\"","commit_id":"a5a249a087ea79ea4b81598f8edda8a5b609f6c5"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3f649ef434de6494696b11bb68961f9260a2711f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix quota usage can exceed limit in manage share API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we directly use db method to change quota usage,"},{"line_number":10,"context_line":"the quota usage limit can not work. So change to use"},{"line_number":11,"context_line":"quota reserve method to modify the share usage value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I9175dae538480bde4704330a79453dfc89cc32b9"},{"line_number":14,"context_line":"Closes-Bug: #1595430"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_df2aaf8f","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":53},"in_reply_to":"3aaa91ec_1008ab90","updated":"2016-06-23 14:55:40.000000000","message":"Done","commit_id":"a5a249a087ea79ea4b81598f8edda8a5b609f6c5"}],"manila/share/manager.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"349afb3541482d65a12680721266331eb957de4d","unresolved":false,"context_lines":[{"line_number":1580,"context_line":"                                          user_id\u003dcontext.user_id,"},{"line_number":1581,"context_line":"                                          shares\u003d1,"},{"line_number":1582,"context_line":"                                          gigabytes\u003dshare_update[\u0027size\u0027])"},{"line_number":1583,"context_line":"            QUOTAS.commit(context, reservations, project_id\u003dproject_id)"},{"line_number":1584,"context_line":""},{"line_number":1585,"context_line":"            share_update.update({"},{"line_number":1586,"context_line":"                \u0027status\u0027: constants.STATUS_AVAILABLE,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_551e370c","line":1583,"range":{"start_line":1583,"start_character":1,"end_line":1583,"end_character":71},"updated":"2016-06-26 22:02:08.000000000","message":"You are committing the reservation instantly, irrespective of whether succeed in the intended operation.\n\nThe current quota paradigm has *reservations*, which then either get committed or rolled back (or expire, but that\u0027s another story) depending on whether the operation succeeds or fails.  So I think you should either commit or rollback further down the code path.","commit_id":"fdfd07097e57ca5ca42f28abb98cd754d8107255"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"349afb3541482d65a12680721266331eb957de4d","unresolved":false,"context_lines":[{"line_number":1603,"context_line":"                    delete\u003dTrue)"},{"line_number":1604,"context_line":""},{"line_number":1605,"context_line":"            self.db.share_update(context, share_id, share_update)"},{"line_number":1606,"context_line":"        except Exception:"},{"line_number":1607,"context_line":"            # NOTE(vponomaryov): set size as 1 because design expects size"},{"line_number":1608,"context_line":"            # to be set, it also will allow us to handle delete/unmanage"},{"line_number":1609,"context_line":"            # operations properly with this errored share according to quotas."}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_95141fe9","line":1606,"range":{"start_line":1606,"start_character":1,"end_line":1606,"end_character":25},"updated":"2016-06-26 22:02:08.000000000","message":"rollback here","commit_id":"fdfd07097e57ca5ca42f28abb98cd754d8107255"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"349afb3541482d65a12680721266331eb957de4d","unresolved":false,"context_lines":[{"line_number":1611,"context_line":"                context, share_id,"},{"line_number":1612,"context_line":"                {\u0027status\u0027: constants.STATUS_MANAGE_ERROR, \u0027size\u0027: 1})"},{"line_number":1613,"context_line":"            raise"},{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":"    @add_hooks"},{"line_number":1616,"context_line":"    @utils.require_driver_initialized"},{"line_number":1617,"context_line":"    def manage_snapshot(self, context, snapshot_id, driver_options):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_f5d5a31b","line":1614,"updated":"2016-06-26 22:02:08.000000000","message":"commit before returning from this method if you didn\u0027t hit the exception","commit_id":"fdfd07097e57ca5ca42f28abb98cd754d8107255"}]}
