)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19144,"name":"José Mello","email":"jose.eduardo.jr@gmail.com","username":"jose-eduardo-jr"},"change_message_id":"ca2e032a0ea9f4bfe9a2a0dd47922ed42f14e4e4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add share_size config option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All tempest tests create shares with fixed size, 1GB. This patch add a config"},{"line_number":10,"context_line":"option in order to allow configurable share sizes as cinder does."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TrivialFix"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_49fc093e","line":9,"range":{"start_line":9,"start_character":67,"end_line":9,"end_character":77},"updated":"2016-06-24 17:55:09.000000000","message":"please review line width","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"34204941145054bf34a2879cce11dd1b54a88ce5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add share_size config option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All tempest tests create shares with fixed size, 1GB. This patch add a config"},{"line_number":10,"context_line":"option in order to allow configurable share sizes as cinder does."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TrivialFix"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_0c09da2c","line":9,"range":{"start_line":9,"start_character":67,"end_line":9,"end_character":77},"in_reply_to":"3aaa91ec_49fc093e","updated":"2016-06-28 19:47:30.000000000","message":"Done","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"5d74c73fb83cdaff6bea83919cac2e6493024e70","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add share_size config option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All tempest tests create shares with fixed size, 1GB. This patch add a config"},{"line_number":10,"context_line":"option in order to allow configurable share sizes as cinder does."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TrivialFix"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_95c25f51","line":10,"updated":"2016-06-26 22:19:32.000000000","message":"Please include a reference to the cinder change id.","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"34204941145054bf34a2879cce11dd1b54a88ce5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add share_size config option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All tempest tests create shares with fixed size, 1GB. This patch add a config"},{"line_number":10,"context_line":"option in order to allow configurable share sizes as cinder does."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TrivialFix"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_0c20ba9a","line":10,"in_reply_to":"3aaa91ec_95c25f51","updated":"2016-06-28 19:47:30.000000000","message":"Done. I don\u0027t know what\u0027s the best way to do it (just added as a plain text). I looked at commit messages documentation, but I didn\u0027t find anything about that, so if it\u0027s not the best way, please, let me know","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f46d56d3ad8654d6a2e22b63fdb631ddcb430379","unresolved":false,"context_lines":[{"line_number":9,"context_line":"All tempest tests create shares with fixed size, 1GB. This patch add a config"},{"line_number":10,"context_line":"option in order to allow configurable share sizes as cinder does."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TrivialFix"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ifd09519b63c6c1a0ec8449e5dae1ffe0caa1b879"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_c7528434","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":10},"updated":"2016-06-26 09:58:30.000000000","message":"Are you sure this is a trivial fix?","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"34204941145054bf34a2879cce11dd1b54a88ce5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"All tempest tests create shares with fixed size, 1GB. This patch add a config"},{"line_number":10,"context_line":"option in order to allow configurable share sizes as cinder does."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TrivialFix"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ifd09519b63c6c1a0ec8449e5dae1ffe0caa1b879"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_6cb4de34","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":10},"in_reply_to":"3aaa91ec_b5c79b62","updated":"2016-06-28 19:47:30.000000000","message":"I think it is a simple change which improve manila_tests, once run all tests with share size \u003d 1 is not a bug. Do you think I have to open a bug or create a blueprint? If so, I can do it too.","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"5d74c73fb83cdaff6bea83919cac2e6493024e70","unresolved":false,"context_lines":[{"line_number":9,"context_line":"All tempest tests create shares with fixed size, 1GB. This patch add a config"},{"line_number":10,"context_line":"option in order to allow configurable share sizes as cinder does."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TrivialFix"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ifd09519b63c6c1a0ec8449e5dae1ffe0caa1b879"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_b5c79b62","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":10},"in_reply_to":"3aaa91ec_c7528434","updated":"2016-06-26 22:19:32.000000000","message":"+1","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"}],"manila_tempest_tests/tests/api/admin/test_shares_actions.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f46d56d3ad8654d6a2e22b63fdb631ddcb430379","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \u0027foo_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":50,"context_line":"            \u0027bar_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":51,"context_line":"        }"},{"line_number":52,"context_line":"        cls.share_size \u003d CONF.share.share_size"},{"line_number":53,"context_line":"        cls.shares.append(cls.create_share("},{"line_number":54,"context_line":"            name\u003dcls.share_name,"},{"line_number":55,"context_line":"            description\u003dcls.share_desc,"},{"line_number":56,"context_line":"            size\u003dcls.share_size,"},{"line_number":57,"context_line":"            metadata\u003dcls.metadata,"},{"line_number":58,"context_line":"            share_type_id\u003dcls.st[\u0027share_type\u0027][\u0027id\u0027],"},{"line_number":59,"context_line":"        ))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_a78c98da","line":56,"range":{"start_line":52,"start_character":7,"end_line":56,"end_character":32},"updated":"2016-06-26 09:58:30.000000000","message":"The size parameter has been set to CONF.share.share_size in the create_share function. Why need to set size again? You could remove the \"size\u003dcls.share_size\" if the size need to be set to CONF.share.share_size.","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"34204941145054bf34a2879cce11dd1b54a88ce5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \u0027foo_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":50,"context_line":"            \u0027bar_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":51,"context_line":"        }"},{"line_number":52,"context_line":"        cls.share_size \u003d CONF.share.share_size"},{"line_number":53,"context_line":"        cls.shares.append(cls.create_share("},{"line_number":54,"context_line":"            name\u003dcls.share_name,"},{"line_number":55,"context_line":"            description\u003dcls.share_desc,"},{"line_number":56,"context_line":"            size\u003dcls.share_size,"},{"line_number":57,"context_line":"            metadata\u003dcls.metadata,"},{"line_number":58,"context_line":"            share_type_id\u003dcls.st[\u0027share_type\u0027][\u0027id\u0027],"},{"line_number":59,"context_line":"        ))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_ac07e6c7","line":56,"range":{"start_line":52,"start_character":7,"end_line":56,"end_character":32},"in_reply_to":"3aaa91ec_5593d75a","updated":"2016-06-28 19:47:30.000000000","message":"Some tests use this parameter to do an assert (see _get_share() function), but looking at cinder tempest code, the assert is done using CONF parameter, so I removed this parameter and used CONF param in the assert statement.","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"5d74c73fb83cdaff6bea83919cac2e6493024e70","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \u0027foo_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":50,"context_line":"            \u0027bar_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":51,"context_line":"        }"},{"line_number":52,"context_line":"        cls.share_size \u003d CONF.share.share_size"},{"line_number":53,"context_line":"        cls.shares.append(cls.create_share("},{"line_number":54,"context_line":"            name\u003dcls.share_name,"},{"line_number":55,"context_line":"            description\u003dcls.share_desc,"},{"line_number":56,"context_line":"            size\u003dcls.share_size,"},{"line_number":57,"context_line":"            metadata\u003dcls.metadata,"},{"line_number":58,"context_line":"            share_type_id\u003dcls.st[\u0027share_type\u0027][\u0027id\u0027],"},{"line_number":59,"context_line":"        ))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_5593d75a","line":56,"range":{"start_line":52,"start_character":7,"end_line":56,"end_character":32},"in_reply_to":"3aaa91ec_a78c98da","updated":"2016-06-26 22:19:32.000000000","message":"I had the same question.","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f92fb13de945f962b191bde9ea31d6db6b4ef7a5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \u0027foo_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":50,"context_line":"            \u0027bar_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":51,"context_line":"        }"},{"line_number":52,"context_line":"        cls.share_size \u003d CONF.share.share_size"},{"line_number":53,"context_line":"        cls.shares.append(cls.create_share("},{"line_number":54,"context_line":"            name\u003dcls.share_name,"},{"line_number":55,"context_line":"            description\u003dcls.share_desc,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_4b23a8a7","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":46},"updated":"2016-06-29 11:38:09.000000000","message":"Actually, it could just be removed.","commit_id":"4d1d3d602a04847364cf58f5bc3087e532f41b07"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"547981b998b5fdca03b52386cf83bd6d249df0c9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \u0027foo_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":50,"context_line":"            \u0027bar_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":51,"context_line":"        }"},{"line_number":52,"context_line":"        cls.share_size \u003d CONF.share.share_size"},{"line_number":53,"context_line":"        cls.shares.append(cls.create_share("},{"line_number":54,"context_line":"            name\u003dcls.share_name,"},{"line_number":55,"context_line":"            description\u003dcls.share_desc,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_e229d29c","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":46},"in_reply_to":"3aaa91ec_4b23a8a7","updated":"2016-06-29 12:46:13.000000000","message":"Done","commit_id":"4d1d3d602a04847364cf58f5bc3087e532f41b07"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":19144,"name":"José Mello","email":"jose.eduardo.jr@gmail.com","username":"jose-eduardo-jr"},"change_message_id":"4af613f7c62add850e9cf545c0b8458e7278c078","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        description \u003d description or \"Tempest\u0027s share\""},{"line_number":359,"context_line":"        share_network_id \u003d share_network_id or client.share_network_id or None"},{"line_number":360,"context_line":"        metadata \u003d metadata or {}"},{"line_number":361,"context_line":"        size \u003d size or CONF.share.share_size or 1"},{"line_number":362,"context_line":"        kwargs.update({"},{"line_number":363,"context_line":"            \u0027share_protocol\u0027: share_protocol,"},{"line_number":364,"context_line":"            \u0027size\u0027: size,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_94072181","line":361,"range":{"start_line":361,"start_character":8,"end_line":361,"end_character":49},"updated":"2016-06-24 19:04:15.000000000","message":"Considering the default is always configured as 1, no need for the last \"or 1\"","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"34204941145054bf34a2879cce11dd1b54a88ce5","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        description \u003d description or \"Tempest\u0027s share\""},{"line_number":359,"context_line":"        share_network_id \u003d share_network_id or client.share_network_id or None"},{"line_number":360,"context_line":"        metadata \u003d metadata or {}"},{"line_number":361,"context_line":"        size \u003d size or CONF.share.share_size or 1"},{"line_number":362,"context_line":"        kwargs.update({"},{"line_number":363,"context_line":"            \u0027share_protocol\u0027: share_protocol,"},{"line_number":364,"context_line":"            \u0027size\u0027: size,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_ec11ee05","line":361,"range":{"start_line":361,"start_character":8,"end_line":361,"end_character":49},"in_reply_to":"3aaa91ec_25118fb0","updated":"2016-06-28 19:47:30.000000000","message":"Done","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"47f2b87d80419cd6e85af251fd9039aded20bf27","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        description \u003d description or \"Tempest\u0027s share\""},{"line_number":359,"context_line":"        share_network_id \u003d share_network_id or client.share_network_id or None"},{"line_number":360,"context_line":"        metadata \u003d metadata or {}"},{"line_number":361,"context_line":"        size \u003d size or CONF.share.share_size or 1"},{"line_number":362,"context_line":"        kwargs.update({"},{"line_number":363,"context_line":"            \u0027share_protocol\u0027: share_protocol,"},{"line_number":364,"context_line":"            \u0027size\u0027: size,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_25118fb0","line":361,"range":{"start_line":361,"start_character":8,"end_line":361,"end_character":49},"in_reply_to":"3aaa91ec_94072181","updated":"2016-06-27 18:23:07.000000000","message":"indeed, the \"or 1\" is not necessary, can be removed.","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"}],"manila_tempest_tests/tests/api/test_consistency_group_actions.py":[{"author":{"_account_id":19144,"name":"José Mello","email":"jose.eduardo.jr@gmail.com","username":"jose-eduardo-jr"},"change_message_id":"ca2e032a0ea9f4bfe9a2a0dd47922ed42f14e4e4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        # Create 2 shares inside first CG and 1 inside second CG"},{"line_number":55,"context_line":"        cls.share_name \u003d data_utils.rand_name(\"tempest-share-name\")"},{"line_number":56,"context_line":"        cls.share_desc \u003d data_utils.rand_name(\"tempest-share-description\")"},{"line_number":57,"context_line":"        cls.share_size \u003d CONF.share.share_size"},{"line_number":58,"context_line":"        cls.share_size2 \u003d cls.share_size + 1"},{"line_number":59,"context_line":"        cls.shares \u003d cls.create_shares(["},{"line_number":60,"context_line":"            {\u0027kwargs\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_4981a98e","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":46},"updated":"2016-06-24 17:55:09.000000000","message":"What happens if config is not set ?","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"5d74c73fb83cdaff6bea83919cac2e6493024e70","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        # Create 2 shares inside first CG and 1 inside second CG"},{"line_number":55,"context_line":"        cls.share_name \u003d data_utils.rand_name(\"tempest-share-name\")"},{"line_number":56,"context_line":"        cls.share_desc \u003d data_utils.rand_name(\"tempest-share-description\")"},{"line_number":57,"context_line":"        cls.share_size \u003d CONF.share.share_size"},{"line_number":58,"context_line":"        cls.share_size2 \u003d cls.share_size + 1"},{"line_number":59,"context_line":"        cls.shares \u003d cls.create_shares(["},{"line_number":60,"context_line":"            {\u0027kwargs\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_b59e7b60","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":46},"in_reply_to":"3aaa91ec_4981a98e","updated":"2016-06-26 22:19:32.000000000","message":"it will get the default value, 1.","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"34204941145054bf34a2879cce11dd1b54a88ce5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        # Create 2 shares inside first CG and 1 inside second CG"},{"line_number":55,"context_line":"        cls.share_name \u003d data_utils.rand_name(\"tempest-share-name\")"},{"line_number":56,"context_line":"        cls.share_desc \u003d data_utils.rand_name(\"tempest-share-description\")"},{"line_number":57,"context_line":"        cls.share_size \u003d CONF.share.share_size"},{"line_number":58,"context_line":"        cls.share_size2 \u003d cls.share_size + 1"},{"line_number":59,"context_line":"        cls.shares \u003d cls.create_shares(["},{"line_number":60,"context_line":"            {\u0027kwargs\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_ccd23234","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":46},"in_reply_to":"3aaa91ec_b59e7b60","updated":"2016-06-28 19:47:30.000000000","message":"yep. The default value is used","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"}],"manila_tempest_tests/tests/api/test_consistency_groups_negative.py":[{"author":{"_account_id":19144,"name":"José Mello","email":"jose.eduardo.jr@gmail.com","username":"jose-eduardo-jr"},"change_message_id":"ca2e032a0ea9f4bfe9a2a0dd47922ed42f14e4e4","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        # Create a share in the consistency group"},{"line_number":122,"context_line":"        cls.share_name \u003d data_utils.rand_name(\"tempest-share-name\")"},{"line_number":123,"context_line":"        cls.share_desc \u003d data_utils.rand_name(\"tempest-share-description\")"},{"line_number":124,"context_line":"        cls.share_size \u003d CONF.share.share_size"},{"line_number":125,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":126,"context_line":"            name\u003dcls.share_name,"},{"line_number":127,"context_line":"            description\u003dcls.share_desc,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_a9464d78","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":46},"updated":"2016-06-24 17:55:09.000000000","message":"What happens if config is not set ?","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"34204941145054bf34a2879cce11dd1b54a88ce5","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        # Create a share in the consistency group"},{"line_number":122,"context_line":"        cls.share_name \u003d data_utils.rand_name(\"tempest-share-name\")"},{"line_number":123,"context_line":"        cls.share_desc \u003d data_utils.rand_name(\"tempest-share-description\")"},{"line_number":124,"context_line":"        cls.share_size \u003d CONF.share.share_size"},{"line_number":125,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":126,"context_line":"            name\u003dcls.share_name,"},{"line_number":127,"context_line":"            description\u003dcls.share_desc,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_4ce76212","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":46},"in_reply_to":"3aaa91ec_3581ebfb","updated":"2016-06-28 19:47:30.000000000","message":"Done","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"5d74c73fb83cdaff6bea83919cac2e6493024e70","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        # Create a share in the consistency group"},{"line_number":122,"context_line":"        cls.share_name \u003d data_utils.rand_name(\"tempest-share-name\")"},{"line_number":123,"context_line":"        cls.share_desc \u003d data_utils.rand_name(\"tempest-share-description\")"},{"line_number":124,"context_line":"        cls.share_size \u003d CONF.share.share_size"},{"line_number":125,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":126,"context_line":"            name\u003dcls.share_name,"},{"line_number":127,"context_line":"            description\u003dcls.share_desc,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_3581ebfb","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":46},"in_reply_to":"3aaa91ec_a9464d78","updated":"2016-06-26 22:19:32.000000000","message":"ditto","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f46d56d3ad8654d6a2e22b63fdb631ddcb430379","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":126,"context_line":"            name\u003dcls.share_name,"},{"line_number":127,"context_line":"            description\u003dcls.share_desc,"},{"line_number":128,"context_line":"            size\u003dcls.share_size,"},{"line_number":129,"context_line":"            consistency_group_id\u003dcls.consistency_group[\u0027id\u0027],"},{"line_number":130,"context_line":"        )"},{"line_number":131,"context_line":"        # Create a cgsnapshot of the consistency group"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_c7a4444c","line":128,"range":{"start_line":128,"start_character":12,"end_line":128,"end_character":32},"updated":"2016-06-26 09:58:30.000000000","message":"The size parameter has been set to CONF.share.share_size in the create_share function. Why need to set size again? You could remove the \"size\u003dcls.share_size\" if the size need to be set to CONF.share.share_size.","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"34204941145054bf34a2879cce11dd1b54a88ce5","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":126,"context_line":"            name\u003dcls.share_name,"},{"line_number":127,"context_line":"            description\u003dcls.share_desc,"},{"line_number":128,"context_line":"            size\u003dcls.share_size,"},{"line_number":129,"context_line":"            consistency_group_id\u003dcls.consistency_group[\u0027id\u0027],"},{"line_number":130,"context_line":"        )"},{"line_number":131,"context_line":"        # Create a cgsnapshot of the consistency group"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_2ce2d601","line":128,"range":{"start_line":128,"start_character":12,"end_line":128,"end_character":32},"in_reply_to":"3aaa91ec_757ff314","updated":"2016-06-28 19:47:30.000000000","message":"Done","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"5d74c73fb83cdaff6bea83919cac2e6493024e70","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":126,"context_line":"            name\u003dcls.share_name,"},{"line_number":127,"context_line":"            description\u003dcls.share_desc,"},{"line_number":128,"context_line":"            size\u003dcls.share_size,"},{"line_number":129,"context_line":"            consistency_group_id\u003dcls.consistency_group[\u0027id\u0027],"},{"line_number":130,"context_line":"        )"},{"line_number":131,"context_line":"        # Create a cgsnapshot of the consistency group"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_757ff314","line":128,"range":{"start_line":128,"start_character":12,"end_line":128,"end_character":32},"in_reply_to":"3aaa91ec_c7a4444c","updated":"2016-06-26 22:19:32.000000000","message":"+1","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"}],"manila_tempest_tests/tests/api/test_shares_actions.py":[{"author":{"_account_id":19144,"name":"José Mello","email":"jose.eduardo.jr@gmail.com","username":"jose-eduardo-jr"},"change_message_id":"ca2e032a0ea9f4bfe9a2a0dd47922ed42f14e4e4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \u0027foo_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":45,"context_line":"            \u0027bar_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":"        cls.share_size \u003d CONF.share.share_size"},{"line_number":48,"context_line":"        cls.shares.append(cls.create_share("},{"line_number":49,"context_line":"            name\u003dcls.share_name,"},{"line_number":50,"context_line":"            description\u003dcls.share_desc,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_29537d3a","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":46},"updated":"2016-06-24 17:55:09.000000000","message":"What happens if config is not set ?","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"a3dbee10f302a6e5bc889f4cdfd98b1ef8fded72","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \u0027foo_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":45,"context_line":"            \u0027bar_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":"        cls.share_size \u003d CONF.share.share_size"},{"line_number":48,"context_line":"        cls.shares.append(cls.create_share("},{"line_number":49,"context_line":"            name\u003dcls.share_name,"},{"line_number":50,"context_line":"            description\u003dcls.share_desc,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_716447b8","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":46},"in_reply_to":"3aaa91ec_29537d3a","updated":"2016-06-24 18:39:33.000000000","message":"Jose Mello, the CONF has a default value of 1.","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"34204941145054bf34a2879cce11dd1b54a88ce5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \u0027foo_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":45,"context_line":"            \u0027bar_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":"        cls.share_size \u003d CONF.share.share_size"},{"line_number":48,"context_line":"        cls.shares.append(cls.create_share("},{"line_number":49,"context_line":"            name\u003dcls.share_name,"},{"line_number":50,"context_line":"            description\u003dcls.share_desc,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_ecb60ef8","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":46},"in_reply_to":"3aaa91ec_716447b8","updated":"2016-06-28 19:47:30.000000000","message":"Done","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":19144,"name":"José Mello","email":"jose.eduardo.jr@gmail.com","username":"jose-eduardo-jr"},"change_message_id":"4af613f7c62add850e9cf545c0b8458e7278c078","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \u0027foo_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":45,"context_line":"            \u0027bar_key_share_1\u0027: \u0027foo_value_share_1\u0027,"},{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":"        cls.share_size \u003d CONF.share.share_size"},{"line_number":48,"context_line":"        cls.shares.append(cls.create_share("},{"line_number":49,"context_line":"            name\u003dcls.share_name,"},{"line_number":50,"context_line":"            description\u003dcls.share_desc,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_9415619d","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":46},"in_reply_to":"3aaa91ec_716447b8","updated":"2016-06-24 19:04:15.000000000","message":"Thanks! Got confused by an OR statement on base.py.\n\nMarcus,\nYou can disconsider these comments of config not set","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":19144,"name":"José Mello","email":"jose.eduardo.jr@gmail.com","username":"jose-eduardo-jr"},"change_message_id":"ca2e032a0ea9f4bfe9a2a0dd47922ed42f14e4e4","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        public_share \u003d self.create_share("},{"line_number":370,"context_line":"            name\u003d\u0027public_share\u0027,"},{"line_number":371,"context_line":"            description\u003d\u0027public_share_desc\u0027,"},{"line_number":372,"context_line":"            size\u003dCONF.share.share_size,"},{"line_number":373,"context_line":"            is_public\u003dTrue,"},{"line_number":374,"context_line":"            cleanup_in_class\u003dFalse"},{"line_number":375,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_3b2f4089","line":372,"range":{"start_line":372,"start_character":12,"end_line":372,"end_character":39},"updated":"2016-06-24 17:55:09.000000000","message":"What happens if config is not set ?","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"34204941145054bf34a2879cce11dd1b54a88ce5","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        public_share \u003d self.create_share("},{"line_number":370,"context_line":"            name\u003d\u0027public_share\u0027,"},{"line_number":371,"context_line":"            description\u003d\u0027public_share_desc\u0027,"},{"line_number":372,"context_line":"            size\u003dCONF.share.share_size,"},{"line_number":373,"context_line":"            is_public\u003dTrue,"},{"line_number":374,"context_line":"            cleanup_in_class\u003dFalse"},{"line_number":375,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_4c95a23e","line":372,"range":{"start_line":372,"start_character":12,"end_line":372,"end_character":39},"in_reply_to":"3aaa91ec_3598cb69","updated":"2016-06-28 19:47:30.000000000","message":"Done","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"5d74c73fb83cdaff6bea83919cac2e6493024e70","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        public_share \u003d self.create_share("},{"line_number":370,"context_line":"            name\u003d\u0027public_share\u0027,"},{"line_number":371,"context_line":"            description\u003d\u0027public_share_desc\u0027,"},{"line_number":372,"context_line":"            size\u003dCONF.share.share_size,"},{"line_number":373,"context_line":"            is_public\u003dTrue,"},{"line_number":374,"context_line":"            cleanup_in_class\u003dFalse"},{"line_number":375,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_3598cb69","line":372,"range":{"start_line":372,"start_character":12,"end_line":372,"end_character":39},"in_reply_to":"3aaa91ec_3b2f4089","updated":"2016-06-26 22:19:32.000000000","message":"ok, see othat rodrigo already replied on this point.","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":19144,"name":"José Mello","email":"jose.eduardo.jr@gmail.com","username":"jose-eduardo-jr"},"change_message_id":"ca2e032a0ea9f4bfe9a2a0dd47922ed42f14e4e4","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        private_share \u003d self.create_share("},{"line_number":377,"context_line":"            name\u003d\u0027private_share\u0027,"},{"line_number":378,"context_line":"            description\u003d\u0027private_share_desc\u0027,"},{"line_number":379,"context_line":"            size\u003dCONF.share.share_size,"},{"line_number":380,"context_line":"            is_public\u003dFalse,"},{"line_number":381,"context_line":"            cleanup_in_class\u003dFalse"},{"line_number":382,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_9b50f40c","line":379,"range":{"start_line":379,"start_character":10,"end_line":379,"end_character":39},"updated":"2016-06-24 17:55:09.000000000","message":"What happens if config is not set ?","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"34204941145054bf34a2879cce11dd1b54a88ce5","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        private_share \u003d self.create_share("},{"line_number":377,"context_line":"            name\u003d\u0027private_share\u0027,"},{"line_number":378,"context_line":"            description\u003d\u0027private_share_desc\u0027,"},{"line_number":379,"context_line":"            size\u003dCONF.share.share_size,"},{"line_number":380,"context_line":"            is_public\u003dFalse,"},{"line_number":381,"context_line":"            cleanup_in_class\u003dFalse"},{"line_number":382,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_6c9a1e70","line":379,"range":{"start_line":379,"start_character":10,"end_line":379,"end_character":39},"in_reply_to":"3aaa91ec_9b50f40c","updated":"2016-06-28 19:47:30.000000000","message":"Done","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"a3dbee10f302a6e5bc889f4cdfd98b1ef8fded72","unresolved":false,"context_lines":[{"line_number":563,"context_line":"        CONF.share.run_extend_tests,"},{"line_number":564,"context_line":"        \"Share extend tests are disabled.\")"},{"line_number":565,"context_line":"    def test_extend_share(self):"},{"line_number":566,"context_line":"        share \u003d self.create_share(size\u003dCONF.share.share_size, cleanup_in_class\u003dFalse)"},{"line_number":567,"context_line":"        new_size \u003d int(share[\u0027size\u0027]) + 1"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"        # extend share and wait for active status"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_1199837c","line":566,"range":{"start_line":566,"start_character":34,"end_line":566,"end_character":60},"updated":"2016-06-24 18:39:33.000000000","message":"You already changed the default value in the share_client, so if you just not supply the kwarg here, then the CONF value set will be used.\n\nPlease review all other usages and do not set a share size where the default value from the share_client can be used.","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"a3dbee10f302a6e5bc889f4cdfd98b1ef8fded72","unresolved":false,"context_lines":[{"line_number":563,"context_line":"        CONF.share.run_extend_tests,"},{"line_number":564,"context_line":"        \"Share extend tests are disabled.\")"},{"line_number":565,"context_line":"    def test_extend_share(self):"},{"line_number":566,"context_line":"        share \u003d self.create_share(size\u003dCONF.share.share_size, cleanup_in_class\u003dFalse)"},{"line_number":567,"context_line":"        new_size \u003d int(share[\u0027size\u0027]) + 1"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"        # extend share and wait for active status"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_319abf6e","line":566,"range":{"start_line":566,"start_character":77,"end_line":566,"end_character":85},"updated":"2016-06-24 18:39:33.000000000","message":"line length should not go beyond 79 characters","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"5d74c73fb83cdaff6bea83919cac2e6493024e70","unresolved":false,"context_lines":[{"line_number":563,"context_line":"        CONF.share.run_extend_tests,"},{"line_number":564,"context_line":"        \"Share extend tests are disabled.\")"},{"line_number":565,"context_line":"    def test_extend_share(self):"},{"line_number":566,"context_line":"        share \u003d self.create_share(size\u003dCONF.share.share_size, cleanup_in_class\u003dFalse)"},{"line_number":567,"context_line":"        new_size \u003d int(share[\u0027size\u0027]) + 1"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"        # extend share and wait for active status"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_55a11793","line":566,"range":{"start_line":566,"start_character":34,"end_line":566,"end_character":60},"in_reply_to":"3aaa91ec_1199837c","updated":"2016-06-26 22:19:32.000000000","message":"+1","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"34204941145054bf34a2879cce11dd1b54a88ce5","unresolved":false,"context_lines":[{"line_number":563,"context_line":"        CONF.share.run_extend_tests,"},{"line_number":564,"context_line":"        \"Share extend tests are disabled.\")"},{"line_number":565,"context_line":"    def test_extend_share(self):"},{"line_number":566,"context_line":"        share \u003d self.create_share(size\u003dCONF.share.share_size, cleanup_in_class\u003dFalse)"},{"line_number":567,"context_line":"        new_size \u003d int(share[\u0027size\u0027]) + 1"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"        # extend share and wait for active status"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_ac8a4618","line":566,"range":{"start_line":566,"start_character":77,"end_line":566,"end_character":85},"in_reply_to":"3aaa91ec_319abf6e","updated":"2016-06-28 19:47:30.000000000","message":"Done","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":19144,"name":"José Mello","email":"jose.eduardo.jr@gmail.com","username":"jose-eduardo-jr"},"change_message_id":"ca2e032a0ea9f4bfe9a2a0dd47922ed42f14e4e4","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        # create share"},{"line_number":616,"context_line":"        cls.share_name \u003d data_utils.rand_name(\"tempest-share-name\")"},{"line_number":617,"context_line":"        cls.share_desc \u003d data_utils.rand_name(\"tempest-share-description\")"},{"line_number":618,"context_line":"        cls.share_size \u003d CONF.share.share_size"},{"line_number":619,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":620,"context_line":"            name\u003dcls.share_name, description\u003dcls.share_desc,"},{"line_number":621,"context_line":"            size\u003dcls.share_size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_bbf5f0ed","line":618,"range":{"start_line":618,"start_character":8,"end_line":618,"end_character":46},"updated":"2016-06-24 17:55:09.000000000","message":"what happens of config is not set ?","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"34204941145054bf34a2879cce11dd1b54a88ce5","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        # create share"},{"line_number":616,"context_line":"        cls.share_name \u003d data_utils.rand_name(\"tempest-share-name\")"},{"line_number":617,"context_line":"        cls.share_desc \u003d data_utils.rand_name(\"tempest-share-description\")"},{"line_number":618,"context_line":"        cls.share_size \u003d CONF.share.share_size"},{"line_number":619,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":620,"context_line":"            name\u003dcls.share_name, description\u003dcls.share_desc,"},{"line_number":621,"context_line":"            size\u003dcls.share_size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_ec844e0c","line":618,"range":{"start_line":618,"start_character":8,"end_line":618,"end_character":46},"in_reply_to":"3aaa91ec_bbf5f0ed","updated":"2016-06-28 19:47:30.000000000","message":"Done","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f92fb13de945f962b191bde9ea31d6db6b4ef7a5","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            self.share_desc, six.text_type(share[\"description\"]), msg)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        msg \u003d \"Expected size: \u0027%s\u0027, actual size: \u0027%s\u0027\" % ("},{"line_number":119,"context_line":"            str(CONF.share.share_size), share[\"size\"])"},{"line_number":120,"context_line":"        self.assertEqual(CONF.share.share_size, int(share[\"size\"]), msg)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_0b852058","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":15},"updated":"2016-06-29 11:38:09.000000000","message":"Why do you translate it to string explicitly? You can use integer for substitution too.","commit_id":"4d1d3d602a04847364cf58f5bc3087e532f41b07"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"547981b998b5fdca03b52386cf83bd6d249df0c9","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            self.share_desc, six.text_type(share[\"description\"]), msg)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        msg \u003d \"Expected size: \u0027%s\u0027, actual size: \u0027%s\u0027\" % ("},{"line_number":119,"context_line":"            str(CONF.share.share_size), share[\"size\"])"},{"line_number":120,"context_line":"        self.assertEqual(CONF.share.share_size, int(share[\"size\"]), msg)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_02569e29","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":15},"in_reply_to":"3aaa91ec_0b852058","updated":"2016-06-29 12:46:13.000000000","message":"Done","commit_id":"4d1d3d602a04847364cf58f5bc3087e532f41b07"}],"manila_tempest_tests/tests/api/test_shares_actions_negative.py":[{"author":{"_account_id":19144,"name":"José Mello","email":"jose.eduardo.jr@gmail.com","username":"jose-eduardo-jr"},"change_message_id":"ca2e032a0ea9f4bfe9a2a0dd47922ed42f14e4e4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(SharesActionsNegativeTest, cls).resource_setup()"},{"line_number":30,"context_line":"        cls.admin_client \u003d cls.admin_shares_v2_client"},{"line_number":31,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":32,"context_line":"            size\u003dCONF.share.share_size,"},{"line_number":33,"context_line":"        )"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_e92335bb","line":32,"range":{"start_line":32,"start_character":12,"end_line":32,"end_character":39},"updated":"2016-06-24 17:55:09.000000000","message":"What happens if config is not set ?","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"34204941145054bf34a2879cce11dd1b54a88ce5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(SharesActionsNegativeTest, cls).resource_setup()"},{"line_number":30,"context_line":"        cls.admin_client \u003d cls.admin_shares_v2_client"},{"line_number":31,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":32,"context_line":"            size\u003dCONF.share.share_size,"},{"line_number":33,"context_line":"        )"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_8c766a3c","line":32,"range":{"start_line":32,"start_character":12,"end_line":32,"end_character":39},"in_reply_to":"3aaa91ec_e92335bb","updated":"2016-06-28 19:47:30.000000000","message":"Done","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"a3dbee10f302a6e5bc889f4cdfd98b1ef8fded72","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        CONF.share.run_extend_tests,"},{"line_number":82,"context_line":"        \"Share extend tests are disabled.\")"},{"line_number":83,"context_line":"    def test_share_extend_with_invalid_share_state(self):"},{"line_number":84,"context_line":"        share \u003d self.create_share(size\u003dCONF.share.share_size, cleanup_in_class\u003dFalse)"},{"line_number":85,"context_line":"        new_size \u003d int(share[\u0027size\u0027]) + 1"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # set \"error\" state"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_114fc337","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":85},"updated":"2016-06-24 18:39:33.000000000","message":"line length should not go beyond 79 characters","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"34204941145054bf34a2879cce11dd1b54a88ce5","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        CONF.share.run_extend_tests,"},{"line_number":82,"context_line":"        \"Share extend tests are disabled.\")"},{"line_number":83,"context_line":"    def test_share_extend_with_invalid_share_state(self):"},{"line_number":84,"context_line":"        share \u003d self.create_share(size\u003dCONF.share.share_size, cleanup_in_class\u003dFalse)"},{"line_number":85,"context_line":"        new_size \u003d int(share[\u0027size\u0027]) + 1"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # set \"error\" state"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_6c717e44","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":85},"in_reply_to":"3aaa91ec_114fc337","updated":"2016-06-28 19:47:30.000000000","message":"Done","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"}],"manila_tempest_tests/tests/api/test_shares_negative.py":[{"author":{"_account_id":19144,"name":"José Mello","email":"jose.eduardo.jr@gmail.com","username":"jose-eduardo-jr"},"change_message_id":"ca2e032a0ea9f4bfe9a2a0dd47922ed42f14e4e4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":32,"context_line":"            name\u003d\u0027public_share\u0027,"},{"line_number":33,"context_line":"            description\u003d\u0027public_share_desc\u0027,"},{"line_number":34,"context_line":"            size\u003dCONF.share.share_size,"},{"line_number":35,"context_line":"            is_public\u003dTrue,"},{"line_number":36,"context_line":"            metadata\u003d{\u0027key\u0027: \u0027value\u0027}"},{"line_number":37,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_db40bc09","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":39},"updated":"2016-06-24 17:55:09.000000000","message":"what happens of config is not set ?","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"34204941145054bf34a2879cce11dd1b54a88ce5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":32,"context_line":"            name\u003d\u0027public_share\u0027,"},{"line_number":33,"context_line":"            description\u003d\u0027public_share_desc\u0027,"},{"line_number":34,"context_line":"            size\u003dCONF.share.share_size,"},{"line_number":35,"context_line":"            is_public\u003dTrue,"},{"line_number":36,"context_line":"            metadata\u003d{\u0027key\u0027: \u0027value\u0027}"},{"line_number":37,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_4ca3e29e","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":39},"in_reply_to":"3aaa91ec_db40bc09","updated":"2016-06-28 19:47:30.000000000","message":"Done","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":19144,"name":"José Mello","email":"jose.eduardo.jr@gmail.com","username":"jose-eduardo-jr"},"change_message_id":"ca2e032a0ea9f4bfe9a2a0dd47922ed42f14e4e4","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        # try create share from snapshot with less size"},{"line_number":82,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":83,"context_line":"                          self.create_share,"},{"line_number":84,"context_line":"                          size\u003dCONF.share.share_size, snapshot_id\u003dsnap[\"id\"],"},{"line_number":85,"context_line":"                          cleanup_in_class\u003dFalse)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_bb5a10f0","line":84,"range":{"start_line":84,"start_character":26,"end_line":84,"end_character":52},"updated":"2016-06-24 17:55:09.000000000","message":"what happens of config is not set ?","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"34204941145054bf34a2879cce11dd1b54a88ce5","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        # try create share from snapshot with less size"},{"line_number":82,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":83,"context_line":"                          self.create_share,"},{"line_number":84,"context_line":"                          size\u003dCONF.share.share_size, snapshot_id\u003dsnap[\"id\"],"},{"line_number":85,"context_line":"                          cleanup_in_class\u003dFalse)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_8cadca8a","line":84,"range":{"start_line":84,"start_character":26,"end_line":84,"end_character":52},"in_reply_to":"3aaa91ec_bb5a10f0","updated":"2016-06-28 19:47:30.000000000","message":"Done","commit_id":"9a81b2c73a0adad71c57ce1d9993871e92a822b9"}]}
