)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c2458021d6ebd8865bd905bd77f2bcf85eb07f9f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Prerequisites:"},{"line_number":12,"context_line":"- share being managed should exist."},{"line_number":13,"context_line":"- share being managed should not be part of any replication relations."},{"line_number":14,"context_line":"- share being managed should not have redefined mountpoint."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Details:"},{"line_number":17,"context_line":"- share being managed will be renamed by share driver based on taken ID."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_92fd5f70","line":14,"range":{"start_line":14,"start_character":38,"end_line":14,"end_character":47},"updated":"2016-06-25 15:53:00.000000000","message":"predefined?","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b9d620a711e88b03111ee5f82305638ba48defbf","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Prerequisites:"},{"line_number":12,"context_line":"- share being managed should exist."},{"line_number":13,"context_line":"- share being managed should not be part of any replication relations."},{"line_number":14,"context_line":"- share being managed should not have redefined mountpoint."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Details:"},{"line_number":17,"context_line":"- share being managed will be renamed by share driver based on taken ID."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_18b991cc","line":14,"range":{"start_line":14,"start_character":38,"end_line":14,"end_character":47},"in_reply_to":"3aaa91ec_92fd5f70","updated":"2016-06-25 17:00:39.000000000","message":"Redefined. Each dataset has \"mountpoint\" attribute. And it should not be redefined.","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c2458021d6ebd8865bd905bd77f2bcf85eb07f9f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  used space (2,4 -\u003e 3, 3.6 -\u003e 4)."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Implements blueprint zfsonlinux-manage-share"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"TODO:"},{"line_number":26,"context_line":"- add unit tests."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_d2fb6777","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":0},"updated":"2016-06-25 15:53:00.000000000","message":"DocImpact please..","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"00a5461169fec86e490430eee5993ccfb04c0ca5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  used space (2,4 -\u003e 3, 3.6 -\u003e 4)."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Implements blueprint zfsonlinux-manage-share"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"TODO:"},{"line_number":26,"context_line":"- add unit tests."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_67de1bdb","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":0},"in_reply_to":"3aaa91ec_d2fb6777","updated":"2016-07-01 12:55:55.000000000","message":"Done","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"}],"manila/share/drivers/zfsonlinux/driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c2458021d6ebd8865bd905bd77f2bcf85eb07f9f","unresolved":false,"context_lines":[{"line_number":446,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":447,"context_line":"        \"\"\"Is called to remove a share.\"\"\""},{"line_number":448,"context_line":"        pool_name \u003d self.private_storage.get(share[\u0027id\u0027], \u0027pool_name\u0027)"},{"line_number":449,"context_line":"        pool_name \u003d pool_name or share_utils.extract_host("},{"line_number":450,"context_line":"            share[\"host\"], level\u003d\"pool\")"},{"line_number":451,"context_line":"        dataset_name \u003d self.private_storage.get(share[\u0027id\u0027], \u0027dataset_name\u0027)"},{"line_number":452,"context_line":"        if not dataset_name:"},{"line_number":453,"context_line":"            dataset_name \u003d self._get_dataset_name(share)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_7237134d","line":450,"range":{"start_line":449,"start_character":8,"end_line":450,"end_character":40},"updated":"2016-06-25 15:53:00.000000000","message":"pool_name is always set on line 448..","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2b4efd29d8aefc53ed22b2639489cb40af5000e3","unresolved":false,"context_lines":[{"line_number":446,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":447,"context_line":"        \"\"\"Is called to remove a share.\"\"\""},{"line_number":448,"context_line":"        pool_name \u003d self.private_storage.get(share[\u0027id\u0027], \u0027pool_name\u0027)"},{"line_number":449,"context_line":"        pool_name \u003d pool_name or share_utils.extract_host("},{"line_number":450,"context_line":"            share[\"host\"], level\u003d\"pool\")"},{"line_number":451,"context_line":"        dataset_name \u003d self.private_storage.get(share[\u0027id\u0027], \u0027dataset_name\u0027)"},{"line_number":452,"context_line":"        if not dataset_name:"},{"line_number":453,"context_line":"            dataset_name \u003d self._get_dataset_name(share)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_38372d4e","line":450,"range":{"start_line":449,"start_character":8,"end_line":450,"end_character":40},"in_reply_to":"3aaa91ec_1892314c","updated":"2016-06-25 17:09:55.000000000","message":"argh. thought private_storage is a python dict; haven\u0027t woken up yet.","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b9d620a711e88b03111ee5f82305638ba48defbf","unresolved":false,"context_lines":[{"line_number":446,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":447,"context_line":"        \"\"\"Is called to remove a share.\"\"\""},{"line_number":448,"context_line":"        pool_name \u003d self.private_storage.get(share[\u0027id\u0027], \u0027pool_name\u0027)"},{"line_number":449,"context_line":"        pool_name \u003d pool_name or share_utils.extract_host("},{"line_number":450,"context_line":"            share[\"host\"], level\u003d\"pool\")"},{"line_number":451,"context_line":"        dataset_name \u003d self.private_storage.get(share[\u0027id\u0027], \u0027dataset_name\u0027)"},{"line_number":452,"context_line":"        if not dataset_name:"},{"line_number":453,"context_line":"            dataset_name \u003d self._get_dataset_name(share)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_1892314c","line":450,"range":{"start_line":449,"start_character":8,"end_line":450,"end_character":40},"in_reply_to":"3aaa91ec_7237134d","updated":"2016-06-25 17:00:39.000000000","message":"It is not in case of errors.","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c2458021d6ebd8865bd905bd77f2bcf85eb07f9f","unresolved":false,"context_lines":[{"line_number":641,"context_line":"        :param driver_options: Empty dict or dict with \u0027size\u0027 option."},{"line_number":642,"context_line":"        :return: dict with share size and its export locations."},{"line_number":643,"context_line":"        \"\"\""},{"line_number":644,"context_line":"        old_export_location \u003d share[\"export_locations\"][0][\"path\"]"},{"line_number":645,"context_line":"        old_dataset_name \u003d old_export_location.split(\":/\")[-1]"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        scheduled_pool_name \u003d share_utils.extract_host("}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_3218ebd2","line":644,"range":{"start_line":644,"start_character":30,"end_line":644,"end_character":66},"updated":"2016-06-25 15:53:00.000000000","message":"share[\u0027export_location\u0027]","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b9d620a711e88b03111ee5f82305638ba48defbf","unresolved":false,"context_lines":[{"line_number":641,"context_line":"        :param driver_options: Empty dict or dict with \u0027size\u0027 option."},{"line_number":642,"context_line":"        :return: dict with share size and its export locations."},{"line_number":643,"context_line":"        \"\"\""},{"line_number":644,"context_line":"        old_export_location \u003d share[\"export_locations\"][0][\"path\"]"},{"line_number":645,"context_line":"        old_dataset_name \u003d old_export_location.split(\":/\")[-1]"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        scheduled_pool_name \u003d share_utils.extract_host("}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_5898396a","line":644,"range":{"start_line":644,"start_character":30,"end_line":644,"end_character":66},"in_reply_to":"3aaa91ec_3218ebd2","updated":"2016-06-25 17:00:39.000000000","message":"Everything is correct. Your case is deprecated and should have been removed.","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2b4efd29d8aefc53ed22b2639489cb40af5000e3","unresolved":false,"context_lines":[{"line_number":641,"context_line":"        :param driver_options: Empty dict or dict with \u0027size\u0027 option."},{"line_number":642,"context_line":"        :return: dict with share size and its export locations."},{"line_number":643,"context_line":"        \"\"\""},{"line_number":644,"context_line":"        old_export_location \u003d share[\"export_locations\"][0][\"path\"]"},{"line_number":645,"context_line":"        old_dataset_name \u003d old_export_location.split(\":/\")[-1]"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        scheduled_pool_name \u003d share_utils.extract_host("}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_b8ecbdbb","line":644,"range":{"start_line":644,"start_character":30,"end_line":644,"end_character":66},"in_reply_to":"3aaa91ec_5898396a","updated":"2016-06-25 17:09:55.000000000","message":"er, when?\nhttps://github.com/openstack/manila/blob/master/manila/db/sqlalchemy/models.py#L355","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd0c812a79808eca8436e566b77f33ebce592d93","unresolved":false,"context_lines":[{"line_number":641,"context_line":"        :param driver_options: Empty dict or dict with \u0027size\u0027 option."},{"line_number":642,"context_line":"        :return: dict with share size and its export locations."},{"line_number":643,"context_line":"        \"\"\""},{"line_number":644,"context_line":"        old_export_location \u003d share[\"export_locations\"][0][\"path\"]"},{"line_number":645,"context_line":"        old_dataset_name \u003d old_export_location.split(\":/\")[-1]"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        scheduled_pool_name \u003d share_utils.extract_host("}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_fb091f96","line":644,"range":{"start_line":644,"start_character":30,"end_line":644,"end_character":66},"in_reply_to":"3aaa91ec_b8ecbdbb","updated":"2016-06-25 19:54:47.000000000","message":"It is compatibility code.","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c2458021d6ebd8865bd905bd77f2bcf85eb07f9f","unresolved":false,"context_lines":[{"line_number":656,"context_line":"            consumed_space \u003d self.get_zfs_option(old_dataset_name, \"used\")"},{"line_number":657,"context_line":"            consumed_space \u003d utils.translate_string_size_to_float("},{"line_number":658,"context_line":"                consumed_space)"},{"line_number":659,"context_line":"            quota \u003d int(consumed_space) + 1"},{"line_number":660,"context_line":"        share[\"size\"] \u003d int(quota)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        # Save dataset-specific data in private storage"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_9259df90","line":659,"range":{"start_line":659,"start_character":20,"end_line":659,"end_character":43},"updated":"2016-06-25 15:53:00.000000000","message":"math.ceil(consumed_space), else you may be giving them an extra GB","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2b4efd29d8aefc53ed22b2639489cb40af5000e3","unresolved":false,"context_lines":[{"line_number":656,"context_line":"            consumed_space \u003d self.get_zfs_option(old_dataset_name, \"used\")"},{"line_number":657,"context_line":"            consumed_space \u003d utils.translate_string_size_to_float("},{"line_number":658,"context_line":"                consumed_space)"},{"line_number":659,"context_line":"            quota \u003d int(consumed_space) + 1"},{"line_number":660,"context_line":"        share[\"size\"] \u003d int(quota)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        # Save dataset-specific data in private storage"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_f8300558","line":659,"range":{"start_line":659,"start_character":20,"end_line":659,"end_character":43},"in_reply_to":"3aaa91ec_389bad67","updated":"2016-06-25 17:09:55.000000000","message":"What specific use case is that?\nWhat if your consumed space is 1048576","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b9d620a711e88b03111ee5f82305638ba48defbf","unresolved":false,"context_lines":[{"line_number":656,"context_line":"            consumed_space \u003d self.get_zfs_option(old_dataset_name, \"used\")"},{"line_number":657,"context_line":"            consumed_space \u003d utils.translate_string_size_to_float("},{"line_number":658,"context_line":"                consumed_space)"},{"line_number":659,"context_line":"            quota \u003d int(consumed_space) + 1"},{"line_number":660,"context_line":"        share[\"size\"] \u003d int(quota)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        # Save dataset-specific data in private storage"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_389bad67","line":659,"range":{"start_line":659,"start_character":20,"end_line":659,"end_character":43},"in_reply_to":"3aaa91ec_9259df90","updated":"2016-06-25 17:00:39.000000000","message":"It solves the use case, why should I change it?","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd0c812a79808eca8436e566b77f33ebce592d93","unresolved":false,"context_lines":[{"line_number":656,"context_line":"            consumed_space \u003d self.get_zfs_option(old_dataset_name, \"used\")"},{"line_number":657,"context_line":"            consumed_space \u003d utils.translate_string_size_to_float("},{"line_number":658,"context_line":"                consumed_space)"},{"line_number":659,"context_line":"            quota \u003d int(consumed_space) + 1"},{"line_number":660,"context_line":"        share[\"size\"] \u003d int(quota)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        # Save dataset-specific data in private storage"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_dbf1c396","line":659,"range":{"start_line":659,"start_character":20,"end_line":659,"end_character":43},"in_reply_to":"3aaa91ec_f8300558","updated":"2016-06-25 19:54:47.000000000","message":"The only thing I need to do is translate float to integer. Plus round it up adding 1. It is solved here.\nSize of value does not matter at all. You just assumed usage of 1 petabyte. If it is true, we say ok, that\u0027s all.","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d62e09010cdf552a9f02d5ced652d61655314bc5","unresolved":false,"context_lines":[{"line_number":657,"context_line":"            consumed_space \u003d utils.translate_string_size_to_float("},{"line_number":658,"context_line":"                consumed_space)"},{"line_number":659,"context_line":"            quota \u003d int(consumed_space) + 1"},{"line_number":660,"context_line":"        share[\"size\"] \u003d int(quota)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        # Save dataset-specific data in private storage"},{"line_number":663,"context_line":"        options \u003d self._get_dataset_creation_options(share, is_readonly\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_9e61e907","line":660,"range":{"start_line":660,"start_character":24,"end_line":660,"end_character":34},"updated":"2016-06-26 00:38:11.000000000","message":"In line 654, the quota value could equal to \u0027None\u0027.But int() argument must be a string or a number, not \u0027NoneType\u0027.","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"98fae86361340bdaecee859c8f7c6358a5dadb34","unresolved":false,"context_lines":[{"line_number":657,"context_line":"            consumed_space \u003d utils.translate_string_size_to_float("},{"line_number":658,"context_line":"                consumed_space)"},{"line_number":659,"context_line":"            quota \u003d int(consumed_space) + 1"},{"line_number":660,"context_line":"        share[\"size\"] \u003d int(quota)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        # Save dataset-specific data in private storage"},{"line_number":663,"context_line":"        options \u003d self._get_dataset_creation_options(share, is_readonly\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_ec196723","line":660,"range":{"start_line":660,"start_character":24,"end_line":660,"end_character":34},"in_reply_to":"3aaa91ec_9e61e907","updated":"2016-06-26 05:32:43.000000000","message":"Lines 655-659.","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c2458021d6ebd8865bd905bd77f2bcf85eb07f9f","unresolved":false,"context_lines":[{"line_number":676,"context_line":"        )"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        # Perform checks on requested dataset"},{"line_number":679,"context_line":"        if actual_pool_name !\u003d scheduled_pool_name:"},{"line_number":680,"context_line":"            raise exception.ZFSonLinuxException("},{"line_number":681,"context_line":"                _(\"Cannot manage share \u0027%(share_id)s\u0027 \""},{"line_number":682,"context_line":"                  \"(share_instance \u0027%(si_id)s\u0027), because scheduled \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_b2005b35","line":679,"range":{"start_line":679,"start_character":0,"end_line":679,"end_character":51},"updated":"2016-06-25 15:53:00.000000000","message":"Shouldn\u0027t this check be done before updating private_storage?","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd0c812a79808eca8436e566b77f33ebce592d93","unresolved":false,"context_lines":[{"line_number":676,"context_line":"        )"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        # Perform checks on requested dataset"},{"line_number":679,"context_line":"        if actual_pool_name !\u003d scheduled_pool_name:"},{"line_number":680,"context_line":"            raise exception.ZFSonLinuxException("},{"line_number":681,"context_line":"                _(\"Cannot manage share \u0027%(share_id)s\u0027 \""},{"line_number":682,"context_line":"                  \"(share_instance \u0027%(si_id)s\u0027), because scheduled \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_9b429bac","line":679,"range":{"start_line":679,"start_character":0,"end_line":679,"end_character":51},"in_reply_to":"3aaa91ec_783d352a","updated":"2016-06-25 19:54:47.000000000","message":"This information is used all over the driver. I write it ASAP. It is intentional. And will not be changed.","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2b4efd29d8aefc53ed22b2639489cb40af5000e3","unresolved":false,"context_lines":[{"line_number":676,"context_line":"        )"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        # Perform checks on requested dataset"},{"line_number":679,"context_line":"        if actual_pool_name !\u003d scheduled_pool_name:"},{"line_number":680,"context_line":"            raise exception.ZFSonLinuxException("},{"line_number":681,"context_line":"                _(\"Cannot manage share \u0027%(share_id)s\u0027 \""},{"line_number":682,"context_line":"                  \"(share_instance \u0027%(si_id)s\u0027), because scheduled \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_783d352a","line":679,"range":{"start_line":679,"start_character":0,"end_line":679,"end_character":51},"in_reply_to":"3aaa91ec_78a1b593","updated":"2016-06-25 17:09:55.000000000","message":"Yes, i still don\u0027t think you should write it into the DB when you\u0027re going to throw an error after; what\u0027s wrong with that? keep lines 449,450..","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b9d620a711e88b03111ee5f82305638ba48defbf","unresolved":false,"context_lines":[{"line_number":676,"context_line":"        )"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        # Perform checks on requested dataset"},{"line_number":679,"context_line":"        if actual_pool_name !\u003d scheduled_pool_name:"},{"line_number":680,"context_line":"            raise exception.ZFSonLinuxException("},{"line_number":681,"context_line":"                _(\"Cannot manage share \u0027%(share_id)s\u0027 \""},{"line_number":682,"context_line":"                  \"(share_instance \u0027%(si_id)s\u0027), because scheduled \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_78a1b593","line":679,"range":{"start_line":679,"start_character":0,"end_line":679,"end_character":51},"in_reply_to":"3aaa91ec_b2005b35","updated":"2016-06-25 17:00:39.000000000","message":"So, you propose me to perform check before writing data to DB and in False case raise exception not saving data. Then you propose me remove lines 449-450. Nice, very nice.","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d62e09010cdf552a9f02d5ced652d61655314bc5","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        else:"},{"line_number":695,"context_line":"            raise exception.ZFSonLinuxException("},{"line_number":696,"context_line":"                _(\"Dataset \u0027%(dataset)s\u0027 not found in zpool \u0027%(zpool)s\u0027.\") % {"},{"line_number":697,"context_line":"                    \"share_id\": share[\"share_id\"],"},{"line_number":698,"context_line":"                    \"si_id\": share[\"id\"],"},{"line_number":699,"context_line":"                    \"dataset\": old_dataset_name,"},{"line_number":700,"context_line":"                    \"zpool\": actual_pool_name})"},{"line_number":701,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_be7b05bd","line":698,"range":{"start_line":697,"start_character":19,"end_line":698,"end_character":41},"updated":"2016-06-26 00:38:11.000000000","message":"The \"share_id\" and \"si_id\" are not exist in message.","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"00a5461169fec86e490430eee5993ccfb04c0ca5","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        else:"},{"line_number":695,"context_line":"            raise exception.ZFSonLinuxException("},{"line_number":696,"context_line":"                _(\"Dataset \u0027%(dataset)s\u0027 not found in zpool \u0027%(zpool)s\u0027.\") % {"},{"line_number":697,"context_line":"                    \"share_id\": share[\"share_id\"],"},{"line_number":698,"context_line":"                    \"si_id\": share[\"id\"],"},{"line_number":699,"context_line":"                    \"dataset\": old_dataset_name,"},{"line_number":700,"context_line":"                    \"zpool\": actual_pool_name})"},{"line_number":701,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_c7642f23","line":698,"range":{"start_line":697,"start_character":19,"end_line":698,"end_character":41},"in_reply_to":"3aaa91ec_4cdfdb39","updated":"2016-07-01 12:55:55.000000000","message":"Done","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"98fae86361340bdaecee859c8f7c6358a5dadb34","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        else:"},{"line_number":695,"context_line":"            raise exception.ZFSonLinuxException("},{"line_number":696,"context_line":"                _(\"Dataset \u0027%(dataset)s\u0027 not found in zpool \u0027%(zpool)s\u0027.\") % {"},{"line_number":697,"context_line":"                    \"share_id\": share[\"share_id\"],"},{"line_number":698,"context_line":"                    \"si_id\": share[\"id\"],"},{"line_number":699,"context_line":"                    \"dataset\": old_dataset_name,"},{"line_number":700,"context_line":"                    \"zpool\": actual_pool_name})"},{"line_number":701,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_4cdfdb39","line":698,"range":{"start_line":697,"start_character":19,"end_line":698,"end_character":41},"in_reply_to":"3aaa91ec_be7b05bd","updated":"2016-06-26 05:32:43.000000000","message":"Will extend message with these data as in above exception message.","commit_id":"ba44b7fa8d1cedccc88b5237692785b081f1f8e2"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cb80f7c2a573b5ca9f24543868c311cadd93f038","unresolved":false,"context_lines":[{"line_number":644,"context_line":"        old_export_location \u003d share[\"export_locations\"][0][\"path\"]"},{"line_number":645,"context_line":"        old_dataset_name \u003d old_export_location.split(\":/\")[-1]"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        scheduled_pool_name \u003d share_utils.extract_host("},{"line_number":648,"context_line":"            share[\"host\"], level\u003d\"pool\")"},{"line_number":649,"context_line":"        actual_pool_name \u003d old_dataset_name.split(\"/\")[0]"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"        new_dataset_name \u003d self._get_dataset_name(share)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_522681ce","line":648,"range":{"start_line":647,"start_character":8,"end_line":648,"end_character":40},"updated":"2016-07-26 17:28:02.000000000","message":"why not self.pool_name?","commit_id":"f284db4e07209b814ea4dcef954490117da50c7f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3135e0d5293a0a68927c69862d27025695dfcc35","unresolved":false,"context_lines":[{"line_number":644,"context_line":"        old_export_location \u003d share[\"export_locations\"][0][\"path\"]"},{"line_number":645,"context_line":"        old_dataset_name \u003d old_export_location.split(\":/\")[-1]"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        scheduled_pool_name \u003d share_utils.extract_host("},{"line_number":648,"context_line":"            share[\"host\"], level\u003d\"pool\")"},{"line_number":649,"context_line":"        actual_pool_name \u003d old_dataset_name.split(\"/\")[0]"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"        new_dataset_name \u003d self._get_dataset_name(share)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_8daa986f","line":648,"range":{"start_line":647,"start_character":8,"end_line":648,"end_character":40},"in_reply_to":"dada55a8_522681ce","updated":"2016-07-26 17:36:19.000000000","message":"\"self.pool_name\"? First of all, there is no such attr in instance of this driver. Second, this driver supports any amount of pools and such attr just could not exist.","commit_id":"f284db4e07209b814ea4dcef954490117da50c7f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"0e9e8509ed5dc5b48824dee5ea8d5b03d45b885c","unresolved":false,"context_lines":[{"line_number":684,"context_line":"                    \"share_id\": share[\"share_id\"],"},{"line_number":685,"context_line":"                    \"si_id\": share[\"id\"],"},{"line_number":686,"context_line":"                    \"sch\": scheduled_pool_name,"},{"line_number":687,"context_line":"                    \"actual\": actual_pool_name})"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        out, err \u003d self.zfs(\"list\", \"-r\", actual_pool_name)"},{"line_number":690,"context_line":"        data \u003d self.parse_zfs_answer(out)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_87aa1918","line":687,"updated":"2016-07-15 17:34:55.000000000","message":"exception.ZFSonLinuxException(msg\u003d_(…..))\n\nhttps://github.com/openstack/manila/blob/master/manila/exception.py#L690","commit_id":"f284db4e07209b814ea4dcef954490117da50c7f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cb80f7c2a573b5ca9f24543868c311cadd93f038","unresolved":false,"context_lines":[{"line_number":675,"context_line":"            }"},{"line_number":676,"context_line":"        )"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        # Perform checks on requested dataset"},{"line_number":679,"context_line":"        if actual_pool_name !\u003d scheduled_pool_name:"},{"line_number":680,"context_line":"            raise exception.ZFSonLinuxException("},{"line_number":681,"context_line":"                _(\"Cannot manage share \u0027%(share_id)s\u0027 \""},{"line_number":682,"context_line":"                  \"(share_instance \u0027%(si_id)s\u0027), because scheduled \""},{"line_number":683,"context_line":"                  \"pool \u0027%(sch)s\u0027 and actual \u0027%(actual)s\u0027 differ.\") % {"},{"line_number":684,"context_line":"                    \"share_id\": share[\"share_id\"],"},{"line_number":685,"context_line":"                    \"si_id\": share[\"id\"],"},{"line_number":686,"context_line":"                    \"sch\": scheduled_pool_name,"},{"line_number":687,"context_line":"                    \"actual\": actual_pool_name})"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        out, err \u003d self.zfs(\"list\", \"-r\", actual_pool_name)"},{"line_number":690,"context_line":"        data \u003d self.parse_zfs_answer(out)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_0d1d0862","line":687,"range":{"start_line":678,"start_character":8,"end_line":687,"end_character":48},"updated":"2016-07-26 17:28:02.000000000","message":"why do you this after updating private storage? shouldn\u0027t this be done first?","commit_id":"f284db4e07209b814ea4dcef954490117da50c7f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3135e0d5293a0a68927c69862d27025695dfcc35","unresolved":false,"context_lines":[{"line_number":675,"context_line":"            }"},{"line_number":676,"context_line":"        )"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        # Perform checks on requested dataset"},{"line_number":679,"context_line":"        if actual_pool_name !\u003d scheduled_pool_name:"},{"line_number":680,"context_line":"            raise exception.ZFSonLinuxException("},{"line_number":681,"context_line":"                _(\"Cannot manage share \u0027%(share_id)s\u0027 \""},{"line_number":682,"context_line":"                  \"(share_instance \u0027%(si_id)s\u0027), because scheduled \""},{"line_number":683,"context_line":"                  \"pool \u0027%(sch)s\u0027 and actual \u0027%(actual)s\u0027 differ.\") % {"},{"line_number":684,"context_line":"                    \"share_id\": share[\"share_id\"],"},{"line_number":685,"context_line":"                    \"si_id\": share[\"id\"],"},{"line_number":686,"context_line":"                    \"sch\": scheduled_pool_name,"},{"line_number":687,"context_line":"                    \"actual\": actual_pool_name})"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        out, err \u003d self.zfs(\"list\", \"-r\", actual_pool_name)"},{"line_number":690,"context_line":"        data \u003d self.parse_zfs_answer(out)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_ed42340e","line":687,"range":{"start_line":678,"start_character":8,"end_line":687,"end_character":48},"in_reply_to":"dada55a8_0d1d0862","updated":"2016-07-26 17:36:19.000000000","message":"No, everything is intended to be so. Data is written ASAP. Because it is used in other places and we should not fail with weird errors when \"manage\" operation failed for some reason.","commit_id":"f284db4e07209b814ea4dcef954490117da50c7f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"026fafc1b5d54f6ea6b10c336beda85780fbf89b","unresolved":false,"context_lines":[{"line_number":684,"context_line":"                    \"share_id\": share[\"share_id\"],"},{"line_number":685,"context_line":"                    \"si_id\": share[\"id\"],"},{"line_number":686,"context_line":"                    \"sch\": scheduled_pool_name,"},{"line_number":687,"context_line":"                    \"actual\": actual_pool_name})"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        out, err \u003d self.zfs(\"list\", \"-r\", actual_pool_name)"},{"line_number":690,"context_line":"        data \u003d self.parse_zfs_answer(out)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_f77e8719","line":687,"in_reply_to":"dada55a8_602266bb","updated":"2016-07-26 16:54:44.000000000","message":"Alright.  So it works the same.  It\u0027s still better to set \"msg\u003d\" directly but I won\u0027t insist now since it works.","commit_id":"f284db4e07209b814ea4dcef954490117da50c7f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"10b763b107e05cab56a9654ae8e09b20aec73e42","unresolved":false,"context_lines":[{"line_number":684,"context_line":"                    \"share_id\": share[\"share_id\"],"},{"line_number":685,"context_line":"                    \"si_id\": share[\"id\"],"},{"line_number":686,"context_line":"                    \"sch\": scheduled_pool_name,"},{"line_number":687,"context_line":"                    \"actual\": actual_pool_name})"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        out, err \u003d self.zfs(\"list\", \"-r\", actual_pool_name)"},{"line_number":690,"context_line":"        data \u003d self.parse_zfs_answer(out)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_602266bb","line":687,"in_reply_to":"fad55976_87aa1918","updated":"2016-07-18 09:49:16.000000000","message":"Xing, do not use \"not fixed\" reference such as branch names when you give links to source code with line numbers. Use specific commits.\n\nAnd here is my answer: https://github.com/openstack/manila/blob/94e04c8d/manila/exception.py#L109","commit_id":"f284db4e07209b814ea4dcef954490117da50c7f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cb80f7c2a573b5ca9f24543868c311cadd93f038","unresolved":false,"context_lines":[{"line_number":692,"context_line":"            if datum[\"NAME\"] \u003d\u003d old_dataset_name:"},{"line_number":693,"context_line":"                break"},{"line_number":694,"context_line":"        else:"},{"line_number":695,"context_line":"            raise exception.ZFSonLinuxException("},{"line_number":696,"context_line":"                _(\"Cannot manage share \u0027%(share_id)s\u0027 \""},{"line_number":697,"context_line":"                  \"(share_instance \u0027%(si_id)s\u0027), because dataset \""},{"line_number":698,"context_line":"                  \"\u0027%(dataset)s\u0027 not found in zpool \u0027%(zpool)s\u0027.\") % {"},{"line_number":699,"context_line":"                    \"share_id\": share[\"share_id\"],"},{"line_number":700,"context_line":"                    \"si_id\": share[\"id\"],"},{"line_number":701,"context_line":"                    \"dataset\": old_dataset_name,"},{"line_number":702,"context_line":"                    \"zpool\": actual_pool_name})"},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"        # Rename dataset"},{"line_number":705,"context_line":"        out, err \u003d self.execute(\"sudo\", \"mount\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_ad52fc10","line":702,"range":{"start_line":695,"start_character":12,"end_line":702,"end_character":47},"updated":"2016-07-26 17:28:02.000000000","message":"same as above","commit_id":"f284db4e07209b814ea4dcef954490117da50c7f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"0e9e8509ed5dc5b48824dee5ea8d5b03d45b885c","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        out, err \u003d self.execute(\"sudo\", \"mount\")"},{"line_number":706,"context_line":"        if \"%s \" % old_dataset_name in out:"},{"line_number":707,"context_line":"            self.zfs_with_retry(\"umount\", \"-f\", old_dataset_name)"},{"line_number":708,"context_line":"            time.sleep(1)"},{"line_number":709,"context_line":"        self.zfs_with_retry(\"rename\", old_dataset_name, new_dataset_name)"},{"line_number":710,"context_line":"        self.zfs(\"mount\", new_dataset_name)"},{"line_number":711,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_4a13085d","line":708,"updated":"2016-07-15 17:34:55.000000000","message":"Why sleeping here in a fixed amount of time without checking any status to see if it is successful?","commit_id":"f284db4e07209b814ea4dcef954490117da50c7f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"026fafc1b5d54f6ea6b10c336beda85780fbf89b","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        out, err \u003d self.execute(\"sudo\", \"mount\")"},{"line_number":706,"context_line":"        if \"%s \" % old_dataset_name in out:"},{"line_number":707,"context_line":"            self.zfs_with_retry(\"umount\", \"-f\", old_dataset_name)"},{"line_number":708,"context_line":"            time.sleep(1)"},{"line_number":709,"context_line":"        self.zfs_with_retry(\"rename\", old_dataset_name, new_dataset_name)"},{"line_number":710,"context_line":"        self.zfs(\"mount\", new_dataset_name)"},{"line_number":711,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_97a62bbf","line":708,"in_reply_to":"dada55a8_6b6887bb","updated":"2016-07-26 16:54:44.000000000","message":"I\u0027d suggest you add a comment before the sleep call if you upload another patch.","commit_id":"f284db4e07209b814ea4dcef954490117da50c7f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"10b763b107e05cab56a9654ae8e09b20aec73e42","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        out, err \u003d self.execute(\"sudo\", \"mount\")"},{"line_number":706,"context_line":"        if \"%s \" % old_dataset_name in out:"},{"line_number":707,"context_line":"            self.zfs_with_retry(\"umount\", \"-f\", old_dataset_name)"},{"line_number":708,"context_line":"            time.sleep(1)"},{"line_number":709,"context_line":"        self.zfs_with_retry(\"rename\", old_dataset_name, new_dataset_name)"},{"line_number":710,"context_line":"        self.zfs(\"mount\", new_dataset_name)"},{"line_number":711,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_6b6887bb","line":708,"in_reply_to":"fad55976_4a13085d","updated":"2016-07-18 09:49:16.000000000","message":"Xing, previous line will return control only in case of success. Here we sleep\" enough time\" to get next command call ready to be executed.","commit_id":"f284db4e07209b814ea4dcef954490117da50c7f"}]}
