)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"90eebdae49f1f7a8cf4ee8500ac503b9e9136b8a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"using CephFSVolumeClient\u0027s updated authorize() interface."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The requisite support in Ceph was added with the following"},{"line_number":13,"context_line":"commits:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"SHA-1                                    | Ceph branch"},{"line_number":16,"context_line":"--------------------------------------------------------"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bacf61ea_8da450a6","line":13,"updated":"2016-08-05 11:31:42.000000000","message":"Does this mean that some specific version of Ceph must be used? Also the description below probably belongs to documentation.","commit_id":"c368b6aa3b82eba173d24fd1b3dd1df676a1fb1b"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"aac0bf371feac7256ae7931be28149efe7b2afe3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"using CephFSVolumeClient\u0027s updated authorize() interface."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The requisite support in Ceph was added with the following"},{"line_number":13,"context_line":"commits:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"SHA-1                                    | Ceph branch"},{"line_number":16,"context_line":"--------------------------------------------------------"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bacf61ea_8121b74f","line":13,"in_reply_to":"bacf61ea_0664bd1f","updated":"2016-08-05 12:41:56.000000000","message":"Ok, that makes sense.\nNow what happens to users who try this with older releases of Jewel? Will such request fail? Shouldn\u0027t there be some version check in place?","commit_id":"c368b6aa3b82eba173d24fd1b3dd1df676a1fb1b"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"5b8d16449ce18521872b6cab3505373e93d874cd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"using CephFSVolumeClient\u0027s updated authorize() interface."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The requisite support in Ceph was added with the following"},{"line_number":13,"context_line":"commits:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"SHA-1                                    | Ceph branch"},{"line_number":16,"context_line":"--------------------------------------------------------"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bacf61ea_57493d30","line":13,"in_reply_to":"bacf61ea_8121b74f","updated":"2016-08-05 13:18:27.000000000","message":"Yeah, you\u0027re right.\n\nAPI versioning in the ceph_volume_client (Ceph library used by Manila) was added in Jewel, but did not make it to the latest Jewel point release.\nhttps://github.com/ceph/ceph/pull/10453/commits/e8dd1eeec7ee2fd11a2985843825a3ec0f522b0c\n\nSince it\u0027s quite a young driver (introduced in Mitaka), and should\u0027ve been mostly used in POCs. I think it\u0027s OK to expect the Manila deployers to upgrade to a later Jewel point release once it\u0027s out, or expect the eager deployers to use gitbuilder Jewel packages as done by the manila-CephFS CI for now.","commit_id":"c368b6aa3b82eba173d24fd1b3dd1df676a1fb1b"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"851c2fbbce995ab53629456cfddfeb182e045f3b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"using CephFSVolumeClient\u0027s updated authorize() interface."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The requisite support in Ceph was added with the following"},{"line_number":13,"context_line":"commits:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"SHA-1                                    | Ceph branch"},{"line_number":16,"context_line":"--------------------------------------------------------"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bacf61ea_0664bd1f","line":13,"in_reply_to":"bacf61ea_8da450a6","updated":"2016-08-05 12:35:41.000000000","message":"The upstream CI uses packages built of latest Jewel branch Ceph which has the required support.\nhttps://github.com/openstack/devstack-plugin-ceph/commit/e5f8480179dcf4af69c944e666f5c55c62c175e9#diff-46836255794d1a173bb2dc5bffb36129R601\nhttp://gitbuilder.ceph.com/ceph-deb-trusty-x86_64-basic/ref/jewel/sha1\n\n\nIn the manila-CephFS docs, the manila users are asked to use Jewel version of Ceph. The latest point release of Jewel (v10.2.2) does not have this support. The next point release would. So once it\u0027s out I\u0027ll add the specific Jewel point release version to the docs.\n\nMeanwhile, I think it\u0027s useful to mention the commit-SHA1s.","commit_id":"c368b6aa3b82eba173d24fd1b3dd1df676a1fb1b"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"ee517e5f8a133b66715a7cbe0d664e4ef82d8524","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"SHA-1                                    | Ceph branch"},{"line_number":19,"context_line":"--------------------------------------------------------"},{"line_number":20,"context_line":"011ea5e7fb35ee07848e0c3abac24702a778ad63 | master"},{"line_number":21,"context_line":"2cd3ed8a59786be28b55a0983a438af1aab226ea | Jewel"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I29eb45104c04da1706c3978441babe9c4a52ca02"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_e77a4787","line":20,"updated":"2016-08-11 08:46:34.000000000","message":"Can you add full links here? Otherwise gerrit links to review.openstack.org ...","commit_id":"aa7c532e91fa12d67f3585cb9ea760ab9b64b496"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"46bcb820e9657152ceea1cbe7fa5cfabf5b78eac","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"SHA-1                                    | Ceph branch"},{"line_number":19,"context_line":"--------------------------------------------------------"},{"line_number":20,"context_line":"011ea5e7fb35ee07848e0c3abac24702a778ad63 | master"},{"line_number":21,"context_line":"2cd3ed8a59786be28b55a0983a438af1aab226ea | Jewel"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I29eb45104c04da1706c3978441babe9c4a52ca02"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_f82782b3","line":20,"in_reply_to":"9ad45d7e_e77a4787","updated":"2016-08-11 09:35:34.000000000","message":"Done","commit_id":"aa7c532e91fa12d67f3585cb9ea760ab9b64b496"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"ee517e5f8a133b66715a7cbe0d664e4ef82d8524","unresolved":false,"context_lines":[{"line_number":18,"context_line":"SHA-1                                    | Ceph branch"},{"line_number":19,"context_line":"--------------------------------------------------------"},{"line_number":20,"context_line":"011ea5e7fb35ee07848e0c3abac24702a778ad63 | master"},{"line_number":21,"context_line":"2cd3ed8a59786be28b55a0983a438af1aab226ea | Jewel"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I29eb45104c04da1706c3978441babe9c4a52ca02"},{"line_number":24,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_2771ffa8","line":21,"updated":"2016-08-11 08:46:34.000000000","message":"same here","commit_id":"aa7c532e91fa12d67f3585cb9ea760ab9b64b496"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"46bcb820e9657152ceea1cbe7fa5cfabf5b78eac","unresolved":false,"context_lines":[{"line_number":18,"context_line":"SHA-1                                    | Ceph branch"},{"line_number":19,"context_line":"--------------------------------------------------------"},{"line_number":20,"context_line":"011ea5e7fb35ee07848e0c3abac24702a778ad63 | master"},{"line_number":21,"context_line":"2cd3ed8a59786be28b55a0983a438af1aab226ea | Jewel"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I29eb45104c04da1706c3978441babe9c4a52ca02"},{"line_number":24,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_d82c3e9b","line":21,"in_reply_to":"9ad45d7e_2771ffa8","updated":"2016-08-11 09:35:34.000000000","message":"Done","commit_id":"aa7c532e91fa12d67f3585cb9ea760ab9b64b496"}],"doc/source/devref/cephfs_native_driver.rst":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"4ac610639006fb528b08e55df27eb0424b1840c5","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  * Only ``cephx`` access type is supported for CephFS protocol."},{"line_number":45,"context_line":"  * ``read-only`` access level is supported in Newton or later versions"},{"line_number":46,"context_line":"    of manila."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- Extend/shrink share"},{"line_number":49,"context_line":"- Create/delete snapshot"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dada55a8_f443786a","line":46,"range":{"start_line":46,"start_character":14,"end_line":46,"end_character":14},"updated":"2016-07-25 11:41:36.000000000","message":"How about Read/write access level?","commit_id":"9ab168ab1320275f34ffa6ac3f45f040c2ff370c"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"f2d0a8f886effb2e4e82f473f0a8dab873f8939c","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  * Only ``cephx`` access type is supported for CephFS protocol."},{"line_number":45,"context_line":"  * ``read-only`` access level is supported in Newton or later versions"},{"line_number":46,"context_line":"    of manila."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- Extend/shrink share"},{"line_number":49,"context_line":"- Create/delete snapshot"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_e0b7db82","line":46,"range":{"start_line":46,"start_character":14,"end_line":46,"end_character":14},"in_reply_to":"dada55a8_f443786a","updated":"2016-08-05 08:58:20.000000000","message":"Done","commit_id":"9ab168ab1320275f34ffa6ac3f45f040c2ff370c"}],"doc/source/devref/share_back_ends_feature_support_mapping.rst":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"4ac610639006fb528b08e55df27eb0424b1840c5","unresolved":false,"context_lines":[{"line_number":110,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":111,"context_line":"|              Oracle ZFSSA              |  NFS,CIFS(K) |       \\-       |     \\-     |      \\-      |      \\-      |       \\-       |     \\-     |     \\-     |"},{"line_number":112,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":113,"context_line":"|              CephFS Native             |      \\-      |       \\-       |     \\-     |  CEPHFS (M)  |      \\-      |       \\-       | CEPHFS (N) |     \\-     |"},{"line_number":114,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":115,"context_line":"|                 Tegile                 |    NFS (M)   |NFS (M),CIFS (M)|     \\-     |      \\-      |    NFS (M)   |NFS (M),CIFS (M)|     \\-     |     \\-     |"},{"line_number":116,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dada55a8_889adc6c","line":113,"range":{"start_line":113,"start_character":134,"end_line":113,"end_character":156},"updated":"2016-07-25 11:41:36.000000000","message":"Support for Cert or CephX?\n\nIn https://review.openstack.org/#/c/334010/2/doc/source/devref/cephfs_native_driver.rst doc, \nOnly ``cephx`` access type is supported for CephFS protocol.","commit_id":"9ab168ab1320275f34ffa6ac3f45f040c2ff370c"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"f2d0a8f886effb2e4e82f473f0a8dab873f8939c","unresolved":false,"context_lines":[{"line_number":110,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":111,"context_line":"|              Oracle ZFSSA              |  NFS,CIFS(K) |       \\-       |     \\-     |      \\-      |      \\-      |       \\-       |     \\-     |     \\-     |"},{"line_number":112,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":113,"context_line":"|              CephFS Native             |      \\-      |       \\-       |     \\-     |  CEPHFS (M)  |      \\-      |       \\-       | CEPHFS (N) |     \\-     |"},{"line_number":114,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":115,"context_line":"|                 Tegile                 |    NFS (M)   |NFS (M),CIFS (M)|     \\-     |      \\-      |    NFS (M)   |NFS (M),CIFS (M)|     \\-     |     \\-     |"},{"line_number":116,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_60a48b4a","line":113,"range":{"start_line":113,"start_character":134,"end_line":113,"end_character":156},"in_reply_to":"dada55a8_889adc6c","updated":"2016-08-05 08:58:20.000000000","message":"Done","commit_id":"9ab168ab1320275f34ffa6ac3f45f040c2ff370c"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"ff6d2c0d9cd2fa7e5e2ebe21226bf85066d5fc86","unresolved":false,"context_lines":[{"line_number":110,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":111,"context_line":"|              Oracle ZFSSA              |  NFS,CIFS(K) |       \\-       |     \\-     |      \\-      |      \\-      |       \\-       |     \\-     |     \\-     |"},{"line_number":112,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":113,"context_line":"|              CephFS Native             |      \\-      |       \\-       |     \\-     |  CEPHFS (M)  |      \\-      |       \\-       | CEPHFS (N) |     \\-     |"},{"line_number":114,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":115,"context_line":"|                 Tegile                 |    NFS (M)   |NFS (M),CIFS (M)|     \\-     |      \\-      |    NFS (M)   |NFS (M),CIFS (M)|     \\-     |     \\-     |"},{"line_number":116,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dada55a8_2b7c8a71","line":113,"range":{"start_line":113,"start_character":134,"end_line":113,"end_character":156},"in_reply_to":"dada55a8_889adc6c","updated":"2016-07-25 11:55:42.000000000","message":"You\u0027re right. ``CEPHFS (N)`` should be moved to the next ``cephx`` column. Thanks!","commit_id":"9ab168ab1320275f34ffa6ac3f45f040c2ff370c"}],"manila/share/drivers/cephfs/cephfs_native.py":[{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"fb3f7214edd31dcc55e17e76bd990b2f61ba5284","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        ceph_auth_id \u003d access[\u0027access_to\u0027]"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        if access[\u0027access_level\u0027] \u003d\u003d constants.ACCESS_LEVEL_RO:"},{"line_number":213,"context_line":"            auth_result \u003d self.volume_client.authorize("},{"line_number":214,"context_line":"                self._share_path(share), ceph_auth_id, readonly\u003dTrue)"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_c54f0769","line":212,"updated":"2016-06-27 10:49:36.000000000","message":"This is going to blow up if it gets called with an older VolumeClient that doesn\u0027t have the readonly argument.  It\u0027s time to get some versioning in (http://tracker.ceph.com/issues/15406) (don\u0027t necessarily have to block this patch, but needs doing before we get to Newton)","commit_id":"807ceed6f8ed1222347baab1c993752c1b9dcd5c"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"08338ca293a7f663aca123c232569ed30a795a0a","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                             ceph_auth_id)"},{"line_number":221,"context_line":"            raise exception.InvalidInput(message\u003derror_message)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        readonly \u003d ("},{"line_number":224,"context_line":"            True if access[\u0027access_level\u0027] \u003d\u003d constants.ACCESS_LEVEL_RO"},{"line_number":225,"context_line":"            else False)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        auth_result \u003d self.volume_client.authorize("},{"line_number":228,"context_line":"            self._share_path(share), ceph_auth_id, readonly\u003dreadonly)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_205c534a","line":225,"range":{"start_line":223,"start_character":0,"end_line":225,"end_character":23},"updated":"2016-08-05 08:59:53.000000000","message":"Why not:\nreadonly \u003d access[\u0027access_level\u0027] \u003d\u003d constants.ACCESS_LEVEL_RO","commit_id":"6762e91120cd6cea571fcb8d885baf30d8d3b7c7"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"9d521ca193febb4a7dcedafada44cc7c724ea88e","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                             ceph_auth_id)"},{"line_number":221,"context_line":"            raise exception.InvalidInput(message\u003derror_message)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        readonly \u003d ("},{"line_number":224,"context_line":"            True if access[\u0027access_level\u0027] \u003d\u003d constants.ACCESS_LEVEL_RO"},{"line_number":225,"context_line":"            else False)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        auth_result \u003d self.volume_client.authorize("},{"line_number":228,"context_line":"            self._share_path(share), ceph_auth_id, readonly\u003dreadonly)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_e6d89420","line":225,"range":{"start_line":223,"start_character":0,"end_line":225,"end_character":23},"in_reply_to":"bacf61ea_205c534a","updated":"2016-08-05 09:10:28.000000000","message":"Done","commit_id":"6762e91120cd6cea571fcb8d885baf30d8d3b7c7"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"6fc7309a0744034abd61d0c6edb57bd4392c112e","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        readonly \u003d access[\u0027access_level\u0027] \u003d\u003d constants.ACCESS_LEVEL_RO"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        auth_result \u003d self.volume_client.authorize("},{"line_number":226,"context_line":"            self._share_path(share), ceph_auth_id, readonly\u003dreadonly)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        return auth_result[\u0027auth_key\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_19544ec8","line":225,"updated":"2016-08-10 12:58:36.000000000","message":"Are you sure you don\u0027t want to check the version?  It seems like it would be pretty easy to have a one-liner here that checks if CephFSVolumeClient has a version attribute, and raises InvalidShareAccessLevel if that is the case and the user asked for readonly","commit_id":"c368b6aa3b82eba173d24fd1b3dd1df676a1fb1b"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"1bddf17da272ea2a72eb01cfdc359ece2a12bbe9","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        readonly \u003d access[\u0027access_level\u0027] \u003d\u003d constants.ACCESS_LEVEL_RO"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        auth_result \u003d self.volume_client.authorize("},{"line_number":226,"context_line":"            self._share_path(share), ceph_auth_id, readonly\u003dreadonly)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        return auth_result[\u0027auth_key\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_977635a2","line":225,"in_reply_to":"9ad45d7e_19544ec8","updated":"2016-08-10 18:40:40.000000000","message":"Done","commit_id":"c368b6aa3b82eba173d24fd1b3dd1df676a1fb1b"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"ee517e5f8a133b66715a7cbe0d664e4ef82d8524","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                             ceph_auth_id)"},{"line_number":221,"context_line":"            raise exception.InvalidInput(message\u003derror_message)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        if not getattr(self.volume_client, \u0027version\u0027, None):"},{"line_number":224,"context_line":"            if access[\u0027access_level\u0027] \u003d\u003d constants.ACCESS_LEVEL_RO:"},{"line_number":225,"context_line":"                raise exception.InvalidShareAccessLevel("},{"line_number":226,"context_line":"                    level\u003dconstants.ACCESS_LEVEL_RO)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_840ee938","line":223,"updated":"2016-08-11 08:46:34.000000000","message":"nit: Can you add a comment here that a newer client version is needed to have RO support?","commit_id":"aa7c532e91fa12d67f3585cb9ea760ab9b64b496"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"46bcb820e9657152ceea1cbe7fa5cfabf5b78eac","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                             ceph_auth_id)"},{"line_number":221,"context_line":"            raise exception.InvalidInput(message\u003derror_message)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        if not getattr(self.volume_client, \u0027version\u0027, None):"},{"line_number":224,"context_line":"            if access[\u0027access_level\u0027] \u003d\u003d constants.ACCESS_LEVEL_RO:"},{"line_number":225,"context_line":"                raise exception.InvalidShareAccessLevel("},{"line_number":226,"context_line":"                    level\u003dconstants.ACCESS_LEVEL_RO)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_982f6687","line":223,"in_reply_to":"9ad45d7e_840ee938","updated":"2016-08-11 09:35:34.000000000","message":"Done.","commit_id":"aa7c532e91fa12d67f3585cb9ea760ab9b64b496"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"483825701593e3a90f8a8e7534b58d11f92e0156","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                             ceph_auth_id)"},{"line_number":221,"context_line":"            raise exception.InvalidInput(message\u003derror_message)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        # TODO(rraja): Log the Ceph point release version, once available, in"},{"line_number":224,"context_line":"        # which the volume client can enable read-only access."},{"line_number":225,"context_line":"        if not getattr(self.volume_client, \u0027version\u0027, None):"},{"line_number":226,"context_line":"            if access[\u0027access_level\u0027] \u003d\u003d constants.ACCESS_LEVEL_RO:"},{"line_number":227,"context_line":"                raise exception.InvalidShareAccessLevel("}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_e1da0e16","line":224,"range":{"start_line":223,"start_character":7,"end_line":224,"end_character":62},"updated":"2016-08-11 19:55:55.000000000","message":"ok","commit_id":"0f596c55df0d6c7a404d22013515748bff516707"}],"releasenotes/notes/cephfs-native-add-readonly-shares-support-067ccab0217ab5f5.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d95f3671cd3a63482e5e60fd7862ac328ad44f37","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - For cephfs_native driver, added read-only shares"},{"line_number":4,"context_line":"    support."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9ad45d7e_8f93795a","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":21},"updated":"2016-08-11 20:02:31.000000000","message":"CEPHFS Native","commit_id":"0f596c55df0d6c7a404d22013515748bff516707"}]}