)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d9807879ce886f26ae0e2a7536c91bed425e149e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"ServiceClients, is going to move to a stable interface in"},{"line_number":13,"context_line":"tempest.lib."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This is a WIP change to test the interface on Tempest side along"},{"line_number":16,"context_line":"with a real life plugin."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I4cc9e2b9cd5cb09dff04ee16edcf85e59aec554f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"ff346bd7_57c3b089","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":24},"updated":"2017-07-28 13:16:43.000000000","message":"This will have to be removed :)","commit_id":"553b66a20f320cf8b226c19a426b798c77d299d5"}],"manila_tempest_tests/plugin.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1c5a1986af4f46656c5b549bfc583e1734200d57","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        return [(config_share.share_group.name, config_share.ShareGroup),"},{"line_number":51,"context_line":"                (\u0027service_available\u0027, config_share.ServiceAvailableGroup)]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def get_service_clients(self):"},{"line_number":54,"context_line":"        shares_config \u003d config.service_client_config(\u0027shares\u0027)"},{"line_number":55,"context_line":"        v1_params \u003d {"},{"line_number":56,"context_line":"            \u0027name\u0027: \u0027shares_v1\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_a81e666d","line":53,"updated":"2016-07-06 14:55:15.000000000","message":"Please, add some docstring with details about returned data.","commit_id":"767e0b0c6d45d9d2465b4ae5b00534ac7c47d5d9"}],"manila_tempest_tests/services/share/v2/json/__init__.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"84c4e4cc6f8104e6411a573ba8a15b8d72819abe","unresolved":false,"context_lines":[{"line_number":1,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1aa78d24_eed16824","line":1,"updated":"2016-07-07 10:03:05.000000000","message":"?","commit_id":"371f18aa5533bcd4a07c585b4090e3679ec4003f"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3960f0987c4695a242982350725c3b6995bea7c9","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def _get_service_clients(cls, credentials):"},{"line_number":154,"context_line":"        \"\"\"Helper method to setup a service clients object from CONF\"\"\""},{"line_number":155,"context_line":"        # Identity settings"},{"line_number":156,"context_line":"        if CONF.identity.auth_version \u003d\u003d \u0027v2\u0027:"},{"line_number":157,"context_line":"            identity_uri \u003d CONF.identity.uri"},{"line_number":158,"context_line":"        else:"},{"line_number":159,"context_line":"            identity_uri \u003d CONF.idenity.uri_v3"},{"line_number":160,"context_line":"        # Common parameters"},{"line_number":161,"context_line":"        parameters \u003d {"},{"line_number":162,"context_line":"            \u0027disable_ssl_certificate_validation\u0027:"},{"line_number":163,"context_line":"                CONF.identity.disable_ssl_certificate_validation,"},{"line_number":164,"context_line":"            \u0027ca_certs\u0027: CONF.identity.ca_certificates_file,"},{"line_number":165,"context_line":"            \u0027trace_requests\u0027: CONF.debug.trace_requests,"},{"line_number":166,"context_line":"            \u0027region\u0027: CONF.identity.region"},{"line_number":167,"context_line":"        }"},{"line_number":168,"context_line":"        # Neutron paramaters"},{"line_number":169,"context_line":"        neutron_params \u003d {"},{"line_number":170,"context_line":"            \u0027available\u0027: CONF.service_available.neutron,"},{"line_number":171,"context_line":"            \u0027region\u0027: CONF.neutron.region,"},{"line_number":172,"context_line":"            \u0027catalog_type\u0027: CONF.neutron.catalog_type,"},{"line_number":173,"context_line":"            \u0027endpoint_type\u0027: CONF.neutron.endpoint_type,"},{"line_number":174,"context_line":"            \u0027build_timeout\u0027: CONF.neutron.build_timeout,"},{"line_number":175,"context_line":"            \u0027build_interval\u0027: CONF.neutron.build_interval"},{"line_number":176,"context_line":"        }"},{"line_number":177,"context_line":"        parameters[\u0027network\u0027] \u003d neutron_params"},{"line_number":178,"context_line":"        # Get and return the service clients object."},{"line_number":179,"context_line":"        return service_clients.ServiceClients("},{"line_number":180,"context_line":"            credentials, identity_uri, **parameters)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @classmethod"},{"line_number":183,"context_line":"    def get_client_with_isolated_creds(cls,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_47463822","line":180,"range":{"start_line":156,"start_character":8,"end_line":180,"end_character":52},"updated":"2016-06-28 11:56:33.000000000","message":"I find it very strange that manila should provide these options.\n\nAlso, will it work with disabled Neutron? We have such jobs.","commit_id":"c414d01de5a0ee844fc4dcb1649ab367e7edd408"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"09fca07d72d0de211d6911632978f7fd12b42841","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def _get_service_clients(cls, credentials):"},{"line_number":154,"context_line":"        \"\"\"Helper method to setup a service clients object from CONF\"\"\""},{"line_number":155,"context_line":"        # Identity settings"},{"line_number":156,"context_line":"        if CONF.identity.auth_version \u003d\u003d \u0027v2\u0027:"},{"line_number":157,"context_line":"            identity_uri \u003d CONF.identity.uri"},{"line_number":158,"context_line":"        else:"},{"line_number":159,"context_line":"            identity_uri \u003d CONF.idenity.uri_v3"},{"line_number":160,"context_line":"        # Common parameters"},{"line_number":161,"context_line":"        parameters \u003d {"},{"line_number":162,"context_line":"            \u0027disable_ssl_certificate_validation\u0027:"},{"line_number":163,"context_line":"                CONF.identity.disable_ssl_certificate_validation,"},{"line_number":164,"context_line":"            \u0027ca_certs\u0027: CONF.identity.ca_certificates_file,"},{"line_number":165,"context_line":"            \u0027trace_requests\u0027: CONF.debug.trace_requests,"},{"line_number":166,"context_line":"            \u0027region\u0027: CONF.identity.region"},{"line_number":167,"context_line":"        }"},{"line_number":168,"context_line":"        # Neutron paramaters"},{"line_number":169,"context_line":"        neutron_params \u003d {"},{"line_number":170,"context_line":"            \u0027available\u0027: CONF.service_available.neutron,"},{"line_number":171,"context_line":"            \u0027region\u0027: CONF.neutron.region,"},{"line_number":172,"context_line":"            \u0027catalog_type\u0027: CONF.neutron.catalog_type,"},{"line_number":173,"context_line":"            \u0027endpoint_type\u0027: CONF.neutron.endpoint_type,"},{"line_number":174,"context_line":"            \u0027build_timeout\u0027: CONF.neutron.build_timeout,"},{"line_number":175,"context_line":"            \u0027build_interval\u0027: CONF.neutron.build_interval"},{"line_number":176,"context_line":"        }"},{"line_number":177,"context_line":"        parameters[\u0027network\u0027] \u003d neutron_params"},{"line_number":178,"context_line":"        # Get and return the service clients object."},{"line_number":179,"context_line":"        return service_clients.ServiceClients("},{"line_number":180,"context_line":"            credentials, identity_uri, **parameters)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @classmethod"},{"line_number":183,"context_line":"    def get_client_with_isolated_creds(cls,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_c832d7a6","line":180,"range":{"start_line":156,"start_character":8,"end_line":180,"end_character":52},"in_reply_to":"3aaa91ec_47463822","updated":"2016-07-06 13:31:34.000000000","message":"I\u0027m improving on this in the next version, I will put a new patchset soon.\nBut still plugins will have to initialise any client they want to use, because that depends on configuration, and any stable interface in tempest.lib cannot depend on that.\n\nRegarding neutron, you can skip initialising the neutron client if neutron is not available, but that would not make a difference really.","commit_id":"c414d01de5a0ee844fc4dcb1649ab367e7edd408"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1c5a1986af4f46656c5b549bfc583e1734200d57","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from tempest import test"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from manila_tempest_tests.common import constants"},{"line_number":33,"context_line":"from manila_tempest_tests.services.share.json import shares_client"},{"line_number":34,"context_line":"from manila_tempest_tests.services.share.v2.json import ("},{"line_number":35,"context_line":"    shares_client as shares_v2_client)"},{"line_number":36,"context_line":"from manila_tempest_tests import share_exceptions"},{"line_number":37,"context_line":"from manila_tempest_tests import utils"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_28d0b6f5","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":38},"updated":"2016-07-06 14:55:15.000000000","message":"According to approach you use, these imports should be updated to \"from manila_tempest_tests.services import share\". But I am not sure it is really required. Manila has just two modules with clients.","commit_id":"767e0b0c6d45d9d2465b4ae5b00534ac7c47d5d9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1c5a1986af4f46656c5b549bfc583e1734200d57","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    @classmethod"},{"line_number":245,"context_line":"    def setup_clients(cls):"},{"line_number":246,"context_line":"        super(BaseSharesTest, cls).setup_clients()"},{"line_number":247,"context_line":"        os \u003d getattr(cls, \u0027os_%s\u0027 % cls.credentials[0])"},{"line_number":248,"context_line":"        os.shares_client \u003d shares_client.SharesClient(os.auth_provider)"},{"line_number":249,"context_line":"        cls.shares_client \u003d os.shares_client"},{"line_number":250,"context_line":"        os.shares_v2_client \u003d shares_v2_client.SharesV2Client("},{"line_number":251,"context_line":"            os.auth_provider)"},{"line_number":252,"context_line":"        cls.shares_v2_client \u003d os.shares_v2_client"},{"line_number":253,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":254,"context_line":"            if not CONF.service_available.neutron:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_08cfba29","line":251,"range":{"start_line":247,"start_character":8,"end_line":251,"end_character":29},"updated":"2016-07-06 14:55:15.000000000","message":"After change of [1], this becomes incompatible.\n\n[1] https://review.openstack.org/#/c/334596/2/manila_tempest_tests/services/share/json/shares_client.py","commit_id":"767e0b0c6d45d9d2465b4ae5b00534ac7c47d5d9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1c5a1986af4f46656c5b549bfc583e1734200d57","unresolved":false,"context_lines":[{"line_number":880,"context_line":"    @classmethod"},{"line_number":881,"context_line":"    def setup_clients(cls):"},{"line_number":882,"context_line":"        super(BaseSharesMixedTest, cls).setup_clients()"},{"line_number":883,"context_line":"        cls.admin_shares_client \u003d shares_client.SharesClient("},{"line_number":884,"context_line":"            cls.os_admin.auth_provider)"},{"line_number":885,"context_line":"        cls.admin_shares_v2_client \u003d shares_v2_client.SharesV2Client("},{"line_number":886,"context_line":"            cls.os_admin.auth_provider)"},{"line_number":887,"context_line":"        cls.alt_shares_client \u003d shares_client.SharesClient("},{"line_number":888,"context_line":"            cls.os_alt.auth_provider)"},{"line_number":889,"context_line":"        cls.alt_shares_v2_client \u003d shares_v2_client.SharesV2Client("},{"line_number":890,"context_line":"            cls.os_alt.auth_provider)"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":893,"context_line":"            admin_share_network_id \u003d cls.provide_share_network("}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_48dd42df","line":890,"range":{"start_line":883,"start_character":9,"end_line":890,"end_character":37},"updated":"2016-07-06 14:55:15.000000000","message":"Same here.","commit_id":"767e0b0c6d45d9d2465b4ae5b00534ac7c47d5d9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d7aad96df0f441d2128a9c6d2a3a3c6b6f19f533","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        cls.shares_client \u003d os.share_v1.SharesClient()"},{"line_number":235,"context_line":"        cls.shares_v2_client \u003d os.share_v2.SharesV2Client()"},{"line_number":236,"context_line":"        # Initialise network clients for test credentials"},{"line_number":237,"context_line":"        if CONF.service_available.neutron:"},{"line_number":238,"context_line":"            cls.networks_client \u003d os.network.NetworksClient()"},{"line_number":239,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":240,"context_line":"            if not CONF.service_available.neutron:"},{"line_number":241,"context_line":"                raise cls.skipException(\"Neutron support is required\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_36aa9585","line":238,"range":{"start_line":237,"start_character":8,"end_line":238,"end_character":61},"updated":"2016-07-07 14:46:07.000000000","message":"It is redundant.","commit_id":"b3a24fc7f13d01242960dafdfef4dec5097320d5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d7aad96df0f441d2128a9c6d2a3a3c6b6f19f533","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            if not CONF.service_available.neutron:"},{"line_number":241,"context_line":"                raise cls.skipException(\"Neutron support is required\")"},{"line_number":242,"context_line":"            share_network_id \u003d cls.provide_share_network("},{"line_number":243,"context_line":"                cls.shares_v2_client, cls.networks_client)"},{"line_number":244,"context_line":"            cls.shares_client.share_network_id \u003d share_network_id"},{"line_number":245,"context_line":"            cls.shares_v2_client.share_network_id \u003d share_network_id"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_5693e15a","line":243,"range":{"start_line":243,"start_character":38,"end_line":243,"end_character":57},"updated":"2016-07-07 14:46:07.000000000","message":"os.network.NetworksClient()","commit_id":"b3a24fc7f13d01242960dafdfef4dec5097320d5"}]}
