)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"APIs and replaces them with the experimental Share Group"},{"line_number":11,"context_line":"apis."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements-bluprint: manila-share-groups"},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"APIImpact"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"9a629dbe_6c1d1f66","line":13,"range":{"start_line":13,"start_character":11,"end_line":13,"end_character":19},"updated":"2016-11-07 12:20:01.000000000","message":"this typo makes gerrit ignore it as link to BP.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"17480d1a168f6ff866b4074f6aebb505df5d60a7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Implements-bluprint: manila-share-groups"},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"APIImpact"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I79a80a62ae4e0015d6161edc2b93fd1f9ba69537"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"9a629dbe_c568868a","line":16,"updated":"2016-11-08 13:16:19.000000000","message":"Please add a \"Depends-On: I4c6d6cd3475bae90d06ac4003a05bcacc3db6ef3\" so this get\u0027s not merged before the spec itself.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"eb885982bd8bc6f6b18f46a49cc88b0287fd278c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"APIImpact"},{"line_number":14,"context_line":"Partially-implements-blueprint: manila-share-groups"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Depends-On: I8e29baed62355fc31caeec9c7a66eaebfcbdf184"},{"line_number":17,"context_line":"Change-Id: I79a80a62ae4e0015d6161edc2b93fd1f9ba69537"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":48,"id":"5a3905b3_daa139ab","line":16,"updated":"2017-01-20 03:51:35.000000000","message":"Hmm, just realized this makes this server patch dependent on the client patch.  This is opposite to what we usually do.  We can\u0027t make manila client calls without server side changes. Is this because of the tempest tests?\n\nhttps://review.openstack.org/#/c/335120/","commit_id":"96ad3e60f58d44813394ff7a5e898b1a67a56580"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4936f654b4992fe6bcc6662bb451e52bcc0dfe9d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"APIImpact"},{"line_number":14,"context_line":"Partially-implements-blueprint: manila-share-groups"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Depends-On: I8e29baed62355fc31caeec9c7a66eaebfcbdf184"},{"line_number":17,"context_line":"Change-Id: I79a80a62ae4e0015d6161edc2b93fd1f9ba69537"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":48,"id":"5a3905b3_ceeedab3","line":16,"in_reply_to":"5a3905b3_daa139ab","updated":"2017-01-20 04:10:44.000000000","message":"Is it because the devstack plugin uses manila client to create a group type?  So I think the devstack related changes should be added after the client patch and the client patch should be merged after the Manila server side changes.","commit_id":"96ad3e60f58d44813394ff7a5e898b1a67a56580"}],"contrib/ci/post_test_hook.sh":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"06dc557190b6e4ac3434ccf657d14a3c9926db44","unresolved":false,"context_lines":[{"line_number":69,"context_line":"RUN_MANILA_QUOTA_TESTS\u003d${RUN_MANILA_QUOTA_TESTS:-True}"},{"line_number":70,"context_line":"RUN_MANILA_SHRINK_TESTS\u003d${RUN_MANILA_SHRINK_TESTS:-True}"},{"line_number":71,"context_line":"RUN_MANILA_SNAPSHOT_TESTS\u003d${RUN_MANILA_SNAPSHOT_TESTS:-True}"},{"line_number":72,"context_line":"RUN_MANILA_CG_TESTS\u003d${RUN_MANILA_CG_TESTS:-False}"},{"line_number":73,"context_line":"RUN_MANILA_MANAGE_TESTS\u003d${RUN_MANILA_MANAGE_TESTS:-True}"},{"line_number":74,"context_line":"RUN_MANILA_MANAGE_SNAPSHOT_TESTS\u003d${RUN_MANILA_MANAGE_SNAPSHOT_TESTS:-False}"},{"line_number":75,"context_line":"RUN_MANILA_REPLICATION_TESTS\u003d${RUN_MANILA_REPLICATION_TESTS:-False}"}],"source_content_type":"text/x-sh","patch_set":43,"id":"7a3c09a3_0a2a0590","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":19},"updated":"2017-01-18 05:23:50.000000000","message":"Should we have equivalent RUN_MANILA_GROUP_TESTS here?","commit_id":"7ebc704c577d99bc91cfd3bd7c97601977076817"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"38970b2a5764531a59e202e65ac53129895c16d9","unresolved":false,"context_lines":[{"line_number":69,"context_line":"RUN_MANILA_QUOTA_TESTS\u003d${RUN_MANILA_QUOTA_TESTS:-True}"},{"line_number":70,"context_line":"RUN_MANILA_SHRINK_TESTS\u003d${RUN_MANILA_SHRINK_TESTS:-True}"},{"line_number":71,"context_line":"RUN_MANILA_SNAPSHOT_TESTS\u003d${RUN_MANILA_SNAPSHOT_TESTS:-True}"},{"line_number":72,"context_line":"RUN_MANILA_CG_TESTS\u003d${RUN_MANILA_CG_TESTS:-False}"},{"line_number":73,"context_line":"RUN_MANILA_MANAGE_TESTS\u003d${RUN_MANILA_MANAGE_TESTS:-True}"},{"line_number":74,"context_line":"RUN_MANILA_MANAGE_SNAPSHOT_TESTS\u003d${RUN_MANILA_MANAGE_SNAPSHOT_TESTS:-False}"},{"line_number":75,"context_line":"RUN_MANILA_REPLICATION_TESTS\u003d${RUN_MANILA_REPLICATION_TESTS:-False}"}],"source_content_type":"text/x-sh","patch_set":43,"id":"7a3c09a3_dca0abf6","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":19},"in_reply_to":"7a3c09a3_0a2a0590","updated":"2017-01-18 16:16:36.000000000","message":"See dependent commit that adds tempest tests:\n\nhttps://review.openstack.org/#/c/355264/12/contrib/ci/post_test_hook.sh","commit_id":"7ebc704c577d99bc91cfd3bd7c97601977076817"}],"etc/manila/policy.json":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    \"share_group_types_extra_spec:update\": \"rule:admin_api\","},{"line_number":147,"context_line":"    \"share_group_types_extra_spec:show\": \"rule:admin_api\","},{"line_number":148,"context_line":"    \"share_group_types_extra_spec:index\": \"rule:admin_api\","},{"line_number":149,"context_line":"    \"share_group_types_extra_spec:delete\": \"rule:admin_api\""},{"line_number":150,"context_line":"}"}],"source_content_type":"application/json","patch_set":26,"id":"1ac06dbe_c95cd1ef","line":149,"range":{"start_line":149,"start_character":58,"end_line":149,"end_character":59},"updated":"2016-08-22 12:59:09.000000000","message":"trailing comma","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    \"share_group_types_extra_spec:update\": \"rule:admin_api\","},{"line_number":147,"context_line":"    \"share_group_types_extra_spec:show\": \"rule:admin_api\","},{"line_number":148,"context_line":"    \"share_group_types_extra_spec:index\": \"rule:admin_api\","},{"line_number":149,"context_line":"    \"share_group_types_extra_spec:delete\": \"rule:admin_api\""},{"line_number":150,"context_line":"}"}],"source_content_type":"application/json","patch_set":26,"id":"ba5da102_721e5560","line":149,"range":{"start_line":149,"start_character":58,"end_line":149,"end_character":59},"in_reply_to":"1ac06dbe_c95cd1ef","updated":"2016-11-01 15:31:20.000000000","message":"trailing comma isn\u0027t valid json. Frustrating I know.","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f50566e91cd848f2708c96fe79b18fa9d0ff475d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    * 2.17 - Added project_id and user_id fields to the JSON response of"},{"line_number":70,"context_line":"             snapshot show/create/manage API."},{"line_number":71,"context_line":"    * 2.18 - Add gateway to the JSON response of share network show API."},{"line_number":72,"context_line":"    * 2.19 - Convert Consistency groups to share groups."},{"line_number":73,"context_line":"\"\"\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_3e35deda","line":72,"range":{"start_line":72,"start_character":33,"end_line":72,"end_character":39},"updated":"2016-07-10 21:04:16.000000000","message":"nit Groups (match 2.4)","commit_id":"7f7e9b00255412e622a1db7afb934160b10b9903"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    * 2.1  - Share create() doesn\u0027t ignore availability_zone field of share."},{"line_number":50,"context_line":"    * 2.2  - Snapshots become optional feature."},{"line_number":51,"context_line":"    * 2.3  - Share instances admin API"},{"line_number":52,"context_line":"    * 2.4  - Consistency Group support (Removed)"},{"line_number":53,"context_line":"    * 2.5  - Share Migration admin API"},{"line_number":54,"context_line":"    * 2.6  - Return share_type UUID instead of name in Share API"},{"line_number":55,"context_line":"    * 2.7  - Rename old extension-like API URLs to core-API-like"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_c92a112c","line":52,"range":{"start_line":52,"start_character":39,"end_line":52,"end_character":48},"updated":"2016-08-22 12:59:09.000000000","message":"I wouldn\u0027t write this change further back in the changelog.","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    * 2.1  - Share create() doesn\u0027t ignore availability_zone field of share."},{"line_number":50,"context_line":"    * 2.2  - Snapshots become optional feature."},{"line_number":51,"context_line":"    * 2.3  - Share instances admin API"},{"line_number":52,"context_line":"    * 2.4  - Consistency Group support (Removed)"},{"line_number":53,"context_line":"    * 2.5  - Share Migration admin API"},{"line_number":54,"context_line":"    * 2.6  - Return share_type UUID instead of name in Share API"},{"line_number":55,"context_line":"    * 2.7  - Rename old extension-like API URLs to core-API-like"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_f260a5d1","line":52,"range":{"start_line":52,"start_character":39,"end_line":52,"end_character":48},"in_reply_to":"1ac06dbe_c92a112c","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def __str__(self):"},{"line_number":127,"context_line":"        \"\"\"Debug/Logging representation of object.\"\"\""},{"line_number":128,"context_line":"        params \u003d {\u0027major\u0027: self._ver_major,"},{"line_number":129,"context_line":"                  \u0027minor\u0027: self._ver_minor,"},{"line_number":130,"context_line":"                  \u0027experimental\u0027: self._experimental}"},{"line_number":131,"context_line":"        return (\"API Version Request Major: %(major)s, Minor: %(minor)s, \""},{"line_number":132,"context_line":"                \"Experimental: %(experimental)s\" % params)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_310c6042","line":130,"range":{"start_line":128,"start_character":8,"end_line":130,"end_character":53},"updated":"2016-11-07 12:20:01.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"e5a02fc28c9d31beb0d06621563667b0eeda2578","unresolved":false,"context_lines":[{"line_number":90,"context_line":"             shares (share_instances) with \u0027syncing\u0027. Share action API"},{"line_number":91,"context_line":"             \u0027access_allow\u0027 now accepts rules even when a share or any of"},{"line_number":92,"context_line":"             its instances may have an access_rules_status set to \u0027error\u0027."},{"line_number":93,"context_line":"    * 2.29 - Convert Consistency groups to share groups."},{"line_number":94,"context_line":"\"\"\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_402d2e45","line":93,"range":{"start_line":93,"start_character":21,"end_line":93,"end_character":22},"updated":"2017-01-20 23:37:06.000000000","message":"if an update is needed s/Consistency/consistency/","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95a36d4def7067fd2f61c30355424a3336b1c626","unresolved":false,"context_lines":[{"line_number":90,"context_line":"             shares (share_instances) with \u0027syncing\u0027. Share action API"},{"line_number":91,"context_line":"             \u0027access_allow\u0027 now accepts rules even when a share or any of"},{"line_number":92,"context_line":"             its instances may have an access_rules_status set to \u0027error\u0027."},{"line_number":93,"context_line":"    * 2.29 - Convert Consistency groups to share groups."},{"line_number":94,"context_line":"\"\"\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_99467a4d","line":93,"range":{"start_line":93,"start_character":21,"end_line":93,"end_character":22},"in_reply_to":"5a3905b3_402d2e45","updated":"2017-01-23 13:07:01.000000000","message":"Done","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"}],"manila/api/v1/share_networks.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"dcc172999a1249b3b39518be1756f648f228fd11","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # NOTE(ameade): Do not allow deletion of share network used by share"},{"line_number":85,"context_line":"        #  group"},{"line_number":86,"context_line":"        share_count \u003d db_api.count_share_groups_in_share_network(context, id)"},{"line_number":87,"context_line":"        if share_count:"},{"line_number":88,"context_line":"            msg \u003d _(\"Can not delete share network %(id)s, it has %(len)s \""}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_71fe9f6c","line":85,"range":{"start_line":85,"start_character":10,"end_line":85,"end_character":11},"updated":"2016-08-09 02:42:28.000000000","message":"redundant space","commit_id":"9a8b0c8aea83b8339caacceea0a6b35768ad7272"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"ff260e4fa4c2dcd0d4d3af139cee05107974d2b3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # NOTE(ameade): Do not allow deletion of share network used by share"},{"line_number":85,"context_line":"        #  group"},{"line_number":86,"context_line":"        share_count \u003d db_api.count_share_groups_in_share_network(context, id)"},{"line_number":87,"context_line":"        if share_count:"},{"line_number":88,"context_line":"            msg \u003d _(\"Can not delete share network %(id)s, it has %(len)s \""}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_5c433d42","line":85,"range":{"start_line":85,"start_character":10,"end_line":85,"end_character":11},"in_reply_to":"9ad45d7e_71fe9f6c","updated":"2016-08-10 20:30:15.000000000","message":"Done","commit_id":"9a8b0c8aea83b8339caacceea0a6b35768ad7272"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9f67f41b514294e7dcb484cb32d477a94c86dd27","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # NOTE(ameade): Do not allow deletion of share network used by share"},{"line_number":83,"context_line":"        # group"},{"line_number":84,"context_line":"        share_count \u003d db_api.count_share_groups_in_share_network(context, id)"},{"line_number":85,"context_line":"        if share_count:"},{"line_number":86,"context_line":"            msg \u003d _(\"Can not delete share network %(id)s, it has %(len)s \""},{"line_number":87,"context_line":"                    \"share group(s).\") % {\u0027id\u0027: id, \u0027len\u0027: share_count}"}],"source_content_type":"text/x-python","patch_set":29,"id":"da4df55a_20ced483","line":84,"updated":"2016-12-21 22:55:32.000000000","message":"Should be share_group_count or group_count.","commit_id":"7ed2a8e0320841cdc6a5f70683891048369bd5c4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f2edc3f895c618b7e809e72a11f5c459c4fa32eb","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # NOTE(ameade): Do not allow deletion of share network used by share"},{"line_number":83,"context_line":"        # group"},{"line_number":84,"context_line":"        share_count \u003d db_api.count_share_groups_in_share_network(context, id)"},{"line_number":85,"context_line":"        if share_count:"},{"line_number":86,"context_line":"            msg \u003d _(\"Can not delete share network %(id)s, it has %(len)s \""},{"line_number":87,"context_line":"                    \"share group(s).\") % {\u0027id\u0027: id, \u0027len\u0027: share_count}"}],"source_content_type":"text/x-python","patch_set":29,"id":"da4df55a_12bbcfc5","line":84,"in_reply_to":"da4df55a_20ced483","updated":"2016-12-22 11:33:27.000000000","message":"Done","commit_id":"7ed2a8e0320841cdc6a5f70683891048369bd5c4"}],"manila/api/v1/shares.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f50566e91cd848f2708c96fe79b18fa9d0ff475d","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        try:"},{"line_number":75,"context_line":"            share \u003d self.share_api.get(context, id)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            # NOTE(ameade): If the share is in a share group, we require its"},{"line_number":78,"context_line":"            #  id be specified as a param."},{"line_number":79,"context_line":"            if share.get(\u0027share_group_id\u0027):"},{"line_number":80,"context_line":"                share_group_id \u003d req.params.get(\u0027share_group_id\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_1e574203","line":77,"range":{"start_line":77,"start_character":73,"end_line":77,"end_character":76},"updated":"2016-07-10 21:04:16.000000000","message":"Thank you :)","commit_id":"7f7e9b00255412e622a1db7afb934160b10b9903"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f50566e91cd848f2708c96fe79b18fa9d0ff475d","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            \u0027display_name\u0027, \u0027status\u0027, \u0027share_server_id\u0027, \u0027volume_type_id\u0027,"},{"line_number":237,"context_line":"            \u0027share_type_id\u0027, \u0027snapshot_id\u0027, \u0027host\u0027, \u0027share_network_id\u0027,"},{"line_number":238,"context_line":"            \u0027is_public\u0027, \u0027metadata\u0027, \u0027extra_specs\u0027, \u0027sort_key\u0027, \u0027sort_dir\u0027,"},{"line_number":239,"context_line":"            \u0027share_group_id\u0027, \u0027cgsnapshot_id\u0027"},{"line_number":240,"context_line":"        )"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def update(self, req, id, body):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_fea7d608","line":239,"range":{"start_line":239,"start_character":30,"end_line":239,"end_character":45},"updated":"2016-07-10 21:04:16.000000000","message":"sharesnapshot_id ?","commit_id":"7f7e9b00255412e622a1db7afb934160b10b9903"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"dcc172999a1249b3b39518be1756f648f228fd11","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            share \u003d self.share_api.get(context, id)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            # NOTE(ameade): If the share is in a share group, we require its"},{"line_number":78,"context_line":"            #  id be specified as a param."},{"line_number":79,"context_line":"            if share.get(\u0027share_group_id\u0027):"},{"line_number":80,"context_line":"                share_group_id \u003d req.params.get(\u0027share_group_id\u0027)"},{"line_number":81,"context_line":"                if (share.get(\u0027share_group_id\u0027) and"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_117e43e4","line":78,"range":{"start_line":78,"start_character":14,"end_line":78,"end_character":15},"updated":"2016-08-09 02:42:28.000000000","message":"redundant space.","commit_id":"9a8b0c8aea83b8339caacceea0a6b35768ad7272"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"dcc172999a1249b3b39518be1756f648f228fd11","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            \u0027display_name\u0027, \u0027status\u0027, \u0027share_server_id\u0027, \u0027volume_type_id\u0027,"},{"line_number":237,"context_line":"            \u0027share_type_id\u0027, \u0027snapshot_id\u0027, \u0027host\u0027, \u0027share_network_id\u0027,"},{"line_number":238,"context_line":"            \u0027is_public\u0027, \u0027metadata\u0027, \u0027extra_specs\u0027, \u0027sort_key\u0027, \u0027sort_dir\u0027,"},{"line_number":239,"context_line":"            \u0027share_group_id\u0027, \u0027cgsnapshot_id\u0027"},{"line_number":240,"context_line":"        )"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def update(self, req, id, body):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_f120cff9","line":239,"range":{"start_line":239,"start_character":31,"end_line":239,"end_character":44},"updated":"2016-08-09 02:42:28.000000000","message":"still have cgsnapshot_id?","commit_id":"9a8b0c8aea83b8339caacceea0a6b35768ad7272"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"ff260e4fa4c2dcd0d4d3af139cee05107974d2b3","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            \u0027display_name\u0027, \u0027status\u0027, \u0027share_server_id\u0027, \u0027volume_type_id\u0027,"},{"line_number":237,"context_line":"            \u0027share_type_id\u0027, \u0027snapshot_id\u0027, \u0027host\u0027, \u0027share_network_id\u0027,"},{"line_number":238,"context_line":"            \u0027is_public\u0027, \u0027metadata\u0027, \u0027extra_specs\u0027, \u0027sort_key\u0027, \u0027sort_dir\u0027,"},{"line_number":239,"context_line":"            \u0027share_group_id\u0027, \u0027cgsnapshot_id\u0027"},{"line_number":240,"context_line":"        )"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def update(self, req, id, body):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_bc535916","line":239,"range":{"start_line":239,"start_character":31,"end_line":239,"end_character":44},"in_reply_to":"9ad45d7e_f120cff9","updated":"2016-08-10 20:30:15.000000000","message":"Done","commit_id":"9a8b0c8aea83b8339caacceea0a6b35768ad7272"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            # NOTE(ameade): If the share is in a share group, we require its"},{"line_number":78,"context_line":"            # id be specified as a param."},{"line_number":79,"context_line":"            if share.get(\u0027share_group_id\u0027):"},{"line_number":80,"context_line":"                share_group_id \u003d req.params.get(\u0027share_group_id\u0027)"},{"line_number":81,"context_line":"                if (share.get(\u0027share_group_id\u0027) and"},{"line_number":82,"context_line":"                        not share_group_id):"},{"line_number":83,"context_line":"                    msg \u003d _(\"Must provide \u0027share_group_id\u0027 as a request \""}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_2c6887ba","line":80,"range":{"start_line":80,"start_character":49,"end_line":80,"end_character":63},"updated":"2016-11-07 12:20:01.000000000","message":"Considering amount of usages of this string, I suggest you using variable with its value, to avoid possible bugs related to typos.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            # id be specified as a param."},{"line_number":79,"context_line":"            if share.get(\u0027share_group_id\u0027):"},{"line_number":80,"context_line":"                share_group_id \u003d req.params.get(\u0027share_group_id\u0027)"},{"line_number":81,"context_line":"                if (share.get(\u0027share_group_id\u0027) and"},{"line_number":82,"context_line":"                        not share_group_id):"},{"line_number":83,"context_line":"                    msg \u003d _(\"Must provide \u0027share_group_id\u0027 as a request \""},{"line_number":84,"context_line":"                            \"parameter when deleting a share in a share \""}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_6cb99f2e","line":81,"range":{"start_line":81,"start_character":20,"end_line":81,"end_character":47},"updated":"2016-11-07 12:20:01.000000000","message":"It is always true. Because we already checked it on line 79.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"}],"manila/api/v2/group_snapshots.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        if not self.is_valid_body(body, \u0027group_snapshot\u0027):"},{"line_number":123,"context_line":"            msg \u003d _(\"\u0027group_snapshot\u0027 is missing from the request body\")"},{"line_number":124,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        group_data \u003d body[\u0027group_snapshot\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_a9efd585","line":123,"range":{"start_line":123,"start_character":69,"end_line":123,"end_character":71},"updated":"2016-08-22 12:59:09.000000000","message":"period","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        if not self.is_valid_body(body, \u0027group_snapshot\u0027):"},{"line_number":123,"context_line":"            msg \u003d _(\"\u0027group_snapshot\u0027 is missing from the request body\")"},{"line_number":124,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        group_data \u003d body[\u0027group_snapshot\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_b2c62d98","line":123,"range":{"start_line":123,"start_character":69,"end_line":123,"end_character":71},"in_reply_to":"1ac06dbe_a9efd585","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        if not self.is_valid_body(body, \u0027group_snapshot\u0027):"},{"line_number":154,"context_line":"            msg \u003d _(\"\u0027group_snapshot\u0027 is missing from the request body\")"},{"line_number":155,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        group_snapshot \u003d body.get(\u0027group_snapshot\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_09d8a9ee","line":154,"range":{"start_line":154,"start_character":69,"end_line":154,"end_character":71},"updated":"2016-08-22 12:59:09.000000000","message":"period","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        if not self.is_valid_body(body, \u0027group_snapshot\u0027):"},{"line_number":154,"context_line":"            msg \u003d _(\"\u0027group_snapshot\u0027 is missing from the request body\")"},{"line_number":155,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        group_snapshot \u003d body.get(\u0027group_snapshot\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_32393da5","line":154,"range":{"start_line":154,"start_character":69,"end_line":154,"end_character":71},"in_reply_to":"1ac06dbe_09d8a9ee","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \"\"\"Return data about the given group snapshot.\"\"\""},{"line_number":47,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        try:"},{"line_number":50,"context_line":"            group \u003d self.group_api.get_group_snapshot(context, id)"},{"line_number":51,"context_line":"        except exception.NotFound:"},{"line_number":52,"context_line":"            msg \u003d _(\"share group snapshot %s not found.\") % id"},{"line_number":53,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        return self._view_builder.detail(req, group)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_a31ae56c","line":53,"range":{"start_line":49,"start_character":8,"end_line":53,"end_character":51},"updated":"2016-11-07 12:20:01.000000000","message":"Same as in https://review.openstack.org/#/c/335093/27/manila/api/v2/share_groups.py\n\nBetter to move to separate private method.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @wsgi.Controller.api_version(\u00272.23\u0027, experimental\u003dTrue)"},{"line_number":58,"context_line":"    @wsgi.Controller.authorize"},{"line_number":59,"context_line":"    def delete(self, req, id):"},{"line_number":60,"context_line":"        \"\"\"Delete a group snapshot.\"\"\""},{"line_number":61,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_43af49e3","line":59,"range":{"start_line":59,"start_character":26,"end_line":59,"end_character":28},"updated":"2016-11-07 12:20:01.000000000","message":"I would prefer to avoid redefinition of built-ins.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    def _delete(self, context, resource, force\u003dTrue):"},{"line_number":213,"context_line":"        db.group_snapshot_destroy(context.elevated(), resource[\u0027id\u0027])"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    @wsgi.Controller.api_version(\u00272.23\u0027, experimental\u003dTrue)"},{"line_number":216,"context_line":"    @wsgi.action(\u0027os-reset_status\u0027)"},{"line_number":217,"context_line":"    def group_snapshot_reset_status_legacy(self, req, id, body):"},{"line_number":218,"context_line":"        return self._reset_status(req, id, body)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    @wsgi.Controller.api_version(\u00272.23\u0027, experimental\u003dTrue)"},{"line_number":221,"context_line":"    @wsgi.action(\u0027reset_status\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_e3d4dd48","line":218,"range":{"start_line":215,"start_character":4,"end_line":218,"end_character":48},"updated":"2016-11-07 12:20:01.000000000","message":"It should be removed. It is relevant only for 2.6- microversions.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    def group_snapshot_reset_status(self, req, id, body):"},{"line_number":223,"context_line":"        return self._reset_status(req, id, body)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @wsgi.Controller.api_version(\u00272.23\u0027, experimental\u003dTrue)"},{"line_number":226,"context_line":"    @wsgi.action(\u0027os-force_delete\u0027)"},{"line_number":227,"context_line":"    def group_snapshot_force_delete_legacy(self, req, id, body):"},{"line_number":228,"context_line":"        return self._force_delete(req, id, body)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    @wsgi.Controller.api_version(\u00272.23\u0027, experimental\u003dTrue)"},{"line_number":231,"context_line":"    @wsgi.action(\u0027force_delete\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_43c4a991","line":228,"range":{"start_line":225,"start_character":4,"end_line":228,"end_character":48},"updated":"2016-11-07 12:20:01.000000000","message":"Ditto","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"}],"manila/api/v2/group_types.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        try:"},{"line_number":59,"context_line":"            group_type \u003d group_types.get_group_type(context, id)"},{"line_number":60,"context_line":"        except exception.NotFound:"},{"line_number":61,"context_line":"            msg \u003d _(\"Group type not found.\")"},{"line_number":62,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        group_type[\u0027id\u0027] \u003d six.text_type(group_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_8403e00c","line":61,"range":{"start_line":61,"start_character":30,"end_line":61,"end_character":38},"updated":"2016-08-22 12:59:09.000000000","message":"in group_snapshots.py you log the ID when it is not found. You could do the same here.","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        try:"},{"line_number":59,"context_line":"            group_type \u003d group_types.get_group_type(context, id)"},{"line_number":60,"context_line":"        except exception.NotFound:"},{"line_number":61,"context_line":"            msg \u003d _(\"Group type not found.\")"},{"line_number":62,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        group_type[\u0027id\u0027] \u003d six.text_type(group_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_925be9f5","line":61,"range":{"start_line":61,"start_character":30,"end_line":61,"end_character":38},"in_reply_to":"1ac06dbe_8403e00c","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        group_type \u003d group_types.get_default_group_type(context)"},{"line_number":74,"context_line":"        if not group_type:"},{"line_number":75,"context_line":"            msg \u003d _(\"Default group type not found\")"},{"line_number":76,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        group_type[\u0027id\u0027] \u003d six.text_type(group_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_297925c9","line":75,"range":{"start_line":75,"start_character":48,"end_line":75,"end_character":50},"updated":"2016-08-22 12:59:09.000000000","message":"period","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        is_public \u003d group_type.get(\u0027is_public\u0027, True)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if not group_type.get(\u0027share_types\u0027):"},{"line_number":133,"context_line":"            msg \u003d _(\"Supported share types must be provided\")"},{"line_number":134,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":135,"context_line":"        share_types \u003d group_type.get(\u0027share_types\u0027)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_c424b8b0","line":133,"range":{"start_line":133,"start_character":58,"end_line":133,"end_character":60},"updated":"2016-08-22 12:59:09.000000000","message":"period","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        is_public \u003d group_type.get(\u0027is_public\u0027, True)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if not group_type.get(\u0027share_types\u0027):"},{"line_number":133,"context_line":"            msg \u003d _(\"Supported share types must be provided\")"},{"line_number":134,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":135,"context_line":"        share_types \u003d group_type.get(\u0027share_types\u0027)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_32077dcb","line":133,"range":{"start_line":133,"start_character":58,"end_line":133,"end_character":60},"in_reply_to":"1ac06dbe_c424b8b0","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            group_type \u003d group_types.get_group_type(context, id)"},{"line_number":160,"context_line":"            group_types.destroy(context, group_type[\u0027id\u0027])"},{"line_number":161,"context_line":"        except exception.GroupTypeInUse:"},{"line_number":162,"context_line":"            msg \u003d _(\u0027Target group type is still in use.\u0027)"},{"line_number":163,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":164,"context_line":"        except exception.NotFound:"},{"line_number":165,"context_line":"            raise webob.exc.HTTPNotFound()"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_c4a958e1","line":162,"range":{"start_line":162,"start_character":38,"end_line":162,"end_character":40},"updated":"2016-08-22 12:59:09.000000000","message":"you could include the ID here","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            group_type \u003d group_types.get_group_type(context, id)"},{"line_number":160,"context_line":"            group_types.destroy(context, group_type[\u0027id\u0027])"},{"line_number":161,"context_line":"        except exception.GroupTypeInUse:"},{"line_number":162,"context_line":"            msg \u003d _(\u0027Target group type is still in use.\u0027)"},{"line_number":163,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":164,"context_line":"        except exception.NotFound:"},{"line_number":165,"context_line":"            raise webob.exc.HTTPNotFound()"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_b222ad50","line":162,"range":{"start_line":162,"start_character":38,"end_line":162,"end_character":40},"in_reply_to":"1ac06dbe_c4a958e1","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"}],"manila/api/v2/group_types_extra_specs.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def update(self, req, type_id, key, body\u003dNone):"},{"line_number":86,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":87,"context_line":"        if not body:"},{"line_number":88,"context_line":"            expl \u003d _(\u0027Request body empty\u0027)"},{"line_number":89,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexpl)"},{"line_number":90,"context_line":"        self._assert_group_type_exists(context, type_id)"},{"line_number":91,"context_line":"        if key not in body:"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_a4d1bc59","line":88,"range":{"start_line":88,"start_character":39,"end_line":88,"end_character":41},"updated":"2016-08-22 12:59:09.000000000","message":"period","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def update(self, req, type_id, key, body\u003dNone):"},{"line_number":86,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":87,"context_line":"        if not body:"},{"line_number":88,"context_line":"            expl \u003d _(\u0027Request body empty\u0027)"},{"line_number":89,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexpl)"},{"line_number":90,"context_line":"        self._assert_group_type_exists(context, type_id)"},{"line_number":91,"context_line":"        if key not in body:"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_32d5bd1b","line":88,"range":{"start_line":88,"start_character":39,"end_line":88,"end_character":41},"in_reply_to":"1ac06dbe_a4d1bc59","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexpl)"},{"line_number":90,"context_line":"        self._assert_group_type_exists(context, type_id)"},{"line_number":91,"context_line":"        if key not in body:"},{"line_number":92,"context_line":"            expl \u003d _(\u0027Request body and URI mismatch\u0027)"},{"line_number":93,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexpl)"},{"line_number":94,"context_line":"        if len(body) \u003e 1:"},{"line_number":95,"context_line":"            expl \u003d _(\u0027Request body contains too many items\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_84d48047","line":92,"range":{"start_line":92,"start_character":50,"end_line":92,"end_character":52},"updated":"2016-08-22 12:59:09.000000000","message":"period","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexpl)"},{"line_number":90,"context_line":"        self._assert_group_type_exists(context, type_id)"},{"line_number":91,"context_line":"        if key not in body:"},{"line_number":92,"context_line":"            expl \u003d _(\u0027Request body and URI mismatch\u0027)"},{"line_number":93,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexpl)"},{"line_number":94,"context_line":"        if len(body) \u003e 1:"},{"line_number":95,"context_line":"            expl \u003d _(\u0027Request body contains too many items\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_52da314d","line":92,"range":{"start_line":92,"start_character":50,"end_line":92,"end_character":52},"in_reply_to":"1ac06dbe_84d48047","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            expl \u003d _(\u0027Request body and URI mismatch\u0027)"},{"line_number":93,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexpl)"},{"line_number":94,"context_line":"        if len(body) \u003e 1:"},{"line_number":95,"context_line":"            expl \u003d _(\u0027Request body contains too many items\u0027)"},{"line_number":96,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexpl)"},{"line_number":97,"context_line":"        self._verify_extra_specs(body)"},{"line_number":98,"context_line":"        db.group_type_extra_specs_update_or_create(context, type_id, body)"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_c4ce78b3","line":95,"range":{"start_line":95,"start_character":57,"end_line":95,"end_character":59},"updated":"2016-08-22 12:59:09.000000000","message":"period","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            expl \u003d _(\u0027Request body and URI mismatch\u0027)"},{"line_number":93,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexpl)"},{"line_number":94,"context_line":"        if len(body) \u003e 1:"},{"line_number":95,"context_line":"            expl \u003d _(\u0027Request body contains too many items\u0027)"},{"line_number":96,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexpl)"},{"line_number":97,"context_line":"        self._verify_extra_specs(body)"},{"line_number":98,"context_line":"        db.group_type_extra_specs_update_or_create(context, type_id, body)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_72dbb54f","line":95,"range":{"start_line":95,"start_character":57,"end_line":95,"end_character":59},"in_reply_to":"1ac06dbe_c4ce78b3","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"}],"manila/api/v2/router.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                       controller\u003dself.resources[\"group-extra-specs\"],"},{"line_number":312,"context_line":"                       action\u003d\u0027index\u0027,"},{"line_number":313,"context_line":"                       conditions\u003d{\"method\": [\"GET\"]})"},{"line_number":314,"context_line":"        # NOTE(ameade): Do we need this post to extra-specs? this isn\u0027t"},{"line_number":315,"context_line":"        # right it\u0027s doing a put type of action."},{"line_number":316,"context_line":"        mapper.connect(\"group-types\","},{"line_number":317,"context_line":"                       \"/{project_id}/group-types/{type_id}/extra-specs\","},{"line_number":318,"context_line":"                       controller\u003dself.resources[\"group-extra-specs\"],"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_23b5f5cc","line":315,"range":{"start_line":314,"start_character":8,"end_line":315,"end_character":48},"updated":"2016-11-07 12:20:01.000000000","message":"It is new API, you decide what to do.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9f67f41b514294e7dcb484cb32d477a94c86dd27","unresolved":false,"context_lines":[{"line_number":292,"context_line":"            \"/{project_id}/share-groups/{id}/action\","},{"line_number":293,"context_line":"            controller\u003dself.resources[\"share-groups\"],"},{"line_number":294,"context_line":"            action\u003d\"action\","},{"line_number":295,"context_line":"            conditions\u003d{\"action\": [\"POST\"]})"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        self.resources[\"share-group-types\"] \u003d ("},{"line_number":298,"context_line":"            share_group_types.create_resource())"}],"source_content_type":"text/x-python","patch_set":29,"id":"da4df55a_abbb8574","line":295,"updated":"2016-12-21 22:55:32.000000000","message":"The doc says conditions should use \"method\" as key, not \"action\".  Both work but it is better to follow the doc.\n\nhttps://routes.readthedocs.io/en/latest/setting_up.html#conditions","commit_id":"7ed2a8e0320841cdc6a5f70683891048369bd5c4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f2edc3f895c618b7e809e72a11f5c459c4fa32eb","unresolved":false,"context_lines":[{"line_number":292,"context_line":"            \"/{project_id}/share-groups/{id}/action\","},{"line_number":293,"context_line":"            controller\u003dself.resources[\"share-groups\"],"},{"line_number":294,"context_line":"            action\u003d\"action\","},{"line_number":295,"context_line":"            conditions\u003d{\"action\": [\"POST\"]})"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        self.resources[\"share-group-types\"] \u003d ("},{"line_number":298,"context_line":"            share_group_types.create_resource())"}],"source_content_type":"text/x-python","patch_set":29,"id":"da4df55a_121d8f73","line":295,"in_reply_to":"da4df55a_abbb8574","updated":"2016-12-22 11:33:27.000000000","message":"Done","commit_id":"7ed2a8e0320841cdc6a5f70683891048369bd5c4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9f67f41b514294e7dcb484cb32d477a94c86dd27","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            \"/{project_id}/share-group-snapshots/{id}/action\","},{"line_number":360,"context_line":"            controller\u003dself.resources[\"share-group-snapshots\"],"},{"line_number":361,"context_line":"            action\u003d\"action\","},{"line_number":362,"context_line":"            conditions\u003d{\"action\": [\"POST\"]})"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        self.resources[\u0027share-replicas\u0027] \u003d share_replicas.create_resource()"},{"line_number":365,"context_line":"        mapper.resource(\"share-replica\", \"share-replicas\","}],"source_content_type":"text/x-python","patch_set":29,"id":"da4df55a_4badb930","line":362,"updated":"2016-12-21 22:55:32.000000000","message":"Same as above.","commit_id":"7ed2a8e0320841cdc6a5f70683891048369bd5c4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f2edc3f895c618b7e809e72a11f5c459c4fa32eb","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            \"/{project_id}/share-group-snapshots/{id}/action\","},{"line_number":360,"context_line":"            controller\u003dself.resources[\"share-group-snapshots\"],"},{"line_number":361,"context_line":"            action\u003d\"action\","},{"line_number":362,"context_line":"            conditions\u003d{\"action\": [\"POST\"]})"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        self.resources[\u0027share-replicas\u0027] \u003d share_replicas.create_resource()"},{"line_number":365,"context_line":"        mapper.resource(\"share-replica\", \"share-replicas\","}],"source_content_type":"text/x-python","patch_set":29,"id":"da4df55a_720c1b43","line":362,"in_reply_to":"da4df55a_4badb930","updated":"2016-12-22 11:33:27.000000000","message":"Done","commit_id":"7ed2a8e0320841cdc6a5f70683891048369bd5c4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"06dc557190b6e4ac3434ccf657d14a3c9926db44","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            \"share-group\","},{"line_number":288,"context_line":"            \"share-groups\","},{"line_number":289,"context_line":"            controller\u003dself.resources[\"share-groups\"],"},{"line_number":290,"context_line":"            collection\u003d{\"detail\": \"GET\"})"},{"line_number":291,"context_line":"        mapper.connect("},{"line_number":292,"context_line":"            \"share-groups\","},{"line_number":293,"context_line":"            \"/{project_id}/share-groups/{id}/action\","}],"source_content_type":"text/x-python","patch_set":43,"id":"7a3c09a3_2dd35b61","line":290,"updated":"2017-01-18 05:23:50.000000000","message":"This should have member\u003d{\"action\": \"POST\"} like shares on line 149.","commit_id":"7ebc704c577d99bc91cfd3bd7c97601977076817"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"38970b2a5764531a59e202e65ac53129895c16d9","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            \"share-group\","},{"line_number":288,"context_line":"            \"share-groups\","},{"line_number":289,"context_line":"            controller\u003dself.resources[\"share-groups\"],"},{"line_number":290,"context_line":"            collection\u003d{\"detail\": \"GET\"})"},{"line_number":291,"context_line":"        mapper.connect("},{"line_number":292,"context_line":"            \"share-groups\","},{"line_number":293,"context_line":"            \"/{project_id}/share-groups/{id}/action\","}],"source_content_type":"text/x-python","patch_set":43,"id":"7a3c09a3_7cf097c9","line":290,"in_reply_to":"7a3c09a3_2dd35b61","updated":"2017-01-18 16:16:36.000000000","message":"291-296","commit_id":"7ebc704c577d99bc91cfd3bd7c97601977076817"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"e5a02fc28c9d31beb0d06621563667b0eeda2578","unresolved":false,"context_lines":[{"line_number":320,"context_line":"            controller\u003dself.resources[\"group-specs\"],"},{"line_number":321,"context_line":"            action\u003d\"index\","},{"line_number":322,"context_line":"            conditions\u003d{\"method\": [\"GET\"]})"},{"line_number":323,"context_line":"        # NOTE(ameade): Do we need this post to extra-specs? this isn\u0027t"},{"line_number":324,"context_line":"        # right it\u0027s doing a put type of action."},{"line_number":325,"context_line":"        mapper.connect("},{"line_number":326,"context_line":"            \"share-group-types\","},{"line_number":327,"context_line":"            \"/{project_id}/share-group-types/{id}/group-specs\","}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_00ac0633","line":324,"range":{"start_line":323,"start_character":1,"end_line":324,"end_character":48},"updated":"2017-01-20 23:37:06.000000000","message":"Resolved?","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95a36d4def7067fd2f61c30355424a3336b1c626","unresolved":false,"context_lines":[{"line_number":320,"context_line":"            controller\u003dself.resources[\"group-specs\"],"},{"line_number":321,"context_line":"            action\u003d\"index\","},{"line_number":322,"context_line":"            conditions\u003d{\"method\": [\"GET\"]})"},{"line_number":323,"context_line":"        # NOTE(ameade): Do we need this post to extra-specs? this isn\u0027t"},{"line_number":324,"context_line":"        # right it\u0027s doing a put type of action."},{"line_number":325,"context_line":"        mapper.connect("},{"line_number":326,"context_line":"            \"share-group-types\","},{"line_number":327,"context_line":"            \"/{project_id}/share-group-types/{id}/group-specs\","}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_75446e1a","line":324,"range":{"start_line":323,"start_character":1,"end_line":324,"end_character":48},"in_reply_to":"5a3905b3_00ac0633","updated":"2017-01-23 13:07:01.000000000","message":"Removing comment, because \"put\" is defined on lines 343-348.\n\nLogic defined on lines 325-330 cannot be PUT, because of the URL it uses. It does not end with resource ID. And bound method to this URL always creates new resource. \"PUT\" is either update of existing one or placement of resource inner data using unique ID, which is absent here.","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"}],"manila/api/v2/share_group_snapshots.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9f67f41b514294e7dcb484cb32d477a94c86dd27","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        search_opts \u003d {}"},{"line_number":184,"context_line":"        search_opts.update(req.GET)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # Remove keys that are not related to group attrs"},{"line_number":187,"context_line":"        search_opts.pop(\u0027limit\u0027, None)"},{"line_number":188,"context_line":"        search_opts.pop(\u0027offset\u0027, None)"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"da4df55a_c630c0a1","line":186,"updated":"2016-12-21 22:55:32.000000000","message":"group snapshot","commit_id":"7ed2a8e0320841cdc6a5f70683891048369bd5c4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f2edc3f895c618b7e809e72a11f5c459c4fa32eb","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        search_opts \u003d {}"},{"line_number":184,"context_line":"        search_opts.update(req.GET)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # Remove keys that are not related to group attrs"},{"line_number":187,"context_line":"        search_opts.pop(\u0027limit\u0027, None)"},{"line_number":188,"context_line":"        search_opts.pop(\u0027offset\u0027, None)"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"da4df55a_b2fcc33f","line":186,"in_reply_to":"da4df55a_c630c0a1","updated":"2016-12-22 11:33:27.000000000","message":"And the fact that \"search_opts\" are not used does not make you sad? ))","commit_id":"7ed2a8e0320841cdc6a5f70683891048369bd5c4"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"e5a02fc28c9d31beb0d06621563667b0eeda2578","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        share_group_snapshot \u003d body.get(\u0027share_group_snapshot\u0027, {})"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        if not share_group_snapshot.get(\u0027share_group_id\u0027, {}):"},{"line_number":151,"context_line":"            msg \u003d _(\"Must supply \u0027share_group_id\u0027 attribute.\")"},{"line_number":152,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_abd233fe","line":150,"range":{"start_line":150,"start_character":57,"end_line":150,"end_character":60},"updated":"2017-01-20 23:37:06.000000000","message":"default looks unnecessary","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95a36d4def7067fd2f61c30355424a3336b1c626","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        share_group_snapshot \u003d body.get(\u0027share_group_snapshot\u0027, {})"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        if not share_group_snapshot.get(\u0027share_group_id\u0027, {}):"},{"line_number":151,"context_line":"            msg \u003d _(\"Must supply \u0027share_group_id\u0027 attribute.\")"},{"line_number":152,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_99a83a79","line":150,"range":{"start_line":150,"start_character":57,"end_line":150,"end_character":60},"in_reply_to":"5a3905b3_abd233fe","updated":"2017-01-23 13:07:01.000000000","message":"Done","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"e5a02fc28c9d31beb0d06621563667b0eeda2578","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        share_group_id \u003d share_group_snapshot.get(\u0027share_group_id\u0027)"},{"line_number":155,"context_line":"        if (share_group_id and"},{"line_number":156,"context_line":"                not uuidutils.is_uuid_like(share_group_id)):"},{"line_number":157,"context_line":"            msg \u003d _(\"The \u0027share_group_id\u0027 attribute must be a uuid.\")"},{"line_number":158,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dsix.text_type(msg))"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_ab55d350","line":155,"range":{"start_line":155,"start_character":12,"end_line":155,"end_character":30},"updated":"2017-01-20 23:37:06.000000000","message":"share_group_id is always true here. Tested above.","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95a36d4def7067fd2f61c30355424a3336b1c626","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        share_group_id \u003d share_group_snapshot.get(\u0027share_group_id\u0027)"},{"line_number":155,"context_line":"        if (share_group_id and"},{"line_number":156,"context_line":"                not uuidutils.is_uuid_like(share_group_id)):"},{"line_number":157,"context_line":"            msg \u003d _(\"The \u0027share_group_id\u0027 attribute must be a uuid.\")"},{"line_number":158,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dsix.text_type(msg))"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_b9b7b6d6","line":155,"range":{"start_line":155,"start_character":12,"end_line":155,"end_character":30},"in_reply_to":"5a3905b3_ab55d350","updated":"2017-01-23 13:07:01.000000000","message":"Done","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"}],"manila/api/v2/share_group_types.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"e5a02fc28c9d31beb0d06621563667b0eeda2578","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            filters[\u0027is_public\u0027] \u003d self._parse_is_public("},{"line_number":84,"context_line":"                req.params.get(\u0027is_public\u0027))"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            # TODO(ameade): Is this correct? can I still see private types"},{"line_number":87,"context_line":"            # shared with me?"},{"line_number":88,"context_line":"            filters[\u0027is_public\u0027] \u003d True"},{"line_number":89,"context_line":"        limited_types \u003d share_group_types.get_all("},{"line_number":90,"context_line":"            context, search_opts\u003dfilters).values()"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_2c9659f0","line":87,"range":{"start_line":86,"start_character":0,"end_line":87,"end_character":29},"updated":"2017-01-20 23:37:06.000000000","message":"TODO - to be answered or bug filed?","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95a36d4def7067fd2f61c30355424a3336b1c626","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            filters[\u0027is_public\u0027] \u003d self._parse_is_public("},{"line_number":84,"context_line":"                req.params.get(\u0027is_public\u0027))"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            # TODO(ameade): Is this correct? can I still see private types"},{"line_number":87,"context_line":"            # shared with me?"},{"line_number":88,"context_line":"            filters[\u0027is_public\u0027] \u003d True"},{"line_number":89,"context_line":"        limited_types \u003d share_group_types.get_all("},{"line_number":90,"context_line":"            context, search_opts\u003dfilters).values()"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_d418c9d5","line":87,"range":{"start_line":86,"start_character":0,"end_line":87,"end_character":29},"in_reply_to":"5a3905b3_2c9659f0","updated":"2017-01-23 13:07:01.000000000","message":"Removing this comment as redundant and confusing. Current logic is following:\n\n- if value is specified, then such type of share group types will be returned.\nAdmin can get any private share group type.\nMember can get private share group types he (project_id) is added to access list.","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"e5a02fc28c9d31beb0d06621563667b0eeda2578","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def _parse_is_public(is_public):"},{"line_number":95,"context_line":"        \"\"\"Parse is_public into something usable."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        * True: API should list public share group types only"},{"line_number":98,"context_line":"        * False: API should list private share group types only"},{"line_number":99,"context_line":"        * None: API should list both public and private share group types"},{"line_number":100,"context_line":"        \"\"\""},{"line_number":101,"context_line":"        if is_public is None:"},{"line_number":102,"context_line":"            # preserve default value of showing only public types"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_ac26c9cb","line":99,"range":{"start_line":97,"start_character":3,"end_line":99,"end_character":73},"updated":"2017-01-20 23:37:06.000000000","message":"this should say \"returns\" because otherwise it looks too much like it is describing the param.","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95a36d4def7067fd2f61c30355424a3336b1c626","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def _parse_is_public(is_public):"},{"line_number":95,"context_line":"        \"\"\"Parse is_public into something usable."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        * True: API should list public share group types only"},{"line_number":98,"context_line":"        * False: API should list private share group types only"},{"line_number":99,"context_line":"        * None: API should list both public and private share group types"},{"line_number":100,"context_line":"        \"\"\""},{"line_number":101,"context_line":"        if is_public is None:"},{"line_number":102,"context_line":"            # preserve default value of showing only public types"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_9944bab7","line":99,"range":{"start_line":97,"start_character":3,"end_line":99,"end_character":73},"in_reply_to":"5a3905b3_ac26c9cb","updated":"2017-01-23 13:07:01.000000000","message":"Done","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"}],"manila/api/v2/share_groups.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    @wsgi.response(202)"},{"line_number":153,"context_line":"    @wsgi.Controller.authorize"},{"line_number":154,"context_line":"    def create(self, req, body):"},{"line_number":155,"context_line":"        \"\"\"Creates a new share.\"\"\""},{"line_number":156,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if not self.is_valid_body(body, \u0027group\u0027):"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_c4af9892","line":155,"range":{"start_line":155,"start_character":24,"end_line":155,"end_character":33},"updated":"2016-08-22 12:59:09.000000000","message":"a new share in group","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    @wsgi.response(202)"},{"line_number":153,"context_line":"    @wsgi.Controller.authorize"},{"line_number":154,"context_line":"    def create(self, req, body):"},{"line_number":155,"context_line":"        \"\"\"Creates a new share.\"\"\""},{"line_number":156,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if not self.is_valid_body(body, \u0027group\u0027):"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_92b769f4","line":155,"range":{"start_line":155,"start_character":24,"end_line":155,"end_character":33},"in_reply_to":"1ac06dbe_c4af9892","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        LOG.info(_LI(\"Delete share group with id: %s\"), id, context\u003dcontext)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        try:"},{"line_number":69,"context_line":"            group \u003d self.group_api.get(context, id)"},{"line_number":70,"context_line":"        except exception.NotFound:"},{"line_number":71,"context_line":"            msg \u003d _(\"Share group %s not found.\") % id"},{"line_number":72,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        try:"},{"line_number":75,"context_line":"            self.group_api.delete(context, group)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_cc938b4e","line":72,"range":{"start_line":68,"start_character":8,"end_line":72,"end_character":51},"updated":"2016-11-07 12:20:01.000000000","message":"This block of code is used lots of times in this module. So, it screams to be separated to private method.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        group \u003d body[\u0027group\u0027]"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        valid_fields \u003d {\u0027name\u0027, \u0027description\u0027, \u0027share_types\u0027,"},{"line_number":165,"context_line":"                        \u0027group_type_id\u0027, \u0027source_group_snapshot_id\u0027,"},{"line_number":166,"context_line":"                        \u0027share_network_id\u0027}"},{"line_number":167,"context_line":"        invalid_fields \u003d set(group.keys()) - valid_fields"},{"line_number":168,"context_line":"        if invalid_fields:"},{"line_number":169,"context_line":"            msg \u003d _(\"The fields %s are invalid.\") % invalid_fields"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_2c26c716","line":166,"range":{"start_line":164,"start_character":8,"end_line":166,"end_character":43},"updated":"2016-11-07 12:20:01.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        \"\"\"Creates a new share group.\"\"\""},{"line_number":156,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if not self.is_valid_body(body, \u0027group\u0027):"},{"line_number":159,"context_line":"            msg \u003d _(\"\u0027group\u0027 is missing from the request body.\")"},{"line_number":160,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        group \u003d body[\u0027group\u0027]"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        valid_fields \u003d {\u0027name\u0027, \u0027description\u0027, \u0027share_types\u0027,"},{"line_number":165,"context_line":"                        \u0027group_type_id\u0027, \u0027source_group_snapshot_id\u0027,"},{"line_number":166,"context_line":"                        \u0027share_network_id\u0027}"},{"line_number":167,"context_line":"        invalid_fields \u003d set(group.keys()) - valid_fields"},{"line_number":168,"context_line":"        if invalid_fields:"},{"line_number":169,"context_line":"            msg \u003d _(\"The fields %s are invalid.\") % invalid_fields"},{"line_number":170,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        if \u0027share_types\u0027 in group and \u0027source_group_snapshot_id\u0027 in group:"},{"line_number":173,"context_line":"            msg \u003d _(\"Cannot supply both \u0027share_types\u0027 and \""}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_8c1d13c0","line":170,"range":{"start_line":158,"start_character":8,"end_line":170,"end_character":53},"updated":"2016-11-07 12:20:01.000000000","message":"This part is copy-pasted too.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                    \"\u0027source_group_snapshot_id\u0027 attributes.\")"},{"line_number":175,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        if (not group.get(\u0027share_types\u0027) and"},{"line_number":178,"context_line":"                \u0027source_group_snapshot_id\u0027 not in group):"},{"line_number":179,"context_line":"            default_share_type \u003d share_types.get_default_share_type()"},{"line_number":180,"context_line":"            if default_share_type:"},{"line_number":181,"context_line":"                group[\u0027share_types\u0027] \u003d [default_share_type[\u0027id\u0027]]"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_cccb8b1d","line":178,"range":{"start_line":177,"start_character":8,"end_line":178,"end_character":57},"updated":"2016-11-07 12:20:01.000000000","message":"Two \"not\"s should be transformed into one:\n\n\"\"\"\nif not (group.get(\u0027share_types\u0027) or \u0027source_group_snapshot_id\u0027 in group):\n\"\"\"","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        _share_types \u003d group.get(\u0027share_types\u0027)"},{"line_number":195,"context_line":"        if _share_types:"},{"line_number":196,"context_line":"            if not all([uuidutils.is_uuid_like(st) for st in _share_types]):"},{"line_number":197,"context_line":"                msg \u003d _(\"The \u0027share_types\u0027 attribute must be a list of uuids\")"},{"line_number":198,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":199,"context_line":"            kwargs[\u0027share_type_ids\u0027] \u003d _share_types"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        if \u0027share_network_id\u0027 in group and \u0027source_group_snapshot_id\u0027 in group:"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_ec112f5f","line":198,"range":{"start_line":196,"start_character":12,"end_line":198,"end_character":57},"updated":"2016-11-07 12:20:01.000000000","message":"Why we do not allow share type names? They are unique.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"}],"manila/api/v2/share_types.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            notifier_err \u003d dict(id\u003did, error_message\u003dsix.text_type(err))"},{"line_number":201,"context_line":"            self._notify_share_type_error(context, \u0027share_type.delete\u0027,"},{"line_number":202,"context_line":"                                          notifier_err)"},{"line_number":203,"context_line":"            msg \u003d _(\u0027Target share type is still in use.\u0027)"},{"line_number":204,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":205,"context_line":"        except exception.NotFound as err:"},{"line_number":206,"context_line":"            notifier_err \u003d dict(id\u003did, error_message\u003dsix.text_type(err))"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_4372e97d","line":203,"updated":"2016-11-07 12:20:01.000000000","message":"Unrelated change in already big patch. Please, avoid it.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"}],"manila/api/v2/shares.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c370882fc617bf74749698a5a84166acaf82710c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(self.__class__, self).__init__()"},{"line_number":36,"context_line":"        self.share_api \u003d share.API()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @wsgi.Controller.api_version(\"2.5\")"},{"line_number":39,"context_line":"    def create(self, req, body):"},{"line_number":40,"context_line":"        return self._create(req, body)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_dff083cb","line":38,"updated":"2016-08-01 21:50:48.000000000","message":"This should be 2.19 now as group APIs are at 2.19.","commit_id":"1a3f2324a89e103bd1f6364a55185b3459d48396"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"6541045839cff8218bfa0a29be338f304ae437ec","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(self.__class__, self).__init__()"},{"line_number":36,"context_line":"        self.share_api \u003d share.API()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @wsgi.Controller.api_version(\"2.5\")"},{"line_number":39,"context_line":"    def create(self, req, body):"},{"line_number":40,"context_line":"        return self._create(req, body)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_1d781ff2","line":38,"in_reply_to":"bacf61ea_dff083cb","updated":"2016-08-08 21:18:13.000000000","message":"this means 2.5 and up. But i will need to add another one to remove group_id for everything less.","commit_id":"1a3f2324a89e103bd1f6364a55185b3459d48396"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c370882fc617bf74749698a5a84166acaf82710c","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @wsgi.Controller.api_version(\"2.0\", \"2.3\")  # noqa"},{"line_number":43,"context_line":"    def create(self, req, body):  # pylint: disable\u003dE0102"},{"line_number":44,"context_line":"        return self._create(req, body)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @wsgi.Controller.api_version(\u00272.0\u0027, \u00272.6\u0027)"},{"line_number":47,"context_line":"    @wsgi.action(\u0027os-reset_status\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_7fc87755","line":44,"updated":"2016-08-01 21:50:48.000000000","message":"This should pop \u0027group_id\u0027 now.  There should be some handling of \u0027consistentency_group_id\u0027 here too.","commit_id":"1a3f2324a89e103bd1f6364a55185b3459d48396"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"6541045839cff8218bfa0a29be338f304ae437ec","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @wsgi.Controller.api_version(\"2.0\", \"2.3\")  # noqa"},{"line_number":43,"context_line":"    def create(self, req, body):  # pylint: disable\u003dE0102"},{"line_number":44,"context_line":"        return self._create(req, body)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @wsgi.Controller.api_version(\u00272.0\u0027, \u00272.6\u0027)"},{"line_number":47,"context_line":"    @wsgi.action(\u0027os-reset_status\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_dd54c755","line":44,"in_reply_to":"bacf61ea_7fc87755","updated":"2016-08-08 21:18:13.000000000","message":"consistency_group_id should never appear here. I do need to add group_id however.","commit_id":"1a3f2324a89e103bd1f6364a55185b3459d48396"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(self.__class__, self).__init__()"},{"line_number":36,"context_line":"        self.share_api \u003d share.API()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @wsgi.Controller.api_version(\"2.21\", \"2.21\", experimental\u003dTrue)"},{"line_number":39,"context_line":"    def create(self, req, body):"},{"line_number":40,"context_line":"        return self._create(req, body)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_04c7f045","line":38,"range":{"start_line":38,"start_character":41,"end_line":38,"end_character":47},"updated":"2016-08-22 12:59:09.000000000","message":"this is not clear to me, 2.22 should not use this method?","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(self.__class__, self).__init__()"},{"line_number":36,"context_line":"        self.share_api \u003d share.API()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @wsgi.Controller.api_version(\"2.21\", \"2.21\", experimental\u003dTrue)"},{"line_number":39,"context_line":"    def create(self, req, body):"},{"line_number":40,"context_line":"        return self._create(req, body)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_7297353a","line":38,"range":{"start_line":38,"start_character":41,"end_line":38,"end_character":47},"in_reply_to":"1ac06dbe_04c7f045","updated":"2016-11-01 15:31:20.000000000","message":"correct, it is experimental so it should only work for the very specific version. Otherwise if we remove it in the future and someone was using 2.25, the functionality would disappear with confusion.","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self._access_view_builder \u003d share_access_views.ViewBuilder()"},{"line_number":48,"context_line":"        self._migration_view_builder \u003d share_migration_views.ViewBuilder()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @wsgi.Controller.api_version(\"2.23\", \"2.23\", experimental\u003dTrue)"},{"line_number":51,"context_line":"    def create(self, req, body):"},{"line_number":52,"context_line":"        return self._create(req, body)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_c3a0b9a8","line":50,"range":{"start_line":50,"start_character":41,"end_line":50,"end_character":47},"updated":"2016-11-07 12:20:01.000000000","message":"It should be removed. No restriction of higher versions is expected here.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def create(self, req, body):"},{"line_number":52,"context_line":"        return self._create(req, body)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @wsgi.Controller.api_version(\"2.0\")  # noqa"},{"line_number":55,"context_line":"    def create(self, req, body):  # pylint: disable\u003dE0102"},{"line_number":56,"context_line":"        body.get(\u0027share\u0027, {}).pop(\u0027share_group_id\u0027, None)"},{"line_number":57,"context_line":"        return self._create(req, body)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_83c88176","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":47},"updated":"2016-11-07 12:20:01.000000000","message":"It should be called for 2.0-2.22 microversions.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"}],"manila/api/views/group_snapshots.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Alex Meade"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_84e120d3","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2016-08-22 12:59:09.000000000","message":"2016","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Alex Meade"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_52bdd1b5","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"in_reply_to":"1ac06dbe_84e120d3","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        members_links \u003d self._get_collection_links(request,"},{"line_number":49,"context_line":"                                                   members,"},{"line_number":50,"context_line":"                                                   \u0027group_snapshot_id\u0027)"},{"line_number":51,"context_line":"        members_dict \u003d dict(group_snapshot_members\u003dmembers_list)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        if members_links:"},{"line_number":54,"context_line":"            members_dict[\u0027group_snapshot_members_links\u0027] \u003d members_links"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_444608c0","line":51,"range":{"start_line":51,"start_character":23,"end_line":51,"end_character":27},"updated":"2016-08-22 12:59:09.000000000","message":"same as below","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        members_links \u003d self._get_collection_links(request,"},{"line_number":49,"context_line":"                                                   members,"},{"line_number":50,"context_line":"                                                   \u0027group_snapshot_id\u0027)"},{"line_number":51,"context_line":"        members_dict \u003d dict(group_snapshot_members\u003dmembers_list)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        if members_links:"},{"line_number":54,"context_line":"            members_dict[\u0027group_snapshot_members_links\u0027] \u003d members_links"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_b2d38d03","line":51,"range":{"start_line":51,"start_character":23,"end_line":51,"end_character":27},"in_reply_to":"1ac06dbe_444608c0","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        snaps_links \u003d self._get_collection_links(request,"},{"line_number":104,"context_line":"                                                 snaps,"},{"line_number":105,"context_line":"                                                 self._collection_name)"},{"line_number":106,"context_line":"        snaps_dict \u003d dict(group_snapshots\u003dsnap_list)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        if snaps_links:"},{"line_number":109,"context_line":"            snaps_dict[\u0027group_snapshot_links\u0027] \u003d snaps_links"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_644b44ca","line":106,"range":{"start_line":106,"start_character":21,"end_line":106,"end_character":25},"updated":"2016-08-22 12:59:09.000000000","message":"whenever you can use \u0027{}\u0027 instead of \u0027dict()\u0027 please do so.","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        snaps_links \u003d self._get_collection_links(request,"},{"line_number":104,"context_line":"                                                 snaps,"},{"line_number":105,"context_line":"                                                 self._collection_name)"},{"line_number":106,"context_line":"        snaps_dict \u003d dict(group_snapshots\u003dsnap_list)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        if snaps_links:"},{"line_number":109,"context_line":"            snaps_dict[\u0027group_snapshot_links\u0027] \u003d snaps_links"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_d2d001f9","line":106,"range":{"start_line":106,"start_character":21,"end_line":106,"end_character":25},"in_reply_to":"1ac06dbe_644b44ca","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"}],"manila/api/views/group_types.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        if brief:"},{"line_number":35,"context_line":"            return trimmed"},{"line_number":36,"context_line":"        else:"},{"line_number":37,"context_line":"            return dict(group_type\u003dtrimmed)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def index(self, request, group_types):"},{"line_number":40,"context_line":"        \"\"\"Index over trimmed share types.\"\"\""}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_43dbc9ed","line":37,"range":{"start_line":37,"start_character":19,"end_line":37,"end_character":23},"updated":"2016-11-07 12:20:01.000000000","message":"Please, use dict comprehensions. see [1]\n\n[1] https://www.python.org/dev/peps/pep-0274/","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"}],"manila/api/views/share_groups.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Alex Meade"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_c48798d5","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2016-08-22 12:59:09.000000000","message":"2016","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                      for share in shares]"},{"line_number":70,"context_line":"        groups_links \u003d self._get_collection_links("},{"line_number":71,"context_line":"            request, shares, self._collection_name)"},{"line_number":72,"context_line":"        groups_dict \u003d dict(groups\u003dgroup_list)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        if groups_links:"},{"line_number":75,"context_line":"            groups_dict[\u0027groups_links\u0027] \u003d groups_links"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_633c4d30","line":72,"range":{"start_line":72,"start_character":22,"end_line":72,"end_character":26},"updated":"2016-11-07 12:20:01.000000000","message":"Please, use dict comprehension. See [1]\n\n[1] https://www.python.org/dev/peps/pep-0274/","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"}],"manila/api/views/shares.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    def add_user_id(self, context, share_dict, share):"},{"line_number":142,"context_line":"        share_dict[\u0027user_id\u0027] \u003d share.get(\u0027user_id\u0027)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @common.ViewBuilder.versioned_method(\"2.21\", \"2.21\", experimental\u003dTrue)"},{"line_number":145,"context_line":"    def add_share_group_fields(self, context, share_dict, share):"},{"line_number":146,"context_line":"        share_dict[\u0027share_group_id\u0027] \u003d share.get("},{"line_number":147,"context_line":"            \u0027share_group_id\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_4ce4db0c","line":144,"range":{"start_line":144,"start_character":42,"end_line":144,"end_character":46},"updated":"2016-11-07 12:20:01.000000000","message":"Should be 2.23","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    def add_user_id(self, context, share_dict, share):"},{"line_number":142,"context_line":"        share_dict[\u0027user_id\u0027] \u003d share.get(\u0027user_id\u0027)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @common.ViewBuilder.versioned_method(\"2.21\", \"2.21\", experimental\u003dTrue)"},{"line_number":145,"context_line":"    def add_share_group_fields(self, context, share_dict, share):"},{"line_number":146,"context_line":"        share_dict[\u0027share_group_id\u0027] \u003d share.get("},{"line_number":147,"context_line":"            \u0027share_group_id\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_2ccec783","line":144,"range":{"start_line":144,"start_character":49,"end_line":144,"end_character":55},"updated":"2016-11-07 12:20:01.000000000","message":"Why do you block newer versions? I guess it is bug.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"09340d346e2b9d886e9c63a03e3fda9fccf73e0f","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    def add_user_id(self, context, share_dict, share):"},{"line_number":142,"context_line":"        share_dict[\u0027user_id\u0027] \u003d share.get(\u0027user_id\u0027)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @common.ViewBuilder.versioned_method(\"2.21\", \"2.21\", experimental\u003dTrue)"},{"line_number":145,"context_line":"    def add_share_group_fields(self, context, share_dict, share):"},{"line_number":146,"context_line":"        share_dict[\u0027share_group_id\u0027] \u003d share.get("},{"line_number":147,"context_line":"            \u0027share_group_id\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_c1e7bf3e","line":144,"range":{"start_line":144,"start_character":42,"end_line":144,"end_character":46},"in_reply_to":"9a629dbe_4ce4db0c","updated":"2016-11-07 18:23:01.000000000","message":"yeah should be updated to 2.23. I block newer versions because this version is experimental so if we remove it in the future we dont want to change behavior for 2.24 right? That\u0027s kind of a fuzzy area we need to decide on.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2275ecf64ec7b1c59f67ffb799f3cc87df2723e3","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    def add_user_id(self, context, share_dict, share):"},{"line_number":142,"context_line":"        share_dict[\u0027user_id\u0027] \u003d share.get(\u0027user_id\u0027)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @common.ViewBuilder.versioned_method(\"2.21\", \"2.21\", experimental\u003dTrue)"},{"line_number":145,"context_line":"    def add_share_group_fields(self, context, share_dict, share):"},{"line_number":146,"context_line":"        share_dict[\u0027share_group_id\u0027] \u003d share.get("},{"line_number":147,"context_line":"            \u0027share_group_id\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_cb41870d","line":144,"range":{"start_line":144,"start_character":42,"end_line":144,"end_character":46},"in_reply_to":"9a629dbe_c1e7bf3e","updated":"2016-11-08 08:12:07.000000000","message":"We have precedent. We do not block it, we just have right to remove it right away when we decide to do it as it is being done with CGs API. We should be able to use it with any new microversion.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"}],"manila/db/migrations/alembic/versions/03da71c0e321_convert_cgs_to_share_groups.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\"\"\"Convert consistency groups to share groups"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: 03da71c0e321"},{"line_number":16,"context_line":"Revises: 63809d875e32"},{"line_number":17,"context_line":"Create Date: 2016-05-19 10:25:17.899008"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_a0557b1e","line":16,"range":{"start_line":16,"start_character":9,"end_line":16,"end_character":21},"updated":"2016-11-07 12:20:01.000000000","message":"wrong version","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                          \"cgsnapshot_members\", \"shares\","},{"line_number":198,"context_line":"                          [\"share_id\"], [\"id\"])"},{"line_number":199,"context_line":"    op.add_column(\"cgsnapshot_members\","},{"line_number":200,"context_line":"                  op.Column(\u0027share_type_id\u0027, op.String(36), nullable\u003dTrue))"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    # TODO(ameade): set member share_type_ids to what the shares are in a"},{"line_number":203,"context_line":"    # mysql friendly way"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_608603bb","line":200,"range":{"start_line":200,"start_character":18,"end_line":200,"end_character":27},"updated":"2016-11-07 12:20:01.000000000","message":"It is the reason of CI failure. Should just be \"Column\".","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":3861,"context_line":"    query \u003d model_query(context,"},{"line_number":3862,"context_line":"                        models.ShareGroupTypes,"},{"line_number":3863,"context_line":"                        session\u003dsession,"},{"line_number":3864,"context_line":"                        read_deleted\u003dread_deleted). \\"},{"line_number":3865,"context_line":"        options(joinedload(\u0027extra_specs\u0027)). \\"},{"line_number":3866,"context_line":"        options(joinedload(\u0027share_types\u0027))"},{"line_number":3867,"context_line":""},{"line_number":3868,"context_line":"    if \u0027projects\u0027 in expected_fields:"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_985b402e","line":3865,"range":{"start_line":3864,"start_character":21,"end_line":3865,"end_character":45},"updated":"2016-08-22 12:59:09.000000000","message":"please avoid the usage of backlashes","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":3911,"context_line":""},{"line_number":3912,"context_line":""},{"line_number":3913,"context_line":"def _group_type_get_id_from_group_type_query(context, id, session\u003dNone):"},{"line_number":3914,"context_line":"    return model_query("},{"line_number":3915,"context_line":"        context, models.ShareGroupTypes, read_deleted\u003d\"no\", session\u003dsession).\\"},{"line_number":3916,"context_line":"        filter_by(id\u003did)"},{"line_number":3917,"context_line":""},{"line_number":3918,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_7875a496","line":3915,"range":{"start_line":3914,"start_character":23,"end_line":3915,"end_character":78},"updated":"2016-08-22 12:59:09.000000000","message":"same as above","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":3930,"context_line":"    expected_fields \u003d expected_fields or []"},{"line_number":3931,"context_line":"    read_deleted \u003d \"yes\" if inactive else \"no\""},{"line_number":3932,"context_line":"    result \u003d _group_type_get_query("},{"line_number":3933,"context_line":"        context, session, read_deleted, expected_fields). \\"},{"line_number":3934,"context_line":"        filter_by(id\u003did). \\"},{"line_number":3935,"context_line":"        first()"},{"line_number":3936,"context_line":""},{"line_number":3937,"context_line":"    if not result:"},{"line_number":3938,"context_line":"        raise exception.GroupTypeNotFound(group_type_id\u003did)"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_1848f05a","line":3935,"range":{"start_line":3933,"start_character":20,"end_line":3935,"end_character":15},"updated":"2016-08-22 12:59:09.000000000","message":"same as above","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":3955,"context_line":""},{"line_number":3956,"context_line":""},{"line_number":3957,"context_line":"@require_context"},{"line_number":3958,"context_line":"def _group_type_get_by_name(context, name, session\u003dNone):"},{"line_number":3959,"context_line":"    result \u003d model_query(context, models.ShareGroupTypes, session\u003dsession).\\"},{"line_number":3960,"context_line":"        options(joinedload(\u0027extra_specs\u0027)).\\"},{"line_number":3961,"context_line":"        options(joinedload(\u0027share_types\u0027)).\\"},{"line_number":3962,"context_line":"        filter_by(name\u003dname).\\"},{"line_number":3963,"context_line":"        first()"},{"line_number":3964,"context_line":""},{"line_number":3965,"context_line":"    if not result:"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_f897d48d","line":3962,"range":{"start_line":3958,"start_character":17,"end_line":3962,"end_character":30},"updated":"2016-08-22 12:59:09.000000000","message":"same as above","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":3980,"context_line":"    session \u003d get_session()"},{"line_number":3981,"context_line":"    with session.begin():"},{"line_number":3982,"context_line":"        _group_type_get(context, id, session)"},{"line_number":3983,"context_line":"        results \u003d model_query(context, models.ShareGroup, session\u003dsession,"},{"line_number":3984,"context_line":"                              read_deleted\u003d\"no\").\\"},{"line_number":3985,"context_line":"            filter_by(share_group_type_id\u003did).count()"},{"line_number":3986,"context_line":"        if results:"},{"line_number":3987,"context_line":"            LOG.error(_LE(\u0027Group type %s deletion failed, Group type in use.\u0027),"},{"line_number":3988,"context_line":"                      id)"},{"line_number":3989,"context_line":"            raise exception.GroupTypeInUse(group_type_id\u003did)"},{"line_number":3990,"context_line":"        model_query(context, models.ShareGroupTypeExtraSpecs,"},{"line_number":3991,"context_line":"                    session\u003dsession).\\"},{"line_number":3992,"context_line":"            filter_by(share_group_type_id\u003did).soft_delete()"},{"line_number":3993,"context_line":"        model_query(context, models.ShareGroupTypes, session\u003dsession).\\"},{"line_number":3994,"context_line":"            filter_by(id\u003did).soft_delete()"},{"line_number":3995,"context_line":""},{"line_number":3996,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_b859dc00","line":3993,"range":{"start_line":3983,"start_character":45,"end_line":3993,"end_character":71},"updated":"2016-08-22 12:59:09.000000000","message":"same as above","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":4002,"context_line":"@require_admin_context"},{"line_number":4003,"context_line":"def group_type_access_get_all(context, type_id):"},{"line_number":4004,"context_line":"    group_type_id \u003d _group_type_get_id_from_group_type(context, type_id)"},{"line_number":4005,"context_line":"    return _group_type_access_query(context).\\"},{"line_number":4006,"context_line":"        filter_by(share_group_type_id\u003dgroup_type_id).all()"},{"line_number":4007,"context_line":""},{"line_number":4008,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_b8271c63","line":4005,"range":{"start_line":4005,"start_character":41,"end_line":4005,"end_character":46},"updated":"2016-08-22 12:59:09.000000000","message":"same as above and all other occurrences","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"e5a02fc28c9d31beb0d06621563667b0eeda2578","unresolved":false,"context_lines":[{"line_number":3089,"context_line":"def _dict_with_specs(inst_type_query, specs_key\u003d\u0027extra_specs\u0027):"},{"line_number":3090,"context_line":"    \"\"\"Convert type query result to dict with extra_spec and rate_limit."},{"line_number":3091,"context_line":""},{"line_number":3092,"context_line":"    Takes a volume type query returned by sqlalchemy and returns it"},{"line_number":3093,"context_line":"    as a dictionary, converting the extra_specs entry from a list"},{"line_number":3094,"context_line":"    of dicts:"},{"line_number":3095,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_396218ae","line":3092,"range":{"start_line":3092,"start_character":12,"end_line":3092,"end_character":18},"updated":"2017-01-20 23:37:06.000000000","message":"volume?","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95a36d4def7067fd2f61c30355424a3336b1c626","unresolved":false,"context_lines":[{"line_number":3089,"context_line":"def _dict_with_specs(inst_type_query, specs_key\u003d\u0027extra_specs\u0027):"},{"line_number":3090,"context_line":"    \"\"\"Convert type query result to dict with extra_spec and rate_limit."},{"line_number":3091,"context_line":""},{"line_number":3092,"context_line":"    Takes a volume type query returned by sqlalchemy and returns it"},{"line_number":3093,"context_line":"    as a dictionary, converting the extra_specs entry from a list"},{"line_number":3094,"context_line":"    of dicts:"},{"line_number":3095,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_d469a9fa","line":3092,"range":{"start_line":3092,"start_character":12,"end_line":3092,"end_character":18},"in_reply_to":"5a3905b3_396218ae","updated":"2017-01-23 13:07:01.000000000","message":"Done","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"}],"manila/db/sqlalchemy/models.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f50566e91cd848f2708c96fe79b18fa9d0ff475d","unresolved":false,"context_lines":[{"line_number":986,"context_line":""},{"line_number":987,"context_line":"    share_group \u003d orm.relationship("},{"line_number":988,"context_line":"        ShareGroup,"},{"line_number":989,"context_line":"        backref\u003d\"cgsnapshots\","},{"line_number":990,"context_line":"        foreign_keys\u003dshare_group_id,"},{"line_number":991,"context_line":"        primaryjoin\u003d(\u0027and_(\u0027"},{"line_number":992,"context_line":"                     \u0027GroupSnapshot.share_group_id \u003d\u003d ShareGroup.id,\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_5e726a7d","line":989,"range":{"start_line":989,"start_character":16,"end_line":989,"end_character":29},"updated":"2016-07-10 21:04:16.000000000","message":"\"groupsnapshots\"","commit_id":"7f7e9b00255412e622a1db7afb934160b10b9903"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"dcc172999a1249b3b39518be1756f648f228fd11","unresolved":false,"context_lines":[{"line_number":916,"context_line":"                             nullable\u003dTrue)"},{"line_number":917,"context_line":"    share_group_type_id \u003d Column(String(36),"},{"line_number":918,"context_line":"                                 ForeignKey(\u0027share_group_types.id\u0027),"},{"line_number":919,"context_line":"                                 nullable\u003dTrue)"},{"line_number":920,"context_line":"    share_group_type \u003d orm.relationship("},{"line_number":921,"context_line":"        ShareGroupTypes,"},{"line_number":922,"context_line":"        backref\u003d\"share_groups\","}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_f5c71a43","line":919,"range":{"start_line":919,"start_character":42,"end_line":919,"end_character":46},"updated":"2016-08-09 02:42:28.000000000","message":"False?","commit_id":"9a8b0c8aea83b8339caacceea0a6b35768ad7272"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"ff260e4fa4c2dcd0d4d3af139cee05107974d2b3","unresolved":false,"context_lines":[{"line_number":916,"context_line":"                             nullable\u003dTrue)"},{"line_number":917,"context_line":"    share_group_type_id \u003d Column(String(36),"},{"line_number":918,"context_line":"                                 ForeignKey(\u0027share_group_types.id\u0027),"},{"line_number":919,"context_line":"                                 nullable\u003dTrue)"},{"line_number":920,"context_line":"    share_group_type \u003d orm.relationship("},{"line_number":921,"context_line":"        ShareGroupTypes,"},{"line_number":922,"context_line":"        backref\u003d\"share_groups\","}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_5c6a1db4","line":919,"range":{"start_line":919,"start_character":42,"end_line":919,"end_character":46},"in_reply_to":"9ad45d7e_f5c71a43","updated":"2016-08-10 20:30:15.000000000","message":"Done","commit_id":"9a8b0c8aea83b8339caacceea0a6b35768ad7272"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"dcc172999a1249b3b39518be1756f648f228fd11","unresolved":false,"context_lines":[{"line_number":936,"context_line":"              \"0project_id0deleted\")),"},{"line_number":937,"context_line":"    )"},{"line_number":938,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":939,"context_line":"    share_group_type_id \u003d Column(Integer, ForeignKey(\u0027share_group_types.id\u0027),"},{"line_number":940,"context_line":"                                 nullable\u003dFalse)"},{"line_number":941,"context_line":"    project_id \u003d Column(String(255))"},{"line_number":942,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_d5abf687","line":939,"range":{"start_line":939,"start_character":33,"end_line":939,"end_character":40},"updated":"2016-08-09 02:42:28.000000000","message":"String","commit_id":"9a8b0c8aea83b8339caacceea0a6b35768ad7272"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"ff260e4fa4c2dcd0d4d3af139cee05107974d2b3","unresolved":false,"context_lines":[{"line_number":936,"context_line":"              \"0project_id0deleted\")),"},{"line_number":937,"context_line":"    )"},{"line_number":938,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":939,"context_line":"    share_group_type_id \u003d Column(Integer, ForeignKey(\u0027share_group_types.id\u0027),"},{"line_number":940,"context_line":"                                 nullable\u003dFalse)"},{"line_number":941,"context_line":"    project_id \u003d Column(String(255))"},{"line_number":942,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_3c6769ea","line":939,"range":{"start_line":939,"start_character":33,"end_line":939,"end_character":40},"in_reply_to":"9ad45d7e_d5abf687","updated":"2016-08-10 20:30:15.000000000","message":"Done","commit_id":"9a8b0c8aea83b8339caacceea0a6b35768ad7272"}],"manila/scheduler/drivers/filter.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c370882fc617bf74749698a5a84166acaf82710c","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            \u0027request_spec\u0027: request_spec,"},{"line_number":396,"context_line":"            \u0027config_options\u0027: config_options,"},{"line_number":397,"context_line":"            \u0027group_type\u0027: group_type,"},{"line_number":398,"context_line":"            \u0027resource_type\u0027: group_type,"},{"line_number":399,"context_line":"        }"},{"line_number":400,"context_line":"        # Filter local hosts based on requirements ..."},{"line_number":401,"context_line":"        hosts \u003d self.host_manager.get_filtered_hosts(all_hosts,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_dffb6345","line":398,"updated":"2016-08-01 21:50:48.000000000","message":"Without also filtering by share_types, I wonder how you can make sure admin won\u0027t make mistakes and the share types belonging to the group_type will work for the backend selected based on the group_type alone.\n\nAssume group-type-A contains share-type-A.\n\n(1) manila cg-create --group-type group-type-A ...\n(2) manila create --share-type share-type-A ...\n\nweighed_hosts from step 2 may not even be in weighed_hosts from step 1.  Of course If you provide group-id to step 2, that won\u0027t go through the scheduler again, but it still seems wrong to me that they can be out of sync like this.","commit_id":"1a3f2324a89e103bd1f6364a55185b3459d48396"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"6541045839cff8218bfa0a29be338f304ae437ec","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            \u0027request_spec\u0027: request_spec,"},{"line_number":396,"context_line":"            \u0027config_options\u0027: config_options,"},{"line_number":397,"context_line":"            \u0027group_type\u0027: group_type,"},{"line_number":398,"context_line":"            \u0027resource_type\u0027: group_type,"},{"line_number":399,"context_line":"        }"},{"line_number":400,"context_line":"        # Filter local hosts based on requirements ..."},{"line_number":401,"context_line":"        hosts \u003d self.host_manager.get_filtered_hosts(all_hosts,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_584d8571","line":398,"in_reply_to":"bacf61ea_dffb6345","updated":"2016-08-08 21:18:13.000000000","message":"This method is only concerned with finding hosts that match the group type. Hosts are also filtered by share types in the below method.","commit_id":"1a3f2324a89e103bd1f6364a55185b3459d48396"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                                    request_spec,"},{"line_number":312,"context_line":"                                    filter_properties):"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        LOG.info(_LI(\"Scheduling share group %s\") % group_id)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        host \u003d self._get_best_host_for_share_group(context, request_spec)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        if not host:"},{"line_number":319,"context_line":"            msg \u003d _(\"No hosts available for share group %s\") % group_id"},{"line_number":320,"context_line":"            raise exception.NoValidHost(reason\u003dmsg)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        msg \u003d _LI(\"Chose host %(host)s for create_share_group %(group)s\")"},{"line_number":323,"context_line":"        LOG.info(msg % {\u0027host\u0027: host, \u0027group\u0027: group_id})"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        updated_group \u003d base.group_update_db(context, group_id, host)"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_f827d40f","line":322,"range":{"start_line":314,"start_character":45,"end_line":322,"end_character":73},"updated":"2016-08-22 12:59:09.000000000","message":"periods","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                                    request_spec,"},{"line_number":312,"context_line":"                                    filter_properties):"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        LOG.info(_LI(\"Scheduling share group %s\") % group_id)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        host \u003d self._get_best_host_for_share_group(context, request_spec)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        if not host:"},{"line_number":319,"context_line":"            msg \u003d _(\"No hosts available for share group %s\") % group_id"},{"line_number":320,"context_line":"            raise exception.NoValidHost(reason\u003dmsg)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        msg \u003d _LI(\"Chose host %(host)s for create_share_group %(group)s\")"},{"line_number":323,"context_line":"        LOG.info(msg % {\u0027host\u0027: host, \u0027group\u0027: group_id})"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        updated_group \u003d base.group_update_db(context, group_id, host)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_b228ede3","line":322,"range":{"start_line":314,"start_character":45,"end_line":322,"end_character":73},"in_reply_to":"1ac06dbe_f827d40f","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"}],"manila/scheduler/filters/capabilities.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        # this filter, so the resource type is either instance or"},{"line_number":81,"context_line":"        # volume."},{"line_number":82,"context_line":"        resource_type \u003d filter_properties.get(\u0027resource_type\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if not self._satisfies_extra_specs(host_state.capabilities,"},{"line_number":85,"context_line":"                                           resource_type):"},{"line_number":86,"context_line":"            LOG.debug(\"%(host_state)s fails resource_type extra_specs \""}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_38504c5d","line":83,"updated":"2016-08-22 12:59:09.000000000","message":"being the only change to this file, it is unecessary","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        # this filter, so the resource type is either instance or"},{"line_number":81,"context_line":"        # volume."},{"line_number":82,"context_line":"        resource_type \u003d filter_properties.get(\u0027resource_type\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if not self._satisfies_extra_specs(host_state.capabilities,"},{"line_number":85,"context_line":"                                           resource_type):"},{"line_number":86,"context_line":"            LOG.debug(\"%(host_state)s fails resource_type extra_specs \""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_928689d9","line":83,"in_reply_to":"1ac06dbe_38504c5d","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"}],"manila/scheduler/filters/capacity.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"e5a02fc28c9d31beb0d06621563667b0eeda2578","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def host_passes(self, host_state, filter_properties):"},{"line_number":35,"context_line":"        \"\"\"Return True if host has sufficient capacity.\"\"\""},{"line_number":36,"context_line":"        share_size \u003d filter_properties.get(\u0027size\u0027, 0)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        if host_state.free_capacity_gb is None:"},{"line_number":39,"context_line":"            # Fail Safe"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_d907541a","line":36,"range":{"start_line":36,"start_character":50,"end_line":36,"end_character":53},"updated":"2017-01-20 23:37:06.000000000","message":"I\u0027m reviewing this change a bit out of context, but I think the handling or size zero changes some things.  If this is zero, then the below tests should also check for zero space. I don\u0027t think we ever want host to pass with zero space.","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95a36d4def7067fd2f61c30355424a3336b1c626","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def host_passes(self, host_state, filter_properties):"},{"line_number":35,"context_line":"        \"\"\"Return True if host has sufficient capacity.\"\"\""},{"line_number":36,"context_line":"        share_size \u003d filter_properties.get(\u0027size\u0027, 0)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        if host_state.free_capacity_gb is None:"},{"line_number":39,"context_line":"            # Fail Safe"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_6fcd7bb6","line":36,"range":{"start_line":36,"start_character":50,"end_line":36,"end_character":53},"in_reply_to":"5a3905b3_d907541a","updated":"2017-01-23 13:07:01.000000000","message":"I added it to avoid TypeError exceptions.","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"e5a02fc28c9d31beb0d06621563667b0eeda2578","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            # is not 0, we cannot calculate the reserved space."},{"line_number":58,"context_line":"            # float(total_space) will throw an exception. total*reserved"},{"line_number":59,"context_line":"            # also won\u0027t work. So the back-ends cannot serve the request."},{"line_number":60,"context_line":"            return reserved \u003d\u003d 0 and share_size \u003c\u003d free_space"},{"line_number":61,"context_line":"        total \u003d float(total_space)"},{"line_number":62,"context_line":"        if total \u003c\u003d 0:"},{"line_number":63,"context_line":"            LOG.warning(_LW(\"Insufficient free space for share creation. \""}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_3403ff0e","line":60,"range":{"start_line":60,"start_character":37,"end_line":60,"end_character":61},"updated":"2017-01-20 23:37:06.000000000","message":"share_size \u003c\u003d free_space and free_space \u003e 0","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"e5a02fc28c9d31beb0d06621563667b0eeda2578","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                host_state.max_over_subscription_ratio \u003e\u003d 1):"},{"line_number":94,"context_line":"            provisioned_ratio \u003d ((host_state.provisioned_capacity_gb +"},{"line_number":95,"context_line":"                                  share_size) / total)"},{"line_number":96,"context_line":"            if provisioned_ratio \u003e host_state.max_over_subscription_ratio:"},{"line_number":97,"context_line":"                LOG.warning(_LW("},{"line_number":98,"context_line":"                    \"Insufficient free space for thin provisioning. \""},{"line_number":99,"context_line":"                    \"The ratio of provisioned capacity over total capacity \""}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_b4360fe5","line":96,"range":{"start_line":96,"start_character":12,"end_line":96,"end_character":74},"updated":"2017-01-20 23:37:06.000000000","message":"if share_size \u003d\u003d 0, then we should also check for privisioned_ratio \u003d \u003dmax (because it\u0027d start out full).","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"}],"manila/scheduler/manager.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"45497e4a66318804cee58f0ed7ef89b03827b678","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        if share_group_id:"},{"line_number":212,"context_line":"            db.share_group_update(context, share_group_id, group_state)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def create_share_group(self, context, group_id, request_spec\u003dNone,"},{"line_number":215,"context_line":"                           filter_properties\u003dNone):"},{"line_number":216,"context_line":"        try:"},{"line_number":217,"context_line":"            self.driver.schedule_create_share_group(context, group_id,"}],"source_content_type":"text/x-python","patch_set":26,"id":"3ac371cc_a4ec8293","line":214,"range":{"start_line":214,"start_character":8,"end_line":214,"end_character":26},"updated":"2016-08-18 17:05:35.000000000","message":"I\u0027m guessing this patch is WIP since backwards compatability with CGs is not maintained (and that\u0027s OK since they\u0027re experimental) but drivers don\u0027t seem to have been updated yet for the new methods?","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"}],"manila/scheduler/rpcapi.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        1.4 - Add migrate_share_to_host method"},{"line_number":38,"context_line":"        1.5 - Add create_share_replica"},{"line_number":39,"context_line":"        1.6 - Add manage_share"},{"line_number":40,"context_line":"        1.7 - Add create_share_group_method"},{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    RPC_API_VERSION \u003d \u00271.7\u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_98486089","line":40,"range":{"start_line":40,"start_character":14,"end_line":40,"end_character":17},"updated":"2016-08-22 12:59:09.000000000","message":"actually you renamed","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        1.4 - Add migrate_share_to_host method"},{"line_number":38,"context_line":"        1.5 - Add create_share_replica"},{"line_number":39,"context_line":"        1.6 - Add manage_share"},{"line_number":40,"context_line":"        1.7 - Add create_share_group_method"},{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    RPC_API_VERSION \u003d \u00271.7\u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_52f5d154","line":40,"range":{"start_line":40,"start_character":14,"end_line":40,"end_character":17},"in_reply_to":"1ac06dbe_98486089","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"}],"manila/share/api.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":710,"context_line":"        group_snapshot_members_count \u003d ("},{"line_number":711,"context_line":"            self.db.count_group_snapshot_members_in_share(context, share_id))"},{"line_number":712,"context_line":"        if group_snapshot_members_count:"},{"line_number":713,"context_line":"            msg \u003d (_(\"Share still has %d dependent group snapshot members\") %"},{"line_number":714,"context_line":"                   group_snapshot_members_count)"},{"line_number":715,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":716,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_1b310aed","line":713,"range":{"start_line":713,"start_character":72,"end_line":713,"end_character":74},"updated":"2016-08-22 12:59:09.000000000","message":"period","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":710,"context_line":"        group_snapshot_members_count \u003d ("},{"line_number":711,"context_line":"            self.db.count_group_snapshot_members_in_share(context, share_id))"},{"line_number":712,"context_line":"        if group_snapshot_members_count:"},{"line_number":713,"context_line":"            msg \u003d (_(\"Share still has %d dependent group snapshot members\") %"},{"line_number":714,"context_line":"                   group_snapshot_members_count)"},{"line_number":715,"context_line":"            raise exception.InvalidShare(reason\u003dmsg)"},{"line_number":716,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_92a2094a","line":713,"range":{"start_line":713,"start_character":72,"end_line":713,"end_character":74},"in_reply_to":"1ac06dbe_1b310aed","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        groups \u003d self.db.share_group_get_all_by_share_server(context,"},{"line_number":787,"context_line":"                                                             server[\u0027id\u0027])"},{"line_number":788,"context_line":"        if groups:"},{"line_number":789,"context_line":"            LOG.error(_LE(\"share server \u0027%(ssid)s\u0027 in use by share groups\"),"},{"line_number":790,"context_line":"                      {\u0027ssid\u0027: server[\u0027id\u0027]})"},{"line_number":791,"context_line":"            raise exception.ShareServerInUse(share_server_id\u003dserver[\u0027id\u0027])"},{"line_number":792,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_bb58b633","line":789,"range":{"start_line":789,"start_character":72,"end_line":789,"end_character":73},"updated":"2016-08-22 12:59:09.000000000","message":"period","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        groups \u003d self.db.share_group_get_all_by_share_server(context,"},{"line_number":787,"context_line":"                                                             server[\u0027id\u0027])"},{"line_number":788,"context_line":"        if groups:"},{"line_number":789,"context_line":"            LOG.error(_LE(\"share server \u0027%(ssid)s\u0027 in use by share groups\"),"},{"line_number":790,"context_line":"                      {\u0027ssid\u0027: server[\u0027id\u0027]})"},{"line_number":791,"context_line":"            raise exception.ShareServerInUse(share_server_id\u003dserver[\u0027id\u0027])"},{"line_number":792,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_3265bd1d","line":789,"range":{"start_line":789,"start_character":72,"end_line":789,"end_character":73},"in_reply_to":"1ac06dbe_bb58b633","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"}],"manila/share/driver.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f50566e91cd848f2708c96fe79b18fa9d0ff475d","unresolved":false,"context_lines":[{"line_number":601,"context_line":"        :param share_servers: list with share-server models"},{"line_number":602,"context_line":"        :param share:  share model"},{"line_number":603,"context_line":"        :param snapshot: snapshot model"},{"line_number":604,"context_line":"        :param share_group: ConsistencyGroup model with shares"},{"line_number":605,"context_line":"        :returns: share-server or None"},{"line_number":606,"context_line":"        \"\"\""},{"line_number":607,"context_line":"        # If creating in a consistency group, use its share server"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_de049ac7","line":604,"range":{"start_line":604,"start_character":28,"end_line":604,"end_character":44},"updated":"2016-07-10 21:04:16.000000000","message":"ShareGroup","commit_id":"7f7e9b00255412e622a1db7afb934160b10b9903"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f50566e91cd848f2708c96fe79b18fa9d0ff475d","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        :param share_group: ConsistencyGroup model with shares"},{"line_number":605,"context_line":"        :returns: share-server or None"},{"line_number":606,"context_line":"        \"\"\""},{"line_number":607,"context_line":"        # If creating in a consistency group, use its share server"},{"line_number":608,"context_line":"        if share_group:"},{"line_number":609,"context_line":"            for share_server in share_servers:"},{"line_number":610,"context_line":"                if (share_group.get(\u0027share_server_id\u0027) \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_7e6766b7","line":607,"range":{"start_line":607,"start_character":27,"end_line":607,"end_character":38},"updated":"2016-07-10 21:04:16.000000000","message":"share","commit_id":"7f7e9b00255412e622a1db7afb934160b10b9903"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f50566e91cd848f2708c96fe79b18fa9d0ff475d","unresolved":false,"context_lines":[{"line_number":824,"context_line":"        \"\"\"Create a share group."},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"        :param context:"},{"line_number":827,"context_line":"        :param group_dict: The consistency group details"},{"line_number":828,"context_line":"            EXAMPLE:"},{"line_number":829,"context_line":"            {"},{"line_number":830,"context_line":"            \u0027status\u0027: \u0027creating\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_9e0332b8","line":827,"range":{"start_line":827,"start_character":31,"end_line":827,"end_character":42},"updated":"2016-07-10 21:04:16.000000000","message":"share","commit_id":"7f7e9b00255412e622a1db7afb934160b10b9903"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f50566e91cd848f2708c96fe79b18fa9d0ff475d","unresolved":false,"context_lines":[{"line_number":854,"context_line":"    def create_share_group_from_group_snapshot(self, context, group_dict,"},{"line_number":855,"context_line":"                                               group_snapshot_dict,"},{"line_number":856,"context_line":"                                               share_server\u003dNone):"},{"line_number":857,"context_line":"        \"\"\"Create a consistency group from a group snapshot."},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        :param context:"},{"line_number":860,"context_line":"        :param group_dict: The consistency group details"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_5ef9cac7","line":857,"range":{"start_line":857,"start_character":20,"end_line":857,"end_character":31},"updated":"2016-07-10 21:04:16.000000000","message":"share","commit_id":"7f7e9b00255412e622a1db7afb934160b10b9903"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f50566e91cd848f2708c96fe79b18fa9d0ff475d","unresolved":false,"context_lines":[{"line_number":857,"context_line":"        \"\"\"Create a consistency group from a group snapshot."},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        :param context:"},{"line_number":860,"context_line":"        :param group_dict: The consistency group details"},{"line_number":861,"context_line":"            EXAMPLE:"},{"line_number":862,"context_line":"            .. code::"},{"line_number":863,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_3ef4becd","line":860,"range":{"start_line":860,"start_character":30,"end_line":860,"end_character":43},"updated":"2016-07-10 21:04:16.000000000","message":"share","commit_id":"7f7e9b00255412e622a1db7afb934160b10b9903"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f50566e91cd848f2708c96fe79b18fa9d0ff475d","unresolved":false,"context_lines":[{"line_number":874,"context_line":"                \u0027host\u0027: \u0027openstack2@cmodeSSVMNFS\u0027,"},{"line_number":875,"context_line":"                \u0027deleted_at\u0027: None,"},{"line_number":876,"context_line":"                \u0027shares\u0027: [\u003cmodels.Share\u003e], # The new shares being created"},{"line_number":877,"context_line":"                \u0027share_types\u0027: [\u003cmodels.ConsistencyGroupShareTypeMapping\u003e],"},{"line_number":878,"context_line":"                \u0027id\u0027: \u0027eda52174-0442-476d-9694-a58327466c14\u0027,"},{"line_number":879,"context_line":"                \u0027name\u0027: None"},{"line_number":880,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_7efe46af","line":877,"range":{"start_line":877,"start_character":40,"end_line":877,"end_character":71},"updated":"2016-07-10 21:04:16.000000000","message":"ShareGroupShareTypeMapping","commit_id":"7f7e9b00255412e622a1db7afb934160b10b9903"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f50566e91cd848f2708c96fe79b18fa9d0ff475d","unresolved":false,"context_lines":[{"line_number":958,"context_line":"        return None, share_update_list"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"    def delete_share_group(self, context, group_dict, share_server\u003dNone):"},{"line_number":961,"context_line":"        \"\"\"Delete a consistency group"},{"line_number":962,"context_line":""},{"line_number":963,"context_line":"        :param context: The request context"},{"line_number":964,"context_line":"        :param group_dict: The consistency group details"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_1e262268","line":961,"range":{"start_line":961,"start_character":20,"end_line":961,"end_character":31},"updated":"2016-07-10 21:04:16.000000000","message":"share","commit_id":"7f7e9b00255412e622a1db7afb934160b10b9903"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":815,"context_line":"            qos\u003dFalse,"},{"line_number":816,"context_line":"            pools\u003dself.pools or None,"},{"line_number":817,"context_line":"            snapshot_support\u003dself.snapshots_are_supported,"},{"line_number":818,"context_line":"            group_snapshot_support\u003dself.snapshots_are_supported,"},{"line_number":819,"context_line":"            replication_domain\u003dself.replication_domain,"},{"line_number":820,"context_line":"            filter_function\u003dself.get_filter_function(),"},{"line_number":821,"context_line":"            goodness_function\u003dself.get_goodness_function(),"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_5b86e265","line":818,"range":{"start_line":818,"start_character":12,"end_line":818,"end_character":64},"updated":"2016-08-22 12:59:09.000000000","message":"These seem to be different things. Are we going to have an extra-spec for when snapshots can be done optimally or in a loop?","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":815,"context_line":"            qos\u003dFalse,"},{"line_number":816,"context_line":"            pools\u003dself.pools or None,"},{"line_number":817,"context_line":"            snapshot_support\u003dself.snapshots_are_supported,"},{"line_number":818,"context_line":"            group_snapshot_support\u003dself.snapshots_are_supported,"},{"line_number":819,"context_line":"            replication_domain\u003dself.replication_domain,"},{"line_number":820,"context_line":"            filter_function\u003dself.get_filter_function(),"},{"line_number":821,"context_line":"            goodness_function\u003dself.get_goodness_function(),"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_b260ed02","line":818,"range":{"start_line":818,"start_character":12,"end_line":818,"end_character":64},"in_reply_to":"1ac06dbe_5b86e265","updated":"2016-11-01 15:31:20.000000000","message":"We could add that later so folks could differentiate based on that.","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"45497e4a66318804cee58f0ed7ef89b03827b678","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        \"\"\"Create a share group."},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        :param context:"},{"line_number":838,"context_line":"        :param group_dict: The consistency group details"},{"line_number":839,"context_line":"            EXAMPLE:"},{"line_number":840,"context_line":"            {"},{"line_number":841,"context_line":"            \u0027status\u0027: \u0027creating\u0027,"}],"source_content_type":"text/x-python","patch_set":26,"id":"3ac371cc_2471b278","line":838,"range":{"start_line":838,"start_character":31,"end_line":838,"end_character":42},"updated":"2016-08-18 17:05:35.000000000","message":"share","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        \"\"\"Create a share group."},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        :param context:"},{"line_number":838,"context_line":"        :param group_dict: The consistency group details"},{"line_number":839,"context_line":"            EXAMPLE:"},{"line_number":840,"context_line":"            {"},{"line_number":841,"context_line":"            \u0027status\u0027: \u0027creating\u0027,"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_d22481c6","line":838,"range":{"start_line":838,"start_character":31,"end_line":838,"end_character":42},"in_reply_to":"3ac371cc_2471b278","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":938,"context_line":""},{"line_number":939,"context_line":"                [{\u0027id\u0027: \u0027uuid\u0027, \u0027export_locations\u0027: [\u0027export_path\u0027]}]"},{"line_number":940,"context_line":"        \"\"\""},{"line_number":941,"context_line":"        # Ensure that the consistency group snapshot has members"},{"line_number":942,"context_line":"        if not group_snapshot_dict[\u0027group_snapshot_members\u0027]:"},{"line_number":943,"context_line":"            return None, None"},{"line_number":944,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_db92d29e","line":941,"range":{"start_line":941,"start_character":26,"end_line":941,"end_character":37},"updated":"2016-08-22 12:59:09.000000000","message":"share","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":938,"context_line":""},{"line_number":939,"context_line":"                [{\u0027id\u0027: \u0027uuid\u0027, \u0027export_locations\u0027: [\u0027export_path\u0027]}]"},{"line_number":940,"context_line":"        \"\"\""},{"line_number":941,"context_line":"        # Ensure that the consistency group snapshot has members"},{"line_number":942,"context_line":"        if not group_snapshot_dict[\u0027group_snapshot_members\u0027]:"},{"line_number":943,"context_line":"            return None, None"},{"line_number":944,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_1202790b","line":941,"range":{"start_line":941,"start_character":26,"end_line":941,"end_character":37},"in_reply_to":"1ac06dbe_db92d29e","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":1168,"context_line":"        return None, None"},{"line_number":1169,"context_line":""},{"line_number":1170,"context_line":"    def _collate_group_snapshot_info(self, group_dict, group_snapshot_dict):"},{"line_number":1171,"context_line":"        \"\"\"Collate the data for a clone of the CG snapshot."},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"        Given two data structures, a CG snapshot (cgsnapshot_dict) and a new"},{"line_number":1174,"context_line":"        CG to be cloned from the snapshot (cg_dict), match up both"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_bbcb96a4","line":1171,"range":{"start_line":1171,"start_character":47,"end_line":1171,"end_character":49},"updated":"2016-08-22 12:59:09.000000000","message":"group","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":1168,"context_line":"        return None, None"},{"line_number":1169,"context_line":""},{"line_number":1170,"context_line":"    def _collate_group_snapshot_info(self, group_dict, group_snapshot_dict):"},{"line_number":1171,"context_line":"        \"\"\"Collate the data for a clone of the CG snapshot."},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"        Given two data structures, a CG snapshot (cgsnapshot_dict) and a new"},{"line_number":1174,"context_line":"        CG to be cloned from the snapshot (cg_dict), match up both"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_254f396c","line":1171,"range":{"start_line":1171,"start_character":47,"end_line":1171,"end_character":49},"in_reply_to":"1ac06dbe_bbcb96a4","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":1170,"context_line":"    def _collate_group_snapshot_info(self, group_dict, group_snapshot_dict):"},{"line_number":1171,"context_line":"        \"\"\"Collate the data for a clone of the CG snapshot."},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"        Given two data structures, a CG snapshot (cgsnapshot_dict) and a new"},{"line_number":1174,"context_line":"        CG to be cloned from the snapshot (cg_dict), match up both"},{"line_number":1175,"context_line":"        structures into a list of dicts (share \u0026 snapshot) suitable for use"},{"line_number":1176,"context_line":"        by existing method that clones individual share snapshots."}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_fbc50e8e","line":1173,"range":{"start_line":1173,"start_character":37,"end_line":1173,"end_character":39},"updated":"2016-08-22 12:59:09.000000000","message":"group","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":1170,"context_line":"    def _collate_group_snapshot_info(self, group_dict, group_snapshot_dict):"},{"line_number":1171,"context_line":"        \"\"\"Collate the data for a clone of the CG snapshot."},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"        Given two data structures, a CG snapshot (cgsnapshot_dict) and a new"},{"line_number":1174,"context_line":"        CG to be cloned from the snapshot (cg_dict), match up both"},{"line_number":1175,"context_line":"        structures into a list of dicts (share \u0026 snapshot) suitable for use"},{"line_number":1176,"context_line":"        by existing method that clones individual share snapshots."}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_7b38fea0","line":1173,"range":{"start_line":1173,"start_character":50,"end_line":1173,"end_character":65},"updated":"2016-08-22 12:59:09.000000000","message":"group_snapshot_dict","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":1170,"context_line":"    def _collate_group_snapshot_info(self, group_dict, group_snapshot_dict):"},{"line_number":1171,"context_line":"        \"\"\"Collate the data for a clone of the CG snapshot."},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"        Given two data structures, a CG snapshot (cgsnapshot_dict) and a new"},{"line_number":1174,"context_line":"        CG to be cloned from the snapshot (cg_dict), match up both"},{"line_number":1175,"context_line":"        structures into a list of dicts (share \u0026 snapshot) suitable for use"},{"line_number":1176,"context_line":"        by existing method that clones individual share snapshots."}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_45542dfe","line":1173,"range":{"start_line":1173,"start_character":50,"end_line":1173,"end_character":65},"in_reply_to":"1ac06dbe_7b38fea0","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":1170,"context_line":"    def _collate_group_snapshot_info(self, group_dict, group_snapshot_dict):"},{"line_number":1171,"context_line":"        \"\"\"Collate the data for a clone of the CG snapshot."},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"        Given two data structures, a CG snapshot (cgsnapshot_dict) and a new"},{"line_number":1174,"context_line":"        CG to be cloned from the snapshot (cg_dict), match up both"},{"line_number":1175,"context_line":"        structures into a list of dicts (share \u0026 snapshot) suitable for use"},{"line_number":1176,"context_line":"        by existing method that clones individual share snapshots."}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_855ac528","line":1173,"range":{"start_line":1173,"start_character":37,"end_line":1173,"end_character":39},"in_reply_to":"1ac06dbe_fbc50e8e","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"        \"\"\"Collate the data for a clone of the CG snapshot."},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"        Given two data structures, a CG snapshot (cgsnapshot_dict) and a new"},{"line_number":1174,"context_line":"        CG to be cloned from the snapshot (cg_dict), match up both"},{"line_number":1175,"context_line":"        structures into a list of dicts (share \u0026 snapshot) suitable for use"},{"line_number":1176,"context_line":"        by existing method that clones individual share snapshots."},{"line_number":1177,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_9b45fa18","line":1174,"range":{"start_line":1174,"start_character":8,"end_line":1174,"end_character":10},"updated":"2016-08-22 12:59:09.000000000","message":"group","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"        \"\"\"Collate the data for a clone of the CG snapshot."},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"        Given two data structures, a CG snapshot (cgsnapshot_dict) and a new"},{"line_number":1174,"context_line":"        CG to be cloned from the snapshot (cg_dict), match up both"},{"line_number":1175,"context_line":"        structures into a list of dicts (share \u0026 snapshot) suitable for use"},{"line_number":1176,"context_line":"        by existing method that clones individual share snapshots."},{"line_number":1177,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_db9f724e","line":1174,"range":{"start_line":1174,"start_character":43,"end_line":1174,"end_character":51},"updated":"2016-08-22 12:59:09.000000000","message":"group_dict","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"        \"\"\"Collate the data for a clone of the CG snapshot."},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"        Given two data structures, a CG snapshot (cgsnapshot_dict) and a new"},{"line_number":1174,"context_line":"        CG to be cloned from the snapshot (cg_dict), match up both"},{"line_number":1175,"context_line":"        structures into a list of dicts (share \u0026 snapshot) suitable for use"},{"line_number":1176,"context_line":"        by existing method that clones individual share snapshots."},{"line_number":1177,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_0547954b","line":1174,"range":{"start_line":1174,"start_character":8,"end_line":1174,"end_character":10},"in_reply_to":"1ac06dbe_9b45fa18","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"        \"\"\"Collate the data for a clone of the CG snapshot."},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"        Given two data structures, a CG snapshot (cgsnapshot_dict) and a new"},{"line_number":1174,"context_line":"        CG to be cloned from the snapshot (cg_dict), match up both"},{"line_number":1175,"context_line":"        structures into a list of dicts (share \u0026 snapshot) suitable for use"},{"line_number":1176,"context_line":"        by existing method that clones individual share snapshots."},{"line_number":1177,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_257659a4","line":1174,"range":{"start_line":1174,"start_character":43,"end_line":1174,"end_character":51},"in_reply_to":"1ac06dbe_db9f724e","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bb2532544ddeb5d982a178fa089f9f2778737c9c","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"            group_model_update - a dict containing any values to be updated"},{"line_number":1127,"context_line":"            for the group in the database. This value may be None."},{"line_number":1128,"context_line":"        \"\"\""},{"line_number":1129,"context_line":"        pass"},{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":"    def _cleanup_group_share_snapshot(self, context, share_snapshot,"},{"line_number":1132,"context_line":"                                      share_server):"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_6d50ea32","line":1129,"range":{"start_line":1129,"start_character":8,"end_line":1129,"end_character":12},"updated":"2016-11-11 10:59:25.000000000","message":"docstring is enough","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bb2532544ddeb5d982a178fa089f9f2778737c9c","unresolved":false,"context_lines":[{"line_number":1132,"context_line":"                                      share_server):"},{"line_number":1133,"context_line":"        \"\"\"Deletes the snapshot of a share belonging to a group.\"\"\""},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"        try:"},{"line_number":1136,"context_line":"            self.delete_snapshot(context, share_snapshot,"},{"line_number":1137,"context_line":"                                 share_server\u003dshare_server)"},{"line_number":1138,"context_line":"        except exception.ManilaException:"},{"line_number":1139,"context_line":"            msg \u003d _LE(\u0027Could not delete group snapshot member %(snap)s \u0027"},{"line_number":1140,"context_line":"                      \u0027for share %(share)s.\u0027)"},{"line_number":1141,"context_line":"            LOG.error(msg % {"},{"line_number":1142,"context_line":"                \u0027snap\u0027: share_snapshot[\u0027id\u0027],"},{"line_number":1143,"context_line":"                \u0027share\u0027: share_snapshot[\u0027share_id\u0027],"},{"line_number":1144,"context_line":"            })"},{"line_number":1145,"context_line":"            raise"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"    def create_group_snapshot(self, context, snap_dict, share_server\u003dNone):"},{"line_number":1148,"context_line":"        \"\"\"Create a share group snapshot."}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_6dc2aaea","line":1145,"range":{"start_line":1135,"start_character":8,"end_line":1145,"end_character":17},"updated":"2016-11-11 10:59:25.000000000","message":"Doing so we stop trying to delete all consequent snapshots. We should try to delete each of snapshots and only then fail.\n\nSo, I guess, we should remove \"raise\" here and replace \"LOG.error\" with \"LOG.exception\". Because we already know that this method is called only when other exception occurred. So, the only thing we really need here - delete as many snapshots as possible logging failures if any occur.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ea0421ca9da28e21e26c594aadf0a4fee7c810dd","unresolved":false,"context_lines":[{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"            member_update_list -  a list of dictionaries containing for every"},{"line_number":1192,"context_line":"            member of the group snapshot. Each dict should contains values to"},{"line_number":1193,"context_line":"            be updated for the CGSnapshotMember in the database. This list"},{"line_number":1194,"context_line":"            may be empty or None."},{"line_number":1195,"context_line":"        \"\"\""},{"line_number":1196,"context_line":"        LOG.debug(\u0027Attempting to create a group snapshot %s.\u0027, snap_dict[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_8057c5c8","line":1193,"range":{"start_line":1193,"start_character":31,"end_line":1193,"end_character":47},"updated":"2016-11-11 11:06:14.000000000","message":"CGSnapshotMember?","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ea0421ca9da28e21e26c594aadf0a4fee7c810dd","unresolved":false,"context_lines":[{"line_number":1200,"context_line":"            raise exception.GroupSnapshotNotSupported("},{"line_number":1201,"context_line":"                group\u003dsnap_dict[\u0027share_group_id\u0027])"},{"line_number":1202,"context_line":"        elif not snapshot_members:"},{"line_number":1203,"context_line":"            LOG.warning(_LW(\u0027No shares in group to create snapshot.\u0027))"},{"line_number":1204,"context_line":"        else:"},{"line_number":1205,"context_line":"            share_snapshots \u003d []"},{"line_number":1206,"context_line":"            for member in snapshot_members:"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_40eccd29","line":1203,"range":{"start_line":1203,"start_character":42,"end_line":1203,"end_character":47},"updated":"2016-11-11 11:06:14.000000000","message":"ID should be specified.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ea0421ca9da28e21e26c594aadf0a4fee7c810dd","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"                }"},{"line_number":1278,"context_line":"        :return: (group_snapshot_update, member_update_list)"},{"line_number":1279,"context_line":"            group_snapshot_update - a dict containing any values to be updated"},{"line_number":1280,"context_line":"            for the CGSnapshot in the database. This value may be None."},{"line_number":1281,"context_line":"        \"\"\""},{"line_number":1282,"context_line":"        snapshot_members \u003d snap_dict.get(\u0027group_snapshot_members\u0027, [])"},{"line_number":1283,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_60d63150","line":1280,"range":{"start_line":1280,"start_character":20,"end_line":1280,"end_character":30},"updated":"2016-11-11 11:06:14.000000000","message":"Old name","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ea0421ca9da28e21e26c594aadf0a4fee7c810dd","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"        return None, None"},{"line_number":1298,"context_line":""},{"line_number":1299,"context_line":"    def _collate_group_snapshot_info(self, group_dict, group_snapshot_dict):"},{"line_number":1300,"context_line":"        \"\"\"Collate the data for a clone of the CG snapshot."},{"line_number":1301,"context_line":""},{"line_number":1302,"context_line":"        Given two data structures, a group snapshot (group_snapshot_dict)"},{"line_number":1303,"context_line":"        and a new share to be cloned from the snapshot (group_dict),"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_e0496132","line":1300,"range":{"start_line":1300,"start_character":47,"end_line":1300,"end_character":49},"updated":"2016-11-11 11:06:14.000000000","message":"CG?","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bb2532544ddeb5d982a178fa089f9f2778737c9c","unresolved":false,"context_lines":[{"line_number":1320,"context_line":"                    break"},{"line_number":1321,"context_line":""},{"line_number":1322,"context_line":"            if len(clone_info) !\u003d 2:"},{"line_number":1323,"context_line":"                msg \u003d _(\"Invalid data supplied for creating group \""},{"line_number":1324,"context_line":"                        \"group from group snapshot %s.\") % group_snapshot_dict["},{"line_number":1325,"context_line":"                    \u0027id\u0027]"},{"line_number":1326,"context_line":"                raise exception.InvalidShareGroup(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_6df46a5a","line":1323,"range":{"start_line":1323,"start_character":60,"end_line":1323,"end_character":65},"updated":"2016-11-11 10:59:25.000000000","message":"s/group/share/","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8b881357f7a85a35c6162a4a0500ce60f6163680","unresolved":false,"context_lines":[{"line_number":1135,"context_line":"                [{\u0027id\u0027: \u0027uuid\u0027, \u0027export_locations\u0027: [{...}, {...}]}]"},{"line_number":1136,"context_line":"        \"\"\""},{"line_number":1137,"context_line":"        # Ensure that the share group snapshot has members"},{"line_number":1138,"context_line":"        if not share_group_snapshot_dict[\u0027share_group_snapshot_members\u0027]:"},{"line_number":1139,"context_line":"            return None, None"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"        clone_list \u003d self._collate_share_group_snapshot_info("},{"line_number":1142,"context_line":"            share_group_dict, share_group_snapshot_dict)"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_d4947be3","line":1139,"range":{"start_line":1138,"start_character":7,"end_line":1139,"end_character":29},"updated":"2017-01-21 00:44:24.000000000","message":"Either this should be an error, or an empty share group should be created, right? I don\u0027t see manager doing anything in this case. Not calling create_share_group() and not an error.","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"aff4933f6ed24b65e775d6d909abe5e6bd8944c0","unresolved":false,"context_lines":[{"line_number":1135,"context_line":"                [{\u0027id\u0027: \u0027uuid\u0027, \u0027export_locations\u0027: [{...}, {...}]}]"},{"line_number":1136,"context_line":"        \"\"\""},{"line_number":1137,"context_line":"        # Ensure that the share group snapshot has members"},{"line_number":1138,"context_line":"        if not share_group_snapshot_dict[\u0027share_group_snapshot_members\u0027]:"},{"line_number":1139,"context_line":"            return None, None"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"        clone_list \u003d self._collate_share_group_snapshot_info("},{"line_number":1142,"context_line":"            share_group_dict, share_group_snapshot_dict)"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_a4f78289","line":1139,"range":{"start_line":1138,"start_character":7,"end_line":1139,"end_character":29},"in_reply_to":"5a3905b3_d4947be3","updated":"2017-01-23 14:15:32.000000000","message":"same as in https://review.openstack.org/#/c/335093/52/manila/share/manager.py","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"}],"manila/share/drivers/cephfs/cephfs_native.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"45497e4a66318804cee58f0ed7ef89b03827b678","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        total_capacity_gb \u003d stats[\u0027kb\u0027] * units.Mi"},{"line_number":89,"context_line":"        free_capacity_gb \u003d stats[\u0027kb_avail\u0027] * units.Mi"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        data \u003d {"},{"line_number":92,"context_line":"            \u0027vendor_name\u0027: \u0027Ceph\u0027,"},{"line_number":93,"context_line":"            \u0027driver_version\u0027: \u00271.0\u0027,"},{"line_number":94,"context_line":"            \u0027share_backend_name\u0027: self.backend_name,"},{"line_number":95,"context_line":"            \u0027storage_protocol\u0027: \"CEPHFS\","}],"source_content_type":"text/x-python","patch_set":26,"id":"3ac371cc_27125459","line":92,"range":{"start_line":91,"start_character":1,"end_line":92,"end_character":34},"updated":"2016-08-18 17:05:35.000000000","message":"CG support is removed but the CG apis remain in this driver?","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        total_capacity_gb \u003d stats[\u0027kb\u0027] * units.Mi"},{"line_number":89,"context_line":"        free_capacity_gb \u003d stats[\u0027kb_avail\u0027] * units.Mi"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        data \u003d {"},{"line_number":92,"context_line":"            \u0027vendor_name\u0027: \u0027Ceph\u0027,"},{"line_number":93,"context_line":"            \u0027driver_version\u0027: \u00271.0\u0027,"},{"line_number":94,"context_line":"            \u0027share_backend_name\u0027: self.backend_name,"},{"line_number":95,"context_line":"            \u0027storage_protocol\u0027: \"CEPHFS\","}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_a598a9c1","line":92,"range":{"start_line":91,"start_character":1,"end_line":92,"end_character":34},"in_reply_to":"3ac371cc_27125459","updated":"2016-11-01 15:31:20.000000000","message":"The new share group snapshot functionality will work by default. Wondering if this patch is the right one to go through and update drivers that had CG support to do optimal snapshots. I can do that here I suppose since we are doing one giant patch anyways.","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"45497e4a66318804cee58f0ed7ef89b03827b678","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        # `share` is a Share"},{"line_number":175,"context_line":"        LOG.debug(\"create_share {be} name\u003d{id} size\u003d{size} cg_id\u003d{cg}\".format("},{"line_number":176,"context_line":"            be\u003dself.backend_name, id\u003dshare[\u0027id\u0027], size\u003dshare[\u0027size\u0027],"},{"line_number":177,"context_line":"            cg\u003dshare[\u0027consistency_group_id\u0027]))"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"},{"line_number":180,"context_line":"        data_isolated \u003d extra_specs.get(\"cephfs:data_isolated\", False)"}],"source_content_type":"text/x-python","patch_set":26,"id":"3ac371cc_8785085b","line":177,"range":{"start_line":177,"start_character":0,"end_line":177,"end_character":46},"updated":"2016-08-18 17:05:35.000000000","message":"This will break now.","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        # `share` is a Share"},{"line_number":175,"context_line":"        LOG.debug(\"create_share {be} name\u003d{id} size\u003d{size} cg_id\u003d{cg}\".format("},{"line_number":176,"context_line":"            be\u003dself.backend_name, id\u003dshare[\u0027id\u0027], size\u003dshare[\u0027size\u0027],"},{"line_number":177,"context_line":"            cg\u003dshare[\u0027consistency_group_id\u0027]))"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"},{"line_number":180,"context_line":"        data_isolated \u003d extra_specs.get(\"cephfs:data_isolated\", False)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_45d7cd4a","line":177,"range":{"start_line":177,"start_character":0,"end_line":177,"end_character":46},"in_reply_to":"3ac371cc_8785085b","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"}],"manila/share/manager.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8b881357f7a85a35c6162a4a0500ce60f6163680","unresolved":false,"context_lines":[{"line_number":3160,"context_line":"            else:"},{"line_number":3161,"context_line":"                model_update \u003d self.driver.create_share_group("},{"line_number":3162,"context_line":"                    context, share_group_ref, share_server\u003dshare_server)"},{"line_number":3163,"context_line":""},{"line_number":3164,"context_line":"            if model_update:"},{"line_number":3165,"context_line":"                share_group_ref \u003d self.db.share_group_update("},{"line_number":3166,"context_line":"                    context, share_group_ref[\u0027id\u0027], model_update)"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_cf6302db","line":3163,"updated":"2017-01-21 00:44:24.000000000","message":"here is where if there are no snap members, I\u0027m thinking it should\u0027ve done create_share_group, but it won\u0027t.","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"aff4933f6ed24b65e775d6d909abe5e6bd8944c0","unresolved":false,"context_lines":[{"line_number":3160,"context_line":"            else:"},{"line_number":3161,"context_line":"                model_update \u003d self.driver.create_share_group("},{"line_number":3162,"context_line":"                    context, share_group_ref, share_server\u003dshare_server)"},{"line_number":3163,"context_line":""},{"line_number":3164,"context_line":"            if model_update:"},{"line_number":3165,"context_line":"                share_group_ref \u003d self.db.share_group_update("},{"line_number":3166,"context_line":"                    context, share_group_ref[\u0027id\u0027], model_update)"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_c4c2ce33","line":3163,"in_reply_to":"5a3905b3_cf6302db","updated":"2017-01-23 14:15:32.000000000","message":"I am leaning to leave it as is because of following reasons:\n\n1) I don\u0027t change logic here, as you can see, renames only.\n2) None of bugs were found using this \"existing\" logic.\n3) We have too narrow time frame to change logic.","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"}],"manila/share/rpcapi.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            create_share() -\u003e create_share_instance()"},{"line_number":40,"context_line":"            delete_share() -\u003e delete_share_instance()"},{"line_number":41,"context_line":"            Add share_instance argument to allow_access() \u0026 deny_access()"},{"line_number":42,"context_line":"        1.5  - Add create_share_group, delete_share_group"},{"line_number":43,"context_line":"                create_group_snapshot, and delete_group_snapshot methods"},{"line_number":44,"context_line":"        1.6  - Introduce Share migration:"},{"line_number":45,"context_line":"            migrate_share()"},{"line_number":46,"context_line":"            get_migration_info()"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_3b4b26cb","line":43,"range":{"start_line":42,"start_character":21,"end_line":43,"end_character":56},"updated":"2016-08-22 12:59:09.000000000","message":"I wouldn\u0027t change this. It is history of what was done in the past","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            create_share() -\u003e create_share_instance()"},{"line_number":40,"context_line":"            delete_share() -\u003e delete_share_instance()"},{"line_number":41,"context_line":"            Add share_instance argument to allow_access() \u0026 deny_access()"},{"line_number":42,"context_line":"        1.5  - Add create_share_group, delete_share_group"},{"line_number":43,"context_line":"                create_group_snapshot, and delete_group_snapshot methods"},{"line_number":44,"context_line":"        1.6  - Introduce Share migration:"},{"line_number":45,"context_line":"            migrate_share()"},{"line_number":46,"context_line":"            get_migration_info()"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_0516b5f0","line":43,"range":{"start_line":42,"start_character":21,"end_line":43,"end_character":56},"in_reply_to":"1ac06dbe_3b4b26cb","updated":"2016-11-01 15:31:20.000000000","message":"Yeah I must have done that by accident","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"}],"manila/share_group/api.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Alex Meade"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_3b220601","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2016-08-22 12:59:09.000000000","message":"2016","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Alex Meade"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_e5ef01e7","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"1ac06dbe_3b220601","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":"Handles all requests relating to consistency groups."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_3be7a6b1","line":17,"range":{"start_line":17,"start_character":33,"end_line":17,"end_character":44},"updated":"2016-08-22 12:59:09.000000000","message":"share","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":"Handles all requests relating to consistency groups."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_45c18d53","line":17,"range":{"start_line":17,"start_character":33,"end_line":17,"end_character":44},"in_reply_to":"1ac06dbe_3be7a6b1","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def create(self, context, name\u003dNone, description\u003dNone,"},{"line_number":51,"context_line":"               share_type_ids\u003dNone, source_group_snapshot_id\u003dNone,"},{"line_number":52,"context_line":"               share_network_id\u003dNone, share_group_type_id\u003dNone):"},{"line_number":53,"context_line":"        \"\"\"Create new consistency group.\"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        group_snapshot \u003d None"},{"line_number":56,"context_line":"        original_group \u003d None"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_fb6eae2d","line":53,"range":{"start_line":53,"start_character":22,"end_line":53,"end_character":33},"updated":"2016-08-22 12:59:09.000000000","message":"share","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def create(self, context, name\u003dNone, description\u003dNone,"},{"line_number":51,"context_line":"               share_type_ids\u003dNone, source_group_snapshot_id\u003dNone,"},{"line_number":52,"context_line":"               share_network_id\u003dNone, share_group_type_id\u003dNone):"},{"line_number":53,"context_line":"        \"\"\"Create new consistency group.\"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        group_snapshot \u003d None"},{"line_number":56,"context_line":"        original_group \u003d None"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_65a93190","line":53,"range":{"start_line":53,"start_character":22,"end_line":53,"end_character":33},"in_reply_to":"1ac06dbe_fb6eae2d","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                share_type_object \u003d share_types.get_share_type("},{"line_number":82,"context_line":"                    context, share_type_id)"},{"line_number":83,"context_line":"            except exception.ShareTypeNotFound:"},{"line_number":84,"context_line":"                msg \u003d _(\"Share type with id %s could not be found\")"},{"line_number":85,"context_line":"                raise exception.InvalidInput(msg % share_type_id)"},{"line_number":86,"context_line":"            share_type_objects.append(share_type_object)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_2e22c600","line":84,"range":{"start_line":84,"start_character":64,"end_line":84,"end_character":66},"updated":"2016-08-22 12:59:09.000000000","message":"period","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                share_type_object \u003d share_types.get_share_type("},{"line_number":82,"context_line":"                    context, share_type_id)"},{"line_number":83,"context_line":"            except exception.ShareTypeNotFound:"},{"line_number":84,"context_line":"                msg \u003d _(\"Share type with id %s could not be found\")"},{"line_number":85,"context_line":"                raise exception.InvalidInput(msg % share_type_id)"},{"line_number":86,"context_line":"            share_type_objects.append(share_type_object)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_45a8ad8d","line":84,"range":{"start_line":84,"start_character":64,"end_line":84,"end_character":66},"in_reply_to":"1ac06dbe_2e22c600","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            group_type \u003d self.db.group_type_get(context, share_group_type_id)"},{"line_number":125,"context_line":"        except exception.ShareGroupTypeNotFound:"},{"line_number":126,"context_line":"            msg \u003d _(\"The specified share group type does not exist.\")"},{"line_number":127,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        supported_share_types \u003d set([x[\u0027share_type_id\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_8e877ad6","line":126,"range":{"start_line":126,"start_character":46,"end_line":126,"end_character":50},"updated":"2016-08-22 12:59:09.000000000","message":"please include the ID","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            group_type \u003d self.db.group_type_get(context, share_group_type_id)"},{"line_number":125,"context_line":"        except exception.ShareGroupTypeNotFound:"},{"line_number":126,"context_line":"            msg \u003d _(\"The specified share group type does not exist.\")"},{"line_number":127,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        supported_share_types \u003d set([x[\u0027share_type_id\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_e59d4167","line":126,"range":{"start_line":126,"start_character":46,"end_line":126,"end_character":50},"in_reply_to":"1ac06dbe_8e877ad6","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        return group"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def delete(self, context, group):"},{"line_number":191,"context_line":"        \"\"\"Delete consistency group.\"\"\""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        group_id \u003d group[\u0027id\u0027]"},{"line_number":194,"context_line":"        if not group[\u0027host\u0027]:"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_2e7926f7","line":191,"range":{"start_line":191,"start_character":18,"end_line":191,"end_character":29},"updated":"2016-08-22 12:59:09.000000000","message":"share","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        return group"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def delete(self, context, group):"},{"line_number":191,"context_line":"        \"\"\"Delete consistency group.\"\"\""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        group_id \u003d group[\u0027id\u0027]"},{"line_number":194,"context_line":"        if not group[\u0027host\u0027]:"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_258ad91b","line":191,"range":{"start_line":191,"start_character":18,"end_line":191,"end_character":29},"in_reply_to":"1ac06dbe_2e7926f7","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        statuses \u003d (constants.STATUS_AVAILABLE, constants.STATUS_ERROR)"},{"line_number":199,"context_line":"        if not group[\u0027status\u0027] in statuses:"},{"line_number":200,"context_line":"            msg \u003d (_(\"Consistency group status must be one of %(statuses)s\")"},{"line_number":201,"context_line":"                   % {\"statuses\": statuses})"},{"line_number":202,"context_line":"            raise exception.InvalidShareGroup(reason\u003dmsg)"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_0e742afb","line":200,"range":{"start_line":200,"start_character":22,"end_line":200,"end_character":33},"updated":"2016-08-22 12:59:09.000000000","message":"share","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        statuses \u003d (constants.STATUS_AVAILABLE, constants.STATUS_ERROR)"},{"line_number":199,"context_line":"        if not group[\u0027status\u0027] in statuses:"},{"line_number":200,"context_line":"            msg \u003d (_(\"Consistency group status must be one of %(statuses)s\")"},{"line_number":201,"context_line":"                   % {\"statuses\": statuses})"},{"line_number":202,"context_line":"            raise exception.InvalidShareGroup(reason\u003dmsg)"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_c57bdd26","line":200,"range":{"start_line":200,"start_character":22,"end_line":200,"end_character":33},"in_reply_to":"1ac06dbe_0e742afb","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        # NOTE(ameade): check for group_snapshots in the group"},{"line_number":205,"context_line":"        if self.db.count_group_snapshots_in_share_group(context, group_id):"},{"line_number":206,"context_line":"            msg \u003d (_(\"Cannot delete a consistency group with group_snapshots\"))"},{"line_number":207,"context_line":"            raise exception.InvalidShareGroup(reason\u003dmsg)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        # NOTE(ameade): check for shares in the group"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_ae5b5686","line":206,"range":{"start_line":206,"start_character":38,"end_line":206,"end_character":49},"updated":"2016-08-22 12:59:09.000000000","message":"share","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        # NOTE(ameade): check for group_snapshots in the group"},{"line_number":205,"context_line":"        if self.db.count_group_snapshots_in_share_group(context, group_id):"},{"line_number":206,"context_line":"            msg \u003d (_(\"Cannot delete a consistency group with group_snapshots\"))"},{"line_number":207,"context_line":"            raise exception.InvalidShareGroup(reason\u003dmsg)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        # NOTE(ameade): check for shares in the group"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_e5746137","line":206,"range":{"start_line":206,"start_character":38,"end_line":206,"end_character":49},"in_reply_to":"1ac06dbe_ae5b5686","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        # NOTE(ameade): check for shares in the group"},{"line_number":210,"context_line":"        if self.db.count_shares_in_share_group(context, group_id):"},{"line_number":211,"context_line":"            msg \u003d (_(\"Cannot delete a consistency group with shares\"))"},{"line_number":212,"context_line":"            raise exception.InvalidShareGroup(reason\u003dmsg)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        group \u003d self.db.share_group_update("}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_ce505261","line":211,"range":{"start_line":211,"start_character":38,"end_line":211,"end_character":49},"updated":"2016-08-22 12:59:09.000000000","message":"share","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        # NOTE(ameade): check for shares in the group"},{"line_number":210,"context_line":"        if self.db.count_shares_in_share_group(context, group_id):"},{"line_number":211,"context_line":"            msg \u003d (_(\"Cannot delete a consistency group with shares\"))"},{"line_number":212,"context_line":"            raise exception.InvalidShareGroup(reason\u003dmsg)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        group \u003d self.db.share_group_update("}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_05723549","line":211,"range":{"start_line":211,"start_character":38,"end_line":211,"end_character":49},"in_reply_to":"1ac06dbe_ce505261","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        return snap"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def delete_group_snapshot(self, context, snap):"},{"line_number":310,"context_line":"        \"\"\"Delete consistency group snapshot.\"\"\""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        snap_id \u003d snap[\u0027id\u0027]"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_0ee26a9f","line":310,"range":{"start_line":310,"start_character":18,"end_line":310,"end_character":29},"updated":"2016-08-22 12:59:09.000000000","message":"share","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        return snap"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def delete_group_snapshot(self, context, snap):"},{"line_number":310,"context_line":"        \"\"\"Delete consistency group snapshot.\"\"\""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        snap_id \u003d snap[\u0027id\u0027]"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_2591f947","line":310,"range":{"start_line":310,"start_character":18,"end_line":310,"end_character":29},"in_reply_to":"1ac06dbe_0ee26a9f","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        if search_opts is None:"},{"line_number":341,"context_line":"            search_opts \u003d {}"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        LOG.debug(\"Searching for consistency group snapshots by: %s\","},{"line_number":344,"context_line":"                  six.text_type(search_opts))"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        # Get filtered list of share_groups"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_1b746afb","line":343,"range":{"start_line":343,"start_character":33,"end_line":343,"end_character":44},"updated":"2016-08-22 12:59:09.000000000","message":"share","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        if search_opts is None:"},{"line_number":341,"context_line":"            search_opts \u003d {}"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        LOG.debug(\"Searching for consistency group snapshots by: %s\","},{"line_number":344,"context_line":"                  six.text_type(search_opts))"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        # Get filtered list of share_groups"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_4596ed3f","line":343,"range":{"start_line":343,"start_character":33,"end_line":343,"end_character":44},"in_reply_to":"1ac06dbe_1b746afb","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8b881357f7a85a35c6162a4a0500ce60f6163680","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Alex Meade"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_6fce8eb5","line":1,"updated":"2017-01-21 00:44:24.000000000","message":"I would leave the date where it was when written.","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95a36d4def7067fd2f61c30355424a3336b1c626","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Alex Meade"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_effecbac","line":1,"in_reply_to":"5a3905b3_6fce8eb5","updated":"2017-01-23 13:07:01.000000000","message":"Done","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"}],"manila/share_group/group_types.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                                             share_types\u003dshare_types),"},{"line_number":47,"context_line":"                                        projects\u003dprojects)"},{"line_number":48,"context_line":"    except db_exception.DBError:"},{"line_number":49,"context_line":"        LOG.exception(_LE(\u0027DB error\u0027))"},{"line_number":50,"context_line":"        raise exception.GroupTypeCreateFailed(name\u003dname,"},{"line_number":51,"context_line":"                                              extra_specs\u003dextra_specs)"},{"line_number":52,"context_line":"    return type_ref"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_4e99021f","line":49,"range":{"start_line":49,"start_character":27,"end_line":49,"end_character":35},"updated":"2016-08-22 12:59:09.000000000","message":"is there any way to obtain more information about this error?","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                                             share_types\u003dshare_types),"},{"line_number":47,"context_line":"                                        projects\u003dprojects)"},{"line_number":48,"context_line":"    except db_exception.DBError:"},{"line_number":49,"context_line":"        LOG.exception(_LE(\u0027DB error\u0027))"},{"line_number":50,"context_line":"        raise exception.GroupTypeCreateFailed(name\u003dname,"},{"line_number":51,"context_line":"                                              extra_specs\u003dextra_specs)"},{"line_number":52,"context_line":"    return type_ref"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_45bd0db6","line":49,"range":{"start_line":49,"start_character":27,"end_line":49,"end_character":35},"in_reply_to":"1ac06dbe_4e99021f","updated":"2016-11-01 15:31:20.000000000","message":"LOG.exception will log the raw error details including traceback","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"def destroy(context, id):"},{"line_number":56,"context_line":"    \"\"\"Marks group types as deleted.\"\"\""},{"line_number":57,"context_line":"    if id is None:"},{"line_number":58,"context_line":"        msg \u003d _(\"id cannot be None\")"},{"line_number":59,"context_line":"        raise exception.InvalidShareGroupType(reason\u003dmsg)"},{"line_number":60,"context_line":"    else:"},{"line_number":61,"context_line":"        db.group_type_destroy(context, id)"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_8ebada6c","line":58,"range":{"start_line":58,"start_character":33,"end_line":58,"end_character":35},"updated":"2016-08-22 12:59:09.000000000","message":"period","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"def destroy(context, id):"},{"line_number":56,"context_line":"    \"\"\"Marks group types as deleted.\"\"\""},{"line_number":57,"context_line":"    if id is None:"},{"line_number":58,"context_line":"        msg \u003d _(\"id cannot be None\")"},{"line_number":59,"context_line":"        raise exception.InvalidShareGroupType(reason\u003dmsg)"},{"line_number":60,"context_line":"    else:"},{"line_number":61,"context_line":"        db.group_type_destroy(context, id)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_e5c2a133","line":58,"range":{"start_line":58,"start_character":33,"end_line":58,"end_character":35},"in_reply_to":"1ac06dbe_8ebada6c","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":120,"context_line":"def get_group_type_by_name(context, name):"},{"line_number":121,"context_line":"    \"\"\"Retrieves single group type by name.\"\"\""},{"line_number":122,"context_line":"    if name is None:"},{"line_number":123,"context_line":"        msg \u003d _(\"name cannot be None\")"},{"line_number":124,"context_line":"        raise exception.InvalidShareGroupType(reason\u003dmsg)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    return db.group_type_get_by_name(context, name)"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_8e713ae3","line":123,"range":{"start_line":123,"start_character":35,"end_line":123,"end_character":37},"updated":"2016-08-22 12:59:09.000000000","message":"period","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":120,"context_line":"def get_group_type_by_name(context, name):"},{"line_number":121,"context_line":"    \"\"\"Retrieves single group type by name.\"\"\""},{"line_number":122,"context_line":"    if name is None:"},{"line_number":123,"context_line":"        msg \u003d _(\"name cannot be None\")"},{"line_number":124,"context_line":"        raise exception.InvalidShareGroupType(reason\u003dmsg)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    return db.group_type_get_by_name(context, name)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_85eac5aa","line":123,"range":{"start_line":123,"start_character":35,"end_line":123,"end_character":37},"in_reply_to":"1ac06dbe_8e713ae3","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    if not group_type:"},{"line_number":131,"context_line":"        group_type_ref \u003d get_default_group_type(context)"},{"line_number":132,"context_line":"        if not group_type_ref:"},{"line_number":133,"context_line":"            msg \u003d _(\"Default group type not found\")"},{"line_number":134,"context_line":"            raise exception.GroupTypeNotFound(reason\u003dmsg)"},{"line_number":135,"context_line":"        return group_type_ref"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_4e4e2297","line":133,"range":{"start_line":133,"start_character":48,"end_line":133,"end_character":50},"updated":"2016-08-22 12:59:09.000000000","message":"period","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    if not group_type:"},{"line_number":131,"context_line":"        group_type_ref \u003d get_default_group_type(context)"},{"line_number":132,"context_line":"        if not group_type_ref:"},{"line_number":133,"context_line":"            msg \u003d _(\"Default group type not found\")"},{"line_number":134,"context_line":"            raise exception.GroupTypeNotFound(reason\u003dmsg)"},{"line_number":135,"context_line":"        return group_type_ref"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_c5d03df9","line":133,"range":{"start_line":133,"start_character":48,"end_line":133,"end_character":50},"in_reply_to":"1ac06dbe_4e4e2297","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        return get_group_type_by_name(ctxt, name)"},{"line_number":155,"context_line":"    except exception.GroupTypeNotFoundByName:"},{"line_number":156,"context_line":"        LOG.exception(_LE(\u0027Default group type is not found, \u0027"},{"line_number":157,"context_line":"                          \u0027please check default_group_type config\u0027))"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def get_group_type_extra_specs(group_type_id, key\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_8ea3fa4e","line":157,"range":{"start_line":157,"start_character":64,"end_line":157,"end_character":66},"updated":"2016-08-22 12:59:09.000000000","message":"period","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        return get_group_type_by_name(ctxt, name)"},{"line_number":155,"context_line":"    except exception.GroupTypeNotFoundByName:"},{"line_number":156,"context_line":"        LOG.exception(_LE(\u0027Default group type is not found, \u0027"},{"line_number":157,"context_line":"                          \u0027please check default_group_type config\u0027))"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def get_group_type_extra_specs(group_type_id, key\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_e5d9c123","line":157,"range":{"start_line":157,"start_character":64,"end_line":157,"end_character":66},"in_reply_to":"1ac06dbe_8ea3fa4e","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":181,"context_line":"def add_group_type_access(context, group_type_id, project_id):"},{"line_number":182,"context_line":"    \"\"\"Add access to group type for project_id.\"\"\""},{"line_number":183,"context_line":"    if group_type_id is None:"},{"line_number":184,"context_line":"        msg \u003d _(\"group_type_id cannot be None\")"},{"line_number":185,"context_line":"        raise exception.InvalidShareGroupType(reason\u003dmsg)"},{"line_number":186,"context_line":"    return db.group_type_access_add(context, group_type_id, project_id)"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_ce85f2ad","line":184,"range":{"start_line":184,"start_character":44,"end_line":184,"end_character":46},"updated":"2016-08-22 12:59:09.000000000","message":"period","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":181,"context_line":"def add_group_type_access(context, group_type_id, project_id):"},{"line_number":182,"context_line":"    \"\"\"Add access to group type for project_id.\"\"\""},{"line_number":183,"context_line":"    if group_type_id is None:"},{"line_number":184,"context_line":"        msg \u003d _(\"group_type_id cannot be None\")"},{"line_number":185,"context_line":"        raise exception.InvalidShareGroupType(reason\u003dmsg)"},{"line_number":186,"context_line":"    return db.group_type_access_add(context, group_type_id, project_id)"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_65fcd172","line":184,"range":{"start_line":184,"start_character":44,"end_line":184,"end_character":46},"in_reply_to":"1ac06dbe_ce85f2ad","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":189,"context_line":"def remove_group_type_access(context, group_type_id, project_id):"},{"line_number":190,"context_line":"    \"\"\"Remove access to group type for project_id.\"\"\""},{"line_number":191,"context_line":"    if group_type_id is None:"},{"line_number":192,"context_line":"        msg \u003d _(\"group_type_id cannot be None\")"},{"line_number":193,"context_line":"        raise exception.InvalidShareGroupType(reason\u003dmsg)"},{"line_number":194,"context_line":"    return db.group_type_access_remove(context, group_type_id, project_id)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_6e195e88","line":192,"range":{"start_line":192,"start_character":44,"end_line":192,"end_character":46},"updated":"2016-08-22 12:59:09.000000000","message":"period","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":189,"context_line":"def remove_group_type_access(context, group_type_id, project_id):"},{"line_number":190,"context_line":"    \"\"\"Remove access to group type for project_id.\"\"\""},{"line_number":191,"context_line":"    if group_type_id is None:"},{"line_number":192,"context_line":"        msg \u003d _(\"group_type_id cannot be None\")"},{"line_number":193,"context_line":"        raise exception.InvalidShareGroupType(reason\u003dmsg)"},{"line_number":194,"context_line":"    return db.group_type_access_remove(context, group_type_id, project_id)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_8501e56c","line":192,"range":{"start_line":192,"start_character":44,"end_line":192,"end_character":46},"in_reply_to":"1ac06dbe_6e195e88","updated":"2016-11-01 15:31:20.000000000","message":"Done","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    ...}"},{"line_number":207,"context_line":"    \"\"\""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def _dict_diff(dict1, dict2):"},{"line_number":210,"context_line":"        res \u003d {}"},{"line_number":211,"context_line":"        equal \u003d True"},{"line_number":212,"context_line":"        if dict1 is None:"},{"line_number":213,"context_line":"            dict1 \u003d {}"},{"line_number":214,"context_line":"        if dict2 is None:"},{"line_number":215,"context_line":"            dict2 \u003d {}"},{"line_number":216,"context_line":"        for k, v in dict1.items():"},{"line_number":217,"context_line":"            res[k] \u003d (v, dict2.get(k))"},{"line_number":218,"context_line":"            if k not in dict2 or res[k][0] !\u003d res[k][1]:"},{"line_number":219,"context_line":"                equal \u003d False"},{"line_number":220,"context_line":"        for k, v in dict2.items():"},{"line_number":221,"context_line":"            res[k] \u003d (dict1.get(k), v)"},{"line_number":222,"context_line":"            if k not in dict1 or res[k][0] !\u003d res[k][1]:"},{"line_number":223,"context_line":"                equal \u003d False"},{"line_number":224,"context_line":"        return (res, equal)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    all_equal \u003d True"},{"line_number":227,"context_line":"    diff \u003d {}"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_ce085230","line":224,"range":{"start_line":209,"start_character":0,"end_line":224,"end_character":27},"updated":"2016-08-22 12:59:09.000000000","message":"this should be in manila.utils","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    ...}"},{"line_number":207,"context_line":"    \"\"\""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def _dict_diff(dict1, dict2):"},{"line_number":210,"context_line":"        res \u003d {}"},{"line_number":211,"context_line":"        equal \u003d True"},{"line_number":212,"context_line":"        if dict1 is None:"},{"line_number":213,"context_line":"            dict1 \u003d {}"},{"line_number":214,"context_line":"        if dict2 is None:"},{"line_number":215,"context_line":"            dict2 \u003d {}"},{"line_number":216,"context_line":"        for k, v in dict1.items():"},{"line_number":217,"context_line":"            res[k] \u003d (v, dict2.get(k))"},{"line_number":218,"context_line":"            if k not in dict2 or res[k][0] !\u003d res[k][1]:"},{"line_number":219,"context_line":"                equal \u003d False"},{"line_number":220,"context_line":"        for k, v in dict2.items():"},{"line_number":221,"context_line":"            res[k] \u003d (dict1.get(k), v)"},{"line_number":222,"context_line":"            if k not in dict1 or res[k][0] !\u003d res[k][1]:"},{"line_number":223,"context_line":"                equal \u003d False"},{"line_number":224,"context_line":"        return (res, equal)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    all_equal \u003d True"},{"line_number":227,"context_line":"    diff \u003d {}"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_c553dd69","line":224,"range":{"start_line":209,"start_character":0,"end_line":224,"end_character":27},"in_reply_to":"1ac06dbe_ce085230","updated":"2016-11-01 15:31:20.000000000","message":"I\u0027ll see what I can do","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"28278a17b906f0a179a3180b92e60afc15586ad3","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    return get_group_type_extra_specs(type_id)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"def parse_boolean_extra_spec(extra_spec_key, extra_spec_value):"},{"line_number":246,"context_line":"    \"\"\"Parse extra spec values of the form \u0027\u003cis\u003e True\u0027 or \u0027\u003cis\u003e False\u0027"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    This method returns the boolean value of an extra spec value.  If"},{"line_number":249,"context_line":"    the value does not conform to the standard boolean pattern, it raises"},{"line_number":250,"context_line":"    an InvalidExtraSpec exception."},{"line_number":251,"context_line":"    \"\"\""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    try:"},{"line_number":254,"context_line":"        if not isinstance(extra_spec_value, six.string_types):"},{"line_number":255,"context_line":"            raise ValueError"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        match \u003d re.match(r\u0027^\u003cis\u003e\\s*(?P\u003cvalue\u003eTrue|False)$\u0027,"},{"line_number":258,"context_line":"                         extra_spec_value.strip(),"},{"line_number":259,"context_line":"                         re.IGNORECASE)"},{"line_number":260,"context_line":"        if not match:"},{"line_number":261,"context_line":"            raise ValueError"},{"line_number":262,"context_line":"        else:"},{"line_number":263,"context_line":"            return strutils.bool_from_string(match.group(\u0027value\u0027), strict\u003dTrue)"},{"line_number":264,"context_line":"    except ValueError:"},{"line_number":265,"context_line":"        msg \u003d (_(\u0027Invalid boolean extra spec %(key)s : %(value)s\u0027) %"},{"line_number":266,"context_line":"               {\u0027key\u0027: extra_spec_key, \u0027value\u0027: extra_spec_value})"},{"line_number":267,"context_line":"        raise exception.InvalidExtraSpec(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":26,"id":"1ac06dbe_311fc760","line":267,"range":{"start_line":245,"start_character":3,"end_line":267,"end_character":52},"updated":"2016-08-22 12:59:09.000000000","message":"IIRC, there are other methods that do this, and this should be in manila.utils or similar place.","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eb48f4b635e9d10c1934b374489df0f4d89292e4","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    return get_group_type_extra_specs(type_id)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"def parse_boolean_extra_spec(extra_spec_key, extra_spec_value):"},{"line_number":246,"context_line":"    \"\"\"Parse extra spec values of the form \u0027\u003cis\u003e True\u0027 or \u0027\u003cis\u003e False\u0027"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    This method returns the boolean value of an extra spec value.  If"},{"line_number":249,"context_line":"    the value does not conform to the standard boolean pattern, it raises"},{"line_number":250,"context_line":"    an InvalidExtraSpec exception."},{"line_number":251,"context_line":"    \"\"\""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    try:"},{"line_number":254,"context_line":"        if not isinstance(extra_spec_value, six.string_types):"},{"line_number":255,"context_line":"            raise ValueError"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        match \u003d re.match(r\u0027^\u003cis\u003e\\s*(?P\u003cvalue\u003eTrue|False)$\u0027,"},{"line_number":258,"context_line":"                         extra_spec_value.strip(),"},{"line_number":259,"context_line":"                         re.IGNORECASE)"},{"line_number":260,"context_line":"        if not match:"},{"line_number":261,"context_line":"            raise ValueError"},{"line_number":262,"context_line":"        else:"},{"line_number":263,"context_line":"            return strutils.bool_from_string(match.group(\u0027value\u0027), strict\u003dTrue)"},{"line_number":264,"context_line":"    except ValueError:"},{"line_number":265,"context_line":"        msg \u003d (_(\u0027Invalid boolean extra spec %(key)s : %(value)s\u0027) %"},{"line_number":266,"context_line":"               {\u0027key\u0027: extra_spec_key, \u0027value\u0027: extra_spec_value})"},{"line_number":267,"context_line":"        raise exception.InvalidExtraSpec(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5da102_45ceed2e","line":267,"range":{"start_line":245,"start_character":3,"end_line":267,"end_character":52},"in_reply_to":"1ac06dbe_311fc760","updated":"2016-11-01 15:31:20.000000000","message":"I thought there was too but didn\u0027t see it at a glance. Will see what I can do.","commit_id":"d4b87e7c80d88e70e13228b9a51353d72ddcc770"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1537d42dcb0e618aa8538fe1bf4cc63c8f6be8d7","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    try:"},{"line_number":42,"context_line":"        type_ref \u003d db.group_type_create(context,"},{"line_number":43,"context_line":"                                        dict(name\u003dname,"},{"line_number":44,"context_line":"                                             extra_specs\u003dextra_specs,"},{"line_number":45,"context_line":"                                             is_public\u003dis_public,"},{"line_number":46,"context_line":"                                             share_types\u003dshare_types),"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_63228dbb","line":43,"range":{"start_line":43,"start_character":40,"end_line":43,"end_character":44},"updated":"2016-11-07 12:20:01.000000000","message":"https://www.python.org/dev/peps/pep-0274/","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d524380bb7cbfd914095a8bd3afca1ad5818d665","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        return extra_specs"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"def get_tenant_visible_extra_specs():"},{"line_number":174,"context_line":"    return constants.ExtraSpecs.TENANT_VISIBLE"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"def get_boolean_extra_specs():"},{"line_number":178,"context_line":"    return constants.ExtraSpecs.BOOLEAN"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"def add_group_type_access(context, group_type_id, project_id):"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_c3eaa7da","line":178,"range":{"start_line":173,"start_character":0,"end_line":178,"end_character":39},"updated":"2016-11-11 11:41:32.000000000","message":"copy-paste","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d524380bb7cbfd914095a8bd3afca1ad5818d665","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    ...}"},{"line_number":207,"context_line":"    \"\"\""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def _dict_diff(dict1, dict2):"},{"line_number":210,"context_line":"        res \u003d {}"},{"line_number":211,"context_line":"        equal \u003d True"},{"line_number":212,"context_line":"        if dict1 is None:"},{"line_number":213,"context_line":"            dict1 \u003d {}"},{"line_number":214,"context_line":"        if dict2 is None:"},{"line_number":215,"context_line":"            dict2 \u003d {}"},{"line_number":216,"context_line":"        for k, v in dict1.items():"},{"line_number":217,"context_line":"            res[k] \u003d (v, dict2.get(k))"},{"line_number":218,"context_line":"            if k not in dict2 or res[k][0] !\u003d res[k][1]:"},{"line_number":219,"context_line":"                equal \u003d False"},{"line_number":220,"context_line":"        for k, v in dict2.items():"},{"line_number":221,"context_line":"            res[k] \u003d (dict1.get(k), v)"},{"line_number":222,"context_line":"            if k not in dict1 or res[k][0] !\u003d res[k][1]:"},{"line_number":223,"context_line":"                equal \u003d False"},{"line_number":224,"context_line":"        return (res, equal)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    all_equal \u003d True"},{"line_number":227,"context_line":"    diff \u003d {}"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_432f773e","line":224,"range":{"start_line":209,"start_character":0,"end_line":224,"end_character":27},"updated":"2016-11-11 11:41:32.000000000","message":"Copy-paste of existing logic:\nhttps://github.com/openstack/manila/blob/2bc62539/manila/share/share_types.py#L288","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d524380bb7cbfd914095a8bd3afca1ad5818d665","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    all_equal \u003d True"},{"line_number":227,"context_line":"    diff \u003d {}"},{"line_number":228,"context_line":"    group_type1 \u003d get_group_type(context, group_type_id1)"},{"line_number":229,"context_line":"    group_type2 \u003d get_group_type(context, group_type_id2)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    extra_specs1 \u003d group_type1.get(\u0027extra_specs\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_43d69728","line":228,"range":{"start_line":228,"start_character":18,"end_line":228,"end_character":32},"updated":"2016-11-11 11:41:32.000000000","message":"In whole function, only name of this is different than in existing share types code.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d524380bb7cbfd914095a8bd3afca1ad5818d665","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    all_equal \u003d True"},{"line_number":227,"context_line":"    diff \u003d {}"},{"line_number":228,"context_line":"    group_type1 \u003d get_group_type(context, group_type_id1)"},{"line_number":229,"context_line":"    group_type2 \u003d get_group_type(context, group_type_id2)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    extra_specs1 \u003d group_type1.get(\u0027extra_specs\u0027)"},{"line_number":232,"context_line":"    extra_specs2 \u003d group_type2.get(\u0027extra_specs\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_63d9db56","line":229,"range":{"start_line":229,"start_character":18,"end_line":229,"end_character":32},"updated":"2016-11-11 11:41:32.000000000","message":"ditto","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d524380bb7cbfd914095a8bd3afca1ad5818d665","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    return get_group_type_extra_specs(type_id)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"def parse_boolean_extra_spec(extra_spec_key, extra_spec_value):"},{"line_number":246,"context_line":"    \"\"\"Parse extra spec values of the form \u0027\u003cis\u003e True\u0027 or \u0027\u003cis\u003e False\u0027"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    This method returns the boolean value of an extra spec value.  If"},{"line_number":249,"context_line":"    the value does not conform to the standard boolean pattern, it raises"},{"line_number":250,"context_line":"    an InvalidExtraSpec exception."},{"line_number":251,"context_line":"    \"\"\""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    try:"},{"line_number":254,"context_line":"        if not isinstance(extra_spec_value, six.string_types):"},{"line_number":255,"context_line":"            raise ValueError"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        match \u003d re.match(r\u0027^\u003cis\u003e\\s*(?P\u003cvalue\u003eTrue|False)$\u0027,"},{"line_number":258,"context_line":"                         extra_spec_value.strip(),"},{"line_number":259,"context_line":"                         re.IGNORECASE)"},{"line_number":260,"context_line":"        if not match:"},{"line_number":261,"context_line":"            raise ValueError"},{"line_number":262,"context_line":"        else:"},{"line_number":263,"context_line":"            return strutils.bool_from_string(match.group(\u0027value\u0027), strict\u003dTrue)"},{"line_number":264,"context_line":"    except ValueError:"},{"line_number":265,"context_line":"        msg \u003d (_(\u0027Invalid boolean extra spec %(key)s : %(value)s\u0027) %"},{"line_number":266,"context_line":"               {\u0027key\u0027: extra_spec_key, \u0027value\u0027: extra_spec_value})"},{"line_number":267,"context_line":"        raise exception.InvalidExtraSpec(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_036c9f9a","line":267,"range":{"start_line":245,"start_character":0,"end_line":267,"end_character":52},"updated":"2016-11-11 11:41:32.000000000","message":"Copy-paste of existing logic in manila codebase:\n\nhttps://github.com/openstack/manila/blob/2bc62539/manila/share/share_types.py#L324","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"}],"manila/share_group/share_group_types.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9a6532619e868b7f98dfbb89cd33f42846018df8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def create(context, name, share_types, group_specs\u003dNone, is_public\u003dTrue,"},{"line_number":30,"context_line":"           projects\u003dNone):"},{"line_number":31,"context_line":"    \"\"\"Creates share group types.\"\"\""},{"line_number":32,"context_line":"    group_specs \u003d group_specs or {}"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_808628d9","line":29,"range":{"start_line":29,"start_character":20,"end_line":29,"end_character":24},"updated":"2017-01-21 06:12:26.000000000","message":"It\u0027s a corner-case, but a uuid_like name breaks the get_by_name_or_id below. So testing for that here and throwing an error would protect against that. Just a corner-case.","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9a6532619e868b7f98dfbb89cd33f42846018df8","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def get_all(context, inactive\u003d0, search_opts\u003dNone):"},{"line_number":57,"context_line":"    \"\"\"Get all non-deleted share group types.\"\"\""},{"line_number":58,"context_line":"    # TODO(ameade): Fix docstring"},{"line_number":59,"context_line":"    search_opts \u003d search_opts or {}"},{"line_number":60,"context_line":"    filters \u003d {}"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_80ae2896","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":10},"updated":"2017-01-21 06:12:26.000000000","message":"TODO","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9a6532619e868b7f98dfbb89cd33f42846018df8","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            raise exception.ShareGroupTypeNotFound(reason\u003dmsg)"},{"line_number":126,"context_line":"        return share_group_type_ref"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    if uuidutils.is_uuid_like(share_group_type):"},{"line_number":129,"context_line":"        return get(context, share_group_type)"},{"line_number":130,"context_line":"    else:"},{"line_number":131,"context_line":"        return get_by_name(context, share_group_type)"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_2014949e","line":128,"updated":"2017-01-21 06:12:26.000000000","message":"since a uuid_like name would break this, we should not allow uuid_like names. Or we could look it up with get() and then if that fails try it by_name() -- but that seems kind of silly since it is such a corner-case.","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95a36d4def7067fd2f61c30355424a3336b1c626","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            raise exception.ShareGroupTypeNotFound(reason\u003dmsg)"},{"line_number":126,"context_line":"        return share_group_type_ref"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    if uuidutils.is_uuid_like(share_group_type):"},{"line_number":129,"context_line":"        return get(context, share_group_type)"},{"line_number":130,"context_line":"    else:"},{"line_number":131,"context_line":"        return get_by_name(context, share_group_type)"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_ef016b07","line":128,"in_reply_to":"5a3905b3_2014949e","updated":"2017-01-23 13:07:01.000000000","message":"I am leaning to leave it as is, because it is identical to what we have in share types and we haven\u0027t faced any problems with it there.","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9a6532619e868b7f98dfbb89cd33f42846018df8","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    try:"},{"line_number":142,"context_line":"        return get_by_name(ctxt, name)"},{"line_number":143,"context_line":"    except exception.ShareGroupTypeNotFoundByName:"},{"line_number":144,"context_line":"        LOG.exception(_LE(\u0027Default share group type is not found, \u0027"},{"line_number":145,"context_line":"                          \u0027please check default_share_group_type config\u0027))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_e0752cfa","line":144,"updated":"2017-01-21 06:12:26.000000000","message":"The msg should include the name","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95a36d4def7067fd2f61c30355424a3336b1c626","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    try:"},{"line_number":142,"context_line":"        return get_by_name(ctxt, name)"},{"line_number":143,"context_line":"    except exception.ShareGroupTypeNotFoundByName:"},{"line_number":144,"context_line":"        LOG.exception(_LE(\u0027Default share group type is not found, \u0027"},{"line_number":145,"context_line":"                          \u0027please check default_share_group_type config\u0027))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_6febbb78","line":144,"in_reply_to":"5a3905b3_e0752cfa","updated":"2017-01-23 13:07:01.000000000","message":"Done","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9a6532619e868b7f98dfbb89cd33f42846018df8","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        if group_specs.get(key):"},{"line_number":153,"context_line":"            return group_specs.get(key)"},{"line_number":154,"context_line":"        else:"},{"line_number":155,"context_line":"            return False"},{"line_number":156,"context_line":"    else:"},{"line_number":157,"context_line":"        return group_specs"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_4051a035","line":155,"range":{"start_line":155,"start_character":19,"end_line":155,"end_character":24},"updated":"2017-01-21 06:12:26.000000000","message":"defaulting to False is strange. Why is it False instead of None? I guess this is OK for now.","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95a36d4def7067fd2f61c30355424a3336b1c626","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        if group_specs.get(key):"},{"line_number":153,"context_line":"            return group_specs.get(key)"},{"line_number":154,"context_line":"        else:"},{"line_number":155,"context_line":"            return False"},{"line_number":156,"context_line":"    else:"},{"line_number":157,"context_line":"        return group_specs"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_2f80d3bf","line":155,"range":{"start_line":155,"start_character":19,"end_line":155,"end_character":24},"in_reply_to":"5a3905b3_4051a035","updated":"2017-01-23 13:07:01.000000000","message":"deleted as unused","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9a6532619e868b7f98dfbb89cd33f42846018df8","unresolved":false,"context_lines":[{"line_number":148,"context_line":"def get_group_specs(share_group_type_id, key\u003dFalse):"},{"line_number":149,"context_line":"    share_group_type \u003d get(context.get_admin_context(), share_group_type_id)"},{"line_number":150,"context_line":"    group_specs \u003d share_group_type[\u0027group_specs\u0027]"},{"line_number":151,"context_line":"    if key:"},{"line_number":152,"context_line":"        if group_specs.get(key):"},{"line_number":153,"context_line":"            return group_specs.get(key)"},{"line_number":154,"context_line":"        else:"},{"line_number":155,"context_line":"            return False"},{"line_number":156,"context_line":"    else:"},{"line_number":157,"context_line":"        return group_specs"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def get_tenant_visible_group_specs():"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_a07964ca","line":157,"range":{"start_line":151,"start_character":0,"end_line":157,"end_character":26},"updated":"2017-01-21 06:12:26.000000000","message":"OK, but how about:\nreturn group_specs.get(key, False) if key else group_specs","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95a36d4def7067fd2f61c30355424a3336b1c626","unresolved":false,"context_lines":[{"line_number":148,"context_line":"def get_group_specs(share_group_type_id, key\u003dFalse):"},{"line_number":149,"context_line":"    share_group_type \u003d get(context.get_admin_context(), share_group_type_id)"},{"line_number":150,"context_line":"    group_specs \u003d share_group_type[\u0027group_specs\u0027]"},{"line_number":151,"context_line":"    if key:"},{"line_number":152,"context_line":"        if group_specs.get(key):"},{"line_number":153,"context_line":"            return group_specs.get(key)"},{"line_number":154,"context_line":"        else:"},{"line_number":155,"context_line":"            return False"},{"line_number":156,"context_line":"    else:"},{"line_number":157,"context_line":"        return group_specs"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def get_tenant_visible_group_specs():"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_8f6f072a","line":157,"range":{"start_line":151,"start_character":0,"end_line":157,"end_character":26},"in_reply_to":"5a3905b3_a07964ca","updated":"2017-01-23 13:07:01.000000000","message":"deleted as unused","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9a6532619e868b7f98dfbb89cd33f42846018df8","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        context, share_group_type_id, project_id)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"def share_group_types_diff(context, share_group_type_id1,"},{"line_number":187,"context_line":"                           share_group_type_id2):"},{"line_number":188,"context_line":"    \"\"\"Returns a \u0027diff\u0027 of two share group types and whether they are equal."},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_c00bd028","line":186,"range":{"start_line":186,"start_character":4,"end_line":186,"end_character":26},"updated":"2017-01-21 06:12:26.000000000","message":"for future use? speculative","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95a36d4def7067fd2f61c30355424a3336b1c626","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        context, share_group_type_id, project_id)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"def share_group_types_diff(context, share_group_type_id1,"},{"line_number":187,"context_line":"                           share_group_type_id2):"},{"line_number":188,"context_line":"    \"\"\"Returns a \u0027diff\u0027 of two share group types and whether they are equal."},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_4f97df39","line":186,"range":{"start_line":186,"start_character":4,"end_line":186,"end_character":26},"in_reply_to":"5a3905b3_c00bd028","updated":"2017-01-23 13:07:01.000000000","message":"deleted as unused","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9a6532619e868b7f98dfbb89cd33f42846018df8","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    if not equal:"},{"line_number":225,"context_line":"        all_equal \u003d False"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    return (diff, all_equal)"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_2301fe05","line":227,"updated":"2017-01-21 06:12:26.000000000","message":"parens are not needed (maybe you like them?)","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95a36d4def7067fd2f61c30355424a3336b1c626","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    if not equal:"},{"line_number":225,"context_line":"        all_equal \u003d False"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    return (diff, all_equal)"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a3905b3_af6cc335","line":227,"in_reply_to":"5a3905b3_2301fe05","updated":"2017-01-23 13:07:01.000000000","message":"deleted as unused","commit_id":"4aa74b59cdd605ff135c3343eac85ec5752399d8"}],"manila/tests/scheduler/drivers/test_filter.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"eb885982bd8bc6f6b18f46a49cc88b0287fd278c","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        fakes.mock_host_manager_db_calls(_mock_service_get_all_by_topic)"},{"line_number":450,"context_line":"        request_spec \u003d {\u0027share_types\u0027: [{\u0027name\u0027: \u0027NFS\u0027,"},{"line_number":451,"context_line":"                                         \u0027extra_specs\u0027: {"},{"line_number":452,"context_line":"                                             REPLICATION_TYPE_SPEC: \u0027readable\u0027"},{"line_number":453,"context_line":"                                         }}]}"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        hosts \u003d sched._get_weighted_candidates_share_group("}],"source_content_type":"text/x-python","patch_set":48,"id":"5a3905b3_3a715de1","line":452,"range":{"start_line":452,"start_character":45,"end_line":452,"end_character":78},"updated":"2017-01-20 03:51:35.000000000","message":"Why making this change?  Aren\u0027t we supposed to make sure SNAPSHOT_SUPPORT is \u0027True\u0027 here as this is a positive test?  Also the test name suggests there should be many hosts, but we only have 1 host in the results.","commit_id":"96ad3e60f58d44813394ff7a5e898b1a67a56580"}],"manila/tests/share/drivers/emc/test_driver.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f378875a7069d5a647132106c036404242a5eea0","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        data[\u0027qos\u0027] \u003d False"},{"line_number":125,"context_line":"        data[\u0027pools\u0027] \u003d None"},{"line_number":126,"context_line":"        data[\u0027snapshot_support\u0027] \u003d True"},{"line_number":127,"context_line":"        data[\u0027group_snapshot_support\u0027] \u003d True"},{"line_number":128,"context_line":"        data[\u0027replication_domain\u0027] \u003d None"},{"line_number":129,"context_line":"        data[\u0027filter_function\u0027] \u003d None"},{"line_number":130,"context_line":"        data[\u0027goodness_function\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_43a4d7b8","line":127,"range":{"start_line":127,"start_character":8,"end_line":127,"end_character":45},"updated":"2016-11-11 12:08:18.000000000","message":"Why it is added?","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"}],"manila/tests/share/drivers/glusterfs/test_glusterfs_native.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f378875a7069d5a647132106c036404242a5eea0","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            \u0027free_capacity_gb\u0027: \u0027unknown\u0027,"},{"line_number":257,"context_line":"            \u0027pools\u0027: None,"},{"line_number":258,"context_line":"            \u0027snapshot_support\u0027: True,"},{"line_number":259,"context_line":"            \u0027group_snapshot_support\u0027: True,"},{"line_number":260,"context_line":"            \u0027replication_domain\u0027: None,"},{"line_number":261,"context_line":"            \u0027filter_function\u0027: None,"},{"line_number":262,"context_line":"            \u0027goodness_function\u0027: None,"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_83aa6f83","line":259,"range":{"start_line":259,"start_character":12,"end_line":259,"end_character":43},"updated":"2016-11-11 12:08:18.000000000","message":"Why it is added?","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"}],"manila/tests/share/drivers/hpe/test_hpe_3par_driver.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f378875a7069d5a647132106c036404242a5eea0","unresolved":false,"context_lines":[{"line_number":733,"context_line":"            \u0027provisioned_capacity_gb\u0027: 0,"},{"line_number":734,"context_line":"            \u0027share_backend_name\u0027: \u0027HPE_3PAR\u0027,"},{"line_number":735,"context_line":"            \u0027snapshot_support\u0027: True,"},{"line_number":736,"context_line":"            \u0027group_snapshot_support\u0027: True,"},{"line_number":737,"context_line":"            \u0027storage_protocol\u0027: \u0027NFS_CIFS\u0027,"},{"line_number":738,"context_line":"            \u0027thin_provisioning\u0027: True,"},{"line_number":739,"context_line":"            \u0027total_capacity_gb\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_638e3b2f","line":736,"range":{"start_line":736,"start_character":12,"end_line":736,"end_character":43},"updated":"2016-11-11 12:08:18.000000000","message":"Why it is added?","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f378875a7069d5a647132106c036404242a5eea0","unresolved":false,"context_lines":[{"line_number":808,"context_line":"                \u0027reserved_percentage\u0027: 0,"},{"line_number":809,"context_line":"                \u0027provisioned_capacity_gb\u0027: expected_capacity}],"},{"line_number":810,"context_line":"            \u0027snapshot_support\u0027: True,"},{"line_number":811,"context_line":"            \u0027group_snapshot_support\u0027: True,"},{"line_number":812,"context_line":"            \u0027replication_domain\u0027: None,"},{"line_number":813,"context_line":"            \u0027filter_function\u0027: None,"},{"line_number":814,"context_line":"            \u0027goodness_function\u0027: None,"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_83818ffd","line":811,"range":{"start_line":811,"start_character":12,"end_line":811,"end_character":43},"updated":"2016-11-11 12:08:18.000000000","message":"Why it is added?","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"}],"manila/tests/share/drivers/huawei/test_huawei_nas.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f378875a7069d5a647132106c036404242a5eea0","unresolved":false,"context_lines":[{"line_number":2385,"context_line":"            \"free_capacity_gb\": 0.0,"},{"line_number":2386,"context_line":"            \"qos\": True,"},{"line_number":2387,"context_line":"            \"snapshot_support\": snapshot_support,"},{"line_number":2388,"context_line":"            \"group_snapshot_support\": True,"},{"line_number":2389,"context_line":"            \"replication_domain\": None,"},{"line_number":2390,"context_line":"            \"filter_function\": None,"},{"line_number":2391,"context_line":"            \"goodness_function\": None,"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_e3932b59","line":2388,"range":{"start_line":2388,"start_character":12,"end_line":2388,"end_character":43},"updated":"2016-11-11 12:08:18.000000000","message":"Why it is added?","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"}],"manila/tests/share/drivers/zfsonlinux/test_driver.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f378875a7069d5a647132106c036404242a5eea0","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":354,"context_line":"            \u0027share_backend_name\u0027: self.driver.backend_name,"},{"line_number":355,"context_line":"            \u0027snapshot_support\u0027: True,"},{"line_number":356,"context_line":"            \u0027group_snapshot_support\u0027: True,"},{"line_number":357,"context_line":"            \u0027storage_protocol\u0027: \u0027NFS\u0027,"},{"line_number":358,"context_line":"            \u0027total_capacity_gb\u0027: \u0027unknown\u0027,"},{"line_number":359,"context_line":"            \u0027vendor_name\u0027: \u0027Open Source\u0027,"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_c37f0713","line":356,"range":{"start_line":356,"start_character":12,"end_line":356,"end_character":43},"updated":"2016-11-11 12:08:18.000000000","message":"Why it is added?","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"}],"manila/tests/share_group/test_api.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d524380bb7cbfd914095a8bd3afca1ad5818d665","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        expected_values[\u0027share_network_id\u0027] \u003d \u0027fake_network_id\u0027"},{"line_number":315,"context_line":"        expected_values[\u0027share_server_id\u0027] \u003d \u0027fake_server_id\u0027"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        self.mock_object(db_driver, \u0027group_snapshot_get\u0027,"},{"line_number":318,"context_line":"                         mock.Mock(return_value\u003dsnap))"},{"line_number":319,"context_line":"        self.mock_object(db_driver, \u0027share_group_get\u0027,"},{"line_number":320,"context_line":"                         mock.Mock(return_value\u003dorig_group))"},{"line_number":321,"context_line":"        self.mock_object(db_driver, \u0027share_group_create\u0027,"},{"line_number":322,"context_line":"                         mock.Mock(return_value\u003dgroup))"},{"line_number":323,"context_line":"        self.mock_object(db_driver, \u0027share_get\u0027,"},{"line_number":324,"context_line":"                         mock.Mock(return_value\u003dstubs.stub_share("},{"line_number":325,"context_line":"                             \u0027fake_share\u0027)))"},{"line_number":326,"context_line":"        self.mock_object(share_types, \u0027get_share_type\u0027,"},{"line_number":327,"context_line":"                         mock.Mock(return_value\u003d{"},{"line_number":328,"context_line":"                             \"id\": self.fake_share_type[\u0027id\u0027]}))"},{"line_number":329,"context_line":"        self.mock_object(db_driver, \u0027share_network_get\u0027)"},{"line_number":330,"context_line":"        self.mock_object(db_driver, \u0027group_snapshot_members_get_all\u0027,"},{"line_number":331,"context_line":"                         mock.Mock(return_value\u003d[]))"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        self.api.create(self.context,"},{"line_number":334,"context_line":"                        source_group_snapshot_id\u003dsnap[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_4350570b","line":331,"range":{"start_line":317,"start_character":8,"end_line":331,"end_character":52},"updated":"2016-11-11 11:41:32.000000000","message":"Such big amount of mocks and not covered with assertions.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d524380bb7cbfd914095a8bd3afca1ad5818d665","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        expected_values[\u0027share_network_id\u0027] \u003d \u0027fake_network_id\u0027"},{"line_number":369,"context_line":"        expected_values[\u0027share_server_id\u0027] \u003d \u0027fake_server_id\u0027"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        self.mock_object(db_driver, \u0027group_snapshot_get\u0027,"},{"line_number":372,"context_line":"                         mock.Mock(return_value\u003dsnap))"},{"line_number":373,"context_line":"        self.mock_object(db_driver, \u0027share_group_get\u0027,"},{"line_number":374,"context_line":"                         mock.Mock(return_value\u003dorig_group))"},{"line_number":375,"context_line":"        self.mock_object(db_driver, \u0027share_group_create\u0027,"},{"line_number":376,"context_line":"                         mock.Mock(return_value\u003dgroup))"},{"line_number":377,"context_line":"        self.mock_object(db_driver, \u0027share_get\u0027,"},{"line_number":378,"context_line":"                         mock.Mock(return_value\u003dstubs.stub_share(\u0027fakeshare\u0027)))"},{"line_number":379,"context_line":"        self.mock_object(share_types, \u0027get_share_type\u0027,"},{"line_number":380,"context_line":"                         mock.Mock(return_value\u003d{"},{"line_number":381,"context_line":"                             \"id\": self.fake_share_type[\u0027id\u0027]}))"},{"line_number":382,"context_line":"        self.mock_object(db_driver, \u0027share_network_get\u0027)"},{"line_number":383,"context_line":"        self.mock_object(db_driver, \u0027share_instance_get\u0027,"},{"line_number":384,"context_line":"                         mock.Mock(return_value\u003dshare))"},{"line_number":385,"context_line":"        self.mock_object(db_driver, \u0027group_snapshot_members_get_all\u0027,"},{"line_number":386,"context_line":"                         mock.Mock(return_value\u003d[member]))"},{"line_number":387,"context_line":"        self.mock_object(self.share_api, \u0027create\u0027)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        self.api.create(self.context,"},{"line_number":390,"context_line":"                        source_group_snapshot_id\u003dsnap[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_232fe388","line":387,"range":{"start_line":371,"start_character":8,"end_line":387,"end_character":50},"updated":"2016-11-11 11:41:32.000000000","message":"Such big amount of mocks and not covered with assertions.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d524380bb7cbfd914095a8bd3afca1ad5818d665","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        expected_values[\u0027share_network_id\u0027] \u003d \u0027fake_network_id\u0027"},{"line_number":427,"context_line":"        expected_values[\u0027share_server_id\u0027] \u003d \u0027fake_server_id\u0027"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        self.mock_object(db_driver, \u0027group_snapshot_get\u0027,"},{"line_number":430,"context_line":"                         mock.Mock(return_value\u003dsnap))"},{"line_number":431,"context_line":"        self.mock_object(db_driver, \u0027share_group_get\u0027,"},{"line_number":432,"context_line":"                         mock.Mock(return_value\u003dorig_group))"},{"line_number":433,"context_line":"        self.mock_object(db_driver, \u0027share_network_get\u0027)"},{"line_number":434,"context_line":"        self.mock_object(db_driver, \u0027share_instance_get\u0027,"},{"line_number":435,"context_line":"                         mock.Mock(return_value\u003dshare))"},{"line_number":436,"context_line":"        self.mock_object(db_driver, \u0027share_group_create\u0027,"},{"line_number":437,"context_line":"                         mock.Mock(return_value\u003dgroup))"},{"line_number":438,"context_line":"        self.mock_object(db_driver, \u0027share_get\u0027,"},{"line_number":439,"context_line":"                         mock.Mock(return_value\u003dstubs.stub_share(\u0027fakeshare\u0027)))"},{"line_number":440,"context_line":"        self.mock_object(share_types, \u0027get_share_type\u0027,"},{"line_number":441,"context_line":"                         mock.Mock(return_value\u003d{"},{"line_number":442,"context_line":"                             \"id\": self.fake_share_type[\u0027id\u0027]}))"},{"line_number":443,"context_line":"        self.mock_object(db_driver, \u0027group_snapshot_members_get_all\u0027,"},{"line_number":444,"context_line":"                         mock.Mock(return_value\u003d[member, member_2]))"},{"line_number":445,"context_line":"        self.mock_object(self.share_api, \u0027create\u0027,"},{"line_number":446,"context_line":"                         mock.Mock(side_effect\u003d[None, exception.Error]))"},{"line_number":447,"context_line":"        self.mock_object(db_driver, \u0027share_group_destroy\u0027)"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        self.assertRaises(exception.Error, self.api.create, self.context,"},{"line_number":450,"context_line":"                          source_group_snapshot_id\u003dsnap[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_e3388bd5","line":447,"range":{"start_line":429,"start_character":8,"end_line":447,"end_character":58},"updated":"2016-11-11 11:41:32.000000000","message":"Such big amount of mocks and not covered with assertions.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d524380bb7cbfd914095a8bd3afca1ad5818d665","unresolved":false,"context_lines":[{"line_number":614,"context_line":"        self.assertRaises(exception.InvalidShareGroup, self.api.delete,"},{"line_number":615,"context_line":"                          self.context, group)"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    def test_update_no_values(self):"},{"line_number":618,"context_line":"        group \u003d fake_group(\u0027fakeid\u0027,"},{"line_number":619,"context_line":"                           user_id\u003dself.context.user_id,"},{"line_number":620,"context_line":"                           project_id\u003dself.context.project_id,"},{"line_number":621,"context_line":"                           status\u003dconstants.STATUS_CREATING)"},{"line_number":622,"context_line":"        expected_values \u003d {}"},{"line_number":623,"context_line":"        self.mock_object(db_driver, \u0027share_group_update\u0027,"},{"line_number":624,"context_line":"                         mock.Mock(return_value\u003dgroup))"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"        self.api.update(self.context, group, expected_values)"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"        db_driver.share_group_update.assert_called_once_with("},{"line_number":629,"context_line":"            self.context, group[\u0027id\u0027], expected_values)"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def test_update_with_name(self):"},{"line_number":632,"context_line":"        fake_name \u003d \u0027fake_name\u0027"},{"line_number":633,"context_line":"        group \u003d fake_group(\u0027fakeid\u0027,"},{"line_number":634,"context_line":"                           user_id\u003dself.context.user_id,"},{"line_number":635,"context_line":"                           project_id\u003dself.context.project_id,"},{"line_number":636,"context_line":"                           status\u003dconstants.STATUS_CREATING)"},{"line_number":637,"context_line":"        expected_values \u003d {\u0027description\u0027: fake_name}"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        self.mock_object(db_driver, \u0027share_group_update\u0027,"},{"line_number":640,"context_line":"                         mock.Mock(return_value\u003dgroup))"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        self.api.update(self.context, group, expected_values)"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"        db_driver.share_group_update.assert_called_once_with("},{"line_number":645,"context_line":"            self.context, group[\u0027id\u0027], expected_values)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"    def test_update_with_description(self):"},{"line_number":648,"context_line":"        fake_desc \u003d \u0027fake_desc\u0027"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_031d7f65","line":645,"range":{"start_line":617,"start_character":4,"end_line":645,"end_character":55},"updated":"2016-11-11 11:41:32.000000000","message":"These should be combined with the Force of ddt.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d524380bb7cbfd914095a8bd3afca1ad5818d665","unresolved":false,"context_lines":[{"line_number":1072,"context_line":"        self.share_rpcapi.delete_group_snapshot.assert_called_once_with("},{"line_number":1073,"context_line":"            self.context, snap, group[\u0027host\u0027])"},{"line_number":1074,"context_line":""},{"line_number":1075,"context_line":"    def test_delete_group_snapshot_group_does_not_exist(self):"},{"line_number":1076,"context_line":"        snap \u003d fake_group_snapshot(\u0027fake_groupsnap_id\u0027,"},{"line_number":1077,"context_line":"                                   share_group_id\u003d\u0027fake_id\u0027)"},{"line_number":1078,"context_line":"        self.mock_object(db_driver, \u0027share_group_get\u0027,"},{"line_number":1079,"context_line":"                         mock.Mock("},{"line_number":1080,"context_line":"                             side_effect\u003dexception.ShareGroupNotFound("},{"line_number":1081,"context_line":"                                 share_group_id\u003d\u0027fake_id\u0027"},{"line_number":1082,"context_line":"                             )))"},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"        self.assertRaises(exception.ShareGroupNotFound,"},{"line_number":1085,"context_line":"                          self.api.delete_group_snapshot,"},{"line_number":1086,"context_line":"                          self.context,"},{"line_number":1087,"context_line":"                          snap)"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"        db_driver.share_group_get.assert_called_once_with("},{"line_number":1090,"context_line":"            self.context, \"fake_id\""},{"line_number":1091,"context_line":"        )"},{"line_number":1092,"context_line":""},{"line_number":1093,"context_line":"    def test_delete_group_snapshot_creating_status(self):"},{"line_number":1094,"context_line":"        snap \u003d fake_group_snapshot(\u0027fake_groupsnap_id\u0027,"},{"line_number":1095,"context_line":"                                   share_group_id\u003d\u0027fake_id\u0027,"},{"line_number":1096,"context_line":"                                   status\u003dconstants.STATUS_CREATING)"},{"line_number":1097,"context_line":"        self.mock_object(db_driver, \u0027share_group_get\u0027)"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"        self.assertRaises(exception.InvalidGroupSnapshot,"},{"line_number":1100,"context_line":"                          self.api.delete_group_snapshot,"},{"line_number":1101,"context_line":"                          self.context,"},{"line_number":1102,"context_line":"                          snap)"},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"        db_driver.share_group_get.assert_called_once_with("},{"line_number":1105,"context_line":"            self.context, \"fake_id\""},{"line_number":1106,"context_line":"        )"},{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"    def test_update_group_snapshot_no_values(self):"},{"line_number":1109,"context_line":"        snap \u003d fake_group_snapshot(\u0027fakeid\u0027,"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_0006551f","line":1106,"range":{"start_line":1075,"start_character":4,"end_line":1106,"end_character":9},"updated":"2016-11-11 11:41:32.000000000","message":"These should be combined with the Force of ddt.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d524380bb7cbfd914095a8bd3afca1ad5818d665","unresolved":false,"context_lines":[{"line_number":1105,"context_line":"            self.context, \"fake_id\""},{"line_number":1106,"context_line":"        )"},{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"    def test_update_group_snapshot_no_values(self):"},{"line_number":1109,"context_line":"        snap \u003d fake_group_snapshot(\u0027fakeid\u0027,"},{"line_number":1110,"context_line":"                                   user_id\u003dself.context.user_id,"},{"line_number":1111,"context_line":"                                   project_id\u003dself.context.project_id,"},{"line_number":1112,"context_line":"                                   status\u003dconstants.STATUS_CREATING)"},{"line_number":1113,"context_line":"        expected_values \u003d {}"},{"line_number":1114,"context_line":"        self.mock_object(db_driver, \u0027group_snapshot_update\u0027,"},{"line_number":1115,"context_line":"                         mock.Mock(return_value\u003dsnap))"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"        self.api.update_group_snapshot(self.context, snap, expected_values)"},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"        db_driver.group_snapshot_update.assert_called_once_with("},{"line_number":1120,"context_line":"            self.context, snap[\u0027id\u0027], expected_values)"},{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"    def test_update_group_snapshot_with_name(self):"},{"line_number":1123,"context_line":"        fake_name \u003d \u0027fake_name\u0027"},{"line_number":1124,"context_line":"        snap \u003d fake_group_snapshot(\u0027fakeid\u0027,"},{"line_number":1125,"context_line":"                                   user_id\u003dself.context.user_id,"},{"line_number":1126,"context_line":"                                   project_id\u003dself.context.project_id,"},{"line_number":1127,"context_line":"                                   status\u003dconstants.STATUS_CREATING)"},{"line_number":1128,"context_line":"        expected_values \u003d {\u0027description\u0027: fake_name}"},{"line_number":1129,"context_line":""},{"line_number":1130,"context_line":"        self.mock_object(db_driver, \u0027group_snapshot_update\u0027,"},{"line_number":1131,"context_line":"                         mock.Mock(return_value\u003dsnap))"},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"        self.api.update_group_snapshot(self.context, snap, expected_values)"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"        db_driver.group_snapshot_update.assert_called_once_with("},{"line_number":1136,"context_line":"            self.context, snap[\u0027id\u0027], expected_values)"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"    def test_group_snapshot_get(self):"},{"line_number":1139,"context_line":"        expected_snap \u003d fake_group_snapshot("}],"source_content_type":"text/x-python","patch_set":27,"id":"9a629dbe_002f35a1","line":1136,"range":{"start_line":1108,"start_character":4,"end_line":1136,"end_character":54},"updated":"2016-11-11 11:41:32.000000000","message":"These should be combined with the Force of ddt.","commit_id":"f91f7626ea5ef81f2e3d0252089a8618866bbfcd"}]}
