)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5dde389bdb2a9984d222428967129f3a94e92dd7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"copy used during create-share-from-snapshot out"},{"line_number":11,"context_line":"of the 3PAR driver and into the data service."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements blueprint bp/hp3par-share-server-support"},{"line_number":14,"context_line":"Change-Id: Ie8399f8bc7b4a1e8715be4d771f1059cf6a62c8d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_592fd5f5","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":51},"updated":"2016-08-29 08:09:03.000000000","message":"https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\nPlease use following format, otherwise it can not be linked to your bp web page.\nImplements: blueprint hp3par-share-server-support","commit_id":"6807ff36cecd8a80782fbf435c5f5523c1c0abe4"}],"manila/share/drivers/hpe/hpe_3par_driver.py":[{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"8387a9306c4d8d73040d0c339cc649c1c9548198","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        if [x for x in locations if x[\u0027path\u0027] \u003d\u003d location]:"},{"line_number":404,"context_line":"            return"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        if locations:"},{"line_number":407,"context_line":"            update_locations \u003d [x.to_dict() for x in locations]"},{"line_number":408,"context_line":"        else:"},{"line_number":409,"context_line":"            update_locations \u003d []"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        update_locations.append({\u0027path\u0027: location,"},{"line_number":412,"context_line":"                                 \u0027metadata\u0027: {},"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_9889f671","line":409,"range":{"start_line":406,"start_character":8,"end_line":409,"end_character":33},"updated":"2016-07-01 07:03:08.000000000","message":"I think you can omit the if else here. If \u0027locations\u0027 is empty, \u0027[x.to_dict() for x in locations]\u0027 will result in an empty list.","commit_id":"0604c7575344fa14b0ed4b397a85ba5172bfe593"}],"manila/share/drivers/hpe/hpe_3par_mediator.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8c1d500ae7389d186d0bea2e9ad70b2b03be1056","unresolved":false,"context_lines":[{"line_number":717,"context_line":"                dest_location \u003d self.build_export_location("},{"line_number":718,"context_line":"                    protocol, ip, dest_path)"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"                data_service_helper \u003d drivers_data_helper.DriversDataHelper()"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"                data_service_helper.copy_share_data("},{"line_number":723,"context_line":"                    context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_96e93583","line":720,"range":{"start_line":720,"start_character":15,"end_line":720,"end_character":77},"updated":"2016-08-28 18:19:51.000000000","message":"you should get it from kwargs just like the driver private storage.","commit_id":"6807ff36cecd8a80782fbf435c5f5523c1c0abe4"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5dde389bdb2a9984d222428967129f3a94e92dd7","unresolved":false,"context_lines":[{"line_number":726,"context_line":"                    share_id,"},{"line_number":727,"context_line":"                    \u0027\u0027,"},{"line_number":728,"context_line":"                    src_export_location\u003dsource_location,"},{"line_number":729,"context_line":"                    dest_export_location\u003ddest_location)"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"                # Revoke the admin access that was needed to copy to the dest."},{"line_number":732,"context_line":"                if protocol \u003d\u003d \u0027nfs\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_ce64f6e6","line":729,"range":{"start_line":729,"start_character":55,"end_line":729,"end_character":55},"updated":"2016-08-29 08:09:03.000000000","message":"Does you need to use data_copy_get_progress check whether the data copy is finished?","commit_id":"6807ff36cecd8a80782fbf435c5f5523c1c0abe4"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"5ba9cd3ff537f79335bed07adbf9b9279b6bf485","unresolved":false,"context_lines":[{"line_number":756,"context_line":""},{"line_number":757,"context_line":"        return dest_path"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"    def _copy_share_data(self, dest_id, source_location, dest_location,"},{"line_number":760,"context_line":"                         protocol):"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"        mount_location \u003d \"%s%s\" % (self.hpe3par_share_mount_path, dest_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_44c8d022","line":759,"range":{"start_line":759,"start_character":8,"end_line":759,"end_character":24},"updated":"2016-08-29 03:37:20.000000000","message":"if this method is not used anymore, remove?","commit_id":"6807ff36cecd8a80782fbf435c5f5523c1c0abe4"}],"manila/tests/share/drivers/hpe/test_hpe_3par_mediator.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"5ba9cd3ff537f79335bed07adbf9b9279b6bf485","unresolved":false,"context_lines":[{"line_number":725,"context_line":"        }"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"        mock_bad_copy \u003d mock.Mock()"},{"line_number":728,"context_line":"        copy_fail \u003d exception.ShareDataCopyFailed(\u0027copy fail\u0027)"},{"line_number":729,"context_line":"        mock_bad_copy.copy_share_data.side_effect \u003d copy_fail"},{"line_number":730,"context_line":"        self.mock_object("},{"line_number":731,"context_line":"            drivers_data_helper, \u0027DriversDataHelper\u0027, mock.Mock("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_4490d043","line":728,"range":{"start_line":728,"start_character":50,"end_line":728,"end_character":51},"updated":"2016-08-29 03:37:20.000000000","message":"reason\u003d\u0027copy fail\u0027","commit_id":"6807ff36cecd8a80782fbf435c5f5523c1c0abe4"}]}
