)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"44bd0838f235f10c60fb13bcc794826180a30f19","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add DriverFilter and GoodnessWeigher to manila"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch ports cinder\u0027s DriverFilter and GoodnessWeigher to manila."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I873f4152e16efdeb30ceae26335a7974dc9b4b69"},{"line_number":12,"context_line":"Implements: blueprint driver-filter"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1aa78d24_b4bd6fd9","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":69},"updated":"2016-07-05 10:52:09.000000000","message":"Doing such things a \"ports\" need to provide some useful links. In your case it is [1] and [2].\n\nAlso, brief description of feature in commit message as it is done in [1] would be useful. Do not make people search for such things separately.\n\n[1] https://review.openstack.org/#/c/129987 (I38408ab49b6ed869c1faae746ee64a3bae86be58) - implementation in Cinder\n\n[2] https://review.openstack.org/#/c/129330 (I59b607a88953a346aa35e67e785a0417a7ce8cc9) - spec for Cinder","commit_id":"cbc08b975423f5718b4c9dec4345e6e8a6b835e6"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"db2e63e386a3c1b18037727af5a3b6ec2c6859da","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add DriverFilter and GoodnessWeigher to manila"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch ports cinder\u0027s DriverFilter and GoodnessWeigher to manila."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I873f4152e16efdeb30ceae26335a7974dc9b4b69"},{"line_number":12,"context_line":"Implements: blueprint driver-filter"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1aa78d24_2e78f18e","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":69},"in_reply_to":"1aa78d24_b4bd6fd9","updated":"2016-07-05 19:13:37.000000000","message":"Done","commit_id":"cbc08b975423f5718b4c9dec4345e6e8a6b835e6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fdc59ee162f5dcc578d0da5ff1759a2bb1b8b32b","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Reference for cinder spec: I59b607a88953a346aa35e67e785a0417a7ce8cc9"},{"line_number":15,"context_line":"Reference for cinder commit: I38408ab49b6ed869c1faae746ee64a3bae86be58"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I873f4152e16efdeb30ceae26335a7974dc9b4b69"},{"line_number":18,"context_line":"Implements: blueprint driver-filter"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1aa78d24_d86f97c2","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":0},"updated":"2016-07-15 03:37:01.000000000","message":"DocImpact please","commit_id":"fc673d4dd62903a752a0d022ee0333a4682b5d46"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"298d05e2beb015f1120e4dd0609bd10599790fcc","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Reference for cinder spec: I59b607a88953a346aa35e67e785a0417a7ce8cc9"},{"line_number":15,"context_line":"Reference for cinder commit: I38408ab49b6ed869c1faae746ee64a3bae86be58"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I873f4152e16efdeb30ceae26335a7974dc9b4b69"},{"line_number":18,"context_line":"Implements: blueprint driver-filter"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"dada55a8_878679b7","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":0},"in_reply_to":"1aa78d24_d86f97c2","updated":"2016-07-18 18:36:55.000000000","message":"Done","commit_id":"fc673d4dd62903a752a0d022ee0333a4682b5d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fdc59ee162f5dcc578d0da5ff1759a2bb1b8b32b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Reference for cinder commit: I38408ab49b6ed869c1faae746ee64a3bae86be58"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I873f4152e16efdeb30ceae26335a7974dc9b4b69"},{"line_number":18,"context_line":"Implements: blueprint driver-filter"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1aa78d24_b88d6b2c","line":18,"range":{"start_line":18,"start_character":22,"end_line":18,"end_character":35},"updated":"2016-07-15 03:37:01.000000000","message":"please rename the LP blueprint to include the goodness weigher and provide more detail regarding how and why these filter and weigher are useful?","commit_id":"fc673d4dd62903a752a0d022ee0333a4682b5d46"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"298d05e2beb015f1120e4dd0609bd10599790fcc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Reference for cinder commit: I38408ab49b6ed869c1faae746ee64a3bae86be58"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I873f4152e16efdeb30ceae26335a7974dc9b4b69"},{"line_number":18,"context_line":"Implements: blueprint driver-filter"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"dada55a8_e793f5f8","line":18,"range":{"start_line":18,"start_character":22,"end_line":18,"end_character":35},"in_reply_to":"1aa78d24_b88d6b2c","updated":"2016-07-18 18:36:55.000000000","message":"Done","commit_id":"fc673d4dd62903a752a0d022ee0333a4682b5d46"}],"manila/scheduler/evaluator/evaluator.py":[{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"65f423279a10b9f66c1fca7d93f4e9623a6eb6b5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def eval(self):"},{"line_number":42,"context_line":"        result \u003d self.value"},{"line_number":43,"context_line":"        if (isinstance(result, six.string_types) and"},{"line_number":44,"context_line":"                re.match(\"^[a-zA-Z_]+\\.[a-zA-Z_]+$\", result)):"},{"line_number":45,"context_line":"            (which_dict, entry) \u003d result.split(\u0027.\u0027)"},{"line_number":46,"context_line":"            try:"},{"line_number":47,"context_line":"                result \u003d _vars[which_dict][entry]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_58794e2e","line":44,"range":{"start_line":44,"start_character":25,"end_line":44,"end_character":51},"updated":"2016-07-01 07:40:06.000000000","message":"If you change this regex to \"^([a-zA-Z_]+)\\.([a-zA-Z_]+)$\" and you save the result of this match, you could directly access the captured groups instead of doing a result.split(\u0027.\u0027) to get which_dict and entry.","commit_id":"571704c6c115546ea57ddd7ddfb56c9af4baa7c1"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"2fc24fc310da130ea399252f3c9feb297ba843b4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def eval(self):"},{"line_number":42,"context_line":"        result \u003d self.value"},{"line_number":43,"context_line":"        if (isinstance(result, six.string_types) and"},{"line_number":44,"context_line":"                re.match(\"^[a-zA-Z_]+\\.[a-zA-Z_]+$\", result)):"},{"line_number":45,"context_line":"            (which_dict, entry) \u003d result.split(\u0027.\u0027)"},{"line_number":46,"context_line":"            try:"},{"line_number":47,"context_line":"                result \u003d _vars[which_dict][entry]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_b44e6f93","line":44,"range":{"start_line":44,"start_character":25,"end_line":44,"end_character":51},"in_reply_to":"3aaa91ec_58794e2e","updated":"2016-07-01 11:10:32.000000000","message":"I didn\u0027t want to mess with this file to keep it consistent with cinder\u0027s implementation, but that looks right. I\u0027ll check that. Thank you!","commit_id":"571704c6c115546ea57ddd7ddfb56c9af4baa7c1"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"e2f378e8115c505605c2276c8e8320d52a80d4df","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def eval(self):"},{"line_number":42,"context_line":"        result \u003d self.value"},{"line_number":43,"context_line":"        if (isinstance(result, six.string_types) and"},{"line_number":44,"context_line":"                re.match(\"^[a-zA-Z_]+\\.[a-zA-Z_]+$\", result)):"},{"line_number":45,"context_line":"            (which_dict, entry) \u003d result.split(\u0027.\u0027)"},{"line_number":46,"context_line":"            try:"},{"line_number":47,"context_line":"                result \u003d _vars[which_dict][entry]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_c7deef0f","line":44,"range":{"start_line":44,"start_character":25,"end_line":44,"end_character":51},"in_reply_to":"3aaa91ec_b44e6f93","updated":"2016-07-01 11:26:09.000000000","message":"Ah ok, I guess it is a good idea to stay consistent with the cinder implementation.\n\nAs this is just a minor nit I would just keep it like it is.","commit_id":"571704c6c115546ea57ddd7ddfb56c9af4baa7c1"}],"manila/scheduler/filters/driver.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e0cc589c2c390694340d42ce14c431d9754bb847","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            \u0027driver_handles_share_servers\u0027:"},{"line_number":118,"context_line":"                host_state.driver_handles_share_servers,"},{"line_number":119,"context_line":"            \u0027thin_provisioning\u0027: host_state.thin_provisioning,"},{"line_number":120,"context_line":"            \u0027updated\u0027: host_state.updated,"},{"line_number":121,"context_line":"        }"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        host_caps \u003d host_state.capabilities"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_1f4dbc72","line":120,"range":{"start_line":120,"start_character":41,"end_line":120,"end_character":42},"updated":"2016-07-04 03:03:45.000000000","message":"You could add  \u0027dedupe\u0027, \u0027compression\u0027, \u0027allocated_capacity_gb\u0027,  \u0027snapshot_support\u0027, \u0027consistency_group_support\u0027 and etc in this dict. please check it again, thanks.","commit_id":"6b1e08340fc8faa6105f833cfdb1589e57e03c23"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e0cc589c2c390694340d42ce14c431d9754bb847","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                host_caps[\u0027filter_function\u0027] is not None):"},{"line_number":129,"context_line":"            filter_function \u003d six.text_type(host_caps[\u0027filter_function\u0027])"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        qos_specs \u003d filter_properties.get(\u0027qos_specs\u0027, {})"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        share_type \u003d filter_properties.get(\u0027share_type\u0027, {})"},{"line_number":134,"context_line":"        extra_specs \u003d share_type.get(\u0027extra_specs\u0027, {})"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_5c447273","line":131,"range":{"start_line":131,"start_character":8,"end_line":131,"end_character":58},"updated":"2016-07-04 03:03:45.000000000","message":"In manila, the \u0027qos_specs\u0027 is not exist in filter_properties. The qos attribute is exist in share_type\u0027s extra_specs.","commit_id":"6b1e08340fc8faa6105f833cfdb1589e57e03c23"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f491f3943d4b5ae260c566c5840e4cc0f0ff766f","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        return result"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def _generate_stats(self, host_state, filter_properties):"},{"line_number":102,"context_line":"        \"\"\"Generates statistics from host and share data.\"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        host_stats \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_4fa64811","line":101,"updated":"2016-07-05 02:26:38.000000000","message":"Most of the code is similar with the function _generate_stats() in goodness.py. How about make it as common to avoid the duplicate code?","commit_id":"cbc08b975423f5718b4c9dec4345e6e8a6b835e6"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"db2e63e386a3c1b18037727af5a3b6ec2c6859da","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        return result"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def _generate_stats(self, host_state, filter_properties):"},{"line_number":102,"context_line":"        \"\"\"Generates statistics from host and share data.\"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        host_stats \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_ae64e1e4","line":101,"in_reply_to":"1aa78d24_4fa64811","updated":"2016-07-05 19:13:37.000000000","message":"Done. Moved the duplicated chunk of the code to a new scheduler/utils module.","commit_id":"cbc08b975423f5718b4c9dec4345e6e8a6b835e6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"871e6f3ce2daee8cf42925807a860cd59e2a1c63","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        elif (extra_specs[\u0027share_backend_name\u0027] !\u003d"},{"line_number":61,"context_line":"                host_stats[\u0027share_backend_name\u0027]):"},{"line_number":62,"context_line":"            LOG.warning(_LW(\"Share backend names do not match: \u0027%(target)s\u0027 \""},{"line_number":63,"context_line":"                            \"vs \u0027%(current)s\u0027 :: Skipping\"),"},{"line_number":64,"context_line":"                        {\u0027target\u0027: extra_specs[\u0027share_backend_name\u0027],"},{"line_number":65,"context_line":"                         \u0027current\u0027: host_stats[\u0027share_backend_name\u0027]})"},{"line_number":66,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_1b4eec3a","line":63,"range":{"start_line":63,"start_character":56,"end_line":63,"end_character":57},"updated":"2016-07-06 12:35:25.000000000","message":"period","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"61fd7da9f07a821362a38ace175bc6f8d4ecb1ba","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        elif (extra_specs[\u0027share_backend_name\u0027] !\u003d"},{"line_number":61,"context_line":"                host_stats[\u0027share_backend_name\u0027]):"},{"line_number":62,"context_line":"            LOG.warning(_LW(\"Share backend names do not match: \u0027%(target)s\u0027 \""},{"line_number":63,"context_line":"                            \"vs \u0027%(current)s\u0027 :: Skipping\"),"},{"line_number":64,"context_line":"                        {\u0027target\u0027: extra_specs[\u0027share_backend_name\u0027],"},{"line_number":65,"context_line":"                         \u0027current\u0027: host_stats[\u0027share_backend_name\u0027]})"},{"line_number":66,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_688be3c3","line":63,"range":{"start_line":63,"start_character":56,"end_line":63,"end_character":57},"in_reply_to":"1aa78d24_1b4eec3a","updated":"2016-07-06 13:40:37.000000000","message":"Done","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"871e6f3ce2daee8cf42925807a860cd59e2a1c63","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            return False"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if stats[\u0027filter_function\u0027] is None:"},{"line_number":69,"context_line":"            LOG.warning(_LW(\"Filter function not set :: passing host\"))"},{"line_number":70,"context_line":"            return True"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_bb5b58f5","line":69,"range":{"start_line":69,"start_character":67,"end_line":69,"end_character":69},"updated":"2016-07-06 12:35:25.000000000","message":"period","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"61fd7da9f07a821362a38ace175bc6f8d4ecb1ba","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            return False"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if stats[\u0027filter_function\u0027] is None:"},{"line_number":69,"context_line":"            LOG.warning(_LW(\"Filter function not set :: passing host\"))"},{"line_number":70,"context_line":"            return True"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_a8914bf3","line":69,"range":{"start_line":69,"start_character":67,"end_line":69,"end_character":69},"in_reply_to":"1aa78d24_bb5b58f5","updated":"2016-07-06 13:40:37.000000000","message":"Done","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"871e6f3ce2daee8cf42925807a860cd59e2a1c63","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            # Warn the admin for now that there is an error in the"},{"line_number":77,"context_line":"            # filter function."},{"line_number":78,"context_line":"            LOG.warning(_LW(\"Error in filtering function \""},{"line_number":79,"context_line":"                            \"\u0027%(function)s\u0027 : \u0027%(error)s\u0027 :: failing host\"),"},{"line_number":80,"context_line":"                        {\u0027function\u0027: stats[\u0027filter_function\u0027],"},{"line_number":81,"context_line":"                         \u0027error\u0027: ex, })"},{"line_number":82,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_7b6570b3","line":79,"range":{"start_line":79,"start_character":72,"end_line":79,"end_character":73},"updated":"2016-07-06 12:35:25.000000000","message":"period","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"61fd7da9f07a821362a38ace175bc6f8d4ecb1ba","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            # Warn the admin for now that there is an error in the"},{"line_number":77,"context_line":"            # filter function."},{"line_number":78,"context_line":"            LOG.warning(_LW(\"Error in filtering function \""},{"line_number":79,"context_line":"                            \"\u0027%(function)s\u0027 : \u0027%(error)s\u0027 :: failing host\"),"},{"line_number":80,"context_line":"                        {\u0027function\u0027: stats[\u0027filter_function\u0027],"},{"line_number":81,"context_line":"                         \u0027error\u0027: ex, })"},{"line_number":82,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_888e0fce","line":79,"range":{"start_line":79,"start_character":72,"end_line":79,"end_character":73},"in_reply_to":"1aa78d24_7b6570b3","updated":"2016-07-06 13:40:37.000000000","message":"Done","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fdc59ee162f5dcc578d0da5ff1759a2bb1b8b32b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        \"\"\"Determines whether a host has a passing filter_function or not.\"\"\""},{"line_number":38,"context_line":"        stats \u003d self._generate_stats(host_state, filter_properties)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        LOG.debug(\"Checking host \u0027%s\u0027\", stats[\u0027host_stats\u0027][\u0027host\u0027])"},{"line_number":41,"context_line":"        result \u003d self._check_filter_function(stats)"},{"line_number":42,"context_line":"        LOG.debug(\"Result: %s\", result)"},{"line_number":43,"context_line":"        LOG.debug(\"Done checking host \u0027%s\u0027\", stats[\u0027host_stats\u0027][\u0027host\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_989cefc0","line":40,"range":{"start_line":40,"start_character":7,"end_line":40,"end_character":68},"updated":"2016-07-15 03:37:01.000000000","message":"It would be nice to log which filter caused this debug statement. \n\nLOG.debug(\"Driver Filter: Checking host ...","commit_id":"fc673d4dd62903a752a0d022ee0333a4682b5d46"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"298d05e2beb015f1120e4dd0609bd10599790fcc","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        \"\"\"Determines whether a host has a passing filter_function or not.\"\"\""},{"line_number":38,"context_line":"        stats \u003d self._generate_stats(host_state, filter_properties)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        LOG.debug(\"Checking host \u0027%s\u0027\", stats[\u0027host_stats\u0027][\u0027host\u0027])"},{"line_number":41,"context_line":"        result \u003d self._check_filter_function(stats)"},{"line_number":42,"context_line":"        LOG.debug(\"Result: %s\", result)"},{"line_number":43,"context_line":"        LOG.debug(\"Done checking host \u0027%s\u0027\", stats[\u0027host_stats\u0027][\u0027host\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_67b6e58b","line":40,"range":{"start_line":40,"start_character":7,"end_line":40,"end_character":68},"in_reply_to":"1aa78d24_989cefc0","updated":"2016-07-18 18:36:55.000000000","message":"Done","commit_id":"fc673d4dd62903a752a0d022ee0333a4682b5d46"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"07535493db022dbf661cf0b7651c1797795b33ad","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        if extra_specs is None or \u0027share_backend_name\u0027 not in extra_specs:"},{"line_number":58,"context_line":"            LOG.warning(_LW(\"No \u0027share_backend_name\u0027 key in extra_specs. \""},{"line_number":59,"context_line":"                            \"Skipping share backend name check.\"))"},{"line_number":60,"context_line":"        elif (extra_specs[\u0027share_backend_name\u0027] !\u003d"},{"line_number":61,"context_line":"                host_stats[\u0027share_backend_name\u0027]):"},{"line_number":62,"context_line":"            LOG.warning(_LW(\"Share backend names do not match: \u0027%(target)s\u0027 \""},{"line_number":63,"context_line":"                            \"vs \u0027%(current)s\u0027 :: Skipping.\"),"},{"line_number":64,"context_line":"                        {\u0027target\u0027: extra_specs[\u0027share_backend_name\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_bd572725","line":61,"range":{"start_line":60,"start_character":8,"end_line":61,"end_character":50},"updated":"2016-07-14 21:39:38.000000000","message":"This block isn\u0027t covered by a unit test.","commit_id":"fc673d4dd62903a752a0d022ee0333a4682b5d46"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"298d05e2beb015f1120e4dd0609bd10599790fcc","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        if extra_specs is None or \u0027share_backend_name\u0027 not in extra_specs:"},{"line_number":58,"context_line":"            LOG.warning(_LW(\"No \u0027share_backend_name\u0027 key in extra_specs. \""},{"line_number":59,"context_line":"                            \"Skipping share backend name check.\"))"},{"line_number":60,"context_line":"        elif (extra_specs[\u0027share_backend_name\u0027] !\u003d"},{"line_number":61,"context_line":"                host_stats[\u0027share_backend_name\u0027]):"},{"line_number":62,"context_line":"            LOG.warning(_LW(\"Share backend names do not match: \u0027%(target)s\u0027 \""},{"line_number":63,"context_line":"                            \"vs \u0027%(current)s\u0027 :: Skipping.\"),"},{"line_number":64,"context_line":"                        {\u0027target\u0027: extra_specs[\u0027share_backend_name\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_3d635e1c","line":61,"range":{"start_line":60,"start_character":8,"end_line":61,"end_character":50},"in_reply_to":"1aa78d24_bd572725","updated":"2016-07-18 18:36:55.000000000","message":"Done","commit_id":"fc673d4dd62903a752a0d022ee0333a4682b5d46"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"12bbff502cbf322fed72b3bda250ea64edf33ca2","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                         \u0027error\u0027: ex, })"},{"line_number":82,"context_line":"            return False"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        return filter_result"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _run_evaluator(self, func, stats):"},{"line_number":87,"context_line":"        \"\"\"Evaluates a given function using the provided available stats.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_a9406808","line":84,"range":{"start_line":84,"start_character":15,"end_line":84,"end_character":28},"updated":"2016-07-15 15:37:40.000000000","message":"There doesn\u0027t appear to be any logging in the event the filter function works fine but returns False.  Please add a detailed log message explaining that the host didn\u0027t pass this filter.","commit_id":"fc673d4dd62903a752a0d022ee0333a4682b5d46"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"298d05e2beb015f1120e4dd0609bd10599790fcc","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                         \u0027error\u0027: ex, })"},{"line_number":82,"context_line":"            return False"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        return filter_result"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _run_evaluator(self, func, stats):"},{"line_number":87,"context_line":"        \"\"\"Evaluates a given function using the provided available stats.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_22e21bd6","line":84,"range":{"start_line":84,"start_character":15,"end_line":84,"end_character":28},"in_reply_to":"1aa78d24_a9406808","updated":"2016-07-18 18:36:55.000000000","message":"Done","commit_id":"fc673d4dd62903a752a0d022ee0333a4682b5d46"}],"manila/scheduler/utils.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fdc59ee162f5dcc578d0da5ff1759a2bb1b8b32b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    extra_specs \u003d share_type.get(\u0027extra_specs\u0027, {})"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    request_spec \u003d properties.get(\u0027request_spec\u0027, {})"},{"line_number":53,"context_line":"    share_stats \u003d request_spec.get(\u0027share_properties\u0027, {})"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    stats \u003d {"},{"line_number":56,"context_line":"        \u0027host_stats\u0027: host_stats,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_d842f70e","line":53,"range":{"start_line":53,"start_character":18,"end_line":53,"end_character":58},"updated":"2016-07-15 03:37:01.000000000","message":"Please use \u0027resource_properties\u0027 -\u003e you need both share and share_instance properties.. the share instance model contains much more information than the share and the request spec has this information as \u0027share_instance_properties\u0027... and manila/scheduler/filter_scheduler grabs these and coalesces both into \u0027resource_properties\u0027 and places them inside request spec.","commit_id":"fc673d4dd62903a752a0d022ee0333a4682b5d46"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"298d05e2beb015f1120e4dd0609bd10599790fcc","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    extra_specs \u003d share_type.get(\u0027extra_specs\u0027, {})"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    request_spec \u003d properties.get(\u0027request_spec\u0027, {})"},{"line_number":53,"context_line":"    share_stats \u003d request_spec.get(\u0027share_properties\u0027, {})"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    stats \u003d {"},{"line_number":56,"context_line":"        \u0027host_stats\u0027: host_stats,"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_62ed338b","line":53,"range":{"start_line":53,"start_character":18,"end_line":53,"end_character":58},"in_reply_to":"1aa78d24_d842f70e","updated":"2016-07-18 18:36:55.000000000","message":"TIL, thanks. Fixed.","commit_id":"fc673d4dd62903a752a0d022ee0333a4682b5d46"}],"manila/scheduler/weighers/goodness.py":[{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"65f423279a10b9f66c1fca7d93f4e9623a6eb6b5","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                if goodness_result:"},{"line_number":77,"context_line":"                    goodness_rating \u003d 100"},{"line_number":78,"context_line":"            elif goodness_result \u003c 0 or goodness_result \u003e 100:"},{"line_number":79,"context_line":"                LOG.warning(_LW(\"Invalid goodness result.  Result must be \""},{"line_number":80,"context_line":"                                \"between 0 and 100.  Result generated: \u0027%s\u0027 \""},{"line_number":81,"context_line":"                                \":: Defaulting to a goodness of 0\"),"},{"line_number":82,"context_line":"                            goodness_result)"},{"line_number":83,"context_line":"            else:"},{"line_number":84,"context_line":"                goodness_rating \u003d goodness_result"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_337d836d","line":82,"range":{"start_line":79,"start_character":16,"end_line":82,"end_character":44},"updated":"2016-07-01 07:40:06.000000000","message":"This warning says that the goodness is set to 0, but i can not see where the rating is actually set to 0.\nCould it be that there is a line missing in this elif branch to set the goodness_rating to 0?","commit_id":"571704c6c115546ea57ddd7ddfb56c9af4baa7c1"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"2fc24fc310da130ea399252f3c9feb297ba843b4","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                if goodness_result:"},{"line_number":77,"context_line":"                    goodness_rating \u003d 100"},{"line_number":78,"context_line":"            elif goodness_result \u003c 0 or goodness_result \u003e 100:"},{"line_number":79,"context_line":"                LOG.warning(_LW(\"Invalid goodness result.  Result must be \""},{"line_number":80,"context_line":"                                \"between 0 and 100.  Result generated: \u0027%s\u0027 \""},{"line_number":81,"context_line":"                                \":: Defaulting to a goodness of 0\"),"},{"line_number":82,"context_line":"                            goodness_result)"},{"line_number":83,"context_line":"            else:"},{"line_number":84,"context_line":"                goodness_rating \u003d goodness_result"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_94fa5341","line":82,"range":{"start_line":79,"start_character":16,"end_line":82,"end_character":44},"in_reply_to":"3aaa91ec_337d836d","updated":"2016-07-01 11:10:32.000000000","message":"The method returns goodness_rating, which defaults to 0 on line 57.","commit_id":"571704c6c115546ea57ddd7ddfb56c9af4baa7c1"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"e2f378e8115c505605c2276c8e8320d52a80d4df","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                if goodness_result:"},{"line_number":77,"context_line":"                    goodness_rating \u003d 100"},{"line_number":78,"context_line":"            elif goodness_result \u003c 0 or goodness_result \u003e 100:"},{"line_number":79,"context_line":"                LOG.warning(_LW(\"Invalid goodness result.  Result must be \""},{"line_number":80,"context_line":"                                \"between 0 and 100.  Result generated: \u0027%s\u0027 \""},{"line_number":81,"context_line":"                                \":: Defaulting to a goodness of 0\"),"},{"line_number":82,"context_line":"                            goodness_result)"},{"line_number":83,"context_line":"            else:"},{"line_number":84,"context_line":"                goodness_rating \u003d goodness_result"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_075637cd","line":82,"range":{"start_line":79,"start_character":16,"end_line":82,"end_character":44},"in_reply_to":"3aaa91ec_94fa5341","updated":"2016-07-01 11:26:09.000000000","message":"Oh you\u0027re right, didn\u0027t see that...","commit_id":"571704c6c115546ea57ddd7ddfb56c9af4baa7c1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e0cc589c2c390694340d42ce14c431d9754bb847","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            \u0027driver_handles_share_servers\u0027:"},{"line_number":121,"context_line":"                host_state.driver_handles_share_servers,"},{"line_number":122,"context_line":"            \u0027thin_provisioning\u0027: host_state.thin_provisioning,"},{"line_number":123,"context_line":"            \u0027updated\u0027: host_state.updated,"},{"line_number":124,"context_line":"        }"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        host_caps \u003d host_state.capabilities"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_7facc0ed","line":123,"range":{"start_line":123,"start_character":41,"end_line":123,"end_character":42},"updated":"2016-07-04 03:03:45.000000000","message":"You could add  \u0027dedupe\u0027, \u0027compression\u0027, \u0027allocated_capacity_gb\u0027,  \u0027snapshot_support\u0027, \u0027consistency_group_support\u0027 and etc in this dict. please check it again, thanks.","commit_id":"6b1e08340fc8faa6105f833cfdb1589e57e03c23"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"3a2f114d83a679f5f07bcc4232b08407dc907f99","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            \u0027driver_handles_share_servers\u0027:"},{"line_number":121,"context_line":"                host_state.driver_handles_share_servers,"},{"line_number":122,"context_line":"            \u0027thin_provisioning\u0027: host_state.thin_provisioning,"},{"line_number":123,"context_line":"            \u0027updated\u0027: host_state.updated,"},{"line_number":124,"context_line":"        }"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        host_caps \u003d host_state.capabilities"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_ccf1ab6c","line":123,"range":{"start_line":123,"start_character":41,"end_line":123,"end_character":42},"in_reply_to":"1aa78d24_7facc0ed","updated":"2016-07-04 20:50:05.000000000","message":"Added all fields from host_state. Thank you!","commit_id":"6b1e08340fc8faa6105f833cfdb1589e57e03c23"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e0cc589c2c390694340d42ce14c431d9754bb847","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                host_caps[\u0027goodness_function\u0027] is not None):"},{"line_number":132,"context_line":"            goodness_function \u003d six.text_type(host_caps[\u0027goodness_function\u0027])"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        qos_specs \u003d weight_properties.get(\u0027qos_specs\u0027, {})"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        share_type \u003d weight_properties.get(\u0027share_type\u0027, {})"},{"line_number":137,"context_line":"        extra_specs \u003d share_type.get(\u0027extra_specs\u0027, {})"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_ff9f10b2","line":134,"range":{"start_line":134,"start_character":42,"end_line":134,"end_character":53},"updated":"2016-07-04 03:03:45.000000000","message":"In manila, the \u0027qos_specs\u0027 is not exist. The qos attributes is exist in share_type\u0027s extra_specs.","commit_id":"6b1e08340fc8faa6105f833cfdb1589e57e03c23"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"3a2f114d83a679f5f07bcc4232b08407dc907f99","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                host_caps[\u0027goodness_function\u0027] is not None):"},{"line_number":132,"context_line":"            goodness_function \u003d six.text_type(host_caps[\u0027goodness_function\u0027])"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        qos_specs \u003d weight_properties.get(\u0027qos_specs\u0027, {})"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        share_type \u003d weight_properties.get(\u0027share_type\u0027, {})"},{"line_number":137,"context_line":"        extra_specs \u003d share_type.get(\u0027extra_specs\u0027, {})"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_6c035743","line":134,"range":{"start_line":134,"start_character":42,"end_line":134,"end_character":53},"in_reply_to":"1aa78d24_ff9f10b2","updated":"2016-07-04 20:50:05.000000000","message":"Didn\u0027t know. Double checked and removed that.","commit_id":"6b1e08340fc8faa6105f833cfdb1589e57e03c23"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"871e6f3ce2daee8cf42925807a860cd59e2a1c63","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if stats[\u0027goodness_function\u0027] is None:"},{"line_number":61,"context_line":"            LOG.warning(_LW(\"Goodness function not set :: defaulting to \""},{"line_number":62,"context_line":"                            \"minimal goodness rating of 0\"))"},{"line_number":63,"context_line":"        else:"},{"line_number":64,"context_line":"            try:"},{"line_number":65,"context_line":"                goodness_result \u003d self._run_evaluator("}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_3bf80849","line":62,"range":{"start_line":62,"start_character":56,"end_line":62,"end_character":58},"updated":"2016-07-06 12:35:25.000000000","message":"period","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"61fd7da9f07a821362a38ace175bc6f8d4ecb1ba","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if stats[\u0027goodness_function\u0027] is None:"},{"line_number":61,"context_line":"            LOG.warning(_LW(\"Goodness function not set :: defaulting to \""},{"line_number":62,"context_line":"                            \"minimal goodness rating of 0\"))"},{"line_number":63,"context_line":"        else:"},{"line_number":64,"context_line":"            try:"},{"line_number":65,"context_line":"                goodness_result \u003d self._run_evaluator("}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_c8c2d7e8","line":62,"range":{"start_line":62,"start_character":56,"end_line":62,"end_character":58},"in_reply_to":"1aa78d24_3bf80849","updated":"2016-07-06 13:40:37.000000000","message":"Done","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"871e6f3ce2daee8cf42925807a860cd59e2a1c63","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            except Exception as ex:"},{"line_number":69,"context_line":"                LOG.warning(_LW(\"Error in goodness_function function \""},{"line_number":70,"context_line":"                                \"\u0027%(function)s\u0027 : \u0027%(error)s\u0027 :: Defaulting \""},{"line_number":71,"context_line":"                                \"to a goodness of 0\"),"},{"line_number":72,"context_line":"                            {\u0027function\u0027: stats[\u0027goodness_function\u0027],"},{"line_number":73,"context_line":"                             \u0027error\u0027: ex, })"},{"line_number":74,"context_line":"                return goodness_rating"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_db9d840b","line":71,"range":{"start_line":71,"start_character":50,"end_line":71,"end_character":52},"updated":"2016-07-06 12:35:25.000000000","message":"period","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"61fd7da9f07a821362a38ace175bc6f8d4ecb1ba","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            except Exception as ex:"},{"line_number":69,"context_line":"                LOG.warning(_LW(\"Error in goodness_function function \""},{"line_number":70,"context_line":"                                \"\u0027%(function)s\u0027 : \u0027%(error)s\u0027 :: Defaulting \""},{"line_number":71,"context_line":"                                \"to a goodness of 0\"),"},{"line_number":72,"context_line":"                            {\u0027function\u0027: stats[\u0027goodness_function\u0027],"},{"line_number":73,"context_line":"                             \u0027error\u0027: ex, })"},{"line_number":74,"context_line":"                return goodness_rating"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_28b43b80","line":71,"range":{"start_line":71,"start_character":50,"end_line":71,"end_character":52},"in_reply_to":"1aa78d24_db9d840b","updated":"2016-07-06 13:40:37.000000000","message":"Done","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"871e6f3ce2daee8cf42925807a860cd59e2a1c63","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            elif goodness_result \u003c 0 or goodness_result \u003e 100:"},{"line_number":80,"context_line":"                LOG.warning(_LW(\"Invalid goodness result.  Result must be \""},{"line_number":81,"context_line":"                                \"between 0 and 100.  Result generated: \u0027%s\u0027 \""},{"line_number":82,"context_line":"                                \":: Defaulting to a goodness of 0\"),"},{"line_number":83,"context_line":"                            goodness_result)"},{"line_number":84,"context_line":"            else:"},{"line_number":85,"context_line":"                goodness_rating \u003d goodness_result"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_5b9234f7","line":82,"range":{"start_line":82,"start_character":64,"end_line":82,"end_character":65},"updated":"2016-07-06 12:35:25.000000000","message":"period","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"61fd7da9f07a821362a38ace175bc6f8d4ecb1ba","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            elif goodness_result \u003c 0 or goodness_result \u003e 100:"},{"line_number":80,"context_line":"                LOG.warning(_LW(\"Invalid goodness result.  Result must be \""},{"line_number":81,"context_line":"                                \"between 0 and 100.  Result generated: \u0027%s\u0027 \""},{"line_number":82,"context_line":"                                \":: Defaulting to a goodness of 0\"),"},{"line_number":83,"context_line":"                            goodness_result)"},{"line_number":84,"context_line":"            else:"},{"line_number":85,"context_line":"                goodness_rating \u003d goodness_result"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_08b97f79","line":82,"range":{"start_line":82,"start_character":64,"end_line":82,"end_character":65},"in_reply_to":"1aa78d24_5b9234f7","updated":"2016-07-06 13:40:37.000000000","message":"Done","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"12bbff502cbf322fed72b3bda250ea64edf33ca2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            else:"},{"line_number":85,"context_line":"                goodness_rating \u003d goodness_result"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return goodness_rating"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _run_evaluator(self, func, stats):"},{"line_number":90,"context_line":"        \"\"\"Evaluates a given function using the provided available stats.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"fad55976_19ce975a","line":87,"range":{"start_line":87,"start_character":15,"end_line":87,"end_character":30},"updated":"2016-07-15 15:37:40.000000000","message":"Can we add a debug log message here that includes the host and the goodness value?","commit_id":"fc673d4dd62903a752a0d022ee0333a4682b5d46"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"298d05e2beb015f1120e4dd0609bd10599790fcc","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            else:"},{"line_number":85,"context_line":"                goodness_rating \u003d goodness_result"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return goodness_rating"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _run_evaluator(self, func, stats):"},{"line_number":90,"context_line":"        \"\"\"Evaluates a given function using the provided available stats.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_a2ce0b58","line":87,"range":{"start_line":87,"start_character":15,"end_line":87,"end_character":30},"in_reply_to":"fad55976_19ce975a","updated":"2016-07-18 18:36:55.000000000","message":"Done","commit_id":"fc673d4dd62903a752a0d022ee0333a4682b5d46"}],"manila/tests/scheduler/filters/test_driver.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e0cc589c2c390694340d42ce14c431d9754bb847","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            })"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        filter_properties \u003d {"},{"line_number":147,"context_line":"            \u0027qos_specs\u0027: {"},{"line_number":148,"context_line":"                \u0027var\u0027: 1"},{"line_number":149,"context_line":"            }"},{"line_number":150,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_3ff878e5","line":147,"range":{"start_line":147,"start_character":13,"end_line":147,"end_character":23},"updated":"2016-07-04 03:03:45.000000000","message":"The qos_specs is not exist in manila.","commit_id":"6b1e08340fc8faa6105f833cfdb1589e57e03c23"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e0cc589c2c390694340d42ce14c431d9754bb847","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            })"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        filter_properties \u003d {"},{"line_number":175,"context_line":"            \u0027qos_specs\u0027: None"},{"line_number":176,"context_line":"        }"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        self.assertFalse(self.filter.host_passes(host1, filter_properties))"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_5ff3c40a","line":175,"range":{"start_line":175,"start_character":13,"end_line":175,"end_character":22},"updated":"2016-07-04 03:03:45.000000000","message":"The qos_specs is not exist in manila.","commit_id":"6b1e08340fc8faa6105f833cfdb1589e57e03c23"}],"manila/tests/scheduler/weighers/test_goodness.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"44bd0838f235f10c60fb13bcc794826180a30f19","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class GoodnessWeigherTestCase(test.TestCase):"},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(GoodnessWeigherTestCase, self).setUp()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_goodness_weigher_with_no_goodness_function(self):"},{"line_number":29,"context_line":"        weigher \u003d goodness.GoodnessWeigher()"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_d7791dfe","line":26,"range":{"start_line":25,"start_character":4,"end_line":26,"end_character":52},"updated":"2016-07-05 10:52:09.000000000","message":"redundant","commit_id":"cbc08b975423f5718b4c9dec4345e6e8a6b835e6"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"db2e63e386a3c1b18037727af5a3b6ec2c6859da","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class GoodnessWeigherTestCase(test.TestCase):"},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(GoodnessWeigherTestCase, self).setUp()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_goodness_weigher_with_no_goodness_function(self):"},{"line_number":29,"context_line":"        weigher \u003d goodness.GoodnessWeigher()"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_8ecbe5a4","line":26,"range":{"start_line":25,"start_character":4,"end_line":26,"end_character":52},"in_reply_to":"1aa78d24_d7791dfe","updated":"2016-07-05 19:13:37.000000000","message":"Done. Removed.","commit_id":"cbc08b975423f5718b4c9dec4345e6e8a6b835e6"}],"releasenotes/notes/driver-filter-91e2c60c9d1a48dd.yaml":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"44bd0838f235f10c60fb13bcc794826180a30f19","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Port cinder\u0027s DriverFilter and GoodnessWeigher to"},{"line_number":4,"context_line":"    manila."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_346e9f96","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":11},"updated":"2016-07-05 10:52:09.000000000","message":"And where one should look for it? Some link would be really useful.","commit_id":"cbc08b975423f5718b4c9dec4345e6e8a6b835e6"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"db2e63e386a3c1b18037727af5a3b6ec2c6859da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Port cinder\u0027s DriverFilter and GoodnessWeigher to"},{"line_number":4,"context_line":"    manila."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_6ebaf96f","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":11},"in_reply_to":"1aa78d24_346e9f96","updated":"2016-07-05 19:13:37.000000000","message":"Done","commit_id":"cbc08b975423f5718b4c9dec4345e6e8a6b835e6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"fdacac8cf339d5e7f40c8ec060b48546bf1eea0f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Port cinder\u0027s DriverFilter and GoodnessWeigher to"},{"line_number":4,"context_line":"    manila acording to change"},{"line_number":5,"context_line":"    https://review.openstack.org/#/c/129987"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1aa78d24_7ffefbae","line":4,"range":{"start_line":4,"start_character":11,"end_line":4,"end_character":19},"updated":"2016-07-06 12:40:54.000000000","message":"according","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"fdacac8cf339d5e7f40c8ec060b48546bf1eea0f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Port cinder\u0027s DriverFilter and GoodnessWeigher to"},{"line_number":4,"context_line":"    manila acording to change"},{"line_number":5,"context_line":"    https://review.openstack.org/#/c/129987"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1aa78d24_5f7e9f19","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":10},"updated":"2016-07-06 12:40:54.000000000","message":"manila\u0027s scheduler","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"871e6f3ce2daee8cf42925807a860cd59e2a1c63","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Port cinder\u0027s DriverFilter and GoodnessWeigher to"},{"line_number":4,"context_line":"    manila acording to change"},{"line_number":5,"context_line":"    https://review.openstack.org/#/c/129987"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1aa78d24_3f3913d8","line":4,"range":{"start_line":4,"start_character":23,"end_line":4,"end_character":29},"updated":"2016-07-06 12:35:25.000000000","message":"s/change/commit, and no need to break line here","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"61fd7da9f07a821362a38ace175bc6f8d4ecb1ba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Port cinder\u0027s DriverFilter and GoodnessWeigher to"},{"line_number":4,"context_line":"    manila acording to change"},{"line_number":5,"context_line":"    https://review.openstack.org/#/c/129987"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1aa78d24_88a56f48","line":4,"range":{"start_line":4,"start_character":11,"end_line":4,"end_character":19},"in_reply_to":"1aa78d24_7ffefbae","updated":"2016-07-06 13:40:37.000000000","message":"Done","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"871e6f3ce2daee8cf42925807a860cd59e2a1c63","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Port cinder\u0027s DriverFilter and GoodnessWeigher to"},{"line_number":4,"context_line":"    manila acording to change"},{"line_number":5,"context_line":"    https://review.openstack.org/#/c/129987"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1aa78d24_7f18bb75","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":43},"updated":"2016-07-06 12:35:25.000000000","message":"I believe you should include the commit here instead of gerrit, it may make more sense for release note viewers.","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"fdacac8cf339d5e7f40c8ec060b48546bf1eea0f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Port cinder\u0027s DriverFilter and GoodnessWeigher to"},{"line_number":4,"context_line":"    manila acording to change"},{"line_number":5,"context_line":"    https://review.openstack.org/#/c/129987"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1aa78d24_7f9a7b6f","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":43},"in_reply_to":"1aa78d24_7f18bb75","updated":"2016-07-06 12:40:54.000000000","message":"Thinking again, I think it may be better if you just mention which features you are porting from cinder, including a very brief description of what they are.","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"61fd7da9f07a821362a38ace175bc6f8d4ecb1ba","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Port cinder\u0027s DriverFilter and GoodnessWeigher to"},{"line_number":4,"context_line":"    manila acording to change"},{"line_number":5,"context_line":"    https://review.openstack.org/#/c/129987"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1aa78d24_e864f322","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":43},"in_reply_to":"1aa78d24_7f9a7b6f","updated":"2016-07-06 13:40:37.000000000","message":"Done","commit_id":"8f92eb7e2afe090d35ff45a8572718912e5c77ff"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fdc59ee162f5dcc578d0da5ff1759a2bb1b8b32b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add cinder\u0027s DriverFilter and GoodnessWeigher to manila\u0027s scheduler."},{"line_number":4,"context_line":"    These can use two new properties provided by backends, \u0027filter_function\u0027"},{"line_number":5,"context_line":"    and \u0027goodness_function\u0027, which can be used to filter and weigh qualified"},{"line_number":6,"context_line":"    backends, respectively."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1aa78d24_581447e8","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":16},"updated":"2016-07-15 03:37:01.000000000","message":"Not necessary. Please add necessary documentation to lead users and deployers to this feature.\n\n\nAlso: \u0027upgrade\u0027 section needs to be added to mention that changes are necessary to add this filter and weigher to a deployment (usually to entry_points.txt)","commit_id":"fc673d4dd62903a752a0d022ee0333a4682b5d46"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"298d05e2beb015f1120e4dd0609bd10599790fcc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add cinder\u0027s DriverFilter and GoodnessWeigher to manila\u0027s scheduler."},{"line_number":4,"context_line":"    These can use two new properties provided by backends, \u0027filter_function\u0027"},{"line_number":5,"context_line":"    and \u0027goodness_function\u0027, which can be used to filter and weigh qualified"},{"line_number":6,"context_line":"    backends, respectively."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dada55a8_f849d4d1","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":16},"in_reply_to":"1aa78d24_581447e8","updated":"2016-07-18 18:36:55.000000000","message":"Done","commit_id":"fc673d4dd62903a752a0d022ee0333a4682b5d46"}]}
