)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"021ecf05db5ab01641dba2a7f19f312cb01e81a5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  REST API (--driver_options size\u003d5) or"},{"line_number":19,"context_line":"  from its \"used\" attribute."},{"line_number":20,"context_line":"  In the latter case it will be set to nearest bigger rounded integer"},{"line_number":21,"context_line":"  of already used space (2,4 -\u003e 3, 3.6 -\u003e 4)."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Implements BP zfsonlinux-manage-snapshot"},{"line_number":24,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_3e404335","line":21,"range":{"start_line":21,"start_character":25,"end_line":21,"end_character":29},"updated":"2016-07-15 04:40:36.000000000","message":"And if the consumed space is 2? We\u0027ll set the managed snapshot size to 3 in the db?","commit_id":"24a2a55e9db3c28f4eb560388ad0f7e31272d5b8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4bc554a9d00d1f1f19629d9c0317422e74aebeba","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  REST API (--driver_options size\u003d5) or"},{"line_number":19,"context_line":"  from its \"used\" attribute."},{"line_number":20,"context_line":"  In the latter case it will be set to nearest bigger rounded integer"},{"line_number":21,"context_line":"  of already used space (2,4 -\u003e 3, 3.6 -\u003e 4)."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Implements BP zfsonlinux-manage-snapshot"},{"line_number":24,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fad55976_eab47cd2","line":21,"range":{"start_line":21,"start_character":25,"end_line":21,"end_character":29},"in_reply_to":"1aa78d24_3e404335","updated":"2016-07-15 17:43:15.000000000","message":"s/2,4/2.4","commit_id":"24a2a55e9db3c28f4eb560388ad0f7e31272d5b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"67c030c14b24b4cff35c527e65e9daa31809b807","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  REST API (--driver_options size\u003d5) or"},{"line_number":19,"context_line":"  from its \"used\" attribute."},{"line_number":20,"context_line":"  In the latter case it will be set to nearest bigger rounded integer"},{"line_number":21,"context_line":"  of already used space (2,4 -\u003e 3, 3.6 -\u003e 4)."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Implements BP zfsonlinux-manage-snapshot"},{"line_number":24,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_769a7e15","line":21,"range":{"start_line":21,"start_character":25,"end_line":21,"end_character":29},"in_reply_to":"fad55976_eab47cd2","updated":"2016-07-27 07:58:52.000000000","message":"Done","commit_id":"24a2a55e9db3c28f4eb560388ad0f7e31272d5b8"}],"manila/share/drivers/zfsonlinux/driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"347fd8454a6345c83fb00cf8691d5a62ee2a06bf","unresolved":false,"context_lines":[{"line_number":755,"context_line":"            consumed_space \u003d self.get_zfs_option(old_provider_location, \"used\")"},{"line_number":756,"context_line":"            consumed_space \u003d utils.translate_string_size_to_float("},{"line_number":757,"context_line":"                consumed_space)"},{"line_number":758,"context_line":"            snapshot_size \u003d int(consumed_space) + 1"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"        dataset_name \u003d self.private_storage.get("},{"line_number":761,"context_line":"            snapshot_instance[\"share_instance_id\"], \"dataset_name\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_3e3963d9","line":758,"range":{"start_line":758,"start_character":28,"end_line":758,"end_character":51},"updated":"2016-07-15 04:37:59.000000000","message":"fwiw in other drivers this is math.ceil(consumed_space). I don\u0027t agree with your previous comment that it works here so it is correct.","commit_id":"24a2a55e9db3c28f4eb560388ad0f7e31272d5b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"021ecf05db5ab01641dba2a7f19f312cb01e81a5","unresolved":false,"context_lines":[{"line_number":755,"context_line":"            consumed_space \u003d self.get_zfs_option(old_provider_location, \"used\")"},{"line_number":756,"context_line":"            consumed_space \u003d utils.translate_string_size_to_float("},{"line_number":757,"context_line":"                consumed_space)"},{"line_number":758,"context_line":"            snapshot_size \u003d int(consumed_space) + 1"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"        dataset_name \u003d self.private_storage.get("},{"line_number":761,"context_line":"            snapshot_instance[\"share_instance_id\"], \"dataset_name\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_de6f7fc2","line":758,"range":{"start_line":758,"start_character":28,"end_line":758,"end_character":51},"in_reply_to":"1aa78d24_3e3963d9","updated":"2016-07-15 04:40:36.000000000","message":"What is the consumed space is a whole number??","commit_id":"24a2a55e9db3c28f4eb560388ad0f7e31272d5b8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4bc554a9d00d1f1f19629d9c0317422e74aebeba","unresolved":false,"context_lines":[{"line_number":755,"context_line":"            consumed_space \u003d self.get_zfs_option(old_provider_location, \"used\")"},{"line_number":756,"context_line":"            consumed_space \u003d utils.translate_string_size_to_float("},{"line_number":757,"context_line":"                consumed_space)"},{"line_number":758,"context_line":"            snapshot_size \u003d int(consumed_space) + 1"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"        dataset_name \u003d self.private_storage.get("},{"line_number":761,"context_line":"            snapshot_instance[\"share_instance_id\"], \"dataset_name\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"fad55976_4a7ca820","line":758,"range":{"start_line":758,"start_character":28,"end_line":758,"end_character":51},"in_reply_to":"1aa78d24_de6f7fc2","updated":"2016-07-15 17:43:15.000000000","message":"Agree that math.ceil(…) is better.\n\nYou have some explanation in the commit message about this.  Can you add some comments here?","commit_id":"24a2a55e9db3c28f4eb560388ad0f7e31272d5b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"67c030c14b24b4cff35c527e65e9daa31809b807","unresolved":false,"context_lines":[{"line_number":755,"context_line":"            consumed_space \u003d self.get_zfs_option(old_provider_location, \"used\")"},{"line_number":756,"context_line":"            consumed_space \u003d utils.translate_string_size_to_float("},{"line_number":757,"context_line":"                consumed_space)"},{"line_number":758,"context_line":"            snapshot_size \u003d int(consumed_space) + 1"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"        dataset_name \u003d self.private_storage.get("},{"line_number":761,"context_line":"            snapshot_instance[\"share_instance_id\"], \"dataset_name\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_0af792d3","line":758,"range":{"start_line":758,"start_character":28,"end_line":758,"end_character":51},"in_reply_to":"dada55a8_5b7a0c25","updated":"2016-07-27 07:58:52.000000000","message":"My dear friends, I changed it as you kindly suggested. \u003d)\n\nValeriy.","commit_id":"24a2a55e9db3c28f4eb560388ad0f7e31272d5b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6c510298ffeb2f517bac275c23522deca1c4cecc","unresolved":false,"context_lines":[{"line_number":755,"context_line":"            consumed_space \u003d self.get_zfs_option(old_provider_location, \"used\")"},{"line_number":756,"context_line":"            consumed_space \u003d utils.translate_string_size_to_float("},{"line_number":757,"context_line":"                consumed_space)"},{"line_number":758,"context_line":"            snapshot_size \u003d int(consumed_space) + 1"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"        dataset_name \u003d self.private_storage.get("},{"line_number":761,"context_line":"            snapshot_instance[\"share_instance_id\"], \"dataset_name\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_5b7a0c25","line":758,"range":{"start_line":758,"start_character":28,"end_line":758,"end_character":51},"in_reply_to":"fad55976_4a7ca820","updated":"2016-07-27 00:43:28.000000000","message":"As you can see in the unit tests too, if the snapshot size is 4G, we bring it into manila as a 5G snapshot.. why?","commit_id":"24a2a55e9db3c28f4eb560388ad0f7e31272d5b8"}],"manila/tests/share/drivers/zfsonlinux/test_driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6c510298ffeb2f517bac275c23522deca1c4cecc","unresolved":false,"context_lines":[{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"        self.mock_object(self.driver, \"zfs\")"},{"line_number":1213,"context_line":"        self.mock_object("},{"line_number":1214,"context_line":"            self.driver, \"get_zfs_option\", mock.Mock(return_value\u003d\"4G\"))"},{"line_number":1215,"context_line":"        self.mock_object("},{"line_number":1216,"context_line":"            self.driver,"},{"line_number":1217,"context_line":"            \u0027_get_snapshot_name\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_9b99247c","line":1214,"range":{"start_line":1214,"start_character":66,"end_line":1214,"end_character":70},"updated":"2016-07-27 00:43:28.000000000","message":"This is a problem.. Why would we allocate 5G for a snapshot that\u0027s actually 4G?","commit_id":"24a2a55e9db3c28f4eb560388ad0f7e31272d5b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"67c030c14b24b4cff35c527e65e9daa31809b807","unresolved":false,"context_lines":[{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"        self.mock_object(self.driver, \"zfs\")"},{"line_number":1213,"context_line":"        self.mock_object("},{"line_number":1214,"context_line":"            self.driver, \"get_zfs_option\", mock.Mock(return_value\u003d\"4G\"))"},{"line_number":1215,"context_line":"        self.mock_object("},{"line_number":1216,"context_line":"            self.driver,"},{"line_number":1217,"context_line":"            \u0027_get_snapshot_name\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_167a22bd","line":1214,"range":{"start_line":1214,"start_character":66,"end_line":1214,"end_character":70},"in_reply_to":"dada55a8_9b99247c","updated":"2016-07-27 07:58:52.000000000","message":"Done","commit_id":"24a2a55e9db3c28f4eb560388ad0f7e31272d5b8"}]}