)]}'
{"manila/share/drivers/hpe/hpe_3par_mediator.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5f29098809f0561893db58f3070cb5d97b844ea5","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        if share_proto \u003d\u003d \u0027nfs\u0027:"},{"line_number":217,"context_line":"            location \u003d \u0027:\u0027.join((ip, path))"},{"line_number":218,"context_line":"        else:"},{"line_number":219,"context_line":"            location \u003d \u0027\\\\\\\\%s\\%s\u0027 % (ip, path)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        return location"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_b879a995","line":219,"range":{"start_line":219,"start_character":23,"end_line":219,"end_character":34},"updated":"2016-07-26 14:13:59.000000000","message":"Shouldn\u0027t this be \u0027\\\\\\\\%s\\\\%s\u0027, or preferably r\u0027\\\\%s\\%s\u0027 ?","commit_id":"9ae88a8b92949d436951d2b91d9e7771694a94e6"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"00b259f682a1ae9a370f2819f68ec7851db4509b","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        if share_proto \u003d\u003d \u0027nfs\u0027:"},{"line_number":217,"context_line":"            location \u003d \u0027:\u0027.join((ip, path))"},{"line_number":218,"context_line":"        else:"},{"line_number":219,"context_line":"            location \u003d \u0027\\\\\\\\%s\\%s\u0027 % (ip, path)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        return location"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_3285c4ce","line":219,"range":{"start_line":219,"start_character":23,"end_line":219,"end_character":34},"in_reply_to":"dada55a8_b879a995","updated":"2016-07-26 22:21:25.000000000","message":"very old, but is actually OK because \\o is just o (we use osf- prefix) -- but still I prefer to use your recommendation while I\u0027m moving the code.","commit_id":"9ae88a8b92949d436951d2b91d9e7771694a94e6"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5f29098809f0561893db58f3070cb5d97b844ea5","unresolved":false,"context_lines":[{"line_number":773,"context_line":"            if progress \u003d\u003d 100:"},{"line_number":774,"context_line":"                return True"},{"line_number":775,"context_line":"            else:"},{"line_number":776,"context_line":"                err_msg \u003d (_(\"Failed to copy data, reason: \""},{"line_number":777,"context_line":"                             \"Total progress %d !\u003d 100.\")"},{"line_number":778,"context_line":"                           % progress)"},{"line_number":779,"context_line":"                LOG.error(err_msg)"},{"line_number":780,"context_line":"        except Exception as err:"},{"line_number":781,"context_line":"            err_msg \u003d (_(\"Failed to copy data, reason: %s.\")"},{"line_number":782,"context_line":"                       % six.text_type(err))"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_b80a49d0","line":779,"range":{"start_line":776,"start_character":16,"end_line":779,"end_character":34},"updated":"2016-07-26 14:13:59.000000000","message":"err_msg \u003d _LE(\"Failed to copy data, reason: \"\n              \"Total progress %d !\u003d 100.\")\nLOG.error(err_msg, progress)","commit_id":"9ae88a8b92949d436951d2b91d9e7771694a94e6"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"00b259f682a1ae9a370f2819f68ec7851db4509b","unresolved":false,"context_lines":[{"line_number":773,"context_line":"            if progress \u003d\u003d 100:"},{"line_number":774,"context_line":"                return True"},{"line_number":775,"context_line":"            else:"},{"line_number":776,"context_line":"                err_msg \u003d (_(\"Failed to copy data, reason: \""},{"line_number":777,"context_line":"                             \"Total progress %d !\u003d 100.\")"},{"line_number":778,"context_line":"                           % progress)"},{"line_number":779,"context_line":"                LOG.error(err_msg)"},{"line_number":780,"context_line":"        except Exception as err:"},{"line_number":781,"context_line":"            err_msg \u003d (_(\"Failed to copy data, reason: %s.\")"},{"line_number":782,"context_line":"                       % six.text_type(err))"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_928ab0bd","line":779,"range":{"start_line":776,"start_character":16,"end_line":779,"end_character":34},"in_reply_to":"dada55a8_b80a49d0","updated":"2016-07-26 22:21:25.000000000","message":"Done","commit_id":"9ae88a8b92949d436951d2b91d9e7771694a94e6"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5f29098809f0561893db58f3070cb5d97b844ea5","unresolved":false,"context_lines":[{"line_number":778,"context_line":"                           % progress)"},{"line_number":779,"context_line":"                LOG.error(err_msg)"},{"line_number":780,"context_line":"        except Exception as err:"},{"line_number":781,"context_line":"            err_msg \u003d (_(\"Failed to copy data, reason: %s.\")"},{"line_number":782,"context_line":"                       % six.text_type(err))"},{"line_number":783,"context_line":"            LOG.error(err_msg)"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_58e86de2","line":782,"range":{"start_line":781,"start_character":22,"end_line":782,"end_character":44},"updated":"2016-07-26 14:13:59.000000000","message":"Same","commit_id":"9ae88a8b92949d436951d2b91d9e7771694a94e6"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"00b259f682a1ae9a370f2819f68ec7851db4509b","unresolved":false,"context_lines":[{"line_number":778,"context_line":"                           % progress)"},{"line_number":779,"context_line":"                LOG.error(err_msg)"},{"line_number":780,"context_line":"        except Exception as err:"},{"line_number":781,"context_line":"            err_msg \u003d (_(\"Failed to copy data, reason: %s.\")"},{"line_number":782,"context_line":"                       % six.text_type(err))"},{"line_number":783,"context_line":"            LOG.error(err_msg)"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_72873cb5","line":782,"range":{"start_line":781,"start_character":22,"end_line":782,"end_character":44},"in_reply_to":"dada55a8_58e86de2","updated":"2016-07-26 22:21:25.000000000","message":"Done","commit_id":"9ae88a8b92949d436951d2b91d9e7771694a94e6"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5f29098809f0561893db58f3070cb5d97b844ea5","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"        try:"},{"line_number":1002,"context_line":"            utils.execute(\u0027umount\u0027, mount_location, run_as_root\u003dTrue)"},{"line_number":1003,"context_line":"        except Exception as err:"},{"line_number":1004,"context_line":"            message \u003d (_LW(\"There was an error unmounting the share at \""},{"line_number":1005,"context_line":"                           \"%(mount_location)s: %(error)s\"),"},{"line_number":1006,"context_line":"                       six.text_type(err))"},{"line_number":1007,"context_line":"            LOG.warning(message)"},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"    def _delete_share_directory(self, directory):"},{"line_number":1010,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_38a13995","line":1007,"range":{"start_line":1004,"start_character":12,"end_line":1007,"end_character":32},"updated":"2016-07-26 14:13:59.000000000","message":"Where are the named substitution arguments for this message?","commit_id":"9ae88a8b92949d436951d2b91d9e7771694a94e6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"08f21ee87b7eaf80c8c28bda308fbc3793347f1f","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"        try:"},{"line_number":1002,"context_line":"            utils.execute(\u0027umount\u0027, mount_location, run_as_root\u003dTrue)"},{"line_number":1003,"context_line":"        except Exception as err:"},{"line_number":1004,"context_line":"            message \u003d (_LW(\"There was an error unmounting the share at \""},{"line_number":1005,"context_line":"                           \"%(mount_location)s: %(error)s\"),"},{"line_number":1006,"context_line":"                       six.text_type(err))"},{"line_number":1007,"context_line":"            LOG.warning(message)"},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"    def _delete_share_directory(self, directory):"},{"line_number":1010,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_6de1242a","line":1007,"range":{"start_line":1004,"start_character":12,"end_line":1007,"end_character":32},"in_reply_to":"dada55a8_38a13995","updated":"2016-07-26 17:30:14.000000000","message":"Yes, it is a bug. Substitution is broken.","commit_id":"9ae88a8b92949d436951d2b91d9e7771694a94e6"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"00b259f682a1ae9a370f2819f68ec7851db4509b","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"        try:"},{"line_number":1002,"context_line":"            utils.execute(\u0027umount\u0027, mount_location, run_as_root\u003dTrue)"},{"line_number":1003,"context_line":"        except Exception as err:"},{"line_number":1004,"context_line":"            message \u003d (_LW(\"There was an error unmounting the share at \""},{"line_number":1005,"context_line":"                           \"%(mount_location)s: %(error)s\"),"},{"line_number":1006,"context_line":"                       six.text_type(err))"},{"line_number":1007,"context_line":"            LOG.warning(message)"},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"    def _delete_share_directory(self, directory):"},{"line_number":1010,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_bd7b45bd","line":1007,"range":{"start_line":1004,"start_character":12,"end_line":1007,"end_character":32},"in_reply_to":"dada55a8_6de1242a","updated":"2016-07-26 22:21:25.000000000","message":"Done","commit_id":"9ae88a8b92949d436951d2b91d9e7771694a94e6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e69bd64e44f0f014590d3535f4a02f648b12d425","unresolved":false,"context_lines":[{"line_number":63,"context_line":"class HPE3ParMediator(object):"},{"line_number":64,"context_line":"    \"\"\"3PAR client-facing code for the 3PAR driver."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    Version history:"},{"line_number":67,"context_line":"        1.0.0 - Begin Liberty development (post-Kilo)"},{"line_number":68,"context_line":"        1.0.1 - Report thin/dedup/hp_flash_cache capabilities"},{"line_number":69,"context_line":"        1.0.2 - Add share server/share network support"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_f0add631","line":66,"range":{"start_line":66,"start_character":4,"end_line":66,"end_character":20},"updated":"2016-07-27 07:53:19.000000000","message":"This is a new hpe feature. Does you need to update the version and add the description for it?","commit_id":"2d95fd1e2fd0c69c108ed788feb7215a5efd50e9"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"c736bb4e7631a00a5cab8a6e3cdc9c89027d5c5c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"class HPE3ParMediator(object):"},{"line_number":64,"context_line":"    \"\"\"3PAR client-facing code for the 3PAR driver."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    Version history:"},{"line_number":67,"context_line":"        1.0.0 - Begin Liberty development (post-Kilo)"},{"line_number":68,"context_line":"        1.0.1 - Report thin/dedup/hp_flash_cache capabilities"},{"line_number":69,"context_line":"        1.0.2 - Add share server/share network support"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_43f87cc3","line":66,"range":{"start_line":66,"start_character":4,"end_line":66,"end_character":20},"in_reply_to":"dada55a8_f0add631","updated":"2016-07-31 05:56:56.000000000","message":"Done","commit_id":"2d95fd1e2fd0c69c108ed788feb7215a5efd50e9"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"777336bb4bd018a097b0f00ba698a73eeafcca10","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        2.0.3 - Fix SMB read-only access (added in 2.0.1)"},{"line_number":75,"context_line":"        2.0.4 - Remove file tree on delete when using nested shares #1538800"},{"line_number":76,"context_line":"        2.0.5 - Reduce the fsquota by share size"},{"line_number":77,"context_line":"                when a share is deleted #1582931"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    \"\"\""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_4aacef8b","line":77,"updated":"2016-07-27 06:47:08.000000000","message":"please add your update here.","commit_id":"2d95fd1e2fd0c69c108ed788feb7215a5efd50e9"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"c736bb4e7631a00a5cab8a6e3cdc9c89027d5c5c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        2.0.3 - Fix SMB read-only access (added in 2.0.1)"},{"line_number":75,"context_line":"        2.0.4 - Remove file tree on delete when using nested shares #1538800"},{"line_number":76,"context_line":"        2.0.5 - Reduce the fsquota by share size"},{"line_number":77,"context_line":"                when a share is deleted #1582931"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    \"\"\""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_a30178b1","line":77,"in_reply_to":"dada55a8_4aacef8b","updated":"2016-07-31 05:56:56.000000000","message":"Done","commit_id":"2d95fd1e2fd0c69c108ed788feb7215a5efd50e9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e69bd64e44f0f014590d3535f4a02f648b12d425","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        if not ip:"},{"line_number":208,"context_line":"            message \u003d _(\u0027Failed to build export location due to missing IP.\u0027)"},{"line_number":209,"context_line":"            raise exception.InvalidInput(message)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        if not path:"},{"line_number":212,"context_line":"            message \u003d _(\u0027Failed to build export location due to missing path.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_904c5a9f","line":209,"range":{"start_line":209,"start_character":18,"end_line":209,"end_character":49},"updated":"2016-07-27 07:53:19.000000000","message":"s/exception.InvalidInput(message)/ exception.InvalidInput(reason\u003dmessage)","commit_id":"2d95fd1e2fd0c69c108ed788feb7215a5efd50e9"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"c736bb4e7631a00a5cab8a6e3cdc9c89027d5c5c","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        if not ip:"},{"line_number":208,"context_line":"            message \u003d _(\u0027Failed to build export location due to missing IP.\u0027)"},{"line_number":209,"context_line":"            raise exception.InvalidInput(message)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        if not path:"},{"line_number":212,"context_line":"            message \u003d _(\u0027Failed to build export location due to missing path.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_e32d3047","line":209,"range":{"start_line":209,"start_character":18,"end_line":209,"end_character":49},"in_reply_to":"dada55a8_904c5a9f","updated":"2016-07-31 05:56:56.000000000","message":"Done","commit_id":"2d95fd1e2fd0c69c108ed788feb7215a5efd50e9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e69bd64e44f0f014590d3535f4a02f648b12d425","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        if not path:"},{"line_number":212,"context_line":"            message \u003d _(\u0027Failed to build export location due to missing path.\u0027)"},{"line_number":213,"context_line":"            raise exception.InvalidInput(message)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        share_proto \u003d HPE3ParMediator.ensure_supported_protocol(protocol)"},{"line_number":216,"context_line":"        if share_proto \u003d\u003d \u0027nfs\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_b0451e70","line":213,"range":{"start_line":213,"start_character":18,"end_line":213,"end_character":49},"updated":"2016-07-27 07:53:19.000000000","message":"s/exception.InvalidInput(message)/ exception.InvalidInput(reason\u003dmessage)","commit_id":"2d95fd1e2fd0c69c108ed788feb7215a5efd50e9"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"c736bb4e7631a00a5cab8a6e3cdc9c89027d5c5c","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        if not path:"},{"line_number":212,"context_line":"            message \u003d _(\u0027Failed to build export location due to missing path.\u0027)"},{"line_number":213,"context_line":"            raise exception.InvalidInput(message)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        share_proto \u003d HPE3ParMediator.ensure_supported_protocol(protocol)"},{"line_number":216,"context_line":"        if share_proto \u003d\u003d \u0027nfs\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_c332aca6","line":213,"range":{"start_line":213,"start_character":18,"end_line":213,"end_character":49},"in_reply_to":"dada55a8_b0451e70","updated":"2016-07-31 05:56:56.000000000","message":"Done","commit_id":"2d95fd1e2fd0c69c108ed788feb7215a5efd50e9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e69bd64e44f0f014590d3535f4a02f648b12d425","unresolved":false,"context_lines":[{"line_number":707,"context_line":"                protocol, ip, source_path)"},{"line_number":708,"context_line":"            dest_location \u003d self.build_export_location(protocol, ip, dest_path)"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"            self._copy_share_data("},{"line_number":711,"context_line":"                share_id, source_location, dest_location,  protocol)"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"            # Revoke the admin access that was needed to copy to the dest."}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_b62196a0","line":710,"range":{"start_line":710,"start_character":12,"end_line":710,"end_character":34},"updated":"2016-07-27 07:53:19.000000000","message":"If the copy share data fail, the create_share_from_snapshot will be successful? Because I saw code line 758, there is not check the return value of the _copy_data function. If the _copy_data function return false, the code will continue, and the create_share_from_snapshot will be successful?  Is it ok?","commit_id":"2d95fd1e2fd0c69c108ed788feb7215a5efd50e9"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"c736bb4e7631a00a5cab8a6e3cdc9c89027d5c5c","unresolved":false,"context_lines":[{"line_number":707,"context_line":"                protocol, ip, source_path)"},{"line_number":708,"context_line":"            dest_location \u003d self.build_export_location(protocol, ip, dest_path)"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"            self._copy_share_data("},{"line_number":711,"context_line":"                share_id, source_location, dest_location,  protocol)"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"            # Revoke the admin access that was needed to copy to the dest."}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_23dbc850","line":710,"range":{"start_line":710,"start_character":12,"end_line":710,"end_character":34},"in_reply_to":"dada55a8_b62196a0","updated":"2016-07-31 05:56:56.000000000","message":"Good catch, Jun. I changed it back so it raises an exception instead of just returning False.","commit_id":"2d95fd1e2fd0c69c108ed788feb7215a5efd50e9"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"777336bb4bd018a097b0f00ba698a73eeafcca10","unresolved":false,"context_lines":[{"line_number":725,"context_line":"                self._revoke_admin_smb_access("},{"line_number":726,"context_line":"                    protocol, fpg, vfs, fstore, comment)"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"        except Exception:"},{"line_number":729,"context_line":"            self._delete_share(share_name, protocol, fpg, vfs, fstore)"},{"line_number":730,"context_line":"            raise"},{"line_number":731,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_fb65b7e0","line":728,"updated":"2016-07-27 06:47:08.000000000","message":"Suggest adding a log here.","commit_id":"2d95fd1e2fd0c69c108ed788feb7215a5efd50e9"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"c736bb4e7631a00a5cab8a6e3cdc9c89027d5c5c","unresolved":false,"context_lines":[{"line_number":725,"context_line":"                self._revoke_admin_smb_access("},{"line_number":726,"context_line":"                    protocol, fpg, vfs, fstore, comment)"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"        except Exception:"},{"line_number":729,"context_line":"            self._delete_share(share_name, protocol, fpg, vfs, fstore)"},{"line_number":730,"context_line":"            raise"},{"line_number":731,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_03e044f9","line":728,"in_reply_to":"dada55a8_fb65b7e0","updated":"2016-07-31 05:56:56.000000000","message":"Done","commit_id":"2d95fd1e2fd0c69c108ed788feb7215a5efd50e9"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"777336bb4bd018a097b0f00ba698a73eeafcca10","unresolved":false,"context_lines":[{"line_number":726,"context_line":"                    protocol, fpg, vfs, fstore, comment)"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"        except Exception:"},{"line_number":729,"context_line":"            self._delete_share(share_name, protocol, fpg, vfs, fstore)"},{"line_number":730,"context_line":"            raise"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_30a76ea8","line":729,"range":{"start_line":729,"start_character":17,"end_line":729,"end_character":30},"updated":"2016-07-27 06:47:08.000000000","message":"will this also delete the read-only share as _delete_ro_share?","commit_id":"2d95fd1e2fd0c69c108ed788feb7215a5efd50e9"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"c736bb4e7631a00a5cab8a6e3cdc9c89027d5c5c","unresolved":false,"context_lines":[{"line_number":726,"context_line":"                    protocol, fpg, vfs, fstore, comment)"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"        except Exception:"},{"line_number":729,"context_line":"            self._delete_share(share_name, protocol, fpg, vfs, fstore)"},{"line_number":730,"context_line":"            raise"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_83ec34f4","line":729,"range":{"start_line":729,"start_character":17,"end_line":729,"end_character":30},"in_reply_to":"dada55a8_30a76ea8","updated":"2016-07-31 05:56:56.000000000","message":"The RO share gets deleted in the finally.","commit_id":"2d95fd1e2fd0c69c108ed788feb7215a5efd50e9"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"777336bb4bd018a097b0f00ba698a73eeafcca10","unresolved":false,"context_lines":[{"line_number":755,"context_line":"            self._mount_share(protocol, dest_location, dest_share_dir)"},{"line_number":756,"context_line":"            dirs_to_unmount.append(dest_share_dir)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"            self._copy_data(source_share_dir, dest_share_dir)"},{"line_number":759,"context_line":"        finally:"},{"line_number":760,"context_line":"            for d in dirs_to_unmount:"},{"line_number":761,"context_line":"                self._unmount_share(d)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_1b16cb4b","line":758,"range":{"start_line":758,"start_character":17,"end_line":758,"end_character":27},"updated":"2016-07-27 06:47:08.000000000","message":"Didn\u0027t check the result or raise exception if the data copying progress failed, how will the caller know the data copying not success?","commit_id":"2d95fd1e2fd0c69c108ed788feb7215a5efd50e9"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"c736bb4e7631a00a5cab8a6e3cdc9c89027d5c5c","unresolved":false,"context_lines":[{"line_number":755,"context_line":"            self._mount_share(protocol, dest_location, dest_share_dir)"},{"line_number":756,"context_line":"            dirs_to_unmount.append(dest_share_dir)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"            self._copy_data(source_share_dir, dest_share_dir)"},{"line_number":759,"context_line":"        finally:"},{"line_number":760,"context_line":"            for d in dirs_to_unmount:"},{"line_number":761,"context_line":"                self._unmount_share(d)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_e3bb70e3","line":758,"range":{"start_line":758,"start_character":17,"end_line":758,"end_character":27},"in_reply_to":"dada55a8_1b16cb4b","updated":"2016-07-31 05:56:56.000000000","message":"_copy_data now raises exceptions instead of returning False","commit_id":"2d95fd1e2fd0c69c108ed788feb7215a5efd50e9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"af1d4e7074d66b148fbae47934c51080293ce7b5","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            raise exception.InvalidInput(reason\u003dmessage)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        share_proto \u003d HPE3ParMediator.ensure_supported_protocol(protocol)"},{"line_number":217,"context_line":"        if share_proto \u003d\u003d \u0027nfs\u0027:"},{"line_number":218,"context_line":"            location \u003d \u0027:\u0027.join((ip, path))"},{"line_number":219,"context_line":"        else:"},{"line_number":220,"context_line":"            location \u003d r\u0027\\\\%s\\%s\u0027 % (ip, path)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_c618f077","line":217,"range":{"start_line":217,"start_character":11,"end_line":217,"end_character":31},"updated":"2016-08-01 02:41:15.000000000","message":"nit:\n\n share_proto.lower() \u003d\u003d \u0027nfs\u0027\n\nis resilient..","commit_id":"d9a64dd91dc3009b3aa43d1f0723d75d14d2ad40"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"eeb558b0583d8528ee4732515c3f8267741e14ed","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            raise exception.InvalidInput(reason\u003dmessage)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        share_proto \u003d HPE3ParMediator.ensure_supported_protocol(protocol)"},{"line_number":217,"context_line":"        if share_proto \u003d\u003d \u0027nfs\u0027:"},{"line_number":218,"context_line":"            location \u003d \u0027:\u0027.join((ip, path))"},{"line_number":219,"context_line":"        else:"},{"line_number":220,"context_line":"            location \u003d r\u0027\\\\%s\\%s\u0027 % (ip, path)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_c71fdc07","line":217,"range":{"start_line":217,"start_character":11,"end_line":217,"end_character":31},"in_reply_to":"bacf61ea_c618f077","updated":"2016-08-02 23:55:01.000000000","message":"ensure_supported_protocol() above is used to deal with case and also mapping CIFS to smb.  I\u0027d rather not repeat the lower() -- although perhaps this ensure pattern should be improved later.","commit_id":"d9a64dd91dc3009b3aa43d1f0723d75d14d2ad40"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fc87fc0fda24a623f70982c8bda0ecea4c7efca3","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            raise exception.InvalidInput(reason\u003dmessage)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        share_proto \u003d HPE3ParMediator.ensure_supported_protocol(protocol)"},{"line_number":217,"context_line":"        if share_proto \u003d\u003d \u0027nfs\u0027:"},{"line_number":218,"context_line":"            location \u003d \u0027:\u0027.join((ip, path))"},{"line_number":219,"context_line":"        else:"},{"line_number":220,"context_line":"            location \u003d r\u0027\\\\%s\\%s\u0027 % (ip, path)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_886725e8","line":217,"range":{"start_line":217,"start_character":11,"end_line":217,"end_character":31},"in_reply_to":"bacf61ea_c71fdc07","updated":"2016-08-11 03:11:26.000000000","message":"+1..","commit_id":"d9a64dd91dc3009b3aa43d1f0723d75d14d2ad40"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"af1d4e7074d66b148fbae47934c51080293ce7b5","unresolved":false,"context_lines":[{"line_number":649,"context_line":"            sharedir \u003d \u0027.snapshot/%s/%s\u0027 % (snapshot[\u0027snapName\u0027],"},{"line_number":650,"context_line":"                                            orig_share_name)"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        if protocol \u003d\u003d \"smb\" and (not self.hpe3par_cifs_admin_access_username"},{"line_number":653,"context_line":"           or not self.hpe3par_cifs_admin_access_password):"},{"line_number":654,"context_line":"            LOG.warning(_LW(\"hpe3par_cifs_admin_access_username and \""},{"line_number":655,"context_line":"                            \"hpe3par_cifs_admin_access_password must be \""}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_a63cdcc8","line":652,"range":{"start_line":652,"start_character":11,"end_line":652,"end_character":28},"updated":"2016-08-01 02:41:15.000000000","message":"same:\n\n protocol.lower() \u003d\u003d \u0027smb\u0027","commit_id":"d9a64dd91dc3009b3aa43d1f0723d75d14d2ad40"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"eeb558b0583d8528ee4732515c3f8267741e14ed","unresolved":false,"context_lines":[{"line_number":649,"context_line":"            sharedir \u003d \u0027.snapshot/%s/%s\u0027 % (snapshot[\u0027snapName\u0027],"},{"line_number":650,"context_line":"                                            orig_share_name)"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        if protocol \u003d\u003d \"smb\" and (not self.hpe3par_cifs_admin_access_username"},{"line_number":653,"context_line":"           or not self.hpe3par_cifs_admin_access_password):"},{"line_number":654,"context_line":"            LOG.warning(_LW(\"hpe3par_cifs_admin_access_username and \""},{"line_number":655,"context_line":"                            \"hpe3par_cifs_admin_access_password must be \""}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_87dcc447","line":652,"range":{"start_line":652,"start_character":11,"end_line":652,"end_character":28},"in_reply_to":"bacf61ea_a63cdcc8","updated":"2016-08-02 23:55:01.000000000","message":"same","commit_id":"d9a64dd91dc3009b3aa43d1f0723d75d14d2ad40"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"af1d4e7074d66b148fbae47934c51080293ce7b5","unresolved":false,"context_lines":[{"line_number":701,"context_line":"            )"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"            try:"},{"line_number":704,"context_line":"                if protocol \u003d\u003d \u0027smb\u0027:"},{"line_number":705,"context_line":"                    self._grant_admin_smb_access("},{"line_number":706,"context_line":"                        protocol, fpg, vfs, fstore, comment, share\u003dshare_name)"},{"line_number":707,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_c62f5086","line":704,"range":{"start_line":704,"start_character":19,"end_line":704,"end_character":36},"updated":"2016-08-01 02:41:15.000000000","message":"same","commit_id":"d9a64dd91dc3009b3aa43d1f0723d75d14d2ad40"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"eeb558b0583d8528ee4732515c3f8267741e14ed","unresolved":false,"context_lines":[{"line_number":701,"context_line":"            )"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"            try:"},{"line_number":704,"context_line":"                if protocol \u003d\u003d \u0027smb\u0027:"},{"line_number":705,"context_line":"                    self._grant_admin_smb_access("},{"line_number":706,"context_line":"                        protocol, fpg, vfs, fstore, comment, share\u003dshare_name)"},{"line_number":707,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_67e1d0fe","line":704,"range":{"start_line":704,"start_character":19,"end_line":704,"end_character":36},"in_reply_to":"bacf61ea_c62f5086","updated":"2016-08-02 23:55:01.000000000","message":"same","commit_id":"d9a64dd91dc3009b3aa43d1f0723d75d14d2ad40"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"af1d4e7074d66b148fbae47934c51080293ce7b5","unresolved":false,"context_lines":[{"line_number":734,"context_line":"                        protocol, fpg, vfs, fstore, comment)"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"            except Exception as e:"},{"line_number":737,"context_line":"                self._delete_share(share_name, protocol, fpg, vfs, fstore)"},{"line_number":738,"context_line":"                msg \u003d _LE(\u0027Exception during mount and copy from RO snapshot \u0027"},{"line_number":739,"context_line":"                          \u0027to RW share: %s\u0027)"},{"line_number":740,"context_line":"                LOG.error(msg, six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_8640b835","line":737,"range":{"start_line":737,"start_character":16,"end_line":737,"end_character":74},"updated":"2016-08-01 02:41:15.000000000","message":"push this deletion after the logging; just in case this raises another exception.","commit_id":"d9a64dd91dc3009b3aa43d1f0723d75d14d2ad40"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"eeb558b0583d8528ee4732515c3f8267741e14ed","unresolved":false,"context_lines":[{"line_number":734,"context_line":"                        protocol, fpg, vfs, fstore, comment)"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"            except Exception as e:"},{"line_number":737,"context_line":"                self._delete_share(share_name, protocol, fpg, vfs, fstore)"},{"line_number":738,"context_line":"                msg \u003d _LE(\u0027Exception during mount and copy from RO snapshot \u0027"},{"line_number":739,"context_line":"                          \u0027to RW share: %s\u0027)"},{"line_number":740,"context_line":"                LOG.error(msg, six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_07ad7488","line":737,"range":{"start_line":737,"start_character":16,"end_line":737,"end_character":74},"in_reply_to":"bacf61ea_8640b835","updated":"2016-08-02 23:55:01.000000000","message":"Done","commit_id":"d9a64dd91dc3009b3aa43d1f0723d75d14d2ad40"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"af1d4e7074d66b148fbae47934c51080293ce7b5","unresolved":false,"context_lines":[{"line_number":737,"context_line":"                self._delete_share(share_name, protocol, fpg, vfs, fstore)"},{"line_number":738,"context_line":"                msg \u003d _LE(\u0027Exception during mount and copy from RO snapshot \u0027"},{"line_number":739,"context_line":"                          \u0027to RW share: %s\u0027)"},{"line_number":740,"context_line":"                LOG.error(msg, six.text_type(e))"},{"line_number":741,"context_line":"                raise"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_4671a0a7","line":740,"range":{"start_line":740,"start_character":30,"end_line":740,"end_character":47},"updated":"2016-08-01 02:41:15.000000000","message":"http://docs.openstack.org/developer/oslo.i18n/guidelines.html#avoid-forcing-the-translation-of-translatable-variables","commit_id":"d9a64dd91dc3009b3aa43d1f0723d75d14d2ad40"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"eeb558b0583d8528ee4732515c3f8267741e14ed","unresolved":false,"context_lines":[{"line_number":737,"context_line":"                self._delete_share(share_name, protocol, fpg, vfs, fstore)"},{"line_number":738,"context_line":"                msg \u003d _LE(\u0027Exception during mount and copy from RO snapshot \u0027"},{"line_number":739,"context_line":"                          \u0027to RW share: %s\u0027)"},{"line_number":740,"context_line":"                LOG.error(msg, six.text_type(e))"},{"line_number":741,"context_line":"                raise"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_07dbb41c","line":740,"range":{"start_line":740,"start_character":30,"end_line":740,"end_character":47},"in_reply_to":"bacf61ea_4671a0a7","updated":"2016-08-02 23:55:01.000000000","message":"Done","commit_id":"d9a64dd91dc3009b3aa43d1f0723d75d14d2ad40"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"af1d4e7074d66b148fbae47934c51080293ce7b5","unresolved":false,"context_lines":[{"line_number":917,"context_line":"                protocol, vfs, share, **setfshare_kwargs)"},{"line_number":918,"context_line":"        except Exception as err:"},{"line_number":919,"context_line":"            message \u003d (_(\"There was an error adding permissions: \""},{"line_number":920,"context_line":"                         \"%s.\") % six.text_type(err))"},{"line_number":921,"context_line":"            raise exception.ShareMountException(reason\u003dmessage)"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"    def _revoke_admin_smb_access(self, protocol, fpg, vfs, fstore, comment,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_86aef8e3","line":920,"range":{"start_line":920,"start_character":33,"end_line":920,"end_character":52},"updated":"2016-08-01 02:41:15.000000000","message":"http://docs.openstack.org/developer/oslo.i18n/guidelines.html#avoid-forcing-the-translation-of-translatable-variables","commit_id":"d9a64dd91dc3009b3aa43d1f0723d75d14d2ad40"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"eeb558b0583d8528ee4732515c3f8267741e14ed","unresolved":false,"context_lines":[{"line_number":917,"context_line":"                protocol, vfs, share, **setfshare_kwargs)"},{"line_number":918,"context_line":"        except Exception as err:"},{"line_number":919,"context_line":"            message \u003d (_(\"There was an error adding permissions: \""},{"line_number":920,"context_line":"                         \"%s.\") % six.text_type(err))"},{"line_number":921,"context_line":"            raise exception.ShareMountException(reason\u003dmessage)"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"    def _revoke_admin_smb_access(self, protocol, fpg, vfs, fstore, comment,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_0d58f555","line":920,"range":{"start_line":920,"start_character":33,"end_line":920,"end_character":52},"in_reply_to":"bacf61ea_86aef8e3","updated":"2016-08-02 23:55:01.000000000","message":"Done. This also wasn\u0027t a mount exception.","commit_id":"d9a64dd91dc3009b3aa43d1f0723d75d14d2ad40"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"af1d4e7074d66b148fbae47934c51080293ce7b5","unresolved":false,"context_lines":[{"line_number":934,"context_line":"                protocol, vfs, share, **setfshare_kwargs)"},{"line_number":935,"context_line":"        except Exception as err:"},{"line_number":936,"context_line":"            message \u003d (_(\"There was an error revoking permissions: \""},{"line_number":937,"context_line":"                         \"%s.\") % six.text_type(err))"},{"line_number":938,"context_line":"            raise exception.ShareMountException(reason\u003dmessage)"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"    def _create_super_share(self, protocol, fpg, vfs, fstore, readonly\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_e6b7f437","line":937,"range":{"start_line":937,"start_character":34,"end_line":937,"end_character":52},"updated":"2016-08-01 02:41:15.000000000","message":"http://docs.openstack.org/developer/oslo.i18n/guidelines.html#avoid-forcing-the-translation-of-translatable-variables","commit_id":"d9a64dd91dc3009b3aa43d1f0723d75d14d2ad40"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"eeb558b0583d8528ee4732515c3f8267741e14ed","unresolved":false,"context_lines":[{"line_number":934,"context_line":"                protocol, vfs, share, **setfshare_kwargs)"},{"line_number":935,"context_line":"        except Exception as err:"},{"line_number":936,"context_line":"            message \u003d (_(\"There was an error revoking permissions: \""},{"line_number":937,"context_line":"                         \"%s.\") % six.text_type(err))"},{"line_number":938,"context_line":"            raise exception.ShareMountException(reason\u003dmessage)"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"    def _create_super_share(self, protocol, fpg, vfs, fstore, readonly\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_78e16dfe","line":937,"range":{"start_line":937,"start_character":34,"end_line":937,"end_character":52},"in_reply_to":"bacf61ea_e6b7f437","updated":"2016-08-02 23:55:01.000000000","message":"Done.  Same.","commit_id":"d9a64dd91dc3009b3aa43d1f0723d75d14d2ad40"}]}
