)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Implement share revert to snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds the ability for Manila to revert a"},{"line_number":10,"context_line":"share to the latest available snapshot. Also fix a"},{"line_number":11,"context_line":"minor issue that prevented unit tests from running"},{"line_number":12,"context_line":"in manager.py in PyCharm."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint manila-share-revert-to-snapshot"},{"line_number":15,"context_line":"Change-Id: Id497e13070e0003db2db951526a52de6c2182cca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fad55976_595c1aed","line":12,"range":{"start_line":10,"start_character":40,"end_line":12,"end_character":25},"updated":"2016-07-17 03:26:10.000000000","message":"Could you please split this change, since this is unrelated to the feature..","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Implement share revert to snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds the ability for Manila to revert a"},{"line_number":10,"context_line":"share to the latest available snapshot. Also fix a"},{"line_number":11,"context_line":"minor issue that prevented unit tests from running"},{"line_number":12,"context_line":"in manager.py in PyCharm."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint manila-share-revert-to-snapshot"},{"line_number":15,"context_line":"Change-Id: Id497e13070e0003db2db951526a52de6c2182cca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_1499316f","line":12,"range":{"start_line":10,"start_character":40,"end_line":12,"end_character":25},"in_reply_to":"fad55976_595c1aed","updated":"2016-07-27 21:50:08.000000000","message":"No longer necessary in this patch (although it *was* related).","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a1acc1014f5e2fb86a4417cbfa8fc97b06e76e15","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds the ability for Manila to revert a"},{"line_number":10,"context_line":"share to the latest available snapshot."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint manila-share-revert-to-snapshot"},{"line_number":13,"context_line":"Change-Id: Id497e13070e0003db2db951526a52de6c2182cca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_0c5ba22f","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"updated":"2016-07-28 22:28:33.000000000","message":"APIImpact\n\nDocImpact","commit_id":"42d27856637161f8e92dfde6e2ca3a3d52b66aaa"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2a1d1375628ff413bd3b9caeb5ada3188915cb53","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds the ability for Manila to revert a"},{"line_number":10,"context_line":"share to the latest available snapshot."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint manila-share-revert-to-snapshot"},{"line_number":13,"context_line":"Change-Id: Id497e13070e0003db2db951526a52de6c2182cca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_3f1cc612","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"in_reply_to":"bacf61ea_0c5ba22f","updated":"2016-07-28 23:19:36.000000000","message":"Done","commit_id":"42d27856637161f8e92dfde6e2ca3a3d52b66aaa"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"b897abf4df9c21e22c3e1cdfefa358df7db26bf8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement share revert to snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds the ability for Manila to revert a"},{"line_number":10,"context_line":"share to the latest available snapshot."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9ad45d7e_cf7bb1bc","line":9,"range":{"start_line":9,"start_character":33,"end_line":9,"end_character":40},"updated":"2016-08-17 00:06:31.000000000","message":"nit: manila","commit_id":"5762ad3c724b8d8e13005723cccf9412e3b1c40a"}],"contrib/ci/post_test_hook.sh":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"# Capability \"revert_to_snapshot_support\""},{"line_number":85,"context_line":"CAPABILITY_REVERT_TO_SNAPSHOT_SUPPORT\u003d${CAPABILITY_REVERT_TO_SNAPSHOT_SUPPORT:-False}"},{"line_number":86,"context_line":"iniset $TEMPEST_CONFIG share capability_revert_to_snapshot_support $CAPABILITY_REVERT_TO_SNAPSHOT_SUPPORT"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"if [[ -z \"$MULTITENANCY_ENABLED\" ]]; then"},{"line_number":89,"context_line":"    # Define whether share drivers handle share servers or not."}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_eeea4a0e","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":105},"updated":"2017-01-06 01:38:58.000000000","message":"I understood ganso\u0027s comment here while trying to fix the migration env variable. \n\nhttps://review.openstack.org/#/c/414180/\n\nTwo things:\n\n* The iniset to Tempest config must be done towards the end of this file\n* No need to set the variable in each driver\u0027s section in this file, unless you want to change the default value.","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"# Capability \"revert_to_snapshot_support\""},{"line_number":85,"context_line":"CAPABILITY_REVERT_TO_SNAPSHOT_SUPPORT\u003d${CAPABILITY_REVERT_TO_SNAPSHOT_SUPPORT:-False}"},{"line_number":86,"context_line":"iniset $TEMPEST_CONFIG share capability_revert_to_snapshot_support $CAPABILITY_REVERT_TO_SNAPSHOT_SUPPORT"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"if [[ -z \"$MULTITENANCY_ENABLED\" ]]; then"},{"line_number":89,"context_line":"    # Define whether share drivers handle share servers or not."}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_1f24165e","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":105},"in_reply_to":"ba5201f7_eeea4a0e","updated":"2017-01-06 03:19:17.000000000","message":"Agreed, thanks for cleaning up this file in 414180.","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    iniset $TEMPEST_CONFIG auth use_dynamic_credentials True"},{"line_number":173,"context_line":"    iniset $TEMPEST_CONFIG share capability_snapshot_support True"},{"line_number":174,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":175,"context_line":"    iniset $TEMPEST_CONFIG share capability_revert_to_snapshot_support True"},{"line_number":176,"context_line":"    if ! grep $USERNAME_FOR_USER_RULES \"/etc/passwd\"; then"},{"line_number":177,"context_line":"        sudo useradd $USERNAME_FOR_USER_RULES"},{"line_number":178,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_cee2e62e","line":175,"range":{"start_line":175,"start_character":0,"end_line":175,"end_character":75},"updated":"2017-01-06 01:38:58.000000000","message":"please change to:\n\n CAPABILITY_REVERT_TO_SNAPSHOT_SUPPORT\u003dTrue\n\nafter line 167","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    iniset $TEMPEST_CONFIG auth use_dynamic_credentials True"},{"line_number":173,"context_line":"    iniset $TEMPEST_CONFIG share capability_snapshot_support True"},{"line_number":174,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":175,"context_line":"    iniset $TEMPEST_CONFIG share capability_revert_to_snapshot_support True"},{"line_number":176,"context_line":"    if ! grep $USERNAME_FOR_USER_RULES \"/etc/passwd\"; then"},{"line_number":177,"context_line":"        sudo useradd $USERNAME_FOR_USER_RULES"},{"line_number":178,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_c4a56547","line":175,"range":{"start_line":175,"start_character":0,"end_line":175,"end_character":75},"in_reply_to":"ba5201f7_cee2e62e","updated":"2017-01-06 03:19:17.000000000","message":"Done","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    iniset $TEMPEST_CONFIG share enable_ro_access_level_for_protocols \u0027nfs\u0027"},{"line_number":201,"context_line":"    iniset $TEMPEST_CONFIG share build_timeout 180"},{"line_number":202,"context_line":"    iniset $TEMPEST_CONFIG share share_creation_retry_number 0"},{"line_number":203,"context_line":"    iniset $TEMPEST_CONFIG share capability_snapshot_support True"},{"line_number":204,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":205,"context_line":"    iniset $TEMPEST_CONFIG share capability_revert_to_snapshot_support False"},{"line_number":206,"context_line":"    iniset $TEMPEST_CONFIG share capability_storage_protocol \u0027NFS\u0027"}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_8e4a9e24","line":203,"range":{"start_line":203,"start_character":0,"end_line":203,"end_character":65},"updated":"2017-01-06 01:38:58.000000000","message":"please remove","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    iniset $TEMPEST_CONFIG share enable_ro_access_level_for_protocols \u0027nfs\u0027"},{"line_number":201,"context_line":"    iniset $TEMPEST_CONFIG share build_timeout 180"},{"line_number":202,"context_line":"    iniset $TEMPEST_CONFIG share share_creation_retry_number 0"},{"line_number":203,"context_line":"    iniset $TEMPEST_CONFIG share capability_snapshot_support True"},{"line_number":204,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":205,"context_line":"    iniset $TEMPEST_CONFIG share capability_revert_to_snapshot_support False"},{"line_number":206,"context_line":"    iniset $TEMPEST_CONFIG share capability_storage_protocol \u0027NFS\u0027"}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_3f71daa8","line":203,"range":{"start_line":203,"start_character":0,"end_line":203,"end_character":65},"in_reply_to":"ba5201f7_8e4a9e24","updated":"2017-01-06 03:19:17.000000000","message":"Actually, I moved this line up to be with the now-removed following line, but I\u0027ll leave it where it was (and still is in 414180).","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    iniset $TEMPEST_CONFIG share build_timeout 180"},{"line_number":202,"context_line":"    iniset $TEMPEST_CONFIG share share_creation_retry_number 0"},{"line_number":203,"context_line":"    iniset $TEMPEST_CONFIG share capability_snapshot_support True"},{"line_number":204,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":205,"context_line":"    iniset $TEMPEST_CONFIG share capability_revert_to_snapshot_support False"},{"line_number":206,"context_line":"    iniset $TEMPEST_CONFIG share capability_storage_protocol \u0027NFS\u0027"},{"line_number":207,"context_line":"    iniset $TEMPEST_CONFIG share enable_protocols \u0027nfs\u0027"}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_0e65ceb3","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":83},"updated":"2017-01-06 01:38:58.000000000","message":"this will be removed in https://review.openstack.org/#/c/414180","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    iniset $TEMPEST_CONFIG share build_timeout 180"},{"line_number":202,"context_line":"    iniset $TEMPEST_CONFIG share share_creation_retry_number 0"},{"line_number":203,"context_line":"    iniset $TEMPEST_CONFIG share capability_snapshot_support True"},{"line_number":204,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":205,"context_line":"    iniset $TEMPEST_CONFIG share capability_revert_to_snapshot_support False"},{"line_number":206,"context_line":"    iniset $TEMPEST_CONFIG share capability_storage_protocol \u0027NFS\u0027"},{"line_number":207,"context_line":"    iniset $TEMPEST_CONFIG share enable_protocols \u0027nfs\u0027"}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_1ff17601","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":83},"in_reply_to":"ba5201f7_0e65ceb3","updated":"2017-01-06 03:19:17.000000000","message":"OK, I rebased on 414180.","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    iniset $TEMPEST_CONFIG share share_creation_retry_number 0"},{"line_number":203,"context_line":"    iniset $TEMPEST_CONFIG share capability_snapshot_support True"},{"line_number":204,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":205,"context_line":"    iniset $TEMPEST_CONFIG share capability_revert_to_snapshot_support False"},{"line_number":206,"context_line":"    iniset $TEMPEST_CONFIG share capability_storage_protocol \u0027NFS\u0027"},{"line_number":207,"context_line":"    iniset $TEMPEST_CONFIG share enable_protocols \u0027nfs\u0027"},{"line_number":208,"context_line":"    iniset $TEMPEST_CONFIG share suppress_errors_in_cleanup False"}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_ce5026d7","line":205,"range":{"start_line":205,"start_character":0,"end_line":205,"end_character":76},"updated":"2017-01-06 01:38:58.000000000","message":"please remove","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    iniset $TEMPEST_CONFIG share share_creation_retry_number 0"},{"line_number":203,"context_line":"    iniset $TEMPEST_CONFIG share capability_snapshot_support True"},{"line_number":204,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":205,"context_line":"    iniset $TEMPEST_CONFIG share capability_revert_to_snapshot_support False"},{"line_number":206,"context_line":"    iniset $TEMPEST_CONFIG share capability_storage_protocol \u0027NFS\u0027"},{"line_number":207,"context_line":"    iniset $TEMPEST_CONFIG share enable_protocols \u0027nfs\u0027"},{"line_number":208,"context_line":"    iniset $TEMPEST_CONFIG share suppress_errors_in_cleanup False"}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_5fdf7e68","line":205,"range":{"start_line":205,"start_character":0,"end_line":205,"end_character":76},"in_reply_to":"ba5201f7_ce5026d7","updated":"2017-01-06 03:19:17.000000000","message":"Done","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    iniset $TEMPEST_CONFIG share enable_ro_access_level_for_protocols \u0027nfs,cifs\u0027"},{"line_number":227,"context_line":"    iniset $TEMPEST_CONFIG share build_timeout 180"},{"line_number":228,"context_line":"    iniset $TEMPEST_CONFIG share share_creation_retry_number 0"},{"line_number":229,"context_line":"    iniset $TEMPEST_CONFIG share capability_snapshot_support True"},{"line_number":230,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":231,"context_line":"    iniset $TEMPEST_CONFIG share capability_revert_to_snapshot_support True"},{"line_number":232,"context_line":"    iniset $TEMPEST_CONFIG share capability_storage_protocol \u0027NFS_CIFS\u0027"}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_2e3ff287","line":229,"range":{"start_line":229,"start_character":0,"end_line":229,"end_character":65},"updated":"2017-01-06 01:38:58.000000000","message":"please remove","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    iniset $TEMPEST_CONFIG share enable_ro_access_level_for_protocols \u0027nfs,cifs\u0027"},{"line_number":227,"context_line":"    iniset $TEMPEST_CONFIG share build_timeout 180"},{"line_number":228,"context_line":"    iniset $TEMPEST_CONFIG share share_creation_retry_number 0"},{"line_number":229,"context_line":"    iniset $TEMPEST_CONFIG share capability_snapshot_support True"},{"line_number":230,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":231,"context_line":"    iniset $TEMPEST_CONFIG share capability_revert_to_snapshot_support True"},{"line_number":232,"context_line":"    iniset $TEMPEST_CONFIG share capability_storage_protocol \u0027NFS_CIFS\u0027"}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_1f56d6cd","line":229,"range":{"start_line":229,"start_character":0,"end_line":229,"end_character":65},"in_reply_to":"ba5201f7_2e3ff287","updated":"2017-01-06 03:19:17.000000000","message":"Why?  The dummy driver supports snapshots.  And why can\u0027t we have a CAPABILITY_SNAPSHOT_SUPPORT that is handled just like CAPABILITY_REVERT_TO_SNAPSHOT_SUPPORT?","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    iniset $TEMPEST_CONFIG share share_creation_retry_number 0"},{"line_number":229,"context_line":"    iniset $TEMPEST_CONFIG share capability_snapshot_support True"},{"line_number":230,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":231,"context_line":"    iniset $TEMPEST_CONFIG share capability_revert_to_snapshot_support True"},{"line_number":232,"context_line":"    iniset $TEMPEST_CONFIG share capability_storage_protocol \u0027NFS_CIFS\u0027"},{"line_number":233,"context_line":"    iniset $TEMPEST_CONFIG share enable_protocols \u0027nfs,cifs\u0027"},{"line_number":234,"context_line":"    iniset $TEMPEST_CONFIG share suppress_errors_in_cleanup False"}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_0e3eae8b","line":231,"range":{"start_line":231,"start_character":0,"end_line":231,"end_character":75},"updated":"2017-01-06 01:38:58.000000000","message":"please change to:\n CAPABILITY_REVERT_TO_SNAPSHOT_SUPPORT\u003dTrue\nafter line 217","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    iniset $TEMPEST_CONFIG share share_creation_retry_number 0"},{"line_number":229,"context_line":"    iniset $TEMPEST_CONFIG share capability_snapshot_support True"},{"line_number":230,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":231,"context_line":"    iniset $TEMPEST_CONFIG share capability_revert_to_snapshot_support True"},{"line_number":232,"context_line":"    iniset $TEMPEST_CONFIG share capability_storage_protocol \u0027NFS_CIFS\u0027"},{"line_number":233,"context_line":"    iniset $TEMPEST_CONFIG share enable_protocols \u0027nfs,cifs\u0027"},{"line_number":234,"context_line":"    iniset $TEMPEST_CONFIG share suppress_errors_in_cleanup False"}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_9f53a6e1","line":231,"range":{"start_line":231,"start_character":0,"end_line":231,"end_character":75},"in_reply_to":"ba5201f7_0e3eae8b","updated":"2017-01-06 03:19:17.000000000","message":"Done","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    iniset $TEMPEST_CONFIG share run_shrink_tests False"},{"line_number":247,"context_line":"    iniset $TEMPEST_CONFIG share run_snapshot_tests False"},{"line_number":248,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support False"},{"line_number":249,"context_line":"    iniset $TEMPEST_CONFIG share capability_revert_to_snapshot_support False"},{"line_number":250,"context_line":"    iniset $TEMPEST_CONFIG share capability_storage_protocol \u0027CIFS\u0027"},{"line_number":251,"context_line":"    iniset $TEMPEST_CONFIG share enable_protocols \u0027cifs\u0027"},{"line_number":252,"context_line":"    iniset $TEMPEST_CONFIG share enable_user_rules_for_protocols \u0027cifs\u0027"}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_4e5b56f6","line":249,"range":{"start_line":249,"start_character":0,"end_line":249,"end_character":76},"updated":"2017-01-06 01:38:58.000000000","message":"please remove","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    iniset $TEMPEST_CONFIG share run_shrink_tests False"},{"line_number":247,"context_line":"    iniset $TEMPEST_CONFIG share run_snapshot_tests False"},{"line_number":248,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support False"},{"line_number":249,"context_line":"    iniset $TEMPEST_CONFIG share capability_revert_to_snapshot_support False"},{"line_number":250,"context_line":"    iniset $TEMPEST_CONFIG share capability_storage_protocol \u0027CIFS\u0027"},{"line_number":251,"context_line":"    iniset $TEMPEST_CONFIG share enable_protocols \u0027cifs\u0027"},{"line_number":252,"context_line":"    iniset $TEMPEST_CONFIG share enable_user_rules_for_protocols \u0027cifs\u0027"}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_1f0df6e7","line":249,"range":{"start_line":249,"start_character":0,"end_line":249,"end_character":76},"in_reply_to":"ba5201f7_4e5b56f6","updated":"2017-01-06 03:19:17.000000000","message":"Done","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"# Enable manage/unmanage snapshot tests"},{"line_number":263,"context_line":"iniset $TEMPEST_CONFIG share run_manage_unmanage_snapshot_tests $RUN_MANILA_MANAGE_SNAPSHOT_TESTS"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"iniset $TEMPEST_CONFIG validation ip_version_for_ssh 4"},{"line_number":266,"context_line":"iniset $TEMPEST_CONFIG validation network_for_ssh ${PRIVATE_NETWORK_NAME:-\"private\"}"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_4e12760a","line":264,"range":{"start_line":264,"start_character":0,"end_line":264,"end_character":0},"updated":"2017-01-06 01:38:58.000000000","message":"the iniset can be done here.","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"# Enable manage/unmanage snapshot tests"},{"line_number":263,"context_line":"iniset $TEMPEST_CONFIG share run_manage_unmanage_snapshot_tests $RUN_MANILA_MANAGE_SNAPSHOT_TESTS"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"iniset $TEMPEST_CONFIG validation ip_version_for_ssh 4"},{"line_number":266,"context_line":"iniset $TEMPEST_CONFIG validation network_for_ssh ${PRIVATE_NETWORK_NAME:-\"private\"}"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba5201f7_ff0bd2d3","line":264,"range":{"start_line":264,"start_character":0,"end_line":264,"end_character":0},"in_reply_to":"ba5201f7_4e12760a","updated":"2017-01-06 03:19:17.000000000","message":"Done","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"}],"contrib/ci/pre_test_hook.sh":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"c8ae61c47d81c76da282fa354fdb2d852aeca96d","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"lvm\" ]]; then"},{"line_number":150,"context_line":"    MANILA_SERVICE_IMAGE_ENABLED\u003dTrue"},{"line_number":151,"context_line":"    DEFAULT_EXTRA_SPECS\u003d\"\u0027snapshot_support\u003dTrue create_share_from_snapshot_support\u003dTrue revert_to_snapshot_support\u003dTrue\u0027\""},{"line_number":152,"context_line":"    save_configuration \"SHARE_DRIVER\" \"manila.share.drivers.lvm.LVMShareDriver\""},{"line_number":153,"context_line":"    save_configuration \"SHARE_BACKING_FILE_SIZE\" \"32000M\""},{"line_number":154,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"zfsonlinux\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":26,"id":"ba5201f7_7729d436","line":151,"updated":"2017-01-05 20:02:20.000000000","message":"Shouldn\u0027t we also do this over-ride for dummy driver?","commit_id":"98291366fb1801a7f38db80854ed60fcca16a88f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"24934911b7c6daf053ac1a3b6dfd5f23dd6645a8","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"lvm\" ]]; then"},{"line_number":150,"context_line":"    MANILA_SERVICE_IMAGE_ENABLED\u003dTrue"},{"line_number":151,"context_line":"    DEFAULT_EXTRA_SPECS\u003d\"\u0027snapshot_support\u003dTrue create_share_from_snapshot_support\u003dTrue revert_to_snapshot_support\u003dTrue\u0027\""},{"line_number":152,"context_line":"    save_configuration \"SHARE_DRIVER\" \"manila.share.drivers.lvm.LVMShareDriver\""},{"line_number":153,"context_line":"    save_configuration \"SHARE_BACKING_FILE_SIZE\" \"32000M\""},{"line_number":154,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"zfsonlinux\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":26,"id":"ba5201f7_8bd0d0f7","line":151,"in_reply_to":"ba5201f7_7729d436","updated":"2017-01-06 00:35:11.000000000","message":"Yes!  Thanks, Tom.","commit_id":"98291366fb1801a7f38db80854ed60fcca16a88f"}],"doc/source/devref/capabilities_and_extra_specs.rst":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"de7855b28bc366410a49c24fe23251a9085cd7d7","unresolved":false,"context_lines":[{"line_number":147,"context_line":"  Mitaka."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"* `revert_to_snapshot` - indicates that a driver is capable of reverting a"},{"line_number":150,"context_line":"  share in place to its most recent snapshot.  This capability defaults to"},{"line_number":151,"context_line":"  False."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Reporting Capabilities"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_51197178","line":150,"range":{"start_line":150,"start_character":45,"end_line":150,"end_character":47},"updated":"2016-07-30 04:48:07.000000000","message":"Could have only one space between two sentences.","commit_id":"ff0c6090fd4e144151bf43493bf7efc92c07937a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"c1e60a687f3d27db989e2900bbdbd6efc2ad2620","unresolved":false,"context_lines":[{"line_number":147,"context_line":"  Mitaka."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"* `revert_to_snapshot` - indicates that a driver is capable of reverting a"},{"line_number":150,"context_line":"  share in place to its most recent snapshot.  This capability defaults to"},{"line_number":151,"context_line":"  False."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Reporting Capabilities"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_168c07d9","line":150,"range":{"start_line":150,"start_character":45,"end_line":150,"end_character":47},"in_reply_to":"bacf61ea_51197178","updated":"2016-07-30 17:36:37.000000000","message":"Done","commit_id":"ff0c6090fd4e144151bf43493bf7efc92c07937a"}],"doc/source/devref/share_back_ends_feature_support_mapping.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":158,"context_line":"|                Tegile                  |        \\-        |        \\-       |        \\-        |"},{"line_number":159,"context_line":"+----------------------------------------+------------------+-----------------+------------------+"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Mapping of share drivers and common capabilities"},{"line_number":162,"context_line":"------------------------------------------------"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fad55976_663fb9d6","line":161,"range":{"start_line":161,"start_character":29,"end_line":161,"end_character":48},"updated":"2016-07-17 03:26:10.000000000","message":"Need to add the capability here? Is that part different from the spec? http://specs.openstack.org/openstack/manila-specs/specs/newton/manila-share-revert-to-snapshot.html#driver-impact","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":158,"context_line":"|                Tegile                  |        \\-        |        \\-       |        \\-        |"},{"line_number":159,"context_line":"+----------------------------------------+------------------+-----------------+------------------+"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Mapping of share drivers and common capabilities"},{"line_number":162,"context_line":"------------------------------------------------"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bacf61ea_3a57ff03","line":161,"range":{"start_line":161,"start_character":29,"end_line":161,"end_character":48},"in_reply_to":"fad55976_663fb9d6","updated":"2016-07-27 21:50:08.000000000","message":"Thanks, this was clearly an omission.  Fixed in various places as appropriate.","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"de7855b28bc366410a49c24fe23251a9085cd7d7","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"+----------------------------------------+-----------------------+-----------------------+--------------+--------------+------------------------+----------------------------+--------------------------+--------------------------+"},{"line_number":34,"context_line":"|               Driver name              | create delete share   | manage unmanage share | extend share | shrink share | create delete snapshot | create share from snapshot | manage unmanage snapshot | revert share to snapshot |"},{"line_number":35,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+--------------------------+"},{"line_number":36,"context_line":"|               ZFSonLinux               |           M           |           N           |       M      |       M      |            M           |              M             |            N             |            \\-            |"},{"line_number":37,"context_line":"+----------------------------------------+-----------------------+-----------------------+--------------+--------------+------------------------+----------------------------+--------------------------+--------------------------+"},{"line_number":38,"context_line":"|      Generic (Cinder as back-end)      |           J           |           K           |       L      |       L      |            J           |              J             |            M             |            \\-            |"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_5147b14a","line":35,"range":{"start_line":35,"start_character":201,"end_line":35,"end_character":227},"updated":"2016-07-30 04:48:07.000000000","message":"use \u003d\u003d\u003d\u003d\u003d instead of  ------ ?","commit_id":"ff0c6090fd4e144151bf43493bf7efc92c07937a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"c1e60a687f3d27db989e2900bbdbd6efc2ad2620","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"+----------------------------------------+-----------------------+-----------------------+--------------+--------------+------------------------+----------------------------+--------------------------+--------------------------+"},{"line_number":34,"context_line":"|               Driver name              | create delete share   | manage unmanage share | extend share | shrink share | create delete snapshot | create share from snapshot | manage unmanage snapshot | revert share to snapshot |"},{"line_number":35,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+--------------------------+"},{"line_number":36,"context_line":"|               ZFSonLinux               |           M           |           N           |       M      |       M      |            M           |              M             |            N             |            \\-            |"},{"line_number":37,"context_line":"+----------------------------------------+-----------------------+-----------------------+--------------+--------------+------------------------+----------------------------+--------------------------+--------------------------+"},{"line_number":38,"context_line":"|      Generic (Cinder as back-end)      |           J           |           K           |       L      |       L      |            J           |              J             |            M             |            \\-            |"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_16b36799","line":35,"range":{"start_line":35,"start_character":201,"end_line":35,"end_character":227},"in_reply_to":"bacf61ea_5147b14a","updated":"2016-07-30 17:36:37.000000000","message":"Done","commit_id":"ff0c6090fd4e144151bf43493bf7efc92c07937a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bc9a8e8df02a9981a72d2434c61fd9582bebcd63","unresolved":false,"context_lines":[{"line_number":61,"context_line":"+----------------------------------------+-----------------------+-----------------------+--------------+--------------+------------------------+----------------------------+--------------------------+--------------------+"},{"line_number":62,"context_line":"|                 Huawei                 |           K           |           L           |       L      |       L      |            K           |              M             |            \\-            |          \\-        |"},{"line_number":63,"context_line":"+----------------------------------------+-----------------------+-----------------------+--------------+--------------+------------------------+----------------------------+--------------------------+--------------------+"},{"line_number":64,"context_line":"|                IBM GPFS                |           K           |          \\-           |       L      |      \\-      |            K           |              K             |            \\-            |          \\-        |"},{"line_number":65,"context_line":"+----------------------------------------+-----------------------+-----------------------+--------------+--------------+------------------------+----------------------------+--------------------------+--------------------+"},{"line_number":66,"context_line":"|                  LVM                   |           M           |          \\-           |       M      |      \\-      |            M           |              M             |            \\-            |          O         |"},{"line_number":67,"context_line":"+----------------------------------------+-----------------------+-----------------------+--------------+--------------+------------------------+----------------------------+--------------------------+--------------------+"}],"source_content_type":"text/x-rst","patch_set":33,"id":"ba5201f7_0f2f08a2","line":64,"range":{"start_line":64,"start_character":76,"end_line":64,"end_character":78},"updated":"2017-01-10 12:13:12.000000000","message":"unrelated change?","commit_id":"937ecfef267642fc2bca144d026ed7697e725362"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"94378d3ab02fda410d5ee617e92ee32f51344471","unresolved":false,"context_lines":[{"line_number":84,"context_line":"             spec. Also made the \u0027snapshot_support\u0027 extra spec optional."},{"line_number":85,"context_line":"    * 2.25 - Added quota-show detail API."},{"line_number":86,"context_line":"    * 2.26 - Removed \u0027nova_net_id\u0027 parameter from share_network API."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    * 2.27 - Added share revert to snapshot API."},{"line_number":89,"context_line":"\"\"\""},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"7a3c09a3_ffc82b57","line":87,"updated":"2017-01-17 22:32:18.000000000","message":"nit: we don\u0027t need this blank line here.","commit_id":"d4a379d0836470a64d79cd28190382eecb1f5c71"}],"manila/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":123,"context_line":"----"},{"line_number":124,"context_line":"  Added share revert to snapshot. This API reverts a share to the specified"},{"line_number":125,"context_line":"  snapshot. The share is reverted in place, and the snapshot must be the most"},{"line_number":126,"context_line":"  recent one taken to manila."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fad55976_a621b1b6","line":126,"range":{"start_line":126,"start_character":13,"end_line":126,"end_character":18},"updated":"2016-07-17 03:26:10.000000000","message":"known, or taken through","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":123,"context_line":"----"},{"line_number":124,"context_line":"  Added share revert to snapshot. This API reverts a share to the specified"},{"line_number":125,"context_line":"  snapshot. The share is reverted in place, and the snapshot must be the most"},{"line_number":126,"context_line":"  recent one taken to manila."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bacf61ea_3a837fce","line":126,"range":{"start_line":126,"start_character":13,"end_line":126,"end_character":18},"in_reply_to":"fad55976_a621b1b6","updated":"2016-07-27 21:50:08.000000000","message":"Done","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"}],"manila/api/v1/shares.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"94378d3ab02fda410d5ee617e92ee32f51344471","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                msg \u003d (_(\"A new share may not be created from snapshot \u0027%s\u0027, \""},{"line_number":271,"context_line":"                         \"because the snapshot\u0027s parent share does not have \""},{"line_number":272,"context_line":"                         \"that capability.\")"},{"line_number":273,"context_line":"                       % snapshot_id)"},{"line_number":274,"context_line":"                LOG.error(msg)"},{"line_number":275,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"7a3c09a3_7f0a7b8b","line":273,"updated":"2017-01-17 22:32:18.000000000","message":"Thank you.","commit_id":"d4a379d0836470a64d79cd28190382eecb1f5c71"}],"manila/api/v2/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @wsgi.Controller.authorize(\u0027revert_to_snapshot\u0027)"},{"line_number":49,"context_line":"    def _revert(self, req, id, body\u003dNone):"},{"line_number":50,"context_line":"        \"\"\"Revert a share to the a snapshot.\"\"\""},{"line_number":51,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":52,"context_line":"        revert_data \u003d self._validate_revert_parameters(context, body)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_4619d587","line":50,"range":{"start_line":50,"start_character":29,"end_line":50,"end_character":32},"updated":"2016-07-17 03:26:10.000000000","message":"delete","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @wsgi.Controller.authorize(\u0027revert_to_snapshot\u0027)"},{"line_number":49,"context_line":"    def _revert(self, req, id, body\u003dNone):"},{"line_number":50,"context_line":"        \"\"\"Revert a share to the a snapshot.\"\"\""},{"line_number":51,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":52,"context_line":"        revert_data \u003d self._validate_revert_parameters(context, body)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_fa5f2773","line":50,"range":{"start_line":50,"start_character":29,"end_line":50,"end_character":32},"in_reply_to":"fad55976_4619d587","updated":"2016-07-27 21:50:08.000000000","message":"Done","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            # Ensure requested share \u0026 snapshot match."},{"line_number":62,"context_line":"            if share[\u0027id\u0027] !\u003d snapshot[\u0027share_id\u0027]:"},{"line_number":63,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"},{"line_number":64,"context_line":"                msg \u003d _(\u0027Share %(share_id)s does not contain snapshot \u0027"},{"line_number":65,"context_line":"                        \u0027%(snap_id)s.\u0027)"},{"line_number":66,"context_line":"                raise exc.HTTPUnprocessableEntity(explanation\u003dmsg % msg_args)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            # Ensure share status is \u0027available\u0027."},{"line_number":69,"context_line":"            if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_66169956","line":66,"range":{"start_line":64,"start_character":0,"end_line":66,"end_character":77},"updated":"2016-07-17 03:26:10.000000000","message":"This should be BadRequest 400.. Snapshot doesn\u0027t belong to the share","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            # Ensure requested share \u0026 snapshot match."},{"line_number":62,"context_line":"            if share[\u0027id\u0027] !\u003d snapshot[\u0027share_id\u0027]:"},{"line_number":63,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"},{"line_number":64,"context_line":"                msg \u003d _(\u0027Share %(share_id)s does not contain snapshot \u0027"},{"line_number":65,"context_line":"                        \u0027%(snap_id)s.\u0027)"},{"line_number":66,"context_line":"                raise exc.HTTPUnprocessableEntity(explanation\u003dmsg % msg_args)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            # Ensure share status is \u0027available\u0027."},{"line_number":69,"context_line":"            if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_3ad1bfce","line":66,"range":{"start_line":64,"start_character":0,"end_line":66,"end_character":77},"in_reply_to":"fad55976_66169956","updated":"2016-07-27 21:50:08.000000000","message":"Done","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                msg \u003d _(\u0027Share %(share_id)s does not contain snapshot \u0027"},{"line_number":65,"context_line":"                        \u0027%(snap_id)s.\u0027)"},{"line_number":66,"context_line":"                raise exc.HTTPUnprocessableEntity(explanation\u003dmsg % msg_args)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            # Ensure share status is \u0027available\u0027."},{"line_number":69,"context_line":"            if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE:"},{"line_number":70,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027state\u0027: share[\u0027status\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_1962a2ad","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":0},"updated":"2016-07-17 03:26:10.000000000","message":"Could you also check if the share is busy with any migration related \u0027task\u0027? Because you may have more than one share instance when that\u0027s happening..","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                msg \u003d _(\u0027Share %(share_id)s does not contain snapshot \u0027"},{"line_number":65,"context_line":"                        \u0027%(snap_id)s.\u0027)"},{"line_number":66,"context_line":"                raise exc.HTTPUnprocessableEntity(explanation\u003dmsg % msg_args)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            # Ensure share status is \u0027available\u0027."},{"line_number":69,"context_line":"            if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE:"},{"line_number":70,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027state\u0027: share[\u0027status\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_b4e5bea9","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":0},"in_reply_to":"fad55976_1962a2ad","updated":"2016-07-27 21:50:08.000000000","message":"Done","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE:"},{"line_number":70,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027state\u0027: share[\u0027status\u0027]}"},{"line_number":71,"context_line":"                msg \u003d _(\"Share %(share_id)s is in \u0027%(state)s\u0027 state, but it \""},{"line_number":72,"context_line":"                        \"must be in \u0027available\u0027 state to be reverted to an \""},{"line_number":73,"context_line":"                        \"earlier snapshot.\")"},{"line_number":74,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg % msg_args)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_a608912e","line":72,"range":{"start_line":72,"start_character":36,"end_line":72,"end_character":47},"updated":"2016-07-17 03:26:10.000000000","message":"%s .. to be substituted with constants.STATUS_AVAILABLE","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE:"},{"line_number":70,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027state\u0027: share[\u0027status\u0027]}"},{"line_number":71,"context_line":"                msg \u003d _(\"Share %(share_id)s is in \u0027%(state)s\u0027 state, but it \""},{"line_number":72,"context_line":"                        \"must be in \u0027available\u0027 state to be reverted to an \""},{"line_number":73,"context_line":"                        \"earlier snapshot.\")"},{"line_number":74,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg % msg_args)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_fabba773","line":72,"range":{"start_line":72,"start_character":36,"end_line":72,"end_character":47},"in_reply_to":"fad55976_a608912e","updated":"2016-07-27 21:50:08.000000000","message":"Done","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE:"},{"line_number":70,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027state\u0027: share[\u0027status\u0027]}"},{"line_number":71,"context_line":"                msg \u003d _(\"Share %(share_id)s is in \u0027%(state)s\u0027 state, but it \""},{"line_number":72,"context_line":"                        \"must be in \u0027available\u0027 state to be reverted to an \""},{"line_number":73,"context_line":"                        \"earlier snapshot.\")"},{"line_number":74,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg % msg_args)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"            # Ensure snapshot status is \u0027available\u0027."}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_e602890a","line":73,"range":{"start_line":72,"start_character":69,"end_line":73,"end_character":41},"updated":"2016-07-17 03:26:10.000000000","message":"nit: to a snapshot?","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            if share[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE:"},{"line_number":70,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027state\u0027: share[\u0027status\u0027]}"},{"line_number":71,"context_line":"                msg \u003d _(\"Share %(share_id)s is in \u0027%(state)s\u0027 state, but it \""},{"line_number":72,"context_line":"                        \"must be in \u0027available\u0027 state to be reverted to an \""},{"line_number":73,"context_line":"                        \"earlier snapshot.\")"},{"line_number":74,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg % msg_args)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"            # Ensure snapshot status is \u0027available\u0027."}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_dac063e3","line":73,"range":{"start_line":72,"start_character":69,"end_line":73,"end_character":41},"in_reply_to":"fad55976_e602890a","updated":"2016-07-27 21:50:08.000000000","message":"Done","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                    \u0027state\u0027: snapshot[\u0027status\u0027],"},{"line_number":81,"context_line":"                }"},{"line_number":82,"context_line":"                msg \u003d _(\"Snapshot %(snap_id)s is in \u0027%(state)s\u0027 state, but it \""},{"line_number":83,"context_line":"                        \"must be in \u0027available\u0027 state to be restored.\")"},{"line_number":84,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg % msg_args)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            # Ensure the snapshot is the most recent one."}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_39004601","line":83,"range":{"start_line":83,"start_character":37,"end_line":83,"end_character":46},"updated":"2016-07-17 03:26:10.000000000","message":"same","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                    \u0027state\u0027: snapshot[\u0027status\u0027],"},{"line_number":81,"context_line":"                }"},{"line_number":82,"context_line":"                msg \u003d _(\"Snapshot %(snap_id)s is in \u0027%(state)s\u0027 state, but it \""},{"line_number":83,"context_line":"                        \"must be in \u0027available\u0027 state to be restored.\")"},{"line_number":84,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg % msg_args)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            # Ensure the snapshot is the most recent one."}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_3ab6df8a","line":83,"range":{"start_line":83,"start_character":37,"end_line":83,"end_character":46},"in_reply_to":"fad55976_39004601","updated":"2016-07-27 21:50:08.000000000","message":"Done","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"112e7e50d4f73db065cd8825c3fea2b2000c9d61","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            snapshot \u003d self.share_api.get_snapshot(context, snapshot_id)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"            # Ensure requested share \u0026 snapshot match."},{"line_number":62,"context_line":"            if share[\u0027id\u0027] !\u003d snapshot[\u0027share_id\u0027]:"},{"line_number":63,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"},{"line_number":64,"context_line":"                msg \u003d _(\u0027Share %(share_id)s does not contain snapshot \u0027"},{"line_number":65,"context_line":"                        \u0027%(snap_id)s.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_7eb5d5cb","line":62,"range":{"start_line":62,"start_character":15,"end_line":62,"end_character":26},"updated":"2016-07-28 06:49:13.000000000","message":"could directly use share_id","commit_id":"81bf37066181c7946d823c8d271514c709d5142f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4401aa4d480139466a3dd7d83b1aa8cd08203654","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            snapshot \u003d self.share_api.get_snapshot(context, snapshot_id)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"            # Ensure requested share \u0026 snapshot match."},{"line_number":62,"context_line":"            if share[\u0027id\u0027] !\u003d snapshot[\u0027share_id\u0027]:"},{"line_number":63,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"},{"line_number":64,"context_line":"                msg \u003d _(\u0027Share %(share_id)s does not contain snapshot \u0027"},{"line_number":65,"context_line":"                        \u0027%(snap_id)s.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_f7e7f8e1","line":62,"range":{"start_line":62,"start_character":15,"end_line":62,"end_character":26},"in_reply_to":"bacf61ea_7eb5d5cb","updated":"2016-07-28 21:48:03.000000000","message":"I could, but I like the symmetry of comparing fields of the two objects I just retrieved.","commit_id":"81bf37066181c7946d823c8d271514c709d5142f"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"112e7e50d4f73db065cd8825c3fea2b2000c9d61","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg % msg_args)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"            # Ensure a long-running task isn\u0027t active on the share"},{"line_number":92,"context_line":"            if share[\u0027task_state\u0027] in constants.BUSY_TASK_STATES:"},{"line_number":93,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id}"},{"line_number":94,"context_line":"                msg \u003d _(\"Share %(share_id)s may not be reverted while it has \""},{"line_number":95,"context_line":"                        \"an active task.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_339a7615","line":92,"updated":"2016-07-28 06:49:13.000000000","message":"I think this check could be moved to share_api.revert_to_snapshot implementation and use _check_is_share_busy method in share_api.","commit_id":"81bf37066181c7946d823c8d271514c709d5142f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4401aa4d480139466a3dd7d83b1aa8cd08203654","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg % msg_args)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"            # Ensure a long-running task isn\u0027t active on the share"},{"line_number":92,"context_line":"            if share[\u0027task_state\u0027] in constants.BUSY_TASK_STATES:"},{"line_number":93,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id}"},{"line_number":94,"context_line":"                msg \u003d _(\"Share %(share_id)s may not be reverted while it has \""},{"line_number":95,"context_line":"                        \"an active task.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_37035044","line":92,"in_reply_to":"bacf61ea_339a7615","updated":"2016-07-28 21:48:03.000000000","message":"That\u0027s true, although all the other state checking is here, and I like to keep the checks in one place.  I\u0027m curious what other reviewers think about this suggestion.","commit_id":"81bf37066181c7946d823c8d271514c709d5142f"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"112e7e50d4f73db065cd8825c3fea2b2000c9d61","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg % msg_args)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"            # Ensure the snapshot is the most recent one."},{"line_number":99,"context_line":"            latest_snapshot \u003d self.share_api.get_latest_snapshot_for_share("},{"line_number":100,"context_line":"                context, share_id)"},{"line_number":101,"context_line":"            if latest_snapshot[\u0027id\u0027] !\u003d snapshot_id:"},{"line_number":102,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_3e8d1d32","line":99,"updated":"2016-07-28 06:49:13.000000000","message":"Why restrict snapshot must be the latest one? Since a snapshot id is passed in, why not use this snapshot as the reverting source?","commit_id":"81bf37066181c7946d823c8d271514c709d5142f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4401aa4d480139466a3dd7d83b1aa8cd08203654","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg % msg_args)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"            # Ensure the snapshot is the most recent one."},{"line_number":99,"context_line":"            latest_snapshot \u003d self.share_api.get_latest_snapshot_for_share("},{"line_number":100,"context_line":"                context, share_id)"},{"line_number":101,"context_line":"            if latest_snapshot[\u0027id\u0027] !\u003d snapshot_id:"},{"line_number":102,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_0760b7cd","line":99,"in_reply_to":"bacf61ea_3e8d1d32","updated":"2016-07-28 21:48:03.000000000","message":"Read the spec.\n\nhttps://review.openstack.org/#/c/315695/","commit_id":"81bf37066181c7946d823c8d271514c709d5142f"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"112e7e50d4f73db065cd8825c3fea2b2000c9d61","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                context, share_id)"},{"line_number":101,"context_line":"            if latest_snapshot[\u0027id\u0027] !\u003d snapshot_id:"},{"line_number":102,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"},{"line_number":103,"context_line":"                msg \u003d _(\"Snapshot \u0027%(snap_id)s\u0027 may not be restored because \""},{"line_number":104,"context_line":"                        \"it is not the most recent snapshot of share \""},{"line_number":105,"context_line":"                        \"%(share_id)s.\")"},{"line_number":106,"context_line":"                raise exc.HTTPForbidden(explanation\u003dmsg % msg_args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_3e94fd35","line":103,"range":{"start_line":103,"start_character":48,"end_line":103,"end_character":51},"updated":"2016-07-28 06:49:13.000000000","message":"can","commit_id":"81bf37066181c7946d823c8d271514c709d5142f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4401aa4d480139466a3dd7d83b1aa8cd08203654","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                context, share_id)"},{"line_number":101,"context_line":"            if latest_snapshot[\u0027id\u0027] !\u003d snapshot_id:"},{"line_number":102,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"},{"line_number":103,"context_line":"                msg \u003d _(\"Snapshot \u0027%(snap_id)s\u0027 may not be restored because \""},{"line_number":104,"context_line":"                        \"it is not the most recent snapshot of share \""},{"line_number":105,"context_line":"                        \"%(share_id)s.\")"},{"line_number":106,"context_line":"                raise exc.HTTPForbidden(explanation\u003dmsg % msg_args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_4752af14","line":103,"range":{"start_line":103,"start_character":48,"end_line":103,"end_character":51},"in_reply_to":"bacf61ea_3e94fd35","updated":"2016-07-28 21:48:03.000000000","message":"I prefer the more polite \u0026 formal language.\n\nhttp://grammarist.com/usage/can-vs-may/","commit_id":"81bf37066181c7946d823c8d271514c709d5142f"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"112e7e50d4f73db065cd8825c3fea2b2000c9d61","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        except exception.ShareNotFound as e:"},{"line_number":114,"context_line":"            raise exc.HTTPNotFound(explanation\u003dsix.text_type(e))"},{"line_number":115,"context_line":"        except exception.ShareSnapshotNotFound as e:"},{"line_number":116,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dsix.text_type(e))"},{"line_number":117,"context_line":"        except exception.ShareSizeExceedsAvailableQuota as e:"},{"line_number":118,"context_line":"            raise exc.HTTPForbidden(explanation\u003dsix.text_type(e))"},{"line_number":119,"context_line":"        except exception.ReplicationException as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_fe46e5bd","line":116,"range":{"start_line":116,"start_character":22,"end_line":116,"end_character":36},"updated":"2016-07-28 06:49:13.000000000","message":"better use HTTPNotFound","commit_id":"81bf37066181c7946d823c8d271514c709d5142f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4401aa4d480139466a3dd7d83b1aa8cd08203654","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        except exception.ShareNotFound as e:"},{"line_number":114,"context_line":"            raise exc.HTTPNotFound(explanation\u003dsix.text_type(e))"},{"line_number":115,"context_line":"        except exception.ShareSnapshotNotFound as e:"},{"line_number":116,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dsix.text_type(e))"},{"line_number":117,"context_line":"        except exception.ShareSizeExceedsAvailableQuota as e:"},{"line_number":118,"context_line":"            raise exc.HTTPForbidden(explanation\u003dsix.text_type(e))"},{"line_number":119,"context_line":"        except exception.ReplicationException as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_2704dbbe","line":116,"range":{"start_line":116,"start_character":22,"end_line":116,"end_character":36},"in_reply_to":"bacf61ea_fe46e5bd","updated":"2016-07-28 21:48:03.000000000","message":"-1\n\nRead the spec.","commit_id":"81bf37066181c7946d823c8d271514c709d5142f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a1acc1014f5e2fb86a4417cbfa8fc97b06e76e15","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg % msg_args)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"            # Ensure a long-running task isn\u0027t active on the share"},{"line_number":92,"context_line":"            if share[\u0027task_state\u0027] in constants.BUSY_TASK_STATES:"},{"line_number":93,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id}"},{"line_number":94,"context_line":"                msg \u003d _(\"Share %(share_id)s may not be reverted while it has \""},{"line_number":95,"context_line":"                        \"an active task.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_8c72f247","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":64},"updated":"2016-07-28 22:28:33.000000000","message":"if share.is_busy:","commit_id":"42d27856637161f8e92dfde6e2ca3a3d52b66aaa"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2a1d1375628ff413bd3b9caeb5ada3188915cb53","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg % msg_args)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"            # Ensure a long-running task isn\u0027t active on the share"},{"line_number":92,"context_line":"            if share[\u0027task_state\u0027] in constants.BUSY_TASK_STATES:"},{"line_number":93,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id}"},{"line_number":94,"context_line":"                msg \u003d _(\"Share %(share_id)s may not be reverted while it has \""},{"line_number":95,"context_line":"                        \"an active task.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_a2e89d11","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":64},"in_reply_to":"bacf61ea_8c72f247","updated":"2016-07-28 23:19:36.000000000","message":"Done","commit_id":"42d27856637161f8e92dfde6e2ca3a3d52b66aaa"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"aef1d1cd61005b0f88f8a04d0522c55bf23ee268","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            # Ensure the snapshot is the most recent one."},{"line_number":99,"context_line":"            latest_snapshot \u003d self.share_api.get_latest_snapshot_for_share("},{"line_number":100,"context_line":"                context, share_id)"},{"line_number":101,"context_line":"            if latest_snapshot[\u0027id\u0027] !\u003d snapshot_id:"},{"line_number":102,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"},{"line_number":103,"context_line":"                msg \u003d _(\"Snapshot \u0027%(snap_id)s\u0027 may not be restored because \""},{"line_number":104,"context_line":"                        \"it is not the most recent snapshot of share \""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_b1325b0e","line":101,"updated":"2016-07-31 16:59:04.000000000","message":"There should be a None check here.  The latest_snapshot could be None.  Even though you\u0027ve checked on line 59 that snapshot_id is valid, between then and now, the snapshot could be deleted.","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f699467c47f44c9a9dafada0924c5c708d5ca81f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            # Ensure the snapshot is the most recent one."},{"line_number":99,"context_line":"            latest_snapshot \u003d self.share_api.get_latest_snapshot_for_share("},{"line_number":100,"context_line":"                context, share_id)"},{"line_number":101,"context_line":"            if latest_snapshot[\u0027id\u0027] !\u003d snapshot_id:"},{"line_number":102,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"},{"line_number":103,"context_line":"                msg \u003d _(\"Snapshot \u0027%(snap_id)s\u0027 may not be restored because \""},{"line_number":104,"context_line":"                        \"it is not the most recent snapshot of share \""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_0f44b4b4","line":101,"in_reply_to":"bacf61ea_b1325b0e","updated":"2016-08-01 19:27:23.000000000","message":"Done","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"aef1d1cd61005b0f88f8a04d0522c55bf23ee268","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"},{"line_number":103,"context_line":"                msg \u003d _(\"Snapshot \u0027%(snap_id)s\u0027 may not be restored because \""},{"line_number":104,"context_line":"                        \"it is not the most recent snapshot of share \""},{"line_number":105,"context_line":"                        \"%(share_id)s.\")"},{"line_number":106,"context_line":"                raise exc.HTTPForbidden(explanation\u003dmsg % msg_args)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"            msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_31d30b06","line":105,"updated":"2016-07-31 16:59:04.000000000","message":"Since you already know the latest_snapshot, I suggest that you add a line in the message: \"Currently the latest snapshot is xxxx\".","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f699467c47f44c9a9dafada0924c5c708d5ca81f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"},{"line_number":103,"context_line":"                msg \u003d _(\"Snapshot \u0027%(snap_id)s\u0027 may not be restored because \""},{"line_number":104,"context_line":"                        \"it is not the most recent snapshot of share \""},{"line_number":105,"context_line":"                        \"%(share_id)s.\")"},{"line_number":106,"context_line":"                raise exc.HTTPForbidden(explanation\u003dmsg % msg_args)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"            msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_6f2e10fc","line":105,"in_reply_to":"bacf61ea_31d30b06","updated":"2016-08-01 19:27:23.000000000","message":"Done","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"aef1d1cd61005b0f88f8a04d0522c55bf23ee268","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        except exception.ShareNotFound as e:"},{"line_number":114,"context_line":"            raise exc.HTTPNotFound(explanation\u003dsix.text_type(e))"},{"line_number":115,"context_line":"        except exception.ShareSnapshotNotFound as e:"},{"line_number":116,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dsix.text_type(e))"},{"line_number":117,"context_line":"        except exception.ShareSizeExceedsAvailableQuota as e:"},{"line_number":118,"context_line":"            raise exc.HTTPForbidden(explanation\u003dsix.text_type(e))"},{"line_number":119,"context_line":"        except exception.ReplicationException as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_116c0734","line":116,"updated":"2016-07-31 16:59:04.000000000","message":"This should be HTTPNotFound as well.","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e1aa9a9905143dbb1c9b06e13a8744454883323d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        except exception.ShareNotFound as e:"},{"line_number":114,"context_line":"            raise exc.HTTPNotFound(explanation\u003dsix.text_type(e))"},{"line_number":115,"context_line":"        except exception.ShareSnapshotNotFound as e:"},{"line_number":116,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dsix.text_type(e))"},{"line_number":117,"context_line":"        except exception.ShareSizeExceedsAvailableQuota as e:"},{"line_number":118,"context_line":"            raise exc.HTTPForbidden(explanation\u003dsix.text_type(e))"},{"line_number":119,"context_line":"        except exception.ReplicationException as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_ef14ee4d","line":116,"in_reply_to":"bacf61ea_116c0734","updated":"2016-07-31 21:10:40.000000000","message":"Snapshot here is part of the body, HTTPNotFound would be appropriate if it were part of the URI..","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e1aa9a9905143dbb1c9b06e13a8744454883323d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    def _validate_revert_parameters(self, context, body):"},{"line_number":125,"context_line":"        if not (body and self.is_valid_body(body, \u0027revert\u0027)):"},{"line_number":126,"context_line":"            msg \u003d _(\"Revert entity not found in request body.\")"},{"line_number":127,"context_line":"            raise exc.HTTPUnprocessableEntity(explanation\u003dmsg)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        required_parameters \u003d (\u0027snapshot_id\u0027,)"},{"line_number":130,"context_line":"        data \u003d body[\u0027revert\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_4f0eda3b","line":127,"range":{"start_line":127,"start_character":22,"end_line":127,"end_character":45},"updated":"2016-07-31 21:10:40.000000000","message":"HTTPBadRequest","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f699467c47f44c9a9dafada0924c5c708d5ca81f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    def _validate_revert_parameters(self, context, body):"},{"line_number":125,"context_line":"        if not (body and self.is_valid_body(body, \u0027revert\u0027)):"},{"line_number":126,"context_line":"            msg \u003d _(\"Revert entity not found in request body.\")"},{"line_number":127,"context_line":"            raise exc.HTTPUnprocessableEntity(explanation\u003dmsg)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        required_parameters \u003d (\u0027snapshot_id\u0027,)"},{"line_number":130,"context_line":"        data \u003d body[\u0027revert\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_af82c8c5","line":127,"range":{"start_line":127,"start_character":22,"end_line":127,"end_character":45},"in_reply_to":"bacf61ea_4f0eda3b","updated":"2016-08-01 19:27:23.000000000","message":"Done","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e1aa9a9905143dbb1c9b06e13a8744454883323d","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        for parameter in required_parameters:"},{"line_number":133,"context_line":"            if parameter not in data:"},{"line_number":134,"context_line":"                msg \u003d _(\"Required parameter %s not found.\") % parameter"},{"line_number":135,"context_line":"                raise exc.HTTPUnprocessableEntity(explanation\u003dmsg)"},{"line_number":136,"context_line":"            if not data.get(parameter):"},{"line_number":137,"context_line":"                msg \u003d _(\"Required parameter %s is empty.\") % parameter"},{"line_number":138,"context_line":"                raise exc.HTTPUnprocessableEntity(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_2f0ba62b","line":135,"range":{"start_line":135,"start_character":26,"end_line":135,"end_character":49},"updated":"2016-07-31 21:10:40.000000000","message":"HTTPBadRequest","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f699467c47f44c9a9dafada0924c5c708d5ca81f","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        for parameter in required_parameters:"},{"line_number":133,"context_line":"            if parameter not in data:"},{"line_number":134,"context_line":"                msg \u003d _(\"Required parameter %s not found.\") % parameter"},{"line_number":135,"context_line":"                raise exc.HTTPUnprocessableEntity(explanation\u003dmsg)"},{"line_number":136,"context_line":"            if not data.get(parameter):"},{"line_number":137,"context_line":"                msg \u003d _(\"Required parameter %s is empty.\") % parameter"},{"line_number":138,"context_line":"                raise exc.HTTPUnprocessableEntity(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_8f8544d0","line":135,"range":{"start_line":135,"start_character":26,"end_line":135,"end_character":49},"in_reply_to":"bacf61ea_2f0ba62b","updated":"2016-08-01 19:27:23.000000000","message":"Done","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e1aa9a9905143dbb1c9b06e13a8744454883323d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                raise exc.HTTPUnprocessableEntity(explanation\u003dmsg)"},{"line_number":136,"context_line":"            if not data.get(parameter):"},{"line_number":137,"context_line":"                msg \u003d _(\"Required parameter %s is empty.\") % parameter"},{"line_number":138,"context_line":"                raise exc.HTTPUnprocessableEntity(explanation\u003dmsg)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        return data"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_8f045218","line":138,"range":{"start_line":138,"start_character":26,"end_line":138,"end_character":49},"updated":"2016-07-31 21:10:40.000000000","message":"HTTPBadRequest","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f699467c47f44c9a9dafada0924c5c708d5ca81f","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                raise exc.HTTPUnprocessableEntity(explanation\u003dmsg)"},{"line_number":136,"context_line":"            if not data.get(parameter):"},{"line_number":137,"context_line":"                msg \u003d _(\"Required parameter %s is empty.\") % parameter"},{"line_number":138,"context_line":"                raise exc.HTTPUnprocessableEntity(explanation\u003dmsg)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        return data"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_ef70400d","line":138,"range":{"start_line":138,"start_character":26,"end_line":138,"end_character":49},"in_reply_to":"bacf61ea_8f045218","updated":"2016-08-01 19:27:23.000000000","message":"Done","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"48cab9e00f30db35f4fae844bb5eccb45de5a82e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            # Ensure share supports reverting to a snapshot"},{"line_number":68,"context_line":"            if not share[\u0027revert_to_snapshot_support\u0027]:"},{"line_number":69,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"},{"line_number":70,"context_line":"                msg \u003d _(\u0027Share %(share_id)s may not be reverted to snapshot \u0027"},{"line_number":71,"context_line":"                        \u0027%(snap_id)s, because share back end does not support \u0027"},{"line_number":72,"context_line":"                        \u0027it.\u0027)"},{"line_number":73,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg % msg_args)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            # Ensure requested share \u0026 snapshot match."}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5201f7_57fcd071","line":72,"range":{"start_line":70,"start_character":0,"end_line":72,"end_character":30},"updated":"2017-01-05 20:19:46.000000000","message":"I know this message mimics the other snapshot capability messages but I think they really need to be changed.  I hit this with create from snapshot and was totally confused because I was using a backend that *did* support the capability - the snapshot in question had however been created from a share that in turn was created with a share type that didn\u0027t have the create-from-share-type-support extra spec.\n\nCan we change this to say that share %s does not support revert-to-snapshot capability instead of saying that the backend does not support it?","commit_id":"98291366fb1801a7f38db80854ed60fcca16a88f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"24934911b7c6daf053ac1a3b6dfd5f23dd6645a8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            # Ensure share supports reverting to a snapshot"},{"line_number":68,"context_line":"            if not share[\u0027revert_to_snapshot_support\u0027]:"},{"line_number":69,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"},{"line_number":70,"context_line":"                msg \u003d _(\u0027Share %(share_id)s may not be reverted to snapshot \u0027"},{"line_number":71,"context_line":"                        \u0027%(snap_id)s, because share back end does not support \u0027"},{"line_number":72,"context_line":"                        \u0027it.\u0027)"},{"line_number":73,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg % msg_args)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            # Ensure requested share \u0026 snapshot match."}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5201f7_ab7f54a9","line":72,"range":{"start_line":70,"start_character":0,"end_line":72,"end_character":30},"in_reply_to":"ba5201f7_57fcd071","updated":"2017-01-06 00:35:11.000000000","message":"Done (both here and in the offending create-share-from-snapshot message).","commit_id":"98291366fb1801a7f38db80854ed60fcca16a88f"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"48cab9e00f30db35f4fae844bb5eccb45de5a82e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            # Ensure requested share \u0026 snapshot match."},{"line_number":76,"context_line":"            if share[\u0027id\u0027] !\u003d snapshot[\u0027share_id\u0027]:"},{"line_number":77,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"},{"line_number":78,"context_line":"                msg \u003d _(\u0027Share %(share_id)s does not contain snapshot \u0027"},{"line_number":79,"context_line":"                        \u0027%(snap_id)s.\u0027)"},{"line_number":80,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg % msg_args)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            # Ensure share status is \u0027available\u0027."}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5201f7_7738f43d","line":79,"range":{"start_line":78,"start_character":24,"end_line":79,"end_character":38},"updated":"2017-01-05 20:19:46.000000000","message":"This message may make sense to developers but to end users the relation between a share and its snapshots is not *containment*.","commit_id":"98291366fb1801a7f38db80854ed60fcca16a88f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"24934911b7c6daf053ac1a3b6dfd5f23dd6645a8","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            # Ensure requested share \u0026 snapshot match."},{"line_number":76,"context_line":"            if share[\u0027id\u0027] !\u003d snapshot[\u0027share_id\u0027]:"},{"line_number":77,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"},{"line_number":78,"context_line":"                msg \u003d _(\u0027Share %(share_id)s does not contain snapshot \u0027"},{"line_number":79,"context_line":"                        \u0027%(snap_id)s.\u0027)"},{"line_number":80,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg % msg_args)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            # Ensure share status is \u0027available\u0027."}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5201f7_cb7c98b7","line":79,"range":{"start_line":78,"start_character":24,"end_line":79,"end_character":38},"in_reply_to":"ba5201f7_7738f43d","updated":"2017-01-06 00:35:11.000000000","message":"OK, I\u0027ll buy that.  Fixed.","commit_id":"98291366fb1801a7f38db80854ed60fcca16a88f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                context, share_id)"},{"line_number":115,"context_line":"            if not latest_snapshot:"},{"line_number":116,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id}"},{"line_number":117,"context_line":"                msg \u003d _(\"Could not determine the latest snapshot for share \""},{"line_number":118,"context_line":"                        \"%(share_id)s.\")"},{"line_number":119,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg % msg_args)"},{"line_number":120,"context_line":"            if latest_snapshot[\u0027id\u0027] !\u003d snapshot_id:"},{"line_number":121,"context_line":"                msg_args \u003d {"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_8ea29e97","line":118,"range":{"start_line":117,"start_character":25,"end_line":118,"end_character":38},"updated":"2017-01-06 01:38:58.000000000","message":"When can this be possible? If you\u0027ve been able to get the snapshot, and match it to the share, this should always succeed?","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                context, share_id)"},{"line_number":115,"context_line":"            if not latest_snapshot:"},{"line_number":116,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id}"},{"line_number":117,"context_line":"                msg \u003d _(\"Could not determine the latest snapshot for share \""},{"line_number":118,"context_line":"                        \"%(share_id)s.\")"},{"line_number":119,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg % msg_args)"},{"line_number":120,"context_line":"            if latest_snapshot[\u0027id\u0027] !\u003d snapshot_id:"},{"line_number":121,"context_line":"                msg_args \u003d {"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_c94900b9","line":118,"range":{"start_line":117,"start_character":25,"end_line":118,"end_character":38},"in_reply_to":"ba5201f7_8ea29e97","updated":"2017-01-06 03:19:17.000000000","message":"We haven\u0027t yet locked the snapshot into a transitional state at this point, so this could race with a delete call.  In any event, get_latest_snapshot_for_share can return None, so it seems prudent to handle that case.","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id}"},{"line_number":117,"context_line":"                msg \u003d _(\"Could not determine the latest snapshot for share \""},{"line_number":118,"context_line":"                        \"%(share_id)s.\")"},{"line_number":119,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg % msg_args)"},{"line_number":120,"context_line":"            if latest_snapshot[\u0027id\u0027] !\u003d snapshot_id:"},{"line_number":121,"context_line":"                msg_args \u003d {"},{"line_number":122,"context_line":"                    \u0027share_id\u0027: share_id,"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_6efada76","line":119,"range":{"start_line":119,"start_character":26,"end_line":119,"end_character":40},"updated":"2017-01-06 01:38:58.000000000","message":"InternalServerError if ^ is possible","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                msg_args \u003d {\u0027share_id\u0027: share_id}"},{"line_number":117,"context_line":"                msg \u003d _(\"Could not determine the latest snapshot for share \""},{"line_number":118,"context_line":"                        \"%(share_id)s.\")"},{"line_number":119,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg % msg_args)"},{"line_number":120,"context_line":"            if latest_snapshot[\u0027id\u0027] !\u003d snapshot_id:"},{"line_number":121,"context_line":"                msg_args \u003d {"},{"line_number":122,"context_line":"                    \u0027share_id\u0027: share_id,"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_49d430bc","line":119,"range":{"start_line":119,"start_character":26,"end_line":119,"end_character":40},"in_reply_to":"ba5201f7_6efada76","updated":"2017-01-06 03:19:17.000000000","message":"Even if the cause is a race condition?","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                        \"it is not the most recent snapshot of share \""},{"line_number":128,"context_line":"                        \"%(share_id)s. Currently the latest snapshot is \""},{"line_number":129,"context_line":"                        \"%(latest_snap_id)s.\")"},{"line_number":130,"context_line":"                raise exc.HTTPForbidden(explanation\u003dmsg % msg_args)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"            msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"},{"line_number":133,"context_line":"            msg \u003d _LI(\u0027Reverting share %(share_id)s to snapshot %(snap_id)s.\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_4eea76ad","line":130,"range":{"start_line":130,"start_character":26,"end_line":130,"end_character":39},"updated":"2017-01-06 01:38:58.000000000","message":"The spec says this will be a 409\n\nhttps://specs.openstack.org/openstack/manila-specs/specs/ocata/manila-share-revert-to-snapshot.html#rest-api-impact\n\nForbidden means that someone else can attempt it. I think Conflict will be a good response, if not, 400 would be perfect. Thoughts?","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                        \"it is not the most recent snapshot of share \""},{"line_number":128,"context_line":"                        \"%(share_id)s. Currently the latest snapshot is \""},{"line_number":129,"context_line":"                        \"%(latest_snap_id)s.\")"},{"line_number":130,"context_line":"                raise exc.HTTPForbidden(explanation\u003dmsg % msg_args)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"            msg_args \u003d {\u0027share_id\u0027: share_id, \u0027snap_id\u0027: snapshot_id}"},{"line_number":133,"context_line":"            msg \u003d _LI(\u0027Reverting share %(share_id)s to snapshot %(snap_id)s.\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_6979f4c7","line":130,"range":{"start_line":130,"start_character":26,"end_line":130,"end_character":39},"in_reply_to":"ba5201f7_4eea76ad","updated":"2017-01-06 03:19:17.000000000","message":"\u003e\u003e Conflict will be a good response\n\nI could respond with conflict, but I prefer to respond with consensus.  ;-)\n\nWe\u0027ve gone in circles on this one, and I\u0027m not sure how it ended up here, but assuming the spec is correct, Conflict it is.","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ae69ea9194d54c6d87c69eba6317ba16bdbd7e6f","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        except exception.ShareSizeExceedsAvailableQuota as e:"},{"line_number":142,"context_line":"            raise exc.HTTPForbidden(explanation\u003dsix.text_type(e))"},{"line_number":143,"context_line":"        except exception.ReplicationException as e:"},{"line_number":144,"context_line":"            raise exc.HTTPInternalServerError(explanation\u003dsix.text_type(e))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ba5201f7_85bb740e","line":144,"range":{"start_line":144,"start_character":22,"end_line":144,"end_character":45},"updated":"2017-01-12 05:13:21.000000000","message":"Why is this HTTPInternalServerError?  HTTPBadRequest seems to be more appropriate.","commit_id":"c155f597f0beca0283ecf3c57d723dbbc3502c5f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"556070a7247beb274c8bea9d21b23f051b780de1","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        except exception.ShareSizeExceedsAvailableQuota as e:"},{"line_number":142,"context_line":"            raise exc.HTTPForbidden(explanation\u003dsix.text_type(e))"},{"line_number":143,"context_line":"        except exception.ReplicationException as e:"},{"line_number":144,"context_line":"            raise exc.HTTPInternalServerError(explanation\u003dsix.text_type(e))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"9a57fde8_f0356cf7","line":144,"range":{"start_line":144,"start_character":22,"end_line":144,"end_character":45},"in_reply_to":"9a57fde8_89aa4d6f","updated":"2017-01-13 15:10:13.000000000","message":"OK, changed to BadRequest.","commit_id":"c155f597f0beca0283ecf3c57d723dbbc3502c5f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ad016a365a907d71602364b9eef8a6e2bd95d844","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        except exception.ShareSizeExceedsAvailableQuota as e:"},{"line_number":142,"context_line":"            raise exc.HTTPForbidden(explanation\u003dsix.text_type(e))"},{"line_number":143,"context_line":"        except exception.ReplicationException as e:"},{"line_number":144,"context_line":"            raise exc.HTTPInternalServerError(explanation\u003dsix.text_type(e))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"9a57fde8_89aa4d6f","line":144,"range":{"start_line":144,"start_character":22,"end_line":144,"end_character":45},"in_reply_to":"ba5201f7_85bb740e","updated":"2017-01-12 10:23:30.000000000","message":"Good catch! Server error should never be raised intentionally. this kind of errors only for unhandled exceptions.","commit_id":"c155f597f0beca0283ecf3c57d723dbbc3502c5f"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"94378d3ab02fda410d5ee617e92ee32f51344471","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            msg \u003d _LI(\u0027Reverting share %(share_id)s to snapshot %(snap_id)s.\u0027)"},{"line_number":134,"context_line":"            LOG.info(msg, msg_args)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"            self.share_api.revert_to_snapshot(context, snapshot)"},{"line_number":137,"context_line":"        except exception.ShareNotFound as e:"},{"line_number":138,"context_line":"            raise exc.HTTPNotFound(explanation\u003dsix.text_type(e))"},{"line_number":139,"context_line":"        except exception.ShareSnapshotNotFound as e:"}],"source_content_type":"text/x-python","patch_set":44,"id":"7a3c09a3_0ad053f5","line":136,"range":{"start_line":136,"start_character":12,"end_line":136,"end_character":64},"updated":"2017-01-17 22:32:18.000000000","message":"Have you considered passing the share as well so that you don\u0027t have to fetch it from the database again in the share api?","commit_id":"d4a379d0836470a64d79cd28190382eecb1f5c71"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"85a9d90d1336950fbe600363cc2e1d42aa60f294","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            msg \u003d _LI(\u0027Reverting share %(share_id)s to snapshot %(snap_id)s.\u0027)"},{"line_number":134,"context_line":"            LOG.info(msg, msg_args)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"            self.share_api.revert_to_snapshot(context, snapshot)"},{"line_number":137,"context_line":"        except exception.ShareNotFound as e:"},{"line_number":138,"context_line":"            raise exc.HTTPNotFound(explanation\u003dsix.text_type(e))"},{"line_number":139,"context_line":"        except exception.ShareSnapshotNotFound as e:"}],"source_content_type":"text/x-python","patch_set":44,"id":"7a3c09a3_b1522833","line":136,"range":{"start_line":136,"start_character":12,"end_line":136,"end_character":64},"in_reply_to":"7a3c09a3_0ad053f5","updated":"2017-01-18 15:33:07.000000000","message":"Good idea.","commit_id":"d4a379d0836470a64d79cd28190382eecb1f5c71"}],"manila/db/migrations/alembic/versions/87ce15c59bbe_add_revert_to_snapshot_support.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        sa.Column(\u0027deleted\u0027, sa.String(length\u003d36)),"},{"line_number":49,"context_line":"        sa.Column(\u0027revert_to_snapshot_support\u0027, sa.Boolean),"},{"line_number":50,"context_line":"    )"},{"line_number":51,"context_line":"    update \u003d shares_table.update().\\"},{"line_number":52,"context_line":"        where(shares_table.c.deleted \u003d\u003d \u0027False\u0027).\\"},{"line_number":53,"context_line":"        values(revert_to_snapshot_support\u003dFalse)"},{"line_number":54,"context_line":"    session.execute(update)"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_4e38b63d","line":51,"range":{"start_line":51,"start_character":33,"end_line":51,"end_character":36},"updated":"2017-01-06 01:38:58.000000000","message":"break at the opening parenthesis to avoid using \\\n\n\n .update().where(\n  ..","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        sa.Column(\u0027deleted\u0027, sa.String(length\u003d36)),"},{"line_number":49,"context_line":"        sa.Column(\u0027revert_to_snapshot_support\u0027, sa.Boolean),"},{"line_number":50,"context_line":"    )"},{"line_number":51,"context_line":"    update \u003d shares_table.update().\\"},{"line_number":52,"context_line":"        where(shares_table.c.deleted \u003d\u003d \u0027False\u0027).\\"},{"line_number":53,"context_line":"        values(revert_to_snapshot_support\u003dFalse)"},{"line_number":54,"context_line":"    session.execute(update)"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_091f886c","line":51,"range":{"start_line":51,"start_character":33,"end_line":51,"end_character":36},"in_reply_to":"ba5201f7_4e38b63d","updated":"2017-01-06 03:19:17.000000000","message":"Done","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        sa.Column(\u0027revert_to_snapshot_support\u0027, sa.Boolean),"},{"line_number":50,"context_line":"    )"},{"line_number":51,"context_line":"    update \u003d shares_table.update().\\"},{"line_number":52,"context_line":"        where(shares_table.c.deleted \u003d\u003d \u0027False\u0027).\\"},{"line_number":53,"context_line":"        values(revert_to_snapshot_support\u003dFalse)"},{"line_number":54,"context_line":"    session.execute(update)"},{"line_number":55,"context_line":"    session.commit()"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_6e41faa8","line":52,"range":{"start_line":52,"start_character":48,"end_line":52,"end_character":50},"updated":"2017-01-06 01:38:58.000000000","message":".values(","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        sa.Column(\u0027revert_to_snapshot_support\u0027, sa.Boolean),"},{"line_number":50,"context_line":"    )"},{"line_number":51,"context_line":"    update \u003d shares_table.update().\\"},{"line_number":52,"context_line":"        where(shares_table.c.deleted \u003d\u003d \u0027False\u0027).\\"},{"line_number":53,"context_line":"        values(revert_to_snapshot_support\u003dFalse)"},{"line_number":54,"context_line":"    session.execute(update)"},{"line_number":55,"context_line":"    session.commit()"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_2910cc58","line":52,"range":{"start_line":52,"start_character":48,"end_line":52,"end_character":50},"in_reply_to":"ba5201f7_6e41faa8","updated":"2017-01-06 03:19:17.000000000","message":"Done","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"94378d3ab02fda410d5ee617e92ee32f51344471","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\"\"\"add_revert_to_snapshot_support"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Revision ID: 87ce15c59bbe"},{"line_number":18,"context_line":"Revises: 3e7d62517afa"},{"line_number":19,"context_line":"Create Date: 2016-08-18 00:12:34.587018"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":44,"id":"7a3c09a3_ab98216b","line":18,"range":{"start_line":18,"start_character":9,"end_line":18,"end_character":21},"updated":"2017-01-17 22:32:18.000000000","message":"doesn\u0027t match but doesn\u0027t matter","commit_id":"d4a379d0836470a64d79cd28190382eecb1f5c71"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"85a9d90d1336950fbe600363cc2e1d42aa60f294","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\"\"\"add_revert_to_snapshot_support"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Revision ID: 87ce15c59bbe"},{"line_number":18,"context_line":"Revises: 3e7d62517afa"},{"line_number":19,"context_line":"Create Date: 2016-08-18 00:12:34.587018"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":44,"id":"7a3c09a3_3146387b","line":18,"range":{"start_line":18,"start_character":9,"end_line":18,"end_character":21},"in_reply_to":"7a3c09a3_ab98216b","updated":"2017-01-18 15:33:07.000000000","message":"Good catch.  Not a bad idea to fix this.","commit_id":"d4a379d0836470a64d79cd28190382eecb1f5c71"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":2135,"context_line":""},{"line_number":2136,"context_line":"@require_context"},{"line_number":2137,"context_line":"def share_snapshot_get_latest_for_share(context, share_id):"},{"line_number":2138,"context_line":"    query \u003d model_query(context, models.ShareSnapshot)"},{"line_number":2139,"context_line":"    query \u003d query.filter_by(share_id\u003dshare_id)"},{"line_number":2140,"context_line":"    query \u003d query.options(joinedload(\u0027share\u0027))"},{"line_number":2141,"context_line":"    sort_attr \u003d getattr(models.ShareSnapshot, \u0027created_at\u0027)"},{"line_number":2142,"context_line":"    query \u003d query.order_by(sort_attr.desc())"},{"line_number":2143,"context_line":"    return query.first()"},{"line_number":2144,"context_line":""},{"line_number":2145,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_b93b96d0","line":2142,"range":{"start_line":2138,"start_character":0,"end_line":2142,"end_character":44},"updated":"2016-07-17 03:26:10.000000000","message":"We should use/reuse share_snapshot_get_all_for_share with sort_key \u003d created_at and sort_dir \u003d \"desc\"...","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":2135,"context_line":""},{"line_number":2136,"context_line":"@require_context"},{"line_number":2137,"context_line":"def share_snapshot_get_latest_for_share(context, share_id):"},{"line_number":2138,"context_line":"    query \u003d model_query(context, models.ShareSnapshot)"},{"line_number":2139,"context_line":"    query \u003d query.filter_by(share_id\u003dshare_id)"},{"line_number":2140,"context_line":"    query \u003d query.options(joinedload(\u0027share\u0027))"},{"line_number":2141,"context_line":"    sort_attr \u003d getattr(models.ShareSnapshot, \u0027created_at\u0027)"},{"line_number":2142,"context_line":"    query \u003d query.order_by(sort_attr.desc())"},{"line_number":2143,"context_line":"    return query.first()"},{"line_number":2144,"context_line":""},{"line_number":2145,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_3d26d968","line":2142,"range":{"start_line":2138,"start_character":0,"end_line":2142,"end_character":44},"in_reply_to":"fad55976_b93b96d0","updated":"2016-07-27 21:50:08.000000000","message":"Done","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"}],"manila/db/sqlalchemy/models.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"94378d3ab02fda410d5ee617e92ee32f51344471","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    @property"},{"line_number":260,"context_line":"    def instance(self):"},{"line_number":261,"context_line":"        # NOTE(gouthamr): The order of preference: status \u0027replication_change\u0027,"},{"line_number":262,"context_line":"        # followed  by \u0027available\u0027 and \u0027error\u0027. If replicated share and"},{"line_number":263,"context_line":"        # not undergoing a \u0027replication_change\u0027, only \u0027active\u0027 instances are"},{"line_number":264,"context_line":"        # preferred."},{"line_number":265,"context_line":"        result \u003d None"},{"line_number":266,"context_line":"        if len(self.instances) \u003e 0:"},{"line_number":267,"context_line":"            order \u003d (constants.STATUS_REVERTING,"}],"source_content_type":"text/x-python","patch_set":44,"id":"7a3c09a3_eb44e94a","line":264,"range":{"start_line":261,"start_character":0,"end_line":264,"end_character":20},"updated":"2017-01-17 22:32:18.000000000","message":"We ought to update this note someday.","commit_id":"d4a379d0836470a64d79cd28190382eecb1f5c71"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4fee46b8e846392b22c7178b7931ebcf7848015c","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    @property"},{"line_number":260,"context_line":"    def instance(self):"},{"line_number":261,"context_line":"        # NOTE(gouthamr): The order of preference: status \u0027replication_change\u0027,"},{"line_number":262,"context_line":"        # followed  by \u0027available\u0027 and \u0027error\u0027. If replicated share and"},{"line_number":263,"context_line":"        # not undergoing a \u0027replication_change\u0027, only \u0027active\u0027 instances are"},{"line_number":264,"context_line":"        # preferred."},{"line_number":265,"context_line":"        result \u003d None"},{"line_number":266,"context_line":"        if len(self.instances) \u003e 0:"},{"line_number":267,"context_line":"            order \u003d (constants.STATUS_REVERTING,"}],"source_content_type":"text/x-python","patch_set":44,"id":"7a3c09a3_13dc0b72","line":264,"range":{"start_line":261,"start_character":0,"end_line":264,"end_character":20},"in_reply_to":"7a3c09a3_eb44e94a","updated":"2017-01-17 23:45:48.000000000","message":"The second part will always make sense.. \nSince we are updating the order like below, we can consider removing the first part of this sentence. \n\nAlso, it does not matter if REVERTING came after REPLICATION_CHANGE -\u003e we know both statuses cannot be true at the same time.","commit_id":"d4a379d0836470a64d79cd28190382eecb1f5c71"}],"manila/scheduler/host_manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a1acc1014f5e2fb86a4417cbfa8fc97b06e76e15","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        self.driver_handles_share_servers \u003d capability.get("},{"line_number":317,"context_line":"            \u0027driver_handles_share_servers\u0027)"},{"line_number":318,"context_line":"        self.snapshot_support \u003d capability.get(\u0027snapshot_support\u0027)"},{"line_number":319,"context_line":"        self.revert_to_snapshot \u003d capability.get(\u0027revert_to_snapshot\u0027)"},{"line_number":320,"context_line":"        self.consistency_group_support \u003d capability.get("},{"line_number":321,"context_line":"            \u0027consistency_group_support\u0027, False)"},{"line_number":322,"context_line":"        self.updated \u003d capability[\u0027timestamp\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_2ce826b4","line":319,"range":{"start_line":319,"start_character":68,"end_line":319,"end_character":70},"updated":"2016-07-28 22:28:33.000000000","message":", False?","commit_id":"42d27856637161f8e92dfde6e2ca3a3d52b66aaa"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2a1d1375628ff413bd3b9caeb5ada3188915cb53","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        self.driver_handles_share_servers \u003d capability.get("},{"line_number":317,"context_line":"            \u0027driver_handles_share_servers\u0027)"},{"line_number":318,"context_line":"        self.snapshot_support \u003d capability.get(\u0027snapshot_support\u0027)"},{"line_number":319,"context_line":"        self.revert_to_snapshot \u003d capability.get(\u0027revert_to_snapshot\u0027)"},{"line_number":320,"context_line":"        self.consistency_group_support \u003d capability.get("},{"line_number":321,"context_line":"            \u0027consistency_group_support\u0027, False)"},{"line_number":322,"context_line":"        self.updated \u003d capability[\u0027timestamp\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_3f47a61e","line":319,"range":{"start_line":319,"start_character":68,"end_line":319,"end_character":70},"in_reply_to":"bacf61ea_2ce826b4","updated":"2016-07-28 23:19:36.000000000","message":"Good idea, done.","commit_id":"42d27856637161f8e92dfde6e2ca3a3d52b66aaa"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"de7855b28bc366410a49c24fe23251a9085cd7d7","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        if \u0027snapshot_support\u0027 not in pool_cap:"},{"line_number":290,"context_line":"            pool_cap[\u0027snapshot_support\u0027] \u003d self.snapshot_support"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        if \u0027revert_to_snapshot\u0027 not in pool_cap:"},{"line_number":293,"context_line":"            pool_cap[\u0027revert_to_snapshot\u0027] \u003d self.revert_to_snapshot"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        if not pool_cap.get(\u0027consistency_group_support\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_f17a2576","line":292,"range":{"start_line":292,"start_character":12,"end_line":292,"end_character":30},"updated":"2016-07-30 04:48:07.000000000","message":"We also need to add \u0027revert_to_snapshot\u0027 capability in utils.py. link:\nhttps://github.com/openstack/manila/blob/master/manila/scheduler/utils.py#L20","commit_id":"ff0c6090fd4e144151bf43493bf7efc92c07937a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"c1e60a687f3d27db989e2900bbdbd6efc2ad2620","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        if \u0027snapshot_support\u0027 not in pool_cap:"},{"line_number":290,"context_line":"            pool_cap[\u0027snapshot_support\u0027] \u003d self.snapshot_support"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        if \u0027revert_to_snapshot\u0027 not in pool_cap:"},{"line_number":293,"context_line":"            pool_cap[\u0027revert_to_snapshot\u0027] \u003d self.revert_to_snapshot"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        if not pool_cap.get(\u0027consistency_group_support\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_167a47bd","line":292,"range":{"start_line":292,"start_character":12,"end_line":292,"end_character":30},"in_reply_to":"bacf61ea_f17a2576","updated":"2016-07-30 17:36:37.000000000","message":"Done.  Good catch.  This file didn\u0027t exist until very recently.","commit_id":"ff0c6090fd4e144151bf43493bf7efc92c07937a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"de7855b28bc366410a49c24fe23251a9085cd7d7","unresolved":false,"context_lines":[{"line_number":387,"context_line":"            self.replication_type \u003d capability.get("},{"line_number":388,"context_line":"                \u0027replication_type\u0027, self.replication_type)"},{"line_number":389,"context_line":"            self.replication_domain \u003d capability.get("},{"line_number":390,"context_line":"                \u0027replication_domain\u0027)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def update_pools(self, capability):"},{"line_number":393,"context_line":"        # Do nothing, since we don\u0027t have pools within pool, yet"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_343dcbc4","line":390,"range":{"start_line":390,"start_character":37,"end_line":390,"end_character":37},"updated":"2016-07-30 04:48:07.000000000","message":"How about add revert_to_snapshot in this too?","commit_id":"ff0c6090fd4e144151bf43493bf7efc92c07937a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"c1e60a687f3d27db989e2900bbdbd6efc2ad2620","unresolved":false,"context_lines":[{"line_number":387,"context_line":"            self.replication_type \u003d capability.get("},{"line_number":388,"context_line":"                \u0027replication_type\u0027, self.replication_type)"},{"line_number":389,"context_line":"            self.replication_domain \u003d capability.get("},{"line_number":390,"context_line":"                \u0027replication_domain\u0027)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def update_pools(self, capability):"},{"line_number":393,"context_line":"        # Do nothing, since we don\u0027t have pools within pool, yet"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_f60b3328","line":390,"range":{"start_line":390,"start_character":37,"end_line":390,"end_character":37},"in_reply_to":"bacf61ea_343dcbc4","updated":"2016-07-30 17:36:37.000000000","message":"I\u0027m using snapshot_support as the model for revert_to_snapshot capability, so I figured it\u0027s good enough to have it on the backend.  What am I missing?","commit_id":"ff0c6090fd4e144151bf43493bf7efc92c07937a"}],"manila/share/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        # Note(cknight): This value may be positive or negative."},{"line_number":695,"context_line":"        size_increase \u003d snapshot[\u0027size\u0027] - share[\u0027size\u0027]"},{"line_number":696,"context_line":"        if not size_increase:"},{"line_number":697,"context_line":"            return None"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_59a9bade","line":696,"range":{"start_line":696,"start_character":8,"end_line":696,"end_character":28},"updated":"2016-07-17 03:26:10.000000000","message":"you mean:\n\n if size_increase \u003e 0:","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        # Note(cknight): This value may be positive or negative."},{"line_number":695,"context_line":"        size_increase \u003d snapshot[\u0027size\u0027] - share[\u0027size\u0027]"},{"line_number":696,"context_line":"        if not size_increase:"},{"line_number":697,"context_line":"            return None"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_e0c018e3","line":696,"range":{"start_line":696,"start_character":8,"end_line":696,"end_character":28},"in_reply_to":"fad55976_59a9bade","updated":"2016-07-27 21:50:08.000000000","message":"I could have said \u0027if size_increase !\u003d 0\u0027.  But keep in mind the quota change could be positive or negative.","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":707,"context_line":"            consumed_gb \u003d (usages[\u0027gigabytes\u0027][\u0027reserved\u0027] +"},{"line_number":708,"context_line":"                           usages[\u0027gigabytes\u0027][\u0027in_use\u0027])"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"            msg \u003d _LE(\u0027Quota exceeded for %(s_pid)s. Share revert to snapshot \u0027"},{"line_number":711,"context_line":"                      \u0027would have increased share %(s_sid)s by %(s_size)sG, \u0027"},{"line_number":712,"context_line":"                      \u0027(%(d_consumed)dG of %(d_quota)dG already consumed).\u0027)"},{"line_number":713,"context_line":"            msg_args \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_d9476a49","line":710,"range":{"start_line":710,"start_character":53,"end_line":710,"end_character":65},"updated":"2016-07-17 03:26:10.000000000","message":"nit: Reverting share %s to snapshot %s will increase the share\u0027s size by ...","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":707,"context_line":"            consumed_gb \u003d (usages[\u0027gigabytes\u0027][\u0027reserved\u0027] +"},{"line_number":708,"context_line":"                           usages[\u0027gigabytes\u0027][\u0027in_use\u0027])"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"            msg \u003d _LE(\u0027Quota exceeded for %(s_pid)s. Share revert to snapshot \u0027"},{"line_number":711,"context_line":"                      \u0027would have increased share %(s_sid)s by %(s_size)sG, \u0027"},{"line_number":712,"context_line":"                      \u0027(%(d_consumed)dG of %(d_quota)dG already consumed).\u0027)"},{"line_number":713,"context_line":"            msg_args \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_03ff3602","line":710,"range":{"start_line":710,"start_character":53,"end_line":710,"end_character":65},"in_reply_to":"fad55976_d9476a49","updated":"2016-07-27 21:50:08.000000000","message":"Done","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":719,"context_line":"            }"},{"line_number":720,"context_line":"            LOG.error(msg, msg_args)"},{"line_number":721,"context_line":"            raise exception.ShareSizeExceedsAvailableQuota("},{"line_number":722,"context_line":"                requested\u003dsize_increase,"},{"line_number":723,"context_line":"                consumed\u003dconsumed_gb,"},{"line_number":724,"context_line":"                quota\u003dquotas[\u0027gigabytes\u0027])"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"    def _revert_to_snapshot(self, context, share, snapshot, reservations):"},{"line_number":727,"context_line":"        \"\"\"Revert a non-replicated share to a snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_f9634eda","line":724,"range":{"start_line":722,"start_character":16,"end_line":724,"end_character":42},"updated":"2016-07-17 03:26:10.000000000","message":"I don\u0027t see these values expected in exception.py..","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":719,"context_line":"            }"},{"line_number":720,"context_line":"            LOG.error(msg, msg_args)"},{"line_number":721,"context_line":"            raise exception.ShareSizeExceedsAvailableQuota("},{"line_number":722,"context_line":"                requested\u003dsize_increase,"},{"line_number":723,"context_line":"                consumed\u003dconsumed_gb,"},{"line_number":724,"context_line":"                quota\u003dquotas[\u0027gigabytes\u0027])"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"    def _revert_to_snapshot(self, context, share, snapshot, reservations):"},{"line_number":727,"context_line":"        \"\"\"Revert a non-replicated share to a snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_032bb6ec","line":724,"range":{"start_line":722,"start_character":16,"end_line":724,"end_character":42},"in_reply_to":"fad55976_f9634eda","updated":"2016-07-27 21:50:08.000000000","message":"True, and this isn\u0027t the only place that is doing this.  There\u0027s a trivial fix for someone needing an ATC pass.  Fixed!","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":764,"context_line":"            snapshot_instances[0] if snapshot_instances else None)"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"        if not active_snapshot_instance:"},{"line_number":767,"context_line":"            msg \u003d _(\u0027Share %s has no snapshot on its active replica.\u0027)"},{"line_number":768,"context_line":"            raise exception.ReplicationException(reason\u003dmsg % share[\u0027id\u0027])"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        # Set active replica to \u0027reverting\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_b997168f","line":767,"range":{"start_line":767,"start_character":46,"end_line":767,"end_character":52},"updated":"2016-07-17 03:26:10.000000000","message":"associated with","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":764,"context_line":"            snapshot_instances[0] if snapshot_instances else None)"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"        if not active_snapshot_instance:"},{"line_number":767,"context_line":"            msg \u003d _(\u0027Share %s has no snapshot on its active replica.\u0027)"},{"line_number":768,"context_line":"            raise exception.ReplicationException(reason\u003dmsg % share[\u0027id\u0027])"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        # Set active replica to \u0027reverting\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_a31d8abf","line":767,"range":{"start_line":767,"start_character":46,"end_line":767,"end_character":52},"in_reply_to":"fad55976_b997168f","updated":"2016-07-27 21:50:08.000000000","message":"Done","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":778,"context_line":"            {\u0027status\u0027: constants.STATUS_RESTORING})"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"        # Send revert API to active replica host"},{"line_number":781,"context_line":"        self.share_rpcapi.revert_to_snapshot("},{"line_number":782,"context_line":"            context, share, snapshot, active_replica[\u0027host\u0027], reservations)"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"    @policy.wrap_check_policy(\u0027share\u0027)"},{"line_number":785,"context_line":"    def delete(self, context, share, force\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_19d46245","line":782,"range":{"start_line":781,"start_character":8,"end_line":782,"end_character":75},"updated":"2016-07-17 03:26:10.000000000","message":"Why not branch right here... we\u0027ve set the statuses here, so, the share manager calls are protected by the status changes... that\u0027s what happens with create_replicated_snapshot..","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8abfcb572f09a1cb51b056940e731980bfef4d8d","unresolved":false,"context_lines":[{"line_number":778,"context_line":"            {\u0027status\u0027: constants.STATUS_RESTORING})"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"        # Send revert API to active replica host"},{"line_number":781,"context_line":"        self.share_rpcapi.revert_to_snapshot("},{"line_number":782,"context_line":"            context, share, snapshot, active_replica[\u0027host\u0027], reservations)"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"    @policy.wrap_check_policy(\u0027share\u0027)"},{"line_number":785,"context_line":"    def delete(self, context, share, force\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_ae93b1f9","line":782,"range":{"start_line":781,"start_character":8,"end_line":782,"end_character":75},"in_reply_to":"fad55976_19d46245","updated":"2016-07-27 20:32:29.000000000","message":"Hearing Ben\u0027s argument that we would have more work to do in maintaining RPC layer interactions with versioned objects in the future, I\u0027m okay with the branching in the share manager. I wish we could go back in time and correct the rpc layer a bit more. Alas, agile programming.","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":778,"context_line":"            {\u0027status\u0027: constants.STATUS_RESTORING})"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"        # Send revert API to active replica host"},{"line_number":781,"context_line":"        self.share_rpcapi.revert_to_snapshot("},{"line_number":782,"context_line":"            context, share, snapshot, active_replica[\u0027host\u0027], reservations)"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"    @policy.wrap_check_policy(\u0027share\u0027)"},{"line_number":785,"context_line":"    def delete(self, context, share, force\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_4e6af51b","line":782,"range":{"start_line":781,"start_character":8,"end_line":782,"end_character":75},"in_reply_to":"fad55976_19d46245","updated":"2016-07-27 21:50:08.000000000","message":"Our illustrious PTL asked me to do this with one RPC call.","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"        return snapshots"},{"line_number":1294,"context_line":""},{"line_number":1295,"context_line":"    def get_latest_snapshot_for_share(self, context, share_id):"},{"line_number":1296,"context_line":"        policy.check_policy(context, \u0027share_snapshot\u0027, \u0027get_snapshot\u0027)"},{"line_number":1297,"context_line":"        return self.db.share_snapshot_get_latest_for_share(context, share_id)"},{"line_number":1298,"context_line":""},{"line_number":1299,"context_line":"    def allow_access(self, ctx, share, access_type, access_to,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_f9350eda","line":1296,"range":{"start_line":1296,"start_character":8,"end_line":1296,"end_character":70},"updated":"2016-07-17 03:26:10.000000000","message":"We are checking policy before the API methods are called.. do we expect inconsistency between \u0027revert_to_snapshot\u0027 and \u0027get_snapshot\u0027?  the policy for the API should allow access to all database objects associated with the API..","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"        return snapshots"},{"line_number":1294,"context_line":""},{"line_number":1295,"context_line":"    def get_latest_snapshot_for_share(self, context, share_id):"},{"line_number":1296,"context_line":"        policy.check_policy(context, \u0027share_snapshot\u0027, \u0027get_snapshot\u0027)"},{"line_number":1297,"context_line":"        return self.db.share_snapshot_get_latest_for_share(context, share_id)"},{"line_number":1298,"context_line":""},{"line_number":1299,"context_line":"    def allow_access(self, ctx, share, access_type, access_to,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_ce64254b","line":1296,"range":{"start_line":1296,"start_character":8,"end_line":1296,"end_character":70},"in_reply_to":"fad55976_f9350eda","updated":"2016-07-27 21:50:08.000000000","message":"Done","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"112e7e50d4f73db065cd8825c3fea2b2000c9d61","unresolved":false,"context_lines":[{"line_number":699,"context_line":"        try:"},{"line_number":700,"context_line":"            return QUOTAS.reserve(context,"},{"line_number":701,"context_line":"                                  project_id\u003dshare[\u0027project_id\u0027],"},{"line_number":702,"context_line":"                                  gigabytes\u003dsize_increase,"},{"line_number":703,"context_line":"                                  user_id\u003dshare[\u0027user_id\u0027])"},{"line_number":704,"context_line":"        except exception.OverQuota as exc:"},{"line_number":705,"context_line":"            usages \u003d exc.kwargs[\u0027usages\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_b93767e2","line":702,"range":{"start_line":702,"start_character":44,"end_line":702,"end_character":57},"updated":"2016-07-28 06:49:13.000000000","message":"what if size_increase is negative?","commit_id":"81bf37066181c7946d823c8d271514c709d5142f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4401aa4d480139466a3dd7d83b1aa8cd08203654","unresolved":false,"context_lines":[{"line_number":699,"context_line":"        try:"},{"line_number":700,"context_line":"            return QUOTAS.reserve(context,"},{"line_number":701,"context_line":"                                  project_id\u003dshare[\u0027project_id\u0027],"},{"line_number":702,"context_line":"                                  gigabytes\u003dsize_increase,"},{"line_number":703,"context_line":"                                  user_id\u003dshare[\u0027user_id\u0027])"},{"line_number":704,"context_line":"        except exception.OverQuota as exc:"},{"line_number":705,"context_line":"            usages \u003d exc.kwargs[\u0027usages\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_e7a3e39c","line":702,"range":{"start_line":702,"start_character":44,"end_line":702,"end_character":57},"in_reply_to":"bacf61ea_b93767e2","updated":"2016-07-28 21:48:03.000000000","message":"Then the reserved quota goes down, as it should.","commit_id":"81bf37066181c7946d823c8d271514c709d5142f"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"112e7e50d4f73db065cd8825c3fea2b2000c9d61","unresolved":false,"context_lines":[{"line_number":764,"context_line":"            snapshot_instances[0] if snapshot_instances else None)"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"        if not active_snapshot_instance:"},{"line_number":767,"context_line":"            msg \u003d _(\u0027Share %s has no snapshot associated with its active \u0027"},{"line_number":768,"context_line":"                    \u0027replica.\u0027)"},{"line_number":769,"context_line":"            raise exception.ReplicationException(reason\u003dmsg % share[\u0027id\u0027])"},{"line_number":770,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_b9cbe771","line":767,"range":{"start_line":767,"start_character":45,"end_line":767,"end_character":46},"updated":"2016-07-28 06:49:13.000000000","message":"of id snapshot[\u0027id\u0027]","commit_id":"81bf37066181c7946d823c8d271514c709d5142f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4401aa4d480139466a3dd7d83b1aa8cd08203654","unresolved":false,"context_lines":[{"line_number":764,"context_line":"            snapshot_instances[0] if snapshot_instances else None)"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"        if not active_snapshot_instance:"},{"line_number":767,"context_line":"            msg \u003d _(\u0027Share %s has no snapshot associated with its active \u0027"},{"line_number":768,"context_line":"                    \u0027replica.\u0027)"},{"line_number":769,"context_line":"            raise exception.ReplicationException(reason\u003dmsg % share[\u0027id\u0027])"},{"line_number":770,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_b788e023","line":767,"range":{"start_line":767,"start_character":45,"end_line":767,"end_character":46},"in_reply_to":"bacf61ea_b9cbe771","updated":"2016-07-28 21:48:03.000000000","message":"OK, done.","commit_id":"81bf37066181c7946d823c8d271514c709d5142f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"aef1d1cd61005b0f88f8a04d0522c55bf23ee268","unresolved":false,"context_lines":[{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        # Get snapshot instance on active replica"},{"line_number":756,"context_line":"        snapshot_instance_filters \u003d {"},{"line_number":757,"context_line":"            \u0027share_instance_ids\u0027: active_replica[\u0027id\u0027],"},{"line_number":758,"context_line":"            \u0027snapshot_ids\u0027: snapshot[\u0027id\u0027],"},{"line_number":759,"context_line":"        }"},{"line_number":760,"context_line":"        snapshot_instances \u003d ("}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_143995d7","line":757,"updated":"2016-07-31 16:59:04.000000000","message":"Why \u0027share_instance_ids\u0027 not \u0027share_instance_id\u0027?  active_replica[\u0027id\u0027] will only give you one id, not multiples.","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f699467c47f44c9a9dafada0924c5c708d5ca81f","unresolved":false,"context_lines":[{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        # Get snapshot instance on active replica"},{"line_number":756,"context_line":"        snapshot_instance_filters \u003d {"},{"line_number":757,"context_line":"            \u0027share_instance_ids\u0027: active_replica[\u0027id\u0027],"},{"line_number":758,"context_line":"            \u0027snapshot_ids\u0027: snapshot[\u0027id\u0027],"},{"line_number":759,"context_line":"        }"},{"line_number":760,"context_line":"        snapshot_instances \u003d ("}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_cf5c5c4d","line":757,"in_reply_to":"bacf61ea_143995d7","updated":"2016-08-01 19:27:23.000000000","message":"snapshot_instance_filters is an argument to the extant DB method share_snapshot_instance_get_all_with_filters, which is expecting the key to be \u0027share_instance_ids\u0027.\n\nhttps://github.com/openstack/manila/blob/master/manila/db/sqlalchemy/api.py#L1938","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"aef1d1cd61005b0f88f8a04d0522c55bf23ee268","unresolved":false,"context_lines":[{"line_number":755,"context_line":"        # Get snapshot instance on active replica"},{"line_number":756,"context_line":"        snapshot_instance_filters \u003d {"},{"line_number":757,"context_line":"            \u0027share_instance_ids\u0027: active_replica[\u0027id\u0027],"},{"line_number":758,"context_line":"            \u0027snapshot_ids\u0027: snapshot[\u0027id\u0027],"},{"line_number":759,"context_line":"        }"},{"line_number":760,"context_line":"        snapshot_instances \u003d ("},{"line_number":761,"context_line":"            self.db.share_snapshot_instance_get_all_with_filters("}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_9453c516","line":758,"updated":"2016-07-31 16:59:04.000000000","message":"Same here.  You will only get one snapshot id.  So should be \u0027snapshot_id\u0027 instead of \u0027snapshot_ids\u0027.","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f699467c47f44c9a9dafada0924c5c708d5ca81f","unresolved":false,"context_lines":[{"line_number":755,"context_line":"        # Get snapshot instance on active replica"},{"line_number":756,"context_line":"        snapshot_instance_filters \u003d {"},{"line_number":757,"context_line":"            \u0027share_instance_ids\u0027: active_replica[\u0027id\u0027],"},{"line_number":758,"context_line":"            \u0027snapshot_ids\u0027: snapshot[\u0027id\u0027],"},{"line_number":759,"context_line":"        }"},{"line_number":760,"context_line":"        snapshot_instances \u003d ("},{"line_number":761,"context_line":"            self.db.share_snapshot_instance_get_all_with_filters("}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_8fa1c448","line":758,"in_reply_to":"bacf61ea_9453c516","updated":"2016-08-01 19:27:23.000000000","message":"Same...the DB method expects snapshot_ids.","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"334079b50568dea1287bdba371c5c799f028cb15","unresolved":false,"context_lines":[{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        self.share_rpcapi.unmanage_snapshot(context, snapshot_ref, host)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def revert_to_snapshot(self, context, snapshot):"},{"line_number":673,"context_line":"        \"\"\"Revert a share to a snapshot.\"\"\""},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"        share \u003d self.db.share_get(context, snapshot[\u0027share_id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_27a8dfda","line":672,"range":{"start_line":672,"start_character":4,"end_line":672,"end_character":52},"updated":"2016-08-11 12:31:12.000000000","message":"There is not check whether the driver can support revert-to-snapshot capability. If the driver report \"revert-to-snapshot\u003dFalse\", we will still run the following code(line 740), and go to the share-service even share driver can not support this feature. \nSo, the revert-to-snapshot doesn\u0027t work in api-service. Then the share status will change to STATUS_REVERTING_ERROR. Is it ok? It sounds like not a good user experience.\n\nHow about add the revert-to-snapshot check in api-service? \nsuch as: https://github.com/openstack/manila/blob/master/manila/api/v1/share_snapshots.py#L166","commit_id":"5762ad3c724b8d8e13005723cccf9412e3b1c40a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        \"\"\""},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        inferred_map \u003d constants.ExtraSpecs.INFERRED_OPTIONAL_MAP"},{"line_number":269,"context_line":"        snapshot_support_key \u003d constants.ExtraSpecs.SNAPSHOT_SUPPORT"},{"line_number":270,"context_line":"        create_share_from_snapshot_key \u003d ("},{"line_number":271,"context_line":"            constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT)"},{"line_number":272,"context_line":"        revert_to_snapshot_key \u003d ("}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_ae1e82b8","line":269,"range":{"start_line":269,"start_character":25,"end_line":269,"end_character":30},"updated":"2017-01-06 01:38:58.000000000","message":"+100","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        \"\"\""},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        inferred_map \u003d constants.ExtraSpecs.INFERRED_OPTIONAL_MAP"},{"line_number":269,"context_line":"        snapshot_support_key \u003d constants.ExtraSpecs.SNAPSHOT_SUPPORT"},{"line_number":270,"context_line":"        create_share_from_snapshot_key \u003d ("},{"line_number":271,"context_line":"            constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT)"},{"line_number":272,"context_line":"        revert_to_snapshot_key \u003d ("}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_24071119","line":269,"range":{"start_line":269,"start_character":25,"end_line":269,"end_character":30},"in_reply_to":"ba5201f7_ae1e82b8","updated":"2017-01-06 03:19:17.000000000","message":":-)\n\nThese names are a trifle long, aren\u0027t they?","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ae69ea9194d54c6d87c69eba6317ba16bdbd7e6f","unresolved":false,"context_lines":[{"line_number":767,"context_line":"            consumed_gb \u003d (usages[\u0027gigabytes\u0027][\u0027reserved\u0027] +"},{"line_number":768,"context_line":"                           usages[\u0027gigabytes\u0027][\u0027in_use\u0027])"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"            msg \u003d _LE(\"Quota exceeded for %(s_pid)s. Reverting share \""},{"line_number":771,"context_line":"                      \"%(s_sid)s to snapshot %(s_ssid)s will increase the \""},{"line_number":772,"context_line":"                      \"share\u0027s size by %(s_size)sG, \""},{"line_number":773,"context_line":"                      \"(%(d_consumed)dG of %(d_quota)dG already consumed).\")"}],"source_content_type":"text/x-python","patch_set":40,"id":"ba5201f7_8573744d","line":770,"range":{"start_line":770,"start_character":18,"end_line":770,"end_character":21},"updated":"2017-01-12 05:13:21.000000000","message":"This should be just _(\"xxxx\") because the same message goes to the exception.","commit_id":"c155f597f0beca0283ecf3c57d723dbbc3502c5f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"556070a7247beb274c8bea9d21b23f051b780de1","unresolved":false,"context_lines":[{"line_number":767,"context_line":"            consumed_gb \u003d (usages[\u0027gigabytes\u0027][\u0027reserved\u0027] +"},{"line_number":768,"context_line":"                           usages[\u0027gigabytes\u0027][\u0027in_use\u0027])"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"            msg \u003d _LE(\"Quota exceeded for %(s_pid)s. Reverting share \""},{"line_number":771,"context_line":"                      \"%(s_sid)s to snapshot %(s_ssid)s will increase the \""},{"line_number":772,"context_line":"                      \"share\u0027s size by %(s_size)sG, \""},{"line_number":773,"context_line":"                      \"(%(d_consumed)dG of %(d_quota)dG already consumed).\")"}],"source_content_type":"text/x-python","patch_set":40,"id":"9a57fde8_b573d64c","line":770,"range":{"start_line":770,"start_character":18,"end_line":770,"end_character":21},"in_reply_to":"ba5201f7_8573744d","updated":"2017-01-13 15:10:13.000000000","message":"Right you are.  Fixed.","commit_id":"c155f597f0beca0283ecf3c57d723dbbc3502c5f"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"94378d3ab02fda410d5ee617e92ee32f51344471","unresolved":false,"context_lines":[{"line_number":732,"context_line":"    def revert_to_snapshot(self, context, snapshot):"},{"line_number":733,"context_line":"        \"\"\"Revert a share to a snapshot.\"\"\""},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"        share \u003d self.db.share_get(context, snapshot[\u0027share_id\u0027])"},{"line_number":736,"context_line":"        reservations \u003d self._handle_revert_to_snapshot_quotas("},{"line_number":737,"context_line":"            context, share, snapshot)"},{"line_number":738,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"7a3c09a3_4aa89b77","line":735,"updated":"2017-01-17 22:32:18.000000000","message":"Could we avoid this DB fetch if the share were passed in the call?","commit_id":"d4a379d0836470a64d79cd28190382eecb1f5c71"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"85a9d90d1336950fbe600363cc2e1d42aa60f294","unresolved":false,"context_lines":[{"line_number":732,"context_line":"    def revert_to_snapshot(self, context, snapshot):"},{"line_number":733,"context_line":"        \"\"\"Revert a share to a snapshot.\"\"\""},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"        share \u003d self.db.share_get(context, snapshot[\u0027share_id\u0027])"},{"line_number":736,"context_line":"        reservations \u003d self._handle_revert_to_snapshot_quotas("},{"line_number":737,"context_line":"            context, share, snapshot)"},{"line_number":738,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"7a3c09a3_f16830f7","line":735,"in_reply_to":"7a3c09a3_4aa89b77","updated":"2017-01-18 15:33:07.000000000","message":"I don\u0027t see why not!  Perhaps someone can make this tweak when adding more 1st-party driver support for revert.","commit_id":"d4a379d0836470a64d79cd28190382eecb1f5c71"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"94378d3ab02fda410d5ee617e92ee32f51344471","unresolved":false,"context_lines":[{"line_number":794,"context_line":"        # Set status of snapshot to \u0027restoring\u0027"},{"line_number":795,"context_line":"        self.db.share_snapshot_update("},{"line_number":796,"context_line":"            context, snapshot[\u0027id\u0027],"},{"line_number":797,"context_line":"            {\u0027status\u0027: constants.STATUS_RESTORING})"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"        # Send revert API to share host"},{"line_number":800,"context_line":"        self.share_rpcapi.revert_to_snapshot("}],"source_content_type":"text/x-python","patch_set":44,"id":"7a3c09a3_4a8edbd0","line":797,"updated":"2017-01-17 22:32:18.000000000","message":"It is interesting to think about how we\u0027ll avoid races here given that multiple DB objects are involved.  Presumably we\u0027ll lock a critical section that ends here and begins at line 61 in api/v2/shares.py ?","commit_id":"d4a379d0836470a64d79cd28190382eecb1f5c71"}],"manila/share/driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        Does not delete the share snapshot.  The share and snapshot must both"},{"line_number":725,"context_line":"        be \u0027available\u0027 for the restore to be attempted.  The snapshot must be"},{"line_number":726,"context_line":"        the most recent one taken by Manila; the API layer performs this check"},{"line_number":727,"context_line":"        so the driver doesn\u0027t have to."},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"        The share must be reverted in place to the contents of the snapshot."},{"line_number":730,"context_line":"        Application writers should quiesce or otherwise prepare the application"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_9992129e","line":727,"range":{"start_line":726,"start_character":45,"end_line":727,"end_character":38},"updated":"2016-07-17 03:26:10.000000000","message":"Unless there\u0027s a snapshot policy of some sort that created newer snapshots without manila knowing about it?\n\nor an overzealous admin who snapshots manila shares out-of-band of manila :)","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        Does not delete the share snapshot.  The share and snapshot must both"},{"line_number":725,"context_line":"        be \u0027available\u0027 for the restore to be attempted.  The snapshot must be"},{"line_number":726,"context_line":"        the most recent one taken by Manila; the API layer performs this check"},{"line_number":727,"context_line":"        so the driver doesn\u0027t have to."},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"        The share must be reverted in place to the contents of the snapshot."},{"line_number":730,"context_line":"        Application writers should quiesce or otherwise prepare the application"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_6048a82e","line":727,"range":{"start_line":726,"start_character":45,"end_line":727,"end_character":38},"in_reply_to":"fad55976_9992129e","updated":"2016-07-27 21:50:08.000000000","message":"If the admin configures scheduled out-of-band snapshots, and the driver checks for those, the revert-to-snapshot feature would rarely work.  It\u0027s best that Manila does the check and the driver doesn\u0027t.","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        :param context: Current context"},{"line_number":734,"context_line":"        :param snapshot: The snapshot to be restored"},{"line_number":735,"context_line":"        :param share_server: Optional -- Share server model"},{"line_number":736,"context_line":"        \"\"\""},{"line_number":737,"context_line":"        raise NotImplementedError()"},{"line_number":738,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_59f7faf4","line":735,"range":{"start_line":735,"start_character":29,"end_line":735,"end_character":37},"updated":"2016-07-17 03:26:10.000000000","message":"Share server model or None","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        :param context: Current context"},{"line_number":734,"context_line":"        :param snapshot: The snapshot to be restored"},{"line_number":735,"context_line":"        :param share_server: Optional -- Share server model"},{"line_number":736,"context_line":"        \"\"\""},{"line_number":737,"context_line":"        raise NotImplementedError()"},{"line_number":738,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_e02f78f4","line":735,"range":{"start_line":735,"start_character":29,"end_line":735,"end_character":37},"in_reply_to":"fad55976_59f7faf4","updated":"2016-07-27 21:50:08.000000000","message":"Done","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":1658,"context_line":"                                      replica_list, active_replica_snapshot,"},{"line_number":1659,"context_line":"                                      replica_snapshots, share_server\u003dNone):"},{"line_number":1660,"context_line":"        \"\"\"Reverts a replicated share (in place) to the specified snapshot."},{"line_number":1661,"context_line":""},{"line_number":1662,"context_line":"        Does not delete the share snapshot.  The share and snapshot must both"},{"line_number":1663,"context_line":"        be \u0027available\u0027 for the restore to be attempted.  The snapshot must be"},{"line_number":1664,"context_line":"        the most recent one taken by Manila; the API layer performs this check"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_79f47ef1","line":1661,"range":{"start_line":1661,"start_character":0,"end_line":1661,"end_character":0},"updated":"2016-07-17 03:26:10.000000000","message":".. note::\n      This call is made on the \u0027active\u0027 replica\u0027s host, since\n      drivers may not be able to revert snapshots on individual\n      replicas.","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":1658,"context_line":"                                      replica_list, active_replica_snapshot,"},{"line_number":1659,"context_line":"                                      replica_snapshots, share_server\u003dNone):"},{"line_number":1660,"context_line":"        \"\"\"Reverts a replicated share (in place) to the specified snapshot."},{"line_number":1661,"context_line":""},{"line_number":1662,"context_line":"        Does not delete the share snapshot.  The share and snapshot must both"},{"line_number":1663,"context_line":"        be \u0027available\u0027 for the restore to be attempted.  The snapshot must be"},{"line_number":1664,"context_line":"        the most recent one taken by Manila; the API layer performs this check"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_c04eb4c0","line":1661,"range":{"start_line":1661,"start_character":0,"end_line":1661,"end_character":0},"in_reply_to":"fad55976_79f47ef1","updated":"2016-07-27 21:50:08.000000000","message":"Done","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a1acc1014f5e2fb86a4417cbfa8fc97b06e76e15","unresolved":false,"context_lines":[{"line_number":1677,"context_line":"        The share must be reverted in place to the contents of the snapshot."},{"line_number":1678,"context_line":"        Application writers should quiesce or otherwise prepare the application"},{"line_number":1679,"context_line":"        for the shared file system contents to change suddenly."},{"line_number":1680,"context_line":""},{"line_number":1681,"context_line":"        This call is made on the \u0027active\u0027 replica\u0027s host, since drivers may"},{"line_number":1682,"context_line":"        not be able to revert snapshots on individual replicas."},{"line_number":1683,"context_line":""},{"line_number":1684,"context_line":"        :param context: Current context"},{"line_number":1685,"context_line":"        :param active_replica: The current active replica"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_6c6e9e30","line":1682,"range":{"start_line":1680,"start_character":0,"end_line":1682,"end_character":63},"updated":"2016-07-28 22:28:33.000000000","message":"for consistency, we should make this the first statement in the body of the docstring, within a \u0027.. note::\u0027","commit_id":"42d27856637161f8e92dfde6e2ca3a3d52b66aaa"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2a1d1375628ff413bd3b9caeb5ada3188915cb53","unresolved":false,"context_lines":[{"line_number":1677,"context_line":"        The share must be reverted in place to the contents of the snapshot."},{"line_number":1678,"context_line":"        Application writers should quiesce or otherwise prepare the application"},{"line_number":1679,"context_line":"        for the shared file system contents to change suddenly."},{"line_number":1680,"context_line":""},{"line_number":1681,"context_line":"        This call is made on the \u0027active\u0027 replica\u0027s host, since drivers may"},{"line_number":1682,"context_line":"        not be able to revert snapshots on individual replicas."},{"line_number":1683,"context_line":""},{"line_number":1684,"context_line":"        :param context: Current context"},{"line_number":1685,"context_line":"        :param active_replica: The current active replica"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_bf2f163d","line":1682,"range":{"start_line":1680,"start_character":0,"end_line":1682,"end_character":63},"in_reply_to":"bacf61ea_6c6e9e30","updated":"2016-07-28 23:19:36.000000000","message":"Done","commit_id":"42d27856637161f8e92dfde6e2ca3a3d52b66aaa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a1acc1014f5e2fb86a4417cbfa8fc97b06e76e15","unresolved":false,"context_lines":[{"line_number":1779,"context_line":"                                   replica_snapshot, share_server\u003dNone):"},{"line_number":1780,"context_line":"        \"\"\"Update the status of a snapshot instance that lives on a replica."},{"line_number":1781,"context_line":""},{"line_number":1782,"context_line":"        .. note::"},{"line_number":1783,"context_line":"            For DR and Readable styles of replication, this call is made on"},{"line_number":1784,"context_line":"            the replica\u0027s host and not the \u0027active\u0027 replica\u0027s host."},{"line_number":1785,"context_line":""},{"line_number":1786,"context_line":"        This method is called periodically by the share manager. It will"},{"line_number":1787,"context_line":"        query for snapshot instances that track the parent snapshot across"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_ac7896f3","line":1784,"range":{"start_line":1782,"start_character":6,"end_line":1784,"end_character":67},"updated":"2016-07-28 22:28:33.000000000","message":"like this","commit_id":"42d27856637161f8e92dfde6e2ca3a3d52b66aaa"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2a1d1375628ff413bd3b9caeb5ada3188915cb53","unresolved":false,"context_lines":[{"line_number":1779,"context_line":"                                   replica_snapshot, share_server\u003dNone):"},{"line_number":1780,"context_line":"        \"\"\"Update the status of a snapshot instance that lives on a replica."},{"line_number":1781,"context_line":""},{"line_number":1782,"context_line":"        .. note::"},{"line_number":1783,"context_line":"            For DR and Readable styles of replication, this call is made on"},{"line_number":1784,"context_line":"            the replica\u0027s host and not the \u0027active\u0027 replica\u0027s host."},{"line_number":1785,"context_line":""},{"line_number":1786,"context_line":"        This method is called periodically by the share manager. It will"},{"line_number":1787,"context_line":"        query for snapshot instances that track the parent snapshot across"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_1f274265","line":1784,"range":{"start_line":1782,"start_character":6,"end_line":1784,"end_character":67},"in_reply_to":"bacf61ea_ac7896f3","updated":"2016-07-28 23:19:36.000000000","message":"Done","commit_id":"42d27856637161f8e92dfde6e2ca3a3d52b66aaa"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"de7855b28bc366410a49c24fe23251a9085cd7d7","unresolved":false,"context_lines":[{"line_number":821,"context_line":"        # Note(zhiteng): These information are driver/backend specific,"},{"line_number":822,"context_line":"        # each driver may define these values in its own config options"},{"line_number":823,"context_line":"        # or fetch from driver specific configuration file."},{"line_number":824,"context_line":"        common \u003d dict("},{"line_number":825,"context_line":"            share_backend_name\u003dbackend_name or \u0027Generic_NFS\u0027,"},{"line_number":826,"context_line":"            driver_handles_share_servers\u003dself.driver_handles_share_servers,"},{"line_number":827,"context_line":"            vendor_name\u003d\u0027Open Source\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_b4289b87","line":824,"range":{"start_line":824,"start_character":7,"end_line":824,"end_character":22},"updated":"2016-07-30 04:48:07.000000000","message":"As we add revert-to-snapshot as a common capability. We need to add revert-to-snapshot in this dict, let the backend report the revert-to-snapshot capability to the scheduler.\nIf we not add revert-to-snapshot capability in this common dict, and the vendor driver not export the revert-to-snapshot capability, the revert-to-snapshot capability will not have a default value(False). so the scheduler can not filter the host with revert-to-snapshot capability.","commit_id":"ff0c6090fd4e144151bf43493bf7efc92c07937a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"c1e60a687f3d27db989e2900bbdbd6efc2ad2620","unresolved":false,"context_lines":[{"line_number":821,"context_line":"        # Note(zhiteng): These information are driver/backend specific,"},{"line_number":822,"context_line":"        # each driver may define these values in its own config options"},{"line_number":823,"context_line":"        # or fetch from driver specific configuration file."},{"line_number":824,"context_line":"        common \u003d dict("},{"line_number":825,"context_line":"            share_backend_name\u003dbackend_name or \u0027Generic_NFS\u0027,"},{"line_number":826,"context_line":"            driver_handles_share_servers\u003dself.driver_handles_share_servers,"},{"line_number":827,"context_line":"            vendor_name\u003d\u0027Open Source\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_d44ee86d","line":824,"range":{"start_line":824,"start_character":7,"end_line":824,"end_character":22},"in_reply_to":"bacf61ea_b4289b87","updated":"2016-07-30 17:36:37.000000000","message":"Done","commit_id":"ff0c6090fd4e144151bf43493bf7efc92c07937a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c50eb411c6ce9116b9d319d968445c371e7b5240","unresolved":false,"context_lines":[{"line_number":816,"context_line":""},{"line_number":817,"context_line":"        return self._creating_shares_from_snapshots_is_supported"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"    @property"},{"line_number":820,"context_line":"    def revert_to_snapshot_support(self):"},{"line_number":821,"context_line":"        \"\"\"Calculate default value for revert_to_snapshot_support.\"\"\""},{"line_number":822,"context_line":""},{"line_number":823,"context_line":"        if not hasattr(self, \u0027_revert_to_snapshot_support\u0027):"},{"line_number":824,"context_line":"            methods \u003d (\u0027revert_to_snapshot\u0027, )"},{"line_number":825,"context_line":"            self._revert_to_snapshot_support \u003d ("},{"line_number":826,"context_line":"                self._has_redefined_driver_methods(methods))"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        return self._revert_to_snapshot_support"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"    def _update_share_stats(self, data\u003dNone):"},{"line_number":831,"context_line":"        \"\"\"Retrieve stats info from share group."}],"source_content_type":"text/x-python","patch_set":20,"id":"7a77a97e_19860bdb","line":828,"range":{"start_line":819,"start_character":2,"end_line":828,"end_character":47},"updated":"2016-11-17 16:22:39.000000000","message":"according to discussion on IRC. We should not detect the capability value automatically for this feature. \n\n1) there is no existing code for this feature\n2) driver maintainers should to implement and report the capability when doing so at this point\n3) there is a use case where a pool may want to report True/False, and this mechanism prevents that","commit_id":"eb7431c4ddf98d46cb1b7da6831bbfede285a4fa"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"bf62c8c610f748d9bdc8ff3d6604022968cb61fe","unresolved":false,"context_lines":[{"line_number":816,"context_line":""},{"line_number":817,"context_line":"        return self._creating_shares_from_snapshots_is_supported"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"    @property"},{"line_number":820,"context_line":"    def revert_to_snapshot_support(self):"},{"line_number":821,"context_line":"        \"\"\"Calculate default value for revert_to_snapshot_support.\"\"\""},{"line_number":822,"context_line":""},{"line_number":823,"context_line":"        if not hasattr(self, \u0027_revert_to_snapshot_support\u0027):"},{"line_number":824,"context_line":"            methods \u003d (\u0027revert_to_snapshot\u0027, )"},{"line_number":825,"context_line":"            self._revert_to_snapshot_support \u003d ("},{"line_number":826,"context_line":"                self._has_redefined_driver_methods(methods))"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        return self._revert_to_snapshot_support"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"    def _update_share_stats(self, data\u003dNone):"},{"line_number":831,"context_line":"        \"\"\"Retrieve stats info from share group."}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5201f7_eeb97516","line":828,"range":{"start_line":819,"start_character":2,"end_line":828,"end_character":47},"in_reply_to":"7a77a97e_19860bdb","updated":"2017-01-05 18:33:25.000000000","message":"Done","commit_id":"eb7431c4ddf98d46cb1b7da6831bbfede285a4fa"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7913176b6c147f742b6083f6cf88e48bb5511d75","unresolved":false,"context_lines":[{"line_number":948,"context_line":"            self.snapshots_are_supported"},{"line_number":949,"context_line":"        )"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    @property"},{"line_number":952,"context_line":"    def revert_to_snapshot_support(self):"},{"line_number":953,"context_line":"        \"\"\"Calculate default value for revert_to_snapshot_support.\"\"\""},{"line_number":954,"context_line":""},{"line_number":955,"context_line":"        if not hasattr(self, \u0027_revert_to_snapshot_support\u0027):"},{"line_number":956,"context_line":"            methods \u003d (\u0027revert_to_snapshot\u0027, )"},{"line_number":957,"context_line":"            self._revert_to_snapshot_support \u003d ("},{"line_number":958,"context_line":"                self._has_redefined_driver_methods(methods))"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"        return self._revert_to_snapshot_support"},{"line_number":961,"context_line":""},{"line_number":962,"context_line":"    def _update_share_stats(self, data\u003dNone):"},{"line_number":963,"context_line":"        \"\"\"Retrieve stats info from share group."}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5201f7_285e2644","line":960,"range":{"start_line":951,"start_character":4,"end_line":960,"end_character":47},"updated":"2017-01-05 11:31:26.000000000","message":"previous comment on PS #20 not addressed","commit_id":"d1cd83eea9dda5f4e3b98df864642cde6052d0e7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":864,"context_line":"        so the driver doesn\u0027t have to."},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"        The share must be reverted in place to the contents of the snapshot."},{"line_number":867,"context_line":"        Application writers should quiesce or otherwise prepare the application"},{"line_number":868,"context_line":"        for the shared file system contents to change suddenly."},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"        :param context: Current context"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_6e8bbac3","line":867,"range":{"start_line":867,"start_character":8,"end_line":867,"end_character":27},"updated":"2017-01-06 01:38:58.000000000","message":"Driver authors?","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":864,"context_line":"        so the driver doesn\u0027t have to."},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"        The share must be reverted in place to the contents of the snapshot."},{"line_number":867,"context_line":"        Application writers should quiesce or otherwise prepare the application"},{"line_number":868,"context_line":"        for the shared file system contents to change suddenly."},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"        :param context: Current context"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_c42f2586","line":867,"range":{"start_line":867,"start_character":8,"end_line":867,"end_character":27},"in_reply_to":"ba5201f7_6e8bbac3","updated":"2017-01-06 03:19:17.000000000","message":"Here I\u0027m referring to the consumer of Manila shares, which can change suddenly and significantly during a revert operation.  I was just trying to help the driver authors understand what is meant by an \"in place\" reversion.  But perhaps \"Application admins\" would be better.  Changed.","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":1822,"context_line":"        so the driver doesn\u0027t have to."},{"line_number":1823,"context_line":""},{"line_number":1824,"context_line":"        The share must be reverted in place to the contents of the snapshot."},{"line_number":1825,"context_line":"        Application writers should quiesce or otherwise prepare the application"},{"line_number":1826,"context_line":"        for the shared file system contents to change suddenly."},{"line_number":1827,"context_line":""},{"line_number":1828,"context_line":"        :param context: Current context"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_ce8e66cf","line":1825,"range":{"start_line":1825,"start_character":8,"end_line":1825,"end_character":19},"updated":"2017-01-06 01:38:58.000000000","message":"same","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":1822,"context_line":"        so the driver doesn\u0027t have to."},{"line_number":1823,"context_line":""},{"line_number":1824,"context_line":"        The share must be reverted in place to the contents of the snapshot."},{"line_number":1825,"context_line":"        Application writers should quiesce or otherwise prepare the application"},{"line_number":1826,"context_line":"        for the shared file system contents to change suddenly."},{"line_number":1827,"context_line":""},{"line_number":1828,"context_line":"        :param context: Current context"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_c45d6516","line":1825,"range":{"start_line":1825,"start_character":8,"end_line":1825,"end_character":19},"in_reply_to":"ba5201f7_ce8e66cf","updated":"2017-01-06 03:19:17.000000000","message":"Changed to \"Application admins\"","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"}],"manila/share/drivers/lvm.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"151578f7ab1af980a5ee5da30fe20487c813cc40","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                self.configuration.reserved_share_percentage,"},{"line_number":191,"context_line":"            \u0027consistency_group_support\u0027: None,"},{"line_number":192,"context_line":"            \u0027snapshot_support\u0027: True,"},{"line_number":193,"context_line":"            \u0027create_share_from_snapshot_support\u0027: True,"},{"line_number":194,"context_line":"            \u0027driver_name\u0027: \u0027LVMShareDriver\u0027,"},{"line_number":195,"context_line":"            \u0027pools\u0027: self.get_share_server_pools()"},{"line_number":196,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba5201f7_d29b5c64","line":193,"range":{"start_line":193,"start_character":12,"end_line":193,"end_character":55},"updated":"2017-01-06 09:54:02.000000000","message":"you need to report the capability here","commit_id":"abb29db5abd7a59c60ec2368f36d9e0cda19cabf"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"6e70fbf0d1c4de389a7629e9771c5aa0195e8bf3","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                self.configuration.reserved_share_percentage,"},{"line_number":191,"context_line":"            \u0027consistency_group_support\u0027: None,"},{"line_number":192,"context_line":"            \u0027snapshot_support\u0027: True,"},{"line_number":193,"context_line":"            \u0027create_share_from_snapshot_support\u0027: True,"},{"line_number":194,"context_line":"            \u0027driver_name\u0027: \u0027LVMShareDriver\u0027,"},{"line_number":195,"context_line":"            \u0027pools\u0027: self.get_share_server_pools()"},{"line_number":196,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba5201f7_ea6141d4","line":193,"range":{"start_line":193,"start_character":12,"end_line":193,"end_character":55},"in_reply_to":"ba5201f7_d29b5c64","updated":"2017-01-06 14:55:13.000000000","message":"Thanks, Rodrigo.","commit_id":"abb29db5abd7a59c60ec2368f36d9e0cda19cabf"}],"manila/share/manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"CONF \u003d cfg.CONF"},{"line_number":104,"context_line":"CONF.register_opts(share_manager_opts)"},{"line_number":105,"context_line":"CONF.import_opt(\u0027periodic_hooks_interval\u0027, \u0027manila.share.hook\u0027)"},{"line_number":106,"context_line":"CONF.import_opt(\u0027periodic_interval\u0027, \u0027manila.service\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"# Drivers that need to change module paths or class names can add their"},{"line_number":109,"context_line":"# old/new path here to maintain backward compatibility."}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_f956aed0","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":54},"updated":"2016-07-17 03:26:10.000000000","message":"is this related? the share manager is a service.. so, we have the opt imported implicitly?","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"CONF \u003d cfg.CONF"},{"line_number":104,"context_line":"CONF.register_opts(share_manager_opts)"},{"line_number":105,"context_line":"CONF.import_opt(\u0027periodic_hooks_interval\u0027, \u0027manila.share.hook\u0027)"},{"line_number":106,"context_line":"CONF.import_opt(\u0027periodic_interval\u0027, \u0027manila.service\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"# Drivers that need to change module paths or class names can add their"},{"line_number":109,"context_line":"# old/new path here to maintain backward compatibility."}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_74c50d5a","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":54},"in_reply_to":"fad55976_f956aed0","updated":"2016-07-27 21:50:08.000000000","message":"Already fixed in a different patch.  No need to have this here now.\n\nBut yes, it was related, since without it I couldn\u0027t run the unit tests in PyCharm.","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bbb50434395f835e49b80b340dc9cc214bddd9b","unresolved":false,"context_lines":[{"line_number":2105,"context_line":"        \"\"\"Find the active replica matching this manager\u0027s host.\"\"\""},{"line_number":2106,"context_line":"        for replica in replica_list:"},{"line_number":2107,"context_line":"            if (replica[\u0027replica_state\u0027] \u003d\u003d constants.REPLICA_STATE_ACTIVE and"},{"line_number":2108,"context_line":"                    share_utils.extract_host(replica.host) \u003d\u003d self.host):"},{"line_number":2109,"context_line":"                return replica"},{"line_number":2110,"context_line":""},{"line_number":2111,"context_line":"    @locked_share_replica_operation"}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_59453a15","line":2108,"range":{"start_line":2108,"start_character":45,"end_line":2108,"end_character":57},"updated":"2016-07-17 03:26:10.000000000","message":"replica[\u0027host\u0027], we want to convert these to primitives at the db_api; someday..","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"4587935e77322757d99b2d7af83a15f3addff66a","unresolved":false,"context_lines":[{"line_number":2105,"context_line":"        \"\"\"Find the active replica matching this manager\u0027s host.\"\"\""},{"line_number":2106,"context_line":"        for replica in replica_list:"},{"line_number":2107,"context_line":"            if (replica[\u0027replica_state\u0027] \u003d\u003d constants.REPLICA_STATE_ACTIVE and"},{"line_number":2108,"context_line":"                    share_utils.extract_host(replica.host) \u003d\u003d self.host):"},{"line_number":2109,"context_line":"                return replica"},{"line_number":2110,"context_line":""},{"line_number":2111,"context_line":"    @locked_share_replica_operation"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_dd35fdf7","line":2108,"range":{"start_line":2108,"start_character":45,"end_line":2108,"end_character":57},"in_reply_to":"fad55976_59453a15","updated":"2016-07-27 21:50:08.000000000","message":"Done","commit_id":"c5549e2879227e22caacb69df9dc608c4ebff88b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"de7855b28bc366410a49c24fe23251a9085cd7d7","unresolved":false,"context_lines":[{"line_number":1882,"context_line":"        self.db.share_snapshot_update("},{"line_number":1883,"context_line":"            context, snapshot_id, {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":1884,"context_line":""},{"line_number":1885,"context_line":"        msg \u003d _LI(\u0027Share %(share)s reverted to snapshot %(snap)s.\u0027)"},{"line_number":1886,"context_line":"        msg_args \u003d {\u0027share\u0027: share_id, \u0027snap\u0027: snapshot_id}"},{"line_number":1887,"context_line":"        LOG.info(msg, msg_args)"},{"line_number":1888,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_f11ea55d","line":1885,"range":{"start_line":1885,"start_character":64,"end_line":1885,"end_character":65},"updated":"2016-07-30 04:48:07.000000000","message":"successfully?","commit_id":"ff0c6090fd4e144151bf43493bf7efc92c07937a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"c1e60a687f3d27db989e2900bbdbd6efc2ad2620","unresolved":false,"context_lines":[{"line_number":1882,"context_line":"        self.db.share_snapshot_update("},{"line_number":1883,"context_line":"            context, snapshot_id, {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":1884,"context_line":""},{"line_number":1885,"context_line":"        msg \u003d _LI(\u0027Share %(share)s reverted to snapshot %(snap)s.\u0027)"},{"line_number":1886,"context_line":"        msg_args \u003d {\u0027share\u0027: share_id, \u0027snap\u0027: snapshot_id}"},{"line_number":1887,"context_line":"        LOG.info(msg, msg_args)"},{"line_number":1888,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_94b75039","line":1885,"range":{"start_line":1885,"start_character":64,"end_line":1885,"end_character":65},"in_reply_to":"bacf61ea_f11ea55d","updated":"2016-07-30 17:36:37.000000000","message":"Well, it\u0027s a bit redundant, but it does seem to be a convention with 18 occurrences in this file already.  So I added it here and below in the replicated method.","commit_id":"ff0c6090fd4e144151bf43493bf7efc92c07937a"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"aef1d1cd61005b0f88f8a04d0522c55bf23ee268","unresolved":false,"context_lines":[{"line_number":2130,"context_line":"                with_share_data\u003dTrue))"},{"line_number":2131,"context_line":"        snapshot_instance_filters \u003d {"},{"line_number":2132,"context_line":"            \u0027share_instance_ids\u0027: active_replica[\u0027id\u0027],"},{"line_number":2133,"context_line":"            \u0027snapshot_ids\u0027: snapshot_id,"},{"line_number":2134,"context_line":"        }"},{"line_number":2135,"context_line":"        active_replica_snapshot \u003d ("},{"line_number":2136,"context_line":"            self.db.share_snapshot_instance_get_all_with_filters("}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_d47edd68","line":2133,"updated":"2016-07-31 16:59:04.000000000","message":"Same comment here.  There is only one id for snapshot and one id for active_replica, so it should be \u0027share_instance_id\u0027 and \u0027snapshot_id\u0027.","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f699467c47f44c9a9dafada0924c5c708d5ca81f","unresolved":false,"context_lines":[{"line_number":2130,"context_line":"                with_share_data\u003dTrue))"},{"line_number":2131,"context_line":"        snapshot_instance_filters \u003d {"},{"line_number":2132,"context_line":"            \u0027share_instance_ids\u0027: active_replica[\u0027id\u0027],"},{"line_number":2133,"context_line":"            \u0027snapshot_ids\u0027: snapshot_id,"},{"line_number":2134,"context_line":"        }"},{"line_number":2135,"context_line":"        active_replica_snapshot \u003d ("},{"line_number":2136,"context_line":"            self.db.share_snapshot_instance_get_all_with_filters("}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_5253ef16","line":2133,"in_reply_to":"bacf61ea_d47edd68","updated":"2016-08-01 19:27:23.000000000","message":"Same answer :-)\n\nhttps://github.com/openstack/manila/blob/master/manila/db/sqlalchemy/api.py#L1938","commit_id":"2e84f52ffec7d7aa8ffb4ba9cfa27484549ffdce"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"39198a5f3ae822d29c53173bdd28fd9d91f4420c","unresolved":false,"context_lines":[{"line_number":1660,"context_line":"                or {}"},{"line_number":1661,"context_line":"            )"},{"line_number":1662,"context_line":""},{"line_number":1663,"context_line":"            if not snapshot_update.get(\u0027size\u0027):"},{"line_number":1664,"context_line":"                snapshot_update[\u0027size\u0027] \u003d snapshot_ref[\u0027share\u0027][\u0027size\u0027]"},{"line_number":1665,"context_line":"                LOG.warning(_LI(\"Cannot get the size of the snapshot \""},{"line_number":1666,"context_line":"                                \"%(snapshot_id)s. Using the size of \""},{"line_number":1667,"context_line":"                                \"the share instead.\"),"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a77a97e_fc52f333","line":1664,"range":{"start_line":1663,"start_character":12,"end_line":1664,"end_character":71},"updated":"2016-11-18 13:07:58.000000000","message":"this is prone to creating problems when reverting to snapshot. Consider the following situation:\n\nthe snapshot has 10gb of contents, but the share has been shrinked to 5gb since the snapshot has been taken, so this code considers the snapshot size to be 5gb. This could create a mess when reverting this managed snapshot.","commit_id":"eb7431c4ddf98d46cb1b7da6831bbfede285a4fa"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"bf62c8c610f748d9bdc8ff3d6604022968cb61fe","unresolved":false,"context_lines":[{"line_number":1660,"context_line":"                or {}"},{"line_number":1661,"context_line":"            )"},{"line_number":1662,"context_line":""},{"line_number":1663,"context_line":"            if not snapshot_update.get(\u0027size\u0027):"},{"line_number":1664,"context_line":"                snapshot_update[\u0027size\u0027] \u003d snapshot_ref[\u0027share\u0027][\u0027size\u0027]"},{"line_number":1665,"context_line":"                LOG.warning(_LI(\"Cannot get the size of the snapshot \""},{"line_number":1666,"context_line":"                                \"%(snapshot_id)s. Using the size of \""},{"line_number":1667,"context_line":"                                \"the share instead.\"),"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5201f7_2d970649","line":1664,"range":{"start_line":1663,"start_character":12,"end_line":1664,"end_character":71},"in_reply_to":"7a77a97e_fc52f333","updated":"2017-01-05 18:33:25.000000000","message":"These lines are a fallback in case the driver cannot determine the true size of a snapshot being managed, so while what you are describing could happen, it\u0027s a corner case.\n\nBut this could happen anyway.  Reverting a share to a larger snapshot in a pool that is completely out of space is guaranteed to fail, which we can\u0027t really prevent.  I discussed this possibility with Ben a while back, and his feeling was that clouds shouldn\u0027t be running that close to the edge.\n\nAnd shares tend to grow, not shrink, over time, so this is a low-probability corner case in any event.","commit_id":"eb7431c4ddf98d46cb1b7da6831bbfede285a4fa"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e991d96dbc1d96ddf1bfc6f7bf6a76c19a468908","unresolved":false,"context_lines":[{"line_number":1851,"context_line":"            context, snapshot_instance)"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"        try:"},{"line_number":1854,"context_line":"            self.driver.revert_to_snapshot(context,"},{"line_number":1855,"context_line":"                                           snapshot_instance_dict,"},{"line_number":1856,"context_line":"                                           share_server\u003dshare_server)"},{"line_number":1857,"context_line":"        except Exception:"},{"line_number":1858,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1859,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1a6eadb0_2ecbbb73","line":1856,"range":{"start_line":1854,"start_character":12,"end_line":1856,"end_character":69},"updated":"2016-12-14 10:47:54.000000000","message":"have you considered invoking update_access after reverting? I believe that some driver may lose access rules when reverting, and you are not supplying them with the set of access rules to apply.","commit_id":"eb7431c4ddf98d46cb1b7da6831bbfede285a4fa"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"bf62c8c610f748d9bdc8ff3d6604022968cb61fe","unresolved":false,"context_lines":[{"line_number":1851,"context_line":"            context, snapshot_instance)"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"        try:"},{"line_number":1854,"context_line":"            self.driver.revert_to_snapshot(context,"},{"line_number":1855,"context_line":"                                           snapshot_instance_dict,"},{"line_number":1856,"context_line":"                                           share_server\u003dshare_server)"},{"line_number":1857,"context_line":"        except Exception:"},{"line_number":1858,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1859,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5201f7_5174ea66","line":1856,"range":{"start_line":1854,"start_character":12,"end_line":1856,"end_character":69},"in_reply_to":"1a6eadb0_2ecbbb73","updated":"2017-01-05 18:33:25.000000000","message":"A good question, but I expect a revert to work without loss of access.  I would consider that to be a backend limitation that the driver must work around by reading and reapplying the rules on its own.  It doesn\u0027t make sense to me to always invoke update_access for every driver just because a one or two don\u0027t work well.","commit_id":"eb7431c4ddf98d46cb1b7da6831bbfede285a4fa"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7913176b6c147f742b6083f6cf88e48bb5511d75","unresolved":false,"context_lines":[{"line_number":1986,"context_line":"                or {}"},{"line_number":1987,"context_line":"            )"},{"line_number":1988,"context_line":""},{"line_number":1989,"context_line":"            if not snapshot_update.get(\u0027size\u0027):"},{"line_number":1990,"context_line":"                snapshot_update[\u0027size\u0027] \u003d snapshot_ref[\u0027share\u0027][\u0027size\u0027]"},{"line_number":1991,"context_line":"                LOG.warning(_LW(\"Cannot get the size of the snapshot \""},{"line_number":1992,"context_line":"                                \"%(snapshot_id)s. Using the size of \""},{"line_number":1993,"context_line":"                                \"the share instead.\"),"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5201f7_2313a75c","line":1990,"range":{"start_line":1989,"start_character":12,"end_line":1990,"end_character":71},"updated":"2017-01-05 11:31:26.000000000","message":"previous concern on PS #20 not addressed. Please provide a response","commit_id":"d1cd83eea9dda5f4e3b98df864642cde6052d0e7"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7913176b6c147f742b6083f6cf88e48bb5511d75","unresolved":false,"context_lines":[{"line_number":2176,"context_line":"            context, snapshot_instance)"},{"line_number":2177,"context_line":""},{"line_number":2178,"context_line":"        try:"},{"line_number":2179,"context_line":"            self.driver.revert_to_snapshot(context,"},{"line_number":2180,"context_line":"                                           snapshot_instance_dict,"},{"line_number":2181,"context_line":"                                           share_server\u003dshare_server)"},{"line_number":2182,"context_line":"        except Exception:"},{"line_number":2183,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2184,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5201f7_6802ee0c","line":2181,"range":{"start_line":2179,"start_character":12,"end_line":2181,"end_character":69},"updated":"2017-01-05 11:31:26.000000000","message":"previous comment on PS #20 not addressed","commit_id":"d1cd83eea9dda5f4e3b98df864642cde6052d0e7"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9df231547381249215cb3f7dd22f0fcc5f6a2758","unresolved":false,"context_lines":[{"line_number":2165,"context_line":"        user_id \u003d share[\u0027user_id\u0027]"},{"line_number":2166,"context_line":""},{"line_number":2167,"context_line":"        snapshot_instance \u003d self.db.share_snapshot_instance_get("},{"line_number":2168,"context_line":"            context, snapshot.instance[\u0027id\u0027], with_share_data\u003dTrue)"},{"line_number":2169,"context_line":""},{"line_number":2170,"context_line":"        # Make primitive to pass the information to the driver"},{"line_number":2171,"context_line":"        snapshot_instance_dict \u003d self._get_snapshot_instance_dict("}],"source_content_type":"text/x-python","patch_set":30,"id":"ba5201f7_fabc9ddd","line":2168,"range":{"start_line":2168,"start_character":46,"end_line":2168,"end_character":66},"updated":"2017-01-07 00:25:00.000000000","message":"(see comment below first). Unfortunately this does not retrieve the snapshot model fields, such as size, and the share size should not be used instead.","commit_id":"da98f28ffc6bd15fef84922a32b83b6d39371667"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9df231547381249215cb3f7dd22f0fcc5f6a2758","unresolved":false,"context_lines":[{"line_number":2168,"context_line":"            context, snapshot.instance[\u0027id\u0027], with_share_data\u003dTrue)"},{"line_number":2169,"context_line":""},{"line_number":2170,"context_line":"        # Make primitive to pass the information to the driver"},{"line_number":2171,"context_line":"        snapshot_instance_dict \u003d self._get_snapshot_instance_dict("},{"line_number":2172,"context_line":"            context, snapshot_instance)"},{"line_number":2173,"context_line":""},{"line_number":2174,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba5201f7_3adc6545","line":2171,"range":{"start_line":2171,"start_character":38,"end_line":2171,"end_character":65},"updated":"2017-01-07 00:25:00.000000000","message":"Clinton, for my driver it is important that the snapshot dict contains the snapshot size information. The snapshot model has this, unfortunately the snapshot instance model does not.","commit_id":"da98f28ffc6bd15fef84922a32b83b6d39371667"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"650e8e47a2c82a01a4c42619b1e806ff4e88850c","unresolved":false,"context_lines":[{"line_number":2168,"context_line":"            context, snapshot.instance[\u0027id\u0027], with_share_data\u003dTrue)"},{"line_number":2169,"context_line":""},{"line_number":2170,"context_line":"        # Make primitive to pass the information to the driver"},{"line_number":2171,"context_line":"        snapshot_instance_dict \u003d self._get_snapshot_instance_dict("},{"line_number":2172,"context_line":"            context, snapshot_instance)"},{"line_number":2173,"context_line":""},{"line_number":2174,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba5201f7_96c7ba63","line":2171,"range":{"start_line":2171,"start_character":38,"end_line":2171,"end_character":65},"in_reply_to":"ba5201f7_1624bcc4","updated":"2017-01-09 16:34:57.000000000","message":"Done.","commit_id":"da98f28ffc6bd15fef84922a32b83b6d39371667"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8c76f35928ace626b9d678d2a12de093e0ae082d","unresolved":false,"context_lines":[{"line_number":2168,"context_line":"            context, snapshot.instance[\u0027id\u0027], with_share_data\u003dTrue)"},{"line_number":2169,"context_line":""},{"line_number":2170,"context_line":"        # Make primitive to pass the information to the driver"},{"line_number":2171,"context_line":"        snapshot_instance_dict \u003d self._get_snapshot_instance_dict("},{"line_number":2172,"context_line":"            context, snapshot_instance)"},{"line_number":2173,"context_line":""},{"line_number":2174,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba5201f7_638f1375","line":2171,"range":{"start_line":2171,"start_character":38,"end_line":2171,"end_character":65},"in_reply_to":"ba5201f7_3adc6545","updated":"2017-01-09 04:36:58.000000000","message":"I\u0027m curious why you need the size in the driver.  And specifically, you would want the \u0027size\u0027 field from the snapshot object?\n\nThe manager has the info at this point already, so it would be simple (if a tad weird) to add that field to the snapshot_instance_dict here.  Is that what you are requesting?","commit_id":"da98f28ffc6bd15fef84922a32b83b6d39371667"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7ab6dc62699e0c80a4e0d3bfc55c1d25e8518fff","unresolved":false,"context_lines":[{"line_number":2168,"context_line":"            context, snapshot.instance[\u0027id\u0027], with_share_data\u003dTrue)"},{"line_number":2169,"context_line":""},{"line_number":2170,"context_line":"        # Make primitive to pass the information to the driver"},{"line_number":2171,"context_line":"        snapshot_instance_dict \u003d self._get_snapshot_instance_dict("},{"line_number":2172,"context_line":"            context, snapshot_instance)"},{"line_number":2173,"context_line":""},{"line_number":2174,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba5201f7_1624bcc4","line":2171,"range":{"start_line":2171,"start_character":38,"end_line":2171,"end_character":65},"in_reply_to":"ba5201f7_638f1375","updated":"2017-01-09 10:24:30.000000000","message":"Yes, the size field from the snapshot object will do. Could you please make this change?\n\nMy backend cannot determine the snapshot size, so the driver relies on the snapshot size information taken from the share when the snapshot was taken.","commit_id":"da98f28ffc6bd15fef84922a32b83b6d39371667"}],"manila/tests/api/v2/test_shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                         stubs.stub_snapshot_get)"},{"line_number":64,"context_line":"        self.maxDiff \u003d None"},{"line_number":65,"context_line":"        self.share \u003d {"},{"line_number":66,"context_line":"            \"id\": \"1\","},{"line_number":67,"context_line":"            \"size\": 100,"},{"line_number":68,"context_line":"            \"display_name\": \"Share Test Name\","},{"line_number":69,"context_line":"            \"display_description\": \"Share Test Desc\","}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_0954e8fc","line":66,"range":{"start_line":66,"start_character":18,"end_line":66,"end_character":21},"updated":"2017-01-06 01:38:58.000000000","message":"uuidutils.generate_uuid()","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                         stubs.stub_snapshot_get)"},{"line_number":64,"context_line":"        self.maxDiff \u003d None"},{"line_number":65,"context_line":"        self.share \u003d {"},{"line_number":66,"context_line":"            \"id\": \"1\","},{"line_number":67,"context_line":"            \"size\": 100,"},{"line_number":68,"context_line":"            \"display_name\": \"Share Test Name\","},{"line_number":69,"context_line":"            \"display_description\": \"Share Test Desc\","}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_844a7d24","line":66,"range":{"start_line":66,"start_character":18,"end_line":66,"end_character":21},"in_reply_to":"ba5201f7_0954e8fc","updated":"2017-01-06 03:19:17.000000000","message":"I\u0027m not opposed to making this value a valid UUID, but self.share is used in dozens of tests in this file, not just the new ones.  Are you suggesting I change them all?  I can do it, but then some other reviewer is bound to say it\u0027s out of scope.","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            \u0027name\u0027: \u0027fake_volume_type_name\u0027,"},{"line_number":89,"context_line":"        }"},{"line_number":90,"context_line":"        self.snapshot \u003d {"},{"line_number":91,"context_line":"            \u0027id\u0027: \u00272\u0027,"},{"line_number":92,"context_line":"            \u0027share_id\u0027: \u00271\u0027,"},{"line_number":93,"context_line":"            \u0027status\u0027: constants.STATUS_AVAILABLE,"},{"line_number":94,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_a9603cd0","line":91,"range":{"start_line":91,"start_character":18,"end_line":91,"end_character":21},"updated":"2017-01-06 01:38:58.000000000","message":"uuidutils.generate_uuid()","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            \u0027name\u0027: \u0027fake_volume_type_name\u0027,"},{"line_number":89,"context_line":"        }"},{"line_number":90,"context_line":"        self.snapshot \u003d {"},{"line_number":91,"context_line":"            \u0027id\u0027: \u00272\u0027,"},{"line_number":92,"context_line":"            \u0027share_id\u0027: \u00271\u0027,"},{"line_number":93,"context_line":"            \u0027status\u0027: constants.STATUS_AVAILABLE,"},{"line_number":94,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_c41565e5","line":91,"range":{"start_line":91,"start_character":18,"end_line":91,"end_character":21},"in_reply_to":"ba5201f7_a9603cd0","updated":"2017-01-06 03:19:17.000000000","message":"Same.","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        }"},{"line_number":90,"context_line":"        self.snapshot \u003d {"},{"line_number":91,"context_line":"            \u0027id\u0027: \u00272\u0027,"},{"line_number":92,"context_line":"            \u0027share_id\u0027: \u00271\u0027,"},{"line_number":93,"context_line":"            \u0027status\u0027: constants.STATUS_AVAILABLE,"},{"line_number":94,"context_line":"        }"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_6943b442","line":92,"range":{"start_line":92,"start_character":24,"end_line":92,"end_character":27},"updated":"2017-01-06 01:38:58.000000000","message":"self.share[\u0027id\u0027]","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        }"},{"line_number":90,"context_line":"        self.snapshot \u003d {"},{"line_number":91,"context_line":"            \u0027id\u0027: \u00272\u0027,"},{"line_number":92,"context_line":"            \u0027share_id\u0027: \u00271\u0027,"},{"line_number":93,"context_line":"            \u0027status\u0027: constants.STATUS_AVAILABLE,"},{"line_number":94,"context_line":"        }"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_2424715e","line":92,"range":{"start_line":92,"start_character":24,"end_line":92,"end_character":27},"in_reply_to":"ba5201f7_6943b442","updated":"2017-01-06 03:19:17.000000000","message":"This would work in some places, but in the case where the ID is an input to DDT, I would have to reference a constant.","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        mock_revert_to_snapshot \u003d self.mock_object("},{"line_number":168,"context_line":"            share_api.API, \u0027revert_to_snapshot\u0027)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        response \u003d self.controller._revert(req, \u00271\u0027, body\u003dbody)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        self.assertEqual(202, response.status_int)"},{"line_number":173,"context_line":"        mock_validate_revert_parameters.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_c95d8016","line":170,"range":{"start_line":170,"start_character":48,"end_line":170,"end_character":51},"updated":"2017-01-06 01:38:58.000000000","message":"share[\u0027id\u0027]","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"}],"manila/tests/api/views/test_shares.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95b5d197f59a0e3d40b2ec0ac44bdca6e07be2e1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def test__collection_name(self):"},{"line_number":53,"context_line":"        self.assertEqual(\u0027shares\u0027, self.builder._collection_name)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @ddt.data(\u00272.6\u0027, \u00272.9\u0027, \u00272.10\u0027, \u00272.11\u0027, \u00272.16\u0027, \u00272.23\u0027, \u00272.24\u0027, \u00272.26\u0027)"},{"line_number":56,"context_line":"    def test_detail(self, microversion):"},{"line_number":57,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/shares\u0027, version\u003dmicroversion)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"ba5201f7_1b1b7c74","line":55,"range":{"start_line":55,"start_character":53,"end_line":55,"end_character":57},"updated":"2017-01-11 17:34:01.000000000","message":"Why 2.23 was added?","commit_id":"a60b167ce44f50bf01612e0cea53da6327243b3f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2b30ae355ed6ef3c1d415192ea283bbb0ebce5f5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def test__collection_name(self):"},{"line_number":53,"context_line":"        self.assertEqual(\u0027shares\u0027, self.builder._collection_name)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @ddt.data(\u00272.6\u0027, \u00272.9\u0027, \u00272.10\u0027, \u00272.11\u0027, \u00272.16\u0027, \u00272.23\u0027, \u00272.24\u0027, \u00272.26\u0027)"},{"line_number":56,"context_line":"    def test_detail(self, microversion):"},{"line_number":57,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/shares\u0027, version\u003dmicroversion)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"ba5201f7_1618b11d","line":55,"range":{"start_line":55,"start_character":53,"end_line":55,"end_character":57},"in_reply_to":"ba5201f7_1b1b7c74","updated":"2017-01-11 18:27:52.000000000","message":"I\u0027ve bumped the microversion so many times on this patch, I have no idea!  I may have wanted to test the version just before the current one, but it\u0027s covered now by 2.24.  Removed.","commit_id":"a60b167ce44f50bf01612e0cea53da6327243b3f"}],"manila/tests/db/migrations/alembic/migrations_data_checks.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95b5d197f59a0e3d40b2ec0ac44bdca6e07be2e1","unresolved":false,"context_lines":[{"line_number":1402,"context_line":""},{"line_number":1403,"context_line":"        # Pre-existing Shares must be present"},{"line_number":1404,"context_line":"        shares_in_db \u003d engine.execute(shares_table.select()).fetchall()"},{"line_number":1405,"context_line":"        share_ids_in_db \u003d [s[\u0027id\u0027] for s in shares_in_db]"},{"line_number":1406,"context_line":"        for share_id in share_ids:"},{"line_number":1407,"context_line":"            self.test_case.assertIn(share_id, share_ids_in_db)"},{"line_number":1408,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"ba5201f7_c021034f","line":1405,"range":{"start_line":1405,"start_character":8,"end_line":1405,"end_character":23},"updated":"2017-01-11 17:34:01.000000000","message":"Need to check that it has some data.","commit_id":"a60b167ce44f50bf01612e0cea53da6327243b3f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2b30ae355ed6ef3c1d415192ea283bbb0ebce5f5","unresolved":false,"context_lines":[{"line_number":1402,"context_line":""},{"line_number":1403,"context_line":"        # Pre-existing Shares must be present"},{"line_number":1404,"context_line":"        shares_in_db \u003d engine.execute(shares_table.select()).fetchall()"},{"line_number":1405,"context_line":"        share_ids_in_db \u003d [s[\u0027id\u0027] for s in shares_in_db]"},{"line_number":1406,"context_line":"        for share_id in share_ids:"},{"line_number":1407,"context_line":"            self.test_case.assertIn(share_id, share_ids_in_db)"},{"line_number":1408,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"ba5201f7_f1a17795","line":1405,"range":{"start_line":1405,"start_character":8,"end_line":1405,"end_character":23},"in_reply_to":"ba5201f7_c021034f","updated":"2017-01-11 18:27:52.000000000","message":"Done.  Note that I adapted this set of tests from the immediately preceding one that Goutham wrote for create_share_from_snapshot_support, so I added the same requested assertion there as well.","commit_id":"a60b167ce44f50bf01612e0cea53da6327243b3f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95b5d197f59a0e3d40b2ec0ac44bdca6e07be2e1","unresolved":false,"context_lines":[{"line_number":1409,"context_line":"        # New shares attr must be present and set to False"},{"line_number":1410,"context_line":"        for share in shares_in_db:"},{"line_number":1411,"context_line":"            self.test_case.assertTrue(hasattr(share, self.expected_attr))"},{"line_number":1412,"context_line":"            self.test_case.assertFalse(share[self.expected_attr])"},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"    def check_downgrade(self, engine):"},{"line_number":1415,"context_line":"        share_ids \u003d [s[\u0027id\u0027] for s in self.shares]"}],"source_content_type":"text/x-python","patch_set":36,"id":"ba5201f7_00014baf","line":1412,"range":{"start_line":1412,"start_character":12,"end_line":1412,"end_character":65},"updated":"2017-01-11 17:34:01.000000000","message":"It will pass in lots of cases, not only \"False\" (boolean). So, it is better to use \"assertEuqal(False, %actual%)\"","commit_id":"a60b167ce44f50bf01612e0cea53da6327243b3f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2b30ae355ed6ef3c1d415192ea283bbb0ebce5f5","unresolved":false,"context_lines":[{"line_number":1409,"context_line":"        # New shares attr must be present and set to False"},{"line_number":1410,"context_line":"        for share in shares_in_db:"},{"line_number":1411,"context_line":"            self.test_case.assertTrue(hasattr(share, self.expected_attr))"},{"line_number":1412,"context_line":"            self.test_case.assertFalse(share[self.expected_attr])"},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"    def check_downgrade(self, engine):"},{"line_number":1415,"context_line":"        share_ids \u003d [s[\u0027id\u0027] for s in self.shares]"}],"source_content_type":"text/x-python","patch_set":36,"id":"ba5201f7_d6d2a9ff","line":1412,"range":{"start_line":1412,"start_character":12,"end_line":1412,"end_character":65},"in_reply_to":"ba5201f7_00014baf","updated":"2017-01-11 18:27:52.000000000","message":"Done","commit_id":"a60b167ce44f50bf01612e0cea53da6327243b3f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95b5d197f59a0e3d40b2ec0ac44bdca6e07be2e1","unresolved":false,"context_lines":[{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"        # Pre-existing Shares must be present"},{"line_number":1419,"context_line":"        shares_in_db \u003d engine.execute(shares_table.select()).fetchall()"},{"line_number":1420,"context_line":"        share_ids_in_db \u003d [s[\u0027id\u0027] for s in shares_in_db]"},{"line_number":1421,"context_line":"        for share_id in share_ids:"},{"line_number":1422,"context_line":"            self.test_case.assertIn(share_id, share_ids_in_db)"},{"line_number":1423,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"ba5201f7_40d4331f","line":1420,"range":{"start_line":1420,"start_character":8,"end_line":1420,"end_character":23},"updated":"2017-01-11 17:34:01.000000000","message":"ditto","commit_id":"a60b167ce44f50bf01612e0cea53da6327243b3f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2b30ae355ed6ef3c1d415192ea283bbb0ebce5f5","unresolved":false,"context_lines":[{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"        # Pre-existing Shares must be present"},{"line_number":1419,"context_line":"        shares_in_db \u003d engine.execute(shares_table.select()).fetchall()"},{"line_number":1420,"context_line":"        share_ids_in_db \u003d [s[\u0027id\u0027] for s in shares_in_db]"},{"line_number":1421,"context_line":"        for share_id in share_ids:"},{"line_number":1422,"context_line":"            self.test_case.assertIn(share_id, share_ids_in_db)"},{"line_number":1423,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"ba5201f7_91e4abe0","line":1420,"range":{"start_line":1420,"start_character":8,"end_line":1420,"end_character":23},"in_reply_to":"ba5201f7_40d4331f","updated":"2017-01-11 18:27:52.000000000","message":"Done","commit_id":"a60b167ce44f50bf01612e0cea53da6327243b3f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ae69ea9194d54c6d87c69eba6317ba16bdbd7e6f","unresolved":false,"context_lines":[{"line_number":1413,"context_line":"        # New shares attr must be present and set to False"},{"line_number":1414,"context_line":"        for share in shares_in_db:"},{"line_number":1415,"context_line":"            self.test_case.assertTrue(hasattr(share, self.expected_attr))"},{"line_number":1416,"context_line":"            self.test_case.assertEqual(False, share[self.expected_attr])"},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"    def check_downgrade(self, engine):"},{"line_number":1419,"context_line":"        share_ids \u003d [s[\u0027id\u0027] for s in self.shares]"}],"source_content_type":"text/x-python","patch_set":40,"id":"ba5201f7_854b74b0","line":1416,"range":{"start_line":1416,"start_character":12,"end_line":1416,"end_character":72},"updated":"2017-01-12 05:13:21.000000000","message":"Use assertFalse","commit_id":"c155f597f0beca0283ecf3c57d723dbbc3502c5f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ad016a365a907d71602364b9eef8a6e2bd95d844","unresolved":false,"context_lines":[{"line_number":1413,"context_line":"        # New shares attr must be present and set to False"},{"line_number":1414,"context_line":"        for share in shares_in_db:"},{"line_number":1415,"context_line":"            self.test_case.assertTrue(hasattr(share, self.expected_attr))"},{"line_number":1416,"context_line":"            self.test_case.assertEqual(False, share[self.expected_attr])"},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"    def check_downgrade(self, engine):"},{"line_number":1419,"context_line":"        share_ids \u003d [s[\u0027id\u0027] for s in self.shares]"}],"source_content_type":"text/x-python","patch_set":40,"id":"9a57fde8_c999b521","line":1416,"range":{"start_line":1416,"start_character":12,"end_line":1416,"end_character":72},"in_reply_to":"ba5201f7_854b74b0","updated":"2017-01-12 10:23:30.000000000","message":"assertFalse will be satisfied not only with boolean value, but with lots of empty values of other data types that is not expected. It is completely correct assertion. Just read previous comments.","commit_id":"c155f597f0beca0283ecf3c57d723dbbc3502c5f"}],"manila/tests/db/sqlalchemy/test_models.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            db_utils.create_share_instance("},{"line_number":88,"context_line":"                status\u003dstatus, share_id\u003d\u0027fake_id\u0027),"},{"line_number":89,"context_line":"            db_utils.create_share_instance("},{"line_number":90,"context_line":"                status\u003dconstants.STATUS_ERROR_DELETING, share_id\u003d\u0027fake_id\u0027)"},{"line_number":91,"context_line":"        ]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        share1 \u003d db_utils.create_share(instances\u003dinstance_list)"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_29c8cca7","line":90,"range":{"start_line":90,"start_character":74,"end_line":90,"end_character":75},"updated":"2017-01-06 01:38:58.000000000","message":"trailing comma","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            db_utils.create_share_instance("},{"line_number":88,"context_line":"                status\u003dstatus, share_id\u003d\u0027fake_id\u0027),"},{"line_number":89,"context_line":"            db_utils.create_share_instance("},{"line_number":90,"context_line":"                status\u003dconstants.STATUS_ERROR_DELETING, share_id\u003d\u0027fake_id\u0027)"},{"line_number":91,"context_line":"        ]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        share1 \u003d db_utils.create_share(instances\u003dinstance_list)"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_84e6fd12","line":90,"range":{"start_line":90,"start_character":74,"end_line":90,"end_character":75},"in_reply_to":"ba5201f7_29c8cca7","updated":"2017-01-06 03:19:17.000000000","message":"Done","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"}],"manila/tests/share/drivers/dell_emc/test_driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        data[\u0027pools\u0027] \u003d None"},{"line_number":126,"context_line":"        data[\u0027snapshot_support\u0027] \u003d True"},{"line_number":127,"context_line":"        data[\u0027create_share_from_snapshot_support\u0027] \u003d True"},{"line_number":128,"context_line":"        data[\u0027revert_to_snapshot_support\u0027] \u003d False"},{"line_number":129,"context_line":"        data[\u0027replication_domain\u0027] \u003d None"},{"line_number":130,"context_line":"        data[\u0027filter_function\u0027] \u003d None"},{"line_number":131,"context_line":"        data[\u0027goodness_function\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_0965c8b3","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":50},"updated":"2017-01-06 01:38:58.000000000","message":"the driver didn\u0027t need it?","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        data[\u0027pools\u0027] \u003d None"},{"line_number":126,"context_line":"        data[\u0027snapshot_support\u0027] \u003d True"},{"line_number":127,"context_line":"        data[\u0027create_share_from_snapshot_support\u0027] \u003d True"},{"line_number":128,"context_line":"        data[\u0027revert_to_snapshot_support\u0027] \u003d False"},{"line_number":129,"context_line":"        data[\u0027replication_domain\u0027] \u003d None"},{"line_number":130,"context_line":"        data[\u0027filter_function\u0027] \u003d None"},{"line_number":131,"context_line":"        data[\u0027goodness_function\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_a4ab0174","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":50},"in_reply_to":"ba5201f7_0965c8b3","updated":"2017-01-06 03:19:17.000000000","message":"This is a strange test, and this line is needed for the test to pass.","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"}],"manila_tempest_tests/config.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                default\u003dFalse,"},{"line_number":108,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":109,"context_line":"                     \"capability called \u0027revert_to_snapshot_support\u0027 \""},{"line_number":110,"context_line":"                     \"and will be used for setting up custom share type. \"),"},{"line_number":111,"context_line":"    cfg.StrOpt(\"share_network_id\","},{"line_number":112,"context_line":"               default\u003d\"\","},{"line_number":113,"context_line":"               help\u003d\"Some backend drivers requires share network \""}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_69749467","line":110,"range":{"start_line":110,"start_character":72,"end_line":110,"end_character":73},"updated":"2017-01-06 01:38:58.000000000","message":"nit: extra space","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                default\u003dFalse,"},{"line_number":108,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":109,"context_line":"                     \"capability called \u0027revert_to_snapshot_support\u0027 \""},{"line_number":110,"context_line":"                     \"and will be used for setting up custom share type. \"),"},{"line_number":111,"context_line":"    cfg.StrOpt(\"share_network_id\","},{"line_number":112,"context_line":"               default\u003d\"\","},{"line_number":113,"context_line":"               help\u003d\"Some backend drivers requires share network \""}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_84cd1d87","line":110,"range":{"start_line":110,"start_character":72,"end_line":110,"end_character":73},"in_reply_to":"ba5201f7_69749467","updated":"2017-01-06 03:19:17.000000000","message":"Done","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5a3f6dd826856d19c9dd36170c3c301dba137ded","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    cfg.BoolOpt(\"capability_revert_to_snapshot_support\","},{"line_number":107,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":108,"context_line":"                     \"capability called \u0027revert_to_snapshot_support\u0027 \""},{"line_number":109,"context_line":"                     \"and will be used for setting up custom share type.\""},{"line_number":110,"context_line":"                     \"Defaults to the value of run_revert_to_snapshot_tests.\"),"},{"line_number":111,"context_line":"    cfg.StrOpt(\"share_network_id\","},{"line_number":112,"context_line":"               default\u003d\"\","}],"source_content_type":"text/x-python","patch_set":33,"id":"ba5201f7_05652fe0","line":109,"range":{"start_line":109,"start_character":71,"end_line":109,"end_character":73},"updated":"2017-01-10 10:08:39.000000000","message":"missing a space here","commit_id":"937ecfef267642fc2bca144d026ed7697e725362"}],"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"94378d3ab02fda410d5ee617e92ee32f51344471","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        return body"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"###############"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    def get_snapshot_instance(self, instance_id, version\u003dLATEST_MICROVERSION):"},{"line_number":618,"context_line":"        resp, body \u003d self.get(\"snapshot-instances/%s\" % instance_id,"},{"line_number":619,"context_line":"                              version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":44,"id":"7a3c09a3_857fd4de","line":616,"updated":"2017-01-17 22:32:18.000000000","message":"Thanks for the coverage.","commit_id":"d4a379d0836470a64d79cd28190382eecb1f5c71"}],"manila_tempest_tests/tests/api/admin/test_revert_to_snapshot.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"ba5201f7_093308ac","updated":"2017-01-06 01:38:58.000000000","message":"We should add one or more of these positive test cases to test replicated snapshots","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"ba5201f7_64a599a0","in_reply_to":"ba5201f7_093308ac","updated":"2017-01-06 03:19:17.000000000","message":"Agreed, but we won\u0027t have 1st-party driver support for reverting replicated snapshots until vponomaryov adds that to the ZFS driver.  I think we were going to ask him to add the test(s) at that time.","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f5cdab858bcac2f9b075ce0d058380da014f3d41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"ba5201f7_7325485a","updated":"2017-01-06 16:18:24.000000000","message":"These tests should be in manila_tempest_tests/tests/api/\n\nSince revert_to_snapshot is not an admin only feature","commit_id":"d328384170c0fefd2b1934c8d5bc24f7a05e6290"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"df93781089fbe95164fa49a024823184683f5938","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"ba5201f7_67c01f51","in_reply_to":"ba5201f7_519e79b9","updated":"2017-01-06 19:21:10.000000000","message":"OK, moved.","commit_id":"d328384170c0fefd2b1934c8d5bc24f7a05e6290"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"ef1cef19451b730536366ee0f78cd278544148a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"ba5201f7_df80b58d","in_reply_to":"ba5201f7_7325485a","updated":"2017-01-06 17:50:15.000000000","message":"Andrew put the tests under admin because they have to use the admin client to create share types.  Which is correct?","commit_id":"d328384170c0fefd2b1934c8d5bc24f7a05e6290"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ae9f9d02ed4a292abcd78ea5ff2f44b6bce16262","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"ba5201f7_519e79b9","in_reply_to":"ba5201f7_df80b58d","updated":"2017-01-06 17:54:30.000000000","message":"You can use the admin client in the API tests to invoke admin APIs, see replication tests for example... \n\nI believe the reason why the admin tests are in their own folder is because they exclusively use the admin client;","commit_id":"d328384170c0fefd2b1934c8d5bc24f7a05e6290"}],"manila_tempest_tests/tests/api/admin/test_revert_to_snapshot_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f5cdab858bcac2f9b075ce0d058380da014f3d41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"ba5201f7_1315dce3","updated":"2017-01-06 16:18:24.000000000","message":"same","commit_id":"d328384170c0fefd2b1934c8d5bc24f7a05e6290"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"df93781089fbe95164fa49a024823184683f5938","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"ba5201f7_e7cc0f8b","in_reply_to":"ba5201f7_1315dce3","updated":"2017-01-06 19:21:10.000000000","message":"Moved.","commit_id":"d328384170c0fefd2b1934c8d5bc24f7a05e6290"}],"manila_tempest_tests/tests/api/admin/test_share_types_extra_specs_negative.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"9c395d09a95f2b8b59482b9a6a26ff874d6fee3d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            st[\u0027share_type\u0027][\u0027id\u0027])"},{"line_number":76,"context_line":"        # Verify a non-admin can only read the required extra-specs"},{"line_number":77,"context_line":"        expected_keys \u003d [\u0027driver_handles_share_servers\u0027, \u0027snapshot_support\u0027]"},{"line_number":78,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \u00272.21\u0027):"},{"line_number":79,"context_line":"            expected_keys.append(\u0027create_share_from_snapshot_support\u0027)"},{"line_number":80,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion,"},{"line_number":81,"context_line":"                                    constants.REVERT_TO_SNAPSHOT_MICROVERSION):"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5201f7_1dd7c94b","line":78,"range":{"start_line":78,"start_character":69,"end_line":78,"end_character":77},"updated":"2017-01-05 21:06:58.000000000","message":"2.24 ?","commit_id":"98291366fb1801a7f38db80854ed60fcca16a88f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"24934911b7c6daf053ac1a3b6dfd5f23dd6645a8","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            st[\u0027share_type\u0027][\u0027id\u0027])"},{"line_number":76,"context_line":"        # Verify a non-admin can only read the required extra-specs"},{"line_number":77,"context_line":"        expected_keys \u003d [\u0027driver_handles_share_servers\u0027, \u0027snapshot_support\u0027]"},{"line_number":78,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion, \u00272.21\u0027):"},{"line_number":79,"context_line":"            expected_keys.append(\u0027create_share_from_snapshot_support\u0027)"},{"line_number":80,"context_line":"        if utils.is_microversion_ge(CONF.share.max_api_microversion,"},{"line_number":81,"context_line":"                                    constants.REVERT_TO_SNAPSHOT_MICROVERSION):"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5201f7_4b38a83d","line":78,"range":{"start_line":78,"start_character":69,"end_line":78,"end_character":77},"in_reply_to":"ba5201f7_1dd7c94b","updated":"2017-01-06 00:35:11.000000000","message":"Yes, good catch.","commit_id":"98291366fb1801a7f38db80854ed60fcca16a88f"}],"manila_tempest_tests/tests/api/test_revert_to_snapshot.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"93d628ec431134b4ad63a621dddaf43e8fc500ed","unresolved":false,"context_lines":[{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"@base.skip_if_microversion_lt(constants.REVERT_TO_SNAPSHOT_MICROVERSION)"},{"line_number":29,"context_line":"@base.skip_if_microversion_not_supported("},{"line_number":30,"context_line":"    constants.REVERT_TO_SNAPSHOT_MICROVERSION)"},{"line_number":31,"context_line":"@ddt.ddt"},{"line_number":32,"context_line":"class RevertToSnapshotTest(base.BaseSharesMixedTest):"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"ba5201f7_bf756e33","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":46},"updated":"2017-01-09 18:39:21.000000000","message":"aren\u0027t those 2 redundant? I always use skip_if_microversion_not_supported, because if it is less than the one supported it is going to be not supported.","commit_id":"cb7aed725de9fe45dec24c6b099e7327b7d96fda"},{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"cb9a8e703225f39ae70e8732b345ad40e5bd9711","unresolved":false,"context_lines":[{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"@base.skip_if_microversion_lt(constants.REVERT_TO_SNAPSHOT_MICROVERSION)"},{"line_number":29,"context_line":"@base.skip_if_microversion_not_supported("},{"line_number":30,"context_line":"    constants.REVERT_TO_SNAPSHOT_MICROVERSION)"},{"line_number":31,"context_line":"@ddt.ddt"},{"line_number":32,"context_line":"class RevertToSnapshotTest(base.BaseSharesMixedTest):"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"ba5201f7_d8ede8f0","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":46},"in_reply_to":"ba5201f7_bf756e33","updated":"2017-01-09 19:48:28.000000000","message":"Valid point.  I hadn\u0027t dug too deep into the logical checks of these skips.  I will remove the less than check.","commit_id":"cb7aed725de9fe45dec24c6b099e7327b7d96fda"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"93d628ec431134b4ad63a621dddaf43e8fc500ed","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def skip_checks(cls):"},{"line_number":36,"context_line":"        super(RevertToSnapshotTest, cls).skip_checks()"},{"line_number":37,"context_line":"        if not CONF.share.capability_snapshot_support:"},{"line_number":38,"context_line":"            msg \u003d \"Snapshot support is disabled.\""},{"line_number":39,"context_line":"            raise cls.skipException(msg)"},{"line_number":40,"context_line":"        if not CONF.share.run_snapshot_tests:"},{"line_number":41,"context_line":"            msg \u003d \"Snapshot tests are disabled.\""},{"line_number":42,"context_line":"            raise cls.skipException(msg)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":32,"id":"ba5201f7_9f3b4a38","line":42,"range":{"start_line":36,"start_character":8,"end_line":42,"end_character":40},"updated":"2017-01-09 18:39:21.000000000","message":"more importantly, it should check if it should run revert tests. It will make no sense to have revert enabled but those config disabled.","commit_id":"cb7aed725de9fe45dec24c6b099e7327b7d96fda"},{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"cb9a8e703225f39ae70e8732b345ad40e5bd9711","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def skip_checks(cls):"},{"line_number":36,"context_line":"        super(RevertToSnapshotTest, cls).skip_checks()"},{"line_number":37,"context_line":"        if not CONF.share.capability_snapshot_support:"},{"line_number":38,"context_line":"            msg \u003d \"Snapshot support is disabled.\""},{"line_number":39,"context_line":"            raise cls.skipException(msg)"},{"line_number":40,"context_line":"        if not CONF.share.run_snapshot_tests:"},{"line_number":41,"context_line":"            msg \u003d \"Snapshot tests are disabled.\""},{"line_number":42,"context_line":"            raise cls.skipException(msg)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":32,"id":"ba5201f7_b8c74463","line":42,"range":{"start_line":36,"start_character":8,"end_line":42,"end_character":40},"in_reply_to":"ba5201f7_9f3b4a38","updated":"2017-01-09 19:48:28.000000000","message":"This comment, and the following one, will be both handled by adding support for a \"run_revert_to_snapshot_tests\" config option","commit_id":"cb7aed725de9fe45dec24c6b099e7327b7d96fda"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"93d628ec431134b4ad63a621dddaf43e8fc500ed","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        super(RevertToSnapshotTest, cls).resource_setup()"},{"line_number":47,"context_line":"        cls.admin_client \u003d cls.admin_shares_v2_client"},{"line_number":48,"context_line":"        pools \u003d cls.admin_client.list_pools(detail\u003dTrue)[\u0027pools\u0027]"},{"line_number":49,"context_line":"        revert_support \u003d ["},{"line_number":50,"context_line":"            pool[\u0027capabilities\u0027][constants.REVERT_TO_SNAPSHOT_SUPPORT]"},{"line_number":51,"context_line":"            for pool in pools]"},{"line_number":52,"context_line":"        if not any(revert_support):"},{"line_number":53,"context_line":"            msg \u003d \"Revert to snapshot not supported.\""},{"line_number":54,"context_line":"            raise cls.skipException(msg)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        cls.share_type_name \u003d data_utils.rand_name(\"share-type\")"},{"line_number":57,"context_line":"        extra_specs \u003d {constants.REVERT_TO_SNAPSHOT_SUPPORT: True}"}],"source_content_type":"text/x-python","patch_set":32,"id":"ba5201f7_1f083a91","line":54,"range":{"start_line":49,"start_character":8,"end_line":54,"end_character":40},"updated":"2017-01-09 18:39:21.000000000","message":"This is not using the config capability_revert_to_snapshot_support at all, so there is no way to disable the tests even if there is a pool that supports it. I configured my CI improperly, it ended up setting capability_revert_to_snapshot_support \u003d False but it ran the tests anyway. I believe that behavior is undesired.","commit_id":"cb7aed725de9fe45dec24c6b099e7327b7d96fda"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95b5d197f59a0e3d40b2ec0ac44bdca6e07be2e1","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest import config"},{"line_number":19,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manila_tempest_tests.common import constants"},{"line_number":23,"context_line":"from manila_tempest_tests.tests.api import base"}],"source_content_type":"text/x-python","patch_set":36,"id":"ba5201f7_2a7c70b4","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":24},"updated":"2017-01-11 17:34:01.000000000","message":"Should be following as in example [1]:\n\n\"\"\"\nfrom testtools import testcase as tc\n\"\"\"\n\n[1] https://github.com/openstack/manila/blob/a0163f4c/manila_tempest_tests/tests/api/test_metadata.py#L16","commit_id":"a60b167ce44f50bf01612e0cea53da6327243b3f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95b5d197f59a0e3d40b2ec0ac44bdca6e07be2e1","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        cls.share \u003d cls.create_share(share_type_id\u003dcls.st_id)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_BACKEND])"},{"line_number":76,"context_line":"    @ddt.data(constants.REVERT_TO_SNAPSHOT_MICROVERSION,"},{"line_number":77,"context_line":"              CONF.share.max_api_microversion)"},{"line_number":78,"context_line":"    def test_revert_to_latest_snapshot(self, version):"}],"source_content_type":"text/x-python","patch_set":36,"id":"ba5201f7_aa3dc0de","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":58},"updated":"2017-01-11 17:34:01.000000000","message":"Should be following as in example [1]:\n\n\"\"\"\n@tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)\n\"\"\"\n\nSame below.\n\n[1] https://github.com/openstack/manila/blob/a0163f4c/manila_tempest_tests/tests/api/test_metadata.py#L42","commit_id":"a60b167ce44f50bf01612e0cea53da6327243b3f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95b5d197f59a0e3d40b2ec0ac44bdca6e07be2e1","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        cls.share \u003d cls.create_share(share_type_id\u003dcls.st_id)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_BACKEND])"},{"line_number":76,"context_line":"    @ddt.data(constants.REVERT_TO_SNAPSHOT_MICROVERSION,"},{"line_number":77,"context_line":"              CONF.share.max_api_microversion)"},{"line_number":78,"context_line":"    def test_revert_to_latest_snapshot(self, version):"},{"line_number":79,"context_line":"        snapshot \u003d self.create_snapshot_wait_for_active(self.share[\u0027id\u0027],"},{"line_number":80,"context_line":"                                                        cleanup_in_class\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":36,"id":"ba5201f7_4aeff486","line":77,"range":{"start_line":76,"start_character":4,"end_line":77,"end_character":46},"updated":"2017-01-11 17:34:01.000000000","message":"To avoid duplication of tests:\n\"\"\"\n@ddt.data(\n    *set(constants.REVERT_TO_SNAPSHOT_MICROVERSION, \n         CONF.share.max_api_microversion)\n)\n\"\"\"\n\nSame below.","commit_id":"a60b167ce44f50bf01612e0cea53da6327243b3f"}],"manila_tempest_tests/tests/api/test_revert_to_snapshot_negative.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"95b5d197f59a0e3d40b2ec0ac44bdca6e07be2e1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":36,"id":"ba5201f7_fd1a306e","line":15,"updated":"2017-01-11 17:34:01.000000000","message":"Same comments as in https://review.openstack.org/#/c/340502/36/manila_tempest_tests/tests/api/test_revert_to_snapshot.py","commit_id":"a60b167ce44f50bf01612e0cea53da6327243b3f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7b6cbda134b0cc698920bcd4ed6594b1588b0459","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest import config"},{"line_number":19,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest.lib import exceptions"}],"source_content_type":"text/x-python","patch_set":36,"id":"ba5201f7_56007901","line":17,"updated":"2017-01-11 17:47:06.000000000","message":"Also, this test module is not running for some reason, see http://logs.openstack.org/02/340502/36/check/gate-manila-tempest-minimal-dsvm-lvm-ubuntu-xenial/69cfdae/console.html","commit_id":"a60b167ce44f50bf01612e0cea53da6327243b3f"},{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"5d6ed444f196e7ae661695d8f1322451de13d7c8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest import config"},{"line_number":19,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest.lib import exceptions"}],"source_content_type":"text/x-python","patch_set":36,"id":"ba5201f7_b6f525ee","line":17,"in_reply_to":"ba5201f7_56007901","updated":"2017-01-11 17:51:27.000000000","message":"because they\u0027re tagged API with backend and you\u0027re skipping API tests on the LVM driver","commit_id":"a60b167ce44f50bf01612e0cea53da6327243b3f"}],"releasenotes/notes/share-revert-to-snapshot-3d028fa00620651e.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add revert-to-snapshot feature for regular and"},{"line_number":4,"context_line":"    replicated shares."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"ba5201f7_69e9f4e5","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":22},"updated":"2017-01-06 01:38:58.000000000","message":"Please mention the revertible snapshot support added in the LVM driver","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add revert-to-snapshot feature for regular and"},{"line_number":4,"context_line":"    replicated shares."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"ba5201f7_64d3d904","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":22},"in_reply_to":"ba5201f7_69e9f4e5","updated":"2017-01-06 03:19:17.000000000","message":"Done","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04bc4fe291695b585df30e86c563dabc7fa9c274","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add revert-to-snapshot feature for regular and"},{"line_number":4,"context_line":"    replicated shares."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"ba5201f7_a9183c1f","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":0},"updated":"2017-01-06 01:38:58.000000000","message":"nit: extra-line","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1476a50b2373a6d6f869c87cfec2e3a77b690f96","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add revert-to-snapshot feature for regular and"},{"line_number":4,"context_line":"    replicated shares."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"ba5201f7_a4d94124","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":0},"in_reply_to":"ba5201f7_a9183c1f","updated":"2017-01-06 03:19:17.000000000","message":"Done","commit_id":"858b7a8cfe32f5ce2773ea10bdf584e9cea16022"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4b8ddbc79c2f214d79f22ba14dd1c71347ad43de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add revert-to-snapshot feature for regular and"},{"line_number":4,"context_line":"    replicated shares."},{"line_number":5,"context_line":"  - Add revert-to-snapshot support to the LVM driver."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"ba5201f7_787a9989","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":7},"updated":"2017-01-06 04:38:28.000000000","message":"Added :)","commit_id":"abb29db5abd7a59c60ec2368f36d9e0cda19cabf"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"6e70fbf0d1c4de389a7629e9771c5aa0195e8bf3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add revert-to-snapshot feature for regular and"},{"line_number":4,"context_line":"    replicated shares."},{"line_number":5,"context_line":"  - Add revert-to-snapshot support to the LVM driver."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"ba5201f7_ea4a2154","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":7},"in_reply_to":"ba5201f7_787a9989","updated":"2017-01-06 14:55:13.000000000","message":"Done","commit_id":"abb29db5abd7a59c60ec2368f36d9e0cda19cabf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4b8ddbc79c2f214d79f22ba14dd1c71347ad43de","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add revert-to-snapshot feature for regular and"},{"line_number":4,"context_line":"    replicated shares."},{"line_number":5,"context_line":"  - Add revert-to-snapshot support to the LVM driver."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"ba5201f7_5877959f","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":7},"updated":"2017-01-06 04:38:28.000000000","message":"Added","commit_id":"abb29db5abd7a59c60ec2368f36d9e0cda19cabf"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"6e70fbf0d1c4de389a7629e9771c5aa0195e8bf3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add revert-to-snapshot feature for regular and"},{"line_number":4,"context_line":"    replicated shares."},{"line_number":5,"context_line":"  - Add revert-to-snapshot support to the LVM driver."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"ba5201f7_0a46854e","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":7},"in_reply_to":"ba5201f7_5877959f","updated":"2017-01-06 14:55:13.000000000","message":"Done","commit_id":"abb29db5abd7a59c60ec2368f36d9e0cda19cabf"}]}
