)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eede69dfbc47361202fe854adf01450da1c4e7f9","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"* Expose it in access_list API"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"APIImpact"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DocImpact"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9ad45d7e_8fc89956","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":9},"updated":"2016-08-12 03:20:33.000000000","message":"This is a minor one key change, could you add the key to the api-ref that is in-tree?","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"686cde9a1a12ebb66a646ac80948077ccae44822","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"* Expose it in access_list API"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"APIImpact"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DocImpact"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3ac371cc_17e642b4","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":9},"in_reply_to":"9ad45d7e_8fc89956","updated":"2016-08-16 08:39:14.000000000","message":"Done","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cbc7700f33728f2d34c713e41c5cea78d792e34d","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    (Since API v2.21) The access credential of the entity granted share access."},{"line_number":379,"context_line":"  in: body"},{"line_number":380,"context_line":"  required: true"},{"line_number":381,"context_line":"  type: string"},{"line_number":382,"context_line":"access_level:"},{"line_number":383,"context_line":"  description: |"},{"line_number":384,"context_line":"    The access level to the share.  To grant or deny"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1ac06dbe_17961ff0","line":381,"range":{"start_line":381,"start_character":8,"end_line":381,"end_character":14},"updated":"2016-08-21 15:50:06.000000000","message":"min_version: 2.21","commit_id":"887b73177235bf64d3f8788907480719f95d3e86"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"d4e73e68bc40401013e3d27c98a7c2dc46dd6695","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    (Since API v2.21) The access credential of the entity granted share access."},{"line_number":379,"context_line":"  in: body"},{"line_number":380,"context_line":"  required: true"},{"line_number":381,"context_line":"  type: string"},{"line_number":382,"context_line":"access_level:"},{"line_number":383,"context_line":"  description: |"},{"line_number":384,"context_line":"    The access level to the share.  To grant or deny"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1ac06dbe_d2459e70","line":381,"range":{"start_line":381,"start_character":8,"end_line":381,"end_character":14},"in_reply_to":"1ac06dbe_17961ff0","updated":"2016-08-22 11:46:57.000000000","message":"Done","commit_id":"887b73177235bf64d3f8788907480719f95d3e86"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b4271198c46f36dbc7efaee0fc7649f80b5995bb","unresolved":false,"context_lines":[{"line_number":375,"context_line":"  type: string"},{"line_number":376,"context_line":"access_key:"},{"line_number":377,"context_line":"  description: |"},{"line_number":378,"context_line":"    (Since API v2.21) The access credential of the entity granted share access."},{"line_number":379,"context_line":"  in: body"},{"line_number":380,"context_line":"  required: true"},{"line_number":381,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1ac06dbe_ee21ce4e","line":378,"range":{"start_line":378,"start_character":4,"end_line":378,"end_character":21},"updated":"2016-08-22 12:51:51.000000000","message":"not necessary","commit_id":"1082312c060a9712018a46ab701d960392f72d14"}],"api-ref/source/samples/share-actions-grant-access-response.json":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6ee4fcd8458568977e96b620bf1c4af0b58f65","unresolved":false,"context_lines":[{"line_number":6,"context_line":"        \"access_type\": \"ip\","},{"line_number":7,"context_line":"        \"access_to\": \"0.0.0.0/0\","},{"line_number":8,"context_line":"        \"access_level\": \"rw\","},{"line_number":9,"context_line":"        \"access_key\": null,"},{"line_number":10,"context_line":"        \"id\": \"a25b2df3-90bd-4add-afa6-5f0dbbd50452\""},{"line_number":11,"context_line":"    }"},{"line_number":12,"context_line":"}"}],"source_content_type":"application/json","patch_set":13,"id":"1ac06dbe_20ab538b","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":27},"updated":"2016-08-19 14:11:53.000000000","message":"You need to add this in the API doc as well, under grant access:\n\n  api-ref/source/share-actions.inc\n\nAlso, the parameter needs to be in api-ref/source/parameters.yaml, with the correct min_version: \u00272.21\u0027 set.. \n\n\nP.S: somehow the parameters.yaml file merged without all the min_versions. That\u0027s a HUGE bug in the api-ref as of now: https://bugs.launchpad.net/manila/+bug/1614955","commit_id":"d84b8f4d1e8b1c9d8e0205d2759a30293920876f"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"d12688b37e755c4a8967f0dc002e6ab7f6ef762f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"        \"access_type\": \"ip\","},{"line_number":7,"context_line":"        \"access_to\": \"0.0.0.0/0\","},{"line_number":8,"context_line":"        \"access_level\": \"rw\","},{"line_number":9,"context_line":"        \"access_key\": null,"},{"line_number":10,"context_line":"        \"id\": \"a25b2df3-90bd-4add-afa6-5f0dbbd50452\""},{"line_number":11,"context_line":"    }"},{"line_number":12,"context_line":"}"}],"source_content_type":"application/json","patch_set":13,"id":"1ac06dbe_14329d10","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":27},"in_reply_to":"1ac06dbe_20ab538b","updated":"2016-08-21 14:31:32.000000000","message":"Done","commit_id":"d84b8f4d1e8b1c9d8e0205d2759a30293920876f"}],"manila/api/v1/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eede69dfbc47361202fe854adf01450da1c4e7f9","unresolved":false,"context_lines":[{"line_number":498,"context_line":"                access_data.get(\u0027access_level\u0027))"},{"line_number":499,"context_line":"        except exception.ShareAccessExists as e:"},{"line_number":500,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":501,"context_line":"        return {\u0027access\u0027: access}"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    def _deny_access(self, req, id, body):"},{"line_number":504,"context_line":"        \"\"\"Remove share access rule.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_1ce7b3ac","line":501,"range":{"start_line":501,"start_character":15,"end_line":501,"end_character":33},"updated":"2016-08-12 03:20:33.000000000","message":"You need to modify this as well..  It would be strange to see the key show up only for list and not during allow_access","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"686cde9a1a12ebb66a646ac80948077ccae44822","unresolved":false,"context_lines":[{"line_number":498,"context_line":"                access_data.get(\u0027access_level\u0027))"},{"line_number":499,"context_line":"        except exception.ShareAccessExists as e:"},{"line_number":500,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":501,"context_line":"        return {\u0027access\u0027: access}"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    def _deny_access(self, req, id, body):"},{"line_number":504,"context_line":"        \"\"\"Remove share access rule.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"3ac371cc_96207f4b","line":501,"range":{"start_line":501,"start_character":15,"end_line":501,"end_character":33},"in_reply_to":"9ad45d7e_1ce7b3ac","updated":"2016-08-16 08:39:14.000000000","message":"Done","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6ee4fcd8458568977e96b620bf1c4af0b58f65","unresolved":false,"context_lines":[{"line_number":498,"context_line":"                access_data.get(\u0027access_level\u0027))"},{"line_number":499,"context_line":"        except exception.ShareAccessExists as e:"},{"line_number":500,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":501,"context_line":"        access_view \u003d self._access_view_builder.view(req, access)"},{"line_number":502,"context_line":"        return {\u0027access\u0027: access_view}"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"    def _deny_access(self, req, id, body):"},{"line_number":505,"context_line":"        \"\"\"Remove share access rule.\"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_40792f2f","line":502,"range":{"start_line":501,"start_character":8,"end_line":502,"end_character":38},"updated":"2016-08-19 14:11:53.000000000","message":"return self._access_view_builder.detail(req, access)\n\ndetail can call view and build the response with \u0027access\u0027 as the key.","commit_id":"d84b8f4d1e8b1c9d8e0205d2759a30293920876f"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"d12688b37e755c4a8967f0dc002e6ab7f6ef762f","unresolved":false,"context_lines":[{"line_number":498,"context_line":"                access_data.get(\u0027access_level\u0027))"},{"line_number":499,"context_line":"        except exception.ShareAccessExists as e:"},{"line_number":500,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":501,"context_line":"        access_view \u003d self._access_view_builder.view(req, access)"},{"line_number":502,"context_line":"        return {\u0027access\u0027: access_view}"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"    def _deny_access(self, req, id, body):"},{"line_number":505,"context_line":"        \"\"\"Remove share access rule.\"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_d435a5da","line":502,"range":{"start_line":501,"start_character":8,"end_line":502,"end_character":38},"in_reply_to":"1ac06dbe_40792f2f","updated":"2016-08-21 14:31:32.000000000","message":"Done","commit_id":"d84b8f4d1e8b1c9d8e0205d2759a30293920876f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6ee4fcd8458568977e96b620bf1c4af0b58f65","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        share \u003d self.share_api.get(context, id)"},{"line_number":526,"context_line":"        access_rules \u003d self.share_api.access_get_all(context, share)"},{"line_number":527,"context_line":"        access_list \u003d self._access_view_builder.list_view(req, access_rules)"},{"line_number":528,"context_line":"        return {\u0027access_list\u0027: access_list}"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    def _extend(self, req, id, body):"},{"line_number":531,"context_line":"        \"\"\"Extend size of a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_009e1756","line":528,"range":{"start_line":527,"start_character":7,"end_line":528,"end_character":43},"updated":"2016-08-19 14:11:53.000000000","message":"same..\n\nthe key \u0027access_list\u0027 can be set in the view builder.","commit_id":"d84b8f4d1e8b1c9d8e0205d2759a30293920876f"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"d12688b37e755c4a8967f0dc002e6ab7f6ef762f","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        share \u003d self.share_api.get(context, id)"},{"line_number":526,"context_line":"        access_rules \u003d self.share_api.access_get_all(context, share)"},{"line_number":527,"context_line":"        access_list \u003d self._access_view_builder.list_view(req, access_rules)"},{"line_number":528,"context_line":"        return {\u0027access_list\u0027: access_list}"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    def _extend(self, req, id, body):"},{"line_number":531,"context_line":"        \"\"\"Extend size of a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_b430e9e9","line":528,"range":{"start_line":527,"start_character":7,"end_line":528,"end_character":43},"in_reply_to":"1ac06dbe_009e1756","updated":"2016-08-21 14:31:32.000000000","message":"Done","commit_id":"d84b8f4d1e8b1c9d8e0205d2759a30293920876f"}],"manila/api/views/share_accesses.py":[{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"3339be6a5c6989c83416fbb8224d12f2868746e8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def view(self, request, access):"},{"line_number":33,"context_line":"        \"\"\"View of a single share access.\"\"\""},{"line_number":34,"context_line":"        access_dict \u003d {"},{"line_number":35,"context_line":"            \u0027id\u0027: access.get(\u0027id\u0027),"},{"line_number":36,"context_line":"            \u0027access_level\u0027: access.get(\u0027access_level\u0027),"},{"line_number":37,"context_line":"            \u0027access_to\u0027: access.get(\u0027access_to\u0027),"},{"line_number":38,"context_line":"            \u0027access_type\u0027: access.get(\u0027access_type\u0027),"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ac06dbe_dac77a10","line":35,"updated":"2016-08-22 09:22:21.000000000","message":"Missed populating with \u0027share_id\u0027 key. See line #1216 of manila/share/api.py of this PS1. This causes the CI of corresponding python-manilaclient patch to fail, see http://logs.openstack.org/48/344948/3/check/gate-manilaclient-dsvm-neutron-functional/261e068/console.html#_2016-08-17_23_28_45_905327","commit_id":"887b73177235bf64d3f8788907480719f95d3e86"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"d4e73e68bc40401013e3d27c98a7c2dc46dd6695","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def view(self, request, access):"},{"line_number":33,"context_line":"        \"\"\"View of a single share access.\"\"\""},{"line_number":34,"context_line":"        access_dict \u003d {"},{"line_number":35,"context_line":"            \u0027id\u0027: access.get(\u0027id\u0027),"},{"line_number":36,"context_line":"            \u0027access_level\u0027: access.get(\u0027access_level\u0027),"},{"line_number":37,"context_line":"            \u0027access_to\u0027: access.get(\u0027access_to\u0027),"},{"line_number":38,"context_line":"            \u0027access_type\u0027: access.get(\u0027access_type\u0027),"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ac06dbe_c9a971e1","line":35,"in_reply_to":"1ac06dbe_dac77a10","updated":"2016-08-22 11:46:57.000000000","message":"Done","commit_id":"887b73177235bf64d3f8788907480719f95d3e86"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b4271198c46f36dbc7efaee0fc7649f80b5995bb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def list_view(self, request, accesses):"},{"line_number":28,"context_line":"        \"\"\"View of a list of share accesses.\"\"\""},{"line_number":29,"context_line":"        access_list_view \u003d []"},{"line_number":30,"context_line":"        for access in accesses:"},{"line_number":31,"context_line":"            access_view \u003d self.view(request, access)[\u0027access\u0027]"},{"line_number":32,"context_line":"            del access_view[\u0027share_id\u0027]"},{"line_number":33,"context_line":"            access_list_view.append(access_view)"},{"line_number":34,"context_line":"        return {\u0027access_list\u0027: access_list_view}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def view(self, request, access):"},{"line_number":37,"context_line":"        \"\"\"View of a single share access.\"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_2e78062a","line":34,"range":{"start_line":30,"start_character":0,"end_line":34,"end_character":48},"updated":"2016-08-22 12:51:51.000000000","message":"The problem with this approach is; whenever the access rule view changes with a key, the list API will get updated. Is this what you want? Can\u0027t you have a summary, and a list?","commit_id":"1082312c060a9712018a46ab701d960392f72d14"}],"manila/db/migrations/alembic/versions/63809d875e32_add_access_key.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"b16ba14e9b78b5dba09ae5874461d430e004e114","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\"\"\"add_access_key"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: 63809d875e32"},{"line_number":16,"context_line":"Revises: e8ea58723178"},{"line_number":17,"context_line":"Create Date: 2016-07-16 20:53:05.958896"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"3ac371cc_f4bcafbc","line":16,"range":{"start_line":16,"start_character":9,"end_line":16,"end_character":21},"updated":"2016-08-17 19:53:34.000000000","message":"Need to update this to match the downrev?","commit_id":"b11134160c5d64b5188fa989689f5f6f61bcf37b"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"7984155784c187d7d75a803f3c02f88a68d4c093","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\"\"\"add_access_key"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: 63809d875e32"},{"line_number":16,"context_line":"Revises: e8ea58723178"},{"line_number":17,"context_line":"Create Date: 2016-07-16 20:53:05.958896"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"3ac371cc_9dcc658a","line":16,"range":{"start_line":16,"start_character":9,"end_line":16,"end_character":21},"in_reply_to":"3ac371cc_f4bcafbc","updated":"2016-08-18 07:28:21.000000000","message":"Done","commit_id":"b11134160c5d64b5188fa989689f5f6f61bcf37b"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"390a7a1bd720c571ea2ae7dd50ce0063e989fd1d","unresolved":false,"context_lines":[{"line_number":1815,"context_line":"def share_access_update_access_key(context, access_id, access_key):"},{"line_number":1816,"context_line":"    session \u003d get_session()"},{"line_number":1817,"context_line":"    with session.begin():"},{"line_number":1818,"context_line":"        mapping \u003d session.query(models.ShareAccessMapping).\\"},{"line_number":1819,"context_line":"            filter_by(id\u003daccess_id).first()"},{"line_number":1820,"context_line":"        mapping.update({\u0027access_key\u0027: access_key})"},{"line_number":1821,"context_line":"        mapping.save(session\u003dsession)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_72a1fc93","line":1818,"range":{"start_line":1818,"start_character":58,"end_line":1818,"end_character":60},"updated":"2016-07-26 20:49:53.000000000","message":"please avoid using backslashes, use parenthesis instead","commit_id":"129f1f424eb205362b1a7f426ab4c07605ebad17"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"7a5cfcee48560ab6bfa47c3f330ef756cc9ef3bb","unresolved":false,"context_lines":[{"line_number":1815,"context_line":"def share_access_update_access_key(context, access_id, access_key):"},{"line_number":1816,"context_line":"    session \u003d get_session()"},{"line_number":1817,"context_line":"    with session.begin():"},{"line_number":1818,"context_line":"        mapping \u003d session.query(models.ShareAccessMapping).\\"},{"line_number":1819,"context_line":"            filter_by(id\u003daccess_id).first()"},{"line_number":1820,"context_line":"        mapping.update({\u0027access_key\u0027: access_key})"},{"line_number":1821,"context_line":"        mapping.save(session\u003dsession)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_35463a4f","line":1818,"range":{"start_line":1818,"start_character":58,"end_line":1818,"end_character":60},"in_reply_to":"dada55a8_72a1fc93","updated":"2016-08-01 13:09:21.000000000","message":"Done","commit_id":"129f1f424eb205362b1a7f426ab4c07605ebad17"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"35cdd33e7bdc219106e05a2ddfed8552cd9da7ca","unresolved":false,"context_lines":[{"line_number":1815,"context_line":"def share_access_update_access_key(context, access_id, access_key):"},{"line_number":1816,"context_line":"    session \u003d get_session()"},{"line_number":1817,"context_line":"    with session.begin():"},{"line_number":1818,"context_line":"        mapping \u003d (session.query(models.ShareAccessMapping)."},{"line_number":1819,"context_line":"                   filter_by(id\u003daccess_id).first())"},{"line_number":1820,"context_line":"        mapping.update({\u0027access_key\u0027: access_key})"},{"line_number":1821,"context_line":"        mapping.save(session\u003dsession)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_56a5de9f","line":1818,"range":{"start_line":1818,"start_character":7,"end_line":1818,"end_character":60},"updated":"2016-08-10 21:13:04.000000000","message":"Guess we should do a little followup patch to change all the other line continuations to parens style :)","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"686cde9a1a12ebb66a646ac80948077ccae44822","unresolved":false,"context_lines":[{"line_number":1815,"context_line":"def share_access_update_access_key(context, access_id, access_key):"},{"line_number":1816,"context_line":"    session \u003d get_session()"},{"line_number":1817,"context_line":"    with session.begin():"},{"line_number":1818,"context_line":"        mapping \u003d (session.query(models.ShareAccessMapping)."},{"line_number":1819,"context_line":"                   filter_by(id\u003daccess_id).first())"},{"line_number":1820,"context_line":"        mapping.update({\u0027access_key\u0027: access_key})"},{"line_number":1821,"context_line":"        mapping.save(session\u003dsession)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3ac371cc_f973b1b2","line":1818,"range":{"start_line":1818,"start_character":7,"end_line":1818,"end_character":60},"in_reply_to":"9ad45d7e_56a5de9f","updated":"2016-08-16 08:39:14.000000000","message":":)","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"}],"manila/share/access.py":[{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"0e4feffc194856ccd0a52188cbf874b57414fd25","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"            if access_keys:"},{"line_number":97,"context_line":"                if not (add_rules or delete_rules):"},{"line_number":98,"context_line":"                    assert len(access_keys) \u003d\u003d len(rules)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"                for access_id, access_key in access_keys.items():"},{"line_number":101,"context_line":"                    self.db.share_access_update_access_key("}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_0fb62edc","line":98,"updated":"2016-07-18 12:50:37.000000000","message":"raise an appropriate error with a decent error message.","commit_id":"6a83b45766ce0b91443cf0b39361e6fa1216147a"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"d83227ca6a7aefb569919781da84ae0af96814e6","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            if access_keys:"},{"line_number":101,"context_line":"                if ("},{"line_number":102,"context_line":"                    not isinstance(access_keys, dict)"},{"line_number":103,"context_line":"                    or [access_id for access_id in access_keys.keys()"},{"line_number":104,"context_line":"                        if not uuidutils.is_uuid_like(access_id)]"},{"line_number":105,"context_line":"                    or [access_key for access_key in access_keys.values()"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_09719e44","line":102,"updated":"2016-08-04 16:32:30.000000000","message":"this can be a inner function _validate_access_keys.\n\nSeparate the checks to make it more readable.","commit_id":"f885036b884bd7efcbf553643859b6d031721104"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"d83227ca6a7aefb569919781da84ae0af96814e6","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                    or [access_id for access_id in access_keys.keys()"},{"line_number":104,"context_line":"                        if not uuidutils.is_uuid_like(access_id)]"},{"line_number":105,"context_line":"                    or [access_key for access_key in access_keys.values()"},{"line_number":106,"context_line":"                        if not isinstance(access_key, str)]"},{"line_number":107,"context_line":"                ):"},{"line_number":108,"context_line":"                    msg \u003d _(\"The driver did not return access_keys as \""},{"line_number":109,"context_line":"                            \"a dictionary of access_id, and access_key \""}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_29c2a234","line":106,"updated":"2016-08-04 16:32:30.000000000","message":"could be unicode for python 2.x","commit_id":"f885036b884bd7efcbf553643859b6d031721104"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"35cdd33e7bdc219106e05a2ddfed8552cd9da7ca","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_log import log"},{"line_number":17,"context_line":"from oslo_utils import uuidutils"},{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from manila.common import constants"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_c7d63a4e","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":32},"updated":"2016-08-10 21:13:04.000000000","message":"so this is no longer used.","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"686cde9a1a12ebb66a646ac80948077ccae44822","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_log import log"},{"line_number":17,"context_line":"from oslo_utils import uuidutils"},{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from manila.common import constants"}],"source_content_type":"text/x-python","patch_set":9,"id":"3ac371cc_39570904","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":32},"in_reply_to":"9ad45d7e_c7d63a4e","updated":"2016-08-16 08:39:14.000000000","message":"Done","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"35cdd33e7bdc219106e05a2ddfed8552cd9da7ca","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                             share_server)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            if access_keys:"},{"line_number":101,"context_line":"                if ("},{"line_number":102,"context_line":"                    not (add_rules or delete_rules)  # recovery mode"},{"line_number":103,"context_line":"                    and len(access_keys) !\u003d len(rules)"},{"line_number":104,"context_line":"                ):"},{"line_number":105,"context_line":"                    msg \u003d _(\"During recovery of access rules, the driver \""}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_0785f205","line":102,"range":{"start_line":101,"start_character":19,"end_line":102,"end_character":24},"updated":"2016-08-10 21:13:04.000000000","message":"I don\u0027t see the inner function _validate_access_keys that you proposed at patch 7.  Do we not need these checks anymore?","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"686cde9a1a12ebb66a646ac80948077ccae44822","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                             share_server)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            if access_keys:"},{"line_number":101,"context_line":"                if ("},{"line_number":102,"context_line":"                    not (add_rules or delete_rules)  # recovery mode"},{"line_number":103,"context_line":"                    and len(access_keys) !\u003d len(rules)"},{"line_number":104,"context_line":"                ):"},{"line_number":105,"context_line":"                    msg \u003d _(\"During recovery of access rules, the driver \""}],"source_content_type":"text/x-python","patch_set":9,"id":"3ac371cc_593e45b9","line":102,"range":{"start_line":101,"start_character":19,"end_line":102,"end_character":24},"in_reply_to":"9ad45d7e_0785f205","updated":"2016-08-16 08:39:14.000000000","message":"Done","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6c2463fdb1e14c5a2af1128966272cfd8ef29a3d","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                    msg \u003d _(\"During recovery of access rules, the driver \""},{"line_number":106,"context_line":"                            \"failed to return access_keys for all the rules \""},{"line_number":107,"context_line":"                            \"it is expected to sync to the backend.\")"},{"line_number":108,"context_line":"                    raise exception.Invalid(message\u003dmsg)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"                for access_id, access_key in access_keys.items():"},{"line_number":111,"context_line":"                    self.db.share_access_update_access_key("}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_490e94e5","line":108,"range":{"start_line":108,"start_character":20,"end_line":108,"end_character":56},"updated":"2016-08-11 23:49:06.000000000","message":"this is going to leave the instance in error state again. What is the strategy for clearing the error state? invoke access-deny (which will trigger recovery mode again) until all rules are capable of returning access keys?","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"0077c5a6cf470e07fc8b1bbccecdbaab333e96c1","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                    msg \u003d _(\"During recovery of access rules, the driver \""},{"line_number":106,"context_line":"                            \"failed to return access_keys for all the rules \""},{"line_number":107,"context_line":"                            \"it is expected to sync to the backend.\")"},{"line_number":108,"context_line":"                    raise exception.Invalid(message\u003dmsg)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"                for access_id, access_key in access_keys.items():"},{"line_number":111,"context_line":"                    self.db.share_access_update_access_key("}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_7f720a4b","line":108,"range":{"start_line":108,"start_character":20,"end_line":108,"end_character":56},"in_reply_to":"9ad45d7e_490e94e5","updated":"2016-08-12 12:29:34.000000000","message":"Yes, that was my thought. If recovery isn\u0027t done properly, i.e. unable to return access keys for all the rules to be recovered, then raise an error conveying that recovery wasn\u0027t successful with a useful message that at least the cloud admin can see, and use to appropriately intervene.\n\nIs there a better way to handle failure of recovery procedure?","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2a38e5ec60f0a8f7e448dde7ebe42a0efd76a562","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                    msg \u003d _(\"During recovery of access rules, the driver \""},{"line_number":106,"context_line":"                            \"failed to return access_keys for all the rules \""},{"line_number":107,"context_line":"                            \"it is expected to sync to the backend.\")"},{"line_number":108,"context_line":"                    raise exception.Invalid(message\u003dmsg)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"                for access_id, access_key in access_keys.items():"},{"line_number":111,"context_line":"                    self.db.share_access_update_access_key("}],"source_content_type":"text/x-python","patch_set":9,"id":"7ac969e8_205b5656","line":108,"range":{"start_line":108,"start_character":20,"end_line":108,"end_character":56},"in_reply_to":"9ad45d7e_7f720a4b","updated":"2016-08-13 00:20:01.000000000","message":"for the moment I don\u0027t think so","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"b16ba14e9b78b5dba09ae5874461d430e004e114","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"            def validate_access_keys(access_keys):"},{"line_number":124,"context_line":"                if not isinstance(access_keys, dict):"},{"line_number":125,"context_line":"                    msg \u003d (_(\"The driver returns access keys as %s instead of \""},{"line_number":126,"context_line":"                             \"as a dictionary with rule ID, and its \""},{"line_number":127,"context_line":"                             \"access key as key, value pairs.\")"},{"line_number":128,"context_line":"                           % type(access_keys))"},{"line_number":129,"context_line":"                    raise exception.Invalid(message\u003dmsg)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3ac371cc_07767fa3","line":127,"range":{"start_line":125,"start_character":29,"end_line":127,"end_character":63},"updated":"2016-08-17 19:53:34.000000000","message":"Not sure this is the clearest message.  I\u0027d expect a massage that says that the access keys must be supplied as a dictionary that maps rule IDs to driver access keys.","commit_id":"b11134160c5d64b5188fa989689f5f6f61bcf37b"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"7984155784c187d7d75a803f3c02f88a68d4c093","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"            def validate_access_keys(access_keys):"},{"line_number":124,"context_line":"                if not isinstance(access_keys, dict):"},{"line_number":125,"context_line":"                    msg \u003d (_(\"The driver returns access keys as %s instead of \""},{"line_number":126,"context_line":"                             \"as a dictionary with rule ID, and its \""},{"line_number":127,"context_line":"                             \"access key as key, value pairs.\")"},{"line_number":128,"context_line":"                           % type(access_keys))"},{"line_number":129,"context_line":"                    raise exception.Invalid(message\u003dmsg)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3ac371cc_5d282d33","line":127,"range":{"start_line":125,"start_character":29,"end_line":127,"end_character":63},"in_reply_to":"3ac371cc_07767fa3","updated":"2016-08-18 07:28:21.000000000","message":"Done","commit_id":"b11134160c5d64b5188fa989689f5f6f61bcf37b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"b16ba14e9b78b5dba09ae5874461d430e004e114","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                else:"},{"line_number":136,"context_line":"                    expected_rule_ids \u003d [rule[\u0027id\u0027] for rule in add_rules]"},{"line_number":137,"context_line":"                if actual_rule_ids !\u003d sorted(expected_rule_ids):"},{"line_number":138,"context_line":"                    msg \u003d (_(\"The driver returns access keys for rules, \""},{"line_number":139,"context_line":"                             \"%(actual)s, instead of for rules, %(expected)s.\")"},{"line_number":140,"context_line":"                           % {\u0027actual\u0027: actual_rule_ids,"},{"line_number":141,"context_line":"                              \u0027expected\u0027: expected_rule_ids})"},{"line_number":142,"context_line":"                    raise exception.Invalid(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3ac371cc_87b1cf49","line":139,"range":{"start_line":138,"start_character":30,"end_line":139,"end_character":79},"updated":"2016-08-17 19:53:34.000000000","message":"ditto.  Maybe: \u0027The rule IDs supplied [%(actual)s] do not match the rule IDs that are expected [%(expected)s].\u0027","commit_id":"b11134160c5d64b5188fa989689f5f6f61bcf37b"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"7984155784c187d7d75a803f3c02f88a68d4c093","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                else:"},{"line_number":136,"context_line":"                    expected_rule_ids \u003d [rule[\u0027id\u0027] for rule in add_rules]"},{"line_number":137,"context_line":"                if actual_rule_ids !\u003d sorted(expected_rule_ids):"},{"line_number":138,"context_line":"                    msg \u003d (_(\"The driver returns access keys for rules, \""},{"line_number":139,"context_line":"                             \"%(actual)s, instead of for rules, %(expected)s.\")"},{"line_number":140,"context_line":"                           % {\u0027actual\u0027: actual_rule_ids,"},{"line_number":141,"context_line":"                              \u0027expected\u0027: expected_rule_ids})"},{"line_number":142,"context_line":"                    raise exception.Invalid(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3ac371cc_bd232155","line":139,"range":{"start_line":138,"start_character":30,"end_line":139,"end_character":79},"in_reply_to":"3ac371cc_87b1cf49","updated":"2016-08-18 07:28:21.000000000","message":"Done","commit_id":"b11134160c5d64b5188fa989689f5f6f61bcf37b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"b16ba14e9b78b5dba09ae5874461d430e004e114","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"                for access_key in access_keys.values():"},{"line_number":145,"context_line":"                    if not isinstance(access_key, six.string_types):"},{"line_number":146,"context_line":"                        msg \u003d (_(\"The driver returns an access key, %s which \""},{"line_number":147,"context_line":"                                 \"is not string type.\") % access_key)"},{"line_number":148,"context_line":"                        raise exception.Invalid(message\u003dmsg)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            if access_keys:"}],"source_content_type":"text/x-python","patch_set":12,"id":"3ac371cc_27cd7bb7","line":147,"range":{"start_line":146,"start_character":34,"end_line":147,"end_character":69},"updated":"2016-08-17 19:53:34.000000000","message":"Ditto.  Maybe \u0027Driver access key [%s] is not a string type.\u0027","commit_id":"b11134160c5d64b5188fa989689f5f6f61bcf37b"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"7984155784c187d7d75a803f3c02f88a68d4c093","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"                for access_key in access_keys.values():"},{"line_number":145,"context_line":"                    if not isinstance(access_key, six.string_types):"},{"line_number":146,"context_line":"                        msg \u003d (_(\"The driver returns an access key, %s which \""},{"line_number":147,"context_line":"                                 \"is not string type.\") % access_key)"},{"line_number":148,"context_line":"                        raise exception.Invalid(message\u003dmsg)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            if access_keys:"}],"source_content_type":"text/x-python","patch_set":12,"id":"3ac371cc_9d1e250a","line":147,"range":{"start_line":146,"start_character":34,"end_line":147,"end_character":69},"in_reply_to":"3ac371cc_27cd7bb7","updated":"2016-08-18 07:28:21.000000000","message":"Done","commit_id":"b11134160c5d64b5188fa989689f5f6f61bcf37b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"b16ba14e9b78b5dba09ae5874461d430e004e114","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                for access_id, access_key in access_keys.items():"},{"line_number":154,"context_line":"                    self.db.share_access_update_access_key("},{"line_number":155,"context_line":"                        context, access_id, access_key)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        except Exception:"},{"line_number":158,"context_line":"            self.db.share_instance_update_access_status("},{"line_number":159,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3ac371cc_c76aa780","line":156,"updated":"2016-08-17 19:53:34.000000000","message":"I\u0027m not sure my messages are great either, but I think the exception itself is going to indicate Invalid so it would be best to keep the message as succinct and direct as possible.  It\u0027s easy to end up with convoluted wording here because dictionaries and keys and backends have security keys and the security keys are dictionary values.","commit_id":"b11134160c5d64b5188fa989689f5f6f61bcf37b"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"7984155784c187d7d75a803f3c02f88a68d4c093","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                for access_id, access_key in access_keys.items():"},{"line_number":154,"context_line":"                    self.db.share_access_update_access_key("},{"line_number":155,"context_line":"                        context, access_id, access_key)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        except Exception:"},{"line_number":158,"context_line":"            self.db.share_instance_update_access_status("},{"line_number":159,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3ac371cc_1dc0754f","line":156,"in_reply_to":"3ac371cc_c76aa780","updated":"2016-08-18 07:28:21.000000000","message":"I think your suggestions are much better. They\u0027re less convoluted. I can edit them if you think they\u0027re still verbose and confusing.","commit_id":"b11134160c5d64b5188fa989689f5f6f61bcf37b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6ee4fcd8458568977e96b620bf1c4af0b58f65","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                                             remove_rules, share_instance,"},{"line_number":121,"context_line":"                                             share_server)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"            def validate_access_keys(access_keys):"},{"line_number":124,"context_line":"                if not isinstance(access_keys, dict):"},{"line_number":125,"context_line":"                    msg \u003d _(\"The access keys must be supplied as a \""},{"line_number":126,"context_line":"                            \"dictionary that maps rule IDs to access \""}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_2044f372","line":123,"range":{"start_line":123,"start_character":0,"end_line":123,"end_character":50},"updated":"2016-08-19 14:11:53.000000000","message":"long methods inside methods make for bad readability.. suggest pulling this outside this method.","commit_id":"d84b8f4d1e8b1c9d8e0205d2759a30293920876f"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"d12688b37e755c4a8967f0dc002e6ab7f6ef762f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                                             remove_rules, share_instance,"},{"line_number":121,"context_line":"                                             share_server)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"            def validate_access_keys(access_keys):"},{"line_number":124,"context_line":"                if not isinstance(access_keys, dict):"},{"line_number":125,"context_line":"                    msg \u003d _(\"The access keys must be supplied as a \""},{"line_number":126,"context_line":"                            \"dictionary that maps rule IDs to access \""}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_749f9150","line":123,"range":{"start_line":123,"start_character":0,"end_line":123,"end_character":50},"in_reply_to":"1ac06dbe_2044f372","updated":"2016-08-21 14:31:32.000000000","message":"Done","commit_id":"d84b8f4d1e8b1c9d8e0205d2759a30293920876f"}],"manila/share/api.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"390a7a1bd720c571ea2ae7dd50ce0063e989fd1d","unresolved":false,"context_lines":[{"line_number":1302,"context_line":"        \"\"\"Returns all access rules for share.\"\"\""},{"line_number":1303,"context_line":"        policy.check_policy(context, \u0027share\u0027, \u0027access_get_all\u0027)"},{"line_number":1304,"context_line":"        rules \u003d self.db.share_access_get_all_for_share(context, share[\u0027id\u0027])"},{"line_number":1305,"context_line":"        if not return_access_key:"},{"line_number":1306,"context_line":"            return [{\u0027id\u0027: rule.id,"},{"line_number":1307,"context_line":"                     \u0027access_type\u0027: rule.access_type,"},{"line_number":1308,"context_line":"                     \u0027access_to\u0027: rule.access_to,"},{"line_number":1309,"context_line":"                     \u0027access_level\u0027: rule.access_level,"},{"line_number":1310,"context_line":"                     \u0027state\u0027: rule.state,"},{"line_number":1311,"context_line":"                     } for rule in rules]"},{"line_number":1312,"context_line":"        else:"},{"line_number":1313,"context_line":"            return [{\u0027id\u0027: rule.id,"},{"line_number":1314,"context_line":"                     \u0027access_key\u0027: rule.access_key,"},{"line_number":1315,"context_line":"                     \u0027access_type\u0027: rule.access_type,"},{"line_number":1316,"context_line":"                     \u0027access_to\u0027: rule.access_to,"},{"line_number":1317,"context_line":"                     \u0027access_level\u0027: rule.access_level,"},{"line_number":1318,"context_line":"                     \u0027state\u0027: rule.state,"},{"line_number":1319,"context_line":"                     } for rule in rules]"},{"line_number":1320,"context_line":""},{"line_number":1321,"context_line":"    def access_get(self, context, access_id):"},{"line_number":1322,"context_line":"        \"\"\"Returns access rule with the id.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_d2ef08af","line":1319,"range":{"start_line":1305,"start_character":8,"end_line":1319,"end_character":41},"updated":"2016-07-26 20:49:53.000000000","message":"ideally this should be in a view, and your microversion bump should add the field","commit_id":"129f1f424eb205362b1a7f426ab4c07605ebad17"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"7a5cfcee48560ab6bfa47c3f330ef756cc9ef3bb","unresolved":false,"context_lines":[{"line_number":1302,"context_line":"        \"\"\"Returns all access rules for share.\"\"\""},{"line_number":1303,"context_line":"        policy.check_policy(context, \u0027share\u0027, \u0027access_get_all\u0027)"},{"line_number":1304,"context_line":"        rules \u003d self.db.share_access_get_all_for_share(context, share[\u0027id\u0027])"},{"line_number":1305,"context_line":"        if not return_access_key:"},{"line_number":1306,"context_line":"            return [{\u0027id\u0027: rule.id,"},{"line_number":1307,"context_line":"                     \u0027access_type\u0027: rule.access_type,"},{"line_number":1308,"context_line":"                     \u0027access_to\u0027: rule.access_to,"},{"line_number":1309,"context_line":"                     \u0027access_level\u0027: rule.access_level,"},{"line_number":1310,"context_line":"                     \u0027state\u0027: rule.state,"},{"line_number":1311,"context_line":"                     } for rule in rules]"},{"line_number":1312,"context_line":"        else:"},{"line_number":1313,"context_line":"            return [{\u0027id\u0027: rule.id,"},{"line_number":1314,"context_line":"                     \u0027access_key\u0027: rule.access_key,"},{"line_number":1315,"context_line":"                     \u0027access_type\u0027: rule.access_type,"},{"line_number":1316,"context_line":"                     \u0027access_to\u0027: rule.access_to,"},{"line_number":1317,"context_line":"                     \u0027access_level\u0027: rule.access_level,"},{"line_number":1318,"context_line":"                     \u0027state\u0027: rule.state,"},{"line_number":1319,"context_line":"                     } for rule in rules]"},{"line_number":1320,"context_line":""},{"line_number":1321,"context_line":"    def access_get(self, context, access_id):"},{"line_number":1322,"context_line":"        \"\"\"Returns access rule with the id.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_d56d1ecd","line":1319,"range":{"start_line":1305,"start_character":8,"end_line":1319,"end_character":41},"in_reply_to":"dada55a8_d2ef08af","updated":"2016-08-01 13:09:21.000000000","message":"Done","commit_id":"129f1f424eb205362b1a7f426ab4c07605ebad17"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"3339be6a5c6989c83416fbb8224d12f2868746e8","unresolved":false,"context_lines":[{"line_number":1213,"context_line":"        # NOTE(tpsilva): refreshing share_access model"},{"line_number":1214,"context_line":"        access \u003d self.db.share_access_get(ctx, access[\u0027id\u0027])"},{"line_number":1215,"context_line":""},{"line_number":1216,"context_line":"        return {"},{"line_number":1217,"context_line":"            \u0027id\u0027: access[\u0027id\u0027],"},{"line_number":1218,"context_line":"            \u0027share_id\u0027: access[\u0027share_id\u0027],"},{"line_number":1219,"context_line":"            \u0027access_type\u0027: access[\u0027access_type\u0027],"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ac06dbe_5afa6abe","line":1216,"updated":"2016-08-22 09:22:21.000000000","message":"return access","commit_id":"887b73177235bf64d3f8788907480719f95d3e86"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"d4e73e68bc40401013e3d27c98a7c2dc46dd6695","unresolved":false,"context_lines":[{"line_number":1213,"context_line":"        # NOTE(tpsilva): refreshing share_access model"},{"line_number":1214,"context_line":"        access \u003d self.db.share_access_get(ctx, access[\u0027id\u0027])"},{"line_number":1215,"context_line":""},{"line_number":1216,"context_line":"        return {"},{"line_number":1217,"context_line":"            \u0027id\u0027: access[\u0027id\u0027],"},{"line_number":1218,"context_line":"            \u0027share_id\u0027: access[\u0027share_id\u0027],"},{"line_number":1219,"context_line":"            \u0027access_type\u0027: access[\u0027access_type\u0027],"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ac06dbe_a9835555","line":1216,"in_reply_to":"1ac06dbe_5afa6abe","updated":"2016-08-22 11:46:57.000000000","message":"Done","commit_id":"887b73177235bf64d3f8788907480719f95d3e86"}],"manila/tests/api/views/test_share_accesses.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6ee4fcd8458568977e96b620bf1c4af0b58f65","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        result \u003d self.builder.view(req, self.fake_access)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        if version \u003d\u003d \"2.20\":"},{"line_number":48,"context_line":"            del self.fake_access[\u0027access_key\u0027]"},{"line_number":49,"context_line":"        self.assertEqual(self.fake_access, result)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_b84bf358","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":29},"updated":"2016-08-19 14:11:53.000000000","message":"from manila.api.openstack import api_version_request as api_version\n\nif api_version.APIVersionRequest(version) \u003e\u003d api_version.APIVersionRequest(\u00272.20\u0027)):","commit_id":"d84b8f4d1e8b1c9d8e0205d2759a30293920876f"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"d12688b37e755c4a8967f0dc002e6ab7f6ef762f","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        result \u003d self.builder.view(req, self.fake_access)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        if version \u003d\u003d \"2.20\":"},{"line_number":48,"context_line":"            del self.fake_access[\u0027access_key\u0027]"},{"line_number":49,"context_line":"        self.assertEqual(self.fake_access, result)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_3424f9ad","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":29},"in_reply_to":"1ac06dbe_b84bf358","updated":"2016-08-21 14:31:32.000000000","message":"Done","commit_id":"d84b8f4d1e8b1c9d8e0205d2759a30293920876f"}],"manila/tests/db/migrations/alembic/migrations_data_checks.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"026840117383f92fddf391c00b8c3a100672f2a2","unresolved":false,"context_lines":[{"line_number":954,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":955,"context_line":"            \u0027share_id\u0027: share_data[\u0027id\u0027],"},{"line_number":956,"context_line":"            \u0027access_type\u0027: \u0027cephx\u0027,"},{"line_number":957,"context_line":"            \u0027access_to\u0027: \u0027alice\u0027,"},{"line_number":958,"context_line":"        }"},{"line_number":959,"context_line":"        share_access_table \u003d utils.load_table(self.table_name, engine)"},{"line_number":960,"context_line":"        engine.execute(share_access_table.insert(share_access_data))"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_099ec962","line":957,"range":{"start_line":957,"start_character":12,"end_line":957,"end_character":33},"updated":"2016-08-17 03:31:23.000000000","message":"\u0027deleted\u0027: \u0027False\u0027,","commit_id":"cae91288b0245b295f60c90bb70d8b45f594fdbe"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"2206a87324185c7457ccb41885e6b9530343d601","unresolved":false,"context_lines":[{"line_number":954,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":955,"context_line":"            \u0027share_id\u0027: share_data[\u0027id\u0027],"},{"line_number":956,"context_line":"            \u0027access_type\u0027: \u0027cephx\u0027,"},{"line_number":957,"context_line":"            \u0027access_to\u0027: \u0027alice\u0027,"},{"line_number":958,"context_line":"        }"},{"line_number":959,"context_line":"        share_access_table \u003d utils.load_table(self.table_name, engine)"},{"line_number":960,"context_line":"        engine.execute(share_access_table.insert(share_access_data))"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_8538d53e","line":957,"range":{"start_line":957,"start_character":12,"end_line":957,"end_character":33},"in_reply_to":"3ac371cc_099ec962","updated":"2016-08-17 07:41:42.000000000","message":"Done","commit_id":"cae91288b0245b295f60c90bb70d8b45f594fdbe"}],"manila/tests/share/test_access.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"35cdd33e7bdc219106e05a2ddfed8552cd9da7ca","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def test_update_access_rules_returns_access_keys(self, access_keys):"},{"line_number":91,"context_line":"        rules \u003d ["},{"line_number":92,"context_line":"            db_utils.create_access("},{"line_number":93,"context_line":"            id\u003d\u0027fakeaccessid\u0027,"},{"line_number":94,"context_line":"            share_id\u003dself.share[\u0027id\u0027],"},{"line_number":95,"context_line":"            access_to\u003d\u0027fakecred\u0027)]"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        share_instance \u003d db_utils.create_share_instance("},{"line_number":98,"context_line":"            id\u003d\u0027fakeshareinstanceid\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_2710f658","line":95,"range":{"start_line":93,"start_character":12,"end_line":95,"end_character":34},"updated":"2016-08-10 21:13:04.000000000","message":"indent these","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"686cde9a1a12ebb66a646ac80948077ccae44822","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def test_update_access_rules_returns_access_keys(self, access_keys):"},{"line_number":91,"context_line":"        rules \u003d ["},{"line_number":92,"context_line":"            db_utils.create_access("},{"line_number":93,"context_line":"            id\u003d\u0027fakeaccessid\u0027,"},{"line_number":94,"context_line":"            share_id\u003dself.share[\u0027id\u0027],"},{"line_number":95,"context_line":"            access_to\u003d\u0027fakecred\u0027)]"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        share_instance \u003d db_utils.create_share_instance("},{"line_number":98,"context_line":"            id\u003d\u0027fakeshareinstanceid\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3ac371cc_b93499de","line":95,"range":{"start_line":93,"start_character":12,"end_line":95,"end_character":34},"in_reply_to":"9ad45d7e_2710f658","updated":"2016-08-16 08:39:14.000000000","message":"Done","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"35cdd33e7bdc219106e05a2ddfed8552cd9da7ca","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        else:"},{"line_number":131,"context_line":"            self.assertFalse(db.share_access_update_access_key.called)"},{"line_number":132,"context_line":"        db.share_instance_update_access_status.assert_called_with("},{"line_number":133,"context_line":"            self.context, share_instance[\u0027id\u0027], constants.STATUS_ACTIVE)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_update_access_rules_fallback(self):"},{"line_number":137,"context_line":"        add_rules \u003d [db_utils.create_access(share_id\u003dself.share[\u0027id\u0027])]"},{"line_number":138,"context_line":"        delete_rules \u003d [db_utils.create_access(share_id\u003dself.share[\u0027id\u0027])]"},{"line_number":139,"context_line":"        original_rules \u003d [db_utils.create_access(share_id\u003dself.share[\u0027id\u0027])]"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_e2008c03","line":136,"range":{"start_line":133,"start_character":0,"end_line":136,"end_character":48},"updated":"2016-08-10 21:13:04.000000000","message":"extra blank line here","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"686cde9a1a12ebb66a646ac80948077ccae44822","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        else:"},{"line_number":131,"context_line":"            self.assertFalse(db.share_access_update_access_key.called)"},{"line_number":132,"context_line":"        db.share_instance_update_access_status.assert_called_with("},{"line_number":133,"context_line":"            self.context, share_instance[\u0027id\u0027], constants.STATUS_ACTIVE)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_update_access_rules_fallback(self):"},{"line_number":137,"context_line":"        add_rules \u003d [db_utils.create_access(share_id\u003dself.share[\u0027id\u0027])]"},{"line_number":138,"context_line":"        delete_rules \u003d [db_utils.create_access(share_id\u003dself.share[\u0027id\u0027])]"},{"line_number":139,"context_line":"        original_rules \u003d [db_utils.create_access(share_id\u003dself.share[\u0027id\u0027])]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3ac371cc_9931ddef","line":136,"range":{"start_line":133,"start_character":0,"end_line":136,"end_character":48},"in_reply_to":"9ad45d7e_e2008c03","updated":"2016-08-16 08:39:14.000000000","message":"Done","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"}],"manila_tempest_tests/tests/api/test_rules.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3d4a011a492ed48789ac637f5b9307887d8fc90b","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        elif CONF.share.enable_cephx_rules_for_protocols:"},{"line_number":425,"context_line":"            cls.protocol \u003d CONF.share.enable_cephx_rules_for_protocols[0]"},{"line_number":426,"context_line":"            cls.access_type \u003d \"cephx\""},{"line_number":427,"context_line":"            cls.access_to \u003d \"eve\""},{"line_number":428,"context_line":"        cls.shares_v2_client.share_protocol \u003d cls.protocol"},{"line_number":429,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":430,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_f881f5fc","line":427,"range":{"start_line":427,"start_character":29,"end_line":427,"end_character":32},"updated":"2016-08-19 13:05:14.000000000","message":"what is wrong with alice? xD","commit_id":"d84b8f4d1e8b1c9d8e0205d2759a30293920876f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6ee4fcd8458568977e96b620bf1c4af0b58f65","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        elif CONF.share.enable_cephx_rules_for_protocols:"},{"line_number":425,"context_line":"            cls.protocol \u003d CONF.share.enable_cephx_rules_for_protocols[0]"},{"line_number":426,"context_line":"            cls.access_type \u003d \"cephx\""},{"line_number":427,"context_line":"            cls.access_to \u003d \"eve\""},{"line_number":428,"context_line":"        cls.shares_v2_client.share_protocol \u003d cls.protocol"},{"line_number":429,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":430,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_18b5e7cc","line":427,"range":{"start_line":427,"start_character":29,"end_line":427,"end_character":32},"in_reply_to":"1ac06dbe_f881f5fc","updated":"2016-08-19 14:11:53.000000000","message":"He\u0027s trying to do right by eve.","commit_id":"d84b8f4d1e8b1c9d8e0205d2759a30293920876f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"df28ac514d89a992f89d67b4d80fef5da9aeb491","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        self.assertEqual(\u0027rw\u0027, rules[0][\"access_level\"])"},{"line_number":480,"context_line":"        if utils.is_microversion_ge(version, \u00272.21\u0027):"},{"line_number":481,"context_line":"            if self.access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":482,"context_line":"                self.assertIsNotNone(rules[0][\u0027access_key\u0027])"},{"line_number":483,"context_line":"            else:"},{"line_number":484,"context_line":"                self.assertIsNone(rules[0][\u0027access_key\u0027])"},{"line_number":485,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1ac06dbe_6870b672","line":482,"range":{"start_line":482,"start_character":16,"end_line":482,"end_character":60},"updated":"2016-08-24 03:28:05.000000000","message":"don\u0027t you want to validate the access key, in terms of allowable characters?","commit_id":"0d4f2ee4e0fd6d389d7d7a9d5fefe65d3137e7bf"}],"releasenotes/notes/add-access-key-to-share-access-map-2fda4c06a750e24e.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eede69dfbc47361202fe854adf01450da1c4e7f9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Driver may return ``access_key``, an access credential, for client"},{"line_number":4,"context_line":"    identities granted share access."},{"line_number":5,"context_line":"  - Added ``access_key`` to the ShareAccessMapping model."},{"line_number":6,"context_line":"  - Exposed ``access_key`` to the client through the ``access_list`` API."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9ad45d7e_e7396ca5","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":57},"updated":"2016-08-12 03:20:33.000000000","message":"not necessary..","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"686cde9a1a12ebb66a646ac80948077ccae44822","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Driver may return ``access_key``, an access credential, for client"},{"line_number":4,"context_line":"    identities granted share access."},{"line_number":5,"context_line":"  - Added ``access_key`` to the ShareAccessMapping model."},{"line_number":6,"context_line":"  - Exposed ``access_key`` to the client through the ``access_list`` API."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3ac371cc_f0b9feed","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":57},"in_reply_to":"9ad45d7e_e7396ca5","updated":"2016-08-16 08:39:14.000000000","message":"Done","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eede69dfbc47361202fe854adf01450da1c4e7f9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Driver may return ``access_key``, an access credential, for client"},{"line_number":4,"context_line":"    identities granted share access."},{"line_number":5,"context_line":"  - Added ``access_key`` to the ShareAccessMapping model."},{"line_number":6,"context_line":"  - Exposed ``access_key`` to the client through the ``access_list`` API."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9ad45d7e_874fd032","line":6,"range":{"start_line":6,"start_character":27,"end_line":6,"end_character":53},"updated":"2016-08-12 03:20:33.000000000","message":"The convention has been:\n\n  Added xyzzy to the JSON response of the spoon API","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"686cde9a1a12ebb66a646ac80948077ccae44822","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Driver may return ``access_key``, an access credential, for client"},{"line_number":4,"context_line":"    identities granted share access."},{"line_number":5,"context_line":"  - Added ``access_key`` to the ShareAccessMapping model."},{"line_number":6,"context_line":"  - Exposed ``access_key`` to the client through the ``access_list`` API."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3ac371cc_d0be82d3","line":6,"range":{"start_line":6,"start_character":27,"end_line":6,"end_character":53},"in_reply_to":"9ad45d7e_874fd032","updated":"2016-08-16 08:39:14.000000000","message":"Done","commit_id":"980faa4c41f3e22a365940c79133c16921e07002"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3d4a011a492ed48789ac637f5b9307887d8fc90b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Driver may return ``access_key``, an access credential, for client"},{"line_number":4,"context_line":"    identities granted share access."},{"line_number":5,"context_line":"  - Added ``access_key`` to the JSON response of  ``access_list`` API."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1ac06dbe_b8113db2","line":5,"range":{"start_line":5,"start_character":49,"end_line":5,"end_character":50},"updated":"2016-08-19 13:05:14.000000000","message":"extra space","commit_id":"d84b8f4d1e8b1c9d8e0205d2759a30293920876f"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"d12688b37e755c4a8967f0dc002e6ab7f6ef762f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Driver may return ``access_key``, an access credential, for client"},{"line_number":4,"context_line":"    identities granted share access."},{"line_number":5,"context_line":"  - Added ``access_key`` to the JSON response of  ``access_list`` API."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1ac06dbe_f450a10c","line":5,"range":{"start_line":5,"start_character":49,"end_line":5,"end_character":50},"in_reply_to":"1ac06dbe_b8113db2","updated":"2016-08-21 14:31:32.000000000","message":"Done","commit_id":"d84b8f4d1e8b1c9d8e0205d2759a30293920876f"}]}
