)]}'
{"manila/share/drivers/quobyte/quobyte.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9f46b92c9f3631fdf374e8c2d37366263fd455bb","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        1.0.1   - Adds ensure_share() implementation."},{"line_number":77,"context_line":"        1.1     - Adds extend_share() and shrink_share() implementation."},{"line_number":78,"context_line":"        1.2     - Adds update_access() implementation and related methods"},{"line_number":79,"context_line":"        1.2.1   - Improved capacity calculation"},{"line_number":80,"context_line":"        1.2.2   - Updated RPC layer for improved stability"},{"line_number":81,"context_line":"        1.2.3   - Minor optimizations"},{"line_number":82,"context_line":"    \"\"\""},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_8f054c12","line":80,"range":{"start_line":79,"start_character":8,"end_line":80,"end_character":58},"updated":"2016-07-21 11:06:32.000000000","message":"Why changes [1] in your separate commits repeat each other?\n\n[1] https://review.openstack.org/#/c/345219/3/manila/share/drivers/quobyte/quobyte.py\n\nThey should either depend on each other or do not implement changes from other commits.","commit_id":"0db64f7227e6297d0ae8490c3795c3faf3a55f19"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"7f9ff2487b994774f394eff5c37dbeb25ce33aea","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        1.0.1   - Adds ensure_share() implementation."},{"line_number":77,"context_line":"        1.1     - Adds extend_share() and shrink_share() implementation."},{"line_number":78,"context_line":"        1.2     - Adds update_access() implementation and related methods"},{"line_number":79,"context_line":"        1.2.1   - Improved capacity calculation"},{"line_number":80,"context_line":"        1.2.2   - Updated RPC layer for improved stability"},{"line_number":81,"context_line":"        1.2.3   - Minor optimizations"},{"line_number":82,"context_line":"    \"\"\""},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_32a768be","line":80,"range":{"start_line":79,"start_character":8,"end_line":80,"end_character":58},"in_reply_to":"dada55a8_8f054c12","updated":"2016-07-21 11:48:29.000000000","message":"True point. With regards to content there\u0027s no dependency between those changes. I added this for clarification but probably it\u0027s not really helping. I\u0027ll remove the other changes version here.","commit_id":"0db64f7227e6297d0ae8490c3795c3faf3a55f19"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"97de8440e8653b33f6aaee0da5e1936b8aeaa965","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        1.0.1   - Adds ensure_share() implementation."},{"line_number":77,"context_line":"        1.1     - Adds extend_share() and shrink_share() implementation."},{"line_number":78,"context_line":"        1.2     - Adds update_access() implementation and related methods"},{"line_number":79,"context_line":"        1.2.3   - Minor optimizations"},{"line_number":80,"context_line":"    \"\"\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    DRIVER_VERSION \u003d \u00271.2.3\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_9c4a6c54","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":37},"updated":"2016-07-22 11:11:34.000000000","message":"1.2.1 and 1.2.2 are lost.","commit_id":"1306ce1e3eb8bb4b7c6d67388240b6f93cb76817"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"47cd6f25f3a5592ce6ba8276f7869f2372a5b04b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        1.0.1   - Adds ensure_share() implementation."},{"line_number":77,"context_line":"        1.1     - Adds extend_share() and shrink_share() implementation."},{"line_number":78,"context_line":"        1.2     - Adds update_access() implementation and related methods"},{"line_number":79,"context_line":"        1.2.3   - Minor optimizations"},{"line_number":80,"context_line":"    \"\"\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    DRIVER_VERSION \u003d \u00271.2.3\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_a4ca774d","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":37},"in_reply_to":"dada55a8_9c4a6c54","updated":"2016-07-25 07:21:38.000000000","message":"1.2.1 is merged and this change has been rebased accordingly (please see latest version of this change).\nA change introducing 1.2.2 is currently in review (please see https://review.openstack.org/#/c/345219/).","commit_id":"1306ce1e3eb8bb4b7c6d67388240b6f93cb76817"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e5dce62c6893fb01418775899f3d234f72ff8d42","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        if self.configuration.quobyte_delete_shares:"},{"line_number":253,"context_line":"            self.rpc.call(\u0027deleteVolume\u0027, {\u0027volume_uuid\u0027: volume_uuid})"},{"line_number":254,"context_line":"        else:"},{"line_number":255,"context_line":"            self.rpc.call(\u0027exportVolume\u0027, dict("},{"line_number":256,"context_line":"                volume_uuid\u003dvolume_uuid,"},{"line_number":257,"context_line":"                remove_export\u003dTrue))"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_97210250","line":255,"range":{"start_line":255,"start_character":42,"end_line":255,"end_character":47},"updated":"2016-07-26 20:18:21.000000000","message":"according to bug entry 1548227 that you addressing, you should replace this dict() by {}","commit_id":"3b6b84136d4629c485cf17763c58ca67877888aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b26b391a83f9b18f84eac88035699bc8ff85cefd","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        if self.configuration.quobyte_delete_shares:"},{"line_number":253,"context_line":"            self.rpc.call(\u0027deleteVolume\u0027, {\u0027volume_uuid\u0027: volume_uuid})"},{"line_number":254,"context_line":"        else:"},{"line_number":255,"context_line":"            self.rpc.call(\u0027exportVolume\u0027, dict("},{"line_number":256,"context_line":"                volume_uuid\u003dvolume_uuid,"},{"line_number":257,"context_line":"                remove_export\u003dTrue))"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_9d7da11e","line":255,"range":{"start_line":255,"start_character":42,"end_line":255,"end_character":47},"in_reply_to":"dada55a8_97210250","updated":"2016-07-26 21:07:42.000000000","message":"+1","commit_id":"3b6b84136d4629c485cf17763c58ca67877888aa"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"d0af63712d6843978081c20a093fc28a16265f88","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        if self.configuration.quobyte_delete_shares:"},{"line_number":253,"context_line":"            self.rpc.call(\u0027deleteVolume\u0027, {\u0027volume_uuid\u0027: volume_uuid})"},{"line_number":254,"context_line":"        else:"},{"line_number":255,"context_line":"            self.rpc.call(\u0027exportVolume\u0027, dict("},{"line_number":256,"context_line":"                volume_uuid\u003dvolume_uuid,"},{"line_number":257,"context_line":"                remove_export\u003dTrue))"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_fb1db70f","line":255,"range":{"start_line":255,"start_character":42,"end_line":255,"end_character":47},"in_reply_to":"dada55a8_97210250","updated":"2016-07-27 06:54:31.000000000","message":"Ooops, lost sight of the woods for the trees here, thanks for pointing that out.\nI\u0027ll update.","commit_id":"3b6b84136d4629c485cf17763c58ca67877888aa"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"d0af63712d6843978081c20a093fc28a16265f88","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        if self.configuration.quobyte_delete_shares:"},{"line_number":253,"context_line":"            self.rpc.call(\u0027deleteVolume\u0027, {\u0027volume_uuid\u0027: volume_uuid})"},{"line_number":254,"context_line":"        else:"},{"line_number":255,"context_line":"            self.rpc.call(\u0027exportVolume\u0027, dict("},{"line_number":256,"context_line":"                volume_uuid\u003dvolume_uuid,"},{"line_number":257,"context_line":"                remove_export\u003dTrue))"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_3b146fe7","line":255,"range":{"start_line":255,"start_character":42,"end_line":255,"end_character":47},"in_reply_to":"dada55a8_9d7da11e","updated":"2016-07-27 06:54:31.000000000","message":"Done","commit_id":"3b6b84136d4629c485cf17763c58ca67877888aa"}],"manila/tests/share/drivers/quobyte/test_quobyte.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"063df60d00a330bd464a6d68535fbb33db2972e9","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        self._driver._resize_share(share\u003dself.share, new_size\u003d7)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        exp_params \u003d {\"consumer\": {\"type\": 3,"},{"line_number":397,"context_line":"                                   \"identifier\": self.share[\"name\"]},"},{"line_number":398,"context_line":"                      \"limits\": {\"type\": 5, \"value\": 7}}"},{"line_number":399,"context_line":"        self._driver.rpc.call.assert_has_calls(["},{"line_number":400,"context_line":"            mock.call(\u0027setQuota\u0027, exp_params)])"},{"line_number":401,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_1391069b","line":398,"range":{"start_line":396,"start_character":8,"end_line":398,"end_character":56},"updated":"2016-07-25 09:48:01.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"c8d710abf3b1670ac960ed8b72bc587af3ecf86a"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"bcb3926f7a106274b2a375e944d48aa00d3f84de","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        self._driver._resize_share(share\u003dself.share, new_size\u003d7)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        exp_params \u003d {\"consumer\": {\"type\": 3,"},{"line_number":397,"context_line":"                                   \"identifier\": self.share[\"name\"]},"},{"line_number":398,"context_line":"                      \"limits\": {\"type\": 5, \"value\": 7}}"},{"line_number":399,"context_line":"        self._driver.rpc.call.assert_has_calls(["},{"line_number":400,"context_line":"            mock.call(\u0027setQuota\u0027, exp_params)])"},{"line_number":401,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_ce46a17a","line":398,"range":{"start_line":396,"start_character":8,"end_line":398,"end_character":56},"in_reply_to":"dada55a8_1391069b","updated":"2016-07-25 10:35:32.000000000","message":"Done","commit_id":"c8d710abf3b1670ac960ed8b72bc587af3ecf86a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f6006b4f058a9dc8301637a33e47f28b37ea356f","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        self._driver._resize_share(share\u003dself.share, new_size\u003d7)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        exp_params \u003d {\"consumer\": {\"type\": 3,"},{"line_number":397,"context_line":"                                   \"identifier\": self.share[\"name\"],"},{"line_number":398,"context_line":"                                   },"},{"line_number":399,"context_line":"                      \"limits\": {\"type\": 5,"},{"line_number":400,"context_line":"                                 \"value\": 7},"},{"line_number":401,"context_line":"                      }"},{"line_number":402,"context_line":"        self._driver.rpc.call.assert_has_calls(["},{"line_number":403,"context_line":"            mock.call(\u0027setQuota\u0027, exp_params)])"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_146d6c99","line":401,"range":{"start_line":396,"start_character":8,"end_line":401,"end_character":23},"updated":"2016-07-25 11:04:12.000000000","message":"What is prettier?\n\n\"\"\"\nexp_params \u003d {\n    \"consumer\": {\n        \"type\": 3,\n        \"identifier\": self.share[\"name\"],\n    },\n    \"limits\": {\n         \"type\": 5,\n         \"value\": 7,\n    },\n}\n\"\"\"","commit_id":"2ad2a0d3e075e883033f4a2c2cdd72dce7816028"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"78a4c463bf517fa0d3142c0e76b43f8be7e7312c","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        self._driver._resize_share(share\u003dself.share, new_size\u003d7)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        exp_params \u003d {\"consumer\": {\"type\": 3,"},{"line_number":397,"context_line":"                                   \"identifier\": self.share[\"name\"],"},{"line_number":398,"context_line":"                                   },"},{"line_number":399,"context_line":"                      \"limits\": {\"type\": 5,"},{"line_number":400,"context_line":"                                 \"value\": 7},"},{"line_number":401,"context_line":"                      }"},{"line_number":402,"context_line":"        self._driver.rpc.call.assert_has_calls(["},{"line_number":403,"context_line":"            mock.call(\u0027setQuota\u0027, exp_params)])"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_c1d2ef5a","line":401,"range":{"start_line":396,"start_character":8,"end_line":401,"end_character":23},"in_reply_to":"dada55a8_146d6c99","updated":"2016-07-25 12:45:01.000000000","message":"Done","commit_id":"2ad2a0d3e075e883033f4a2c2cdd72dce7816028"}]}