)]}'
{"manila/share/access.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"94de538e96ca17c9ef35f2d4e5b49d85d1df3435","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        - rules which should be deleted. If \"all\" is provided - all rules will"},{"line_number":41,"context_line":"        be deleted."},{"line_number":42,"context_line":"        :param share_server: Share server model or None"},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        share_instance \u003d self.db.share_instance_get("},{"line_number":45,"context_line":"            context, share_instance_id, with_share_data\u003dTrue)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # NOTE (rraja): preserve error state to trigger maintenance mode"},{"line_number":48,"context_line":"        if share_instance[\u0027access_rules_status\u0027] !\u003d constants.STATUS_ERROR:"},{"line_number":49,"context_line":"            self.db.share_instance_update_access_status("},{"line_number":50,"context_line":"                context,"},{"line_number":51,"context_line":"                share_instance_id,"},{"line_number":52,"context_line":"                constants.STATUS_UPDATING"},{"line_number":53,"context_line":"            )"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        add_rules \u003d add_rules or []"},{"line_number":56,"context_line":"        delete_rules \u003d delete_rules or []"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_f5c2da51","line":53,"range":{"start_line":43,"start_character":11,"end_line":53,"end_character":13},"updated":"2016-07-21 12:05:47.000000000","message":"Aaaaaaand where is test coverage?","commit_id":"0688cca91c9cf864b89599cdcf12d84bf23030d7"}],"manila/tests/share/test_access.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"27900a53496509a1e6b972f56d140ff59746e4e0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            access_to\u003d\u0027fakeip2\u0027,"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":"        original_rules \u003d [rule1, rule2]"},{"line_number":54,"context_line":"        delete_rules \u003d [rule2]"},{"line_number":55,"context_line":"        rules \u003d [rule for rule in original_rules if rule not in delete_rules]"},{"line_number":56,"context_line":"        if maintenance_mode:"},{"line_number":57,"context_line":"            share_instance \u003d db_utils.create_share_instance("}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_66688c22","line":54,"range":{"start_line":54,"start_character":23,"end_line":54,"end_character":30},"updated":"2016-07-24 23:39:39.000000000","message":".  \n  delete_rules \u003d [rule2] if not maintenance_mode else []","commit_id":"946d779620949826ac571e77d24a2ae861dce95f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6fcb609de9237c95a25c7c5b9979ce548695cbc7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            access_to\u003d\u0027fakeip2\u0027,"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":"        original_rules \u003d [rule1, rule2]"},{"line_number":54,"context_line":"        delete_rules \u003d [rule2]"},{"line_number":55,"context_line":"        rules \u003d [rule for rule in original_rules if rule not in delete_rules]"},{"line_number":56,"context_line":"        if maintenance_mode:"},{"line_number":57,"context_line":"            share_instance \u003d db_utils.create_share_instance("}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_21d14bce","line":54,"range":{"start_line":54,"start_character":23,"end_line":54,"end_character":30},"in_reply_to":"dada55a8_1312afb4","updated":"2016-07-25 12:56:33.000000000","message":":| meant to discard this comment. But i like your fix, anyway.","commit_id":"946d779620949826ac571e77d24a2ae861dce95f"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"b370b5f97eff71dbb6dab35cd823e8efbd61d91d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            access_to\u003d\u0027fakeip2\u0027,"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":"        original_rules \u003d [rule1, rule2]"},{"line_number":54,"context_line":"        delete_rules \u003d [rule2]"},{"line_number":55,"context_line":"        rules \u003d [rule for rule in original_rules if rule not in delete_rules]"},{"line_number":56,"context_line":"        if maintenance_mode:"},{"line_number":57,"context_line":"            share_instance \u003d db_utils.create_share_instance("}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_d3f2d799","line":54,"range":{"start_line":54,"start_character":23,"end_line":54,"end_character":30},"in_reply_to":"dada55a8_66688c22","updated":"2016-07-25 05:28:10.000000000","message":"Done","commit_id":"946d779620949826ac571e77d24a2ae861dce95f"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"74e2bcd0e8a973b9dcc61602986823001f65fae9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            access_to\u003d\u0027fakeip2\u0027,"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":"        original_rules \u003d [rule1, rule2]"},{"line_number":54,"context_line":"        delete_rules \u003d [rule2]"},{"line_number":55,"context_line":"        rules \u003d [rule for rule in original_rules if rule not in delete_rules]"},{"line_number":56,"context_line":"        if maintenance_mode:"},{"line_number":57,"context_line":"            share_instance \u003d db_utils.create_share_instance("}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_1312afb4","line":54,"range":{"start_line":54,"start_character":23,"end_line":54,"end_character":30},"in_reply_to":"dada55a8_d3f2d799","updated":"2016-07-25 05:29:48.000000000","message":"Please see line 82 of patch set #4.","commit_id":"946d779620949826ac571e77d24a2ae861dce95f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"27900a53496509a1e6b972f56d140ff59746e4e0","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        original_rules \u003d [rule1, rule2]"},{"line_number":54,"context_line":"        delete_rules \u003d [rule2]"},{"line_number":55,"context_line":"        rules \u003d [rule for rule in original_rules if rule not in delete_rules]"},{"line_number":56,"context_line":"        if maintenance_mode:"},{"line_number":57,"context_line":"            share_instance \u003d db_utils.create_share_instance("},{"line_number":58,"context_line":"                id\u003d\u0027fakeid\u0027,"},{"line_number":59,"context_line":"                share_id\u003dself.share[\u0027id\u0027],"},{"line_number":60,"context_line":"                access_rules_status\u003dconstants.STATUS_ERROR)"},{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            share_instance \u003d db_utils.create_share_instance("},{"line_number":63,"context_line":"                id\u003d\u0027fakeid\u0027,"},{"line_number":64,"context_line":"                share_id\u003dself.share[\u0027id\u0027],"},{"line_number":65,"context_line":"                access_rules_status\u003dconstants.STATUS_ACTIVE)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        self.mock_object(db, \"share_instance_get\", mock.Mock("},{"line_number":68,"context_line":"            return_value\u003dshare_instance))"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_e67bdcf2","line":65,"range":{"start_line":56,"start_character":8,"end_line":65,"end_character":60},"updated":"2016-07-24 23:39:39.000000000","message":"shorter:\n\n access_rules_status \u003d (constants.STATUS_ACTIVE if not maintenance_mode  \n                       else constants.STATUS_ERROR)\n \n share_instance \u003d db_utils.create_share_instance(\n                id\u003d\u0027fakeid\u0027,\n                share_id\u003dself.share[\u0027id\u0027],\n                access_rules_status\u003daccess_rules_status)","commit_id":"946d779620949826ac571e77d24a2ae861dce95f"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"b370b5f97eff71dbb6dab35cd823e8efbd61d91d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        original_rules \u003d [rule1, rule2]"},{"line_number":54,"context_line":"        delete_rules \u003d [rule2]"},{"line_number":55,"context_line":"        rules \u003d [rule for rule in original_rules if rule not in delete_rules]"},{"line_number":56,"context_line":"        if maintenance_mode:"},{"line_number":57,"context_line":"            share_instance \u003d db_utils.create_share_instance("},{"line_number":58,"context_line":"                id\u003d\u0027fakeid\u0027,"},{"line_number":59,"context_line":"                share_id\u003dself.share[\u0027id\u0027],"},{"line_number":60,"context_line":"                access_rules_status\u003dconstants.STATUS_ERROR)"},{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            share_instance \u003d db_utils.create_share_instance("},{"line_number":63,"context_line":"                id\u003d\u0027fakeid\u0027,"},{"line_number":64,"context_line":"                share_id\u003dself.share[\u0027id\u0027],"},{"line_number":65,"context_line":"                access_rules_status\u003dconstants.STATUS_ACTIVE)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        self.mock_object(db, \"share_instance_get\", mock.Mock("},{"line_number":68,"context_line":"            return_value\u003dshare_instance))"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_b3eda3b9","line":65,"range":{"start_line":56,"start_character":8,"end_line":65,"end_character":60},"in_reply_to":"dada55a8_e67bdcf2","updated":"2016-07-25 05:28:10.000000000","message":"Done","commit_id":"946d779620949826ac571e77d24a2ae861dce95f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"27900a53496509a1e6b972f56d140ff59746e4e0","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.share_access_helper.update_access_rules("},{"line_number":80,"context_line":"            self.context, share_instance[\u0027id\u0027],"},{"line_number":81,"context_line":"            delete_rules\u003ddelete_rules"},{"line_number":82,"context_line":"        )"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if maintenance_mode:"},{"line_number":85,"context_line":"            self.driver.update_access.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_268694db","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":9},"updated":"2016-07-24 23:39:39.000000000","message":"needs to end on previous line..","commit_id":"946d779620949826ac571e77d24a2ae861dce95f"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"b370b5f97eff71dbb6dab35cd823e8efbd61d91d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.share_access_helper.update_access_rules("},{"line_number":80,"context_line":"            self.context, share_instance[\u0027id\u0027],"},{"line_number":81,"context_line":"            delete_rules\u003ddelete_rules"},{"line_number":82,"context_line":"        )"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if maintenance_mode:"},{"line_number":85,"context_line":"            self.driver.update_access.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_132bcfec","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":9},"in_reply_to":"dada55a8_268694db","updated":"2016-07-25 05:28:10.000000000","message":"Done","commit_id":"946d779620949826ac571e77d24a2ae861dce95f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"27900a53496509a1e6b972f56d140ff59746e4e0","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            self.driver.update_access.assert_called_once_with("},{"line_number":90,"context_line":"                self.context, share_instance, rules, add_rules\u003d[],"},{"line_number":91,"context_line":"                delete_rules\u003ddelete_rules, share_server\u003dNone"},{"line_number":92,"context_line":"            )"},{"line_number":93,"context_line":"        self.share_access_helper._remove_access_rules.assert_called_once_with("},{"line_number":94,"context_line":"            self.context, delete_rules, share_instance[\u0027id\u0027])"},{"line_number":95,"context_line":"        self.share_access_helper._check_needs_refresh.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_06eef08a","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":13},"updated":"2016-07-24 23:39:39.000000000","message":"needs to end on previous line..","commit_id":"946d779620949826ac571e77d24a2ae861dce95f"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"b370b5f97eff71dbb6dab35cd823e8efbd61d91d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            self.driver.update_access.assert_called_once_with("},{"line_number":90,"context_line":"                self.context, share_instance, rules, add_rules\u003d[],"},{"line_number":91,"context_line":"                delete_rules\u003ddelete_rules, share_server\u003dNone"},{"line_number":92,"context_line":"            )"},{"line_number":93,"context_line":"        self.share_access_helper._remove_access_rules.assert_called_once_with("},{"line_number":94,"context_line":"            self.context, delete_rules, share_instance[\u0027id\u0027])"},{"line_number":95,"context_line":"        self.share_access_helper._check_needs_refresh.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_f32d5bfe","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":13},"in_reply_to":"dada55a8_06eef08a","updated":"2016-07-25 05:28:10.000000000","message":"Done","commit_id":"946d779620949826ac571e77d24a2ae861dce95f"}]}
