)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98df64a2dfb4335dcc92b5d02eb54abf44241275","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix checks datatype to be an integer before"},{"line_number":10,"context_line":"applying a unary operator."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I96343ffd4f273b01c0376713717cdc89ea9a873a"},{"line_number":13,"context_line":"Closes-Bug: #1587636"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_d60f7edf","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"updated":"2016-07-28 10:23:23.000000000","message":"APIImpact please","commit_id":"d0d04dd996837baf7f13584e9fbaa2d71f51b258"}],"releasenotes/notes/error-share-set-size-ff5d4f4ac2d56755.yaml":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"4a875319034785f9fb22ec7b3c736286e08fa999","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":" - Size of share is set to 1 when state is changed to \u0027manage_error\u0027."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a89bdaa_a2bbc074","line":3,"range":{"start_line":2,"start_character":1,"end_line":3,"end_character":69},"updated":"2016-09-02 20:02:48.000000000","message":"reno should be user oriented and this one does not explain at all why setting share size to 1 on manage_error is being done.\n\nPerhaps something like: \"When state is changed to \u0027manage_error\u0027 avoid api errors by setting share size to 1.\"\n\nBut that\u0027s still not good enough IMO b/c it doesn\u0027t say *when* this API error can occur.  Is it only in running tests?  If so, we should say \"api errors observed in gate tests\" or something like that.  I\u0027m not that clear on when the api error can happen in real life and I can\u0027t tell from reading this review and bug description.","commit_id":"723bdd35934e6ef29270751d0ab16ff10dd32501"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc9c6021ebbd7c64b1880be676e3eb29f4e4bb19","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":" - When state is changed to \u0027manage_error\u0027, setting share size"},{"line_number":4,"context_line":"   to 1 to avoid delete-share api error w.r.t quota."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a89bdaa_e4071d1a","line":4,"range":{"start_line":3,"start_character":3,"end_line":4,"end_character":52},"updated":"2016-09-06 19:01:48.000000000","message":"This is confusing.. I understand the fix and the reasoning, but on the first look, very confusing.. \n\n Any errors that may occur during \u0027managing\u0027 a share into manila will\n result in the share\u0027s size being set to 1, aside from transitioning\n the status to ``manage_error``.","commit_id":"f8379f314a587500df68dc27ef14452729432af0"},{"author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"change_message_id":"fa2d9c52437d15577556bfed5bb768e0a99bc90a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":" - When state is changed to \u0027manage_error\u0027, setting share size"},{"line_number":4,"context_line":"   to 1 to avoid delete-share api error w.r.t quota."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a89bdaa_968028f9","line":4,"range":{"start_line":3,"start_character":3,"end_line":4,"end_character":52},"in_reply_to":"9a89bdaa_076dcc30","updated":"2016-09-07 09:16:16.000000000","message":"Goutham,\n\nI have put similar reno earlier. \nBut later changed it as per reviewer\u0027s suggestion.\n\nCan you please see and discuss.\nhttps://review.openstack.org/#/c/348160/6/releasenotes/notes/error-share-set-size-ff5d4f4ac2d56755.yaml","commit_id":"f8379f314a587500df68dc27ef14452729432af0"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"24ca9e8b0329c3c9a4b30d51dc099b2c6252b421","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":" - When state is changed to \u0027manage_error\u0027, setting share size"},{"line_number":4,"context_line":"   to 1 to avoid delete-share api error w.r.t quota."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a89bdaa_076dcc30","line":4,"range":{"start_line":3,"start_character":3,"end_line":4,"end_character":52},"in_reply_to":"9a89bdaa_87801348","updated":"2016-09-07 08:06:05.000000000","message":"Goutham, Nidhi: can the user tell that the size has been set to 1 and that we did not do that in the past?  If so, then I can see a case for mentioning the new behavior.  If not, then how about simply: \"Fix an api error when share-state is set to \u0027manage-error\u0027.\" ?","commit_id":"f8379f314a587500df68dc27ef14452729432af0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c59bf2d11137b688679f29fc2b6f04667d2a3be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":" - When state is changed to \u0027manage_error\u0027, setting share size"},{"line_number":4,"context_line":"   to 1 to avoid delete-share api error w.r.t quota."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a89bdaa_cb64a223","line":4,"range":{"start_line":3,"start_character":3,"end_line":4,"end_character":52},"in_reply_to":"9a89bdaa_968028f9","updated":"2016-09-07 20:21:51.000000000","message":"Tom, nidhi: yes.. Users can see shares that have the status \"manage_error\" and the size field will now be populated with 1 even if the scheduling failed.. The chances of the users seeing this behavior is less than administrators noticing it; since manage itself is an administrator action.. It is useful to call out that the size will be 1 intentionally; we may not need to provide any more detail.. but it *may* be confusing for an administrator who tries to manage a 10 GiG share with some invalid share type and the share size was set to 1... \n\nSince we don\u0027t have different statuses for different errors along the manage path, i suggest saying that this behavior (setting size to 1) will occur when a share transitions to manage_error.","commit_id":"f8379f314a587500df68dc27ef14452729432af0"},{"author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"change_message_id":"5d7dc425d476d305bbe351e8e19e9ca20fb81fb2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":" - When state is changed to \u0027manage_error\u0027, setting share size"},{"line_number":4,"context_line":"   to 1 to avoid delete-share api error w.r.t quota."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a89bdaa_3f6c5a9b","line":4,"range":{"start_line":3,"start_character":3,"end_line":4,"end_character":52},"in_reply_to":"9a89bdaa_cb64a223","updated":"2016-09-08 04:45:00.000000000","message":"so goutham, Tom, \n\nis this reno acceptable?\n\nSize of share is set to 1 when state is changed to \u0027manage_error\u0027.","commit_id":"f8379f314a587500df68dc27ef14452729432af0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"20fb85a1e7058c5b5c63c41498ab9e230afd91d9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":" - When state is changed to \u0027manage_error\u0027, setting share size"},{"line_number":4,"context_line":"   to 1 to avoid delete-share api error w.r.t quota."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a89bdaa_87801348","line":4,"range":{"start_line":3,"start_character":3,"end_line":4,"end_character":52},"in_reply_to":"9a89bdaa_e4071d1a","updated":"2016-09-06 19:04:18.000000000","message":"There could be another way of fixing this problem; i.e, making deletes resilient to manage_errors by ignoring the size and hence not attempting a quota update.. \n\nAn user/deployer need not know the internal working of the code when reading the release notes.","commit_id":"f8379f314a587500df68dc27ef14452729432af0"}]}