)]}'
{"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"51da84c570d0f8f847900786e95dfccc2f6b8ef5","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        vserver_client \u003d self._get_api_client(vserver\u003dvserver)"},{"line_number":321,"context_line":"        network_interfaces \u003d vserver_client.get_network_interfaces()"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        vlan \u003d 0"},{"line_number":324,"context_line":"        if network_interfaces:"},{"line_number":325,"context_line":"            home_port \u003d network_interfaces[0][\u0027home-port\u0027]"},{"line_number":326,"context_line":"            vlan \u003d home_port.split(\u0027-\u0027)[1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_ea221ca2","line":323,"range":{"start_line":323,"start_character":15,"end_line":323,"end_character":16},"updated":"2016-07-31 21:03:11.000000000","message":"None is more explicit.","commit_id":"c13d437f472074addf1928ed2a09dd79a4ba2c5e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b102f40e6402fcb7ad32770ba106858eff084727","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        vserver_client \u003d self._get_api_client(vserver\u003dvserver)"},{"line_number":321,"context_line":"        network_interfaces \u003d vserver_client.get_network_interfaces()"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        vlan \u003d 0"},{"line_number":324,"context_line":"        if network_interfaces:"},{"line_number":325,"context_line":"            home_port \u003d network_interfaces[0][\u0027home-port\u0027]"},{"line_number":326,"context_line":"            vlan \u003d home_port.split(\u0027-\u0027)[1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_6d61f8a8","line":323,"range":{"start_line":323,"start_character":15,"end_line":323,"end_character":16},"in_reply_to":"bacf61ea_a77af221","updated":"2016-08-01 19:22:43.000000000","message":"Thanks.. made the change.","commit_id":"c13d437f472074addf1928ed2a09dd79a4ba2c5e"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"0e2957c1e81d24ebe05c2b2325e2474b06ff46a1","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        vserver_client \u003d self._get_api_client(vserver\u003dvserver)"},{"line_number":321,"context_line":"        network_interfaces \u003d vserver_client.get_network_interfaces()"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        vlan \u003d 0"},{"line_number":324,"context_line":"        if network_interfaces:"},{"line_number":325,"context_line":"            home_port \u003d network_interfaces[0][\u0027home-port\u0027]"},{"line_number":326,"context_line":"            vlan \u003d home_port.split(\u0027-\u0027)[1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_a77af221","line":323,"range":{"start_line":323,"start_character":15,"end_line":323,"end_character":16},"in_reply_to":"bacf61ea_ea221ca2","updated":"2016-08-01 17:28:18.000000000","message":"True, but VLAN tags are generally integers, which is why I used zero.  It really doesn\u0027t matter to me.","commit_id":"c13d437f472074addf1928ed2a09dd79a4ba2c5e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"274f088144c2b8f7f11d1249e10d97a0f3a0d044","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        network_interfaces \u003d vserver_client.get_network_interfaces()"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        vlan \u003d None"},{"line_number":324,"context_line":"        if network_interfaces:"},{"line_number":325,"context_line":"            home_port \u003d network_interfaces[0][\u0027home-port\u0027]"},{"line_number":326,"context_line":"            vlan \u003d home_port.split(\u0027-\u0027)[1]"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_980d93ea","line":324,"range":{"start_line":324,"start_character":8,"end_line":324,"end_character":30},"updated":"2016-08-05 19:50:53.000000000","message":"if this can be None, it will fail in _delete_vserver_with_lock","commit_id":"deae18758f091933445cc149ffa6b8edd76f9fc0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"62632a6590abf7d374a832ce11ca933335281595","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        network_interfaces \u003d vserver_client.get_network_interfaces()"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        vlan \u003d None"},{"line_number":324,"context_line":"        if network_interfaces:"},{"line_number":325,"context_line":"            home_port \u003d network_interfaces[0][\u0027home-port\u0027]"},{"line_number":326,"context_line":"            vlan \u003d home_port.split(\u0027-\u0027)[1]"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_86241460","line":324,"range":{"start_line":324,"start_character":8,"end_line":324,"end_character":30},"in_reply_to":"bacf61ea_980d93ea","updated":"2016-08-05 20:32:34.000000000","message":"it is [] if no network_interfaces exist..","commit_id":"deae18758f091933445cc149ffa6b8edd76f9fc0"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"274f088144c2b8f7f11d1249e10d97a0f3a0d044","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            home_port \u003d network_interfaces[0][\u0027home-port\u0027]"},{"line_number":326,"context_line":"            vlan \u003d home_port.split(\u0027-\u0027)[1]"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        @utils.synchronized(\u0027netapp-VLAN-%s\u0027 % vlan, external\u003dTrue)"},{"line_number":329,"context_line":"        def _delete_vserver_with_lock():"},{"line_number":330,"context_line":"            self._client.delete_vserver(vserver,"},{"line_number":331,"context_line":"                                        vserver_client,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_b8f697d4","line":328,"range":{"start_line":328,"start_character":41,"end_line":328,"end_character":43},"updated":"2016-08-05 19:50:53.000000000","message":"I guess it\u0027s OK to use None here (?), but not the best thing to lock on.","commit_id":"deae18758f091933445cc149ffa6b8edd76f9fc0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"62632a6590abf7d374a832ce11ca933335281595","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            home_port \u003d network_interfaces[0][\u0027home-port\u0027]"},{"line_number":326,"context_line":"            vlan \u003d home_port.split(\u0027-\u0027)[1]"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        @utils.synchronized(\u0027netapp-VLAN-%s\u0027 % vlan, external\u003dTrue)"},{"line_number":329,"context_line":"        def _delete_vserver_with_lock():"},{"line_number":330,"context_line":"            self._client.delete_vserver(vserver,"},{"line_number":331,"context_line":"                                        vserver_client,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_9bf10d04","line":328,"range":{"start_line":328,"start_character":41,"end_line":328,"end_character":43},"in_reply_to":"bacf61ea_b8f697d4","updated":"2016-08-05 20:32:34.000000000","message":"Yep -we\u0027ll lock with netapp-VLAN-None, but we don\u0027t have the VLAN ID anyway, it\u0027s no different than locking with netapp-VLAN-0..","commit_id":"deae18758f091933445cc149ffa6b8edd76f9fc0"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"274f088144c2b8f7f11d1249e10d97a0f3a0d044","unresolved":false,"context_lines":[{"line_number":343,"context_line":"    def _delete_vserver_vlan(self, vserver_network_interfaces):"},{"line_number":344,"context_line":"        \"\"\"Delete Vserver\u0027s VLAN configuration from ports\"\"\""},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        for interface in vserver_network_interfaces:"},{"line_number":347,"context_line":"            try:"},{"line_number":348,"context_line":"                home_port \u003d interface[\u0027home-port\u0027]"},{"line_number":349,"context_line":"                port, vlan \u003d home_port.split(\u0027-\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_1819a322","line":346,"range":{"start_line":346,"start_character":25,"end_line":346,"end_character":51},"updated":"2016-08-05 19:50:53.000000000","message":"so hopefully this would be an empty iterable and not None.","commit_id":"deae18758f091933445cc149ffa6b8edd76f9fc0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"62632a6590abf7d374a832ce11ca933335281595","unresolved":false,"context_lines":[{"line_number":343,"context_line":"    def _delete_vserver_vlan(self, vserver_network_interfaces):"},{"line_number":344,"context_line":"        \"\"\"Delete Vserver\u0027s VLAN configuration from ports\"\"\""},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        for interface in vserver_network_interfaces:"},{"line_number":347,"context_line":"            try:"},{"line_number":348,"context_line":"                home_port \u003d interface[\u0027home-port\u0027]"},{"line_number":349,"context_line":"                port, vlan \u003d home_port.split(\u0027-\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_bbc17182","line":346,"range":{"start_line":346,"start_character":25,"end_line":346,"end_character":51},"in_reply_to":"bacf61ea_1819a322","updated":"2016-08-05 20:32:34.000000000","message":"yep.. iterable: https://github.com/openstack/manila/blob/60a32f1/manila/share/drivers/netapp/dataontap/client/client_cmode.py#L775","commit_id":"deae18758f091933445cc149ffa6b8edd76f9fc0"}]}