)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"e8a9cdf5c5d9dd22a655622cb61711841e2d1279","unresolved":false,"context_lines":[{"line_number":11,"context_line":"support MTU sizes with jumbo frames."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch exposes this information to the drivers. Each driver"},{"line_number":14,"context_line":"should setup it\u0027s resources accordingly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"APIImpact"},{"line_number":17,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_79193879","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":17},"updated":"2016-08-09 17:31:18.000000000","message":"Nit:  s/it\u0027s/its/","commit_id":"e65d15c42fa700dbf0ac8d8e16438b03c16c834b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ab657955c8d83d0d1430df054fe2e601c36963b4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"support MTU sizes with jumbo frames."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch exposes this information to the drivers. Each driver"},{"line_number":14,"context_line":"should setup it\u0027s resources accordingly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"APIImpact"},{"line_number":17,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_cd29868b","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":17},"updated":"2016-08-10 02:23:07.000000000","message":"nit: s/it\u0027s/its/","commit_id":"e65d15c42fa700dbf0ac8d8e16438b03c16c834b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"483b7b1bc039604eff9688c61cea2619473d8338","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"MTU value can be different for each neutron network."},{"line_number":10,"context_line":"E.g. for high-performance use-cases it\u0027s very important to also"},{"line_number":11,"context_line":"support MTU sizes with jumbo frames."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch exposes this information to the drivers. Each driver"},{"line_number":14,"context_line":"should setup its resources accordingly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9ad45d7e_5c017805","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":17},"updated":"2016-08-11 03:15:50.000000000","message":"redundant..","commit_id":"83d98dcec106620de79780f10325afdda48024e5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f0a5a47f3c113d3a11e648de3e82b7086134192","unresolved":false,"context_lines":[{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I9b4efae620ec9f6790547c8fffc58872d43277f5"},{"line_number":20,"context_line":"Closes-bug: #1606190"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9ad45d7e_e339c0d8","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":20},"updated":"2016-08-10 15:40:54.000000000","message":"This isn\u0027t a bug fix.. it\u0027s a feature.. applying network provider MTU to share networks and network allocations is the feature..","commit_id":"83d98dcec106620de79780f10325afdda48024e5"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"0aaec4a36d1b79e8ff83a5961886a1605f8cb229","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    * 2.18 - Add gateway to the JSON response of share network show API."},{"line_number":72,"context_line":"    * 2.19 - Share snapshot instances admin APIs"},{"line_number":73,"context_line":"            (list/show/detail/reset-status)."},{"line_number":74,"context_line":"    * 2.20 - Add mtu to the JSON response of share network show API."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"\"\"\""},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_cd38bd40","line":74,"range":{"start_line":74,"start_character":17,"end_line":74,"end_character":20},"updated":"2016-08-12 09:47:12.000000000","message":"MTU","commit_id":"e2117f89c9648c035a69b95de6747b53cdab2afa"}],"manila/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"0aaec4a36d1b79e8ff83a5961886a1605f8cb229","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"2.20"},{"line_number":127,"context_line":"----"},{"line_number":128,"context_line":"  Add mtu in share network show API."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9ad45d7e_8d15259d","line":128,"range":{"start_line":128,"start_character":6,"end_line":128,"end_character":9},"updated":"2016-08-12 09:47:12.000000000","message":"MTU","commit_id":"e2117f89c9648c035a69b95de6747b53cdab2afa"}],"manila/db/migrations/alembic/versions/493eaffd79e1_add_mtu_network_allocations.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"0aaec4a36d1b79e8ff83a5961886a1605f8cb229","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\"\"\"add_mtu_network_allocations"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: 493eaffd79e1"},{"line_number":16,"context_line":"Revises: e8ea58723178"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_0dd775c0","line":13,"range":{"start_line":13,"start_character":3,"end_line":13,"end_character":30},"updated":"2016-08-12 09:47:12.000000000","message":"add_mtu_to_network_allocations.\nAnd the mtu column is also added to share_networks.\nMaybe change a better name.","commit_id":"e2117f89c9648c035a69b95de6747b53cdab2afa"}],"manila/db/migrations/alembic/versions/493eaffd79e1_add_mtu_network_allocations_share_networks.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9a4edf441955ab89ac242d1d9f998f2c6a54b1d4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\"\"\"add_mtu_network_allocations"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: 493eaffd79e1"},{"line_number":16,"context_line":"Revises: e8ea58723178"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_ee02c571","line":13,"updated":"2016-08-12 15:01:12.000000000","message":"nit: You changed the file name to include \"share_networks\" but not the docstring here.","commit_id":"e3afcd751ff8e681867e1c7a054684277ec2874b"}],"manila/network/neutron/neutron_network_plugin.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ab2ed5658f4638aa578a9d26ef49691c3421e989","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            \u0027segmentation_id\u0027: share_network[\u0027segmentation_id\u0027],"},{"line_number":132,"context_line":"            \u0027ip_version\u0027: share_network[\u0027ip_version\u0027],"},{"line_number":133,"context_line":"            \u0027cidr\u0027: share_network[\u0027cidr\u0027],"},{"line_number":134,"context_line":"            \u0027mtu\u0027: share_network[\u0027mtu\u0027]"},{"line_number":135,"context_line":"        }"},{"line_number":136,"context_line":"        return self.db.network_allocation_create(context, port_dict)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_8871f30e","line":134,"range":{"start_line":134,"start_character":38,"end_line":134,"end_character":39},"updated":"2016-08-05 03:16:10.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"2df7f96ab82a2dd73a383c76cd08461f4d682bc0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ab2ed5658f4638aa578a9d26ef49691c3421e989","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        provider_nw_dict \u003d {"},{"line_number":157,"context_line":"            \u0027network_type\u0027: net_info[\u0027provider:network_type\u0027],"},{"line_number":158,"context_line":"            \u0027segmentation_id\u0027: net_info[\u0027provider:segmentation_id\u0027],"},{"line_number":159,"context_line":"            \u0027mtu\u0027:  net_info[\u0027mtu\u0027]"},{"line_number":160,"context_line":"        }"},{"line_number":161,"context_line":"        share_network.update(provider_nw_dict)"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_e8606f37","line":159,"range":{"start_line":159,"start_character":34,"end_line":159,"end_character":35},"updated":"2016-08-05 03:16:10.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"2df7f96ab82a2dd73a383c76cd08461f4d682bc0"}],"manila/network/standalone_network_plugin.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"e8a9cdf5c5d9dd22a655622cb61711841e2d1279","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    cfg.IntOpt("},{"line_number":69,"context_line":"        \u0027standalone_network_plugin_mtu_size\u0027,"},{"line_number":70,"context_line":"        default\u003d1500,"},{"line_number":71,"context_line":"        help\u003d\"MTU value of the network. Default value is 1500.\","},{"line_number":72,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":73,"context_line":"]"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_f971a8a9","line":71,"range":{"start_line":71,"start_character":14,"end_line":71,"end_character":17},"updated":"2016-08-09 17:31:18.000000000","message":"I think it would be helpful to spell this out here:\n\nMaximum Transmission Unit (MTU) value of the network...","commit_id":"e65d15c42fa700dbf0ac8d8e16438b03c16c834b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"483b7b1bc039604eff9688c61cea2619473d8338","unresolved":false,"context_lines":[{"line_number":66,"context_line":"             \"Allowed values are \u00274\u0027 and \u00276\u0027. Default value is \u00274\u0027.\","},{"line_number":67,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt("},{"line_number":69,"context_line":"        \u0027standalone_network_plugin_mtu_size\u0027,"},{"line_number":70,"context_line":"        default\u003d1500,"},{"line_number":71,"context_line":"        help\u003d\"Maximum Transmission Unit (MTU) value of the network. Default \""},{"line_number":72,"context_line":"             \"value is 1500.\","}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_3f43d643","line":69,"range":{"start_line":69,"start_character":38,"end_line":69,"end_character":43},"updated":"2016-08-11 03:15:50.000000000","message":"\"size\" is redundant.. \n\nthe neutron opt is \"global_physnet_mtu\" or \"path_mtu\" in ml2.. so, standalone_network_plugin_mtu is sufficient..","commit_id":"83d98dcec106620de79780f10325afdda48024e5"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"71f0d77c6c7726c0e8f34b858691928f5c7d4ebe","unresolved":false,"context_lines":[{"line_number":66,"context_line":"             \"Allowed values are \u00274\u0027 and \u00276\u0027. Default value is \u00274\u0027.\","},{"line_number":67,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":68,"context_line":"    cfg.IntOpt("},{"line_number":69,"context_line":"        \u0027standalone_network_plugin_mtu_size\u0027,"},{"line_number":70,"context_line":"        default\u003d1500,"},{"line_number":71,"context_line":"        help\u003d\"Maximum Transmission Unit (MTU) value of the network. Default \""},{"line_number":72,"context_line":"             \"value is 1500.\","}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_28a54746","line":69,"range":{"start_line":69,"start_character":38,"end_line":69,"end_character":43},"in_reply_to":"9ad45d7e_3f43d643","updated":"2016-08-11 14:30:07.000000000","message":"Done","commit_id":"83d98dcec106620de79780f10325afdda48024e5"}],"manila/tests/api/views/test_share_networks.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f0a5a47f3c113d3a11e648de3e82b7086134192","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.assertEqual(sn[\u0027id\u0027], result[\u0027share_network\u0027][\u0027id\u0027])"},{"line_number":137,"context_line":"        self.assertEqual(sn[\u0027name\u0027], result[\u0027share_network\u0027][\u0027name\u0027])"},{"line_number":138,"context_line":"        self.assertEqual(len(expected_keys), len(result[\u0027share_network\u0027]))"},{"line_number":139,"context_line":"        for key in expected_keys:"},{"line_number":140,"context_line":"            self.assertIn(key, result[\u0027share_network\u0027])"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @ddt.data("},{"line_number":143,"context_line":"        [],"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_98014f6d","line":140,"range":{"start_line":139,"start_character":0,"end_line":140,"end_character":55},"updated":"2016-08-10 15:40:54.000000000","message":"You should perform a strict key check here..","commit_id":"83d98dcec106620de79780f10325afdda48024e5"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"71f0d77c6c7726c0e8f34b858691928f5c7d4ebe","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.assertEqual(sn[\u0027id\u0027], result[\u0027share_network\u0027][\u0027id\u0027])"},{"line_number":137,"context_line":"        self.assertEqual(sn[\u0027name\u0027], result[\u0027share_network\u0027][\u0027name\u0027])"},{"line_number":138,"context_line":"        self.assertEqual(len(expected_keys), len(result[\u0027share_network\u0027]))"},{"line_number":139,"context_line":"        for key in expected_keys:"},{"line_number":140,"context_line":"            self.assertIn(key, result[\u0027share_network\u0027])"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @ddt.data("},{"line_number":143,"context_line":"        [],"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_686c5a9c","line":140,"range":{"start_line":139,"start_character":0,"end_line":140,"end_character":55},"in_reply_to":"9ad45d7e_98014f6d","updated":"2016-08-11 14:30:07.000000000","message":"Done","commit_id":"83d98dcec106620de79780f10325afdda48024e5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"483b7b1bc039604eff9688c61cea2619473d8338","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @ddt.data("},{"line_number":143,"context_line":"        [],"},{"line_number":144,"context_line":"        [dict(id\u003d\u0027fake_id\u0027,"},{"line_number":145,"context_line":"              name\u003d\u0027fake_name\u0027,"},{"line_number":146,"context_line":"              project_id\u003d\u0027fake_project_id\u0027,"},{"line_number":147,"context_line":"              created_at\u003d\u0027fake_created_at\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_e88ea177","line":144,"range":{"start_line":144,"start_character":9,"end_line":144,"end_character":14},"updated":"2016-08-11 03:15:50.000000000","message":"{}","commit_id":"83d98dcec106620de79780f10325afdda48024e5"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"71f0d77c6c7726c0e8f34b858691928f5c7d4ebe","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @ddt.data("},{"line_number":143,"context_line":"        [],"},{"line_number":144,"context_line":"        [dict(id\u003d\u0027fake_id\u0027,"},{"line_number":145,"context_line":"              name\u003d\u0027fake_name\u0027,"},{"line_number":146,"context_line":"              project_id\u003d\u0027fake_project_id\u0027,"},{"line_number":147,"context_line":"              created_at\u003d\u0027fake_created_at\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_2876e26f","line":144,"range":{"start_line":144,"start_character":9,"end_line":144,"end_character":14},"in_reply_to":"9ad45d7e_e88ea177","updated":"2016-08-11 14:30:07.000000000","message":"Done","commit_id":"83d98dcec106620de79780f10325afdda48024e5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"483b7b1bc039604eff9688c61cea2619473d8338","unresolved":false,"context_lines":[{"line_number":156,"context_line":"              gateway\u003d\u0027fake_gateway\u0027,"},{"line_number":157,"context_line":"              description\u003d\u0027fake_description\u0027,"},{"line_number":158,"context_line":"              mtu\u003d1509),"},{"line_number":159,"context_line":"         dict(id\u003d\u0027fake_id2\u0027, name\u003d\u0027fake_name2\u0027)],"},{"line_number":160,"context_line":"    )"},{"line_number":161,"context_line":"    def test_build_share_networks_with_details_v_2_20(self, share_networks):"},{"line_number":162,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/share-networks\u0027, version\u003d\"2.20\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_08f055fd","line":159,"range":{"start_line":159,"start_character":9,"end_line":159,"end_character":14},"updated":"2016-08-11 03:15:50.000000000","message":"{}","commit_id":"83d98dcec106620de79780f10325afdda48024e5"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"71f0d77c6c7726c0e8f34b858691928f5c7d4ebe","unresolved":false,"context_lines":[{"line_number":156,"context_line":"              gateway\u003d\u0027fake_gateway\u0027,"},{"line_number":157,"context_line":"              description\u003d\u0027fake_description\u0027,"},{"line_number":158,"context_line":"              mtu\u003d1509),"},{"line_number":159,"context_line":"         dict(id\u003d\u0027fake_id2\u0027, name\u003d\u0027fake_name2\u0027)],"},{"line_number":160,"context_line":"    )"},{"line_number":161,"context_line":"    def test_build_share_networks_with_details_v_2_20(self, share_networks):"},{"line_number":162,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/share-networks\u0027, version\u003d\"2.20\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_c85aa6f1","line":159,"range":{"start_line":159,"start_character":9,"end_line":159,"end_character":14},"in_reply_to":"9ad45d7e_08f055fd","updated":"2016-08-11 14:30:07.000000000","message":"Done","commit_id":"83d98dcec106620de79780f10325afdda48024e5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"483b7b1bc039604eff9688c61cea2619473d8338","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/share-networks\u0027, version\u003d\"2.20\")"},{"line_number":198,"context_line":"        expected \u003d []"},{"line_number":199,"context_line":"        for share_network in share_networks:"},{"line_number":200,"context_line":"            expected.append(dict("},{"line_number":201,"context_line":"                id\u003dshare_network.get(\u0027id\u0027), name\u003dshare_network.get(\u0027name\u0027)))"},{"line_number":202,"context_line":"        expected \u003d {\u0027share_networks\u0027: expected}"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_48f6cdf9","line":200,"range":{"start_line":200,"start_character":28,"end_line":200,"end_character":33},"updated":"2016-08-11 03:15:50.000000000","message":"{}","commit_id":"83d98dcec106620de79780f10325afdda48024e5"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"71f0d77c6c7726c0e8f34b858691928f5c7d4ebe","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/share-networks\u0027, version\u003d\"2.20\")"},{"line_number":198,"context_line":"        expected \u003d []"},{"line_number":199,"context_line":"        for share_network in share_networks:"},{"line_number":200,"context_line":"            expected.append(dict("},{"line_number":201,"context_line":"                id\u003dshare_network.get(\u0027id\u0027), name\u003dshare_network.get(\u0027name\u0027)))"},{"line_number":202,"context_line":"        expected \u003d {\u0027share_networks\u0027: expected}"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_88642eb9","line":200,"range":{"start_line":200,"start_character":28,"end_line":200,"end_character":33},"in_reply_to":"9ad45d7e_48f6cdf9","updated":"2016-08-11 14:30:07.000000000","message":"Done","commit_id":"83d98dcec106620de79780f10325afdda48024e5"}],"manila/tests/db/migrations/alembic/migrations_data_checks.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ab2ed5658f4638aa578a9d26ef49691c3421e989","unresolved":false,"context_lines":[{"line_number":858,"context_line":"                \u0027segmentation_id\u0027: 1005,"},{"line_number":859,"context_line":"                \u0027ip_version\u0027: 4,"},{"line_number":860,"context_line":"                \u0027cidr\u0027: \u0027240.0.0.0/16\u0027,"},{"line_number":861,"context_line":"                \u0027mtu\u0027: 1509"},{"line_number":862,"context_line":"            },"},{"line_number":863,"context_line":"        ]"},{"line_number":864,"context_line":"        engine.execute(na_table.insert(network_allocations))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_a8f95750","line":861,"range":{"start_line":861,"start_character":16,"end_line":861,"end_character":27},"updated":"2016-08-05 03:16:10.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"2df7f96ab82a2dd73a383c76cd08461f4d682bc0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ab2ed5658f4638aa578a9d26ef49691c3421e989","unresolved":false,"context_lines":[{"line_number":882,"context_line":"                \u0027project_id\u0027: sn.project_id,"},{"line_number":883,"context_line":"                \u0027gateway\u0027: \u00271.1.1.1\u0027,"},{"line_number":884,"context_line":"                \u0027name\u0027: \u0027name_foo_2\u0027,"},{"line_number":885,"context_line":"                \u0027mtu\u0027: 1509"},{"line_number":886,"context_line":"            },"},{"line_number":887,"context_line":"        ]"},{"line_number":888,"context_line":"        engine.execute(sn_table.insert(share_networks))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_6803df42","line":885,"range":{"start_line":885,"start_character":16,"end_line":885,"end_character":27},"updated":"2016-08-05 03:16:10.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"2df7f96ab82a2dd73a383c76cd08461f4d682bc0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f0a5a47f3c113d3a11e648de3e82b7086134192","unresolved":false,"context_lines":[{"line_number":864,"context_line":"        engine.execute(na_table.insert(network_allocations))"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"        # Select network allocations with mtu info"},{"line_number":867,"context_line":"        for na in engine.execute("},{"line_number":868,"context_line":"                na_table.select().where(na_table.c.mtu \u003d\u003d \u00271509\u0027)):"},{"line_number":869,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027mtu\u0027))"},{"line_number":870,"context_line":"            self.test_case.assertEqual(network_allocations[0][\u0027mtu\u0027],"},{"line_number":871,"context_line":"                                       getattr(na, \u0027mtu\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_d8af4728","line":868,"range":{"start_line":867,"start_character":0,"end_line":868,"end_character":67},"updated":"2016-08-10 15:40:54.000000000","message":"This is fine.. but what about the upgrade case for existing network allocations.. \n\n   for na in engine.execute(na_table.select()):\n           self.test_case.assertTrue(hasattr(na, \u0027mtu\u0027))\n           if na[\u0027id\u0027] \u003d\u003d self.na_ids[2]:\n                self.test_case.assertEqual(network_allocations[0][\u0027mtu\u0027],\n                                       getattr(na, \u0027mtu\u0027))\n          else:\n               self.test_case.assertIsNone(network_allocations[0][\u0027mtu\u0027])","commit_id":"83d98dcec106620de79780f10325afdda48024e5"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"71f0d77c6c7726c0e8f34b858691928f5c7d4ebe","unresolved":false,"context_lines":[{"line_number":864,"context_line":"        engine.execute(na_table.insert(network_allocations))"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"        # Select network allocations with mtu info"},{"line_number":867,"context_line":"        for na in engine.execute("},{"line_number":868,"context_line":"                na_table.select().where(na_table.c.mtu \u003d\u003d \u00271509\u0027)):"},{"line_number":869,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027mtu\u0027))"},{"line_number":870,"context_line":"            self.test_case.assertEqual(network_allocations[0][\u0027mtu\u0027],"},{"line_number":871,"context_line":"                                       getattr(na, \u0027mtu\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_5ef14ccc","line":868,"range":{"start_line":867,"start_character":0,"end_line":868,"end_character":67},"in_reply_to":"9ad45d7e_d8af4728","updated":"2016-08-11 14:30:07.000000000","message":"Done","commit_id":"83d98dcec106620de79780f10325afdda48024e5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f0a5a47f3c113d3a11e648de3e82b7086134192","unresolved":false,"context_lines":[{"line_number":888,"context_line":"        engine.execute(sn_table.insert(share_networks))"},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"        # Select share network"},{"line_number":891,"context_line":"        for sn in engine.execute("},{"line_number":892,"context_line":"                sn_table.select().where(sn_table.c.name \u003d\u003d \u0027name_foo_2\u0027)):"},{"line_number":893,"context_line":"            self.test_case.assertTrue(hasattr(sn, \u0027mtu\u0027))"},{"line_number":894,"context_line":"            self.test_case.assertEqual(share_networks[0][\u0027mtu\u0027],"},{"line_number":895,"context_line":"                                       getattr(sn, \u0027mtu\u0027))"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"    def check_downgrade(self, engine):"},{"line_number":898,"context_line":"        for table_name, ids in ((self.na_table_name, self.na_ids),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_d87627d6","line":895,"range":{"start_line":891,"start_character":0,"end_line":895,"end_character":58},"updated":"2016-08-10 15:40:54.000000000","message":"same","commit_id":"83d98dcec106620de79780f10325afdda48024e5"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"71f0d77c6c7726c0e8f34b858691928f5c7d4ebe","unresolved":false,"context_lines":[{"line_number":888,"context_line":"        engine.execute(sn_table.insert(share_networks))"},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"        # Select share network"},{"line_number":891,"context_line":"        for sn in engine.execute("},{"line_number":892,"context_line":"                sn_table.select().where(sn_table.c.name \u003d\u003d \u0027name_foo_2\u0027)):"},{"line_number":893,"context_line":"            self.test_case.assertTrue(hasattr(sn, \u0027mtu\u0027))"},{"line_number":894,"context_line":"            self.test_case.assertEqual(share_networks[0][\u0027mtu\u0027],"},{"line_number":895,"context_line":"                                       getattr(sn, \u0027mtu\u0027))"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"    def check_downgrade(self, engine):"},{"line_number":898,"context_line":"        for table_name, ids in ((self.na_table_name, self.na_ids),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_9ebd84da","line":895,"range":{"start_line":891,"start_character":0,"end_line":895,"end_character":58},"in_reply_to":"9ad45d7e_d87627d6","updated":"2016-08-11 14:30:07.000000000","message":"Done","commit_id":"83d98dcec106620de79780f10325afdda48024e5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a4361f25505d548b5287589a00d72c8865727558","unresolved":false,"context_lines":[{"line_number":869,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027mtu\u0027))"},{"line_number":870,"context_line":"            self.test_case.assertEqual(network_allocations[0][\u0027mtu\u0027],"},{"line_number":871,"context_line":"                                       getattr(na, \u0027mtu\u0027))"},{"line_number":872,"context_line":"        for na in engine.execute(na_table.select()):"},{"line_number":873,"context_line":"            self.test_case.assertTrue(hasattr(na, \u0027mtu\u0027))"},{"line_number":874,"context_line":"            if na[\u0027id\u0027] \u003d\u003d self.na_ids[2]:"},{"line_number":875,"context_line":"                self.test_case.assertEqual(network_allocations[0][\u0027mtu\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_50f48b59","line":872,"updated":"2016-08-11 16:59:06.000000000","message":"nit: add space and appropriate comment","commit_id":"1ee8a2231aa7dea6896a4611e8e6bec4f72cb460"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a4361f25505d548b5287589a00d72c8865727558","unresolved":false,"context_lines":[{"line_number":900,"context_line":"            self.test_case.assertTrue(hasattr(sn, \u0027mtu\u0027))"},{"line_number":901,"context_line":"            self.test_case.assertEqual(share_networks[0][\u0027mtu\u0027],"},{"line_number":902,"context_line":"                                       getattr(sn, \u0027mtu\u0027))"},{"line_number":903,"context_line":"        for sn in engine.execute(sn_table.select()):"},{"line_number":904,"context_line":"            self.test_case.assertTrue(hasattr(sn, \u0027mtu\u0027))"},{"line_number":905,"context_line":"            if sn[\u0027id\u0027] \u003d\u003d self.sn_ids[1]:"},{"line_number":906,"context_line":"                self.test_case.assertEqual(network_allocations[0][\u0027mtu\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_30fc773d","line":903,"updated":"2016-08-11 16:59:06.000000000","message":"ditto","commit_id":"1ee8a2231aa7dea6896a4611e8e6bec4f72cb460"}],"manila/tests/network/neutron/test_neutron_plugin.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ab2ed5658f4638aa578a9d26ef49691c3421e989","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    \u0027ip_version\u0027: 4,"},{"line_number":63,"context_line":"    \u0027cidr\u0027: \u0027fake_cidr\u0027,"},{"line_number":64,"context_line":"    \u0027gateway\u0027: \u0027fake_gateway\u0027,"},{"line_number":65,"context_line":"    \u0027mtu\u0027: 1509"},{"line_number":66,"context_line":"}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"fake_share_server \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_c89acb13","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":15},"updated":"2016-08-05 03:16:10.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"2df7f96ab82a2dd73a383c76cd08461f4d682bc0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ab2ed5658f4638aa578a9d26ef49691c3421e989","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    \u0027ip_version\u0027: fake_share_network[\u0027ip_version\u0027],"},{"line_number":86,"context_line":"    \u0027cidr\u0027: fake_share_network[\u0027cidr\u0027],"},{"line_number":87,"context_line":"    \u0027gateway\u0027: fake_share_network[\u0027gateway\u0027],"},{"line_number":88,"context_line":"    \u0027mtu\u0027: 1509"},{"line_number":89,"context_line":"}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_289c470d","line":88,"range":{"start_line":88,"start_character":3,"end_line":88,"end_character":15},"updated":"2016-08-05 03:16:10.000000000","message":"above","commit_id":"2df7f96ab82a2dd73a383c76cd08461f4d682bc0"}],"manila_tempest_tests/tests/api/test_share_networks.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"e8a9cdf5c5d9dd22a655622cb61711841e2d1279","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        if utils.is_microversion_supported(\u00272.18\u0027):"},{"line_number":54,"context_line":"            keys.append(\u0027gateway\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # In v2.20 and beyond, we expect gateway."},{"line_number":57,"context_line":"        if utils.is_microversion_supported(\u00272.20\u0027):"},{"line_number":58,"context_line":"            keys.append(\u0027mtu\u0027)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_1e13c267","line":56,"range":{"start_line":56,"start_character":41,"end_line":56,"end_character":48},"updated":"2016-08-09 17:31:18.000000000","message":"s/gateway/mtu/","commit_id":"e65d15c42fa700dbf0ac8d8e16438b03c16c834b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ab657955c8d83d0d1430df054fe2e601c36963b4","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        if utils.is_microversion_supported(\u00272.18\u0027):"},{"line_number":54,"context_line":"            keys.append(\u0027gateway\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # In v2.20 and beyond, we expect gateway."},{"line_number":57,"context_line":"        if utils.is_microversion_supported(\u00272.20\u0027):"},{"line_number":58,"context_line":"            keys.append(\u0027mtu\u0027)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_d9cad26d","line":56,"range":{"start_line":56,"start_character":41,"end_line":56,"end_character":48},"in_reply_to":"9ad45d7e_1e13c267","updated":"2016-08-10 02:23:07.000000000","message":"+1","commit_id":"e65d15c42fa700dbf0ac8d8e16438b03c16c834b"}],"releasenotes/notes/add_mtu_info_db-3c1d6dc02f40d5a6.yaml":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"e8a9cdf5c5d9dd22a655622cb61711841e2d1279","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Store network mtu value into DB to make it possible for drivers to support"},{"line_number":4,"context_line":"    different values than 1500."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_190abc21","line":3,"range":{"start_line":3,"start_character":60,"end_line":3,"end_character":67},"updated":"2016-08-09 17:31:18.000000000","message":"You might make it clear that only share-server drivers are affected.","commit_id":"e65d15c42fa700dbf0ac8d8e16438b03c16c834b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1bacac27be3b2e4b978bc3bdaa1d8ea030b00c7d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Store network mtu value into DB to make it possible for drivers to support"},{"line_number":4,"context_line":"    different values than 1500."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_beb1c4e3","line":3,"range":{"start_line":3,"start_character":60,"end_line":3,"end_character":67},"in_reply_to":"9ad45d7e_190abc21","updated":"2016-08-10 01:38:56.000000000","message":"+1","commit_id":"e65d15c42fa700dbf0ac8d8e16438b03c16c834b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f0a5a47f3c113d3a11e648de3e82b7086134192","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Store network mtu value into DB to make it possible for drivers with share"},{"line_number":4,"context_line":"    server support to support different values than 1500."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ad45d7e_182b9f95","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2016-08-10 15:40:54.000000000","message":"Don\u0027t see how this is a bug fix.. It should be a feature..","commit_id":"83d98dcec106620de79780f10325afdda48024e5"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"71f0d77c6c7726c0e8f34b858691928f5c7d4ebe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Store network mtu value into DB to make it possible for drivers with share"},{"line_number":4,"context_line":"    server support to support different values than 1500."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ad45d7e_5253fd38","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"in_reply_to":"9ad45d7e_182b9f95","updated":"2016-08-11 14:30:07.000000000","message":"Done","commit_id":"83d98dcec106620de79780f10325afdda48024e5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f0a5a47f3c113d3a11e648de3e82b7086134192","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Store network mtu value into DB to make it possible for drivers with share"},{"line_number":4,"context_line":"    server support to support different values than 1500."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ad45d7e_581fd76b","line":3,"range":{"start_line":3,"start_character":18,"end_line":3,"end_character":21},"updated":"2016-08-10 15:40:54.000000000","message":"MTU","commit_id":"83d98dcec106620de79780f10325afdda48024e5"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"71f0d77c6c7726c0e8f34b858691928f5c7d4ebe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Store network mtu value into DB to make it possible for drivers with share"},{"line_number":4,"context_line":"    server support to support different values than 1500."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ad45d7e_d116ca4a","line":3,"range":{"start_line":3,"start_character":18,"end_line":3,"end_character":21},"in_reply_to":"9ad45d7e_581fd76b","updated":"2016-08-11 14:30:07.000000000","message":"Done","commit_id":"83d98dcec106620de79780f10325afdda48024e5"}]}
