)]}'
{"manila/share/drivers/zfsonlinux/driver.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"246d58f46a3348a4b1d5fcd4470c9d0b45536174","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"            replica_snapshots_dict[replica_snapshot[\u0027id\u0027]][\u0027status\u0027] \u003d ("},{"line_number":1253,"context_line":"                constants.STATUS_DELETED)"},{"line_number":1254,"context_line":""},{"line_number":1255,"context_line":"        self.private_storage.delete(replica_snapshot[\u0027snapshot_id\u0027])"},{"line_number":1256,"context_line":"        return list(replica_snapshots_dict.values())"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    @ensure_share_server_not_provided"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_bcb83d12","line":1255,"updated":"2016-08-01 21:01:59.000000000","message":"replica_snapshot will be last one in the above loop?  If replica_snapshots is empty, replica_snapshot won\u0027t be defined.","commit_id":"839ba2301854fa2cf5357d38e039e4d6f28eecbe"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"92dabca70cba38d75ae3b15e95fe0a86e2bfd889","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"            replica_snapshots_dict[replica_snapshot[\u0027id\u0027]][\u0027status\u0027] \u003d ("},{"line_number":1253,"context_line":"                constants.STATUS_DELETED)"},{"line_number":1254,"context_line":""},{"line_number":1255,"context_line":"        self.private_storage.delete(replica_snapshot[\u0027snapshot_id\u0027])"},{"line_number":1256,"context_line":"        return list(replica_snapshots_dict.values())"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    @ensure_share_server_not_provided"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_db71170e","line":1255,"in_reply_to":"bacf61ea_1bd9ef57","updated":"2016-08-04 13:10:48.000000000","message":"I will just leave it here: https://docs.python.org/3/reference/compound_stmts.html#for","commit_id":"839ba2301854fa2cf5357d38e039e4d6f28eecbe"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7fd248b31ca254a9f07fe0655473a7ebc4711a0a","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"            replica_snapshots_dict[replica_snapshot[\u0027id\u0027]][\u0027status\u0027] \u003d ("},{"line_number":1253,"context_line":"                constants.STATUS_DELETED)"},{"line_number":1254,"context_line":""},{"line_number":1255,"context_line":"        self.private_storage.delete(replica_snapshot[\u0027snapshot_id\u0027])"},{"line_number":1256,"context_line":"        return list(replica_snapshots_dict.values())"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    @ensure_share_server_not_provided"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_fb74dbfe","line":1255,"in_reply_to":"bacf61ea_1bd9ef57","updated":"2016-08-04 13:10:49.000000000","message":"a code that looks like it has a potential problem","commit_id":"839ba2301854fa2cf5357d38e039e4d6f28eecbe"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"be92dc30e88b8e80e4f0aded5eaec8800d4a5fef","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"            replica_snapshots_dict[replica_snapshot[\u0027id\u0027]][\u0027status\u0027] \u003d ("},{"line_number":1253,"context_line":"                constants.STATUS_DELETED)"},{"line_number":1254,"context_line":""},{"line_number":1255,"context_line":"        self.private_storage.delete(replica_snapshot[\u0027snapshot_id\u0027])"},{"line_number":1256,"context_line":"        return list(replica_snapshots_dict.values())"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    @ensure_share_server_not_provided"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_9b383fd5","line":1255,"in_reply_to":"bacf61ea_1decb58e","updated":"2016-08-04 13:00:27.000000000","message":"I agree with Xing on this, even though this does not cause failure, I don\u0027t think we should merge code like this","commit_id":"839ba2301854fa2cf5357d38e039e4d6f28eecbe"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"55a26a0611ac416e50f215330ebc2658390aae5e","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"            replica_snapshots_dict[replica_snapshot[\u0027id\u0027]][\u0027status\u0027] \u003d ("},{"line_number":1253,"context_line":"                constants.STATUS_DELETED)"},{"line_number":1254,"context_line":""},{"line_number":1255,"context_line":"        self.private_storage.delete(replica_snapshot[\u0027snapshot_id\u0027])"},{"line_number":1256,"context_line":"        return list(replica_snapshots_dict.values())"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    @ensure_share_server_not_provided"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_e1454c43","line":1255,"in_reply_to":"bacf61ea_7be58ba2","updated":"2016-08-04 13:35:04.000000000","message":"nevermind, took a while to notice it is the \u0027snapshot_id\u0027 which is not the instance ID. A different pair of eyes helped me see this","commit_id":"839ba2301854fa2cf5357d38e039e4d6f28eecbe"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"87bb2464a0a6df4454ef6a0580417eab029f1fc1","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"            replica_snapshots_dict[replica_snapshot[\u0027id\u0027]][\u0027status\u0027] \u003d ("},{"line_number":1253,"context_line":"                constants.STATUS_DELETED)"},{"line_number":1254,"context_line":""},{"line_number":1255,"context_line":"        self.private_storage.delete(replica_snapshot[\u0027snapshot_id\u0027])"},{"line_number":1256,"context_line":"        return list(replica_snapshots_dict.values())"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    @ensure_share_server_not_provided"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_1bd9ef57","line":1255,"in_reply_to":"bacf61ea_9b383fd5","updated":"2016-08-04 13:05:46.000000000","message":"What do you mean by \"code like this\"?","commit_id":"839ba2301854fa2cf5357d38e039e4d6f28eecbe"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e67b64046080ea0afb1ef24914ad8e35e7525fed","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"            replica_snapshots_dict[replica_snapshot[\u0027id\u0027]][\u0027status\u0027] \u003d ("},{"line_number":1253,"context_line":"                constants.STATUS_DELETED)"},{"line_number":1254,"context_line":""},{"line_number":1255,"context_line":"        self.private_storage.delete(replica_snapshot[\u0027snapshot_id\u0027])"},{"line_number":1256,"context_line":"        return list(replica_snapshots_dict.values())"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    @ensure_share_server_not_provided"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_fc947537","line":1255,"in_reply_to":"bacf61ea_bcb83d12","updated":"2016-08-01 21:05:14.000000000","message":"Ok, just provide scenario how we can reproduce such situation, when we do not have replicas at all - even active one and can call this method.","commit_id":"839ba2301854fa2cf5357d38e039e4d6f28eecbe"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4b5559a24972d638ff9d0ff61f05cc99c9c86f6a","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"            replica_snapshots_dict[replica_snapshot[\u0027id\u0027]][\u0027status\u0027] \u003d ("},{"line_number":1253,"context_line":"                constants.STATUS_DELETED)"},{"line_number":1254,"context_line":""},{"line_number":1255,"context_line":"        self.private_storage.delete(replica_snapshot[\u0027snapshot_id\u0027])"},{"line_number":1256,"context_line":"        return list(replica_snapshots_dict.values())"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    @ensure_share_server_not_provided"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_7be58ba2","line":1255,"in_reply_to":"bacf61ea_fb74dbfe","updated":"2016-08-04 13:11:48.000000000","message":"It does not have potential problem. Or \"no more than any other possible approach\".","commit_id":"839ba2301854fa2cf5357d38e039e4d6f28eecbe"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9317c7fb840ecad3ee27a524c8865607aafeb053","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"            replica_snapshots_dict[replica_snapshot[\u0027id\u0027]][\u0027status\u0027] \u003d ("},{"line_number":1253,"context_line":"                constants.STATUS_DELETED)"},{"line_number":1254,"context_line":""},{"line_number":1255,"context_line":"        self.private_storage.delete(replica_snapshot[\u0027snapshot_id\u0027])"},{"line_number":1256,"context_line":"        return list(replica_snapshots_dict.values())"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    @ensure_share_server_not_provided"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_1d8795d8","line":1255,"in_reply_to":"bacf61ea_fc947537","updated":"2016-08-02 16:04:04.000000000","message":"Ok, I\u0027ll leave it for others to take a look.","commit_id":"839ba2301854fa2cf5357d38e039e4d6f28eecbe"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"eb1667e23a3bb4535ff60e4627d47658c807c501","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"            replica_snapshots_dict[replica_snapshot[\u0027id\u0027]][\u0027status\u0027] \u003d ("},{"line_number":1253,"context_line":"                constants.STATUS_DELETED)"},{"line_number":1254,"context_line":""},{"line_number":1255,"context_line":"        self.private_storage.delete(replica_snapshot[\u0027snapshot_id\u0027])"},{"line_number":1256,"context_line":"        return list(replica_snapshots_dict.values())"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    @ensure_share_server_not_provided"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_1decb58e","line":1255,"in_reply_to":"bacf61ea_fc947537","updated":"2016-08-02 16:04:48.000000000","message":"On this step \"replica_snapshot\" always exists and defined. If it would not be so, it would fail earlier.","commit_id":"839ba2301854fa2cf5357d38e039e4d6f28eecbe"}]}