)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"c1a26b939e75300ce3b60d5bb7566f41d3c06577","unresolved":false,"context_lines":[{"line_number":13,"context_line":"share with that Cephx ID, the share will become stuck in the"},{"line_number":14,"context_line":"\"deleting\" state."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This commit adds logic to the allow_access method in the CephFS Native"},{"line_number":17,"context_line":"driver that checks to see if the Cephx ID given is the same that Manila"},{"line_number":18,"context_line":"is using for its communication with the Ceph backend. If that is the"},{"line_number":19,"context_line":"case, the creation of the access rule will fail with an error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_a48da932","line":16,"range":{"start_line":16,"start_character":30,"end_line":16,"end_character":42},"updated":"2016-08-02 11:18:10.000000000","message":"_allow_access","commit_id":"a97c20c3f9818c3b138928b1b858b081c9acdc57"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"a13b04c812f474b3ac8b483e47f48251b536434a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"share with that Cephx ID, the share will become stuck in the"},{"line_number":14,"context_line":"\"deleting\" state."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This commit adds logic to the allow_access method in the CephFS Native"},{"line_number":17,"context_line":"driver that checks to see if the Cephx ID given is the same that Manila"},{"line_number":18,"context_line":"is using for its communication with the Ceph backend. If that is the"},{"line_number":19,"context_line":"case, the creation of the access rule will fail with an error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_62727a4b","line":16,"range":{"start_line":16,"start_character":30,"end_line":16,"end_character":42},"in_reply_to":"bacf61ea_a48da932","updated":"2016-08-02 13:36:52.000000000","message":"Fixed, thanks!","commit_id":"a97c20c3f9818c3b138928b1b858b081c9acdc57"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6696dacfb5de4141962222dac2b9d12a10fad9c2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"driver that checks to see if the Cephx ID given is the same that Manila"},{"line_number":18,"context_line":"is using for its communication with the Ceph backend. If that is the"},{"line_number":19,"context_line":"case, the creation of the access rule will fail with an error."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ida89b0061db1c8780a19475510b830d013a5c154"},{"line_number":22,"context_line":"Closes-Bug: #1608592"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_1c285e32","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":0},"updated":"2016-08-02 03:02:38.000000000","message":"APIImpact\nDocImpact","commit_id":"a97c20c3f9818c3b138928b1b858b081c9acdc57"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"a13b04c812f474b3ac8b483e47f48251b536434a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"driver that checks to see if the Cephx ID given is the same that Manila"},{"line_number":18,"context_line":"is using for its communication with the Ceph backend. If that is the"},{"line_number":19,"context_line":"case, the creation of the access rule will fail with an error."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ida89b0061db1c8780a19475510b830d013a5c154"},{"line_number":22,"context_line":"Closes-Bug: #1608592"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_a2b912ce","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":0},"in_reply_to":"bacf61ea_1c285e32","updated":"2016-08-02 13:36:52.000000000","message":"Added, thanks, Goutham!","commit_id":"a97c20c3f9818c3b138928b1b858b081c9acdc57"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"576cfb60831daaec4d6e52e9cf19ec5421a010d9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"case, the creation of the access rule will fail with an error."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ida89b0061db1c8780a19475510b830d013a5c154"},{"line_number":22,"context_line":"Closes-Bug: #1608592"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_02e910b7","line":22,"updated":"2016-08-02 09:33:57.000000000","message":"Please move the bug to manila\u0027s LP. It\u0027s currently in python-manilaclient LP.","commit_id":"a97c20c3f9818c3b138928b1b858b081c9acdc57"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"a13b04c812f474b3ac8b483e47f48251b536434a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"case, the creation of the access rule will fail with an error."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ida89b0061db1c8780a19475510b830d013a5c154"},{"line_number":22,"context_line":"Closes-Bug: #1608592"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_82da0e16","line":22,"in_reply_to":"bacf61ea_02e910b7","updated":"2016-08-02 13:36:52.000000000","message":"Moved it over to Manila\u0027s Launchpad. Forgot to move it when I realized that the fix would need to be in the driver and not the client.","commit_id":"a97c20c3f9818c3b138928b1b858b081c9acdc57"}],"manila/api/v1/shares.py":[{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"576cfb60831daaec4d6e52e9cf19ec5421a010d9","unresolved":false,"context_lines":[{"line_number":452,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":453,"context_line":"                \u0027Ceph IDs may not be empty\u0027))"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        if not isinstance(cephx_id, str):"},{"line_number":456,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":457,"context_line":"                \u0027Ceph IDs must be strings\u0027))"},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_e28afc19","line":455,"updated":"2016-08-02 09:33:57.000000000","message":"Remove this check.\n\nWhat if the Ceph auth ID is unicode type (python 2.x) with ASCII printable characters? The patch raises an error when it shouldn\u0027t. See the tempest failures for valid ceph auth IDs in the manila-cephfs CI, http://logs.openstack.org/18/349718/2/check/gate-manila-tempest-dsvm-cephfs-native/a6a80a1/console.html\n\nThe check in line 460 is sufficient.","commit_id":"a97c20c3f9818c3b138928b1b858b081c9acdc57"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"a13b04c812f474b3ac8b483e47f48251b536434a","unresolved":false,"context_lines":[{"line_number":452,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":453,"context_line":"                \u0027Ceph IDs may not be empty\u0027))"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        if not isinstance(cephx_id, str):"},{"line_number":456,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":457,"context_line":"                \u0027Ceph IDs must be strings\u0027))"},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_b7ecb293","line":455,"in_reply_to":"bacf61ea_e28afc19","updated":"2016-08-02 13:36:52.000000000","message":"Ahh, I see. I thought that the restriction specified below would raise an error on any unicode string or characters. I will remove this.","commit_id":"a97c20c3f9818c3b138928b1b858b081c9acdc57"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6696dacfb5de4141962222dac2b9d12a10fad9c2","unresolved":false,"context_lines":[{"line_number":452,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":453,"context_line":"                \u0027Ceph IDs may not be empty\u0027))"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        if not isinstance(cephx_id, str):"},{"line_number":456,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":457,"context_line":"                \u0027Ceph IDs must be strings\u0027))"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        # This restriction may be lifted in Ceph in the future:"},{"line_number":460,"context_line":"        # http://tracker.ceph.com/issues/14626"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_dc3c0695","line":457,"range":{"start_line":455,"start_character":8,"end_line":457,"end_character":44},"updated":"2016-08-02 03:02:38.000000000","message":"If they have to be, any reason you can\u0027t cast them into strings? Is there something that prevents us from doing that, apart from being explicit in the API.","commit_id":"a97c20c3f9818c3b138928b1b858b081c9acdc57"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"a13b04c812f474b3ac8b483e47f48251b536434a","unresolved":false,"context_lines":[{"line_number":452,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":453,"context_line":"                \u0027Ceph IDs may not be empty\u0027))"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        if not isinstance(cephx_id, str):"},{"line_number":456,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":457,"context_line":"                \u0027Ceph IDs must be strings\u0027))"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        # This restriction may be lifted in Ceph in the future:"},{"line_number":460,"context_line":"        # http://tracker.ceph.com/issues/14626"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_377602d9","line":457,"range":{"start_line":455,"start_character":8,"end_line":457,"end_character":44},"in_reply_to":"bacf61ea_dc3c0695","updated":"2016-08-02 13:36:52.000000000","message":"Resolved because this is being removed in next patch set. Thanks, Goutham!","commit_id":"a97c20c3f9818c3b138928b1b858b081c9acdc57"}],"manila/share/drivers/cephfs/cephfs_native.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"401ac2d86985b07669aa7c9ed2d32e2d1c11a4a8","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        # is the same, we need to error out."},{"line_number":221,"context_line":"        if ceph_auth_id \u003d\u003d CONF.cephfs_auth_id:"},{"line_number":222,"context_line":"            error_message \u003d (_(\u0027Ceph authentication ID %s must be different \u0027"},{"line_number":223,"context_line":"                             \u0027than the one the Manila service uses\u0027) %"},{"line_number":224,"context_line":"                             ceph_auth_id)"},{"line_number":225,"context_line":"            raise exception.InvalidInput(message\u003derror_message)"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_998d80d5","line":223,"range":{"start_line":223,"start_character":66,"end_line":223,"end_character":67},"updated":"2016-08-02 03:13:08.000000000","message":"period","commit_id":"a97c20c3f9818c3b138928b1b858b081c9acdc57"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"a13b04c812f474b3ac8b483e47f48251b536434a","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        # is the same, we need to error out."},{"line_number":221,"context_line":"        if ceph_auth_id \u003d\u003d CONF.cephfs_auth_id:"},{"line_number":222,"context_line":"            error_message \u003d (_(\u0027Ceph authentication ID %s must be different \u0027"},{"line_number":223,"context_line":"                             \u0027than the one the Manila service uses\u0027) %"},{"line_number":224,"context_line":"                             ceph_auth_id)"},{"line_number":225,"context_line":"            raise exception.InvalidInput(message\u003derror_message)"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_57545620","line":223,"range":{"start_line":223,"start_character":66,"end_line":223,"end_character":67},"in_reply_to":"bacf61ea_998d80d5","updated":"2016-08-02 13:36:52.000000000","message":"Added it!","commit_id":"a97c20c3f9818c3b138928b1b858b081c9acdc57"}],"manila/tests/share/drivers/cephfs/test_cephfs_native.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"401ac2d86985b07669aa7c9ed2d32e2d1c11a4a8","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                          self._context, self._share, {"},{"line_number":198,"context_line":"                              \u0027access_level\u0027: constants.ACCESS_LEVEL_RW,"},{"line_number":199,"context_line":"                              \u0027access_type\u0027: \u0027cephx\u0027,"},{"line_number":200,"context_line":"                              \u0027access_to\u0027: \u0027manila\u0027"},{"line_number":201,"context_line":"                          })"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def test_deny_access(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_f9f0fc68","line":200,"range":{"start_line":200,"start_character":50,"end_line":200,"end_character":51},"updated":"2016-08-02 03:13:08.000000000","message":"trailing comma","commit_id":"a97c20c3f9818c3b138928b1b858b081c9acdc57"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e193a4fbb681f569459f3141243d2a558d936ff5","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                          self._context, self._share, {"},{"line_number":198,"context_line":"                              \u0027access_level\u0027: constants.ACCESS_LEVEL_RW,"},{"line_number":199,"context_line":"                              \u0027access_type\u0027: \u0027cephx\u0027,"},{"line_number":200,"context_line":"                              \u0027access_to\u0027: \u0027manila\u0027"},{"line_number":201,"context_line":"                          })"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def test_deny_access(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_be858dae","line":200,"range":{"start_line":200,"start_character":50,"end_line":200,"end_character":51},"in_reply_to":"bacf61ea_426776ea","updated":"2016-08-03 01:46:21.000000000","message":"This is not a big deal. :) You could update all tests in other submit if you want.","commit_id":"a97c20c3f9818c3b138928b1b858b081c9acdc57"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"6d9e36fbfa25f77021bdf46b924202f1d35e0916","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                          self._context, self._share, {"},{"line_number":198,"context_line":"                              \u0027access_level\u0027: constants.ACCESS_LEVEL_RW,"},{"line_number":199,"context_line":"                              \u0027access_type\u0027: \u0027cephx\u0027,"},{"line_number":200,"context_line":"                              \u0027access_to\u0027: \u0027manila\u0027"},{"line_number":201,"context_line":"                          })"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def test_deny_access(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_530eee32","line":200,"range":{"start_line":200,"start_character":50,"end_line":200,"end_character":51},"in_reply_to":"bacf61ea_be858dae","updated":"2016-08-03 12:33:04.000000000","message":"Okay, good to know. I think I\u0027ll pass on updating the rest for this patch set and update them in a different patch set. Thanks for the clarification!","commit_id":"a97c20c3f9818c3b138928b1b858b081c9acdc57"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"a13b04c812f474b3ac8b483e47f48251b536434a","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                          self._context, self._share, {"},{"line_number":198,"context_line":"                              \u0027access_level\u0027: constants.ACCESS_LEVEL_RW,"},{"line_number":199,"context_line":"                              \u0027access_type\u0027: \u0027cephx\u0027,"},{"line_number":200,"context_line":"                              \u0027access_to\u0027: \u0027manila\u0027"},{"line_number":201,"context_line":"                          })"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def test_deny_access(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_426776ea","line":200,"range":{"start_line":200,"start_character":50,"end_line":200,"end_character":51},"in_reply_to":"bacf61ea_f9f0fc68","updated":"2016-08-02 13:36:52.000000000","message":"There are no trailing commas on the other tests, should I maintain consistency or add the trailing commas to all tests that need them?","commit_id":"a97c20c3f9818c3b138928b1b858b081c9acdc57"}]}
