)]}'
{"manila/share/access.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"a5d8879be5d8371ce0669fe934a6cf4a5ee9c4d2","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            self.db.share_instance_access_delete(context, access_mapping[\u0027id\u0027])"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @access_synchronized"},{"line_number":197,"context_line":"    def _update_db_and_check_refresh("},{"line_number":198,"context_line":"            self, context, rules, delete_rules, share_instance):"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        self._remove_access_rules(context, delete_rules, share_instance[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_ca34dfdf","line":197,"range":{"start_line":197,"start_character":8,"end_line":197,"end_character":36},"updated":"2016-08-03 13:55:11.000000000","message":"This method has two completely different responsibilities. I understand you created this only because of the lock, but this is not necessarily a good thing :)","commit_id":"1aed974857d68c3b5f4e3b0bb61e1518bcb6c713"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"a5d8879be5d8371ce0669fe934a6cf4a5ee9c4d2","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        needs_refresh \u003d self._check_needs_refresh("},{"line_number":206,"context_line":"            context, rules, share_instance)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        return needs_refresh, share_instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_1f159748","line":208,"range":{"start_line":208,"start_character":30,"end_line":208,"end_character":44},"updated":"2016-08-03 13:55:11.000000000","message":"No need to return this. An updated model was needed for _check_needs_refresh on the previous code, but since you\u0027re calling it inside this method, it is not needed anymore.","commit_id":"1aed974857d68c3b5f4e3b0bb61e1518bcb6c713"}]}
