)]}'
{"manila/share/drivers/huawei/v3/smartx.py":[{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"130fc1401ff5b81b6279f38773eef7ed7d12a8f4","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        thin_provision \u003d opts.get(\u0027thin_provisioning\u0027)"},{"line_number":127,"context_line":"        if thin_provision is None:"},{"line_number":128,"context_line":"            root \u003d self.helper._read_xml()"},{"line_number":129,"context_line":"            fstype \u003d root.findtext(\u0027Filesystem/AllocType\u0027)"},{"line_number":130,"context_line":"            if fstype:"},{"line_number":131,"context_line":"                fstype \u003d fstype.strip().strip(\u0027\\n\u0027)"},{"line_number":132,"context_line":"                if fstype \u003d\u003d \u0027Thin\u0027:"},{"line_number":133,"context_line":"                    opts[\u0027LUNType\u0027] \u003d constants.ALLOC_TYPE_THIN_FLAG"},{"line_number":134,"context_line":"                elif fstype \u003d\u003d \u0027Thick\u0027:"},{"line_number":135,"context_line":"                    opts[\u0027LUNType\u0027] \u003d constants.ALLOC_TYPE_THICK_FLAG"},{"line_number":136,"context_line":"                else:"},{"line_number":137,"context_line":"                    err_msg \u003d (_("},{"line_number":138,"context_line":"                        \u0027Huawei config file is wrong. AllocType type must be \u0027"},{"line_number":139,"context_line":"                        \u0027set to \"Thin\" or \"Thick\". AllocType:%(fetchtype)s\u0027) %"},{"line_number":140,"context_line":"                        {\u0027fetchtype\u0027: fstype})"},{"line_number":141,"context_line":"                    raise exception.InvalidShare(reason\u003derr_msg)"},{"line_number":142,"context_line":"            else:"},{"line_number":143,"context_line":"                opts[\u0027LUNType\u0027] \u003d constants.ALLOC_TYPE_THICK_FLAG"},{"line_number":144,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_a9e2f99d","side":"PARENT","line":141,"range":{"start_line":129,"start_character":12,"end_line":141,"end_character":64},"updated":"2016-08-05 05:02:26.000000000","message":"Why delete this? If thin_provision is None, that\u0027s just to say share type doesn\u0027t config sharetype. But our xml config the sharetype. Following the logic about delete the code, if THICK is configured in xml, and we will create a THIN share.Is that correct?","commit_id":"8907c93740cb059b31eae9683abfc898c711f7fc"}],"releasenotes/notes/remove-AllocType-from-huawei-driver-8b279802f36efb00.yaml":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"bedc53fc0d05932e96e1f2e611f737fc2b0ffdcb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Manila scheduler checks \"thin_provisioning\" in extra specs of the share type"},{"line_number":4,"context_line":"    and decides whether to use the logic for thin or thick. If \"thin_provisioning\""},{"line_number":5,"context_line":"    not given in extra specs, default use thin."},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - Remove the \"AllocType\" configuration from huawei driver configuration file."},{"line_number":8,"context_line":"    If \"thin_provisioning\" not given, default create new share by \"thin\" type."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1ac06dbe_5c629d17","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":79},"updated":"2016-08-24 21:48:09.000000000","message":"\"Deprecation\" means something still works but will be removed in the future.  AllocType has been removed, not deprecated, so this reno is misleading.","commit_id":"d48a23fb959f72d65b75c71ddce9c253342834c0"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"73f882e9faf5f7b42b1eaef53fd23e0f19e4a449","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Manila scheduler checks \"thin_provisioning\" in extra specs of the share type"},{"line_number":4,"context_line":"    and decides whether to use the logic for thin or thick. If \"thin_provisioning\""},{"line_number":5,"context_line":"    not given in extra specs, default use thin."},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - Remove the \"AllocType\" configuration from huawei driver configuration file."},{"line_number":8,"context_line":"    If \"thin_provisioning\" not given, default create new share by \"thin\" type."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa7ab95a_1f41110c","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":79},"in_reply_to":"1ac06dbe_5c629d17","updated":"2016-08-26 06:51:59.000000000","message":"Done","commit_id":"d48a23fb959f72d65b75c71ddce9c253342834c0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5a080006ac4fe2778e58e3997cb890124207a8f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Manila scheduler checks \"thin_provisioning\" in extra specs of the share type"},{"line_number":4,"context_line":"    and decides whether to use the logic for thin or thick. If \"thin_provisioning\""},{"line_number":5,"context_line":"    not given in extra specs, default use thin."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - Remove the \"AllocType\" configuration from huawei driver configuration file."},{"line_number":8,"context_line":"    If \"thin_provisioning\" not given, default create new share by \"thin\" type."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a89bdaa_c96672ba","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":47},"updated":"2016-09-14 13:09:35.000000000","message":"don\u0027t go beyond 79 chars","commit_id":"d0e2380324dbece4d17496ff6ddf094ecdc6f887"}]}
