)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e2ed18573aa811e6106dc130801c4b91ee1c6dfc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HNAS backend has support for enabling dedupe in file systems. This"},{"line_number":10,"context_line":"commit adds a report for this capability in Manila HNAS driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: fca3ba3759128d9e1ae8a5f15368aef58aa929d8"},{"line_number":13,"context_line":"Closes-Bug: #1610956"},{"line_number":14,"context_line":"Change-Id: I6f83da1e51cfdcd8d20b607619c131d13f9e513f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_def47888","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"updated":"2016-08-10 01:43:31.000000000","message":"DocImpact\n\nDo you need to update: doc/source/devref/hds_hnas_driver.rst ?","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"f7dd883ddae9e1d1fa5e6af1a27bcee31715cc29","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HNAS backend has support for enabling dedupe in file systems. This"},{"line_number":10,"context_line":"commit adds a report for this capability in Manila HNAS driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: fca3ba3759128d9e1ae8a5f15368aef58aa929d8"},{"line_number":13,"context_line":"Closes-Bug: #1610956"},{"line_number":14,"context_line":"Change-Id: I6f83da1e51cfdcd8d20b607619c131d13f9e513f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_a885b7cf","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"in_reply_to":"9ad45d7e_def47888","updated":"2016-08-11 11:45:12.000000000","message":"Added DocImpact\nI\u0027ll make another patch to update the .rst file including this fix and features, like cifs support.","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e2ed18573aa811e6106dc130801c4b91ee1c6dfc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"commit adds a report for this capability in Manila HNAS driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: fca3ba3759128d9e1ae8a5f15368aef58aa929d8"},{"line_number":13,"context_line":"Closes-Bug: #1610956"},{"line_number":14,"context_line":"Change-Id: I6f83da1e51cfdcd8d20b607619c131d13f9e513f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_5e2fe8f5","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":20},"updated":"2016-08-10 01:43:31.000000000","message":"This is not a bug fix. It is essentially a new feature..  needs a blueprint.","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2b2f834c0ea0fec9178d092fad84f9506a030075","unresolved":false,"context_lines":[{"line_number":10,"context_line":"commit adds a report for this capability in Manila HNAS driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: fca3ba3759128d9e1ae8a5f15368aef58aa929d8"},{"line_number":13,"context_line":"Closes-Bug: #1610956"},{"line_number":14,"context_line":"Change-Id: I6f83da1e51cfdcd8d20b607619c131d13f9e513f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_c19c6f5f","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":20},"in_reply_to":"9ad45d7e_06269d14","updated":"2016-08-10 18:06:11.000000000","message":"and yes, we intend to backport this one as well.","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ca369b32501ee8df48851f9b304bcb1514dede6a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"commit adds a report for this capability in Manila HNAS driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: fca3ba3759128d9e1ae8a5f15368aef58aa929d8"},{"line_number":13,"context_line":"Closes-Bug: #1610956"},{"line_number":14,"context_line":"Change-Id: I6f83da1e51cfdcd8d20b607619c131d13f9e513f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_e3f9e481","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":20},"in_reply_to":"9ad45d7e_5e2fe8f5","updated":"2016-08-10 03:50:58.000000000","message":"+1, It should be a new blueprint","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"f7dd883ddae9e1d1fa5e6af1a27bcee31715cc29","unresolved":false,"context_lines":[{"line_number":10,"context_line":"commit adds a report for this capability in Manila HNAS driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: fca3ba3759128d9e1ae8a5f15368aef58aa929d8"},{"line_number":13,"context_line":"Closes-Bug: #1610956"},{"line_number":14,"context_line":"Change-Id: I6f83da1e51cfdcd8d20b607619c131d13f9e513f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_0e17ab48","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":20},"in_reply_to":"9ad45d7e_77ce212f","updated":"2016-08-11 11:45:12.000000000","message":"Ok, keeping it as bug fix. Thanks for the thoughts guys.","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e31d4166b1c465470bb6b9b3dcdc9a35173269d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"commit adds a report for this capability in Manila HNAS driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: fca3ba3759128d9e1ae8a5f15368aef58aa929d8"},{"line_number":13,"context_line":"Closes-Bug: #1610956"},{"line_number":14,"context_line":"Change-Id: I6f83da1e51cfdcd8d20b607619c131d13f9e513f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_77ce212f","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":20},"in_reply_to":"9ad45d7e_c19c6f5f","updated":"2016-08-10 18:57:23.000000000","message":"Alright.. As we discussed on the IRC.. we could consider this a bug fix; generally speaking adding new driver capabilities should be new features.. but your explanation works in this case.. \n\nAs i mentioned.. the Thin provisioning fix you quoted is definitely a bug fix.. because the scheduler understands thin_provisioning to be a special flag that it has to perform some scheduling decisions and math upon. Not reporting it would result in your backend being treated as a thick_provisioning only backend.. which would throw all the over provisioning math out of the window.","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"d697a2e0d08c4b5fef5ac71d86eae92f1e4fb507","unresolved":false,"context_lines":[{"line_number":10,"context_line":"commit adds a report for this capability in Manila HNAS driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: fca3ba3759128d9e1ae8a5f15368aef58aa929d8"},{"line_number":13,"context_line":"Closes-Bug: #1610956"},{"line_number":14,"context_line":"Change-Id: I6f83da1e51cfdcd8d20b607619c131d13f9e513f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_06269d14","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":20},"in_reply_to":"9ad45d7e_e3f9e481","updated":"2016-08-10 17:45:20.000000000","message":"It\u0027s a bugfix, not a new feature. The backend always supported dedupe but the driver was not reporting it, so Manila was assuming the default value. We have made a similar fix on the HNAS driver previously, which was backported: https://review.openstack.org/#/c/290401/","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"96c3cffed672a8dc8f31c86d7563eafd13fb9a23","unresolved":false,"context_lines":[{"line_number":10,"context_line":"commit adds a report for this capability in Manila HNAS driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":"Depends-On: fca3ba3759128d9e1ae8a5f15368aef58aa929d8"},{"line_number":14,"context_line":"Closes-Bug: #1610956"},{"line_number":15,"context_line":"Change-Id: I6f83da1e51cfdcd8d20b607619c131d13f9e513f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_48a51645","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":52},"updated":"2016-08-11 12:35:49.000000000","message":"?","commit_id":"1864ee1ac21ae0bd03489aa7688aa23572256c55"}],"manila/share/drivers/hitachi/ssh.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"a2af0af0cc20595057a26d785720c5d077eb5db5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        :returns:"},{"line_number":54,"context_line":"        fs_capacity.size \u003d Total size from filesystem."},{"line_number":55,"context_line":"        available_space \u003d Free space currently on filesystem."},{"line_number":56,"context_line":"        dedupe \u003d Returns if dedupe is enabled on filesystem."},{"line_number":57,"context_line":"        \"\"\""},{"line_number":58,"context_line":"        command \u003d [\u0027df\u0027, \u0027-a\u0027, \u0027-f\u0027, self.fs_name]"},{"line_number":59,"context_line":"        output, err \u003d self._execute(command)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_da7344b3","line":56,"range":{"start_line":56,"start_character":17,"end_line":56,"end_character":59},"updated":"2016-08-08 13:05:11.000000000","message":"True if dedupe is enabled on filesystem","commit_id":"cb954be9abec8ad8d667833667ba3593237bed67"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"2486b22b274b0827a4d8f05e6d70886bcfd36d90","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        :returns:"},{"line_number":54,"context_line":"        fs_capacity.size \u003d Total size from filesystem."},{"line_number":55,"context_line":"        available_space \u003d Free space currently on filesystem."},{"line_number":56,"context_line":"        dedupe \u003d Returns if dedupe is enabled on filesystem."},{"line_number":57,"context_line":"        \"\"\""},{"line_number":58,"context_line":"        command \u003d [\u0027df\u0027, \u0027-a\u0027, \u0027-f\u0027, self.fs_name]"},{"line_number":59,"context_line":"        output, err \u003d self._execute(command)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_5ab0f48b","line":56,"range":{"start_line":56,"start_character":17,"end_line":56,"end_character":59},"in_reply_to":"9ad45d7e_da7344b3","updated":"2016-08-08 15:26:13.000000000","message":"Done","commit_id":"cb954be9abec8ad8d667833667ba3593237bed67"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"a2af0af0cc20595057a26d785720c5d077eb5db5","unresolved":false,"context_lines":[{"line_number":613,"context_line":"                self.used_measure \u003d items[6]"},{"line_number":614,"context_line":"                if self.used_measure \u003d\u003d \u0027TB\u0027:"},{"line_number":615,"context_line":"                    self.used \u003d self.used * units.Ki"},{"line_number":616,"context_line":"            self.dedupe \u003d True if \u0027dedupe enabled\u0027 in data else False"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"class Quota(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_7a1a1870","line":616,"range":{"start_line":616,"start_character":12,"end_line":616,"end_character":69},"updated":"2016-08-08 13:05:11.000000000","message":"No need for the verification. Just\n\n    \u0027dedupe enabled\u0027 in data\n\nalready returns a boolean value.","commit_id":"cb954be9abec8ad8d667833667ba3593237bed67"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"2486b22b274b0827a4d8f05e6d70886bcfd36d90","unresolved":false,"context_lines":[{"line_number":613,"context_line":"                self.used_measure \u003d items[6]"},{"line_number":614,"context_line":"                if self.used_measure \u003d\u003d \u0027TB\u0027:"},{"line_number":615,"context_line":"                    self.used \u003d self.used * units.Ki"},{"line_number":616,"context_line":"            self.dedupe \u003d True if \u0027dedupe enabled\u0027 in data else False"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"class Quota(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_ba993022","line":616,"range":{"start_line":616,"start_character":12,"end_line":616,"end_character":69},"in_reply_to":"9ad45d7e_7a1a1870","updated":"2016-08-08 15:26:13.000000000","message":"Done","commit_id":"cb954be9abec8ad8d667833667ba3593237bed67"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e2ed18573aa811e6106dc130801c4b91ee1c6dfc","unresolved":false,"context_lines":[{"line_number":613,"context_line":"                self.used_measure \u003d items[6]"},{"line_number":614,"context_line":"                if self.used_measure \u003d\u003d \u0027TB\u0027:"},{"line_number":615,"context_line":"                    self.used \u003d self.used * units.Ki"},{"line_number":616,"context_line":"            self.dedupe \u003d \u0027dedupe enabled\u0027 in data"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"class Quota(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_fecfbc7c","line":616,"range":{"start_line":616,"start_character":26,"end_line":616,"end_character":42},"updated":"2016-08-10 01:43:31.000000000","message":"please declare this as a constant..","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"f7dd883ddae9e1d1fa5e6af1a27bcee31715cc29","unresolved":false,"context_lines":[{"line_number":613,"context_line":"                self.used_measure \u003d items[6]"},{"line_number":614,"context_line":"                if self.used_measure \u003d\u003d \u0027TB\u0027:"},{"line_number":615,"context_line":"                    self.used \u003d self.used * units.Ki"},{"line_number":616,"context_line":"            self.dedupe \u003d \u0027dedupe enabled\u0027 in data"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"class Quota(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_884d539c","line":616,"range":{"start_line":616,"start_character":26,"end_line":616,"end_character":42},"in_reply_to":"9ad45d7e_d9961fef","updated":"2016-08-11 11:45:12.000000000","message":"Ben +1, it seems ok for me.","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"392b77d0015cd635d4853175ea3a9689cab80cf7","unresolved":false,"context_lines":[{"line_number":613,"context_line":"                self.used_measure \u003d items[6]"},{"line_number":614,"context_line":"                if self.used_measure \u003d\u003d \u0027TB\u0027:"},{"line_number":615,"context_line":"                    self.used \u003d self.used * units.Ki"},{"line_number":616,"context_line":"            self.dedupe \u003d \u0027dedupe enabled\u0027 in data"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"class Quota(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_d9961fef","line":616,"range":{"start_line":616,"start_character":26,"end_line":616,"end_character":42},"in_reply_to":"9ad45d7e_fecfbc7c","updated":"2016-08-10 20:21:31.000000000","message":"This seems like a good use of an inline string. Making it a constant just adds an extra layer of indirection.","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"}],"manila/tests/share/drivers/hitachi/test_ssh.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e2ed18573aa811e6106dc130801c4b91ee1c6dfc","unresolved":false,"context_lines":[{"line_number":524,"context_line":"    def test_get_stats_dedupe_on(self):"},{"line_number":525,"context_line":"        fake_list_command \u003d [\u0027df\u0027, \u0027-a\u0027, \u0027-f\u0027, self.fs_name]"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        self.mock_object(ssh.HNASSSHBackend, \u0027_execute\u0027,"},{"line_number":528,"context_line":"                         mock.Mock(return_value\u003d(HNAS_RESULT_df_dedupe_on,"},{"line_number":529,"context_line":"                                                 \"\")))"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        total, free, dedupe \u003d self._driver_ssh.get_stats()"},{"line_number":532,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_5e8c0835","line":529,"range":{"start_line":527,"start_character":0,"end_line":529,"end_character":54},"updated":"2016-08-10 01:43:31.000000000","message":"format:\n\n    self.mock_object(\n            ssh.HNASSSHBackend, \u0027_execute\u0027,\n            mock.Mock(return_value\u003d(HNAS_RESULT_df_dedupe_on, \"\")))","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"f7dd883ddae9e1d1fa5e6af1a27bcee31715cc29","unresolved":false,"context_lines":[{"line_number":524,"context_line":"    def test_get_stats_dedupe_on(self):"},{"line_number":525,"context_line":"        fake_list_command \u003d [\u0027df\u0027, \u0027-a\u0027, \u0027-f\u0027, self.fs_name]"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        self.mock_object(ssh.HNASSSHBackend, \u0027_execute\u0027,"},{"line_number":528,"context_line":"                         mock.Mock(return_value\u003d(HNAS_RESULT_df_dedupe_on,"},{"line_number":529,"context_line":"                                                 \"\")))"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        total, free, dedupe \u003d self._driver_ssh.get_stats()"},{"line_number":532,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_d1229451","line":529,"range":{"start_line":527,"start_character":0,"end_line":529,"end_character":54},"in_reply_to":"9ad45d7e_5e8c0835","updated":"2016-08-11 11:45:12.000000000","message":"Done","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"}],"releasenotes/notes/dedupe-support-hnas-driver-017d2f2a93a8b487.yaml":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"499932eb99d41b59ee4b26534ac875521ea74fe9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - Even if the file system in HNAS backend has dedupe enabled, Manila HNAS"},{"line_number":6,"context_line":"    driver reports it as False. Adding a check for HNAS dedupe status and"},{"line_number":7,"context_line":"    reporting it in _update_share_stats method. "}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9ad45d7e_0f0d773e","line":7,"range":{"start_line":7,"start_character":47,"end_line":7,"end_character":48},"updated":"2016-08-09 06:15:09.000000000","message":"remove this tail space.","commit_id":"84a81ebd8e9d302ef687b63b2bc77dce341a0684"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e2ed18573aa811e6106dc130801c4b91ee1c6dfc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Add dedupe report for Manila HNAS driver."},{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - Even if the file system in HNAS backend has dedupe enabled, Manila HNAS"},{"line_number":6,"context_line":"    driver reports it as False. Adding a check for HNAS dedupe status and"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_9e9de05b","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":45},"updated":"2016-08-10 01:43:31.000000000","message":"Prelude\u0027s for major release themes.. This isn\u0027t a release theme, sorry :)","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"392b77d0015cd635d4853175ea3a9689cab80cf7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Add dedupe report for Manila HNAS driver."},{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - Even if the file system in HNAS backend has dedupe enabled, Manila HNAS"},{"line_number":6,"context_line":"    driver reports it as False. Adding a check for HNAS dedupe status and"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_39dadbe8","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":45},"in_reply_to":"9ad45d7e_9e9de05b","updated":"2016-08-10 20:21:31.000000000","message":"+1","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"f7dd883ddae9e1d1fa5e6af1a27bcee31715cc29","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Add dedupe report for Manila HNAS driver."},{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - Even if the file system in HNAS backend has dedupe enabled, Manila HNAS"},{"line_number":6,"context_line":"    driver reports it as False. Adding a check for HNAS dedupe status and"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_91c81caa","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":45},"in_reply_to":"9ad45d7e_9e9de05b","updated":"2016-08-11 11:45:12.000000000","message":"Ops! Removed ;)","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e2ed18573aa811e6106dc130801c4b91ee1c6dfc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Add dedupe report for Manila HNAS driver."},{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - Even if the file system in HNAS backend has dedupe enabled, Manila HNAS"},{"line_number":6,"context_line":"    driver reports it as False. Adding a check for HNAS dedupe status and"},{"line_number":7,"context_line":"    reporting it in _update_share_stats method."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_fed21cff","line":7,"range":{"start_line":5,"start_character":4,"end_line":7,"end_character":47},"updated":"2016-08-10 01:43:31.000000000","message":"What was done in this patch? This sounds like wording for the commit message\n\nAlso, this is a feature.. \n\nfeatures:\n   - Hitachi HNAS driver now reports ``dedupe`` capability and\n     it can be used in extra-specs to choose a HNAS file system\n     that has dedupe enabled when creating a manila share on HNAS.","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"f7dd883ddae9e1d1fa5e6af1a27bcee31715cc29","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Add dedupe report for Manila HNAS driver."},{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - Even if the file system in HNAS backend has dedupe enabled, Manila HNAS"},{"line_number":6,"context_line":"    driver reports it as False. Adding a check for HNAS dedupe status and"},{"line_number":7,"context_line":"    reporting it in _update_share_stats method."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_4e4b6359","line":7,"range":{"start_line":5,"start_character":4,"end_line":7,"end_character":47},"in_reply_to":"9ad45d7e_b9f40b5b","updated":"2016-08-11 11:45:12.000000000","message":"Fix description updated.","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"392b77d0015cd635d4853175ea3a9689cab80cf7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Add dedupe report for Manila HNAS driver."},{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - Even if the file system in HNAS backend has dedupe enabled, Manila HNAS"},{"line_number":6,"context_line":"    driver reports it as False. Adding a check for HNAS dedupe status and"},{"line_number":7,"context_line":"    reporting it in _update_share_stats method."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_b9f40b5b","line":7,"range":{"start_line":5,"start_character":4,"end_line":7,"end_character":47},"in_reply_to":"9ad45d7e_fed21cff","updated":"2016-08-10 20:21:31.000000000","message":"Better to leave this as a bugfix if the intention is to backport","commit_id":"da38d85b40f56b74a56b9c642643e42e7e1ad2b6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"73c8a3bc7764b99e5a12b9ad526587d88fc0a141","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - _update_share_stats method now parser correctly the output for HNAS"},{"line_number":4,"context_line":"    filesystems when dedupe is enabled and return this capability for"},{"line_number":5,"context_line":"    scheduler."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9ad45d7e_c87e2669","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":14},"updated":"2016-08-11 12:26:46.000000000","message":"Nope..people who read release notes would have to look at the code to understand what _update_share_stats is.. \n\n   - Hitachi HNAS driver now reports ``dedupe`` capability and\n     it can be used in extra-specs to choose a HNAS file system\n     that has dedupe enabled when creating a manila share on HNAS.","commit_id":"d4c083f552efde354ddfc6098141e2bdac4de8c9"}]}