)]}'
{"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"899139aafadb85e00f08137d989a020d0b9e4690","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"            \u0027is-nfsv3-enabled\u0027: nfs3,"},{"line_number":1085,"context_line":"            \u0027is-nfsv40-enabled\u0027: nfs40,"},{"line_number":1086,"context_line":"            \u0027is-nfsv41-enabled\u0027: nfs41,"},{"line_number":1087,"context_line":"        }"},{"line_number":1088,"context_line":"        self.send_request(\u0027nfs-service-modify\u0027, nfs_service_modify_args)"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_d225d60a","line":1087,"range":{"start_line":1087,"start_character":7,"end_line":1087,"end_character":9},"updated":"2016-08-12 18:52:02.000000000","message":"what happens if they are all false?","commit_id":"ead05120ab41c56597eb00f1581ea574f1d7417e"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"65642ef4559bf47f665f71a1fdeaff7f818de7a5","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"            \u0027is-nfsv3-enabled\u0027: nfs3,"},{"line_number":1085,"context_line":"            \u0027is-nfsv40-enabled\u0027: nfs40,"},{"line_number":1086,"context_line":"            \u0027is-nfsv41-enabled\u0027: nfs41,"},{"line_number":1087,"context_line":"        }"},{"line_number":1088,"context_line":"        self.send_request(\u0027nfs-service-modify\u0027, nfs_service_modify_args)"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_fda9cb7c","line":1087,"range":{"start_line":1087,"start_character":7,"end_line":1087,"end_character":9},"in_reply_to":"9ad45d7e_d225d60a","updated":"2016-08-12 19:01:33.000000000","message":"Then the NFS server will run but no mounts will succeed.  But there is a reasonable default, and it\u0027s a pretty bad admin that would explicitly disable every NFS version, so we think it\u0027s probably overkill to check that case.","commit_id":"ead05120ab41c56597eb00f1581ea574f1d7417e"}],"manila/tests/share/drivers/netapp/dataontap/client/test_client_cmode.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"899139aafadb85e00f08137d989a020d0b9e4690","unresolved":false,"context_lines":[{"line_number":1937,"context_line":"            fake.NFS_VERSIONS)"},{"line_number":1938,"context_line":"        self.client._create_default_nfs_export_rule.assert_called_once_with()"},{"line_number":1939,"context_line":""},{"line_number":1940,"context_line":"    @ddt.data((True, True, True), (True, False, False), (False, True, True))"},{"line_number":1941,"context_line":"    @ddt.unpack"},{"line_number":1942,"context_line":"    def test_enable_nfs_protocols(self, v3, v40, v41):"},{"line_number":1943,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_92d07ecb","line":1940,"range":{"start_line":1940,"start_character":15,"end_line":1940,"end_character":75},"updated":"2016-08-12 18:52:02.000000000","message":"why not test the other combinations?","commit_id":"ead05120ab41c56597eb00f1581ea574f1d7417e"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"65642ef4559bf47f665f71a1fdeaff7f818de7a5","unresolved":false,"context_lines":[{"line_number":1937,"context_line":"            fake.NFS_VERSIONS)"},{"line_number":1938,"context_line":"        self.client._create_default_nfs_export_rule.assert_called_once_with()"},{"line_number":1939,"context_line":""},{"line_number":1940,"context_line":"    @ddt.data((True, True, True), (True, False, False), (False, True, True))"},{"line_number":1941,"context_line":"    @ddt.unpack"},{"line_number":1942,"context_line":"    def test_enable_nfs_protocols(self, v3, v40, v41):"},{"line_number":1943,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_fd9b8b70","line":1940,"range":{"start_line":1940,"start_character":15,"end_line":1940,"end_character":75},"in_reply_to":"9ad45d7e_92d07ecb","updated":"2016-08-12 19:01:33.000000000","message":"Seems overkill to have 8 tests here, TBH.  I tested the most common combinations that also ensured each flag was tested with each value.","commit_id":"ead05120ab41c56597eb00f1581ea574f1d7417e"}]}
