)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"f159399126965a08d34b740c279a6a012daa90bb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support of share migration feature to ZFsonLinux driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements BP zfsonlinux-share-migration"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If9e1fec9a6d4f96d2bb5c176c6249fafc7e3e891"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"fa7ab95a_dcb985cd","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":13},"updated":"2016-08-31 03:14:12.000000000","message":"Implements: blueprint","commit_id":"c6fd6cc56bfffb8b4a305e9fb77403195bc3c632"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"40f7b91916f6232e01eec23033b59e687588dd19","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support of share migration feature to ZFsonLinux driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements BP zfsonlinux-share-migration"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If9e1fec9a6d4f96d2bb5c176c6249fafc7e3e891"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"fa7ab95a_1c78348f","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":13},"in_reply_to":"fa7ab95a_dcb985cd","updated":"2016-08-31 11:15:46.000000000","message":"The fact that gerrit correctly detects it means it is OK.","commit_id":"c6fd6cc56bfffb8b4a305e9fb77403195bc3c632"}],"manila/share/drivers/zfsonlinux/driver.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"77a2596a274d7565a56f9e6b8e0af3aae72b6e65","unresolved":false,"context_lines":[{"line_number":1316,"context_line":"                                  share_server\u003dNone):"},{"line_number":1317,"context_line":"        \"\"\"Is called to provide necessary driver migration logic.\"\"\""},{"line_number":1318,"context_line":"        return {"},{"line_number":1319,"context_line":"            \"share_driver\": self.configuration.share_driver,"},{"line_number":1320,"context_line":"            \"executor\": zfs_utils.get_remote_shell_executor("},{"line_number":1321,"context_line":"                ip\u003dself.configuration.zfs_service_ip,"},{"line_number":1322,"context_line":"                port\u003d22,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_431ff96b","line":1319,"range":{"start_line":1319,"start_character":11,"end_line":1319,"end_character":60},"updated":"2016-08-10 13:02:42.000000000","message":"as we discussed in midcycle, this is not this driver\u0027s information, this is the remote\u0027s. Driver should read dest_host\u0027s configuration in manila.conf and return info respective to that. NetApp driver does that.\n\nThis is described in the docstring.","commit_id":"202bb1b3cd3e547b82eea5b98b7d725cac5e2da0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"07fb42aafb2a92f041d98e981546637aece7ecc7","unresolved":false,"context_lines":[{"line_number":1316,"context_line":"                                  share_server\u003dNone):"},{"line_number":1317,"context_line":"        \"\"\"Is called to provide necessary driver migration logic.\"\"\""},{"line_number":1318,"context_line":"        return {"},{"line_number":1319,"context_line":"            \"share_driver\": self.configuration.share_driver,"},{"line_number":1320,"context_line":"            \"executor\": zfs_utils.get_remote_shell_executor("},{"line_number":1321,"context_line":"                ip\u003dself.configuration.zfs_service_ip,"},{"line_number":1322,"context_line":"                port\u003d22,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_348f9976","line":1319,"range":{"start_line":1319,"start_character":11,"end_line":1319,"end_character":60},"in_reply_to":"9ad45d7e_431ff96b","updated":"2016-08-10 13:16:12.000000000","message":"I disagree with that approach and has never agreed. I expect that this method will be called from destination host and then its output provided to source which will be able to compare it.","commit_id":"202bb1b3cd3e547b82eea5b98b7d725cac5e2da0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"07fb42aafb2a92f041d98e981546637aece7ecc7","unresolved":false,"context_lines":[{"line_number":1317,"context_line":"        \"\"\"Is called to provide necessary driver migration logic.\"\"\""},{"line_number":1318,"context_line":"        return {"},{"line_number":1319,"context_line":"            \"share_driver\": self.configuration.share_driver,"},{"line_number":1320,"context_line":"            \"executor\": zfs_utils.get_remote_shell_executor("},{"line_number":1321,"context_line":"                ip\u003dself.configuration.zfs_service_ip,"},{"line_number":1322,"context_line":"                port\u003d22,"},{"line_number":1323,"context_line":"                conn_timeout\u003dself.configuration.ssh_conn_timeout,"},{"line_number":1324,"context_line":"                login\u003dself.configuration.zfs_ssh_username,"},{"line_number":1325,"context_line":"                password\u003dself.configuration.zfs_ssh_user_password,"},{"line_number":1326,"context_line":"                privatekey\u003dself.configuration.zfs_ssh_private_key_path,"},{"line_number":1327,"context_line":"                max_size\u003d10,"},{"line_number":1328,"context_line":"            ),"},{"line_number":1329,"context_line":"        }"},{"line_number":1330,"context_line":""},{"line_number":1331,"context_line":"    @ensure_share_server_not_provided"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_f4c6a198","line":1328,"range":{"start_line":1320,"start_character":12,"end_line":1328,"end_character":14},"updated":"2016-08-10 13:16:12.000000000","message":"Same here, should be called exactly on destination host.","commit_id":"202bb1b3cd3e547b82eea5b98b7d725cac5e2da0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"77a2596a274d7565a56f9e6b8e0af3aae72b6e65","unresolved":false,"context_lines":[{"line_number":1333,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":1334,"context_line":"            dest_driver_migration_info, dest_share_instance, access_rules,"},{"line_number":1335,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":1336,"context_line":"        \"\"\"Is called to perform 1st phase of driver migration of a given share."},{"line_number":1337,"context_line":""},{"line_number":1338,"context_line":"        \"\"\""},{"line_number":1339,"context_line":"        src_dataset_name \u003d self.private_storage.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_765ab92b","line":1336,"range":{"start_line":1336,"start_character":24,"end_line":1336,"end_character":31},"updated":"2016-08-10 13:02:42.000000000","message":"s/perform/start. This method is not responsible for doing everything anymore, it should start the migration and end.","commit_id":"202bb1b3cd3e547b82eea5b98b7d725cac5e2da0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"07fb42aafb2a92f041d98e981546637aece7ecc7","unresolved":false,"context_lines":[{"line_number":1333,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":1334,"context_line":"            dest_driver_migration_info, dest_share_instance, access_rules,"},{"line_number":1335,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":1336,"context_line":"        \"\"\"Is called to perform 1st phase of driver migration of a given share."},{"line_number":1337,"context_line":""},{"line_number":1338,"context_line":"        \"\"\""},{"line_number":1339,"context_line":"        src_dataset_name \u003d self.private_storage.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_d4c39d87","line":1336,"range":{"start_line":1336,"start_character":24,"end_line":1336,"end_character":31},"in_reply_to":"9ad45d7e_765ab92b","updated":"2016-08-10 13:16:12.000000000","message":"It is just out-of-date docstring.","commit_id":"202bb1b3cd3e547b82eea5b98b7d725cac5e2da0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f8f78609d268e4e12700d91217ba24601f8555d8","unresolved":false,"context_lines":[{"line_number":1333,"context_line":"            self, context, src_share_instance, dest_host,"},{"line_number":1334,"context_line":"            dest_driver_migration_info, dest_share_instance, access_rules,"},{"line_number":1335,"context_line":"            share_server\u003dNone, dest_share_server\u003dNone):"},{"line_number":1336,"context_line":"        \"\"\"Is called to perform 1st phase of driver migration of a given share."},{"line_number":1337,"context_line":""},{"line_number":1338,"context_line":"        \"\"\""},{"line_number":1339,"context_line":"        src_dataset_name \u003d self.private_storage.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_e5a54da2","line":1336,"range":{"start_line":1336,"start_character":24,"end_line":1336,"end_character":31},"in_reply_to":"9ad45d7e_d4c39d87","updated":"2016-08-10 14:19:25.000000000","message":"Done","commit_id":"202bb1b3cd3e547b82eea5b98b7d725cac5e2da0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"77a2596a274d7565a56f9e6b8e0af3aae72b6e65","unresolved":false,"context_lines":[{"line_number":1364,"context_line":"            \u0027migr_snapshot_tag\u0027: snapshot_tag,"},{"line_number":1365,"context_line":"        })"},{"line_number":1366,"context_line":""},{"line_number":1367,"context_line":"        # Create temporary snapshot on src host."},{"line_number":1368,"context_line":"        self.execute(\u0027sudo\u0027, \u0027zfs\u0027, \u0027snapshot\u0027, src_snapshot_name)"},{"line_number":1369,"context_line":""},{"line_number":1370,"context_line":"        # Send/receive temporary snapshot"},{"line_number":1371,"context_line":"        cmd \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_99b2fe04","line":1368,"range":{"start_line":1367,"start_character":0,"end_line":1368,"end_character":66},"updated":"2016-08-10 13:02:42.000000000","message":"it seems to me your share cannot remain writable during migration, else the snapshot content will be different than the share at the end of migration. In this case you should change access rules to read only.","commit_id":"202bb1b3cd3e547b82eea5b98b7d725cac5e2da0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"07fb42aafb2a92f041d98e981546637aece7ecc7","unresolved":false,"context_lines":[{"line_number":1364,"context_line":"            \u0027migr_snapshot_tag\u0027: snapshot_tag,"},{"line_number":1365,"context_line":"        })"},{"line_number":1366,"context_line":""},{"line_number":1367,"context_line":"        # Create temporary snapshot on src host."},{"line_number":1368,"context_line":"        self.execute(\u0027sudo\u0027, \u0027zfs\u0027, \u0027snapshot\u0027, src_snapshot_name)"},{"line_number":1369,"context_line":""},{"line_number":1370,"context_line":"        # Send/receive temporary snapshot"},{"line_number":1371,"context_line":"        cmd \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_f474e168","line":1368,"range":{"start_line":1367,"start_character":0,"end_line":1368,"end_character":66},"in_reply_to":"9ad45d7e_99b2fe04","updated":"2016-08-10 13:16:12.000000000","message":"It is not driver\u0027s problem. It should be done via its common update_access interface called from share manager.","commit_id":"202bb1b3cd3e547b82eea5b98b7d725cac5e2da0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"77a2596a274d7565a56f9e6b8e0af3aae72b6e65","unresolved":false,"context_lines":[{"line_number":1448,"context_line":"        self.delete_share(context, src_share_instance)"},{"line_number":1449,"context_line":""},{"line_number":1450,"context_line":"        return export_locations"},{"line_number":1451,"context_line":""},{"line_number":1452,"context_line":"    @ensure_share_server_not_provided"},{"line_number":1453,"context_line":"    def migration_cancel("},{"line_number":1454,"context_line":"            self, context, src_share_instance, dest_host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_398f922b","line":1451,"updated":"2016-08-10 13:02:42.000000000","message":"where is migration_get_progress?","commit_id":"202bb1b3cd3e547b82eea5b98b7d725cac5e2da0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"07fb42aafb2a92f041d98e981546637aece7ecc7","unresolved":false,"context_lines":[{"line_number":1448,"context_line":"        self.delete_share(context, src_share_instance)"},{"line_number":1449,"context_line":""},{"line_number":1450,"context_line":"        return export_locations"},{"line_number":1451,"context_line":""},{"line_number":1452,"context_line":"    @ensure_share_server_not_provided"},{"line_number":1453,"context_line":"    def migration_cancel("},{"line_number":1454,"context_line":"            self, context, src_share_instance, dest_host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_d97916ca","line":1451,"in_reply_to":"9ad45d7e_398f922b","updated":"2016-08-10 13:16:12.000000000","message":"Cannot be implemented. Only workarounded with \"0\" when in progress or \"100\" when finished.","commit_id":"202bb1b3cd3e547b82eea5b98b7d725cac5e2da0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4e7d3c8530e706297a80ae9cbdebdb7781ba9105","unresolved":false,"context_lines":[{"line_number":1364,"context_line":"            \u0027migr_snapshot_tag\u0027: snapshot_tag,"},{"line_number":1365,"context_line":"        })"},{"line_number":1366,"context_line":""},{"line_number":1367,"context_line":"        # Create temporary snapshot on src host."},{"line_number":1368,"context_line":"        self.execute(\u0027sudo\u0027, \u0027zfs\u0027, \u0027snapshot\u0027, src_snapshot_name)"},{"line_number":1369,"context_line":""},{"line_number":1370,"context_line":"        # Send/receive temporary snapshot"},{"line_number":1371,"context_line":"        cmd \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_0f4ebb3a","line":1368,"range":{"start_line":1367,"start_character":1,"end_line":1368,"end_character":66},"updated":"2016-08-10 14:43:11.000000000","message":"it is driver\u0027s responsibility. If access.update_access is invoked, it will update access rules in DB. Design states that drivers should change access rules, not change DB, because they are managing it. Later, the original list of access_rules is provided again so they can be restored. Fallback does this.","commit_id":"b71f158660ed984ae9967cf4522965992c25cd89"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"82a845034dea75f28d2eba4ff9c960308a6fa1dd","unresolved":false,"context_lines":[{"line_number":1364,"context_line":"            \u0027migr_snapshot_tag\u0027: snapshot_tag,"},{"line_number":1365,"context_line":"        })"},{"line_number":1366,"context_line":""},{"line_number":1367,"context_line":"        # Create temporary snapshot on src host."},{"line_number":1368,"context_line":"        self.execute(\u0027sudo\u0027, \u0027zfs\u0027, \u0027snapshot\u0027, src_snapshot_name)"},{"line_number":1369,"context_line":""},{"line_number":1370,"context_line":"        # Send/receive temporary snapshot"},{"line_number":1371,"context_line":"        cmd \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_8838dcf0","line":1368,"range":{"start_line":1367,"start_character":1,"end_line":1368,"end_character":66},"in_reply_to":"9ad45d7e_0f4ebb3a","updated":"2016-08-10 17:02:31.000000000","message":"No agreement here right now. And, we can leave with it right now to have working implementation in general.","commit_id":"b71f158660ed984ae9967cf4522965992c25cd89"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4e7d3c8530e706297a80ae9cbdebdb7781ba9105","unresolved":false,"context_lines":[{"line_number":1455,"context_line":"        self.delete_share(context, src_share_instance)"},{"line_number":1456,"context_line":""},{"line_number":1457,"context_line":"        return export_locations"},{"line_number":1458,"context_line":""},{"line_number":1459,"context_line":"    @ensure_share_server_not_provided"},{"line_number":1460,"context_line":"    def migration_cancel("},{"line_number":1461,"context_line":"            self, context, src_share_instance, dest_host,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_2c546d1f","line":1458,"updated":"2016-08-10 14:43:11.000000000","message":"I advise implementing migration_get_progress and raising an exception with a friendly message, else it will always raise NotImplementedError.","commit_id":"b71f158660ed984ae9967cf4522965992c25cd89"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"82a845034dea75f28d2eba4ff9c960308a6fa1dd","unresolved":false,"context_lines":[{"line_number":1455,"context_line":"        self.delete_share(context, src_share_instance)"},{"line_number":1456,"context_line":""},{"line_number":1457,"context_line":"        return export_locations"},{"line_number":1458,"context_line":""},{"line_number":1459,"context_line":"    @ensure_share_server_not_provided"},{"line_number":1460,"context_line":"    def migration_cancel("},{"line_number":1461,"context_line":"            self, context, src_share_instance, dest_host,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_e8423867","line":1458,"in_reply_to":"9ad45d7e_2c546d1f","updated":"2016-08-10 17:02:31.000000000","message":"For now it works without it, lets leave it for future.","commit_id":"b71f158660ed984ae9967cf4522965992c25cd89"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"0c600f80f97aebeded9361f2ccd1664c3d4fb26d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from manila.share import configuration"},{"line_number":34,"context_line":"from manila.share import driver"},{"line_number":35,"context_line":"from manila.share.drivers.zfsonlinux import utils as zfs_utils"},{"line_number":36,"context_line":"from manila.share.manager import share_manager_opts  # noqa"},{"line_number":37,"context_line":"from manila.share import share_types"},{"line_number":38,"context_line":"from manila.share import utils as share_utils"},{"line_number":39,"context_line":"from manila import utils"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_c58c44dc","line":36,"range":{"start_line":36,"start_character":53,"end_line":36,"end_character":59},"updated":"2016-08-11 15:29:50.000000000","message":"Is noqa really needed here? I just tested it without and flake8 didn\u0027t complain about it.","commit_id":"c4b2ce3c1683105fbac5953dd387c3398011d009"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ae1ce085565b6fee674d0616f5c1b1997182b37a","unresolved":false,"context_lines":[{"line_number":1523,"context_line":"                        x for x in line.strip().split(\u0027 \u0027) if x !\u003d \u0027\u0027][1]"},{"line_number":1524,"context_line":"                    self.execute(\u0027sudo\u0027, \u0027kill\u0027, \u0027-9\u0027, migr_pid)"},{"line_number":1525,"context_line":"        except exception.ProcessExecutionError as e:"},{"line_number":1526,"context_line":"            LOG.warning(_LW("},{"line_number":1527,"context_line":"                \"Caught following error trying to kill migration process: %s\"),"},{"line_number":1528,"context_line":"                e)"},{"line_number":1529,"context_line":""},{"line_number":1530,"context_line":"        # Sleep couple of seconds before destroying updated objects"},{"line_number":1531,"context_line":"        time.sleep(2)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_b0fb3046","line":1528,"range":{"start_line":1526,"start_character":12,"end_line":1528,"end_character":18},"updated":"2016-08-12 00:59:12.000000000","message":"see comment below","commit_id":"da828ff840f7b23044ffe2e64846d560b1765408"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ae1ce085565b6fee674d0616f5c1b1997182b37a","unresolved":false,"context_lines":[{"line_number":1527,"context_line":"                \"Caught following error trying to kill migration process: %s\"),"},{"line_number":1528,"context_line":"                e)"},{"line_number":1529,"context_line":""},{"line_number":1530,"context_line":"        # Sleep couple of seconds before destroying updated objects"},{"line_number":1531,"context_line":"        time.sleep(2)"},{"line_number":1532,"context_line":""},{"line_number":1533,"context_line":"        # Destroy snapshot on source host"},{"line_number":1534,"context_line":"        self._delete_dataset_or_snapshot_with_retry("},{"line_number":1535,"context_line":"            src_dataset_name + \u0027@\u0027 + snapshot_tag)"},{"line_number":1536,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_5000f433","line":1533,"range":{"start_line":1530,"start_character":0,"end_line":1533,"end_character":26},"updated":"2016-08-12 00:59:12.000000000","message":"maybe you should not continue if the above command fails?","commit_id":"da828ff840f7b23044ffe2e64846d560b1765408"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ae1ce085565b6fee674d0616f5c1b1997182b37a","unresolved":false,"context_lines":[{"line_number":1541,"context_line":"                \u0027sudo\u0027, \u0027zfs\u0027, \u0027destroy\u0027, \u0027-r\u0027, dst_dataset_name,"},{"line_number":1542,"context_line":"            )"},{"line_number":1543,"context_line":"        except exception.ProcessExecutionError as e:"},{"line_number":1544,"context_line":"            LOG.warning(_LW("},{"line_number":1545,"context_line":"                \"Failed to destroy destination dataset with following error: \""},{"line_number":1546,"context_line":"                \"%s\"),"},{"line_number":1547,"context_line":"                e)"},{"line_number":1548,"context_line":""},{"line_number":1549,"context_line":"        LOG.debug("},{"line_number":1550,"context_line":"            \"Migration of share with ID \u0027%s\u0027 has been canceled.\" %"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_30e740ad","line":1547,"range":{"start_line":1544,"start_character":12,"end_line":1547,"end_character":18},"updated":"2016-08-12 00:59:12.000000000","message":"you are not actually cancelling at this point. So if this method returns successfully, it will assume it is cancelled.","commit_id":"da828ff840f7b23044ffe2e64846d560b1765408"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"f159399126965a08d34b740c279a6a012daa90bb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from manila.share import configuration"},{"line_number":34,"context_line":"from manila.share import driver"},{"line_number":35,"context_line":"from manila.share.drivers.zfsonlinux import utils as zfs_utils"},{"line_number":36,"context_line":"from manila.share.manager import share_manager_opts  # noqa"},{"line_number":37,"context_line":"from manila.share import share_types"},{"line_number":38,"context_line":"from manila.share import utils as share_utils"},{"line_number":39,"context_line":"from manila import utils"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa7ab95a_9cf8dd4b","line":36,"updated":"2016-08-31 03:14:12.000000000","message":"http://docs.openstack.org/developer/hacking/#imports","commit_id":"c6fd6cc56bfffb8b4a305e9fb77403195bc3c632"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"40f7b91916f6232e01eec23033b59e687588dd19","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from manila.share import configuration"},{"line_number":34,"context_line":"from manila.share import driver"},{"line_number":35,"context_line":"from manila.share.drivers.zfsonlinux import utils as zfs_utils"},{"line_number":36,"context_line":"from manila.share.manager import share_manager_opts  # noqa"},{"line_number":37,"context_line":"from manila.share import share_types"},{"line_number":38,"context_line":"from manila.share import utils as share_utils"},{"line_number":39,"context_line":"from manila import utils"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa7ab95a_dc308ceb","line":36,"in_reply_to":"fa7ab95a_9cf8dd4b","updated":"2016-08-31 11:15:46.000000000","message":"It is intended.","commit_id":"c6fd6cc56bfffb8b4a305e9fb77403195bc3c632"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"f159399126965a08d34b740c279a6a012daa90bb","unresolved":false,"context_lines":[{"line_number":126,"context_line":"def ensure_share_server_not_provided(f):"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def wrap(self, context, *args, **kwargs):"},{"line_number":129,"context_line":"        server \u003d kwargs.get(\u0027share_server\u0027, kwargs.get(\u0027dest_share_server\u0027))"},{"line_number":130,"context_line":"        if server:"},{"line_number":131,"context_line":"            raise exception.InvalidInput("},{"line_number":132,"context_line":"                reason\u003d_(\"Share server handling is not available. \""}],"source_content_type":"text/x-python","patch_set":13,"id":"fa7ab95a_b703fabd","line":129,"range":{"start_line":129,"start_character":56,"end_line":129,"end_character":73},"updated":"2016-08-31 03:14:12.000000000","message":"According to the methods that use this decorator, here should be destination_share_server?","commit_id":"c6fd6cc56bfffb8b4a305e9fb77403195bc3c632"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"40f7b91916f6232e01eec23033b59e687588dd19","unresolved":false,"context_lines":[{"line_number":126,"context_line":"def ensure_share_server_not_provided(f):"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def wrap(self, context, *args, **kwargs):"},{"line_number":129,"context_line":"        server \u003d kwargs.get(\u0027share_server\u0027, kwargs.get(\u0027dest_share_server\u0027))"},{"line_number":130,"context_line":"        if server:"},{"line_number":131,"context_line":"            raise exception.InvalidInput("},{"line_number":132,"context_line":"                reason\u003d_(\"Share server handling is not available. \""}],"source_content_type":"text/x-python","patch_set":13,"id":"fa7ab95a_01cfebb3","line":129,"range":{"start_line":129,"start_character":56,"end_line":129,"end_character":73},"in_reply_to":"fa7ab95a_b703fabd","updated":"2016-08-31 11:15:46.000000000","message":"Done","commit_id":"c6fd6cc56bfffb8b4a305e9fb77403195bc3c632"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"f159399126965a08d34b740c279a6a012daa90bb","unresolved":false,"context_lines":[{"line_number":1428,"context_line":"            destination_share[\u0027id\u0027], \u0027migr_snapshot_tag\u0027)"},{"line_number":1429,"context_line":""},{"line_number":1430,"context_line":"        out, err \u003d self.execute(\u0027ps\u0027, \u0027aux\u0027)"},{"line_number":1431,"context_line":"        if not \u0027@%s\u0027 % snapshot_tag in out:"},{"line_number":1432,"context_line":"            dst_dataset_name \u003d self.private_storage.get("},{"line_number":1433,"context_line":"                destination_share[\u0027id\u0027], \u0027dataset_name\u0027)"},{"line_number":1434,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa7ab95a_77da5219","line":1431,"range":{"start_line":1431,"start_character":11,"end_line":1431,"end_character":43},"updated":"2016-08-31 03:14:12.000000000","message":"could be \u0027@%s\u0027 % snapshot_tag not in out","commit_id":"c6fd6cc56bfffb8b4a305e9fb77403195bc3c632"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"40f7b91916f6232e01eec23033b59e687588dd19","unresolved":false,"context_lines":[{"line_number":1428,"context_line":"            destination_share[\u0027id\u0027], \u0027migr_snapshot_tag\u0027)"},{"line_number":1429,"context_line":""},{"line_number":1430,"context_line":"        out, err \u003d self.execute(\u0027ps\u0027, \u0027aux\u0027)"},{"line_number":1431,"context_line":"        if not \u0027@%s\u0027 % snapshot_tag in out:"},{"line_number":1432,"context_line":"            dst_dataset_name \u003d self.private_storage.get("},{"line_number":1433,"context_line":"                destination_share[\u0027id\u0027], \u0027dataset_name\u0027)"},{"line_number":1434,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa7ab95a_9c3d24be","line":1431,"range":{"start_line":1431,"start_character":11,"end_line":1431,"end_character":43},"in_reply_to":"fa7ab95a_77da5219","updated":"2016-08-31 11:15:46.000000000","message":"Could be, but why do you mention it? Any reason to change?","commit_id":"c6fd6cc56bfffb8b4a305e9fb77403195bc3c632"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fecfdf74f785d08f49915e69ff389649c6932d30","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from manila.share import configuration"},{"line_number":34,"context_line":"from manila.share import driver"},{"line_number":35,"context_line":"from manila.share.drivers.zfsonlinux import utils as zfs_utils"},{"line_number":36,"context_line":"from manila.share.manager import share_manager_opts  # noqa"},{"line_number":37,"context_line":"from manila.share import share_types"},{"line_number":38,"context_line":"from manila.share import utils as share_utils"},{"line_number":39,"context_line":"from manila import utils"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa7ab95a_eb6716b5","line":36,"range":{"start_line":36,"start_character":53,"end_line":36,"end_character":59},"updated":"2016-09-01 00:26:03.000000000","message":"why?","commit_id":"126d7e64015223ce7a7d7cecb31f83cd2e68d7c5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fecfdf74f785d08f49915e69ff389649c6932d30","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    cfg.StrOpt("},{"line_number":115,"context_line":"        \"zfs_migration_snapshot_prefix\","},{"line_number":116,"context_line":"        required\u003dTrue,"},{"line_number":117,"context_line":"        default\u003d\"tmp_snapshot_for_share_migration_\","},{"line_number":118,"context_line":"        help\u003d\"Set snapshot prefix for usage in ZFS migration. Required.\"),"},{"line_number":119,"context_line":"]"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"fa7ab95a_4b0f22e1","line":117,"range":{"start_line":117,"start_character":49,"end_line":117,"end_character":50},"updated":"2016-09-01 00:26:03.000000000","message":"This underscore must be is already added in the code..","commit_id":"126d7e64015223ce7a7d7cecb31f83cd2e68d7c5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fecfdf74f785d08f49915e69ff389649c6932d30","unresolved":false,"context_lines":[{"line_number":1441,"context_line":"                return True"},{"line_number":1442,"context_line":"            except exception.ProcessExecutionError as e:"},{"line_number":1443,"context_line":"                raise exception.ZFSonLinuxException(msg\u003d_("},{"line_number":1444,"context_line":"                    \u0027Migration process is absent and dst dataset \u0027"},{"line_number":1445,"context_line":"                    \u0027returned following error: %s\u0027) % e)"},{"line_number":1446,"context_line":""},{"line_number":1447,"context_line":"    @ensure_share_server_not_provided"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa7ab95a_4bdd6241","line":1444,"range":{"start_line":1444,"start_character":53,"end_line":1444,"end_character":56},"updated":"2016-09-01 00:26:03.000000000","message":"destination","commit_id":"126d7e64015223ce7a7d7cecb31f83cd2e68d7c5"}]}
