)]}'
{"manila/share/drivers/windows/windows_smb_helper.py":[{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"6e6ae6a9d2216e3fe16c141c63c7561a913dac97","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        cmd \u003d (\u0027Get-SmbShareAccess -Name %(share_name)s | \u0027"},{"line_number":96,"context_line":"               \u0027Select-Object @(\"Name\", \"AccountName\", \u0027"},{"line_number":97,"context_line":"               \u0027\"AccessControlType\", \"AccessRight\") | \u0027"},{"line_number":98,"context_line":"               \u0027ConvertTo-JSON -Compress\u0027 % dict(share_name\u003dshare_name))"},{"line_number":99,"context_line":"        (out, err) \u003d self._remote_exec(server, cmd)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if not out.strip():"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_bd03de0e","line":98,"range":{"start_line":98,"start_character":44,"end_line":98,"end_character":48},"updated":"2016-08-15 09:15:03.000000000","message":"{}","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aab2d067234409c6b924550682ff48e8130c1744","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                    dict(access_to\u003daccess_to,"},{"line_number":140,"context_line":"                         share_name\u003dshare_name))"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"            acl \u003d dict(access_to\u003daccess_to,"},{"line_number":143,"context_line":"                       access_level\u003daccess_level,"},{"line_number":144,"context_line":"                       access_type\u003d\u0027user\u0027)"},{"line_number":145,"context_line":"            acls.append(acl)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_93bee6d2","line":142,"range":{"start_line":142,"start_character":18,"end_line":142,"end_character":22},"updated":"2016-08-14 06:02:09.000000000","message":"{}","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aab2d067234409c6b924550682ff48e8130c1744","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        return acls"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _grant_share_access(self, server, share_name, access_level, access_to):"},{"line_number":149,"context_line":"        LOG.info(_LI(\"Granting %(access_level)s acess to \u0027%(acess_to)s\u0027 \""},{"line_number":150,"context_line":"                     \"on share %(share_name)s\"),"},{"line_number":151,"context_line":"                 dict(access_level\u003daccess_level,"},{"line_number":152,"context_line":"                      acess_to\u003daccess_to,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_f3b3da08","line":149,"range":{"start_line":149,"start_character":48,"end_line":149,"end_character":53},"updated":"2016-08-14 06:02:09.000000000","message":"access","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aab2d067234409c6b924550682ff48e8130c1744","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        return acls"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _grant_share_access(self, server, share_name, access_level, access_to):"},{"line_number":149,"context_line":"        LOG.info(_LI(\"Granting %(access_level)s acess to \u0027%(acess_to)s\u0027 \""},{"line_number":150,"context_line":"                     \"on share %(share_name)s\"),"},{"line_number":151,"context_line":"                 dict(access_level\u003daccess_level,"},{"line_number":152,"context_line":"                      acess_to\u003daccess_to,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_d3b85ee8","line":149,"range":{"start_line":149,"start_character":60,"end_line":149,"end_character":68},"updated":"2016-08-14 06:02:09.000000000","message":"access_to","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aab2d067234409c6b924550682ff48e8130c1744","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        return acls"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _grant_share_access(self, server, share_name, access_level, access_to):"},{"line_number":149,"context_line":"        LOG.info(_LI(\"Granting %(access_level)s acess to \u0027%(acess_to)s\u0027 \""},{"line_number":150,"context_line":"                     \"on share %(share_name)s\"),"},{"line_number":151,"context_line":"                 dict(access_level\u003daccess_level,"},{"line_number":152,"context_line":"                      acess_to\u003daccess_to,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_53c58e59","line":149,"range":{"start_line":149,"start_character":12,"end_line":149,"end_character":16},"updated":"2016-08-14 06:02:09.000000000","message":"info level messages should be to inform completion of an action.. you should use debug here, or log this after the action has been completed.","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"22af507b8249a46b974282100b3a810392a9b148","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        return acls"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _grant_share_access(self, server, share_name, access_level, access_to):"},{"line_number":149,"context_line":"        LOG.info(_LI(\"Granting %(access_level)s acess to \u0027%(acess_to)s\u0027 \""},{"line_number":150,"context_line":"                     \"on share %(share_name)s\"),"},{"line_number":151,"context_line":"                 dict(access_level\u003daccess_level,"},{"line_number":152,"context_line":"                      acess_to\u003daccess_to,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_68cb2654","line":149,"range":{"start_line":149,"start_character":12,"end_line":149,"end_character":16},"in_reply_to":"3ac371cc_53c58e59","updated":"2016-08-16 11:00:55.000000000","message":"Makes sense.","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aab2d067234409c6b924550682ff48e8130c1744","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    def _grant_share_access(self, server, share_name, access_level, access_to):"},{"line_number":149,"context_line":"        LOG.info(_LI(\"Granting %(access_level)s acess to \u0027%(acess_to)s\u0027 \""},{"line_number":150,"context_line":"                     \"on share %(share_name)s\"),"},{"line_number":151,"context_line":"                 dict(access_level\u003daccess_level,"},{"line_number":152,"context_line":"                      acess_to\u003daccess_to,"},{"line_number":153,"context_line":"                      share_name\u003dshare_name))"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_33ce1284","line":151,"range":{"start_line":151,"start_character":17,"end_line":151,"end_character":21},"updated":"2016-08-14 06:02:09.000000000","message":"{}","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aab2d067234409c6b924550682ff48e8130c1744","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        self._remote_exec(server, cmd)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def _revoke_share_access(self, server, share_name, access_to):"},{"line_number":167,"context_line":"        LOG.info(_LI(\"Revoking acess to \u0027%(acess_to)s\u0027 \""},{"line_number":168,"context_line":"                     \"on share %(share_name)s\"),"},{"line_number":169,"context_line":"                 dict(acess_to\u003daccess_to,"},{"line_number":170,"context_line":"                      share_name\u003dshare_name))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_739fea5f","line":167,"range":{"start_line":167,"start_character":43,"end_line":167,"end_character":51},"updated":"2016-08-14 06:02:09.000000000","message":"access_to","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aab2d067234409c6b924550682ff48e8130c1744","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        self._remote_exec(server, cmd)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def _revoke_share_access(self, server, share_name, access_to):"},{"line_number":167,"context_line":"        LOG.info(_LI(\"Revoking acess to \u0027%(acess_to)s\u0027 \""},{"line_number":168,"context_line":"                     \"on share %(share_name)s\"),"},{"line_number":169,"context_line":"                 dict(acess_to\u003daccess_to,"},{"line_number":170,"context_line":"                      share_name\u003dshare_name))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_539c6e69","line":167,"range":{"start_line":167,"start_character":7,"end_line":167,"end_character":56},"updated":"2016-08-14 06:02:09.000000000","message":"same comment about info logging..","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aab2d067234409c6b924550682ff48e8130c1744","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    def _revoke_share_access(self, server, share_name, access_to):"},{"line_number":167,"context_line":"        LOG.info(_LI(\"Revoking acess to \u0027%(acess_to)s\u0027 \""},{"line_number":168,"context_line":"                     \"on share %(share_name)s\"),"},{"line_number":169,"context_line":"                 dict(acess_to\u003daccess_to,"},{"line_number":170,"context_line":"                      share_name\u003dshare_name))"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        cmd \u003d [\u0027Revoke-SmbShareAccess\u0027, \u0027-Name\u0027, share_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_b387a211","line":169,"range":{"start_line":169,"start_character":17,"end_line":169,"end_character":21},"updated":"2016-08-14 06:02:09.000000000","message":"{}","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aab2d067234409c6b924550682ff48e8130c1744","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    def update_access(self, server, share_name, access_rules, add_rules,"},{"line_number":178,"context_line":"                      delete_rules):"},{"line_number":179,"context_line":"        all_rules \u003d access_rules + add_rules + delete_rules"},{"line_number":180,"context_line":"        self.validate_access_rules("},{"line_number":181,"context_line":"            all_rules, (\u0027user\u0027,),"},{"line_number":182,"context_line":"            (constants.ACCESS_LEVEL_RO, constants.ACCESS_LEVEL_RW))"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":185,"context_line":"            existing_rules \u003d self.get_access_rules(server, share_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_b38e8225","line":182,"range":{"start_line":180,"start_character":0,"end_line":182,"end_character":67},"updated":"2016-08-14 06:02:09.000000000","message":"The problem with this is what happens when a \"bad\" rule is added by a user.. \n\n i. User uses \u0027manila access-allow\u0027 and the driver raises \"InvalidShareAccess\", \nThe access rule status is set to \u0027error\u0027\nii. User wants to delete the bad access rule, uses \"manila access-deny\",\n but the driver raises InvalidShareAccess again.. so the rule status is set to\n \u0027error_deleting\u0027... so, instead, could you avoid this check in the\n delete_rules path and try/except or check for the validity of\n the delete rule and ignore if you get a rule that doesn\u0027t \nmake sense in the first place?","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"22af507b8249a46b974282100b3a810392a9b148","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    def update_access(self, server, share_name, access_rules, add_rules,"},{"line_number":178,"context_line":"                      delete_rules):"},{"line_number":179,"context_line":"        all_rules \u003d access_rules + add_rules + delete_rules"},{"line_number":180,"context_line":"        self.validate_access_rules("},{"line_number":181,"context_line":"            all_rules, (\u0027user\u0027,),"},{"line_number":182,"context_line":"            (constants.ACCESS_LEVEL_RO, constants.ACCESS_LEVEL_RW))"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":185,"context_line":"            existing_rules \u003d self.get_access_rules(server, share_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_a84fdebb","line":182,"range":{"start_line":180,"start_character":0,"end_line":182,"end_character":67},"in_reply_to":"3ac371cc_b38e8225","updated":"2016-08-16 11:00:55.000000000","message":"Good point, I just saw that the same approach is used by the NFS helper.\n\nI\u0027ll fix this in the following patch set.","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aab2d067234409c6b924550682ff48e8130c1744","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            add_rules, delete_rules \u003d self._get_rule_updates("},{"line_number":187,"context_line":"                existing_rules\u003dexisting_rules,"},{"line_number":188,"context_line":"                requested_rules\u003daccess_rules)"},{"line_number":189,"context_line":"            LOG.info(_LI(\"Missing rules: %(add_rules)s, \""},{"line_number":190,"context_line":"                         \"superfluous rules: %(delete_rules)s\"),"},{"line_number":191,"context_line":"                     dict(add_rules\u003dadd_rules,"},{"line_number":192,"context_line":"                          delete_rules\u003ddelete_rules))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_d39dfe5a","line":189,"range":{"start_line":189,"start_character":16,"end_line":189,"end_character":20},"updated":"2016-08-14 06:02:09.000000000","message":"debug","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aab2d067234409c6b924550682ff48e8130c1744","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                requested_rules\u003daccess_rules)"},{"line_number":189,"context_line":"            LOG.info(_LI(\"Missing rules: %(add_rules)s, \""},{"line_number":190,"context_line":"                         \"superfluous rules: %(delete_rules)s\"),"},{"line_number":191,"context_line":"                     dict(add_rules\u003dadd_rules,"},{"line_number":192,"context_line":"                          delete_rules\u003ddelete_rules))"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # Some rules may have changed, so we\u0027ll"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_13a03690","line":191,"range":{"start_line":191,"start_character":21,"end_line":191,"end_character":25},"updated":"2016-08-14 06:02:09.000000000","message":"{}","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aab2d067234409c6b924550682ff48e8130c1744","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    def _subtract_access_rules(self, access_rules, subtracted_rules):"},{"line_number":206,"context_line":"        # Account names are case insensitive on Windows."},{"line_number":207,"context_line":"        filter_rules \u003d lambda rules: ["},{"line_number":208,"context_line":"            dict(access_to\u003daccess_rule[\u0027access_to\u0027].lower(),"},{"line_number":209,"context_line":"                 access_level\u003daccess_rule[\u0027access_level\u0027],"},{"line_number":210,"context_line":"                 access_type\u003daccess_rule[\u0027access_type\u0027])"},{"line_number":211,"context_line":"            for access_rule in rules]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_93ba66bf","line":208,"range":{"start_line":208,"start_character":12,"end_line":208,"end_character":16},"updated":"2016-08-14 06:02:09.000000000","message":"{}","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c39d891d04cf960488352372d70f20e4bcdac27a","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                    {\u0027access_to\u0027: access_to,"},{"line_number":145,"context_line":"                     \u0027share_name\u0027: share_name})"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"            acl \u003d {\u0027access_to\u0027: access_to,"},{"line_number":148,"context_line":"                   \u0027access_level\u0027: access_level,"},{"line_number":149,"context_line":"                   \u0027access_type\u0027: \u0027user\u0027}"},{"line_number":150,"context_line":"            acls.append(acl)"},{"line_number":151,"context_line":"        return acls"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_08752331","line":149,"range":{"start_line":147,"start_character":0,"end_line":149,"end_character":41},"updated":"2016-08-22 20:21:41.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"ca47b762ac1064b6e152358aeae1d8d25c5a4b99"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"c5f0b78b4fea5bfc8e833dd3cf519f6648a00fd1","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    _WIN_ACL_MAP \u003d {"},{"line_number":48,"context_line":"        _WIN_ACCESS_RIGHT_CHANGE: constants.ACCESS_LEVEL_RW,"},{"line_number":49,"context_line":"        _WIN_ACCESS_RIGHT_FULL: constants.ACCESS_LEVEL_RW,"},{"line_number":50,"context_line":"        _WIN_ACCESS_RIGHT_READ: constants.ACCESS_LEVEL_RO,"},{"line_number":51,"context_line":"        _WIN_ACCESS_RIGHT_CUSTOM: _ACCESS_LEVEL_CUSTOM,"},{"line_number":52,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_46d4dbea","line":49,"range":{"start_line":49,"start_character":55,"end_line":49,"end_character":57},"updated":"2016-08-30 16:41:32.000000000","message":"Did you mean to map full to full?  s/RW/FULL/","commit_id":"9b7f95b2d42c96b77a730e02180ebac4979bd35d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"932a6cabdbea303bcc5fe1b7116199a81b935724","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    _WIN_ACL_MAP \u003d {"},{"line_number":48,"context_line":"        _WIN_ACCESS_RIGHT_CHANGE: constants.ACCESS_LEVEL_RW,"},{"line_number":49,"context_line":"        _WIN_ACCESS_RIGHT_FULL: constants.ACCESS_LEVEL_RW,"},{"line_number":50,"context_line":"        _WIN_ACCESS_RIGHT_READ: constants.ACCESS_LEVEL_RO,"},{"line_number":51,"context_line":"        _WIN_ACCESS_RIGHT_CUSTOM: _ACCESS_LEVEL_CUSTOM,"},{"line_number":52,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_616b89b7","line":49,"range":{"start_line":49,"start_character":55,"end_line":49,"end_character":57},"in_reply_to":"fa7ab95a_46d4dbea","updated":"2016-08-30 16:45:34.000000000","message":"I read further and I think this is intentional.","commit_id":"9b7f95b2d42c96b77a730e02180ebac4979bd35d"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"1a1a5dc6d1383b5f441465147d5125813e565d40","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    _WIN_ACL_MAP \u003d {"},{"line_number":48,"context_line":"        _WIN_ACCESS_RIGHT_CHANGE: constants.ACCESS_LEVEL_RW,"},{"line_number":49,"context_line":"        _WIN_ACCESS_RIGHT_FULL: constants.ACCESS_LEVEL_RW,"},{"line_number":50,"context_line":"        _WIN_ACCESS_RIGHT_READ: constants.ACCESS_LEVEL_RO,"},{"line_number":51,"context_line":"        _WIN_ACCESS_RIGHT_CUSTOM: _ACCESS_LEVEL_CUSTOM,"},{"line_number":52,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_81db2d7b","line":49,"range":{"start_line":49,"start_character":55,"end_line":49,"end_character":57},"in_reply_to":"fa7ab95a_616b89b7","updated":"2016-08-30 16:49:14.000000000","message":"Indeed, the idea was to map possible Windows share ACEs to manila access rules and as far as I\u0027ve seen, \u0027ro\u0027 and \u0027rw\u0027 where the only possible rules set by manila.","commit_id":"9b7f95b2d42c96b77a730e02180ebac4979bd35d"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"fdb2afdff8a2b5f65d8af7147bf84f124506344d","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    _WIN_ACL_MAP \u003d {"},{"line_number":48,"context_line":"        _WIN_ACCESS_RIGHT_CHANGE: constants.ACCESS_LEVEL_RW,"},{"line_number":49,"context_line":"        _WIN_ACCESS_RIGHT_FULL: constants.ACCESS_LEVEL_RW,"},{"line_number":50,"context_line":"        _WIN_ACCESS_RIGHT_READ: constants.ACCESS_LEVEL_RO,"},{"line_number":51,"context_line":"        _WIN_ACCESS_RIGHT_CUSTOM: _ACCESS_LEVEL_CUSTOM,"},{"line_number":52,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_c1a7f5a4","line":49,"range":{"start_line":49,"start_character":55,"end_line":49,"end_character":57},"in_reply_to":"fa7ab95a_81db2d7b","updated":"2016-08-30 16:51:12.000000000","message":"*were","commit_id":"9b7f95b2d42c96b77a730e02180ebac4979bd35d"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9c7cc8cdeb1eef1cd3d61374050c7d6788703806","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"            if not access_allow:"},{"line_number":125,"context_line":"                if access_to.lower() \u003d\u003d \u0027everyone\u0027 and len(raw_acls) \u003d\u003d 1:"},{"line_number":126,"context_line":"                    LOG.debug(\"No access rules are set yet for share %s\","},{"line_number":127,"context_line":"                              share_name)"},{"line_number":128,"context_line":"                else:"},{"line_number":129,"context_line":"                    LOG.warning("},{"line_number":130,"context_line":"                        _LW(\"Found explicit deny ACE rule that was not \""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_97ac4f8d","line":127,"range":{"start_line":126,"start_character":0,"end_line":127,"end_character":41},"updated":"2016-08-30 17:21:03.000000000","message":"This block wasn\u0027t covered by a unit test, although it doesn\u0027t seem critical.  Something to fix later.","commit_id":"68cd04751c4dcfbd173c8663a32ba50dc20419a5"}],"manila/tests/share/drivers/windows/test_windows_smb_helper.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aab2d067234409c6b924550682ff48e8130c1744","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                       \u0027_get_acls\u0027)"},{"line_number":133,"context_line":"    def test_get_access_rules(self, mock_get_acls):"},{"line_number":134,"context_line":"        helper \u003d self._win_smb_helper"},{"line_number":135,"context_line":"        valid_acl \u003d dict(AccountName\u003dself._FAKE_ACCOUNT_NAME,"},{"line_number":136,"context_line":"                         AccessRight\u003dhelper._WIN_ACCESS_RIGHT_FULL,"},{"line_number":137,"context_line":"                         AccessControlType\u003dhelper._WIN_ACL_ALLOW)"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_93e1c6d3","line":135,"range":{"start_line":135,"start_character":20,"end_line":135,"end_character":24},"updated":"2016-08-14 06:02:09.000000000","message":"{}","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"6e6ae6a9d2216e3fe16c141c63c7561a913dac97","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                       \u0027_get_acls\u0027)"},{"line_number":133,"context_line":"    def test_get_access_rules(self, mock_get_acls):"},{"line_number":134,"context_line":"        helper \u003d self._win_smb_helper"},{"line_number":135,"context_line":"        valid_acl \u003d dict(AccountName\u003dself._FAKE_ACCOUNT_NAME,"},{"line_number":136,"context_line":"                         AccessRight\u003dhelper._WIN_ACCESS_RIGHT_FULL,"},{"line_number":137,"context_line":"                         AccessControlType\u003dhelper._WIN_ACL_ALLOW)"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_a0af35e2","line":135,"range":{"start_line":135,"start_character":20,"end_line":135,"end_character":24},"in_reply_to":"3ac371cc_93e1c6d3","updated":"2016-08-15 09:15:03.000000000","message":"There are many more dict() calls in this file that could be replaced by {}.","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"22af507b8249a46b974282100b3a810392a9b148","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                       \u0027_get_acls\u0027)"},{"line_number":133,"context_line":"    def test_get_access_rules(self, mock_get_acls):"},{"line_number":134,"context_line":"        helper \u003d self._win_smb_helper"},{"line_number":135,"context_line":"        valid_acl \u003d dict(AccountName\u003dself._FAKE_ACCOUNT_NAME,"},{"line_number":136,"context_line":"                         AccessRight\u003dhelper._WIN_ACCESS_RIGHT_FULL,"},{"line_number":137,"context_line":"                         AccessControlType\u003dhelper._WIN_ACL_ALLOW)"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_48910a52","line":135,"range":{"start_line":135,"start_character":20,"end_line":135,"end_character":24},"in_reply_to":"3ac371cc_a0af35e2","updated":"2016-08-16 11:00:55.000000000","message":"IMO this is just a matter of coding style. It\u0027s easier to type, not having to define strings for the keys while being just as easy to read.\n\nAnyway, I\u0027ll change this, using the \u0027{}\u0027 syntax whenever possible.","commit_id":"8d2d5c78f6b283cc39c5deb85adbb2c7111ea620"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c39d891d04cf960488352372d70f20e4bcdac27a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        configuration.Configuration(None).share_mount_path,"},{"line_number":43,"context_line":"        _FAKE_SHARE_NAME)"},{"line_number":44,"context_line":"    _FAKE_ACCOUNT_NAME \u003d \u0027FakeDomain\\\\FakeUser\u0027"},{"line_number":45,"context_line":"    _FAKE_RW_ACC_RULE \u003d {\u0027access_to\u0027: _FAKE_ACCOUNT_NAME,"},{"line_number":46,"context_line":"                         \u0027access_level\u0027: constants.ACCESS_LEVEL_RW,"},{"line_number":47,"context_line":"                         \u0027access_type\u0027: \u0027user\u0027}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def setUp(self):"},{"line_number":50,"context_line":"        self._remote_exec \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_28961f3f","line":47,"range":{"start_line":45,"start_character":24,"end_line":47,"end_character":47},"updated":"2016-08-22 20:21:41.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"ca47b762ac1064b6e152358aeae1d8d25c5a4b99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c39d891d04cf960488352372d70f20e4bcdac27a","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                       \u0027_get_acls\u0027)"},{"line_number":133,"context_line":"    def test_get_access_rules(self, mock_get_acls):"},{"line_number":134,"context_line":"        helper \u003d self._win_smb_helper"},{"line_number":135,"context_line":"        valid_acl \u003d {\u0027AccountName\u0027: self._FAKE_ACCOUNT_NAME,"},{"line_number":136,"context_line":"                     \u0027AccessRight\u0027: helper._WIN_ACCESS_RIGHT_FULL,"},{"line_number":137,"context_line":"                     \u0027AccessControlType\u0027: helper._WIN_ACL_ALLOW}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        valid_acls \u003d [valid_acl,"},{"line_number":140,"context_line":"                      dict(valid_acl,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_689c975d","line":137,"range":{"start_line":135,"start_character":20,"end_line":137,"end_character":64},"updated":"2016-08-22 20:21:41.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"ca47b762ac1064b6e152358aeae1d8d25c5a4b99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2bdea124f833637220b13a7a62ef4a9f6817ac3c","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                       \u0027_get_acls\u0027)"},{"line_number":133,"context_line":"    def test_get_access_rules(self, mock_get_acls):"},{"line_number":134,"context_line":"        helper \u003d self._win_smb_helper"},{"line_number":135,"context_line":"        valid_acl \u003d {\u0027AccountName\u0027: self._FAKE_ACCOUNT_NAME,"},{"line_number":136,"context_line":"                     \u0027AccessRight\u0027: helper._WIN_ACCESS_RIGHT_FULL,"},{"line_number":137,"context_line":"                     \u0027AccessControlType\u0027: helper._WIN_ACL_ALLOW}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        valid_acls \u003d [valid_acl,"},{"line_number":140,"context_line":"                      dict(valid_acl,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_e8f7e756","line":137,"range":{"start_line":135,"start_character":20,"end_line":137,"end_character":64},"in_reply_to":"1ac06dbe_688657dc","updated":"2016-08-22 20:26:43.000000000","message":"with a trailing comma:\n\n\n  valid_acl \u003d {\n    \u0027AccountName\u0027: self._FAKE_ACCOUNT_NAME,\n    \u0027AccessRight\u0027: helper._WIN_ACCESS_RIGHT_FULL,\n    \u0027AccessControlType\u0027: helper._WIN_ACL_ALLOW,\n }","commit_id":"ca47b762ac1064b6e152358aeae1d8d25c5a4b99"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"daf4ec8435b01e4e193a0da337f1a3701d29ffb9","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                       \u0027_get_acls\u0027)"},{"line_number":133,"context_line":"    def test_get_access_rules(self, mock_get_acls):"},{"line_number":134,"context_line":"        helper \u003d self._win_smb_helper"},{"line_number":135,"context_line":"        valid_acl \u003d {\u0027AccountName\u0027: self._FAKE_ACCOUNT_NAME,"},{"line_number":136,"context_line":"                     \u0027AccessRight\u0027: helper._WIN_ACCESS_RIGHT_FULL,"},{"line_number":137,"context_line":"                     \u0027AccessControlType\u0027: helper._WIN_ACL_ALLOW}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        valid_acls \u003d [valid_acl,"},{"line_number":140,"context_line":"                      dict(valid_acl,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_688657dc","line":137,"range":{"start_line":135,"start_character":20,"end_line":137,"end_character":64},"in_reply_to":"1ac06dbe_689c975d","updated":"2016-08-22 20:24:48.000000000","message":"You mean this should be written as following, right?\n\nvalid_acl \u003d {\n    \u0027AccountName\u0027: self._FAKE_ACCOUNT_NAME,\n    \u0027AccessRight\u0027: helper._WIN_ACCESS_RIGHT_FULL,\n    \u0027AccessControlType\u0027: helper._WIN_ACL_ALLOW\n}","commit_id":"ca47b762ac1064b6e152358aeae1d8d25c5a4b99"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"ad571f6cbf1d208a6da578272bae192392232eb5","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                       \u0027_get_acls\u0027)"},{"line_number":133,"context_line":"    def test_get_access_rules(self, mock_get_acls):"},{"line_number":134,"context_line":"        helper \u003d self._win_smb_helper"},{"line_number":135,"context_line":"        valid_acl \u003d {\u0027AccountName\u0027: self._FAKE_ACCOUNT_NAME,"},{"line_number":136,"context_line":"                     \u0027AccessRight\u0027: helper._WIN_ACCESS_RIGHT_FULL,"},{"line_number":137,"context_line":"                     \u0027AccessControlType\u0027: helper._WIN_ACL_ALLOW}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        valid_acls \u003d [valid_acl,"},{"line_number":140,"context_line":"                      dict(valid_acl,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_e87c07b7","line":137,"range":{"start_line":135,"start_character":20,"end_line":137,"end_character":64},"in_reply_to":"1ac06dbe_e8f7e756","updated":"2016-08-22 20:28:03.000000000","message":"Got it, updating it right now.","commit_id":"ca47b762ac1064b6e152358aeae1d8d25c5a4b99"}]}
