)]}'
{"contrib/ci/post_test_hook.sh":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"be34567aeb3a4f7cb423ddee70c90d1b5b157a0d","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        iniset $TEMPEST_CONFIG share enable_protocols nfs"},{"line_number":158,"context_line":"    fi"},{"line_number":159,"context_line":"    MANILA_TESTS\u003d\"(^manila_tempest_tests.tests.api)(?\u003d.*\\[.*\\bbackend\\b.*\\])\""},{"line_number":160,"context_line":"    RUN_MANILA_SG_TESTS\u003dFalse"},{"line_number":161,"context_line":"fi"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"if [[ \"$DRIVER\" \u003d\u003d \"lvm\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":26,"id":"5a3905b3_3b29cc8a","line":160,"range":{"start_line":160,"start_character":24,"end_line":160,"end_character":29},"updated":"2017-01-24 06:28:09.000000000","message":"why not true?","commit_id":"1002642674ff4a72949b27eb0892ec4c8590a825"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fd86283395d7ce974efc22cd44ffdd8818146b7e","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        iniset $TEMPEST_CONFIG share enable_protocols nfs"},{"line_number":158,"context_line":"    fi"},{"line_number":159,"context_line":"    MANILA_TESTS\u003d\"(^manila_tempest_tests.tests.api)(?\u003d.*\\[.*\\bbackend\\b.*\\])\""},{"line_number":160,"context_line":"    RUN_MANILA_SG_TESTS\u003dFalse"},{"line_number":161,"context_line":"fi"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"if [[ \"$DRIVER\" \u003d\u003d \"lvm\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":26,"id":"5a3905b3_39b5537d","line":160,"range":{"start_line":160,"start_character":24,"end_line":160,"end_character":29},"in_reply_to":"5a3905b3_3b29cc8a","updated":"2017-01-24 08:27:12.000000000","message":"Because \"share groups\" feature has default functionality on driver side and can be redefined. \"default\" one is tested in \"dummy\" driver, the fastest and the most reliable one.\n\nIt has no sense to run it in generic driver. It does not implement its own approach and very-very expensive to run.","commit_id":"1002642674ff4a72949b27eb0892ec4c8590a825"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"be34567aeb3a4f7cb423ddee70c90d1b5b157a0d","unresolved":false,"context_lines":[{"line_number":186,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"zfsonlinux\" ]]; then"},{"line_number":187,"context_line":"    MANILA_TESTS\u003d\"(^manila_tempest_tests.tests)(?\u003d.*\\[.*\\bbackend\\b.*\\])\""},{"line_number":188,"context_line":"    MANILA_TEMPEST_CONCURRENCY\u003d8"},{"line_number":189,"context_line":"    RUN_MANILA_SG_TESTS\u003dFalse"},{"line_number":190,"context_line":"    RUN_MANILA_MANAGE_TESTS\u003dTrue"},{"line_number":191,"context_line":"    RUN_MANILA_MANAGE_SNAPSHOT_TESTS\u003dTrue"},{"line_number":192,"context_line":"    RUN_MANILA_DRIVER_ASSISTED_MIGRATION_TESTS\u003dTrue"}],"source_content_type":"text/x-sh","patch_set":26,"id":"5a3905b3_7b1fd45a","line":189,"range":{"start_line":189,"start_character":24,"end_line":189,"end_character":29},"updated":"2017-01-24 06:28:09.000000000","message":"same","commit_id":"1002642674ff4a72949b27eb0892ec4c8590a825"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fd86283395d7ce974efc22cd44ffdd8818146b7e","unresolved":false,"context_lines":[{"line_number":186,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"zfsonlinux\" ]]; then"},{"line_number":187,"context_line":"    MANILA_TESTS\u003d\"(^manila_tempest_tests.tests)(?\u003d.*\\[.*\\bbackend\\b.*\\])\""},{"line_number":188,"context_line":"    MANILA_TEMPEST_CONCURRENCY\u003d8"},{"line_number":189,"context_line":"    RUN_MANILA_SG_TESTS\u003dFalse"},{"line_number":190,"context_line":"    RUN_MANILA_MANAGE_TESTS\u003dTrue"},{"line_number":191,"context_line":"    RUN_MANILA_MANAGE_SNAPSHOT_TESTS\u003dTrue"},{"line_number":192,"context_line":"    RUN_MANILA_DRIVER_ASSISTED_MIGRATION_TESTS\u003dTrue"}],"source_content_type":"text/x-sh","patch_set":26,"id":"5a3905b3_79b35b98","line":189,"range":{"start_line":189,"start_character":24,"end_line":189,"end_character":29},"in_reply_to":"5a3905b3_7b1fd45a","updated":"2017-01-24 08:27:12.000000000","message":"Default functionality is tested in dummy driver. Redundant to run it elsewhere.","commit_id":"1002642674ff4a72949b27eb0892ec4c8590a825"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"be34567aeb3a4f7cb423ddee70c90d1b5b157a0d","unresolved":false,"context_lines":[{"line_number":227,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"container\" ]]; then"},{"line_number":228,"context_line":"    MANILA_TESTS\u003d\"(^manila_tempest_tests.tests.api)(?\u003d.*\\[.*\\bbackend\\b.*\\])\""},{"line_number":229,"context_line":"    MANILA_TEMPEST_CONCURRENCY\u003d8"},{"line_number":230,"context_line":"    RUN_MANILA_SG_TESTS\u003dFalse"},{"line_number":231,"context_line":"    RUN_MANILA_MANAGE_TESTS\u003dFalse"},{"line_number":232,"context_line":"    RUN_MANILA_QUOTA_TESTS\u003dFalse"},{"line_number":233,"context_line":"    RUN_MANILA_SHRINK_TESTS\u003dFalse"}],"source_content_type":"text/x-sh","patch_set":26,"id":"5a3905b3_1b2fb088","line":230,"range":{"start_line":230,"start_character":24,"end_line":230,"end_character":29},"updated":"2017-01-24 06:28:09.000000000","message":"same","commit_id":"1002642674ff4a72949b27eb0892ec4c8590a825"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fd86283395d7ce974efc22cd44ffdd8818146b7e","unresolved":false,"context_lines":[{"line_number":227,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"container\" ]]; then"},{"line_number":228,"context_line":"    MANILA_TESTS\u003d\"(^manila_tempest_tests.tests.api)(?\u003d.*\\[.*\\bbackend\\b.*\\])\""},{"line_number":229,"context_line":"    MANILA_TEMPEST_CONCURRENCY\u003d8"},{"line_number":230,"context_line":"    RUN_MANILA_SG_TESTS\u003dFalse"},{"line_number":231,"context_line":"    RUN_MANILA_MANAGE_TESTS\u003dFalse"},{"line_number":232,"context_line":"    RUN_MANILA_QUOTA_TESTS\u003dFalse"},{"line_number":233,"context_line":"    RUN_MANILA_SHRINK_TESTS\u003dFalse"}],"source_content_type":"text/x-sh","patch_set":26,"id":"5a3905b3_b9a94326","line":230,"range":{"start_line":230,"start_character":24,"end_line":230,"end_character":29},"in_reply_to":"5a3905b3_1b2fb088","updated":"2017-01-24 08:27:12.000000000","message":"Default functionality is tested in dummy driver. Redundant to run it elsewhere.","commit_id":"1002642674ff4a72949b27eb0892ec4c8590a825"}],"manila_tempest_tests/config.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c429dbd5b441b375675066de8fcb9c5f28dc3e04","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                     \"to snapshots or not. Enable this feature if used \""},{"line_number":172,"context_line":"                     \"driver supports it.\"),"},{"line_number":173,"context_line":"    cfg.BoolOpt(\"run_share_group_tests\","},{"line_number":174,"context_line":"                default\u003dTrue,"},{"line_number":175,"context_line":"                deprecated_name\u003d\"run_consistency_group_tests\","},{"line_number":176,"context_line":"                help\u003d\"Defines whether to run share group tests or not.\"),"},{"line_number":177,"context_line":"    cfg.BoolOpt(\"run_replication_tests\","}],"source_content_type":"text/x-python","patch_set":26,"id":"5a3905b3_85989f6b","line":174,"range":{"start_line":174,"start_character":16,"end_line":174,"end_character":28},"updated":"2017-01-24 05:25:26.000000000","message":"I would feel more comfortable if this is set to False by default now.  Once everything is merged, more drivers can test share groups and this can be changed to True later.","commit_id":"1002642674ff4a72949b27eb0892ec4c8590a825"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fd86283395d7ce974efc22cd44ffdd8818146b7e","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                     \"to snapshots or not. Enable this feature if used \""},{"line_number":172,"context_line":"                     \"driver supports it.\"),"},{"line_number":173,"context_line":"    cfg.BoolOpt(\"run_share_group_tests\","},{"line_number":174,"context_line":"                default\u003dTrue,"},{"line_number":175,"context_line":"                deprecated_name\u003d\"run_consistency_group_tests\","},{"line_number":176,"context_line":"                help\u003d\"Defines whether to run share group tests or not.\"),"},{"line_number":177,"context_line":"    cfg.BoolOpt(\"run_replication_tests\","}],"source_content_type":"text/x-python","patch_set":26,"id":"5a3905b3_790fdb36","line":174,"range":{"start_line":174,"start_character":16,"end_line":174,"end_character":28},"in_reply_to":"5a3905b3_00065d1f","updated":"2017-01-24 08:27:12.000000000","message":"It was True for CGs, proof:\nhttps://review.openstack.org/#/c/335093/57/manila_tempest_tests/config.py\n\nSo, behaviour will not be changed even in 3rd-party CIs, old env vars are considered.\n\nIt was disabled in commit with main feature only because tempest tests are in separate commit from feature.","commit_id":"1002642674ff4a72949b27eb0892ec4c8590a825"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"be34567aeb3a4f7cb423ddee70c90d1b5b157a0d","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                     \"to snapshots or not. Enable this feature if used \""},{"line_number":172,"context_line":"                     \"driver supports it.\"),"},{"line_number":173,"context_line":"    cfg.BoolOpt(\"run_share_group_tests\","},{"line_number":174,"context_line":"                default\u003dTrue,"},{"line_number":175,"context_line":"                deprecated_name\u003d\"run_consistency_group_tests\","},{"line_number":176,"context_line":"                help\u003d\"Defines whether to run share group tests or not.\"),"},{"line_number":177,"context_line":"    cfg.BoolOpt(\"run_replication_tests\","}],"source_content_type":"text/x-python","patch_set":26,"id":"5a3905b3_00065d1f","line":174,"range":{"start_line":174,"start_character":16,"end_line":174,"end_character":28},"in_reply_to":"5a3905b3_85989f6b","updated":"2017-01-24 06:28:09.000000000","message":"I\u0027d usually agree, but in this case why would it be optional?","commit_id":"1002642674ff4a72949b27eb0892ec4c8590a825"}],"manila_tempest_tests/tests/api/admin/test_share_group_types.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"cff51dfad7af210ef99dd6f22cf39f9d7de23f96","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        sg_type \u003d self.shares_v2_client.get_share_group_type("},{"line_number":185,"context_line":"            sg_type[\u0027id\u0027])"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        self.assertDictMatch(group_specs, sg_type[\u0027group_specs\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a3905b3_ee2636b9","line":187,"updated":"2017-01-20 03:54:41.000000000","message":"Can you also add some tests for group type access?","commit_id":"207c0f03bbcf01db4e1388149c2c7c3f8f8753a2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8e6e95b96ad50a190ffef9d082d82c6d27753d3b","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        sg_type \u003d self.shares_v2_client.get_share_group_type("},{"line_number":185,"context_line":"            sg_type[\u0027id\u0027])"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        self.assertDictMatch(group_specs, sg_type[\u0027group_specs\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a3905b3_f541950c","line":187,"in_reply_to":"5a3905b3_ee2636b9","updated":"2017-01-20 11:51:31.000000000","message":"Will add.","commit_id":"207c0f03bbcf01db4e1388149c2c7c3f8f8753a2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe227af1985a8c50db7a86571a9c020f5b17a403","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        sg_type \u003d self.shares_v2_client.get_share_group_type("},{"line_number":185,"context_line":"            sg_type[\u0027id\u0027])"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        self.assertDictMatch(group_specs, sg_type[\u0027group_specs\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a3905b3_a62601b8","line":187,"in_reply_to":"5a3905b3_f541950c","updated":"2017-01-20 12:55:57.000000000","message":"Added in PS19:\n\nhttps://review.openstack.org/#/c/355264/16..19/manila_tempest_tests/tests/api/admin/test_share_group_types.py","commit_id":"207c0f03bbcf01db4e1388149c2c7c3f8f8753a2"}]}
